Working as expected, moving it to product signoff

I tried it on my local setup and it seems to be working

Its working for me locally

This is working fine but this Selected subject seems to only work for items selected from wikidata search but not for manual outlines. @SBisson shall we do it as part of separate task, or move this one back to dev?

I am also leaning towards keeping it consistent as editors would put effort to set it from language settings and then not seeing it in some cases may not go well

the proposed fix seems fine to me

In T421329#11897425, @Pginer-WMF wrote:

Also: Move the footer closer to the page chrome, keeping ~16px(@spacing-100) between them.

@SGautam_WMF regarding your proposal to move the footer closer to the page chrome, you may want to check a related ticket to consider how those may play together T425623: Avoid footer to take most of the viewport in Article Guidance
Maybe these layout adjustments could go together in T425623 and leave the present task focused on the label change if that makes things easier (or clearer).

@Pginer-WMF i have documented proposed improvement, let me know if it aligns with your understanding.

Thanks @Pginer-WMF, I am planning to update the task with some more design details, and i will include your feedback too in there.

In T424830#11875758, @SBisson wrote:

@SGautam_WMF

Mixed results. A search can return some items with Hindi labels and some without. The message should only appear when at least one item actually falls back, and it should make clear that *some* names aren't available, not all of them.

It is not always obvious if the label is missing for a language. Some items use the lang code "mul" to indicate that a label can be used for any language unless explicitly redefined. Is this case, we don't know if it should be defined.

We could use the following rule: when asking for label in language x and receiving label in language mul: the label is not missing. When asking for language X and receiving Y: the label is missing.

Fallback chain. Rather than jumping straight to English, walk the MediaWiki standard language fallback chain (so e.g. a Hindi user might see Sanskrit before English, depending on the wiki's configuration).

When calling the wikidata API to get labels and description, we are enabling the language fallback feature. As far as I understand it is using the standard MediaWiki language fallback system internally.

Message string (placeholder): "Hindi names aren't available yet for some items; showing those in another language."

Using language name inside of a message is tricky. If you can think of an alternative that doesn't include "Hindi" that would be preferred.

@SBisson given you are currently working on T422841, What do you think of this proposal for this task?

The current footer "None of these? [Pick a type instead]" makes two silent assumptions:

@SBisson updated, changed copy from "Couldn't check this topic" to "Couldn't check this subject"

@SBisson I am proposing an update to the language here, allow me few mins to update it.

In T416512#11826498, @stjn wrote:

Yeah, I see no reason why it shouldn't be 9 (IIRC) like in ULS suggested languages list itself.

In T416512#11825494, @Prototyperspective wrote:

@SGautam_WMF Looks good, thanks. 1) It would be good if for a while after the feature is introduced there is a small hint on the settings wheel icon that informs users about this functionality, e.g. with 'You can now pin languages'. 2) I think some users may like to be able to pin more than 4 languages.