PR: https://github.com/wikisource/wscontest/pull/3

WIP for the rest of this ticket: https://github.com/wikimedia/svgtranslate/pull/70

I meant if they had multiple tabs open with the tool and were in the process of translating multiple files. Switching between multiple To languages should not preserve translations. We should discard existing translations when they decide to change the language (which is what we have the popup for).

Is this clearer?

While a contest is underway, no one other than a contest admin can see the scores and participants.

the user should land back on the same page after they complete the login.

I'll see if I can figure it out.

The webservice for ia-upload was already done (I guess by @Tpt?) and I've just moved the cronjob as well.

Oh yes, I hadn't thought about customizing the display. It's easy enough to do that by modifying the extension though; let's start with extension-built HTML and see how it goes (it's easier, as you say). :)

Would a parser function like this be what we're looking for?—

Patch merged. Ready for QA.

Yeah I always develop with ./node_modules/.bin/encore dev --watch running, which seems to work fine with regard to accurately locating JS errors in their actual source locations. It's also faster than building the whole production assets on every change. I've had a couple of issues at times with things like images (although I think that's been in conjunction with OOUI updates, because I can't replicate that now).

Thanks Joe; I think I'm understanding things now. The patch is updated.

Yep, it's the tool caching the image. It caches for 5 hours and then starts deleting cached files (i.e. they can last for longer than 5 hours). It's definitely something we need to improve!

This is now ready for QA.

As discussed in today's standup, I'll remove the arrow in the link.

This is ready for QA.

This is ready for QA.

Sorry, disregard me, I just saw the comment on the PR. I'm updating the patch to count correctly.

The PR that's waiting for review here is https://github.com/wikimedia/ToolforgeBundle/pull/12

The last bit of this task is https://github.com/wikimedia/svgtranslate/pull/67

I'm confused! Sorry. :)

Ah cool, that makes sense.

I think the problem here is not with the pages-improved-pageviews stat, but rather with the pages-improved stat. For the period 20170311212100 to 20170311212200 User:Srkrm has a single revision recorded (ID 769825324), and this revision has no parent (i.e. rev_parent_id = 0). So that means that the total pages created is 1, but the total pages improved should actually be 0 — and not 1 as is currently being reported. That's right isn't it? We don't want to treat a page-creation as an edit as well as a creation do we?

Can we keep them all? Or are there other problems that arise if we do that?

Prod updated.

Production site updated to 0.2.0.

Production site updated to 0.2.0.

Doing so will also deploy T214452; is that okay?

So the tests are now failing on a different problem, and I can't figure it out. It looks to me like the commands for the two containers aren't being run (in Travis) on docker-compose up --build -d. Things work okay locally.

One change could be to not group when there's only one item in each group, like in https://tools.wmflabs.org/svgtranslate-test/File:Cathedral.svg

It's not urgent for me, but I think it's also not far from being done. I've brought the patch up to date with the latest feedback from @davidwbarratt, but the tests are currently failing due to some npm inconsistency — probably not too hard to fix, I'll look at it now and see if we can merge soon.

I've updated deploy.sh to use composer etc. directly.

Yep. I'll have a dig into this later today, maybe add some more tests with the above parameters. Thanks @dom_walden for finding this.

Production hasn't been updated with this yet. I forgot to move this to QA when the patch was merged. Doing so now. Test with e.g. https://tools.wmflabs.org/svgtranslate-test/File:Speech_bubbles.svg

Patch merged.