Page MenuHomePhabricator

Samwilson (Sam Wilson)
Software Engineer (Community Tech) & volunteer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 5 2015, 5:03 AM (362 w, 4 d)
Availability
Available
IRC Nick
samwilson
LDAP User
Samwilson
MediaWiki User
Samwilson [ Global Accounts ]

Recent Activity

Today

Samwilson added a comment to T307725: Make action=edit with 2010 wikitext editor a full-width page in Vector-2022.

It looks like $wgVectorTableOfContents = true; is the culprit. Turn it on, and everything's fine with the above patch; turn it off, and the error we're seeing appears. That config var is enabled for Beta.

Tue, May 17, 2:28 AM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Patch-For-Review, Desktop Improvements, Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson created T308510: Table of Contents breaks tabs on max-width pages.
Tue, May 17, 2:26 AM · Desktop Improvements
Samwilson added a comment to T307725: Make action=edit with 2010 wikitext editor a full-width page in Vector-2022.

This is strange: I'm getting that same error (the overlapping of the taps) on my local with both Vector and WikiEditor at current master (i.e. it's not related to this patch). But I can't replicate it on Beta.

Tue, May 17, 12:48 AM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Patch-For-Review, Desktop Improvements, Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021

Yesterday

Samwilson created T308423: Double border in toolbar on narrow screens.
Mon, May 16, 8:57 AM · Realtime-Preview-Wish-2021
Samwilson moved T307725: Make action=edit with 2010 wikitext editor a full-width page in Vector-2022 from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-24) board.
Mon, May 16, 5:32 AM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Patch-For-Review, Desktop Improvements, Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson claimed T307725: Make action=edit with 2010 wikitext editor a full-width page in Vector-2022.
Mon, May 16, 3:04 AM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Patch-For-Review, Desktop Improvements, Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021

Thu, May 12

Volker_E awarded T307415: Add JSDoc configuration to WikiEditor a Like token.
Thu, May 12, 4:20 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Documentation, WikiEditor

Wed, May 11

Krinkle awarded T294319: Refactor preview front-end into reusable API a Orange Medal token.
Wed, May 11, 2:22 PM · Community-Tech (CommTech-Sprint-21), MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), MediaWiki-Page-editing, Realtime-Preview-Wish-2021
Samwilson added a comment to T308087: Make #tool-docs a subproject of #tools.

Thanks! And sorry for the extra work.

Wed, May 11, 3:15 AM · Project-Admins
Samwilson added a comment to T307174: Create a way to view docs-in-code from tools.

Oh, I didn't know that! I've created T308087 to get it moved.

Wed, May 11, 12:03 AM · tool-docs, Documentation, CommTech-Hackathon-AKA-CodeJam-2022, Wikimedia-Hackathon-2022
Samwilson created T308087: Make #tool-docs a subproject of #tools.
Wed, May 11, 12:02 AM · Project-Admins

Tue, May 10

Samwilson set Source Repo to https://gitlab.wikimedia.org/repos/commtech/toolforge-docs.git on tool-docs.
Tue, May 10, 11:58 PM
Samwilson added a watcher for tool-docs: Samwilson.
Tue, May 10, 11:52 PM
Samwilson added a project to T307174: Create a way to view docs-in-code from tools: tool-docs.

I've created a Phab project for the tool: tool-docs

Tue, May 10, 11:48 PM · tool-docs, Documentation, CommTech-Hackathon-AKA-CodeJam-2022, Wikimedia-Hackathon-2022
Samwilson created tool-docs.
Tue, May 10, 11:46 PM
Samwilson added a project to T307174: Create a way to view docs-in-code from tools: Documentation.
Tue, May 10, 12:07 AM · tool-docs, Documentation, CommTech-Hackathon-AKA-CodeJam-2022, Wikimedia-Hackathon-2022

Mon, May 9

Samwilson added a comment to T307956: IA-upload: Drop phetools dependency.

Great idea!

Mon, May 9, 11:25 PM · IA Upload
Samwilson awarded T307956: IA-upload: Drop phetools dependency a Like token.
Mon, May 9, 11:22 PM · IA Upload
Samwilson moved T307805: Manual reload shortcut causes the RTP pane to reopen from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-24) board.
Mon, May 9, 1:50 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson edited projects for T307805: Manual reload shortcut causes the RTP pane to reopen, added: Community-Tech (CommTech-Sprint-24); removed Community-Tech.
Mon, May 9, 1:38 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021

Sat, May 7

Samwilson added a comment to T183950: Search and replace is totally broken when using it with ProofreadPage.

This doesn't mean that we should give up on VE support, of course! But for now, these other bugs are more pressing.

Sat, May 7, 11:59 PM · All-and-every-Wikisource, WikiEditor, ProofreadPage
Samwilson added a comment to T307805: Manual reload shortcut causes the RTP pane to reopen.

Yes, I must admit the shortcut feature was a bit ill-defined and added without much design oversight. Sorry everyone! :-)

Sat, May 7, 12:14 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021

Fri, May 6

Samwilson closed T307415: Add JSDoc configuration to WikiEditor, a subtask of T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases, as Resolved.
Fri, May 6, 6:06 AM · Editing-team (Tracking), Epic, Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, Documentation
Samwilson closed T307415: Add JSDoc configuration to WikiEditor as Resolved.
Fri, May 6, 6:06 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Documentation, WikiEditor
Samwilson added a comment to T307106: Improve preview button look and feel in the Editor toolbar.

@nayoub good point, but yep we caught that one. Actually, it was a bug from T296447, in that the new section's groups never had their side border switched.

Fri, May 6, 5:56 AM · Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson moved T307105: Improvements to resize UI from QA 🐛 to In Development 💻 on the Community-Tech (CommTech-Sprint-24) board.

Moving this back to dev for the last bits.

Fri, May 6, 5:47 AM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson added a comment to T307725: Make action=edit with 2010 wikitext editor a full-width page in Vector-2022.

Do we want the edit page to always be wide, or only if the Realtime Preview beta feature is turned on, or only if the preview pane is enabled? There was a comment in Slack about "the transition" being important, which makes me think there might be an animation involved.

Fri, May 6, 1:15 AM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Patch-For-Review, Desktop Improvements, Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson added a comment to T307680: Use manageForeignResources.php to manage OpenSeadragon dependency.

That'd be great!

Fri, May 6, 12:12 AM · ProofreadPage

Thu, May 5

Samwilson created T307680: Use manageForeignResources.php to manage OpenSeadragon dependency.
Thu, May 5, 12:59 PM · ProofreadPage
Samwilson changed the subtype of T307174: Create a way to view docs-in-code from tools from "Task" to "Feature Request".
Thu, May 5, 8:43 AM · tool-docs, Documentation, CommTech-Hackathon-AKA-CodeJam-2022, Wikimedia-Hackathon-2022
Samwilson updated the task description for T307174: Create a way to view docs-in-code from tools.
Thu, May 5, 8:42 AM · tool-docs, Documentation, CommTech-Hackathon-AKA-CodeJam-2022, Wikimedia-Hackathon-2022
Samwilson added a watcher for IPA-Audio-Renderer-Wish-2022: Samwilson.
Thu, May 5, 3:50 AM
Samwilson moved T306590: [Realtime Preview] Make whole manual-mode bar clickable from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-24) board.
Thu, May 5, 3:21 AM · Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021, WikiEditor
Samwilson moved T306906: Manual reload button does not have a tooltip from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-24) board.
Thu, May 5, 3:21 AM · Community-Tech (CommTech-Sprint-24), Accessibility, Realtime-Preview-Wish-2021
Samwilson moved T306880: In manual-mode, shortcut key does not open preview if it has been closed from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-24) board.
Thu, May 5, 3:21 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021

Wed, May 4

Samwilson added a comment to T303991: Design QA on testwiki.

@nayoub don't forget to create a task for "Visual adjustments on handlebars". I think that's the last part of this ticket (the other bits now have their own tasks, for easier tracking).

Wed, May 4, 11:49 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson moved T307106: Improve preview button look and feel in the Editor toolbar from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-24) board.
Wed, May 4, 11:48 PM · Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson reopened T307106: Improve preview button look and feel in the Editor toolbar, a subtask of T303991: Design QA on testwiki, as Open.
Wed, May 4, 11:47 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson reopened T307106: Improve preview button look and feel in the Editor toolbar as "Open".

@TheresNoTime thanks for reviewing and merging this! I actually forgot to update the commit message with this (new) task number (the one on it is for the parent task), so here it is for posterity: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiEditor/+/784084

Wed, May 4, 11:47 PM · Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson added a comment to T303532: Add ability to refresh via shortcut and UX.

I think the shortcut on Mac is Control+⌥ Option (you mentioned Command+Option above). Does that work?

Wed, May 4, 11:39 PM · Community-Tech (CommTech-Sprint-24), MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Realtime-Preview-Wish-2021
Samwilson moved T306965: Blank realtime preview pane when request times out from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-24) board.
Wed, May 4, 3:44 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson moved T306590: [Realtime Preview] Make whole manual-mode bar clickable from Review/Feedback 💬 to In Development 💻 on the Community-Tech (CommTech-Sprint-24) board.
Wed, May 4, 3:44 AM · Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021, WikiEditor
Samwilson moved T306906: Manual reload button does not have a tooltip from Review/Feedback 💬 to In Development 💻 on the Community-Tech (CommTech-Sprint-24) board.
Wed, May 4, 3:44 AM · Community-Tech (CommTech-Sprint-24), Accessibility, Realtime-Preview-Wish-2021
Samwilson moved T306880: In manual-mode, shortcut key does not open preview if it has been closed from Review/Feedback 💬 to In Development 💻 on the Community-Tech (CommTech-Sprint-24) board.
Wed, May 4, 3:44 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson added a comment to T302916: Loading the output area to the matching wikitext .

I think that's the correct behaviour. T294977 is about making the preview pane automatically scroll to match the current editing position (which I think is what you're expecting there?).

Wed, May 4, 2:50 AM · Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson added a comment to T306965: Blank realtime preview pane when request times out.

I think I've figured this out. We're hiding the error message whenever entering manual mode, but actually should be doing so only on successful preview. i.e. I'd been thinking that we wouldn't want the error and manual bar to show at the same time, but that's actually valid.

Wed, May 4, 2:44 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021

Tue, May 3

Samwilson added a comment to T294977: Investigate: Match the preview area to the wikitext area.

It sounds like our approach here is going to be to scroll the preview area to the same percentage as the editing box. This can be inaccurate where there's a big discrepancy between wikitext height and rendered HTML height (e.g. large list of infobox parameters, only one of which is rendered; or a tall image, which requires only a single line in wikitext).

Tue, May 3, 9:18 AM · Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson moved T302916: Loading the output area to the matching wikitext from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-24) board.

This is working now. No code changes required.

Tue, May 3, 9:15 AM · Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson added a comment to T306176: Event tracking for Realtime Preview.

How often are users opening and closing the Preview window inside the Wikitext code editor?

Tue, May 3, 7:27 AM · Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson added a comment to T306969: Re-organise the #wikisource Phab board.

What we're wanting to do here is to use this project as the triaging place: so that any Wikisource-related project can be added here, but after triaging it'll be moved to the correct other projects. There's no point in having this board be only for tasks that effect every Wikisource, because those tasks already have more specific projects to which they belong.

Tue, May 3, 7:10 AM · All-and-every-Wikisource
Samwilson moved T307415: Add JSDoc configuration to WikiEditor from Backlog to Automated and Inline Technical Documentation on the Documentation board.
Tue, May 3, 6:22 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Documentation, WikiEditor
Samwilson added a subtask for T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases: T307415: Add JSDoc configuration to WikiEditor.
Tue, May 3, 6:21 AM · Editing-team (Tracking), Epic, Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, Documentation
Samwilson added a parent task for T307415: Add JSDoc configuration to WikiEditor: T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases.
Tue, May 3, 6:21 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Documentation, WikiEditor
Samwilson created T307415: Add JSDoc configuration to WikiEditor.
Tue, May 3, 6:21 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Documentation, WikiEditor
Samwilson claimed T306880: In manual-mode, shortcut key does not open preview if it has been closed.
Tue, May 3, 3:46 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson moved T293337: Disable Preview editing mode when screen is too crowded from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-24) board.
Tue, May 3, 2:32 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021

Mon, May 2

Samwilson created T307343: Increase indent of mw.dumpObject() table output.
Mon, May 2, 10:26 AM · Patch-For-Review, MediaWiki-extensions-Scribunto
Samwilson added a comment to T280637: Disable the WS-Export extension on Hebrew Wikisource.

Thanks for your patience. We're really keen to try to sort out the actual problems with WS Export.

Mon, May 2, 8:12 AM · WS Export, Wikimedia-Site-requests
Samwilson closed T192199: Proofread scan appearing tiny in wikisource, when creating or editing Page: pages as Resolved.

Okay, let's call this fine, and chase any new bugs separately. Thanks!

Mon, May 2, 7:41 AM · MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), ProofreadPage

Fri, Apr 29

bd808 awarded T307174: Create a way to view docs-in-code from tools a Love token.
Fri, Apr 29, 4:19 PM · tool-docs, Documentation, CommTech-Hackathon-AKA-CodeJam-2022, Wikimedia-Hackathon-2022
Samwilson renamed T45921: Add option to swap position of image and textbox from Add option to change the position of scanned page to Add option to swap position of image and textbox.
Fri, Apr 29, 1:11 PM · Malayalam-Sites, ProofreadPage
Samwilson removed a project from T192199: Proofread scan appearing tiny in wikisource, when creating or editing Page: pages: All-and-every-Wikisource.

Since we've switched to OpenSeadragon for the image viewer, has this issue been resolved?

Fri, Apr 29, 1:07 PM · MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), ProofreadPage
Samwilson moved T307174: Create a way to view docs-in-code from tools from Backlog to Hacking Projects on the Wikimedia-Hackathon-2022 board.
Fri, Apr 29, 7:58 AM · tool-docs, Documentation, CommTech-Hackathon-AKA-CodeJam-2022, Wikimedia-Hackathon-2022
Samwilson created T307174: Create a way to view docs-in-code from tools.
Fri, Apr 29, 5:40 AM · tool-docs, Documentation, CommTech-Hackathon-AKA-CodeJam-2022, Wikimedia-Hackathon-2022
Samwilson added a comment to T306969: Re-organise the #wikisource Phab board.

We'll talk about this task at the Wikisource Triage Meeting later today: https://meta.wikimedia.org/wiki/Wikisource_Triage_meetings#April_2022_meeting

Fri, Apr 29, 2:51 AM · All-and-every-Wikisource
Samwilson claimed T306965: Blank realtime preview pane when request times out.
Fri, Apr 29, 2:37 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021

Thu, Apr 28

Samwilson closed T251881: Cron <tools.wscontest@tools-sgecron-01> /usr/bin/jsub -N scores -once /data/project/wscontest/scores.sh as Resolved.

All issues with scoring should be fixed now, with the new version of the tool.

Thu, Apr 28, 7:32 AM · tool-wscontest
Samwilson closed T218368: Upgrade Slim as Declined.

We've switched to Symfony!

Thu, Apr 28, 7:31 AM · tool-wscontest
Samwilson moved T306590: [Realtime Preview] Make whole manual-mode bar clickable from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-24) board.
Thu, Apr 28, 2:36 AM · Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021, WikiEditor
Samwilson claimed T306906: Manual reload button does not have a tooltip .
Thu, Apr 28, 2:35 AM · Community-Tech (CommTech-Sprint-24), Accessibility, Realtime-Preview-Wish-2021
Samwilson updated the task description for T273840: Create Symfony skeleton for quick creation of new Toolforge tools.
Thu, Apr 28, 1:37 AM · Wikimedia-Hackathon-2022, ToolforgeBundle

Wed, Apr 27

Samwilson moved T306866: [Realtime Preview] Reload button should not display on top of error message from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-24) board.
Wed, Apr 27, 11:02 AM · MW-1.39-notes (1.39.0-wmf.10; 2022-05-02), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson added a comment to T306969: Re-organise the #wikisource Phab board.

I'm afraid that's the problem this such generic project tags, no matter how these project tags are called. The more generic, the more it can become a dump ground for anything and nothing experienced on some Wikisource.

Wed, Apr 27, 11:00 AM · All-and-every-Wikisource
Samwilson moved T306969: Re-organise the #wikisource Phab board from Backlog to Next-up on the All-and-every-Wikisource board.
Wed, Apr 27, 10:27 AM · All-and-every-Wikisource
Samwilson created T306969: Re-organise the #wikisource Phab board.
Wed, Apr 27, 10:16 AM · All-and-every-Wikisource
Samwilson edited Description on All-and-every-Wikisource.
Wed, Apr 27, 9:53 AM

Tue, Apr 26

Samwilson moved T304568: Manual refresh message in case of slow connection from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-24) board.

All follow-up patches are done for this task.

Tue, Apr 26, 8:28 AM · Community-Tech (CommTech-Sprint-24), Patch-For-Review, MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Realtime-Preview-Wish-2021
Samwilson moved T306866: [Realtime Preview] Reload button should not display on top of error message from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-24) board.
Tue, Apr 26, 8:25 AM · MW-1.39-notes (1.39.0-wmf.10; 2022-05-02), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson renamed T306866: [Realtime Preview] Reload button should not display on top of error message from Reload button should not display on top of error message to [Realtime Preview] Reload button should not display on top of error message.
Tue, Apr 26, 8:24 AM · MW-1.39-notes (1.39.0-wmf.10; 2022-05-02), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson edited projects for T306866: [Realtime Preview] Reload button should not display on top of error message, added: Community-Tech (CommTech-Sprint-24); removed Patch-For-Review.
Tue, Apr 26, 8:24 AM · MW-1.39-notes (1.39.0-wmf.10; 2022-05-02), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson created T306866: [Realtime Preview] Reload button should not display on top of error message.
Tue, Apr 26, 8:16 AM · MW-1.39-notes (1.39.0-wmf.10; 2022-05-02), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson updated the task description for T304568: Manual refresh message in case of slow connection.
Tue, Apr 26, 7:45 AM · Community-Tech (CommTech-Sprint-24), Patch-For-Review, MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Realtime-Preview-Wish-2021

Mon, Apr 25

Samwilson removed a project from T306774: test_get_property_names_en_ws test fails due to unknown 'noexternallanglinks' property: PHP-API-for-Wikisource.

The #wikisource-api Phabricator project was poorly named. It's not about general API access to Wikisource. I've updated it and given it a better title of PHP-API-for-Wikisource.

Mon, Apr 25, 4:23 AM · Pywikibot-tests, Pywikibot
Samwilson renamed PHP-API-for-Wikisource from wikisource-api to PHP-API-for-Wikisource.
Mon, Apr 25, 4:20 AM

Thu, Apr 21

Samwilson updated subscribers of T306590: [Realtime Preview] Make whole manual-mode bar clickable.

@nayoub @NRodriguez Should the whole bar be dimmed during loading, or just the "Reload" blue text? The blue snake is not dimmed, and (at the moment) appears below the bar:

Thu, Apr 21, 7:39 AM · Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021, WikiEditor
Samwilson claimed T306590: [Realtime Preview] Make whole manual-mode bar clickable.
Thu, Apr 21, 4:53 AM · Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021, WikiEditor
Samwilson added a comment to T240363: "Undefined index: imageinfo" attempting to generate certain ebooks.

I'm happy to just merge this and keep an eye on things, if no one's got time to review it thoroughly.

Thu, Apr 21, 3:42 AM · Community-Tech (CommTech-Sprint-24), WS Export
Samwilson added a project to T306590: [Realtime Preview] Make whole manual-mode bar clickable: Community-Tech (CommTech-Sprint-23).

Moving to current sprint as this is work from an existing task.

Thu, Apr 21, 3:38 AM · Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021, WikiEditor
Samwilson added a comment to T304568: Manual refresh message in case of slow connection.

Hey @Samwilson where are we keeping track of these changes?

Thu, Apr 21, 3:37 AM · Community-Tech (CommTech-Sprint-24), Patch-For-Review, MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Realtime-Preview-Wish-2021
Samwilson updated the task description for T306590: [Realtime Preview] Make whole manual-mode bar clickable.
Thu, Apr 21, 3:37 AM · Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021, WikiEditor
Samwilson created T306590: [Realtime Preview] Make whole manual-mode bar clickable.
Thu, Apr 21, 3:35 AM · Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021, WikiEditor

Wed, Apr 20

Samwilson added a comment to T304568: Manual refresh message in case of slow connection.

Sounds good.

Wed, Apr 20, 4:42 AM · Community-Tech (CommTech-Sprint-24), Patch-For-Review, MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Realtime-Preview-Wish-2021
Samwilson moved T304568: Manual refresh message in case of slow connection from Review / Feedback 💬 to In Development 💻 on the Community-Tech (CommTech-Sprint-23) board.
Wed, Apr 20, 12:51 AM · Community-Tech (CommTech-Sprint-24), Patch-For-Review, MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Realtime-Preview-Wish-2021

Tue, Apr 19

Samwilson updated the task description for T303991: Design QA on testwiki.
Tue, Apr 19, 9:49 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021
Samwilson added a comment to T303991: Design QA on testwiki.

i. Preview button in the Editor toolbar

Tue, Apr 19, 9:48 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Community-Tech (CommTech-Sprint-24), Realtime-Preview-Wish-2021

Apr 14 2022

Samwilson added a comment to T298218: Add EventLogging for realtime preview.

My understanding is that no events are logged from Beta wikis. The four events logged so far are from testwiki.

Apr 14 2022, 9:12 AM · Community-Tech (CommTech-Sprint-24), MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), Realtime-Preview-Wish-2021, WikiEditor
Samwilson added a comment to T305331: Migrate tools from Grid Engine to Kubernetes.

I agree that we should be removed as maintainers from all those. Access to jarry-common was I think because the old svgtranslate code used something from there.

Apr 14 2022, 9:03 AM · Community-Tech (CommTech-Sprint-24)
Samwilson updated subscribers of T304568: Manual refresh message in case of slow connection.

Ah great, looks good!

Apr 14 2022, 8:59 AM · Community-Tech (CommTech-Sprint-24), Patch-For-Review, MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Realtime-Preview-Wish-2021
Samwilson moved T304568: Manual refresh message in case of slow connection from In Development 💻 to Review / Feedback 💬 on the Community-Tech (CommTech-Sprint-23) board.
Apr 14 2022, 8:58 AM · Community-Tech (CommTech-Sprint-24), Patch-For-Review, MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Realtime-Preview-Wish-2021
Samwilson added a comment to T302282: Real Time Preview performance safeguards.

In addition to what @MusikAnimal says above, you can also test the timeouts by trying to preview a huge page (I find on my local environment previewing something big copied from Wikipedia works, especially if there are lots of images and InstantCommons is turned on). Also, adding a sleep(11) to ApiParse::execute() can help test a quick connection with a slow parse. The inverse can be done with browser tools for slowing the connection down.

Apr 14 2022, 3:12 AM · Community-Tech (CommTech-Sprint-24), MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), Patch-For-Review, Performance-Team, Realtime-Preview-Wish-2021