Samwilson (Sam Wilson)
Software Engineer (Community Tech) & volunteer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 5 2015, 5:03 AM (150 w, 15 h)
Availability
Available
LDAP User
Samwilson
MediaWiki User
Samwilson

Recent Activity

Today

Samwilson added a comment to T190348: Improve usability of TemplateWizard.

I was going to say that perhaps we could search the template data that's stored in page_props, but it's compressed isn't it so that probably doesn't work?

Fri, Apr 20, 12:46 PM · Community-Tech, MediaWiki-extensions-TemplateWizard
Samwilson moved T191756: Guess parameters for templates without TemplateData from Ready to In Development on the Community-Tech-Sprint board.
Fri, Apr 20, 7:03 AM · Patch-For-Review, VisualEditor, TemplateData, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson claimed T191756: Guess parameters for templates without TemplateData.
Fri, Apr 20, 7:03 AM · Patch-For-Review, VisualEditor, TemplateData, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard

Yesterday

Samwilson added a comment to T191793: OOui undefined error when loading template wizard userscript on en.wp on Safari.

Thanks!

Thu, Apr 19, 9:17 AM · MediaWiki-extensions-TemplateWizard, Community-Tech
Samwilson added a project to T191756: Guess parameters for templates without TemplateData: TemplateData.

It seems like it might be nice to add an option to the TemplateData API, e.g. extend the doNotIgnoreMissingTitles parameter to also return guessed parameters, or add an new guessmissing that does the same. No metadata about these parameters would be available of course.

Thu, Apr 19, 6:22 AM · Patch-For-Review, VisualEditor, TemplateData, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
This is a test notification, sent at Thu, Apr 19, 12:21 PM.
Thu, Apr 19, 4:21 AM
This is a test notification, sent at Thu, Apr 19, 12:21 PM.
Thu, Apr 19, 4:21 AM
This is a test notification, sent at Thu, Apr 19, 12:21 PM.
Thu, Apr 19, 4:21 AM
Samwilson added a comment to T191264: Don't drop fields with incorrect format values.

This seems to be a deeper bug than it first looks (see also T150455). Number fields are type="number" and browsers hide non-numerical values for those (i.e. .val() returns an empty string).

Thu, Apr 19, 2:25 AM · Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard

Wed, Apr 18

Samwilson added a comment to T188966: cleanupPreferences.php would nuke all global preference overrides.

There aren't preferences any with variable names (that depend on the user), but the presence of a few depend on the user (e.g. those to do with email are not present for users who don't have sendemail) and so with the current system we can't retrieve all the preference names.

Wed, Apr 18, 9:33 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), MediaWiki-User-preferences, Patch-For-Review, MediaWiki-extensions-GlobalPreferences, Community-Tech-Sprint

Tue, Apr 17

Samwilson added a comment to T190373: JavaScript error in Chrome, preferences don't save.

I haven't been able to replicate this.

Tue, Apr 17, 3:48 AM · Community-Tech-Sprint, Browser-Support-Google-Chrome, MediaWiki-extensions-GlobalPreferences
Samwilson moved T191264: Don't drop fields with incorrect format values from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.
Tue, Apr 17, 2:01 AM · Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson moved T190231: Popup on submission of empty required fields; Popup on hitting cancel with data in form from Ready to In Development on the Community-Tech-Sprint board.
Tue, Apr 17, 1:56 AM · Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard

Mon, Apr 16

Samwilson moved T191264: Don't drop fields with incorrect format values from Ready to In Development on the Community-Tech-Sprint board.
Mon, Apr 16, 10:19 PM · Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson added a comment to T191608: markasread param doesn't work for log entry thanks.

This seems to be because we're using the Special:Redirect/logid/123 method to link to a log entry, and the markasread parameter isn't forwarded with the redirect.

Mon, Apr 16, 8:00 AM · Community-Tech-Sprint, Thanks, Collaboration-Team-Triage, Notifications
Samwilson added a comment to T190353: Argument 1 passed to CentralIdLookup::namesFromCentralIds() must be an instance of array, string given.

It's not only Echo that has an array preference, it's core as well (email-blacklist). So really, GP should only have to convert the core one (and do whatever else core does to preference values when loading) when it loads global preferences.

Mon, Apr 16, 5:16 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Community-Tech-Sprint, Notifications, MediaWiki-extensions-GlobalPreferences, Collaboration-Team-Triage
Samwilson claimed T191608: markasread param doesn't work for log entry thanks.
Mon, Apr 16, 4:22 AM · Community-Tech-Sprint, Thanks, Collaboration-Team-Triage, Notifications
Samwilson moved T191608: markasread param doesn't work for log entry thanks from Ready to In Development on the Community-Tech-Sprint board.
Mon, Apr 16, 4:22 AM · Community-Tech-Sprint, Thanks, Collaboration-Team-Triage, Notifications
Samwilson added a comment to T190425: GlobalPreferences deploy caused a significant increase in reads on s3.

Could this be related to looking up the central ID? I've attempted to reproduce the bug locally by running 1000 requests, and do see considerable increase in Handler_read_next:

Mon, Apr 16, 4:20 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences
Samwilson moved T190353: Argument 1 passed to CentralIdLookup::namesFromCentralIds() must be an instance of array, string given from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.
Mon, Apr 16, 2:31 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Community-Tech-Sprint, Notifications, MediaWiki-extensions-GlobalPreferences, Collaboration-Team-Triage

Sun, Apr 15

Samwilson added a comment to T191004: Wikiapiary Session problems: can't edit due to loss of session data. If trying to login from a new browser, says cookies are disabled.

Also reported at https://www.mediawiki.org/wiki/Topic:Ubb4rq1ajetfbxc2

Sun, Apr 15, 9:10 AM · WikiApiary
Samwilson created T192226: Invalid security certificate for www.wikiapiary.com.
Sun, Apr 15, 9:10 AM · WikiApiary

Sat, Apr 14

Samwilson added a comment to T192147: Regression: Changes to email blacklist or muted users do not activate Save button in Preferences.

I don't think this is related to GlobalPreferences. The closest current issue is T190902: Usernames remain disabled when enabling local exception for email-blacklist, so I wonder if there are just some peculiarities about that widget.

Sat, Apr 14, 12:37 AM · Verified, MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Regression, Anti-Harassment, Notifications, Collaboration-Team-Triage, MediaWiki-User-preferences

Fri, Apr 13

Samwilson added a comment to T191004: Wikiapiary Session problems: can't edit due to loss of session data. If trying to login from a new browser, says cookies are disabled.

I am unable to log in as well. The login form is has a link to log in via HTTPS (as though it doesn't know that it already is).

Fri, Apr 13, 5:11 AM · WikiApiary
Samwilson awarded T191004: Wikiapiary Session problems: can't edit due to loss of session data. If trying to login from a new browser, says cookies are disabled a Like token.
Fri, Apr 13, 5:07 AM · WikiApiary
Samwilson claimed T190231: Popup on submission of empty required fields; Popup on hitting cancel with data in form.
Fri, Apr 13, 2:10 AM · Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson moved T190231: Popup on submission of empty required fields; Popup on hitting cancel with data in form from In Development to Ready on the Community-Tech-Sprint board.
Fri, Apr 13, 2:10 AM · Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson moved T191264: Don't drop fields with incorrect format values from Needs Review/Feedback to Ready on the Community-Tech-Sprint board.
Fri, Apr 13, 2:10 AM · Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson moved T191264: Don't drop fields with incorrect format values from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.
Fri, Apr 13, 2:10 AM · Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson moved T192057: Error when getting templatedata of all templates from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.
Fri, Apr 13, 2:08 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), Community-Tech-Sprint, Patch-For-Review, MediaWiki-General-or-Unknown, TemplateData
Samwilson added a comment to T191264: Don't drop fields with incorrect format values.

The above patch depends on T192057 being resolved.

Fri, Apr 13, 2:02 AM · Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson added a project to T192057: Error when getting templatedata of all templates: Community-Tech-Sprint.
Fri, Apr 13, 2:01 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), Community-Tech-Sprint, Patch-For-Review, MediaWiki-General-or-Unknown, TemplateData
Samwilson added a comment to T192057: Error when getting templatedata of all templates.

Thanks @Anomie that's super useful. I've made the changes you suggest https://gerrit.wikimedia.org/r/#/c/425941/ and this task's two problems are fixed (and the TemplateWizard patch is passing). :-)

Fri, Apr 13, 2:01 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), Community-Tech-Sprint, Patch-For-Review, MediaWiki-General-or-Unknown, TemplateData
Samwilson lowered the priority of T190353: Argument 1 passed to CentralIdLookup::namesFromCentralIds() must be an instance of array, string given from High to Low.
Fri, Apr 13, 1:28 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Community-Tech-Sprint, Notifications, MediaWiki-extensions-GlobalPreferences, Collaboration-Team-Triage
Samwilson reopened T190353: Argument 1 passed to CentralIdLookup::namesFromCentralIds() must be an instance of array, string given as "Open".

Should we add a check to Echo to ensure GlobalPreferences isn't loaded? Because we can't check in GlobalPreferences to make sure Echo is loaded, because it may not be installed at all.

Fri, Apr 13, 1:27 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Community-Tech-Sprint, Notifications, MediaWiki-extensions-GlobalPreferences, Collaboration-Team-Triage
Samwilson reopened T190353: Argument 1 passed to CentralIdLookup::namesFromCentralIds() must be an instance of array, string given, a subtask of T189806: Deploy GlobalPrefs on production, as Open.
Fri, Apr 13, 1:27 AM · Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-GlobalPreferences
Samwilson moved T188966: cleanupPreferences.php would nuke all global preference overrides from Backlog to Defects on the MediaWiki-extensions-GlobalPreferences board.
Fri, Apr 13, 12:44 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), MediaWiki-User-preferences, Patch-For-Review, MediaWiki-extensions-GlobalPreferences, Community-Tech-Sprint
Samwilson moved T189806: Deploy GlobalPrefs on production from Backlog to Wikimedia integration on the MediaWiki-extensions-GlobalPreferences board.
Fri, Apr 13, 12:44 AM · Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-GlobalPreferences

Thu, Apr 12

Samwilson added a comment to T192057: Error when getting templatedata of all templates.

I don't think this has anything to do with VisualEditor, Herald. But whatever you reckon, you go for it. :)

Thu, Apr 12, 8:02 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), Community-Tech-Sprint, Patch-For-Review, MediaWiki-General-or-Unknown, TemplateData
Samwilson removed a project from T192057: Error when getting templatedata of all templates: VisualEditor.
Thu, Apr 12, 8:01 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), Community-Tech-Sprint, Patch-For-Review, MediaWiki-General-or-Unknown, TemplateData
Samwilson updated subscribers of T192057: Error when getting templatedata of all templates.

@Simetrical is this something you know about? (You added the above failing test I think.)

Thu, Apr 12, 8:01 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), Community-Tech-Sprint, Patch-For-Review, MediaWiki-General-or-Unknown, TemplateData
Samwilson created T192057: Error when getting templatedata of all templates.
Thu, Apr 12, 8:00 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), Community-Tech-Sprint, Patch-For-Review, MediaWiki-General-or-Unknown, TemplateData
Samwilson added a comment to T190231: Popup on submission of empty required fields; Popup on hitting cancel with data in form.

The first part of this will be covered by T191264, because empty required fields are treated as a type of validation exception and so are caught along with misformed values etc.

Thu, Apr 12, 3:23 AM · Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson closed T190354: Wikimedia\Rdbms\Database::query: lost connection to {dbserver}; reconnected, a subtask of T189806: Deploy GlobalPrefs on production, as Resolved.
Thu, Apr 12, 3:18 AM · Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-GlobalPreferences
Samwilson closed T190354: Wikimedia\Rdbms\Database::query: lost connection to {dbserver}; reconnected as Resolved.

We didn't see any more of these errors in the last deployment.

Thu, Apr 12, 3:18 AM · Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences
Samwilson added a comment to T190425: GlobalPreferences deploy caused a significant increase in reads on s3.

So it looks to me like (for a logged-in user's request) the user three times: once when loading the session, once when setting $wgUser, and once in the ResourceLoaderContext.

Thu, Apr 12, 2:51 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences
Samwilson added a comment to T192043: Consider changing thanks for "Import" to use revision instead of log.

If a log entry has an associated revision ID, it uses that.

Thu, Apr 12, 12:38 AM · Community-Tech, Collaboration-Team-Triage, Thanks
Samwilson moved T190231: Popup on submission of empty required fields; Popup on hitting cancel with data in form from Ready to In Development on the Community-Tech-Sprint board.
Thu, Apr 12, 12:04 AM · Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson edited projects for T190231: Popup on submission of empty required fields; Popup on hitting cancel with data in form, added: Community-Tech-Sprint; removed Community-Tech.
Thu, Apr 12, 12:03 AM · Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard

Wed, Apr 11

Samwilson added a comment to T190348: Improve usability of TemplateWizard.

Could the above slides be attached here as a PDF?

Wed, Apr 11, 9:59 PM · Community-Tech, MediaWiki-extensions-TemplateWizard
Samwilson committed rEGNE883324037600: Update Composer fields (authored by Samwilson).
Update Composer fields
Wed, Apr 11, 9:51 AM
Samwilson committed rEGNE246a67e780b8: Fix for empty descriptions, and properly strip their tags in graphs (authored by Samwilson).
Fix for empty descriptions, and properly strip their tags in graphs
Wed, Apr 11, 9:47 AM
Samwilson committed rEGNEa6395305517b: Fix for empty descriptions, and properly strip their tags in graphs (authored by Samwilson).
Fix for empty descriptions, and properly strip their tags in graphs
Wed, Apr 11, 9:47 AM
Samwilson created T191962: Comma in URL ignored.
Wed, Apr 11, 9:40 AM · GraphViz

Tue, Apr 10

Samwilson changed the status of T191793: OOui undefined error when loading template wizard userscript on en.wp on Safari from Declined to Resolved.

This should be working now, thanks to @kaldari: https://en.wikipedia.org/w/index.php?title=User%3ASamwilson%2FTemplateWizard.js&type=revision&diff=835798273&oldid=834272150

Tue, Apr 10, 10:34 PM · MediaWiki-extensions-TemplateWizard, Community-Tech
Samwilson changed the status of T191793: OOui undefined error when loading template wizard userscript on en.wp on Safari, a subtask of T186653: [Epic] Template wizard for WikiEditor, from Declined to Resolved.
Tue, Apr 10, 10:34 PM · MediaWiki-extensions-TemplateWizard, Community-Wishlist-Survey-2017, Community-Tech
Samwilson moved T191264: Don't drop fields with incorrect format values from Ready to In Development on the Community-Tech-Sprint board.
Tue, Apr 10, 5:12 AM · Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson added a comment to T188966: cleanupPreferences.php would nuke all global preference overrides.

I think the main problem, and the (slightly indirect) reason that this hook needs to exist, is that it is not possible to determine valid preference names without doing so for a particular user. This is why the cleanup script treats anything that is $wgDefaultUserOptions as 'unknown' (along with userjs- preferences).

Tue, Apr 10, 3:14 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), MediaWiki-User-preferences, Patch-For-Review, MediaWiki-extensions-GlobalPreferences, Community-Tech-Sprint
Samwilson claimed T191264: Don't drop fields with incorrect format values.
Tue, Apr 10, 1:35 AM · Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard

Mon, Apr 9

Samwilson added a comment to T191793: OOui undefined error when loading template wizard userscript on en.wp on Safari.

It happens on Firefox too, on Wikisource. I can't get it to happen with the extension though, so haven't really looked into what load order or other confusion is causing it. The gadget is loading oojs-ui-core which should be enough, but I guess sometimes other things are happening. :-(

Mon, Apr 9, 10:51 PM · MediaWiki-extensions-TemplateWizard, Community-Tech
Samwilson moved T190390: Fix numbered parameters to not include the number from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.
Mon, Apr 9, 6:12 AM · Community-Tech-Sprint, Patch-For-Review, MediaWiki-extensions-TemplateWizard
Samwilson added a comment to T191755: List all linked patches at the top of a Phab ticket.

So if we're sticking with Gerrit forever, then the work to implement this might be worth it? (I'm not not volunteering to do it, by the way.)

Mon, Apr 9, 4:33 AM · Phabricator
Samwilson awarded T191182: Consider disabling differential a Like token.
Mon, Apr 9, 4:29 AM · Release-Engineering-Team (Someday), Phabricator, Gerrit
Samwilson added a comment to T187900: There is no way to reference a specific quote on Wikiquote.

The purple-numbers idea is about adding anchors to every paragraph or list-item (etc.) as little purple-coloured hashes or pilcrows at the end of the block. I don't suppose it would ever be considered on a Wikimedia wiki as it's often considered a bit annoying to readers, and anyway seems to have died out in recent years.

Mon, Apr 9, 3:11 AM · Wikimedia-Extension-setup, MediaWiki-extensions-WikibaseRepository, Wikidata, MediaWiki-General-or-Unknown
Samwilson moved T189908: Create a help page for TemplateWizard from Backlog to Ready on the MediaWiki-extensions-TemplateWizard board.
Mon, Apr 9, 2:51 AM · Community-Tech-Sprint, Documentation, MediaWiki-extensions-TemplateWizard
Samwilson moved T189177: Fix colours of form section headers (required/suggested/optional) from Backlog to Ready on the MediaWiki-extensions-TemplateWizard board.
Mon, Apr 9, 2:51 AM · Community-Tech, MediaWiki-extensions-TemplateWizard
Samwilson moved T190231: Popup on submission of empty required fields; Popup on hitting cancel with data in form from Backlog to Ready on the MediaWiki-extensions-TemplateWizard board.
Mon, Apr 9, 2:51 AM · Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson moved T190388: Add checkboxes to allow users to pick fields they want inserted from Backlog to Ready on the MediaWiki-extensions-TemplateWizard board.
Mon, Apr 9, 2:51 AM · MediaWiki-extensions-TemplateWizard
Samwilson moved T191194: Template wizard won't insert a template in IE11 from Backlog to Ready on the MediaWiki-extensions-TemplateWizard board.
Mon, Apr 9, 2:51 AM · Patch-For-Review, MediaWiki-extensions-TemplateWizard, Browser-Support-Internet-Explorer, Community-Tech
Samwilson moved T190390: Fix numbered parameters to not include the number from Backlog to Ready on the MediaWiki-extensions-TemplateWizard board.
Mon, Apr 9, 2:51 AM · Community-Tech-Sprint, Patch-For-Review, MediaWiki-extensions-TemplateWizard
Samwilson moved T191264: Don't drop fields with incorrect format values from Backlog to Ready on the MediaWiki-extensions-TemplateWizard board.
Mon, Apr 9, 2:51 AM · Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson moved T191756: Guess parameters for templates without TemplateData from Backlog to Waiting on the MediaWiki-extensions-TemplateWizard board.
Mon, Apr 9, 2:51 AM · Patch-For-Review, VisualEditor, TemplateData, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson moved T191757: Investigation: Edit existing templates from Backlog to Waiting on the MediaWiki-extensions-TemplateWizard board.
Mon, Apr 9, 2:51 AM · Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson created T191757: Investigation: Edit existing templates.
Mon, Apr 9, 2:48 AM · Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson closed T190372: Split classes out of main module file as Resolved.
Mon, Apr 9, 2:45 AM · Community-Tech-Sprint, Patch-For-Review, MediaWiki-extensions-TemplateWizard
Samwilson closed T190372: Split classes out of main module file, a subtask of T186653: [Epic] Template wizard for WikiEditor, as Resolved.
Mon, Apr 9, 2:45 AM · MediaWiki-extensions-TemplateWizard, Community-Wishlist-Survey-2017, Community-Tech
Samwilson renamed T191756: Guess parameters for templates without TemplateData from ' to Guess parameters for templates without TemplateData.
Mon, Apr 9, 2:43 AM · Patch-For-Review, VisualEditor, TemplateData, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson created T191756: Guess parameters for templates without TemplateData.
Mon, Apr 9, 2:25 AM · Patch-For-Review, VisualEditor, TemplateData, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson added projects to T191608: markasread param doesn't work for log entry thanks: Thanks, Community-Tech.
Mon, Apr 9, 2:21 AM · Community-Tech-Sprint, Thanks, Collaboration-Team-Triage, Notifications
Samwilson created T191755: List all linked patches at the top of a Phab ticket.
Mon, Apr 9, 1:21 AM · Phabricator
Samwilson added a comment to T132220: Add datetime selector to Special:Block to select expiration.

It's probably fine to leave the deprecation warning in, but maybe there's a way around.

Mon, Apr 9, 1:05 AM · Anti-Harassment (AHT Sprint 19), Patch-For-Review, I18n, JavaScript, MediaWiki-User-management

Fri, Apr 6

Samwilson committed rEDBE0897d70dc451: Remove 'generated_files/' directory as it's no longer required (authored by Samwilson).
Remove 'generated_files/' directory as it's no longer required
Fri, Apr 6, 11:37 PM
Samwilson committed rEDBE480ee9d4f630: Remove 'generated_files/' directory as it's no longer required (authored by Samwilson).
Remove 'generated_files/' directory as it's no longer required
Fri, Apr 6, 11:37 PM
Samwilson committed rEDBE2d5d361a457a: Remove 'generated_files/' directory as it's no longer required (authored by Samwilson).
Remove 'generated_files/' directory as it's no longer required
Fri, Apr 6, 11:37 PM
Samwilson committed rEDBE5f2405bc18c1: Move build dir to within $wgUploadDir (authored by Samwilson).
Move build dir to within $wgUploadDir
Fri, Apr 6, 4:58 AM
Samwilson moved T190354: Wikimedia\Rdbms\Database::query: lost connection to {dbserver}; reconnected from Ready to In Development on the Community-Tech-Sprint board.
Fri, Apr 6, 2:30 AM · Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences

Thu, Apr 5

Samwilson added a comment to T188966: cleanupPreferences.php would nuke all global preference overrides.

Thanks. Will do.

Thu, Apr 5, 10:51 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), MediaWiki-User-preferences, Patch-For-Review, MediaWiki-extensions-GlobalPreferences, Community-Tech-Sprint
Samwilson added a comment to T191482: Add thanks for resolving StructuredDiscussions topics?.

Yeah, it does seem a strange choice for a log type name, but it looks like it's not used for anything other than flow-* actions: https://quarry.wmflabs.org/query/26144

Thu, Apr 5, 10:35 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Collaboration-Team-Triage, Community-Tech, Thanks, StructuredDiscussions
Samwilson closed T191268: Show "example" field from TemplateData as placeholder as Resolved.
Thu, Apr 5, 11:49 AM · Community-Tech-Sprint, Patch-For-Review, MediaWiki-extensions-TemplateWizard
Samwilson closed T191268: Show "example" field from TemplateData as placeholder, a subtask of T186653: [Epic] Template wizard for WikiEditor, as Resolved.
Thu, Apr 5, 11:49 AM · MediaWiki-extensions-TemplateWizard, Community-Wishlist-Survey-2017, Community-Tech
Samwilson moved T190390: Fix numbered parameters to not include the number from Ready to In Development on the Community-Tech-Sprint board.
Thu, Apr 5, 6:47 AM · Community-Tech-Sprint, Patch-For-Review, MediaWiki-extensions-TemplateWizard
Samwilson claimed T190390: Fix numbered parameters to not include the number.

@Esanders this is a good idea, and would certainly make some things a bit simpler. However, after discussion, we've decided to at least try to avoid a dependency on Parsoid. This is mainly because we want to be able to support 3rd party MediaWiki installations, and not many of them have Parsoid installed. Also, the (possible?) future shifting of Parsoid to be in core or at least in PHP adds a bit of uncertainty (although, I guess the API endpoints wouldn't change, so that's maybe less of a worry). We'll of course re-visit this if it seems we're going down a long tail of annoying bugs! :-)

Thu, Apr 5, 6:46 AM · Community-Tech-Sprint, Patch-For-Review, MediaWiki-extensions-TemplateWizard
Samwilson closed T191274: Improve button adding and don't load dependencies again as Resolved.
Thu, Apr 5, 1:56 AM · Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Samwilson closed T191274: Improve button adding and don't load dependencies again, a subtask of T186653: [Epic] Template wizard for WikiEditor, as Resolved.
Thu, Apr 5, 1:56 AM · MediaWiki-extensions-TemplateWizard, Community-Wishlist-Survey-2017, Community-Tech

Wed, Apr 4

Samwilson added a comment to T191268: Show "example" field from TemplateData as placeholder.

It shows default if there is one, and then example if there's no default. Doesn't show both.

Wed, Apr 4, 11:59 PM · Community-Tech-Sprint, Patch-For-Review, MediaWiki-extensions-TemplateWizard
Samwilson created T191482: Add thanks for resolving StructuredDiscussions topics?.
Wed, Apr 4, 11:55 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Collaboration-Team-Triage, Community-Tech, Thanks, StructuredDiscussions
Samwilson added a comment to T191268: Show "example" field from TemplateData as placeholder.

VE does this with placeholders for both example and default: e.g. $1 and Default: $1. Shall we do the same?

Wed, Apr 4, 11:42 PM · Community-Tech-Sprint, Patch-For-Review, MediaWiki-extensions-TemplateWizard
Samwilson added a comment to T191194: Template wizard won't insert a template in IE11.

Oops! I think I even knew that about endswith, but forgot. It feels like the sort of method that must have existed for ages. Wasn't there an endswith in Visual Basic? ;-)

Wed, Apr 4, 10:34 PM · Patch-For-Review, MediaWiki-extensions-TemplateWizard, Browser-Support-Internet-Explorer, Community-Tech
Samwilson added a comment to T132220: Add datetime selector to Special:Block to select expiration.

The Timeless oddity I mentioned:

Wed, Apr 4, 8:02 AM · Anti-Harassment (AHT Sprint 19), Patch-For-Review, I18n, JavaScript, MediaWiki-User-management
Samwilson moved T191268: Show "example" field from TemplateData as placeholder from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.
Wed, Apr 4, 4:47 AM · Community-Tech-Sprint, Patch-For-Review, MediaWiki-extensions-TemplateWizard