Page MenuHomePhabricator

Sarai-WMDE (Sarai Sanchez (WMDE))
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Nov 5 2019, 9:43 AM (69 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Sarai-WMDE [ Global Accounts ]

Recent Activity

Yesterday

Sarai-WMDE renamed T274261: (optional) the popover should be responsive to prevent making the screen scroll from (optional) the popover should become smaller if it would make the screen scroll to (optional) the popover should be responsive to prevent making the screen scroll.
Wed, Mar 3, 1:51 PM · Wikidata Design System, Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T273002: (MS 6) 🛑 Create Date input component.
Wed, Mar 3, 1:26 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T275758: (MS 6) Create InputWithExtender component.
Wed, Mar 3, 10:08 AM · Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T267010: Create BouncingDots loader mixin.
Wed, Mar 3, 9:14 AM · Wikidata, Wikidata Query Builder

Tue, Mar 2

Sarai-WMDE added a comment to T272697: (MS 6) Query for date values.

Hey, @abian. Those are very valid and concerns, and we really appreciate you sharing them! We are aware that unfortunately some current issues will also be reproduced by the new application (e.g. querying for a specific date like 01-01-2021 will result in false positives, since 2021 with precision year will also be retrieved). In the context of the Query Builder, users will only be able to enter specific dates, and precision will be interpreted based on their input (we are yet to define how some values – e.g. years only – would be translated into SPARQL. This might be the key to alleviate some of the inherent issues with dates?). This data type is definitely a tricky one, and we wouldn't like to proceed being unaware of big problems. Since you seem to really have a deep understanding of the issue and its consequences, it'd be great if you'd be up for a chat?

Tue, Mar 2, 4:46 PM · Wikidata Query Builder, Wikidata

Mon, Mar 1

Sarai-WMDE updated the task description for T267010: Create BouncingDots loader mixin.
Mon, Mar 1, 4:49 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE renamed T267010: Create BouncingDots loader mixin from Create loading state mixin to Create BouncingDots loader mixin.
Mon, Mar 1, 4:49 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE moved T267010: Create BouncingDots loader mixin from Later to Incoming on the Wikidata Query Builder board.
Mon, Mar 1, 4:41 PM · Wikidata, Wikidata Query Builder

Fri, Feb 26

Sarai-WMDE updated the task description for T273002: (MS 6) 🛑 Create Date input component.
Fri, Feb 26, 3:47 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE renamed T275758: (MS 6) Create InputWithExtender component from (MS 6) Create InputWithPreview component to (MS 6) Create InputWithExtender component.
Fri, Feb 26, 2:47 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T272958: (MS 5) Create link component.
Fri, Feb 26, 1:03 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T275758: (MS 6) Create InputWithExtender component.
Fri, Feb 26, 11:57 AM · Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T275758: (MS 6) Create InputWithExtender component.
Fri, Feb 26, 11:34 AM · Wikidata, Wikidata Query Builder

Thu, Feb 25

Sarai-WMDE renamed T273002: (MS 6) 🛑 Create Date input component from (MS 6) Create Date input component to (MS 6) 🛑 Create Date input component.
Thu, Feb 25, 12:44 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T272697: (MS 6) Query for date values.
Thu, Feb 25, 12:37 PM · Wikidata Query Builder, Wikidata
Sarai-WMDE updated the task description for T275758: (MS 6) Create InputWithExtender component.
Thu, Feb 25, 12:37 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T275758: (MS 6) Create InputWithExtender component.
Thu, Feb 25, 12:35 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T273002: (MS 6) 🛑 Create Date input component.
Thu, Feb 25, 12:33 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE created T275758: (MS 6) Create InputWithExtender component.
Thu, Feb 25, 12:32 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE added a comment to T273046: Allow buttons to be full width.

LGTM!

Thu, Feb 25, 9:22 AM · Wikidata, Wikidata Query Builder

Wed, Feb 24

Sarai-WMDE updated the task description for T273002: (MS 6) 🛑 Create Date input component.
Wed, Feb 24, 11:02 AM · Wikidata, Wikidata Query Builder

Tue, Feb 23

Sarai-WMDE updated the task description for T272958: (MS 5) Create link component.
Tue, Feb 23, 10:56 AM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Sarai-WMDE renamed T273002: (MS 6) 🛑 Create Date input component from (MS 6) Create Point in time input component to (MS 6) Create Date input component.
Tue, Feb 23, 10:05 AM · Wikidata, Wikidata Query Builder

Thu, Feb 18

Sarai-WMDE updated the task description for T272958: (MS 5) Create link component.
Thu, Feb 18, 11:53 AM · User-Ladsgroup, Wikidata, Wikidata Query Builder

Wed, Feb 17

Sarai-WMDE created T275052: Remove default focus outline of dropdown in Safari.
Wed, Feb 17, 5:34 PM · Wikidata, Wikidata Design System
Sarai-WMDE updated the task description for T271943: (MS 3) Use the DS NumberInput component and add validation to the Limit component.
Wed, Feb 17, 11:57 AM · Wikidata Query Builder, Wikidata
Sarai-WMDE created T275010: Create basic NumberInput component.
Wed, Feb 17, 11:55 AM · Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T273796: Create extended number input component.
Wed, Feb 17, 11:40 AM · Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T273001: (MS 3) Create Quantity input component.
Wed, Feb 17, 10:58 AM · User-Michael, Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T273001: (MS 3) Create Quantity input component.
Wed, Feb 17, 10:56 AM · User-Michael, Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T273796: Create extended number input component.
Wed, Feb 17, 10:55 AM · Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T273796: Create extended number input component.
Wed, Feb 17, 10:47 AM · Wikidata, Wikidata Query Builder
Sarai-WMDE renamed T273796: Create extended number input component from Create number input component to Create extended number input component.
Wed, Feb 17, 10:35 AM · Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T273001: (MS 3) Create Quantity input component.
Wed, Feb 17, 9:29 AM · User-Michael, Wikidata, Wikidata Query Builder

Tue, Feb 16

Sarai-WMDE added a comment to T264760: Tokens: Investigate how to create typography mixins.

Notes & doubts on initial attempt (WIP):

Tue, Feb 16, 3:22 PM · Wikidata Design System, Wikidata
Sarai-WMDE added a project to T268842: Disabled components should display disabled labels: Wikidata Query Builder.
Tue, Feb 16, 12:22 PM · Wikidata Query Builder, Wikidata, Wikidata Design System
Sarai-WMDE updated subscribers of T273046: Allow buttons to be full width.

Sorry for not being more specific! There were yet some decisions to be made when I wrote this ticket. I think that those ("Add condition" and "Run query") are the only two buttons that should become full-width is smaller viewports, looking at @Charlie_WMDE's designs.

Tue, Feb 16, 8:57 AM · Wikidata, Wikidata Query Builder

Mon, Feb 15

Sarai-WMDE renamed T264760: Tokens: Investigate how to create typography mixins from Tokens: Investigate creating typography mixins to Tokens: Investigate how to create typography mixins.
Mon, Feb 15, 12:54 PM · Wikidata Design System, Wikidata
Sarai-WMDE created T274776: [Design] Define responsive behaviour of button groups.
Mon, Feb 15, 11:56 AM · Wikidata, Wikidata Design System
Sarai-WMDE moved T255767: 🎨 Design: Quantity value selector from Ongoing to Done on the Wikidata Design System board.
Mon, Feb 15, 10:39 AM · Wikidata, Wikidata Design System
Sarai-WMDE updated the task description for T272609: fix checkbox issues.
Mon, Feb 15, 9:21 AM · Wikidata, Wikidata Query Builder

Fri, Feb 12

Sarai-WMDE moved T266557: Button components should display hovered state while focused from Needs review to Done on the Wikidata Design System board.
Fri, Feb 12, 3:14 PM · Wikidata, Wikidata Design System

Thu, Feb 11

Sarai-WMDE updated the task description for T273001: (MS 3) Create Quantity input component.
Thu, Feb 11, 2:43 PM · User-Michael, Wikidata, Wikidata Query Builder
Sarai-WMDE updated subscribers of T273795: Investigation: Number input component.

Thanks for the detailed investigation notes! The recommendation to not use the number input sounds sensible. Regarding validation, I lean towards embedding it in the QuantitySelector, since it would make the component reusable "out of the box" in the future, but 1. this is not a core component, so its reusage rate is way lower than that of a button, for example; and 2. I see how that contradicts the validation approach we've been following until now.

Thu, Feb 11, 9:57 AM · User-Michael, Wikidata Query Builder, Wikidata Design System, Wikidata

Wed, Feb 10

Sarai-WMDE raised the priority of T270327: Investigate how to ensure proper spacing between icons and labels in Button from Low to Needs Triage.
Wed, Feb 10, 6:27 PM · Wikidata Design System, Wikidata
Sarai-WMDE added a comment to T273796: Create extended number input component.

Hey, @Volker_E. The simple type=number input seems more convenient whenever users have to perform a single value input instead of modifying a default. We also considered this could be a core input type, on top of which the increment/decrement variant could be created.

Wed, Feb 10, 4:59 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T272958: (MS 5) Create link component.
Wed, Feb 10, 12:35 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T273796: Create extended number input component.
Wed, Feb 10, 10:53 AM · Wikidata, Wikidata Query Builder
Sarai-WMDE created T274346: Add named slot for icon to Design System components with label.
Wed, Feb 10, 10:39 AM · Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T273041: (MS 6) Create popover component.
Wed, Feb 10, 9:58 AM · Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T273041: (MS 6) Create popover component.
Wed, Feb 10, 9:58 AM · Wikidata, Wikidata Query Builder

Tue, Feb 9

Sarai-WMDE updated the task description for T272958: (MS 5) Create link component.
Tue, Feb 9, 3:13 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Sarai-WMDE added a comment to T273795: Investigation: Number input component.

Notes from Itamar's investigation:

Tue, Feb 9, 2:06 PM · User-Michael, Wikidata Query Builder, Wikidata Design System, Wikidata
Sarai-WMDE updated the task description for T273796: Create extended number input component.
Tue, Feb 9, 1:50 PM · Wikidata, Wikidata Query Builder

Mon, Feb 8

Sarai-WMDE updated the task description for T273796: Create extended number input component.
Mon, Feb 8, 6:10 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T273796: Create extended number input component.
Mon, Feb 8, 5:06 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE added a project to T273795: Investigation: Number input component: Wikidata Query Builder.
Mon, Feb 8, 4:51 PM · User-Michael, Wikidata Query Builder, Wikidata Design System, Wikidata
Sarai-WMDE updated the task description for T273001: (MS 3) Create Quantity input component.
Mon, Feb 8, 4:49 PM · User-Michael, Wikidata, Wikidata Query Builder
Sarai-WMDE removed a project from T273795: Investigation: Number input component: Wikidata Query Builder.
Mon, Feb 8, 11:04 AM · User-Michael, Wikidata Query Builder, Wikidata Design System, Wikidata
Sarai-WMDE added a project to T273795: Investigation: Number input component: Wikidata Design System.
Mon, Feb 8, 10:52 AM · User-Michael, Wikidata Query Builder, Wikidata Design System, Wikidata
Sarai-WMDE moved T270327: Investigate how to ensure proper spacing between icons and labels in Button from Incoming to Prioritized on the Wikidata Design System board.
Mon, Feb 8, 10:50 AM · Wikidata Design System, Wikidata
Sarai-WMDE removed a project from T270327: Investigate how to ensure proper spacing between icons and labels in Button: Wikidata Query Builder.
Mon, Feb 8, 10:50 AM · Wikidata Design System, Wikidata
Sarai-WMDE moved T273652: [DS Onboarding] Create new "add" icon component from Prioritized to Done on the Wikidata Design System board.
Mon, Feb 8, 10:44 AM · Wikidata, Wikidata Design System

Wed, Feb 3

Sarai-WMDE updated the task description for T273795: Investigation: Number input component.
Wed, Feb 3, 6:11 PM · User-Michael, Wikidata Query Builder, Wikidata Design System, Wikidata
Sarai-WMDE updated the task description for T273041: (MS 6) Create popover component.
Wed, Feb 3, 5:53 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE renamed T273795: Investigation: Number input component from Investigation: Number component to Investigation: Number input component.
Wed, Feb 3, 5:49 PM · User-Michael, Wikidata Query Builder, Wikidata Design System, Wikidata
Sarai-WMDE moved T273796: Create extended number input component from Backlog to Incoming on the Wikidata Query Builder board.
Wed, Feb 3, 5:48 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE created T273796: Create extended number input component.
Wed, Feb 3, 5:45 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE created T273795: Investigation: Number input component.
Wed, Feb 3, 5:44 PM · User-Michael, Wikidata Query Builder, Wikidata Design System, Wikidata
Sarai-WMDE renamed T272958: (MS 5) Create link component from (MS 5) Create link to (MS 5) Create link component.
Wed, Feb 3, 4:49 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Sarai-WMDE renamed T267807: Document components' validation states from Display components' validation states to Document components' validation states.
Wed, Feb 3, 4:40 PM · Wikimedia Design Style Guide
Sarai-WMDE updated the task description for T267807: Document components' validation states.
Wed, Feb 3, 4:40 PM · Wikimedia Design Style Guide
Sarai-WMDE moved T272958: (MS 5) Create link component from Ready to pick up to Ready for story time on the Wikidata Query Builder board.
Wed, Feb 3, 3:05 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Sarai-WMDE moved T272958: (MS 5) Create link component from Ready for story time to Ready to pick up on the Wikidata Query Builder board.
Wed, Feb 3, 2:35 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Sarai-WMDE moved T273039: investigation: links as components vs. reusable styles [timebox: 1d] from Doing to Done on the Wikidata Query Builder board.
Wed, Feb 3, 1:49 PM · Wikidata Design System, Wikidata Query Builder, Wikidata
Sarai-WMDE updated the task description for T272958: (MS 5) Create link component.
Wed, Feb 3, 1:45 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Sarai-WMDE updated the task description for T272958: (MS 5) Create link component.
Wed, Feb 3, 1:44 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Sarai-WMDE moved T272958: (MS 5) Create link component from Backlog to Ready for story time on the Wikidata Query Builder board.
Wed, Feb 3, 1:33 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Sarai-WMDE added a comment to T273039: investigation: links as components vs. reusable styles [timebox: 1d].

It is entirely possible to instead have a prop that says something like inheritStyles=true or isStandalone=false.

Wed, Feb 3, 1:32 PM · Wikidata Design System, Wikidata Query Builder, Wikidata
Sarai-WMDE added a comment to T273039: investigation: links as components vs. reusable styles [timebox: 1d].

The color of links should never be inherited, exactly; only the font-family, size, weight and line-height of embedded links should be adjusted.

Wed, Feb 3, 11:19 AM · Wikidata Design System, Wikidata Query Builder, Wikidata
Sarai-WMDE added a comment to T273039: investigation: links as components vs. reusable styles [timebox: 1d].

Itamar and I had only an initial discussion on Mattermost, where the working idea of creating the WiKit link as a set of classes rather than as a component was introduced by him. I later brought up that approach to the hike while looking at the Link component ticket together, and detected the need for an investigation tick. I believe that the outcome of this investigation is an excellent starting point! Thanks so much, Bereket and Michael.

Wed, Feb 3, 10:58 AM · Wikidata Design System, Wikidata Query Builder, Wikidata
Sarai-WMDE added a comment to T249840: Where should shared Vue.js UI components live for WMDE and WMF projects?.

Please mind that our design system components (the ones already being used in new applications) actually live in this GitHub repo and this Storybook. You can also find our tokens and all sorts of documentation in both resources.

Wed, Feb 3, 8:17 AM · WVUI, Vue.js, Spike

Tue, Feb 2

Sarai-WMDE renamed T273650: [DS Onboarding] Create new "search" icon component from [DS Onboarding] Create new search icon component to [DS Onboarding] Create new "search" icon component.
Tue, Feb 2, 5:23 PM · Wikidata, Wikidata Design System
Sarai-WMDE created T273652: [DS Onboarding] Create new "add" icon component.
Tue, Feb 2, 5:23 PM · Wikidata, Wikidata Design System
Sarai-WMDE moved T273650: [DS Onboarding] Create new "search" icon component from Incoming to Prioritized on the Wikidata Design System board.
Tue, Feb 2, 5:16 PM · Wikidata, Wikidata Design System
Sarai-WMDE created T273650: [DS Onboarding] Create new "search" icon component.
Tue, Feb 2, 5:16 PM · Wikidata, Wikidata Design System

Feb 2 2021

Sarai-WMDE updated the task description for T272958: (MS 5) Create link component.
Feb 2 2021, 12:14 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Sarai-WMDE created T273609: Review State transitions tokens.
Feb 2 2021, 12:05 PM · Wikidata, Wikidata Design System
Sarai-WMDE updated the task description for T273039: investigation: links as components vs. reusable styles [timebox: 1d].
Feb 2 2021, 11:14 AM · Wikidata Design System, Wikidata Query Builder, Wikidata
Sarai-WMDE added a project to T266688: Evaluate (and implement) variables aka tokens abstraction: Wikidata Design System.
Feb 2 2021, 8:59 AM · Wikidata, Wikidata Design System, Wikimedia Design Style Guide, WikimediaUI-Base, WVUI

Feb 1 2021

Sarai-WMDE updated subscribers of T273041: (MS 6) Create popover component.

@Michael brought up this important question about the popover:

Feb 1 2021, 5:40 PM · Wikidata, Wikidata Query Builder
Sarai-WMDE closed T261650: Provide branch hosting for docs storybook as Resolved.
Feb 1 2021, 4:18 PM · Wikidata, Wikidata Design System
Sarai-WMDE closed T268128: Remove unnecessary tokens as Resolved.
Feb 1 2021, 4:17 PM · Wikidata, Wikidata Design System
Sarai-WMDE closed T271201: Investigate: Adding descriptions to component stories as Resolved.
Feb 1 2021, 4:17 PM · Wikidata Design System, Wikidata
Sarai-WMDE updated the task description for T273041: (MS 6) Create popover component.
Feb 1 2021, 11:31 AM · Wikidata, Wikidata Query Builder
Sarai-WMDE moved T269212: Update Storybook to the latest stable version from Incoming to Prioritized on the Wikidata Design System board.
Feb 1 2021, 11:08 AM · Wikidata, Wikidata Design System
Sarai-WMDE removed a project from T270111: Consider a different font for arabic script: Wikidata Design System.
Feb 1 2021, 10:59 AM · Wikidata, Wikidata Query Builder
Sarai-WMDE moved T273076: Apply line-height medium to OptionMenu descriptions from Incoming to Prioritized on the Wikidata Design System board.
Feb 1 2021, 10:55 AM · Wikidata, Wikidata Design System
Sarai-WMDE closed T256745: 🎨 Design: Table component (SQB) as Declined.
Feb 1 2021, 10:46 AM · Wikidata Design System, Wikidata
Sarai-WMDE moved T267828: Optimize storybook deployment workflow from Needs review to Prioritized on the Wikidata Design System board.
Feb 1 2021, 10:46 AM · Wikidata Design System, Wikidata