Page MenuHomePhabricator

Sarai-WMDE (Sarai Sanchez (WMDE))
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 5 2019, 9:43 AM (137 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Sarai Sánchez (WMDE) [ Global Accounts ]

Recent Activity

Yesterday

Sarai-WMDE updated the task description for T311443: Remove extra spacing at the top of menu item text.
Mon, Jun 27, 6:21 PM · Codex, Design-Systems-Team
Sarai-WMDE created T311443: Remove extra spacing at the top of menu item text.
Mon, Jun 27, 6:16 PM · Codex, Design-Systems-Team
Sarai-WMDE added a comment to T303558: Use CdxTypeaheadSearch in Vector.

I think a different way of thinking of it is: if the entire element is a link, then the title and description text should be blue by default. Instead, we are currently suppressing the link styling in order for the page title to be black and the description gray. With this change we would instead only be suppressing the link styling on the description text (still displaying it in gray). I think from that perspective we are then using less CSS, and overriding the default styling less.

Mon, Jun 27, 5:58 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, Codex
Sarai-WMDE moved T308273: Apply MenuItem selected styles to Menu footer from Design Sign-Off to Functional Testing on the Design-Systems-Team (Design-Systems-Sprint) board.
Mon, Jun 27, 5:21 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE added a comment to T308273: Apply MenuItem selected styles to Menu footer.

Can be signed off, given that the issue detected was fixed in a separate patch.

Mon, Jun 27, 5:20 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE moved T308170: MenuItems should lose highlighted and active states on mouseleave from Design Sign-Off to Functional Testing on the Design-Systems-Team (Design-Systems-Sprint) board.
Mon, Jun 27, 5:19 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE added a comment to T308170: MenuItems should lose highlighted and active states on mouseleave.

Looking and behaving great! This task and T308273 can now be signed off by design after changes were verified in Safari v15.5, Firefox v101 and Chrome v103 on MacOS Monterey.

Mon, Jun 27, 5:19 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE moved T311265: Apply consistent font size to TahS' footer from Design Sign-Off to Functional Testing on the Design-Systems-Team (Design-Systems-Sprint) board.
Mon, Jun 27, 5:15 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE updated subscribers of T311265: Apply consistent font size to TahS' footer.

Thanks for the patch, @AnneT! Changes are looking great in, as always, Safari v15.5, Firefox v101 and Chrome v103 on MacOS Monterey. The task can be signed-off.

Mon, Jun 27, 5:14 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE added a comment to T303558: Use CdxTypeaheadSearch in Vector.

I think that this might be the strongest point against the new navigational menu item styling proposal: the whole menu item is the interactive element here, the one that needs to react to hover and click events, not the title, which is not a link. In the markup, this is expressed by the fact that all the content in menu options (thumbnail, suggestion text) is wrapped in an <a> element. I might be wrong, but moving ahead with the proposal would either involve applying link styling to an element that's technically not a link, or needing to nest two consecutive links with the same href.

Mon, Jun 27, 4:15 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, Codex
Sarai-WMDE updated the task description for T310628: Design and build initial Card component (MVP).
Mon, Jun 27, 3:54 PM · Design-Systems-Team, Codex, Design, Wikimedia Design Style Guide
Sarai-WMDE added a comment to T310630: [TEMPLATE] Design and build initial [ComponentName] component (MVP).

A Figma spec sheet is created for the component that includes the scope defined here. A link to the Figma spec sheet's MVP version has been added to this task's description.

Mon, Jun 27, 3:52 PM · Design-Systems-Team (Design-Systems-Sprint)
Sarai-WMDE renamed T311267: TextInput should have relative heights from TextInputs should have relative heights to TextInput should have relative heights.
Mon, Jun 27, 3:43 PM · Design-Systems-Team (Design-Systems-Sprint), Accessibility, Codex
Sarai-WMDE added a comment to T295711: Move component-specific tokens into the Codex tokens package.

@bmartinezcalvo @Sarai-WMDE Should we also define animation-iteration-count: infinite; as token? It's used for example on ProgressBar.

Mon, Jun 27, 10:46 AM · Design-Systems-Team, Technical-Debt, Patch-For-Review, Codex
Sarai-WMDE added a comment to T311267: TextInput should have relative heights.

Thanks, @Volker_E! While creating the ticket, I also thought this would be solved with the introduction of Codex's spacing tokens, but it seemed necessary to document this in any case just to be safe 🙏🏻

Mon, Jun 27, 10:39 AM · Design-Systems-Team (Design-Systems-Sprint), Accessibility, Codex

Thu, Jun 23

Sarai-WMDE updated the task description for T311115: Codex button should adapt to large font sizes.
Thu, Jun 23, 6:50 PM · Codex, Design-Systems-Team
Sarai-WMDE added a project to T311267: TextInput should have relative heights: Codex.
Thu, Jun 23, 6:44 PM · Design-Systems-Team (Design-Systems-Sprint), Accessibility, Codex
Sarai-WMDE created T311267: TextInput should have relative heights.
Thu, Jun 23, 6:43 PM · Design-Systems-Team (Design-Systems-Sprint), Accessibility, Codex
Sarai-WMDE added a subtask for T297025: Add TypeaheadSearch to Codex: T311265: Apply consistent font size to TahS' footer.
Thu, Jun 23, 6:32 PM · Epic, Design-Systems-Team, Design, Readers-Web-Backlog (Needs Prioritization (Tech)), Codex
Sarai-WMDE added a parent task for T311265: Apply consistent font size to TahS' footer: T297025: Add TypeaheadSearch to Codex.
Thu, Jun 23, 6:32 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE updated the task description for T311265: Apply consistent font size to TahS' footer.
Thu, Jun 23, 6:30 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE added a project to T311265: Apply consistent font size to TahS' footer: Codex.
Thu, Jun 23, 6:29 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE created T311265: Apply consistent font size to TahS' footer.
Thu, Jun 23, 6:29 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE moved T310200: MenuItem: Display placeholder thumbnails before images are loaded from Design Sign-Off to Functional Testing on the Design-Systems-Team (Design-Systems-Sprint) board.
Thu, Jun 23, 1:55 PM · Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, Design, Codex
Sarai-WMDE added a comment to T310200: MenuItem: Display placeholder thumbnails before images are loaded.

Thanks so much, @AnneT 💯 I tested the new implementation using the pending state demo in Safari v15.5, Firefox v101 and Chrome v103 on MacOS Monterey. No issues were found: the placeholder thumbnails replaced the white squares and are displayed while images load. Said images display the agreed upon 100ms opacity-based transition on enter. Seeing also that @Volker_E already provided a +2 in the last patch, I consider reasonable to sign off this ticket from a design point of view.

Thu, Jun 23, 1:54 PM · Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, Design, Codex
Sarai-WMDE moved T308769: Menu: Selected item does not appear highlighted on subsequent menu expansion from Design Sign-Off to Functional Testing on the Design-Systems-Team (Design-Systems-Sprint) board.
Thu, Jun 23, 1:23 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE added a comment to T308769: Menu: Selected item does not appear highlighted on subsequent menu expansion.

The task can be signed-off from a design perspective. The selected/highlighted menu item displays the right styles regardless of the way in which the menu is reopened. Tested in Chrome v103, Safari v15.5 and Firefox v101 on MacOS Monterey.

Thu, Jun 23, 1:10 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE added a comment to T303558: Use CdxTypeaheadSearch in Vector.

Thanks for your reply, @alexhollender_WMF! I think my question should have been phrased differently. Knowing that your team has tested and iterated on the component before, I think the existing TypeaheadSearch has been considered a source of truth. A sort of standard we're aiming for. The change in line-height was a way to try to maintain the same level of scannability in the new component. Therefore my question should have had a more comparative tone, related to the satisfaction of said standards, which already fulfilled by the production component.
I agree with you. In my opinion, the new version makes it easier to parse through the options in the menu. All considered: we weren't planning on conducting any usability testing as part of the implementation of this component, for the reasons stated above, but if we were to introduce (more dramatic) changes to the original designs, it'd then introduce this step in our process.

Thu, Jun 23, 11:59 AM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, Codex

Wed, Jun 22

Sarai-WMDE added a comment to T309256: Spike: Nearby Pages use-case for MenuItem ("Card") Component.

Hey, Readers Web team 👋🏻 Supported by the arguments provided by Anne in the comment above, the Codex team identified the need to introduce a Card component into Codex (See Epic: T278311). We've taken the first steps in that direction and defined the scope of a Card MVP (T310628), which will start to be implemented by our team as soon as the corresponding MVP design specs are finalized.

Wed, Jun 22, 6:54 PM · Codex, Design-Systems-Team
Sarai-WMDE added a comment to T310200: MenuItem: Display placeholder thumbnails before images are loaded.

Regarding the transition's duration: I'm torn! I've been trying both options and, while I like the smoothness of 250ms, I agree that faster loading always feels more efficient. We also recently increased the speed of progress bar animations, so I think we could follow the trend and apply 100ms here. After all, it's @transition-duration-base 👍🏻

Wed, Jun 22, 4:49 PM · Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, Design, Codex
Sarai-WMDE added a comment to T303558: Use CdxTypeaheadSearch in Vector.

Indeed! I forgot to ping you about that, @alexhollender_WMF. The content within options has been grouped a bit more closely (option 3) as a result of a recent patch, as Anne just commented. Please let us know if you think this new version improves scannability to some degree.

Wed, Jun 22, 4:19 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, Codex
Sarai-WMDE added a comment to T308273: Apply MenuItem selected styles to Menu footer.

Behavior and styles are correct in all last versions of Chrome, Firefox and Safari. I detected, though, that the footer's text keeps displaying the active blue color on mouseleave during mousedown. The correct behavior would be for the active styles to be fully removed in that case (see 803610 and T308170: MenuItems should lose highlighted and active states on mouseleave for reference). I'm not sure if this fix should be implemented as part of this same task, or if a separate ticket is needed. Would be happy to create it if so!

Wed, Jun 22, 2:52 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE updated subscribers of T308170: MenuItems should lose highlighted and active states on mouseleave.

Looks great! The only thing that I noticed is that the footer's text keeps displaying an active blue color on mouseleave during mousedown (the problem described by Volker two comments above). These new, consistent active footer styles were introduced by @SimoneThisDot in a recent patch: 805399 (as part of T308273: Apply MenuItem selected styles to Menu footer). Not sure how this fix should be handled or by whom, but let me know in case a separate ticket is needed 🙏🏻

Wed, Jun 22, 2:44 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE moved T306525: MenuItem: Icons and thumbnails should top-align with multiple lines of text from Code Review to Functional Testing on the Design-Systems-Team (Design-Systems-Sprint) board.
Wed, Jun 22, 2:15 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE added a comment to T306525: MenuItem: Icons and thumbnails should top-align with multiple lines of text.

The changes were reviewed in the MenuItem, Select and TypeaheadSearch demos. The alignment between icon and text was correctly maintained under a combination of conditions: increasing the length of item labels to make them wrap, increasing the size of their font, and/or rounding up line height to 1.4 (see comment below). Browsers used: Safari 15.5, Firefox 101 and Chrome v.102.

Wed, Jun 22, 2:04 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE added a comment to T300659: Design Divider component.

Hey Sergio. That sounds really good in my opinion, but I should get back at the Design system team for alignment in order to provide a uniform answer. Will do that asap.

Wed, Jun 22, 10:53 AM · Design-Systems-Team, Design, Codex
Sarai-WMDE renamed T311115: Codex button should adapt to large font sizes from Codex inputs should have relative heights to Codex button should adapt to large font sizes.
Wed, Jun 22, 10:11 AM · Codex, Design-Systems-Team
Sarai-WMDE updated the task description for T311115: Codex button should adapt to large font sizes.
Wed, Jun 22, 9:44 AM · Codex, Design-Systems-Team
Sarai-WMDE added a comment to T311115: Codex button should adapt to large font sizes.
Wed, Jun 22, 9:25 AM · Codex, Design-Systems-Team
Sarai-WMDE updated the task description for T311115: Codex button should adapt to large font sizes.
Wed, Jun 22, 9:22 AM · Codex, Design-Systems-Team
Sarai-WMDE renamed T311115: Codex button should adapt to large font sizes from Make Codex input heights relative to Codex inputs should have relative heights.
Wed, Jun 22, 9:00 AM · Codex, Design-Systems-Team
Sarai-WMDE created T311115: Codex button should adapt to large font sizes.
Wed, Jun 22, 8:58 AM · Codex, Design-Systems-Team

Tue, Jun 21

Sarai-WMDE added a comment to T310200: MenuItem: Display placeholder thumbnails before images are loaded.

I see and share the concern you're describing. The approach makes it look like some images are still pending or 'failed' to load. After giving it some thought, though, I'd say we should still go ahead with this solution, because it's at least an improvement (the white squares really made the component look broken).

Tue, Jun 21, 5:25 PM · Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, Design, Codex
Sarai-WMDE added a comment to T304041: Consider enhancements for Selects and other menus with many items.

Hey @Catrope 👋🏻 I've been forgetting to ask: do you agree that the implementation of a scroll functionality in the Menu component could be a potential solution for this issue? Copying the main functional requirements from that task (T306932) here for visibility:

Tue, Jun 21, 5:08 PM · Design-Systems-Team, Codex
Sarai-WMDE updated the task description for T306932: Add configurable scroll behavior to the Menu component.
Tue, Jun 21, 5:06 PM · Design-Systems-Team, Design, Codex
Sarai-WMDE edited projects for T305947: Define the system's typographic scale (sizes and line-heights), added: Design-Systems-Team (Design-Systems-Sprint); removed Design-Systems-Team.
Tue, Jun 21, 4:24 PM · Design-Systems-Team (Design-Systems-Sprint), Design, Codex
Sarai-WMDE updated the task description for T296998: Define the system's typographic styles and scale.
Tue, Jun 21, 4:24 PM · Design-Systems-Team, Design, Codex
Sarai-WMDE assigned T304423: Update "Component addition process" documentation in Codex Demo to AnneT.
Tue, Jun 21, 4:14 PM · Design-Systems-Team (Design-Systems-Sprint), Documentation, Codex

Mon, Jun 20

Sarai-WMDE updated subscribers of T300659: Design Divider component.

Hi @Sgs! Thanks for sharing your use case. We had doubts regarding the need to incorporate this component into Codex. I originally thought that this could be introduced a styled, reusable <hr> element. Nevertheless, like in the example you shared, these "dividers" are actually implemented as border in most cases (e.g. Wikipedia titles). A far as I can see, we have three alternatives:

Mon, Jun 20, 4:25 PM · Design-Systems-Team, Design, Codex
Sarai-WMDE added a comment to T310200: MenuItem: Display placeholder thumbnails before images are loaded.

Thanks for noticing and for the suggestion, @Volker_E. I agreed with @SimoneThisDot that we could introduce the transition as part of this same task, given that the patch is still active.

Mon, Jun 20, 2:48 PM · Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, Design, Codex
Sarai-WMDE added a comment to T303558: Use CdxTypeaheadSearch in Vector.

Thanks (again) for sharing this really sensible concern, and for already providing solutions, @alexhollender_WMF! 🙏🏻

Mon, Jun 20, 9:41 AM · Readers-Web-Backlog (Kanbanana-FY-2021-22), Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, Codex

Tue, Jun 14

Sarai-WMDE updated the task description for T310628: Design and build initial Card component (MVP).
Tue, Jun 14, 4:25 PM · Design-Systems-Team, Codex, Design, Wikimedia Design Style Guide
Sarai-WMDE claimed T310628: Design and build initial Card component (MVP).
Tue, Jun 14, 3:44 PM · Design-Systems-Team, Codex, Design, Wikimedia Design Style Guide
Sarai-WMDE updated the task description for T310628: Design and build initial Card component (MVP).
Tue, Jun 14, 3:20 PM · Design-Systems-Team, Codex, Design, Wikimedia Design Style Guide
Sarai-WMDE placed T310628: Design and build initial Card component (MVP) up for grabs.
Tue, Jun 14, 3:12 PM · Design-Systems-Team, Codex, Design, Wikimedia Design Style Guide
Sarai-WMDE updated the task description for T310628: Design and build initial Card component (MVP).
Tue, Jun 14, 3:12 PM · Design-Systems-Team, Codex, Design, Wikimedia Design Style Guide
Sarai-WMDE created T310628: Design and build initial Card component (MVP).
Tue, Jun 14, 3:11 PM · Design-Systems-Team, Codex, Design, Wikimedia Design Style Guide

Fri, Jun 10

Sarai-WMDE added a comment to T290733: Results of EntityLookup are not announced to screen reader.

Hi @Lydia_Pintscher! I provided my findings and feedback in the relevant PR after testing the changes locally using VoiceOver (in MacOS, of course).

Fri, Jun 10, 3:14 PM · Special:NewLexeme revival (Special:NewLexeme revival - sprint 10), Wikidata Lexicographical data, Wikidata Design System, Accessibility, Wikidata, Wikidata Query Builder
Sarai-WMDE moved T310213: MenuItem: Apply consistent font-size from Design Sign-Off to Functional Testing on the Design-Systems-Team (Design-Systems-Sprint) board.
Fri, Jun 10, 3:08 PM · Design-Systems-Team (Design-Systems-Sprint), Design, Codex
Sarai-WMDE added a comment to T310213: MenuItem: Apply consistent font-size.

After receiving Alex's thumbs-up (thanks so much for checking! 🙏🏻 ) the changes were verified in the latest versions of Chrome, Safari and Firefox on MacOS Monterey, where everything's looking good. The task can be signed-off from a design pov 👍🏻

Fri, Jun 10, 3:07 PM · Design-Systems-Team (Design-Systems-Sprint), Design, Codex
Sarai-WMDE moved T307770: Items in "Menu with custom menu item display" demo should display right styling from Design Sign-Off to Functional Testing on the Design-Systems-Team (Design-Systems-Sprint) board.
Fri, Jun 10, 2:48 PM · Design-Systems-Team (Design-Systems-Sprint)
Sarai-WMDE added a comment to T307770: Items in "Menu with custom menu item display" demo should display right styling.

This task is ready for design sign-off: all available options in the"Menu with custom menu item display" demo now present the right styling for the hovered/highlighted, active and selected states. Tested in the latest versions of Chrome, Firefox and Safari on MacOS Monterey.

Fri, Jun 10, 2:48 PM · Design-Systems-Team (Design-Systems-Sprint)
Sarai-WMDE placed T305920: Define the system's sans, serif and monospace typefaces up for grabs.
Fri, Jun 10, 2:40 PM · Design-Systems-Team (Design-Systems-Sprint), Epic, Design, Codex
Sarai-WMDE moved T305920: Define the system's sans, serif and monospace typefaces from Functional Testing to Product Sign-Off on the Design-Systems-Team (Design-Systems-Sprint) board.
Fri, Jun 10, 2:40 PM · Design-Systems-Team (Design-Systems-Sprint), Epic, Design, Codex
Sarai-WMDE moved T305920: Define the system's sans, serif and monospace typefaces from Design Sign-Off to Functional Testing on the Design-Systems-Team (Design-Systems-Sprint) board.
Fri, Jun 10, 2:40 PM · Design-Systems-Team (Design-Systems-Sprint), Epic, Design, Codex
Sarai-WMDE added a comment to T305920: Define the system's sans, serif and monospace typefaces.

The typefaces' proposal was presented to the Product design team, and shared and reviewed by the members of the Pattern lab team. Feedback was received and acted upon. The current documentation in Figma (access the Typography exploration file here) will need to be adjusted in case we decide to update the CSS font stack to reflect the latest design choices. This possibility is captured in T309158: Update Wikimedia Design Style Guide with typeface choices.

Fri, Jun 10, 2:28 PM · Design-Systems-Team (Design-Systems-Sprint), Epic, Design, Codex
Sarai-WMDE placed T307001: Thumbnail component icon shouldn't change color on select up for grabs.
Fri, Jun 10, 2:15 PM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE placed T300565: Design and build dropdown Menu component up for grabs.
Fri, Jun 10, 2:14 PM · Design-Systems-Team (Design-Systems-Sprint), Design, Codex
Sarai-WMDE moved T305396: Create a configurable demo for MenuItem from Design Sign-Off to Functional Testing on the Design-Systems-Team (Design-Systems-Sprint) board.
Fri, Jun 10, 2:14 PM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
Sarai-WMDE added a comment to T305396: Create a configurable demo for MenuItem.

This is nice! It would be great if we could make the configurable MenuIntem interactive. So it would display the selected, active and highlighted states, instead of presenting them in the table. But I believe this is conditioned by the current implementation approach, so all good and ready for sign-off.

Fri, Jun 10, 2:13 PM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
Sarai-WMDE updated subscribers of T310213: MenuItem: Apply consistent font-size.

No problem at all, @AnneT!

Fri, Jun 10, 2:05 PM · Design-Systems-Team (Design-Systems-Sprint), Design, Codex
Sarai-WMDE added a comment to T306525: MenuItem: Icons and thumbnails should top-align with multiple lines of text.

Thanks so much for the detailed explanation and screenshots! Definitely this change makes the issue more apparent, but not scaling icons was going to cause problems whenever font sizes are modified, regardless of alignment

Fri, Jun 10, 11:36 AM · Design-Systems-Team (Design-Systems-Sprint), Codex

Thu, Jun 9

Sarai-WMDE closed T308866: Apply responsive behavior to TypeaheadSearch menu, a subtask of T300565: Design and build dropdown Menu component, as Declined.
Thu, Jun 9, 6:25 PM · Design-Systems-Team (Design-Systems-Sprint), Design, Codex
Sarai-WMDE closed T308866: Apply responsive behavior to TypeaheadSearch menu, a subtask of T297025: Add TypeaheadSearch to Codex, as Declined.
Thu, Jun 9, 6:25 PM · Epic, Design-Systems-Team, Design, Readers-Web-Backlog (Needs Prioritization (Tech)), Codex
Sarai-WMDE closed T308866: Apply responsive behavior to TypeaheadSearch menu as Declined.

The Readers Web and Design System teams agreed to let this responsive behavior be handled by Vector, and to not introduce it in the Codex TypeaheadSearch component at this point in time.

Thu, Jun 9, 6:24 PM · Codex, Design-Systems-Team
Sarai-WMDE added a comment to T308866: Apply responsive behavior to TypeaheadSearch menu.

Minor adjustment: I don't have Volker-vision, but I think the bottom-end border radius for the button will need to be set to 0 in this case

Thu, Jun 9, 6:11 PM · Codex, Design-Systems-Team
Sarai-WMDE updated the task description for T308866: Apply responsive behavior to TypeaheadSearch menu.
Thu, Jun 9, 5:47 PM · Codex, Design-Systems-Team
Sarai-WMDE added a comment to T310213: MenuItem: Apply consistent font-size.

The regular label has line-height: 1.6, while the search-query label has line-height: normal plus a 2px margin-bottom. Should these be consistent, too? This would result in a slightly different look in TypeaheadSearch, which makes me think that we should maintain the current search-query line height but move those styles to TypeaheadSearch since they seem to be specific to that component.

Thu, Jun 9, 5:19 PM · Design-Systems-Team (Design-Systems-Sprint), Design, Codex
Sarai-WMDE updated the task description for T310213: MenuItem: Apply consistent font-size.
Thu, Jun 9, 1:50 PM · Design-Systems-Team (Design-Systems-Sprint), Design, Codex
Sarai-WMDE added a comment to T306525: MenuItem: Icons and thumbnails should top-align with multiple lines of text.

The comments were tackled (thanks as always, Bárbara!) and the branch was merged. I added a link to the relevant design specs in the task's description.

Thu, Jun 9, 11:56 AM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE updated the task description for T306525: MenuItem: Icons and thumbnails should top-align with multiple lines of text.
Thu, Jun 9, 11:55 AM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE added a subtask for T301275: Design and build indeterminate inlineProgressBar: T306655: Add inline ProgressBar to TypeaheadSearch.
Thu, Jun 9, 11:48 AM · Design-Systems-Team (Design-Systems-Sprint), Design, Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board), Codex
Sarai-WMDE added a parent task for T306655: Add inline ProgressBar to TypeaheadSearch: T301275: Design and build indeterminate inlineProgressBar.
Thu, Jun 9, 11:48 AM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE added a subtask for T300652: Design Thumbnail component: T307001: Thumbnail component icon shouldn't change color on select.
Thu, Jun 9, 11:47 AM · Design-Systems-Team, Design, Codex
Sarai-WMDE added a parent task for T307001: Thumbnail component icon shouldn't change color on select: T300652: Design Thumbnail component.
Thu, Jun 9, 11:47 AM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE added a subtask for T300625: Add MenuItem component to Codex and TypeaheadSearch component: T303631: Fix text styles for menu items in TypeaheadSearch on keyboard navigation.
Thu, Jun 9, 11:45 AM · Design-Systems-Team, Patch-For-Review, Design, Codex
Sarai-WMDE added a parent task for T303631: Fix text styles for menu items in TypeaheadSearch on keyboard navigation: T300625: Add MenuItem component to Codex and TypeaheadSearch component.
Thu, Jun 9, 11:45 AM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE added a subtask for T300625: Add MenuItem component to Codex and TypeaheadSearch component: T304454: Set color of MenuItem label text in its base state.
Thu, Jun 9, 11:44 AM · Design-Systems-Team, Patch-For-Review, Design, Codex
Sarai-WMDE added a parent task for T304454: Set color of MenuItem label text in its base state: T300625: Add MenuItem component to Codex and TypeaheadSearch component.
Thu, Jun 9, 11:44 AM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE added a parent task for T308170: MenuItems should lose highlighted and active states on mouseleave: T300565: Design and build dropdown Menu component.
Thu, Jun 9, 11:42 AM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE added a subtask for T300565: Design and build dropdown Menu component: T308170: MenuItems should lose highlighted and active states on mouseleave.
Thu, Jun 9, 11:42 AM · Design-Systems-Team (Design-Systems-Sprint), Design, Codex
Sarai-WMDE added a subtask for T300565: Design and build dropdown Menu component: T308769: Menu: Selected item does not appear highlighted on subsequent menu expansion.
Thu, Jun 9, 11:40 AM · Design-Systems-Team (Design-Systems-Sprint), Design, Codex
Sarai-WMDE added a parent task for T308769: Menu: Selected item does not appear highlighted on subsequent menu expansion: T300565: Design and build dropdown Menu component.
Thu, Jun 9, 11:40 AM · Design-Systems-Team (Design-Systems-Sprint), Codex
Sarai-WMDE added a subtask for T300625: Add MenuItem component to Codex and TypeaheadSearch component: T305091: [TypeaheadSearch] Support lang and dir attributes for text nodes within MenuItem component.
Thu, Jun 9, 11:40 AM · Design-Systems-Team, Patch-For-Review, Design, Codex
Sarai-WMDE added a parent task for T305091: [TypeaheadSearch] Support lang and dir attributes for text nodes within MenuItem component: T300625: Add MenuItem component to Codex and TypeaheadSearch component.
Thu, Jun 9, 11:40 AM · Design-Systems-Team (Design-Systems-Sprint), Wikidata, Codex
Sarai-WMDE added a subtask for T300565: Design and build dropdown Menu component: T308866: Apply responsive behavior to TypeaheadSearch menu.
Thu, Jun 9, 11:40 AM · Design-Systems-Team (Design-Systems-Sprint), Design, Codex
Sarai-WMDE added a parent task for T308866: Apply responsive behavior to TypeaheadSearch menu: T300565: Design and build dropdown Menu component.
Thu, Jun 9, 11:40 AM · Codex, Design-Systems-Team
Sarai-WMDE added a subtask for T297025: Add TypeaheadSearch to Codex: T300625: Add MenuItem component to Codex and TypeaheadSearch component.
Thu, Jun 9, 11:37 AM · Epic, Design-Systems-Team, Design, Readers-Web-Backlog (Needs Prioritization (Tech)), Codex
Sarai-WMDE added a parent task for T300625: Add MenuItem component to Codex and TypeaheadSearch component: T297025: Add TypeaheadSearch to Codex.
Thu, Jun 9, 11:37 AM · Design-Systems-Team, Patch-For-Review, Design, Codex

Wed, Jun 8

Sarai-WMDE created T310213: MenuItem: Apply consistent font-size.
Wed, Jun 8, 6:25 PM · Design-Systems-Team (Design-Systems-Sprint), Design, Codex