I think we can resolve this ticket now. Let us know if the error happens again!

Lowering the priority because this seems to be fixed and is no longer broken.

Hot fix commit link: https://github.com/WikipediaLibrary/TWLight/commit/7f58e1595e5822544806f2570d7e9c9ca4651ffb

I have been playing around with the patch, and I can't trigger the error for the To Date field, even when I set a date way into the future.

The upvoters have been sent privately to the interested parties!

Let's do that!

In T380846#10428567, @Ladsgroup wrote:

The RC purge is random based on edits done or maint scripts. You should either run PurgeRecentChanges or make enough edits that RecentChangesUpdateJob::newPurgeJob() get queued (see this section in RecentChanges class):

		// Flush old entries from the `recentchanges` table
		if ( mt_rand( 0, 9 ) == 0 ) {
			$jobs[] = RecentChangesUpdateJob::newPurgeJob();
		}

this is called in Recentchanges::save()

I have been testing this locally, and I am getting unexpected behavior:

Do you think this might be a Discussion Tools API error rather than something on our side?

@Amire80, this has been merged and will be deployed in the next few minutes. Please let us know if the changes appear ready for translation.

It looks like the error message shows on the confirmation page.

Thanks for working on this, Chlod! I have a couple of comments UI-wise. While clicking around the UI, I noticed the error message when you input an incorrect date is not showing. I know it is not optimal to have duplicated code with Codex around the corner, but the validation messages are needed to provide context.

The edit was an undo so there is null content on the revision record (Is this true?)

I agree we could remove the final step in this (already big) ticket and place it in T370787: Wikilink batch inserts.

I've played around with the Wikilink admin and it's faster and I've had not problems loading any individual link event. Moving this back to Ready for the next steps.

I clicked around the production version and it all seems to be working for me.

In T380297#10396049, @Samwalton9-WMF wrote:

I still think this is the better choice of the two users to pick in this case. I'm open to discussing further, so perhaps we should merge this patch and then file a followup ticket to explore further. This new layout is blocking other work so let's perfect it after merging.

Thanks for the feedback! I'll do that.

I have played around with the code in Patch Demo and locally and everything seems to be working fine! My only concern/UI question is similar to the bug that @stjn found and got fixed.

I can see this feature has rolled out on testwiki. I cannot test if it has rolled out to other wikis.

I can verify that this bug no longer appears in NPP in the enwiki. If the issue occurs again, please reopen this ticket or create a new one.

It seems this patch has already rolled out on a train. Resolving it because it didn't break anything and we can't really QA it.

The username text box no longer overlaps in enwiki.

We also discussed that jobs may not be the best or only way of tracking Nuke deletions - an alternative could be to look at the queued pages and check whether they still exist.

This change in core probably affected our tests: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/030a196d80681570cd89da9125cbc6243a95040f%5E1..030a196d80681570cd89da9125cbc6243a95040f/. We should take a look at it and change our tests accordingly.

In T381282#10386877, @Kgraessle wrote:

This is ready to review, but I'm seeing some strange new CICD failures that are not showing up locally when I run the tests.

@Samwalton9-WMF, should we wait until we hear back from Product Analytics before we continue to review/merge the patch? If so, we should mark it as stalled until we have an answer.

I created a PatchDemo with the latest patchset so you can test it there, @Samwalton9-WMF.

This patch is now ready for review! I also fixed the same bug that was happening in AFC.

Thank you for clarifying, Sam! This then looks good on test wiki. We can resolve it now or wait until you QA on enwiki. 😄

@Chlod, we have QA'ed your patch on test wiki and we have noticed that the user actions do not show up whenever we mass delete pages where we leave the user/IP field blank. Here is a screenshot for reference.