It's working now! I missed the SQLite schema change file in my initial review.

I commented on the Gerrit patch. It seems like you modified ptrp_reviewed_updated instead of prtp_tags_updated. Also, no SQLite update script was created because apparently the ALTER TABLE statement support in SQLite is minimal. We can try to create a new table with that field NULL by default, adding the data from the old table, and then dropping the old table.

I have a few questions on how to proceed with this ticket:

This has been merged!

This is no longer stalled :)

Moving it to Done since the relevant patches have been merged.

From what I can see in the logs, the query is an INSERT OR IGNORE query. That's why it fails silently.

After following @kostajh's advice to use MySQL instead of SQLite, I found the error that keeps data from being inserted into the pagetriage_page table:

What does $wgPageTriageNamespaces look like in shell.php?

@kostajh Have you had this issue where no new pages are showing up in Special:NewPagesFeed in your local environment?

I see that a Add to the New Pages Feed link has been added to the page toolbar on the right of my screen. I press it and it returns a success message. However, I still don't see the articles in Special:NewPagesFeed and there are no entries in the database.

Comparing some Ajax requests between my local environment and en.wiki, I see that my local environment throws some warnings about unrecognized parameters and the date format is different. This might be the reason articles are not showing. I'll take a look at how dates are stored in articles to see if there is something there.

I see the tables in the database, but no information in them except for pagetriage_tags.

I cloned and added all configurations for PageTriage in the LocalSettings file. I created several new pages as an anonymous and logged-in user. They all appear in RecentChanges but none appear in Special:NewPagesFeed.

Thanks, Leon! :) It seems like it's the same error for us.

Can confirm the Wikipedia Library's error is the same: Error: No token was found matching your request.

@MusikAnimal do you know in what part of the code the authentication breaks? The Wikipedia Library's authentication seems to be breaking here: https://github.com/mediawiki-utilities/python-mwoauth/blob/master/mwoauth/functions.py#L193

There are some editors who still cannot log in to their Wikipedia Library account (T332349). We are using mwoauth for authentication.

Can you erase your Wikipedia Library cookies and session, and try again?

Thanks for the feedback! The .mw-prefs-title in noJS and the dialog header bug have been fixed. I am taking a look at the screenreader reading the name and description twice.

It looks to be working in production. @HouseBlaster @jsn.sherman can you please confirm?

Pushing to prod!

Can you try again? It's working for me now.

GitHub PR: https://github.com/WikipediaLibrary/twlight_ezproxy/pull/32

Flagged for preprod!

On it!

Merged!

tab-navigating between sections is now working beautifully for me, though I still can't open a section with my keyboard.

Thanks for the information in the link! I'll try adding that and get to you when I have something working.

I can only open the dialogs with a mouseclick.

GitHub PR: https://github.com/WikipediaLibrary/TWLight/pull/1117

Pushed to prod! Users who still are experiencing issues should delete their cookies to solve it.

Quick question, @Samwalton9: do you think the Corriere della Sera archives also needs those filed added?

PR has been merged!

@jsn.sherman I just created a Patch Demo so you can test the changes on Orca and other tools :)

Ok, I'll also change it in production. Flagged for prod!

Flagged for prod!

Flagged for prod!

Flagged for prod!

Hi @Samwalton9! I changed the target URL from https://dukeupress.edu/ to https://read.dukeupress.edu to match https://help-es.oclc.org/Library_Management/EZproxy/Database_stanzas/Duke_University_Press_Books_and_Journals. Is this correct, or should I change it back?

Flagged for preprod!

Flagged for preprod!

Flagged for preprod!

Flagged for preprod again!

Moving this back to the Ready column while we wait for answers from Newspapers.com.

2. Whenever I refresh the desktop layout with a highlighted hash, the subsection of the hash disappears. I don't think this is the intended behavior.

Hi @jsn.sherman! I have been reviewing your change request on Gerrit and have a couple of comments and questions:

GitHub PR: https://github.com/WikipediaLibrary/TWLight/pull/1094

The last patch has been merged!

Yeah, I also noticed that. @jsn.sherman, do you think this is something Newspapers.com need to solve on their end, or is there something we need to do?

Link for getPreferences search: https://codesearch.wmcloud.org/search/?q=function%20onGetPreferences&i=nope&files=&excludeFiles=&repos=

Flagged for preprod!

Flagged for preprod!

I have also updated the MediaWiki documentation to reflect the changes made by these patches.