Thanks, @Jdlrobson! I am removing some functions that appear to be unused in the code and removing one of the MenuEntry classes so that there is only one class to rule them all :)

I have a question. It seems there are two ways to insert a menu item: with insert and insertEntry. These functions add from different classes SingleMenuEntry and MenuEntry, which are very similar. Is there a reason why some items are inserted with insertEntry? Would it be part of the scope to unify these classes?

Both patches have been merged. Moving to Done.

Thank you for the very thorough QA @Djackson-ctr! :)

I think I got a solution working that is a combination of both patches. Patch Demo incoming...

Yes, here are some credentials you can use:

I have created a Patch Demo to test the changes I made and they seem to be working for Vector, Monobook, Timeless, and Minerva.

Merged https://github.com/WikipediaLibrary/TWLight/pull/1011. If there is nothing more to do, we can move this to the Done column

This is ready for review!

Hi @Samwalton9! I have created a Patch Demo for you and the team to look at the changes. This is ready for review.

@jsn.sherman, upon further inspection, the code already excludes a secondary suggestion if it's also the main suggestion. Moving this back to Review.

Pushed the suspend.htm file and the pre-ASHA files to preprod.

Based on the meeting today, I will add a guard clause to prevent a suggestion to merge itself.

This is ready for another review

GitHub PR: https://github.com/WikipediaLibrary/TWLight/pull/1008

GitHub PR: https://github.com/WikipediaLibrary/TWLight/pull/1005

Looks like the Overflow menu is being added here: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/skins/MinervaNeue/+/refs/heads/master/includes/ServiceWiring.php#120. The TOOLBAR_SUBMENU option is a skin option that is set in /includes/SkinOptions.php in the MinervaNeue repository.

GitHub PR: https://github.com/WikipediaLibrary/twlight_ezproxy/pull/22

Hi @Ankit18gupta! How are you doing with this ticket? Do you need any additional help, or are you not available to work on this?

Merged!

I changed the order and placed the ASHA configuration after Wiley and have pushed it to preprod. Hope this works!

Based on what was discussed in the engineering meeting, I have made the changes and pushed them to preprod.

Flagged for preprod! GitHub PR: https://github.com/WikipediaLibrary/twlight_ezproxy/pull/21

Thanks for the additional info @Samwalton9 and for answering the questions @jsn.sherman!

What steps would be required to add a Block link to the overflow menu?

To solve this issue, you will need to add a new context_data key/value pair, just like you added one in PR #956. The template variable you added does not exist anywhere, that is why you have to add it to get_context_data (https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/views.py#L34).

GitHub PR: https://github.com/WikipediaLibrary/TWLight/pull/997

Flagged for prod! Moving this task to the Review column.

GitHub PR: https://github.com/WikipediaLibrary/twlight_ezproxy/pull/20

Flagged for preprod!

In T303038#7863886, @Samwalton9 wrote:

I set this live on production but when I go to access it (https://wikipedialibrary.idm.oclc.org/login?auth=production&url=https://www.spiedigitallibrary.org/) the proxy seems to be timing out.

I can access the website directly (outside of proxy) no problem, and other proxied URLs work.

Flagged for prod! Moving to the Review column.

Flagged for preprod. GitHub PR: https://github.com/WikipediaLibrary/twlight_ezproxy/pull/19

Flagged for prod!

Flagged for preprod! GitHub PR: https://github.com/WikipediaLibrary/twlight_ezproxy/pull/18

Flagged for prod!

Flagged for preprod! GitHub PR: https://github.com/WikipediaLibrary/twlight_ezproxy/pull/17

Flagged for prod!

Flagged for preprod!

My bug fix PR: https://github.com/WikipediaLibrary/TWLight/pull/987

Flagged for prod! Moving to the Review column.

Flagged for preprod!

Flagged for prod. Moving to Review

Since this has been merged, I'm moving this to the Review/Feedback column.

Changes have been made and pushed to preprod!

Merged!

Merged!

In T302704#7822201, @jsn.sherman wrote:

@Scardenasmolinar it looks like the most recent preprod flag got uploaded as flag.prerpod instead of flag.txt I went ahead and renamed it as a first step to troubleshoot this issue. We should have a preprod deploy in a few minutes, though I'm not sure of what's currently deployed.

Flagged for preprod!

I can set up the patch demo as soon as there is a Gerrit patch :)

Merged! Thank you for your contribution.

Merged! Thank you for your contribution!

In T302704#7791926, @Samwalton9 wrote:

Are these on prod?

Flagged for prod! Moving to the Review column.