Thanks for taking over this patch! I just have one small nit:

This ticket is stalled until we get new/updated designs

This was probably introduced in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/5396736ce299705821cdb25c814dfd39f475d9fc

After reducing the buttons' sizes to small and moving the username and edit count higher, the footer looks better, but it's still a tight fit.

I am running out of space in the footer without having to increase the footer's height.

Maybe we can use a codex popover that says See user rights and display them there?

I have made some changes and went for an ellipsis. I think the real estate user rights occupy now decrease and look better, even though some information is now obscured. Let me know what you think! I will push these changes and update the patch demo.

In T357352#11281660, @jsn.sherman wrote:

In T357352#11266005, @Scardenasmolinar wrote:

Can the user groups remain as-is, since changing them is outside the scope of this ticket? We can discuss this further on T402297: It should be possible to undo edits on mobile, where a redesign is planned, and the user groups may occupy a significant portion of the mobile footer. This ticket wants to keep as close to the current design as possible.

I'm sorry to say that I agree with Jon on this one; the design is a problem if it requires removing this info to fix the display bug. I think we should be sticking as close to the in-production design as possible while fixing the bug. Larger layout changes should probably go with T402297.

If that's not feasible; then I suggest we stall this task on the other one (or make it a child task) and fix both in one go in that task.

Patch has been reverted. Waiting for changes to be made before testing again

This task does not have any pending changes to be merged, so I am moving it over to QA.

Can the user groups remain as-is, since changing them is outside the scope of this ticket? We can discuss this further on T402297: It should be possible to undo edits on mobile, where a redesign is planned, and the user groups may occupy a significant portion of the mobile footer. This ticket wants to keep as close to the current design as possible.

In T357352#11265589, @Jdlrobson wrote:

In T357352#11265385, @OTichonova wrote:

Hi @Scardenasmolinar. Are the user groups a vital part of the card? If not, I wouldn't keep them, as the elements in the card are taking up a lot of the screen.

cc @Samwalton9-WMF

As a volunteer I can say I personally find them useful indicators about the experience of the editor. This is particularly useful in talk page conversations (it's good to know if I am talking to a newbie vs an admin).

I suspect you might see some backlash from mobile editors if you were to removal them altogether but it is hard to know how strong :)

If you wanted to be more conservative perhaps you could put them behind an overlay or use an ellipsis/horizontal scrollbar to cut them off?

I've pushed some changes that remove the overlap between user groups and the user link. However, there is a significant gap when a user has only a few user groups. Based on the new designs of the footer, it appears that we will not be including the user groups. Can you confirm, @OTichonova? @Jdlrobson-WMF, how important are the user groups information-wise? Do you think it is critical to include all user groups, or can we hide some of them when they are numerous?

We are planning on redesigning the Diff footer on mobile to incorporate more elements like the undo button. These are the design mocks: {T402297#11221166}. We are also refactoring how the mobile Diff footer is built because of a bug in Visual Diff that obscures the Thank button: T357352: Thanks button is obscured on mobile diffs in visual diff mode.

This is ready for engineer + design review!

I took the liberty of moving the Thank button a little bit because of a comment made in another Phab task (https://phabricator.wikimedia.org/T402297#11247391). Note that the thank button's style is changed because I had https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Thanks/+/1192650 checked out when I made the screenshots. These patches do not deal with changing the Thankbutton's styling

Hi @tstarling! I have found a couple of bugs while testing your changes in patch 1191646.

Thanks for pointing those errors out!

I checked on enwiki in Firefox Desktop, and the thanks button is showing up, but it's not showing up in Safari.

In T357352#11240415, @Samwalton9-WMF wrote:

In T357352#11234670, @jsn.sherman wrote:

We noticed this on an iPhone SE 2020

, but haven't been able to reproduce elsewhere; looking into it

Where was this happening, test.wiki, or in a patch demo?

Can't reproduce on an iPhone 11 in Safari, for users with short or long usernames, in Visual or Wikitext diffs, on test.wikipedia.org.

Update: I deleted my local environment and Git fork, then recreated them, and I am no longer getting that error.

I might be getting the backup from a different directory, maybe? Let's go over the backup from production process tomorrow in our engineering meeting. Meanwhile, I think we can move this ticket to Done and resolve it.

I am still seeing the same error in my local environment,

In T405925#11230954, @jsn.sherman wrote:

@Scardenasmolinar This does look to be a local overlay fs driver issue to me; I did quite a bit of troubleshooting locally, and so far switching to a bind mount is the only thing that's fixed it. You and I were seeing somewhat different errors, so I was wondering if you could try running a restore in my test branch?
https://github.com/WikipediaLibrary/externallinks/tree/Jsn.sherman/T405925

In T402297#11221166, @OTichonova wrote:

Hi @Scardenasmolinar!

Here are the designs:
They are a little bit different to the ones we discussed in RTL . Since having the buttons side by side might be tricky for languages that have really long names for the actions (ml wiki example below).

Card en	Card ml	Mobile en	Mobile ml

cc @Samwalton9-WMF

Moving this back to in progress to reflect that I am working on showing the undo button to registered users and waiting on final designs to move this forward. This task is also no longer dependent on the Thank button fix (which is ready for engineering review).

I did notice that the elements are very close together now, so we may want to add some spacing.

when you switch to Visual diff mode both the Undo and Thank buttons disappear for some reason - this shouldn't happen.

I have added the undo link below the thank button instead of beside it. Let me know what you think, @OTichonova. I placed it there because, if I put it inline with the thank button, it would look crowded on narrow cellphones when the rollback option appears (see screenshots below to see how my changes look). I will create a PatchDemo so you can test it on your mobile phone.