Page MenuHomePhabricator

Schnark (Michael M.)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 7:11 AM (259 w, 1 h)
Availability
Available
LDAP User
Unknown
MediaWiki User
Schnark [ Global Accounts ]

Recent Activity

Tue, Sep 17

Schnark added a comment to T227564: Menu of DropdownWidget with $overlay has padding at bottom.

BTW, this doesn't happen for $overlay: true (and the code where I used the body as overlay predates the default overlay), so there is an easy workaround.

Tue, Sep 17, 7:56 AM · OOUI

Sat, Sep 14

Schnark added a comment to T232601: Provide a mechanism for in-surface autocomplete.

I have a script for autocomplete suggestions (not for @user, but for words already in the text): https://de.wikipedia.org/wiki/Benutzer:Schnark/js/veSuggestions.js
(German) documentation (including screenshot) is on https://de.wikipedia.org/wiki/Benutzer:Schnark/js/veSuggestions
If you want to reuse any code from there, feel free to do so.

Sat, Sep 14, 9:40 AM · OWC2020, VisualEditor (Current work)

Mon, Sep 9

Schnark updated subscribers of T232285: How to use Babel.js with MediaWiki Javascript.

With a PHP port of babel.js (or some wrapper) this should be possible in theory, but:

Mon, Sep 9, 7:25 AM · MediaWiki-ResourceLoader, Performance-Team

Aug 23 2019

Schnark added a comment to T231031: Instrument usage of ISBN barcode scanner.

what sort of things they scan (presumably: 99.9% books, but let's confirm that)

The tool only reads ISBNs, which stands for International Standard Book Number[0], so...

Aug 23 2019, 7:05 AM · VisualEditor (Current work), Citoid

Aug 20 2019

Schnark created T230782: Link list on ApiSandbox looks silly.
Aug 20 2019, 10:07 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Schnark closed T135489: Special:Contributions in newbie mode shouldn't use old definition of newbie as Declined.

Feature removed with T220447: Split out or remove Special:Contributions/newbies functionality.

Aug 20 2019, 9:43 AM · MediaWiki-Special-pages

Aug 16 2019

Schnark added a comment to T181484: Links to sections in an article will land behind unscrollable header in older browsers.

According to https://caniuse.com/#feat=css-snappoints this should also work in Safari (which I didn't test), and it will work in Edge once they switch to Blink.

Aug 16 2019, 7:16 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Timeless

Aug 13 2019

Schnark added a comment to T230395: Unreachable item in a long list outside of the bodycontent div.

See T182602 and https://www.mediawiki.org/wiki/OOUI/Concepts#Overlays.

Aug 13 2019, 9:48 AM · WikibaseMediaInfo, UploadWizard
Schnark created T230393: Arrow in DateInputWidget vanishes on hover.
Aug 13 2019, 7:26 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MediaWiki-General

Aug 6 2019

Schnark added a comment to T226476: wgUserNewMsgRevisionId is null even when there are new messages.

BTW, this also happens for users not logged in (though I'm not entirely sure whether the variable should be set in for those users, too, but I don't see a reason why not).

Aug 6 2019, 7:02 AM · MediaWiki-General

Aug 5 2019

Schnark updated subscribers of T229734: Convert button doesn't display since wmf.16.

Since this works in mobile editor, I'm going to blame rECEX46014698791a: Move convert ref button to footer when the footer exists (even though that is wmf.16, not wmf.15).

Aug 5 2019, 7:31 AM · Skipped QA, VisualEditor (Current work), Citoid
Schnark created T229781: Editing fails when section is deleted.
Aug 5 2019, 7:19 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Schnark added a project to T229734: Convert button doesn't display since wmf.16: Citoid.
Aug 5 2019, 7:05 AM · Skipped QA, VisualEditor (Current work), Citoid

Aug 2 2019

Schnark added a comment to T229592: citoid dosen't work at Hindi Wikipedia.

The console shows the following warning:

Aug 2 2019, 7:21 AM · User-Ryasmeen, VisualEditor, Citoid

Aug 1 2019

Schnark added a comment to T229467: Investigate how visual diffs differ performance can be optimized .

A cheap “fix” that might be worth investigating is seeing whether we can pack the entire thing into a Web Worker (what’s a web worker?), thus getting it off the main thread even if it doesn’t speed it up in any way.

Aug 1 2019, 7:28 AM · VisualEditor (Current work)
Schnark added a comment to T229307: Reference numbers wrong in Firefox when following a list.

And now I found https://bugzilla.mozilla.org/show_bug.cgi?id=1545746, which already is closed as invalid.

Aug 1 2019, 7:17 AM · Upstream, VisualEditor, VisualEditor-MediaWiki-References, Browser-Support-Firefox

Jul 31 2019

Schnark merged T229373: For some HTML entities, the edit preview incorrectly shows the interpreted value (e.g. "[") but the saved edit shows "[" into T94603: Unexpanded HTML character entity references.
Jul 31 2019, 8:00 AM · MediaWiki-Parser
Schnark merged task T229373: For some HTML entities, the edit preview incorrectly shows the interpreted value (e.g. "[") but the saved edit shows "[" into T94603: Unexpanded HTML character entity references.
Jul 31 2019, 8:00 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Schnark added a comment to T229307: Reference numbers wrong in Firefox when following a list.

After reading https://drafts.csswg.org/css-lists-3/#list-item-counter: This might actually be the expected behavior (but I'm not going to encourage Firefox devs by making that comment on Bugzilla), and the correct workaround is counter-reset: mw-ref-linkback list-item.

Jul 31 2019, 7:14 AM · Upstream, VisualEditor, VisualEditor-MediaWiki-References, Browser-Support-Firefox

Jul 30 2019

Schnark added a comment to T229307: Reference numbers wrong in Firefox when following a list.

I was able to reduce it to a minimal example, and reported this upstream as https://bugzilla.mozilla.org/show_bug.cgi?id=1569886.

Jul 30 2019, 7:51 AM · Upstream, VisualEditor, VisualEditor-MediaWiki-References, Browser-Support-Firefox
Schnark created T229307: Reference numbers wrong in Firefox when following a list.
Jul 30 2019, 7:30 AM · Upstream, VisualEditor, VisualEditor-MediaWiki-References, Browser-Support-Firefox

Jul 19 2019

Schnark added a comment to T228353: Consider expanding wikilink search results.

Wikilinks already included within the article

Jul 19 2019, 7:31 AM · VisualEditor-MediaWiki-Mobile, VisualEditor

Jul 17 2019

Schnark added a comment to T225021: Support a new "close" flag (distinct from "back") in OOUI dialogs.
  • we consider adding a title to the icon only action
Jul 17 2019, 7:42 AM · Skipped QA, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), OOUI (OOUI-0.33.0), VisualEditor (Current work)

Jul 15 2019

Schnark added a comment to T228006: Inserting special character after link links that character, too.

This actually happens for all annotations:

  1. Place the cursor after a bold word.
  2. Switch bold off.
  3. Insert a special character.
Jul 15 2019, 10:02 AM · VisualEditor-MediaWiki-Links, VisualEditor
Schnark created T228006: Inserting special character after link links that character, too.
Jul 15 2019, 7:06 AM · VisualEditor-MediaWiki-Links, VisualEditor

Jul 9 2019

Schnark created T227564: Menu of DropdownWidget with $overlay has padding at bottom.
Jul 9 2019, 8:47 AM · OOUI

Jul 8 2019

Schnark added a comment to T225277: Save button on Special:Preferences lags behind when scrolling.

I reported the bug upstream as https://bugzilla.mozilla.org/show_bug.cgi?id=1564071

Jul 8 2019, 9:50 AM · OOUI, MediaWiki-User-preferences

Jul 4 2019

Schnark added a comment to T227254: Activity panel is shown three times in default dashboard on Phabricator frontpage.

The Activity Feed on the left is shown twice, too.

Jul 4 2019, 9:20 AM · WMSE-Bug-Reporting-and-Translation-2019, Phabricator

Jul 1 2019

Schnark added a comment to T226875: monobook skin "your alerts" click brings "your notices".

These changes improve things, but nonetheless, the personal menu is still broken in Monobook. To reproduce:

  1. Visit a wiki where the change is live already (e.g. beta.wmflabs), log in with a name that is not too short (since my name is quite short and shows the issues, you'll probably be able to verify them, too).
  2. Slowly decrease the width of the window and observe all the weirdness that happens:
Jul 1 2019, 10:28 AM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Growth-Team, MonoBook, Notifications

Jun 27 2019

Schnark updated subscribers of T226478: Syntaxhighlight in NWE out of sync when text contains TAB characters.

I suspect rGVEDc0799b060844: Source mode performance optimizations is shortcutting, and omits the whitespace replacements.

Jun 27 2019, 8:59 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work), Regression, MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor
Schnark added a project to T226478: Syntaxhighlight in NWE out of sync when text contains TAB characters: Regression.

Actually, CodeMirror still replaces TAB characters by arrows for display, via ve.ui.CodeMirrorAction.static.fixWhitespace. It's NWE that no longer does this replacement, so this must be a regression.

Jun 27 2019, 8:16 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work), Regression, MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor
Restricted Application added a project to T226692: Add mw-disambig class to original content in VE: VisualEditor.
Jun 27 2019, 7:48 AM · User-Ryasmeen, Parsoid, VisualEditor-MediaWiki-Links, MediaWiki-extensions-Disambiguator, VisualEditor

Jun 26 2019

Schnark added a comment to T226478: Syntaxhighlight in NWE out of sync when text contains TAB characters.

For reference, this is ve.visibleWhitespaceCharacters from ve.utils.js.

Jun 26 2019, 8:46 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work), Regression, MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor
Restricted Application added a project to T226604: After replacing last match, still one match shown: VisualEditor.
Jun 26 2019, 8:11 AM · VisualEditor, VisualEditor-EditingTools
Schnark added a comment to T226478: Syntaxhighlight in NWE out of sync when text contains TAB characters.

I just copied from a code file which had the code indented with tab characters. CodeEditor has nothing to do with it, this is about wikitext (which may contain code inside syntaxhighlight tags), not about real code.
No tool does or should replace anything during pasting, the pasted tab characters are still real tab characters. But VE and NWE display a tab character as arrow (just as VE displays a single line break as hooked arrow), which is shorter than the real tab character used by CodeMirror.

Jun 26 2019, 7:29 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work), Regression, MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor

Jun 25 2019

Restricted Application added projects to T226478: Syntaxhighlight in NWE out of sync when text contains TAB characters: VisualEditor, Community-Tech.
Jun 25 2019, 8:50 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work), Regression, MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor
Schnark created T226476: wgUserNewMsgRevisionId is null even when there are new messages.
Jun 25 2019, 8:27 AM · MediaWiki-General

Jun 12 2019

Restricted Application added a project to T225600: VE still explicitely blacklists Opera < 12: VisualEditor.
Jun 12 2019, 9:47 AM · VisualEditor, VisualEditor-Initialisation, VisualEditor-MediaWiki
Schnark added a comment to T225550: Categories (and possibly other start-of-line transparent wikitext) that follow indent-pre wikitext get absorbed into <pre> tags and don't round-trip.

T225217: VE is removing spaces (dirty diffs) on some wikis (wikitech, officewiki) is about removing spaces, but could be a duplicate anyway.

Jun 12 2019, 7:44 AM · Parsoid

Jun 7 2019

Schnark created T225277: Save button on Special:Preferences lags behind when scrolling.
Jun 7 2019, 6:56 AM · OOUI, MediaWiki-User-preferences

Jun 6 2019

Schnark added a comment to T225189: Revision deletion breaks navigation links in diffs.

I.e. the expected result is https://en.wikipedia.org/w/index.php?title=Fourways_Farm&type=revision&oldid=900417793&diff=prev&diffmode=source

Jun 6 2019, 10:15 AM · MediaWiki-Page-Diffs, MediaWiki-Revision-deletion
Schnark created T225189: Revision deletion breaks navigation links in diffs.
Jun 6 2019, 10:13 AM · MediaWiki-Page-Diffs, MediaWiki-Revision-deletion
Schnark merged T225132: VisualEditor: Can no longer drag and drop (move) citations into T224042: Drag and drop of focusable nodes no longer works in Visual Editor.
Jun 6 2019, 7:17 AM · Verified, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), VisualEditor (Current work), Regression, VisualEditor-CopyPaste
Schnark merged task T225132: VisualEditor: Can no longer drag and drop (move) citations into T224042: Drag and drop of focusable nodes no longer works in Visual Editor.
Jun 6 2019, 7:17 AM · VisualEditor

May 27 2019

Schnark added a comment to T224363: VisualEditor frequently adds <br /> to articles.

This could be T215002: New paragraph before section heading becomes line break (well, the first example doesn't have the new section above a heading, but it's probably still related).

May 27 2019, 7:24 AM · VisualEditor

May 25 2019

Schnark closed T224320: Using five apostrophes in Arabic Wikipedia editor, it is not parsed as bold+italic, but only italic surrounded by two apostrophes (due to local CSS) as Invalid.

https://ar.wikipedia.org/wiki/%D9%85%D9%8A%D8%AF%D9%8A%D8%A7%D9%88%D9%8A%D9%83%D9%8A:Common.css includes the following rules:

May 25 2019, 9:03 AM · MediaWiki-Page-editing

May 24 2019

Schnark merged T224266: MediaWiki:Wikimedia-copyright asks for sitewide CSS/JS/JSON into T207652: JavaScript protection error message on some non-JavaScript MediaWiki messages.
May 24 2019, 9:24 AM · JavaScript, MediaWiki-Page-protection
Schnark merged task T224266: MediaWiki:Wikimedia-copyright asks for sitewide CSS/JS/JSON into T207652: JavaScript protection error message on some non-JavaScript MediaWiki messages.
May 24 2019, 9:24 AM · MediaWiki-Page-protection

May 18 2019

D3r1ck01 awarded T219604: Remove unused jquery.ui.* and jquery.effects.* modules a Like token.
May 18 2019, 2:59 PM · patch-welcome, Performance-Team (Radar), MW-1.34-release, MediaWiki-General, Technical-Debt (Deprecation), JavaScript
Schnark created T223694: Misleading namespace input in Advanced Search when searching with a prefix.
May 18 2019, 9:44 AM · TCB-Team, Advanced-Search

May 17 2019

Schnark added a comment to T223433: Vandalism is marked as checked edit after edit conflict.

For solution A see T76997: Edit conflict automatic resolution can silently produce unexpected results.

May 17 2019, 7:33 AM · MediaWiki-Patrolling, MediaWiki-Page-editing

May 14 2019

Schnark added a comment to T223155: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style.

This probably also fixes T217215: Toggle state in WikiEditor toolbar is not obvious.

May 14 2019, 9:27 AM · UI-Standardization, Patch-For-Review, WikiEditor
TerraCodes awarded T75714: ResourceLoader JavaScript parser should allow ES6 syntax features a Like token.
May 14 2019, 5:23 AM · Performance-Team, MediaWiki-ResourceLoader

May 13 2019

Schnark added a comment to T222859: Cursor focus not set on editsummary box when publishing dialog opens.

Wild guess: Could this be caused by rEVEDf9330c8564ee: Replace the save button with a save tool? At least, that seems to changes how the dialog is invoked.

May 13 2019, 9:14 AM · Skipped QA, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), VisualEditor-MediaWiki, Regression, Accessibility, VisualEditor-EditingTools
Schnark added a comment to T222944: Citoid doesn't load when uselang=qqx.

Shouldn't the config be loaded in content language always and thus not be breaking on changing the interface language?

May 13 2019, 8:34 AM · Verified, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), VisualEditor (Current work), MediaWiki-Internationalization, VisualEditor-InterfaceLanguage

May 11 2019

Schnark added a comment to T222953: Make "move subpages" checked by default on Special:MovePage.

Note that the necessary right "move-subpages" is by default only granted to sysops etc. So even if you check the checkbox by default, most moves will still be made without subpages.

May 11 2019, 9:45 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Core Platform Team Workboards (Clinic Duty Team), User-DannyS712, MediaWiki-Special-pages
Schnark merged T222997: Shared file page of a Wikimedia Commons file does not longer show information template and license (and more....) into T222935: HttpRequestFactory get method always return null (was: All local file description pages pointing to Commons do not display description locally from 1.34.0-wmf.4).
May 11 2019, 9:24 AM · User-notice, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, WMF-Legal, WikibaseMediaInfo, Regression, Multimedia, Commons, Chinese-Sites, MediaWiki-File-management
Schnark merged task T222997: Shared file page of a Wikimedia Commons file does not longer show information template and license (and more....) into T222935: HttpRequestFactory get method always return null (was: All local file description pages pointing to Commons do not display description locally from 1.34.0-wmf.4).
May 11 2019, 9:24 AM · Multimedia, Commons, MediaWiki-File-management, WikibaseMediaInfo
Schnark added a comment to T222999: Preview of editing summary missing in VE.

I didn't really look into it, but this could be caused by rEVED934572cdf732: API: Use formatversion=2 by default, as formatversion=2 moves the parsed result from the key "*" to its parent "parsedsummary".

May 11 2019, 8:42 AM · Verified, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), Regression, VisualEditor-MediaWiki
Schnark created T222999: Preview of editing summary missing in VE.
May 11 2019, 8:15 AM · Verified, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), Regression, VisualEditor-MediaWiki

May 10 2019

Schnark created T222939: UploadWizard should set proper language code on input for description.
May 10 2019, 8:11 AM · UploadWizard, Multimedia

May 9 2019

Schnark added a comment to T222859: Cursor focus not set on editsummary box when publishing dialog opens.

I can also reproduce this on mediawiki.org and de.wikisource. All of these wikis have the SingleEditTab config in common, so perhaps this has some strange effect on the focus. The focus actually isn't even on the dialog, you can't close it by pressing ESC.

May 9 2019, 8:34 AM · Skipped QA, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), VisualEditor-MediaWiki, Regression, Accessibility, VisualEditor-EditingTools

May 3 2019

Schnark created T222427: Page notices hidden behind toolbar dialogs.
May 3 2019, 8:27 AM · Verified, VisualEditor-MediaWiki, OOUI, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work)

May 2 2019

Schnark added a comment to T222325: [Regression pre-wmf.4] There is a "Publish changes" button under Insert drop down.

Probably caused by rEVEDf9330c8564ee: Replace the save button with a save tool (now that it is a tool, the insert menu includes it because it includes all "other" tools by default).

May 2 2019, 7:18 AM · User-Ryasmeen, VisualEditor (Current work), Verified, MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), VisualEditor-MediaWiki

Apr 29 2019

Schnark added a comment to T221997: Confusing re-use of 'quotes' icon in Find & Replace dialog.

Via Google Image search I found:

Apr 29 2019, 10:11 AM · VisualEditor
Schnark added a comment to T222048: Parsoid VE should not decode HTML5 entities.

T94603: Unexpanded HTML character entity references suggests to do it the other way round, i.e. the PHP parser should recognize all HTML5 entities.

Apr 29 2019, 8:31 AM · Parsoid

Apr 27 2019

Schnark added a comment to T221892: &veaction=edit no longer overrides namespace settings (can't edit global sandbox page using VE).

For the whitelist there is already T52883: VisualEditor: Provide some way of enabling VE on arbitrary pages for all users (e.g. non-ns0 sandboxes), a blacklist was previously declined in T54141: VisualEditor: Provide a mechanism to disable VisualEditor on a given page (to be used if it corrupts said page).
The "real" solution of course would be to enable Flow, use it for all pages in project namespace that have discussions on them, and then enable VE for everything else, (i.e. the same configuration as on mediawiki.org) but unfortunately that isn't going to happen.

Apr 27 2019, 8:16 AM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), VisualEditor-MediaWiki, VisualEditor (Current work)

Apr 26 2019

Schnark merged T176125: Trying to force the visual editor to load on a talk page whilst logged out causes the welcome dialogue to have no buttons (or other strange behaviour) into T219457: Opening VisualEditor in a disabled namespace with 2017 wikitext editor enabled displays raw Parsoid HTML.
Apr 26 2019, 7:39 AM · Skipped QA, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
Schnark merged task T176125: Trying to force the visual editor to load on a talk page whilst logged out causes the welcome dialogue to have no buttons (or other strange behaviour) into T219457: Opening VisualEditor in a disabled namespace with 2017 wikitext editor enabled displays raw Parsoid HTML.
Apr 26 2019, 7:39 AM · VisualEditor
Schnark added a comment to T176125: Trying to force the visual editor to load on a talk page whilst logged out causes the welcome dialogue to have no buttons (or other strange behaviour).

The originally reported issue isn't really a duplicate of T219457, but after merging T199411 it is, so I'll mark it as duplicate (it should have been done the other way round, but now the patch is linked to T219457).

Apr 26 2019, 7:39 AM · VisualEditor
Schnark merged T176099: Trying to use `veaction=edit` on a talk page loads the source editor and puts the page's HTML in the edit window into T219457: Opening VisualEditor in a disabled namespace with 2017 wikitext editor enabled displays raw Parsoid HTML.
Apr 26 2019, 7:36 AM · Skipped QA, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
Schnark merged task T176099: Trying to use `veaction=edit` on a talk page loads the source editor and puts the page's HTML in the edit window into T219457: Opening VisualEditor in a disabled namespace with 2017 wikitext editor enabled displays raw Parsoid HTML.
Apr 26 2019, 7:36 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Apr 24 2019

Schnark added a comment to T221705: [Regression pre-wmf.2] The context menu for categories is appearing transparent .

Curiously, this is caused by the filter: drop-shadow(0 2px 1px rgba(0,0,0,0.3)); rule added in OOUI per T220248.

Apr 24 2019, 8:09 AM · OOUI (OOUI-0.31.5), Verified, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), User-Ryasmeen, Regression, VisualEditor-MediaWiki, VisualEditor

Apr 23 2019

Schnark created T221600: HTML of edit page downloaded twice.
Apr 23 2019, 9:20 AM · Skipped QA, VisualEditor (Current work)

Apr 12 2019

Schnark created T220792: LookupElement has padding at the end if there is just one suggestion.
Apr 12 2019, 7:48 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), OOUI (OOUI-0.31.6)

Apr 10 2019

Schnark created T220584: Links generated by templates inaccessible while editing.
Apr 10 2019, 8:11 AM · VisualEditor-MediaWiki-Links, VisualEditor-MediaWiki-Templates, VisualEditor
Schnark added a project to T220465: [Regression wmf.25] VE is not loading for pages with music score, shows error " Uncaught Error: No class registered by that name: mwScore": MediaWiki-extensions-Score.

Did rESCRb3a898135dd7: ScoreHooks: Bundle configuration vars into JS that needs it change something in the execution order / scope / whatever, that code for score nodes isn't accessible yet when needed?

Apr 10 2019, 7:09 AM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MediaWiki-extensions-Score, VisualEditor (Current work)

Apr 9 2019

Schnark added a comment to T220152: Adding a new line causes the next to be struck out.

Well, what do you expect when you split one paragraph into three paragraphs, and edit each of the new paragraphs heavily?

Apr 9 2019, 9:15 AM · VisualEditor, VisualEditor-VisualDiffs

Apr 5 2019

Schnark created T220177: Width of suggestions for edit summaries doesn't match width of input.
Apr 5 2019, 7:35 AM · OOUI, VisualEditor, VisualEditor-MediaWiki
Schnark created T220176: Suggestion for edit comments can appear without interaction.
Apr 5 2019, 7:28 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki

Apr 4 2019

Schnark added a comment to T220007: Remove confirm dialogs (prompts) when switching between VE and 2010 wikitext editor with changes.

Additional benefit: I think there have been some cases where users switched from section editing to visual editing and blindly clicked on "Discard changes and switch", and only noticed when too late that they just lost their edit. Showing the confirmation only when it really is necessary will probably prevent this.

Apr 4 2019, 7:07 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Verified, VisualEditor (Current work), VisualEditor-MediaWiki

Apr 3 2019

Schnark added a comment to T219826: Add 'error' icon to 'alerts' icon pack.

notice is going to be deprecated, both message and icon, see T218236

Apr 3 2019, 8:45 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), OOUI (OOUI-0.31.3), UI-Standardization, UI-Standardization-Kanban

Mar 30 2019

Schnark updated subscribers of T219675: [Regression wmf.23] Searching image is broken on both Beta and test.wiki.

Very likely caused by rEVED21e9db7d1339: Respect user preference for default thumbnail size while editing.

Mar 30 2019, 9:15 AM · User-Ryasmeen, Verified, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), VisualEditor (Current work), Patch-For-Review

Mar 29 2019

Volker_E awarded T219604: Remove unused jquery.ui.* and jquery.effects.* modules a Like token.
Mar 29 2019, 6:53 PM · patch-welcome, Performance-Team (Radar), MW-1.34-release, MediaWiki-General, Technical-Debt (Deprecation), JavaScript
Schnark created T219604: Remove unused jquery.ui.* and jquery.effects.* modules.
Mar 29 2019, 10:04 AM · patch-welcome, Performance-Team (Radar), MW-1.34-release, MediaWiki-General, Technical-Debt (Deprecation), JavaScript
Schnark added a comment to T214790: Allow selection of the page title in Visual Editor.

Looks like those gadget links get erased by VE anyway, as we manually set the firstHeading.

Mar 29 2019, 9:19 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Verified, VisualEditor-MediaWiki, VisualEditor (Current work)

Mar 27 2019

Schnark added a comment to T219340: Remove wgMonthNames and wgMonthNamesShort from mw.config.

There is an important difference between wgMonthNames and mw.language.months.names: wgMonthNames uses the language of the wiki, while mw.language.months.names is in the language of the user.
This probably also means that sorting dates in tables is broken when the user has an interface language different from the content.

Mar 27 2019, 9:01 AM · Readers-Web-Backlog, patch-welcome, Performance-Team, MediaWiki-Interface, Technical-Debt (Deprecation)

Mar 25 2019

Schnark added a comment to T219009: Focusing on tabs should trigger the appropriate event of the first focusable element if autoFocus is true.

IndexLayout does have an option to configure this bahaviour: autoFocus (which indeed defaults to true), see https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.ui.IndexLayout

Mar 25 2019, 9:40 AM · OOUI

Mar 22 2019

Schnark added a comment to T218977: Native controls shown for number inputs in Firefox.
.oo-ui-textInputWidget .oo-ui-inputWidget-input {
    -webkit-appearance: none;
}

overrides

.oo-ui-textInputWidget [type="number"] {
    -moz-appearance: textfield;
}
Mar 22 2019, 8:57 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), OOUI (OOUI-0.33.0), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Browser-Support-Firefox
Schnark created T218977: Native controls shown for number inputs in Firefox.
Mar 22 2019, 8:28 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), OOUI (OOUI-0.33.0), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Browser-Support-Firefox

Mar 14 2019

Schnark added a comment to T218257: Article creation suggestion on search should check for permissions.

Some checking whether the user is allowed to create a page or not does happen, compare https://en.wikipedia.org/w/index.php?search=talk%3Adoes+not+exist&title=Special%3ASearch and https://en.wikipedia.org/w/index.php?search=does+not+exist&title=Special%3ASearch logged out. The latter is using the message searchmenu-new-nocreate.

Mar 14 2019, 8:41 AM · patch-welcome, good first bug, MediaWiki-Interface, MediaWiki-Search, Discovery-Search

Mar 13 2019

Schnark added a comment to T216413: Support accesskey (small k) in AccessKeyedElement trait.

Note that this confusion also exists in the HTML standard: Only the attribute is called accesskey, the corresponding property is accessKey, same with tabindex (that's the attribute) and tabIndex (that's the property).

Mar 13 2019, 8:56 AM · OOUI

Mar 9 2019

Schnark added a comment to T217921: Support for prefers-color-scheme CSS @media feature in default skins.

prefers-color-scheme is a new draft proposal, supported by (at the time of this posting) two browsers.

Well, actually this should read "prefers-color-scheme is a new draft proposal, supported by (at the time of this posting) two beta versions of browsers, but only if the user uses a supported OS." (Though AFAIK Firefox supports both MacOS and Windows, only Linux is unsupported.)

Mar 9 2019, 10:39 AM · CologneBlue, MonoBook, Vector, Modern

Mar 8 2019

Schnark added a comment to T217857: Be able to choose a specific wikitext editor when switching to source mode.

Technically, this is possible, and I do so in my script https://de.wikipedia.org/wiki/Benutzer:Schnark/js/veCode.js (search for EditModeOweTool).
But generally I'm not sure that two very similar options are a good idea. On which basis does a user - especially a new user - decide which of the two wikitext modes he wants to switch to? Having more choice can make things harder, not easier.

Mar 8 2019, 8:26 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Mar 6 2019

Schnark added a comment to T213426: Deprecate jquery.throttle-debounce in favour of OO.ui.debounce/throttle.

Can this note from @Krinkle be added to the description and rationale for the deprecation be added to the task description? There's really no excuse for an empty task description, especially if we're pointing people to it directly from the console.

Mar 6 2019, 9:15 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog, MW-1.35-release, Growth-Team, Metrolook, Vector, WikiEditor, Wikidata, MediaWiki-extensions-Translate, RelatedArticles, MobileFrontend, MediaViewer, MassMessage, Maps (Kartographer), MediaWiki-extensions-InputBox, Graphs, StructuredDiscussions, MediaWiki-extensions-CentralNotice, Patch-For-Review, Technical-Debt (Deprecation), JavaScript, MediaWiki-General

Mar 5 2019

Schnark added a comment to T213522: Reconsider URL changes done by Visual Diff.

This would make it unlikely that URLs with accidental diffmode parameters are shared, while it would be automatically included in most cases where a user wants to share the exact mode.

I don't think this works, because the diffmode is remembered in user options. This would effectively stop the diffmode ever being appended after the first time the user changes it to their preference. If the user wanted to share a diffmode they would have to change the mode twice.

Mar 5 2019, 8:03 AM · VisualEditor, VisualEditor-VisualDiffs

Mar 4 2019

Schnark added a project to T217494: Tabs being forced down and crashing with page title: VisualEditor-Initialisation.

The label for editing the local page as wikitext is actually "Create source" (see the HTML code), and only gets changed to "Add local description source" by JS (probably VE initialization code). This changes the width of the tabs, but the check whether collapsing some tabs is necessary doesn't happen again.
Ideally, the same message would be used both on server and client side, or at least a re-check should be triggered (I actually run a $(window).trigger('resize') on most pages, which fixes this issue).

Mar 4 2019, 10:06 AM · VisualEditor-Initialisation, VisualEditor, Vector
Schnark merged T217502: Can't select across reference in VisualEditor into T214976: Can't select across block images in Firefox.
Mar 4 2019, 9:13 AM · Verified, User-notice, VisualEditor (Current work), VisualEditor-ContentEditable, Browser-Support-Firefox
Schnark merged task T217502: Can't select across reference in VisualEditor into T214976: Can't select across block images in Firefox.
Mar 4 2019, 9:13 AM · VisualEditor
Schnark added a comment to T217502: Can't select across reference in VisualEditor.

Even though the different title, this is just a duplicate of T214976: Can't select across block images in Firefox, which already is fixed on master. You can verify that selecting across references works as expected in Firefox on https://de.wikipedia.beta.wmflabs.org/wiki/Https_Test_3?veaction=edit.

Mar 4 2019, 9:12 AM · VisualEditor