Schnark (Michael M.)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 7:11 AM (166 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Schnark

Recent Activity

Yesterday

Schnark added a comment to T182156: RecentChanges legend overlaps actual RecentChanges.

Just another screenshot to show that this isn't just a minor nuisance:

Fri, Dec 15, 8:12 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression, MediaWiki-Recent-changes

Wed, Dec 13

Sunpriat2 awarded T165283: Editing a page with unflagged changes should edit latest version in VE, even if you view the stable version a Burninate token.
Wed, Dec 13, 7:52 PM · MediaWiki-extensions-FlaggedRevs, VisualEditor-MediaWiki, VisualEditor

Sat, Dec 9

Schnark added a comment to T182404: 2017 wikitext editor gets very confused while typing signature (combining diacritics and non-breaking spaces?).

I can't reproduce this with Linux, but for some reason I don't get an NBSP with AltGr+Space, so this seems an important factor.
By the way, the most efficient way to type 4 tildes with a Finnish keyboard with dead keys seems to me to be: Hold AltGr, Press the key with the tilde 8 times, release AltGr.

Sat, Dec 9, 9:35 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Schnark added a comment to T182393: Alt text for images should be spellchecked.

On a second thought: The alt attribute accepts multiline text (both in HTML and Mediawiki), so a multiline input for it would make sense, and would enable spellchecking in most if not all browsers automatically.

Sat, Dec 9, 9:14 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), User-Ryasmeen, VisualEditor-MediaWiki-Media, VisualEditor

Fri, Dec 8

Schnark created T182402: Pasting HTML in NWE can't be undone via keyboard.
Fri, Dec 8, 11:03 AM · Patch-For-Review, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Schnark created T182393: Alt text for images should be spellchecked.
Fri, Dec 8, 9:21 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), User-Ryasmeen, VisualEditor-MediaWiki-Media, VisualEditor
Schnark created T182392: After editing a multipage file VE incorrectly shows first page whilst editing (but shows the correct page after saving).
Fri, Dec 8, 9:19 AM · VisualEditor-MediaWiki-Media, VisualEditor
Schnark added a comment to T182300: Paragraph indicated as moved, though it wasn't.

It even happens for paragraphs with nothing between them: https://de.wikipedia.org/w/index.php?title=Frankenhardt&curid=502187&diff=171771634&oldid=170255294

Fri, Dec 8, 8:37 AM · German-Community-Wishlist, WMDE-QWERTY-Team-Board, MediaWiki-History-or-Diffs, TCB-Team

Thu, Dec 7

Schnark added a comment to T182300: Paragraph indicated as moved, though it wasn't.

And the other way round, too: https://de.wikipedia.org/w/index.php?title=Maria_Canins&curid=5138507&diff=171746679&oldid=171745939
Most of the "moved" paragraphs weren't moved, the diff totally obscures the fact that only a) headlines were inserted, and b) paragraphs have been split.
The only real move in this example is the block with the references.

Thu, Dec 7, 10:18 AM · German-Community-Wishlist, WMDE-QWERTY-Team-Board, MediaWiki-History-or-Diffs, TCB-Team
Schnark created T182300: Paragraph indicated as moved, though it wasn't.
Thu, Dec 7, 10:09 AM · German-Community-Wishlist, WMDE-QWERTY-Team-Board, MediaWiki-History-or-Diffs, TCB-Team
Schnark added a comment to T181975: action=query & list=watchlist can't return edit tags.

Personally, I am actually only interested in the wlprop=tags, and just noticed that the filter is missing, too, without wanting to use it. So I don't have any preference in whether to leave this task open until somebody implements the filter, creating a new task for it, or just ignoring it.

Thu, Dec 7, 8:53 AM · Patch-For-Review, MediaWiki-API
Schnark created T182292: Moved paragraphs in diff use a tag with name, which is obsolete in HTML5.
Thu, Dec 7, 8:31 AM · German-Community-Wishlist, WMDE-QWERTY-Team-Board, MediaWiki-History-or-Diffs, TCB-Team

Wed, Dec 6

Schnark renamed T182156: RecentChanges legend overlaps actual RecentChanges from RecentChanges legend overlaps actual RecentChanges in Timeless skin to RecentChanges legend overlaps actual RecentChanges.
Wed, Dec 6, 11:10 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression, MediaWiki-Recent-changes
Schnark added a comment to T182156: RecentChanges legend overlaps actual RecentChanges.

I can reproduce on mw and beta.wmflabs (i.e. with 1.31.0-wmf.11) in any skin.

Wed, Dec 6, 11:10 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression, MediaWiki-Recent-changes
Schnark added a comment to T181484: Links to sections in an article will land behind unscrollable header.

Ignore my comment about display: contents, I was tricked into thinking it works, but it doesn't.

Wed, Dec 6, 10:58 AM · Timeless
Schnark added a comment to T181484: Links to sections in an article will land behind unscrollable header.

This seems to be caused by the fact that the :target element is an inline element, not a block element. Setting display: block works, but of course breaks the layout. An alternative is perhaps :target {display: contents;} which works for me, but isn't widely supported yet: https://caniuse.com/#search=contents

Wed, Dec 6, 10:49 AM · Timeless

Tue, Dec 5

Schnark added a comment to T181699: New video player touches all global vars on Special:Search, triggering lots of deprecation messages.

And this indeed has a for k in window loop (in hasAutomationEqualityBug).

Tue, Dec 5, 9:12 AM · TimedMediaHandler-Player
Schnark added a comment to T181699: New video player touches all global vars on Special:Search, triggering lots of deprecation messages.

When I switch on debug mode, it takes some time, but the warnings occur directly after https://en.wikipedia.beta.wmflabs.org/w/extensions/TimedMediaHandler/resources/videojs/video.js is loaded. (Firefox ESR 52)

Tue, Dec 5, 8:42 AM · TimedMediaHandler-Player

Mon, Dec 4

Schnark created T181975: action=query & list=watchlist can't return edit tags.
Mon, Dec 4, 11:14 AM · Patch-For-Review, MediaWiki-API
Schnark created T181968: BookletLayout with expanded: false and continuous: true doesn't scroll pages into view.
Mon, Dec 4, 10:03 AM · OOjs-UI

Sat, Dec 2

Schnark created T181880: unicodeJS.TextString.substring removed without warning.
Sat, Dec 2, 10:12 AM · Regression, Utilities-UnicodeJS
Schnark created T181877: CSS loading sometimes delayed in Firefox; FOUC reproducibly displayed.
Sat, Dec 2, 8:26 AM · Upstream, Performance-Team, Regression, MediaWiki-ResourceLoader, Browser-Support-Firefox

Fri, Dec 1

Schnark created T181788: Preference tabs inaccessible when header wraps in Timeless skin.
Fri, Dec 1, 10:56 AM · MediaWiki-User-preferences, Timeless
Schnark updated the task description for T181781: FOUC on line height in Recent Changes/Watchlist with combined items.
Fri, Dec 1, 10:17 AM · MediaWiki-Watchlist, MediaWiki-Recent-changes
Schnark created T181781: FOUC on line height in Recent Changes/Watchlist with combined items.
Fri, Dec 1, 10:16 AM · MediaWiki-Watchlist, MediaWiki-Recent-changes

Thu, Nov 30

Schnark created T181699: New video player touches all global vars on Special:Search, triggering lots of deprecation messages.
Thu, Nov 30, 10:20 AM · TimedMediaHandler-Player

Wed, Nov 29

Schnark added a comment to T181491: Langlink box has scrollbar in Firefox.

Do you have ULS-CompactLinks enabled? It doesn't look like it, but I am going to ask the dumb question.

Wed, Nov 29, 8:13 AM · Browser-Support-Firefox, Timeless

Tue, Nov 28

Schnark created T181491: Langlink box has scrollbar in Firefox.
Tue, Nov 28, 11:18 AM · Browser-Support-Firefox, Timeless
Schnark created T181490: Highlight for references extends above ref.
Tue, Nov 28, 11:13 AM · Cite, Timeless
Schnark added a comment to T179755: DropdownWidget and TextInputWidget have different vertical align.

By the way, this doesn't occur with DropdownInputWidget.

Tue, Nov 28, 10:35 AM · OOjs-UI
Schnark created T181484: Links to sections in an article will land behind unscrollable header.
Tue, Nov 28, 10:30 AM · Timeless
Schnark merged T181325: Reconsider whether top aligned labels for the basic information in preferences are best approach into T180538: Improve Special:Preferences UI/UX.
Tue, Nov 28, 9:29 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, UI-Standardization, MediaWiki-User-preferences
Schnark merged task T181325: Reconsider whether top aligned labels for the basic information in preferences are best approach into T180538: Improve Special:Preferences UI/UX.
Tue, Nov 28, 9:29 AM · MediaWiki-User-preferences

Sat, Nov 25

Schnark created T181325: Reconsider whether top aligned labels for the basic information in preferences are best approach.
Sat, Nov 25, 9:29 AM · MediaWiki-User-preferences
Schnark created T181324: Edit font preview in preferences uses a small font size for monospace.
Sat, Nov 25, 9:16 AM · VisualEditor, MediaWiki-Page-editing, Patch-For-Review, MediaWiki-User-preferences
Schnark created T181323: Content pushed down by a large amount in Timeless.
Sat, Nov 25, 8:38 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Timeless, Regression

Wed, Nov 22

Schnark added a comment to T180710: On the "Watchlist" preferences panel, don't show the user's watchlist token; instead just link to Special:ResetTokens.

Slightly related (I didn't test whether the above patch also fixes this, but it doesn't seem unlikely, so I'll comment here instead of a new task): Currently the info text about the token is duplicated, once below (directly visible) and once behind the help icon:


(To all hackers reading this: No, this is no longer my watchlist token, apart from the fact that my watchlist on beta.wmflabs doesn't contain anything interesting).

Wed, Nov 22, 9:19 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-Watchlist, UI-Standardization, MediaWiki-User-preferences

Fri, Nov 17

Schnark merged T180736: The (edit) link from old diff is opening the current version of the page into T179994: Link to action=edit of a specific revision shows current revision in VE.
Fri, Nov 17, 8:38 AM · VisualEditor-MediaWiki, User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), VisualEditor
Schnark merged task T180736: The (edit) link from old diff is opening the current version of the page into T179994: Link to action=edit of a specific revision shows current revision in VE.
Fri, Nov 17, 8:38 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Nov 15 2017

Schnark added a comment to T180116: Link to history is missing in mobile view for anonymous page views with pending changes.

The link to the history is actually missing always if you are viewing any non-current version (e.g. https://de.m.wikipedia.org/w/index.php?title=Spielw%C3%BCrfel&oldid=171015053), and viewing a page with pending changes as anon just gives you an old version of the page (without the notice on the top that it is an old version).

Nov 15 2017, 11:00 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Regression, Readers-Web-Kanban-Board, Readers-Web-Backlog, MinervaNeue, MediaWiki-extensions-FlaggedRevs

Nov 14 2017

Schnark created T180440: Search suggestions ignore settings for logged in users on de.wikipedia, always performing a prefix search (no typo correction).
Nov 14 2017, 10:21 AM · Discovery-Search, Discovery, CirrusSearch
Schnark added a comment to T180116: Link to history is missing in mobile view for anonymous page views with pending changes.
I'm not 100% clear what Spezial:Seiten_mit_ungesichteten_Versionen has to do with this bug report right now.

This issue applies to all pages listed there, and only to those.
For example, currently https://de.wikipedia.org/wiki/Italiaonline is on that list, and when you visit https://de.m.wikipedia.org/wiki/Italiaonline while not logged in, you won't see a link to the history. But once that page is reviewed, the link to the history will be shown again, so to reproduce it is best to first visit https://de.wikipedia.org/w/index.php?title=Spezial:Seiten_mit_ungesichteten_Versionen&namespace=0, select any page listed there, and view this page in mobile view while not logged in.

Nov 14 2017, 9:27 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Regression, Readers-Web-Kanban-Board, Readers-Web-Backlog, MinervaNeue, MediaWiki-extensions-FlaggedRevs

Nov 11 2017

Schnark added a comment to T180259: Investigate possible regression due to wikidiff2 1.5 change detection.

Searching old screenshots of diff screens will find lots of more examples. One interesting case from it.wiki: https://commons.wikimedia.org/wiki/File:Confronto_diff_monobook.png / https://it.wikipedia.org/w/index.php?title=Colle_Vento&diff=prev&oldid=7897666
Sure, the second paragraph changed a lot. But the new version hides the fact that also a lot stayed the same. There are more similar changes later on (but not in the screenshot on Commons, so I currently can't compare them to the previous version), but I'm quite sure that for those, too, previously a diff was shown, while now wikidiff refuses to show a diff for them, hiding the fact that they are clearly based on the previous version for a large part.

Nov 11 2017, 10:44 AM · WMDE-QWERTY-Sprint-2017-11-01, wikidiff2, WMDE-QWERTY-Team-Board, meta-ci-docker-diffs, TCB-Team
Schnark added a comment to T180259: Investigate possible regression due to wikidiff2 1.5 change detection.

One example where I do have a screenshot of the old version (https://commons.wikimedia.org/wiki/File:Wiki_labels_screenshot_(zoomed_--_diff).png ): https://en.wikipedia.org/w/index.php?title=Marbella_Cup&diff=646838927&oldid=645151368
While the old version clearly shows that previously empty table cells were filled in, the new version is almost twice as long and doesn't show this clearly. So even though the new version here works as advertised (no diff shown for lines that changed very much), it makes things worse.

Nov 11 2017, 10:30 AM · WMDE-QWERTY-Sprint-2017-11-01, wikidiff2, WMDE-QWERTY-Team-Board, meta-ci-docker-diffs, TCB-Team
Schnark added a comment to T180259: Investigate possible regression due to wikidiff2 1.5 change detection.

Actually, in most of the examples above both the old and the new behavior is bad, because either the wrong paragraphs (old version of wikidiff2) or neither paragraphs (new version of wikidiff2) are connected, which makes me wonder whether this really was always the case or whether there is yet another regression that went unnoticed, especially since the example from comment T180259#3751693 was linked in a discussion about T35331, which suggests that in a previous version the paragraphs were linked as expected.

Nov 11 2017, 8:28 AM · WMDE-QWERTY-Sprint-2017-11-01, wikidiff2, WMDE-QWERTY-Team-Board, meta-ci-docker-diffs, TCB-Team

Nov 10 2017

Schnark created T180214: Numbered external links not visible in preview in NWE.
Nov 10 2017, 11:19 AM · Verified-in-Phase0, Verified, VisualEditor-MediaWiki, User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), VisualEditor

Nov 9 2017

Schnark created T180116: Link to history is missing in mobile view for anonymous page views with pending changes.
Nov 9 2017, 11:04 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Regression, Readers-Web-Kanban-Board, Readers-Web-Backlog, MinervaNeue, MediaWiki-extensions-FlaggedRevs
Schnark created T180103: OutputPage::getRevisionTimestamp on (de|hu).wikipedia returning incorrect values for anonymous users.
Nov 9 2017, 9:23 AM · User-Jdlrobson, MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-extensions-FlaggedRevs, Readers-Web-Backlog, MinervaNeue, MediaWiki-General-or-Unknown

Nov 8 2017

Schnark created T180010: Parsoid creates broken wikitext for link inside square brackets.
Nov 8 2017, 9:28 AM · Patch-For-Review, Parsoid

Nov 7 2017

Schnark added a comment to T179870: Re-use a citation isn't finding citations.

The search seems only to take the number and the name attribute (if it has one) of the reference into consideration.
Yes, searching the content of the reference would be very convenient.

Nov 7 2017, 9:51 AM · Verified-in-Phase2, Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Regression, VisualEditor, VisualEditor-MediaWiki-References

Nov 4 2017

Schnark created T179755: DropdownWidget and TextInputWidget have different vertical align.
Nov 4 2017, 9:28 AM · OOjs-UI

Nov 3 2017

Schnark created T179654: Title of new section in NWE not automatically spellchecked.
Nov 3 2017, 10:27 AM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Oct 26 2017

Schnark added a comment to T179052: Some browsers ignore newline characters in MultilineTextInputWidget placeholder.

One possible workaround: Use many spaces instead of the line break.

Oct 26 2017, 10:03 AM · Browser-Support-Firefox, Upstream, OOjs-UI
Schnark added a comment to T179052: Some browsers ignore newline characters in MultilineTextInputWidget placeholder.

This works as expected in Blink based browsers. In Firefox it fails due to the fact that Firefox still follows the old spec that told browsers to ignore newline characters in placeholders (https://bugzilla.mozilla.org/show_bug.cgi?id=1391044). I didn't test other browsers. But it's probably better to wait until this is fixed inside the browsers instead of trying to find a workaround.

Oct 26 2017, 8:36 AM · Browser-Support-Firefox, Upstream, OOjs-UI

Oct 23 2017

Schnark added a comment to T178780: Single line breaks shown a little strangely.

Since line breaks are shown as while editing in VE, it probably would make sense to use <del>↵</del><ins>&nbsp;</ins> to show such a diff.

Oct 23 2017, 8:14 AM · VisualEditor, VisualEditor-VisualDiffs

Oct 18 2017

Schnark created T178456: Small unclickable gap between checkbox and label.
Oct 18 2017, 8:21 AM · OOjs-UI

Oct 17 2017

Schnark created T178357: Don't use protocol relative links to Commons in MultimediaViewer.
Oct 17 2017, 9:21 AM · Wikimedia-General-or-Unknown, Multimedia

Oct 11 2017

Schnark added a comment to T177822: VisualEditor says I have "2 notices" but only one is shown..

If your local edit message system is an outdated copy of enwiki's (or something similar), see T45013 and related tasks.

Oct 11 2017, 7:42 AM · VisualEditor

Oct 10 2017

Schnark created T177818: "Add links" link for adding language link should use color from WikimediaUI palette.
Oct 10 2017, 9:08 AM · Wikidata, MediaWiki-extensions-WikibaseClient

Oct 9 2017

Schnark added a comment to T177378: Historical visual diff throwing uncaught exception.

Other diff that also fails with the same error message: https://de.wikipedia.org/w/index.php?title=Lex&diff=prev&oldid=169798942&visualdiff&diffmode=visual

Oct 9 2017, 7:19 AM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), VisualEditor, VisualEditor-VisualDiffs

Oct 6 2017

Schnark created T177584: Tablesorter should re-merge cells with rowspan if possible.
Oct 6 2017, 8:28 AM · JavaScript, MediaWiki-jQuery-Tablesorter

Oct 4 2017

Schnark added a comment to T177243: Visual editor does not work with Modern Skin.

This bug consists of two different parts:
Part 1 is the fact, that Modern skin isn't compatible with VE (probably the missing #content).
Part 2 is the fact, that even though Modern skin isn't compatible with VE, the editing tab for VE is still shown.

Oct 4 2017, 8:20 AM · Modern, VisualEditor
Schnark added a comment to T170129: Use NWE + CodeMirror for JS/CSS pages.

Don't you see Ace/Code editor on those pages? (https://www.mediawiki.org/wiki/Extension:CodeEditor)

Oct 4 2017, 7:30 AM · Community-Tech, MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Sep 29 2017

Schnark updated the task description for T177041: After triggering edit conflict in VE, error about missing Unicode support is shown.
Sep 29 2017, 9:17 AM · MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Patch-For-Review, VisualEditor-MediaWiki, User-Ryasmeen, MediaWiki-Page-editing, VisualEditor
Schnark created T177041: After triggering edit conflict in VE, error about missing Unicode support is shown.
Sep 29 2017, 7:18 AM · MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Patch-For-Review, VisualEditor-MediaWiki, User-Ryasmeen, MediaWiki-Page-editing, VisualEditor

Sep 6 2017

Yair_rand awarded T75714: ResourceLoader JavaScript parser should allow ES6 syntax features a Doubloon token.
Sep 6 2017, 8:25 PM · MediaWiki-ResourceLoader
Schnark added a comment to T174898: Copy and paste added no-wiki.

Editors can specify the MIME type for copied content. I don't know how this works in Java, just for reference: https://developer.mozilla.org/en-US/docs/Web/API/HTML_Drag_and_Drop_API/Recommended_drag_types explains the JavaScript part of the copy-paste process. Since you know that you're copying wikitext, text/x-wiki would probably be the best choice, next to a simple text/plain.

Sep 6 2017, 7:11 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Sep 4 2017

Schnark added a comment to T174898: Copy and paste added no-wiki.

I can't reproduce this: I opened my de.wikipedia user page for editing in NWE, cut everything, pasted it into my external text editor, copied it from there again, and inserted in NWE. No nowiki tags were added.

Sep 4 2017, 8:26 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Aug 31 2017

Schnark closed T172361: Visual diff on historical diffs shows changes for date-dependent content as Resolved.

I should have included a screenshot. The problem was that the parser indeed rendered the page as it was on a previous day (at least partially), so the question wasn't whether that's possible, but how not to do so. But apparently this has been fixed.

Aug 31 2017, 7:12 AM · User-Ryasmeen, VisualEditor-VisualDiffs, VisualEditor

Aug 30 2017

Schnark added a comment to T162503: VE in Timeless makes cactions non-responsive, trapping users forever.

See also T164705: Provide visible tool for aborting edit in VE (which still wouldn't allow you to open the current page for reading in a new tab while editing, etc., but would improve the situation to some degree).

Aug 30 2017, 8:43 AM · VisualEditor, Timeless

Aug 29 2017

Schnark added a comment to T160651: Better handling for tools block.

Additionally, while on a wide screen the tools are on the top right - a very prominent place - on a small screen they are bottom left - probably the least prominent place. This is a bit strange, too, especially for users like me who have the window width just at the threshold, and sometimes increase and decrease the width.

Aug 29 2017, 10:24 AM · Timeless

Aug 28 2017

Schnark created T174314: Focus outline around watch star extends to left.
Aug 28 2017, 9:11 AM · Timeless

Aug 26 2017

FriedhelmW awarded T170122: Link to combined change on watchlist wrong for Wikidata edits a 100 token.
Aug 26 2017, 8:50 AM · MediaWiki-Recent-changes, MediaWiki-extensions-WikibaseClient, Wikidata
Schnark merged T174149: void elements cause error markup into T170238: Highlight void tags and other tags correctly.
Aug 26 2017, 8:01 AM · Community-Tech, MediaWiki-extensions-CodeMirror
Schnark merged task T174149: void elements cause error markup into T170238: Highlight void tags and other tags correctly.
Aug 26 2017, 8:01 AM · Community-Tech, MediaWiki-extensions-CodeMirror

Aug 16 2017

Schnark added a comment to T173089: Watchlisting confirmation dialog interrupts editing.

I cannot reproduce the issue. Clicking the star while editing adds/removes the page from the watchlist without interrupting my editing. The confirmation dialog should only show up when JS is disabled (which clearly isn't the case here) or updating the watched status in the background fails for some other reason (e.g. token expired). In this case indeed a new page is loaded, which will cause you lose all your editing. But in this case a warning should be shown before you leave the editing page (unless you disabled this warning in your preferences), and would happen just in the same way in the old wikitext editor.

Aug 16 2017, 9:13 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-Page-editing, MediaWiki-Watchlist
Schnark created T173400: Invalid diff mode should be ignored.
Aug 16 2017, 7:04 AM · VisualEditor-VisualDiffs, VisualEditor

Aug 12 2017

Schnark added a comment to T171377: Changing a reference shows useless and confusing details in visual diff.

No. Note that this only happens while reviewing the change in VE. The historical diff looks as I would expect it.

Aug 12 2017, 7:42 AM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, VisualEditor, Cite, VisualEditor-VisualDiffs

Aug 11 2017

Schnark added a comment to T134423: Deprecate nonstandard behavior of self-closed HTML tags in wikitext..

@Verdy_p: Please read https://html.spec.whatwg.org/multipage/parsing.html#parse-error-non-void-html-element-start-tag-with-trailing-solidus
In HTML5, a slash at the end of a start tag

  • is ignored for void elements like <br>
  • is a parser error for non-void elements like <div> (but is just ignored, too)
  • only is treated as an actual self-closing element for foreign elements (i.e. for <svg> and <math>, which aren't allowed in wikitext anyway).
Aug 11 2017, 7:25 AM · Patch-For-Review, Chinese-Sites, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)), User-notice, Parsoid, MediaWiki-Parser

Aug 9 2017

Schnark created T172857: When switching modes fails, stay with old mode.
Aug 9 2017, 9:33 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Aug 8 2017

Schnark added a comment to T171437: Allow easily extending the diff mode switcher in page history.

I now did this in a very hacky way, see https://de.wikipedia.org/wiki/Benutzer:Schnark/js/diff.js, with such really ugly code like

$switcherContainer.find('[role="button"]').eq(currentMode === 'visual' ? 0 : 1)
	.trigger($.Event('mousedown', {which: 1}))[0].dispatchEvent(new MouseEvent('mouseup'));

to pass on clicks from my switcher to the other switcher.

Aug 8 2017, 9:16 AM · VisualEditor-VisualDiffs, VisualEditor

Aug 7 2017

Schnark added a comment to T95104: Fix the default browser spellcheck functionality, or integrate a spell checker to CodeMirror.

Web browsers can check spelling in textareas only.

I am not certain that this is completely accurate any longer. For example, I understand that VisualEditor isn't a textarea, and my web browser's spellcheck system works in it anyway:

This screenshot was taken in VisualEditor's visual mode in Firefox 50 at the German Wikipedia, with the browser's spelling dictionary set to English. All those red lines indicate "misspelled" words.

Aug 7 2017, 8:26 AM · Community-Tech, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), User-notice, Patch-For-Review, MediaWiki-extensions-CodeMirror

Aug 4 2017

Schnark created T172493: mw.util.escapeId should log deprecation warning.
Aug 4 2017, 8:41 AM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, MediaWiki-General-or-Unknown, JavaScript

Aug 3 2017

Schnark created T172361: Visual diff on historical diffs shows changes for date-dependent content.
Aug 3 2017, 7:52 AM · User-Ryasmeen, VisualEditor-VisualDiffs, VisualEditor

Aug 1 2017

Schnark created T172177: Rounding errors for step on NumberInputWidget.
Aug 1 2017, 10:09 AM · OOjs-UI

Jul 28 2017

Schnark created T171937: Visual diff broken for revision deletions.
Jul 28 2017, 8:56 AM · MediaWiki-Revision-deletion, VisualEditor-VisualDiffs, VisualEditor
Schnark added a comment to T171861: Show reference list for context whenever any change is made to a reference.

As far as I can tell (from just looking at visual diffs sometimes) this has already been done. When the issue was reported on mw, the list of references was never shown in the diff as far as I remember. But since then I have seen lists of references in visual diffs.

Jul 28 2017, 7:30 AM · VisualEditor-VisualDiffs, VisualEditor

Jul 27 2017

Schnark created T171821: Visual diff on Special:ComparePages just shows loading bar.
Jul 27 2017, 8:13 AM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), Patch-For-Review, VisualEditor-VisualDiffs, VisualEditor
Schnark added a comment to T169325: Consider clarifying the visual language for Visual Diffs.

I'm wondering whether it is really necessary that the diff tells you exactly where each of the paragraphs moved.
Of course, one could create a diff view that tells you exactly: "The first paragraph was moved 3 places down, the second 1 up, the third stayed in its place (except that no 1 moved past it), and ..."
Does this really add clarity over a diff view that tells you: "The paragraphs were heavily re-ordered, but except this minor typo correction shown in red and green, no other changes to the text occurred. If you want to see and compare the order of the paragraphs before and after the edit, please look at the old and new version."
I'm not saying that there is no point in showing the user which moves happened, but for simple moves it should be easy to understand for any reasonable presentation, while for complicated moves it will be hard in any presentation of the diff.

Jul 27 2017, 7:19 AM · VisualEditor, VisualEditor-VisualDiffs
Schnark added a comment to T171377: Changing a reference shows useless and confusing details in visual diff.

I don't really care whether the reference shows up as deleted and inserted vs. changed. But all those internal changes ("mw", "listIndex", "listKey", "contetsUsed", "refListItemId") shouldn't be shown to a user. Instead, the annotation could just show something like "This reference has been changed in some way."

Jul 27 2017, 6:58 AM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, VisualEditor, Cite, VisualEditor-VisualDiffs

Jul 25 2017

Schnark added a comment to T171563: Implement better default protection model for JS files that are not in MediaWiki namespace.

Whether a shared JS is "critical" or not does not only depend on how many users import it, but mainly on whether a sysop imports it. Any such script could be used to gain access to sysop rights and thus should be protected the same way as MediaWiki:Common.js. I do not think there are that many non-critical scripts to justify a new group. If you don't trust them enough to grant them the editinterface right, they shouldn't be able to edit any shared JS at all.
Instead, I'd like to propose that JS/CSS pages outside MediaWiki: or User: namespace (or other namespaces like Gadget: where they are protected automatically) should be deprecated, and MW finally should stop to send them with a text/javascript MIME type even if requested so, and additionally set the X-Content-Type-Options: nosniff header to make browsers accept that and not to execute such scripts.

Jul 25 2017, 8:11 AM · MediaWiki-Page-protection, Security-General, JavaScript
Schnark added a comment to T170235: Visual diff (on history page) shows changes to reference numbers caused by inserting more references.

Example 1 is what I would expect.
In Example 2, two things could be changed (though I'm not sure that they actually should be changed):

  • Additionally, the text with the reference numbers could be shown, with the reference numbers highlighted and annotated as "changed". Currently you can see that references 1 and 2 have been changed, but it's missing the context. In this example where both references belong to the same sentence this doesn't matter, but if they belonged to different sentences it would be nice to see them in the diff, too.
  • Instead of showing that the two references were both completely changed, the diff could show that they were just exchanged. But given that this isn't done for normal ordered lists either (to test, exchange # Point and # Cube on your example page), I don't think this should have high priority.

In Example 3 it's debatable whether the list of references should be shown with a change, as it doesn't look the same before and after the edit, but in this case I think it makes things clearer by leaving it out. This might change when there are more changes to references, though.

Jul 25 2017, 7:30 AM · Patch-For-Review, VisualEditor, VisualEditor-VisualDiffs

Jul 24 2017

Schnark created T171437: Allow easily extending the diff mode switcher in page history.
Jul 24 2017, 8:21 AM · VisualEditor-VisualDiffs, VisualEditor
Schnark created T171431: Thank button in mobile view sometimes with unresolved GENDER.
Jul 24 2017, 7:23 AM · MobileFrontend

Jul 22 2017

Schnark created T171377: Changing a reference shows useless and confusing details in visual diff.
Jul 22 2017, 8:35 AM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, VisualEditor, Cite, VisualEditor-VisualDiffs
Schnark added a comment to T171276: Impossible to split a list by repeatedly pressing enter inside the list.

I tested in LibreOffice Writer: To split a list, you have to press the Enter key twice, the first one creates an empty item in the middle of the list, the second one removes that empty item and replaces it by a paragraph. That is what I intuitively tried in my edit, but this doesn't work in VE. In LibreOffice, unindenting the item actually just unindents it.
Of course, LibreOffice isn't "most editors", but I wouldn't be surprised if the method "press Enter twice" is more common.

Jul 22 2017, 7:56 AM · VisualEditor

Jul 21 2017

Schnark created T171276: Impossible to split a list by repeatedly pressing enter inside the list.
Jul 21 2017, 8:27 AM · VisualEditor

Jul 20 2017

Schnark added a comment to T169398: In visual diff, parameter changes to templates inside references are shown out of place.

When I originally reported this, the two change annotations were at the top of the annotation column, while the actual changes were not shown at all, so the main issue here has actually been fixed already.
As noted by Esanders, the order of the annotations is wrong, but that's only a minor issue compared to my original report.

Jul 20 2017, 8:22 AM · User-Ryasmeen, VisualEditor-VisualDiffs, VisualEditor
RandomDSdevel awarded T168040: Table of contents (TOC) missing sporadically without apparent reason a Baby Tequila token.
Jul 20 2017, 1:47 AM · Readers-Web-Backlog (Tracking), User-notice, MediaWiki-Parser, Regression, MediaWiki-Interface

Jul 17 2017

Schnark added a comment to T170748: After checking the preview, the NWE appears one more plus (+) icon after the categories.

This is a bug in the HotCat gadget, which reacts poorly to the wikipage.content hook. HotCat bugs aren't handled here, but given that my report almost a year ago on commons about this issue wasn't handled there either and the fact that there are many tasks in Phabricator for HotCat, let's see if someone wants to fix the issue given this report here.

Jul 17 2017, 8:22 AM · Commons, Wikimedia-General-or-Unknown, User-Ryasmeen