Schnark (Michael M.)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 7:11 AM (201 w, 1 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Schnark [ Global Accounts ]

Recent Activity

Sat, Aug 11

Schnark merged T201743: Changing the menu language on some content page does not (always) work into T196314: UniversalLanguageSelector doesn't work if language is set globally in global preferences.
Sat, Aug 11, 8:40 AM · MediaWiki-extensions-GlobalPreferences, UniversalLanguageSelector
Schnark merged task T201743: Changing the menu language on some content page does not (always) work into T196314: UniversalLanguageSelector doesn't work if language is set globally in global preferences.
Sat, Aug 11, 8:40 AM

Wed, Aug 8

Schnark added a comment to T199925: Be able to insert horizontal rules (<hr> or ----).

Yes, "sequences" are only triggered if you actually type them (or at least the last character). I consider them in the same class a keyboard shortcuts, so for me that makes sense.

Wed, Aug 8, 7:03 AM · Verified, VisualEditor (Current work), VisualEditor-MediaWiki, User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16))

Wed, Aug 1

Schnark added a comment to T200877: Forbid use of $.each, $.map, $.isArray in core JavaScript code.

Your first approach does work, but can require some re-writing (especially as you have to assign the object to a variable if it isn't already), which probably is acceptable, but it definitely isn't a trivial replacement like the others.
Your second approach doesn't work, due to limited browser support (i.e., it doesn't work in all Grade A browsers, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries#Browser_compatibility).

Wed, Aug 1, 9:44 AM · MediaWiki-Core-Tests, Performance-Team (Radar), Google-Code-in-2018, Patch-For-Review, Readers-Web-Backlog, User-Jdlrobson
Schnark added a comment to T200877: Forbid use of $.each, $.map, $.isArray in core JavaScript code.
but I think $.each( object, callback ) is a valid use that shouldn't be deprecated.

Why? What is the advantage of using this over casting to an array and using Array.forEach ?

I do agree with you that $.each shouldn't be used for arrays, where forEach is the better choice, but that doesn't work on plain objects.

Wed, Aug 1, 8:03 AM · MediaWiki-Core-Tests, Performance-Team (Radar), Google-Code-in-2018, Patch-For-Review, Readers-Web-Backlog, User-Jdlrobson
Schnark added a comment to T200877: Forbid use of $.each, $.map, $.isArray in core JavaScript code.

$.each and $.map can be used on plain objects as well (http://api.jquery.com/jquery.each/#jQuery-each-object-callback, http://api.jquery.com/jquery.map/#jQuery-map-object-callback), where they doesn't have simple equivalents in core JS. $.map is a bit strange on objects, as it will return an array (which may be unexpected), so it might be a good idea to avoid it anyway, but I think $.each( object, callback ) is a valid use that shouldn't be deprecated.

Wed, Aug 1, 7:51 AM · MediaWiki-Core-Tests, Performance-Team (Radar), Google-Code-in-2018, Patch-For-Review, Readers-Web-Backlog, User-Jdlrobson

Fri, Jul 27

Schnark added a comment to T200469: Improve documentation on how to write user scripts and gadgets for VisualEditor.

but nobody says that the existing documentation worked and covered everything they needed to know

The documentation worked for me, and enabled me to write several user scripts (https://de.wikipedia.org/wiki/Spezial:Pr%C3%A4fixindex/User:Schnark/js/ve and some more).
But I'm one of those who prefer reading code even if there is a great documentation, so the current content with some examples and pointers to code and https://doc.wikimedia.org/VisualEditor/master/ fitted my needs perfectly.

Fri, Jul 27, 7:55 AM · Gadgets, Documentation, VisualEditor
Schnark added a comment to T199925: Be able to insert horizontal rules (<hr> or ----).

The old toolbar has a discouraging "Horizontal line (use sparingly)" as tooltip, WikiEditor doesn't have it at all. But I think as a sequence-only command (without tool in the toolbar) it does make sense, though you might want to limit the sequence to take only effect at the start of a paragraph and not inside the text (as that's how it works in wikitext).

Fri, Jul 27, 7:30 AM · Verified, VisualEditor (Current work), VisualEditor-MediaWiki, User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16))

Thu, Jul 26

Schnark added a comment to T200368: Javascript error when opening a page with ?action=edit.

Maybe related or even a duplicate: T199484: Clicking on red link gives error "Uncaught TypeError: Cannot read property 'start' of null" , which also fails on range.start, where range is null.

Thu, Jul 26, 7:31 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Tue, Jul 24

Schnark added a comment to T199561: Update extensions to support GlobalPreferences APIs.

All extensions that write preferences on the client side use the the core mediawiki.api/options.js (or if they don't, they should), so the best solution would be to extend that code to support global preferences. This should magically fix those extensions.

Tue, Jul 24, 7:05 AM · MediaWiki-extensions-GlobalPreferences, Community-Tech

Mon, Jul 23

Schnark edited projects for T200186: Broken user page on meta, added: MediaWiki-extensions-Babel; removed Wikimedia-General-or-Unknown.

I can reproduce with only the line
{{#babel:plain=1|zh-cn-N|lzh-3|en-3}}
so let's blame that extension.

Mon, Jul 23, 10:17 AM · MediaWiki-extensions-Babel, Wikimedia-log-errors

Fri, Jul 20

Schnark added a comment to T200006: Visual diffs of categories are confusing since categories aren't rendered .

I think that somewhere I suggested to just add one sentence "There are (also|only) changes to invisible metadata, please see the wikitext diff for details." for all such changes (categories, defaultsort, double underscore stuff, etc.).

Fri, Jul 20, 9:19 AM · VisualEditor-VisualDiffs, VisualEditor

Thu, Jul 19

Schnark added a comment to T199752: Toolbar menu positioning broken when zoom level > 100%.

I can reproduce in Vivaldi, but only if I first zoom in, and then load a new page. It doesn't happen if the page was at 100% zoom when originally loaded, even if zoomed afterwards. It also happens for zoom levels < 100%. Firefox seems unaffected.

Thu, Jul 19, 9:45 AM · VisualEditor
Schnark added a comment to T199740: Bold and big not highlighted correctly in the 2017WTE.

We disabled the bold/italic rules as in some browsers (probably IE) they were causing sub-pixel width differences.

Thu, Jul 19, 7:19 AM · MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Tue, Jul 17

Schnark created T199770: [Regression] Inserted paragraph shown in wrong position in diff.
Tue, Jul 17, 7:53 AM · wikidiff2, MediaWiki-History-or-Diffs, Regression
Schnark added a comment to T199752: Toolbar menu positioning broken when zoom level > 100%.

For me (in Firefox) the menu is positioned correctly in any zoom level, but it reminds me of T194120: Layout of edit mode switcher in old wikitext editor broken in Monobook skin (though that happens in a completely different situation, so it might be completely unrelated).

Tue, Jul 17, 7:27 AM · VisualEditor
Schnark added a comment to T199740: Bold and big not highlighted correctly in the 2017WTE.

For <big> (and headlines) this is not possible, as the text itself always has the same size, and the syntaxhighlight layer must be exactly in the same place, so must use the same fixed size as well.

Tue, Jul 17, 7:20 AM · MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Jul 16 2018

Schnark added a comment to T199572: Why does a single-paragraph, plain-old-text change produce a surprisingly messy diff?.

Actually, it's just the same as T196380: Visual diff shows unchanged text containing a reference as removed/inserted (absent from source diff) , though the reason why the timeout occurs may be different.

Jul 16 2018, 8:36 AM · VisualEditor, VisualEditor-VisualDiffs

Jul 14 2018

Schnark added a comment to T176125: Trying to force the visual editor to load on a talk page whilst logged out causes the welcome dialogue to have no buttons (or other strange behaviour).

The edgiest of edge cases.

Jul 14 2018, 8:33 AM · VisualEditor
Schnark added a comment to T199572: Why does a single-paragraph, plain-old-text change produce a surprisingly messy diff?.

I think this is caused by a) the fact that due to the inserted references the reference indexes of all other refs changed, and b) the timeout that prevents proper diffs inside paragraphs.

Jul 14 2018, 8:29 AM · VisualEditor, VisualEditor-VisualDiffs

Jul 13 2018

Schnark updated the task description for T199411: Forcing visual editing in a non-VE namespace can fail horribly.
Jul 13 2018, 10:00 AM · VisualEditor-Initialisation, VisualEditor

Jul 12 2018

Schnark created T199411: Forcing visual editing in a non-VE namespace can fail horribly.
Jul 12 2018, 7:45 AM · VisualEditor-Initialisation, VisualEditor

Jul 11 2018

Schnark created T199298: Visual diff fails with "jQuery.Deferred exception: listContents is undefined".
Jul 11 2018, 7:29 AM · Verified-in-Phase2, MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), VisualEditor (Current work), VisualEditor-VisualDiffs
Schnark added a comment to T199246: Parsoid should expose content inside <includeonly> to editors instead of hiding it in the meta tag's data-parsoid attribute.

I assume that the dashes don't have anything to do with it (https://de.wikipedia.org/w/index.php?title=Intermodulation&diff=prev&oldid=179042962&diffmode=visual works as expected), but the fact that the change is inside the includeonly part.

Jul 11 2018, 7:25 AM · Parsoid

Jul 9 2018

Schnark added a comment to T197759: Preview shows categories in alphabetical order instead of original one.

Indeed, ve.init.mw.ArticleTarget.prototype.renderCategories does the sorting, and actually seems to do so on purpose, though I don't really understand why (since the hidden cat flag is determined async, the categories might be in random order after the promises are all done, but sorting according to either the sortkey or the category name just doesn't make sense).

Jul 9 2018, 7:17 AM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Verified, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor

Jul 5 2018

Schnark added a comment to T181491: Langlink box has scrollbar in Firefox.

I can still reproduce this in Firefox ESR 60 on Linux, and can confirm that the proposed patch fixes this.
The overflow: auto actually is with the grandparent #mw-related-navigation .sidebar-chunk.

Jul 5 2018, 9:54 AM · Patch-For-Review, Browser-Support-Firefox, Timeless

Jul 4 2018

Schnark added a comment to T198759: Vector menu tabs animates in-and-out twice instead of once before settling.

Is this really a regression? According to T71729#2937052 this has always been the case since the animation at least doesn't happen infinitely.

Jul 4 2018, 8:48 AM · Readers-Web-Backlog (Tracking), Performance-Team (Radar), Vector
Schnark added a comment to T198719: jquery.ime keyboard layouts that convert letters to combining characters works incorrectly.

It already reverts to o~/ when you click in another paragraph.

Jul 4 2018, 8:43 AM · UniversalLanguageSelector, VisualEditor

Jul 3 2018

Schnark updated subscribers of T198660: [Regression pre-wmf.12] VE crashes with an error "VM51:1122 Uncaught TypeError: Cannot read property 'thumbtime' of undefined" while trying to add an image .

Caused by rEVED715d67b5647f: Pass page parameter for multipage file (PDF, DjVu) thumbnails: The || {} was important.

Jul 3 2018, 8:48 AM · User-Ryasmeen, Verified, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor-Media, VisualEditor (Current work)

Jul 2 2018

Schnark added a comment to T198597: List entries in recent changes contain U+0E20 (or U+200E?).

That's not U+0E20, but U+200E, LEFT-TO-RIGHT MARK, which is necessary for correct display should the title end with a letter from an right-to-left script.

Jul 2 2018, 9:17 AM · MediaWiki-Watchlist, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage

Jun 30 2018

Schnark created T198524: Form for action=purge should have autofocus on button.
Jun 30 2018, 9:17 AM · MediaWiki-Interface

Jun 28 2018

Schnark added a comment to T198150: 'thumbtime' not preserved when re-generating view rendering of video thumbnail in VE.

The same problem also affects other extension thumbnail parameters, e.g. page=N for PDF files:

[[File:The Sad, Sad Story of Social Wikipedia.pdf|thumb|page=3]]
Jun 28 2018, 9:52 AM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor-MediaWiki, VisualEditor (Current work)
Schnark added a project to T198278: [Regression ?] The text typed on the first line while adding a new section is blurry on Firefox: MediaWiki-extensions-CodeMirror.
Jun 28 2018, 7:01 AM · MediaWiki-extensions-CodeMirror, VisualEditor

Jun 27 2018

Schnark added a comment to T198278: [Regression ?] The text typed on the first line while adding a new section is blurry on Firefox.

Is this with CodeMirror's syntaxhighlight enabled? I don't get a blurry text, but I do see a slight horizontal offset of the cursor.

Jun 27 2018, 7:21 AM · MediaWiki-extensions-CodeMirror, VisualEditor
Schnark added a project to T198276: VE Wikitext editor cursor is misplaced on Minerva desktop: MediaWiki-extensions-CodeMirror.
Jun 27 2018, 7:17 AM · MediaWiki-extensions-CodeMirror, VisualEditor, MinervaNeue (Desktop)

Jun 25 2018

Schnark added a comment to T75714: ResourceLoader JavaScript parser should allow ES6 syntax features .

I have also removed the sub task for requiring ES6 for MediaWiki Grade A code because that can be enforced statically via ESLint already. It does not prevent us from being able to parse and validate ES6 syntax in user scripts or other opt-in areas.

Jun 25 2018, 7:55 AM · Performance-Team, MediaWiki-ResourceLoader

Jun 22 2018

Schnark created T197928: Visual diff shows non-minimal diff that could easily be improved.
Jun 22 2018, 7:17 AM · VisualEditor, VisualEditor-VisualDiffs

Jun 21 2018

Schnark created T197852: Don't sort categories alphabetically.
Jun 21 2018, 10:20 AM · Patch-For-Review, Timeless
Schnark merged T197846: JavaScript parse error into T96901: ResourceLoader JavaScript parser should allow ES5 syntax features .
Jun 21 2018, 8:54 AM · Performance-Team, MediaWiki-ResourceLoader
Schnark merged task T197846: JavaScript parse error into T96901: ResourceLoader JavaScript parser should allow ES5 syntax features .
Jun 21 2018, 8:54 AM · Performance-Team, MediaWiki-ResourceLoader
Schnark added a comment to T197846: JavaScript parse error.

The line is

Jun 21 2018, 8:54 AM · Performance-Team, MediaWiki-ResourceLoader

Jun 20 2018

Schnark created T197762: Probably wrong usage of "this" in ve.init.mw.DesktopArticleTarget.js.
Jun 20 2018, 8:45 AM · VisualEditor (Current work), VisualEditor-MediaWiki
Schnark updated the task description for T197760: References can get lost while editing under some circumstances.
Jun 20 2018, 7:51 AM · Parsoid, VisualEditor, VisualEditor-MediaWiki-References
Schnark created T197760: References can get lost while editing under some circumstances.
Jun 20 2018, 7:49 AM · Parsoid, VisualEditor, VisualEditor-MediaWiki-References
Schnark created T197759: Preview shows categories in alphabetical order instead of original one.
Jun 20 2018, 7:41 AM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Verified, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor

Jun 19 2018

Schnark added a comment to T182300: Paragraph indicated as moved, though it wasn't.

Old diff (1):

Jun 19 2018, 7:21 AM · wikidiff2, German-Community-Wishlist, WMDE-QWERTY-Team, MediaWiki-History-or-Diffs, TCB-Team

Jun 18 2018

Schnark created T197569: "Find and replace" tool shown as active in menu after dialog closed.
Jun 18 2018, 7:17 AM · Verified-in-Phase0, VisualEditor (Current work), VisualEditor-MediaWiki

Jun 15 2018

Schnark created T197445: Can't reload a page by clicking article tab after editing in VE.
Jun 15 2018, 8:39 AM · Verified, VisualEditor (Current work), VisualEditor-MediaWiki

Jun 14 2018

Schnark added a comment to T196117: [Regression pre-wmf.7] Drop down for template search results appears to go over the dialog when the template description is too long and not wrapping.

No matter whether it is intentional or not, it certainly is buggy:

  1. Open the template dialog in de.wikipedia.org
  2. Type "a"

-> Menu larger than dialog (which might be intentional)

  1. Type another "a"

-> Menu smaller than input (which looks ugly)

  1. Type another "a"

-> No menu (which is correct)

  1. Delete the last "a"

-> Menu as large as input (which is inconsistent with 3)

  1. Delete the last "a"

-> Menu again as large as input (which is inconsistent with 2)

Jun 14 2018, 10:05 AM · VisualEditor (Current work)

Jun 12 2018

Schnark created T196975: Several commits missing from Diffusion with status "Importing".
Jun 12 2018, 9:54 AM · Phabricator

Jun 11 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rELINT907eab2dde1d: Update patch set 2 (authored by Schnark).
Update patch set 2
Jun 11 2018, 2:21 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rELINTaf937f868505: Update patch set 1 (authored by Schnark).
Update patch set 1
Jun 11 2018, 2:21 PM

Jun 9 2018

Schnark added a comment to T196789: Consider exposing the plain-paste shortcut in the rich-text/plain-text paste dialog somewhere.

Do we have any other shortcuts exposed in dialogs to be consistent with the styling of, or is this treading new ground? (Nothing springs to mind, but...)

Jun 9 2018, 8:59 AM · Patch-For-Review, Design, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Jun 7 2018

Schnark closed T196588: Can't save in VE (due to local scripts on de.wp) as Resolved.

You have to update your https://de.wikipedia.org/wiki/Benutzer:MichaelSchoenitzer/common.js to use https://de.wikipedia.org/wiki/Benutzer:Schnark/js/veSummary.js instead of https://de.wikipedia.org/wiki/Benutzer:Schnark/veEditsummary.js.

Jun 7 2018, 8:30 AM · User-Ryasmeen, VisualEditor

Jun 5 2018

Schnark added a comment to T196215: Responsive Layout for Monobook broken when standard user scripts are used.

I do not use any of these scripts myself, but one script collection which I know is affected is the very popular fliegelflagel by @Schnark.

Jun 5 2018, 9:21 AM · User-notice, MonoBook
Schnark added a comment to T165945: Timeless: Re-evaluate width cutoffs.

For reference, the position of the "Page tools" is discussed in T160651: Better handling for tools block, and I agree with Evad37 that I prefer them at the top-right. So I think that before making a change that would result in the one-sidebar-mode instead of two-sidebar-mode for many users, you should make sure that even in the one-sidebar-mode the "Page tools" are shown in a prominent place, and not somewhere below the fold.

Jun 5 2018, 7:29 AM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, Timeless

Jun 4 2018

Schnark created T196343: Changing an image should always be shown as deletion + insertion in visual diff.
Jun 4 2018, 10:20 AM · Verified-in-Phase2, MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), VisualEditor (Current work), VisualEditor-VisualDiffs

Jun 1 2018

Schnark added a comment to T195946: Allow editors to style main page's differently from other pages for performance and to allow creativity (e.g. MediaWiki:Mainpage.css).

T78418: Introduce MediaWiki:Mainpage.css has actually been discussed before and declined.

Jun 1 2018, 8:18 AM · Performance-Team, MediaWiki-ResourceLoader, MediaWiki-Interface, MediaWiki-Platform-Team, Readers-Web-Backlog, Performance
Restricted Application added a project to T78418: Introduce MediaWiki:Mainpage.css: Performance-Team.
Jun 1 2018, 8:18 AM · Performance-Team, Technical-Debt, MediaWiki-ResourceLoader
Schnark added a comment to T155976: Floating menu (attached to MWSaveDialog's editSummaryInput by a script/gadget) can be misplaced under certain circumstances.

JFTR: In my user script I use a different approach now (for different reasons), so I'm no longer affected by this bug. So unless someone else runs into this somewhere else, it probably can be ignored.

Jun 1 2018, 7:33 AM · VisualEditor-MediaWiki, VisualEditor

May 28 2018

Schnark created T195733: Optionally convert inserted URLs to wikilink syntax.
May 28 2018, 7:30 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

May 23 2018

Schnark created T195345: When visual diff times out, offer a way to retry with more time.
May 23 2018, 8:10 AM · VisualEditor-VisualDiffs, VisualEditor
Schnark created T195344: Unchanged alien nodes sometimes show up in visual diff.
May 23 2018, 7:55 AM · MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), VisualEditor (Current work), VisualEditor-VisualDiffs
Schnark added a comment to T195323: Visual Editor changes dialog hangs when clicking on preview on pages without categories.

According to the code (https://phabricator.wikimedia.org/diffusion/EVED/browse/master/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js;5330e42dc7ae09abf505a2494e22c6e1768331ad$277) this only happens on pages without categories, but when it happens it is really annoying.

May 23 2018, 7:12 AM · MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), VisualEditor-MediaWiki, VisualEditor (Current work)

May 17 2018

Schnark added a comment to T194865: List output by fullname (without image) for Special:UnusedImages.

able to be accessible through the API

May 17 2018, 7:23 AM · MediaWiki-Special-pages

May 15 2018

Schnark added a comment to T194323: [Regression wmf.3] Selecting "Collapsed initially" makes the table look broken with an unclickable useless text [Expand].

@Schnark I don't know. If it doesn't, a separate task can be filed for that.

May 15 2018, 7:05 AM · Verified, User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), VisualEditor (Current work), VisualEditor-MediaWiki
Schnark created T194725: Collapsed tables broken in visual diff.
May 15 2018, 7:04 AM · Verified-in-Phase2, Verified-in-Phase0, Verified, MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), VisualEditor (Current work), VisualEditor-VisualDiffs

May 14 2018

Schnark created T194631: Canceling section edit in NWE takes you to start of page.
May 14 2018, 9:04 AM · Verified, MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
Schnark created T194622: MenuTagMultiselectWidget: `draggable: false` doesn't do anything.
May 14 2018, 7:50 AM · OOUI

May 11 2018

Schnark created T194463: Hashlinks with question marks shown as missing articles in preview.
May 11 2018, 9:15 AM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
Schnark added a comment to T170129: Use NWE + CodeMirror for JS/CSS pages.

If somebody comes here because he like me wants to use the same editor for all edits, https://de.wikipedia.org/wiki/Benutzer:Schnark/js/veCode.js enables NWE for JS/CSS, too. A documentation (German only, sorry) is on https://de.wikipedia.org/wiki/Benutzer:Schnark/js/veCode.

May 11 2018, 8:48 AM · MediaWiki-extensions-CodeMirror, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Schnark added a comment to T194323: [Regression wmf.3] Selecting "Collapsed initially" makes the table look broken with an unclickable useless text [Expand].

Does the above patch also address the issue in visual diffs? E.g. in https://de.wikipedia.org/w/index.php?title=Benutzer:Schnark/js&diff=prev&oldid=177332168&diffmode=visual the table is currently broken and even though I didn't test, I think the patch only fixes this for editing, not in diff.

May 11 2018, 8:46 AM · Verified, User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), VisualEditor (Current work), VisualEditor-MediaWiki
Schnark created T194458: VisualEditor: Only show edit summary remaining character countdown for last 99 characters.
May 11 2018, 8:07 AM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), VisualEditor (Current work), VisualEditor-MediaWiki
Schnark added a comment to T194122: Cursor position sometimes gets lost when switching from temporary wikitext editor to final editor.

The best way to avoid this bug seems to be to try to reproduce it ...

I think it is something that happens after https://gerrit.wikimedia.org/g/mediawiki/extensions/VisualEditor/+/master/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js#147, but before https://gerrit.wikimedia.org/g/mediawiki/extensions/VisualEditor/+/master/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js#469. It's obvious that any cursor change between these two points will be ignored, but I have no idea how much time there is between them.

I also have "search as you type" enabled in Firefox, so when I type something while the temporary editor is read-only, this will invoke the search, and so moves the focus. So this setting might have something to do with this issue.

In the first call you link to we do tempWikitextEditor.$element.prop( 'readonly', true ); which means no more input is allowed. (I note that in Firefox you can still move the cursor, but that would manifest as a different issue).

May 11 2018, 7:39 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

May 9 2018

Schnark added a comment to T194122: Cursor position sometimes gets lost when switching from temporary wikitext editor to final editor.

The best way to avoid this bug seems to be to try to reproduce it ...

May 9 2018, 9:57 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Schnark added a comment to T194122: Cursor position sometimes gets lost when switching from temporary wikitext editor to final editor.

Do you have syntax highlight enabled?

May 9 2018, 6:50 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

May 8 2018

Schnark created T194122: Cursor position sometimes gets lost when switching from temporary wikitext editor to final editor.
May 8 2018, 7:39 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Schnark created T194120: Layout of edit mode switcher in old wikitext editor broken in Monobook skin.
May 8 2018, 7:21 AM · MonoBook, MediaWiki-Page-editing

May 7 2018

Schnark added a comment to T171437: Allow easily extending the diff mode switcher in page history.

Actually, due to the fact that my script supports 4 modes (diff while editing in VE, diff while editing in OWE, historical diff without VisualDiff, and historical diff including VisualDiff), but can combine the last 3 into one function, I'm not so sure, whether I'd actually any advanced features to extend the VisualDiff for historical diffs, as this would just force me to maintain 3 ways instead of 2.
So I think the only issues worth considering are:

  • The ButtonSelectWidget for switching the mode should be accessible from scripts (which would allow me to interact with it without triggering simulated click events).
  • The code that enforces a valid mode (line 19ff) should allow me to specify my own mode. Currently, when I add diffmode=schnark to the URL (which would be handled by my script), the code will reset it to source and also adapt the URL before I have a chance to react to that URL parameter.
May 7 2018, 9:59 AM · VisualEditor-VisualDiffs, VisualEditor

May 5 2018

Schnark created T193925: Notice about diff over multiple revisions missing in visual diffs.
May 5 2018, 8:33 AM · MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), Patch-For-Review, VisualEditor (Current work), VisualEditor-VisualDiffs

May 4 2018

Schnark created T193848: https://wikitech.wikimedia.org/view/ no longer redirects to /wiki.
May 4 2018, 9:52 AM · cloud-services-team, Wikimedia-Apache-configuration, Regression, wikitech.wikimedia.org
Schnark created T193839: Consider adding back RevisionSlider header to VisualDiffs.
May 4 2018, 8:00 AM · MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), VisualEditor (Current work), VisualEditor-VisualDiffs
Schnark added a comment to T193624: Make language screenshot bot use a bigger window.

Yeah, slightly worrying that we got different heights on the same(?) bot run...

May 4 2018, 7:16 AM · User-zeljkofilipin, Browser-Tests, VisualEditor

May 3 2018

Schnark created T193721: Deleting last use of a named ref defined in <references> block should delete that ref.
May 3 2018, 9:41 AM · Parsoid, VisualEditor, VisualEditor-MediaWiki-References
Schnark added a comment to T193624: Make language screenshot bot use a bigger window.

Even worse example: https://commons.wikimedia.org/wiki/File:VisualEditor_References_List_Insert_Menu-ilo.png

May 3 2018, 9:26 AM · User-zeljkofilipin, Browser-Tests, VisualEditor

Apr 27 2018

Schnark added a comment to T193207: "?uselang=qqx" throws exceptions with VisualEditor.

After a quick search, I'd blame https://ru.wikipedia.org/wiki/MediaWiki:Gadget-iwcore.js on this, wgLangNames[ conf.wgUserLanguage ] breaks when wgLangNames is undefined. That variable is defined at the bottom of the script, but only when the user's language is ru. So when this gadget is enabled, I expect things to break for any language other then Russian, and nothing specific to the pseudo langauge qqx.

Apr 27 2018, 10:10 AM · VisualEditor
Schnark created T193219: Lineheight out of sync for long articles in NWE with syntaxhighlight.
Apr 27 2018, 7:46 AM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), VisualEditor (Current work), Community-Tech, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror

Apr 26 2018

Schnark created T193120: Word processor toolbars on demo page allow selecting multiple block-level formats .
Apr 26 2018, 9:30 AM · Documentation, OOUI
Schnark created T193119: Menu of MenuTagMultiselectWidget won't easily reopen after you selected an entry.
Apr 26 2018, 9:21 AM · OOUI
Schnark merged T193117: When creating a new section with preloadtitle in NWE, text about loading editor isn't removed into T192901: "TypeError: Cannot read property 'isDisabled' of null" when opening the editor for new section with predefined heading (section=new&preloadtitle=Test).
Apr 26 2018, 7:55 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor, Beta-Feature
Schnark merged task T193117: When creating a new section with preloadtitle in NWE, text about loading editor isn't removed into T192901: "TypeError: Cannot read property 'isDisabled' of null" when opening the editor for new section with predefined heading (section=new&preloadtitle=Test).
Apr 26 2018, 7:55 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Schnark added a comment to T193000: Expose basic article identifiers (title, variant, revision...) to HTML scrapers.

MediaWiki scripts rely on page variables instead, but those use mw.config so they are not in a parsable format.

Apr 26 2018, 7:40 AM · MediaWiki-API
Schnark created T193117: When creating a new section with preloadtitle in NWE, text about loading editor isn't removed.
Apr 26 2018, 7:05 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Apr 25 2018

Schnark added a comment to T192755: Simply cloning diff header disrupts user scripts and causes other issues.

Alternatively one could wrap the header in <thead>, and the actual diff in <tbody> and then only hide the body when switching to visual (and toggle the data-attributes).

Apr 25 2018, 9:32 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor-MediaWiki, VisualEditor (Current work), VisualEditor-VisualDiffs
Schnark added a comment to T192951: Incorrect display of OOUI checkboxes on 2010 editor.

(Opera 36 is probably the best option if you're stuck on Windows XP. I don't think anyone else supported Windows XP for as long as they did.)

Apr 25 2018, 8:01 AM · Wikimedia-General-or-Unknown, OOUI

Apr 24 2018

Schnark added a comment to T192823: Use top alignment for multi-line check/radio labels.

This actually is a duplicate of T184526: Multi-line checkbox/radio labels should be aligned to the top, not middle, but I can't decide in which direction this should be merged, so I leave that to you.

Apr 24 2018, 6:57 AM · OOUI

Apr 23 2018

Schnark created T192755: Simply cloning diff header disrupts user scripts and causes other issues.
Apr 23 2018, 7:08 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor-MediaWiki, VisualEditor (Current work), VisualEditor-VisualDiffs

Apr 17 2018

Schnark added a comment to T192341: Alternatives for “Clear styling” icon.

Additionally, a separate "unlink" icon (i.e. crossed out variant of the current "link" icon) for removing a link would perhaps make sense.

Apr 17 2018, 9:50 AM · Design, VisualEditor
Schnark added a comment to T192341: Alternatives for “Clear styling” icon.

From a user's perspective:
4c looks to me very much like "subscript". Also, what's the rationale behind using a "T", when the other formatting icons (like big and small, and some language variants) use "A"?

Apr 17 2018, 9:44 AM · Design, VisualEditor

Apr 16 2018

Schnark awarded T192258: VisualEditor: Add a shortcut to add an image a Like token.
Apr 16 2018, 10:01 AM · VisualEditor