Page MenuHomePhabricator

Seb35 (Seb35)
MediaWiki gnome

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 9:50 AM (451 w, 5 d)
Availability
Available
IRC Nick
seb35
LDAP User
Seb35
MediaWiki User
Seb35 [ Global Accounts ]

I follow MediaWiki development since 2007. Although I don’t regularly submit patches for the MediaWiki core, I act as an ambassador, submitting bugs, helping in their resolution, exchanging with the French-speaking community, improving documentation and its translation into French, etc. I developed three extensions (BackwardsTimeTravel, HSTS, and MediaWikiFarm).

Since 2016, I run a small MediaWiki consulting company in France, which help companies, associations and public sector to set up MediaWiki installations. We also have a farm mainly with private wikis; the farm is managed by MediaWikiFarm.

My GitHub account is Seb35.

Recent Activity

Mon, May 15

Seb35 added a comment to T53110: Provide a way to exclude certain links to disambiguation pages from [[Special:DisambiguationPageLinks]].

As said above, this task makes [[Special:DisambiguationPageLinks]] useless on most wikis given there are legitimate links to disambiguations pages, often in header templates.

Mon, May 15, 4:28 PM · MediaWiki-extensions-Disambiguator

May 3 2023

Seb35 added a comment to T213083: NumerAlpha extension: PHP Notice: Undefined index: full level prefix in NumerAlpha.class.php on line 266.

Imvuong provided a solution in the linked topic on MediaWiki.org, and I aggree with them: when full level prefix is not defined, it should be defined to the empty string, which is the default value in the powerful parser function {{counter:}}.

May 3 2023, 3:12 PM · MediaWiki-extensions-Other

Apr 17 2023

Seb35 added a comment to T203256: OATH (2FA) needs an option to remember device but not keep user logged in.

There may be situations where the user connects in a semi-trusted device and don’t want to let some secondary authentication token, e.g. when s/he uses a public library computer or a colleague’s computer. For instance it happened to me recently during a editathon where I had to use a public library computer (the WiFi was too secure and not available to visitors). Of course, a private browsing is preferable in this situation, when available.

Apr 17 2023, 3:15 PM · MediaWiki-extensions-OATHAuth

Apr 6 2023

Seb35 added a comment to T327584: Exception when the title is malformed.

This bug is fixed from version 1.40 (branch REL1_40).

Apr 6 2023, 7:04 PM · MediaWiki-extensions-Title-Icon

Feb 27 2023

Seb35 closed T273687: ProtectSite may grant rights to users they do not otherwise have as Resolved.

This is now fixed in branch master, so it will in branches REL1_40 and further, and in versions 0.5.4+.

Feb 27 2023, 10:53 AM · MediaWiki-extensions-ProtectSite, Uncyclomedia, ShoutWiki
Seb35 updated the task description for T330623: On-page debug log is empty.
Feb 27 2023, 8:44 AM · Patch-For-Review, MediaWiki-Debug-Logger
Seb35 updated the task description for T330623: On-page debug log is empty.
Feb 27 2023, 8:42 AM · Patch-For-Review, MediaWiki-Debug-Logger
Seb35 renamed T330623: On-page debug log is empty from On-page debug log is emtpy to On-page debug log is empty.
Feb 27 2023, 8:41 AM · Patch-For-Review, MediaWiki-Debug-Logger
Seb35 added a comment to T330623: On-page debug log is empty.

This bug is with the default LegacySpi, there is also T114532 with MonologSpi.

Feb 27 2023, 8:24 AM · Patch-For-Review, MediaWiki-Debug-Logger
Seb35 created T330623: On-page debug log is empty.
Feb 27 2023, 8:22 AM · Patch-For-Review, MediaWiki-Debug-Logger
Seb35 committed rEPRO385120e2c19a: Never grant rights when protecting the site (authored by Seb35).
Never grant rights when protecting the site
Feb 27 2023, 2:17 AM

Feb 26 2023

Seb35 added a comment to T168783: A failed CAPTCHA during account creation doesn't block the account request.

Fixed in branch REL1_39+ (version 1.39+). I updated MW.org.

Feb 26 2023, 1:09 PM · MediaWiki-extensions-ConfirmAccount

Feb 14 2023

Seb35 updated the task description for T10819: Full Path Disclosure vulnerability in MediaWiki 1.9.1.
Feb 14 2023, 6:14 PM · MediaWiki-Templates
Seb35 added a comment to T10819: Full Path Disclosure vulnerability in MediaWiki 1.9.1.

For reference this was fixed in Git commit 90759fa8a1a5187d881763ea89f9ca2f0a5f8a4a.

Feb 14 2023, 10:53 AM · MediaWiki-Templates

Feb 2 2023

Seb35 committed rECACc78c03dca122: Do verify the captcha (authored by Seb35).
Do verify the captcha
Feb 2 2023, 10:37 PM

Jan 21 2023

Seb35 added a comment to T312589: Graph is storing a stdClass not a JsonUnserializable.

I remarked there are two unserializations in IconManager, and removing the internal unserialization seems to fix the failing tests.

Jan 21 2023, 11:32 PM · Patch-Needs-Improvement, MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), MediaWiki-extensions-Graph, MediaWiki-Parser, Wikimedia-production-error
Seb35 added a comment to T312589: Graph is storing a stdClass not a JsonUnserializable.

The extension TitleIcon has a wrong unserialization since 96e4f5d8402 (more exactly the class MediaWiki\Extension\TitleIcon\Icon): see for instance the patch I am preparing, but the failing tests are independent of the patch and fail exactly when MediaWiki has 96e4f5d8402.

Jan 21 2023, 10:56 PM · Patch-Needs-Improvement, MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), MediaWiki-extensions-Graph, MediaWiki-Parser, Wikimedia-production-error
Seb35 triaged T327584: Exception when the title is malformed as Low priority.
Jan 21 2023, 7:41 PM · MediaWiki-extensions-Title-Icon
Seb35 added a comment to T327584: Exception when the title is malformed.

And here is the corresponding patch

Jan 21 2023, 7:31 PM · MediaWiki-extensions-Title-Icon
Seb35 created T327584: Exception when the title is malformed.
Jan 21 2023, 7:30 PM · MediaWiki-extensions-Title-Icon

Jan 17 2023

Seb35 added a comment to T168783: A failed CAPTCHA during account creation doesn't block the account request.

@Seb35 Will it be possible to back-port this to MW 1.39 since this the the LTS branch? Will be cool I believe.

Jan 17 2023, 3:22 PM · MediaWiki-extensions-ConfirmAccount

Jan 10 2023

Seb35 added a comment to T311449: ConfirmEdit - HCaptcha no longer working with Visual Editor in 1.38.1.

[e2b82f9bd017f414a556d7a9] /load.php?lang=en&modules=startup&only=scripts&raw=1&skin=chameleon TypeError: Argument 1 passed to MediaWiki\Extension\ConfirmEdit\hCaptcha\Hooks\ResourceLoaderHooks::getHCaptchaResourceLoaderConfig() must be an instance of MediaWiki\ResourceLoader\Context, instance of ResourceLoaderContext given, called in ----/includes/resourceloader/ResourceLoaderFileModule.php on line 1312

Jan 10 2023, 8:40 PM · MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), ConfirmEdit (CAPTCHA extension)

Nov 28 2022

Seb35 added a comment to T311167: Hit Count reported in Popular Pages is incorrect.

This is caused by rEHTC6827d8cdd7420074c50d38a8724c72fac5feac32: the SQL query constructed by MediaWiki is SELECT … FROM page p,hit_counter h ORDER BY … instead of SELECT … FROM hit_counter h JOIN page p ON ((p.page_id = h.page_id)) ORDER BY … (I removed the backticks here for readability), so a cross product is computed by MySQL instead of a JOIN.

Nov 28 2022, 4:36 PM · MW-1.39-release, MW-1.38-release, MediaWiki-extensions-HitCounters

Oct 22 2022

Seb35 merged T202235: MediaWiki 1.31 : Error from line 4829 of /var/lib/mediawiki/languages/Language.php into T198325: Using $this when not in object context when uploading html file or archive in Html2Wiki 1.31.
Oct 22 2022, 2:33 PM · MediaWiki-extensions-Html2Wiki
Seb35 merged task T202235: MediaWiki 1.31 : Error from line 4829 of /var/lib/mediawiki/languages/Language.php into T198325: Using $this when not in object context when uploading html file or archive in Html2Wiki 1.31.
Oct 22 2022, 2:32 PM · MediaWiki-extensions-Html2Wiki

Oct 17 2022

Seb35 changed the subtype of T320980: Add parameters to control ActorCache from "Task" to "Feature Request".
Oct 17 2022, 3:20 PM · MediaWiki-User-management
Seb35 created T320980: Add parameters to control ActorCache.
Oct 17 2022, 3:18 PM · MediaWiki-User-management

Oct 12 2022

Seb35 closed T168783: A failed CAPTCHA during account creation doesn't block the account request as Resolved.

Fixed in current master, so it will be available in REL1_40+ (version 1.40+).

Oct 12 2022, 12:11 PM · MediaWiki-extensions-ConfirmAccount

Sep 25 2022

Seb35 added a comment to T258537: Fix gitinfo.json issues in extdist.

Example of file generated:

{
  "head": "refs/heads/REL1_39",
  "headSHA1": "9ddf52d2df69634f558d6a3c04d4daa0b06dc4ff",
  "headCommitDate": 1660112594,
  "branch": "REL1_39",
  "remoteURL": "https://gerrit.wikimedia.org/r/mediawiki/extensions/Dashiki"
}
Sep 25 2022, 5:59 PM · Patch-For-Review, VPS-project-Extdist
Seb35 added a comment to T258537: Fix gitinfo.json issues in extdist.

In the linked patch, I changed the following entries in gitinfo.json to make them correspond to the GitInfo class of MediaWiki:

  • branch: changed from the HEAD’s SHA1 to the branch name (e.g. "REL1_39")
  • head: changed from the HEAD’s SHA1 to the branch reference (e.g. "refs/heads/REL1_39")
  • headCommitDate: changed from a string to an int
  • headSHA1: removed the trailing \n
Sep 25 2022, 5:57 PM · Patch-For-Review, VPS-project-Extdist
Seb35 added a comment to T253586: extensions including semantic-forms via composer are broken and breaking extension distributor.

There are no more issue with the mentionned repo SemanticPageSeries (the renaming from semantic-forms to page-forms is finished), but if we want to fix it for an hypothetical other case, including when a repo will be deleted (it will probably happen one day), I have the following proposition:

Sep 25 2022, 5:38 PM · MediaWiki-extensions-SemanticSignup, MediaWiki-extensions-Page_Forms, VPS-project-Extdist
Seb35 removed a project from T253586: extensions including semantic-forms via composer are broken and breaking extension distributor: MediaWiki-extensions-MediaWikiFarm.

I remove the tag MediaWikiFarm since page-forms only appears in test/phpunit/, not the root composer.json.

Sep 25 2022, 3:17 PM · MediaWiki-extensions-SemanticSignup, MediaWiki-extensions-Page_Forms, VPS-project-Extdist

Sep 24 2022

Seb35 added a comment to T253461: Liberate the @ for AtEase.

I modified mw:at-ease to reflect this decision, even if the library is strictly-speaking independent of MediaWiki.

Sep 24 2022, 9:59 PM · Performance-Team, TechCom, MediaWiki-Codesniffer, Proposal, at-ease, MediaWiki-General
Seb35 added a comment to T273687: ProtectSite may grant rights to users they do not otherwise have.

I propose the linked patch, adding on each right a preliminary condition ( $wgGroupPermissions[$group][$right] ?? false ) && … to be sure no right can be added but only removed.

Sep 24 2022, 7:15 PM · MediaWiki-extensions-ProtectSite, Uncyclomedia, ShoutWiki

Sep 21 2022

Seb35 committed rECAC9b6e91a3a364: Do verify the captcha (authored by Seb35).
Do verify the captcha
Sep 21 2022, 11:59 PM

Sep 9 2022

Seb35 committed rECAC21214092ba1b: Replace deprecated hook PersonalUrls (authored by Seb35).
Replace deprecated hook PersonalUrls
Sep 9 2022, 11:22 PM

Sep 3 2022

Seb35 closed T313937: PageForms: Call to a member function canExist() on null as Resolved.
Sep 3 2022, 6:25 PM · MediaWiki-extensions-Page_Forms

Aug 31 2022

Seb35 reopened T313937: PageForms: Call to a member function canExist() on null as "Open".

I reopen this task given I reached this bug in another code path (MW 1.38.2, PF 5.4 and current master a308554b9). I propose a complementary patch below.

Aug 31 2022, 9:34 AM · MediaWiki-extensions-Page_Forms

Aug 29 2022

Seb35 added a comment to T229092: Investigate migrateActors script failing due to duplicate empty actor_name.

migrateActors.php was added in 1.31 and this the beginning the option IGNORE is not present, so theoretically it could be backported in all versions. I did not request other backports since other versions are no more supported, but perhaps there are exceptions for upgrade-related patches?

Aug 29 2022, 6:24 PM · MW-1.35-notes, MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Platform Engineering (Icebox), MediaWiki-Maintenance-system
Seb35 closed T229092: Investigate migrateActors script failing due to duplicate empty actor_name as Resolved.

I close this task since the patch has been merged in master (future 1.39.0) and REL1_35 (future 1.35.8), which are both LTS versions.
NB: it is not fixed in 1.36, 1.37, or 1.38.

Aug 29 2022, 2:47 PM · MW-1.35-notes, MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Platform Engineering (Icebox), MediaWiki-Maintenance-system
Seb35 closed T229092: Investigate migrateActors script failing due to duplicate empty actor_name, a subtask of T167246: Refactor "user" & "user_text" fields into "actor" reference table, as Resolved.
Aug 29 2022, 2:47 PM · Platform Team Initiatives (Revision Storage Schema Improvements), Schema-change, MediaWiki-General, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Epic

Aug 28 2022

Seb35 removed a project from T283686: Replace Content::getNativeData() calls with TextContent::getText() in Wikibase: Patch-For-Review.

Wrong task number in my patch, I reaffected it. But related to this task to permit the removal of EntityContent::getNativeData().

Aug 28 2022, 6:04 PM · MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), Wikidata, MediaWiki-extensions-WikibaseRepository
Seb35 added a comment to T283691: Replace Content::getNativeData() calls with TextContent::getText() in SemanticACL.

TextContent::getText() was introduced in 1.33, here: rMW54c70c3551ea2b19a8967135fce5913c65e4bfbd.

Aug 28 2022, 5:53 PM · MediaWiki-extensions-SemanticACL
Seb35 added a comment to T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .

Currently AbstractContent::getNativeData() is an abstract method given it is defined in the interface Content but not defined in AbstractContent.

Aug 28 2022, 5:43 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), Platform Engineering (Icebox), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Technical-Debt, User-Daniel, MediaWiki-ContentHandler
Seb35 added a comment to T283686: Replace Content::getNativeData() calls with TextContent::getText() in Wikibase.

Hello team,
I'm working on those sub-tasks to replace Content::getNativeData() to TextContent::getText().
For me is not clear how to replace it in EntityContent as it didn't have any dependency with TextContent.
So we have public method getNativeData in EntityContent that implements from Content, we call this method in getSize(). As we deprecate Content::getNativeData we should remove any usage of this method there.
And as I understand well the propose was to replace it with TextContent::getText().
Could you please provide more details about better way to replace it?

Aug 28 2022, 4:41 PM · MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), Wikidata, MediaWiki-extensions-WikibaseRepository
Seb35 added a comment to T229092: Investigate migrateActors script failing due to duplicate empty actor_name.

I re-tried yesterday in a lab environment to upgrade a wiki created in 2004 and in version 1.27. Probably someone did a hard cleanup (linked to spam?) because many users were missing in the user table and a few log_user_text or rev_user_text were an empty string, leading to this issue. In this case it is hard to re-create these data, even if sometimes possible (see T229092#7730875).

Aug 28 2022, 11:55 AM · MW-1.35-notes, MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Platform Engineering (Icebox), MediaWiki-Maintenance-system
Seb35 added a comment to T315657: Fatal exception of type "TypeError" from TranslatableBundleLogFormatter.php.

This is fixed and deployed in production (1.39.0-wmf.26), isn’t it?

Aug 28 2022, 9:10 AM · User-Urbanecm, Regression, Wikimedia-production-error, MediaWiki-extensions-Translate

Aug 25 2022

Seb35 added a comment to T313517: ApiSandbox 'continue' button breaks on second use.

I was bitten by this bug and found this issue. Here it is the fix as described by @Anomie (I added Co-Authored-by given it is the direct fix you proposed).

Aug 25 2022, 11:20 AM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), MediaWiki-Special-pages, MediaWiki-Action-API

Aug 23 2022

Seb35 added a comment to T217307: PageImages' og:image interferes with the one defined by OpenGraphMeta.

I documented this on MediaWiki.org.

Aug 23 2022, 10:02 AM · Readers-Web-Backlog (Kanbanana-2022-23-Q1), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), patch-welcome, PageImages
Seb35 added a comment to T315740: Fatal error when there is an empty <source/>.

Thanks for catching this and submitting a patch. What is the expectation regarding these empty tags? Do we want to lint them away in the future? Or do we want to continue accepting them?

Aug 23 2022, 9:17 AM · MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Wikimedia-production-error, SyntaxHighlight

Aug 21 2022

Seb35 added a comment to T315827: GenderCache could avoid one SQL request sometimes.

I submit my current proposition as a WIP because it might be sub-optimal if the options of the current user are not loaded (and possibly detrimental to the performance in this specific case).

Aug 21 2022, 7:54 PM · Patch-For-Review, Performance Issue, MediaWiki-General
Seb35 changed the subtype of T315827: GenderCache could avoid one SQL request sometimes from "Bug Report" to "Task".
Aug 21 2022, 7:42 PM · Patch-For-Review, Performance Issue, MediaWiki-General
Seb35 added a comment to T315827: GenderCache could avoid one SQL request sometimes.

In my observations, I assumed the properties of the current user are always loaded, but I’m not completely sure of this in all types of requests.

  • An option is to prove this by checking all code paths.
  • Another option would be to opportunistically ask UserOptionManager::getOption( $wgUser, 'gender' ) in the sense that, if it has the information it’s great, else it doesn’t matter and the information will be retrieved by GenderCache possibly with other requested users. I propose this opportunistic solution because I think (but I might be mistaken) that it should be prefered the SQL request in GenderCache instead of the SQL request of UserOptionManager (at this point we don’t need all user options, only the gender). The downside is that UserOptionManager currently does not implement such opportunistic behaviour.
Aug 21 2022, 7:41 PM · Patch-For-Review, Performance Issue, MediaWiki-General
Seb35 added a comment to T315827: GenderCache could avoid one SQL request sometimes.

There is another task quite near of this one, but centered on LinkCache T297914.

Aug 21 2022, 7:18 PM · Patch-For-Review, Performance Issue, MediaWiki-General
Seb35 created T315827: GenderCache could avoid one SQL request sometimes.
Aug 21 2022, 7:16 PM · Patch-For-Review, Performance Issue, MediaWiki-General

Aug 20 2022

Seb35 renamed T315740: Fatal error when there is an empty <source/> from Fatal error when there is an empty <source/> in Translate-enabled pages to Fatal error when there is an empty <source/>.
Aug 20 2022, 11:11 PM · MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Wikimedia-production-error, SyntaxHighlight
Seb35 removed a project from T315740: Fatal error when there is an empty <source/>: MediaWiki-extensions-Translate.

I remove Translate since I reproduced this locally on both Translate and non-Translate pages.

Aug 20 2022, 11:08 PM · MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Wikimedia-production-error, SyntaxHighlight
Seb35 changed the subtype of T315740: Fatal error when there is an empty <source/> from "Bug Report" to "Production Error".
Aug 20 2022, 10:16 PM · MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Wikimedia-production-error, SyntaxHighlight
Seb35 added a comment to T315740: Fatal error when there is an empty <source/>.

I just see T315657: it could be the same bug or perhaps slightly different.

Aug 20 2022, 10:14 PM · MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Wikimedia-production-error, SyntaxHighlight
Seb35 created T315740: Fatal error when there is an empty <source/>.
Aug 20 2022, 10:07 PM · MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Wikimedia-production-error, SyntaxHighlight
Seb35 added a comment to T209034: Incomplete continuation in MWAPI.

I documented on the user manual this feature.

Aug 20 2022, 11:11 AM · Discovery-Wikidata-Query-Service-Sprint, Wikidata-Query-Service, Wikidata

Aug 19 2022

Seb35 added a comment to T313475: $smwgDefaultStore should test for SMW\SQLStore\SQLStore.

And BTW this is fixed in master since 27 July 2022 with 3f5e60bd22139c1bc8ebd73a596dccbbb0f03f76.

Aug 19 2022, 2:25 PM · MediaWiki-extensions-SemanticDrilldown
Seb35 merged T313475: $smwgDefaultStore should test for SMW\SQLStore\SQLStore into T305911: Fatal error about schema when used with SMW 4.0+.
Aug 19 2022, 2:25 PM · MediaWiki-extensions-SemanticDrilldown
Seb35 merged task T313475: $smwgDefaultStore should test for SMW\SQLStore\SQLStore into T305911: Fatal error about schema when used with SMW 4.0+.
Aug 19 2022, 2:24 PM · MediaWiki-extensions-SemanticDrilldown
Seb35 closed T304692: A few images are now 404 since last commit on master as Resolved.
Aug 19 2022, 2:17 PM · MediaWiki-extensions-SemanticDrilldown
Seb35 closed T305911: Fatal error about schema when used with SMW 4.0+ as Resolved.

Fixed in 3f5e60bd22139c1bc8ebd73a596dccbbb0f03f76.

Aug 19 2022, 2:10 PM · MediaWiki-extensions-SemanticDrilldown

Aug 16 2022

Seb35 placed T106994: generateSitemap.php - Error: 1300 Invalid utf8 character string: 'F0A8AE' up for grabs.
Aug 16 2022, 7:12 PM · Patch-For-Review, MediaWiki-Maintenance-system
Seb35 added a comment to T106994: generateSitemap.php - Error: 1300 Invalid utf8 character string: 'F0A8AE'.

Percent-encoding makes the URL with the non-ASCII characters much longer, so using a string of 255 a's would break the size check. Another option would be to instead replace the 4-byte characters with twice the number of 2-byte characters. The check may still be flawed though because of the gendered User namespace issue (aliases may be of different byte lengths), and there are better ways to implement such a size check. The patch set I uploaded (see above) is one of them.

Aug 16 2022, 7:12 PM · Patch-For-Review, MediaWiki-Maintenance-system

Aug 13 2022

Seb35 added a comment to T85345: MediaWiki does not support memcached through unix sockets.

I see this was independently documented on Manual:$wgMemCachedServers, so perhaps this task could be marked as solved.

Aug 13 2022, 4:21 PM · Performance-Team, MediaWiki-libs-ObjectCache
Seb35 added a comment to T85345: MediaWiki does not support memcached through unix sockets.

De facto it works when configured directly in LocalSettings.php in $wgMemCachedServers, but the Web installer mandates the form IP:PORT or DOMAIN:PORT.

Aug 13 2022, 1:45 PM · Performance-Team, MediaWiki-libs-ObjectCache

Aug 10 2022

Seb35 added a comment to T296435: Title::getLinksTo() appears to be broken.

I confirm the patch merged on July 6 fixes the issue, to this task can be closed.

Aug 10 2022, 8:36 AM · MW-1.37-release, MediaWiki-General

Jul 28 2022

Seb35 added a comment to T217307: PageImages' og:image interferes with the one defined by OpenGraphMeta.

I also observe this issue with SemanticMetaTags adding an og:image according to a specific semantic (SMW) property.

Jul 28 2022, 3:16 PM · Readers-Web-Backlog (Kanbanana-2022-23-Q1), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), patch-welcome, PageImages

Jul 26 2022

Seb35 added a comment to T269508: VisualEditor gives 401 when behind basic auth.

I also tried on MW 1.39 behind an SSL client authentication, it works great! Thanks @cscott!

Jul 26 2022, 7:04 PM · Parsoid (Tracking), VisualEditor
Seb35 awarded T305108: Zero Config Install of VE + Parsoid for MW 1.39 a Love token.
Jul 26 2022, 6:30 PM · MW-1.39-notes (1.39.0-wmf.14; 2022-05-30), Editing-team (Tracking), Parsoid (Third-party), MW-1.39-release, VisualEditor

Jul 22 2022

Seb35 added a subtask for T255366: SameSite cookie issues: T261093: The “mwext-jsbreadcrumbs” cookie will be rejected in the future.
Jul 22 2022, 1:58 PM · MediaWiki-General
Seb35 added a parent task for T261093: The “mwext-jsbreadcrumbs” cookie will be rejected in the future: T255366: SameSite cookie issues.
Jul 22 2022, 1:58 PM · Patch-For-Review, User-Cicalese, MediaWiki-extensions-JSBreadCrumbs

Jun 21 2022

Seb35 added a comment to T308993: Template backlinks on ?action=info broken on 1.37.

Duplicate of T296435, opened before and contains a Gerrit patch for 1.37.

Jun 21 2022, 12:51 PM · MW-1.37-release, MediaWiki-Page-derived-data, Platform Engineering
Seb35 merged T308993: Template backlinks on ?action=info broken on 1.37 into T296435: Title::getLinksTo() appears to be broken.
Jun 21 2022, 12:51 PM · MW-1.37-release, MediaWiki-General
Seb35 merged task T308993: Template backlinks on ?action=info broken on 1.37 into T296435: Title::getLinksTo() appears to be broken.
Jun 21 2022, 12:50 PM · MW-1.37-release, MediaWiki-Page-derived-data, Platform Engineering
Seb35 added a comment to T269508: VisualEditor gives 401 when behind basic auth.

I configured an SSL client certificate on nginx in front of MediaWiki 1.37, it mostly works except the VisualEditor due to this issue, and at the contrary of basic auth it’s absolutely impossible to forward authentication tokens for this configuration.

Jun 21 2022, 11:17 AM · Parsoid (Tracking), VisualEditor

May 12 2022

Seb35 committed rELLO39ae56cab216: Declare dependency to OOUI (authored by Seb35).
Declare dependency to OOUI
May 12 2022, 11:17 AM

May 4 2022

Seb35 added a comment to T280147: Out of memory errors in translatewiki.net from MessageCache deferred update.

$wgMemoryLimit can be increased. I don’t have a precise method to set it to a sensible value, except try-observe-adjust.

May 4 2022, 8:05 PM · MediaWiki-Internationalization, Performance-Team (Radar), affects-translatewiki.net
Seb35 added a comment to T258860: LogicException: Process cache for 'en' should be set by now.

I see two different actions to mitigate this issue:

May 4 2022, 7:14 PM · MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Performance-Team, MediaWiki-Internationalization, Wikimedia-production-error, MW-1.35-release, Discovery-Search, affects-translatewiki.net
Seb35 added a comment to T258860: LogicException: Process cache for 'en' should be set by now.

We (Wiki Valley) had recently this error on MW 1.36, together with something like T280147 (we have $wgMainCacheType = CACHE_MEMCACHED like others here).

May 4 2022, 6:26 PM · MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Performance-Team, MediaWiki-Internationalization, Wikimedia-production-error, MW-1.35-release, Discovery-Search, affects-translatewiki.net

Apr 27 2022

Seb35 committed rELLO23d861bdb858: Fix PHP Notice: Undefined index: fieldname (authored by Seb35).
Fix PHP Notice: Undefined index: fieldname
Apr 27 2022, 8:03 PM

Apr 20 2022

Seb35 added a comment to T299015: Archive the DeletePagesForGood extension.

I hereby candidate to become maintainer of the extension, on behalf of the MediaWiki consulting company Wiki Valley.

Apr 20 2022, 8:57 AM · MediaWiki-extensions-DeletePagesForGood, translatewiki.net, Wikimedia-GitHub, Diffusion-Repository-Administrators, Projects-Cleanup

Apr 19 2022

Seb35 added a comment to T306463: SQL injection in SemanticDrilldown (CVE-2022-29904).

Here is a patch as a Git commit: (name and email redacted to avoid harvesting of my email address)

commit dda8ac5ca2d8f6ff595f1a2e641bda4c2057bfc4
tree 7492d30ceab679b68d72c026ecbddc7987085202
parent 044614d60c30cbbd7d3882f836905796bc1ade06
author xxxx <xxxx> 1650395410 +0200
committer xxxx <xxxx> 1650395410 +0200
Apr 19 2022, 7:15 PM · SecTeam-Processed, Vuln-Inject, MediaWiki-extensions-SemanticDrilldown, Security
Seb35 added a project to T306463: SQL injection in SemanticDrilldown (CVE-2022-29904): MediaWiki-extensions-SemanticDrilldown.
Apr 19 2022, 7:08 PM · SecTeam-Processed, Vuln-Inject, MediaWiki-extensions-SemanticDrilldown, Security
Seb35 created T306463: SQL injection in SemanticDrilldown (CVE-2022-29904).
Apr 19 2022, 7:08 PM · SecTeam-Processed, Vuln-Inject, MediaWiki-extensions-SemanticDrilldown, Security

Apr 18 2022

Seb35 lowered the priority of T282133: PhanUndeclaredConstantOfClass Reference to undeclared class constant \Redis::SERIALIZER_IGBINARY from High to Low.
Apr 18 2022, 7:02 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), MW-1.37-notes, MW-1.37-release, MW-1.35-notes, MW-1.36-notes, MW-1.36-release, ci-test-error, phan, MW-1.35-release
Seb35 reopened T282133: PhanUndeclaredConstantOfClass Reference to undeclared class constant \Redis::SERIALIZER_IGBINARY as "Open".

I reopen this task since I got this issue when I executed Phan locally.

Apr 18 2022, 6:42 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), MW-1.37-notes, MW-1.37-release, MW-1.35-notes, MW-1.36-notes, MW-1.36-release, ci-test-error, phan, MW-1.35-release

Apr 14 2022

Seb35 added a comment to T305911: Fatal error about schema when used with SMW 4.0+.

Another Gerrit patch was submitted I271e3babd231e855412ede02931a7ac85ecd9569 one week before mine.
It fixes the default case when SQLStore is used but is a bit less complete than mine (no handling of SPARQLStore).

Apr 14 2022, 8:38 AM · MediaWiki-extensions-SemanticDrilldown
Seb35 raised the priority of T305911: Fatal error about schema when used with SMW 4.0+ from Medium to High.
Apr 14 2022, 8:28 AM · MediaWiki-extensions-SemanticDrilldown
Seb35 claimed T305911: Fatal error about schema when used with SMW 4.0+.
Apr 14 2022, 8:27 AM · MediaWiki-extensions-SemanticDrilldown
Seb35 claimed T304692: A few images are now 404 since last commit on master.
Apr 14 2022, 8:26 AM · MediaWiki-extensions-SemanticDrilldown
Seb35 closed T291493: Remove $sdgNamespaceIndex reference from INSTALL file as Resolved.

This sentence was removed in INSTALL file on 2022-03-15 in 41569b4cdb27c65288fd19aa1940b3bac46b6546 by @Umherirrender, so this task is resolved.

Apr 14 2022, 8:23 AM · MediaWiki-extensions-SemanticDrilldown

Apr 13 2022

Seb35 closed T246216: Error from line 31 of "SD_BrowseData.php": Call to undefined method SDBrowseData::getTitle(), a subtask of T223005: Replace usages of SpecialPage::getTitle() with SpecialPage::getPageTitle(), as Resolved.
Apr 13 2022, 7:30 AM · MediaWiki-extensions-WikiLexicalData-or-OmegaWiki, good first task, MediaWiki-extensions-General, Technical-Debt, MW-1.34-release
Seb35 closed T246216: Error from line 31 of "SD_BrowseData.php": Call to undefined method SDBrowseData::getTitle() as Resolved.

Was fixed by @RazeSoldier in June 2019 : 4f41672bc2b4.

Apr 13 2022, 7:30 AM · MediaWiki-extensions-SemanticDrilldown
Seb35 added a subtask for T223005: Replace usages of SpecialPage::getTitle() with SpecialPage::getPageTitle(): T246216: Error from line 31 of "SD_BrowseData.php": Call to undefined method SDBrowseData::getTitle().
Apr 13 2022, 7:19 AM · MediaWiki-extensions-WikiLexicalData-or-OmegaWiki, good first task, MediaWiki-extensions-General, Technical-Debt, MW-1.34-release
Seb35 added a parent task for T246216: Error from line 31 of "SD_BrowseData.php": Call to undefined method SDBrowseData::getTitle(): T223005: Replace usages of SpecialPage::getTitle() with SpecialPage::getPageTitle().
Apr 13 2022, 7:19 AM · MediaWiki-extensions-SemanticDrilldown