Seb35 (Seb35)
MediaWiki gnome

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 9:50 AM (154 w, 21 h)
Availability
Available
IRC Nick
seb35
LDAP User
Seb35
MediaWiki User
Seb35

I follow MediaWiki development since 2007. Although I don’t regularly submit patches for the MediaWiki core, I act as an ambassador, submitting bugs, helping in their resolution, exchanging with the French-speaking community, improving documentation and its translation into French, etc. I developed three extensions (BackwardsTimeTravel, HSTS, and MediaWikiFarm).

Since 2016, I run a small MediaWiki consulting company in France, which help companies, associations and public sector to set up MediaWiki installations.

My GitHub account is Seb35.

Recent Activity

Yesterday

Seb35 updated the task description for T142120: Remove UnitTestsList hook subscribers, move tests to be autodiscovered for extensions that have been converted to extension registration.
Tue, Sep 19, 9:43 AM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), Patch-For-Review, MediaWiki-Core-Tests, MediaWiki-extensions-General

Mon, Sep 18

Seb35 moved T174199: Investigate getting rid of the non-Tidy option in parser tests from Unsorted to PHP 7 on the NewPHP board.
Mon, Sep 18, 9:22 AM · NewPHP, MediaWiki-Core-Tests, MediaWiki-Parser
Seb35 added a project to T174199: Investigate getting rid of the non-Tidy option in parser tests: NewPHP.

For information, when I run locally the parser tests, I have no failing tests with PHP 5.6, but I have 9 failing tests with PHP 7.0 and PHP 7.1 with their respective PHP extension tidy.

Mon, Sep 18, 9:22 AM · NewPHP, MediaWiki-Core-Tests, MediaWiki-Parser

Sun, Sep 17

Seb35 added a comment to T166010: The Great Namespaceization and Reorg.

The standard PSR-4 requires a map (namespace => directory). If each extension declares its map, there is no real constraint and BlueSpice (and SMW and others) can use a specific vendor without much difficulty. But if in the future most extensions are given a namespace MediaWiki\ExtensionName it could become tempting to define an implicit autoloader (MediaWiki\MyExtension\MyClass => /extensions/MyExtension/includes/MyClass.php). If it is the case, there could be these two parameters in extension.json:

  • the subdirectory where are stored the classes ("includes" in my example), possibly with a default value;
  • a specific vendor with "MediaWiki" or "MediaWiki\Extension" as default value.
Sun, Sep 17, 1:43 PM · Patch-For-Review, TechCom-RfC, MediaWiki-Platform-Team
Seb35 added a comment to T166010: The Great Namespaceization and Reorg.

For information, in the case MediaWiki\ExtensionName (versus MediaWiki\Extension\ExtensionName/MediaWiki\Skin\SkinName, there are at least 3 conflicts where an extension and a skin have the same name: Athena, CustomPage, Vector.

Sun, Sep 17, 1:38 PM · Patch-For-Review, TechCom-RfC, MediaWiki-Platform-Team
Seb35 added a comment to T152540: Migrate to HTML5 section ids.

I was curious to see the result and didn’t find live examples with MediaWiki, so I created one on https://test.wikipedia.org/wiki/HTML_5_section_IDs.

Sun, Sep 17, 11:16 AM · Patch-For-Review, Readers-Web-Backlog (Tracking), User-notice, Community-Tech-Sprint, Mobile-Content-Service, Reading-Infrastructure-Team-Backlog, TechCom-RfC, Community-Wishlist-Survey-2016, Community-Tech, ContentTranslation, MediaWiki-Parser, Parsoid, Parsing-Team

Sat, Sep 16

Seb35 updated the task description for T47514: ResourceLoader: Implement support for Source Maps.
Sat, Sep 16, 4:57 PM · Front-end-Standards-Group, MediaWiki-ResourceLoader
Seb35 added a comment to T47514: ResourceLoader: Implement support for Source Maps.

Some PHP libraries:

Sat, Sep 16, 4:55 PM · Front-end-Standards-Group, MediaWiki-ResourceLoader

Fri, Sep 15

Seb35 added a comment to T155747: All extension should link to the deployed Git revision from Special:Version.

In my understanding, there are at least two different cases about why some extensions don’t have a Git hashes:

  1. Some are registered as Composer library (e.g. DataValues* extensions installed with Semantic MediaWiki through Composer) and as such don’t appear because their code is in /vendor/X/Y instead of /extensions/Z; imho this is not a bug in MediaWiki core but either the extensions should be installed in /extensions either it should not be registered as a MediaWiki extension in Special:Version but as a Composer library (section above).
  2. In some Git setup, particularly if a git gc ran in some directory, the class GitInfo class doesn’t read the file /.git/packed-refs and hence cannot retrieve the hash for this Git-versioned directory.
Fri, Sep 15, 7:45 AM · Patch-For-Review, Release-Engineering-Team (Backlog), Deployment-Systems, MediaWiki-Special-pages

Wed, Sep 13

Seb35 placed T162686: Reorganise tests in MediaWikiFarm to focus on unit tests up for grabs.

Removed myself from this task, I’m not working actively on it for now.

Wed, Sep 13, 6:02 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 placed T162682: Add tags in MediaWikiFarm up for grabs.

Removed myself from this task, I’m not working on it.

Wed, Sep 13, 6:01 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 claimed T162733: Delete a wiki from cache when it is deleted in origin files.

I worked on it and will send soon this patch. I rewrote the part with the mechanism 'deployment' and I’m quite happy with this new code, more clear than before.

Wed, Sep 13, 5:59 PM · MediaWiki-extensions-MediaWikiFarm

Sun, Sep 10

Seb35 committed rEMWF141fa0d0bd9f: Improved reading of config files (authored by Seb35).
Improved reading of config files
Sun, Sep 10, 4:02 PM

Fri, Sep 8

Seb35 committed rEMWF3d00c5dde0f0: Cache files in /cache/wikis were never used (authored by Seb35).
Cache files in /cache/wikis were never used
Fri, Sep 8, 10:59 AM
Seb35 committed rEMWFc95100cbc1ee: Cache files in /cache/wikis were never used (authored by Seb35).
Cache files in /cache/wikis were never used
Fri, Sep 8, 10:59 AM
Seb35 added a comment to T175332: In MediaWikiFarm some cache files are not read because path is used in the file name.

For cross-reference I found this bug when I studied T162733.

Fri, Sep 8, 10:58 AM · MediaWiki-extensions-MediaWikiFarm
Seb35 closed T175332: In MediaWikiFarm some cache files are not read because path is used in the file name as Resolved.
Fri, Sep 8, 10:56 AM · MediaWiki-extensions-MediaWikiFarm
Seb35 moved T175332: In MediaWikiFarm some cache files are not read because path is used in the file name from Backlog to Bugs on the MediaWiki-extensions-MediaWikiFarm board.
Fri, Sep 8, 9:57 AM · MediaWiki-extensions-MediaWikiFarm
Seb35 added a comment to T175332: In MediaWikiFarm some cache files are not read because path is used in the file name.

In the original description I was mistaken about the cached files in /cache/composer and /cache/LocalSettings, it was correctly implemented - edited the description accordingly.

Fri, Sep 8, 8:24 AM · MediaWiki-extensions-MediaWikiFarm
Seb35 updated the task description for T175332: In MediaWikiFarm some cache files are not read because path is used in the file name.
Fri, Sep 8, 8:22 AM · MediaWiki-extensions-MediaWikiFarm
Seb35 added a comment to T175332: In MediaWikiFarm some cache files are not read because path is used in the file name.

In earlier times I though about a caching mechanism where all existing unique identifiers (host and paths) would be in a single cache file, with associated existence configuration (variables and config to recompile the LocalSettings); but I prefered create separated files instead of such a big file to avoid too much writes in a single file (a cache with too much writes is no more a real cache). This could be a solution, with the variation such a big file could be only a dictionary 'host' => [ paths ].

Fri, Sep 8, 7:08 AM · MediaWiki-extensions-MediaWikiFarm
Seb35 claimed T175332: In MediaWikiFarm some cache files are not read because path is used in the file name.
Fri, Sep 8, 6:44 AM · MediaWiki-extensions-MediaWikiFarm
Seb35 renamed T175332: In MediaWikiFarm some cache files are not read because path is used in the file name from Some cache files are not read because path is used in the file name to In MediaWikiFarm some cache files are not read because path is used in the file name.
Fri, Sep 8, 6:44 AM · MediaWiki-extensions-MediaWikiFarm
Seb35 created T175332: In MediaWikiFarm some cache files are not read because path is used in the file name.
Fri, Sep 8, 6:43 AM · MediaWiki-extensions-MediaWikiFarm
Seb35 added a comment to T162733: Delete a wiki from cache when it is deleted in origin files.

I checked the others cases (i.e. when the deployment mode is not used) : it works correctly when there is no cache and when cache is enabled.

Fri, Sep 8, 6:26 AM · MediaWiki-extensions-MediaWikiFarm

Sat, Sep 2

Seb35 committed rEMWF7351ef7285e1: Fix MW-CS to a fixed version (authored by Seb35).
Fix MW-CS to a fixed version
Sat, Sep 2, 9:13 PM

Fri, Sep 1

Seb35 committed rEMWF8d4f4dca5276: Use xxx.php as an alias of maintenance/xxx.php (authored by Seb35).
Use xxx.php as an alias of maintenance/xxx.php
Fri, Sep 1, 1:41 PM
Seb35 committed rEMWFcac8d7a3ff27: Use xxx.php as an alias of maintenance/xxx.php (authored by Seb35).
Use xxx.php as an alias of maintenance/xxx.php
Fri, Sep 1, 1:41 PM

Mon, Aug 28

Seb35 changed the status of T120333: Remove old mysql extension support in favor of mysqli from Open to Stalled.
Mon, Aug 28, 9:28 PM · MW-1.30-release-notes, NewPHP, Technical-Debt, MediaWiki-Database
Seb35 removed a project from T162690: Take into account the special nature of $wgExtensionDirectory in MediaWikiFarm: Patch-For-Review.
Mon, Aug 28, 10:30 AM · MediaWiki-extensions-MediaWikiFarm
Seb35 moved T174319: Review behaviour of +wgParameter when set in multiple files in MediaWikiFarm from Backlog to Features on the MediaWiki-extensions-MediaWikiFarm board.
Mon, Aug 28, 10:29 AM · MediaWiki-extensions-MediaWikiFarm
Seb35 triaged T174319: Review behaviour of +wgParameter when set in multiple files in MediaWikiFarm as Lowest priority.
Mon, Aug 28, 10:29 AM · MediaWiki-extensions-MediaWikiFarm
Seb35 added a comment to T174319: Review behaviour of +wgParameter when set in multiple files in MediaWikiFarm.

Personally I tend to prefer the second option, even if it introduces a new syntax. I find it more natural to reserve the syntaxes +wgParameter:\n default: and `+wgParameter:\n wiki: to completely replace the "diff arrays".

Mon, Aug 28, 10:28 AM · MediaWiki-extensions-MediaWikiFarm
Seb35 created T174319: Review behaviour of +wgParameter when set in multiple files in MediaWikiFarm.
Mon, Aug 28, 10:26 AM · MediaWiki-extensions-MediaWikiFarm
Seb35 removed a project from T168807: A forced-mechanism missing extension should be gracefully disabled in MediaWikiFarm: Patch-For-Review.
Mon, Aug 28, 9:49 AM · MediaWiki-extensions-MediaWikiFarm
Seb35 closed T168807: A forced-mechanism missing extension should be gracefully disabled in MediaWikiFarm as Resolved.

The behaviour is now the same for all loading mechanisms, be it a specific forced mechanism or any mechanism.

Mon, Aug 28, 9:49 AM · MediaWiki-extensions-MediaWikiFarm

Sat, Aug 26

Seb35 committed rEMWF442efe5e4f4a: Always verify an extension exists, even if the mechanism is forced (authored by Seb35).
Always verify an extension exists, even if the mechanism is forced
Sat, Aug 26, 2:52 PM
Seb35 committed rEMWFa5f52c615e53: Bug: a Composer extension could not be deactivated (authored by Seb35).
Bug: a Composer extension could not be deactivated
Sat, Aug 26, 1:15 PM

Fri, Aug 25

Seb35 committed rEMWFc9225ae94db6: Split out utilitary functions into dedicated classes (authored by Seb35).
Split out utilitary functions into dedicated classes
Fri, Aug 25, 6:36 PM

Thu, Aug 24

Seb35 added a comment to T173562: ug_expiry column of the user_groups table is not present after update from 1.28.2 to 1.29.0.

We had the same issue during update from 1.28.2 to 1.29.0; in our case it appeared Flow was enabled and seemed to require this schema change before it was applied by MediaWiki updater (hypothesis to be verified). It worked by deactivating Flow, updating, reactivating Flow, re-updating.

Thu, Aug 24, 4:01 PM · MediaWiki-Database

Tue, Aug 22

Seb35 edited Description on MediaWiki-extensions-MediaWikiFarm.
Tue, Aug 22, 5:26 PM
Seb35 committed rEMWFeb15873ce868: Move classes for scripts from ./src to ./src/bin (authored by Seb35).
Move classes for scripts from ./src to ./src/bin
Tue, Aug 22, 5:11 PM
Seb35 committed rEMWF748da8a6c1a5: Move classes for scripts from ./src to ./src/bin (authored by Seb35).
Move classes for scripts from ./src to ./src/bin
Tue, Aug 22, 5:02 PM
Seb35 lowered the priority of T162686: Reorganise tests in MediaWikiFarm to focus on unit tests from Normal to Lowest.
Tue, Aug 22, 1:25 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 committed rEMWF24ed952cc30e: Small bug during logging (authored by Seb35).
Small bug during logging
Tue, Aug 22, 9:15 AM

Mon, Aug 21

Seb35 claimed T162737: Create a list of all known wikis in MediaWikiFarm.

I developed the code for this feature, but I need to tidy it a bit more before releasing. In preparation of this, I just pushed an improvement of the rules to define the wikis, because there was a possibility some wikis exist but were unregistered in MediaWikiFarm (“ghost wikis”), this new commit forbids this behaviour. Without it, the creation of the list of wikis could have missed some wikis.

Mon, Aug 21, 9:07 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 committed rEMWFc8124a359e23: Define more precisely the set of existing wikis (authored by Seb35).
Define more precisely the set of existing wikis
Mon, Aug 21, 8:52 PM

Aug 19 2017

Seb35 committed rEMWFaf173e9d129d: Update coding rules according to phpcs (authored by Seb35).
Update coding rules according to phpcs
Aug 19 2017, 12:01 PM
Seb35 committed rEMWF7714478542bb: Update coding rules according to phpcs (authored by Seb35).
Update coding rules according to phpcs
Aug 19 2017, 12:01 PM

Aug 6 2017

Seb35 added a comment to T72357: wfShellExec() causes web-installer (and possible more) to hang.

I added a test capturing this specific bug. This occurs in the specific case:

  • with PHP (5.6, 7.0, 7.1) but not with HHVM (possibly HHVM has a higher limit FD_SETSIZE or no limit?), and
  • on Linux (at least I didn’t test on Windows or Mac, I don’t have these platforms), and
  • when ulimit -Sn (=limit nofile) is higher than 1024, and
  • when more than 1024 (=FD_SETSIZE) and less than nofile (*) files are simultaneously opened, which can occur on a heavily-loaded server or when executing unit tests with PHPDBG since it opens a lot of (all?) PHP files (1660 in my case).

(*) if more than nofile files are opened, Linux terminates the PHP process due to Linux security limits.

Aug 6 2017, 8:15 PM · Patch-For-Review, MediaWiki-General-or-Unknown

Aug 5 2017

Seb35 added a comment to T161232: Bump MediaWiki's minimum supported MySQL Version to 5.5.8.

Note the related task T120333 about deprecation of the PHP extension 'mysql'. From the only compatibility matrix between the PHP extension 'mysql' and MySQL server I found, Choosing an API explictely says the PHP extension 'mysql' is not compatible with MySQL 5.1, amongst other missing features.

Aug 5 2017, 7:34 PM · MediaWiki-Documentation, Documentation, TechCom-RfC (ArchCom-Approved), DBA, MediaWiki-Database
Seb35 updated the task description for T120333: Remove old mysql extension support in favor of mysqli.
Aug 5 2017, 6:56 PM · MW-1.30-release-notes, NewPHP, Technical-Debt, MediaWiki-Database

Aug 4 2017

Seb35 added a comment to T131686: Provide an integration of VisualEditor for Page Forms.

I successfully installed VEForPageForm on MediaWiki 1.28 (with a small issue though). I tried with MediaWiki 1.29 + PageForms REL1_29 + VisualEditor REL1_29 and got two blocking issues:

  • the hook "pfHTMLBeforeForm" I used (see the linked issue on GitHub) was renamed "PageForms::HTMLBeforeForm" in PageForms REL1_29 -- I’m not sure it’s the appropriate hook but it does the job,
  • "Error: Unknown dependency: ext.visualEditor.standalone" in the browser console.
Aug 4 2017, 4:57 PM · VisualEditor, MediaWiki-extensions-Page_Forms, VisualEditor-MediaWiki
Seb35 renamed T131686: Provide an integration of VisualEditor for Page Forms from Provide an integration of VisualEditor for SemanticForms to Provide an integration of VisualEditor for Page Forms.
Aug 4 2017, 4:38 PM · VisualEditor, MediaWiki-extensions-Page_Forms, VisualEditor-MediaWiki

Jul 26 2017

Seb35 awarded T150672: Provide a /parsoid directory on releases.wikimedia.org a Piece of Eight token.
Jul 26 2017, 10:14 AM · Release-Engineering-Team (Watching / External), Parsoid, Operations

Jul 24 2017

Seb35 added a comment to T162686: Reorganise tests in MediaWikiFarm to focus on unit tests.

Since I redacted this task, I have a less strong opinion about focusing on unit tests. Some thoughts:

  • ideally large parts should be splitted in smaller functions, and it will help create unit tests;
  • on the other side, integration tests are also interesting ; but they should be labelled as such, perhaps by creating a subdirectory /tests/integration next to /tests/phpunit (both could use PHPUnit, it would reduce the number of dependencies)
  • real integration tests could be: 1/ mock some MW parts and check an extension is really activated, or 2/ test scenarios like updating a config file, or 3/ transitionning from no-cache to cache to no-cache. If integration tests are added (and I now think it would be better), a separate task should be created about it.
  • I read the Wikipedia article about IEEE 829 - perhaps a bit overkill for such a small software as MediaWikiFarm but I find it interesting, perhaps I will invest the $153 to buy the standard but very unsure for now
Jul 24 2017, 3:54 PM · MediaWiki-extensions-MediaWikiFarm

Jul 18 2017

Seb35 added a comment to T146841: Reach out to Google about @yahoo.com emails not reaching gmail inboxes (when sent to mailing lists).

Instead of reaching Google about this issue, it should first be tried to implement the DMARC-workaround in Mailman 2.1.18 as described in T168467.

Jul 18 2017, 8:34 PM · Wikimedia-Mailing-lists, Operations
Seb35 added a comment to T168467: Improve lists.wikimedia.org DMARC compatibility.

Recently a sender with a yahoo.fr address sent an email on the list wikimediafr ∂ lists.wikimedia.org (newly created) and Mailman unsubscribed many addresses (mostly gmail.com I think) because Gmail rejected the message (because of Yahoo DMARC policy). See this message in French from the moderator. The moderators just changed the DMARC behaviour to "Munge From".

Jul 18 2017, 8:21 PM · Wikimedia-Mailing-lists, Mail
Seb35 added a comment to T55341: Convert $wgDebugDBTransactions to debug log group..

@Nikerabbit: the configuration parameter $wgDebugDBTransactions was removed in 1.27.0 in this commit. Do you want to re-phrase this task or possibly close it?

Jul 18 2017, 1:14 PM · MediaWiki-Database
Seb35 added a comment to T85762: Get rid of the Uncommitted DB writes notice.

Still current in MediaWiki 1.27: Topic:Tr7p9m3hybmc7kf3

Jul 18 2017, 12:58 PM · MediaWiki-Database
Seb35 added a comment to T140340: Connect moved paragraphs by arrows.

I like this design, I find it more clear with arrows than without. Some small comments:

  1. First, a graphical detail: I don’t know if it’s possible in CSS, but I find some bluring around the elements "Line 35" , "+" , "-" could be more aesthetic (that’s my opinion, but you’re free to ignore it if you find otherwise).
  2. I thought about a refinement – but you already mentioned it in your comment – about highlighting the arrows on hover (useful in case of visually closed moves) and/or when clicking/touching (useful in case of long-distance moves), which would be particularly useful if there are a lot of moves.
  3. If there are a lot of moves (I see T166571 mentions a maximum of 25 moves), what would be the behaviour?
    1. For some informational comparison, below is an illustration of how Git shows parallel branches (that’s not exactly the same application as here but a similar design – arrows linking points): it was chosen to take a fixed width for each arrow (and hence a variable total width), but in our case the total width is fixed and it’s sensible in our case.
    2. A design choice could be that the lines collapse together. In this case some highlighting would become a great helper to visually distinguish a specific move between the others.
    3. Another design choice could be to only display arrows on hovering/clicking/touching.
    4. It could be also a mix of the second and third points, and for example only short-distance moves are displayed by default and long-distances moves are only displayed on hovering/clicking/touching.
Jul 18 2017, 12:01 PM · German-Community-Wishlist, Design, WMDE-Design, TCB-Team

Jul 17 2017

Seb35 added a watcher for MW-1.30-release: Seb35.
Jul 17 2017, 8:57 PM

Jul 13 2017

Seb35 added a comment to T162737: Create a list of all known wikis in MediaWikiFarm.

Other uses of such a list would be to define the virtual hosts in the webserver (see this method for nginx for instance) and in the DNS, in order to avoid either manual editing of these config files either catch-all regexes. This use case could also be delegated to an external configuration management tool (Ansible, etc.), to be decided if it is taken into account specifically by MediaWikiFarm.

Jul 13 2017, 9:27 AM · MediaWiki-extensions-MediaWikiFarm

Jul 10 2017

Seb35 created T170151: Empty categories are not proposed in VisualEditor.
Jul 10 2017, 2:32 PM · VisualEditor

Jul 6 2017

Seb35 added a comment to T90249: Establish and consistently release schedule for MediaWiki releases.

What exactly is expected to solve this task? There is the page Version lifecycle, which gives some details about scheduling for MediaWiki versions. Or is it about updating the page Release checklist with current processes?

Jul 6 2017, 9:22 PM · Release-Engineering-Team (Kanban), User-greg, MediaWiki-Stakeholders-Group, MediaWiki-Releasing

Jul 4 2017

Seb35 updated subscribers of T168723: LinksUpdate totally broken when JobQueueDB is in use.

I and @Envlh tried various configurations; it seems that, with the current master (884a54e) and REL1_29 (eb815ad), it works with a fresh installation without any extensions (only skins) (i.e. categories are correctly added, sometimes with some delay), but I experience the bug (=pages are not added in a category and job queue is empty) in some cases with only the Translate extension activated ("some cases" = with specific configuration parameters – we were not able still to determine what configuration parameters exactly), and possibly the bug occurs with other extensions and/or set of extensions and/or specific configuration.

Jul 4 2017, 10:36 PM · MW-1.29-release-notes, MW-1.30-release-notes, MediaWiki-JobQueue, Performance-Team, MediaWiki-Platform-Team, MW-1.29-release

Jun 29 2017

Seb35 closed T155076: VisualEditor REL1_23 is not distributed by ExtensionDistributor as Resolved.

Given MediaWiki 1.23 is deprecated now, it is no more available in downloading through the ExtensionDistributor, but it remains available with the Git installation (similarly to what is explained for other branches in Extension:VisualEditor#Download):

Jun 29 2017, 8:45 AM · User-Ryasmeen, VisualEditor, ExtensionDistributor

Jun 27 2017

Seb35 added a comment to T168723: LinksUpdate totally broken when JobQueueDB is in use.

Studied, the situation could become better but the bug is not solved.

Jun 27 2017, 11:31 PM · MW-1.29-release-notes, MW-1.30-release-notes, MediaWiki-JobQueue, Performance-Team, MediaWiki-Platform-Team, MW-1.29-release
Seb35 added a comment to T168347: DeferredUpdates hides exceptions.

I didn’t see the notification earlier -- in fact it was in my bunch of emails, but I would have expected that a direct mention shows something in Phabricator like in MediaWiki/Echo, seems it’s not the case.

Jun 27 2017, 9:26 PM · MW-1.30-release-notes, MW-1.29-release-notes, MediaWiki-Debug-Logger, Patch-For-Review, MW-1.29-release, MediaWiki-Database

Jun 25 2017

Seb35 moved T168807: A forced-mechanism missing extension should be gracefully disabled in MediaWikiFarm from Backlog to Features on the MediaWiki-extensions-MediaWikiFarm board.
Jun 25 2017, 10:49 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 added a comment to T162690: Take into account the special nature of $wgExtensionDirectory in MediaWikiFarm.

Note that Composer-managed extensions must be in $IP/extensions and cannot be moved elsewhere because it is written in Composer autoload (and is the expected location during installation/update). Hence Composer-managed extensions must be there even if non-Composer-managed extensions could be elsewhere according to wgExtensionDirectory/wgStyleDirectory. It is not possible to change that, so let’s call it a Composer feature.

Jun 25 2017, 10:46 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 triaged T168807: A forced-mechanism missing extension should be gracefully disabled in MediaWikiFarm as Lowest priority.
Jun 25 2017, 10:38 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 created T168807: A forced-mechanism missing extension should be gracefully disabled in MediaWikiFarm.
Jun 25 2017, 10:37 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 closed T162690: Take into account the special nature of $wgExtensionDirectory in MediaWikiFarm as Resolved.
Jun 25 2017, 10:28 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 committed rEMWF698913b16f65: Add support for wgExtensionDirectory and wgStyleDirectory (authored by Seb35).
Add support for wgExtensionDirectory and wgStyleDirectory
Jun 25 2017, 10:14 PM
Seb35 committed rEMWFd63881c9030b: Execute scripts when wikis are path-based (authored by Seb35).
Execute scripts when wikis are path-based
Jun 25 2017, 5:59 PM

Jun 20 2017

Seb35 triaged T168389: Create a maintenance script in Flow to rename a wiki as Low priority.

I did the following operations in database in a wiki and it globally works (*):

UPDATE flow_ext_ref SET ref_src_wiki = 'newWikiID' WHERE ref_src_wiki = 'oldWikiID';
UPDATE flow_revision SET rev_user_wiki = 'newWikiID' WHERE rev_user_wiki = 'oldWikiID';
UPDATE flow_revision SET rev_mod_user_wiki = 'newWikiID' WHERE rev_mod_user_wiki = 'oldWikiID';
UPDATE flow_revision SET rev_edit_user_wiki = 'newWikiID' WHERE rev_edit_user_wiki = 'oldWikiID';
UPDATE flow_tree_revision SET tree_orig_user_wiki = 'newWikiID' WHERE tree_orig_user_wiki = 'oldWikiID';
UPDATE flow_wiki_ref SET ref_src_wiki = 'newWikiID' WHERE ref_src_wiki = 'oldWikiID';
UPDATE flow_workflow SET workflow_wiki = 'newWikiID' WHERE workflow_wiki = 'oldWikiID';
UPDATE flow_subscription SET subscription_user_wiki = 'newWikiID' WHERE subscription_user_wiki = 'oldWikiID';

(The last table was empty, so I’m less sure, but it seems it should be changed too.)

Jun 20 2017, 11:43 AM · MediaWiki-Maintenance-scripts, Collaboration-Team-Triage, StructuredDiscussions
Seb35 created T168389: Create a maintenance script in Flow to rename a wiki.
Jun 20 2017, 11:28 AM · MediaWiki-Maintenance-scripts, Collaboration-Team-Triage, StructuredDiscussions

Jun 16 2017

Seb35 added a comment to T166384: scap: Investigate scaps handling of InitialiseSettings.php.

Note that there is a filemtime( "InitialiseSettings.php" ) in https://phabricator.wikimedia.org/source/mediawiki-config/browse/master/wmf-config/CommonSettings.php;3d7a96ad4d39b09960f4c212109ff7e129cdc712$159. I guess it explains why touching InitialiseSettings.php triggered the beginning of the performance issues, possibly some feature flag or parameter was activated at this time. (I didn’t read in details the post-mortem itself.)

Jun 16 2017, 4:15 PM · Release-Engineering-Team (Kanban), Scap
Seb35 added a comment to T117332: Links tables are sometimes not being populated.

For those who saw this issue, could you re-check if you still experience this issue? There were quite a lot of changes around jobs and related topics since this task was first opened, it could have been fixed.

Jun 16 2017, 2:44 PM · MediaWiki-JobQueue, MediaWiki-Page-editing
Seb35 added a comment to T166738: Error "Class 'MWTimestamp' not found" when upgrading to MW 1.29.0-rc.0.

I found the task T164896 recently closed, possibly similar to this one (class_alias issue).

Jun 16 2017, 1:51 PM · Timestamp
Seb35 added a comment to T100085: PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted.

@aaron I added some documentation on Manual:Job queue and Manual:Job queue/For developers; could you review it and particularly the differences between deferrable updates and jobs? It should help developers to decide if they want to use a deferrable update and/or a job.

Jun 16 2017, 12:16 PM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.28-release, Wikimedia-log-errors, Performance-Team, MW-1.27-release, MW-1.29-release, MediaWiki-JobQueue

Jun 15 2017

Seb35 added a comment to T166738: Error "Class 'MWTimestamp' not found" when upgrading to MW 1.29.0-rc.0.

I’m no more sure how I did to see the error, I guess it is a very specific state.

Jun 15 2017, 8:26 AM · Timestamp

Jun 13 2017

Seb35 updated the task description for T154438: Special:MovePage throws MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush, JobQueueDB::doBatchPush).
Jun 13 2017, 5:17 PM · MW-1.29-release-notes, MediaWiki-JobQueue, MW-1.29-release, MediaWiki-Database
Seb35 updated the task description for T100085: PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted.
Jun 13 2017, 5:17 PM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.28-release, Wikimedia-log-errors, Performance-Team, MW-1.27-release, MW-1.29-release, MediaWiki-JobQueue
Seb35 updated the task description for T165714: BagOStuff::trackDuplicateKeys causes a "MWCallableUpdate::doUpdate: transaction round ..." during JobRunner::executeJob.
Jun 13 2017, 5:17 PM · MW-1.29-release-notes, MW-1.29-release, Patch-For-Review, MediaWiki-JobQueue, Performance-Team, MediaWiki-Database
Seb35 updated the task description for T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".
Jun 13 2017, 5:16 PM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database

Jun 10 2017

Linedwell awarded T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)" a Cookie token.
Jun 10 2017, 3:02 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database

Jun 9 2017

Seb35 added a comment to T132215: Do not show recent changes for recently deleted pages.

Not sure about the MediaWiki version then (1.27-alpha or 1.28-alpha) but possibly this is partly solved by T153849 "Deleted pages' creation entry shows up in Special:RecentChanges as a redlink since MW 1.28" (duplicate of T154425): it is still a deferred update (by design) but it will work better.

Jun 9 2017, 9:20 AM · MediaWiki-JobQueue, MediaWiki-Recent-changes
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

I link here some other tasks I found as partly linked to this one - if someone want to check in details and/or discuss these and/or close these:

  • T85762 "Get rid of the Uncommitted DB writes notice" A proposal about hiding these warnings in some cases
  • T85734 "Uncommitted DB writes (transaction from DatabaseBase::query (DatabaseBase::query))" Quite old, possibly solved in newer MediaWiki versions
  • T58269 "Uncommitted DB writes (transaction from DatabaseBase::query (Block::newLoad))" Quite old, possibly solved in newer MediaWiki versions
  • T52778 "nested transaction in update.php when updating collation" Quite old, possibly solved in newer MediaWiki versions
  • T132215 "Do not show recent changes for recently deleted pages" About the design to make as deferred updates for remove RC entries, parly solved (mitigated) by this fix (linked to T153849 "Deleted pages' creation entry shows up in Special:RecentChanges as a redlink since MW 1.28")
Jun 9 2017, 9:14 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

I am able to confirm the observation (sadly)

@Seb35 Thanks for your time and effort.

Jun 9 2017, 8:55 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

Closed the quasi-duplicates T154438, T157679, T166867, T153849 (same call stack but different user-end actions).

Jun 9 2017, 7:47 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 closed T153849: Deleted pages' creation entry shows up in Special:RecentChanges as a redlink since MW 1.28 as Resolved.

Closed this task given it is almost a duplicate for T154425, it is solved by https://gerrit.wikimedia.org/r/#/c/356619/ (fixed in 1.28, 1.29, 1.30). An issue remains as of now, see T154425 for details.

Jun 9 2017, 7:38 AM · Multimedia, MediaWiki-Patrolling, MediaWiki-File-management, MediaWiki-JobQueue, ShoutWiki, MediaWiki-Recent-changes
Seb35 closed T166867: DBUnexpectedError from line 2877 of Database.php: MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush). as Resolved.

Closed this task given it is almost a duplicate for T154425, it is solved by https://gerrit.wikimedia.org/r/#/c/356619/ (fixed in 1.28, 1.29, 1.30). An issue remains as of now, see T154425 for details.

Jun 9 2017, 7:35 AM · MW-1.29-release-notes, MediaWiki-Database, MediaWiki-JobQueue, MW-1.29-release
Seb35 closed T157679: Exception thrown with an uncommited database transaction: MWCallableUpdate::doUpdate: Flush failed on server(s) as Resolved.

Closed this task given it is almost a duplicate for T154425, it is solved by https://gerrit.wikimedia.org/r/#/c/356619/ (fixed in 1.28, 1.29, 1.30). An issue remains as of now, see T154425 for details.

Jun 9 2017, 7:34 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Patch-For-Review, MediaWiki-Database
Seb35 closed T157679: Exception thrown with an uncommited database transaction: MWCallableUpdate::doUpdate: Flush failed on server(s), a subtask of T41480: Bugs affecting translatewiki.net (errors from MediaWiki master) (tracking), as Resolved.
Jun 9 2017, 7:34 AM · Tracking, MediaWiki-General-or-Unknown
Seb35 closed T154438: Special:MovePage throws MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush, JobQueueDB::doBatchPush) as Resolved.

Closed this task given it is almost a duplicate for T154425, it is solved by https://gerrit.wikimedia.org/r/#/c/356619/ (fixed in 1.28, 1.29, 1.30). An issue remains as of now, see T154425 for details.

Jun 9 2017, 7:33 AM · MW-1.29-release-notes, MediaWiki-JobQueue, MW-1.29-release, MediaWiki-Database

Jun 8 2017

Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

I see some resolution path:

  • deactivate DeferredUpdates::tryOpportunisticExecute (it’s quite brutal)
  • add a check to the transaction status in DeferredUpdates::getBusyDbConnections
  • lazy push all jobs in CLI to defer their pushing at the end of the job execution (although it should be carefully designed because pushLazyJobs will push the jobs, and an indefinite loop could be created)
Jun 8 2017, 2:58 PM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

I pretty sure there is no issue with Redis-managed queues.

Jun 8 2017, 12:55 PM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

I localised the issue in DeferredUpdates::tryOpportunisticExecute() [which is pretty expected given it’s a difference between CLI and Web execution of jobs] => the callback is directly executed, but still don’t know why it does not add the job to the job queue.

Jun 8 2017, 11:58 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database