Seb35 (Seb35)
MediaWiki gnome

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 9:50 AM (145 w, 4 d)
Availability
Available
IRC Nick
seb35
LDAP User
Seb35
MediaWiki User
Seb35

I follow MediaWiki development since 2007. Although I don’t regularly submit patches for the MediaWiki core, I act as an ambassador, submitting bugs, helping in their resolution, exchanging with the French-speaking community, improving documentation and its translation into French, etc. I developed three extensions (BackwardsTimeTravel, HSTS, and MediaWikiFarm).

Since 2016, I run a small MediaWiki consulting company in France, which help companies, associations and public sector to set up MediaWiki installations.

My GitHub account is Seb35.

Recent Activity

Tue, Jul 18

Seb35 added a comment to T146841: Reach out to Google about @yahoo.com emails not reaching gmail inboxes (when sent to mailing lists).

Instead of reaching Google about this issue, it should first be tried to implement the DMARC-workaround in Mailman 2.1.18 as described in T168467.

Tue, Jul 18, 8:34 PM · Wikimedia-Mailing-lists, Operations
Seb35 added a comment to T168467: Improve lists.wikimedia.org DMARC compatibility.

Recently a sender with a yahoo.fr address sent an email on the list wikimediafr ∂ lists.wikimedia.org (newly created) and Mailman unsubscribed many addresses (mostly gmail.com I think) because Gmail rejected the message (because of Yahoo DMARC policy). See this message in French from the moderator. The moderators just changed the DMARC behaviour to "Munge From".

Tue, Jul 18, 8:21 PM · Patch-For-Review, Wikimedia-Mailing-lists, Mail
Seb35 added a comment to T55341: Convert $wgDebugDBTransactions to debug log group..

@Nikerabbit: the configuration parameter $wgDebugDBTransactions was removed in 1.27.0 in this commit. Do you want to re-phrase this task or possibly close it?

Tue, Jul 18, 1:14 PM · MediaWiki-Database
Seb35 added a comment to T85762: Get rid of the Uncommitted DB writes notice.

Still current in MediaWiki 1.27: Topic:Tr7p9m3hybmc7kf3

Tue, Jul 18, 12:58 PM · MediaWiki-Database
Seb35 added a comment to T140340: Connect moved paragraphs by arrows.

I like this design, I find it more clear with arrows than without. Some small comments:

  1. First, a graphical detail: I don’t know if it’s possible in CSS, but I find some bluring around the elements "Line 35" , "+" , "-" could be more aesthetic (that’s my opinion, but you’re free to ignore it if you find otherwise).
  2. I thought about a refinement – but you already mentioned it in your comment – about highlighting the arrows on hover (useful in case of visually closed moves) and/or when clicking/touching (useful in case of long-distance moves), which would be particularly useful if there are a lot of moves.
  3. If there are a lot of moves (I see T166571 mentions a maximum of 25 moves), what would be the behaviour?
    1. For some informational comparison, below is an illustration of how Git shows parallel branches (that’s not exactly the same application as here but a similar design – arrows linking points): it was chosen to take a fixed width for each arrow (and hence a variable total width), but in our case the total width is fixed and it’s sensible in our case.
    2. A design choice could be that the lines collapse together. In this case some highlighting would become a great helper to visually distinguish a specific move between the others.
    3. Another design choice could be to only display arrows on hovering/clicking/touching.
    4. It could be also a mix of the second and third points, and for example only short-distance moves are displayed by default and long-distances moves are only displayed on hovering/clicking/touching.
Tue, Jul 18, 12:01 PM · German-Community-Wishlist, Design, WMDE-Design, TCB-Team

Mon, Jul 17

Seb35 added a watcher for MW-1.30-release: Seb35.
Mon, Jul 17, 8:57 PM

Thu, Jul 13

Seb35 added a comment to T162737: Create a list of all known wikis in MediaWikiFarm.

Other uses of such a list would be to define the virtual hosts in the webserver (see this method for nginx for instance) and in the DNS, in order to avoid either manual editing of these config files either catch-all regexes. This use case could also be delegated to an external configuration management tool (Ansible, etc.), to be decided if it is taken into account specifically by MediaWikiFarm.

Thu, Jul 13, 9:27 AM · MediaWiki-extensions-MediaWikiFarm

Mon, Jul 10

Seb35 created T170151: Empty categories are not proposed in VisualEditor.
Mon, Jul 10, 2:32 PM · VisualEditor

Thu, Jul 6

Seb35 added a comment to T90249: Establish and consistently release schedule for MediaWiki releases.

What exactly is expected to solve this task? There is the page Version lifecycle, which gives some details about scheduling for MediaWiki versions. Or is it about updating the page Release checklist with current processes?

Thu, Jul 6, 9:22 PM · Release-Engineering-Team (Kanban), User-greg, MediaWiki-Stakeholders-Group, MediaWiki-Releasing

Tue, Jul 4

Seb35 updated subscribers of T168723: LinksUpdate totally broken when JobQueueDB is in use.

I and @Envlh tried various configurations; it seems that, with the current master (884a54e) and REL1_29 (eb815ad), it works with a fresh installation without any extensions (only skins) (i.e. categories are correctly added, sometimes with some delay), but I experience the bug (=pages are not added in a category and job queue is empty) in some cases with only the Translate extension activated ("some cases" = with specific configuration parameters – we were not able still to determine what configuration parameters exactly), and possibly the bug occurs with other extensions and/or set of extensions and/or specific configuration.

Tue, Jul 4, 10:36 PM · MW-1.29-release-notes, MW-1.30-release-notes, MediaWiki-JobQueue, Performance-Team, MediaWiki-Platform-Team, MW-1.29-release

Thu, Jun 29

Seb35 closed T155076: VisualEditor REL1_23 is not distributed by ExtensionDistributor as Resolved.

Given MediaWiki 1.23 is deprecated now, it is no more available in downloading through the ExtensionDistributor, but it remains available with the Git installation (similarly to what is explained for other branches in Extension:VisualEditor#Download):

Thu, Jun 29, 8:45 AM · User-Ryasmeen, VisualEditor, ExtensionDistributor

Tue, Jun 27

Seb35 added a comment to T168723: LinksUpdate totally broken when JobQueueDB is in use.

Studied, the situation could become better but the bug is not solved.

Tue, Jun 27, 11:31 PM · MW-1.29-release-notes, MW-1.30-release-notes, MediaWiki-JobQueue, Performance-Team, MediaWiki-Platform-Team, MW-1.29-release
Seb35 added a comment to T168347: DeferredUpdates hides exceptions.

I didn’t see the notification earlier -- in fact it was in my bunch of emails, but I would have expected that a direct mention shows something in Phabricator like in MediaWiki/Echo, seems it’s not the case.

Tue, Jun 27, 9:26 PM · MW-1.30-release-notes, MW-1.29-release-notes, MediaWiki-Debug-Logger, Patch-For-Review, MW-1.29-release, MediaWiki-Database

Sun, Jun 25

Seb35 moved T168807: A forced-mechanism missing extension should be gracefully disabled in MediaWikiFarm from Backlog to Features on the MediaWiki-extensions-MediaWikiFarm board.
Sun, Jun 25, 10:49 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 added a comment to T162690: Take into account the special nature of $wgExtensionDirectory in MediaWikiFarm.

Note that Composer-managed extensions must be in $IP/extensions and cannot be moved elsewhere because it is written in Composer autoload (and is the expected location during installation/update). Hence Composer-managed extensions must be there even if non-Composer-managed extensions could be elsewhere according to wgExtensionDirectory/wgStyleDirectory. It is not possible to change that, so let’s call it a Composer feature.

Sun, Jun 25, 10:46 PM · Patch-For-Review, MediaWiki-extensions-MediaWikiFarm
Seb35 triaged T168807: A forced-mechanism missing extension should be gracefully disabled in MediaWikiFarm as Lowest priority.
Sun, Jun 25, 10:38 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 created T168807: A forced-mechanism missing extension should be gracefully disabled in MediaWikiFarm.
Sun, Jun 25, 10:37 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 closed T162690: Take into account the special nature of $wgExtensionDirectory in MediaWikiFarm as Resolved.
Sun, Jun 25, 10:28 PM · Patch-For-Review, MediaWiki-extensions-MediaWikiFarm
Seb35 committed rEMWF698913b16f65: Add support for wgExtensionDirectory and wgStyleDirectory (authored by Seb35).
Add support for wgExtensionDirectory and wgStyleDirectory
Sun, Jun 25, 10:14 PM
Seb35 committed rEMWFd63881c9030b: Execute scripts when wikis are path-based (authored by Seb35).
Execute scripts when wikis are path-based
Sun, Jun 25, 5:59 PM

Jun 20 2017

Seb35 triaged T168389: Create a maintenance script in Flow to rename a wiki as Low priority.

I did the following operations in database in a wiki and it globally works (*):

UPDATE flow_ext_ref SET ref_src_wiki = 'newWikiID' WHERE ref_src_wiki = 'oldWikiID';
UPDATE flow_revision SET rev_user_wiki = 'newWikiID' WHERE rev_user_wiki = 'oldWikiID';
UPDATE flow_revision SET rev_mod_user_wiki = 'newWikiID' WHERE rev_mod_user_wiki = 'oldWikiID';
UPDATE flow_revision SET rev_edit_user_wiki = 'newWikiID' WHERE rev_edit_user_wiki = 'oldWikiID';
UPDATE flow_tree_revision SET tree_orig_user_wiki = 'newWikiID' WHERE tree_orig_user_wiki = 'oldWikiID';
UPDATE flow_wiki_ref SET ref_src_wiki = 'newWikiID' WHERE ref_src_wiki = 'oldWikiID';
UPDATE flow_workflow SET workflow_wiki = 'newWikiID' WHERE workflow_wiki = 'oldWikiID';
UPDATE flow_subscription SET subscription_user_wiki = 'newWikiID' WHERE subscription_user_wiki = 'oldWikiID';

(The last table was empty, so I’m less sure, but it seems it should be changed too.)

Jun 20 2017, 11:43 AM · Flow, Collaboration-Team-Triage
Seb35 created T168389: Create a maintenance script in Flow to rename a wiki.
Jun 20 2017, 11:28 AM · Flow, Collaboration-Team-Triage

Jun 16 2017

Seb35 added a comment to T166384: scap: Investigate scaps handling of InitialiseSettings.php.

Note that there is a filemtime( "InitialiseSettings.php" ) in https://phabricator.wikimedia.org/source/mediawiki-config/browse/master/wmf-config/CommonSettings.php;3d7a96ad4d39b09960f4c212109ff7e129cdc712$159. I guess it explains why touching InitialiseSettings.php triggered the beginning of the performance issues, possibly some feature flag or parameter was activated at this time. (I didn’t read in details the post-mortem itself.)

Jun 16 2017, 4:15 PM · Release-Engineering-Team (Kanban), Scap
Seb35 added a comment to T117332: Links tables are sometimes not being populated.

For those who saw this issue, could you re-check if you still experience this issue? There were quite a lot of changes around jobs and related topics since this task was first opened, it could have been fixed.

Jun 16 2017, 2:44 PM · MediaWiki-JobQueue, MediaWiki-Page-editing
Seb35 added a comment to T166738: Error "Class 'MWTimestamp' not found" when upgrading to MW 1.29.0-rc.0.

I found the task T164896 recently closed, possibly similar to this one (class_alias issue).

Jun 16 2017, 1:51 PM · Timestamp
Seb35 added a comment to T100085: PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted.

@aaron I added some documentation on Manual:Job queue and Manual:Job queue/For developers; could you review it and particularly the differences between deferrable updates and jobs? It should help developers to decide if they want to use a deferrable update and/or a job.

Jun 16 2017, 12:16 PM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.28-release, Wikimedia-log-errors, Performance-Team, MW-1.27-release, MW-1.29-release, MediaWiki-JobQueue

Jun 15 2017

Seb35 added a comment to T166738: Error "Class 'MWTimestamp' not found" when upgrading to MW 1.29.0-rc.0.

I’m no more sure how I did to see the error, I guess it is a very specific state.

Jun 15 2017, 8:26 AM · Timestamp

Jun 13 2017

Seb35 updated the task description for T154438: Special:MovePage throws MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush, JobQueueDB::doBatchPush).
Jun 13 2017, 5:17 PM · MW-1.29-release-notes, MediaWiki-JobQueue, MW-1.29-release, MediaWiki-Database
Seb35 updated the task description for T100085: PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted.
Jun 13 2017, 5:17 PM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.28-release, Wikimedia-log-errors, Performance-Team, MW-1.27-release, MW-1.29-release, MediaWiki-JobQueue
Seb35 updated the task description for T165714: BagOStuff::trackDuplicateKeys causes a "MWCallableUpdate::doUpdate: transaction round ..." during JobRunner::executeJob.
Jun 13 2017, 5:17 PM · MW-1.29-release-notes, MW-1.29-release, Patch-For-Review, MediaWiki-JobQueue, Performance-Team, MediaWiki-Database
Seb35 updated the task description for T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".
Jun 13 2017, 5:16 PM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database

Jun 10 2017

Linedwell awarded T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)" a Cookie token.
Jun 10 2017, 3:02 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database

Jun 9 2017

Seb35 added a comment to T132215: Do not show recent changes for recently deleted pages.

Not sure about the MediaWiki version then (1.27-alpha or 1.28-alpha) but possibly this is partly solved by T153849 "Deleted pages' creation entry shows up in Special:RecentChanges as a redlink since MW 1.28" (duplicate of T154425): it is still a deferred update (by design) but it will work better.

Jun 9 2017, 9:20 AM · MediaWiki-JobQueue, MediaWiki-Recent-changes
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

I link here some other tasks I found as partly linked to this one - if someone want to check in details and/or discuss these and/or close these:

  • T85762 "Get rid of the Uncommitted DB writes notice" A proposal about hiding these warnings in some cases
  • T85734 "Uncommitted DB writes (transaction from DatabaseBase::query (DatabaseBase::query))" Quite old, possibly solved in newer MediaWiki versions
  • T58269 "Uncommitted DB writes (transaction from DatabaseBase::query (Block::newLoad))" Quite old, possibly solved in newer MediaWiki versions
  • T52778 "nested transaction in update.php when updating collation" Quite old, possibly solved in newer MediaWiki versions
  • T132215 "Do not show recent changes for recently deleted pages" About the design to make as deferred updates for remove RC entries, parly solved (mitigated) by this fix (linked to T153849 "Deleted pages' creation entry shows up in Special:RecentChanges as a redlink since MW 1.28")
Jun 9 2017, 9:14 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

I am able to confirm the observation (sadly)

@Seb35 Thanks for your time and effort.

Jun 9 2017, 8:55 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

Closed the quasi-duplicates T154438, T157679, T166867, T153849 (same call stack but different user-end actions).

Jun 9 2017, 7:47 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 closed T153849: Deleted pages' creation entry shows up in Special:RecentChanges as a redlink since MW 1.28 as Resolved.

Closed this task given it is almost a duplicate for T154425, it is solved by https://gerrit.wikimedia.org/r/#/c/356619/ (fixed in 1.28, 1.29, 1.30). An issue remains as of now, see T154425 for details.

Jun 9 2017, 7:38 AM · Multimedia, MediaWiki-Patrolling, MediaWiki-File-management, MediaWiki-JobQueue, ShoutWiki, MediaWiki-Recent-changes
Seb35 closed T166867: DBUnexpectedError from line 2877 of Database.php: MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush). as Resolved.

Closed this task given it is almost a duplicate for T154425, it is solved by https://gerrit.wikimedia.org/r/#/c/356619/ (fixed in 1.28, 1.29, 1.30). An issue remains as of now, see T154425 for details.

Jun 9 2017, 7:35 AM · MW-1.29-release-notes, MediaWiki-Database, MediaWiki-JobQueue, MW-1.29-release
Seb35 closed T157679: Exception thrown with an uncommited database transaction: MWCallableUpdate::doUpdate: Flush failed on server(s) as Resolved.

Closed this task given it is almost a duplicate for T154425, it is solved by https://gerrit.wikimedia.org/r/#/c/356619/ (fixed in 1.28, 1.29, 1.30). An issue remains as of now, see T154425 for details.

Jun 9 2017, 7:34 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Patch-For-Review, MediaWiki-Database
Seb35 closed T157679: Exception thrown with an uncommited database transaction: MWCallableUpdate::doUpdate: Flush failed on server(s), a subtask of T41480: Bugs affecting translatewiki.net (errors from MediaWiki master) (tracking), as Resolved.
Jun 9 2017, 7:34 AM · Tracking, MediaWiki-General-or-Unknown
Seb35 closed T154438: Special:MovePage throws MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush, JobQueueDB::doBatchPush) as Resolved.

Closed this task given it is almost a duplicate for T154425, it is solved by https://gerrit.wikimedia.org/r/#/c/356619/ (fixed in 1.28, 1.29, 1.30). An issue remains as of now, see T154425 for details.

Jun 9 2017, 7:33 AM · MW-1.29-release-notes, MediaWiki-JobQueue, MW-1.29-release, MediaWiki-Database

Jun 8 2017

Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

I see some resolution path:

  • deactivate DeferredUpdates::tryOpportunisticExecute (it’s quite brutal)
  • add a check to the transaction status in DeferredUpdates::getBusyDbConnections
  • lazy push all jobs in CLI to defer their pushing at the end of the job execution (although it should be carefully designed because pushLazyJobs will push the jobs, and an indefinite loop could be created)
Jun 8 2017, 2:58 PM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

I pretty sure there is no issue with Redis-managed queues.

Jun 8 2017, 12:55 PM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

I localised the issue in DeferredUpdates::tryOpportunisticExecute() [which is pretty expected given it’s a difference between CLI and Web execution of jobs] => the callback is directly executed, but still don’t know why it does not add the job to the job queue.

Jun 8 2017, 11:58 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

@mwjames @Krinkle I am able to confirm the observation (sadly): the FakeDispatchJob, added by SecondaryUpdateJob, is not added in the job queue when the job queue is executed on CLI (but works when executed on Web).

Jun 8 2017, 9:42 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 closed T100085: PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted as Resolved.

Resolved in 1.27-1.30 (see summary in description for an overview of the two similar bugs).

Jun 8 2017, 8:43 AM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.28-release, Wikimedia-log-errors, Performance-Team, MW-1.27-release, MW-1.29-release, MediaWiki-JobQueue
Seb35 closed T100085: PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted, a subtask of T41480: Bugs affecting translatewiki.net (errors from MediaWiki master) (tracking), as Resolved.
Jun 8 2017, 8:43 AM · Tracking, MediaWiki-General-or-Unknown

Jun 7 2017

Seb35 added a comment to T166738: Error "Class 'MWTimestamp' not found" when upgrading to MW 1.29.0-rc.0.

Hmm, I now have this issue - not sure why I didn’t have previously.

Jun 7 2017, 8:30 AM · Timestamp
Seb35 closed T165714: BagOStuff::trackDuplicateKeys causes a "MWCallableUpdate::doUpdate: transaction round ..." during JobRunner::executeJob as Resolved.

Thanks for the confirmation @mwjames: given the possibly wide range of potential issues, it helps to have a +1 from a different setup.

Jun 7 2017, 8:01 AM · MW-1.29-release-notes, MW-1.29-release, Patch-For-Review, MediaWiki-JobQueue, Performance-Team, MediaWiki-Database
Seb35 updated the task description for T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".
Jun 7 2017, 7:51 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 updated the task description for T154438: Special:MovePage throws MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush, JobQueueDB::doBatchPush).
Jun 7 2017, 7:51 AM · MW-1.29-release-notes, MediaWiki-JobQueue, MW-1.29-release, MediaWiki-Database
Seb35 updated the task description for T100085: PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted.
Jun 7 2017, 7:50 AM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.28-release, Wikimedia-log-errors, Performance-Team, MW-1.27-release, MW-1.29-release, MediaWiki-JobQueue
Seb35 updated the task description for T165714: BagOStuff::trackDuplicateKeys causes a "MWCallableUpdate::doUpdate: transaction round ..." during JobRunner::executeJob.
Jun 7 2017, 7:50 AM · MW-1.29-release-notes, MW-1.29-release, Patch-For-Review, MediaWiki-JobQueue, Performance-Team, MediaWiki-Database
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

The patch should be backported to REL1_29 and REL1_28. Should be checked for REL1_27.

Jun 7 2017, 7:02 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database

Jun 3 2017

Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

Ok so when a problem is solved another appears. We are in the shutdown, hence nothing is like normal operation. What happens with the proposed change is to add the lazy jobs as a deferrable update and not with onTransactionIdle (given it’s not possible due to Database mechanisms). So in the shutdown (either MediaWiki::restInPeace() either JobRunner::executeJob()), you execute the deferred updates, you add lazy jobs, and since the lazy jobs are added through a deferrable update, nothing more happens since deferred updates are already executed.

Jun 3 2017, 5:11 PM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

Ok, I am able to reproduce the issue you are observing @mwjames, I investigate.

Jun 3 2017, 4:26 PM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

From what I understand in this issue, when you have an EnqueuableDataUpdate (e.g. when you delete a page) and a classical DeferrableUpdate (e.g. Pingback, which is always added):

Jun 3 2017, 3:50 PM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

So it would suggest the issue is in JobQueue::push(). If you set $wgJobRunRate to 0, do you see the job(s) with showJobs.php?

Jun 3 2017, 3:29 PM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T160710: Session (new) Developers and MediaWiki: How to become BFFs?.

It is missing the 'Thanks' extension on Phabricator :) but thanks for the session and for the outcomes (notes and photos).

Jun 3 2017, 3:01 PM · Developer-Relations (Jul-Sep 2017), TCB-Team, Wikimedia-Hackathon-2017
Seb35 awarded T160710: Session (new) Developers and MediaWiki: How to become BFFs? a Barnstar token.
Jun 3 2017, 2:59 PM · Developer-Relations (Jul-Sep 2017), TCB-Team, Wikimedia-Hackathon-2017
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

The more worrying factor is that I executed the same process and now jobs are inserted which seems to indicate some non deterministic (or better opportunistic) behaviour.

Never mind my last comment, I actually reverted to the onTransactionIdle in doBatchPush to compare the results which showed the expected behaviour of jobs being inserted and executed but as soon as I switch to the proposed AutoCommitUpdate handler, jobs just vanish.

Jun 3 2017, 2:26 PM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 updated the task description for T154438: Special:MovePage throws MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush, JobQueueDB::doBatchPush).
Jun 3 2017, 10:51 AM · MW-1.29-release-notes, MediaWiki-JobQueue, MW-1.29-release, MediaWiki-Database
Seb35 updated the task description for T100085: PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted.
Jun 3 2017, 10:50 AM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.28-release, Wikimedia-log-errors, Performance-Team, MW-1.27-release, MW-1.29-release, MediaWiki-JobQueue
Seb35 updated the task description for T165714: BagOStuff::trackDuplicateKeys causes a "MWCallableUpdate::doUpdate: transaction round ..." during JobRunner::executeJob.
Jun 3 2017, 10:50 AM · MW-1.29-release-notes, MW-1.29-release, Patch-For-Review, MediaWiki-JobQueue, Performance-Team, MediaWiki-Database
Seb35 updated the task description for T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".
Jun 3 2017, 10:49 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".
  1. Just to be sure: you have both the gerrit patches https://gerrit.wikimedia.org/r/#/c/356120/ (now in master, REL1_29 and REL1_28 branches) and https://gerrit.wikimedia.org/r/#/c/356619/ ? Un-pushed lazy jobs are more specifically solved by https://gerrit.wikimedia.org/r/#/c/356120/ (T100085).
  2. What is your value of $wgJobRunRate ?
  3. How can you be sure they are never inserted in the job queue? To test this sort of things, I tend to set $wgJobRunRate to 0 (so that Web does not execute any jobs), wait at least 30 seconds, and run php maintenance/showJobs.php --group (or --list). The 30 seconds are mandatory because JobQueueDB has a cache of 30 seconds (JobQueueDB::CACHE_TTL_SHORT) -- sometimes I edit this constant to (e.g.) 3 to reduce the delays.
Jun 3 2017, 10:01 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T119330: Templates with parameters in the Index: namespace are dismissed when opening in editing.

If I understand correctly the deployments, the patch https://gerrit.wikimedia.org/r/#/c/328543/ is now live on Wikisource. However I just tested and it does not work: put the following wikitext in the 'Sommaire' of an index page, preview, and you see everything after the "\n|" (included) is removed.

{{Table
| page = {{pli|5}}
| indentation=-1
| titre = I. — Les temps.
}}
Jun 3 2017, 9:44 AM · Patch-For-Review, ProofreadPage
Seb35 added a comment to T163640: ConfiguredReadOnlyMode has a bad config during testing.

If someone else experience this issue, you must use PHPUnit ≥ 6.0 to solve it.

Jun 3 2017, 8:45 AM · MediaWiki-Core-Tests

Jun 2 2017

Seb35 added a comment to T165714: BagOStuff::trackDuplicateKeys causes a "MWCallableUpdate::doUpdate: transaction round ..." during JobRunner::executeJob.

Backported to 1.28, which is very similar to 1.29 in this area -- I was able to reproduce the same behaviour with Translate.

Jun 2 2017, 7:14 PM · MW-1.29-release-notes, MW-1.29-release, Patch-For-Review, MediaWiki-JobQueue, Performance-Team, MediaWiki-Database
Seb35 added a comment to T100085: PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted.

Backported to 1.28, which is very similar to 1.29 in this area -- I was able to reproduce the same behaviour with Translate.

Jun 2 2017, 7:11 PM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.28-release, Wikimedia-log-errors, Performance-Team, MW-1.27-release, MW-1.29-release, MediaWiki-JobQueue
Seb35 added a watcher for MW-1.29-release: Seb35.
Jun 2 2017, 5:35 PM
Seb35 added a comment to T166738: Error "Class 'MWTimestamp' not found" when upgrading to MW 1.29.0-rc.0.

I tried with the steps and was not able to reproduce the issue. MediaWiki from REL1_28 (664b1b4) to version 1.29.0-rc.0 (c749bf6) with the specific composer.local.json.

Jun 2 2017, 4:35 PM · Timestamp
Seb35 added a comment to T166867: DBUnexpectedError from line 2877 of Database.php: MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)..

Yes, it’s probably the same as T154425. I cannot be absolutely sure since it is a different action (not delete, restore, or move), so it will be better to check once T154425 will be fixed, but there is a high probability it will be fixed also.

Jun 2 2017, 12:27 PM · MW-1.29-release-notes, MediaWiki-Database, MediaWiki-JobQueue, MW-1.29-release
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

@Choralia the "PHP Deprecated" is probably unrelated to this specific bug, but possibly comes from a specific job from an extension. And it’s very subtle, but this specific bug is related to a specific job type (called deferred updates) which are not executed but deferred updates are not managed by the job queue, the bug about jobs remaining in the job queue is T165714, which is now fixed in the master version of MediaWiki. If you want to test the patch of the other bug, it should be with the master version (1.30.0-alpha) and it should be included also in 1.29.0 (probably in 1.29.0-rc.1).

Jun 2 2017, 9:13 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T100085: PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted.

Cherry-picked to REL1_29. I guess it should be backported to REL1_27 and REL1_28, but I’m not sure. Will check later, except if someone is quicker.

Jun 2 2017, 8:50 AM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.28-release, Wikimedia-log-errors, Performance-Team, MW-1.27-release, MW-1.29-release, MediaWiki-JobQueue
Seb35 added a comment to T165714: BagOStuff::trackDuplicateKeys causes a "MWCallableUpdate::doUpdate: transaction round ..." during JobRunner::executeJob.

Cherry-picked to REL1_29. I guess it should be backported to REL1_27 and REL1_28, but I’m not sure. Will check later, except if someone is quicker.

Jun 2 2017, 8:50 AM · MW-1.29-release-notes, MW-1.29-release, Patch-For-Review, MediaWiki-JobQueue, Performance-Team, MediaWiki-Database
Seb35 added a comment to T100085: PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted.

@ all: should be fixed in standard conditions for temperature and pressure in master version of MediaWiki. Could you test/verify if you still see this error? – I’m a bit afraid since Translatewiki has no Web-executed jobs, so no sure the patch will fix all cases.

Jun 2 2017, 8:20 AM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.28-release, Wikimedia-log-errors, Performance-Team, MW-1.27-release, MW-1.29-release, MediaWiki-JobQueue
Seb35 added a comment to T165714: BagOStuff::trackDuplicateKeys causes a "MWCallableUpdate::doUpdate: transaction round ..." during JobRunner::executeJob.

@mwjames Can you test with master version of MediaWiki? It should be fixed – Be warn: it does not fix (for now) the similar message from T154425.

Jun 2 2017, 8:15 AM · MW-1.29-release-notes, MW-1.29-release, Patch-For-Review, MediaWiki-JobQueue, Performance-Team, MediaWiki-Database

Jun 1 2017

Seb35 claimed T157679: Exception thrown with an uncommited database transaction: MWCallableUpdate::doUpdate: Flush failed on server(s).
Jun 1 2017, 4:39 PM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Patch-For-Review, MediaWiki-Database
Seb35 claimed T154438: Special:MovePage throws MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush, JobQueueDB::doBatchPush).
Jun 1 2017, 4:08 PM · MW-1.29-release-notes, MediaWiki-JobQueue, MW-1.29-release, MediaWiki-Database
Seb35 claimed T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".
Jun 1 2017, 4:08 PM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

Well, I’m quite confident in my understanding of this issue. If I’m correct, it happens with some deferred updates, namely EnqueueableDataUpdate – which can be converted to jobs – and it happens with the action "delete", "restore", and "move" because LinksDeletionUpdate and LinksUpdate implement EnqueueableDataUpdate. An other necessary condition is that another deferred updates, *not* an EnqueueableDataUpdate is exectuted at the same time.

Jun 1 2017, 2:05 PM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database
Seb35 added a comment to T154439: AutoCommitUpdate::doUpdate (Title->invalidateCache) causes Exception thrown with an uncommited database transaction.

In fact I do no more think it is the same as T154438 and T154425 but instead a true duplicate of T165714: I have SMW installed on my test wiki and it does not trigger exceptions (I have the patch https://gerrit.wikimedia.org/r/#/c/356120/ applied) -- I didn’t notice these exception before applying the patch but perhaps I missed these. A difference with the two other tasks is: the two others call DeferredUpdates::doUpdates directly from MediaWiki::restInPeace, but this task call DeferredUpdates::doUpdates after a call from DeferredUpdates::addUpdate from a job, so I’m pretty sure this will be solved with the gerrit patch.

Jun 1 2017, 12:03 PM · MediaWiki-Database
Seb35 created P5525 Exception in Gerrit#356120/4.
Jun 1 2017, 3:18 AM
Seb35 created P5524 Exception in Gerrit#356120/4 if no condition on CLI mode.
Jun 1 2017, 3:12 AM
Seb35 added a comment to T154439: AutoCommitUpdate::doUpdate (Title->invalidateCache) causes Exception thrown with an uncommited database transaction.

Very similar to T154438 and T154425 , should be checked after resolution of the other bug, or closed as a duplicate.

Jun 1 2017, 12:57 AM · MediaWiki-Database
Seb35 added a comment to T71614: The mysql extension is dead, long live PDO.

Duplicate of T120333?

Jun 1 2017, 12:44 AM · MediaWiki-Database
Seb35 added a comment to T97693: TransationProfiler should not apply to using LCStoreDB.

Perhaps a duplicate of T154424.

Jun 1 2017, 12:40 AM · MediaWiki-Cache, MediaWiki-Database

May 31 2017

Seb35 added a comment to T100085: PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted.

And TWN had previously $wgJobRunRate > 0 at the time the error message occured? (if you can remember, could it be correlated?)

May 31 2017, 10:21 AM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.28-release, Wikimedia-log-errors, Performance-Team, MW-1.27-release, MW-1.29-release, MediaWiki-JobQueue
Seb35 added a comment to T100085: PHP Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted.

I’m not sure the root cause of this bug is the same for everybody reporting here, because there two very different cases: $wgJobRunRate = 0 and $wgJobRunRate > 0, and given the situation changed with the Gerrit change 212485.

May 31 2017, 9:10 AM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.28-release, Wikimedia-log-errors, Performance-Team, MW-1.27-release, MW-1.29-release, MediaWiki-JobQueue

May 30 2017

Seb35 added a comment to T154425: Delete action throws a DBUnexpectedError with "MWCallableUpdate::doUpdate: Cannot flush snapshot because writes are pending (JobQueueDB::doBatchPush)".

I dived into this/these issues after issues with Translate.

May 30 2017, 8:24 AM · MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Performance-Team, MW-1.29-release, MediaWiki-Database

May 29 2017

Seb35 added a comment to T165714: BagOStuff::trackDuplicateKeys causes a "MWCallableUpdate::doUpdate: transaction round ..." during JobRunner::executeJob.

I experienced this bug this Translate jobs, here is a proposed fix. I don’t really have the time now to explain more my findings, but I will take time later.

May 29 2017, 11:26 PM · MW-1.29-release-notes, MW-1.29-release, Patch-For-Review, MediaWiki-JobQueue, Performance-Team, MediaWiki-Database
Seb35 added a comment to T165714: BagOStuff::trackDuplicateKeys causes a "MWCallableUpdate::doUpdate: transaction round ..." during JobRunner::executeJob.

I experienced this bug this Translate jobs, here is a proposed fix. I don’t really have the time now to explain more my findings, but I will take time later.

May 29 2017, 11:26 PM · MW-1.29-release-notes, MW-1.29-release, Patch-For-Review, MediaWiki-JobQueue, Performance-Team, MediaWiki-Database

May 26 2017

Seb35 added a comment to T149454: 1.28-alpha / Error: 42P01 ERROR: table "unittest_user_groups" does not exist.

Possibly this issue is linked to T155147, or at least the underlying code: initialisation of the database in unit tests is managed by two properties, one static and one non-static, so possibly it creates a disorder in the initialisation state of the database.

May 26 2017, 10:07 PM · Release-Engineering-Team (Kanban), MW-1.29-release-notes, MW-1.28-release-notes, MW-1.30-release-notes, Patch-For-Review, MW-1.29-release, PostgreSQL, Regression, MediaWiki-Core-Tests, MediaWiki-Database
Seb35 added a comment to T162686: Reorganise tests in MediaWikiFarm to focus on unit tests.

The recent change (-; 6e59c1063fc3 to isolate the configuration in a specific class is one step in this direction (the so-called divide-and-test strategy :-).

May 26 2017, 8:31 AM · MediaWiki-extensions-MediaWikiFarm

May 25 2017

Seb35 committed rEMWFd58c70369794: Refactoring: extraction of configuration compilation (authored by Seb35).
Refactoring: extraction of configuration compilation
May 25 2017, 6:10 PM
Seb35 committed rEMWFbbf2e7d0cca8: Refactoring: extraction of configuration compilation (authored by Seb35).
Refactoring: extraction of configuration compilation
May 25 2017, 6:02 PM

May 22 2017

Seb35 added a comment to T149579: Array to string conversion from Flow when using scripts against officewiki.

This bug also occurs in MediaWiki 1.28 + Flow branch REL1_28, is it possible to backport also to REL1_28? I prepare the Gerrit patch.

May 22 2017, 10:05 AM · MW-1.29-release (WMF-deploy-2016-11-15_(1.29.0-wmf.3)), Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), Patch-For-Review, Flow
Seb35 added a comment to T166017: Disable Flagged Revisions on sq.wikipedia.

(for information) Active users belonging to the "Reviewers" group : https://sq.wikipedia.org/wiki/Speciale:PërdoruesitAktivë?groups[]=reviewer&wpFormIdentifier=specialactiveusers&uselang=en

May 22 2017, 12:59 AM · Community-consensus-needed, Wikimedia-Site-requests

May 21 2017

Seb35 added a comment to T110465: Update SecureSessions to use AuthManager.

I finished the part for Authentication (CountryBinding and Tor), see the gerrit patch 352708.

May 21 2017, 1:29 PM · Patch-For-Review, MediaWiki-extensions-SecureSessions, MediaWiki-Authentication-and-authorization