Page MenuHomePhabricator

Seb35 (Seb35)
MediaWiki gnome

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 9:50 AM (496 w, 6 d)
Availability
Available
IRC Nick
seb35
LDAP User
Seb35
MediaWiki User
Seb35 [ Global Accounts ]

I follow MediaWiki development since 2007. Although I don’t regularly submit patches for the MediaWiki core, I act as an ambassador, submitting bugs, helping in their resolution, exchanging with the French-speaking community, improving documentation and its translation into French, etc. I developed three extensions (BackwardsTimeTravel, HSTS, and MediaWikiFarm).

Since 2016, I run a small MediaWiki consulting company in France, which help companies, associations and public sector to set up MediaWiki installations. We also have a farm mainly with private wikis; the farm is managed by MediaWikiFarm.

My GitHub account is Seb35.

Recent Activity

Fri, Apr 5

Seb35 added a comment to T360631: Singleton was called with no singleton theme set.

I completed the stacktrace in the description (log_errors_max_len has to be set to a larger value than 1024, like 2048).

Fri, Apr 5, 10:35 AM · VisualEditor
Seb35 updated the task description for T360631: Singleton was called with no singleton theme set.
Fri, Apr 5, 9:45 AM · VisualEditor

Thu, Apr 4

Seb35 awarded T361379: generateSitemap: Uninitialized string offset 0 a Like token.
Thu, Apr 4, 3:15 PM · MW-1.41-notes, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), MediaWiki-Platform-Team, MW-1.41-release, MediaWiki-Maintenance-system

Tue, Apr 2

Seb35 added a comment to T360631: Singleton was called with no singleton theme set.

I also observe this exception on MW 1.41.1 with VE REL1_41 on PHP 7.4. I wonder how crawlers find these links, they are not displayed by MediaWiki in the history page, so either they appear somewhere I’m not aware, either they are constructed by MediaWiki-optimised crawlers to crawl the histories.

Tue, Apr 2, 11:28 PM · VisualEditor

Sun, Mar 24

Seb35 added a comment to T360857: For pre-2005 users the API userinfo says the registration is the current day.

The relevant code in includes/api/ApiQueryUserInfo.php function getCurrentUserInfo is:

if ( isset( $this->prop['registrationdate'] ) ) {
        $regDate = $user->getRegistration();
        if ( $regDate !== false ) {
                $vals['registrationdate'] = wfTimestamp( TS_ISO_8601, $regDate );
        }
}

How it returns the current day:

  1. User::getRegistration() returns string|false|null (string = timestamp, false = anonymous user, null = logged-in user but no data),
  2. Here $regDate = null,
  3. so the condition $regDate !== false is true (because null !== false),
  4. and finally wfTimestamp( TS_ISO_8601, null ) returns the current date.
Sun, Mar 24, 4:57 PM · Patch-For-Review, MediaWiki-Action-API
Seb35 triaged T360857: For pre-2005 users the API userinfo says the registration is the current day as Low priority.
Sun, Mar 24, 4:48 PM · Patch-For-Review, MediaWiki-Action-API
Seb35 created T360857: For pre-2005 users the API userinfo says the registration is the current day.
Sun, Mar 24, 4:48 PM · Patch-For-Review, MediaWiki-Action-API

Feb 19 2024

Seb35 committed rEMWF7b8976740e4a: extension.json - don't use array syntax when hooks only have 1 handler (authored by DannyS712).
extension.json - don't use array syntax when hooks only have 1 handler
Feb 19 2024, 4:42 PM

Feb 15 2024

Seb35 added a comment to T357686: Uninitialised Parser::mOutput triggers an error.

As of now, $parser->getOutput() cannot be used with a fresh Parser because Parser::$mOutput is uninitialised.

Feb 15 2024, 4:51 PM · MediaWiki-extensions-Lingo, MediaWiki-Parser
Seb35 added a comment to T348223: LinkedWiki not compatible with wmf/1.41.0-wmf.29.

I observed this exact error with the extension Lingo, but it comes from a change introduced in MW 1.41.0, see T357686.

Feb 15 2024, 4:42 PM · NFDI, MediaWiki-extensions-LinkedWiki
Seb35 added a comment to T357686: Uninitialised Parser::mOutput triggers an error.

See also this small experiment with PHP 7.4.33:

$ php -a
Interactive mode enabled
Feb 15 2024, 4:29 PM · MediaWiki-extensions-Lingo, MediaWiki-Parser
Seb35 created T357686: Uninitialised Parser::mOutput triggers an error.
Feb 15 2024, 4:25 PM · MediaWiki-extensions-Lingo, MediaWiki-Parser
Seb35 added a comment to T335825: "LogicException: This ParserOutput contains no text!" while moving a page.

I’m quite sure this was fixed in 173efe9 (on 2023-05-09) and backported to REL1_35 (56c67a6), REL1_39 (0bd987c), and REL1_40 (35e4521). Do you confirm it works by using the lastest commit of branch REL1_39 (works also with the ExtensionDistributor)?

Feb 15 2024, 3:46 PM · MediaWiki-extensions-Lingo

Feb 14 2024

Seb35 added a comment to T350206: Add support for MWDebug and $wgDebugToolbar to MonologSpi.

This seems to be a duplicate of T114532, and there is Gerrit patch waiting for review :)

Feb 14 2024, 7:41 PM · Developer Productivity, MediaWiki-Debug-Logger
Seb35 committed rEMWF707d7e628b64: Version 2.0.0-dev.
Version 2.0.0-dev
Feb 14 2024, 6:36 PM
Seb35 committed rEMWF4b71a0c0b106: Exclude a test file from PHP linting.
Exclude a test file from PHP linting
Feb 14 2024, 5:43 PM
Seb35 committed rEMWF739bee33750d: Add allow-plugins in composer.json in test files.
Add allow-plugins in composer.json in test files
Feb 14 2024, 5:36 PM
Seb35 committed rEMWF0be6a97419ec: Deactivate a test to be fixed later.
Deactivate a test to be fixed later
Feb 14 2024, 5:24 PM

Jan 11 2024

Seb35 added a comment to T352682: Request for +2 on the extension DeletePagesForGood.

Thanks!

Jan 11 2024, 11:26 AM · Gerrit-Privilege-Requests

Dec 22 2023

Seb35 added a comment to T348426: Upgrade DicoAdo.org from 1.35.11 to 1.39.5 (LTS).

Here are the actions done on the skin, most are similar to those on previous 1.35 and adapted:

  • the skin foreground is now based on REL1_39 and specifically here f485d29, the diff is available with the command git diff when inside skins/foreground (NB: previously the skin foreground was hosted on GitHub, it is now hosted on Gerrit alongside most of other skins)
  • assets/scripts/foreground.js is replaced with the same file as in 1.35
  • assets/stylesheets/font-awesome.css is replaced with the same file as in 1.35 (FontAwesome Pro 5.15.1)
  • assets/stylesheets/foreground.css: removed rules about "#echo-notifications" (replaced by rules in MediaWiki:Foreground.css to be imported in production)
  • skin.json: removed "assets/stylesheets/fontawesome.css" (it is achieved with the modified script foreground.js)
  • Foreground.skin.php: diff below, the changes are:
    • moved the search bar from #top-bar-right to #top-bar-left
    • moved the Echo notifications and changed from div to ul-li
    • added the script Masonry
Dec 22 2023, 4:21 PM · WMCH-Infrastructure, DicoAdo.org

Dec 19 2023

Seb35 added a comment to T293109: Firefox: Referrer Policy: Less restricted policies, including ‘no-referrer-when-downgrade’, ‘origin-when-cross-origin’ and ‘unsafe-url’, will be ignored soon for the cross-site request.

Firefox enforces strict-origin-when-cross-origin since Firefox 93 (released in October 2021) when Tracking Protection is enabled. The user can disable it per-site (click on the shield in the address bar) and in this case these logs disappear in the console.

Dec 19 2023, 8:41 PM · Traffic, Browser-Support-Firefox
Seb35 added a comment to T257703: Clean up Cache-Control handling in MediaWiki.

More broadly, we may need to revisit the practice of eagerly setting up the session itself in Setup.php as well, since that itself may set cookies even if nothing attempts to interact with the session user during the lifetime of the request.

Dec 19 2023, 8:08 PM · Sustainability (Incident Followup), FR-CentralNotice-Caching, MediaWiki-Core-AuthManager
Seb35 added a comment to T285210: High frequency warning logged in production: Cookies set on {url} with Cache-Control "{cache-control}".

These two mechanisms are contradictory in the general case:

  1. on each new request where there is no cookie "_session" (always subdomain-local) but there is a cookie "Token" (might be domain-global), always define the session cookies;
  2. define cachable responses.
Dec 19 2023, 2:12 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Sustainability (Incident Followup), Fundraising-Backlog, Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-CentralNotice
Seb35 added a comment to T285210: High frequency warning logged in production: Cookies set on {url} with Cache-Control "{cache-control}".
In description, @daniel wrote:

It is unclear why session cookies are set here.

Dec 19 2023, 1:48 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Sustainability (Incident Followup), Fundraising-Backlog, Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-CentralNotice

Dec 8 2023

Seb35 added a comment to T348426: Upgrade DicoAdo.org from 1.35.11 to 1.39.5 (LTS).

I fixed 5 more issues today:

Dec 8 2023, 7:05 PM · WMCH-Infrastructure, DicoAdo.org

Dec 5 2023

Seb35 updated subscribers of T348426: Upgrade DicoAdo.org from 1.35.11 to 1.39.5 (LTS).

We worked today with @Nicolas_NALLET to fix various issues:

  • we silenced the warning Deprecated InternalParseBeforeSanitize hook on top of every page due to the extension Variables, there is a pending patch T250963 (silenced in [mediawiki]/includes/HookContainer/DeprecatedHooks.php
  • we disabled in the LocalSettings.php $wgUseFileCache = true; which triggered an error on the main page Fatal exception of type "Error" : this cache mechanism has very few users and is probably not really maintained: TODO it would be better to replace it by an external cache from Apache (NB: Wikimedia uses the software Varnish for this task, but it adds another software to be maintained, so perhaps not the better option here)
  • we updated the extension Cargo to its latest version in the branch REL1_39 (it triggered an errro on Special:Drilldown/Article): the few added commits fixes the issue
Dec 5 2023, 11:02 AM · WMCH-Infrastructure, DicoAdo.org

Dec 4 2023

Seb35 created T352682: Request for +2 on the extension DeletePagesForGood.
Dec 4 2023, 3:36 PM · Gerrit-Privilege-Requests
Seb35 closed T211757: Exception when the page contains some categories, a subtask of T231752: Use ordinary deletion prior to doing further cleanup, as Resolved.
Dec 4 2023, 3:07 PM · Patch-For-Review, MediaWiki-extensions-DeletePagesForGood
Seb35 closed T211757: Exception when the page contains some categories as Resolved.
Dec 4 2023, 3:06 PM · MediaWiki-extensions-DeletePagesForGood

Nov 9 2023

Seb35 added a comment to T229992: Locally created fallback should take precedent over config fallback.

I added T349115 as a subtask since it is a (minor) bug introduced in rMWbfd4001c6c229657091d866ae51e2cbb5979344a. I proposed a patch.

Nov 9 2023, 4:57 PM · MW-1.40-notes, MW-1.39-notes, User-notice, MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), I18n, MediaWiki-Internationalization, Chinese-Sites
Seb35 added a subtask for T229992: Locally created fallback should take precedent over config fallback: T349115: PHP Notice: Undefined offset: 1 in LocalisationCache.php on line 579.
Nov 9 2023, 4:54 PM · MW-1.40-notes, MW-1.39-notes, User-notice, MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), I18n, MediaWiki-Internationalization, Chinese-Sites
Seb35 added a parent task for T349115: PHP Notice: Undefined offset: 1 in LocalisationCache.php on line 579: T229992: Locally created fallback should take precedent over config fallback.
Nov 9 2023, 4:53 PM · MW-1.40-notes, MW-1.41-notes, MW-1.39-notes, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), MW-1.39-release, MediaWiki-Internationalization
Seb35 added a comment to T349115: PHP Notice: Undefined offset: 1 in LocalisationCache.php on line 579.

I also observe this error on 1.40.1. I’m not completely sure, but it seems to appear when the (default?) skin in not Vector ($wgDefaultSkin = 'chameleon'; in my case), I had these notices for only 3 message keys vector-view-(view|edit|history) whose the value is NULL in the $preload array.

Nov 9 2023, 4:10 PM · MW-1.40-notes, MW-1.41-notes, MW-1.39-notes, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), MW-1.39-release, MediaWiki-Internationalization

Oct 28 2023

Seb35 updated the task description for T208477: Move "privileged account' concept into MediaWiki core.
Oct 28 2023, 3:14 PM · MediaWiki-Platform-Team, MW-1.41-notes (1.41.0-wmf.26; 2023-09-12), MW-1.40-notes, MW-1.39-notes, Security, Security-Team, Patch-For-Review, MediaWiki-Debug-Logger, MediaWiki-Core-AuthManager

Oct 22 2023

Seb35 added a comment to T345319: TypeError: Argument 1 passed to HtmlFormatter\HtmlFormatter::onHtmlReady() must be of the type string, null given, called in /srv/mediawiki/php-1.41.0-wmf.24/vendor/wikimedia/html-formatter/src/HtmlFormatter.php on line 314.

I propose my patch, it fixes this issue as well as a similar one for long comments (the second preg_replace). I added 2 units tests inspired from matmarex’s comment above (T345319#9140869), these unit tests did not pass without this fix (triggering type errors) and pass with this fix.

Oct 22 2023, 7:01 PM · HtmlFormatter, MediaWiki-Parser, Discovery-Search, CirrusSearch, Wikimedia-production-error

Oct 21 2023

Seb35 added a comment to T345319: TypeError: Argument 1 passed to HtmlFormatter\HtmlFormatter::onHtmlReady() must be of the type string, null given, called in /srv/mediawiki/php-1.41.0-wmf.24/vendor/wikimedia/html-formatter/src/HtmlFormatter.php on line 314.

I observed this issue on 1.39.5. Given the simple regex, I replaced it by strpos+substr:

@@ -313 +313,10 @@ class HtmlFormatter {
-               $html = \preg_replace( '/^.*?<body>|<\/body>.*$/s', '', $html );
+               $pos = strpos( $html, '<body>' );
+               if ( $pos !== false ) {
+                       $html = substr( $html, $pos+6 );
+               }
+               $pos = strpos( $html, '</body>' );
+               if ( $pos !== false ) {
+                       $html = substr( $html, 0, $pos );
+               }
Oct 21 2023, 4:43 PM · HtmlFormatter, MediaWiki-Parser, Discovery-Search, CirrusSearch, Wikimedia-production-error

Oct 18 2023

Seb35 added a comment to T150526: BotPasswords: grant all rights.

I’m not sure why this task has the priority High, it seems there is no work done at least since 3-4 years, is there?

Oct 18 2023, 3:26 PM · Security, MediaWiki-Core-AuthManager
Seb35 added a comment to T150526: BotPasswords: grant all rights.

An alternative solution to fix the original issue would be a last grant "Misc. rights" containing all rights which are not attributed to a grant, so that we keep the spirit "only add necessary rights for a given task" as Tgr said above (T150526#2818602) and if some extension has not attributed its rights to a grant (as in subtasks of T142308) there is a transitional solution for users.

Oct 18 2023, 3:23 PM · Security, MediaWiki-Core-AuthManager

Oct 2 2023

Seb35 committed rEDPG36b9cb267e48: Deferred update for category count..
Deferred update for category count.
Oct 2 2023, 6:01 PM

Sep 27 2023

Seb35 added a comment to T257477: Preview fails when $wgRawHtml is activated.

For the record, I found the solution and it is unrelated to PageForms.

Sep 27 2023, 8:35 AM · MediaWiki-extensions-Page_Forms

Sep 26 2023

Seb35 awarded T47514: ResourceLoader: Implement support for Source Maps a Love token.
Sep 26 2023, 6:05 PM · User-notice-archive, Patch-For-Review, MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), MediaWiki-Platform-Team, Front-end-Standards-Group, MediaWiki-ResourceLoader
Seb35 removed a project from T99223: GENDER support for 'editinguser': Patch-For-Review.
Sep 26 2023, 10:10 AM · Gender-Support, MediaWiki-Internationalization
Seb35 added a member for Trusted-Contributors: Ypermat.
Sep 26 2023, 9:26 AM
Seb35 added a member for Trusted-Contributors: Nicolas_NALLET.
Sep 26 2023, 9:16 AM
Seb35 added a comment to T41676: Links in MediaWiki emails should respect the user's https preference.

There is still a 'prefershttps' in MediaWiki, but it is hidden when $wgForceHTTPS is true since rMWc75eef91bf27046ca (T256095).

Sep 26 2023, 8:41 AM · MediaWiki-Email

Sep 19 2023

Seb35 closed T220884: Update the DeletePagesForGood extension for MCR as Resolved.

Fixed by the patch 958530 of @BPirkle and myself.

Sep 19 2023, 3:46 PM · MediaWiki-extensions-DeletePagesForGood

Sep 18 2023

Seb35 committed rEDPG65d4c14590f8: Remove references to db fields rev_text_id and ar_text_id (authored by BPirkle).
Remove references to db fields rev_text_id and ar_text_id
Sep 18 2023, 7:56 PM

Aug 29 2023

Seb35 updated subscribers of T324646: 1.39 upgrade: Modifying tl_namespace field of table templatelinks: Error 1091: Can't DROP INDEX `PRIMARY`.

I have no good idea how to fix this from the updater side. As this state is unexpected (from my point of view) and possible the cause of some previous upgrade error, not sure if the updater should be smart enough to handle the case.

Aug 29 2023, 3:22 PM · MediaWiki-Installer, MW-1.39-release

Jul 21 2023

Seb35 updated subscribers of T291725: AbuseFilter causes Error 1091: Can't DROP INDEX `afl_filter_timestamp`; check that it exists.

During the update 1.31 → 1.35 → 1.39 of Vikidia, this issue was triggered, either in the original form Can't DROP 'filter_timestamp_full' with some upgrade path either in the form Duplicate key name 'afl_filter_timestamp_full' in another upgrade path (this second one because afl_filter_timestamp_full is created just before by patch-split-afl_filter.sql when there is no column abuse_filter_log.afl_filter_id in 1.39 updater).

Jul 21 2023, 9:37 AM · MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), affects-translatewiki.net, AbuseFilter

May 15 2023

Seb35 added a comment to T53110: Provide a way to exclude certain links to disambiguation pages from [[Special:DisambiguationPageLinks]].

As said above, this task makes [[Special:DisambiguationPageLinks]] useless on most wikis given there are legitimate links to disambiguations pages, often in header templates.

May 15 2023, 4:28 PM · MediaWiki-extensions-Disambiguator

May 3 2023

Seb35 added a comment to T213083: NumerAlpha extension: PHP Notice: Undefined index: full level prefix in NumerAlpha.class.php on line 266.

Imvuong provided a solution in the linked topic on MediaWiki.org, and I aggree with them: when full level prefix is not defined, it should be defined to the empty string, which is the default value in the powerful parser function {{counter:}}.

May 3 2023, 3:12 PM · MediaWiki-extensions-Other

Apr 17 2023

Seb35 added a comment to T203256: OATH (2FA) needs an option to remember device but not keep user logged in.

There may be situations where the user connects in a semi-trusted device and don’t want to let some secondary authentication token, e.g. when s/he uses a public library computer or a colleague’s computer. For instance it happened to me recently during a editathon where I had to use a public library computer (the WiFi was too secure and not available to visitors). Of course, a private browsing is preferable in this situation, when available.

Apr 17 2023, 3:15 PM · MediaWiki-extensions-OATHAuth

Apr 6 2023

Seb35 added a comment to T327584: Exception when the title is malformed.

This bug is fixed from version 1.40 (branch REL1_40).

Apr 6 2023, 7:04 PM · MediaWiki-extensions-Title-Icon

Feb 27 2023

Seb35 closed T273687: ProtectSite may grant rights to users they do not otherwise have as Resolved.

This is now fixed in branch master, so it will in branches REL1_40 and further, and in versions 0.5.4+.

Feb 27 2023, 10:53 AM · MediaWiki-extensions-ProtectSite, Uncyclomedia, ShoutWiki
Seb35 updated the task description for T330623: On-page debug log is empty.
Feb 27 2023, 8:44 AM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), MediaWiki-Debug-Logger
Seb35 updated the task description for T330623: On-page debug log is empty.
Feb 27 2023, 8:42 AM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), MediaWiki-Debug-Logger
Seb35 renamed T330623: On-page debug log is empty from On-page debug log is emtpy to On-page debug log is empty.
Feb 27 2023, 8:41 AM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), MediaWiki-Debug-Logger
Seb35 added a comment to T330623: On-page debug log is empty.

This bug is with the default LegacySpi, there is also T114532 with MonologSpi.

Feb 27 2023, 8:24 AM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), MediaWiki-Debug-Logger
Seb35 created T330623: On-page debug log is empty.
Feb 27 2023, 8:22 AM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), MediaWiki-Debug-Logger
Seb35 committed rEPRO385120e2c19a: Never grant rights when protecting the site.
Never grant rights when protecting the site
Feb 27 2023, 2:17 AM

Feb 26 2023

Seb35 added a comment to T168783: A failed CAPTCHA during account creation doesn't block the account request.

Fixed in branch REL1_39+ (version 1.39+). I updated MW.org.

Feb 26 2023, 1:09 PM · MediaWiki-extensions-ConfirmAccount

Feb 14 2023

Seb35 updated the task description for T10819: Full Path Disclosure vulnerability in MediaWiki 1.9.1.
Feb 14 2023, 6:14 PM · MediaWiki-Templates
Seb35 added a comment to T10819: Full Path Disclosure vulnerability in MediaWiki 1.9.1.

For reference this was fixed in Git commit 90759fa8a1a5187d881763ea89f9ca2f0a5f8a4a.

Feb 14 2023, 10:53 AM · MediaWiki-Templates

Feb 2 2023

Seb35 committed rECACc78c03dca122: Do verify the captcha.
Do verify the captcha
Feb 2 2023, 10:37 PM

Jan 21 2023

Seb35 added a comment to T312589: Graph is storing a stdClass not a JsonUnserializable.

I remarked there are two unserializations in IconManager, and removing the internal unserialization seems to fix the failing tests.

Jan 21 2023, 11:32 PM · Patch-Needs-Improvement, MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), MediaWiki-extensions-Graph, MediaWiki-Parser, Wikimedia-production-error
Seb35 added a comment to T312589: Graph is storing a stdClass not a JsonUnserializable.

The extension TitleIcon has a wrong unserialization since 96e4f5d8402 (more exactly the class MediaWiki\Extension\TitleIcon\Icon): see for instance the patch I am preparing, but the failing tests are independent of the patch and fail exactly when MediaWiki has 96e4f5d8402.

Jan 21 2023, 10:56 PM · Patch-Needs-Improvement, MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), MediaWiki-extensions-Graph, MediaWiki-Parser, Wikimedia-production-error
Seb35 triaged T327584: Exception when the title is malformed as Low priority.
Jan 21 2023, 7:41 PM · MediaWiki-extensions-Title-Icon
Seb35 added a comment to T327584: Exception when the title is malformed.

And here is the corresponding patch

Jan 21 2023, 7:31 PM · MediaWiki-extensions-Title-Icon
Seb35 created T327584: Exception when the title is malformed.
Jan 21 2023, 7:30 PM · MediaWiki-extensions-Title-Icon

Jan 17 2023

Seb35 added a comment to T168783: A failed CAPTCHA during account creation doesn't block the account request.

@Seb35 Will it be possible to back-port this to MW 1.39 since this the the LTS branch? Will be cool I believe.

Jan 17 2023, 3:22 PM · MediaWiki-extensions-ConfirmAccount

Jan 10 2023

Seb35 added a comment to T311449: ConfirmEdit - HCaptcha no longer working with Visual Editor in 1.38.1.

[e2b82f9bd017f414a556d7a9] /load.php?lang=en&modules=startup&only=scripts&raw=1&skin=chameleon TypeError: Argument 1 passed to MediaWiki\Extension\ConfirmEdit\hCaptcha\Hooks\ResourceLoaderHooks::getHCaptchaResourceLoaderConfig() must be an instance of MediaWiki\ResourceLoader\Context, instance of ResourceLoaderContext given, called in ----/includes/resourceloader/ResourceLoaderFileModule.php on line 1312

Jan 10 2023, 8:40 PM · MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), ConfirmEdit (CAPTCHA extension)

Nov 28 2022

Seb35 added a comment to T311167: Hit Count reported in Popular Pages is incorrect.

This is caused by rEHTC6827d8cdd7420074c50d38a8724c72fac5feac32: the SQL query constructed by MediaWiki is SELECT … FROM page p,hit_counter h ORDER BY … instead of SELECT … FROM hit_counter h JOIN page p ON ((p.page_id = h.page_id)) ORDER BY … (I removed the backticks here for readability), so a cross product is computed by MySQL instead of a JOIN.

Nov 28 2022, 4:36 PM · MW-1.39-release, MW-1.38-release, MediaWiki-extensions-HitCounters

Oct 22 2022

Seb35 merged T202235: MediaWiki 1.31 : Error from line 4829 of /var/lib/mediawiki/languages/Language.php into T198325: Using $this when not in object context when uploading html file or archive in Html2Wiki 1.31.
Oct 22 2022, 2:33 PM · MediaWiki-extensions-Html2Wiki
Seb35 merged task T202235: MediaWiki 1.31 : Error from line 4829 of /var/lib/mediawiki/languages/Language.php into T198325: Using $this when not in object context when uploading html file or archive in Html2Wiki 1.31.
Oct 22 2022, 2:32 PM · MediaWiki-extensions-Html2Wiki

Oct 17 2022

Seb35 changed the subtype of T320980: Add parameters to control ActorCache from "Task" to "Feature Request".
Oct 17 2022, 3:20 PM · MediaWiki-User-management
Seb35 created T320980: Add parameters to control ActorCache.
Oct 17 2022, 3:18 PM · MediaWiki-User-management

Oct 12 2022

Seb35 closed T168783: A failed CAPTCHA during account creation doesn't block the account request as Resolved.

Fixed in current master, so it will be available in REL1_40+ (version 1.40+).

Oct 12 2022, 12:11 PM · MediaWiki-extensions-ConfirmAccount

Sep 25 2022

Seb35 added a comment to T258537: Fix gitinfo.json issues in extdist.

Example of file generated:

{
  "head": "refs/heads/REL1_39",
  "headSHA1": "9ddf52d2df69634f558d6a3c04d4daa0b06dc4ff",
  "headCommitDate": 1660112594,
  "branch": "REL1_39",
  "remoteURL": "https://gerrit.wikimedia.org/r/mediawiki/extensions/Dashiki"
}
Sep 25 2022, 5:59 PM · Patch-For-Review, VPS-project-Extdist
Seb35 added a comment to T258537: Fix gitinfo.json issues in extdist.

In the linked patch, I changed the following entries in gitinfo.json to make them correspond to the GitInfo class of MediaWiki:

  • branch: changed from the HEAD’s SHA1 to the branch name (e.g. "REL1_39")
  • head: changed from the HEAD’s SHA1 to the branch reference (e.g. "refs/heads/REL1_39")
  • headCommitDate: changed from a string to an int
  • headSHA1: removed the trailing \n
Sep 25 2022, 5:57 PM · Patch-For-Review, VPS-project-Extdist
Seb35 added a comment to T253586: extensions including semantic-forms via composer are broken and breaking extension distributor.

There are no more issue with the mentionned repo SemanticPageSeries (the renaming from semantic-forms to page-forms is finished), but if we want to fix it for an hypothetical other case, including when a repo will be deleted (it will probably happen one day), I have the following proposition:

Sep 25 2022, 5:38 PM · MediaWiki-extensions-SemanticSignup, MediaWiki-extensions-Page_Forms, VPS-project-Extdist
Seb35 removed a project from T253586: extensions including semantic-forms via composer are broken and breaking extension distributor: MediaWiki-extensions-MediaWikiFarm.

I remove the tag MediaWikiFarm since page-forms only appears in test/phpunit/, not the root composer.json.

Sep 25 2022, 3:17 PM · MediaWiki-extensions-SemanticSignup, MediaWiki-extensions-Page_Forms, VPS-project-Extdist

Sep 24 2022

Seb35 added a comment to T253461: Liberate the @ for AtEase.

I modified mw:at-ease to reflect this decision, even if the library is strictly-speaking independent of MediaWiki.

Sep 24 2022, 9:59 PM · Performance-Team, TechCom, MediaWiki-Codesniffer, Proposal, at-ease, MediaWiki-General
Seb35 added a comment to T273687: ProtectSite may grant rights to users they do not otherwise have.

I propose the linked patch, adding on each right a preliminary condition ( $wgGroupPermissions[$group][$right] ?? false ) && … to be sure no right can be added but only removed.

Sep 24 2022, 7:15 PM · MediaWiki-extensions-ProtectSite, Uncyclomedia, ShoutWiki

Sep 21 2022

Seb35 committed rECAC9b6e91a3a364: Do verify the captcha.
Do verify the captcha
Sep 21 2022, 11:59 PM

Sep 9 2022

Seb35 committed rECAC21214092ba1b: Replace deprecated hook PersonalUrls.
Replace deprecated hook PersonalUrls
Sep 9 2022, 11:22 PM

Sep 3 2022

Seb35 closed T313937: PageForms: Call to a member function canExist() on null as Resolved.
Sep 3 2022, 6:25 PM · MediaWiki-extensions-Page_Forms

Aug 31 2022

Seb35 reopened T313937: PageForms: Call to a member function canExist() on null as "Open".

I reopen this task given I reached this bug in another code path (MW 1.38.2, PF 5.4 and current master a308554b9). I propose a complementary patch below.

Aug 31 2022, 9:34 AM · MediaWiki-extensions-Page_Forms

Aug 29 2022

Seb35 added a comment to T229092: Investigate migrateActors script failing due to duplicate empty actor_name.

migrateActors.php was added in 1.31 and this the beginning the option IGNORE is not present, so theoretically it could be backported in all versions. I did not request other backports since other versions are no more supported, but perhaps there are exceptions for upgrade-related patches?

Aug 29 2022, 6:24 PM · MW-1.35-notes, MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Platform Engineering (Icebox), MediaWiki-Maintenance-system
Seb35 closed T229092: Investigate migrateActors script failing due to duplicate empty actor_name as Resolved.

I close this task since the patch has been merged in master (future 1.39.0) and REL1_35 (future 1.35.8), which are both LTS versions.
NB: it is not fixed in 1.36, 1.37, or 1.38.

Aug 29 2022, 2:47 PM · MW-1.35-notes, MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Platform Engineering (Icebox), MediaWiki-Maintenance-system
Seb35 closed T229092: Investigate migrateActors script failing due to duplicate empty actor_name, a subtask of T167246: Refactor "user" & "user_text" fields into "actor" reference table, as Resolved.
Aug 29 2022, 2:47 PM · MediaWiki-Core-Revision-backend, Platform Team Initiatives (Revision Storage Schema Improvements), Schema-change, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Epic

Aug 28 2022

Seb35 removed a project from T283686: Replace Content::getNativeData() calls with TextContent::getText() in Wikibase: Patch-For-Review.

Wrong task number in my patch, I reaffected it. But related to this task to permit the removal of EntityContent::getNativeData().

Aug 28 2022, 6:04 PM · MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), Wikidata, MediaWiki-extensions-WikibaseRepository
Seb35 added a comment to T283691: Replace Content::getNativeData() calls with TextContent::getText() in SemanticACL.

TextContent::getText() was introduced in 1.33, here: rMW54c70c3551ea2b19a8967135fce5913c65e4bfbd.

Aug 28 2022, 5:53 PM · MediaWiki-extensions-SemanticACL
Seb35 added a comment to T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .

Currently AbstractContent::getNativeData() is an abstract method given it is defined in the interface Content but not defined in AbstractContent.

Aug 28 2022, 5:43 PM · Patch-Needs-Improvement, MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), Platform Engineering (Icebox), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Technical-Debt, User-Daniel, MediaWiki-ContentHandler
Seb35 added a comment to T283686: Replace Content::getNativeData() calls with TextContent::getText() in Wikibase.

Hello team,
I'm working on those sub-tasks to replace Content::getNativeData() to TextContent::getText().
For me is not clear how to replace it in EntityContent as it didn't have any dependency with TextContent.
So we have public method getNativeData in EntityContent that implements from Content, we call this method in getSize(). As we deprecate Content::getNativeData we should remove any usage of this method there.
And as I understand well the propose was to replace it with TextContent::getText().
Could you please provide more details about better way to replace it?

Aug 28 2022, 4:41 PM · MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), Wikidata, MediaWiki-extensions-WikibaseRepository
Seb35 added a comment to T229092: Investigate migrateActors script failing due to duplicate empty actor_name.

I re-tried yesterday in a lab environment to upgrade a wiki created in 2004 and in version 1.27. Probably someone did a hard cleanup (linked to spam?) because many users were missing in the user table and a few log_user_text or rev_user_text were an empty string, leading to this issue. In this case it is hard to re-create these data, even if sometimes possible (see T229092#7730875).

Aug 28 2022, 11:55 AM · MW-1.35-notes, MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Platform Engineering (Icebox), MediaWiki-Maintenance-system
Seb35 added a comment to T315657: Fatal exception of type "TypeError" from TranslatableBundleLogFormatter.php.

This is fixed and deployed in production (1.39.0-wmf.26), isn’t it?

Aug 28 2022, 9:10 AM · User-Urbanecm, Regression, Wikimedia-production-error, MediaWiki-extensions-Translate

Aug 25 2022

Seb35 added a comment to T313517: ApiSandbox 'continue' button breaks on second use.

I was bitten by this bug and found this issue. Here it is the fix as described by @Anomie (I added Co-Authored-by given it is the direct fix you proposed).

Aug 25 2022, 11:20 AM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), MediaWiki-Special-pages, MediaWiki-Action-API

Aug 23 2022

Seb35 added a comment to T217307: PageImages' og:image interferes with the one defined by OpenGraphMeta.

I documented this on MediaWiki.org.

Aug 23 2022, 10:02 AM · Web-Team-Backlog (Kanbanana-2022-23-Q1), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), patch-welcome, PageImages
Seb35 added a comment to T315740: Fatal error when there is an empty <source/>.

Thanks for catching this and submitting a patch. What is the expectation regarding these empty tags? Do we want to lint them away in the future? Or do we want to continue accepting them?

Aug 23 2022, 9:17 AM · MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Wikimedia-production-error, SyntaxHighlight

Aug 21 2022

Seb35 added a comment to T315827: GenderCache could avoid one SQL request sometimes.

I submit my current proposition as a WIP because it might be sub-optimal if the options of the current user are not loaded (and possibly detrimental to the performance in this specific case).

Aug 21 2022, 7:54 PM · Patch-For-Review, Performance Issue, MediaWiki-General