Seb35 (Seb35)
MediaWiki gnome

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 9:50 AM (172 w, 1 h)
Availability
Available
IRC Nick
seb35
LDAP User
Seb35
MediaWiki User
Seb35

I follow MediaWiki development since 2007. Although I don’t regularly submit patches for the MediaWiki core, I act as an ambassador, submitting bugs, helping in their resolution, exchanging with the French-speaking community, improving documentation and its translation into French, etc. I developed three extensions (BackwardsTimeTravel, HSTS, and MediaWikiFarm).

Since 2016, I run a small MediaWiki consulting company in France, which help companies, associations and public sector to set up MediaWiki installations.

My GitHub account is Seb35.

Recent Activity

Yesterday

Seb35 added a comment to T176765: Write browser tests for DonationInterface.

Duplicate of T99955 ?

Mon, Jan 22, 2:00 PM · Fundraising-Backlog, MediaWiki-extensions-DonationInterface
Seb35 added a comment to T180121: Provide way to configure or purge cache of VCS data on Special:Version or simply remove caching..

About the single cache file, it could be a performance improvement, but it remains to be implemented.

Mon, Jan 22, 10:37 AM · Patch-For-Review, MediaWiki-Special-pages, User-Addshore
Seb35 added a comment to T180121: Provide way to configure or purge cache of VCS data on Special:Version or simply remove caching..

On my dev install, I deactivated the vcs cache - I have a "deployment" commit removing the $cache->set, but I would be happy if a better solution is found.

Mon, Jan 22, 10:11 AM · Patch-For-Review, MediaWiki-Special-pages, User-Addshore

Sun, Jan 21

Seb35 added a comment to T127233: Endpoints which do not need to authenticate users should set MW_NO_SESSION.

FYI https://gerrit.wikimedia.org/r/#/c/394032/ (merged) is related to this task.

Sun, Jan 21, 6:13 PM · User-Tgr, MW-1.28-release (WMF-deploy-2016-05-10_(1.28.0-wmf.1)), MW-1.28-release-notes, Patch-For-Review, MW-1.27-release (WMF-deploy-2016-04-05_(1.27.0-wmf.20)), MW-1.27-release-notes, MediaWiki-Authentication-and-authorization

Fri, Jan 19

Seb35 added a comment to T184593: Wrong substitution in cache file wikis.php.

I remarked this bug also, thanks for opening the task. If you have a patch for it, you can submit it on Gerrit, I will review it. Else I will take some time in one or two weeks.

Fri, Jan 19, 9:05 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 placed T103772: Toolbar buttons that invoke dialogs insert text into incorrect text areas when there is more than one WikiEditor on a page up for grabs.

Could someone more knowlegeable in JS and WikiEditor take care of this? Debugging is done, it remains fixing properly the issue.

Fri, Jan 19, 8:33 PM · MediaWiki-extensions-Page_Forms, WikiEditor
Seb35 added a comment to T103772: Toolbar buttons that invoke dialogs insert text into incorrect text areas when there is more than one WikiEditor on a page.

The issue is that PageForms initializes with some global config $.wikiEditor.modules.toolbar.config.getDefaultConfig() and in this sub-sub-object there is $.wikiEditor.modules.toolbar.fn.doAction( $( this ).data( 'context' ) .. (for insert-link; there are similar calls for other dialogs) but the object this is always the same, it should not.

Fri, Jan 19, 8:30 PM · MediaWiki-extensions-Page_Forms, WikiEditor
Seb35 added a comment to T103772: Toolbar buttons that invoke dialogs insert text into incorrect text areas when there is more than one WikiEditor on a page.

The bug occurs only for dialogs (link, image, etc.), it works correctly for direct buttons (bold, italics, special character, etc.). I would say it is more a WikiEditor bug than a PageForms bug, probably in the JS for the dialogs.

Fri, Jan 19, 8:04 PM · MediaWiki-extensions-Page_Forms, WikiEditor
Seb35 added a comment to T103772: Toolbar buttons that invoke dialogs insert text into incorrect text areas when there is more than one WikiEditor on a page.

I confirm the bug still exists, it seems it is always added to the first text area; probably there is a global variable somewhere, which should not be global.

Fri, Jan 19, 7:30 PM · MediaWiki-extensions-Page_Forms, WikiEditor

Wed, Jan 17

jcrespo awarded T120333: Remove old mysql extension support in favor of mysqli a Like token.
Wed, Jan 17, 7:28 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MW-1.30-release-notes, NewPHP, Technical-Debt, MediaWiki-Database
Seb35 updated the task description for T120333: Remove old mysql extension support in favor of mysqli.
Wed, Jan 17, 4:33 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MW-1.30-release-notes, NewPHP, Technical-Debt, MediaWiki-Database
Seb35 updated the task description for T120333: Remove old mysql extension support in favor of mysqli.
Wed, Jan 17, 12:17 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MW-1.30-release-notes, NewPHP, Technical-Debt, MediaWiki-Database

Tue, Jan 16

Seb35 updated the task description for T120333: Remove old mysql extension support in favor of mysqli.
Tue, Jan 16, 11:43 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MW-1.30-release-notes, NewPHP, Technical-Debt, MediaWiki-Database
Seb35 updated the task description for T120333: Remove old mysql extension support in favor of mysqli.
Tue, Jan 16, 10:46 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MW-1.30-release-notes, NewPHP, Technical-Debt, MediaWiki-Database
Seb35 updated the task description for T120333: Remove old mysql extension support in favor of mysqli.
Tue, Jan 16, 9:50 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MW-1.30-release-notes, NewPHP, Technical-Debt, MediaWiki-Database
Seb35 updated the task description for T120333: Remove old mysql extension support in favor of mysqli.
Tue, Jan 16, 9:29 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MW-1.30-release-notes, NewPHP, Technical-Debt, MediaWiki-Database
Seb35 changed the status of T120333: Remove old mysql extension support in favor of mysqli from Stalled to Open.
Tue, Jan 16, 7:20 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MW-1.30-release-notes, NewPHP, Technical-Debt, MediaWiki-Database
Seb35 added a comment to T120333: Remove old mysql extension support in favor of mysqli.

I wrote the patch to remove DatabaseMysql and tried to find everywhere where there is a link with the driver mysql, but obviously there is an homonymy with the type mysql. I found occurences in multiple extensions, often in tests but some in the code itself; there also some extensions which directly use the functions mysql_* but it is out of scope of this task.

Tue, Jan 16, 7:02 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MW-1.30-release-notes, NewPHP, Technical-Debt, MediaWiki-Database
Seb35 updated the task description for T120333: Remove old mysql extension support in favor of mysqli.
Tue, Jan 16, 6:44 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MW-1.30-release-notes, NewPHP, Technical-Debt, MediaWiki-Database

Mon, Jan 15

Seb35 closed T184877: ApprovedRevs should not try to access to TextContent::mText, a subtask of T155298: Document visibility of TextContent::$mText, as Resolved.
Mon, Jan 15, 5:01 PM · Patch-For-Review, MediaWiki-extensions-WikiLexicalData-or-OmegaWiki, MediaWiki-ContentHandler
Seb35 closed T184877: ApprovedRevs should not try to access to TextContent::mText as Resolved.
Mon, Jan 15, 5:01 PM · Patch-For-Review, MediaWiki-extensions-Other, MediaWiki-ContentHandler
Seb35 committed rEMWF18c66f1f0081: Stop MediaWikiTestCase defition appearing for IDEs (authored by Addshore).
Stop MediaWikiTestCase defition appearing for IDEs
Mon, Jan 15, 3:30 PM
Seb35 added a comment to T184877: ApprovedRevs should not try to access to TextContent::mText.

Also, it is out of scope of this very maintenance task, but the content model should be checked more precisely. For instance, if I set ApprovedRevs in the namespace MediaWiki: and set $egApprovedRevsBlankIfUnapproved = false the patch would return a WikitextContent object, which is semantically incorrect because it should be another subclass of TextContent (perhaps I will submit a new version of the patch for that), but even worse is for very different content models, e.g. 'flow-board', it should be handled in some way by ApprovedRevs.

Mon, Jan 15, 12:28 PM · Patch-For-Review, MediaWiki-extensions-Other, MediaWiki-ContentHandler

Sun, Jan 14

Seb35 updated subscribers of T18487: UserManagement: Anonymous Account not create-/delete-/edit able , but it is visbile in user list.
Sun, Jan 14, 5:17 PM · PostgreSQL, MediaWiki-User-login-and-signup
Seb35 removed a project from T18487: UserManagement: Anonymous Account not create-/delete-/edit able , but it is visbile in user list: Patch-For-Review.

Submitted a patch with the wrong task, I fixed it but I remove the references added here.

Sun, Jan 14, 5:17 PM · PostgreSQL, MediaWiki-User-login-and-signup
Seb35 added a project to T184877: ApprovedRevs should not try to access to TextContent::mText: MediaWiki-extensions-Other.
Sun, Jan 14, 5:05 PM · Patch-For-Review, MediaWiki-extensions-Other, MediaWiki-ContentHandler
Seb35 triaged T184877: ApprovedRevs should not try to access to TextContent::mText as Normal priority.
Sun, Jan 14, 5:04 PM · Patch-For-Review, MediaWiki-extensions-Other, MediaWiki-ContentHandler
Seb35 updated subscribers of T155298: Document visibility of TextContent::$mText.

In the meantime, @Addshore added this property as protected rMWc9231ac. @daniel, I let you submit a patch if you prefer a private visibility, or close this task.

Sun, Jan 14, 4:25 PM · Patch-For-Review, MediaWiki-extensions-WikiLexicalData-or-OmegaWiki, MediaWiki-ContentHandler
Seb35 added a comment to T178778: Parsoid, VisualEditor not working with SSL / HTTPS.

@PlanetKrypton: did you try @Arlolra’s config? My rule of thumb about that is: put a domain on both sides or nowhere. But it seems your domain name expired, which kind of more critical than this issue.

Sun, Jan 14, 2:06 PM · HTTPS, Parsoid, VisualEditor

Sat, Jan 13

Seb35 awarded T184043: MediaWiki should treat phpdbg as cli a Love token.
Sat, Jan 13, 9:35 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, MediaWiki-General-or-Unknown, MediaWiki-Maintenance-scripts
Seb35 closed T183878: Fatal error when maintenance script outputs help as Resolved.

It was fixed in rMW803a291 on January 5, 2018. Thanks @hoo!

Sat, Jan 13, 9:15 PM · MediaWiki-Maintenance-scripts
Seb35 added a comment to T183878: Fatal error when maintenance script outputs help.

I also experienced this issue recently with MediaWiki 1.31 (not 1.30), with all maintenance scripts with the parameter "-h" to display help, e.g. "php maintenance/runJobs.php -h".

Sat, Jan 13, 9:01 PM · MediaWiki-Maintenance-scripts
Seb35 renamed T183878: Fatal error when maintenance script outputs help from Fatal error when maintenance script parameters are not provided to Fatal error when maintenance script outputs help.
Sat, Jan 13, 8:58 PM · MediaWiki-Maintenance-scripts
Seb35 merged T179011: {{NUMBEROFACTIVEUSERS}} doesn't get updated on non-miser mode wikis into T140079: {{NUMBEROFACTIVEUSERS}} doesn’t get updated.
Sat, Jan 13, 6:06 PM · MediaWiki-Installer, MediaWiki-User-login-and-signup, MediaWiki-Special-pages
Seb35 merged task T179011: {{NUMBEROFACTIVEUSERS}} doesn't get updated on non-miser mode wikis into T140079: {{NUMBEROFACTIVEUSERS}} doesn’t get updated.
Sat, Jan 13, 6:06 PM · MediaWiki-Special-pages
Seb35 renamed T140079: {{NUMBEROFACTIVEUSERS}} doesn’t get updated from {{NUMBEROFACTIVEUSERS}} stuck at 0 to {{NUMBEROFACTIVEUSERS}} doesn’t get updated.
Sat, Jan 13, 6:04 PM · MediaWiki-Installer, MediaWiki-User-login-and-signup, MediaWiki-Special-pages
Seb35 added a comment to T179011: {{NUMBEROFACTIVEUSERS}} doesn't get updated on non-miser mode wikis.

By following how is updated the statistics of active users, except if I’m mistaken:

  1. it is stored in the table site_stats in the column ss_active_users
  2. this column is only update in SiteStatsUpdate::cacheUpdate
  3. this static function is only called from
    • the maintenance scripts InitSiteStats and UpdateSpecialPages (the second through the parameter wgSpecialPageCacheUpdates which has a default value to add this function as a callback)
    • the function SiteStats::doAllAndCommit, but the flag to execute SiteStatsUpdate::cacheUpdate is false by default and is never set to true elsewhere
Sat, Jan 13, 5:54 PM · MediaWiki-Special-pages
Seb35 added a comment to T176551: Special:Statistics show incorrect statistics of active users on svwp.

It is now back to normal, I propose to close this issue. It can be reopened if it comes back.

Sat, Jan 13, 5:41 PM · MediaWiki-Special-pages
Seb35 added a comment to T172773: -1 active users in Special:Statistics.

-1 is the default value for the statistic of active users. Do you have sensible values for others statistics (number of edits, of users, etc)? Do you have something in the table "site_stats"? Between the first and the second time you experienced the issue, what happened? (update, is it another site, etc.)

Sat, Jan 13, 5:36 PM · MediaWiki-Special-pages

Mon, Jan 8

Seb35 added a comment to T184458: Floats are badly interpreted in SQL when locale is not English.

Searching on the Internet, a lot of people have this issue, either casting float to string (like here) or string to float. The best solution I found (the most generic one) is:

$localeinfo = localeconv();
$floatString = str_replace( $localeinfo['mon_decimal_point'], '.', $floatFloat );

Source: https://secure.php.net/manual/fr/function.floatval.php#92563

Mon, Jan 8, 10:59 PM · MediaWiki-Database
Seb35 renamed T181987: False decimal point in srcset when locale is not English from False decimal point in srcset #php7.2 to False decimal point in srcset when locale is not English.
Mon, Jan 8, 5:07 PM · I18n, MediaWiki-Internationalization
Seb35 removed a project from T181987: False decimal point in srcset when locale is not English: NewPHP.

We could either use number_format, but then we end up with 1.0x instead of 1x, or I guess we can do character replacement...
Neither is particularly ideal really...

Mon, Jan 8, 5:06 PM · I18n, MediaWiki-Internationalization
Seb35 merged T183659: locale-aware float to string conversion in Html::srcSet into T181987: False decimal point in srcset when locale is not English.
Mon, Jan 8, 4:55 PM · I18n, MediaWiki-Internationalization
Seb35 merged task T183659: locale-aware float to string conversion in Html::srcSet into T181987: False decimal point in srcset when locale is not English.
Mon, Jan 8, 4:55 PM · MediaWiki-General-or-Unknown
Seb35 created T184458: Floats are badly interpreted in SQL when locale is not English.
Mon, Jan 8, 4:49 PM · MediaWiki-Database

Sat, Dec 30

Seb35 closed T142127: NUMBEROFVIEWS variable throws HitCounters error, "numberOfViews() expected to be a reference" as Resolved.
Sat, Dec 30, 2:11 PM · Patch-For-Review, MediaWiki-extensions-HitCounters

Thu, Dec 28

Seb35 added a comment to T142127: NUMBEROFVIEWS variable throws HitCounters error, "numberOfViews() expected to be a reference".

@maiden_taiwan: can you try my patch, either downloading it with git or as as .tar file (link “download” on top right on Gerrit)?

Thu, Dec 28, 10:03 PM · Patch-For-Review, MediaWiki-extensions-HitCounters

Dec 19 2017

Seb35 edited P6481 Dependency hell between Composer librairies used in MediaWiki extensions and skins.
Dec 19 2017, 8:46 AM

Dec 18 2017

Seb35 edited P6481 Dependency hell between Composer librairies used in MediaWiki extensions and skins.
Dec 18 2017, 10:31 PM
Seb35 edited P6481 Dependency hell between Composer librairies used in MediaWiki extensions and skins.
Dec 18 2017, 10:11 PM
Seb35 added a comment to T156637: 1.27 tarball: Unnecessary library "ruflin/elastica 2.3.1" requirement.

This task is similar to T172927, given that ruflin/elastica is an example of the few librairies that are not necessary for all users.

Dec 18 2017, 8:07 PM · MediaWiki-Releasing, MediaWiki-Vendor
Seb35 moved T183166: Manage Composer-installed wfLoadExtension-activated extensions in MediaWikiFarm from Backlog to Bugs on the MediaWiki-extensions-MediaWikiFarm board.
Dec 18 2017, 6:12 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 triaged T183166: Manage Composer-installed wfLoadExtension-activated extensions in MediaWikiFarm as Normal priority.
Dec 18 2017, 6:12 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 created T183166: Manage Composer-installed wfLoadExtension-activated extensions in MediaWikiFarm.
Dec 18 2017, 6:12 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 added a comment to T178137: MediaWiki-Vendor is an unnecessary unique practice that must be manually maintained.

The task T172927 is linked to this one, focusing on reconciling mediawiki/vendor’s composer.json for tarballs with mediawiki/core’s composer.json, hence mediawiki/vendor could be fully dedicated to Wikimedia. There are issues related to librairies used by extensions, similarly to what Tgr exposed above in T178137#3695758.

Dec 18 2017, 5:35 PM · Developer-Wishlist, MediaWiki-Vendor, Composer
Seb35 edited P6481 Dependency hell between Composer librairies used in MediaWiki extensions and skins.
Dec 18 2017, 3:02 PM
Seb35 added a comment to T172927: mediawiki/vendor is bloated for tarball releases.

I was about to ask if there is a documentation/policy about what is included in mediawiki/vendor compared to mediawiki/core, and then I found this task. If my understanding below is right, I will add add a note on this on mw:Composer.

Dec 18 2017, 2:40 PM · MW-1.27-release-notes, Patch-For-Review, MediaWiki-Vendor, MediaWiki-Releasing
Seb35 created P6481 Dependency hell between Composer librairies used in MediaWiki extensions and skins.
Dec 18 2017, 2:34 PM
Seb35 awarded T172927: mediawiki/vendor is bloated for tarball releases a Love token.
Dec 18 2017, 10:36 AM · MW-1.27-release-notes, Patch-For-Review, MediaWiki-Vendor, MediaWiki-Releasing

Dec 8 2017

Seb35 closed T177313: Cancel button returns Undefined error as Resolved.
Dec 8 2017, 10:34 AM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), Patch-For-Review, JavaScript, WikiEditor

Dec 4 2017

Seb35 updated the task description for T181212: Errors when using monoversion configuration template.
Dec 4 2017, 2:57 PM · Patch-For-Review, MediaWiki-extensions-MediaWikiFarm
Seb35 added a comment to T181212: Errors when using monoversion configuration template.

I realised an additional issue in the monoversion case: when a wiki does not exist, MediaWikiFarm should return an HTTP 404 or HTTP 500 and should not further execute MediaWiki, but with the example configuration MediaWikiFarm still load the LocalSettings.php and MediaWiki is executed. Similarly to the multiversion case, the file MediaWikiFarm.php should contain something like if( MediaWikiFarm::load() == 200 ) { ... } else { die( 0 ); }.

Dec 4 2017, 2:53 PM · Patch-For-Review, MediaWiki-extensions-MediaWikiFarm
Seb35 committed rEMWFc615f6303067: Improve discoverability of $wgMediaWikiFarmSyslog (authored by Seb35).
Improve discoverability of $wgMediaWikiFarmSyslog
Dec 4 2017, 2:40 PM
Seb35 committed rEMWFc32280409b33: Alternative declaration of wikis for small setups (authored by Seb35).
Alternative declaration of wikis for small setups
Dec 4 2017, 2:40 PM
Seb35 added a comment to T181212: Errors when using monoversion configuration template.

This second change addresses the issue of the discoverability of the logs in syslog, and I remove the message "Logging parameter must be false or a string" in the case there is no config parameter $wgMediaWikiFarmSyslog (or is null) in order to safely remove it when you don’t want logs (safely = without being forcingly spammed by this message).

Dec 4 2017, 2:07 PM · Patch-For-Review, MediaWiki-extensions-MediaWikiFarm
Seb35 added a comment to T181212: Errors when using monoversion configuration template.

This first change is for the point 4) hence it will be directly possible to add the values of each variables in the farms.yml file, making it easier to write introductory tuturials and for small farms. However this is only for small setups given it has two drawbacks:

  1. any change in the list of wikis invalidate all cached configuration files (given farms.yml is the entry config file);
  2. when there are multiple variables, it will be only possible to create a cartesian space, instead of a fibre bundle as made possible when using files: e.g. if v1 ∈ { 'a', 'b' } and v2 ∈ { '1', '2' } the list of declared wikis will be { ('a', '1'), ('a', '2'), ('b', '1'), ('b', '2') }, but when you use files, v2 can depend on the value of v1 and create for instance this list of declared wikis: { ('a', '1'), ('a', '2'), ('b', '3') }.
Dec 4 2017, 12:41 PM · Patch-For-Review, MediaWiki-extensions-MediaWikiFarm

Dec 1 2017

Seb35 triaged T181212: Errors when using monoversion configuration template as Normal priority.
Dec 1 2017, 7:33 PM · Patch-For-Review, MediaWiki-extensions-MediaWikiFarm
Seb35 updated subscribers of T181212: Errors when using monoversion configuration template.
Dec 1 2017, 6:39 PM · Patch-For-Review, MediaWiki-extensions-MediaWikiFarm
Seb35 added a comment to T181212: Errors when using monoversion configuration template.

I was able to reproduce the issue with the same details, thank you for your detailled analysis.

Dec 1 2017, 6:37 PM · Patch-For-Review, MediaWiki-extensions-MediaWikiFarm

Nov 30 2017

Seb35 added a comment to T181212: Errors when using monoversion configuration template.

I don’t regularly test the monoversion case, I should setup it on my test installation to routinely check if everything still work.

Nov 30 2017, 5:24 PM · Patch-For-Review, MediaWiki-extensions-MediaWikiFarm

Nov 29 2017

Seb35 added a comment to T181641: Add the Parsoid repository key in https://www.mediawiki.org/keys/keys.html.

I am aware of the recent refactoring in this area with T181017 and T181019, possibly this task will become WONTFIX shortly, but I prefer to mention it as a dedicated task.

Nov 29 2017, 3:53 PM · Parsoid, Security-General
Seb35 added a project to T181641: Add the Parsoid repository key in https://www.mediawiki.org/keys/keys.html: Security-General.
Nov 29 2017, 3:50 PM · Parsoid, Security-General
Seb35 created T181641: Add the Parsoid repository key in https://www.mediawiki.org/keys/keys.html.
Nov 29 2017, 3:49 PM · Parsoid, Security-General

Nov 24 2017

Seb35 added a comment to T177313: Cancel button returns Undefined error.

I propose window.location.href = $( '#mw-editform-cancel a' ).attr( 'href' ); hence, as soon as jQuery works (it’s a pre-condition here), it will work.

Nov 24 2017, 4:28 PM · MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)), Patch-For-Review, JavaScript, WikiEditor

Nov 22 2017

Seb35 added a comment to T142127: NUMBEROFVIEWS variable throws HitCounters error, "numberOfViews() expected to be a reference".

Observed also on 1.29. This comes from rMW63bb3852a52, it can be solved with two small fixes:

  • in HitCounters\Hooks::onParserGetVariableValueSwitch(), add as third argument to CoreParserFunctions::formatRaw: $parser->getFunctionLang() (similarly to core, see linked commit) [this is the fatal error];
  • in HitCounters\HitCounters::numberOfViews() and HitCounters\HitCounters::numberOfPageViews(), remove the ampersand in the first parameter [this is only a warning].

I prepare soon a commit fixing this.

Nov 22 2017, 1:56 PM · Patch-For-Review, MediaWiki-extensions-HitCounters

Nov 14 2017

Seb35 added a comment to T54813: Remove "Show table of contents (for pages with more than 3 headings)" user preference from MediaWiki core.

Relatedly to JamesHaigh’s comment, it can be hidden the TOCs with a CSS rule, either for the whole site or per-user, see https://www.mediawiki.org/wiki/Manual:FAQ#How_can_I_hide_the_table_of_contents.3F

Nov 14 2017, 8:00 AM · Easy, MediaWiki-User-preferences

Oct 7 2017

Seb35 added a comment to T155624: Special:Version not showing SHA info for Mediawiki version on fr.wikisource.

I observed on my wikis that the SHAs were sometimes missing. In my case it was because I use to run git gc, and during this operation the references are packed together in the file .git/packed-refs and MediaWiki didn’t read this file. I proposed a patch in T155747 to implement this feature (rMW125f832) and it was merged and deployed on Wikimedia some days ago.

Oct 7 2017, 10:12 AM · Wikimedia-General-or-Unknown
Seb35 awarded T177111: Librarize multiversion code a Love token.
Oct 7 2017, 8:51 AM · MediaWiki-Farmers, MediaWiki-Vagrant, MediaWiki-Configuration, Librarization
Seb35 added a comment to T177111: Librarize multiversion code.

I created rEMWF extension-MediaWikiFarm mostly by copying the concepts from rOMWC Wikimedia - MediaWiki Config/multiversion and wgConf/SiteConfiguration: hierarchical configuration, per-wiki configuration cache, bootstrap to choose the MediaWiki version located in different directories, the syntax to add values to array parameters, amongst others. It is intended to create a proper farm management; it was developed primary for the MediaWiki hosting of our company, but I try to make it as general as possible without specificities.

Oct 7 2017, 8:51 AM · MediaWiki-Farmers, MediaWiki-Vagrant, MediaWiki-Configuration, Librarization

Sep 28 2017

Seb35 added a comment to T92531: add a check for whitespace before leading <?php.

I read this bug and I don’t understand what remains to be done [to close this task]:

  • T46875 about MediaWiki is now a standard PHPCS rule executed in CI;
  • T92534 in scap is now done;

Are there remaining parts to be checked? perhaps extensions/skins used by WMF?

Sep 28 2017, 8:35 PM · RelEng-Archive-FY201718-Q1, User-greg, Wikimedia-Incident, Continuous-Integration-Config, Incident-20150312-whitespace
Seb35 added a comment to T162737: Create a list of all known wikis in MediaWikiFarm.

I let open this task because some other work should be done in this scope, mainly execute a bunch of wikis for MediaWiki scripts, I think about a command line such that:

mwscript --wiki=* runJobs
mwscript --wiki=*.example.org runJobs

For each individual wiki, a new PHP instance should be launched (at least for multiversion farms) because MediaWiki versions could be different between wikis and there would be a risk of conflicting versions (e.g. the class Job was already autoloaded but with a different version).

Sep 28 2017, 5:27 PM · Patch-For-Review, MediaWiki-extensions-MediaWikiFarm
Seb35 committed rEMWF4c16908d1c11: Enumerate all known wikis (authored by Seb35).
Enumerate all known wikis
Sep 28 2017, 4:03 PM

Sep 25 2017

Seb35 committed rEMWFe819db74970e: New function readAnyFile to read a file with any extension (authored by Seb35).
New function readAnyFile to read a file with any extension
Sep 25 2017, 12:51 PM
Seb35 committed rEMWFf70cb5ac4319: New function readAnyFile to read a file with any extension (authored by Seb35).
New function readAnyFile to read a file with any extension
Sep 25 2017, 12:38 PM

Sep 24 2017

Seb35 committed rEMWF2c91faed5aed: New function readAnyFile to read a file with any extension (authored by Seb35).
New function readAnyFile to read a file with any extension
Sep 24 2017, 8:58 PM
Seb35 committed rEMWF576af4fbdc88: Always check Composer extensions independantly of ExtensionRegistration (authored by Seb35).
Always check Composer extensions independantly of ExtensionRegistration
Sep 24 2017, 4:37 PM
Seb35 committed rEMWF3a0b2fa6e9ab: Bug: Relaunch the tests before 5 minutes removed some coverage (authored by Seb35).
Bug: Relaunch the tests before 5 minutes removed some coverage
Sep 24 2017, 4:12 PM

Sep 23 2017

Seb35 added a comment to T162686: Reorganise tests in MediaWikiFarm to focus on unit tests.

I just fixed a bug where Composer extensions were no more loaded; possibly an integration test could have tested this behaviour and detected the bug.

Sep 23 2017, 9:17 PM · MediaWiki-extensions-MediaWikiFarm
Seb35 committed rEMWFca185e09d2aa: Bug: Composer extensions were no more loaded (authored by Seb35).
Bug: Composer extensions were no more loaded
Sep 23 2017, 8:11 PM
Seb35 committed rEMWF3b37332ddeda: Add LICENSE (authored by Seb35).
Add LICENSE
Sep 23 2017, 3:39 PM
Seb35 updated the task description for T123943: Add extension licenses so they appear correctly on Special:Version.
Sep 23 2017, 3:13 PM · Epic, MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), Software-Licensing, Patch-For-Review, Google-Code-In-2015, MediaWiki-extensions-General

Sep 19 2017

Seb35 updated the task description for T142120: Remove UnitTestsList hook subscribers, move tests to be autodiscovered for extensions that have been converted to extension registration.
Sep 19 2017, 9:43 AM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), Patch-For-Review, MediaWiki-Core-Tests, MediaWiki-extensions-General

Sep 18 2017

Seb35 moved T174199: Investigate getting rid of the non-Tidy option in parser tests from Unsorted to PHP 7 on the NewPHP board.
Sep 18 2017, 9:22 AM · MediaWiki-Core-Tests, MediaWiki-Parser
Seb35 added a project to T174199: Investigate getting rid of the non-Tidy option in parser tests: NewPHP.

For information, when I run locally the parser tests, I have no failing tests with PHP 5.6, but I have 9 failing tests with PHP 7.0 and PHP 7.1 with their respective PHP extension tidy.

Sep 18 2017, 9:22 AM · MediaWiki-Core-Tests, MediaWiki-Parser

Sep 17 2017

Seb35 added a comment to T166010: The Great Namespaceization and Reorg.

The standard PSR-4 requires a map (namespace => directory). If each extension declares its map, there is no real constraint and BlueSpice (and SMW and others) can use a specific vendor without much difficulty. But if in the future most extensions are given a namespace MediaWiki\ExtensionName it could become tempting to define an implicit autoloader (MediaWiki\MyExtension\MyClass => /extensions/MyExtension/includes/MyClass.php). If it is the case, there could be these two parameters in extension.json:

  • the subdirectory where are stored the classes ("includes" in my example), possibly with a default value;
  • a specific vendor with "MediaWiki" or "MediaWiki\Extension" as default value.
Sep 17 2017, 1:43 PM · MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Epic, TechCom-RFC
Seb35 added a comment to T166010: The Great Namespaceization and Reorg.

For information, in the case MediaWiki\ExtensionName (versus MediaWiki\Extension\ExtensionName/MediaWiki\Skin\SkinName, there are at least 3 conflicts where an extension and a skin have the same name: Athena, CustomPage, Vector.

Sep 17 2017, 1:38 PM · MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Epic, TechCom-RFC
Seb35 added a comment to T152540: Migrate to HTML5 section ids.

I was curious to see the result and didn’t find live examples with MediaWiki, so I created one on https://test.wikipedia.org/wiki/HTML_5_section_IDs.

Sep 17 2017, 11:16 AM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Readers-Web-Backlog (Tracking), User-notice, Mobile-Content-Service, Reading-Infrastructure-Team-Backlog, Community-Wishlist-Survey-2016, Community-Tech, ContentTranslation, MediaWiki-Parser, Parsoid, Parsing-Team

Sep 16 2017

Seb35 updated the task description for T47514: ResourceLoader: Implement support for Source Maps.
Sep 16 2017, 4:57 PM · Front-end-Standards-Group, MediaWiki-ResourceLoader
Seb35 added a comment to T47514: ResourceLoader: Implement support for Source Maps.

Some PHP libraries:

Sep 16 2017, 4:55 PM · Front-end-Standards-Group, MediaWiki-ResourceLoader

Sep 15 2017

Seb35 added a comment to T155747: All extension should link to the deployed Git revision from Special:Version.

In my understanding, there are at least two different cases about why some extensions don’t have a Git hashes:

  1. Some are registered as Composer library (e.g. DataValues* extensions installed with Semantic MediaWiki through Composer) and as such don’t appear because their code is in /vendor/X/Y instead of /extensions/Z; imho this is not a bug in MediaWiki core but either the extensions should be installed in /extensions either it should not be registered as a MediaWiki extension in Special:Version but as a Composer library (section above).
  2. In some Git setup, particularly if a git gc ran in some directory, the class GitInfo class doesn’t read the file /.git/packed-refs and hence cannot retrieve the hash for this Git-versioned directory.
Sep 15 2017, 7:45 AM · MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Patch-For-Review, Release-Engineering-Team (Someday), Deployments, MediaWiki-Special-pages