Page MenuHomePhabricator

Seb35 (Seb35)
MediaWiki gnome

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 9:50 AM (237 w, 1 d)
Availability
Available
IRC Nick
seb35
LDAP User
Seb35
MediaWiki User
Seb35 [ Global Accounts ]

I follow MediaWiki development since 2007. Although I don’t regularly submit patches for the MediaWiki core, I act as an ambassador, submitting bugs, helping in their resolution, exchanging with the French-speaking community, improving documentation and its translation into French, etc. I developed three extensions (BackwardsTimeTravel, HSTS, and MediaWikiFarm).

Since 2016, I run a small MediaWiki consulting company in France, which help companies, associations and public sector to set up MediaWiki installations.

My GitHub account is Seb35.

Recent Activity

Mar 21 2019

Mill <mill@mail.com> committed rETSTebbccf98b448: %26hbaaaaaaaaaaa (authored by Seb35).
%26hbaaaaaaaaaaa
Mar 21 2019, 12:33 AM
Mill <mill@mail.com> committed rETST8ccb914ef96c: 4hbaaaaaaaaaaa (authored by Seb35).
4hbaaaaaaaaaaa
Mar 21 2019, 12:33 AM

Mar 20 2019

Seb35 added a comment to T50007: Error creating PDF on Commons: "convert: no decode delegate for this image format" (fixed in GS 9.07).

FYI I have this error message on some PDF scans (on a private wiki). The issue is with Ghostscript 9.26, who writes the following error message at the beginning of the file (before the JPEG real content):

**** Error: stream operator isn't terminated by valid EOL.
            Output may be incorrect.

The user-displayed error is ImageMagick who does not understand the JPEG image (which is normal). Hence it is not a MediaWiki or an ImageMagick issue, but a Ghostscript’s one. If I find something useful to solve it, I will report it here if anyone else has this issue in the recent days.

Mar 20 2019, 2:17 PM · Operations, Multimedia, MediaWiki-extensions-PdfHandler

Feb 18 2019

Seb35 added a comment to T212453: Allow to explicity call certain function when multiple extensions define the same function (conflicting function names).

Cross-link to https://github.com/JeroenDeDauw/Maps/issues/530, which is the issue on extension Maps.

Feb 18 2019, 3:25 PM · MediaWiki-Parser, MediaWiki-extensions-General

Jan 11 2019

Seb35 added a comment to T173141: Provide a way to install Composer dependencies after installing an extension, without updating all unrelated libraries.

I read this bug and I am interested if it could be solved in some way. I’ve not tested yet, but if I understand correctly @dbarratt on issue #6601, there are some Composer commands which, when executed in a specific order, would solve this issue, isn’t it?

Jan 11 2019, 5:49 PM · MediaWiki-General-or-Unknown, Upstream, Composer

Dec 22 2018

Seb35 created T212555: Require nodejs 6.x in Parsoid Debian package.
Dec 22 2018, 9:11 AM · Packaging, Parsoid

Dec 12 2018

Seb35 added a comment to T201486: Exception caught when deleting a page.

@PlavorSeol: what are your versions of MediaWiki and DeletePagesForGood? And do you use MySQL or PostgreSQL? If you can, try with a recent version of DeletePagesForGood.

Dec 12 2018, 1:20 PM · Patch-For-Review, MediaWiki-extensions-DeletePagesForGood
Seb35 created T211757: Exception when the page contains some categories.
Dec 12 2018, 11:32 AM · MediaWiki-extensions-DeletePagesForGood
Seb35 added a comment to T196042: Configurable RDF prefixes for WDQS.

I find wd: (and derivatives) should be reserved for Wikidata to avoid confusion, and the default installation of wdqs-updater should propose another prefix, advertised as shared between all default Wikibase installations. In this proposition, the default prefixes in the frontend would include wd: fixed as Wikidata and the shared prefix for the specific Wikibase installation.

Dec 12 2018, 9:55 AM · Wikidata, Wikibase-Containers

Nov 26 2018

Seb35 updated subscribers of T210312: Upgrade extdist/nightly.py to Python3.

As remarked @Volans the .decode() could trigger errors in Py2, and it did in fetch_all_repos() (reached with cmd arguments --all like in prod). For the current prod, if it was deployed it should be either reverted either completed by the second patch Idbc9abc58653fb.

Nov 26 2018, 9:53 AM · Patch-For-Review, VPS-project-Extdist

Nov 24 2018

Seb35 added a comment to T46429: Please enable ParserFunctions in new installs of MediaWiki by default.

See also T55983

Nov 24 2018, 5:35 PM · MediaWiki-Installer
Seb35 added a comment to T63415: Include math extension again in default extensions of MediaWiki tarball.

I have the same opinion as @Legoktm here: the extension Math requires some external config and it needs specific actions from the sysadmin. Also I’m not completely sure enough MediaWiki websites need maths to include it by default (see WikiApiary).

Nov 24 2018, 5:31 PM · MediaWiki-Installer
Seb35 added a parent task for T63415: Include math extension again in default extensions of MediaWiki tarball: T178349: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites.
Nov 24 2018, 5:24 PM · MediaWiki-Installer
Seb35 added a subtask for T178349: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites: T63415: Include math extension again in default extensions of MediaWiki tarball.
Nov 24 2018, 5:24 PM · Epic, MediaWiki-Releasing, MediaWiki-Installer
Seb35 added a comment to T63146: cli installer ignores lang parameter.

Still an issue on MediaWiki 1.33-alpha, although I rewrote a bit the description because indeed the CLI installer does not set $wgLanguageCode in the generated LocalSettings.php, but the parameter --lang does have an effect because the main page (title and content) is generated using the lang parameter (e.g. Accueil for --lang fr).

Nov 24 2018, 4:35 PM · I18n, MediaWiki-Installer
Seb35 updated the task description for T63146: cli installer ignores lang parameter.
Nov 24 2018, 4:35 PM · I18n, MediaWiki-Installer
Seb35 added a comment to T50083: Installer environmental checks don't update when reloading page.

Tested on MW 1.33-alpha by removing all my database drivers (php7.0-mysql and php7.0-sqlite3).

Nov 24 2018, 4:21 PM · MediaWiki-Installer
Seb35 added a comment to T108097: Improve the web installer's error page for missing dependencies.

I like it!

Nov 24 2018, 3:50 PM · Composer, MediaWiki-Installer
Seb35 added a comment to T123819: Installer seemingly using wrong db name and username.

Well, without more information I’m tempted to close as invalid. At first sight I would say a " GRANT ALL PRIVILEGES ON my_wiki.* TO wikiuser@localhost; " was forgotten, and I guess @daniel solved the issue a long time ago.

Nov 24 2018, 3:16 PM · MediaWiki-Installer
Seb35 lowered the priority of T106148: PHP Fatal error: Call to undefined function MediaWiki\suppressWarnings() in ... Maintenance.php on line 960 from High to Normal.

Still an issue? It seems to work in recent builds.

Nov 24 2018, 2:40 PM · MediaWiki-Installer
Seb35 added a comment to T188084: Add Git tags REL1_XX for historical branches.

I didn’t know git-ls-remote, that helps a bit, but from a programmatic (or mental for humans) point of view you still have to implement some logic to:

  1. git ls-remote
  2. remove various stuff like "rc" and "beta"
  3. grep your searched version (e.g. 1.20)
  4. sort the versions
  5. take the last entry, but if the last entry ends with ^{} you have to take the entry just before, which should be the same without the ^{}

So, yes, it is possible, but it’s a lot more work than retrieving a REL1_XX branch or tag, particularly easy given git clone -b REL1_XX choose either depending on what is available.

Nov 24 2018, 1:13 PM · MediaWiki-Releasing

Nov 23 2018

Seb35 updated subscribers of T210312: Upgrade extdist/nightly.py to Python3.
Nov 23 2018, 11:54 PM · Patch-For-Review, VPS-project-Extdist
Seb35 triaged T210312: Upgrade extdist/nightly.py to Python3 as Low priority.
Nov 23 2018, 11:37 PM · Patch-For-Review, VPS-project-Extdist
Seb35 created T210312: Upgrade extdist/nightly.py to Python3.
Nov 23 2018, 11:36 PM · Patch-For-Review, VPS-project-Extdist
Seb35 closed T209870: MediaWiki 1.32.0-RC0 tables.sql missing comma as Resolved.

Fixed in the last supported version (1.31.2) and in upcoming versions (1.32.0, 1.33.0). Previous versions didn’t have this bug. Thanks @Brentil!

Nov 23 2018, 10:20 PM · MW-1.31-release-notes, MediaWiki-General-or-Unknown, MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), MW-1.32-release, Patch-For-Review, MSSQL
Seb35 closed T135194: ExtensionDistributor should dereference symbolic links as Resolved.

The patch was merged and I see it is in production given that the extension GuidedTour – which has a symbolic link COPYING – has no symbolic link when downloaded on mediawiki.org but a correctly-dereferenced file.

Nov 23 2018, 9:04 PM · VPS-project-Extdist, Patch-For-Review, ExtensionDistributor
Seb35 added a comment to T209870: MediaWiki 1.32.0-RC0 tables.sql missing comma.

Fixed in master and REL1_32 (hence it will be in 1.32.0). I just wait the merge for REL1_31 to close this task (hopefully it will be included in 1.31.2).

Nov 23 2018, 9:13 AM · MW-1.31-release-notes, MediaWiki-General-or-Unknown, MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), MW-1.32-release, Patch-For-Review, MSSQL

Nov 22 2018

Seb35 added a project to T161968: Installer gives wrong hint for local piped MySQL install: MediaWiki-Documentation.

On https://www.mediawiki.org/wiki/Manual:$wgDBserver it is advised to set it to "localhost:/var/run/mysql/mysql.sock". I successfully tested this option, but probably tip in installer should be improved.

Nov 22 2018, 4:09 PM · MediaWiki-Documentation, MediaWiki-Installer
Seb35 added a subtask for T196185: Drop $wgDBmysql5 from MediaWiki: T117339: Why is `$wgDBmysql5 = false'` set by the installer?.
Nov 22 2018, 3:54 PM · MW-1.33-release, Technical-Debt (Deprecation), MW-1.31-release-notes, Performance-Team (Radar), MediaWiki-Installer, MediaWiki-Database
Seb35 added a parent task for T117339: Why is `$wgDBmysql5 = false'` set by the installer?: T196185: Drop $wgDBmysql5 from MediaWiki.
Nov 22 2018, 3:54 PM · MediaWiki-Installer
Seb35 closed T117339: Why is `$wgDBmysql5 = false'` set by the installer? as Resolved.

Removed in rMWc9339ba552cb5f87586e7045b46519bd9db04fe0 as part of T196185.

Nov 22 2018, 3:52 PM · MediaWiki-Installer
Seb35 triaged T210152: Use database flags and options in installer as Low priority.
Nov 22 2018, 3:17 PM · MediaWiki-Installer
Seb35 created T210152: Use database flags and options in installer.
Nov 22 2018, 3:16 PM · MediaWiki-Installer
Seb35 closed T25016: Create new extension implementing article importance and quality (and/or other configurable attributes) as database fields as Resolved.

Implemented and deployed on some wikis whose the English Wikipedia with MediaWiki-extensions-PageAssessments.

Nov 22 2018, 8:30 AM · MediaWiki-extension-requests

Nov 21 2018

Seb35 added a comment to T196650: Expand the set of bundled extensions and skins in MediaWiki 1.32.

Given this decision, should we remove the tag MW-1.32-release in the unitary tasks and add MW-1.33-release?

Nov 21 2018, 10:29 AM · Growth-Team, Epic, MW-1.32-release, MediaWiki-Releasing, MediaWiki-Installer

Nov 20 2018

Seb35 added a comment to T209972: Remove auto-fill/suggest of usernames from password reset forms.

About possible abuse, perhaps it can be monitored on the long term if there are more 'forgotten passwords' requests than before this feature was introduced and/or if some users (e.g. User:A on English Wikipedia if I type "A" and Enter) complain about receiving too much (false positive) such requests.

Nov 20 2018, 10:10 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Trust-and-Safety, MediaWiki-Authentication-and-authorization, MediaWiki-Special-pages, Security-Team, Security
Seb35 added a comment to T209972: Remove auto-fill/suggest of usernames from password reset forms.

I just tested on a private wiki with MediaWiki 1.33-alpha – with $wgGroupPermissions['*']['read'] = false; – the text field is blinking but nothing is showing because the API returns an error readapidenied. Hence it is slightly disappointing to type and see the text field blinking, but nothing else.

Nov 20 2018, 9:58 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Trust-and-Safety, MediaWiki-Authentication-and-authorization, MediaWiki-Special-pages, Security-Team, Security
Seb35 closed T191392: BounceHandler is using removed EchoBasicFormatter class as Resolved.
Nov 20 2018, 9:30 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Technical-Debt, MediaWiki-extensions-BounceHandler
Seb35 triaged T191392: BounceHandler is using removed EchoBasicFormatter class as Normal priority.
Nov 20 2018, 6:45 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Technical-Debt, MediaWiki-extensions-BounceHandler
Seb35 triaged T209870: MediaWiki 1.32.0-RC0 tables.sql missing comma as Normal priority.
Nov 20 2018, 2:33 PM · MW-1.31-release-notes, MediaWiki-General-or-Unknown, MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), MW-1.32-release, Patch-For-Review, MSSQL
Seb35 added a project to T209870: MediaWiki 1.32.0-RC0 tables.sql missing comma: MW-1.32-release.

I submit the patch so that it has a chance to be published with 1.32.0. Is it possible to merge it in master and REL1_32 (and possibly REL1_31)? I have not tested myself but @Brentil successfully did.

Nov 20 2018, 2:31 PM · MW-1.31-release-notes, MediaWiki-General-or-Unknown, MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), MW-1.32-release, Patch-For-Review, MSSQL

Nov 19 2018

Seb35 added a comment to T209870: MediaWiki 1.32.0-RC0 tables.sql missing comma.

Thanks for reporting this bug! Do you want to submit yourself the patch fixing this? If so, you can follow https://www.mediawiki.org/wiki/Gerrit/Tutorial – it could take some time (perhaps 1-2 hours) but it is an investment for the long time. If you don’t want to submit yourself the patch, I can prepare it (but I don’t have myself MSSQL, so I am unable to test).

Nov 19 2018, 6:34 PM · MW-1.31-release-notes, MediaWiki-General-or-Unknown, MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), MW-1.32-release, Patch-For-Review, MSSQL
Seb35 claimed T136220: IPSet documentation mentions MediaWiki's IP::isInRange() without context.
Nov 19 2018, 1:24 PM · Patch-For-Review, Documentation, IPSet
Seb35 triaged T136220: IPSet documentation mentions MediaWiki's IP::isInRange() without context as Lowest priority.
Nov 19 2018, 1:22 PM · Patch-For-Review, Documentation, IPSet

Nov 18 2018

Seb35 closed T202224: CI failure for MediaWikiFarm (says unable to merge, but change is up to date) as Resolved.

Yes, this was linked to T198968 and the change I02d72045ca288 in the repository wikidata/query/gui. It turns that the fact that I02d72045ca288 was recently merged unblocked the repository mediawiki/extensions/MediaWikiFarm, probably because Gerrit no more gives multiple results for query 433653.

Nov 18 2018, 11:55 PM · Continuous-Integration-Config, Gerrit, Patch-For-Review, MediaWiki-extensions-MediaWikiFarm
Seb35 updated the task description for T202224: CI failure for MediaWikiFarm (says unable to merge, but change is up to date).
Nov 18 2018, 11:49 PM · Continuous-Integration-Config, Gerrit, Patch-For-Review, MediaWiki-extensions-MediaWikiFarm
Seb35 closed T202455: BounceHandler extension unit tests failing on UnSubscribeUserTest::testUnSubscribeUser as Resolved.

Fixed. Jenkins jobs no more detect "false positive" errors for recent patches.

Nov 18 2018, 5:17 PM · MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, MediaWiki-extensions-BounceHandler
Seb35 added a comment to T97539: UploadStash - Cannot serve a file larger than 1048576 bytes. .

This task should be either better phrased or declined:

  • the part about completing the upload process is already discussed on T85561 for UploadWizard (Special:UploadStash is MediaWiki core, but the main user is probably UploadWizard) and there is already a patch about resuming stashed uploads in UploadWizard;
  • the part about the Internal Server Error can be reproduced with any file larger than 1Mio, but it is a feature to avoid abuse with people using Special:UploasStash as a file drop, see comment in code.
Nov 18 2018, 2:07 PM · Multimedia, MediaWiki-File-management, Commons

Nov 14 2018

Seb35 closed T37544: Cross-protocol support for X-Forwarded-For for both IPv4 and IPv6, a subtask of T37540: Enable full IPv6 support on Wikimedia wikis, as Resolved.
Nov 14 2018, 9:25 AM · Goal, Patch-For-Review, IPv6, Wikimedia-Site-requests
Seb35 closed T37544: Cross-protocol support for X-Forwarded-For for both IPv4 and IPv6 as Resolved.

I just tried proxying with nginx an HTTPS on IPv4 (127.0.0.1:443) to a HTTP IPv6 ([::1]:8080) with MediaWiki only responding on [::1]:8080 and configured with $wgSquidServersNoPurge = [ '::1' ]; and the IP recognised by MediaWiki is correctly 127.0.0.1 thanks to the header X-Forwarded-For read in WebRequest::getIP() and the protocol is correctly recognised as HTTPS thanks to the header X-Forwarded-Proto read in WebRequest::detectProtocol().

Nov 14 2018, 9:25 AM · IPv6, MediaWiki-General-or-Unknown

Nov 12 2018

Seb35 added a comment to T187491: ApiUpload throws MWException "No specifications provided to ArchivedFile constructor".

This happens sometimes on http://www.wiki-brest.net, which I maintain (23 times such a log over 1.5 month) on Media Upload in VisualEditor. According to some tests, the issue could happen iff the file is larger than the authorised file size (2 Mio currently on the mentionned wiki, I will probably increase it).

Nov 12 2018, 4:15 PM · VisualEditor, Multimedia, MediaWiki-Uploading, Wikimedia-production-error

Nov 10 2018

Seb35 added a comment to T209163: Loading an edit page using veaction=edit in single-tab mode changes URL to an incorrect state.

This wrong behaviour is present in the three modes (other than the mode "two buttons") when wgVisualEditorUseSingleEditTab is true.

Nov 10 2018, 10:07 AM · VisualEditor (Current work)

Nov 8 2018

Seb35 created T209096: Delete the email address when wgEmailAuthentication is false and address is in error.
Nov 8 2018, 7:54 PM · MediaWiki-extensions-BounceHandler
Seb35 added a comment to T209005: Lots of web pages are misunderstood by Citoid on Czech Wikipedia.

First check that https://cs.wikipedia.org/wiki/MediaWiki:Citoid-template-type-map.json is sufficiently precise and up-to-date. This is the table mapping 34 Zotero types to your Wikipedia templates. If you need more templates, you should follow https://www.mediawiki.org/wiki/Citoid/Maps_TemplateData for the new templates (essentially add a key "map -> citoid" in the TemplateData of the template). (But I’m not sure you can add more than 4 templates, see https://www.mediawiki.org/wiki/VisualEditor/Citation_tool.)

Nov 8 2018, 9:10 AM · Wikimedia-Site-requests, Citoid

Nov 6 2018

Seb35 closed T208686: Missing icon 'menu' in VisualEditor as Resolved.

Thanks for the merge and cherry picks!

Nov 6 2018, 9:43 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Regression, VisualEditor (Current work), VisualEditor-MediaWiki, Patch-For-Review

Nov 4 2018

Seb35 added a comment to T208686: Missing icon 'menu' in VisualEditor.

Raising to priority 'High' given it is quite visible in the interface.

Nov 4 2018, 5:37 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Regression, VisualEditor (Current work), VisualEditor-MediaWiki, Patch-For-Review
Seb35 triaged T208686: Missing icon 'menu' in VisualEditor as High priority.
Nov 4 2018, 5:36 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Regression, VisualEditor (Current work), VisualEditor-MediaWiki, Patch-For-Review
Seb35 created T208686: Missing icon 'menu' in VisualEditor.
Nov 4 2018, 5:35 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Regression, VisualEditor (Current work), VisualEditor-MediaWiki, Patch-For-Review
Seb35 awarded T173432: Sort claims of a property in meaningful way a Meh! token.
Nov 4 2018, 12:22 PM · patch-welcome, MediaWiki-extensions-WikibaseRepository, Wikidata
Seb35 added a comment to T173432: Sort claims of a property in meaningful way.

Related to this task, I’ve created a script to sort the values of P⁠348 (versions of a software), see https://www.wikidata.org/wiki/User:Seb35/sortValues.js (and talk page). It could be adapted for other properties.

Nov 4 2018, 12:05 PM · patch-welcome, MediaWiki-extensions-WikibaseRepository, Wikidata

Nov 3 2018

Seb35 added a comment to T175874: RESTBase's and Parsoid's configs in MW-Vagrant don't contain additional domains.

For Parsoid the feature added by T100841 could be useful for this task.

Nov 3 2018, 4:01 PM · RESTBase, Core Platform Team Backlog (Later), Services (later), Patch-For-Review, Parsoid, MediaWiki-Vagrant
Seb35 awarded T100841: Support for dynamically enabling new wikis a Yellow Medal token.
Nov 3 2018, 4:00 PM · Patch-For-Review, Parsoid

Nov 2 2018

Seb35 added a comment to T55089: VisualEditor: When "section editing", re-focus on that section after saving the page.

It seems to work in recent versions of VisualEditor, isn’t it?

Nov 2 2018, 11:57 AM · User-Ryasmeen, VisualEditor, VisualEditor-MediaWiki

Oct 29 2018

Seb35 added a comment to T181641: Add the Parsoid repository key in https://www.mediawiki.org/keys/keys.html.

Yes, putting the key in the repo works also, either in https://releases.wikimedia.org/debian/ or https://releases.wikimedia.org/parsoid/ or elsewhere.

Oct 29 2018, 4:01 PM · Parsoid

Oct 15 2018

Seb35 added a comment to T188538: Implement SQL Query Validator in Quarry.

A possible solution would be to use CodeMirror and the linting addon since it is already used in Quarry, but there is no support for linting the SQL syntax. If someone is interested, it could be an upstream contribution, and then it could be integrated on Quarry.

Oct 15 2018, 2:24 PM · Quarry
Seb35 added a comment to T74874: Provide a way to add hyperlink in Quarry results/output.

I tested sqlparse, with the idea to solve T188538 with the same library, but it seems a bit overkill to just retrieve the comment after the field names, there is hardly parsing error detection (you have to search 'Error' tokens).

Oct 15 2018, 12:49 PM · Quarry
Seb35 added a comment to T74874: Provide a way to add hyperlink in Quarry results/output.
In T74874#4664854, @Tgr wrote:

It's easy to construct the URLs in SQL, though.

Oct 15 2018, 9:20 AM · Quarry

Oct 14 2018

Seb35 added a comment to T74874: Provide a way to add hyperlink in Quarry results/output.

I would have a first fix in JavaScript for the URLs, which is a simpler case, but I’m not sure it is really useful given there are not so much URLs in MediaWiki databases. Probably we should instead implement the more complete proposal, because the main format which is really helpful is page_title.

Oct 14 2018, 5:14 PM · Quarry
Seb35 added a comment to T74874: Provide a way to add hyperlink in Quarry results/output.

A more advanced suggestion (but could be another task) would be to have a dictionary about the datatype of common field names. E.g. default formatting for rev_user_text is @quarry:format link https://{$wgServer}/wiki/User:%s. But some fields have no meaning alone, like page_title without page_namespace.

Oct 14 2018, 3:16 PM · Quarry
Seb35 added a comment to T74874: Provide a way to add hyperlink in Quarry results/output.

I like Tgr’s both proposals, even if the implementation is nontrivial for the first comment.

Oct 14 2018, 3:09 PM · Quarry

Oct 1 2018

Seb35 added a comment to T99740: Use static php array files for l10n cache instead of CDB.

I’ve created some statistics with this proposed method. Summary:

  • generation time: 5x quicker than CDB, 2x quicker than current PHP arrays
  • size: 10% smaller than CDB, 30% smaller than current PHP arrays
Oct 1 2018, 10:05 AM · Performance-Team (Radar), Deployments, MediaWiki-Internationalization
Seb35 created P7605 Statistics for proposed LocalisationCache with slimer PHP arrays.
Oct 1 2018, 9:52 AM

Sep 30 2018

Seb35 added a comment to T119711: Let update.php check for composer updates in extensions.

Also if this is implemented there could be "false" warnings because of T141225, because extensions could use version ranges (e.g. 2.3.*) in their Composer requirements.

Sep 30 2018, 2:00 PM · Composer, Patch-For-Review, MediaWiki-General-or-Unknown, SyntaxHighlight, MediaWiki-Maintenance-scripts
Seb35 added a comment to T119711: Let update.php check for composer updates in extensions.

I tested the patch with various extensions: without composer.json (LanguageTool), with composer.json containing a 'require' section, with composer.json without 'require' section. The first type is correctly detected, the second correctly says if the composer.lock inside the extension directory is obsolete, and the third type says there is no composer.lock file (it’s true but it’s normal in production).

Sep 30 2018, 1:23 PM · Composer, Patch-For-Review, MediaWiki-General-or-Unknown, SyntaxHighlight, MediaWiki-Maintenance-scripts

Sep 28 2018

Seb35 triaged T127195: Detect if l10n_cache-<language code>.cdb is writable as Lowest priority.
Sep 28 2018, 12:41 PM · MediaWiki-Internationalization
Seb35 added a comment to T127195: Detect if l10n_cache-<language code>.cdb is writable.

I propose to close this task.

Sep 28 2018, 12:41 PM · MediaWiki-Internationalization
Seb35 merged T127127: Error writing to CDB file when several MediaWiki installations use the same tmp directory into T161453: Having LocalisationCache directory default to system tmp directory is insecure.
Sep 28 2018, 7:31 AM · MW-1.27-release-notes, MW-1.28-release-notes, MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), MW-1.29-release-notes, MediaWiki-Internationalization, Vuln-Infoleak, Security
Seb35 merged task T127127: Error writing to CDB file when several MediaWiki installations use the same tmp directory into T161453: Having LocalisationCache directory default to system tmp directory is insecure.
Sep 28 2018, 7:31 AM · MediaWiki-Internationalization
Seb35 added a comment to T127127: Error writing to CDB file when several MediaWiki installations use the same tmp directory.

I found the missing link I didn’t understand: between 1.27.0 and 1.27.2 the CDB caches were indeed either in $wgCacheDirectory if set else in wfTempDir() after rMW36171312ef0e1. In 1.27.2 the security task T161453 was fixed and wfTempDir() was no more the fallback if $wgCacheDirectory is not set - hence the database became again the fallback for localisation cache.

Sep 28 2018, 7:29 AM · MediaWiki-Internationalization

Sep 25 2018

Seb35 added a comment to T127127: Error writing to CDB file when several MediaWiki installations use the same tmp directory.

I just rewrote https://www.mediawiki.org/wiki/Manual:$wgCacheDirectory.

Sep 25 2018, 9:21 PM · MediaWiki-Internationalization
Seb35 added a comment to T127127: Error writing to CDB file when several MediaWiki installations use the same tmp directory.

I’m not sure everybody speaks about the same configuration parameters here:

  • $wgCacheDirectory: should be configured per-wiki for various long-life cache file – currently mainly l10n_cache-XX.cdb and lessphp_XXX.lesscache – and defaults to false
  • $wgTmpDirectory: short-life files - this is now wfTempDir() redirecting to TempFSFile::getUsableTempDirectory() which now guarantee the temp directory is writable (else throw a RuntimeException)
Sep 25 2018, 8:13 PM · MediaWiki-Internationalization
Seb35 closed T124027: unlink(c:/xampp/tmp/l10n_cache-en.cdb): Permission denied as Invalid.

I close this task as invalid first because:

  • it is a sysadmin task at the first level (set $wgCacheDirectory or more specifically $wgLocalisationCacheConf['storeDirectory'] to a writable directory),
  • there are the tasks T127195 and T127127 which aim to improve handling of this case.
Sep 25 2018, 6:31 PM · MediaWiki-Internationalization

Sep 24 2018

Seb35 added a comment to T194501: Top-level pages in the template namespace are not recognized as TemplateStyles stylesheets.

@jeblad @PerfektesChaos and other TemplateStyles users : there are now two patches to enable by default Sanitized CSS on top-level pages in templates, either unconditionally (which I guess would not satisfy @PerfektesChaos) either on a per-wiki and per-namespace basis, hence different communities could have different parameters. I point out this is only about the by default behaviour, there is always the possibility to change the content model (for users having this right).

Sep 24 2018, 6:40 PM · Patch-For-Review, TemplateStyles
Seb35 added a comment to T179963: Workspaces for mwgate-php55lint / mwgate-php70lint are getting huge.

git-changed-in-head works with almost-shallow clones: git clone --depth 2 https://gerrit.wikimedia.org/...

Sep 24 2018, 5:29 PM · Patch-For-Review, Wikimedia-production-error (Shared Build Failure), Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure
Seb35 updated the task description for T116701: XMPReader::checkParseSafely requires allow_url_fopen to be set enabled.
Sep 24 2018, 11:58 AM · Security, Security-Core, MediaWiki-General-or-Unknown
Seb35 added a comment to T116701: XMPReader::checkParseSafely requires allow_url_fopen to be set enabled.

The faulty code is exactly in Reader::checkParseSafety with the function XMLReader::open(). The tests works with replacing by the function XMLReader::xml() although there is specifically a comment warning about not doing that for security reasons.

Sep 24 2018, 11:55 AM · Security, Security-Core, MediaWiki-General-or-Unknown

Sep 23 2018

Seb35 added a comment to T99740: Use static php array files for l10n cache instead of CDB.

I tried this option. I didn’t benchmark but I noticed the files are quite big – as noted in rMWc403d4838dc86.

Sep 23 2018, 10:39 PM · Performance-Team (Radar), Deployments, MediaWiki-Internationalization
Seb35 triaged T202455: BounceHandler extension unit tests failing on UnSubscribeUserTest::testUnSubscribeUser as Normal priority.
Sep 23 2018, 2:08 PM · MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, MediaWiki-extensions-BounceHandler
Seb35 updated subscribers of T202455: BounceHandler extension unit tests failing on UnSubscribeUserTest::testUnSubscribeUser.

I now have a good understanding of the issue, and my comments above were not completely exact.

Sep 23 2018, 1:46 PM · MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, MediaWiki-extensions-BounceHandler
Seb35 added a comment to T202455: BounceHandler extension unit tests failing on UnSubscribeUserTest::testUnSubscribeUser.

After more tests on my local installation, this test fails if and only if CentralAuth is activated on the wiki. Hence there is a high probability that resolution of T201290 will imply resolution of this bug.

Sep 23 2018, 11:33 AM · MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, MediaWiki-extensions-BounceHandler
Seb35 added a comment to T202455: BounceHandler extension unit tests failing on UnSubscribeUserTest::testUnSubscribeUser.

The CI fails systematically since 17 August 2018 (list of changes in Gerrit). The two first jobs failing are https://gerrit.wikimedia.org/r/453327 and https://gerrit.wikimedia.org/r/454366.

Sep 23 2018, 10:03 AM · MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, MediaWiki-extensions-BounceHandler
Seb35 added a comment to T202455: BounceHandler extension unit tests failing on UnSubscribeUserTest::testUnSubscribeUser.

Some links:

  • T142134 - this test already failed two years ago because of an issue with WANObjectCache/CAS in MediaWiki core
  • T201290 - about the warning in destructor failing in a CentralAuth hook, possibly not the cause of this failed test but it adds noise and complexity in this case
Sep 23 2018, 8:59 AM · MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, MediaWiki-extensions-BounceHandler

Sep 22 2018

Seb35 committed rETST4ca65ffd1906: Allow Sanitized CSS in non-subpages according to a parameter (authored by Seb35).
Allow Sanitized CSS in non-subpages according to a parameter
Sep 22 2018, 9:49 AM

Sep 21 2018

Seb35 committed rETSTfc684a68a5de: Allow Sanitized CSS in non-subpages according to a parameter (authored by Seb35).
Allow Sanitized CSS in non-subpages according to a parameter
Sep 21 2018, 5:17 PM
Seb35 committed rETST63c781b4d8dd: Allow Sanitized CSS in non-subpages according to a parameter (authored by Seb35).
Allow Sanitized CSS in non-subpages according to a parameter
Sep 21 2018, 5:10 PM

Sep 20 2018

Seb35 closed T155298: Document visibility of TextContent::$mText as Resolved.

The property is now declared as protected. See also T155582 related to this task.

Sep 20 2018, 4:06 PM · Patch-For-Review, MediaWiki-extensions-WikiLexicalData-or-OmegaWiki, MediaWiki-ContentHandler
Seb35 updated subscribers of T195281: Instant "edit with form" tab on saving #default_form:.

@Nicolas_NALLET and I also observed this issue, annoying but not critical.

Sep 20 2018, 2:10 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms
Seb35 added a comment to T189928: Non-list values containing a comma lead to error when $wgPageFormsUseDisplayTitle = true.

Yes, it works for me with the current master b7b2c72 containing the latter change. Thanks!

Sep 20 2018, 10:34 AM · MediaWiki-extensions-Page_Forms
Seb35 committed rETSTd8f912b653ea: Allow Sanitized CSS in non-subpages (authored by Seb35).
Allow Sanitized CSS in non-subpages
Sep 20 2018, 7:55 AM
Seb35 committed rETST1c3564a20d9a: Allow Sanitized CSS in non-subpages according to a parameter (authored by Seb35).
Allow Sanitized CSS in non-subpages according to a parameter
Sep 20 2018, 7:55 AM