Page MenuHomePhabricator

Setian
Disabled

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 22 2019, 5:51 AM (8 w, 3 d)
Roles
Disabled
Availability
Available
LDAP User
Unknown
MediaWiki User
Setian~mw [ Global Accounts ]

Recent Activity

Mar 3 2019

Zoranzoki21 awarded T217125: Set $wgGroupPermissions['*']['deletedhistory'] = true; in DefaultSettings.php a Dislike token.
Mar 3 2019, 4:10 PM · Wikimedia-Site-requests, MediaWiki-Configuration, Patch-For-Review, MediaWiki-User-management

Mar 1 2019

Setian added a comment to T23312: Request for feature: RevisionMove.

Here's a mockup I created. https://upload.wikimedia.org/wikipedia/mediawiki/2/27/Screenshot-localhost-2019.02.28-22-39-30.png

Mar 1 2019, 3:43 AM · MediaWiki-extension-requests

Feb 28 2019

Setian added a comment to T211504: Ignore null revisions when checking if a non-admin can overwrite a redirect.

So what's going to happen to these null revisions? Will they just get deleted? What happens if the move is reversed; should those deleted null revisions get automatically restored, or should a sysop have to come along and restore them?

Yes, they will just get deleted, along the original revision with the original redirect, This is what currently happens if there is only a single revision with the redirect and no intermediate null revisions.

There's no need to restore them, if you leave the redirect when renaming the page back to the original name.

Feb 28 2019, 8:36 PM · MediaWiki-History-and-Diffs, MediaWiki-Page-deletion
Setian updated the task description for T217372: Implement "user was banned for this edit" tag.
Feb 28 2019, 8:06 PM · MediaWiki-Change-tagging
Setian updated the task description for T217372: Implement "user was banned for this edit" tag.
Feb 28 2019, 8:05 PM · MediaWiki-Change-tagging
Setian created T217372: Implement "user was banned for this edit" tag.
Feb 28 2019, 8:05 PM · MediaWiki-Change-tagging
Setian created T217370: Get rid of null revisions; instead just intersperse log entries with revisions in action=history.
Feb 28 2019, 7:49 PM · MediaWiki-Logging, MediaWiki-History-and-Diffs
Setian added a comment to T23312: Request for feature: RevisionMove.

So where should the log entries get saved? Is this going to the move/revision log, kinda like how currently, revisiondelete actions go to the delete/revision log?

Feb 28 2019, 5:26 PM · MediaWiki-extension-requests
Setian added a comment to T23312: Request for feature: RevisionMove.

In my experience, if I do not have selective delete of edits, I would certainly need selective undelete of edits like we have now.

(Selective or non-selective move (while keeping them deleted) of the deleted edits which are listed under a page-name, would also be useful.)

Feb 28 2019, 7:01 AM · MediaWiki-extension-requests
Setian added a comment to T23312: Request for feature: RevisionMove.

So what's the user interface for this going to look like? I'm thinking it's going to be like a cross between action=revisiondelete and Special:MovePage, because it'll list the revisions being moved and then ask where they're being moved to.

Feb 28 2019, 6:07 AM · MediaWiki-extension-requests
Setian added a comment to T23312: Request for feature: RevisionMove.

If there was a "selective revision move" feature ...

But selective delete of edits would also be useful, in my experience.

Feb 28 2019, 5:41 AM · MediaWiki-extension-requests
Setian updated the task description for T23312: Request for feature: RevisionMove.
Feb 28 2019, 1:34 AM · MediaWiki-extension-requests
Setian added a comment to T23312: Request for feature: RevisionMove.

I created this mockup: https://upload.wikimedia.org/wikipedia/mediawiki/d/d2/Screenshot-localhost-2019-02-26-23-07-41.png

Feb 28 2019, 1:30 AM · MediaWiki-extension-requests
Setian added a comment to T213617: Selective delete of edits.

I have now read https://www.mediawiki.org/wiki/Manual:RevisionDelete and https://www.mediawiki.org/wiki/Manual:Revision_table

The entry https://www.mediawiki.org/wiki/Manual:Revision_table#rev_deleted says that "rev_deleted ... This field is reserved for the RevisionDelete system. It's a bitfield in which the values are DELETED_TEXT = 1; DELETED_COMMENT = 2; DELETED_USER = 4; and DELETED_RESTRICTED = 8." Does this show that "revision deletion" is what I listed at (1) above, i.e. what I thought of as "hiding" edits, and not the same as ordinary deleting and undeleting of edits or pages that users often ask me to perform? Or what?

Feb 28 2019, 12:14 AM · MediaWiki-History-and-Diffs, MediaWiki-Page-deletion

Feb 27 2019

Setian added a comment to T213617: Selective delete of edits.

The situation is complicated by the fact that there are two tables for storing revisions, the archive table and the revision table.

Feb 27 2019, 8:02 PM · MediaWiki-History-and-Diffs, MediaWiki-Page-deletion
Restricted Application added a project to T140916: Remove curid parameter from diff links on watch list and recent changes: Growth-Team.

T215696 ("RecentChanges should update entries when user move a page") may help with this.

Feb 27 2019, 6:33 AM · Growth-Team, MediaWiki-Recent-changes, MediaWiki-Watchlist
Setian added a comment to T213619: Moving deleted edits while keeping them deleted.

@Anthony_Appleyard So if logged actions are being taken to move archived revisions from one page title to another, what log would these entries be filed under? Move log? Deletion log?

Feb 27 2019, 5:34 AM · MediaWiki-Page-deletion
Setian added a comment to T213617: Selective delete of edits.

@Anthony_Appleyard So basically you want something along the lines of this, it sounds like. https://upload.wikimedia.org/wikipedia/mediawiki/d/d2/Screenshot-localhost-2019-02-26-23-07-41.png

Feb 27 2019, 4:48 AM · MediaWiki-History-and-Diffs, MediaWiki-Page-deletion

Feb 26 2019

Setian removed a watcher for Thanks: Setian.
Feb 26 2019, 11:17 PM
Setian removed a watcher for MediaWiki-Recent-changes: Setian.
Feb 26 2019, 11:17 PM
Setian removed a watcher for MediaWiki-Page-deletion: Setian.
Feb 26 2019, 11:17 PM
Setian removed a watcher for good first bug: Setian.
Feb 26 2019, 11:17 PM
Setian added a comment to T211504: Ignore null revisions when checking if a non-admin can overwrite a redirect.

So what's going to happen to these null revisions? Will they just get deleted? What happens if the move is reversed; should those deleted null revisions get automatically restored, or should a sysop have to come along and restore them?

Feb 26 2019, 6:31 PM · MediaWiki-History-and-Diffs, MediaWiki-Page-deletion
Setian updated the task description for T217127: Improve transparency in MediaWiki.
Feb 26 2019, 4:42 PM
Setian added a comment to T213617: Selective delete of edits.

When an administrator has selected some edits, there could be options for him to ask for various things to be done with them, e.g.: (1) Deleting them. (2) Moving them to another pagename (i.e. renaming them). (3) Delete them and rename them at the same time.

Feb 26 2019, 3:30 PM · MediaWiki-History-and-Diffs, MediaWiki-Page-deletion
Setian added a project to T217125: Set $wgGroupPermissions['*']['deletedhistory'] = true; in DefaultSettings.php: MediaWiki-Configuration.
Feb 26 2019, 3:10 PM · Wikimedia-Site-requests, MediaWiki-Configuration, Patch-For-Review, MediaWiki-User-management
Setian added a comment to T213617: Selective delete of edits.

More simply :: sometimes in my work, I need to delete some edits of a page's edit history. But I cannot :: I must delete all of that page's edits, then undelete some of them. That wastes internet link time and Wikipedia server time. That is why selective delete is needed.

Feb 26 2019, 12:14 PM · MediaWiki-History-and-Diffs, MediaWiki-Page-deletion
Setian added a comment to T217125: Set $wgGroupPermissions['*']['deletedhistory'] = true; in DefaultSettings.php.

This goes well with T217089, "Add a config setting to disable deletion of recentchanges entries when pages are deleted."

Feb 26 2019, 10:37 AM · Wikimedia-Site-requests, MediaWiki-Configuration, Patch-For-Review, MediaWiki-User-management
Setian added a comment to T217089: Add a config setting to disable deletion of recentchanges entries when pages are deleted.

This task dovetails nicely with T217125, "Set $wgGroupPermissions['*']['deletedhistory'] = true; in DefaultSettings.php".

Feb 26 2019, 10:36 AM · Patch-For-Review, MediaWiki-Recent-changes, Growth-Team, MediaWiki-Page-deletion
Setian added a parent task for T217089: Add a config setting to disable deletion of recentchanges entries when pages are deleted: T217127: Improve transparency in MediaWiki.
Feb 26 2019, 10:34 AM · Patch-For-Review, MediaWiki-Recent-changes, Growth-Team, MediaWiki-Page-deletion
Setian added subtasks for T217127: Improve transparency in MediaWiki: T217125: Set $wgGroupPermissions['*']['deletedhistory'] = true; in DefaultSettings.php, T217089: Add a config setting to disable deletion of recentchanges entries when pages are deleted.
Feb 26 2019, 10:34 AM
Setian added a parent task for T217125: Set $wgGroupPermissions['*']['deletedhistory'] = true; in DefaultSettings.php: T217127: Improve transparency in MediaWiki.
Feb 26 2019, 10:34 AM · Wikimedia-Site-requests, MediaWiki-Configuration, Patch-For-Review, MediaWiki-User-management
Setian created T217127: Improve transparency in MediaWiki.
Feb 26 2019, 10:33 AM
Setian created T217125: Set $wgGroupPermissions['*']['deletedhistory'] = true; in DefaultSettings.php.
Feb 26 2019, 10:23 AM · Wikimedia-Site-requests, MediaWiki-Configuration, Patch-For-Review, MediaWiki-User-management
Setian added a comment to T42411: Add user right to see logs which are deleted by deletelogentry.

How do we want to implement this? As a core user right, or as a hook that an extension would use to add a new user right?

Feb 26 2019, 10:05 AM · MediaWiki-Revision-deletion
Setian added a comment to T178038: Rebuildrecentchanges.php should regenerate CatWatch entries.

Maybe T215696 ("RecentChanges should update entries when user move a page") would help with this?

Feb 26 2019, 8:47 AM · Growth-Team, MediaWiki-Maintenance-scripts, MediaWiki-Recent-changes, TCB-Team, CatWatch
Setian renamed T217089: Add a config setting to disable deletion of recentchanges entries when pages are deleted from Don't delete recentchanges entries when pages are deleted to Add a config setting to disable deletion of recentchanges entries when pages are deleted.
Feb 26 2019, 8:31 AM · Patch-For-Review, MediaWiki-Recent-changes, Growth-Team, MediaWiki-Page-deletion

Feb 25 2019

Setian updated the task description for T217089: Add a config setting to disable deletion of recentchanges entries when pages are deleted.
Feb 25 2019, 8:28 PM · Patch-For-Review, MediaWiki-Recent-changes, Growth-Team, MediaWiki-Page-deletion
Setian updated the task description for T217089: Add a config setting to disable deletion of recentchanges entries when pages are deleted.
Feb 25 2019, 8:27 PM · Patch-For-Review, MediaWiki-Recent-changes, Growth-Team, MediaWiki-Page-deletion
Setian added a comment to T215696: RecentChanges should update entries when user move a page.

If this were to be implemented, then that would mean that Special:NewPages would no longer need to show "originally created as" for moved pages.

This looks to be automagically taken care of (going forward) when this patch is applied. The "originally created as" simply doesn't appear for newer entries.

Feb 25 2019, 8:25 PM · Growth-Team (Current Sprint), Patch-For-Review, MediaWiki-Recent-changes
Setian updated the task description for T217089: Add a config setting to disable deletion of recentchanges entries when pages are deleted.
Feb 25 2019, 8:24 PM · Patch-For-Review, MediaWiki-Recent-changes, Growth-Team, MediaWiki-Page-deletion
Setian updated the task description for T217089: Add a config setting to disable deletion of recentchanges entries when pages are deleted.
Feb 25 2019, 8:24 PM · Patch-For-Review, MediaWiki-Recent-changes, Growth-Team, MediaWiki-Page-deletion
Setian updated the task description for T217089: Add a config setting to disable deletion of recentchanges entries when pages are deleted.
Feb 25 2019, 8:23 PM · Patch-For-Review, MediaWiki-Recent-changes, Growth-Team, MediaWiki-Page-deletion
Setian updated the task description for T217089: Add a config setting to disable deletion of recentchanges entries when pages are deleted.
Feb 25 2019, 8:21 PM · Patch-For-Review, MediaWiki-Recent-changes, Growth-Team, MediaWiki-Page-deletion
Setian created T217089: Add a config setting to disable deletion of recentchanges entries when pages are deleted.
Feb 25 2019, 8:21 PM · Patch-For-Review, MediaWiki-Recent-changes, Growth-Team, MediaWiki-Page-deletion
Setian added a watcher for Anisa: Setian.
Feb 25 2019, 6:16 AM
Setian added a watcher for ActiveAbstract: Setian.
Feb 25 2019, 6:03 AM
Setian added a comment to T213617: Selective delete of edits.

Can you provide a specific example article where this would be helpful, and point out which exact edits you would move from where to where?

Feb 25 2019, 4:23 AM · MediaWiki-History-and-Diffs, MediaWiki-Page-deletion
Setian added a member for MediaWiki-Page-deletion: Setian.
Feb 25 2019, 4:20 AM
Setian added a watcher for MediaWiki-Page-deletion: Setian.
Feb 25 2019, 4:20 AM
Setian added a watcher for Thanks: Setian.
Feb 25 2019, 3:09 AM
Setian added a watcher for MediaWiki-Recent-changes: Setian.
Feb 25 2019, 3:08 AM
Setian added a member for MediaWiki-Recent-changes: Setian.
Feb 25 2019, 3:08 AM
Setian added a member for good first bug: Setian.
Feb 25 2019, 3:07 AM
Setian added a member for Thanks: Setian.
Feb 25 2019, 3:07 AM
Setian added a watcher for good first bug: Setian.
Feb 25 2019, 3:06 AM
Setian added a comment to T136048: Thanks logs page id 0.

I think (I could be wrong, since I'm new to the code.) that logging.log_page is the page ID of the user page for the user being thanked. If that user doesn't have such a page, it's 0.

Feb 25 2019, 2:09 AM · Growth-Team, Collaboration-Team-Triage, Thanks
Setian added a comment to T191599: Remove Thanks for autopromote log.

So how do you want to do this; should it be set up like:

Feb 25 2019, 1:38 AM · Patch-For-Review, good first bug, Growth-Team, MediaWiki-Logging, MediaWiki-User-management, Thanks, Collaboration-Team-Triage

Feb 24 2019

Setian updated subscribers of T215696: RecentChanges should update entries when user move a page.

And after this change, that would still be the case, right? That seems to be working as expected. Anyhow, I'll leave this for Growth to triage :)

Feb 24 2019, 7:26 PM · Growth-Team (Current Sprint), Patch-For-Review, MediaWiki-Recent-changes
Setian added a comment to T216873: Integrate interwiki titles into LinkCache.

There's going to be a need for cross-wiki invalidation of caches, right, when pages are deleted, etc.? How are we going to implement that?

Feb 24 2019, 5:01 PM · MediaWiki-Interwiki
Setian added a comment to T215696: RecentChanges should update entries when user move a page.

The page link is indeed red and represents the title at the time.

But, does the "diff" link work?

Feb 24 2019, 4:36 PM · Growth-Team (Current Sprint), Patch-For-Review, MediaWiki-Recent-changes
Setian added a comment to T216873: Integrate interwiki titles into LinkCache.

@Legoktm , I took a look at your 2014 patch here: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/177960/5/includes/cache/LinkCache.php

Feb 24 2019, 1:05 AM · MediaWiki-Interwiki

Feb 23 2019

Setian added a comment to T212236: Installer doesn't handle connection error in SHOW ENGINES gracefully.

Here are the current error messages I get (when using mysql Ver 15.1 Distrib 10.1.34-MariaDB, for debian-linux-gnu (x86_64)):

Feb 23 2019, 12:15 PM · good first bug, MediaWiki-Installer
Setian added a comment to T215696: RecentChanges should update entries when user move a page.

Are there certain mw.log entries, like previous page moves, whose recentchanges rows should be left alone rather than changed when the page is moved? If so, what's the list of exclusions? Anyway, for now I just went ahead and excluded all mw.log entries from being changed by this.

Feb 23 2019, 11:14 AM · Growth-Team (Current Sprint), Patch-For-Review, MediaWiki-Recent-changes
Setian added a comment to T2011: Red interwiki links -- check for page existence across wikis.

Does that seem like something you could take on? It's definitely not a trivial task - let me know if anything I suggested is unclear.

Feb 23 2019, 8:58 AM · Patch-For-Review, Crosswiki, MediaWiki-Parser
Setian added a parent task for T2011: Red interwiki links -- check for page existence across wikis: T216873: Integrate interwiki titles into LinkCache.
Feb 23 2019, 8:51 AM · Patch-For-Review, Crosswiki, MediaWiki-Parser
Setian added a subtask for T216873: Integrate interwiki titles into LinkCache: T2011: Red interwiki links -- check for page existence across wikis.
Feb 23 2019, 8:51 AM · MediaWiki-Interwiki
Setian created T216873: Integrate interwiki titles into LinkCache.
Feb 23 2019, 8:51 AM · MediaWiki-Interwiki
Setian updated subscribers of T2011: Red interwiki links -- check for page existence across wikis.

Adding Legoktm since he wrote the LinkRenderer.

Feb 23 2019, 7:42 AM · Patch-For-Review, Crosswiki, MediaWiki-Parser
Setian added a comment to T2011: Red interwiki links -- check for page existence across wikis.

Do you want to have an isset() for $wgInterwikiNamespaces, or do you want it defined in DefaultSettings.php as an empty array, or is there some better way to find out the namespace scheme of another wiki?

Feb 23 2019, 7:41 AM · Patch-For-Review, Crosswiki, MediaWiki-Parser
Setian added a comment to T214591: MediaWiki Codesniffer not catching irrelevant characters after PHPDoc return types.

What documentation should a newbie read to learn how to do this? Oh, I guess I'll take a look at https://phabricator.wikimedia.org/project/profile/1087/ for inspiration.

Feb 23 2019, 7:31 AM · good first bug, MediaWiki-Codesniffer

Feb 22 2019

Setian added a comment to T6459: Create a special page to handle additions, removals, changes and logging of spam blacklist entries.

So now I'm starting to think, since this is going to have so many of the features and aesthetics of AbuseFilter, the best approach would be to just rip off most of the code from AbuseFilter, and rip off a small amount of code from SpamBlacklist (the part that compares the blacklist to the whitelist to see if it's going to be triggered). In a case like this where the needed functionality is so close to what already exists, might as well just rip it off wholesale, rather than merely take inspiration from it.

Feb 22 2019, 8:16 PM · Stewards-and-global-tools, SpamBlacklist
Setian added a comment to T6459: Create a special page to handle additions, removals, changes and logging of spam blacklist entries.

See mockup:

Feb 22 2019, 7:41 PM · Stewards-and-global-tools, SpamBlacklist
Setian added a comment to T6459: Create a special page to handle additions, removals, changes and logging of spam blacklist entries.

It looks like most of the consensus is in favor of creating a special page of some sort for the spam blacklist, since this task hasn't been WONTFIXed.

Feb 22 2019, 5:29 PM · Stewards-and-global-tools, SpamBlacklist
Setian added a comment to T216803: Add an option for an expiration date for spam blacklist items.

Hmm. Since when TitleBlacklist entries can be set to expire? I don't see any docs (or can't find them) on mediawiki.org. That should be documented. Thanks.

Feb 22 2019, 5:05 PM · SpamBlacklist
Setian added a comment to T157826: Spam blacklist should provide options like the Title blacklist.

So, a few questions.

  1. Are we anticipating there are just going to be 3-4 options?
  2. Are we going to want to integrate this with AbuseFilter; and if so, how does that affect our design decisions?
  3. Do you mind if we have to create another database table for this?
  4. If we do this as a special page, how do we handle situations where sysops want to insert a line next to an already-existing line, so that similar items are grouped together? Is each line going to be numbered, so that for example, they could number a new line 65 to put it between lines 60 and 70?
Feb 22 2019, 9:42 AM · Stewards-and-global-tools, SpamBlacklist
Setian added a subtask for T157826: Spam blacklist should provide options like the Title blacklist: T216803: Add an option for an expiration date for spam blacklist items.
Feb 22 2019, 9:20 AM · Stewards-and-global-tools, SpamBlacklist
Setian added a parent task for T216803: Add an option for an expiration date for spam blacklist items: T157826: Spam blacklist should provide options like the Title blacklist.
Feb 22 2019, 9:20 AM · SpamBlacklist
Setian created T216803: Add an option for an expiration date for spam blacklist items.
Feb 22 2019, 9:18 AM · SpamBlacklist
Setian added a comment to T216393: Database is continually denying access to root@localhost.

2019-02-21T16:38:43.676509Z 27866 [Note] Access denied for user 'root'@'localhost' (using password: NO)

Looks to be happening every 30 seconds.

Feb 22 2019, 8:55 AM · good first bug, Hashtags
Setian added a comment to T216393: Database is continually denying access to root@localhost.

I am done with the setup and able to reproduce the same error

Feb 22 2019, 7:51 AM · good first bug, Hashtags
Setian added a comment to T216617: Visual Editor educational popup about links has LTR and RTL versions of the image in reverse.

Just curious, is the RTL version actually used anywhere? I ran a Catfish search and didn't see it in any of the files, although the LTR version is used in VisualEditor/modules/ve-mw/ui/styles/tools/ve.ui.MWLinkInspectorTool.css

Feb 22 2019, 7:42 AM · Verified, MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), VisualEditor (Current work), good first bug
Setian added a comment to T216727: Display a notice if database appears to be significantly behind current time.

What table will it be looking at for this timestamp? Also, what style of notice will it be displaying; is there another one like it, that it can be modeled after? Thanks.

Feb 22 2019, 5:53 AM · good first bug, Hashtags