Sat, Jun 22
Thu, Jun 20
Thu, Jun 13
Wed, Jun 12
Tue, Jun 11
Same on android @bearND . We use it while loading the leas section as a meta preference.:
Further we have a native transform for it.
Mon, Jun 10
@schoenbaechler the news item ellipsis that we discussed this morning, is the only change pending. Otherwise ready for review.
Tue, Jun 4
@schoenbaechler I have removed page item view is also used in page bottom content, so when I remove the placeholder image, it looks like this :
Mon, Jun 3
Thank you @schoenbaechler :) Will do that..
@VeghTomi Please do. I have unassigned myself. Thank you :-)
There’s only one right now: “Go to file page”. The reason why it’s hidden in the overflow menu is we don’t want to promote it since it’s not optimized (coming in V2: T223132). I’m thinking about a more prominent button at the bottom for V2.
Fri, May 31
Blocked until the DescriptionEditView logic is solidified to support image caption edits
@schoenbaechler couple questions...
1.what are the options on the overflow menu?
2.The toolbar scrolls with the dialog as it is not a separate activity and cannot behave like a regular screens' toolbar. Is that ok?
Wed, May 29
Tue, May 28
May 22 2019
May 18 2019
hi @Ashishkumar468 Thank you for offering help... The new designs will be updated in a bit. @schoenbaechler has designed it ... Please update here if you have more questions. Once I stabilize the four fragments we want to display, we can probably collaborate and use your help on stabilizing the menu and orientation changes..Will update you on this ticket..
May 17 2019
May 13 2019
May 8 2019
Point to note... when there is no image for the news card item, that is all the text we can show... 😖 Of course in the example I had to artificially remove the image to show how it would look... but in reality i assume all of the news items not having an image is very borderline..
Yes yes yes!!! whoo hoo! Thanks @schoenbaechler
May 7 2019
After code change for search:
May 6 2019
May 3 2019
May 2 2019
And after the description is added, in the landscape mode, do we see pencil image instead of '+'
@schoenbaechler Thank you...
Just one more clarification:
what is the color attribute for '+ ADD DESCRIOTION' - is it just base100[white] or paper_color?
May 1 2019
You mentioned it @schoenbaechler ... its done :)
Apr 30 2019
Thank you @schoenbaechler will do it
@schoenbaechler Thank you for the clarification on the feed cards.
01) Users should stay within the “Add/translate descriptions“ workflow when coming from the “Explore feed“. Currently, the behavior that’s implemented in the Alpha is that users return to the “Explore feed“. The user journey should be:
- Users taps a “Suggested edit“ card in the “Explore feed“
- Users add/translate a description
- Users are presented with a new card within the Add/translate descriptions view
- Do these things apply to the Suggested Edits feed cards too:
Apr 24 2019
@Charlotte @schoenbaechler The root cause for this bug is that the custom styles are not getting applied to the dialog on the first load. It is the same behavior in light mode too, but we do not notice as our custom colors and default are close. With Dark/Black mode, the default styles for dialogs assigns the textPrimaryColor to the text and hence renders the way we see in the screenshot, very light[which is the primary text color in dark mode].
It is unclear as to why this is happening and why it gets resolved when we try to take any action in the bottom sheet, say, changing the theme or dimming image settings from the bottom sheet.. So I will open an issue on sdk repo and will wait for your responses to move it to tracking.
Apr 19 2019
Add descriptions has been unlocked (3 non-reverted edits): Daily suggestions for “Add descriptions“ are shown in the feed.
Thank you @schoenbaechler!
Apr 16 2019
Apr 15 2019
yes, @Charlotte ! moving it to done.
Apr 12 2019
Apr 8 2019
@schoenbaechler Could you please let me know the margins when there is no image?
Apr 4 2019
My guess is that it is their custom component which is not exposed to us..[ I will look around if there is a function call to make it behave differently]
Hmm interesting, I find it’s poorly designed with that huge gap. What component is Google Translate using here?
Thanks for the clarifications @schoenbaechler
For point 03, we are not doing any particular transition here, it is just the system transition. The only improvement to the transition between the Activities that we can do is to fade-out first and fade-in next activity. I tried that, but I don't feel it looks all that good...Check it out.. Even assuming we do something about the keyboard coming up after the animation... looks unnecessarily dramatic.:
03 Related to transitioning from one screen to another (also affects T217169): is there a way to avoid the page jump at the top when arriving in the editing interface? (Observe “English description“ & “Beach of Portugal“ in the video below):
Unable to makeout the difference between the two 😂 . Can I refer to zeplin and make it 9dp margin on top and 19dp on bottom? https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5c77d20a86d8b86292fd9750
02 Move plus icon and label ("Add German translation") 12dp lower (the values in sp are still a mystery to me). Please use the “After“ screenshot below (Pixel 3) to adjust the position accordingly.
@schoenbaechler We are using a system component for this, and it changes the space between the label and arrow according to the longest entry in the list. For eg: This is how it looks with a really long named language:
Apr 3 2019
@schoenbaechler ready for review..
Apr 2 2019
Apr 1 2019
Mar 28 2019
Mar 27 2019
ok cool! that makes it easier then..
@schoenbaechler so other main reason for a separate ticket was to group them and further give the user an option to individually turn them on/off as well... so which would mean, we indicate in ui that 'Suggested edits' is a group, and on clicking it, it will expose the various types of cards grouped under it.. like suggested edit add description, suggested edit translate description,suggested edit image... etc.. which can also then be turned on/off individually.. If you feel that is how we should proceed, then this ticket should include design to do that as well?
Could I get strings for the title and description for the feed card in customize screen:
Mar 26 2019
@schoenbaechler should this verbiage be changed on the main drawer too, or just here?