@RHo this is ready for a design review..
@RHo above patch should fix the other two issues : 8dp top and bottom padding, and swapping of functionality.
Height of menu item should be 48dp as of now... does it show differently to you @RHo
Related patch : https://gerrit.wikimedia.org/r/#/c/425606/
@RHo please review this.
Tue, Apr 24
Mon, Apr 23
Tue, Apr 17
Fri, Apr 13
Yes @Rita we should... i will put something on calendar. I have more questions about showing recent search in languages, should area below tabs be swipeable, etc..
@RHo I am assuming the languages tab layout should not be visible at this point:
Thu, Apr 12
Wed, Apr 11
finally!!!! I was able to ssh into releases1001 and stat1006!
yes... I was looking in the wrong directory... I have updated my comment to reflect the contents of /etc/ssh/ssh_config
wmf2050:~ sharan$ ssh-add -L releases1001.eqiad.wmnet The agent has no identities.
This is what I have in etc/ssh
@MoritzMuehlenhoff please let me know if a hangout would be better. I will be available for the next hour and then anytime after 9am Pacific time.
My config looks like this now..
Tue, Apr 10
Do you want to do a quick hangout?
I am still getting the same error after changing username to sharvaniharan
@Dzahn my new key for production is not an rsa key, it is a ed25519 key. While we are doing this exercise, could you please update it to the new rsa key i am attaching here.. prod_key.pub?
@Dzahn please let me know if being on a hangout or remote access would help you.. I am open to it.
## Use bastion-eqiad.wmflabs.org as proxy to labs Host bastlabs HostName bastion-eqiad.wmflabs.org User sharan IdentityFile ~/.ssh/id_rsa
Mon, Apr 9
Fri, Apr 6
Thu, Apr 5
Some screenshots on how it will look once the changes are merger. @RHo let me know if anything looks off:
Wed, Apr 4
Not bad at all!
Tue, Apr 3
@RHo I played around with different heights and the preset text sizes 24sp - 28sp with granularity of 1sp [decreaments of 1sp while trying to resize]. I see no best-fit scenarios at all.
-Cannot add ellipsis.
-Cuts off the last line of text in some cases
-If the height is increased, then the small titles start looking funny
- Even if you decide on a smaller text size, some long titles may still be rendered badly, getting cut-off on the last line..
Mon, Apr 2
I have also asked the user for more details : Article name.
Sun, Apr 1
Fri, Mar 30
Thu, Mar 29
Min of 24sp only offers a slight improvement to current title without autosizing:
@RHo here are a few examples with 24sp minimum and 28sp maximum:
Wed, Mar 28
@RHo : When there is an edit conflict, we advice the user to copy content and go back and refresh, and then when the user tries to exit, we still show the dialog asking the user to save changes. If we should not show that dialog once we show the conflict dialog, could you please open a ticket for that? : https://youtu.be/_gX9RMGnF7g
Tue, Mar 27
Mar 26 2018
Mar 23 2018
@RHo Dmitry put in a fix and now we have no border on 19, there is no portion being cut-off on the right... however, the corner couldn't be rounded off without having that white border... Can we call this a win and close this? ;-)
@RHo do you want a particular height for the title view, a particular minimum text size, or do you want me to play around?
Mar 22 2018
Resolved by : https://gerrit.wikimedia.org/r/#/c/420127/
Mar 21 2018
Mar 20 2018
Mar 19 2018
Mar 16 2018
Mar 13 2018
Mar 12 2018
Mar 8 2018
Thanks Rita! will do that!
Also, wondering if we should be having this option at individual list screen as well?
@RHo should the option be invisible if: