Page MenuHomePhabricator

Sharvaniharan (Sharvaniharan)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 23 2017, 3:03 PM (112 w, 5 d)
Availability
Available
LDAP User
Sharvaniharan
MediaWiki User
SHaran (WMF) [ Global Accounts ]

Recent Activity

Fri, Oct 18

Sharvaniharan claimed T235908: Remove "targets" from Suggested Edits API..
Fri, Oct 18, 6:03 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Thu, Oct 10

Sharvaniharan added a comment to T231442: Move Suggested edits menu item to main tab bar.

@schoenbaechler looks like we might have to wait for the stable release. Looks like google is tracking this issue: https://issuetracker.google.com/issues/115754572.

Thu, Oct 10, 6:37 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T234949: Extend UX recruitment snackbar indefinitely from Doing to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Thu, Oct 10, 5:05 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T231448: Incorporate onboarding message and illustration for new users on SE home from Doing to Blocked/Waiting on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Thu, Oct 10, 5:04 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Tue, Oct 8

Sharvaniharan claimed T234949: Extend UX recruitment snackbar indefinitely.
Tue, Oct 8, 7:54 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T234949: Extend UX recruitment snackbar indefinitely from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Tue, Oct 8, 7:53 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Mon, Oct 7

Sharvaniharan moved T231445: Incorporate new structure and design for tasks on the SE home page from Doing to Blocked/Waiting on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Mon, Oct 7, 10:21 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan added a comment to T231445: Incorporate new structure and design for tasks on the SE home page.

@schoenbaechler thank you for all the updated icons :-)

Mon, Oct 7, 9:32 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan claimed T231448: Incorporate onboarding message and illustration for new users on SE home.
Mon, Oct 7, 9:06 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Fri, Oct 4

Sharvaniharan moved T231448: Incorporate onboarding message and illustration for new users on SE home from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Fri, Oct 4, 8:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T231445: Incorporate new structure and design for tasks on the SE home page from Doing to Blocked/Waiting on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Fri, Oct 4, 8:54 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T233918: Review Suggested edits V3 copy from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Fri, Oct 4, 8:54 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Wed, Oct 2

Sharvaniharan added a comment to T231581: "No apps can perform this action" or "All apps associated with this action..." error.

@Dbrant @Charlotte I have moved this to 'Done' as this cannot be tested and has already been included in the previous release.

Wed, Oct 2, 11:17 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T231581: "No apps can perform this action" or "All apps associated with this action..." error from Doing to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Wed, Oct 2, 11:16 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Mon, Sep 30

Sharvaniharan added a comment to T231448: Incorporate onboarding message and illustration for new users on SE home.

@schoenbaechler the circle with accent background is rendering differently,

Mon, Sep 30, 9:17 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T232847: Improve "offline" error messaging for circumstances when the user's phone isn't actually offline from Doing to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Mon, Sep 30, 4:56 PM · UX-Debt, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan claimed T233918: Review Suggested edits V3 copy.
Mon, Sep 30, 4:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T233918: Review Suggested edits V3 copy from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Mon, Sep 30, 4:54 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Thu, Sep 26

Sharvaniharan added a comment to T231445: Incorporate new structure and design for tasks on the SE home page.

@schoenbaechler for completion sake can we add green90 to our palette and have a group.. even if it is just the same color for all themes?

Thu, Sep 26, 6:22 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan added a comment to T231445: Incorporate new structure and design for tasks on the SE home page.

Thank you @schoenbaechler

Thu, Sep 26, 3:42 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan added a comment to T231445: Incorporate new structure and design for tasks on the SE home page.

@schoenbaechler thank you for the above clarifications. Couple more
1.is this tool tip text finalized?:
https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5d6fe67366c07d187b8ac732

Thu, Sep 26, 2:04 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Tue, Sep 24

Sharvaniharan added a comment to T231581: "No apps can perform this action" or "All apps associated with this action..." error.

@Dbrant thats is a good point.. I did not try to reproduce it after fixing it... steps to a possible reproduction would be... re-install both the opera and opera mini apps on the phone and set a default browser and try to open an external link from the app.

Tue, Sep 24, 10:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan added a comment to T231445: Incorporate new structure and design for tasks on the SE home page.

Also while we are at it... need a few confirmations:
All text color is material_theme_secondary_color [color_group_30]?
The all-caps headings are material_theme_primary_color [color_group_40]?
Stats icons size is 32 x 32?
Task icon is 48 x 48 background circle, and image 24 x 24 ?

Tue, Sep 24, 12:36 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan added a comment to T231445: Incorporate new structure and design for tasks on the SE home page.

@schoenbaechler thank you for all the clarifications above. One more :-)
I did not find a color group for the inner circle background for Edit quality stats icon:


is it #d5fdf4 in light mode?

Tue, Sep 24, 12:17 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan added a comment to T231445: Incorporate new structure and design for tasks on the SE home page.

Of course I liked my own idea from our call earlier of having a greyed-out translate button that then led users into a set languages flow, but I look forward to seeing how much better a thing you can come up with. 😄

No better idea needed @Charlotte! 👏 I love this “less but better” approach!

Tue, Sep 24, 12:13 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan updated subscribers of T231581: "No apps can perform this action" or "All apps associated with this action..." error.

I inspected this bug on @JKatzWMF phone yesterday and here are my findings @Charlotte
The root cause was that when a default app is chosen for browsing, under settings -> apps ->Default apps
If that app is incapable of opening our links, we get this message. I resolved this on Jon’s phone by deleting the opera browser, which started working properly but was still choosing Chrome automatically. However resetting the default preferences, started showing a chooser with all the available browsers as expected.

Tue, Sep 24, 11:47 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T231581: "No apps can perform this action" or "All apps associated with this action..." error from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Tue, Sep 24, 2:09 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan claimed T231581: "No apps can perform this action" or "All apps associated with this action..." error.
Tue, Sep 24, 2:08 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Sep 20 2019

Sharvaniharan added a comment to T231445: Incorporate new structure and design for tasks on the SE home page.

Thank you @schoenbaechler! Will do this.

Sep 20 2019, 6:33 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T229940: [SPIKE] Investigate user edit impact APIs from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Sep 20 2019, 6:05 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan added a comment to T229940: [SPIKE] Investigate user edit impact APIs.

@Jhernandez Of the 4 things required to display stats, this is what I feel we would need

Sep 20 2019, 6:00 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan claimed T229940: [SPIKE] Investigate user edit impact APIs.
Sep 20 2019, 4:44 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing

Sep 18 2019

Sharvaniharan added a comment to T231445: Incorporate new structure and design for tasks on the SE home page.

Is there a zeplin mock up for this... It is ok if we don't, I was able to guess most measurements ... and we can fix the styles during review.

Sep 18 2019, 11:36 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan added a comment to T231445: Incorporate new structure and design for tasks on the SE home page.

@schoenbaechler Couple things:

Sep 18 2019, 11:35 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Sep 17 2019

Sharvaniharan updated subscribers of T231442: Move Suggested edits menu item to main tab bar.

@schoenbaechler @Charlotte How about when the user is not logged in?

Sep 17 2019, 12:38 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Sep 13 2019

Sharvaniharan added a comment to T232847: Improve "offline" error messaging for circumstances when the user's phone isn't actually offline.

@Charlotte I agree. This ticket should at least be about better messages conditionally, if the bug itself is not reproducible[DDoS attack was my guess too].

Sep 13 2019, 4:17 PM · UX-Debt, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T232847: Improve "offline" error messaging for circumstances when the user's phone isn't actually offline from Did not pass QA to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Sep 13 2019, 4:09 PM · UX-Debt, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T232847: Improve "offline" error messaging for circumstances when the user's phone isn't actually offline from Backlog to Did not pass QA on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Sep 13 2019, 4:08 PM · UX-Debt, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T232847: Improve "offline" error messaging for circumstances when the user's phone isn't actually offline from Needs Triage to Android-app-release-v2.7.29x-N-Nanaimo-Bar on the Wikipedia-Android-App-Backlog board.
Sep 13 2019, 4:08 PM · UX-Debt, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T231445: Incorporate new structure and design for tasks on the SE home page from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Sep 13 2019, 3:20 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan claimed T231445: Incorporate new structure and design for tasks on the SE home page.
Sep 13 2019, 3:20 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan updated subscribers of T231682: [BUG] Share button and "copy to clipboard" doesn't work.

My best guess is that the user is referring to copying the url of the article through the share menu - 'Copy to Clipboard' utility. It is working fine in the current production version:
https://youtu.be/4cBQnncRjPw

Sep 13 2019, 12:24 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T232455: Snackbar for microcontributions research survey from Doing to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Sep 13 2019, 12:02 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Sep 12 2019

Sharvaniharan added a comment to T232455: Snackbar for microcontributions research survey.

Resolved @schoenbaechler! Lmk if it all looks good.

Sep 12 2019, 11:54 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan added a comment to T232455: Snackbar for microcontributions research survey.

perfect! thank you @Charlotte

Sep 12 2019, 7:09 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan added a comment to T232455: Snackbar for microcontributions research survey.

Also a quick question @dchen @Charlotte is the survey still active on the 26th or does it end at the start of the day at 0h:0m:0s?

Sep 12 2019, 5:49 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan added a comment to T232455: Snackbar for microcontributions research survey.

Just for process... approved screenshot.

Sep 12 2019, 5:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Sep 11 2019

Sharvaniharan closed T232628: "Suggested edits" doesn't appear in the Explore feed even if it is customized to be the only feed object. as Invalid.
Sep 11 2019, 5:35 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-Bugs
Sharvaniharan updated subscribers of T232628: "Suggested edits" doesn't appear in the Explore feed even if it is customized to be the only feed object..

@Charlotte @ABorbaWMF Not able to reproduce this issue.

Sep 11 2019, 5:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-Bugs
Sharvaniharan moved T232455: Snackbar for microcontributions research survey from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Sep 11 2019, 3:59 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Sep 10 2019

Sharvaniharan claimed T232455: Snackbar for microcontributions research survey.
Sep 10 2019, 4:19 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T231442: Move Suggested edits menu item to main tab bar from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Sep 10 2019, 3:48 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Sep 5 2019

Sharvaniharan claimed T231442: Move Suggested edits menu item to main tab bar.
Sep 5 2019, 6:47 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T231442: Move Suggested edits menu item to main tab bar from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Sep 5 2019, 6:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T219995: mobile-html article view updates from Code Review to Blocked/Waiting on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Sep 5 2019, 5:33 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.30x-O-Ontbijtkoek), Android-app-feature-mobile-html
Sharvaniharan moved T231441: Remove all current onboarding dialogs and notifications from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Sep 5 2019, 5:33 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Aug 29 2019

Sharvaniharan claimed T231441: Remove all current onboarding dialogs and notifications.
Aug 29 2019, 10:41 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan moved T231441: Remove all current onboarding dialogs and notifications from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Aug 29 2019, 10:40 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan awarded T231441: Remove all current onboarding dialogs and notifications a Yellow Medal token.
Aug 29 2019, 5:00 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Aug 26 2019

Sharvaniharan moved T231217: Lead image obscures upper part of the article on Android Tablets from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Aug 26 2019, 6:50 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-Bugs
Sharvaniharan moved T231059: Should stay in the theme fitting room after changing theme from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Aug 26 2019, 5:59 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-Bugs
Sharvaniharan moved T231217: Lead image obscures upper part of the article on Android Tablets from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Aug 26 2019, 5:59 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-Bugs
Sharvaniharan moved T231217: Lead image obscures upper part of the article on Android Tablets from Needs Triage to Android-app-release-v2.7.29x-N-Nanaimo-Bar on the Wikipedia-Android-App-Backlog board.
Aug 26 2019, 5:59 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-Bugs
Sharvaniharan claimed T231217: Lead image obscures upper part of the article on Android Tablets.
Aug 26 2019, 5:58 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-Bugs

Aug 23 2019

Sharvaniharan moved T231059: Should stay in the theme fitting room after changing theme from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Aug 23 2019, 3:53 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-Bugs
Sharvaniharan claimed T231059: Should stay in the theme fitting room after changing theme.
Aug 23 2019, 3:52 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-Bugs

Aug 9 2019

Sharvaniharan created T230208: [BUG] Not seeing effect of Font size change during reading.
Aug 9 2019, 2:49 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan created T230203: File page opened from GalleryActivity is expected to return back to GalleryActivity on back-press.
Aug 9 2019, 2:31 PM · Wikipedia-Android-App-Backlog
Sharvaniharan created T230198: mobile-html: Render preview html during editing.
Aug 9 2019, 1:11 PM · Android-app-feature-mobile-html, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.30x-O-Ontbijtkoek)

Aug 6 2019

Sharvaniharan moved T219995: mobile-html article view updates from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Aug 6 2019, 6:21 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.30x-O-Ontbijtkoek), Android-app-feature-mobile-html

Jul 31 2019

Sharvaniharan updated the task description for T229353: Move to MediaList endpoint.
Jul 31 2019, 6:43 PM · Technical-Debt, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Jul 30 2019

Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

@schoenbaechler I found that the root cause for this is that, on Gallery cta, we hide the explicit cta, since we have the edit button, only when there is neither structured nor unstructured caption available. However, we show it when there is an unstructured caption available, but no structured. However, on article cta we show in either case, which i feel is what should be the case. I have created a PR for correcting this logic, but please let me know if we need to do otherwise.
Thank you!

Jul 30 2019, 1:38 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan moved T224728: Add caption CTA on article pages from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.

I have merged it... and I did not completely understand 1) - is it that for any random image which doesn't have a structured caption in primary language, only sometimes the article CTA is shown and other times it is not? - I could not reproduce that.

Jul 30 2019, 6:34 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing

Jul 29 2019

Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

Merged... @schoenbaechler ready for sign-off

Jul 29 2019, 8:57 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan moved T224728: Add caption CTA on article pages from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.

Moved back to design sign-off @schoenbaechler

Jul 29 2019, 6:53 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

Thank you for making this change @cooltey . Appreciate it. Will move it .

Jul 29 2019, 6:39 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing

Jul 26 2019

Sharvaniharan added a comment to T226446: Warn the user to start Wikidata descriptions with lowercase letter in SE.

@schoenbaechler ready for sign-off

Jul 26 2019, 11:40 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Wikipedia-iOS-App-Backlog (Administrative), iOS-app-Bugs, Android-app-feature-Description-Editing
Sharvaniharan moved T226446: Warn the user to start Wikidata descriptions with lowercase letter in SE from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Jul 26 2019, 11:40 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Wikipedia-iOS-App-Backlog (Administrative), iOS-app-Bugs, Android-app-feature-Description-Editing

Jul 25 2019

Sharvaniharan moved T228661: Sunset Nearby from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Jul 25 2019, 6:54 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Technical-Debt
Sharvaniharan claimed T228661: Sunset Nearby.
Jul 25 2019, 6:54 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Technical-Debt
Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

@Charlotte Gauthier @schoenbaechler, we will re-release tomorrow once the design sign-off is done on this ticket, which will also give us some time to keep testing ..

Jul 25 2019, 6:01 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan moved T224728: Add caption CTA on article pages from Did not pass QA to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Jul 25 2019, 5:45 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan added a comment to T228774: [BUG] Media endpoint doesn't returned structured captions for non-English wikis.

Thank you @bearND

Jul 25 2019, 12:37 PM · Page Content Service, Product-Infrastructure-Team-Backlog (Kanban)

Jul 24 2019

Sharvaniharan updated the task description for T228686: mobile-html: Need ability to get text selection info.
Jul 24 2019, 5:11 PM · wikimedia-page-library, Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
Sharvaniharan added a comment to T228686: mobile-html: Need ability to get text selection info.

You are right @bearND. Sorry about that , we don't need the purpose attribute. That is derived natively.

Jul 24 2019, 2:59 PM · wikimedia-page-library, Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

@Charlotte @Sharvaniharan patch for review is linked on the other bug. If that goes through it'd be a better short term solution, but switching to media-list is still the long term solution

Jul 24 2019, 2:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing

Jul 23 2019

Sharvaniharan added a comment to T228774: [BUG] Media endpoint doesn't returned structured captions for non-English wikis.

@JoeWalsh I don't see structured captions in the response. For example for the file File:Billy_Joel_Shankbone_NYC_2009

Jul 23 2019, 6:04 PM · Page Content Service, Product-Infrastructure-Team-Backlog (Kanban)
Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

@Charlotte here is the ticket I have created for RI : https://phabricator.wikimedia.org/T228774

Jul 23 2019, 5:37 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan created T228774: [BUG] Media endpoint doesn't returned structured captions for non-English wikis.
Jul 23 2019, 5:35 PM · Page Content Service, Product-Infrastructure-Team-Backlog (Kanban)
Sharvaniharan updated subscribers of T224728: Add caption CTA on article pages.

@schoenbaechler @Charlotte This is a blocking bug that happens because of an unexpected response from the api returning structured edits. We will have to notify RI team and will be blocked until it is resolved. Great catch @schoenbaechler

Jul 23 2019, 5:25 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

Also, generally when the user is reading the article in secondary language and opens the gallery, but there is no structured caption present in that language, it should fallback to the primary language, or to the unstructured caption in the secondary language.

Jul 23 2019, 1:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan added a comment to T224728: Add caption CTA on article pages.
  1. @schoenbaechler Thank you ..Will fix this.

The green color in the snackbar for action button is a standard across the app in all the places where we use this kind of snackbar. We set it all in just one place. Can I change it so it is color-group-3 for all, or should we leave it green to maintain uniformity, or should this be different?

Jul 23 2019, 1:25 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing

Jul 22 2019

Sharvaniharan updated the task description for T228459: mobile-html: prioritized list of remaining bugs & feature requests.
Jul 22 2019, 6:34 PM · Epic, Product-Infrastructure-Team-Backlog, Page Content Service, Wikipedia-iOS-App-Backlog
Sharvaniharan updated the task description for T228459: mobile-html: prioritized list of remaining bugs & feature requests.
Jul 22 2019, 6:34 PM · Epic, Product-Infrastructure-Team-Backlog, Page Content Service, Wikipedia-iOS-App-Backlog
Sharvaniharan created T228686: mobile-html: Need ability to get text selection info.
Jul 22 2019, 6:33 PM · wikimedia-page-library, Product-Infrastructure-Team-Backlog (Kanban), Page Content Service
Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

@schoenbaechler ready for sign off!

Jul 22 2019, 4:59 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan moved T224728: Add caption CTA on article pages from Did not pass QA to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Jul 22 2019, 4:58 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing

Jul 19 2019

Sharvaniharan updated the task description for T228459: mobile-html: prioritized list of remaining bugs & feature requests.
Jul 19 2019, 5:45 PM · Epic, Product-Infrastructure-Team-Backlog, Page Content Service, Wikipedia-iOS-App-Backlog
Sharvaniharan added a project to T228536: Need Filename info in interaction "data" for "image_clicked": wikimedia-page-library.
Jul 19 2019, 5:44 PM · Product-Infrastructure-Team-Backlog (Kanban), wikimedia-page-library
Sharvaniharan created T228536: Need Filename info in interaction "data" for "image_clicked".
Jul 19 2019, 5:43 PM · Product-Infrastructure-Team-Backlog (Kanban), wikimedia-page-library