Page MenuHomePhabricator

Sharvaniharan (Sharvaniharan)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 23 2017, 3:03 PM (103 w, 3 d)
Availability
Available
LDAP User
Sharvaniharan
MediaWiki User
SHaran (WMF) [ Global Accounts ]

Recent Activity

Fri, Aug 9

Sharvaniharan created T230208: [BUG] Not seeing effect of Font size change during reading.
Fri, Aug 9, 2:49 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)
Sharvaniharan created T230203: File page opened from GalleryActivity is expected to return back to GalleryActivity on back-press.
Fri, Aug 9, 2:31 PM · Wikipedia-Android-App-Backlog
Sharvaniharan created T230198: mobile-html: Render preview html during editing.
Fri, Aug 9, 1:11 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Tue, Aug 6

Sharvaniharan moved T219995: mobile-html article view updates from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Tue, Aug 6, 6:21 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-mobile-html

Wed, Jul 31

Sharvaniharan updated the task description for T229353: Move to MediaList endpoint.
Wed, Jul 31, 6:43 PM · Technical-Debt, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Tue, Jul 30

Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

@schoenbaechler I found that the root cause for this is that, on Gallery cta, we hide the explicit cta, since we have the edit button, only when there is neither structured nor unstructured caption available. However, we show it when there is an unstructured caption available, but no structured. However, on article cta we show in either case, which i feel is what should be the case. I have created a PR for correcting this logic, but please let me know if we need to do otherwise.
Thank you!

Tue, Jul 30, 1:38 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan moved T224728: Add caption CTA on article pages from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.

I have merged it... and I did not completely understand 1) - is it that for any random image which doesn't have a structured caption in english, only sometimes the article CTA is shown and other times it is not? - I could not reproduce that.

Tue, Jul 30, 6:34 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing

Mon, Jul 29

Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

Merged... @schoenbaechler ready for sign-off

Mon, Jul 29, 8:57 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan moved T224728: Add caption CTA on article pages from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.

Moved back to design sign-off @schoenbaechler

Mon, Jul 29, 6:53 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

Thank you for making this change @cooltey . Appreciate it. Will move it .

Mon, Jul 29, 6:39 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing

Fri, Jul 26

Sharvaniharan added a comment to T226446: Warn the user to start Wikidata descriptions with lowercase letter in SE.

@schoenbaechler ready for sign-off

Fri, Jul 26, 11:40 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Wikipedia-iOS-App-Backlog (Administrative), iOS-app-Bugs, Android-app-feature-Description-Editing
Sharvaniharan moved T226446: Warn the user to start Wikidata descriptions with lowercase letter in SE from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Fri, Jul 26, 11:40 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Wikipedia-iOS-App-Backlog (Administrative), iOS-app-Bugs, Android-app-feature-Description-Editing

Thu, Jul 25

Sharvaniharan moved T228661: Sunset Nearby from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Thu, Jul 25, 6:54 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Technical-Debt
Sharvaniharan claimed T228661: Sunset Nearby.
Thu, Jul 25, 6:54 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Technical-Debt
Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

@Charlotte Gauthier @schoenbaechler, we will re-release tomorrow once the design sign-off is done on this ticket, which will also give us some time to keep testing ..

Thu, Jul 25, 6:01 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan moved T224728: Add caption CTA on article pages from Did not pass QA to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Thu, Jul 25, 5:45 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan added a comment to T228774: [BUG] Media endpoint doesn't returned structured captions for non-English wikis.

Thank you @bearND

Thu, Jul 25, 12:37 PM · Page Content Service, Reading-Infrastructure-Team-Backlog (Kanban)

Wed, Jul 24

Sharvaniharan updated the task description for T228686: mobile-html: Need ability to get text selection info.
Wed, Jul 24, 5:11 PM · wikimedia-page-library, Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service
Sharvaniharan added a comment to T228686: mobile-html: Need ability to get text selection info.

You are right @bearND. Sorry about that , we don't need the purpose attribute. That is derived natively.

Wed, Jul 24, 2:59 PM · wikimedia-page-library, Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service
Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

@Charlotte @Sharvaniharan patch for review is linked on the other bug. If that goes through it'd be a better short term solution, but switching to media-list is still the long term solution

Wed, Jul 24, 2:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing

Tue, Jul 23

Sharvaniharan added a comment to T228774: [BUG] Media endpoint doesn't returned structured captions for non-English wikis.

@JoeWalsh I don't see structured captions in the response. For example for the file File:Billy_Joel_Shankbone_NYC_2009

Tue, Jul 23, 6:04 PM · Page Content Service, Reading-Infrastructure-Team-Backlog (Kanban)
Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

@Charlotte here is the ticket I have created for RI : https://phabricator.wikimedia.org/T228774

Tue, Jul 23, 5:37 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan created T228774: [BUG] Media endpoint doesn't returned structured captions for non-English wikis.
Tue, Jul 23, 5:35 PM · Page Content Service, Reading-Infrastructure-Team-Backlog (Kanban)
Sharvaniharan updated subscribers of T224728: Add caption CTA on article pages.

@schoenbaechler @Charlotte This is a blocking bug that happens because of an unexpected response from the api returning structured edits. We will have to notify RI team and will be blocked until it is resolved. Great catch @schoenbaechler

Tue, Jul 23, 5:25 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

Also, generally when the user is reading the article in secondary language and opens the gallery, but there is no structured caption present in that language, it should fallback to the primary language, or to the unstructured caption in the secondary language.

Tue, Jul 23, 1:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan added a comment to T224728: Add caption CTA on article pages.
  1. @schoenbaechler Thank you ..Will fix this.

The green color in the snackbar for action button is a standard across the app in all the places where we use this kind of snackbar. We set it all in just one place. Can I change it so it is color-group-3 for all, or should we leave it green to maintain uniformity, or should this be different?

Tue, Jul 23, 1:25 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing

Mon, Jul 22

Sharvaniharan updated the task description for T228459: mobile-html: prioritized list of remaining bugs & feature requests.
Mon, Jul 22, 6:34 PM · Epic, Reading-Infrastructure-Team-Backlog, Page Content Service, Wikipedia-iOS-App-Backlog
Sharvaniharan updated the task description for T228459: mobile-html: prioritized list of remaining bugs & feature requests.
Mon, Jul 22, 6:34 PM · Epic, Reading-Infrastructure-Team-Backlog, Page Content Service, Wikipedia-iOS-App-Backlog
Sharvaniharan created T228686: mobile-html: Need ability to get text selection info.
Mon, Jul 22, 6:33 PM · wikimedia-page-library, Reading-Infrastructure-Team-Backlog (Kanban), Page Content Service
Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

@schoenbaechler ready for sign off!

Mon, Jul 22, 4:59 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan moved T224728: Add caption CTA on article pages from Did not pass QA to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Mon, Jul 22, 4:58 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing

Fri, Jul 19

Sharvaniharan updated the task description for T228459: mobile-html: prioritized list of remaining bugs & feature requests.
Fri, Jul 19, 5:45 PM · Epic, Reading-Infrastructure-Team-Backlog, Page Content Service, Wikipedia-iOS-App-Backlog
Sharvaniharan added a project to T228536: Need Filename info in interaction "data" for "image_clicked": wikimedia-page-library.
Fri, Jul 19, 5:44 PM · Reading-Infrastructure-Team-Backlog (Kanban), wikimedia-page-library
Sharvaniharan created T228536: Need Filename info in interaction "data" for "image_clicked".
Fri, Jul 19, 5:43 PM · Reading-Infrastructure-Team-Backlog (Kanban), wikimedia-page-library
Sharvaniharan created T228535: Add "title" and "text" to link_clicked interaction.
Fri, Jul 19, 5:37 PM · Reading-Infrastructure-Team-Backlog (Kanban), wikimedia-page-library

Jul 18 2019

Sharvaniharan moved T224728: Add caption CTA on article pages from Did not pass QA to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Jul 18 2019, 12:07 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing

Jul 17 2019

Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

ok @schoenbaechler @Charlotte . will do that. will be visible to all logged in users

Jul 17 2019, 2:14 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing

Jul 16 2019

Sharvaniharan added a comment to T224728: Add caption CTA on article pages.

Not quite sure why this hasn’t been moved to Design signoff first as there are obviously issues with it @Sharvaniharan ?

Jul 16 2019, 6:27 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing

Jul 10 2019

Sharvaniharan moved T224728: Add caption CTA on article pages from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jul 10 2019, 4:06 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan moved T223130: Bottom sheet popup for adding/translating/editing image captions from QA signoff to Did not pass QA on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jul 10 2019, 3:43 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Jul 9 2019

Sharvaniharan moved T226118: [BUG] In image caption editing, some links on the file page are not clickable, but they appear to be from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jul 9 2019, 6:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
Sharvaniharan moved T224728: Add caption CTA on article pages from QA signoff to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jul 9 2019, 6:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan moved T224728: Add caption CTA on article pages from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jul 9 2019, 6:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan moved T219995: mobile-html article view updates from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar) board.
Jul 9 2019, 2:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-mobile-html

Jul 8 2019

Sharvaniharan claimed T219995: mobile-html article view updates.
Jul 8 2019, 5:02 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-mobile-html
Sharvaniharan added a comment to T224789: Deep link action should open a new tab.

@schoenbaechler The system back button only works on a fresh launch as expected. I feel that it will be too much code to maintain, in order to detect a deep-link launch and behave differently. Posting this video so you are aware of a non-fresh launch:
https://youtu.be/y78VDTH043g

Jul 8 2019, 7:13 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T226291: [BUG] Reading list syncing issue from Doing to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jul 8 2019, 6:40 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan updated subscribers of T226291: [BUG] Reading list syncing issue.

Verified that this is no more an issue. This was a server-side issue only, as discussed on this thread on slack : https://wikimedia.slack.com/archives/C7P3N5E6P/p1561662568069200 which iOS also observed, and is now resolved. I will still move it to QA just for confirmation.

Jul 8 2019, 6:39 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T226118: [BUG] In image caption editing, some links on the file page are not clickable, but they appear to be from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jul 8 2019, 5:36 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
Sharvaniharan moved T226291: [BUG] Reading list syncing issue from Blocked/Waiting to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jul 8 2019, 5:36 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T226291: [BUG] Reading list syncing issue from Ready for dev to Blocked/Waiting on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jul 8 2019, 5:36 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan claimed T226291: [BUG] Reading list syncing issue.
Jul 8 2019, 5:36 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Jul 3 2019

Sharvaniharan moved T224600: Create Explore feed cards for add/translate image captions from Did not pass QA to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jul 3 2019, 9:26 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Sharvaniharan moved T218201: Explore new ways to display content instead of showing placeholder images from Did not pass QA to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jul 3 2019, 9:26 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt

Jun 27 2019

Sharvaniharan added a comment to T218201: Explore new ways to display content instead of showing placeholder images.

Thanks for discussing this today morning @schoenbaechler :-) As discussed on call, 1 and 2 will be fixed and I was able to just change background colors conditionally per theme. However, 3 is just how the recyclerview draws with clipped padding.

Jun 27 2019, 10:10 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Sharvaniharan added a comment to T224600: Create Explore feed cards for add/translate image captions.

ok @schoenbaechler . will remove date altogether.

Jun 27 2019, 9:15 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Sharvaniharan moved T223130: Bottom sheet popup for adding/translating/editing image captions from Did not pass QA to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 27 2019, 9:14 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Sharvaniharan moved T225874: Wikipedia - mobile app for Android - translate languages from Did not pass QA to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 27 2019, 9:13 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Jun 26 2019

Sharvaniharan added a comment to T225874: Wikipedia - mobile app for Android - translate languages.

ok will make changes according to Robin's comments.

Jun 26 2019, 9:18 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan updated subscribers of T225874: Wikipedia - mobile app for Android - translate languages.
Jun 26 2019, 5:17 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan added a comment to T225874: Wikipedia - mobile app for Android - translate languages.

Hi @Patriccck ... We maintain a list of localized names for all languages in the app. So if the system language is čeština, you would have the strings reading like this:

Jun 26 2019, 4:50 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Jun 25 2019

Sharvaniharan moved T226118: [BUG] In image caption editing, some links on the file page are not clickable, but they appear to be from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 25 2019, 9:05 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
Sharvaniharan claimed T226118: [BUG] In image caption editing, some links on the file page are not clickable, but they appear to be.
Jun 25 2019, 7:36 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-Bugs
Sharvaniharan moved T225874: Wikipedia - mobile app for Android - translate languages from Doing to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 25 2019, 4:36 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T224600: Create Explore feed cards for add/translate image captions from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 25 2019, 4:36 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Jun 24 2019

Sharvaniharan claimed T225874: Wikipedia - mobile app for Android - translate languages.
Jun 24 2019, 10:32 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T218201: Explore new ways to display content instead of showing placeholder images from Did not pass QA to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 24 2019, 7:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Sharvaniharan moved T224728: Add caption CTA on article pages from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 24 2019, 5:04 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing

Jun 22 2019

Sharvaniharan renamed T226291: [BUG] Reading list syncing issue from reading list syncing issue to Reading list syncing issue.
Jun 22 2019, 12:16 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan created T226291: [BUG] Reading list syncing issue.
Jun 22 2019, 12:16 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan created T226290: [BUG] Images not saved when article saved for offline reading.
Jun 22 2019, 12:10 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Jun 20 2019

Sharvaniharan moved T222946: mobile-html: investigate the page/metadata endpoint from Doing to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 20 2019, 3:17 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Spike

Jun 13 2019

Sharvaniharan moved T224728: Add caption CTA on article pages from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 13 2019, 6:56 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing
Sharvaniharan claimed T224728: Add caption CTA on article pages.
Jun 13 2019, 3:48 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), Android-app-feature-Description-Editing

Jun 12 2019

Sharvaniharan moved T224600: Create Explore feed cards for add/translate image captions from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 12 2019, 11:25 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Sharvaniharan moved T224709: Clean-up test-only code for showing bottom sheet from QA signoff to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 12 2019, 11:25 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T224709: Clean-up test-only code for showing bottom sheet from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 12 2019, 11:25 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T223130: Bottom sheet popup for adding/translating/editing image captions from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 12 2019, 11:25 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Sharvaniharan moved T222946: mobile-html: investigate the page/metadata endpoint from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 12 2019, 11:24 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Spike
Sharvaniharan claimed T222946: mobile-html: investigate the page/metadata endpoint.
Jun 12 2019, 11:23 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Spike

Jun 11 2019

Sharvaniharan added a comment to T218050: mobile-html: allow clients to adjust tables.

Same on android @bearND . We use it while loading the leas section as a meta preference.:
https://github.com/wikimedia/apps-android-wikipedia/blob/master/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java#L412
Further we have a native transform for it.

Jun 11 2019, 4:27 PM · Reading-Infrastructure-Team-Backlog, Page Content Service

Jun 10 2019

Sharvaniharan added a comment to T218201: Explore new ways to display content instead of showing placeholder images.

@schoenbaechler the news item ellipsis that we discussed this morning, is the only change pending. Otherwise ready for review.

Jun 10 2019, 11:04 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Sharvaniharan moved T218201: Explore new ways to display content instead of showing placeholder images from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 10 2019, 11:02 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Sharvaniharan moved T224709: Clean-up test-only code for showing bottom sheet from Blocked/Waiting to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 10 2019, 11:01 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Jun 4 2019

Sharvaniharan claimed T224600: Create Explore feed cards for add/translate image captions.
Jun 4 2019, 5:26 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Sharvaniharan added a comment to T218201: Explore new ways to display content instead of showing placeholder images.

@schoenbaechler I have removed page item view is also used in page bottom content, so when I remove the placeholder image, it looks like this :

Jun 4 2019, 5:18 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt

Jun 3 2019

Sharvaniharan added a comment to T223130: Bottom sheet popup for adding/translating/editing image captions.

Thank you @schoenbaechler :) Will do that..

Jun 3 2019, 5:06 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Sharvaniharan moved T219651: Design recommendations for “Add/translate descriptions“ from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Jun 3 2019, 4:26 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Sharvaniharan placed T182716: Users should be able to swipe left and right in the 'On this day' calendar view up for grabs.

@VeghTomi Please do. I have unassigned myself. Thank you :-)

Jun 3 2019, 4:22 PM · Wikipedia-Android-App-Backlog, Android-app-feature-UX-Debt, Reading Epics (Feed 2.0)
Sharvaniharan added a comment to T223130: Bottom sheet popup for adding/translating/editing image captions.

There’s only one right now: “Go to file page”. The reason why it’s hidden in the overflow menu is we don’t want to promote it since it’s not optimized (coming in V2: T223132). I’m thinking about a more prominent button at the bottom for V2.

Jun 3 2019, 4:20 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

May 31 2019

Sharvaniharan moved T223130: Bottom sheet popup for adding/translating/editing image captions from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
May 31 2019, 3:11 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Sharvaniharan added a comment to T224709: Clean-up test-only code for showing bottom sheet.

Blocked until the DescriptionEditView logic is solidified to support image caption edits

May 31 2019, 3:11 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan claimed T224709: Clean-up test-only code for showing bottom sheet.
May 31 2019, 3:10 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan created T224709: Clean-up test-only code for showing bottom sheet.
May 31 2019, 3:10 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan added a comment to T223130: Bottom sheet popup for adding/translating/editing image captions.

@schoenbaechler couple questions...
1.what are the options on the overflow menu?
2.The toolbar scrolls with the dialog as it is not a separate activity and cannot behave like a regular screens' toolbar. Is that ok?

May 31 2019, 3:04 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

May 29 2019

Kaartic awarded T223159: Navigation redesign of the Commons Android app a Love token.
May 29 2019, 3:54 PM · Commons-App-Android, Wikimedia-Hackathon-2019

May 28 2019

Sharvaniharan moved T217373: Create feed card for suggested edits and update iconography from Did not pass QA to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
May 28 2019, 4:45 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T218201: Explore new ways to display content instead of showing placeholder images from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
May 28 2019, 4:44 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt

May 22 2019

Sharvaniharan moved T223130: Bottom sheet popup for adding/translating/editing image captions from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
May 22 2019, 8:58 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Sharvaniharan claimed T223130: Bottom sheet popup for adding/translating/editing image captions.
May 22 2019, 4:07 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing