Sharvaniharan (Sharvaniharan)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Aug 23 2017, 3:03 PM (47 w, 2 d)
Availability
Available
LDAP User
Sharvaniharan
MediaWiki User
Unknown

Recent Activity

Yesterday

Sharvaniharan moved T197705: Visual design updates to the Explore feed and bottom navigation bar for the "Explicit reading" mode from Doing to Code Review on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.
Fri, Jul 20, 1:48 PM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan claimed T197705: Visual design updates to the Explore feed and bottom navigation bar for the "Explicit reading" mode.
Fri, Jul 20, 11:25 AM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation

Thu, Jul 19

Sharvaniharan moved T197705: Visual design updates to the Explore feed and bottom navigation bar for the "Explicit reading" mode from Ready for dev to Doing on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.
Thu, Jul 19, 8:16 PM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan moved T197703: Merge page activity to main activity from Doing to Code Review on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.
Thu, Jul 19, 3:48 PM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan moved T197100: Remove Explore feed overflow and place options in a side drawer from Doing to Code Review on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.
Thu, Jul 19, 3:48 PM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation, Epic

Mon, Jul 16

Sharvaniharan claimed T197100: Remove Explore feed overflow and place options in a side drawer.
Mon, Jul 16, 4:05 PM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation, Epic

Tue, Jul 10

Sharvaniharan moved T172283: Improve the ease of viewing individual citations references grouped together from Blocked/Waiting to Ready for dev on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.
Tue, Jul 10, 1:19 PM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Patch-For-Review, Android-app-feature-UX-Debt

Sun, Jul 1

Sharvaniharan removed projects from T197811: Add floating queue element: TCB-Team, Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, JADE, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Sun, Jul 1, 6:19 AM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan renamed T193275: PCS Media endpoint for Android from k2daaaaaaa to PCS Media endpoint for Android.
Sun, Jul 1, 6:18 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Reading-Infrastructure-Team-Backlog
Sharvaniharan renamed T193277: PCS CSS endpoint for Android from i2daaaaaaa to PCS CSS endpoint for Android .
Sun, Jul 1, 6:07 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Reading-Infrastructure-Team-Backlog
Sharvaniharan renamed T195608: renamed this task from [BUG] Editing view has incorrect styling from r9baaaaaaa to renamed this task from [BUG] Editing view has incorrect styling.
Sun, Jul 1, 6:04 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Patch-For-Review, Android-app-Bugs
Sharvaniharan renamed T197479: [BUG] Section parsing bug on https://en.wikipedia.org/wiki/Chiang Kai-shek from staaaaaaaa to [BUG] Section parsing bug on https://en.wikipedia.org/wiki/Chiang Kai-shek .
Sun, Jul 1, 6:00 AM · Reading-Infrastructure-Team-Backlog (Kanban), Parsoid, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-Bugs
Sharvaniharan renamed T197100: Remove Explore feed overflow and place options in a side drawer from b4aaaaaaaa to Remove Explore feed overflow and place options in a side drawer.
Sun, Jul 1, 5:52 AM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation, Epic
Sharvaniharan renamed T197705: Visual design updates to the Explore feed and bottom navigation bar for the "Explicit reading" mode from inaaaaaaaa to Visual design updates to the Explore feed and bottom navigation bar for the "Explicit reading" mode.
Sun, Jul 1, 5:49 AM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan lowered the priority of T197705: Visual design updates to the Explore feed and bottom navigation bar for the "Explicit reading" mode from High to Normal.
Sun, Jul 1, 5:48 AM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan renamed T197809: Update the article view's top toolbar elements in the "Explicit reading mode" prototype from mkaaaaaaaa to Update the article view's top toolbar elements in the "Explicit reading mode" prototype.
Sun, Jul 1, 5:47 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan renamed T197812: Visual design updates to the Explore feed and "Add floating queue element" mode from jkaaaaaaaa to Visual design updates to the Explore feed and "Add floating queue element" mode.
Sun, Jul 1, 5:45 AM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan renamed T197814: Update the article view's top and bottom toolbar elements (prototype 1) from hkaaaaaaaa to Update the article view's top and bottom toolbar elements.
Sun, Jul 1, 5:40 AM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan renamed T197704: UI changes to incorporate Search and Article reading into the bottom navigation bar from jnaaaaaaaa to UI changes to incorporate Search and Article reading into the bottom navigation bar .
Sun, Jul 1, 5:39 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan renamed T197808: Update the article view in the Explicit reading mode" prototype from nkaaaaaaaa to Update the article view in the Explicit reading mode" prototype.
Sun, Jul 1, 5:37 AM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan renamed T197813: Add an additional option on link previews to "Open in new tab" from ikaaaaaaaa to Add an additional option on link previews to "Open in new tab".
Sun, Jul 1, 5:35 AM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan renamed T195264: [EPIC] Improve app and article navigation from bjcaaaaaaa to [EPIC] Improve app and article navigation.
Sun, Jul 1, 5:28 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation, Epic
Sharvaniharan renamed T195335: Create a prototype to test an "Article Queue" app navigation concept from chcaaaaaaa to Create a prototype to test an "Article Queue" app navigation concept.
Sun, Jul 1, 5:25 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation, Epic
Sharvaniharan renamed T196372: Create a prototype to test an "Explicit reading mode" app and article navigation concept from jobaaaaaaa to Create a prototype to test an "Explicit reading mode" app and article navigation concept.
Sun, Jul 1, 5:24 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation, Epic
Sharvaniharan renamed T196398: Perform user testing on android navigation prototype concepts from tnbaaaaaaa to Perform user testing on android navigation prototype concepts.
Sun, Jul 1, 5:18 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan renamed T197178: Perform second round of usability testing on the final android navigation design from 51aaaaaaaa to Perform second round of usability testing on the final android navigation design.
Sun, Jul 1, 5:15 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan renamed T197181: Implement Analytics/Event logging instrumentation to measure final app updates from 21aaaaaaaa to Implement Analytics/Event logging instrumentation to measure final app updates.
Sun, Jul 1, 5:14 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan renamed T197182: Create project page for the App and Article navigation improvements project on Mediawiki from 11aaaaaaaa to Create project page for the App and Article navigation improvements project on Mediawiki .
Sun, Jul 1, 5:12 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan lowered the priority of T197880: Conduct user testing of the Wikitext keyboard prototype from High to Normal.
Sun, Jul 1, 5:09 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Design
Sharvaniharan renamed T197880: Conduct user testing of the Wikitext keyboard prototype from niaaaaaaaa to Conduct user testing of the Wikitext keyboard prototype.
Sun, Jul 1, 5:09 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Design
Sharvaniharan renamed T193478: Some audio files not playing in the app from xwdaaaaaaa to Some audio files not playing in the app.
Sun, Jul 1, 5:06 AM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-Bugs
Sharvaniharan renamed T193184: Maintain all the times an article is accessed in History instead of just the most recent accessed date from 34daaaaaaa to Maintain all the times an article is accessed in History instead of just the most recent accessed date.
Sun, Jul 1, 5:04 AM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake)
Sharvaniharan renamed T193027: Add a download on WiFi only setting for reading list users from g9daaaaaaa to Add a download on WiFi only setting for reading list users.
Sun, Jul 1, 5:02 AM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Reading Epics (Synchronized Reading Lists)
Sharvaniharan updated subscribers of T197703: Merge page activity to main activity.
Sun, Jul 1, 4:45 AM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan renamed T197703: Merge page activity to main activity from knaaaaaaaa to Merge page activity to main activity.
Sun, Jul 1, 4:43 AM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan renamed T197811: Add floating queue element from kkaaaaaaaa to Add floating queue element.
Sun, Jul 1, 4:28 AM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan assigned T197811: Add floating queue element to cooltey.
Sun, Jul 1, 4:28 AM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation

Thu, Jun 28

Sharvaniharan moved T164957: Show complete license info for images shown in full screen from Doing to Code Review on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.
Thu, Jun 28, 2:38 PM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake)

Mon, Jun 25

Sharvaniharan claimed T197703: Merge page activity to main activity.
Mon, Jun 25, 3:51 PM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan moved T197703: Merge page activity to main activity from Backlog to Doing on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.
Mon, Jun 25, 3:51 PM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan edited projects for T197808: Update the article view in the Explicit reading mode" prototype, added: Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake); removed Wikipedia-Android-App-Backlog.
Mon, Jun 25, 12:33 PM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan edited projects for T197704: UI changes to incorporate Search and Article reading into the bottom navigation bar , added: Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake); removed Wikipedia-Android-App-Backlog.
Mon, Jun 25, 12:29 PM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation
Sharvaniharan edited projects for T197703: Merge page activity to main activity, added: Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake); removed Wikipedia-Android-App-Backlog.
Mon, Jun 25, 12:28 PM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Android-app-feature-Navigation

Thu, Jun 21

Sharvaniharan closed T141292: [BUG] Many languages only get 2 cards per Feed network request as Invalid.

@RHo @Charlotte It is happening in some languages like Italian, because thats the number of cards available per refresh/load. So closing this.

Thu, Jun 21, 6:25 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual, Android-app-feature-Feeds
Sharvaniharan moved T190931: Implement Analytics/Event logging instrumentation to measure new multilingual features from Code Review to Ready for signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Thu, Jun 21, 4:51 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual

Jun 18 2018

This is a test notification, sent at Mon, Jun 18, 11:16 AM.
Jun 18 2018, 6:16 PM

Jun 15 2018

Sharvaniharan moved T164957: Show complete license info for images shown in full screen from Backlog to Doing on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.
Jun 15 2018, 7:33 PM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake)
Sharvaniharan claimed T164957: Show complete license info for images shown in full screen.
Jun 15 2018, 7:33 PM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake)
Sharvaniharan moved T172283: Improve the ease of viewing individual citations references grouped together from Backlog to Blocked/Waiting on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.
Jun 15 2018, 2:37 PM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Patch-For-Review, Android-app-feature-UX-Debt
Sharvaniharan added a comment to T190931: Implement Analytics/Event logging instrumentation to measure new multilingual features .

@mpopov you should be seeing this from patch set 18:

Jun 15 2018, 2:17 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual

Jun 12 2018

Sharvaniharan moved T196783: Rename appInstallID, ts, sessionToken, timeSpent/duration property names in EL schemas from Doing to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Jun 12 2018, 10:09 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly)
Sharvaniharan moved T190931: Implement Analytics/Event logging instrumentation to measure new multilingual features from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Jun 12 2018, 10:09 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan moved T194958: [BUG] Empty state illustrations on Reading lists and History moving when search is triggered from Did not pass QA to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Jun 12 2018, 10:09 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-Bugs
Sharvaniharan moved T195909: Add a ‘customize by language’ option on the overflow menu of relevant cards in the feed itself from Did not pass QA to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Jun 12 2018, 10:09 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan moved T194958: [BUG] Empty state illustrations on Reading lists and History moving when search is triggered from Code Review to Did not pass QA on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Jun 12 2018, 10:09 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-Bugs
Sharvaniharan moved T195909: Add a ‘customize by language’ option on the overflow menu of relevant cards in the feed itself from Code Review to Did not pass QA on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Jun 12 2018, 10:08 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan added a comment to T190931: Implement Analytics/Event logging instrumentation to measure new multilingual features .
  • (B) Or send just one event with multilingual data. Since enabledList and orderList can be arbitrary strings, they could be JSON representations with the lists of values for each language. For example, orderList could have the value of {"en":[0,1,2,3,4,5,6,7,8],"de":[8,7,6,5,4,3,2,1,0]}. Then languages would be the JSON array of languages in the order they're set – e.g. ["de","en"] (notice that is where we have to make sure to have the correct order, the array in the enabledList & orderList fields can have any order) -- I would prefer if the instrumentation implemented this approach.
Jun 12 2018, 4:43 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual

Jun 11 2018

Sharvaniharan added a comment to T196783: Rename appInstallID, ts, sessionToken, timeSpent/duration property names in EL schemas.

@mpopov We will not be sending anymore events to MobileWikiAppOfflineLibrary. All Offline Library related code has been removed.

Jun 11 2018, 10:30 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly)
Sharvaniharan added a comment to T190931: Implement Analytics/Event logging instrumentation to measure new multilingual features .

@Sharvaniharan: I just remembered the analytics for the feed! I've updated the MobileWikiAppFeed schema (Revision 18115458) to include a language field, which should contain a language code for action = 'cardShown' and action = 'cardClicked' events. Also ,per T196783, the following field names have been renamed:

Jun 11 2018, 9:14 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan added a comment to T190931: Implement Analytics/Event logging instrumentation to measure new multilingual features .
  1. Is one delete one interaction count or one count per language deleted

One interaction count. This also brings up the question of how to treat non-modifying interactions (going into remove languages mode or going into add language mode and backing out).

  • Option 1: ignore them and don't increment interaction counter unless user added/removed languages
  • Option 2: increment interaction counter either way

    @Sharvaniharan @Dbrant and I will discuss this later today.
Jun 11 2018, 8:50 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual

Jun 8 2018

Sharvaniharan moved T196783: Rename appInstallID, ts, sessionToken, timeSpent/duration property names in EL schemas from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Jun 8 2018, 11:14 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly)
Sharvaniharan added a comment to T196783: Rename appInstallID, ts, sessionToken, timeSpent/duration property names in EL schemas.

@mpopov also the timeSpent property please. Shoudl it be 'duration' from now on?

Jun 8 2018, 11:06 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly)
Sharvaniharan added a comment to T190931: Implement Analytics/Event logging instrumentation to measure new multilingual features .

Thanks for this Mikhail! Here are a few questions:

  1. Is one delete one interaction count or one count per language deleted
  2. What is the searched boolean in MobileWikiAppLanguageSettings keeping track of?
  3. Are we no longer tracking rearrange, search_cancelled, other than counting them as interactions? [They can be deduced, but they aren't getting logged as their own events within the parent event]
Jun 8 2018, 8:07 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual

Jun 6 2018

Sharvaniharan added a comment to T190931: Implement Analytics/Event logging instrumentation to measure new multilingual features .

No problem! will look forward to your updates!

Jun 6 2018, 5:33 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan moved T192397: [UX-debt] Improve visual design of "Recent searches" in Search from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Jun 6 2018, 8:35 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-UX-Debt
Sharvaniharan added a comment to T195894: Show warning if both ZH variants are added to app languages by default.

@RHo @cooltey not sure if this need a design review since it is only a dialog, but feel free to move it around. Merged and available on alpha.

Jun 6 2018, 8:34 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Chinese-Sites, Android-app-feature-Multilingual
Sharvaniharan moved T195894: Show warning if both ZH variants are added to app languages by default from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Jun 6 2018, 8:33 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Chinese-Sites, Android-app-feature-Multilingual
Sharvaniharan added a comment to T169314: Allow user to save articles from their mobile browser to the Wikipedia Android app.

@RHo I remember you signing off on the expected behavior on this ... please feel free to move it to design sign off and review it, if I am wrong.. This has passed code review and has been merged, so needs to be in one of the sign off columns

Jun 6 2018, 8:32 AM · Wikipedia-Android-App-Backlog
Sharvaniharan moved T169314: Allow user to save articles from their mobile browser to the Wikipedia Android app from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Jun 6 2018, 8:31 AM · Wikipedia-Android-App-Backlog
Sharvaniharan moved T141587: Changing app language does not automatically update the explore feed language from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Jun 6 2018, 8:29 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual, Android-app-Bugs
Sharvaniharan moved T187549: App should cache data about feed content availability per language from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Jun 6 2018, 8:27 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual, Chinese-Sites, Android-app-feature-Feeds, Android-app-feature-UX-Debt
Sharvaniharan moved T194958: [BUG] Empty state illustrations on Reading lists and History moving when search is triggered from Code Review to QA signoff on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.
Jun 6 2018, 8:04 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-Bugs
Sharvaniharan moved T172283: Improve the ease of viewing individual citations references grouped together from Code Review to Blocked/Waiting on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Jun 6 2018, 8:02 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Patch-For-Review, Android-app-feature-UX-Debt

Jun 5 2018

Sharvaniharan added a comment to T190931: Implement Analytics/Event logging instrumentation to measure new multilingual features .

Thanks for the excellent feedback @Sharvaniharan & @RHo! Additional recommendations per our discussion:

Language selection funnel will need to be re-instrumented to replace MobileWikiAppLangSelect with MobileWikiAppLanguageSettings.

That schema has a generic extras field that would include additional info depending on context (action):

  • In case of action = 'start', extras would have the source from which the language selection dialog was initiated:
    • "settings"
    • "search" (the "More" button when searching)
    • "onboarding"
  • In case of action = 'search':
    • extras is "<cancelled>" if user backs out without typing anything in the search bar
    • extras is the search string if user searches for a language but doesn't add and just backs out (e.g. "Spanglish")
    • extras is "<added> if user concludes interaction with searching for languages by adding a language they found

Just to be clear here... we are only mentioning 'added', and not which language was added?

  • In case of action = 'add', extras depends on whether they actually added any languages
    • If user didn't add any languages (change of mind or they searched for a language and didn't find the one they were looking for), we just set extras to "<cancelled>"
    • If user did add a new language, we use the language code. For example, if user currently has English & French and they add Spanish, extras is "es"
    • This event may be triggered either by user finding the language in list OR if they search for a language by tapping the magnifying glass + type the name of language + tap the language
  • In case of action = 'arrange', extras would have a JSON array of the new order of languages
    • So if user has languages "English" "French" "Spanish" and they make Spanish first, the string would be ["es","en","fr"]

Do we not want the old order here? something like ["en',"fr","es"] => ["es","en","fr"]

  • In case of action = 'remove', extras would have a JSON array of removed languages
    • So if user removed English and French and just left Spanish, extras would look like ["en","fr"]
  • In case of action = 'back', extras is a JSON array of languages the user ended up with.
    • So in the case of the user I've been using in examples above, extras would be ["es"]

Just confirming... This is triggered on exit of the add language screen, in all 3 scenarios - search, onboarding and settings?

  • For this funnel I think the sampling rate should be 100%
Jun 5 2018, 7:24 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual

Jun 1 2018

Sharvaniharan added a comment to T172283: Improve the ease of viewing individual citations references grouped together.

Thanks @RHo.

Jun 1 2018, 6:49 PM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Patch-For-Review, Android-app-feature-UX-Debt
Sharvaniharan added a comment to M224: Android Citation pane.

@RHo changes are complete and a patch is available for review here : https://gerrit.wikimedia.org/r/#/c/433915/.
However, since the supporting page library PR is still not merged and published, you will not be able to verify it by checking out the patch and running as-is. So, just to get us started I have taken a few key screenshots here : https://drive.google.com/open?id=1RiL4-5kylhHps4-PHfFE_4zDcxt_XYLL . Please let me know if they need any design changes. Also, a question:
I am using the material_theme_shadow color theme for the unselected dot indicators at the bottom, which is : light: black26, dark: base10, and black: base10. However, it looks different from the zeplin mock. It looks like whte40? which we don't have in our palette at all. However, I used that and took one screenshot: https://drive.google.com/open?id=1fNAlg4zCJMD9eN67Yl07dQyLOqDOOGwU which looks like the mock. So just wondering what it should be?

Jun 1 2018, 5:48 PM
Sharvaniharan updated subscribers of T190931: Implement Analytics/Event logging instrumentation to measure new multilingual features .

@mpopov some things we are not taking care of :

Jun 1 2018, 6:42 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual

May 31 2018

Sharvaniharan moved T190931: Implement Analytics/Event logging instrumentation to measure new multilingual features from Blocked/Waiting to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
May 31 2018, 5:13 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan moved T172283: Improve the ease of viewing individual citations references grouped together from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
May 31 2018, 5:13 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Patch-For-Review, Android-app-feature-UX-Debt

May 29 2018

Sharvaniharan moved T192534: Missing Save this article bookmark on "Read more" section of article footer from Ready for dev to Code Review on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.
May 29 2018, 7:33 PM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake)
Sharvaniharan added a comment to T192534: Missing Save this article bookmark on "Read more" section of article footer.

@RHo this is ready for review here : https://gerrit.wikimedia.org/r/#/c/434943/

May 29 2018, 7:25 PM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake)

May 24 2018

Sharvaniharan added a comment to T192534: Missing Save this article bookmark on "Read more" section of article footer.

@RHo is there a Zeplin mock for this? also, what happens when the bookmark is clicked? UI-wise, should it open a bottom sheet like 'Featured Article'?

May 24 2018, 3:51 PM · Patch-For-Review, Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake)

May 22 2018

Sharvaniharan added a comment to T172568: [BUG] User may be directed to unrelated content from the "featured article" widget if device and app language are different.

@ABorbaWMF It is captured here : https://phabricator.wikimedia.org/T141587

May 22 2018, 4:27 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual, Android-app-Bugs
Sharvaniharan added a comment to T172568: [BUG] User may be directed to unrelated content from the "featured article" widget if device and app language are different.

@ABorbaWMF it is expected behavior when we change app language that it will update the feed only on refresh. However, I can create a ticket for this specific case, so we can triage on it. This is not related to the widget issue we are trying to resolve here. If that particular scenario is met, could you please move this to the right column. @RHo lmk if you feel differently.

May 22 2018, 4:16 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual, Android-app-Bugs

May 21 2018

Sharvaniharan added a comment to T192397: [UX-debt] Improve visual design of "Recent searches" in Search .

here : https://gerrit.wikimedia.org/r/#/c/433917/ . Not yet merged.

May 21 2018, 7:12 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-UX-Debt
Sharvaniharan added a comment to T192397: [UX-debt] Improve visual design of "Recent searches" in Search .

@RHo made changes. Lmk if they look good now.

May 21 2018, 7:09 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-UX-Debt
Sharvaniharan added a comment to T191241: Update espresso tests.

@Charlotte this is dependent on : https://phabricator.wikimedia.org/T191642 . So for now it can live in tech debt, and we will move this to workboard when it makes sense.

May 21 2018, 4:35 PM · Wikipedia-Android-App-Backlog
Sharvaniharan moved T190082: 5-second latency for certain API calls? from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
May 21 2018, 4:12 PM · MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, MediaWiki-Database, Performance-Team, Android-app-Bugs
Sharvaniharan moved T192397: [UX-debt] Improve visual design of "Recent searches" in Search from Backlog to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
May 21 2018, 4:04 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-UX-Debt

May 19 2018

Sharvaniharan added a comment to T192397: [UX-debt] Improve visual design of "Recent searches" in Search .

@RHo Let me know [Monday] if the sub-heading "Recent Searches"looks ok... text size and font:

May 19 2018, 2:29 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-UX-Debt
Sharvaniharan moved T172283: Improve the ease of viewing individual citations references grouped together from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
May 19 2018, 1:46 AM · Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake), Patch-For-Review, Android-app-feature-UX-Debt
Sharvaniharan added a comment to M224: Android Citation pane.

No worries @RHo I have used existing components, but need a few heights and stuff... we can discuss Monday. Thanks :)

May 19 2018, 12:30 AM
Sharvaniharan placed T178163: Add transitions when users interacts with feed content up for grabs.
May 19 2018, 12:27 AM · Wikipedia-Android-App-Backlog, Android-app-feature-Feeds, Android-app-feature-UX-Debt

May 18 2018

Sharvaniharan added a comment to M224: Android Citation pane.

@RHo is there a zeplin mock for this?

May 18 2018, 8:39 PM

May 17 2018

Sharvaniharan moved T190839: Enable searching Wikipedia in multiple app languages from Did not pass QA to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
May 17 2018, 5:31 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan added a comment to T190839: Enable searching Wikipedia in multiple app languages.

Thanks @RHo ... sorry it took some back and forth... I previously made all changes to the library file that renders the search bar and it just stayed local.. thanks for the re-reviews!

May 17 2018, 4:20 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual

May 16 2018

Sharvaniharan added a comment to T190839: Enable searching Wikipedia in multiple app languages.

hi @RHo made changes. lmk.

May 16 2018, 5:41 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan moved T190922: Add language detection and selection to app onboarding from Did not pass QA to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
May 16 2018, 3:45 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual

May 15 2018

Sharvaniharan moved T190931: Implement Analytics/Event logging instrumentation to measure new multilingual features from Doing to Blocked/Waiting on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
May 15 2018, 10:46 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan added a comment to T190922: Add language detection and selection to app onboarding.

@RHo RTL update ready to review..

May 15 2018, 10:01 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual