Fri, Feb 15
Thu, Feb 14
@schoenbaechler Could you please update the designs to reflect what should happen when page items have multiline descriptions?
Mon, Feb 11
Ah! That would be the android.R.string.* strings. I assumed only the strings that were created and translated by us, but yes over all I guess they must be reviewed as well. Will move this back to ready-to-dev in that case. We can convert all those places to local strings, also making it a coding standard going forward not to use general android strings, maybe?
I have taken care of "OK", "Cancel", "Yes", and "No" messages. Infact, all the strings are single use right now, other than the ones I documented here : https://docs.google.com/spreadsheets/d/1DNweLAylPjIZ1_Vmx7voZnDwdseB8QXzAvkrF0ZIeYE/edit?usp=sharing why I have ignored them. But yes, the ticket is far from done till we review the document and agree upon ignoring them... I just assumed it was, since the change was merged. Where should we move this to?
Thu, Feb 7
Wed, Feb 6
Tue, Feb 5
Fri, Feb 1
@Charlotte just one clarification needed:
Mon, Jan 28
Part of the CSS outage. Will be automatically resolved when that is fixed.
Sat, Jan 26
Fri, Jan 25
Jan 16 2019
The translation unlock logic is solely based on the number of user edits being more than 1 [2 or more], which causes these conflicts:
"1. What happens if the user unlocks the edit feed by making the very first edit, sees unlock dialog, hits ‘Maybe later’ and goes on to read few more articles and along the way makes description edits? Let us say user made 3 edits.
Now the indicator dot is seen, the user visits the edit feed page,
A. Should both title and translate description options be unlocked and available now?
B. If user hits on ‘Add Title Descriptions’ , both first time title edit dialog and translate unlock dialog are now waiting to be shown. Should they both be shown one after the other? Should the translate unlock not appear? Should translate unlocked dialog have appeared anywhere wherever the 2nd edit was made?
C. What happens if the user enters the edit feed, chooses not to hit 'Add Title Descriptions’ , but hits ‘Translate Title Descriptions’ which will now be unlocked. When they next visit 'Add Title Descriptions’ obviously the translate unlock dialog doesn't make sense, so should we include logic to track that and not show translation unlock dialog?"
Jan 15 2019
Jan 14 2019
@cmadeo Thank you for the suggestions. I was actually able to have a chat with @schoenbaechler before he left for the day and he was able to clarify. Other than the last point , the back button functionality... rest were the same. Will re-confirm with him tomorrow.
User hasn’t set multiple languages in the app’s settings:
Title: Translate title descriptions
Description: Translation tasks are available if you read and write in more than one Wikipedia language.
Actions: Not for me | Add languages
- When setting multiple languages in the app's onboarding after initial launch as described in T207334, the second "Title description" edit triggers the Translating tile descriptions editing has been unlocked dialog. If no additional languages are set in the app's onboarding (or settings), the "More tasks for multilingual editors" item in "App editor tasks" can't be accessed at all (screen).\ Plus, it wasn't completely clear to me when and why sometimes the "More tasks for multilingual editors" appears visually locked (which is sometimes accessible in locked state, sometimes not) and when unlocked. Ideally, it would always be in unlocked state for the usability testing to not cause confusion and to make it easier for participants to "Add languages" if they haven't done it already.
Yes, this is unexpected, and something we definitely need to work out for the final version.
Jan 11 2019
Jan 8 2019
Adding this for reference on dialog text that needs to be updated: https://docs.google.com/document/d/1ITpVMDgYQY8OPS5I8AT2CuIjYdSZaUfZrALFqxh2pxo/edit?ts=5c336bb7#
Jan 7 2019
Jan 5 2019
Jan 4 2019
Dec 21 2018
Dec 20 2018
Dec 18 2018
@cmadeo having trouble importing..
@cmadeo final one... need the asset for the image next to 'Caption images'.
Dec 17 2018
.56 worked perfectly!
Thank you @RHo... let me try that..
@cmadeo I just wanted to run the disabled looks by you since we decided to have an alpha instead of different colors..
We decided 0.62 looks like this :
Dec 15 2018
Moving this to Blocked to indicate 'Development done and waiting for other tasks for the prototype to be completed, but does not need QA'.
Dec 14 2018
Dec 7 2018
Dec 5 2018
Dec 3 2018
oh i see that now... for some weird reason it looks different in the browser.. thank you ..
Thanks @RHo... I also saw there was an option to convert pdf to svg... but thanks for this :)
Will it be possible to give me an svg?
np at all! Thank you @cmadeo :)
Nov 29 2018
Nov 28 2018
Thank you so much @cmadeo ! will wrap this up now :)
Nov 27 2018
Screenshot as of now
@cmadeo @schoenbaechler Image for the dialog is not provided in the Zeplin mocks.
Few more questions:
--With the margins provided, and the width of the dialog, along with the text size in mock, the text appearance is not the same. The title runs to 3 lines.
--Left margin of title and description is 24dp, right is 27dp?
Nov 26 2018
Nov 19 2018
Nov 16 2018
Nov 15 2018
@ABorbaWMF I made it scrollable thinking it would solve the issue, but when there is a floating button for continue reading, it still doesn't work : https://youtu.be/0aLFDsAqwXQ spoke to @cmadeo ... we feel this needs more thought into the design, to find a way to have the sync dialog , reading list, and the empty message all visible on the screen, while the continue reading floating button is visible. So could we please pass this now, and have a separate ticket to design what is needed?
Nov 14 2018
Thank you @cmadeo :)
@cmadeo Could you please give me colors for all themes..
Nov 6 2018
@ABorbaWMF will look into this today. .. at first glance it looks like the dialog got created 3 times, which makes it related to this, but it could also be triggered from a different place... either way, will fix this