Fri, Aug 9
Tue, Aug 6
Wed, Jul 31
Tue, Jul 30
@schoenbaechler I found that the root cause for this is that, on Gallery cta, we hide the explicit cta, since we have the edit button, only when there is neither structured nor unstructured caption available. However, we show it when there is an unstructured caption available, but no structured. However, on article cta we show in either case, which i feel is what should be the case. I have created a PR for correcting this logic, but please let me know if we need to do otherwise.
I have merged it... and I did not completely understand 1) - is it that for any random image which doesn't have a structured caption in english, only sometimes the article CTA is shown and other times it is not? - I could not reproduce that.
Mon, Jul 29
Merged... @schoenbaechler ready for sign-off
Moved back to design sign-off @schoenbaechler
Thank you for making this change @cooltey . Appreciate it. Will move it .
Fri, Jul 26
@schoenbaechler ready for sign-off
Thu, Jul 25
Thank you @bearND
Wed, Jul 24
You are right @bearND. Sorry about that , we don't need the purpose attribute. That is derived natively.
Tue, Jul 23
@JoeWalsh I don't see structured captions in the response. For example for the file File:Billy_Joel_Shankbone_NYC_2009
@schoenbaechler @Charlotte This is a blocking bug that happens because of an unexpected response from the api returning structured edits. We will have to notify RI team and will be blocked until it is resolved. Great catch @schoenbaechler
Also, generally when the user is reading the article in secondary language and opens the gallery, but there is no structured caption present in that language, it should fallback to the primary language, or to the unstructured caption in the secondary language.
- @schoenbaechler Thank you ..Will fix this.
The green color in the snackbar for action button is a standard across the app in all the places where we use this kind of snackbar. We set it all in just one place. Can I change it so it is color-group-3 for all, or should we leave it green to maintain uniformity, or should this be different?
Mon, Jul 22
@schoenbaechler ready for sign off!
Fri, Jul 19
Jul 18 2019
Jul 17 2019
Jul 16 2019
Jul 10 2019
Jul 9 2019
Jul 8 2019
@schoenbaechler The system back button only works on a fresh launch as expected. I feel that it will be too much code to maintain, in order to detect a deep-link launch and behave differently. Posting this video so you are aware of a non-fresh launch:
Verified that this is no more an issue. This was a server-side issue only, as discussed on this thread on slack : https://wikimedia.slack.com/archives/C7P3N5E6P/p1561662568069200 which iOS also observed, and is now resolved. I will still move it to QA just for confirmation.
Jul 3 2019
Jun 27 2019
Thanks for discussing this today morning @schoenbaechler :-) As discussed on call, 1 and 2 will be fixed and I was able to just change background colors conditionally per theme. However, 3 is just how the recyclerview draws with clipped padding.
ok @schoenbaechler . will remove date altogether.
Jun 26 2019
ok will make changes according to Robin's comments.
Hi @Patriccck ... We maintain a list of localized names for all languages in the app. So if the system language is čeština, you would have the strings reading like this:
Jun 25 2019
Jun 24 2019
Jun 22 2019
Jun 20 2019
Jun 13 2019
Jun 12 2019
Jun 11 2019
Same on android @bearND . We use it while loading the leas section as a meta preference.:
Further we have a native transform for it.
Jun 10 2019
@schoenbaechler the news item ellipsis that we discussed this morning, is the only change pending. Otherwise ready for review.
Jun 4 2019
@schoenbaechler I have removed page item view is also used in page bottom content, so when I remove the placeholder image, it looks like this :
Jun 3 2019
Thank you @schoenbaechler :) Will do that..
@VeghTomi Please do. I have unassigned myself. Thank you :-)
There’s only one right now: “Go to file page”. The reason why it’s hidden in the overflow menu is we don’t want to promote it since it’s not optimized (coming in V2: T223132). I’m thinking about a more prominent button at the bottom for V2.
May 31 2019
Blocked until the DescriptionEditView logic is solidified to support image caption edits
@schoenbaechler couple questions...
1.what are the options on the overflow menu?
2.The toolbar scrolls with the dialog as it is not a separate activity and cannot behave like a regular screens' toolbar. Is that ok?