Thu, Mar 4
@ABorbaWMF This is resolved and can be tested on beta or on stable channel: https://releases.wikimedia.org/mobile/android/wikipedia/stable/wikipedia-2.7.50345-r-2021-03-04.apk
Tue, Mar 2
Mon, Mar 1
Thu, Feb 25
Wed, Feb 24
@schoenbaechler This is the same svg we are using for More->Donate option and Edits->Learn more link. Lmk if I need to make changes. Thank you!
Thu, Feb 18
@schoenbaechler This looks a bit different from what I have tested. We might need to discuss this on a call. Are you sure you were using the latest build for the video?
Thank you @schoenbaechler.
This change is a bit more complicated than it looks for 2 reasons:
- I remember we deliberately made this change from specifying a particular list to mentioning the generic 'list' in the message. We might need to look into it more why we changed that.
- We will need to consider many places... long press from list items that display articles, removing just one article from one list, one article from many lists and many articles from one list.
Fri, Feb 12
Thu, Feb 11
Thank you @schoenbaechler ... I have used a fresh one from material design for talk... lmk if that doesnt work, then will change that too..
We do not have any issues with deleted pages, as only the deleted edit is shown and is disabled and unclickable. So this spike is complete with following info:
For moved pages, the comment informs the users to where it was moved to , and no diff is shown. I also do not see a very obvious way for us to know that a particular 'regular edit' is of a moved page.
For deleted pages, the current behavior is sufficient.
@schoenbaechler @JTannerWMF Lmk if it looks good for now.
Wed, Feb 10
I have marked a test page for deletion and will update this ticket with findings once it is deleted.
Few notes from the spike:
Tue, Feb 9
@schoenbaechler could I please get an icon for talk page option in the overflow menu?
Mon, Feb 8
Feb 5 2021
Feb 2 2021
@ABorbaWMF Thank you for testing this.
Thank you @schoenbaechler !! 🎉🎉🎉
02), 03) and 04) Changes are done @schoenbaechler . Please test and Let me know.
@schoenbaechler Thank you for reviewing.. I will address the ui issues...
I have also made a tiny change... since there is no profile page for anonymous users, i have made changes to hide this menu option when it is an anonymous user. Please test this too and lmk.
@schoenbaechler I have fixed the UI issues, but for 01), since the page is deleted, user is seeing the error message in the video. Handling this in a more graceful way would have to be a v2 issue since we will also need to check if we get any feedback from the api in such cases and what message to show
Feb 1 2021
Jan 26 2021
@schoenbaechler I have addressed all comments but for 02) swiping, which will be too complicated technically. I also addressed
Jan 21 2021
Picking up utils
Jan 20 2021
Jan 13 2021
Jan 11 2021
Jan 7 2021
Thank you @schoenbaechler that works for paragraph switch. Also, correct edit summary.
Jan 6 2021
@schoenbaechler Thank you for the icons. I have put them in. I think we should create 4 more color groups in the theme, for the edit add and removal font-colors and background colors.
Also a couple questions about the diff screen: https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5fc655837c345ea57e72a98d
- is the bold diff text the comment on the edit?
- if a paragraph has been moved, how do we style it? We get a 'from' diff and a 'to' diff with the same text of the paragraph that was moved, but we do not get a highlight range [we can discuss this on a call to be more clear]
Dec 17 2020
@schoenbaechler could I please get the icons for profile and contributions options in the menu here : https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5fc655860f5a5c9dbf26c455
Dec 15 2020
@schoenbaechler asking the same questions from our slack chat here too, just for reference:
It is not possible to deep link an edit diff for the ‘Share Edit’ in the menu, so we might have to take it out.
Dec 14 2020
Dec 11 2020
Dec 10 2020
Thank you @schoenbaechler
Dec 8 2020
@schoenbaechler is the group color for the 'WATCHING" button color_group_45?
Dec 3 2020
Dec 1 2020
@SNowick_WMF We have already switched to the new rev number, but am not able to reproduce the Unterminated string error. Will keep you posted if I track that down.
Nov 24 2020
As discussed on the call, this is currently designed to allow news cards to have different heights, with a minor jump between them. We can try a more optimal solution by trying one of the two:
- increase height and have a fixed height, so it can accommodate 4 lines of text[max] on all types of devices [less preferred ]
- Or, search for ways to avoid the minor jump.
Since this will need some trials, and is a minor matter, will be moving this to UX backlog.
Moving this to current board as I have zeroed in on the root cause.
Nov 23 2020
Nov 10 2020
Nov 9 2020
Nov 6 2020
Nov 5 2020
Nov 4 2020
Nov 2 2020
Oct 31 2020
Whoops! did not see that! will tag mobile web team.