Page MenuHomePhabricator

Sharvaniharan (Sharvaniharan)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 23 2017, 3:03 PM (95 w, 6 d)
Availability
Available
LDAP User
Sharvaniharan
MediaWiki User
SHaran (WMF) [ Global Accounts ]

Recent Activity

Today

Sharvaniharan moved T225874: Wikipedia Android - translate languages from Doing to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Tue, Jun 25, 4:36 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T224600: Create Explore feed cards for add/translate image captions from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Tue, Jun 25, 4:36 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Yesterday

Sharvaniharan claimed T225874: Wikipedia Android - translate languages.
Mon, Jun 24, 10:32 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T218201: Explore new ways to display content instead of showing placeholder images from Did not pass QA to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Jun 24, 7:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Sharvaniharan moved T224728: Add caption CTA on article pages from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Jun 24, 5:04 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Sat, Jun 22

Sharvaniharan renamed T226291: [BUG] Reading list syncing issue from reading list syncing issue to Reading list syncing issue.
Sat, Jun 22, 12:16 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan created T226291: [BUG] Reading list syncing issue.
Sat, Jun 22, 12:16 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan created T226290: [BUG] Images not saved when article saved for offline reading.
Sat, Jun 22, 12:10 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar)

Thu, Jun 20

Sharvaniharan moved T222946: mobile-html: investigate the page/metadata endpoint from Doing to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Thu, Jun 20, 3:17 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Spike

Thu, Jun 13

Sharvaniharan moved T224728: Add caption CTA on article pages from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Thu, Jun 13, 6:56 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Sharvaniharan claimed T224728: Add caption CTA on article pages.
Thu, Jun 13, 3:48 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Wed, Jun 12

Sharvaniharan moved T224600: Create Explore feed cards for add/translate image captions from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Wed, Jun 12, 11:25 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Sharvaniharan moved T224709: Clean-up test-only code for showing bottom sheet from QA signoff to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Wed, Jun 12, 11:25 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T224709: Clean-up test-only code for showing bottom sheet from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Wed, Jun 12, 11:25 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T223130: Bottom sheet popup for adding/translating/editing image captions from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Wed, Jun 12, 11:25 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Sharvaniharan moved T222946: mobile-html: investigate the page/metadata endpoint from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Wed, Jun 12, 11:24 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Spike
Sharvaniharan claimed T222946: mobile-html: investigate the page/metadata endpoint.
Wed, Jun 12, 11:23 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Spike

Tue, Jun 11

Sharvaniharan added a comment to T218050: mobile-html: allow clients to adjust tables.

Same on android @bearND . We use it while loading the leas section as a meta preference.:
https://github.com/wikimedia/apps-android-wikipedia/blob/master/app/src/main/java/org/wikipedia/page/PageFragmentLoadState.java#L412
Further we have a native transform for it.

Tue, Jun 11, 4:27 PM · Reading-Infrastructure-Team-Backlog, Page Content Service

Mon, Jun 10

Sharvaniharan added a comment to T218201: Explore new ways to display content instead of showing placeholder images.

@schoenbaechler the news item ellipsis that we discussed this morning, is the only change pending. Otherwise ready for review.

Mon, Jun 10, 11:04 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Sharvaniharan moved T218201: Explore new ways to display content instead of showing placeholder images from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Jun 10, 11:02 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Sharvaniharan moved T224709: Clean-up test-only code for showing bottom sheet from Blocked/Waiting to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Jun 10, 11:01 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Tue, Jun 4

Sharvaniharan claimed T224600: Create Explore feed cards for add/translate image captions.
Tue, Jun 4, 5:26 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Sharvaniharan added a comment to T218201: Explore new ways to display content instead of showing placeholder images.

@schoenbaechler I have removed page item view is also used in page bottom content, so when I remove the placeholder image, it looks like this :

Tue, Jun 4, 5:18 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt

Mon, Jun 3

Sharvaniharan added a comment to T223130: Bottom sheet popup for adding/translating/editing image captions.

Thank you @schoenbaechler :) Will do that..

Mon, Jun 3, 5:06 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Sharvaniharan moved T219651: Design recommendations for “Add/translate descriptions“ from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Jun 3, 4:26 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Sharvaniharan placed T182716: Users should be able to swipe left and right in the 'On this day' calendar view up for grabs.

@VeghTomi Please do. I have unassigned myself. Thank you :-)

Mon, Jun 3, 4:22 PM · Wikipedia-Android-App-Backlog, Android-app-feature-UX-Debt, Reading Epics (Feed 2.0)
Sharvaniharan added a comment to T223130: Bottom sheet popup for adding/translating/editing image captions.

There’s only one right now: “Go to file page”. The reason why it’s hidden in the overflow menu is we don’t want to promote it since it’s not optimized (coming in V2: T223132). I’m thinking about a more prominent button at the bottom for V2.

Mon, Jun 3, 4:20 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Fri, May 31

Sharvaniharan moved T223130: Bottom sheet popup for adding/translating/editing image captions from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Fri, May 31, 3:11 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Sharvaniharan added a comment to T224709: Clean-up test-only code for showing bottom sheet.

Blocked until the DescriptionEditView logic is solidified to support image caption edits

Fri, May 31, 3:11 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan claimed T224709: Clean-up test-only code for showing bottom sheet.
Fri, May 31, 3:10 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan created T224709: Clean-up test-only code for showing bottom sheet.
Fri, May 31, 3:10 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan added a comment to T223130: Bottom sheet popup for adding/translating/editing image captions.

@schoenbaechler couple questions...
1.what are the options on the overflow menu?
2.The toolbar scrolls with the dialog as it is not a separate activity and cannot behave like a regular screens' toolbar. Is that ok?

Fri, May 31, 3:04 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

Wed, May 29

Kaartic awarded T223159: Navigation redesign of the Commons Android app a Love token.
Wed, May 29, 3:54 PM · Commons-App-Android, Wikimedia-Hackathon-2019

Tue, May 28

Sharvaniharan moved T217373: Create feed card for suggested edits and update iconography from Did not pass QA to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Tue, May 28, 4:45 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T218201: Explore new ways to display content instead of showing placeholder images from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Tue, May 28, 4:44 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt

May 22 2019

Sharvaniharan moved T223130: Bottom sheet popup for adding/translating/editing image captions from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
May 22 2019, 8:58 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing
Sharvaniharan claimed T223130: Bottom sheet popup for adding/translating/editing image captions.
May 22 2019, 4:07 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-Description-Editing

May 18 2019

Sharvaniharan added a comment to T223159: Navigation redesign of the Commons Android app.

hi @Ashishkumar468 Thank you for offering help... The new designs will be updated in a bit. @schoenbaechler has designed it ... Please update here if you have more questions. Once I stabilize the four fragments we want to display, we can probably collaborate and use your help on stabilizing the menu and orientation changes..Will update you on this ticket..

May 18 2019, 8:24 AM · Commons-App-Android, Wikimedia-Hackathon-2019

May 17 2019

Sharvaniharan claimed T223159: Navigation redesign of the Commons Android app.
May 17 2019, 8:11 AM · Commons-App-Android, Wikimedia-Hackathon-2019

May 13 2019

Sharvaniharan placed T223159: Navigation redesign of the Commons Android app up for grabs.
May 13 2019, 7:13 PM · Commons-App-Android, Wikimedia-Hackathon-2019
Sharvaniharan created T223159: Navigation redesign of the Commons Android app.
May 13 2019, 6:58 PM · Commons-App-Android, Wikimedia-Hackathon-2019

May 8 2019

Sharvaniharan added a comment to T218201: Explore new ways to display content instead of showing placeholder images.

Point to note... when there is no image for the news card item, that is all the text we can show... 😖 Of course in the example I had to artificially remove the image to show how it would look... but in reality i assume all of the news items not having an image is very borderline..

May 8 2019, 4:11 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Sharvaniharan added a comment to T218201: Explore new ways to display content instead of showing placeholder images.

Hey @Sharvaniharan, thanks for checking back! Looks like you nailed the margins 👏. It’s 16dp left, right and between text and image, right? (see image)

Yes yes yes!!! whoo hoo! Thanks @schoenbaechler

May 8 2019, 4:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Sharvaniharan added a comment to T218201: Explore new ways to display content instead of showing placeholder images.

OnThis Day


Fullscreen

May 8 2019, 4:05 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt

May 7 2019

Sharvaniharan added a comment to T218201: Explore new ways to display content instead of showing placeholder images.

After code change for search:

May 7 2019, 7:33 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt

May 6 2019

Sharvaniharan moved T219651: Design recommendations for “Add/translate descriptions“ from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
May 6 2019, 4:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Sharvaniharan moved T218201: Explore new ways to display content instead of showing placeholder images from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
May 6 2019, 4:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Sharvaniharan claimed T218201: Explore new ways to display content instead of showing placeholder images.
May 6 2019, 4:07 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt

May 3 2019

Sharvaniharan created T222478: Page bottom bar behavior and appearance.
May 3 2019, 8:17 PM · Android-app-feature-UX-Debt, Wikipedia-Android-App-Backlog
Sharvaniharan created T222476: [Bug] Error in Article table display in dark mode.
May 3 2019, 8:01 PM · wikimedia-page-library

May 2 2019

Sharvaniharan added a comment to T219651: Design recommendations for “Add/translate descriptions“.

And after the description is added, in the landscape mode, do we see pencil image instead of '+'

May 2 2019, 4:39 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Sharvaniharan added a comment to T219651: Design recommendations for “Add/translate descriptions“.

@schoenbaechler Thank you...
Just one more clarification:
what is the color attribute for '+ ADD DESCRIOTION' - is it just base100[white] or paper_color?

May 2 2019, 4:00 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt

May 1 2019

Sharvaniharan added a comment to T217373: Create feed card for suggested edits and update iconography.

You mentioned it @schoenbaechler ... its done :)

May 1 2019, 4:14 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Apr 30 2019

Sharvaniharan added a comment to T217373: Create feed card for suggested edits and update iconography.

Thank you @schoenbaechler will do it

Apr 30 2019, 7:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan added a comment to T219651: Design recommendations for “Add/translate descriptions“.

@schoenbaechler Thank you for the clarification on the feed cards.

Apr 30 2019, 6:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Sharvaniharan added a comment to T217373: Create feed card for suggested edits and update iconography.

01) Users should stay within the “Add/translate descriptions“ workflow when coming from the “Explore feed“. Currently, the behavior that’s implemented in the Alpha is that users return to the “Explore feed“. The user journey should be:

  1. Users taps a “Suggested edit“ card in the “Explore feed“
  2. Users add/translate a description
  3. Users are presented with a new card within the Add/translate descriptions view
Apr 30 2019, 5:58 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan added a comment to T219651: Design recommendations for “Add/translate descriptions“.
  1. Do these things apply to the Suggested Edits feed cards too:
Apr 30 2019, 5:54 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt

Apr 24 2019

Sharvaniharan moved T220218: Context menu (long press) has extremely light grey text with the dark and black themes from Doing to Blocked/Waiting on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Apr 24 2019, 4:57 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan updated subscribers of T220218: Context menu (long press) has extremely light grey text with the dark and black themes.

@Charlotte @schoenbaechler The root cause for this bug is that the custom styles are not getting applied to the dialog on the first load. It is the same behavior in light mode too, but we do not notice as our custom colors and default are close. With Dark/Black mode, the default styles for dialogs assigns the textPrimaryColor to the text and hence renders the way we see in the screenshot, very light[which is the primary text color in dark mode].
It is unclear as to why this is happening and why it gets resolved when we try to take any action in the bottom sheet, say, changing the theme or dimming image settings from the bottom sheet.. So I will open an issue on sdk repo and will wait for your responses to move it to tracking.

Apr 24 2019, 4:56 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T215255: Review app to find re-used translations from Code Review to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Apr 24 2019, 4:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), I18n, Technical-Debt
Sharvaniharan moved T117380: [Dev] Crash report description should include device locale from Code Review to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Apr 24 2019, 4:48 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Technical-Debt
Sharvaniharan moved T219462: Provide an option to enable/disable all cards related to “Suggested edits“ from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Apr 24 2019, 4:47 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T217373: Create feed card for suggested edits and update iconography from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Apr 24 2019, 4:47 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T219651: Design recommendations for “Add/translate descriptions“ from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Apr 24 2019, 3:44 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt
Sharvaniharan claimed T219651: Design recommendations for “Add/translate descriptions“.
Apr 24 2019, 3:44 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Android-app-feature-UX-Debt

Apr 19 2019

Sharvaniharan added a comment to T217373: Create feed card for suggested edits and update iconography.

Add descriptions has been unlocked (3 non-reverted edits): Daily suggestions for “Add descriptions“ are shown in the feed.

Apr 19 2019, 7:18 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan added a comment to T217373: Create feed card for suggested edits and update iconography.

Thank you @schoenbaechler!

Apr 19 2019, 7:16 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Apr 16 2019

Sharvaniharan moved T220218: Context menu (long press) has extremely light grey text with the dark and black themes from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Apr 16 2019, 8:04 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan claimed T220218: Context menu (long press) has extremely light grey text with the dark and black themes.
Apr 16 2019, 8:03 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T117380: [Dev] Crash report description should include device locale from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Apr 16 2019, 8:03 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Technical-Debt

Apr 15 2019

Sharvaniharan moved T117380: [Dev] Crash report description should include device locale from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Apr 15 2019, 4:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Technical-Debt
Sharvaniharan claimed T117380: [Dev] Crash report description should include device locale.
Apr 15 2019, 4:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Technical-Debt
Sharvaniharan moved T215255: Review app to find re-used translations from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Apr 15 2019, 3:29 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), I18n, Technical-Debt
Sharvaniharan moved T206855: mobile-html: Android prototype from Backlog to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.

yes, @Charlotte ! moving it to done.

Apr 15 2019, 3:20 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Apr 12 2019

Sharvaniharan claimed T215255: Review app to find re-used translations.
Apr 12 2019, 5:31 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), I18n, Technical-Debt
Sharvaniharan moved T215255: Review app to find re-used translations from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Apr 12 2019, 5:30 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), I18n, Technical-Debt

Apr 8 2019

Sharvaniharan added a comment to T217373: Create feed card for suggested edits and update iconography.

@schoenbaechler Could you please let me know the margins when there is no image?

Apr 8 2019, 6:15 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T219462: Provide an option to enable/disable all cards related to “Suggested edits“ from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Apr 8 2019, 6:09 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T217373: Create feed card for suggested edits and update iconography from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Apr 8 2019, 4:06 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T219462: Provide an option to enable/disable all cards related to “Suggested edits“ from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Apr 8 2019, 4:06 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T217373: Create feed card for suggested edits and update iconography from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Apr 8 2019, 4:06 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Apr 4 2019

Sharvaniharan moved T217170: Visual changes to translate descriptions from Did not pass QA to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Apr 4 2019, 8:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan added a comment to T217170: Visual changes to translate descriptions.

@schoenbaechler
My guess is that it is their custom component which is not exposed to us..[ I will look around if there is a function call to make it behave differently]

Hmm interesting, I find it’s poorly designed with that huge gap. What component is Google Translate using here?

Apr 4 2019, 4:56 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan added a comment to T217170: Visual changes to translate descriptions.

Thanks for the clarifications @schoenbaechler
For point 03, we are not doing any particular transition here, it is just the system transition. The only improvement to the transition between the Activities that we can do is to fade-out first and fade-in next activity. I tried that, but I don't feel it looks all that good...Check it out.. Even assuming we do something about the keyboard coming up after the animation... looks unnecessarily dramatic.:

03 Related to transitioning from one screen to another (also affects T217169): is there a way to avoid the page jump at the top when arriving in the editing interface? (Observe “English description“ & “Beach of Portugal“ in the video below):

Apr 4 2019, 4:53 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan added a comment to T217170: Visual changes to translate descriptions.

Unable to makeout the difference between the two 😂 . Can I refer to zeplin and make it 9dp margin on top and 19dp on bottom? https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5c77d20a86d8b86292fd9750

02 Move plus icon and label ("Add German translation") 12dp lower (the values in sp are still a mystery to me). Please use the “After“ screenshot below (Pixel 3) to adjust the position accordingly.

BeforeAfter
Apr 4 2019, 4:24 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan added a comment to T217170: Visual changes to translate descriptions.

@schoenbaechler We are using a system component for this, and it changes the space between the label and arrow according to the longest entry in the list. For eg: This is how it looks with a really long named language:

Apr 4 2019, 4:18 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Apr 3 2019

Sharvaniharan added a comment to T217170: Visual changes to translate descriptions.

@schoenbaechler ready for review..

Apr 3 2019, 1:15 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan moved T217170: Visual changes to translate descriptions from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Apr 3 2019, 1:15 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Apr 2 2019

Sharvaniharan moved T217170: Visual changes to translate descriptions from Blocked/Waiting to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Apr 2 2019, 7:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Apr 1 2019

Sharvaniharan moved T217562: Update Info/help screen concept from Did not pass QA to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Apr 1 2019, 6:43 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Mar 28 2019

Sharvaniharan moved T217373: Create feed card for suggested edits and update iconography from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mar 28 2019, 8:22 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Mar 27 2019

Sharvaniharan moved T219462: Provide an option to enable/disable all cards related to “Suggested edits“ from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mar 27 2019, 10:52 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan claimed T219462: Provide an option to enable/disable all cards related to “Suggested edits“.
Mar 27 2019, 10:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan added a comment to T219462: Provide an option to enable/disable all cards related to “Suggested edits“.

ok cool! that makes it easier then..

Mar 27 2019, 10:27 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan added a comment to T219462: Provide an option to enable/disable all cards related to “Suggested edits“.

@schoenbaechler so other main reason for a separate ticket was to group them and further give the user an option to individually turn them on/off as well... so which would mean, we indicate in ui that 'Suggested edits' is a group, and on clicking it, it will expose the various types of cards grouped under it.. like suggested edit add description, suggested edit translate description,suggested edit image... etc.. which can also then be turned on/off individually.. If you feel that is how we should proceed, then this ticket should include design to do that as well?

Mar 27 2019, 10:13 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan added a comment to T217373: Create feed card for suggested edits and update iconography.

@schoenbaechler

Mar 27 2019, 4:02 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan added a comment to T217373: Create feed card for suggested edits and update iconography.

Could I get strings for the title and description for the feed card in customize screen:

Mar 27 2019, 4:02 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Mar 26 2019

Sharvaniharan added a comment to T217562: Update Info/help screen concept.

@schoenbaechler should this verbiage be changed on the main drawer too, or just here?

Mar 26 2019, 5:26 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Mar 25 2019

Sharvaniharan updated the task description for T217373: Create feed card for suggested edits and update iconography.
Mar 25 2019, 6:30 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T217562: Update Info/help screen concept from QA signoff to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mar 25 2019, 4:53 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)