Page MenuHomePhabricator

Sharvaniharan (Sharvaniharan)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 23 2017, 3:03 PM (86 w, 4 d)
Availability
Available
LDAP User
Sharvaniharan
MediaWiki User
SHaran (WMF) [ Global Accounts ]

Recent Activity

Fri, Apr 19

Sharvaniharan added a comment to T217373: Create feed card for editor tasks and update iconography.

Add descriptions has been unlocked (3 non-reverted edits): Daily suggestions for “Add descriptions“ are shown in the feed.

Fri, Apr 19, 7:18 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan added a comment to T217373: Create feed card for editor tasks and update iconography.

Thank you @schoenbaechler!

Fri, Apr 19, 7:16 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Tue, Apr 16

Sharvaniharan moved T220218: Context menu (long press) has extremely light grey text with the dark and black themes from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Tue, Apr 16, 8:04 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan claimed T220218: Context menu (long press) has extremely light grey text with the dark and black themes.
Tue, Apr 16, 8:03 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T117380: [Dev] Crash report description should include device locale from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Tue, Apr 16, 8:03 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Technical-Debt

Mon, Apr 15

Sharvaniharan moved T117380: [Dev] Crash report description should include device locale from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Apr 15, 4:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Technical-Debt
Sharvaniharan claimed T117380: [Dev] Crash report description should include device locale.
Mon, Apr 15, 4:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), Technical-Debt
Sharvaniharan moved T215255: Review app to find re-used translations from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Apr 15, 3:29 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), I18n, Technical-Debt
Sharvaniharan moved T206855: mobile-html: Android prototype from Backlog to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.

yes, @Charlotte ! moving it to done.

Mon, Apr 15, 3:20 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Fri, Apr 12

Sharvaniharan claimed T215255: Review app to find re-used translations.
Fri, Apr 12, 5:31 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), I18n, Technical-Debt
Sharvaniharan moved T215255: Review app to find re-used translations from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Fri, Apr 12, 5:30 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), I18n, Technical-Debt

Mon, Apr 8

Sharvaniharan added a comment to T217373: Create feed card for editor tasks and update iconography.

@schoenbaechler Could you please let me know the margins when there is no image?

Mon, Apr 8, 6:15 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T219462: Provide an option to enable/disable all cards related to “Suggested edits“ from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Apr 8, 6:09 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T217373: Create feed card for editor tasks and update iconography from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Apr 8, 4:06 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T219462: Provide an option to enable/disable all cards related to “Suggested edits“ from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Apr 8, 4:06 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T217373: Create feed card for editor tasks and update iconography from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi) board.
Mon, Apr 8, 4:06 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Thu, Apr 4

Sharvaniharan moved T217170: Visual changes to translate descriptions from Did not pass QA to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Thu, Apr 4, 8:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan added a comment to T217170: Visual changes to translate descriptions.

@schoenbaechler
My guess is that it is their custom component which is not exposed to us..[ I will look around if there is a function call to make it behave differently]

Hmm interesting, I find it’s poorly designed with that huge gap. What component is Google Translate using here?

Thu, Apr 4, 4:56 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan added a comment to T217170: Visual changes to translate descriptions.

Thanks for the clarifications @schoenbaechler
For point 03, we are not doing any particular trasition here, it is just the system transition. The only improvement to the transition between the Activities that we can do is to fade-out first and fade-in next activity. I tried thta, but I don't feel it looks all that good...Check it out.. Even assuming we do something about the keyboard coming up after the animation... looks unnecessarily dramatic.:

03 Related to transitioning from one screen to another (also affects T217169): is there a way to avoid the page jump at the top when arriving in the editing interface? (Observe “English description“ & “Beach of Portugal“ in the video below):

Thu, Apr 4, 4:53 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan added a comment to T217170: Visual changes to translate descriptions.

Unable to makeout the difference between the two 😂 . Can I refer to zeplin and make it 9dp margin on top and 19dp on bottom?

02 Move plus icon and label ("Add German translation") 12dp lower (the values in sp are still a mystery to me). Please use the “After“ screenshot below (Pixel 3) to adjust the position accordingly.

BeforeAfter
Thu, Apr 4, 4:24 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan added a comment to T217170: Visual changes to translate descriptions.

We are using a system component for this, and it changes the space between the label and arrow according to the longest entry in the list. For eg: This is how it looks with a really long named language:

Thu, Apr 4, 4:18 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Wed, Apr 3

Sharvaniharan added a comment to T217170: Visual changes to translate descriptions.

@schoenbaechler ready for review..

Wed, Apr 3, 1:15 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan moved T217170: Visual changes to translate descriptions from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Wed, Apr 3, 1:15 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Tue, Apr 2

Sharvaniharan moved T217170: Visual changes to translate descriptions from Blocked/Waiting to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Tue, Apr 2, 7:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Mon, Apr 1

Sharvaniharan moved T217562: Update Info/help screen concept from Did not pass QA to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mon, Apr 1, 6:43 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Thu, Mar 28

Sharvaniharan moved T217373: Create feed card for editor tasks and update iconography from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Thu, Mar 28, 8:22 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Wed, Mar 27

Sharvaniharan moved T219462: Provide an option to enable/disable all cards related to “Suggested edits“ from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Wed, Mar 27, 10:52 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan claimed T219462: Provide an option to enable/disable all cards related to “Suggested edits“.
Wed, Mar 27, 10:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan added a comment to T219462: Provide an option to enable/disable all cards related to “Suggested edits“.

ok cool! that makes it easier then..

Wed, Mar 27, 10:27 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan added a comment to T219462: Provide an option to enable/disable all cards related to “Suggested edits“.

@schoenbaechler so other main reason for a separate ticket was to group them and further give the user an option to individually turn them on/off as well... so which would mean, we indicate in ui that 'Suggested edits' is a group, and on clicking it, it will expose the various types of cards grouped under it.. like suggested edit add description, suggested edit translate description,suggested edit image... etc.. which can also then be turned on/off individually.. If you feel that is how we should proceed, then this ticket should include design to do that as well?

Wed, Mar 27, 10:13 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan added a comment to T217373: Create feed card for editor tasks and update iconography.

@schoenbaechler

Wed, Mar 27, 4:02 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan added a comment to T217373: Create feed card for editor tasks and update iconography.

Could I get strings for the title and description for the feed card in customize screen:

Wed, Mar 27, 4:02 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Tue, Mar 26

Sharvaniharan added a comment to T217562: Update Info/help screen concept.

@schoenbaechler should this verbiage be change on the main drawer too, or just here?

Tue, Mar 26, 5:26 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Mon, Mar 25

Sharvaniharan updated the task description for T217373: Create feed card for editor tasks and update iconography.
Mon, Mar 25, 6:30 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T217562: Update Info/help screen concept from QA signoff to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mon, Mar 25, 4:53 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan moved T217562: Update Info/help screen concept from Design signoff to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mon, Mar 25, 4:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan moved T217562: Update Info/help screen concept from QA signoff to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mon, Mar 25, 4:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan moved T217562: Update Info/help screen concept from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mon, Mar 25, 4:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Mar 16 2019

Sharvaniharan added a comment to T218439: Crash report.

@Dbrant I looked at the APP_VERSION_NAME that it was old... but I was curious what transaction was as big as a parcel size of 666064 bytes. So asked the user for more details just to verify it is not happening anymore [ not that it has come to our notice anywhere else]. I would have closed it in any case other than currently reproducible steps.

Mar 16 2019, 1:17 AM · Wikipedia-Android-App-Backlog

Mar 15 2019

Sharvaniharan added a comment to T218439: Crash report.
USER_COMMENT=
ANDROID_VERSION=9
APP_VERSION_NAME=2.0-r-2014-08-13
BRAND=samsung
PHONE_MODEL=SM-G960F
CUSTOM_DATA=
STACK_TRACE=java.lang.RuntimeException: android.os.TransactionTooLargeException: data parcel size 666064 bytes
	at android.app.ActivityThread.handleSleeping(ActivityThread.java:4501)
	at android.app.ActivityThread.access$2400(ActivityThread.java:235)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1867)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:6981)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1445)
Caused by: android.os.TransactionTooLargeException: data parcel size 666064 bytes
	at android.os.BinderProxy.transactNative(Native Method)
	at android.os.BinderProxy.transact(Binder.java:1140)
	at android.app.IActivityManager$Stub$Proxy.activitySlept(IActivityManager.java:6155)
	at android.app.ActivityThread.handleSleeping(ActivityThread.java:4499)
	... 8 more
android.os.TransactionTooLargeException: data parcel size 666064 bytes
	at android.os.BinderProxy.transactNative(Native Method)
	at android.os.BinderProxy.transact(Binder.java:1140)
	at android.app.IActivityManager$Stub$Proxy.activitySlept(IActivityManager.java:6155)
	at android.app.ActivityThread.handleSleeping(ActivityThread.java:4499)
	at android.app.ActivityThread.access$2400(ActivityThread.java:235)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1867)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:6981)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1445)
Mar 15 2019, 9:07 PM · Wikipedia-Android-App-Backlog
Sharvaniharan created T218439: Crash report.
Mar 15 2019, 9:07 PM · Wikipedia-Android-App-Backlog
Sharvaniharan renamed T218438: Deep link is not working from Deep link is not working in to Deep link is not working .
Mar 15 2019, 8:43 PM · Wikipedia-Android-App-Backlog
Sharvaniharan created T218438: Deep link is not working .
Mar 15 2019, 8:42 PM · Wikipedia-Android-App-Backlog

Mar 14 2019

Sharvaniharan claimed T217373: Create feed card for editor tasks and update iconography.
Mar 14 2019, 9:50 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T217373: Create feed card for editor tasks and update iconography from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mar 14 2019, 9:50 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)
Sharvaniharan moved T217562: Update Info/help screen concept from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mar 14 2019, 9:35 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan moved T217170: Visual changes to translate descriptions from Doing to Blocked/Waiting on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mar 14 2019, 9:35 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan added a comment to T217562: Update Info/help screen concept.

@schoenbaechler I have used the same for link from 'Learn more' on the first time dialogs for both Add Title Description and Add Translate Description : https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5c378de9592d54299d1edc0e
https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5c05a008b19de10170816cd3

Mar 14 2019, 5:57 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Mar 13 2019

Sharvaniharan claimed T217562: Update Info/help screen concept.
Mar 13 2019, 5:29 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Mar 12 2019

Sharvaniharan added a comment to T217170: Visual changes to translate descriptions.

Thank you @schoenbaechler

Mar 12 2019, 7:16 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan moved T214504: Add activity for lists that contain X article + list links from Did not pass QA to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mar 12 2019, 6:01 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-UX-Debt
Sharvaniharan added a comment to T217170: Visual changes to translate descriptions.

CC - @Dbrant @cooltey ^

Mar 12 2019, 5:58 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan added a comment to T217170: Visual changes to translate descriptions.

@schoenbaechler Can we limit the Rtl support to in-app components only, and not change the direction of the support toolbar? Which would mean the translation card would be rtl, but the title and arrow and overflow would still be inline with the system language.

Mar 12 2019, 5:57 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan moved T216856: Article view does not show in the center in landscape mode on a tablet from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mar 12 2019, 4:19 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-Bugs

Mar 11 2019

Sharvaniharan moved T216856: Article view does not show in the center in landscape mode on a tablet from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mar 11 2019, 8:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-Bugs
Sharvaniharan claimed T216856: Article view does not show in the center in landscape mode on a tablet.
Mar 11 2019, 8:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-Bugs
Sharvaniharan added a comment to T214504: Add activity for lists that contain X article + list links.

@schoenbaechler according to our conversation, I have referenced the new color groups as 'chip_background_color' and 'chip_text_color'.

Mar 11 2019, 6:17 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-UX-Debt

Mar 8 2019

Sharvaniharan added a comment to T214504: Add activity for lists that contain X article + list links.

Thank you @schoenbaechler :)
So the background combination now would be

Mar 8 2019, 8:01 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-UX-Debt

Mar 7 2019

Sharvaniharan moved T214504: Add activity for lists that contain X article + list links from Code Review to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mar 7 2019, 8:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-UX-Debt

Mar 6 2019

Sharvaniharan moved T214504: Add activity for lists that contain X article + list links from Did not pass QA to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mar 6 2019, 6:54 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-UX-Debt
Sharvaniharan moved T217170: Visual changes to translate descriptions from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Mar 6 2019, 6:53 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan claimed T217170: Visual changes to translate descriptions.
Mar 6 2019, 6:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Feb 26 2019

Sharvaniharan moved T214504: Add activity for lists that contain X article + list links from Doing to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Feb 26 2019, 12:53 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-UX-Debt

Feb 15 2019

Sharvaniharan created T216277: Make Apptheme inherit from MaterialComponents/its descendants.
Feb 15 2019, 8:32 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Feb 14 2019

Sharvaniharan added a comment to T214504: Add activity for lists that contain X article + list links.

@schoenbaechler Could you please update the designs to reflect what should happen when page items have multiline descriptions?

Feb 14 2019, 11:12 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-UX-Debt
Sharvaniharan claimed T206855: mobile-html: Android prototype.
Feb 14 2019, 3:08 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi)

Feb 11 2019

Sharvaniharan updated the task description for T215255: Review app to find re-used translations.
Feb 11 2019, 6:24 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), I18n, Technical-Debt
Sharvaniharan placed T215255: Review app to find re-used translations up for grabs.
Feb 11 2019, 6:16 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), I18n, Technical-Debt
Sharvaniharan moved T215255: Review app to find re-used translations from Done to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Feb 11 2019, 6:16 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), I18n, Technical-Debt
Sharvaniharan added a comment to T215255: Review app to find re-used translations.

Ah! That would be the android.R.string.* strings. I assumed only the strings that were created and translated by us, but yes over all I guess they must be reviewed as well. Will move this back to ready-to-dev in that case. We can convert all those places to local strings, also making it a coding standard going forward not to use general android strings, maybe?

Feb 11 2019, 6:14 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), I18n, Technical-Debt
Sharvaniharan added a comment to T215255: Review app to find re-used translations.

I have taken care of "OK", "Cancel", "Yes", and "No" messages. Infact, all the strings are single use right now, other than the ones I documented here : https://docs.google.com/spreadsheets/d/1DNweLAylPjIZ1_Vmx7voZnDwdseB8QXzAvkrF0ZIeYE/edit?usp=sharing why I have ignored them. But yes, the ticket is far from done till we review the document and agree upon ignoring them... I just assumed it was, since the change was merged. Where should we move this to?

Feb 11 2019, 5:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), I18n, Technical-Debt
Sharvaniharan moved T214786: In the Wikipedia Android App, the onboarding_skip message is reused from Doing to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Feb 11 2019, 5:22 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), I18n, Android-app-Bugs
Sharvaniharan moved T215255: Review app to find re-used translations from Doing to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Feb 11 2019, 5:22 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), I18n, Technical-Debt
Sharvaniharan claimed T214504: Add activity for lists that contain X article + list links.
Feb 11 2019, 5:19 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-UX-Debt
Sharvaniharan moved T214504: Add activity for lists that contain X article + list links from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Feb 11 2019, 5:16 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-UX-Debt

Feb 7 2019

Sharvaniharan moved T215255: Review app to find re-used translations from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Feb 7 2019, 10:37 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi), I18n, Technical-Debt
Sharvaniharan moved T209539: On boarding screens for the App Editor task list from QA signoff to Ready for signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Feb 7 2019, 5:48 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan moved T209539: On boarding screens for the App Editor task list from Needs Design/Design doing to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Feb 7 2019, 4:29 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Feb 6 2019

Sharvaniharan claimed T214786: In the Wikipedia Android App, the onboarding_skip message is reused.
Feb 6 2019, 5:20 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), I18n, Android-app-Bugs
Sharvaniharan moved T214786: In the Wikipedia Android App, the onboarding_skip message is reused from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Feb 6 2019, 5:19 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), I18n, Android-app-Bugs

Feb 5 2019

Sharvaniharan moved T214492: Open “Explore“ search result item in the existing tab if it’s already open from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Feb 5 2019, 7:08 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Feb 1 2019

Sharvaniharan moved T214492: Open “Explore“ search result item in the existing tab if it’s already open from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Feb 1 2019, 7:32 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan moved T214492: Open “Explore“ search result item in the existing tab if it’s already open from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington) board.
Feb 1 2019, 7:32 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan claimed T214492: Open “Explore“ search result item in the existing tab if it’s already open.
Feb 1 2019, 7:32 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)
Sharvaniharan added a comment to T214492: Open “Explore“ search result item in the existing tab if it’s already open.

@Charlotte just one clarification needed:

Feb 1 2019, 7:31 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington)

Jan 28 2019

Sharvaniharan closed T214745: [Recurring BUG] 'About this article' section is overlapping as Invalid.

Part of the CSS outage. Will be automatically resolved when that is fixed.

Jan 28 2019, 11:53 PM · Wikipedia-Android-App-Backlog

Jan 26 2019

Sharvaniharan created T214745: [Recurring BUG] 'About this article' section is overlapping.
Jan 26 2019, 12:20 AM · Wikipedia-Android-App-Backlog

Jan 25 2019

Sharvaniharan created T214667: [BUG] Pages in a category are not shown .
Jan 25 2019, 4:02 AM · Wikipedia-Android-App-Backlog
Sharvaniharan renamed T214666: [BUG] Offline articles get deleted after a few days from [BUG} Offline articles get deleted after a few days to [BUG] Offline articles get deleted after a few days.
Jan 25 2019, 3:50 AM · Wikipedia-Android-App-Backlog, Android-app-Bugs
Sharvaniharan renamed T214666: [BUG] Offline articles get deleted after a few days from Offline articles get deleted after a few days to [BUG} Offline articles get deleted after a few days.
Jan 25 2019, 3:50 AM · Wikipedia-Android-App-Backlog, Android-app-Bugs
Sharvaniharan created T214666: [BUG] Offline articles get deleted after a few days.
Jan 25 2019, 3:49 AM · Wikipedia-Android-App-Backlog, Android-app-Bugs

Jan 16 2019

Sharvaniharan added a comment to T207334: Create a UI for Translating title descriptions (within the App Editor Tasks list).

The translation unlock logic is solely based on the number of user edits being more than 1 [2 or more], which causes these conflicts:
"1. What happens if the user unlocks the edit feed by making the very first edit, sees unlock dialog, hits ‘Maybe later’ and goes on to read few more articles and along the way makes description edits? Let us say user made 3 edits.
Now the indicator dot is seen, the user visits the edit feed page,
A. Should both title and translate description options be unlocked and available now?
B. If user hits on ‘Add Title Descriptions’ , both first time title edit dialog and translate unlock dialog are now waiting to be shown. Should they both be shown one after the other? Should the translate unlock not appear? Should translate unlocked dialog have appeared anywhere wherever the 2nd edit was made?
C. What happens if the user enters the edit feed, chooses not to hit 'Add Title Descriptions’ , but hits ‘Translate Title Descriptions’ which will now be unlocked. When they next visit 'Add Title Descriptions’ obviously the translate unlock dialog doesn't make sense, so should we include logic to track that and not show translation unlock dialog?"

Jan 16 2019, 8:59 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-Description-Editing
Sharvaniharan updated the task description for T211109: Create testable prototype for user testing the Edit action queue (add and translate title descriptions only).
Jan 16 2019, 2:43 AM · Patch-For-Review, Wikidata, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-Description-Editing
Sharvaniharan updated the task description for T211109: Create testable prototype for user testing the Edit action queue (add and translate title descriptions only).
Jan 16 2019, 2:01 AM · Patch-For-Review, Wikidata, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-Description-Editing

Jan 15 2019

Sharvaniharan added a comment to T211109: Create testable prototype for user testing the Edit action queue (add and translate title descriptions only).

@schoenbaechler @RHo @dchen @Charlotte final apk link has been updated.

Jan 15 2019, 5:48 AM · Patch-For-Review, Wikidata, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-Description-Editing
Sharvaniharan updated the task description for T211109: Create testable prototype for user testing the Edit action queue (add and translate title descriptions only).
Jan 15 2019, 5:46 AM · Patch-For-Review, Wikidata, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-Description-Editing
Sharvaniharan updated the task description for T211109: Create testable prototype for user testing the Edit action queue (add and translate title descriptions only).
Jan 15 2019, 5:44 AM · Patch-For-Review, Wikidata, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-Description-Editing
Sharvaniharan updated the task description for T211109: Create testable prototype for user testing the Edit action queue (add and translate title descriptions only).
Jan 15 2019, 5:43 AM · Patch-For-Review, Wikidata, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-Description-Editing

Jan 14 2019

Sharvaniharan added a comment to T211109: Create testable prototype for user testing the Edit action queue (add and translate title descriptions only).

@cmadeo Thank you for the suggestions. I was actually able to have a chat with @schoenbaechler before he left for the day and he was able to clarify. Other than the last point , the back button functionality... rest were the same. Will re-confirm with him tomorrow.

Jan 14 2019, 11:15 PM · Patch-For-Review, Wikidata, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-Description-Editing
Sharvaniharan added a comment to T211109: Create testable prototype for user testing the Edit action queue (add and translate title descriptions only).

User hasn’t set multiple languages in the app’s settings:
Title: Translate title descriptions
Description: Translation tasks are available if you read and write in more than one Wikipedia language.
Actions: Not for me | Add languages

Jan 14 2019, 8:16 PM · Patch-For-Review, Wikidata, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington), Android-app-feature-Description-Editing