Fri, Oct 18
Thu, Oct 10
Tue, Oct 8
Mon, Oct 7
@schoenbaechler thank you for all the updated icons :-)
Fri, Oct 4
Wed, Oct 2
Mon, Sep 30
@schoenbaechler the circle with accent background is rendering differently,
Thu, Sep 26
@schoenbaechler for completion sake can we add green90 to our palette and have a group.. even if it is just the same color for all themes?
Thank you @schoenbaechler
@schoenbaechler thank you for the above clarifications. Couple more
1.is this tool tip text finalized?:
Tue, Sep 24
@Dbrant thats is a good point.. I did not try to reproduce it after fixing it... steps to a possible reproduction would be... re-install both the opera and opera mini apps on the phone and set a default browser and try to open an external link from the app.
Also while we are at it... need a few confirmations:
All text color is material_theme_secondary_color [color_group_30]?
The all-caps headings are material_theme_primary_color [color_group_40]?
Stats icons size is 32 x 32?
Task icon is 48 x 48 background circle, and image 24 x 24 ?
@schoenbaechler thank you for all the clarifications above. One more :-)
I did not find a color group for the inner circle background for Edit quality stats icon:
is it #d5fdf4 in light mode?
I inspected this bug on @JKatzWMF phone yesterday and here are my findings @Charlotte
The root cause was that when a default app is chosen for browsing, under settings -> apps ->Default apps
If that app is incapable of opening our links, we get this message. I resolved this on Jon’s phone by deleting the opera browser, which started working properly but was still choosing Chrome automatically. However resetting the default preferences, started showing a chooser with all the available browsers as expected.
Sep 20 2019
Thank you @schoenbaechler! Will do this.
@Jhernandez Of the 4 things required to display stats, this is what I feel we would need
Sep 18 2019
Is there a zeplin mock up for this... It is ok if we don't, I was able to guess most measurements ... and we can fix the styles during review.
@schoenbaechler Couple things:
Sep 17 2019
Sep 13 2019
@Charlotte I agree. This ticket should at least be about better messages conditionally, if the bug itself is not reproducible[DDoS attack was my guess too].
My best guess is that the user is referring to copying the url of the article through the share menu - 'Copy to Clipboard' utility. It is working fine in the current production version:
Sep 12 2019
Resolved @schoenbaechler! Lmk if it all looks good.
perfect! thank you @Charlotte
Just for process... approved screenshot.
Sep 11 2019
Sep 10 2019
Sep 5 2019
Aug 29 2019
Aug 26 2019
Aug 23 2019
Aug 9 2019
Aug 6 2019
Jul 31 2019
Jul 30 2019
@schoenbaechler I found that the root cause for this is that, on Gallery cta, we hide the explicit cta, since we have the edit button, only when there is neither structured nor unstructured caption available. However, we show it when there is an unstructured caption available, but no structured. However, on article cta we show in either case, which i feel is what should be the case. I have created a PR for correcting this logic, but please let me know if we need to do otherwise.
I have merged it... and I did not completely understand 1) - is it that for any random image which doesn't have a structured caption in primary language, only sometimes the article CTA is shown and other times it is not? - I could not reproduce that.
Jul 29 2019
Merged... @schoenbaechler ready for sign-off
Moved back to design sign-off @schoenbaechler
Thank you for making this change @cooltey . Appreciate it. Will move it .
Jul 26 2019
@schoenbaechler ready for sign-off
Jul 25 2019
Thank you @bearND
Jul 24 2019
You are right @bearND. Sorry about that , we don't need the purpose attribute. That is derived natively.
Jul 23 2019
@JoeWalsh I don't see structured captions in the response. For example for the file File:Billy_Joel_Shankbone_NYC_2009
@schoenbaechler @Charlotte This is a blocking bug that happens because of an unexpected response from the api returning structured edits. We will have to notify RI team and will be blocked until it is resolved. Great catch @schoenbaechler
Also, generally when the user is reading the article in secondary language and opens the gallery, but there is no structured caption present in that language, it should fallback to the primary language, or to the unstructured caption in the secondary language.
- @schoenbaechler Thank you ..Will fix this.
The green color in the snackbar for action button is a standard across the app in all the places where we use this kind of snackbar. We set it all in just one place. Can I change it so it is color-group-3 for all, or should we leave it green to maintain uniformity, or should this be different?
Jul 22 2019
@schoenbaechler ready for sign off!