User Details
- User Since
- Aug 23 2017, 3:03 PM (347 w, 6 d)
- Availability
- Available
- LDAP User
- Sharvaniharan
- MediaWiki User
- SHaran (WMF) [ Global Accounts ]
Mon, Apr 1
Mar 22 2024
Hi @scblr
Updated this:
If this looks too busy I can dismiss the bottomsheet and show a toast.
Thank you.
Mar 20 2024
Good catch @scblr ! :-)
Here is the fix:
https://youtube.com/shorts/I9kCzTe-DXA
Thank you. makes sense. Put in the change:
I have fixed 1), 2) and 4)
Mar 19 2024
I fixed the toast message and made a short screen rec in case you did not easily find a stub article to edit. Feel free to use the same to test it out.: https://youtu.be/zapBN4O915M
[Took a while to publish the edit to the testwiki article but I don't think this is a typical delay for real wikis]
Mar 18 2024
Hi @scblr ,
This is ready for review. However few things I wanted to highlight:
Mar 14 2024
Hi @scblr
Have fixed 1) annd 3), but have a question about 2) about how you are envisioning the edit message change:
a: It would be hard to have a link-specific message like how you are suggesting, because we will have to remember that for all links that get accessed in that session, which is cumbersome.
b: If you want the dialog to stay active when we go to edit mode, we can update when we come back, but if the user dismisses the dialog and then visits it again, they will see the original stub placeholder text and not the shorter one.
c: Best possible solution can be to update the toast message to indicate that they wont see a change in preview for that link immediately. So instead of Edit published! which is displayed now, we can have Edit published! It might take some time before you see your contribution in the preview - something like that?
Mar 8 2024
Minor question:
b) Looks like, from the designs, that we have removed the title from messages. Every message has a subject and message, but no longer, the title. This is a very welcome change and easier to manage. However, that means we will need to remove the need to add a title on 6. Please confirm this, so I can remove titles.
Yes, exactly; we removed this to make it more straightforward. Any ideas on how we could migrate users that have a title and a subject? I suggest to simply remove titles as the subject will be self-explanatory. Thoughts?
Could you please check this again: https://github.com/wikimedia/apps-android-wikipedia/pull/4465/checks. I was able to download.. but if you have problems again, I will create a separate branch.
Thank you.
Mar 6 2024
Mar 1 2024
I have a few questions as I started implementing:
Feb 29 2024
A new version of beta was re-released with some minor fixes @ABorbaWMF - have updated the links in description.
Feb 26 2024
Feb 23 2024
Still wip, as I need your input on this. Can be tested here:
https://github.com/wikimedia/apps-android-wikipedia/pull/4465/checks
Feb 20 2024
Hi @scblr
Thank you for all the work on this! All translations look great!
Thank you @satdeep_gill !🙌
Feb 15 2024
Feb 14 2024
Feb 9 2024
Feb 8 2024
Feb 7 2024
@scblr
I have updated the google sheet. Please review when you get a chance. thank you.
I remember we wanted to have a custom release not for Places. Given that the release is scheduled for next week, should we add the notes to the translation request?
Feb 6 2024
Thank you for checking-in on the translations. I took a closer look into the Hindi translations, and I found that there were other strings where:
- Even though in the Hindi alphabet, they were transliterations instead of Hindi equivalent translation of the words.
- We use | for period in Hindi instead of . . Have changed this.
- In a few places there was a space missing between words
- Very minor grammatical errors [Singular/plural]
Can this be moved to Merged and waiting?
Feb 3 2024
Thank you for letting me know.
Few things we probably need to change on the sheet:
- Explore nearby Wikipedia articles with 'Places' the copy has changed to Discover Wikipedia articles around you with Places
- Saved needs translation
- Unwatch needs translation
- What would you like us to change or improve? needs translation
- Location permission is required to see your location on the map. Please try again. needs translation
Not sure if I could add them to the sheet directly, so reporting here.
Feb 2 2024
Feb 1 2024
Hi @scblr
Sorry. Looks like one change did not get pushed correctly. You should be able to see the change now. Thank you.
This is ready for review.
APK: https://github.com/wikimedia/apps-android-wikipedia/pull/4428/checks
Jan 31 2024
Jan 30 2024
Thank you for looking into this.
Jan 29 2024
Update: Synced with @JTannerWMF about the main nav tooltip and she wants it to be displayed on second launch of the app, so I have added that changes as well.
This is ready for review here: https://github.com/wikimedia/apps-android-wikipedia/pull/4412/checks
Just confirming that we are no more using the copy on screen image 3. -> How can 'Places' be improved?
This was worked as part of places discovery task: T355302. So there might not be a need to re-review, but just updating here to keep track.
I will move this to Code review when places task gets moved.
Thank you :-)
Hi @scblr
Thank you for the update. This is ready for review.
APK: https://github.com/wikimedia/apps-android-wikipedia/pull/4407/checks
Jan 26 2024
I have fixed the survey feedback triggers. To clarify,
Very Satisfied - Takes user straight to tooltip - screen 4
Satisfied - Takes user straight to tooltip - screen 4
Neutral - Takes user to screen 2, but with title as How can 'Places' be improved?
Unsatisfied - Takes user to screen 2, but with title as What would you like us to change or improve?
Very unsatisfied - Takes user to screen 2, but with title as What would you like us to change or improve?
@cooltey 's work on this task was merged to the main feature branch, so the location of APK changed because of that : https://github.com/wikimedia/apps-android-wikipedia/pull/4182/checks
Have updated this on the task as well. Just leaving you a note too so you do not miss :-)
Jan 25 2024
Thank you for the review @scblr . Will update this once you have had a chance to discuss this and update here.
- Thank you for reviewing. I have updated the dialog with more granular options and a cancel button. So 1 and 3 are done.
- Also wanted to let you know about another choice we have with the dialog for 3, as in we can just make it cancelable, which would dismiss it when user clicks anywhere outside of the dialog, like the Empty form screen behavior.
- Will work on 2 once you have had a chance to discuss and update.
Jan 24 2024
This work is done. Please review the survey placement and let me know your thoughts
APK for testing: https://github.com/wikimedia/apps-android-wikipedia/pull/4412/checks
Jan 23 2024
On PT we have just 3 options.
Just wanted to make sure you want to add the Very satisfied and Very unsatisfied for this, or keep it the same as PT? - Keeping in mind that it is not any added work at all to add them to existing screens.