Sharvaniharan (Sharvaniharan)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 23 2017, 3:03 PM (35 w, 17 h)
Availability
Available
LDAP User
Sharvaniharan
MediaWiki User
Unknown

Recent Activity

Yesterday

Sharvaniharan moved T188463: Provide an option to manually sync reading lists from Did not pass QA to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Wed, Apr 25, 10:53 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt
Sharvaniharan moved T190922: Add language detection and selection to app onboarding from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Wed, Apr 25, 10:52 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan moved T116841: Standardize footer across mobile apps with addition of an "About this article" footer menu from Backlog to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Wed, Apr 25, 10:52 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-feature-UX-Debt, Wikipedia-iOS-App-Backlog, wikimedia-page-library, Android-app-feature-Navigation
Sharvaniharan moved T190839: Enable searching Wikipedia in multiple app languages from Blocked/Waiting to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Wed, Apr 25, 10:52 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan moved T116841: Standardize footer across mobile apps with addition of an "About this article" footer menu from Android-app-release-v2.7.24x-H-Hot-pepper to Android-app-release-v2.7.24x-I-Ice-lolly on the Wikipedia-Android-App-Backlog board.
Wed, Apr 25, 10:51 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-feature-UX-Debt, Wikipedia-iOS-App-Backlog, wikimedia-page-library, Android-app-feature-Navigation
Sharvaniharan added a comment to T190922: Add language detection and selection to app onboarding.

@RHo this is ready for a design review..

Wed, Apr 25, 10:32 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan claimed T192534: Missing Save this article bookmark on "Read more" section of article footer.
Wed, Apr 25, 7:40 PM · Wikipedia-Android-App-Backlog
Sharvaniharan added a comment to T188463: Provide an option to manually sync reading lists .

@RHo above patch should fix the other two issues : 8dp top and bottom padding, and swapping of functionality.

Wed, Apr 25, 6:36 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt
Sharvaniharan added a comment to T188463: Provide an option to manually sync reading lists .

Height of menu item should be 48dp as of now... does it show differently to you @RHo

Wed, Apr 25, 6:34 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt
Sharvaniharan added a comment to T183018: [BUG] Edit icons shown on article section headings are too big and are misaligned.

Related patch : https://gerrit.wikimedia.org/r/#/c/425606/

Wed, Apr 25, 4:44 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-feature-UX-Debt, Android-app-Bugs
Sharvaniharan added a comment to T183018: [BUG] Edit icons shown on article section headings are too big and are misaligned.

@RHo please review this.

Wed, Apr 25, 4:39 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-feature-UX-Debt, Android-app-Bugs

Tue, Apr 24

Sharvaniharan moved T190922: Add language detection and selection to app onboarding from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Tue, Apr 24, 8:40 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan claimed T190922: Add language detection and selection to app onboarding.
Tue, Apr 24, 8:40 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan moved T190839: Enable searching Wikipedia in multiple app languages from Doing to Blocked/Waiting on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Tue, Apr 24, 4:25 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan moved T183018: [BUG] Edit icons shown on article section headings are too big and are misaligned from Blocked/Waiting to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Tue, Apr 24, 12:10 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-feature-UX-Debt, Android-app-Bugs

Mon, Apr 23

Sharvaniharan moved T191794: Remove usage of single app code after all multilingual changes from Ready for dev to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Mon, Apr 23, 1:16 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly)
Sharvaniharan closed T191794: Remove usage of single app code after all multilingual changes as Resolved.
Mon, Apr 23, 1:15 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly)

Tue, Apr 17

Sharvaniharan moved T188463: Provide an option to manually sync reading lists from Did not pass QA to Design signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Tue, Apr 17, 7:34 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt

Fri, Apr 13

Sharvaniharan added a comment to T190839: Enable searching Wikipedia in multiple app languages.

Yes @Rita we should... i will put something on calendar. I have more questions about showing recent search in languages, should area below tabs be swipeable, etc..

Fri, Apr 13, 7:20 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan added a comment to T190839: Enable searching Wikipedia in multiple app languages.

@RHo I am assuming the languages tab layout should not be visible at this point:

Fri, Apr 13, 5:55 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual

Thu, Apr 12

Sharvaniharan added a comment to T190839: Enable searching Wikipedia in multiple app languages.
Thu, Apr 12, 12:38 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan moved T190839: Enable searching Wikipedia in multiple app languages from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Thu, Apr 12, 12:20 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual
Sharvaniharan claimed T190839: Enable searching Wikipedia in multiple app languages.
Thu, Apr 12, 12:14 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-Multilingual

Wed, Apr 11

Sharvaniharan closed T191673: Update SSH key in production hosts for @Sharvaniharan as Resolved.
Wed, Apr 11, 1:10 PM · Patch-For-Review, Operations
Sharvaniharan added a comment to T191673: Update SSH key in production hosts for @Sharvaniharan.

finally!!!! I was able to ssh into releases1001 and stat1006!

Wed, Apr 11, 1:04 PM · Patch-For-Review, Operations
Sharvaniharan added a comment to T191673: Update SSH key in production hosts for @Sharvaniharan.

yes... I was looking in the wrong directory... I have updated my comment to reflect the contents of /etc/ssh/ssh_config

Wed, Apr 11, 12:59 PM · Patch-For-Review, Operations
Sharvaniharan added a comment to T191673: Update SSH key in production hosts for @Sharvaniharan.
wmf2050:~ sharan$ ssh-add -L releases1001.eqiad.wmnet
The agent has no identities.
Wed, Apr 11, 12:48 PM · Patch-For-Review, Operations
Sharvaniharan added a comment to T191673: Update SSH key in production hosts for @Sharvaniharan.

This is what I have in etc/ssh

Wed, Apr 11, 12:47 PM · Patch-For-Review, Operations
Sharvaniharan added a comment to T191673: Update SSH key in production hosts for @Sharvaniharan.

@MoritzMuehlenhoff please let me know if a hangout would be better. I will be available for the next hour and then anytime after 9am Pacific time.

Wed, Apr 11, 12:33 PM · Patch-For-Review, Operations
Sharvaniharan added a comment to T191673: Update SSH key in production hosts for @Sharvaniharan.

My config looks like this now..

Wed, Apr 11, 12:32 PM · Patch-For-Review, Operations

Tue, Apr 10

Sharvaniharan added a comment to T191673: Update SSH key in production hosts for @Sharvaniharan.

Do you want to do a quick hangout?

Tue, Apr 10, 11:44 PM · Patch-For-Review, Operations
Sharvaniharan added a comment to T191673: Update SSH key in production hosts for @Sharvaniharan.

I am still getting the same error after changing username to sharvaniharan

Tue, Apr 10, 11:44 PM · Patch-For-Review, Operations
Sharvaniharan added a comment to T191673: Update SSH key in production hosts for @Sharvaniharan.

@Dzahn my new key for production is not an rsa key, it is a ed25519 key. While we are doing this exercise, could you please update it to the new rsa key i am attaching here.. prod_key.pub?

Tue, Apr 10, 11:14 PM · Patch-For-Review, Operations
Sharvaniharan added a comment to T191673: Update SSH key in production hosts for @Sharvaniharan.

@Dzahn please let me know if being on a hangout or remote access would help you.. I am open to it.

Tue, Apr 10, 11:01 PM · Patch-For-Review, Operations
Sharvaniharan added a comment to T191673: Update SSH key in production hosts for @Sharvaniharan.
## Use bastion-eqiad.wmflabs.org as proxy to labs
Host bastlabs
HostName bastion-eqiad.wmflabs.org
User sharan
IdentityFile ~/.ssh/id_rsa
Tue, Apr 10, 7:08 PM · Patch-For-Review, Operations
Sharvaniharan added a comment to T191673: Update SSH key in production hosts for @Sharvaniharan.

I am unable to ssh into releases1001 or stat1006.eqiad.wmnet after the changes.. @MarcoAurelio @MoritzMuehlenhoff

Tue, Apr 10, 6:54 PM · Patch-For-Review, Operations

Mon, Apr 9

Sharvaniharan moved T191332: Create technical underpinnings for multi-language support. from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Mon, Apr 9, 1:36 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly)
Sharvaniharan created T191794: Remove usage of single app code after all multilingual changes.
Mon, Apr 9, 1:33 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly)
Sharvaniharan moved T191332: Create technical underpinnings for multi-language support. from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly) board.
Mon, Apr 9, 12:01 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly)
Sharvaniharan claimed T191332: Create technical underpinnings for multi-language support..
Mon, Apr 9, 11:48 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly)

Fri, Apr 6

Sharvaniharan created T191673: Update SSH key in production hosts for @Sharvaniharan.
Fri, Apr 6, 10:03 PM · Patch-For-Review, Operations

Thu, Apr 5

Sharvaniharan moved T183018: [BUG] Edit icons shown on article section headings are too big and are misaligned from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Thu, Apr 5, 10:45 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-feature-UX-Debt, Android-app-Bugs
Sharvaniharan added a comment to T183018: [BUG] Edit icons shown on article section headings are too big and are misaligned.

Some screenshots on how it will look once the changes are merger. @RHo let me know if anything looks off:

Thu, Apr 5, 9:49 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-feature-UX-Debt, Android-app-Bugs

Wed, Apr 4

Sharvaniharan added a comment to T180000: Enable page titles to be shown completely.

Not bad at all!

Wed, Apr 4, 4:39 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Technical-Debt

Tue, Apr 3

Sharvaniharan moved T188691: [EspressoTest] Update the Wikimedia Apps/Team/Android/App hacking page from Code Review to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Tue, Apr 3, 5:24 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-Bugs
Sharvaniharan added a comment to T180000: Enable page titles to be shown completely.

@RHo I played around with different heights and the preset text sizes 24sp - 28sp with granularity of 1sp [decreaments of 1sp while trying to resize]. I see no best-fit scenarios at all.
-Cannot add ellipsis.
-Cuts off the last line of text in some cases
-If the height is increased, then the small titles start looking funny

  • Even if you decide on a smaller text size, some long titles may still be rendered badly, getting cut-off on the last line..

Tue, Apr 3, 3:47 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Technical-Debt

Mon, Apr 2

Sharvaniharan added a comment to T191253: Wrong translation between chinese variants.

I have also asked the user for more details : Article name.

Mon, Apr 2, 10:57 PM · MediaWiki-Language-converter, Chinese-Sites, Wikipedia-Android-App-Backlog
Sharvaniharan created T191253: Wrong translation between chinese variants.
Mon, Apr 2, 10:53 PM · MediaWiki-Language-converter, Chinese-Sites, Wikipedia-Android-App-Backlog
Sharvaniharan created T191251: The bottom navigation bar is inconsistent with the latest Google apps.
Mon, Apr 2, 10:47 PM · Wikipedia-Android-App-Backlog
Sharvaniharan edited projects for T191246: Text rendering next to tables on mobile dewp, added: Reading-Web-Local-Wiki-Issues; removed Wikipedia-Android-App-Backlog.
Mon, Apr 2, 10:27 PM · Reading-Web-Local-Wiki-Issues
Sharvaniharan created T191246: Text rendering next to tables on mobile dewp.
Mon, Apr 2, 10:12 PM · Reading-Web-Local-Wiki-Issues
Sharvaniharan created T191241: Update espresso tests.
Mon, Apr 2, 8:08 PM · Wikipedia-Android-App-Backlog
Sharvaniharan moved T178163: Add transitions when users interacts with feed content from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Mon, Apr 2, 3:05 PM · Wikipedia-Android-App-Backlog, Android-app-feature-Feeds, Android-app-feature-UX-Debt

Sun, Apr 1

Sharvaniharan moved T178163: Add transitions when users interacts with feed content from Code Review to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Sun, Apr 1, 8:52 PM · Wikipedia-Android-App-Backlog, Android-app-feature-Feeds, Android-app-feature-UX-Debt
Sharvaniharan moved T178163: Add transitions when users interacts with feed content from Backlog to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Sun, Apr 1, 8:52 PM · Wikipedia-Android-App-Backlog, Android-app-feature-Feeds, Android-app-feature-UX-Debt

Fri, Mar 30

Sharvaniharan claimed T178163: Add transitions when users interacts with feed content.
Fri, Mar 30, 5:50 PM · Wikipedia-Android-App-Backlog, Android-app-feature-Feeds, Android-app-feature-UX-Debt

Thu, Mar 29

Sharvaniharan moved T183018: [BUG] Edit icons shown on article section headings are too big and are misaligned from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Thu, Mar 29, 10:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-feature-UX-Debt, Android-app-Bugs
Sharvaniharan claimed T183018: [BUG] Edit icons shown on article section headings are too big and are misaligned.
Thu, Mar 29, 9:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-feature-UX-Debt, Android-app-Bugs
Sharvaniharan added a comment to T180000: Enable page titles to be shown completely.

Min of 24sp only offers a slight improvement to current title without autosizing:

Thu, Mar 29, 5:43 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Technical-Debt
Sharvaniharan added a comment to T180000: Enable page titles to be shown completely.
Thu, Mar 29, 5:25 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Technical-Debt
Sharvaniharan added a comment to T180000: Enable page titles to be shown completely.
Thu, Mar 29, 5:21 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Technical-Debt
Sharvaniharan added a comment to T180000: Enable page titles to be shown completely.

@RHo here are a few examples with 24sp minimum and 28sp maximum:

Thu, Mar 29, 5:21 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Technical-Debt
Sharvaniharan moved T172283: Improve the ease of viewing individual citations references grouped together from Doing to Blocked/Waiting on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Thu, Mar 29, 4:09 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-UX-Debt

Wed, Mar 28

Sharvaniharan updated subscribers of T66281: Handle edit conflicts on the mobile app in some way.

@RHo : When there is an edit conflict, we advice the user to copy content and go back and refresh, and then when the user tries to exit, we still show the dialog asking the user to save changes. If we should not show that dialog once we show the conflict dialog, could you please open a ticket for that? : https://youtu.be/_gX9RMGnF7g

Wed, Mar 28, 5:27 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), WorkType-NewFunctionality

Tue, Mar 27

Sharvaniharan moved T172283: Improve the ease of viewing individual citations references grouped together from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Tue, Mar 27, 4:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-UX-Debt
Sharvaniharan moved T116841: Standardize footer across mobile apps with addition of an "About this article" footer menu from Doing to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Tue, Mar 27, 4:08 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-feature-UX-Debt, Wikipedia-iOS-App-Backlog, wikimedia-page-library, Android-app-feature-Navigation
Sharvaniharan moved T189731: Image title is different in open and close events in Gallery funnel from Code Review to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Tue, Mar 27, 4:07 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper)

Mar 26 2018

Sharvaniharan claimed T172283: Improve the ease of viewing individual citations references grouped together.
Mar 26 2018, 10:11 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Android-app-feature-UX-Debt
Sharvaniharan moved T189731: Image title is different in open and close events in Gallery funnel from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Mar 26 2018, 9:05 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper)
Sharvaniharan moved T189731: Image title is different in open and close events in Gallery funnel from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Mar 26 2018, 5:22 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper)
Sharvaniharan claimed T189731: Image title is different in open and close events in Gallery funnel.
Mar 26 2018, 5:21 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper)

Mar 23 2018

Sharvaniharan updated subscribers of T172117: Fix rounded corners of Explore feed overflow menu on API 19.

@RHo Dmitry put in a fix and now we have no border on 19, there is no portion being cut-off on the right... however, the corner couldn't be rounded off without having that white border... Can we call this a win and close this? ;-)

Mar 23 2018, 1:17 AM · Wikipedia-Android-App-Backlog, Patch-For-Review, Android-app-feature-UX-Debt
Sharvaniharan added a comment to T180000: Enable page titles to be shown completely.

@RHo do you want a particular height for the title view, a particular minimum text size, or do you want me to play around?

Mar 23 2018, 12:09 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Technical-Debt

Mar 22 2018

Sharvaniharan moved T184661: [BUG] Bottom section momentarily overlaps content for articles with very short lead section. from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Mar 22 2018, 4:46 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Patch-For-Review, Android-app-Bugs
Sharvaniharan moved T188463: Provide an option to manually sync reading lists from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Mar 22 2018, 4:45 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt
Sharvaniharan moved T188328: [UX-debt] Provide an ability to create lists from the ‘My lists’ screen from Code Review to QA signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Mar 22 2018, 4:45 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt
Sharvaniharan closed T148685: When a page is refreshed by the user and the network is unavailable, show a message to the user as Resolved.

Resolved by : https://gerrit.wikimedia.org/r/#/c/420127/

Mar 22 2018, 4:45 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt
Sharvaniharan moved T180000: Enable page titles to be shown completely from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Mar 22 2018, 4:43 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Technical-Debt
Sharvaniharan claimed T180000: Enable page titles to be shown completely.
Mar 22 2018, 4:43 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Technical-Debt
Sharvaniharan added a comment to T116841: Standardize footer across mobile apps with addition of an "About this article" footer menu.

Thanks @RHo

Mar 22 2018, 1:40 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-feature-UX-Debt, Wikipedia-iOS-App-Backlog, wikimedia-page-library, Android-app-feature-Navigation

Mar 21 2018

Sharvaniharan added a comment to T116841: Standardize footer across mobile apps with addition of an "About this article" footer menu.

Whilst the "About this article" footer menu is largely implemented, there are some visual design deviations in the mocks shown in the description and Zeplin, namely:

  • Menu titles should all be written as actions (eg. "View talk page" rather than "Talk")
  • Icons should be updated

    Actual:
Mar 21 2018, 11:45 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-feature-UX-Debt, Wikipedia-iOS-App-Backlog, wikimedia-page-library, Android-app-feature-Navigation
Sharvaniharan moved T116841: Standardize footer across mobile apps with addition of an "About this article" footer menu from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Mar 21 2018, 5:00 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-feature-UX-Debt, Wikipedia-iOS-App-Backlog, wikimedia-page-library, Android-app-feature-Navigation

Mar 20 2018

Sharvaniharan claimed T116841: Standardize footer across mobile apps with addition of an "About this article" footer menu.
Mar 20 2018, 7:03 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-I-Ice-lolly), Patch-For-Review, Android-app-feature-UX-Debt, Wikipedia-iOS-App-Backlog, wikimedia-page-library, Android-app-feature-Navigation
Sharvaniharan moved T171856: [BUG] Overflow menu on article lists are misaligned from Code Review to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Mar 20 2018, 6:07 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt, Android-app-Bugs
Sharvaniharan moved T188691: [EspressoTest] Update the Wikimedia Apps/Team/Android/App hacking page from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Mar 20 2018, 6:07 AM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-Bugs

Mar 19 2018

Sharvaniharan moved T188691: [EspressoTest] Update the Wikimedia Apps/Team/Android/App hacking page from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Mar 19 2018, 5:37 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-Bugs
Sharvaniharan claimed T188691: [EspressoTest] Update the Wikimedia Apps/Team/Android/App hacking page.
Mar 19 2018, 4:01 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-Bugs

Mar 16 2018

Sharvaniharan moved T148685: When a page is refreshed by the user and the network is unavailable, show a message to the user from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Mar 16 2018, 4:14 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt
Sharvaniharan claimed T148685: When a page is refreshed by the user and the network is unavailable, show a message to the user.
Mar 16 2018, 4:14 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt

Mar 13 2018

Sharvaniharan moved T184661: [BUG] Bottom section momentarily overlaps content for articles with very short lead section. from Backlog to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Mar 13 2018, 7:06 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Patch-For-Review, Android-app-Bugs
Sharvaniharan edited projects for T184661: [BUG] Bottom section momentarily overlaps content for articles with very short lead section., added: Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper); removed Wikipedia-Android-App-Backlog.
Mar 13 2018, 7:06 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Patch-For-Review, Android-app-Bugs

Mar 12 2018

Sharvaniharan claimed T189035: Change how font size switching is logged.
Mar 12 2018, 5:18 PM · Patch-For-Review, Discovery-Analysis, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper)
Sharvaniharan moved T188328: [UX-debt] Provide an ability to create lists from the ‘My lists’ screen from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Mar 12 2018, 5:08 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt

Mar 8 2018

Sharvaniharan moved T188463: Provide an option to manually sync reading lists from Ready for dev to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Mar 8 2018, 9:32 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt
Sharvaniharan moved T188328: [UX-debt] Provide an ability to create lists from the ‘My lists’ screen from Backlog to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper) board.
Mar 8 2018, 9:31 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt
Sharvaniharan edited projects for T188328: [UX-debt] Provide an ability to create lists from the ‘My lists’ screen, added: Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper); removed Wikipedia-Android-App-Backlog.
Mar 8 2018, 9:31 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt
Sharvaniharan claimed T188328: [UX-debt] Provide an ability to create lists from the ‘My lists’ screen.
Mar 8 2018, 9:29 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt
Sharvaniharan added a comment to T188463: Provide an option to manually sync reading lists .

Thanks Rita! will do that!

Mar 8 2018, 6:57 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt
Sharvaniharan added a comment to T188463: Provide an option to manually sync reading lists .

Also, wondering if we should be having this option at individual list screen as well?

Mar 8 2018, 6:43 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt
Sharvaniharan added a comment to T188463: Provide an option to manually sync reading lists .

@RHo should the option be invisible if:

Mar 8 2018, 6:39 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.24x-H-Hot-pepper), Android-app-feature-UX-Debt