Add descriptions has been unlocked (3 non-reverted edits): Daily suggestions for “Add descriptions“ are shown in the feed.

Thank you @schoenbaechler!

yes, @Charlotte ! moving it to done.

@schoenbaechler Could you please let me know the margins when there is no image?

@schoenbaechler
My guess is that it is their custom component which is not exposed to us..[ I will look around if there is a function call to make it behave differently]

Hmm interesting, I find it’s poorly designed with that huge gap. What component is Google Translate using here?

Thanks for the clarifications @schoenbaechler
For point 03, we are not doing any particular trasition here, it is just the system transition. The only improvement to the transition between the Activities that we can do is to fade-out first and fade-in next activity. I tried thta, but I don't feel it looks all that good...Check it out.. Even assuming we do something about the keyboard coming up after the animation... looks unnecessarily dramatic.:

03 Related to transitioning from one screen to another (also affects T217169): is there a way to avoid the page jump at the top when arriving in the editing interface? (Observe “English description“ & “Beach of Portugal“ in the video below):

page-jump-after-load.mp41 MBDownload

Unable to makeout the difference between the two 😂 . Can I refer to zeplin and make it 9dp margin on top and 19dp on bottom?

02 Move plus icon and label ("Add German translation") 12dp lower (the values in sp are still a mystery to me). Please use the “After“ screenshot below (Pixel 3) to adjust the position accordingly.

Before	After

We are using a system component for this, and it changes the space between the label and arrow according to the longest entry in the list. For eg: This is how it looks with a really long named language:

@schoenbaechler ready for review..

ok cool! that makes it easier then..

@schoenbaechler so other main reason for a separate ticket was to group them and further give the user an option to individually turn them on/off as well... so which would mean, we indicate in ui that 'Suggested edits' is a group, and on clicking it, it will expose the various types of cards grouped under it.. like suggested edit add description, suggested edit translate description,suggested edit image... etc.. which can also then be turned on/off individually.. If you feel that is how we should proceed, then this ticket should include design to do that as well?

@schoenbaechler

Could I get strings for the title and description for the feed card in customize screen:

@schoenbaechler should this verbiage be change on the main drawer too, or just here?

@Dbrant I looked at the APP_VERSION_NAME that it was old... but I was curious what transaction was as big as a parcel size of 666064 bytes. So asked the user for more details just to verify it is not happening anymore [ not that it has come to our notice anywhere else]. I would have closed it in any case other than currently reproducible steps.

@schoenbaechler I have used the same for link from 'Learn more' on the first time dialogs for both Add Title Description and Add Translate Description : https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5c378de9592d54299d1edc0e
https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5c05a008b19de10170816cd3

Thank you @schoenbaechler

CC - @Dbrant @cooltey ^

@schoenbaechler Can we limit the Rtl support to in-app components only, and not change the direction of the support toolbar? Which would mean the translation card would be rtl, but the title and arrow and overflow would still be inline with the system language.

@schoenbaechler according to our conversation, I have referenced the new color groups as 'chip_background_color' and 'chip_text_color'.

Thank you @schoenbaechler :)
So the background combination now would be

@schoenbaechler Could you please update the designs to reflect what should happen when page items have multiline descriptions?

Ah! That would be the android.R.string.* strings. I assumed only the strings that were created and translated by us, but yes over all I guess they must be reviewed as well. Will move this back to ready-to-dev in that case. We can convert all those places to local strings, also making it a coding standard going forward not to use general android strings, maybe?

I have taken care of "OK", "Cancel", "Yes", and "No" messages. Infact, all the strings are single use right now, other than the ones I documented here : https://docs.google.com/spreadsheets/d/1DNweLAylPjIZ1_Vmx7voZnDwdseB8QXzAvkrF0ZIeYE/edit?usp=sharing why I have ignored them. But yes, the ticket is far from done till we review the document and agree upon ignoring them... I just assumed it was, since the change was merged. Where should we move this to?

@Charlotte just one clarification needed:

Part of the CSS outage. Will be automatically resolved when that is fixed.

The translation unlock logic is solely based on the number of user edits being more than 1 [2 or more], which causes these conflicts:
"1. What happens if the user unlocks the edit feed by making the very first edit, sees unlock dialog, hits ‘Maybe later’ and goes on to read few more articles and along the way makes description edits? Let us say user made 3 edits.
Now the indicator dot is seen, the user visits the edit feed page,
A. Should both title and translate description options be unlocked and available now?
B. If user hits on ‘Add Title Descriptions’ , both first time title edit dialog and translate unlock dialog are now waiting to be shown. Should they both be shown one after the other? Should the translate unlock not appear? Should translate unlocked dialog have appeared anywhere wherever the 2nd edit was made?
C. What happens if the user enters the edit feed, chooses not to hit 'Add Title Descriptions’ , but hits ‘Translate Title Descriptions’ which will now be unlocked. When they next visit 'Add Title Descriptions’ obviously the translate unlock dialog doesn't make sense, so should we include logic to track that and not show translation unlock dialog?"

@schoenbaechler @RHo @dchen @Charlotte final apk link has been updated.

@cmadeo Thank you for the suggestions. I was actually able to have a chat with @schoenbaechler before he left for the day and he was able to clarify. Other than the last point , the back button functionality... rest were the same. Will re-confirm with him tomorrow.

User hasn’t set multiple languages in the app’s settings:
Title: Translate title descriptions
Description: Translation tasks are available if you read and write in more than one Wikipedia language.
Actions: Not for me | Add languages