Sharvaniharan (Sharvaniharan)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 23 2017, 3:03 PM (21 w, 4 d)
Availability
Available
LDAP User
Sharvaniharan
MediaWiki User
Unknown

Recent Activity

Fri, Jan 19

Sharvaniharan moved T185015: BaseActivity is receiving event multiple times per post of the event from To Do to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Fri, Jan 19, 10:40 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan claimed T185015: BaseActivity is receiving event multiple times per post of the event.
Fri, Jan 19, 10:40 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan moved T185343: Create option to Delete Lists and multiple Test article lists from To Do to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Fri, Jan 19, 8:05 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan created T185343: Create option to Delete Lists and multiple Test article lists.
Fri, Jan 19, 8:05 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan placed T185330: [BUG] Default reading list is able to be deleted up for grabs.
Fri, Jan 19, 5:28 PM · Patch-For-Review, Android-app-Bugs, Wikipedia-Android-App-Backlog, Reading Epics (Synchronized Reading Lists)
Sharvaniharan claimed T185330: [BUG] Default reading list is able to be deleted.
Fri, Jan 19, 4:45 PM · Patch-For-Review, Android-app-Bugs, Wikipedia-Android-App-Backlog, Reading Epics (Synchronized Reading Lists)

Thu, Jan 18

Sharvaniharan moved T184868: Random cards never load when swiped throught very quickly from To Do to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Thu, Jan 18, 11:58 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Patch-For-Review, Android-app-Bugs
Sharvaniharan moved T184868: Random cards never load when swiped throught very quickly from Bug Backlog to Android-app-release-v2.7.23x-G on the Wikipedia-Android-App-Backlog board.
Thu, Jan 18, 11:58 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Patch-For-Review, Android-app-Bugs
Sharvaniharan edited projects for T184868: Random cards never load when swiped throught very quickly, added: Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G); removed Wikipedia-Android-App-Backlog.
Thu, Jan 18, 11:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Patch-For-Review, Android-app-Bugs
Sharvaniharan claimed T184868: Random cards never load when swiped throught very quickly.
Thu, Jan 18, 9:42 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Patch-For-Review, Android-app-Bugs
Sharvaniharan moved T183520: User-education and promotion of the reading list sync feature from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Thu, Jan 18, 7:09 PM · Patch-For-Review, Reading Epics (Synchronized Reading Lists), Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)

Wed, Jan 17

Sharvaniharan moved T180230: Show messages when limits to articles in a reading list or number of lists is reached from Code Review to Design Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Wed, Jan 17, 9:25 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)

Tue, Jan 16

Sharvaniharan added a comment to T180230: Show messages when limits to articles in a reading list or number of lists is reached.

https://youtu.be/vA6S73SExEI

Tue, Jan 16, 10:22 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan added a comment to T180230: Show messages when limits to articles in a reading list or number of lists is reached.

+1

Tue, Jan 16, 8:15 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan added a comment to T180230: Show messages when limits to articles in a reading list or number of lists is reached.

@RHo another quick q:

Tue, Jan 16, 8:00 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan created T185015: BaseActivity is receiving event multiple times per post of the event.
Tue, Jan 16, 5:59 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan moved T183520: User-education and promotion of the reading list sync feature from To Do to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Tue, Jan 16, 5:19 PM · Patch-For-Review, Reading Epics (Synchronized Reading Lists), Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan claimed T183520: User-education and promotion of the reading list sync feature.
Tue, Jan 16, 5:19 PM · Patch-For-Review, Reading Epics (Synchronized Reading Lists), Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan moved T180230: Show messages when limits to articles in a reading list or number of lists is reached from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Tue, Jan 16, 5:02 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan added a comment to T180230: Show messages when limits to articles in a reading list or number of lists is reached.

Thank you..

Tue, Jan 16, 4:55 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan added a comment to T180230: Show messages when limits to articles in a reading list or number of lists is reached.

One more small clarification.. @RHo "Can't create another list. You've reached the limit of 100 lists reading lists per account." is it a typo "...100 lists reading lists..." should it be "...100 reading lists..."?

Tue, Jan 16, 2:50 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan added a comment to T180230: Show messages when limits to articles in a reading list or number of lists is reached.

Thanks for the clarification @RHo . I have made changes accordingly.

Tue, Jan 16, 2:36 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan added a comment to T180230: Show messages when limits to articles in a reading list or number of lists is reached.

Also, why are we even displaying the list with >1k articles to the bottom sheet as an option?

Tue, Jan 16, 1:57 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan added a comment to T180230: Show messages when limits to articles in a reading list or number of lists is reached.

Clarification needed on QA steps: Article 1K limit point 3: Should the message appear anytime any list with 1K articles is viewed, or only on the event that a user tries to add the 1001st article and immediately views the list?

Tue, Jan 16, 1:56 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan moved T180239: Expose the 'default list' in the Android app from Code Review to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Tue, Jan 16, 1:51 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Epic, Reading Epics (Synchronized Reading Lists)
Sharvaniharan moved T183169: Add some unit tests to the new Reading List database layer. from Code Review to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Tue, Jan 16, 1:51 PM · Patch-For-Review, Technical-Debt, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan moved T183434: Empty state of reading lists should be updated the fact that all will see the default list from Code Review to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Tue, Jan 16, 1:50 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan moved T180229: Split reading lists with more articles than the limit per list into multiple lists from Code Review to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Tue, Jan 16, 1:50 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)

Fri, Jan 12

Sharvaniharan moved T183169: Add some unit tests to the new Reading List database layer. from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Fri, Jan 12, 2:29 PM · Patch-For-Review, Technical-Debt, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan moved T180229: Split reading lists with more articles than the limit per list into multiple lists from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Fri, Jan 12, 7:52 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)

Thu, Jan 11

Sharvaniharan moved T183588: Change the user-created list name if it the same name as the default list from Code Review to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Thu, Jan 11, 5:06 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan moved T180239: Expose the 'default list' in the Android app from QA Signoff to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Thu, Jan 11, 5:06 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Epic, Reading Epics (Synchronized Reading Lists)
Sharvaniharan moved T180239: Expose the 'default list' in the Android app from Code Review to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Thu, Jan 11, 5:05 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Epic, Reading Epics (Synchronized Reading Lists)
Sharvaniharan moved T180230: Show messages when limits to articles in a reading list or number of lists is reached from To Do to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Thu, Jan 11, 4:54 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan claimed T180230: Show messages when limits to articles in a reading list or number of lists is reached.
Thu, Jan 11, 4:41 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)

Tue, Jan 9

Sharvaniharan moved T182803: [BUG] Perpetual loading spinner appears if user accesses Randomizer whilst offline from Blocked/Waiting to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Tue, Jan 9, 4:31 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Android-app-Bugs
Sharvaniharan moved T183555: [BUG] Fix layout alignment for WikiErrorView from Code Review to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Tue, Jan 9, 4:31 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)

Fri, Jan 5

Sharvaniharan moved T180229: Split reading lists with more articles than the limit per list into multiple lists from To Do to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Fri, Jan 5, 9:42 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan claimed T180229: Split reading lists with more articles than the limit per list into multiple lists.
Fri, Jan 5, 9:42 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)

Thu, Jan 4

Sharvaniharan claimed T183434: Empty state of reading lists should be updated the fact that all will see the default list.
Thu, Jan 4, 6:02 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)

Wed, Jan 3

Sharvaniharan moved T184082: [BUG] Widget does not load from Doing to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Wed, Jan 3, 9:25 PM · Wikipedia-Android-App-Backlog, Android-app-Bugs
Sharvaniharan placed T184082: [BUG] Widget does not load up for grabs.
Wed, Jan 3, 9:25 PM · Wikipedia-Android-App-Backlog, Android-app-Bugs
Sharvaniharan claimed T184082: [BUG] Widget does not load.
Wed, Jan 3, 7:56 PM · Wikipedia-Android-App-Backlog, Android-app-Bugs
Sharvaniharan moved T184082: [BUG] Widget does not load from To Do to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Wed, Jan 3, 7:56 PM · Wikipedia-Android-App-Backlog, Android-app-Bugs
Sharvaniharan moved T183555: [BUG] Fix layout alignment for WikiErrorView from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Wed, Jan 3, 7:36 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan added a comment to T183555: [BUG] Fix layout alignment for WikiErrorView.

Layout Misaligned :


Showing margins. Red is the footer layout :

Fix:

Regression:

Wed, Jan 3, 7:33 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan moved T183588: Change the user-created list name if it the same name as the default list from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Wed, Jan 3, 5:24 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan moved T183555: [BUG] Fix layout alignment for WikiErrorView from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Wed, Jan 3, 5:24 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan claimed T183555: [BUG] Fix layout alignment for WikiErrorView.
Wed, Jan 3, 5:23 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)

Tue, Jan 2

Sharvaniharan moved T183588: Change the user-created list name if it the same name as the default list from To Do to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Tue, Jan 2, 9:33 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan claimed T183588: Change the user-created list name if it the same name as the default list.
Tue, Jan 2, 9:32 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan claimed T180239: Expose the 'default list' in the Android app.
Tue, Jan 2, 9:29 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Epic, Reading Epics (Synchronized Reading Lists)
Sharvaniharan moved T183434: Empty state of reading lists should be updated the fact that all will see the default list from To Do to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Tue, Jan 2, 6:32 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)

Sat, Dec 23

Sharvaniharan added a comment to T180239: Expose the 'default list' in the Android app.

Thanks @RHo . also just now noticed the image missing next to the saved list in the first screenshot, will update the patch and fix that

Sat, Dec 23, 12:47 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Epic, Reading Epics (Synchronized Reading Lists)
Sharvaniharan updated subscribers of T180239: Expose the 'default list' in the Android app.

@RHo @Dbrant I feel Part B should be a separate ticket dependent on Reading list sync service integration.

Sat, Dec 23, 12:35 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Epic, Reading Epics (Synchronized Reading Lists)
Sharvaniharan added a comment to T180239: Expose the 'default list' in the Android app.

Screenshots :

Sat, Dec 23, 12:33 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Epic, Reading Epics (Synchronized Reading Lists)

Dec 22 2017

Sharvaniharan claimed T183441: Update the user education message when user first saves an article to a reading list.
Dec 22 2017, 7:06 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Synchronized Reading Lists)
Sharvaniharan added a comment to T182803: [BUG] Perpetual loading spinner appears if user accesses Randomizer whilst offline.

Yes... i feel so too...

Dec 22 2017, 5:04 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Android-app-Bugs
Sharvaniharan moved T180372: Allow users to select other days to view from On this day from Blocked/Waiting to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Dec 22 2017, 4:50 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Feed 2.0)
Sharvaniharan added a comment to T183555: [BUG] Fix layout alignment for WikiErrorView.

@RHo we can take the same image that you have posted as an example... it actually is not vertically centered, it is off by around 32+ pixels.. however, the background being the same as the parent, makes it feel centered. Here is a colored errorview screenshot, you can see that the errorview is actually centered in the screen, but the views inside are off.

Dec 22 2017, 4:48 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan added a comment to T182803: [BUG] Perpetual loading spinner appears if user accesses Randomizer whilst offline.

@RHo we can take the same image that you have posted as an example... it actually is not vertically centered, it is off by around 32+ pixels.. however, the background being the same as the parent, makes it feel centered. Here is a colored errorview screenshot, you can see that the errorview is actually centered in the screen, but the views inside are off.

Dec 22 2017, 4:46 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Android-app-Bugs
Sharvaniharan added a comment to T182803: [BUG] Perpetual loading spinner appears if user accesses Randomizer whilst offline.

@RHo The Error view is an independent view that is getting used through out the app, and the misalignment is in that view and not on the randomizer view. We must nevertheless fix it, I have opened this and kept it in ready-for-dev on g board for now. I will try to fix it by end of day today, if possible, after my other planned tasks are over. If it gets fixed then i will unblock this ticket and move it to QA. Unless you feel we can move this to QA for now, and once the error view is fixed, the expectation is that this and all other places where it is displayed will be fixed. Let me know how to move on this.

Dec 22 2017, 2:53 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Android-app-Bugs
Sharvaniharan created T183555: [BUG] Fix layout alignment for WikiErrorView.
Dec 22 2017, 2:50 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan added a comment to T180372: Allow users to select other days to view from On this day.

@RHo I have fixed this. Please take a look at this and let me know if it all looks fine : https://youtu.be/gBqii1jP2ks
I will merge this and move to QA if it checks out.

Dec 22 2017, 2:25 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Feed 2.0)

Dec 20 2017

Sharvaniharan created T183334: Make it easier to find feedback screen.
Dec 20 2017, 6:18 AM · Android-app-feature-UX-Debt, Wikipedia-Android-App-Backlog
Sharvaniharan created T183333: Black theme doesn't render Chess template properly.
Dec 20 2017, 6:16 AM · wikimedia-page-library, Wikipedia-Android-App-Backlog
Sharvaniharan created T183332: Investigate crash.
Dec 20 2017, 6:13 AM · Wikipedia-Android-App-Backlog
Sharvaniharan created T183331: Create an option to donate through Google Pay.
Dec 20 2017, 6:12 AM · Wikipedia-Android-App-Backlog
Sharvaniharan created T183330: When a user subscribes for monthly donation, stop showing the donation announcement.
Dec 20 2017, 6:10 AM · Wikipedia-Android-App-Backlog

Dec 19 2017

Sharvaniharan moved T180372: Allow users to select other days to view from On this day from Code Review to Design Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Dec 19 2017, 9:40 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Feed 2.0)
Sharvaniharan moved T183169: Add some unit tests to the new Reading List database layer. from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Dec 19 2017, 5:57 PM · Patch-For-Review, Technical-Debt, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan claimed T183169: Add some unit tests to the new Reading List database layer..
Dec 19 2017, 5:56 PM · Patch-For-Review, Technical-Debt, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)

Dec 15 2017

Sharvaniharan added a comment to T182694: [BUG] Unexpected behavior when trying to access Random whilst offline in the feed.

Thanks @RHo , changed it.

Dec 15 2017, 6:03 PM · Patch-For-Review, Wikipedia-Android-App-Backlog, Android-app-Bugs
Sharvaniharan added a comment to T180806: Animation of the random die in the FAB.

Since I suppressed the api warning on the xml, I just wanted to upload a video of the feature working on all api levels. https://youtu.be/CzN4WR8HgmE

Dec 15 2017, 5:54 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Patch-For-Review, Reading Epics (Feed 2.0), Android-app-feature-Feeds

Dec 14 2017

Sharvaniharan claimed T180806: Animation of the random die in the FAB.
Dec 14 2017, 10:39 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Patch-For-Review, Reading Epics (Feed 2.0), Android-app-feature-Feeds
Sharvaniharan moved T182803: [BUG] Perpetual loading spinner appears if user accesses Randomizer whilst offline from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Dec 14 2017, 6:57 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Android-app-Bugs
Sharvaniharan added a comment to T182803: [BUG] Perpetual loading spinner appears if user accesses Randomizer whilst offline.

@RHo the errorView looks like this : https://youtu.be/0qrnCVT1OxQ . fyi..When the device comes back online, we are still able to see the error view for a couple times on back swipe/click.

Dec 14 2017, 3:05 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Android-app-Bugs

Dec 13 2017

Sharvaniharan moved T182803: [BUG] Perpetual loading spinner appears if user accesses Randomizer whilst offline from To Do to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Dec 13 2017, 9:24 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Android-app-Bugs
Sharvaniharan claimed T182803: [BUG] Perpetual loading spinner appears if user accesses Randomizer whilst offline.
Dec 13 2017, 9:24 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Android-app-Bugs

Dec 12 2017

Sharvaniharan moved T182593: [BUG] On this day event text should be shown in its entirety from To Do to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Dec 12 2017, 10:21 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Patch-For-Review, Android-app-Bugs
Sharvaniharan moved T182593: [BUG] On this day event text should be shown in its entirety from Open Questions/Discussions to Android-app-release-v2.7.23x-G on the Wikipedia-Android-App-Backlog board.
Dec 12 2017, 10:20 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Patch-For-Review, Android-app-Bugs
Sharvaniharan moved T182593: [BUG] On this day event text should be shown in its entirety from Needs Triage to Open Questions/Discussions on the Wikipedia-Android-App-Backlog board.
Dec 12 2017, 10:19 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Patch-For-Review, Android-app-Bugs
Sharvaniharan added a comment to T180372: Allow users to select other days to view from On this day.

Yes, correct... i only coded that to demonstrate what is possible with a quick change right now... will not be merging that change.

Dec 12 2017, 9:47 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Feed 2.0)
Sharvaniharan created T182716: Use viewPager for the months in CustomCalendarView - on on-this-day drop down view.
Dec 12 2017, 9:18 PM · Wikipedia-Android-App-Backlog, Android-app-feature-UX-Debt, Reading Epics (Feed 2.0)
Sharvaniharan added a comment to T180372: Allow users to select other days to view from On this day.

I will need to make a major change for the months to be swipe-able like a pager . I did add a swipe listener on the existing component, but it doesn't give the same look/feel like a pager... so will file this as a separate task.

Dec 12 2017, 9:14 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Feed 2.0)
Sharvaniharan edited projects for T182593: [BUG] On this day event text should be shown in its entirety, added: Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G); removed Wikipedia-Android-App-Backlog.
Dec 12 2017, 2:20 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Patch-For-Review, Android-app-Bugs
Sharvaniharan claimed T182593: [BUG] On this day event text should be shown in its entirety.
Dec 12 2017, 2:18 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Patch-For-Review, Android-app-Bugs

Dec 11 2017

Sharvaniharan added a comment to T182593: [BUG] On this day event text should be shown in its entirety.

after code changes

Dec 11 2017, 10:55 PM · Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Patch-For-Review, Android-app-Bugs
Sharvaniharan added a comment to T180372: Allow users to select other days to view from On this day.

Have fixed the date selection issue and few other minor design issues, post design update. Only thing remaining on this now is to change the dark/black mode colors once they are available on Zeplin.

Dec 11 2017, 9:49 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Feed 2.0)
Sharvaniharan moved T180372: Allow users to select other days to view from On this day from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Dec 11 2017, 4:33 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Feed 2.0)
Sharvaniharan added a comment to T180372: Allow users to select other days to view from On this day.

Some behavior assumptions made based on standard component:

Dec 11 2017, 8:50 AM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Feed 2.0)

Dec 8 2017

Sharvaniharan added a comment to T180372: Allow users to select other days to view from On this day.

And when they return to today's date it goes back to 50% opacity?

Dec 8 2017, 6:14 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Feed 2.0)
Sharvaniharan added a comment to T180372: Allow users to select other days to view from On this day.

@RHo Little unclear on the alpha changes on the calendar icon in the toolbar. Icon has 50% alpha on load, and when a different date is picked from the arrow. However, the alpha changes if [and only if] the user taps it to get back to the current day?

Dec 8 2017, 4:40 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Feed 2.0)

Dec 7 2017

CKoerner_WMF awarded T180372: Allow users to select other days to view from On this day a 100 token.
Dec 7 2017, 9:28 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Feed 2.0)
Sharvaniharan moved T182250: Add hidden developer setting to create reading list with 1000+ pages from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Dec 7 2017, 8:02 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan added a comment to T182250: Add hidden developer setting to create reading list with 1000+ pages.

Adding more than 700 articles is crashing the app, and "1", "2",etc pages are giving an error. Will look into these. Also @Dbrant as of now I have given an option for testers to enter the number of articles(<=700) in the "Test reading list" and number of reading lists (<=10). Should I remove that and make it fixed?

Dec 7 2017, 2:07 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)

Dec 6 2017

Sharvaniharan claimed T182250: Add hidden developer setting to create reading list with 1000+ pages.
Dec 6 2017, 9:57 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G)
Sharvaniharan moved T180372: Allow users to select other days to view from On this day from Ready for dev to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Dec 6 2017, 9:56 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Feed 2.0)
Sharvaniharan moved T180372: Allow users to select other days to view from On this day from To Do to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G) board.
Dec 6 2017, 9:56 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Feed 2.0)
Sharvaniharan claimed T180372: Allow users to select other days to view from On this day.
Dec 6 2017, 9:55 PM · Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G), Reading Epics (Feed 2.0)