Fri, Nov 16
Thu, Nov 15
@ABorbaWMF I made it scrollable thinking it would solve the issue, but when there is a floating button for continue reading, it still doesn't work : https://youtu.be/0aLFDsAqwXQ spoke to @cmadeo ... we feel this needs more thought into the design, to find a way to have the sync dialog , reading list, and the empty message all visible on the screen, while the continue reading floating button is visible. So could we please pass this now, and have a separate ticket to design what is needed?
Wed, Nov 14
Thank you @cmadeo :)
@cmadeo Could you please give me colors for all themes..
Tue, Nov 6
@ABorbaWMF will look into this today. .. at first glance it looks like the dialog got created 3 times, which makes it related to this, but it could also be triggered from a different place... either way, will fix this
I am working on this.... unable to edit the task..
Mon, Nov 5
Removed the previous 'Steps to reproduce' since that was not the issue the ticket referred to.
Thu, Nov 1
The root cause for this is, the class "thumbborder" needs to be added from the backend to the <img> tag.
Thank you @cmadeo
Wed, Oct 31
Thu, Oct 25
Wed, Oct 24
Tue, Oct 23
Mon, Oct 22
Oct 18 2018
Oct 16 2018
@ABorbaWMF @RHo the fix has been merged. In the latest alpha you should see that saving an article from anywhere else other than by tapping bookmark on article screen will not affect showing the tooltip. In the previous version, when you install app, save an article from featured article, or overflow of list items, the tooltip would not be shown on the article screen. I don't think you need to QA again... @cooltey has verified... but just wanted to update you..
Agree! will update code as well!
@RHo could you please confirm that step#3 on the 'Steps for QA' in the task def. is a correct assumption?
Oct 15 2018
Oct 11 2018
@RHo Even the most recent support library doesn't expose explicit attributes for all 3 states: activated, de-activated and disabled. However, there is provision to do this programmatically, but it takes a fair amount of code coupled with a weird unrelated issue we are facing with color resource resolution while theme switching. However, we can achieve very comparable colors with minimum code, with just the style attributes available to us, which also makes sure that all preferences which will be created in the future also adhere to the colors effortlessly. Please find the changes here and let me know :https://gerrit.wikimedia.org/r/#/c/apps/android/wikipedia/+/458330/.
With the attributes available to us:
- We can set colors for thumb-on-color, but track is the 0.5 alpha of it, there is attribute to set track-on-color.
- We can mention de-activated colors for both track and thumb
- For disabled state we can only mention alpha, and it takes the disabled colors and applies the alpha to it. [I have set it at 0.5 or 50%, please feel free to suggest other value]
Sep 28 2018
You were right ...they did not render well..@RHo thank you..
hi @RHo , for screen1 is it possible to give me an svg for app_onboarding_globe, please? I tried using this per @Dbrant suggestion, but I the file is not getting properly imported into Android Studio... If you could create a valid svg for it, that would be great. It will save us a lot of space compared to the png we are using.
Sep 27 2018
Sep 26 2018
Sep 25 2018
Sep 21 2018
Sep 20 2018
@RHo Is the tool tip text available somewhere?
Sep 10 2018
Sep 6 2018
@RHo We can only set an alpha for the disabled state. The color will be the same as the 'off' state colors, we can only add an alpha on top of it, by setting an attribute called disabledAlpha.There is no way to have a completely different color set.Although we can still have different alphas for light, dark and black modes.
Sep 4 2018
Aug 31 2018
Aug 30 2018
Aug 28 2018
This is what I have so far... just wanted to give you a peek to check i am in the right direction... the download progress is not synced to the real download time as you can see from the status bar... https://youtu.be/ouLFLttWIYw
@RHo is it possible to give me an svg without the background? Just the white arrow and line ?
Aug 27 2018
Aug 23 2018
@RHo All changes are made... but i guess i dont have the right permissions to copy the apk there...apk is ready.. i will troubleshoot permissions with Dmitry tomorrow and upload..
@RHo The shadow around the tab list is a bit hard to do with the current set-up we have, so we have decided to wait until we re-architect the tabslist. Other changes are done
Aug 21 2018
Aug 16 2018
Aug 14 2018
Aug 13 2018
Aug 9 2018
@RHo couple questions: