In T148693#3092220, @Arthur2e5 wrote:

P.S.: Shoichi, I am seeing some heavy spamming on http://ids-testing.wmflabs.org/wiki/Main_Page. Are there any abusefilter sort of thing available for stopping these spambots that you can use? (Or just protect the main page for now.)

Yes, I also found it. I have fixed main page. Damn it . I will go to find extension to handle it.

In T154044#3090912, @Aklapper wrote:

In T154044#3090257, @Shoichi wrote:

so can someone do security review first? Where should I apply?

See https://www.mediawiki.org/wiki/Review_queue#Preparing_for_deployment

About cache,after discussion with upstream author , cache put in production server side is better than put in wikis-sites side. No matter how many sites connect to the server, they share the same cache.

In T154044#3090176, @Samwilson wrote:

In T154044#3090170, @kaldari wrote:

This probably isn't a realistic option as there aren't any caching servers available for Tool Labs.

I think the idea would be to have Squid in front of a production IDS rendering server. Which would work, I think? If so, then really the big next step in getting this resolved is to finish translating the code in han3_ji7_tsoo1_kian3 and get it read for security review. (Same for the extension, but it's so simple — especially if it doesn't need to incorporate caching — and it can be done after; the Java bit is the hard bit.)

Hello everyone, about renderer codereview, I posted https://phabricator.wikimedia.org/T154044

Hello awight, about code review (IDS render server) , do you know who can do it? My translation team have made some. I want to know if its is enough?

Excuse me, beacuse our new year is coming at 1/28 ,everyone in Taiwan is very busy in each business. It took a lot of days. >_<

In T153989#2911800, @Samwilson wrote:

I think 'IDS' makes more sense than 'Ids' — I keep reading it wrong myself. It won't be too hard to rename it everywhere, and better to do so before it becomes any more embedded. If there's no convention to follow, lets just go with what's easier to read.

In T148693#2936504, @Arthur2e5 wrote:

Yes.

---

2017-01-14, too lazy to add a comment:

Well, that's just an example. Any character works.

In T148693#2926097, @Arthur2e5 wrote:

Regarding marking translated comments, consider using something like /*e to
replace /**, and e to replace /. This would allow easy English javadoc
generation with some quick sed-work.

Thanks ,I pushed my new one.

In T148693#2925731, @zhuyifei1999 wrote:

For better readability, is it possible for you to use a consistent syntax regarding translations? I see a few are used:
/** 組宋體用的工具 / The Tool for compositing Song font . */ (X / x)
//連線 means connetcion (X means x)
//活字加粗 = Make a sparate movable type bolder. (X = x)

---

Regarding the first type (translating comments itself), I'm not sure about others, but I would personally prefer it's split into two lines:

/** 組宋體用的工具 */
/** The Tool for compositing Song font. */

The first type I change to you suggestion,but use C style

/**/

for being Identificated fast as translation comments, and

/**..... */

is original .

In T148693#2923787, @Niharika wrote:

Hi @Shoichi is the translation work currently in progress?

Yes, in progress. Sorry for vacation, and in Taiwan,now it is busy. Because our Spring Festival is still traditional one. It is during 1/27~2/1 this year. Many Companies will work hard during January (not December). Some members in my team is affected,and also I need to teach 2 members how to use git. >_<

In T154043#2901483, @Aklapper wrote:

@kaldari: Is this an good first task task suitable for newcomers once the task desc has been improved?
Or maybe Google-Code-In-2016 (who would mentor this)?

Hi , about IDS extension,I think that it can be changed to render-server-path set-able in Localsetting.php. I am a poor php guy,but I guess it might be a easy task?

In T153796#2897239, @kaldari wrote:

Still required:

• How do screen-readers (etc.) handle IDS? The extension adds the input string (including the operator prefix character) as the alt attribute of the image.

@Samwilson: A bit confused by this last required item. Is there any action that needs to be taken or was this just a question that has been answered?

@awight @Niharika @MaxSem: Hi , my translation team started to work. Our work is in
https://github.com/Wikimedia-TW/han3_ji7_tsoo1_kian3_WM/tree/code_vf_H2E the fork reason is for some members who are not used to git working (pure Wikipedian,not tech guys).

In T153796#2892239, @Shoichi wrote:

In T153796#2892227, @Samwilson wrote:

That sounds great @Shoichi! So it sounds like it isn't going to be necessary to maintain a separate fork of han3_ji7_tsoo1_kian3; is that correct? (That'd be best, of course!)

Yes, after discussion with him, we found it's too complicated. I have agreement with him: he keeps using function name and variable name with using Han characters,and I set up a team to translate its meaning in comments by English(also translate other Mandarin or Taiwanese comments ).

I will start from making a branch in upstream ,and then clone it out. After we working get done, merge it back to upstream.

Actually speaking one thing you don't know....originally all its source file names are also Chinese,too. I translate to English for non-Chinese file system compatibility. (Some Python2 script problem ). After this discussion and testings ,he just gave up to fall back English filenames to Chinese names. XD

han3_ji7_tsoo1_kian3_WM Network code translation for safey code review.

In T153796#2892227, @Samwilson wrote:

That sounds great @Shoichi! So it sounds like it isn't going to be necessary to maintain a separate fork of han3_ji7_tsoo1_kian3; is that correct? (That'd be best, of course!)

In T153796#2892171, @Niharika wrote:

To explain a little more about what the extension is actually trying to do: Written Chinese involves "inventing" new characters all the time by combining a bunch of standard characters. For example this ideograph is a combination of 4 individual Chinese characters.

About Translate han3_ji7_tsoo1_kian3 into English for Security (etc.) review, I will set a team in this week. After discussion with the upstream author, my plan is give English translating by comments to each function name and variable name which use Han character( what a little difficult is those Han character including not only Mandarin but also Taiwanese. A little similar to English mixing German) . Then Security review can go. The translating will start from core of web service- servlet.

My plan is to add English code comments ,also inlcude comments translating those names with Han characters of functions and variables. I sent the proposo to the author in December,and he agreed. I will set up a little translate team to execulate this. Let People in foundation also can understand its code .

In T144805#2823366, @Stashbot wrote:

Mentioned in SAL (#wikimedia-operations) [2016-11-25T14:16:20Z] <Reedy> delete oathauth row on wikitech for user Shoichi per T144805

In T144805#2823276, @Reedy wrote:

Ok, so what username are you using on wikitech? Is it Shoichi too? I notice that isn't linked to your Wikitech account, but is to your normal wiki account...

In T144805#2789485, @Shoichi wrote:

Months ago, I can log in,but it also happen to me. I don't know rember I had set two-factor authentication or not. Can someone help me? >_< My account there is also "shoichi"

In T137786#2400935, @Liuxinyu970226 wrote:

In T137786#2400241, @Shoichi wrote:

And, The java servlet of "han3_ji7_tsoo1_kian3_WM" is this one. If you want to trace it, just from the java source file.

Looks like there has a license which is non-free:

本字型檔採用創用CC「姓名標示－禁止改作」3.0臺灣版授權條款釋出。

lit. This font file is licensed under a Creative Commons Attribution-NoDerivs 3.0 Taiwan License.

In T137786#2730130, @awight wrote:

Prioritizing because it seems there is significant community interest, and the deployment path is reasonable. Feel free to revert or discuss...

I've done some code review of the extension and it's very straightforward. There was an XSS vulnerability, the patch is pending review and merge:
https://github.com/MGdesigner/Mediawiki-IDSextension/pull/5

Getting the extension into Gerrit will be easy, assuming @Shoichi agrees with that plan.

Moving the rendering engine onto the production cluster will be the difficult part, I'll open a subtask for that.

Months ago, I can log in,but it also happen to me. I don't know rember I had set two-factor authentication or not. Can someone help me? >_< My account there is also "shoichi"

I also paste the testing wiki as an reference. Most funny , there is also some special emojis by IDS there. :)

Thx to Luke081515 help me setting up ids-testing instance,and setup the testing wiki . Now working :

By using the new method, I found I sucessfully login to Ids-1.mw-extension-ids.eqiad.wmflabs ,but still failed on logining to Ids.mw-extension-ids.eqiad.wmflabs.

In T138679#2409636, @yuvipanda wrote:

I've added @Shoichi to be a projectadmin too!

In T138679#2408207, @Niharika wrote:

Hi Shoichi, let's collaborate on this on irc or messenger. I can explain more. :)

In T138679#2407650, @yuvipanda wrote:

I've created it - it is mw-extension-ids, and added Niharika as admin. Feel free to add others.

Thank you !

And, The java servlet of "han3_ji7_tsoo1_kian3_WM" is this one. If you want to trace it, just from the java source file.

In T137786#2400001, @Dereckson wrote:

What runs on idsgen side?

Could we read somewhere the source code?

This one, han3_ji7_tsoo1_kian3_WM. It's an unicode Ideographic Description Sequences renderer. It provide a web api to render an I.D.S as a character image. And the IDS are used to represent a lacking C/J/K/V character ( Or other 2D composited characters writing systems like Maya, ancient Egypt).

In T137786#2390994, @Dereckson wrote:

@Shoichi so next step is you require a Gerrit repository: https://www.mediawiki.org/wiki/Gerrit/New_repositories#Step_4:_Request_a_Git_repository

(Steps 1 and 2 are already done, read the step 3 content too, but you don't really have the choice as it's targeted for a Wikimedia cluster wiki)

Excuse me, I think we are at step3,and I have written the extension page on Mediiawiki site.

In T137786#2390994, @Dereckson wrote:

@Shoichi so next step is you require a Gerrit repository: https://www.mediawiki.org/wiki/Gerrit/New_repositories#Step_4:_Request_a_Git_repository

OK.

(Steps 1 and 2 are already done, read the step 3 content too, but you don't really have the choice as it's targeted for a Wikimedia cluster wiki)

I assume you already have support from zh.wikisource community. If this is not the case, now is probably the good moment to gather such support (that would be frustrating to do all the process to find the community doesn't want the extension).

Yes, it's very important. That's what I should do.

Meanwhile a Gerrit admin creates the repository, you can start the main documentation page at https://www.mediawiki.org/wiki/Extension:IDSextension

Then, you'll follow https://www.mediawiki.org/wiki/Manual:Extension_registration#Migration_for_extension_developers to use the new extension registration mechanism.

Finally, you'll apply https://www.mediawiki.org/wiki/Special:MyLanguage/Manual:Coding_conventions/PHP

Let me know if you're stucked on one of these steps, I can help there.

Thanks for your help very much. I will go on to next move.

In T137786#2379398, @Aklapper wrote:

I've set priority to lowest and status to stalled as this requires numerous steps to be performed before this could be deployed (code security review etc etc).
See the two links provided for a checklist. Thanks!

In T137786#2379397, @Aklapper wrote:

@Shoichi: Also see https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment

In T137786#2379227, @Peachey88 wrote:

There will be a few steps involved:

• Extension needs to be moved into Gerrit

Excuse me,Where is Gerrit?

• Security review of extension

for the major starting points.

Extensions deployed on the production cluster can't rely on labs instances, so that will need to be setup in the production cluster as well.

Do you mean I also need to put the ids server onto the production cluster? How should I do it?

I got the ~/public_tomcat/. It works. Thank you all very much!

@scfc @zhuyifei1999 Thanks, waiting you!

Sorry I am wrong, setup-tomcat give me the replying:

Setting up your public_tomcat directory...
Unable to run job: Job was rejected because job requests unknown queue "webgrid-tomcat".
Exiting.
All done.
You can edit the configuration in /data/project/idsgen/public_tomcat/conf/server.xml as needed.

@scfc
Thank you . I tested.

After "jstart -mem 4G -l release=trusty -q webgrid-generic ./httpserver.sh"

I need it to launch my java servlet for runing our plan.