Page MenuHomePhabricator

Simetrical (Aryeh Gregor (active through September 1))
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 18 2018, 12:21 PM (75 w, 12 h)
Availability
Available
IRC Nick
AryehGregor
LDAP User
Unknown
MediaWiki User
Simetrical [ Global Accounts ]

I learn full-time in kollel, and sometimes contract for Wikimedia bein hazemanim.

Recent Activity

Yesterday

Simetrical added a project to T231159: Wrap file access so it can be mocked: MediaWiki-Core-Testing.
Sun, Aug 25, 12:06 PM · MediaWiki-Core-Testing
Simetrical created T231159: Wrap file access so it can be mocked.
Sun, Aug 25, 12:06 PM · MediaWiki-Core-Testing
Simetrical added a comment to T224429: Hunt and remove unused i18n messages in mediawiki core.

We definitely should have a test that checks for this. Any existing cases can be whitelisted for the time being, but it could at least stop new cases from being inadvertently added.

Sun, Aug 25, 9:16 AM · Patch-For-Review, Google-Code-in-2019, translatewiki.net, Wikimania-Hackathon-2019, I18n, MediaWiki-Internationalization
Simetrical added a comment to T231103: WikibaseLexeme test broken by refactor of MediaWiki's Language class.

WikibaseLexeme tests were accessing a private property of Language via ReflectionClass in order to clear Language caches, instead of using the public method Language::clearCaches(). When Language got refactored, the private member was removed, which broke the tests. Tests that are not run by CI cannot rely on private things not changing if they want to not break -- they need to use only public interfaces.

Sun, Aug 25, 9:11 AM · MediaWiki-Core-Testing, Wikidata, Lexicographical data, Release-Engineering-Team-TODO (201908), ci-test-error

Fri, Aug 23

Simetrical added a comment to T230688: @coversDefaultClass should be allowed on traits as well as classes (MediaWiki.Commenting.PhpunitAnnotations.NotClass).

For the record, @coversDefaultClass seems not to work properly on HHVM either, although on PHP I didn't get any errors. So maybe the sniff is a good idea, at least for now.

Fri, Aug 23, 9:49 AM · MediaWiki-Codesniffer

Thu, Aug 22

Simetrical added a comment to T231014: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode".

The question is, did this work before, or crash with a stack overflow? Do we log all fatal errors in such a way that we know these page views actually succeeded before this change, or might the error just have changed?

Thu, Aug 22, 4:37 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Wikimedia-production-error
Simetrical placed T218555: Provide access to WebRequest and associated information via a service object up for grabs.
Thu, Aug 22, 1:29 PM · CPT Initiatives (Decoupling (CDP2))
Simetrical added a comment to T230979: CR+2 on MediaWiki for Aryeh Gregor (aka Simetrical).

I should add that lately I've been contracting for Wikimedia for about seven weeks a year, and have been working 30-40 hours a week during those periods. When not contracting, I'm completely inactive.

Thu, Aug 22, 10:30 AM · MediaWiki-Gerrit-Group-Requests
Simetrical added a comment to T230979: CR+2 on MediaWiki for Aryeh Gregor (aka Simetrical).

My older contributions are available via git log --author simetrical. I couldn't find a webpage that would display the results of the search that I could link to. Note that that includes things from the SVN era that I only committed and didn't author, so it's inflated (probably only slightly). But if we leave that aside, according to git shortlog -sne, I have 1052 commits (after updating .mailmap to merge the three different e-mail addresses I've used). Surprisingly, this still makes me the #19 all-time contributor by number of commits. I think I always tended to break up my commits more than a lot of people, though.

Thu, Aug 22, 10:15 AM · MediaWiki-Gerrit-Group-Requests
Simetrical closed T200882: Create BadFileLookup service as Resolved.
Thu, Aug 22, 8:46 AM · Patch-For-Review, Core Platform Team (Needs Cleaning - Code Health (TEC13)), MediaWiki-General

Wed, Aug 21

Simetrical added a comment to T224020: Create a class to represent the identity of wikis on the same wiki farm.

In general, false instead of a string ID, or null instead of a SiteID object, are considered to represent the current wiki (home wiki).

Wed, Aug 21, 11:21 AM · CPT Initiatives (Cross-Wiki (CDP2)), Performance-Team (Radar), Proposal, MediaWiki-General, MediaWiki-Farmers, User-Daniel

Mon, Aug 19

Simetrical closed T230528: Allow hooks to work with dependency injection as Resolved.

I don't see a way to mark as duplicate?

Mon, Aug 19, 4:43 PM · Core Platform Team, MediaWiki-General
Simetrical added a comment to T200392: RfC: Release notes automation.

If we wanted a simpler change that would solve the immediate problem, I suggest just adding new release-notes lines in separate files in a designated directory. Before a release, a simple script could aggregate them into a traditional RELEASE-NOTES file. E.g., instead of adding * MediaWikiServices is now deprecated to the 'Deprecations in 1.x' section of RELEASE-NOTES, I'd put a file in release-notes/deprecations named whatever I feel like (name will be ignored by the script) with my release-notes line. Then to accumulate all the deprecations before making a release could be as simple as cat $(ls -tr release-notes/deprecations) or such.

Mon, Aug 19, 12:17 PM · TechCom-RFC (TechCom-Approved), MediaWiki-Documentation
Simetrical added a comment to T200882: Create BadFileLookup service.

Patch: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/530829

Mon, Aug 19, 11:51 AM · Patch-For-Review, Core Platform Team (Needs Cleaning - Code Health (TEC13)), MediaWiki-General

Sun, Aug 18

Simetrical claimed T200882: Create BadFileLookup service.
Sun, Aug 18, 6:18 PM · Patch-For-Review, Core Platform Team (Needs Cleaning - Code Health (TEC13)), MediaWiki-General
Simetrical added a comment to T230688: @coversDefaultClass should be allowed on traits as well as classes (MediaWiki.Commenting.PhpunitAnnotations.NotClass).

Actually, @covers might not actually work on trait-level comments (PHPUnit bug?).

Sun, Aug 18, 2:31 PM · MediaWiki-Codesniffer
Simetrical added a comment to T230688: @coversDefaultClass should be allowed on traits as well as classes (MediaWiki.Commenting.PhpunitAnnotations.NotClass).

Also @covers and presumably other things.

Sun, Aug 18, 2:29 PM · MediaWiki-Codesniffer
Simetrical created T230688: @coversDefaultClass should be allowed on traits as well as classes (MediaWiki.Commenting.PhpunitAnnotations.NotClass).
Sun, Aug 18, 1:01 PM · MediaWiki-Codesniffer
Simetrical closed T220966: TitleParser needs a substitute for Title::makeTitleSafe() as Resolved.
Sun, Aug 18, 9:30 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MediaWiki-General

Thu, Aug 15

Simetrical added a comment to T230528: Allow hooks to work with dependency injection.

So I should probably have waited to get feedback from someone before writing up a test implementation. They would probably have pointed out to me that existing hooks are in some cases run before services are functional. This complicates things a bit, but I think the idea is still something we need to implement.

Thu, Aug 15, 5:38 PM · Core Platform Team, MediaWiki-General
Simetrical added a comment to T230528: Allow hooks to work with dependency injection.

Okay, this took way more time than I expected. I'm putting it on hold for now until I get feedback on the general approach.

Thu, Aug 15, 1:32 PM · Core Platform Team, MediaWiki-General
Simetrical added a project to T230378: Fail tests if they access stale services: MediaWiki-Core-Testing.

Sorry about that. If we want every task to have at least one project tag, is there a way to make it mandatory, or at least warn the submitter if they don't provide one? Other issue trackers I've used all require picking a product/component/whatever, and I keep forgetting with this one.

Thu, Aug 15, 12:24 PM · MediaWiki-Core-Testing
Simetrical added a comment to T228342: Set explicit PHP support target for MediaWiki.

The idea being, then, that we just don't want to waste resources fixing 7.0-specific problems when it's already been EOL'd? That makes perfect sense, I just got confused because of my own assumptions about why we'd want to drop support for old PHP. (There are plenty of 7.1/7.2 features I'd love to use!)

Thu, Aug 15, 12:21 PM · MediaWiki-General, PHP 7.3 support, PHP 7.2 support, PHP 7.1 support, PHP 7.0 support, TechCom-RFC
Simetrical added a comment to T230528: Allow hooks to work with dependency injection.

So I should probably have waited to get feedback from someone before writing up a test implementation. They would probably have pointed out to me that existing hooks are in some cases run before services are functional. This complicates things a bit, but I think the idea is still something we need to implement.

Thu, Aug 15, 11:26 AM · Core Platform Team, MediaWiki-General
Simetrical added a comment to T228342: Set explicit PHP support target for MediaWiki.

I don't see anywhere in Krinkle's text that explains the benefits of dropping support for older PHP versions. I assumed it was so we'd be able to use features of newer PHP versions in core code (because that's why I want to require a newer version :) ). If this is the case, I'm interested in knowing what new features we could use while still supporting HHVM. If there's some other reason entirely that we want to require a higher version, that explains my confusion.

Thu, Aug 15, 11:25 AM · MediaWiki-General, PHP 7.3 support, PHP 7.2 support, PHP 7.1 support, PHP 7.0 support, TechCom-RFC
Simetrical created T230528: Allow hooks to work with dependency injection.
Thu, Aug 15, 8:36 AM · Core Platform Team, MediaWiki-General

Wed, Aug 14

Simetrical committed rECIRaad8e658de54: Support MessageCache as service (authored by Simetrical).
Support MessageCache as service
Wed, Aug 14, 5:49 PM
Simetrical added a comment to T228342: Set explicit PHP support target for MediaWiki.

If it's not really useful to require 7.2 before dropping HHVM support, is it worth making third-party admins upgrade their PHP? I don't know how many there are who will need to, but it's presumably nonzero, so shouldn't we identify some clear benefit to us before inconveniencing them?

Wed, Aug 14, 11:05 AM · MediaWiki-General, PHP 7.3 support, PHP 7.2 support, PHP 7.1 support, PHP 7.0 support, TechCom-RFC

Tue, Aug 13

Simetrical added a comment to T228342: Set explicit PHP support target for MediaWiki.

How does this relate to dropping HHVM support? Is it useful to require PHP 7.2 but also support HHVM? Should T192166 block this, and does it have a timeline?

Tue, Aug 13, 11:16 AM · MediaWiki-General, PHP 7.3 support, PHP 7.2 support, PHP 7.1 support, PHP 7.0 support, TechCom-RFC

Mon, Aug 12

Simetrical created T230378: Fail tests if they access stale services.
Mon, Aug 12, 5:47 PM · MediaWiki-Core-Testing
Simetrical closed T192078: Figure out some way to not use addUncoveredFilesFromWhitelist="true" when running only some PHPUnit tests as Resolved.

This is fixed now, right? Yay! \o/

Mon, Aug 12, 9:50 AM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Test-Coverage, Continuous-Integration-Config, MediaWiki-Core-Testing
Simetrical closed T201278: Running PHPUnit on includes/ or includes/parser/ results in "Call to a member function staticSetup() on null" as Resolved.

Seems fixed.

Mon, Aug 12, 9:18 AM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), MediaWiki-Core-Testing
Simetrical updated Simetrical.
Mon, Aug 12, 9:12 AM

May 6 2019

Simetrical updated Simetrical.
May 6 2019, 11:20 AM
Simetrical closed T214390: Refactor the Http class to not use global state as Resolved.
May 6 2019, 10:20 AM · Core Platform Team Workboards (Done with CPT), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Core Platform Team (Decoupling (CDP2))
Simetrical created T222598: NamespaceInfo::getRestrictionLevels() does not correctly handle namespace restrictions that require more than one permission.
May 6 2019, 10:03 AM · Core Platform Team Workboards (Done with CPT), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Security-Team, MediaWiki-Page-protection, MediaWiki-User-management, MediaWiki-General

May 5 2019

Simetrical created T222545: Where should page move permissions go?.
May 5 2019, 6:34 PM · MediaWiki-General
Simetrical added a comment to T222529: Wikimedia\Assert\ParameterAssertionException when rendering a log snippet and log_user_text is empty.

So this is an actual bug -- until now, we were presumably creating a bogus link (to https://en.wiktionary.org/wiki/User_talk:). What should we actually do here? Is the database actually supposed to ever have empty usernames in it? That doesn't seem reasonable. Surely conversion scripts should also have usernames?

May 5 2019, 11:48 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MediaWiki-Logging, MediaWiki-Revision-backend, Wikimedia-production-error

May 2 2019

Simetrical updated subscribers of T201778: Add pre-commit hook that does basic checks like php -l.

@daniel @tstarling Does it make sense to you that I should work on this? I have most of the work done already for my own productivity, it's just a question of putting it in MediaWiki and figuring out how to let people install it (and decide if we want to auto-install it).

May 2 2019, 9:29 AM · Continuous-Integration-Infrastructure

May 1 2019

Simetrical added a comment to T222212: RevisionStore must not expose user IDs from a foreign wiki.

I think it's best to not allow constructing RevisionStores on foreign repos until we have a clear-cut use-case. Then we can add the functionality to support that use-case. It's not obvious to me that global user pages and such are best implemented using RevisionStore on the local wiki -- somebody needs to come up with an actual design that they plan to implement before that can be decided.

May 1 2019, 8:21 AM · Multi-Content-Revisions (Reactive)

Apr 28 2019

Simetrical claimed T207972: Use UserIdentity in WatchedItem instead of User.
Apr 28 2019, 11:12 AM · Core Platform Team Workboards (Done with CPT), Core Platform Team (Decoupling (CDP2)), Growth-Team, MediaWiki-Watchlist, Technical-Debt
Simetrical added a comment to T221949: Remove uses of Title::moveTo.

That caveat should be removed by https://gerrit.wikimedia.org/r/504336 when that lands.

Apr 28 2019, 9:07 AM · Google-Code-in-2019, CPT Initiatives (Decoupling (CDP2)), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Technical-Debt (Deprecation)

Apr 17 2019

Simetrical added a comment to T218555: Provide access to WebRequest and associated information via a service object.

If the pieces of information are completely unrelated, why not expose them separately, like MediaWikiServices::getInstance()->getUserIdentity() and so on? What do we gain by bundling them in one unit? There are certainly tons of places that use $wgUser or RequestContext::getMain()->getUser() without having any need for a WebRequest, for instance.

Apr 17 2019, 1:58 PM · CPT Initiatives (Decoupling (CDP2))
Simetrical added a comment to T218555: Provide access to WebRequest and associated information via a service object.
  1. Like what?
Apr 17 2019, 11:52 AM · CPT Initiatives (Decoupling (CDP2))

Apr 16 2019

Simetrical added a comment to T218555: Provide access to WebRequest and associated information via a service object.

Why not inject the WebRequest directly instead of putting it inside a wrapper that includes stuff about the user, language, and skin? I.e., what's wrong with just MediaWikiServices::getWebRequest()?

Apr 16 2019, 8:41 AM · CPT Initiatives (Decoupling (CDP2))

Apr 15 2019

Simetrical added a comment to T218555: Provide access to WebRequest and associated information via a service object.

There is no use of WebRequest in PermissionManager right now. The only use of RequestContext is to pass it straight along to Action, which exposes it to subclasses that could conceivably be in extensions. Could you provide more details on what you want to use it for?

Apr 15 2019, 4:34 PM · CPT Initiatives (Decoupling (CDP2))
Simetrical added a comment to T208775: Hard-deprecate Title::moveTo.

So moveTo() does a couple of extra things that MovePage doesn't. It calls spreadAnyEditBlock() if there's an error, and honors the suppressredirect permission. Why are these not done in MovePage proper? As it stands, it considerably complicates porting the existing users, which are fairly numerous.

Apr 15 2019, 4:32 PM · Core Platform Team Workboards (Done with CPT), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Patch-For-Review, Core Platform Team (Decoupling (CDP2)), Technical-Debt (Deprecation)
Simetrical claimed T208775: Hard-deprecate Title::moveTo.
Apr 15 2019, 4:30 PM · Core Platform Team Workboards (Done with CPT), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Patch-For-Review, Core Platform Team (Decoupling (CDP2)), Technical-Debt (Deprecation)
Simetrical added a comment to T214321: Create a value-only interface alternative to the File class.

It doesn't look like Linker could make any use of a FileIdentity type. It seems to basically use File for methods that wouldn't be in such a type, like: exists(), getUrl(), allowInlineDisplay(), isVectorized(), getWidth(), mustRender(), transform().

Apr 15 2019, 12:52 PM · CPT Initiatives (Decoupling (CDP2)), MediaWiki-File-management, Multimedia, Commons
Simetrical claimed T214318: Replace usage of Title with usage of LinkTarget in Linker.
Apr 15 2019, 12:48 PM · Core Platform Team Workboards (Done with CPT), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Core Platform Team (Decoupling (CDP2)), MediaWiki-File-management, Multimedia, Commons
Simetrical created T220966: TitleParser needs a substitute for Title::makeTitleSafe().
Apr 15 2019, 12:00 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MediaWiki-General
Simetrical added a comment to T218555: Provide access to WebRequest and associated information via a service object.

So it's very easy to write the class, but I can't figure out where to use it. Most RequestContext users seem to use it for config and messages and such, inter alia, so there aren't many places I can see where it makes a lot of sense to just substitute RequestInfo. It seems like you'd want to start from classes like LogFormatter and Message, and the first step there should probably be to make them be constructed by services.

Apr 15 2019, 11:26 AM · CPT Initiatives (Decoupling (CDP2))
Simetrical added a comment to T214390: Refactor the Http class to not use global state.

What exactly should this new service contain?

Apr 15 2019, 9:44 AM · Core Platform Team Workboards (Done with CPT), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Core Platform Team (Decoupling (CDP2))
Simetrical claimed T214390: Refactor the Http class to not use global state.
Apr 15 2019, 9:21 AM · Core Platform Team Workboards (Done with CPT), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Core Platform Team (Decoupling (CDP2))
Simetrical claimed T218555: Provide access to WebRequest and associated information via a service object.
Apr 15 2019, 9:21 AM · CPT Initiatives (Decoupling (CDP2))

Apr 10 2019

Simetrical created T220589: Support phan in MediaWiki's default composer.json.
Apr 10 2019, 9:49 AM · phan, MediaWiki-Core-Testing, MediaWiki-General

Apr 9 2019

Simetrical updated Simetrical.
Apr 9 2019, 2:05 PM
Simetrical claimed T214319: Replace usage of Title with usage of LinkTarget in File.
Apr 9 2019, 2:03 PM · CPT Initiatives (Decoupling (CDP2)), Patch-For-Review, MediaWiki-File-management, Multimedia, Commons
Simetrical added a comment to T214626: Title should not use Action.

It looks like this was fixed by 8e1342ed470a08d6658e2483976dfdc8f4388ea5.

Apr 9 2019, 1:46 PM · Core Platform Team Legacy (Next), Core Platform Team (Decoupling (CDP2))

Apr 8 2019

Simetrical added a comment to T104501: Fix global variable and function prefixes in core.

@Legoktm Why do we want variables like $IP to only be ignored if whitelisted on a per-project basis? Any extension could potentially want to use variables like this. Should every extension have to whitelist them separately?

Apr 8 2019, 2:33 PM · MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)), MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)), MW-1.27-release-notes, Patch-For-Review, MediaWiki-Codesniffer, MediaWiki-General

Oct 14 2018

Krinkle awarded T206476: PHPSessionHandlerTest::testSessionHandling fails on PHP 7.2 when run after PHPSessionHandlerTest::testInstall a Orange Medal token.
Oct 14 2018, 10:52 PM · MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), PHP 7.2 support, Patch-For-Review, MediaWiki-Core-Testing

Oct 9 2018

Simetrical added a comment to T201776: TitlePermissionTest failing on travis-ci after ContentLanguage service conversion .

The fix is depressingly simple. We just needed to reset the Language cache in between test runs.

Oct 9 2018, 1:31 PM · Core Platform Team Workboards (Done with CPT), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing
Simetrical added a comment to T201776: TitlePermissionTest failing on travis-ci after ContentLanguage service conversion .

In retrospect, grepping for "MyWiki" would have been a vastly quicker way to narrow down the problem.

Oct 9 2018, 12:41 PM · Core Platform Team Workboards (Done with CPT), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing
Simetrical added a comment to T201776: TitlePermissionTest failing on travis-ci after ContentLanguage service conversion .

I can reproduce by editing suite.xml to run only HtmlTest.php, TitleMethodsTest.php, and TitlePermissionTest.php (by adding <exclude> for everything else in includes/). Now working on narrowing down more.

Oct 9 2018, 12:37 PM · Core Platform Team Workboards (Done with CPT), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing
Simetrical added a comment to T201776: TitlePermissionTest failing on travis-ci after ContentLanguage service conversion .

I can actually reproduce locally, but only if I run all of includes/, not just if I run the file by itself.

Oct 9 2018, 12:16 PM · Core Platform Team Workboards (Done with CPT), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing
Simetrical created T206528: Consider whether we want to rely on synchronous destructors in ScopedCallback.
Oct 9 2018, 11:28 AM · ScopedCallback
Simetrical added a comment to T201776: TitlePermissionTest failing on travis-ci after ContentLanguage service conversion .

There is no way for every test to compile a list of all config options that might cause it to fail. There are far too many config options. The only solution is https://gerrit.wikimedia.org/r/451638.

Oct 9 2018, 9:48 AM · Core Platform Team Workboards (Done with CPT), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing

Oct 8 2018

Simetrical added a comment to T206476: PHPSessionHandlerTest::testSessionHandling fails on PHP 7.2 when run after PHPSessionHandlerTest::testInstall.

Looks like it's this: https://bugs.php.net/bug.php?id=75628 Seems we have to make sure this test actually doesn't output anything.

Oct 8 2018, 5:50 PM · MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), PHP 7.2 support, Patch-For-Review, MediaWiki-Core-Testing
Simetrical added a comment to T206476: PHPSessionHandlerTest::testSessionHandling fails on PHP 7.2 when run after PHPSessionHandlerTest::testInstall.

The "Headers already sent" is just because capitalization changed in PHP 7.2 and evaded our error suppression, so that's presumably not related.

Oct 8 2018, 5:10 PM · MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), PHP 7.2 support, Patch-For-Review, MediaWiki-Core-Testing
Simetrical added a comment to T206476: PHPSessionHandlerTest::testSessionHandling fails on PHP 7.2 when run after PHPSessionHandlerTest::testInstall.

A revision from 2017 had the same problem, so it's safe to assume this isn't a regression in MediaWiki.

Oct 8 2018, 5:08 PM · MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), PHP 7.2 support, Patch-For-Review, MediaWiki-Core-Testing
Simetrical added a comment to T206476: PHPSessionHandlerTest::testSessionHandling fails on PHP 7.2 when run after PHPSessionHandlerTest::testInstall.

I'm trying to bisect now to see if this is a regression. If headers are already sent, that seems like a problem?

Oct 8 2018, 5:02 PM · MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), PHP 7.2 support, Patch-For-Review, MediaWiki-Core-Testing
Simetrical created T206476: PHPSessionHandlerTest::testSessionHandling fails on PHP 7.2 when run after PHPSessionHandlerTest::testInstall.
Oct 8 2018, 4:59 PM · MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), PHP 7.2 support, Patch-For-Review, MediaWiki-Core-Testing
Simetrical created T206449: Services/caches need to be reset when changing configuration in tests.
Oct 8 2018, 8:42 AM · MediaWiki-Configuration, MediaWiki-Core-Testing, MediaWiki-ServiceContainer

Oct 7 2018

Simetrical added a comment to T200392: RfC: Release notes automation.

Can we get MatmaRex's merge driver installed by default for all checkouts, maybe using composer (just because people are already running composer update)? It probably needs to be rewritten in Python first.

Oct 7 2018, 1:46 PM · TechCom-RFC (TechCom-Approved), MediaWiki-Documentation
Simetrical added a comment to T201778: Add pre-commit hook that does basic checks like php -l.

I've been using the following pre-review hook and it works well for me:

Oct 7 2018, 1:44 PM · Continuous-Integration-Infrastructure
Simetrical added a comment to T201776: TitlePermissionTest failing on travis-ci after ContentLanguage service conversion .

Well, one solution would be to force the sitename to MyWiki for these tests, right? Or we could just leave them disabled. (Assuming nobody wants to figure out what the actual problem is, which isn't so easy if it can't be reproduced locally.)

Oct 7 2018, 9:05 AM · Core Platform Team Workboards (Done with CPT), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing

Oct 4 2018

Simetrical reopened T204420: PHPUnit 7.3 on master fails with "Declaration of MediaWikiPHPUnitCommand::createRunner() must be compatible with PHPUnit\TextUI\Command::createRunner()" as "Open".
Oct 4 2018, 5:58 PM · PHP 7.3 support, MediaWiki-Core-Testing
Simetrical closed T206209: Meta name robots does not work for namespaces as Invalid.

The page you linked to is in the main namespace. If you want it to be in the No-index namespace, the page name must start with "No-index:", like "No-index:Тестирование_ограничений". Putting {{ns:No-index}} in the text of the page does not change the namespace, it just prints out the name of the given namespace.

Oct 4 2018, 12:32 PM · MediaWiki-General
Simetrical edited projects for T206209: Meta name robots does not work for namespaces, added: MediaWiki-General; removed Wikimedia-production-error.
Oct 4 2018, 11:50 AM · MediaWiki-General
Simetrical added a comment to T206209: Meta name robots does not work for namespaces.

If I copy the LocalSettings.php snippets and create a page 'No-index:Test' on my local test wiki, I see the correct meta tag. Are you sure the page you're testing is in the No-index namespace? What exact URL are you accessing to get to the page? {{NAMESPACE}} outputs 'No-index'? Could you link to a live wiki that exhibits the problem?

Oct 4 2018, 11:48 AM · MediaWiki-General
Simetrical added a comment to T201778: Add pre-commit hook that does basic checks like php -l.

So pre-push doesn't run for git review. There's a pre-review hook, but it doesn't receive information about which commits are being pushed for review, as far as I can tell, so it's not as useful. git review also doesn't have a --no-verify option to skip the hook when needed. I filed two bugs upstream to improve the pre-review hook:

Oct 4 2018, 9:25 AM · Continuous-Integration-Infrastructure

Oct 3 2018

Simetrical added a comment to T200882: Create BadFileLookup service.

Legoktm, ping?

Oct 3 2018, 5:40 PM · Patch-For-Review, Core Platform Team (Needs Cleaning - Code Health (TEC13)), MediaWiki-General
Simetrical added a comment to T201778: Add pre-commit hook that does basic checks like php -l.

I started using the following pre-commit hook:

Oct 3 2018, 1:28 PM · Continuous-Integration-Infrastructure

Oct 2 2018

Simetrical committed R1985:316455b75b68: Fix docs for setFakeTime() (authored by Simetrical).
Fix docs for setFakeTime()
Oct 2 2018, 7:12 PM
Simetrical closed T201258: When resetting a service, automatically reset services that depend on it as Resolved.

We now reset all services on every test: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/456543

Oct 2 2018, 2:28 PM · Patch-For-Review, MediaWiki-ServiceContainer
Simetrical added a comment to T200392: RfC: Release notes automation.

Why can't Jenkins use the merge driver too, so that it will auto-merge these as well?

Oct 2 2018, 1:10 PM · TechCom-RFC (TechCom-Approved), MediaWiki-Documentation
Simetrical closed T200643: Action text in <title> was inadvertently removed (OutputPage::mPageTitleActionText) as Resolved.
Oct 2 2018, 11:56 AM · MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, MediaWiki-General
Simetrical added a comment to T188687: phpunit-patch-coverage logic on when coverage goes down in one file and up for others needs improving.

It seems correct to complain in this case. The phrasing of the error message is just misleading -- it makes it sound like you removed existing tests or made previously covered lines no longer covered, when it really means you didn't cover newly-added lines. But this way of measuring things will give wrong results in some cases, like if you remove some existing test coverage but also add more, which should warrant a complaint but might not.

Oct 2 2018, 11:51 AM · phpunit-patch-coverage

Aug 12 2018

Simetrical edited projects for T201778: Add pre-commit hook that does basic checks like php -l, added: Continuous-Integration-Infrastructure; removed Core-Platform-Team-Old.

The pre-commit hook is a development tool that's not strictly related to CI. A pre-receive hook would be CI. I think this is basically CI-related, though, yeah.

Aug 12 2018, 8:17 AM · Continuous-Integration-Infrastructure
Simetrical added a comment to T201776: TitlePermissionTest failing on travis-ci after ContentLanguage service conversion .

This looks related to the ContentLanguage service change, not the ParserFactory one. I can't reproduce the failure locally, but probably adding an overrideMwServices() to setUp() will fix the problem.

Aug 12 2018, 7:43 AM · Core Platform Team Workboards (Done with CPT), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing
Simetrical created T201778: Add pre-commit hook that does basic checks like php -l.
Aug 12 2018, 7:39 AM · Continuous-Integration-Infrastructure

Aug 9 2018

Simetrical added a comment to T192166: Drop HHVM support from MediaWiki.

Another HHVM-only error, seemingly:

Aug 9 2018, 4:23 PM · Core Platform Team Legacy (Watching / External), Patch-For-Review, HHVM

Aug 8 2018

Simetrical added a comment to T200392: RfC: Release notes automation.

(end off-topic)

Aug 8 2018, 3:34 PM · TechCom-RFC (TechCom-Approved), MediaWiki-Documentation
Simetrical added a comment to T200889: Audit/document plans for service-ifying MediaWiki core.

What should happen to classes like Html that don't have any internal state at all, including caches? Should those still be ported to services? I guess so, because we want them to stop using globals like $wgContLang and config options.

Aug 8 2018, 2:19 PM · CPT Initiatives (Decoupling (CDP2)), User-Daniel, MediaWiki-General
Simetrical added a comment to T200392: RfC: Release notes automation.

It should definitely run on Gerrit. That doesn't mean it shouldn't run on developers' machines too, though. Merging/rebasing is part of normal workflow, e.g., rebasing your changes locally onto origin/master. If Gerrit doesn't support it yet, at least we can support it on developers' machines, so that when you resolve the conflict locally it's automatic.

Aug 8 2018, 2:09 PM · TechCom-RFC (TechCom-Approved), MediaWiki-Documentation
Simetrical added a comment to T200392: RfC: Release notes automation.

For the record, I tried out the linked merge tool and it ate a line on the first trial run. If we do this, we need a test suite.

Aug 8 2018, 1:59 PM · TechCom-RFC (TechCom-Approved), MediaWiki-Documentation
Simetrical added a comment to T200392: RfC: Release notes automation.

I think a custom merge tool is the right solution here. merge=union doesn't work in all cases, for reasons I outlined in T201514: "This isn't exactly what we want, because if one side removes a line and the other adds in the same place, it will re-add the removed line. Also, conflicting changes to bits of the file that aren't line-based will result in duplicate lines. This will happen silently without warning, without any merge conflict being reported."

Aug 8 2018, 1:55 PM · TechCom-RFC (TechCom-Approved), MediaWiki-Documentation
Simetrical created T201514: Auto-resolve merge conflicts in RELEASE-NOTES.
Aug 8 2018, 1:38 PM · Core-Platform-Team-Old
Simetrical created T201505: "This change depends on a change that failed to merge." Please say which change?.
Aug 8 2018, 11:34 AM · Zuul

Aug 7 2018

Simetrical added a comment to T200785: Allow pushing more than 10 changes at once.

For the record, I keep running into this. I'm doing a lot of refactoring work, and if I don't build all my patches on each other there are inevitably merge conflicts. I've been forced to just submit different sets of patches separately and work out the merge conflicts later.

Aug 7 2018, 4:52 PM · Gerrit