Hello. I'm a lowly student. Also known as GEOFBOT or OH-.
User Details
- User Since
- Nov 27 2014, 8:19 PM (485 w, 4 d)
- Availability
- Available
- IRC Nick
- OH-
- LDAP User
- Sn1per
- MediaWiki User
- Sn1per [ Global Accounts ]
Oct 14 2018
Jul 24 2018
Jan 9 2018
I don't know why log entries were grouped by performer, but it required more logic to deal with when implementing unwatch links. To enforce consistency, I would prefer the log grouping behavior to be page-based rather than removing unwatch links from the ungrouped log entries.
Aug 25 2017
Aug 23 2017
Aug 15 2017
Jul 16 2017
If someone wants to make a user script or gadget for this, note that Special:Contributions still supports year and month querystring parameters. You could add input boxes to the Special:Contributions form and set the name attributes of those inputs to year and month.
Jun 9 2017
CIDR Gadget produces this error on Google Chrome:
Uncaught TypeError: Cannot read property 'value' of undefined at HTMLDocument.prefixContribsInit (load.php?debug=true&lang=en&modules=ext.gadget.contribsrange&only=scripts&skin=vector&version=0j6bd…:51)
Jun 8 2017
Jun 6 2017
Jun 5 2017
Jun 4 2017
The above patch makes action=feedcontributions work again but doesn't change its parameters. I've made a new task (T166966) to deal with actually changing the API action parameters.
Jun 3 2017
This happens because the changes for T120733 cause ContribsPager to expect 'start' and 'end' options. SpecialContributions converts the old 'date' and 'month' options to 'start' and 'end' options, but ApiFeedContributions (which is the only other class that uses ContribsPager) does not, which breaks ApiFeedContributions date filtering capabilities and causes these notices.
Jun 2 2017
Jun 1 2017
May 31 2017
May 26 2017
May 24 2017
May 23 2017
The resulting interface looks like this:
Mar 8 2017
Mar 2 2017
@kaldari It was unintentional because the pager logic checks to see if the mOffset field is empty to determine whether to check for "newer 50," and my change did not use this field, which caused the pager logic to never use "newer 50." (My response to @matmarex above was inaccurate because I mixed some things up in my head) I've updated both patches to simply reuse the offset field for the end date and to add a separate condition for the start date and the pager links and offset should work as before.
Feb 23 2017
Feb 17 2017
Feb 12 2017
Feb 11 2017
I've updated the patch to work with log entries. Since EnhancedChangesList groups log entries by performer, grouped log entries do not have an (un)watch link, although sub-entries of log entries will have the same style changes if the page that they relate to is unwatched or watched.
Feb 10 2017
Feb 4 2017
There are notifications using the same wording and messages as the notifications that pop up when you use the (un)watch star/tab on a normal page; they just aren't visible in those screenshots.
Feb 1 2017
Jan 31 2017
Jan 29 2017
The patch is now in a working state. Please comment on the design.
Jan 28 2017
Thanks, this works for me now.
Jan 27 2017
As for removing a watchlist entry when unwatched, I can't see a necessity for that. There's no harm with keeping the entry there until the page is refreshed, I think. You can always have some kind of indicator that the particular entry is no longer watched (added text to that effect, or graying out, or...?).
Jan 10 2017
Jan 9 2017
Side note while working page_tests: tests.page_tests.TestPageDelete.test_delete doesn't seem to run properly for me:
tests: max_retries reduced from 25 to 1 Logging in to test:test as Sn1per@pywikibot test_delete (tests.page_tests.TestPageDelete) Test the site.delete and site.undelete method. ... Sleeping for 38.4 seconds, 2017-01-08 17:10:45 Page [[User:Unicodesnowman/DeleteTest]] saved 39.129s FAIL
Jan 3 2017
Jan 1 2017
Dec 29 2016
or we could avoid the problem entirely by just having the page show an error if start date comes after end date.
Dec 28 2016
Dec 27 2016
I noticed that pywikibot.comms.http.fetch and other related methods claim to use the same kwargs as requests.Session.request in their docstrings, but pywikibot http methods use a body parameter to provide data for the Requests method's data parameter. (the body/data parameter corresponds to an HTTP POST body) This could be a bit confusing and should be changed to be more consistent unless there's some other naming conflict I don't know about.
Dec 26 2016
Is there a way to modify HTMLForm values? If the start date comes after the end date, I swap them so that the range filters still work, but I haven't been able to figure out a way to apply this change to the values of the two DateTimeInputWidgets without using client-side JS to swap them (which wouldn't work for non-JS users etc.).
Dec 24 2016
Dec 23 2016
I've adjusted some margins accordingly and this is the embed pane now:
Dec 22 2016
What it looks like now:
Dec 18 2016
Dec 17 2016
Dec 16 2016
The disappearing part (for both the progress bar and the button) was part of the design. The loading bar disappears when it's done, and the button disappears as well. The button disappears because with the original form-submission reset behavior, new watchlist items would also show up when the watchlist was reset. However, the new JS reset does not load new items. Therefore, clicking the button after the initial click would in theory mark new watchlist changes as visited, but would not display said changes or show any visual change or indication, which could be confusing. (see https://gerrit.wikimedia.org/r/#/c/326242/)
Dec 15 2016
Since the original form-submission-based reset didn't require a confirmation, how about removing the dialog confirmation and immediately resetting the watchlist via JS? It wouldn't require a reload but wouldn't add another extra click.
Adding
$(function() { $watchlistReset = $('#mw-watchlist-resetbutton'); $watchlistReset.submit( function ( event ) { $watchlistReset.off( 'submit' ).submit(); }); });
to common.js should restore original functionality (although the confirm dialog does pop up, the page immediately reloads).
Dec 14 2016
Dec 13 2016
I don't think there's a API for this so we would need to assemble query strings like this one and screen scrape.
Dec 12 2016
https://gerrit.wikimedia.org/r/#/c/326459 implements a RangeChronologicalPager that makes it relatively easy to add date range filtering to other pages such as Special:NewFiles.
Dec 10 2016
Dec 8 2016
Those were removed in rEMMV532819b5a0dca69409c4696dae3d18cbf6029389. I couldn't find an accompanying bug/task but I assume they were deemed to be excessive?
It looks like tooltips have already been added in rEMMVea610f8256f96e5e7909991049298dc9866a15e3. Is this still an issue?
Dec 7 2016
Dec 4 2016
Dec 3 2016
I get this issue with the LXC provider, but not with virtualbox.
Dec 2 2016
Dec 1 2016
I was a little confused as to how to implement tests for the following from the diff_tests page:
Nov 29 2016
Nov 27 2016
Current status:
Oct 22 2016
Oh, I wasn't arguing against the task. Since I got date and month types added to TextInputWidget so that I could use them as the non-JS versions of DateInputWidgets, I was stating that if the week type was added, the corresponding week selection feature should be added to DateInputWidget to provide a nicer, more widely-available week selector.
For reference, what Chrome/Blink's week picker looks like: