@AnneT A few reasons why this differs
1 the user may have clicked the save out of curiosity because of pulsating dot (I discussed behaviour with Hsaunwei and we are going to persist for the experiment until they tap) and so their intention might not have been to save the article but simply tap it out of curiosity. In those cases it would add something to "reading list" and count as people adding things to reading list. Whereas at this point we want to see if this feature is interesting enough for people to create account.
2 I have added some more details in figma regarding the flow. If we add the item automatically after login we would have to show where to find the saved items dialog as soon as you log in. Currently it appears when you first tap on save. It might be okay to show it after login but there are other dialog mentioned in #4
3 We also show the dialog for where watchstar moved after log in for some cases, and we would need to sequence that and "where to find saved items" dialog one after the other which can seem like too many dialogs.
4 Also the star behaviour is not going to stay as the plan is to replace it with save eventually so there won't be inconsistency going forward
5 The current watch star behaviour of auto saving after login is a bit confusing as there is no indication that something is saved besides the change in icon and it also skips the pop up asking users how to long to watch etc. We would end up in similar situation in the future if we have things like which list you want to save etc. It would be better and more contextual if it appeared right after you tapped on save.

Sorry just seeing this now. I remember talking about the copy in slack with @aude but not able to find the thread. Seems I have wireframes updated to this "To access this page, you’ll need to be logged into the associated account." and it might be the result of conversation we had on this. Does this copy sound okay?

There is more space between the two lines than intended. But its okay and we can approve this for now because we are most likely going to change the position of "privacy policy" to go under the Yes/No buttons according to @Volker_E's suggestion and will be captured in a separate ticket.

@AnneT I have added a few more paths and edge cases into Figma file which clarifies how pop up should be sequenced. I will sync up with @HFan-WMF and we will align the tickets and figma file this week.

@Jdlrobson looks like the setting page has evolved since this ticket was written. The appearance options are more exposed and there is a toast that appears when you change which says "settings were saved". So the problem identified here is not an issue anymore. I don't think we need to do this.

@bwang the spacing looks good to me. Can you double check the colour value of the line? As it looks slightly darker than what is on vector (wikipedia)

ah we did not talk about this! I don't think we need to do this given our the solution we worked out on slack.

@Volker_E lets revisit this once we have a refinement patch from codex. I would like to explore your suggestion to tackle it differently on Desktop and Mobile. It works well on minerva, but looks a bit odd on Desktop as its so close to the line.

I have checked the patch demo shared by @Volker_E and it fixes the issue... also lot of nice improvement in addition to the layout and buttons.

@HFan-WMF thanks for laying it all out so nicely here. I am thinking about it more and also talking to other app designers.

Thanks Steph... Yeah I agree the radio buttons don't have the same effect. But we could change the copy/options that may be more suitable for this UI. Also I wonder if that input box can be made any bigger its so small. Also curious if this box would overlap the reading list items?

@AnneT for seeing the survey 10 times... could we simplify it to visiting the saved pages 10 times after the survey is triggered?

@Volker_E the image is not visible.

Thank you both. I understand the issue now. In that case, would a copy below make sense?

@HFan-WMF I know we discussed this but on second thoughts may be the criteria should be at least 1 article on the saved pages to be able to see feedback form.

I have actually center-aligned horizontally the title and badge. Are there other suggestions for making the text look aligned?

@aude If you are logged out, how does the system know that the page is related to you account (show login) vs someone else's (show error). Is it based on browser history?

@Volker_E I did not suggest superscript mostly because it would add unnecessary space on mobile at the top and if we don't add space it will look cramped.

okay that's a fair point. The yellow also makes it look a bit like warning. Although I am finding that green seems to be standing out more than blue as a badge.

@AnneT thanks for alerting... the link you shared there is "Beta" tag next to the codex icon and that is using a warning colour without a warning icon which could also work....need to think about this.

When we work on custom list we will have to figure out the best approach that is consistent between web, android app, and iOS app but will require cross team discussion

@aude Yes, an article should only show once in all items even if its added to multiple lists including default.

Yes we have a ticket T417348 to fix this and a patch submitted for it already

Although I noticed the size of the bookmark icon is a bit big. I will attach a new SVG with fix size. But its minor @AnneT

@Etonkovidova This is interesting I did not realize the gray I used for background would turn to the same colour as the page background in dark mode. But I think it looks fine because the clarity of the illustration is preserved even without a background.

@HFan-WMF sounds good to me I intentionally left that blank so we could decide the month we want to put there depending how things go. May be we should put that in the acceptance criteria because incase we want to change the date it would be easier to update.

@AnneT added in the task

Thanks @Aklapper
It would be nice to have a list of tags to use listed in some document for our team @HFan-WMF @Jdrewniak as its hard to remember all the different tags we should be using for different purposes.

@aude That is a mistake in the mock. Let's leave it as is - "Saved pages". I will update the figma files later.

@HFan-WMF I am checking the current page in test wiki and looks fine for beta release with few minor spacing issues that I will create a new ticket for. We can deprioritize this and come back to it later.

The reason we should not go with pulsating dot right now is that I think to dismiss it you have to tap on the button (or atleast that is my understading) and we don't want to force users to save something they are not interested in saving just to dismiss the dot.

@HFan-WMF I thought about this a bit more. And I think we should make this higher priority. Especially the second dialogue that appears on first save - the access to save pages is inside a menu which may not be discoverable right away so its important we let users know where to find their saved pages when they first save anything. For the other prompt I think at least during the beta phase it will be good to make it as discoverable as possible for accurate assessment of interest in the feature so we can rule out lack of discovery as an issue.

The spacing in the screenshot looks good to me.

@Jdlrobson-WMF would you say the same adding the mini baby globe next to settings in the main menu is also difficult right now?

@Jdlrobson-WMF okay good to know. Lets not prioritize that then. Also thanks @Etonkovidova for creating a ticket for location.

Also I noticed the mini baby globe is not present in the settings on mobile as shown in design. Is putting the mini baby globe there as difficult as it is on vector? @ATitkov If so, thats okay as we are discussing adding the "baby globe" copy there.

Thanks @Etonkovidova I checked on my side as well.

This type of side bar concept is something we may want to explore in the future for both logged in and logged out users. But yeah not sure if we need a spike ticket to know if its possible.

I caught up with the context for this ticket and agree with the decision. However, I would keep all the contribution/edit related options grouped together and so in advanced mode we should not only move sandbox below watchlist but also talk (see image below). This also keeps the top 3 menu items consistent across advanced and non-advanced mode.

I mentioned this comment on T404227 but might be more applicable to this ticket

Checked this on beta cluster and is working as expected except in the user menu "saved pages" should be below the "sandbox" in advanced mode, so as to maintain showing the cluster of users lists together in any mode. (This might be more applicable to T409865)

@Etonkovidova I tried Mac voiceover too. It only happens in certain cases. The first time you save it does not happen but it happens if you unsave and save without tabbing to other options. I have attached the video here

For the Vector 2022 layout changes, is it just adding the padding around the images in the cards? and does not include changes to the header? (above "Saved")

Yeah no changes to the header on vector. And the padding around images and title font size changes are only for very narrow viewports less than 450ish (we can adjust this number later if needed)