Page MenuHomePhabricator

Soda (Sohom Datta)
Volunteer dev

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 4 2019, 5:26 PM (131 w, 6 d)
Availability
Available
IRC Nick
Sohom Datta
LDAP User
Unknown
MediaWiki User
Sohom data [ Global Accounts ]

GSoC '20 Intern at Wikimedia,
Coding pursuits: GitHub
Wikimedia: mediawiki.org

Recent Activity

Yesterday

Soda added a comment to T308091: Proofreading Page djvu image scrolling.

@Soda, The new system is very good for text only pages, BUT, I can give you a 1,000 examples I am working on currently. Please attempt and edit a page with images and text. https://en.wikisource.org/wiki/Page:Africa_by_%C3%89lis%C3%A9e_Reclus,_Volume_3.djvu/590. Images are surrounded by text and navigating around an image without scrolling doubles my time of proofreading a page. This may sound crazy but I see results in my recent contributions on WS.

I claim experience on the basis of the number of images I contributed to the commons which ended up used in Wikisource proofreading projects. One does not make such an arbitrary decision of dumping a feature that existed since the beginning of Wikipedia and then abandon it. Inductiveload was kind enough demonstrate the Openseadragon and I can live with the extra clicks.

Sun, May 15, 10:54 PM · ProofreadPage
Soda added a comment to T308092: Implement "checker" functionality into ProofreadPage.

We already kinda expose this information (abeit not in such a condensed form). It might be interesting to look into exposing this info directly via javascript on the Index: page also.

Sun, May 15, 9:58 PM · ProofreadPage

Wed, May 11

Soda added a comment to T308091: Proofreading Page djvu image scrolling.

@Ineuw The current system in Openseadragon binds the scrolling function to zooming the image instead of the panning up and down (which could be toggled into scroll to zoom by clicking on the image) in the old implementation. However, the old system was very hard to use in terms of touchpad/accidental clicking which was one of the reasons we switched to the newer system. It is technically possible to implement this behaviour using Openseadragon, but I feel like implementing it would actually be a step backwards in terms of usability.

Wed, May 11, 9:15 AM · ProofreadPage
Soda updated the task description for T308098: Integrate edit-in-sequence inside ProofreadPage.
Wed, May 11, 5:08 AM · ProofreadPage
Soda updated subscribers of T308098: Integrate edit-in-sequence inside ProofreadPage.
Wed, May 11, 5:07 AM · ProofreadPage
Soda created T308098: Integrate edit-in-sequence inside ProofreadPage.
Wed, May 11, 5:07 AM · ProofreadPage
Soda edited projects for T308091: Proofreading Page djvu image scrolling, added: ProofreadPage; removed All-and-every-Wikisource.
Wed, May 11, 4:09 AM · ProofreadPage

Thu, May 5

Soda updated the task description for T304292: Update Openseadragon to 3.0.0 from git hash.
Thu, May 5, 5:59 PM · ProofreadPage
Soda added a comment to T307680: Use manageForeignResources.php to manage OpenSeadragon dependency.

Is there any current extensions that use the ManageForeignResources.php script ? I'm working on and off on T304292 and might take a look at this alongside it.

Thu, May 5, 5:56 PM · ProofreadPage

Mon, May 2

Soda added a comment to T192199: Proofread scan appearing tiny in wikisource, when creating or editing Page: pages.

It should be resolved. Openseadragon loads the images in a completely different way. (We extract the URLs of the image and send it over to Openseadragon which creates it's own canvas and reloads and re-renders the image based on it's canvas height. AFAIR)

Mon, May 2, 5:07 AM · MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), ProofreadPage

Mar 21 2022

Soda added a member for Wikisource-Community-User-Group: Soda.
Mar 21 2022, 10:51 AM
Soda created T304292: Update Openseadragon to 3.0.0 from git hash.
Mar 21 2022, 10:02 AM · ProofreadPage
Soda added a comment to T304286: npm checksum mismatch for ProofreadPage npm dependency: openseadragon.

Yeah, the git hash was pinned since the then current version of Openseadragon (v2.4.2) did not have a few of the features that we required. Now that v3.0.0 is released, we should update the dependencies to the newer version

Mar 21 2022, 8:57 AM · Release-Engineering-Team (Radar), Patch-For-Review, ProofreadPage, ci-test-error (WMF-deployed Build Failure)

Feb 28 2022

Soda added a comment to T277267: Displayed Number in TopPanel is offset for numbers lower than 100.

We used to just use the raw text in the buttons, but now, we are putting a link inside the buttons, which significantly reduces clickability (since clicking the link takes you to a different page).

Feb 28 2022, 3:22 AM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Patch-For-Review, MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), good first task, ProofreadPage
Soda added a comment to T277267: Displayed Number in TopPanel is offset for numbers lower than 100.

The number parsing for the Pagelist Widget itself appears to have broken following this change.

Feb 28 2022, 3:18 AM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Patch-For-Review, MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), good first task, ProofreadPage

Feb 10 2022

Soda added a comment to T176196: Fatal error on action=edit for Index-namespace redirect: "EditIndexPage is only able to display a form for IndexContent".

We don't appear to be defining any interface for editing Index: namespace redirects, which is probably what this is about

Feb 10 2022, 6:45 PM · ProofreadPage, Editing-team (Tracking), JavaScript, Wikimedia-production-error, VisualEditor
Soda added a comment to T263652: Hook up keyboard shortcuts to the Pagelist Widget Dialog.

@DorianWinty That object should be in modules/index.pagelist/PagelistInputWidget.PagelistPreview.js which inherits from OO.ui.Widget. The general idea is to use selectItemByData() to select the next element.

Feb 10 2022, 3:59 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Accessibility, good first task, ProofreadPage

Jan 19 2022

Soda closed T262146: Add zoom and pan to the Wikisource Pagelist Widget as Resolved.

I think all the parts were done! Closing :)

Jan 19 2022, 7:02 AM · Google-Summer-of-Code (2021), ProofreadPage, All-and-every-Wikisource
Soda reassigned T262146: Add zoom and pan to the Wikisource Pagelist Widget from Soda to Yash4357.
Jan 19 2022, 7:01 AM · Google-Summer-of-Code (2021), ProofreadPage, All-and-every-Wikisource

Dec 22 2021

Soda added a comment to T297338: Switching to horizontal mode in ProofreadPage leaves the edit window narrow.

The Bug tag doesn't link this issue (it also fixes T297339), but this should be fixed when https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/745460 deploys (maybe today?)

Dec 22 2021, 8:36 AM · ProofreadPage

Dec 8 2021

Soda awarded T291082: Grant Inductiveload +2 right on ProofreadPage a Like token.
Dec 8 2021, 4:28 PM · ProofreadPage, Gerrit-Privilege-Requests

Nov 24 2021

Soda claimed T255573: Adding a npm fix script to ProofreadPage extension.
Nov 24 2021, 2:59 PM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), ProofreadPage
Soda added a comment to T255573: Adding a npm fix script to ProofreadPage extension.

@Soda is this done?

Nov 24 2021, 2:59 PM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), ProofreadPage
Soda added a comment to T288141: ProofreadPage: use OpenSeadragon for the Page NS image viewer.

@Xover Can you suggest a place (can be phabricator as well) where users can interact with more expert ones to discuss such technical issues? I reckon that this is a specific case where such help is needed and requires a longer discussion.

For specific issues (things that can be narrowed down to a concrete "Need access to X") a Phabricator task tagged with ProofreadPage is probably good. I imagine @Inductiveload would not be averse to getting questions on their talk page on enWS, that can eventually turn into a Phabricator task, and if worse comes to worse you're welcome to use my user talk page on enWS for such things. I won't be able to help much directly (at least in the near term), but I'm happy to host the discussions and I have few compunctions about pinging people I think may be able to help. :-)

Nov 24 2021, 9:56 AM · ProofreadPage

Nov 23 2021

Soda updated subscribers of T296325: Investigate Page namespace 1.5x/2x image without zooming in .

@Ankry Can send a screenshot of the networks tab (in your browser's developer tools) when you see this bug? I was able to reproduce it consistently on Windows (couldn't get it to load a bigger image in Linux) but based on a bit of looking around, the bigger image seems to be loaded via the HTML itself, not Openseadragon (not sure why that's the case).

Nov 23 2021, 7:15 PM · ProofreadPage
Soda created T296325: Investigate Page namespace 1.5x/2x image without zooming in .
Nov 23 2021, 7:09 PM · ProofreadPage

Nov 22 2021

Soda added a comment to T296194: Allow to enable/disable recent improvements in zooming/moving scans with Wikisources.

There is some discussion upstream wrt to the exact same problem (issue 1791). Maybe we could implement option 2 (no panning when zoomed out, but panning is enabled when zoomed in when on mobile).

Nov 22 2021, 6:53 PM · ProofreadPage
Soda added a comment to T296033: Disabling toolbar no longer works in Page namespace.

not working or not deployed yet?

Nov 22 2021, 6:43 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), ProofreadPage, Regression, All-and-every-Wikisource

Nov 21 2021

Soda claimed T296153: OSD: Original image gets removed when layout gets toggled.
Nov 21 2021, 3:09 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), ProofreadPage
Soda created T296153: OSD: Original image gets removed when layout gets toggled.
Nov 21 2021, 2:43 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), ProofreadPage
Soda added a comment to T288141: ProofreadPage: use OpenSeadragon for the Page NS image viewer.

If there are memory issues (maybe OpenSeadragon is too greedy), Wikisources probably need a way to disable it locally. Have we thought about that?

Nov 21 2021, 9:50 AM · ProofreadPage

Nov 19 2021

Soda added a comment to T296033: Disabling toolbar no longer works in Page namespace.

Did the zooming and panning functionality work without the toolbar (when we had the older zooming and panning interface)?

Nov 19 2021, 8:11 AM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), ProofreadPage, Regression, All-and-every-Wikisource

Nov 18 2021

Soda added a comment to T238382: Make Page pages quality editing widget accessible.

I did do a mock-up around a year back converting the whole widget into a dropdown. Not sure if that would count as taking up vertical space (+ it adds one more click to the editor's workflow)

Screenshot from 2021-11-19 01-05-02.png (314×1 px, 46 KB)

Nov 18 2021, 7:38 PM · Accessibility, Design, ProofreadPage

Sep 5 2021

Soda added a comment to T290243: Index pages no longer show elements on the "edit" page between "Pages" and "Categories" (Hebrew Wikisource).
  1. 1. The "Pagelist Widget" was installed in January of this year, after a community vote.
  2. 2. After installation, the page "Mediawiki:Proofreadpage index data config" was created, by a user. It initially had all of the fields. The page underwent revisions for translation and some fields were removed. But all fields in previously existing pages are blank!
  3. 3. Is this a bug?? I.e. does the installation of the "Pagelist Widget" or the creation of "Mediawiki:Proofreadpage index data config" lead to lack of access to text in previously existing fields?
Sep 5 2021, 3:34 PM · ProofreadPage

Sep 3 2021

Soda created P17207 MediaWiki config for hewikisource.
Sep 3 2021, 12:10 PM
Soda added a comment to T290243: Index pages no longer show elements on the "edit" page between "Pages" and "Categories" (Hebrew Wikisource).

@Dovi Can you try the following config? It's based on the config hewikisource had before + some guesses based on the MediaWiki:Proofreadpage index attributes page (which is the old configuration syntax)

Sep 3 2021, 12:06 PM · ProofreadPage
Soda added a comment to T290243: Index pages no longer show elements on the "edit" page between "Pages" and "Categories" (Hebrew Wikisource).

For context, the way the wikitext is generated and stored server-side is {{:MediaWiki:Proofreadpage_index_template\n|title=<everything you put in the title field>\n|author=<everything you put in the author field>}}

Sep 3 2021, 10:02 AM · ProofreadPage
Soda added a comment to T290243: Index pages no longer show elements on the "edit" page between "Pages" and "Categories" (Hebrew Wikisource).

You can see the generated wikitext of the page via the API at this page after clicking Make request. The JSON representation is a bit garbled so this is what I was able to get after rendering it in the browser console:

Sep 3 2021, 9:56 AM · ProofreadPage
Soda added a comment to T290243: Index pages no longer show elements on the "edit" page between "Pages" and "Categories" (Hebrew Wikisource).

The page appears to have a field called הערות that stores most of the data after the pagelist field (based on a quick look at the API). Did you guys have such a field at some point (maybe defined in MediaWiki:Proofreadpag_index_attributes)

Sep 3 2021, 9:35 AM · ProofreadPage

Aug 30 2021

Soda created P17108 (An Untitled Masterwork).
Aug 30 2021, 4:00 PM

Aug 23 2021

Soda added a comment to T288902: Fit scanned page portion within the hieght of the screen while using PagelistWidget.

@Bodhisattwa, Can you take a look and see if the current behaviour suits the use-case you were talking about (demo on testwikisource). We have essentially removed a parameter that set the minimum zoom level to the default zoom level and enabled remembering of zoom and pan position between pages.

It stll doesn't fit within the height of the screen.

Screenshot from 2021-08-23 10-24-00.png (905×1 px, 389 KB)

Aug 23 2021, 7:52 AM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), ProofreadPage

Aug 22 2021

Soda updated the title for P17059 ProofreadPage possible implementation of VE + WikiEditor zooming from untitled to ProofreadPage possible implementation of VE + WikiEditor zooming.
Aug 22 2021, 4:14 PM
Soda created P17059 ProofreadPage possible implementation of VE + WikiEditor zooming.
Aug 22 2021, 4:13 PM
Soda added a comment to T288902: Fit scanned page portion within the hieght of the screen while using PagelistWidget.

@Bodhisattwa, Can you take a look and see if the current behaviour suits the use-case you were talking about (demo on testwikisource). We have essentially removed a parameter that set the minimum zoom level to the default zoom level and enabled remembering of zoom and pan position between pages.

Aug 22 2021, 1:15 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), ProofreadPage

Aug 20 2021

Soda closed T287839: Prevent multiple calls to PagelistWidget's setData function as Resolved.
Aug 20 2021, 9:33 AM · MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), ProofreadPage
Soda added a project to T51023: in Page namespace, provide link(s) to ns0 page(s) which transclude the current Page:: good first task.

Should be easy to implement either from PHP or with a standalone JS module inside the modules/page directory.

Aug 20 2021, 9:29 AM · good first task, All-and-every-Wikisource, ProofreadPage

Aug 15 2021

Soda updated subscribers of T288902: Fit scanned page portion within the hieght of the screen while using PagelistWidget.

This should be resolved by just remembering the zoom and pan position (we used to remember the scroll position before). Trying to show the whole page (which is the default for Openseadragon) is going to make the text too small to read on smaller screens.

Aug 15 2021, 7:08 AM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), ProofreadPage

Aug 12 2021

Soda added a comment to T287133: Zoom toolbar buttons next to transcribe button in toolbar.

@NRodriguez We are already (kind of) implementing this (moving the zoom and pan buttons beside the current Transcribe text button in the Page namespace editor) as part of integrating Openseadragon into the Page: namespace in this patch. :)

Aug 12 2021, 5:21 PM · ProofreadPage, Wikimedia OCR, Community-Tech

Aug 4 2021

Soda updated subscribers of T288141: ProofreadPage: use OpenSeadragon for the Page NS image viewer.
Aug 4 2021, 6:10 PM · ProofreadPage
Soda added a comment to T288141: ProofreadPage: use OpenSeadragon for the Page NS image viewer.

@Soda Oh, great. BTW, I have a very preliminary patch for it at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/709879

So feel free to take whatever you need from there if it's at all helpful.

Aug 4 2021, 6:03 PM · ProofreadPage
Soda added a comment to T288141: ProofreadPage: use OpenSeadragon for the Page NS image viewer.

@Inductiveload We are actually working on a patch for adding OSD to the Page namespace editor within this month as part of the GSoC project :)

Aug 4 2021, 5:34 PM · ProofreadPage

Aug 3 2021

Soda added a comment to T287653: Add button to Index edit form to prefetch all image thumbs.

@Inductiveload Is the rate limit documented anywhere? Also, with the new zooming and panning system, we are loading 1024, 1024 * 1.5, 1024 * 2 resolution images (as the user zooms in)... It's going to slow things down in the PagelistWidget by quite a bit especially since I'm guessing rendering the higher resolution images will take a lot more time.

Aug 3 2021, 1:15 PM · ProofreadPage

Aug 1 2021

Soda created T287839: Prevent multiple calls to PagelistWidget's setData function.
Aug 1 2021, 8:36 PM · MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), ProofreadPage

Jul 12 2021

Soda closed T278615: Use localBasePath for PagelistWidget as Resolved.
Jul 12 2021, 12:47 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), good first task, ProofreadPage
Soda added a comment to T285218: ProofreadPage: allow access to index fields config item (e.g. prpPageNumber) in edit mode.

Yeah, this needs to be fixed and consistently added both in edit mode and view/submit mode. We might also want to refactor some of the existing code and add a dedicated function to deal with adding all the config variables inside PageDisplayHandler.php.

Jul 12 2021, 12:44 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), ProofreadPage

Jul 9 2021

Soda created P16810 MediaWiki:Proofreadpage index data config.
Jul 9 2021, 2:06 PM

Jun 29 2021

Soda added a comment to T285128: Unnecessary empty space below edit form.

@Samwilson Does this (flexbox) change make sense at all for the vertical layout? width:100%; flex-direction:column; is essentially just normal box model flow, except we've now limited the ability to freely resize the form fields to accommodate the flexbox in horizontal layout. Is it all downside with no real upside for that case?

width:100%; flex-direction:column; isn't the same as box-model. It basically stretches out the elements inside the container to fill all available space vertically (whereas box-model stacks everything based on their default width). Generally speaking, this patch should allow everybody to look at more of the Wikitext inside wpTextbox1 instead of having to drag the resize handler every time.

Jun 29 2021, 6:36 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), ProofreadPage

Jun 24 2021

Soda added a comment to T285128: Unnecessary empty space below edit form.

Also, I think we still can't use CSS grid: it's not supported by Safari 9.1 for example.

  1. That's insane. WMF browser stats are non-public, but all versions of Safari before 10.1 have a combined global usage share of 0.39%. Safaris less than 10.1 also lack support for ES6 Generators, ES6 arrow functions, ES6 let, Shadow DOM, and CSP 2.0 just to pick a few obvious ones. The minimum OS requirement for Safari 9 is OSX El Capitan (10.11), which is also the minimum OS requirement for Safari 11, so there are no machines out there supporting Safari 9 that do not also support Safari 11. On MobileSafari the story is slightly more restrictive but we're still talking support for devices back to the iPhone 5!

The page says the compatbility matrix is based on these browser stats

  1. Graceful fallback is acceptable in Grade A. You may conceivably be able to simply apply a Grid layout to the existing layout (I think it uses floats etc. currently).
  2. Whatever works is good enough, and He Who Writes the Code is best situated to make a call like this. But based on the experience and on the design of the two layout modes I worry going with Flexbox will be needlessly complicated to implement and cause grief down the line. Flexbox just isn't designed for this use case.
Jun 24 2021, 10:17 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), ProofreadPage

Jun 10 2021

Soda moved T284776: Move pagelist update logic from VisualDialogModel into seperate class and add QUnit tests for it from Backlog to Pagelist Widget on the ProofreadPage board.
Jun 10 2021, 7:09 PM · ProofreadPage
Soda created T284776: Move pagelist update logic from VisualDialogModel into seperate class and add QUnit tests for it.
Jun 10 2021, 7:08 PM · ProofreadPage
Soda moved T284775: Add Selenium tests for Pagelist Widget from Backlog to Pagelist Widget on the ProofreadPage board.
Jun 10 2021, 7:07 PM · User-zeljkofilipin, Browser-Tests, ProofreadPage
Soda created T284775: Add Selenium tests for Pagelist Widget.
Jun 10 2021, 7:06 PM · User-zeljkofilipin, Browser-Tests, ProofreadPage

Jun 8 2021

Soda updated subscribers of T274350: ProofreadPage source tab not shown in the Minerva skin.

Inside Extension:ProofReadPage

Sorry I'm being thick: in what function? There's already a mapping in extension.json: "SkinTemplateNavigation": "ProofreadPage\\ProofreadPage::onSkinTemplateNavigation",

The onSkinTemplateNavigation is being deprecated for two separate hooks, (SkinTemplateNavigation::SpecialPage (for SpecialPages) and SkinTemplateNavigation::Universal (everything else) per T255319).

Jun 8 2021, 6:54 AM · MinervaNeue (Tracking), Mobile, ProofreadPage

Jun 5 2021

Soda added a comment to T284370: Insertion of special character at the wrong place.

What we need is something like:

  • Check if CodeMirror is supposed to load
  • If it going to be loaded, wait for it to load
  • Unregister CodeMirror's textSelection API
  • Register our own API based on CodeMirror
Jun 5 2021, 6:35 PM · Community-Tech, MediaWiki-extensions-CodeMirror, ProofreadPage
Soda edited projects for T284370: Insertion of special character at the wrong place, added: MediaWiki-extensions-CodeMirror; removed SyntaxHighlight.

Was able to reproduce (a part of this bug)

Jun 5 2021, 6:15 PM · Community-Tech, MediaWiki-extensions-CodeMirror, ProofreadPage

May 30 2021

Soda awarded T283980: Phacility (Maintainer of Phabricator) is winding down. Upstream support ending. a Heartbreak token.
May 30 2021, 6:37 AM · Release-Engineering-Team (Seen), User-Matthewrbowker, Phabricator

May 24 2021

Soda placed T282910: Test failure on ProofreadPage\Index\IndexContentHandlerTest::testUnserializeContentInWikitext up for grabs.
May 24 2021, 11:11 AM · ProofreadPage, ci-test-error (WMF-deployed Build Failure)
Soda closed T282910: Test failure on ProofreadPage\Index\IndexContentHandlerTest::testUnserializeContentInWikitext as Resolved.

Per https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/693609

May 24 2021, 11:11 AM · ProofreadPage, ci-test-error (WMF-deployed Build Failure)

May 21 2021

Soda renamed T278050: Improve ProofreadPage developer setup documentation from Provide a standard simplified verson of the Proofreadpage index template and ProofreadPage index config for easy setup during development to Improve ProofreadPage developer setup documentation.
May 21 2021, 5:04 PM · Documentation, Wikimedia-Hackathon-2021, ProofreadPage
Soda added a project to T278050: Improve ProofreadPage developer setup documentation: Wikimedia-Hackathon-2021.
May 21 2021, 4:12 PM · Documentation, Wikimedia-Hackathon-2021, ProofreadPage

May 18 2021

Soda added a project to T279255: GSoC 2021 Proposal: Add zoom and pan to the Wikisource Pagelist Widget: ProofreadPage.
May 18 2021, 11:51 AM · Patch-For-Review, ProofreadPage, Google-Summer-of-Code (2021)

May 15 2021

Soda added a comment to T282892: Bizarre collision between index/style.css and incomplete table notation.

T253072 strikes again!

Also, this is probably happening because the inserted <templatestyles /> extension tag leads to the parser failing to recognise the table-start wikimarkup since it is no longer at the beginning of the line. I'm not sure whether the p-wrapping plays a role in that or not. The same thing will be happening for all Page: pages, but only the table wikimarkup is sensitive to being at the very start of a line so that's the only case where you are likely to notice.

You can work around it by putting a {{np}} (on esWS; on enWS it'll be {{nopt}}) on the line before the {|.

@Inductiveload You may want to be aware of this issue as it relates to T215165.

Adding a newline after the TS in this concatenation is probably enough to fix this (modulo p-wrapping).

$wikitext = $indexTs->getIndexTemplateStyles( '.pagetext' );
$wikitext .= $this->header->getText() . "\n\n" . $this->body->getText() . $this->footer->getText();
May 15 2021, 12:55 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), ProofreadPage, All-and-every-Wikisource

May 1 2021

Soda added a subtask for T262146: Add zoom and pan to the Wikisource Pagelist Widget: T279255: GSoC 2021 Proposal: Add zoom and pan to the Wikisource Pagelist Widget.
May 1 2021, 1:11 PM · Google-Summer-of-Code (2021), ProofreadPage, All-and-every-Wikisource
Soda added a parent task for T279255: GSoC 2021 Proposal: Add zoom and pan to the Wikisource Pagelist Widget: T262146: Add zoom and pan to the Wikisource Pagelist Widget.
May 1 2021, 1:11 PM · Patch-For-Review, ProofreadPage, Google-Summer-of-Code (2021)

Apr 13 2021

Soda added a comment to T262146: Add zoom and pan to the Wikisource Pagelist Widget.

Folks, just a heads up, the Application submission phase ends at 6:00 pm UTC (11:30 pm IST) today. Make sure to submit your final proposals in time at https://summerofcode.withgoogle.com

Apr 13 2021, 12:53 PM · Google-Summer-of-Code (2021), ProofreadPage, All-and-every-Wikisource

Apr 2 2021

Soda added a comment to T279131: "fresh-node: command not found" in Git Bash on Windows.

@Iamumangg The error in question is due to the fact that you are probably running the script inside Git Bash (which has some weird quirks that may be causing issues with the bash script). If you want to do stuff using fresh-node on Windows, try using either a Linux VM or WSL2.

Apr 2 2021, 12:10 PM · Performance-Team, User-Vidhi-Mody, Fresh

Mar 31 2021

Soda added a comment to T278070: Pagelist Widget does not work on Index Pages with Individual Image Files.

@Languageseeker The error is shown 'cause indexing individual images via <pagelist /> syntax is not supported by ProofreadPage. If ProofreadPage decides to support individual image indexing via <pagelist /> syntax, Pagelist Widget could possibly be modified to support it.

Mar 31 2021, 1:18 PM · ProofreadPage
Soda added a comment to T262146: Add zoom and pan to the Wikisource Pagelist Widget.

@Divrthor345 Thanks for taking an interest in the project :) I'd suggest you try and setup the MediaWiki-Docker development environment (as per the instructions given here) and then setup the ProofreadPage extension (per the instructions here) and then start working on the micro-task/proposal. (It's quite late, so you'd better hurry up)

Mar 31 2021, 6:13 AM · Google-Summer-of-Code (2021), ProofreadPage, All-and-every-Wikisource

Mar 30 2021

Soda moved T278817: Proposal 2021 : Proofreadpage from Backlog to Pagelist Widget on the ProofreadPage board.
Mar 30 2021, 4:50 PM · Google-Summer-of-Code (2021), ProofreadPage
Soda added a comment to T278817: Proposal 2021 : Proofreadpage .

Proposal is not completed I will update the implementation and timeline soon

Mar 30 2021, 12:34 PM · Google-Summer-of-Code (2021), ProofreadPage
Soda added a subtask for T262146: Add zoom and pan to the Wikisource Pagelist Widget: T278817: Proposal 2021 : Proofreadpage .
Mar 30 2021, 12:31 PM · Google-Summer-of-Code (2021), ProofreadPage, All-and-every-Wikisource
Soda added a parent task for T278817: Proposal 2021 : Proofreadpage : T262146: Add zoom and pan to the Wikisource Pagelist Widget.
Mar 30 2021, 12:31 PM · Google-Summer-of-Code (2021), ProofreadPage
Soda edited projects for T278817: Proposal 2021 : Proofreadpage , added: Google-Summer-of-Code (2021); removed Google-Summer-of-Code.
Mar 30 2021, 12:31 PM · Google-Summer-of-Code (2021), ProofreadPage

Mar 29 2021

Soda updated Soda.
Mar 29 2021, 1:51 PM
Soda added a comment to T262146: Add zoom and pan to the Wikisource Pagelist Widget.

Folks, just a heads up, the student application phase of Google Summer of Code will start in ~ 6 hours (23:30 IST today (29th March 2021)).

Mar 29 2021, 12:22 PM · Google-Summer-of-Code (2021), ProofreadPage, All-and-every-Wikisource

Mar 27 2021

Soda moved T278618: Dynamically build a default NumberTypeConfig based on values in mw.config from Backlog to Pagelist Widget on the ProofreadPage board.
Mar 27 2021, 12:14 PM · good first task, ProofreadPage
Soda created T278618: Dynamically build a default NumberTypeConfig based on values in mw.config.
Mar 27 2021, 12:04 PM · good first task, ProofreadPage
Soda moved T278617: ImagePanel should show loading animation for first image from Backlog to Pagelist Widget on the ProofreadPage board.
Mar 27 2021, 11:45 AM · good first task, ProofreadPage
Soda updated the task description for T278617: ImagePanel should show loading animation for first image.
Mar 27 2021, 11:44 AM · good first task, ProofreadPage
Soda created T278617: ImagePanel should show loading animation for first image.
Mar 27 2021, 11:40 AM · good first task, ProofreadPage
Soda moved T278615: Use localBasePath for PagelistWidget from Backlog to Pagelist Widget on the ProofreadPage board.
Mar 27 2021, 11:17 AM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), good first task, ProofreadPage
Soda created T278615: Use localBasePath for PagelistWidget.
Mar 27 2021, 11:14 AM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), good first task, ProofreadPage
Soda moved T278613: When encountering an error, enable Update pagelist button in dialogue from Backlog to Pagelist Widget on the ProofreadPage board.
Mar 27 2021, 10:55 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), good first task, ProofreadPage
Soda moved T278607: Preview pagelist button on non-dialogue portion should not be active when closing the dialogue from Backlog to Pagelist Widget on the ProofreadPage board.
Mar 27 2021, 10:55 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), good first task, ProofreadPage
Soda created T278613: When encountering an error, enable Update pagelist button in dialogue.
Mar 27 2021, 10:51 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), good first task, ProofreadPage
Soda updated subscribers of T278607: Preview pagelist button on non-dialogue portion should not be active when closing the dialogue.
Mar 27 2021, 10:32 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), good first task, ProofreadPage
Soda updated subscribers of T278607: Preview pagelist button on non-dialogue portion should not be active when closing the dialogue.
Mar 27 2021, 10:31 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), good first task, ProofreadPage
Soda closed T277296: Handle internet connectivity drops gracefully as Resolved.
Mar 27 2021, 10:22 AM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), good first task, ProofreadPage
Soda created T278607: Preview pagelist button on non-dialogue portion should not be active when closing the dialogue.
Mar 27 2021, 10:17 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), good first task, ProofreadPage
Soda claimed T278604: Add all of the Index fields to the Page: namespace so that they can be used to create community specific gadgets.
Mar 27 2021, 7:25 AM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), ProofreadPage