Page MenuHomePhabricator

Southparkfan (Ferran Tufan)
Security

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 12 2014, 7:12 AM (440 w, 5 d)
Availability
Available
IRC Nick
Southparkfan
LDAP User
Southparkfan
MediaWiki User
Southparkfan [ Global Accounts ]

The guy who fixes bugs. In daily life I am a Computer Science student specialising in Cyber Security & Cloud.

Macro southparkfan-approves: Approved by Wikimedia

Recent Activity

Feb 1 2023

Southparkfan added a comment to T127717: Move Cloud VPS auth.logs to central logging.

I have expanded https://wikitech.wikimedia.org/wiki/Portal:Cloud_VPS/Admin/Auth_logging. The 'known limitations' section shows there is enough work to do, but to avoid a never ending task, I am fine with resolving this task when T127717#8505600 has been applied to Cloud VPS. I find the lack of monitoring to be a blocker too, though.

Feb 1 2023, 7:30 PM · Cloud-VPS, cloud-services-team, User-dcaro, Sustainability (Incident Followup)

Dec 14 2022

Southparkfan added a comment to T325128: git: detected dubious ownership in repository at '/srv/mediawiki-staging'.

Standalone puppetmasters are also affected by this Git update:

$ git push -f project_puppetmaster HEAD:production
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
remote: fatal: detected dubious ownership in repository at '/var/lib/git/operations/puppet'
remote: To add an exception for this directory, call:
remote: 
remote: 	git config --global --add safe.directory /var/lib/git/operations/puppet
Dec 14 2022, 5:45 PM · Release-Engineering-Team (Radar), SRE, Beta-Cluster-Infrastructure

Dec 7 2022

Southparkfan added a comment to T324623: Switch rsyslog from gtls to ossl.

I have tested https://gerrit.wikimedia.org/r/c/operations/puppet/+/865731 by using rsyslog-openssl on one syslog client and one syslog server running buster + one syslog client and one syslog server running bullseye. All works as expected.

Dec 7 2022, 8:05 PM · Cloud-VPS, cloud-services-team, Patch-For-Review, SRE, observability, User-dcaro
Southparkfan added a comment to T127717: Move Cloud VPS auth.logs to central logging.

Status: we chose #3 (Let's Encrypt via acme-chief). We've gotten stuck on a bug in the gnutls driver for rsyslog: T324623

Dec 7 2022, 12:16 AM · Cloud-VPS, cloud-services-team, User-dcaro, Sustainability (Incident Followup)
Southparkfan added a comment to T324623: Switch rsyslog from gtls to ossl.

Background: for T127717, we went with Let's Encrypt certificates. Unlike the rather simple chain of trust for the Puppet CA (leaf certificate -> root certificate (Puppet CA)), Let's Encrypt certificates have an intermediate certificate in between. 'Because TLS' (certificates are terrible, I know), the clients need to receive all certificates but the root certificate (because that is in /etc/ssl/certs/ca-certificates.crt).

Dec 7 2022, 12:15 AM · Cloud-VPS, cloud-services-team, Patch-For-Review, SRE, observability, User-dcaro

Dec 5 2022

Southparkfan added a comment to T127717: Move Cloud VPS auth.logs to central logging.

@Andrew and I have spent this evening on the initial set up of two WMCS-wide syslog servers. Those work fine. However, this setup is broken for all Cloud VPS instances that do not use the central puppetmaster.

Dec 5 2022, 10:48 PM · Cloud-VPS, cloud-services-team, User-dcaro, Sustainability (Incident Followup)

Jul 27 2022

Southparkfan added a comment to T36738: ResourceLoader should use context/config instead of global variables.

@Southparkfan Thanks. Your patch avoids use of $wgRequest which unblocks removal of that variable from core. However, this task represents the work for T32956 and would not be resolved unless other forms of global state are avoided as well. Whether we obtain WebRequest from $wgRequest or RequestContext::getMain() is a minor detail from this task's perspective.

I understand, eliminating $wgRequest was low-hanging fruit here. DI is still better than either using ::getMain().

I'm happy to accept it, but keep the task and checkbox open after this lands.

If you'd like to resolve the use of global WebRequest in ::inDebugMode(), I can recommend two approaches to try.

Now that we're at it, I'll try to get a durable solution; after all, I would like to reduce technical debt, not move it somewhere else. Assistance is needed to get me starting here, though :-). Your advice is welcome.

  1. Perhaps create a setDebugMode() method marked @internal that we'd call from load.php and possibly OutputPage.php. It could take WebRequest and Config as parameter. Doing this would actually highlight an issue which is that we appear to be reading the cookie even when on load.php which is potentially a problem even today. The cookie should instruct OutputPage to make load.php?debug=true requests, there is no need for it to read it directly. If it does, it might actually poison the cache.

Assumptions

  • load.php (RL\Context) only needs to know if ?debug=<value> exists; cookies and config don't matter here.
  • index.php emits HTML elements (sourcing resources from load.php) that may or may not contain ?debug, depending on the sixth argument of ResourceLoader::makeLoaderQuery(). This entry point is not interested in the presence of a ?debug parameter - inverse of load.php.
Jul 27 2022, 4:01 PM · MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Patch-For-Review, good first task, Performance-Team, Technical-Debt, MediaWiki-ResourceLoader

Jul 21 2022

Southparkfan added a comment to T127717: Move Cloud VPS auth.logs to central logging.

Sorry for the slow response here. I also don't see a clear way to provision those certs, so I think relying on source IP is probably good for this pass. It's already the case that we can't fully 'trust' log messages originating from within cloud-vps projects; I suspect that the risk of a ddos attack is already present even if we have certified logs.

Please lmk if I'm missing a more obvious threat.

Cool! Not sure what the relationship with a DDoS is, though :). If you have time, you can review the patch above. I wasn't too sure about the locations of the default hiera: some things have to be defined in cloud.yaml, others in common/, ...

Jul 21 2022, 9:34 PM · Cloud-VPS, cloud-services-team, User-dcaro, Sustainability (Incident Followup)
Southparkfan added a member for ops-eqsin: Southparkfan.
Jul 21 2022, 7:22 PM
Southparkfan added a member for ops-drmrs: Southparkfan.
Jul 21 2022, 7:22 PM
Southparkfan removed a watcher for ops-eqiad: Southparkfan.
Jul 21 2022, 7:21 PM
Southparkfan removed a watcher for ops-codfw: Southparkfan.
Jul 21 2022, 7:21 PM
Southparkfan removed a watcher for ops-ulsfo: Southparkfan.
Jul 21 2022, 7:21 PM
Southparkfan closed T279332: Replace usages of Linker::link() and Linker::linkKnown() in extension Intersection (DynamicPageList), a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Resolved.
Jul 21 2022, 7:18 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279332: Replace usages of Linker::link() and Linker::linkKnown() in extension Intersection (DynamicPageList) as Resolved.
Jul 21 2022, 7:18 PM · MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), DynamicPageList (Wikimedia), Technical-Debt

Jul 20 2022

Southparkfan removed a project from T36378: Rename namespaces on mr.wikisource.org: Patch-For-Review.

(wrong task)

Jul 20 2022, 6:28 PM · Shell, Wikimedia-Site-requests
Southparkfan added a comment to T36738: ResourceLoader should use context/config instead of global variables.

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/815776/ would alleviate the 'usage of $wgRequest global' concern, but a second pair of eyes is needed:

  • Since [\MediaWiki\ResourceLoader\ResourceLoader]::inDebugMode() is a static function with neither WebRequest exposed via $this->getRequest() or [\MediaWiki\ResourceLoader\Context]->getRequest() available. Unless extensions can/should fetch a 'ResourceLoader object' (and therefore convert this function into a non-static one), I'm not sure how to refrain from this "last restort".
  • Apart from OutputPage and OutputPageTest, [\MediaWiki\ResourceLoader\ResourceLoader]::makeCombinedStyles() is the only caller for OutputPage::transformCssMedia(), hence I couldn't refrain from using RequestContext::getMain() here either.
  • According to T165176, RequestContext::getMain() can cause side-effects? Will that affect the ResourceLoader Context too?
Jul 20 2022, 6:27 PM · MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Patch-For-Review, good first task, Performance-Team, Technical-Debt, MediaWiki-ResourceLoader
Southparkfan updated the task description for T36738: ResourceLoader should use context/config instead of global variables.
Jul 20 2022, 5:36 PM · MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Patch-For-Review, good first task, Performance-Team, Technical-Debt, MediaWiki-ResourceLoader

Jul 18 2022

Southparkfan updated the task description for T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions.
Jul 18 2022, 8:29 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279334: Replace usages of Linker::link() and Linker::linkKnown() in extension OpenStackManager, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Resolved.
Jul 18 2022, 8:28 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279334: Replace usages of Linker::link() and Linker::linkKnown() in extension OpenStackManager as Resolved.
Jul 18 2022, 8:28 PM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), MediaWiki-extensions-OpenStackManager, Technical-Debt
Southparkfan closed T279362: Replace usages of Linker::link() and Linker::linkKnown() in extension OpenID, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Resolved.
Jul 18 2022, 8:28 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279362: Replace usages of Linker::link() and Linker::linkKnown() in extension OpenID as Resolved.
Jul 18 2022, 8:28 PM · MediaWiki-extensions-OpenID, Technical-Debt
Southparkfan committed rECPU1c2ab5ca354e: Replace Linker with LinkRenderer (authored by Southparkfan).
Replace Linker with LinkRenderer
Jul 18 2022, 8:26 PM
Southparkfan closed T279369: Replace usages of Linker::link() and Linker::linkKnown() in extension RevisionCommentSupplement, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Resolved.
Jul 18 2022, 7:58 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279369: Replace usages of Linker::link() and Linker::linkKnown() in extension RevisionCommentSupplement as Resolved.
Jul 18 2022, 7:58 PM · MediaWiki-extensions-RevisionCommentSupplement, Technical-Debt
Southparkfan reopened T279369: Replace usages of Linker::link() and Linker::linkKnown() in extension RevisionCommentSupplement, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Open.
Jul 18 2022, 7:40 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan reopened T279369: Replace usages of Linker::link() and Linker::linkKnown() in extension RevisionCommentSupplement as "Open".

Nevermind, missed one occurrence :P

Jul 18 2022, 7:40 PM · MediaWiki-extensions-RevisionCommentSupplement, Technical-Debt
Southparkfan closed T279369: Replace usages of Linker::link() and Linker::linkKnown() in extension RevisionCommentSupplement, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Resolved.
Jul 18 2022, 7:39 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279369: Replace usages of Linker::link() and Linker::linkKnown() in extension RevisionCommentSupplement as Resolved.
Jul 18 2022, 7:39 PM · MediaWiki-extensions-RevisionCommentSupplement, Technical-Debt

Jul 17 2022

Southparkfan updated the task description for T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions.
Jul 17 2022, 6:29 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279367: Replace usages of Linker::link() and Linker::linkKnown() in extension Poll, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Resolved.
Jul 17 2022, 6:29 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279367: Replace usages of Linker::link() and Linker::linkKnown() in extension Poll as Resolved.
Jul 17 2022, 6:29 PM · MediaWiki-extensions-Poll, Technical-Debt
Southparkfan committed rECDIefe7c2cb3d57: Replace Linker with LinkRenderer (authored by Southparkfan).
Replace Linker with LinkRenderer
Jul 17 2022, 6:27 PM
Southparkfan committed rEASH61b78eb87ce6: Replace Linker with LinkRenderer (authored by Southparkfan).
Replace Linker with LinkRenderer
Jul 17 2022, 6:21 PM
Southparkfan added a member for Technical-Debt: Southparkfan.
Jul 17 2022, 1:45 PM

Jul 16 2022

Southparkfan closed T279353: Replace usages of Linker::link() and Linker::linkKnown() in extension IndexFunction, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Resolved.
Jul 16 2022, 4:19 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279353: Replace usages of Linker::link() and Linker::linkKnown() in extension IndexFunction as Resolved.
Jul 16 2022, 4:19 PM · MediaWiki-extensions-IndexFunction, Technical-Debt
Southparkfan closed T279370: Replace usages of Linker::link() and Linker::linkKnown() in extension SelectCategory, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Resolved.
Jul 16 2022, 4:17 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279378: Replace usages of Linker::link() and Linker::linkKnown() in extension WikiLexicalData/OmegaWiki, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Resolved.
Jul 16 2022, 4:17 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279370: Replace usages of Linker::link() and Linker::linkKnown() in extension SelectCategory as Resolved.
Jul 16 2022, 4:17 PM · MediaWiki-extensions-SelectCategory, Technical-Debt
Southparkfan closed T279378: Replace usages of Linker::link() and Linker::linkKnown() in extension WikiLexicalData/OmegaWiki as Resolved.
Jul 16 2022, 4:17 PM · MediaWiki-extensions-WikiLexicalData-or-OmegaWiki, Technical-Debt
Southparkfan closed T279352: Replace usages of Linker::link() and Linker::linkKnown() in extension ImportFreeImages, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Resolved.
Jul 16 2022, 4:17 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279354: Replace usages of Linker::link() and Linker::linkKnown() in extension Interlanguage, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Resolved.
Jul 16 2022, 4:17 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279352: Replace usages of Linker::link() and Linker::linkKnown() in extension ImportFreeImages as Resolved.
Jul 16 2022, 4:17 PM · MediaWiki-extensions-ImportFreeImages, Technical-Debt
Southparkfan closed T279354: Replace usages of Linker::link() and Linker::linkKnown() in extension Interlanguage as Resolved.
Jul 16 2022, 4:17 PM · MediaWiki-extensions-Interlanguage, Technical-Debt
Southparkfan claimed T279318: Replace usages of Linker::link() and Linker::linkKnown() in Nostalgia skin.
Jul 16 2022, 11:25 AM · Patch-For-Review, Technical-Debt, Nostalgia
Southparkfan updated the task description for T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions.
Jul 16 2022, 1:01 AM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan claimed T279367: Replace usages of Linker::link() and Linker::linkKnown() in extension Poll.
Jul 16 2022, 12:25 AM · MediaWiki-extensions-Poll, Technical-Debt

Jul 15 2022

Southparkfan claimed T279369: Replace usages of Linker::link() and Linker::linkKnown() in extension RevisionCommentSupplement.
Jul 15 2022, 11:49 PM · MediaWiki-extensions-RevisionCommentSupplement, Technical-Debt
Southparkfan updated the task description for T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions.
Jul 15 2022, 9:55 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan updated the task description for T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions.
Jul 15 2022, 9:34 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan claimed T279362: Replace usages of Linker::link() and Linker::linkKnown() in extension OpenID.
Jul 15 2022, 9:21 PM · MediaWiki-extensions-OpenID, Technical-Debt
Southparkfan claimed T279334: Replace usages of Linker::link() and Linker::linkKnown() in extension OpenStackManager.
Jul 15 2022, 9:06 PM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), MediaWiki-extensions-OpenStackManager, Technical-Debt
Southparkfan reopened T279354: Replace usages of Linker::link() and Linker::linkKnown() in extension Interlanguage, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Open.
Jul 15 2022, 8:59 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan reopened T279354: Replace usages of Linker::link() and Linker::linkKnown() in extension Interlanguage as "Open".
Jul 15 2022, 8:59 PM · MediaWiki-extensions-Interlanguage, Technical-Debt
Southparkfan reopened T279353: Replace usages of Linker::link() and Linker::linkKnown() in extension IndexFunction, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Open.
Jul 15 2022, 8:59 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan reopened T279353: Replace usages of Linker::link() and Linker::linkKnown() in extension IndexFunction as "Open".
Jul 15 2022, 8:58 PM · MediaWiki-extensions-IndexFunction, Technical-Debt
Southparkfan closed T279354: Replace usages of Linker::link() and Linker::linkKnown() in extension Interlanguage, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Resolved.
Jul 15 2022, 8:53 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279354: Replace usages of Linker::link() and Linker::linkKnown() in extension Interlanguage as Resolved.
Jul 15 2022, 8:53 PM · MediaWiki-extensions-Interlanguage, Technical-Debt
Southparkfan closed T279353: Replace usages of Linker::link() and Linker::linkKnown() in extension IndexFunction, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Resolved.
Jul 15 2022, 8:49 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279353: Replace usages of Linker::link() and Linker::linkKnown() in extension IndexFunction as Resolved.
Jul 15 2022, 8:49 PM · MediaWiki-extensions-IndexFunction, Technical-Debt
Southparkfan claimed T279352: Replace usages of Linker::link() and Linker::linkKnown() in extension ImportFreeImages.
Jul 15 2022, 8:14 PM · MediaWiki-extensions-ImportFreeImages, Technical-Debt
Southparkfan added a comment to T279370: Replace usages of Linker::link() and Linker::linkKnown() in extension SelectCategory.

Regarding the comment on PS1:

Jul 15 2022, 7:55 PM · MediaWiki-extensions-SelectCategory, Technical-Debt
Southparkfan closed T279360: Replace usages of Linker::link() and Linker::linkKnown() in extension MintyDocs, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Resolved.
Jul 15 2022, 7:43 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279349: Replace usages of Linker::link() and Linker::linkKnown() in extension DocBookExport, a subtask of T149346: Replace Linker::link() and Linker::linkKnown() usage with LinkRenderer in MediaWiki extensions, as Resolved.
Jul 15 2022, 7:43 PM · Patch-Needs-Improvement, MediaWiki-extensions-Other, MediaWiki-extensions-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Google-Code-in-2017, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), patch-welcome, MW-1.29-release-notes, Google-Code-In-2016, Technical-Debt
Southparkfan closed T279360: Replace usages of Linker::link() and Linker::linkKnown() in extension MintyDocs as Resolved.
Jul 15 2022, 7:43 PM · MediaWiki-extensions-MintyDocs, Technical-Debt
Southparkfan closed T279349: Replace usages of Linker::link() and Linker::linkKnown() in extension DocBookExport as Resolved.
Jul 15 2022, 7:43 PM · MediaWiki-extensions-DocBookExport, Technical-Debt
Southparkfan committed rEDBEd84882fbc7be: Replace usage of Linker with LinkRenderer service (authored by Southparkfan).
Replace usage of Linker with LinkRenderer service
Jul 15 2022, 3:48 PM
Southparkfan committed rEMDO3b8c94a2e4cd: Replace usage of Linker with LinkRenderer services (authored by Southparkfan).
Replace usage of Linker with LinkRenderer services
Jul 15 2022, 3:47 PM

Jul 14 2022

Southparkfan added a comment to T311866: Migrate Database::select usages to SelectQueryBuilder.

Given that not every extension calls the functions that were mentioned in the description of this task, 99 of the subtasks have been closed as invalid. All tasks that have been left open make at least one call to one of these functions.

Jul 14 2022, 8:06 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Southparkfan closed T312504: Migrate usage of Database::select to SelectQueryBuilder in TocTree, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Invalid.
Jul 14 2022, 8:01 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Southparkfan closed T312504: Migrate usage of Database::select to SelectQueryBuilder in TocTree as Invalid.

Affected functions not present.

Jul 14 2022, 8:01 PM · MediaWiki-extensions-TocTree, Technical-Debt
Southparkfan closed T312503: Migrate usage of Database::select to SelectQueryBuilder in WikiEditor, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Invalid.
Jul 14 2022, 8:01 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Southparkfan closed T312500: Migrate usage of Database::select to SelectQueryBuilder in Kartographer, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Invalid.
Jul 14 2022, 8:01 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Southparkfan closed T312503: Migrate usage of Database::select to SelectQueryBuilder in WikiEditor as Invalid.

Affected functions not present.

Jul 14 2022, 8:01 PM · WikiEditor, Technical-Debt
Southparkfan closed T312500: Migrate usage of Database::select to SelectQueryBuilder in Kartographer as Invalid.

Affected functions not present.

Jul 14 2022, 8:01 PM · Maps (Kartographer), Technical-Debt
Southparkfan closed T312499: Migrate usage of Database::select to SelectQueryBuilder in Calendar, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Invalid.
Jul 14 2022, 8:01 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Southparkfan closed T312499: Migrate usage of Database::select to SelectQueryBuilder in Calendar as Invalid.

Affected functions not present.

Jul 14 2022, 8:01 PM · Technical-Debt
Southparkfan closed T312497: Migrate usage of Database::select to SelectQueryBuilder in MapSources, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Invalid.
Jul 14 2022, 8:01 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Southparkfan closed T312497: Migrate usage of Database::select to SelectQueryBuilder in MapSources as Invalid.

Affected functions not present.

Jul 14 2022, 8:01 PM · MediaWiki-extensions-MapSources, Technical-Debt
Southparkfan closed T312495: Migrate usage of Database::select to SelectQueryBuilder in TitleBlacklist, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Invalid.
Jul 14 2022, 8:01 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Southparkfan closed T312495: Migrate usage of Database::select to SelectQueryBuilder in TitleBlacklist as Invalid.

Affected functions not present.

Jul 14 2022, 8:01 PM · TitleBlacklist, Technical-Debt
Southparkfan closed T312505: Migrate usage of Database::select to SelectQueryBuilder in FileExporter, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Invalid.
Jul 14 2022, 8:01 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Southparkfan closed T312505: Migrate usage of Database::select to SelectQueryBuilder in FileExporter as Invalid.

Affected functions not present.

Jul 14 2022, 8:01 PM · Move-Files-To-Commons, Technical-Debt
Southparkfan closed T312478: Migrate usage of Database::select to SelectQueryBuilder in FundraiserLandingPage, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Invalid.
Jul 14 2022, 7:59 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Southparkfan closed T312478: Migrate usage of Database::select to SelectQueryBuilder in FundraiserLandingPage as Invalid.

Affected functions not present.

Jul 14 2022, 7:59 PM · MediaWiki-extensions-FundraiserLandingPage, Technical-Debt
Southparkfan closed T312492: Migrate usage of Database::select to SelectQueryBuilder in Score, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Invalid.
Jul 14 2022, 7:59 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Southparkfan closed T312492: Migrate usage of Database::select to SelectQueryBuilder in Score as Invalid.

Affected functions not present.

Jul 14 2022, 7:59 PM · MediaWiki-extensions-Score, Technical-Debt
Southparkfan closed T312491: Migrate usage of Database::select to SelectQueryBuilder in ParserFunctions, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Invalid.
Jul 14 2022, 7:59 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Southparkfan closed T312491: Migrate usage of Database::select to SelectQueryBuilder in ParserFunctions as Invalid.

Affected functions not present.

Jul 14 2022, 7:58 PM · ParserFunctions, Technical-Debt
Southparkfan closed T312489: Migrate usage of Database::select to SelectQueryBuilder in SiteMatrix, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Invalid.
Jul 14 2022, 7:58 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Southparkfan closed T312489: Migrate usage of Database::select to SelectQueryBuilder in SiteMatrix as Invalid.

Affected functions not present.

Jul 14 2022, 7:58 PM · SiteMatrix, Technical-Debt
Southparkfan closed T312488: Migrate usage of Database::select to SelectQueryBuilder in TrustedXFF, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Invalid.
Jul 14 2022, 7:58 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Southparkfan closed T312488: Migrate usage of Database::select to SelectQueryBuilder in TrustedXFF as Invalid.

Affected functions not present.

Jul 14 2022, 7:58 PM · MediaWiki-extensions-TrustedXFF, Technical-Debt
Southparkfan closed T312487: Migrate usage of Database::select to SelectQueryBuilder in InterwikiSorting, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Invalid.
Jul 14 2022, 7:58 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Southparkfan closed T312487: Migrate usage of Database::select to SelectQueryBuilder in InterwikiSorting as Invalid.

Affected functions not present.

Jul 14 2022, 7:58 PM · MediaWiki-extensions-InterwikiSorting, Technical-Debt
Southparkfan closed T312486: Migrate usage of Database::select to SelectQueryBuilder in ImageMap, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Invalid.
Jul 14 2022, 7:58 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Southparkfan closed T312483: Migrate usage of Database::select to SelectQueryBuilder in InputBox, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Invalid.
Jul 14 2022, 7:58 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Southparkfan closed T312486: Migrate usage of Database::select to SelectQueryBuilder in ImageMap as Invalid.

Impacted code is not used by this extension.

Jul 14 2022, 7:58 PM · ImageMap, Technical-Debt