Page MenuHomePhabricator

TK-999 (Máté Szabó)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 7 2017, 10:09 PM (123 w, 1 d)
Availability
Available
LDAP User
TK-999
MediaWiki User
Unknown

Recent Activity

Thu, Jun 13

TK-999 added a comment to T221177: REST route handler extension interface RFC.

Is https://phabricator.wikimedia.org/T221177#5219503 considered valid for the final version of the RfC? i.e. will the base path for the REST routes be configurable / respect existing $wgScriptPath values?

Thu, Jun 13, 9:49 PM · TechCom-RFC, Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Core Platform Team Kanban (Doing)

Tue, Jun 4

TK-999 updated subscribers of T225019: MSCompoundFileReaderTest fails on macOS.

Adding @tstarling as the author of this code—it seems that this might be an issue with how libiconv tries to interpret UTF-16 strings without a BOM.[1] Apparently it tries to guess endianness based on the current OS, so one gets different results on different machines. When I changed "UTF-16" to "UTF-16LE" on L336 of MSCompoundFileReader.php, to force little-endian byte order always, the test passed on macOS.

Tue, Jun 4, 7:59 PM · Multimedia, MediaWiki-File-management, MediaWiki-Uploading, Commons
Restricted Application added projects to T225019: MSCompoundFileReaderTest fails on macOS: Commons, Multimedia.
Tue, Jun 4, 7:58 PM · Multimedia, MediaWiki-File-management, MediaWiki-Uploading, Commons

Sun, Jun 2

TK-999 added a comment to T89432: Make PHPUnit tests run without installing MediaWiki.

Here's what integration with Intellij's PHPUnit execution and coverage display looks like:

Sun, Jun 2, 1:24 PM · Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Goal, MediaWiki-Core-Testing
TK-999 added a comment to T89432: Make PHPUnit tests run without installing MediaWiki.
Sun, Jun 2, 10:55 AM · Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Goal, MediaWiki-Core-Testing

Sat, Jun 1

TK-999 added a comment to T89432: Make PHPUnit tests run without installing MediaWiki.

This should be ready to move forward. I've updated the branch to split proper unit tests into their dedicated suite. 5301 unit tests can now be run from your IDE in less than 5 seconds! :)

Sat, Jun 1, 2:33 PM · Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Goal, MediaWiki-Core-Testing

Wed, May 29

TK-999 added a comment to T223727: Investigate OpenTracing integration with MediaWiki.

I did some work on this during the hackathon. I achieved basic instrumentation of MediaWiki DB queries using the PHP OpenTracing API and Jaeger as the implementation of choice. Instrumentation of BagOStuff (memcache etc.) lookups was also achieved but may not ultimately be useful due to the ubiquitous and fast nature of those transactions.

Wed, May 29, 2:28 PM · Wikimedia-Hackathon-2019

Mon, May 27

TK-999 added a comment to T221535: Provide a "wiki farm" abstraction in MediaWiki core.

(moved from T224020):
How would this relate to the existing wikifarm related concepts that are already in core? It seems there is already:

Mon, May 27, 4:10 PM · MediaWiki-Farmers, MediaWiki-Sites, MediaWiki-Configuration
TK-999 added a comment to T224020: Create a class to represent the identity of wikis on the same wiki farm.

Thanks, I will move this comment there!

Mon, May 27, 4:09 PM · Proposal, MediaWiki-General-or-Unknown, MediaWiki-Farmers, User-Daniel, Core Platform Team (Cross-Wiki (CDP2))
TK-999 added a comment to T224020: Create a class to represent the identity of wikis on the same wiki farm.

How would this relate to the existing wikifarm related concepts that are already in core? It seems there is already:

  • SiteConfiguration / wgConf
  • WikiMap that builds on top of SiteConfiguration and combines (duplicates?) it with $wgLocalDatabases
  • SiteStore / SiteLookup, i.e. the sites table.
Mon, May 27, 2:14 PM · Proposal, MediaWiki-General-or-Unknown, MediaWiki-Farmers, User-Daniel, Core Platform Team (Cross-Wiki (CDP2))
TK-999 added a watcher for MediaWiki-Farmers: TK-999.
Mon, May 27, 11:26 AM

May 19 2019

TK-999 added a comment to T223099: Factor code for handling for options (preferences) out of User class.

The above patch is an initial implementation of what such a preference service could look like. With this approach, a migration path could look something like this:

  • Migrate uses of deprecated User::get/setOption** accessors to the service
  • Once all uses of these accessors have been migrated, remove the accessors, remove User::saveSettings, and remove the "shouldUpdateUserTouched" param from the service interface
  • (in parallel to the above two points) Migrate deprecated hook handlers
May 19 2019, 8:01 PM · Wikimedia-Hackathon-2019, Patch-For-Review, Core Platform Team Kanban (Contractor - Ready), Core Platform Team (Decoupling (CDP2)), MediaWiki-User-management, MediaWiki-User-preferences
TK-999 added a comment to T223099: Factor code for handling for options (preferences) out of User class.

In the current state, memcache entries for User instances include their configured preferences as an array. Should this be kept for B/C during the refactor?

May 19 2019, 10:40 AM · Wikimedia-Hackathon-2019, Patch-For-Review, Core Platform Team Kanban (Contractor - Ready), Core Platform Team (Decoupling (CDP2)), MediaWiki-User-management, MediaWiki-User-preferences

May 18 2019

TK-999 claimed T223727: Investigate OpenTracing integration with MediaWiki.
May 18 2019, 3:21 PM · Wikimedia-Hackathon-2019
TK-999 moved T223727: Investigate OpenTracing integration with MediaWiki from Backlog to Projects on the Wikimedia-Hackathon-2019 board.
May 18 2019, 3:21 PM · Wikimedia-Hackathon-2019
TK-999 created T223727: Investigate OpenTracing integration with MediaWiki.
May 18 2019, 3:21 PM · Wikimedia-Hackathon-2019

May 15 2019

TK-999 committed rMTDAd5c5a2704e68: Adjust sed invocation due to macOS sed not recognizing "\t" (authored by TK-999).
Adjust sed invocation due to macOS sed not recognizing "\t"
May 15 2019, 9:22 PM
TK-999 committed rMTDA0ab9de860b8d: Change delimiter due to macOS sed not recognizing "\t" (authored by TK-999).
Change delimiter due to macOS sed not recognizing "\t"
May 15 2019, 12:22 AM

May 14 2019

TK-999 added a comment to T87781: Split mediawiki tests into unit and integration tests.

@kostajh I'm in!

May 14 2019, 10:00 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Code-Health-Metrics, Epic, MediaWiki-Core-Testing

May 10 2019

TK-999 added a comment to T87781: Split mediawiki tests into unit and integration tests.

@kostajh yup, that's right!

May 10 2019, 8:47 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Code-Health-Metrics, Epic, MediaWiki-Core-Testing

May 7 2019

TK-999 added a comment to T220867: Gerrit: Cannot assign user name "vladi2016" to account XXXX; name already in use..

Thank you! It's working fine now :)

May 7 2019, 5:55 PM · Release-Engineering-Team (Kanban), LDAP, Gerrit

May 6 2019

TK-999 added a comment to T220867: Gerrit: Cannot assign user name "vladi2016" to account XXXX; name already in use..

For reference, it seems the Gerrit 2.16 upgrade rollout is being tracked in T200739

May 6 2019, 11:39 PM · Release-Engineering-Team (Kanban), LDAP, Gerrit
TK-999 added a comment to T222186: Gerrit login failure for user tk-999.

Thanks @Paladox for investigating :) The timing of the issue is a bit unfortunate with the WM Hackathon coming up in a week, but I guess I can create a secondary account for that if all else fails.

May 6 2019, 11:28 PM · Gerrit, LDAP
TK-999 added a comment to T87781: Split mediawiki tests into unit and integration tests.

Yeah, that was my question, thanks!

May 6 2019, 2:55 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Code-Health-Metrics, Epic, MediaWiki-Core-Testing
TK-999 updated subscribers of T87781: Split mediawiki tests into unit and integration tests.

As suggested by @hashar , this ticket could potentially be a nice hackathon project—if not for Barcelona, then for Prague 😉It's still quite relevant and would make developers' life a whole lot easier.

May 6 2019, 2:15 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Code-Health-Metrics, Epic, MediaWiki-Core-Testing
TK-999 updated TK-999.
May 6 2019, 1:25 PM

Apr 30 2019

TK-999 added a comment to T222186: Gerrit login failure for user tk-999.

Note: I've tried other case variations of my Wikitech username as well (TK-999, Tk-999, tk-999), but to no avail.

Apr 30 2019, 3:33 PM · Gerrit, LDAP
TK-999 created T222186: Gerrit login failure for user tk-999.
Apr 30 2019, 3:11 PM · Gerrit, LDAP

Sep 19 2018

TK-999 added a comment to T204751: Expected mass commit of all peer transactions in TemporaryTableManager::queryWithAutoCommit: .

In this situation it should be safe to set explicitly the IDatabase::FLUSHING_ALL_PEERS flag since we want to commit any open implicit transaction.

Sep 19 2018, 10:19 AM · MediaWiki-extensions-SemanticDrilldown
TK-999 added a comment to T204751: Expected mass commit of all peer transactions in TemporaryTableManager::queryWithAutoCommit: .

I think this might be a result of https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/417477/ updating some transaction related warnings to exceptions. Need to take a look at what's going on there.

Sep 19 2018, 10:03 AM · MediaWiki-extensions-SemanticDrilldown

Aug 27 2018

Nemo_bis awarded T189702: Replace transcache table with objectcache backend a Doubloon token.
Aug 27 2018, 7:35 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), MediaWiki-Database, Patch-For-Review, Core-Platform-Team-Old, Performance-Team, MediaWiki-Templates

Jul 30 2018

TK-999 awarded T189702: Replace transcache table with objectcache backend a Love token.
Jul 30 2018, 12:47 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), MediaWiki-Database, Patch-For-Review, Core-Platform-Team-Old, Performance-Team, MediaWiki-Templates

Jul 11 2018

TK-999 created T199377: Consider removing page_restrictions.pr_user field from schema.
Jul 11 2018, 9:30 PM · Patch-For-Review, Schema-change, MediaWiki-Database

May 19 2018

TK-999 awarded T194901: MediaWiki and GDPR a Orange Medal token.
May 19 2018, 8:58 PM · MediaWiki-Stakeholders-Group, Wikimedia-Hackathon-2018
TK-999 added a comment to T195028: Add goat import and export capability.

I believe this will be especially necessary given the data portability clauses of the GDPR. We must provide users with a way to export their own goats.

May 19 2018, 6:14 PM · Goatification, Wikimedia-Hackathon-2018

Apr 28 2018

TK-999 added a comment to T177024: Function to replace invisible characters with blank.

Probably the character 2062 (INVISIBLE TIMES) should be added to the list. For example, https://community.wikia.com/wiki/Special:Contributions/Low_Spark_of_Lyman%E2%81%A2%E2%81%A2 has this character appended to this user name, but it's visually indistinguishable from https://community.wikia.com/wiki/Special:Contributions/Low_Spark_of_Lyman .

Apr 28 2018, 11:10 PM · AntiSpoof

Apr 26 2018

TK-999 added a comment to T182177: PHP function each() has been deprecated.

FYI, PHP 7.2 compatibility issues are fixed in version 1.10.2 of the PEAR Mail_Mime library.

Apr 26 2018, 2:27 PM · PHP 7.2 support, Upstream, MediaWiki-Vendor

Mar 20 2018

TK-999 added a comment to T183300: Use list=blocks to return all single IP blocks in a CIDR.

I think that's MySQL specific and won't work on other supported RDBMSes. AFAIK Postgres for instance has designated data types like cidr instead of this helper.

Mar 20 2018, 4:26 PM · MediaWiki-API
TK-999 added a comment to T183300: Use list=blocks to return all single IP blocks in a CIDR.

I was thinking that it might help with this task, if we separated concerns between the ipblocks.ipb_user and ipblocks.ipb_address fields:

Mar 20 2018, 1:40 PM · MediaWiki-API
TK-999 added a comment to T51504: ipb_range_start and ipb_range_end should be blank for single-IP blocks.

Thank you very much for the quick review @Anomie 🙂 I have amended the patch set according to your notes.

Mar 20 2018, 1:19 PM · Patch-For-Review, Performance, MediaWiki-User-management

Mar 19 2018

TK-999 added a comment to T50767: Support 'utf8mb4' character set in MySQL 5.5 and above.

What collation would MediaWiki use for the utf8mb4character set? I assume it'd have to be the binary collation utf8mb4_bin, but it'd be good to clarify this. Sadly case- and accent-sensitive collations for Unicode character sets will only be available with MySQL 8.0 😞

Mar 19 2018, 8:51 PM · MediaWiki-Database

Mar 16 2018

TK-999 added a project to T181658: Numeric page titles can cause query page reports to stop updating: MediaWiki-Special-pages.
Mar 16 2018, 12:46 PM · MediaWiki-Special-pages, Patch-For-Review, MediaWiki-Database

Mar 14 2018

TK-999 added a comment to T189702: Replace transcache table with objectcache backend.

Yeah, the only reason created this separate ticket since it represents an improvement that can be done within the bounds of the existing interwiki transclusion system without requiring an extensive overhaul or migration process.

Mar 14 2018, 7:27 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), MediaWiki-Database, Patch-For-Review, Core-Platform-Team-Old, Performance-Team, MediaWiki-Templates
TK-999 added a comment to T189702: Replace transcache table with objectcache backend.

I'll gladly work on this if it is deemed to be acceptable.

Mar 14 2018, 4:39 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), MediaWiki-Database, Patch-For-Review, Core-Platform-Team-Old, Performance-Team, MediaWiki-Templates
TK-999 created T189702: Replace transcache table with objectcache backend.
Mar 14 2018, 4:38 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), MediaWiki-Database, Patch-For-Review, Core-Platform-Team-Old, Performance-Team, MediaWiki-Templates
TK-999 added a comment to T164167: change_tag table needs redesign.

Ohh, that is true, I'll have to rethink it. Still, it might make sense to consider a different schema in the long run to avoid the previously described issues...

Mar 14 2018, 2:12 PM · User-Ladsgroup, Schema-change, MediaWiki-Change-tagging, DBA
TK-999 added a comment to T164167: change_tag table needs redesign.

Since the schema of change_tags table is due to be adjusted, what do you think of tweaking it to avoid the current situation with 3 UNIQUE indexes and nullable columns? I was thinking of something along the lines of:

Mar 14 2018, 1:24 PM · User-Ladsgroup, Schema-change, MediaWiki-Change-tagging, DBA

Nov 29 2017

TK-999 added a comment to T181658: Numeric page titles can cause query page reports to stop updating.
-- Some sort of stored value. Sizes, counts...
qc_value int unsigned NOT NULL default 0,

I wonder what it's trying to put in it...

Nov 29 2017, 5:49 PM · MediaWiki-Special-pages, Patch-For-Review, MediaWiki-Database
TK-999 updated the task description for T181658: Numeric page titles can cause query page reports to stop updating.
Nov 29 2017, 5:44 PM · MediaWiki-Special-pages, Patch-For-Review, MediaWiki-Database
TK-999 created T181658: Numeric page titles can cause query page reports to stop updating.
Nov 29 2017, 5:40 PM · MediaWiki-Special-pages, Patch-For-Review, MediaWiki-Database

Nov 16 2017

TK-999 added a comment to T180752: Support customizing base path of Parsoid server.

Yes, after further investigation it seems we can use a proxy just fine. Thanks for your quick comments! This ticket can be closed then

Nov 16 2017, 11:36 PM · Parsoid
TK-999 added a comment to T180752: Support customizing base path of Parsoid server.

You can run multiple instances of Parsoid on various ports or (better) use a single Parsoid instance for all the various services. Parsoid can be configured with different api prefixes for different servers; in fact that's how WMF runs it in production (each Parsoid instance can handle all the different wmf sites).

Nov 16 2017, 11:18 PM · Parsoid
TK-999 created T180752: Support customizing base path of Parsoid server.
Nov 16 2017, 10:57 PM · Parsoid

Nov 9 2017

TK-999 added a comment to T180157: DatabaseMysqlBase::fieldExists check can trigger full table scan.

Yeah, the actual query indeed stops at the first row. Thanks for clarifying :)

Nov 9 2017, 8:06 PM · Patch-For-Review, MediaWiki-Database
TK-999 added a comment to T180157: DatabaseMysqlBase::fieldExists check can trigger full table scan.

On a MySQL 5.7 install:

Nov 9 2017, 7:38 PM · Patch-For-Review, MediaWiki-Database
TK-999 renamed T180157: DatabaseMysqlBase::fieldExists check can trigger full table scan from DatabaseBase::fieldExists check can trigger full table scan to DatabaseMysqlBase::fieldExists check can trigger full table scan.
Nov 9 2017, 7:22 PM · Patch-For-Review, MediaWiki-Database
TK-999 added a comment to T180157: DatabaseMysqlBase::fieldExists check can trigger full table scan.

Yeah, that's my bad - but the query is still there via DatabaseMysqlBase.

Nov 9 2017, 7:22 PM · Patch-For-Review, MediaWiki-Database
TK-999 added a comment to T180157: DatabaseMysqlBase::fieldExists check can trigger full table scan.

A potential alternative would be to use a DESCRIBE query here, kind of like this.

Nov 9 2017, 7:20 PM · Patch-For-Review, MediaWiki-Database
TK-999 created T180157: DatabaseMysqlBase::fieldExists check can trigger full table scan.
Nov 9 2017, 7:19 PM · Patch-For-Review, MediaWiki-Database

Sep 4 2017

TK-999 updated subscribers of T174908: Special:BrowseData causes error on MySQL 5.7 slave.
Sep 4 2017, 12:15 PM · Patch-For-Review, MediaWiki-extensions-SemanticDrilldown
TK-999 created T174908: Special:BrowseData causes error on MySQL 5.7 slave.
Sep 4 2017, 10:24 AM · Patch-For-Review, MediaWiki-extensions-SemanticDrilldown

May 23 2017

Qgil awarded T165981: Implement a prototype JavaScript review system for MediaWiki a Cookie token.
May 23 2017, 12:42 PM · Security, Developer-Advocacy, MediaWiki-extension-requests, Security-General, JavaScript, Wikimedia-Hackathon-2017

May 22 2017

TK-999 added a comment to T71445: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites.

Based on my work around T165981 during the 2017 Hackathon - which essentially involved creating a prototype implementation of Wikia's ContentReview extension compatible with core MediaWiki - I would like to note the following:

May 22 2017, 1:11 AM · Security, Developer-Wishlist (2017), Developer-Advocacy, Gadgets, Security-General, JavaScript, Wikimedia-General-or-Unknown

May 21 2017

TK-999 added a comment to T165981: Implement a prototype JavaScript review system for MediaWiki.

A few notes on how we can progress from here:

May 21 2017, 5:07 PM · Security, Developer-Advocacy, MediaWiki-extension-requests, Security-General, JavaScript, Wikimedia-Hackathon-2017
TK-999 added a comment to T165981: Implement a prototype JavaScript review system for MediaWiki.

Demo produced during hackathon is at https://github.com/TK-999/mediawiki-extensions-ContentReview

May 21 2017, 1:59 PM · Security, Developer-Advocacy, MediaWiki-extension-requests, Security-General, JavaScript, Wikimedia-Hackathon-2017
TK-999 added a comment to T162634: If you block an IP address as anonymous only, and then change it to a hardblock or vise versa, it is recorded as a completely new block.

Looks like this is the same issue that was reported in T157508

May 21 2017, 1:23 PM · MediaWiki-User-management
TK-999 created T165981: Implement a prototype JavaScript review system for MediaWiki.
May 21 2017, 12:00 PM · Security, Developer-Advocacy, MediaWiki-extension-requests, Security-General, JavaScript, Wikimedia-Hackathon-2017

Feb 16 2017

TK-999 edited projects for T157718: Skip User edit count computation in Autopromote if APCOND_EDITCOUNT isn't used, added: MediaWiki-Authentication-and-authorization; removed MediaWiki-General-or-Unknown.
Feb 16 2017, 12:03 AM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Performance, MediaWiki-Authentication-and-authorization

Feb 15 2017

TK-999 added a comment to T157718: Skip User edit count computation in Autopromote if APCOND_EDITCOUNT isn't used.

I've attached a patch which adds a simple check to return early if condition is 0 or invalid, with an associated unit test.

Feb 15 2017, 11:04 AM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Performance, MediaWiki-Authentication-and-authorization

Feb 9 2017

TK-999 created T157718: Skip User edit count computation in Autopromote if APCOND_EDITCOUNT isn't used.
Feb 9 2017, 7:34 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Performance, MediaWiki-Authentication-and-authorization

Feb 7 2017

TK-999 updated the task description for T157508: Issuing an anon-only block, then changing anon-only setting causes incorrect block settings to be applied for anon user.
Feb 7 2017, 10:52 PM · MediaWiki-User-management
TK-999 added a comment to T157508: Issuing an anon-only block, then changing anon-only setting causes incorrect block settings to be applied for anon user.

It seems when software performs block check via User::isBlocked etc., Block::newLoad tries to find the best matching block based on type, and because of https://github.com/wikimedia/mediawiki/blob/master/includes/Block.php#L332 the first match of Block::TYPE_IP (the older block) will always be preferred for anons.

Feb 7 2017, 10:51 PM · MediaWiki-User-management
TK-999 updated the task description for T157508: Issuing an anon-only block, then changing anon-only setting causes incorrect block settings to be applied for anon user.
Feb 7 2017, 10:47 PM · MediaWiki-User-management
TK-999 updated the task description for T157508: Issuing an anon-only block, then changing anon-only setting causes incorrect block settings to be applied for anon user.
Feb 7 2017, 10:47 PM · MediaWiki-User-management
TK-999 created T157508: Issuing an anon-only block, then changing anon-only setting causes incorrect block settings to be applied for anon user.
Feb 7 2017, 10:46 PM · MediaWiki-User-management