Page MenuHomePhabricator

TK-999 (Máté Szabó)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 7 2017, 10:09 PM (148 w, 4 d)
Availability
Available
LDAP User
TK-999
MediaWiki User
Unknown

Recent Activity

Today

TK-999 committed rEAFY87f849bf35eb: SUS-857: Add rights descriptions for extension-specific user rights (authored by TyA).
SUS-857: Add rights descriptions for extension-specific user rights
Sun, Dec 15, 12:19 AM

Wed, Dec 11

TK-999 awarded T240307: Hook container with strong types and DI a Yellow Medal token.
Wed, Dec 11, 6:08 PM · User-Daniel, Core Platform Team, TechCom-RFC

Fri, Nov 22

TK-999 closed T238273: unconference: Presentation about Wikia/Fandom's solution to MW configuration management at scale as Resolved.
Fri, Nov 22, 12:14 AM · Wikimedia-Technical-Conference-2019

Nov 14 2019

TK-999 added a comment to T238255: Unconference: How can we automate new wiki creation.

Suggestion from @akosiaris : T238273 ;)

Nov 14 2019, 10:39 PM · Wikimedia-Technical-Conference-2019
TK-999 added a comment to T238273: unconference: Presentation about Wikia/Fandom's solution to MW configuration management at scale.

Slides: https://docs.google.com/presentation/d/1sYvRVGUsK8bdX_olL2m8A2HUVeC3gvMQkVrbvP1z9gQ/edit?usp=sharing

Nov 14 2019, 10:26 PM · Wikimedia-Technical-Conference-2019

Nov 13 2019

TK-999 moved T238273: unconference: Presentation about Wikia/Fandom's solution to MW configuration management at scale from Backlog to Ideas for unconference on the Wikimedia-Technical-Conference-2019 board.
Nov 13 2019, 10:37 PM · Wikimedia-Technical-Conference-2019
TK-999 created T238273: unconference: Presentation about Wikia/Fandom's solution to MW configuration management at scale.
Nov 13 2019, 10:36 PM · Wikimedia-Technical-Conference-2019

Nov 5 2019

VIGNERON awarded T212881: addWiki.php broken creating ES tables a Like token.
Nov 5 2019, 10:20 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance

Nov 4 2019

TK-999 added a comment to T181658: Numeric page titles can cause query page reports to stop updating.

@Reedy Makes sense, who would be the person to ask for approval? :)

Nov 4 2019, 1:33 PM · MW-1.32-notes, MW-1.33-notes, MW-1.34-notes, MW-1.31-release-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikimedia-database-error, MediaWiki-Special-pages, Patch-For-Review

Oct 31 2019

TK-999 added a comment to T181658: Numeric page titles can cause query page reports to stop updating.

I've rebased the existing patchset, sorry about the undue delay incurred.

Oct 31 2019, 12:22 PM · MW-1.32-notes, MW-1.33-notes, MW-1.34-notes, MW-1.31-release-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikimedia-database-error, MediaWiki-Special-pages, Patch-For-Review
TK-999 added a comment to T181658: Numeric page titles can cause query page reports to stop updating.

Still an issue with 1.33

Oct 31 2019, 11:10 AM · MW-1.32-notes, MW-1.33-notes, MW-1.34-notes, MW-1.31-release-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikimedia-database-error, MediaWiki-Special-pages, Patch-For-Review

Oct 29 2019

TK-999 added a comment to T236810: Make private methods of Parser.php actually private.

@cscott I was wondering if there is a preferred migration path away from Parser::replaceLinkHolders for code that relied on it. I see that the mLinkHolders field in Parser is public, but I imagine that won't stay that way either, right? Thanks in advance!

Oct 29 2019, 7:02 PM · Parsoid, MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Parser

Oct 24 2019

TK-999 created T236374: ExternalStoreDB fails to connect for foreign wikis when custom external storage database names are used.
Oct 24 2019, 12:19 PM · MediaWiki-Revision-backend

Oct 16 2019

TK-999 added a comment to T235188: Preemptive refresh in getMultiWithSetCallback() and getMultiWithUnionSetCallback() pollutes cache.

Interesting, I've seen a similar caching issue where revision content got mixed up on a 1.33 wiki with $wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_NEW;. I haven't yet been able to consistently reproduce it, though.

Huh... I'd love to know more about this. Was that with external storage enabled, or without? What was the caching config?

Oct 16 2019, 11:05 PM · serviceops, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), User-ArielGlenn, Language-Team (Language-2019-October-December), Patch-For-Review, MediaWiki-General, affects-translatewiki.net
TK-999 added a comment to T234091: Theme: People and Processes.

How to share the burden of technical debt (e.g. how to make the implementation of accepted RfCs like dependency injection or extension registration not take the better part of a decade) would also be a useful topic. (Maybe that falls under platform stewardship?)

Oct 16 2019, 9:34 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019

Oct 12 2019

TK-999 added a comment to T234634: Wikimedia Technical Conference 2019 Session: On-wiki documentation & documentation as code: strengths, weaknesses, and compromises.

@josephine_l Thank you for the offer! However, being a first-time attendee, I'm afraid I am not sure what this would entail and how I should prepare for the task.

Oct 12 2019, 10:40 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
TK-999 added a comment to T234646: Wikimedia Technical Conference 2019 Session: Self-service Stateless Microservices (for APIs).

Something to consider would be using a monorepo for hosting such services. This setup can bring some benefits (less administrative overhead as provisioning a new service wouldn't require creating a new repository/package, easier code and dependency sharing between services, the ability to share CI/CD configuration for all services).

Oct 12 2019, 3:44 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019

Oct 11 2019

TK-999 added a comment to T234634: Wikimedia Technical Conference 2019 Session: On-wiki documentation & documentation as code: strengths, weaknesses, and compromises.

Something I was thinking about is whether storing developer documentation in an open wiki format on mediawiki.org may be a double edged sword. While this setup allows anyone to edit and improve the documentation, it's not always clear exactly how the documentation should be changed and who should approve changes, if anybody. Storing documentation in a VCS repo, perhaps next to source code even, could be an interesting alternative to consider, as it might allow for an easier review and contribution process. The session could also look at some other open source projects to see how they store and curate documentation.

Oct 11 2019, 5:10 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
TK-999 added a comment to T235188: Preemptive refresh in getMultiWithSetCallback() and getMultiWithUnionSetCallback() pollutes cache.

Interesting, I've seen a similar caching issue where revision content got mixed up on a 1.33 wiki with $wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_NEW;. I haven't yet been able to consistently reproduce it, though.

Huh... I'd love to know more about this. Was that with external storage enabled, or without? What was the caching config?

Oct 11 2019, 12:57 AM · serviceops, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), User-ArielGlenn, Language-Team (Language-2019-October-December), Patch-For-Review, MediaWiki-General, affects-translatewiki.net

Oct 10 2019

TK-999 added a comment to T235188: Preemptive refresh in getMultiWithSetCallback() and getMultiWithUnionSetCallback() pollutes cache.

Interesting, I've seen a similar caching issue where revision content got mixed up on a 1.33 wiki with $wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_NEW;. I haven't yet been able to consistently reproduce it, though.

Oct 10 2019, 10:44 PM · serviceops, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), User-ArielGlenn, Language-Team (Language-2019-October-December), Patch-For-Review, MediaWiki-General, affects-translatewiki.net

Oct 7 2019

TK-999 added a comment to T234632: Wikimedia Technical Conference 2019 Session: Local development environment - MediaWiki core.

As more and more services and technologies enter the orbit of MediaWiki (at least MediaWiki as deployed by Wikimedia), I'm wondering if it is still feasible to try to create and maintain an environment on developers' computers for

Oct 7 2019, 4:18 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
TK-999 awarded T234654: Wikimedia Technical Conference 2019 Session: Componentization and sharing with the open source community a Love token.
Oct 7 2019, 9:12 AM · International-Developer-Events, Wikimedia-Technical-Conference-2019

Oct 5 2019

TK-999 awarded T234655: Wikimedia Technical Conference 2019 Session: Mediawiki Code Ownership a Love token.
Oct 5 2019, 3:01 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
TK-999 awarded T234662: Wikimedia Technical Conference 2019 Session: Integrating contributions from other teams or volunteers a Love token.
Oct 5 2019, 2:55 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
TK-999 awarded T234651: Wikimedia Technical Conference 2019 Session: 3rd Party MediaWiki development and support a Love token.
Oct 5 2019, 2:54 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
TK-999 awarded T234633: Wikimedia Technical Conference 2019 Unconference: Reducing barriers to entry for new developers a Love token.
Oct 5 2019, 2:54 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019

Oct 4 2019

TK-999 added a watcher for Wikimedia-Technical-Conference-2019: TK-999.
Oct 4 2019, 10:13 PM

Oct 3 2019

TK-999 awarded T232563: Drop IE6 and IE7 basic compatibility and security support a Like token.
Oct 3 2019, 7:30 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MW-1.34-notes, User-notice, TechCom-RFC (TechCom-Approved), MediaWiki-General

Sep 30 2019

TK-999 added a comment to T218446: Remove use of legacy page.page_restrictions field.

@WDoranWMF This was initially set for later I believe, but given Wikia has started work on it for us, perhaps CR could be provided earlier. Just leaving this here for now :)

Sep 30 2019, 10:55 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), Schema-change, MediaWiki-General, Technical-Debt (Deprecation process)

Sep 29 2019

TK-999 added a comment to T214035: DBError "Error: 1213 Deadlock found when trying to get lock" on WikiPage::doUpdateRestrictions.

Uploaded a tentative fix as per my hypothesis regarding the root cause.

Sep 29 2019, 10:38 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Wikimedia-production-error

Sep 25 2019

TK-999 added a comment to T214035: DBError "Error: 1213 Deadlock found when trying to get lock" on WikiPage::doUpdateRestrictions.

I thought about this a bit. My impression is that this may be caused by the locks set by DELETE statements issued from WikiPage::doUpdateRestrictions.

Sep 25 2019, 10:46 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Wikimedia-production-error
Ruthven awarded T212881: addWiki.php broken creating ES tables a Stroopwafel token.
Sep 25 2019, 9:21 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance
Quiddity awarded T212881: addWiki.php broken creating ES tables a Love token.
Sep 25 2019, 8:18 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance
Ankry awarded T212881: addWiki.php broken creating ES tables a Like token.
Sep 25 2019, 7:31 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance
TK-999 reopened T233165: Tag a new release of avro-php, a subtask of T233012: Make MediaWiki core compatible with PHP 7.4, as Open.
Sep 25 2019, 4:55 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-General, Patch-For-Review, PHP 7.4 support
TK-999 reopened T233165: Tag a new release of avro-php as "Open".
Sep 25 2019, 4:55 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Patch-For-Review, PHP 7.4 support
TK-999 closed T233165: Tag a new release of avro-php, a subtask of T233012: Make MediaWiki core compatible with PHP 7.4, as Resolved.
Sep 25 2019, 4:55 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-General, Patch-For-Review, PHP 7.4 support
TK-999 closed T233165: Tag a new release of avro-php as Resolved.
Sep 25 2019, 4:55 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Patch-For-Review, PHP 7.4 support

Sep 18 2019

TK-999 awarded Blog Post: Wikipedia's JavaScript initialisation on a budget a Love token.
Sep 18 2019, 11:33 PM

Sep 17 2019

TK-999 added a subtask for T233012: Make MediaWiki core compatible with PHP 7.4: T233165: Tag a new release of avro-php.
Sep 17 2019, 9:53 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-General, Patch-For-Review, PHP 7.4 support
TK-999 added a parent task for T233165: Tag a new release of avro-php: T233012: Make MediaWiki core compatible with PHP 7.4.
Sep 17 2019, 9:53 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Patch-For-Review, PHP 7.4 support
TK-999 created T233165: Tag a new release of avro-php.
Sep 17 2019, 9:53 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Patch-For-Review, PHP 7.4 support
TK-999 added a comment to T231930: Introduce ActingUser to represent the user performing the current request.

I was thinking that the interface we are looking for here may be somewhat similar to the concept of authorization Subjects as found in e.g. the Apache Shiro framework—something that provides access to the identity of the principal being authorized and the context of the authorization (e.g. the current request/session). A hypothetical narrow definition of such an interface could look as follows:

Sep 17 2019, 4:23 PM · MediaWiki-User-management, CPT Initiatives (Decoupling (CDP2))

Sep 16 2019

TK-999 awarded T232613: LBFactoryMulti.php: PHP Notice: Undefined index: a Party Time token.
Sep 16 2019, 3:47 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Core Platform Team Workboards (Clinic Duty Team), Wikimedia-Rdbms, PHP 7.2 support, Wikimedia-production-error
TK-999 added a comment to T233012: Make MediaWiki core compatible with PHP 7.4.

The issue in the RemexHTML lib seems to have been fixed in https://gerrit.wikimedia.org/r/c/mediawiki/libs/RemexHtml/+/531022.

Sep 16 2019, 3:21 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-General, Patch-For-Review, PHP 7.4 support

Sep 11 2019

TK-999 added a comment to T232563: Drop IE6 and IE7 basic compatibility and security support.

Thank you for the notice :) From our (Wikia) standpoint, we have been requiring[1] TLS >= 1.2 for some time now like WMF does, preventing IE6/7 from accessing our sites. So dropping official support for these browsers should not be an issue from our perspective.

Sep 11 2019, 10:23 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MW-1.34-notes, User-notice, TechCom-RFC (TechCom-Approved), MediaWiki-General

Sep 3 2019

TK-999 added a comment to T109179: Migrate MySQLs to use ROW-based replication.

This is important, but not a goal for this quarter- we are still blocked on mediawiki extension maintainers to be compatible with it; however, all databases (misc, x1, parsercache, es) have been meanwhile migrated to ROW already with great success.
There are some issues to solve regarding schema changes, but this is still a desirable change; at least to have the option, even if we go for MIXED or STATEMENT.

Sep 3 2019, 10:32 PM · Operations, DBA
TK-999 added a comment to T231946: user_newtalk table is missing a primary key.

Looking at the design of this table, it seems that once the actor migration finishes (T167246), it may be possible to replace the user_id / user_ip field duo here with an actor_id reference, which could then naturally serve as a primary key.

Sep 3 2019, 9:55 PM · Core Platform Team, Wikimedia-Rdbms
TK-999 added a subtask for T17441: Some tables lack unique or primary keys, may allow confusing duplicate data: T231946: user_newtalk table is missing a primary key.
Sep 3 2019, 9:53 PM · MediaWiki-General, Wikimedia-database-error, PostgreSQL, DBA, Schema-change
TK-999 added a parent task for T231946: user_newtalk table is missing a primary key: T17441: Some tables lack unique or primary keys, may allow confusing duplicate data.
Sep 3 2019, 9:53 PM · Core Platform Team, Wikimedia-Rdbms
TK-999 created T231946: user_newtalk table is missing a primary key.
Sep 3 2019, 9:53 PM · Core Platform Team, Wikimedia-Rdbms

Aug 29 2019

TK-999 added a comment to T218555: Provide access to WebRequest and associated information via a service object.

@daniel, thanks for sharing the context about the cross-wiki initiative—much appreciated 🙂

Aug 29 2019, 4:20 PM · TechCom, MediaWiki-ServiceContainer, CPT Initiatives (Decoupling (CDP2))
TK-999 added a comment to T218555: Provide access to WebRequest and associated information via a service object.

What I mean is - what is our strategy for constructing things like a RevisionStore, Parser or MessageCache for another wiki. If services only vary by wiki and their Config, it is logically trivial to construct another tree for that, so long as its config can be retrieved (SiteConfiguration, legacy, known issues, limitations etc. yes).

Aug 29 2019, 2:06 PM · TechCom, MediaWiki-ServiceContainer, CPT Initiatives (Decoupling (CDP2))

Aug 28 2019

TK-999 added a comment to T218555: Provide access to WebRequest and associated information via a service object.

I'd like to share some of my thoughts related to this dilemma 🙂

Aug 28 2019, 3:07 PM · TechCom, MediaWiki-ServiceContainer, CPT Initiatives (Decoupling (CDP2))

Aug 27 2019

TK-999 added a comment to T194125: [RFC] Future of charset and collation for mediawiki on mysql .

Thank you for the explanation Anomie, it's all clear now. :)

Aug 27 2019, 6:35 PM · MediaWiki-Installer, MediaWiki-General, Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Wikimedia-Rdbms

Aug 26 2019

TK-999 added a comment to T228895: 2% of load.php spent creating DBLoadBalancerFactory in WebStart.php.

I've just uploaded a patch to defer this explicit instantiation. However, the DBLoadBalancerFactory will still be implicitly instantiated on every request if MediaWiki is configured to use a shared database, due to the following:

Aug 26 2019, 12:34 PM · Wikimedia-Rdbms, Performance-Team

Aug 13 2019

TK-999 added a comment to T222224: Normalize MediaWiki link tables.

This may resolve T196950, as the title_id could serve as the "stable identifier" mentioned there.

Aug 13 2019, 4:13 PM · DBA, Core Platform Team, MediaWiki-Page-derived-data, Schema-change, Patch-For-Review, TechCom-RFC

Jul 31 2019

TK-999 added a comment to T194125: [RFC] Future of charset and collation for mediawiki on mysql .

I wonder how this may be impacted by T191231. Theoretically, having such an abstraction layer could make it easier to add support for alternative collation configurations such as utf8mb4.

Jul 31 2019, 2:08 PM · MediaWiki-Installer, MediaWiki-General, Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Wikimedia-Rdbms

Jul 12 2019

TK-999 added a comment to T87781: Split mediawiki tests into unit and integration tests.

In general, it's better to combine composer dependencies of extension into core using composer merge plugin: https://www.mediawiki.org/wiki/Composer#Using_composer-merge-plugin

Thanks, should this be done by default or will we have instructions to tell developers to tweak their composer.local.json file to run the unit tests?

Jul 12 2019, 9:12 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Code-Health, Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Code-Health-Metrics, Epic, MediaWiki-Core-Testing

Jun 13 2019

TK-999 added a comment to T221177: REST route handler extension interface RFC.

Is https://phabricator.wikimedia.org/T221177#5219503 considered valid for the final version of the RfC? i.e. will the base path for the REST routes be configurable / respect existing $wgScriptPath values?

Jun 13 2019, 9:49 PM · Core Platform Team Workboards (Team 1), TechCom-RFC (TechCom-Approved), Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2))

Jun 4 2019

TK-999 updated subscribers of T225019: MSCompoundFileReaderTest fails on macOS.

Adding @tstarling as the author of this code—it seems that this might be an issue with how libiconv tries to interpret UTF-16 strings without a BOM.[1] Apparently it tries to guess endianness based on the current OS, so one gets different results on different machines. When I changed "UTF-16" to "UTF-16LE" on L336 of MSCompoundFileReader.php, to force little-endian byte order always, the test passed on macOS.

Jun 4 2019, 7:59 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Multimedia, MediaWiki-File-management, Commons, MediaWiki-Uploading
Restricted Application added projects to T225019: MSCompoundFileReaderTest fails on macOS: Commons, Multimedia.
Jun 4 2019, 7:58 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Multimedia, MediaWiki-File-management, Commons, MediaWiki-Uploading

Jun 2 2019

TK-999 added a comment to T89432: Make PHPUnit tests run without installing MediaWiki.

Here's what integration with Intellij's PHPUnit execution and coverage display looks like:

Jun 2 2019, 1:24 PM · Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Goal, MediaWiki-Core-Testing
TK-999 added a comment to T89432: Make PHPUnit tests run without installing MediaWiki.
Jun 2 2019, 10:55 AM · Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Goal, MediaWiki-Core-Testing

Jun 1 2019

TK-999 added a comment to T89432: Make PHPUnit tests run without installing MediaWiki.

This should be ready to move forward. I've updated the branch to split proper unit tests into their dedicated suite. 5301 unit tests can now be run from your IDE in less than 5 seconds! :)

Jun 1 2019, 2:33 PM · Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Goal, MediaWiki-Core-Testing

May 29 2019

TK-999 added a comment to T223727: Investigate OpenTracing integration with MediaWiki.

I did some work on this during the hackathon. I achieved basic instrumentation of MediaWiki DB queries using the PHP OpenTracing API and Jaeger as the implementation of choice. Instrumentation of BagOStuff (memcache etc.) lookups was also achieved but may not ultimately be useful due to the ubiquitous and fast nature of those transactions.

May 29 2019, 2:28 PM · MediaWiki-General, Wikimedia-Hackathon-2019

May 27 2019

TK-999 added a comment to T221535: Provide a "wiki farm" abstraction in MediaWiki core.

(moved from T224020):
How would this relate to the existing wikifarm related concepts that are already in core? It seems there is already:

May 27 2019, 4:10 PM · MediaWiki-Farmers, MediaWiki-Sites, MediaWiki-Configuration
TK-999 added a comment to T224020: Create a class to represent the identity of wikis on the same wiki farm.

Thanks, I will move this comment there!

May 27 2019, 4:09 PM · Performance-Team (Radar), Proposal, MediaWiki-General, MediaWiki-Farmers, User-Daniel
TK-999 added a comment to T224020: Create a class to represent the identity of wikis on the same wiki farm.

How would this relate to the existing wikifarm related concepts that are already in core? It seems there is already:

  • SiteConfiguration / wgConf
  • WikiMap that builds on top of SiteConfiguration and combines (duplicates?) it with $wgLocalDatabases
  • SiteStore / SiteLookup, i.e. the sites table.
May 27 2019, 2:14 PM · Performance-Team (Radar), Proposal, MediaWiki-General, MediaWiki-Farmers, User-Daniel
TK-999 added a watcher for MediaWiki-Farmers: TK-999.
May 27 2019, 11:26 AM

May 19 2019

TK-999 added a comment to T223099: Factor code for handling for options (preferences) out of User class.

The above patch is an initial implementation of what such a preference service could look like. With this approach, a migration path could look something like this:

  • Migrate uses of deprecated User::get/setOption** accessors to the service
  • Once all uses of these accessors have been migrated, remove the accessors, remove User::saveSettings, and remove the "shouldUpdateUserTouched" param from the service interface
  • (in parallel to the above two points) Migrate deprecated hook handlers
May 19 2019, 8:01 PM · CPT Initiatives (Decoupling (CDP2)), Core Platform Team Workboards (Contractor Workboard), Wikimedia-Hackathon-2019, Patch-For-Review, MediaWiki-User-management, MediaWiki-User-preferences
TK-999 added a comment to T223099: Factor code for handling for options (preferences) out of User class.

In the current state, memcache entries for User instances include their configured preferences as an array. Should this be kept for B/C during the refactor?

May 19 2019, 10:40 AM · CPT Initiatives (Decoupling (CDP2)), Core Platform Team Workboards (Contractor Workboard), Wikimedia-Hackathon-2019, Patch-For-Review, MediaWiki-User-management, MediaWiki-User-preferences

May 18 2019

TK-999 claimed T223727: Investigate OpenTracing integration with MediaWiki.
May 18 2019, 3:21 PM · MediaWiki-General, Wikimedia-Hackathon-2019
TK-999 moved T223727: Investigate OpenTracing integration with MediaWiki from Backlog to Projects on the Wikimedia-Hackathon-2019 board.
May 18 2019, 3:21 PM · MediaWiki-General, Wikimedia-Hackathon-2019
TK-999 created T223727: Investigate OpenTracing integration with MediaWiki.
May 18 2019, 3:21 PM · MediaWiki-General, Wikimedia-Hackathon-2019

May 15 2019

TK-999 committed rMTDAd5c5a2704e68: Adjust sed invocation due to macOS sed not recognizing "\t" (authored by TK-999).
Adjust sed invocation due to macOS sed not recognizing "\t"
May 15 2019, 9:22 PM
TK-999 committed rMTDA0ab9de860b8d: Change delimiter due to macOS sed not recognizing "\t" (authored by TK-999).
Change delimiter due to macOS sed not recognizing "\t"
May 15 2019, 12:22 AM

May 14 2019

TK-999 added a comment to T87781: Split mediawiki tests into unit and integration tests.

@kostajh I'm in!

May 14 2019, 10:00 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Code-Health, Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Code-Health-Metrics, Epic, MediaWiki-Core-Testing

May 10 2019

TK-999 added a comment to T87781: Split mediawiki tests into unit and integration tests.

@kostajh yup, that's right!

May 10 2019, 8:47 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Code-Health, Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Code-Health-Metrics, Epic, MediaWiki-Core-Testing

May 7 2019

TK-999 added a comment to T220867: Gerrit: Cannot assign user name "vladi2016" to account XXXX; name already in use..

Thank you! It's working fine now :)

May 7 2019, 5:55 PM · Release-Engineering-Team (Kanban), LDAP, Gerrit

May 6 2019

TK-999 added a comment to T220867: Gerrit: Cannot assign user name "vladi2016" to account XXXX; name already in use..

For reference, it seems the Gerrit 2.16 upgrade rollout is being tracked in T200739

May 6 2019, 11:39 PM · Release-Engineering-Team (Kanban), LDAP, Gerrit
TK-999 added a comment to T222186: Gerrit login failure for user tk-999.

Thanks @Paladox for investigating :) The timing of the issue is a bit unfortunate with the WM Hackathon coming up in a week, but I guess I can create a secondary account for that if all else fails.

May 6 2019, 11:28 PM · Gerrit, LDAP
TK-999 added a comment to T87781: Split mediawiki tests into unit and integration tests.

Yeah, that was my question, thanks!

May 6 2019, 2:55 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Code-Health, Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Code-Health-Metrics, Epic, MediaWiki-Core-Testing
TK-999 updated subscribers of T87781: Split mediawiki tests into unit and integration tests.

As suggested by @hashar , this ticket could potentially be a nice hackathon project—if not for Barcelona, then for Prague 😉It's still quite relevant and would make developers' life a whole lot easier.

May 6 2019, 2:15 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Code-Health, Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Code-Health-Metrics, Epic, MediaWiki-Core-Testing
TK-999 updated TK-999.
May 6 2019, 1:25 PM

Apr 30 2019

TK-999 added a comment to T222186: Gerrit login failure for user tk-999.

Note: I've tried other case variations of my Wikitech username as well (TK-999, Tk-999, tk-999), but to no avail.

Apr 30 2019, 3:33 PM · Gerrit, LDAP
TK-999 created T222186: Gerrit login failure for user tk-999.
Apr 30 2019, 3:11 PM · Gerrit, LDAP

Sep 19 2018

TK-999 added a comment to T204751: Expected mass commit of all peer transactions in TemporaryTableManager::queryWithAutoCommit: .

In this situation it should be safe to set explicitly the IDatabase::FLUSHING_ALL_PEERS flag since we want to commit any open implicit transaction.

Sep 19 2018, 10:19 AM · MediaWiki-extensions-SemanticDrilldown
TK-999 added a comment to T204751: Expected mass commit of all peer transactions in TemporaryTableManager::queryWithAutoCommit: .

I think this might be a result of https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/417477/ updating some transaction related warnings to exceptions. Need to take a look at what's going on there.

Sep 19 2018, 10:03 AM · MediaWiki-extensions-SemanticDrilldown

Aug 27 2018

Nemo_bis awarded T189702: Replace transcache table with objectcache backend a Doubloon token.
Aug 27 2018, 7:35 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Wikimedia-Rdbms, Patch-For-Review, Core-Platform-Team-Old, Performance-Team, MediaWiki-Templates

Jul 30 2018

TK-999 awarded T189702: Replace transcache table with objectcache backend a Love token.
Jul 30 2018, 12:47 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Wikimedia-Rdbms, Patch-For-Review, Core-Platform-Team-Old, Performance-Team, MediaWiki-Templates

Jul 11 2018

TK-999 created T199377: Consider removing page_restrictions.pr_user field from schema.
Jul 11 2018, 9:30 PM · MediaWiki-General, Patch-For-Review, Schema-change

May 19 2018

TK-999 awarded T194901: MediaWiki and GDPR a Orange Medal token.
May 19 2018, 8:58 PM · MediaWiki-Stakeholders-Group, Wikimedia-Hackathon-2018
TK-999 added a comment to T195028: Add goat import and export capability.

I believe this will be especially necessary given the data portability clauses of the GDPR. We must provide users with a way to export their own goats.

May 19 2018, 6:14 PM · Goatification, Wikimedia-Hackathon-2018

Apr 28 2018

TK-999 added a comment to T177024: Function to replace invisible characters with blank.

Probably the character 2062 (INVISIBLE TIMES) should be added to the list. For example, https://community.wikia.com/wiki/Special:Contributions/Low_Spark_of_Lyman%E2%81%A2%E2%81%A2 has this character appended to this user name, but it's visually indistinguishable from https://community.wikia.com/wiki/Special:Contributions/Low_Spark_of_Lyman .

Apr 28 2018, 11:10 PM · Patch-For-Review, AntiSpoof

Apr 26 2018

TK-999 added a comment to T182177: PHP function each() has been deprecated.

FYI, PHP 7.2 compatibility issues are fixed in version 1.10.2 of the PEAR Mail_Mime library.

Apr 26 2018, 2:27 PM · PHP 7.2 support, Upstream, MediaWiki-Vendor

Mar 20 2018

TK-999 added a comment to T183300: Use list=blocks to return all single IP blocks in a CIDR.

I think that's MySQL specific and won't work on other supported RDBMSes. AFAIK Postgres for instance has designated data types like cidr instead of this helper.

Mar 20 2018, 4:26 PM · MediaWiki-API
TK-999 added a comment to T183300: Use list=blocks to return all single IP blocks in a CIDR.

I was thinking that it might help with this task, if we separated concerns between the ipblocks.ipb_user and ipblocks.ipb_address fields:

Mar 20 2018, 1:40 PM · MediaWiki-API
TK-999 added a comment to T51504: ipb_range_start and ipb_range_end should be blank for single-IP blocks.

Thank you very much for the quick review @Anomie 🙂 I have amended the patch set according to your notes.

Mar 20 2018, 1:19 PM · Patch-For-Review, Performance Issue, MediaWiki-User-management

Mar 19 2018

TK-999 added a comment to T50767: Support 'utf8mb4' character set in MySQL 5.5 and above.

What collation would MediaWiki use for the utf8mb4character set? I assume it'd have to be the binary collation utf8mb4_bin, but it'd be good to clarify this. Sadly case- and accent-sensitive collations for Unicode character sets will only be available with MySQL 8.0 😞

Mar 19 2018, 8:51 PM · Wikimedia-Rdbms