Page MenuHomePhabricator

TK-999 (Máté Szabó)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 7 2017, 10:09 PM (251 w, 4 d)
Availability
Available
LDAP User
TK-999
MediaWiki User
Unknown

Recent Activity

Fri, Nov 26

TK-999 added a comment to T296023: Parsoid needs a LazyLinkTarget factory.

Scott noted on https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/738019/ that it may be beneficial to include the variant link resolution mechanism currently implemented in the legacy parser's LinkHolderArray into this proposed new resolver.

Fri, Nov 26, 1:19 PM · Parsoid-Read-Views (Phase 2), Parsoid

Thu, Nov 11

TK-999 added a comment to T222064: Parsoid doesn't work with node 12.

NB: for those out there still using Parsoid/JS, while it was indeed crashing on startup with Node 12, it seems to have no such qualms with Node 16. The parser test suite passes as well, with only the Cite blacklist needing to be regenerated (but without new failures).

Thu, Nov 11, 2:49 AM · Parsoid

Nov 1 2021

TK-999 added a comment to T292402: TDF: Review mechanism to configure individual MediaWiki installations.

Provide proper support for wiki-farms (multi-tenant setups), not only for the benefit of WMF's production configuration but also for testing and development as well as 3rd party installations of MediaWiki.

Nov 1 2021, 9:11 PM · Platform Engineering, tech-decision-forum

Oct 31 2021

TK-999 added a comment to T264735: MultiHttpClient has hard-coded deprecated cURL option used by CdnCacheUpdate.

If it is possible to move the current functionality into an extension without losing performance, it would be rather useful since it would be a nice example in ‘how to make a purge client extension’. I wanted to implement a small purge proxy in Rust but got stuck in MW's purge client code and then kind of forgot about it.

Oct 31 2021, 10:57 PM · MW-1.36-release, Patch-For-Review, Platform Team Workboards (Clinic Duty Team), MW-1.35-release, PHP 8.0 support, PHP 7.4 support, MediaWiki-libs-HTTP

Aug 18 2021

TK-999 added a comment to T288848: Make HTTP calls work within mediawiki on kubernetes .

For the record, to resolve the same issue during our effort to upgrade Fandom's MW-on-k8s deployment, we ended up creating an HttpRequestFactory service override to dynamically use the current k8s service as proxy for request URLs known to belong to wikis on our platform. Some "automatic" solution like that could help avoid the whack-a-mole of updating every extension and core call site that makes internal HTTP requests. The logic for determining whether an URL should be automatically proxied or not would probably be similar to the existing core MWHttpRequest::isLocalURL method.

Aug 18 2021, 7:39 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), MW-on-K8s, serviceops, SRE

Jul 19 2021

TK-999 added a comment to T286694: Legacy cruft from introduction of ResultWrapper.

I don't know if there is anyone out there using this extension, but fixing it on the off chance there is.

Jul 19 2021, 3:57 PM · Technical-Debt (Deprecation process), Wikimedia-Rdbms, Patch-For-Review
TK-999 added a comment to T286694: Legacy cruft from introduction of ResultWrapper.

Thanks for the ping. WhosOnline was undeployed in 2015 and hasn't been in use since: https://github.com/Wikia/app/commit/9ae0e22367087bb606eecb7cea211e61880a5c79

Jul 19 2021, 12:35 PM · Technical-Debt (Deprecation process), Wikimedia-Rdbms, Patch-For-Review

Jun 21 2021

TK-999 created T285271: ForeignAPIRepo should allow reusing cached values across wikis.
Jun 21 2021, 8:30 PM · Commons, Patch-For-Review, MediaWiki-File-management

Apr 27 2021

TK-999 added a comment to T278565: Parsoid: p-wrapping shouldn't try to wrap <aside> tags.

Thanks!

Apr 27 2021, 11:43 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Parsoid

Apr 22 2021

TK-999 added a project to T216808: VE shuffles the order of template parameters in template dialog: VisualEditor-MediaWiki-Templates.
Apr 22 2021, 12:11 PM · WMDE-TechWish-Sprint-2021-11-24, VisualEditor-MediaWiki-Templates, VisualEditor, TemplateData

Apr 14 2021

TK-999 added a comment to T280078: TemplateData support for specifying parameters that are allowed to be empty.

Thanks for the heads-up! I have pinged some folks on our side for awareness so they can look into what would be the best approach from our perspective.

Apr 14 2021, 10:37 PM · VisualEditor, TemplateData

Mar 26 2021

TK-999 created T278565: Parsoid: p-wrapping shouldn't try to wrap <aside> tags.
Mar 26 2021, 4:40 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Parsoid
TK-999 created T278543: updateSpecialPages.php tries (and fails) to silently ignore DB errors.
Mar 26 2021, 12:43 PM · Patch-For-Review, MediaWiki-Maintenance-system

Mar 19 2021

TK-999 added a comment to T277829: Understand or mitigate duplicate ParserCache fetches in the same request.

I think I know the reason for idoptions.

During a normal page view, we reuse the cached parse metadata to construct the PoolCounter work key. That's needed cause we want the PoolCounter work key to differentiate by parser options just like ParserCache does, and the used options are stored in parser cache.

Then, when we actually do the pool work, it looks up the cache entry in the parser cache - that internally looks up metadata first.

So we basically always fetch from the metadata twice.

Mar 19 2021, 8:29 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), MediaWiki-Parser

Mar 17 2021

TK-999 added a comment to T277693: ForeignDBFile attempts to load users in the context of the wrong wiki.

Thanks for the quick response! This fix in itself would not solve our problems, as we still have to finish the actor migration across all of our wikis. I consider this patch more as a future insurance to ensure the problem doesn't pop up after that's done, so probably not so urgent.

Mar 17 2021, 8:27 PM · Platform Team Workboards (MW Expedition), Patch-For-Review, Commons, MediaWiki-File-management
TK-999 updated subscribers of T277693: ForeignDBFile attempts to load users in the context of the wrong wiki.

Tentatively tagging @daniel and @Pchelolo due to their recent work around similar issues. :)

Mar 17 2021, 7:57 PM · Platform Team Workboards (MW Expedition), Patch-For-Review, Commons, MediaWiki-File-management
Pcj awarded T277693: ForeignDBFile attempts to load users in the context of the wrong wiki a Like token.
Mar 17 2021, 7:13 PM · Platform Team Workboards (MW Expedition), Patch-For-Review, Commons, MediaWiki-File-management
TK-999 added a comment to T277693: ForeignDBFile attempts to load users in the context of the wrong wiki.

Note: This is essentially T222212 but for images.

Mar 17 2021, 7:04 PM · Platform Team Workboards (MW Expedition), Patch-For-Review, Commons, MediaWiki-File-management
TK-999 created T277693: ForeignDBFile attempts to load users in the context of the wrong wiki.
Mar 17 2021, 6:59 PM · Platform Team Workboards (MW Expedition), Patch-For-Review, Commons, MediaWiki-File-management

Feb 17 2021

TK-999 created T275033: MessageCache generates high number of memcache GETs for nonexistent messages.
Feb 17 2021, 2:57 PM · Performance-Team, MediaWiki-Cache

Feb 12 2021

TK-999 added a comment to T274648: ExtensionRegistry: Allow reusing cached queues between wikis.

@TK-999 thanks, this is great! I'm curious to how you measured the ExtensionRegistry cache miss rate, we probably should be tracking that too.

Feb 12 2021, 8:48 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Performance-Team (Radar), Patch-For-Review, MediaWiki-Configuration
TK-999 added a comment to T274648: ExtensionRegistry: Allow reusing cached queues between wikis.

Tentatively labeling this task for the Performance Team due to ongoing related ER improvements at T274445 and elsewhere.

Feb 12 2021, 4:03 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Performance-Team (Radar), Patch-For-Review, MediaWiki-Configuration
TK-999 added a project to T274648: ExtensionRegistry: Allow reusing cached queues between wikis: Performance-Team (Radar).
Feb 12 2021, 4:02 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Performance-Team (Radar), Patch-For-Review, MediaWiki-Configuration
TK-999 created T274648: ExtensionRegistry: Allow reusing cached queues between wikis.
Feb 12 2021, 2:21 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Performance-Team (Radar), Patch-For-Review, MediaWiki-Configuration

Feb 10 2021

TK-999 added a comment to T240775: RFC: Support PHP 7.4 preload.

I'm not sure how much benefit we would get eagerly loading class definitions. I expect this to not matter so much since that's largely opcache's responsibility, and would matter even less after we disable opcache's revalidation-ttl's (thus no more file stats for mtimes).

Feb 10 2021, 2:59 PM · MediaWiki-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Performance-Team, TechCom-RFC

Feb 9 2021

TK-999 added a comment to T240775: RFC: Support PHP 7.4 preload.

Something to consider: If preload will encompass not just core code but e.g. extension classes, it may break extensions that use class_exists checks in conditionals to determine if some other extension is loaded, since class_exists will always return true for all preloaded classes, even if the extension providing them might not be enabled in the context of the current wiki. So these checks may need to be swapped out to use ExtensionRegistry::isLoaded or an equivalent instead.

Feb 9 2021, 1:51 PM · MediaWiki-General, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Performance-Team, TechCom-RFC

Jan 27 2021

TK-999 added a comment to T249164: RFC: Better interface for generating metrics in MediaWiki.

Should the timing metrics emitted by the new interface be mapped to Prometheus histograms or summaries? By default, statsd_exporter will map timers to summaries, and Prometheus docs warn against using summaries in aggregations,[1][2] which can be a problem when gathering metrics from multiple nodes.

Jan 27 2021, 11:01 PM · Observability-Metrics, Metrics-Platform, Product-Data-Infrastructure (Backlog), Better Use Of Data, TechCom-RFC
TK-999 added a comment to T268847: PHP 8: libxml_disable_entity_loader() is deprecated.

Should we introduce some wfLibXmlDisableEntityLoader helper function that does the appropriate thing depending on PHP / libxml versions?

Jan 27 2021, 6:00 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Patch-For-Review, MediaWiki-General, PHP 8.0 support

Jan 13 2021

TK-999 added a comment to T268857: PHP 8: Fatal error while running Parsoid tests with opcache enabled.

So, I reran the parsoid parser tests with a PHP 8.0.0 release build and a PHP 8.0.1 one, and I got no fatals with and without opcache. Would be nice if someone else could confirm, but it does look like whatever caused this error was fixed before the PHP 8 release.

Jan 13 2021, 1:23 PM · Upstream, Parsoid, PHP 8.0 support

Jan 11 2021

TK-999 added a comment to T271733: MW 1.33+: Special:AbuseLog is empty on wikis where AbuseFilter was installed before 2010.

Looks like this is resolved in T240895.

Jan 11 2021, 5:24 PM · AbuseFilter
TK-999 closed T271733: MW 1.33+: Special:AbuseLog is empty on wikis where AbuseFilter was installed before 2010 as Resolved.
Jan 11 2021, 5:24 PM · AbuseFilter
TK-999 created T271733: MW 1.33+: Special:AbuseLog is empty on wikis where AbuseFilter was installed before 2010.
Jan 11 2021, 5:16 PM · AbuseFilter

Dec 10 2020

TK-999 added a comment to T269718: RCE in Widgets extension (CVE-2020-35625).

Hey, just wanted to let you know that the patch has been applied to Gamepedia wikis. It's fine from our perspective to move forward and make this issue/patch public. Thanks for the heads-up!

Dec 10 2020, 4:23 PM · Vuln-DirectObjectReference, Vuln-MissingAuthz, ShoutWiki, MediaWiki-extensions-Widgets, Security

Nov 27 2020

TK-999 created T268857: PHP 8: Fatal error while running Parsoid tests with opcache enabled.
Nov 27 2020, 12:38 AM · Upstream, Parsoid, PHP 8.0 support

Nov 26 2020

TK-999 added a subtask for T248925: Make MediaWiki compatible with PHP 8: T268852: PHP 8: parse_url() change causes a parser test failure.
Nov 26 2020, 9:41 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Patch-For-Review, MW-1.35-notes, PHP 8.0 support, MediaWiki-General, MediaWiki-Stakeholders-Group
TK-999 added a parent task for T268852: PHP 8: parse_url() change causes a parser test failure: T248925: Make MediaWiki compatible with PHP 8.
Nov 26 2020, 9:41 PM · MW-1.35-release, MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MediaWiki-Parser, MediaWiki-General, PHP 8.0 support
TK-999 created T268852: PHP 8: parse_url() change causes a parser test failure.
Nov 26 2020, 9:40 PM · MW-1.35-release, MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MediaWiki-Parser, MediaWiki-General, PHP 8.0 support
TK-999 added a comment to T248925: Make MediaWiki compatible with PHP 8.

unexpected token "match"

Yea, see http://maettig.com/2020-09-21-prepare-for-php-8. Functions named match might be one of the bigger PHP 7→8 problems we have. I started renaming some already. Here is the rest: https://codesearch.wmcloud.org/search/?q=function%20match%5Cb&files=%5C.php%24. This doesn't cover Wikia codebases, unfortunately.

Nov 26 2020, 8:26 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Patch-For-Review, MW-1.35-notes, PHP 8.0 support, MediaWiki-General, MediaWiki-Stakeholders-Group
TK-999 added a comment to T248925: Make MediaWiki compatible with PHP 8.

More specifically, any PHPUnit mock/stub encountered by tests throws an error like:

1) ActorMigrationTest::testInsertRoundTrip with data set "normal" ('actormigration1', 'am1_user', 'am1_id', false)
ParseError: syntax error, unexpected token "match"
Nov 26 2020, 7:56 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Patch-For-Review, MW-1.35-notes, PHP 8.0 support, MediaWiki-General, MediaWiki-Stakeholders-Group
TK-999 added a comment to T248925: Make MediaWiki compatible with PHP 8.

@Reedy Currently I'm not sure if we can even get the test suite to run on PHP 8 without upgrading PHPUnit first (there are some errors from generated mock code). I monkey-patched PHPUnit 9 over master to work around that for now on my local machine.

Nov 26 2020, 7:49 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Patch-For-Review, MW-1.35-notes, PHP 8.0 support, MediaWiki-General, MediaWiki-Stakeholders-Group
TK-999 added a subtask for T248925: Make MediaWiki compatible with PHP 8: T268847: PHP 8: libxml_disable_entity_loader() is deprecated.
Nov 26 2020, 6:30 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Patch-For-Review, MW-1.35-notes, PHP 8.0 support, MediaWiki-General, MediaWiki-Stakeholders-Group
TK-999 added a parent task for T268847: PHP 8: libxml_disable_entity_loader() is deprecated: T248925: Make MediaWiki compatible with PHP 8.
Nov 26 2020, 6:30 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Patch-For-Review, MediaWiki-General, PHP 8.0 support
TK-999 created T268847: PHP 8: libxml_disable_entity_loader() is deprecated.
Nov 26 2020, 6:29 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Patch-For-Review, MediaWiki-General, PHP 8.0 support
TK-999 added a subtask for T248925: Make MediaWiki compatible with PHP 8: T268846: Update MediaWiki to a new wikimedia/testing-access-wrapper release.
Nov 26 2020, 6:10 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Patch-For-Review, MW-1.35-notes, PHP 8.0 support, MediaWiki-General, MediaWiki-Stakeholders-Group
TK-999 added a parent task for T268846: Update MediaWiki to a new wikimedia/testing-access-wrapper release: T248925: Make MediaWiki compatible with PHP 8.
Nov 26 2020, 6:10 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MW-1.35-notes, MW-1.35-release, Release, PHP 8.0 support, MediaWiki-Core-Tests
TK-999 created T268846: Update MediaWiki to a new wikimedia/testing-access-wrapper release.
Nov 26 2020, 6:09 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MW-1.35-notes, MW-1.35-release, Release, PHP 8.0 support, MediaWiki-Core-Tests

Nov 16 2020

TK-999 added a comment to T101075: Do not save unused (or deliberately removed) suggested parameters when inserting or editing transclusions.

Looks like the old Wikia-WMF VisualEditor implementation is handling this case already, so I have ported the relevant logic from https://github.com/Wikia/app/pull/6450/commits/858eaa928dda808999d9c3f0e253dcde582b901e#diff-499ee0316d78ea3542a87f1412b1db0adf23bf227669ad50495aa7ef7988b6a0R74 and submitted a patch.

Nov 16 2020, 6:48 PM · Skipped QA, User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Editing-team (FY2021-22 Kanban Board), VisualEditor-MediaWiki-Templates, VisualEditor

Nov 13 2020

TK-999 closed T267563: MsUpload bar is showing on non-wikitext pages as Resolved.
Nov 13 2020, 11:08 AM · MediaWiki-extensions-MsUpload

Nov 9 2020

TK-999 created T267563: MsUpload bar is showing on non-wikitext pages.
Nov 9 2020, 3:01 PM · MediaWiki-extensions-MsUpload

Oct 14 2020

TK-999 closed T259719: UserEditTracker attempts to initialize edit count in read only mode as Resolved.
Oct 14 2020, 12:50 AM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Platform Team Workboards (External Code Reviews), MediaWiki-User-management
TK-999 added a comment to T259719: UserEditTracker attempts to initialize edit count in read only mode.

Looks like it's been on WMF production without issues, so I'll close this. Thanks!

Oct 14 2020, 12:50 AM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Platform Team Workboards (External Code Reviews), MediaWiki-User-management

Oct 5 2020

TK-999 added a comment to T264536: MediaWiki 1.31 throws PHP Warning: Cannot modify header information - headers already sent by (output started at SectionProfiler.php:99) in WebResponse.php on line 74.

MediaWiki 1.31 doesn't support PHP 7.4, IIRC. This warning was fixed in rMW278227608808c25242c87a7092da5fb9adc50cde.

Oct 5 2020, 12:43 AM · PHP 7.4 support, Performance-Team (Radar), MW-1.31-release, MediaWiki-Core-Profiler

Sep 22 2020

TK-999 added a comment to T263545: Decide on logging in k8s for ShellBox.

This also relies on FPM's catch_workers_output and decorate_workers_output options to redirect workers' stdout and stderr into the main error log FPM is configured to use, without messing up the formatting of the messages logged by applayer. However, the latter param is only available from PHP 7.3 onwards.

Sep 22 2020, 3:37 PM · Shellbox, MW-on-K8s, serviceops, SRE
TK-999 added a comment to T263545: Decide on logging in k8s for ShellBox.

The "official" PHP docker images use the same method for FPM (output redirection) to get worker logs into stdout so they can be ingested: https://github.com/docker-library/php/blob/d6838d8e45f6356d867dbc8ff8b3513492cba500/7.3/buster/fpm/Dockerfile#L230

Sep 22 2020, 3:32 PM · Shellbox, MW-on-K8s, serviceops, SRE

Sep 1 2020

TK-999 added a watcher for MW-on-K8s: TK-999.
Sep 1 2020, 3:46 PM

Aug 25 2020

TK-999 closed T260997: Linker::getRollbackEditCount queries are forced into a suboptimal execution plan due to index forcing as Resolved.
Aug 25 2020, 8:41 PM · MediaWiki-Recent-changes, Performance Issue
TK-999 added a comment to T260997: Linker::getRollbackEditCount queries are forced into a suboptimal execution plan due to index forcing.

@TK-999 I'm very interested in the Percona aspect of this. Have you tried my Percona driver ??

I doubt it would solve this problem, but I'm curious about how you're approaching the different index handling.

Aug 25 2020, 8:40 PM · MediaWiki-Recent-changes, Performance Issue

Aug 21 2020

TK-999 added a comment to T260997: Linker::getRollbackEditCount queries are forced into a suboptimal execution plan due to index forcing.

Interestingly, https://www.mediawiki.org/wiki/Manual:$wgShowRollbackEditCount suggests that $wgMiserMode can be used to disable this counting of edits for rollback links rendering, but the code seems to perform the calculation anyways (in \Linker::generateRollback).

Aug 21 2020, 4:25 PM · MediaWiki-Recent-changes, Performance Issue
TK-999 added a comment to T260997: Linker::getRollbackEditCount queries are forced into a suboptimal execution plan due to index forcing.

The query also performs well with the index forcing if I get rid of the JOINs on the comment tables, since they are never actually used by this query.

Aug 21 2020, 2:39 PM · MediaWiki-Recent-changes, Performance Issue
TK-999 edited projects for T260997: Linker::getRollbackEditCount queries are forced into a suboptimal execution plan due to index forcing, added: Platform Engineering; removed Growth-Team.

Tagging Platform as potential stakeholders and @hoo as the original author of the query :)

Aug 21 2020, 2:36 PM · MediaWiki-Recent-changes, Performance Issue
TK-999 added a comment to T260997: Linker::getRollbackEditCount queries are forced into a suboptimal execution plan due to index forcing.

Looking at the latest source code, it seems the index forcing is still present there as well. It may be worth to consider removing it if we can verify it doesn't hurt the performance on MariaDB.

Aug 21 2020, 2:34 PM · MediaWiki-Recent-changes, Performance Issue
TK-999 created T260997: Linker::getRollbackEditCount queries are forced into a suboptimal execution plan due to index forcing.
Aug 21 2020, 2:32 PM · MediaWiki-Recent-changes, Performance Issue

Aug 18 2020

TK-999 added a comment to T199323: Checkuser does not truncate data (cuc_comment, cuc_agent, cuc_actiontext) and that causes exceptions with strict mode.

Yup, should be all good!

Aug 18 2020, 9:10 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), affects-translatewiki.net, CheckUser

Aug 12 2020

TK-999 added a comment to T248756: RevisionStore::getRevisionByTitle can fail for foreign wikis when called with TitleValue.

This should be resolved now, thanks!

Aug 12 2020, 9:57 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), MediaWiki-Revision-backend
TK-999 closed T248756: RevisionStore::getRevisionByTitle can fail for foreign wikis when called with TitleValue as Resolved.
Aug 12 2020, 9:57 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), MediaWiki-Revision-backend

Aug 5 2020

TK-999 added a comment to T249673: RFC: A modern and restrictive (but flexible!) skin system using Mustache.

One point is not immediately clear for me: Does this proposal aim to remove the option of writing PHP-based skins altogether, or does it preserve the option of using PHP to implement a skin if need be?

Aug 5 2020, 11:25 PM · Patch-For-Review, MediaWiki-Core-Skin-Architecture, User-Jdlrobson, TechCom-RFC
TK-999 created T259719: UserEditTracker attempts to initialize edit count in read only mode.
Aug 5 2020, 4:00 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Platform Team Workboards (External Code Reviews), MediaWiki-User-management

Aug 1 2020

TK-999 added a comment to T259362: Permit temporary table operations to be executed on replica connections.

Thanks for the review! :)

Aug 1 2020, 3:01 PM · MW-1.35-notes, Patch-For-Review, Performance-Team, Platform Team Workboards (External Code Reviews), Wikimedia-Rdbms
Krinkle awarded T259362: Permit temporary table operations to be executed on replica connections a Orange Medal token.
Aug 1 2020, 3:00 AM · MW-1.35-notes, Patch-For-Review, Performance-Team, Platform Team Workboards (External Code Reviews), Wikimedia-Rdbms

Jul 31 2020

TK-999 added a comment to T259362: Permit temporary table operations to be executed on replica connections.

Tagging Daniel, Aaron, Roan and Adam on this ticket for visibility as contributors to T183265 and T183242.

Jul 31 2020, 3:46 PM · MW-1.35-notes, Patch-For-Review, Performance-Team, Platform Team Workboards (External Code Reviews), Wikimedia-Rdbms
TK-999 created T259362: Permit temporary table operations to be executed on replica connections.
Jul 31 2020, 3:45 PM · MW-1.35-notes, Patch-For-Review, Performance-Team, Platform Team Workboards (External Code Reviews), Wikimedia-Rdbms
TK-999 added a comment to T222224: RFC: Normalize MediaWiki link tables.

@TK-999 Hi, I wonder if Fandom have perhaps done something in this area?

Jul 31 2020, 3:25 PM · DBA, Platform Engineering, MediaWiki-Page-derived-data, Schema-change, Patch-For-Review, TechCom-RFC

Jun 12 2020

TK-999 added a comment to T199323: Checkuser does not truncate data (cuc_comment, cuc_agent, cuc_actiontext) and that causes exceptions with strict mode.

@Paladox No worries. I will create a fresh patchset on top of master with all relevant changes restored.

Jun 12 2020, 4:02 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), affects-translatewiki.net, CheckUser
TK-999 added a comment to T199323: Checkuser does not truncate data (cuc_comment, cuc_agent, cuc_actiontext) and that causes exceptions with strict mode.

@Paladox I noticed that truncation logic was removed from the above patch (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/598196/6..7) for several code paths, such as account creation logging. Can you clarify why this was done?

Jun 12 2020, 2:18 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), affects-translatewiki.net, CheckUser

Jun 9 2020

TK-999 added a comment to T157508: Issuing an anon-only block, then changing anon-only setting causes incorrect block settings to be applied for anon user.

T251188 should fix this issue.

Jun 9 2020, 12:02 PM · MediaWiki-Blocks
TK-999 closed T157508: Issuing an anon-only block, then changing anon-only setting causes incorrect block settings to be applied for anon user as Resolved.
Jun 9 2020, 12:01 PM · MediaWiki-Blocks
TK-999 added a comment to T251188: ipb_address_unique has an extra column in production but not in the code.

This will probably address T157508 as well.

Jun 9 2020, 2:18 AM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Anti-Harassment (The Letter Song), Blocked-on-schema-change, DBA

May 23 2020

TK-999 added a comment to T236880: Document when to use different ILoadBalancer::get*Connection* methods.

I think there are some additional nuances to consider here:

  • getConnectionRef() should be the default for all foreign wiki DB connections because the caller must call ILoadBalancer::reuseConnection() for those when they're finished with the connection, so using getConnectionRef() can be a saner way of managing this unless the caller explicitly wants to control the lifecycle of the foreign DB connections it opens.
  • @aaron seems to be working on some improvements to DB connection pooling in https://gerrit.wikimedia.org/r/q/I540b08920997c5 for T226595, which, when complete, would probably mean that all callers should prefer getConnectionRef() for both local and foreign connections.
May 23 2020, 9:48 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Platform Engineering (Icebox), Performance-Team, Documentation, Wikimedia-Rdbms, MediaWiki-Documentation

May 14 2020

TK-999 added a comment to T252798: How should hook implementations access the current request context?.

Historically, it seems that hooks were updated to pass the request context to the handlers when needed, for instance in rMW1051f68e7d438d20df44fd9386a0a451e77fbb8e. Given that request context is not suitable for injection as per T218555, this strikes me as probably the most suitable approach.

May 14 2020, 6:03 PM · Platform Team Initiatives (New Hook System), Anti-Harassment, TechCom

May 5 2020

TK-999 added a comment to T146571: Add a primary key to querycache table.

If it's not feasible to weed out duplicates, possibly even a (qc_type,qc_value,qc_namespace,qc_title) PK could be an improvement. For MySQL at least, it'd avoid bug 76252, and reduce overall storage space usage when using InnoDB.[1]

May 5 2020, 12:56 AM · Schema-change, MediaWiki-Special-pages, Patch-For-Review

Apr 29 2020

TK-999 added a comment to T247990: Tests leak memory under PHP 7.4 and 8.

Is there much we can do about this one? Other than waitng for an upstream fix, and a possible backport/similar?

I've tried adjusting MediaWikiIntegrationTestCase::installMockMwServices to clone the default service container, as opposed to populating a new instance from wiring files, when not given any config overrides.

That seems risky. I'd rather find a way to cache the wiring array itself, so we don't re-create all these closures for every test.

Apr 29 2020, 11:42 AM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Workboards (External Code Reviews), Patch-For-Review, Upstream, PHP 7.4 support, PHP 8.0 support, MediaWiki-Core-Tests

Apr 28 2020

TK-999 added a comment to T248061: RFC: Remove IE 8 from basic support.

Thanks for reaching out! I've confirmed that IE 8 has no support status on either of our wiki products so there are no objections from our side.

Apr 28 2020, 1:42 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), MW-1.36-release, TechCom-RFC (TechCom-RFC-Closed), Tech-Ambassadors, User-notice, MediaWiki-General, Browser-Support-Internet-Explorer, Front-end-Standards-Group

Apr 25 2020

TK-999 added a comment to T247990: Tests leak memory under PHP 7.4 and 8.

Is there much we can do about this one? Other than waitng for an upstream fix, and a possible backport/similar?

Apr 25 2020, 8:57 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Workboards (External Code Reviews), Patch-For-Review, Upstream, PHP 7.4 support, PHP 8.0 support, MediaWiki-Core-Tests

Apr 4 2020

TK-999 added a comment to T247990: Tests leak memory under PHP 7.4 and 8.

I tried to debug this a bit today, and would like to post the results here in case it may be useful to somebody with better PHP internals knowledge than me (and that's a very low bar!)

Apr 4 2020, 10:45 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Workboards (External Code Reviews), Patch-For-Review, Upstream, PHP 7.4 support, PHP 8.0 support, MediaWiki-Core-Tests
TK-999 added a comment to T247990: Tests leak memory under PHP 7.4 and 8.

https://github.com/php/php-src/commit/0f2cdbf214efd98b4bdaf5ca41728faf00e7c037 looks to be a likely culprit (introduced as a fix for PHP bug 78903). Specifically the monotonically increasing rtd_counter appears to mean that each time a file containing a closure is included, a new entry will be generated in the function table for the closure. After some quick & dirty testing locally, removing the counter seems to stabilize memory usage.

Apr 4 2020, 1:39 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Workboards (External Code Reviews), Patch-For-Review, Upstream, PHP 7.4 support, PHP 8.0 support, MediaWiki-Core-Tests

Apr 3 2020

TK-999 added a comment to T247990: Tests leak memory under PHP 7.4 and 8.

@MaxSem I wonder if this is somehow related to https://bugs.php.net/bug.php?id=76982. Granted, that one seems to have been present on PHP 7.x as well, but perhaps PHP 8 exacerbated the issue.

Apr 3 2020, 11:27 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Workboards (External Code Reviews), Patch-For-Review, Upstream, PHP 7.4 support, PHP 8.0 support, MediaWiki-Core-Tests

Mar 28 2020

TK-999 added a comment to T248756: RevisionStore::getRevisionByTitle can fail for foreign wikis when called with TitleValue.

This looks to be caused by rMWaed6be4, which changed RevisionStore::getRevisionByTitle to convert the passed LinkTarget to a Title using Title::newFromLinkTarget, to resolve T206498. Unfortunately, this breaks when the given RevisionStore is operating in the context of a foreign wiki. In this scenario, when RevisionStoreRecord::__construct calls Title::getArticleID on the Title instance to perform a sanity check of the page ID against the page ID reference stored in the revision table for the given revision record, then Title::getArticleID will lazily fetch the page ID on the local, rather than the foreign wiki. This results in the aforementioned InvalidArgumentException being thrown.

Mar 28 2020, 7:24 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), MediaWiki-Revision-backend
TK-999 created T248756: RevisionStore::getRevisionByTitle can fail for foreign wikis when called with TitleValue.
Mar 28 2020, 7:14 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), MediaWiki-Revision-backend

Mar 24 2020

TK-999 added a comment to T248333: Schema change: Make page.page_restrictions column NULL.

It is looking good, thank you!

Mar 24 2020, 11:39 AM · Blocked-on-schema-change, DBA

Mar 23 2020

TK-999 added a subtask for T218446: Remove use of legacy page.page_restrictions field: T248333: Schema change: Make page.page_restrictions column NULL.
Mar 23 2020, 5:54 PM · Platform Engineering Code Jam, MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), Schema-change, MediaWiki-General, Technical-Debt (Deprecation process)
TK-999 added a parent task for T248333: Schema change: Make page.page_restrictions column NULL: T218446: Remove use of legacy page.page_restrictions field.
Mar 23 2020, 5:54 PM · Blocked-on-schema-change, DBA
TK-999 created T248333: Schema change: Make page.page_restrictions column NULL.
Mar 23 2020, 5:53 PM · Blocked-on-schema-change, DBA

Mar 21 2020

TK-999 added a comment to T223099: Factor code for handling for options (preferences) out of User class.

@DannyS712 Thanks for reaching out :) Unfortunately this tasks seems to have stalled and I couldn't find the time to get back to it. I am not sure about next steps.

Mar 21 2020, 12:03 AM · Platform Team Initiatives (Decoupling (CDP2)), Platform Team Workboards (S&F Workboard), Wikimedia-Hackathon-2019, MediaWiki-User-management, MediaWiki-User-preferences

Mar 18 2020

TK-999 placed T165981: Implement a prototype JavaScript review system for MediaWiki up for grabs.
Mar 18 2020, 5:43 PM · Security, Developer-Advocacy, MediaWiki-extension-requests, JavaScript, Wikimedia-Hackathon-2017

Mar 6 2020

Nemo_bis awarded T245582: Show "you are creating a new article" notification only once per session a Doubloon token.
Mar 6 2020, 3:53 PM · VisualEditor, VisualEditor-MediaWiki

Feb 19 2020

TK-999 added a comment to T245582: Show "you are creating a new article" notification only once per session.

If this is OK to implement, this could potentially be as simple as setting a cookie/session data in ApiVisualEditor when first showing the newarticletext notice to a registered user, and checking this data on subsequent calls so as not to show the notice again.

Feb 19 2020, 1:28 AM · VisualEditor, VisualEditor-MediaWiki
TK-999 created T245582: Show "you are creating a new article" notification only once per session.
Feb 19 2020, 1:26 AM · VisualEditor, VisualEditor-MediaWiki

Feb 13 2020

TK-999 awarded Blog Post: Parsoid in PHP, or There and Back Again a Love token.
Feb 13 2020, 2:06 AM · Parsoid

Feb 7 2020

TK-999 added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

Developing a new component library in any framework will need to be done in a way that aligns with Wikimedia’s existing design system. Integrating any new tools we adopt into this system is a precondition to production usage and should commence as soon as possible.

Feb 7 2020, 10:47 PM · Front-end-Standards-Group, Design-Systems-team, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Jan 31 2020

TK-999 added a comment to T238716: HTML for newly-created pages with VE on testwiki not stored in RESTBase.

@mobrovac I was able to reproduce this issue on mediawiki.org as well (screenshot attached).

Screenshot 2020-01-31 at 17.56.50.png (1×1 px, 384 KB)

It seems that when creating the page, VE first tries to request the page HTML from RESTBase, using the /page/html/{title} endpoint. Since the page doesn't exist, RESTBase will return a 404 cached for 5 minutes (cache-control: s-maxage=600).

Jan 31 2020, 5:05 PM · Platform Engineering (Icebox), RESTBase, VisualEditor