Page MenuHomePhabricator

TK-999 (Máté Szabó)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 7 2017, 10:09 PM (368 w, 3 d)
Availability
Available
LDAP User
TK-999
MediaWiki User
Unknown

Recent Activity

Tue, Feb 13

TK-999 created T357395: Only run CargoStore validation logic before storing data.
Tue, Feb 13, 11:37 AM · MediaWiki-extensions-Cargo

Mon, Feb 12

TK-999 created T357313: Setup E2E tests for Cargo.
Mon, Feb 12, 2:10 PM · MediaWiki-extensions-Cargo

Tue, Feb 6

TK-999 closed T355530: Cannot delete files with non-standard extensions on MySQL in a strict mode as Resolved.
Tue, Feb 6, 3:51 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MW-1.41-notes, MW-1.39-notes, MW-1.40-notes, MediaWiki-Uploading
TK-999 closed T355530: Cannot delete files with non-standard extensions on MySQL in a strict mode, a subtask of T108255: Enable MariaDB/MySQL's Strict Mode, as Resolved.
Tue, Feb 6, 3:51 PM · SRE-Sprint-Week-Sustainability-March2023, Epic, Beta-Cluster-Infrastructure, DBA, MediaWiki-libs-Rdbms

Mon, Feb 5

TK-999 added a comment to T316540: Support macOS compatibility.

It seems that kqueue is usable on macOS for at least wall-time profiling and simple timers—and unlike other Apple-specific APIs, should be available on other OSes too like BSD, which should facilitate testing. I cobbled together a patch leveraging this that seems to work on macOS.

Mon, Feb 5, 11:08 AM · MediaWiki-Platform-Team, Developer Productivity, Excimer
TK-999 triaged T356568: PHP deprecation warning on Special:Drilldown as Low priority.
Mon, Feb 5, 8:39 AM · Patch-For-Review, PHP 8.1 support, MediaWiki-extensions-Cargo
TK-999 closed T356568: PHP deprecation warning on Special:Drilldown as Resolved.
Mon, Feb 5, 8:38 AM · Patch-For-Review, PHP 8.1 support, MediaWiki-extensions-Cargo

Sat, Feb 3

TK-999 created T356568: PHP deprecation warning on Special:Drilldown.
Sat, Feb 3, 2:48 PM · Patch-For-Review, PHP 8.1 support, MediaWiki-extensions-Cargo

Jan 30 2024

TK-999 added a comment to T320980: Add parameters to control ActorCache.

This should no longer be necessary, as the mentioned tests have been adjusted to not need such functionality.

Jan 30 2024, 8:05 AM · MediaWiki-User-management

Jan 23 2024

TK-999 edited projects for T32148: Year 10,000 problem, added: Patch-For-Review; removed Patch-Needs-Improvement.
Jan 23 2024, 2:34 PM · Patch-For-Review, I18n, MediaWiki-General

Dec 20 2023

TK-999 added a comment to T257703: Clean up Cache-Control handling in MediaWiki.

Making session initialization happen at a predictable point in time was one of the design goals of the current session system, and IMO it resulted in much easier to reason about behavior, so it would be nice to keep that.

Dec 20 2023, 8:54 AM · Sustainability (Incident Followup), FR-CentralNotice-Caching, MediaWiki-Core-AuthManager
TK-999 added a comment to T257703: Clean up Cache-Control handling in MediaWiki.

Having something in place for REST that would allow handlers to specify whether they depend on a session SGTM irregardless—but we should consider the case where a handler unknowingly ends up depending on the session because of some deep dependency.

Dec 20 2023, 8:17 AM · Sustainability (Incident Followup), FR-CentralNotice-Caching, MediaWiki-Core-AuthManager
TK-999 added a comment to T257703: Clean up Cache-Control handling in MediaWiki.

That would mean the session is not available during hooks that run between the beginning of Setup.php and wherever session initialization would happen. Checking for registered or temp users would return the wrong result, messages would be rendered in the wrong language etc. Currently the only hook that runs before session initialization is MediaWikiServices and there the services are not set up yet so it's very unlikely that something session-dependent would be attempted.

The opposite approach would be to have some sort of URL routing step very early in Setup.php or the entry point which would determine whether this request needs a session. I think that's how a more modern web application would work: determining which controller handles the request is one of the first steps. MediaWiki doesn't really have controllers but it could be approximated for REST URLs.

Dec 20 2023, 8:16 AM · Sustainability (Incident Followup), FR-CentralNotice-Caching, MediaWiki-Core-AuthManager

Dec 19 2023

TK-999 added a comment to T257703: Clean up Cache-Control handling in MediaWiki.

More broadly, we may need to revisit the practice of eagerly setting up the session itself in Setup.php as well, since that itself may set cookies even if nothing attempts to interact with the session user during the lifetime of the request.

I had the same conclusion when analysing the related task T285210#9415537, and defering session management would make the warning Cookies set on {url} with Cache-Control "{cache-control}" more useful for developers to track actual code paths where both session is used and cache-control is declared as public.

At the same time, some session-independent API-like requests (API with action=query, index.php with action=raw, Wikibase’s Special:EntityData…) might also be marked as "should not use $wgUser" to extend a bit more the mechanism MW_NO_SESSION, and these would not set Set-Cookie if it don’t use $wgUser (and emit a log if they do).

Dec 19 2023, 10:15 PM · Sustainability (Incident Followup), FR-CentralNotice-Caching, MediaWiki-Core-AuthManager

Nov 23 2023

TK-999 added a comment to T302083: Source and preview getting out of sync on Firefox for Android (keyboard / GBoard app may be involved).

Adding @TK-999 since they wrote a patch for a similar issue in VE. Maybe they can provide some insights :)

Nov 23 2023, 4:34 PM · Editing-team, DiscussionTools

Nov 13 2023

TK-999 added a subtask for T289926: Fix passing null to non-null param of PHP internal functions in MediaWiki core (PHP 8.1 warning): T351088: PHP 8.1: WebRequest::getFuzzyBool may emit deprecation warnings.
Nov 13 2023, 2:41 PM · MW-1.40-notes (1.40.0-wmf.24; 2023-02-20), MW-1.39-release, MW-1.39-notes, MW-1.38-release, MW-1.38-notes, Patch-For-Review, MW-1.36-notes, MW-1.35-notes, MediaWiki-extensions-General, MediaWiki-General, PHP 8.1 support
TK-999 added a parent task for T351088: PHP 8.1: WebRequest::getFuzzyBool may emit deprecation warnings: T289926: Fix passing null to non-null param of PHP internal functions in MediaWiki core (PHP 8.1 warning).
Nov 13 2023, 2:41 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), MediaWiki-Platform-Team, MediaWiki-General, PHP 8.1 support
TK-999 moved T351088: PHP 8.1: WebRequest::getFuzzyBool may emit deprecation warnings from Backlog to MediaWiki core on the PHP 8.1 support board.
Nov 13 2023, 2:40 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), MediaWiki-Platform-Team, MediaWiki-General, PHP 8.1 support
TK-999 created T351088: PHP 8.1: WebRequest::getFuzzyBool may emit deprecation warnings.
Nov 13 2023, 2:07 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), MediaWiki-Platform-Team, MediaWiki-General, PHP 8.1 support

Nov 2 2023

TK-999 edited projects for T51504: ipb_range_start and ipb_range_end should be blank for single-IP blocks, added: Patch-For-Review; removed Patch-Needs-Improvement.
Nov 2 2023, 8:48 PM · Patch-For-Review, MediaWiki-Blocks, Performance Issue

Oct 25 2023

TK-999 added a comment to T344189: array_merge_recursive inefficient on PHP 8.2 in HtmlForm.

What page(s) does this happen on reliably?

Oct 25 2023, 10:18 AM · Performance Issue, MediaWiki-HTMLForm, PHP 8.2 support

Oct 17 2023

TK-999 added a comment to T347507: ParsoidExtensionAPI: Provide a new method for extensions to access enclosing template parameters.

Thanks @Alex44019 and @cscott for raising this one. I remember discussing it with the team a while back, but the Parsoid extension API was considerably less fleshed out back then.

Oct 17 2023, 9:32 AM · Parsoid-Read-Views, Parsoid

Oct 15 2023

TK-999 added a comment to T324207: Phan crashes on css-sanitizer on PHP 8.1.

Taint-check is fully under our control, but it's not causing this crash as per above. This is a bug in phan itself. But unfortunately I agree with the second part of your comment. Phan is all but actively maintained at the moment, and this is already causing us troubles (T325321 immediately comes to mind).

Oct 15 2023, 6:35 AM · Patch-For-Review, Upstream, phan, PHP 8.1 support, css-sanitizer

Oct 13 2023

TK-999 added a comment to T324207: Phan crashes on css-sanitizer on PHP 8.1.

Might be worth to manually patch the affected plugin in CI—Phan seems to have been in development limbo for most of this year, there is very little activity both in terms of code changes and responding to issues.

Oct 13 2023, 4:07 PM · Patch-For-Review, Upstream, phan, PHP 8.1 support, css-sanitizer

Oct 11 2023

TK-999 edited projects for T53587: Parsoid needs to run findVariantLink or some equivalent thing, added: Patch-For-Review; removed Patch-Needs-Improvement.
Oct 11 2023, 3:53 PM · MediaWiki-Language-converter, Patch-For-Review, Parsoid-Read-Views (Phase 4 - Parsoid generates metadata needed by core), Parsoid-Rendering, Parsoid, Chinese-Sites

Oct 9 2023

TK-999 added a comment to T258856: Links to variants titles in Parsoid are still marked as red links.

Rebased this since it got a question about its status, just wanted to note per earlier discussions on the patch that T296023 probably needs to be resolved first to unblock this.

Oct 9 2023, 11:03 PM · Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Patch-For-Review, Parsoid-Rendering, Parsoid
TK-999 added a comment to T275710: Deprecate IContextSource::getWikiPage and IContextSource::canUseWikiPage.

Perhaps one option could be to add a new method to WikiPageFactory that returns an optionally cached WikiPage instance for a given PageIdentity. That could then be used as a replacement without a performance cost.

Oct 9 2023, 10:38 AM · Patch-For-Review, MediaWiki-General, Platform Team Workboards (MW Expedition)

Sep 27 2023

TK-999 added a comment to T321527: Support conditional defaults for user properties.

Thanks for the CC.

Sep 27 2023, 4:19 PM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Growth-Team (Sprint 5 (Growth Team)), Wikimedia-Performance-recommendation, Proposal, MediaWiki-Core-Preferences

Sep 13 2023

TK-999 triaged T346265: ApiParse returns numeric file names as numbers in imagelinks section as Low priority.
Sep 13 2023, 9:51 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-Action-API
TK-999 closed T346265: ApiParse returns numeric file names as numbers in imagelinks section as Resolved.
Sep 13 2023, 9:50 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-Action-API
TK-999 moved T346265: ApiParse returns numeric file names as numbers in imagelinks section from Unsorted to Needs Review on the MediaWiki-Action-API board.
Sep 13 2023, 6:10 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-Action-API
TK-999 created T346265: ApiParse returns numeric file names as numbers in imagelinks section.
Sep 13 2023, 6:05 PM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), MediaWiki-Action-API

Aug 15 2023

TK-999 added a comment to T344189: array_merge_recursive inefficient on PHP 8.2 in HtmlForm.

Possibly. I think it's worth disabling the JIT (ie making sure that opcache.jit_buffer_size is unset or 0, which is the default) though just to rule it out as a cause—it's been known to cause oddball issues when it is enabled that simply do not occur when it is off, and its maintenance status in general is dubious.

Aug 15 2023, 4:05 PM · Performance Issue, MediaWiki-HTMLForm, PHP 8.2 support
TK-999 added a comment to T344189: array_merge_recursive inefficient on PHP 8.2 in HtmlForm.

Might be worth an upstream report if a minimal reproducer can be isolated.

Aug 15 2023, 11:31 AM · Performance Issue, MediaWiki-HTMLForm, PHP 8.2 support

Jul 26 2023

TK-999 added a comment to T342748: mw-on-k8s app container CPU throttling at low average load.

@Clement_Goubert Yeah, we currently set a limit of 1 CPU per worker. We have not experimented with pinning.

Jul 26 2023, 1:52 PM · serviceops, MW-on-K8s
TK-999 added a comment to T342748: mw-on-k8s app container CPU throttling at low average load.

We were consistently throttled until we set limits == FPM worker count. Per the description (and Dan Luu's insightful foray[1]) into the topic, I don't think there is much that can be done besides adjusting or removing the limits or tweaking the CFS period that k8s uses. Removing the limits is probably fine given that the size of the worker pool is a natural upper bound on concurrency with pm = static.

Jul 26 2023, 1:07 PM · serviceops, MW-on-K8s

Jul 25 2023

TK-999 added a comment to T342201: MediaWiki\Extension\Notifications\Api\ApiEchoUnreadNotificationPages::getUnreadNotificationPagesFromForeign: Unexpected API response from {wiki}.

We've encountered spurious memcached timeouts (likely due to packet loss) with MW on k8s since forever. Are there any memcached errors logged as part of the same request?

Jul 25 2023, 11:01 AM · Growth-Team, serviceops, SRE, MediaWiki-Platform-Team, MW-1.41-notes (1.41.0-wmf.20; 2023-08-01), MediaWiki-extensions-CentralAuth, MW-on-K8s, Notifications, Wikimedia-production-error

Jul 21 2023

TK-999 closed T286928: Undefined index 0 exception in ExtArrays.php as Resolved.
Jul 21 2023, 12:20 PM · MediaWiki-extensions-Arrays

Jul 18 2023

TK-999 created T342127: CodeEditor $.textSelection('replaceSelection',...) fails.
Jul 18 2023, 2:37 PM · MW-1.41-notes (1.41.0-wmf.19; 2023-07-25), CodeEditor
hashar awarded T322748: LuaSandbox segmentation fault on PHP 8 during request shutdown a Love token.
Jul 18 2023, 8:50 AM · Upstream, php-segfault, PHP 8.0 support, LuaSandbox
TK-999 added a comment to T322748: LuaSandbox segmentation fault on PHP 8 during request shutdown.

Thanks, this is great!

Jul 18 2023, 2:10 AM · Upstream, php-segfault, PHP 8.0 support, LuaSandbox

Jul 17 2023

TK-999 added a comment to T322748: LuaSandbox segmentation fault on PHP 8 during request shutdown.

I think this is not a PHP 8.0 specific issue, it'd likely happen on earlier versions as well. We just happened to notice it because we were on the lookout for core dumps while investigating unrelated JIT issues.

Jul 17 2023, 8:31 PM · Upstream, php-segfault, PHP 8.0 support, LuaSandbox
TK-999 added a comment to T322748: LuaSandbox segmentation fault on PHP 8 during request shutdown.

Thanks a lot, Tim :)- using your advice, I inspected a more recent dump and found that it was a request where PHP was exceeding its configured memory limit while it was parsing a rather complex page. Going by that, I managed to narrow it down to a consistent reproducer:

--TEST--
Memory limit exceeded during sandbox init
--INI--
memory_limit=2M
--FILE--
<?php
$buf = str_repeat('a', 1000000);
$sandboxes = [];
for ($i = 0; $i < 100; $i++) {
    $sandboxes[] = new LuaSandbox();
}
?>
--EXPECTF--
Fatal error: Allowed memory size of 2097152 bytes exhausted%s(tried to allocate %d bytes) in %s on line %d
Jul 17 2023, 8:30 PM · Upstream, php-segfault, PHP 8.0 support, LuaSandbox
TK-999 closed T341945: PageForms may pick up default form from invalid page props as Resolved.
Jul 17 2023, 2:24 PM · MediaWiki-extensions-Page_Forms

Jul 16 2023

TK-999 updated the task description for T341945: PageForms may pick up default form from invalid page props.
Jul 16 2023, 1:34 PM · MediaWiki-extensions-Page_Forms
TK-999 created T341945: PageForms may pick up default form from invalid page props.
Jul 16 2023, 1:17 PM · MediaWiki-extensions-Page_Forms

Jul 15 2023

TK-999 added a comment to T337087: Move Cargo backlink updates to LinksUpdate.

Thank you, I forgot to circle back and close this task.

Jul 15 2023, 12:35 PM · Wikimedia-Hackathon-2023, MediaWiki-extensions-Cargo

Jul 14 2023

TK-999 added projects to T341319: RecentChanges: Improve performance of Special:RecentChanges rendering : Performance Issue, Performance-Team.
Jul 14 2023, 11:00 AM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Wikimedia-Performance-recommendation, Anti-Harassment, Performance Issue, Patch-For-Review, Growth-Team, MediaWiki-Recent-changes

Jul 12 2023

TK-999 added a comment to T249164: RFC: Better interface for generating metrics in MediaWiki.

I wonder if OpenTelemetry metrics could be an alternative here.[1] T340551 makes it seem likely that the OTEL Collector will be deployed as an infrastructure component, so it could potentially be leveraged for exporting metrics in Prometheus format[2] while avoiding the use of APCu or a dedicated storage backend. What do you think?

Jul 12 2023, 6:52 AM · Observability-Metrics, Metrics Platform Backlog, Product-Data-Infrastructure (Backlog), Better Use Of Data, TechCom-RFC

Jun 13 2023

TK-999 added a comment to T338421: PageForms generates TransactionProfiler warnings on pageviews.

Thanks! Sorry, it seems I missed one spot so I made a fast follow.

Jun 13 2023, 11:54 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Jun 8 2023

TK-999 created T338421: PageForms generates TransactionProfiler warnings on pageviews.
Jun 8 2023, 10:45 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Jun 2 2023

TK-999 added a comment to T270525: Evaluate php-mustache .

It seems that the libmustache library used by php-mustache for actual mustache rendering purposes does not yet support referencing section data in some cases, i.e. given data like

$data = [ 'foo' => 'bar' ];

then

{{#foo}}{{.}} should be bar {{/foo}}

won't render correctly. Vector 2022 heavily uses this, so I made https://github.com/jbboehr/libmustache/pull/25 to hopefully try and fix this.

Jun 2 2023, 7:26 PM · Performance-Team

May 21 2023

TK-999 added a comment to T56140: Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot.

Tagging Wikimedia-Hackathon-2023 to showcase a basic PoC created during this event.

May 21 2023, 8:50 AM · Patch-For-Review, Wikimedia-Hackathon-2023, Multi-Content-Revisions, VisualEditor-MediaWiki, VisualEditor, TemplateData
TK-999 added a project to T56140: Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot: Wikimedia-Hackathon-2023.
May 21 2023, 8:50 AM · Patch-For-Review, Wikimedia-Hackathon-2023, Multi-Content-Revisions, VisualEditor-MediaWiki, VisualEditor, TemplateData

May 20 2023

TK-999 created T337087: Move Cargo backlink updates to LinksUpdate.
May 20 2023, 8:11 AM · Wikimedia-Hackathon-2023, MediaWiki-extensions-Cargo

May 19 2023

TK-999 edited projects for T324921: Add interface for extension properties to Parser, added: Wikimedia-Hackathon-2023; removed Wikimania-Hackathon-2023.
May 19 2023, 11:27 AM · Content-Transform-Team, Wikimedia-Hackathon-2023, Patch-For-Review, Technical-Debt, PHP 8.2 support, MediaWiki-Parser
TK-999 added a project to T324921: Add interface for extension properties to Parser: Wikimania-Hackathon-2023.
May 19 2023, 11:25 AM · Content-Transform-Team, Wikimedia-Hackathon-2023, Patch-For-Review, Technical-Debt, PHP 8.2 support, MediaWiki-Parser

Apr 25 2023

TK-999 created T335370: Cargo tables with more than 500 rows cannot be recreated on MW 1.38+.
Apr 25 2023, 4:24 PM · MediaWiki-extensions-Cargo

Apr 17 2023

TK-999 closed T334756: CargoSQLQuery: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated on PHP 8.1 as Resolved.
Apr 17 2023, 9:39 AM · PHP 8.1 support, MediaWiki-extensions-Cargo
TK-999 closed T334755: CargoQueryAPI doesn't expose error when a disallowed field alias is used as Resolved.
Apr 17 2023, 9:33 AM · MediaWiki-extensions-Cargo

Apr 14 2023

TK-999 created T334756: CargoSQLQuery: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated on PHP 8.1.
Apr 14 2023, 4:59 PM · PHP 8.1 support, MediaWiki-extensions-Cargo
TK-999 created T334755: CargoQueryAPI doesn't expose error when a disallowed field alias is used.
Apr 14 2023, 4:04 PM · MediaWiki-extensions-Cargo

Mar 29 2023

TK-999 added a comment to T333181: Cargo phan change is causing Page Forms validation to fail.

That should be fine for now. After that, we could either:

  • Configure PageForms to ignore Phan stubs in other extensions via a config stanza such as $cfg['exclude_file_regex'] = '@^../../extensions/Cargo/.phan/stubs/@';, or
  • Reimplement the hooks change in Cargo without stubs. This will require people to have a checkout of the AdminLinks extension to run phan locally and will also need a corresponding integration/config patch as noted by Sam.
Mar 29 2023, 1:34 PM · MediaWiki-extensions-Cargo

Mar 27 2023

TK-999 added a comment to T333181: Cargo phan change is causing Page Forms validation to fail.

Okay, that would work. And now I think I understand why Cargo has these class re-declarations: so that the validation will know that these classes exist, since Admin Links is not being loaded. But why do none of the other extensions that also hook in to Admin Links (https://www.mediawiki.org/wiki/Category:AdminLinks_extensions) need these class declarations? (I think.)

Mar 27 2023, 4:29 PM · MediaWiki-extensions-Cargo
TK-999 added a comment to T333181: Cargo phan change is causing Page Forms validation to fail.

Sorry about that.

Mar 27 2023, 3:34 PM · MediaWiki-extensions-Cargo

Mar 21 2023

TK-999 added a comment to T331689: It would be cool if cargo had configuration to reduce risk of denial of service attacks.

AIUI PHP's max_execution_time is a CPU-time limit, rather than a wall time limit. It also cannot interrupt pending queries.

Mar 21 2023, 7:19 PM · MediaWiki-extensions-Cargo

Mar 16 2023

TK-999 added a comment to T305105: TemplateData save hook causes a duplicate parse, and is questionable UX.

And indeed it always seems to do so (at least on MW 1.40 CLI):

 % php maintenance/run.php shell.php
Psy Shell v0.11.12 (PHP 8.0.28 — cli) by Justin Hileman
> $services = MediaWiki\MediaWikiServices::getInstance();
= MediaWiki\MediaWikiServices {#26}
Mar 16 2023, 5:36 PM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), WMDE-TechWish-Sprint-2022-03-30, Unplanned-Sprint-Work, Patch-For-Review, VisualEditor, WMDE-TechWish-Maintenance, TemplateData
TK-999 added a comment to T305105: TemplateData save hook causes a duplicate parse, and is questionable UX.

FWIW, on MW 1.39 it seems like the double parse may be avoided if the parser output doesn't depend on any revision/page specific bits (i.e. no {{REVISIONID}}) and friends, as generate-html does not actually appear to change whether the ParserOutput generated from wikitext has HTML or not.

Mar 16 2023, 4:07 PM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), WMDE-TechWish-Sprint-2022-03-30, Unplanned-Sprint-Work, Patch-For-Review, VisualEditor, WMDE-TechWish-Maintenance, TemplateData

Mar 10 2023

TK-999 added a comment to T241321: Index more HydraWiki repositories from GitLab.com.

Hi there, just wanted to note that the hydrawiki org is no longer used for any actively utilized extensions. Relevant extensions have been migrated to the Wikia org on GitHub under the same names.

Mar 10 2023, 5:48 PM · VPS-project-Codesearch

Feb 27 2023

TK-999 added a comment to T326480: PHP 8.2 failure for ApiResultTest::testTransformations for different order of the result.

Sorry about the delay in following up, I was busy with some other work.

Feb 27 2023, 12:12 PM · Patch-For-Review, MediaWiki-Core-Tests, MediaWiki-Action-API, PHP 8.2 support

Feb 23 2023

TK-999 updated the task description for T330404: Deprecate JobQueueFederated.
Feb 23 2023, 2:13 PM · Technical-Debt, MediaWiki-Core-JobQueue
TK-999 created T330404: Deprecate JobQueueFederated.
Feb 23 2023, 2:11 PM · Technical-Debt, MediaWiki-Core-JobQueue

Feb 20 2023

TK-999 updated the task description for T330100: RecentChanges and WatchList unnecessarily render the page for RCFilters redirects.
Feb 20 2023, 5:23 PM · MW-1.40-notes (1.40.0-wmf.24; 2023-02-20), MediaWiki-Watchlist, MediaWiki-Recent-changes, Growth-Team
TK-999 created T330100: RecentChanges and WatchList unnecessarily render the page for RCFilters redirects.
Feb 20 2023, 5:18 PM · MW-1.40-notes (1.40.0-wmf.24; 2023-02-20), MediaWiki-Watchlist, MediaWiki-Recent-changes, Growth-Team

Feb 18 2023

TK-999 added a comment to T325299: LibUp failing on npm ci due to missing or invalid dependencies in the lock file (related to stylelint).

@Umherirrender Thanks, that's very useful context. npm dedupe seems the best approach in this case indeed.

Feb 18 2023, 12:36 PM · LibUp
TK-999 added a comment to T325299: LibUp failing on npm ci due to missing or invalid dependencies in the lock file (related to stylelint).

@Umherirrender One issue that I see is that grunt-stylelint explicitly warns consumers to depend on stylelint as well:

Note that this installs both grunt-stylelint and the stylelint tool itself, which is a peer dependency. If you do not explicitly depend on stylelint in your package.json file and do not have it available, grunt-stylelint will not work. Modern versions of npm will warn you of such unmet peer dependencies.

https://github.com/wikimedia/grunt-stylelint/blob/de0b7b3ffe80acbfab2639984fa79c58d1b6a243/README.md#getting-started

Feb 18 2023, 11:54 AM · LibUp

Feb 12 2023

TK-999 added a comment to T328699: Consider including a JS runtime as part of MediaWiki.

One concern I had when I last thought about this was i18n support. Localization messages can currently be customized locally via MediaWiki:* pages, use a MediaWiki-specific plural/gender rule syntax, and may even support wikitext (if the caller so desires). Language fallbacks and conversion are also something configured and managed in MediaWiki. Outside of the most basic of logic-less templates that can afford taking in prerendered i18n messages as parameters, it seems likely to me that an SSR service would end up needing to render i18n messages dynamically - which opens up a whole new can of worms with regards to supporting the above that'd either require additional crosstalk with MediaWiki or extra service-side logic.

Feb 12 2023, 9:55 PM · MediaWiki-Platform-Team (Radar), Design-System-Team, Front-end Modernization, MediaWiki-ResourceLoader
TK-999 created T329466: Add Phan to Cargo.
Feb 12 2023, 9:32 PM · Patch-For-Review, MediaWiki-extensions-Cargo

Feb 3 2023

TK-999 added a comment to T275710: Deprecate IContextSource::getWikiPage and IContextSource::canUseWikiPage.

WikiPage instances are expensive to instantiate because initializing them always requires a DB query. If IContextSource::getWikiPage calls are to be replaced by instantiations via WikiPageFactory, then every extension that needs access to the WikiPage instance corresponding to the current page will trigger a new, effectively redundant, DB query. I think this cost needs to be considered here.

Feb 3 2023, 9:40 AM · Patch-For-Review, MediaWiki-General, Platform Team Workboards (MW Expedition)

Feb 1 2023

TK-999 added a comment to T328503: Custom content types whose getNativeData() method returns a non-string value can break XML dump generation.

getNativeData was deprecated in 1.33. It's still used in XmlDumpWriter though:

		if ( $content instanceof TextContent ) {
			// HACK: For text based models, bypass the serialization step. This allows extensions (like Flow)
			// that use incompatible combinations of serialization format and content model.
			$data = $content->getNativeData();
		} else {
			$data = $content->serialize( $contentFormat );
		}

It seems to me like this should be fixed in Flow. getNativeData is broken by design, nothing should use it. Import/export should rely on serialize().

Anyway, if you have a Content object that extends TextContent but does not return a string from getNativeData(), this will explode.

Feb 1 2023, 3:18 PM · MW-1.35-notes, MW-1.38-notes, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), MW-1.39-notes, MW-1.39-release, MW-1.38-release, MW-1.35-release, Dumps-Generation, MediaWiki-ContentHandler
TK-999 moved T328529: StaticClosureSniff should support arrow functions from Untriaged to Proposed rule changes on the MediaWiki-Codesniffer board.
Feb 1 2023, 10:32 AM · Patch-For-Review, MediaWiki-Codesniffer
TK-999 created T328529: StaticClosureSniff should support arrow functions.
Feb 1 2023, 10:10 AM · Patch-For-Review, MediaWiki-Codesniffer
TK-999 added a comment to T328503: Custom content types whose getNativeData() method returns a non-string value can break XML dump generation.

As the code is from rMWfdc3e9f9524d: Add support for xml dump schema 0.11, I suspect it's applicable all the way back to 1.34 :)

Feb 1 2023, 12:31 AM · MW-1.35-notes, MW-1.38-notes, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), MW-1.39-notes, MW-1.39-release, MW-1.38-release, MW-1.35-release, Dumps-Generation, MediaWiki-ContentHandler
TK-999 added a comment to T328503: Custom content types whose getNativeData() method returns a non-string value can break XML dump generation.

Are you running with modifications? Line 571 is the strlen() - https://github.com/wikimedia/mediawiki/blame/REL1_37/includes/export/XmlDumpWriter.php#L571

Obviously 1.37 is unsupported, but clearly can still happen on master as the code is basically identical...

Feb 1 2023, 12:24 AM · MW-1.35-notes, MW-1.38-notes, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), MW-1.39-notes, MW-1.39-release, MW-1.38-release, MW-1.35-release, Dumps-Generation, MediaWiki-ContentHandler
TK-999 created T328503: Custom content types whose getNativeData() method returns a non-string value can break XML dump generation.
Feb 1 2023, 12:11 AM · MW-1.35-notes, MW-1.38-notes, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), MW-1.39-notes, MW-1.39-release, MW-1.38-release, MW-1.35-release, Dumps-Generation, MediaWiki-ContentHandler

Jan 27 2023

TK-999 added a comment to T327339: TypeError with compound queries on PHP 8.0.

Yeah, should be fine now!

Jan 27 2023, 10:31 PM · PHP 8.0 support, MediaWiki-extensions-Cargo
TK-999 closed T327339: TypeError with compound queries on PHP 8.0 as Resolved.
Jan 27 2023, 10:31 PM · PHP 8.0 support, MediaWiki-extensions-Cargo
TK-999 created T328174: Special:AllPages does not utilize LinkCache.
Jan 27 2023, 10:24 PM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), MediaWiki-Special-pages

Jan 20 2023

TK-999 added a comment to T327353: PHP 8.2: Creation of dynamic property CargoICalendarFormat::$mParser is deprecated.

Yeah, should be good now! Sorry, I've been meaning to close the task after the changeset was merged but I forgot about it.

Jan 20 2023, 2:25 PM · PHP 8.2 support, MediaWiki-extensions-Cargo

Jan 18 2023

TK-999 created T327353: PHP 8.2: Creation of dynamic property CargoICalendarFormat::$mParser is deprecated.
Jan 18 2023, 10:44 PM · PHP 8.2 support, MediaWiki-extensions-Cargo
TK-999 added a project to T327339: TypeError with compound queries on PHP 8.0: PHP 8.0 support.
Jan 18 2023, 8:55 PM · PHP 8.0 support, MediaWiki-extensions-Cargo
TK-999 created T327339: TypeError with compound queries on PHP 8.0.
Jan 18 2023, 8:32 PM · PHP 8.0 support, MediaWiki-extensions-Cargo

Dec 12 2022

TK-999 added a comment to T324921: Add interface for extension properties to Parser.

Could these extensions use ParserOutput's mechanism already? Not sure whether there's a benefit in using fields on Parser itself here.

Dec 12 2022, 3:04 PM · Content-Transform-Team, Wikimedia-Hackathon-2023, Patch-For-Review, Technical-Debt, PHP 8.2 support, MediaWiki-Parser

Nov 28 2022

TK-999 added a comment to T257703: Clean up Cache-Control handling in MediaWiki.

More broadly, we may need to revisit the practice of eagerly setting up the session itself in Setup.php as well, since that itself may set cookies even if nothing attempts to interact with the session user during the lifetime of the request.

Nov 28 2022, 1:02 PM · Sustainability (Incident Followup), FR-CentralNotice-Caching, MediaWiki-Core-AuthManager
TK-999 added a comment to T257703: Clean up Cache-Control handling in MediaWiki.

In T155314 it was suggested that some kind of mechanism be implemented that would track whether the session user was accessed at all while processing the request. That could be an useful way of determining whether or not the current response depended on user-specific data.

Vary headers always have to be the same for a given URL (otherwise logged-in users would get content cached for anonymous users). At a minimum you'd have to mark the entire API module as not being allowed to ever use the session (like we do for load.php), and then you could still get into all kinds of trouble because of the modular structure of the action API where e.g. the error formatter is a separate module which might check the user language. For the REST API, marking whole endpoints / URL prefixes as not using the session seems a bit more feasible.

Nov 28 2022, 12:28 PM · Sustainability (Incident Followup), FR-CentralNotice-Caching, MediaWiki-Core-AuthManager

Nov 18 2022

TK-999 moved T323373: API: 'section' parameter handling for prop=revisions is broken on PHP 8.0 from Needs Review to Blocked on the MediaWiki-Action-API board.
Nov 18 2022, 5:11 PM · MW-1.38-notes, MW-1.35-notes, Patch-For-Review, MW-1.38-release, MW-1.35-release, MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), PHP 8.0 support, MediaWiki-Action-API
TK-999 moved T323373: API: 'section' parameter handling for prop=revisions is broken on PHP 8.0 from Unsorted to Needs Review on the MediaWiki-Action-API board.
Nov 18 2022, 2:30 PM · MW-1.38-notes, MW-1.35-notes, Patch-For-Review, MW-1.38-release, MW-1.35-release, MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), PHP 8.0 support, MediaWiki-Action-API
TK-999 moved T323373: API: 'section' parameter handling for prop=revisions is broken on PHP 8.0 from Backlog to MediaWiki core on the PHP 8.0 support board.
Nov 18 2022, 2:30 PM · MW-1.38-notes, MW-1.35-notes, Patch-For-Review, MW-1.38-release, MW-1.35-release, MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), PHP 8.0 support, MediaWiki-Action-API
TK-999 created T323373: API: 'section' parameter handling for prop=revisions is broken on PHP 8.0.
Nov 18 2022, 2:02 PM · MW-1.38-notes, MW-1.35-notes, Patch-For-Review, MW-1.38-release, MW-1.35-release, MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.12; 2022-11-28), PHP 8.0 support, MediaWiki-Action-API
TK-999 closed T322335: API: 'rvdiffto' parameter handling is broken on PHP 8.0 as Resolved.
Nov 18 2022, 1:51 PM · MW-1.39-notes, MW-1.40-notes (1.40.0-wmf.10; 2022-11-14), PHP 8.0 support, MediaWiki-Action-API