TK-999 (TK-999)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 7 2017, 10:09 PM (41 w, 1 d)
Availability
Available
LDAP User
TK-999
MediaWiki User
Unknown

Recent Activity

Thu, Nov 16

TK-999 added a comment to T180752: Support customizing base path of Parsoid server.

Yes, after further investigation it seems we can use a proxy just fine. Thanks for your quick comments!

Thu, Nov 16, 11:36 PM · Parsoid
TK-999 added a comment to T180752: Support customizing base path of Parsoid server.

You can run multiple instances of Parsoid on various ports or (better) use a single Parsoid instance for all the various services. Parsoid can be configured with different api prefixes for different servers; in fact that's how WMF runs it in production (each Parsoid instance can handle all the different wmf sites).

Thu, Nov 16, 11:18 PM · Parsoid
TK-999 created T180752: Support customizing base path of Parsoid server.
Thu, Nov 16, 10:57 PM · Parsoid

Thu, Nov 9

TK-999 added a comment to T180157: DatabaseMysqlBase::fieldExists check can trigger full table scan.

Yeah, the actual query indeed stops at the first row. Thanks for clarifying :)

Thu, Nov 9, 8:06 PM · Patch-For-Review, MediaWiki-Database
TK-999 added a comment to T180157: DatabaseMysqlBase::fieldExists check can trigger full table scan.

On a MySQL 5.7 install:

Thu, Nov 9, 7:38 PM · Patch-For-Review, MediaWiki-Database
TK-999 renamed T180157: DatabaseMysqlBase::fieldExists check can trigger full table scan from DatabaseBase::fieldExists check can trigger full table scan to DatabaseMysqlBase::fieldExists check can trigger full table scan.
Thu, Nov 9, 7:22 PM · Patch-For-Review, MediaWiki-Database
TK-999 added a comment to T180157: DatabaseMysqlBase::fieldExists check can trigger full table scan.

Yeah, that's my bad - but the query is still there via DatabaseMysqlBase.

Thu, Nov 9, 7:22 PM · Patch-For-Review, MediaWiki-Database
TK-999 added a comment to T180157: DatabaseMysqlBase::fieldExists check can trigger full table scan.

A potential alternative would be to use a DESCRIBE query here, kind of like this.

Thu, Nov 9, 7:20 PM · Patch-For-Review, MediaWiki-Database
TK-999 created T180157: DatabaseMysqlBase::fieldExists check can trigger full table scan.
Thu, Nov 9, 7:19 PM · Patch-For-Review, MediaWiki-Database

Sep 4 2017

TK-999 updated subscribers of T174908: Special:BrowseData causes error on MySQL 5.7 slave.
Sep 4 2017, 12:15 PM · Patch-For-Review, MediaWiki-extensions-SemanticDrilldown
TK-999 created T174908: Special:BrowseData causes error on MySQL 5.7 slave.
Sep 4 2017, 10:24 AM · Patch-For-Review, MediaWiki-extensions-SemanticDrilldown

May 23 2017

Qgil awarded T165981: Implement a prototype JavaScript review system for MediaWiki a Cookie token.
May 23 2017, 12:42 PM · Developer-Relations, Community-Liaisons, MediaWiki-extension-requests, Security-General, JavaScript, Wikimedia-Hackathon-2017

May 22 2017

TK-999 added a comment to T71445: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites.

Based on my work around T165981 during the 2017 Hackathon - which essentially involved creating a prototype implementation of Wikia's ContentReview extension compatible with core MediaWiki - I would like to note the following:

May 22 2017, 1:11 AM · User-Tgr, Developer-Wishlist (2017), Developer-Relations, Gadgets, Security-General, JavaScript, Wikimedia-General-or-Unknown

May 21 2017

TK-999 added a comment to T165981: Implement a prototype JavaScript review system for MediaWiki.

A few notes on how we can progress from here:

May 21 2017, 5:07 PM · Developer-Relations, Community-Liaisons, MediaWiki-extension-requests, Security-General, JavaScript, Wikimedia-Hackathon-2017
TK-999 added a comment to T165981: Implement a prototype JavaScript review system for MediaWiki.

Demo produced during hackathon is at https://github.com/TK-999/mediawiki-extensions-ContentReview

May 21 2017, 1:59 PM · Developer-Relations, Community-Liaisons, MediaWiki-extension-requests, Security-General, JavaScript, Wikimedia-Hackathon-2017
TK-999 added a comment to T162634: If you block an IP address as anonymous only, and then change it to a hardblock or vise versa, it is recorded as a completely new block.

Looks like this is the same issue that was reported in T157508

May 21 2017, 1:23 PM · MediaWiki-User-management
TK-999 created T165981: Implement a prototype JavaScript review system for MediaWiki.
May 21 2017, 12:00 PM · Developer-Relations, Community-Liaisons, MediaWiki-extension-requests, Security-General, JavaScript, Wikimedia-Hackathon-2017

Feb 16 2017

TK-999 edited projects for T157718: Skip User edit count computation in Autopromote if APCOND_EDITCOUNT isn't used, added: MediaWiki-Authentication-and-authorization; removed MediaWiki-General-or-Unknown.
Feb 16 2017, 12:03 AM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Performance, MediaWiki-Authentication-and-authorization

Feb 15 2017

TK-999 added a comment to T157718: Skip User edit count computation in Autopromote if APCOND_EDITCOUNT isn't used.

I've attached a patch which adds a simple check to return early if condition is 0 or invalid, with an associated unit test.

Feb 15 2017, 11:04 AM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Performance, MediaWiki-Authentication-and-authorization

Feb 9 2017

TK-999 created T157718: Skip User edit count computation in Autopromote if APCOND_EDITCOUNT isn't used.
Feb 9 2017, 7:34 PM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Performance, MediaWiki-Authentication-and-authorization

Feb 7 2017

TK-999 updated the task description for T157508: Issuing an anon-only block, then changing anon-only setting causes incorrect block settings to be applied for anon user.
Feb 7 2017, 10:52 PM · MediaWiki-User-management
TK-999 added a comment to T157508: Issuing an anon-only block, then changing anon-only setting causes incorrect block settings to be applied for anon user.

It seems when software performs block check via User::isBlocked etc., Block::newLoad tries to find the best matching block based on type, and because of https://github.com/wikimedia/mediawiki/blob/master/includes/Block.php#L332 the first match of Block::TYPE_IP (the older block) will always be preferred for anons.

Feb 7 2017, 10:51 PM · MediaWiki-User-management
TK-999 updated the task description for T157508: Issuing an anon-only block, then changing anon-only setting causes incorrect block settings to be applied for anon user.
Feb 7 2017, 10:47 PM · MediaWiki-User-management
TK-999 updated the task description for T157508: Issuing an anon-only block, then changing anon-only setting causes incorrect block settings to be applied for anon user.
Feb 7 2017, 10:47 PM · MediaWiki-User-management
TK-999 created T157508: Issuing an anon-only block, then changing anon-only setting causes incorrect block settings to be applied for anon user.
Feb 7 2017, 10:46 PM · MediaWiki-User-management