May 19 2018
I believe this will be especially necessary given the data portability clauses of the GDPR. We must provide users with a way to export their own goats.
Apr 28 2018
Probably the character 2062 (INVISIBLE TIMES) should be added to the list. For example, https://community.wikia.com/wiki/Special:Contributions/Low_Spark_of_Lyman%E2%81%A2%E2%81%A2 has this character appended to this user name, but it's visually indistinguishable from https://community.wikia.com/wiki/Special:Contributions/Low_Spark_of_Lyman .
Apr 26 2018
FYI, PHP 7.2 compatibility issues are fixed in version 1.10.2 of the PEAR Mail_Mime library.
Mar 20 2018
I think that's MySQL specific and won't work on other supported RDBMSes. AFAIK Postgres for instance has designated data types like cidr instead of this helper.
I was thinking that it might help with this task, if we separated concerns between the ipblocks.ipb_user and ipblocks.ipb_address fields:
Thank you very much for the quick review @Anomie 🙂 I have amended the patch set according to your notes.
Mar 19 2018
What collation would MediaWiki use for the utf8mb4character set? I assume it'd have to be the binary collation utf8mb4_bin, but it'd be good to clarify this. Sadly case- and accent-sensitive collations for Unicode character sets will only be available with MySQL 8.0 😞
Mar 16 2018
Mar 14 2018
Yeah, the only reason created this separate ticket since it represents an improvement that can be done within the bounds of the existing interwiki transclusion system without requiring an extensive overhaul or migration process.
I'll gladly work on this if it is deemed to be acceptable.
Ohh, that is true, I'll have to rethink it. Still, it might make sense to consider a different schema in the long run to avoid the previously described issues...
Since the schema of change_tags table is due to be adjusted, what do you think of tweaking it to avoid the current situation with 3 UNIQUE indexes and nullable columns? I was thinking of something along the lines of:
Nov 29 2017
Nov 16 2017
Yes, after further investigation it seems we can use a proxy just fine. Thanks for your quick comments! This ticket can be closed then
Nov 9 2017
Yeah, the actual query indeed stops at the first row. Thanks for clarifying :)
On a MySQL 5.7 install:
Yeah, that's my bad - but the query is still there via DatabaseMysqlBase.
A potential alternative would be to use a DESCRIBE query here, kind of like this.
Sep 4 2017
May 23 2017
May 22 2017
Based on my work around T165981 during the 2017 Hackathon - which essentially involved creating a prototype implementation of Wikia's ContentReview extension compatible with core MediaWiki - I would like to note the following:
May 21 2017
A few notes on how we can progress from here:
Demo produced during hackathon is at https://github.com/TK-999/mediawiki-extensions-ContentReview
Looks like this is the same issue that was reported in T157508
Feb 16 2017
Feb 15 2017
I've attached a patch which adds a simple check to return early if condition is 0 or invalid, with an associated unit test.
Feb 9 2017
Feb 7 2017
It seems when software performs block check via User::isBlocked etc., Block::newLoad tries to find the best matching block based on type, and because of https://github.com/wikimedia/mediawiki/blob/master/includes/Block.php#L332 the first match of Block::TYPE_IP (the older block) will always be preferred for anons.