Page MenuHomePhabricator

TK-999 (Máté Szabó)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 7 2017, 10:09 PM (193 w, 6 d)
Availability
Available
LDAP User
TK-999
MediaWiki User
Unknown

Recent Activity

Wed, Oct 14

TK-999 closed T259719: UserEditTracker attempts to initialize edit count in read only mode as Resolved.
Wed, Oct 14, 12:50 AM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Platform Team Workboards (External Code Reviews), MediaWiki-User-management
TK-999 added a comment to T259719: UserEditTracker attempts to initialize edit count in read only mode.

Looks like it's been on WMF production without issues, so I'll close this. Thanks!

Wed, Oct 14, 12:50 AM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Platform Team Workboards (External Code Reviews), MediaWiki-User-management

Mon, Oct 5

TK-999 added a comment to T264536: MediaWiki 1.31 throws PHP Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/mw-sqlite/includes/profiler/SectionProfiler.php:99) in /var/www/html/mw-sqlite/includes/WebResponse.php on line 74.

MediaWiki 1.31 doesn't support PHP 7.4, IIRC. This warning was fixed in rMW278227608808c25242c87a7092da5fb9adc50cde.

Mon, Oct 5, 12:43 AM · Performance-Team (Radar), MW-1.31-release, MediaWiki-Core-Profiler

Sep 22 2020

TK-999 added a comment to T263545: Decide on logging in k8s for ShellBox.

This also relies on FPM's catch_workers_output and decorate_workers_output options to redirect workers' stdout and stderr into the main error log FPM is configured to use, without messing up the formatting of the messages logged by applayer. However, the latter param is only available from PHP 7.3 onwards.

Sep 22 2020, 3:37 PM · MW-on-K8s, serviceops, Operations
TK-999 added a comment to T263545: Decide on logging in k8s for ShellBox.

The "official" PHP docker images use the same method for FPM (output redirection) to get worker logs into stdout so they can be ingested: https://github.com/docker-library/php/blob/d6838d8e45f6356d867dbc8ff8b3513492cba500/7.3/buster/fpm/Dockerfile#L230

Sep 22 2020, 3:32 PM · MW-on-K8s, serviceops, Operations

Sep 1 2020

TK-999 added a watcher for MW-on-K8s: TK-999.
Sep 1 2020, 3:46 PM

Aug 25 2020

TK-999 closed T260997: Linker::getRollbackEditCount queries are forced into a suboptimal execution plan due to index forcing as Resolved.
Aug 25 2020, 8:41 PM · MediaWiki-Recent-changes, Performance Issue
TK-999 added a comment to T260997: Linker::getRollbackEditCount queries are forced into a suboptimal execution plan due to index forcing.

@TK-999 I'm very interested in the Percona aspect of this. Have you tried my Percona driver ??

I doubt it would solve this problem, but I'm curious about how you're approaching the different index handling.

Aug 25 2020, 8:40 PM · MediaWiki-Recent-changes, Performance Issue

Aug 21 2020

TK-999 added a comment to T260997: Linker::getRollbackEditCount queries are forced into a suboptimal execution plan due to index forcing.

Interestingly, https://www.mediawiki.org/wiki/Manual:$wgShowRollbackEditCount suggests that $wgMiserMode can be used to disable this counting of edits for rollback links rendering, but the code seems to perform the calculation anyways (in \Linker::generateRollback).

Aug 21 2020, 4:25 PM · MediaWiki-Recent-changes, Performance Issue
TK-999 added a comment to T260997: Linker::getRollbackEditCount queries are forced into a suboptimal execution plan due to index forcing.

The query also performs well with the index forcing if I get rid of the JOINs on the comment tables, since they are never actually used by this query.

Aug 21 2020, 2:39 PM · MediaWiki-Recent-changes, Performance Issue
TK-999 edited projects for T260997: Linker::getRollbackEditCount queries are forced into a suboptimal execution plan due to index forcing, added: Platform Engineering; removed Growth-Team.

Tagging Platform as potential stakeholders and @hoo as the original author of the query :)

Aug 21 2020, 2:36 PM · MediaWiki-Recent-changes, Performance Issue
TK-999 added a comment to T260997: Linker::getRollbackEditCount queries are forced into a suboptimal execution plan due to index forcing.

Looking at the latest source code, it seems the index forcing is still present there as well. It may be worth to consider removing it if we can verify it doesn't hurt the performance on MariaDB.

Aug 21 2020, 2:34 PM · MediaWiki-Recent-changes, Performance Issue
TK-999 created T260997: Linker::getRollbackEditCount queries are forced into a suboptimal execution plan due to index forcing.
Aug 21 2020, 2:32 PM · MediaWiki-Recent-changes, Performance Issue

Aug 18 2020

TK-999 added a comment to T199323: Checkuser does not truncate data (cuc_comment, cuc_agent, cuc_actiontext) and that causes exceptions with strict mode.

Yup, should be all good!

Aug 18 2020, 9:10 AM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), affects-translatewiki.net, CheckUser

Aug 12 2020

TK-999 added a comment to T248756: RevisionStore::getRevisionByTitle can fail for foreign wikis when called with TitleValue.

This should be resolved now, thanks!

Aug 12 2020, 9:57 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), MediaWiki-Revision-backend
TK-999 closed T248756: RevisionStore::getRevisionByTitle can fail for foreign wikis when called with TitleValue as Resolved.
Aug 12 2020, 9:57 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), MediaWiki-Revision-backend

Aug 5 2020

TK-999 added a comment to T249673: RFC: A modern and restrictive (but flexible!) skin system using Mustache.

One point is not immediately clear for me: Does this proposal aim to remove the option of writing PHP-based skins altogether, or does it preserve the option of using PHP to implement a skin if need be?

Aug 5 2020, 11:25 PM · Patch-For-Review, MediaWiki-Core-Skin-Architecture, User-Jdlrobson, TechCom-RFC
TK-999 created T259719: UserEditTracker attempts to initialize edit count in read only mode.
Aug 5 2020, 4:00 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Platform Team Workboards (External Code Reviews), MediaWiki-User-management

Aug 1 2020

TK-999 added a comment to T259362: Permit temporary table operations to be executed on replica connections.

Thanks for the review! :)

Aug 1 2020, 3:01 PM · MW-1.35-notes, Patch-For-Review, Performance-Team, Platform Team Workboards (External Code Reviews), Wikimedia-Rdbms
Krinkle awarded T259362: Permit temporary table operations to be executed on replica connections a Orange Medal token.
Aug 1 2020, 3:00 AM · MW-1.35-notes, Patch-For-Review, Performance-Team, Platform Team Workboards (External Code Reviews), Wikimedia-Rdbms

Jul 31 2020

TK-999 added a comment to T259362: Permit temporary table operations to be executed on replica connections.

Tagging Daniel, Aaron, Roan and Adam on this ticket for visibility as contributors to T183265 and T183242.

Jul 31 2020, 3:46 PM · MW-1.35-notes, Patch-For-Review, Performance-Team, Platform Team Workboards (External Code Reviews), Wikimedia-Rdbms
TK-999 created T259362: Permit temporary table operations to be executed on replica connections.
Jul 31 2020, 3:45 PM · MW-1.35-notes, Patch-For-Review, Performance-Team, Platform Team Workboards (External Code Reviews), Wikimedia-Rdbms
TK-999 added a comment to T222224: RFC: Normalize MediaWiki link tables.

@TK-999 Hi, I wonder if Fandom have perhaps done something in this area?

Jul 31 2020, 3:25 PM · DBA, Platform Engineering, MediaWiki-Page-derived-data, Schema-change, Patch-For-Review, TechCom-RFC

Jun 12 2020

TK-999 added a comment to T199323: Checkuser does not truncate data (cuc_comment, cuc_agent, cuc_actiontext) and that causes exceptions with strict mode.

@Paladox No worries. I will create a fresh patchset on top of master with all relevant changes restored.

Jun 12 2020, 4:02 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), affects-translatewiki.net, CheckUser
TK-999 added a comment to T199323: Checkuser does not truncate data (cuc_comment, cuc_agent, cuc_actiontext) and that causes exceptions with strict mode.

@Paladox I noticed that truncation logic was removed from the above patch (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/598196/6..7) for several code paths, such as account creation logging. Can you clarify why this was done?

Jun 12 2020, 2:18 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), affects-translatewiki.net, CheckUser

Jun 9 2020

TK-999 added a comment to T157508: Issuing an anon-only block, then changing anon-only setting causes incorrect block settings to be applied for anon user.

T251188 should fix this issue.

Jun 9 2020, 12:02 PM · MediaWiki-Blocks
TK-999 closed T157508: Issuing an anon-only block, then changing anon-only setting causes incorrect block settings to be applied for anon user as Resolved.
Jun 9 2020, 12:01 PM · MediaWiki-Blocks
TK-999 added a comment to T251188: ipb_address_unique has an extra column in production but not in the code.

This will probably address T157508 as well.

Jun 9 2020, 2:18 AM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Anti-Harassment (The Letter Song), Blocked-on-schema-change, DBA

May 23 2020

TK-999 added a comment to T236880: Document when to use different ILoadBalancer::get*Connection* methods.

I think there are some additional nuances to consider here:

  • getConnectionRef() should be the default for all foreign wiki DB connections because the caller must call ILoadBalancer::reuseConnection() for those when they're finished with the connection, so using getConnectionRef() can be a saner way of managing this unless the caller explicitly wants to control the lifecycle of the foreign DB connections it opens.
  • @aaron seems to be working on some improvements to DB connection pooling in https://gerrit.wikimedia.org/r/q/I540b08920997c5 for T226595, which, when complete, would probably mean that all callers should prefer getConnectionRef() for both local and foreign connections.
May 23 2020, 9:48 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Platform Engineering (Icebox), Performance-Team, Documentation, Wikimedia-Rdbms, MediaWiki-Documentation

May 14 2020

TK-999 added a comment to T252798: How should hook implementations access the current request context?.

Historically, it seems that hooks were updated to pass the request context to the handlers when needed, for instance in rMW1051f68e7d438d20df44fd9386a0a451e77fbb8e. Given that request context is not suitable for injection as per T218555, this strikes me as probably the most suitable approach.

May 14 2020, 6:03 PM · Platform Team Initiatives (New Hook System), Anti-Harassment, TechCom

May 5 2020

TK-999 added a comment to T146571: Add a primary key to querycache table.

If it's not feasible to weed out duplicates, possibly even a (qc_type,qc_value,qc_namespace,qc_title) PK could be an improvement. For MySQL at least, it'd avoid bug 76252, and reduce overall storage space usage when using InnoDB.[1]

May 5 2020, 12:56 AM · Schema-change, MediaWiki-Special-pages, Patch-For-Review

Apr 29 2020

TK-999 added a comment to T247990: Tests leak memory under PHP 7.4 and 8.

Is there much we can do about this one? Other than waitng for an upstream fix, and a possible backport/similar?

I've tried adjusting MediaWikiIntegrationTestCase::installMockMwServices to clone the default service container, as opposed to populating a new instance from wiring files, when not given any config overrides.

That seems risky. I'd rather find a way to cache the wiring array itself, so we don't re-create all these closures for every test.

Apr 29 2020, 11:42 AM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Workboards (External Code Reviews), Patch-For-Review, Upstream, PHP 7.4 support, PHP 8.0 support, MediaWiki-Core-Testing

Apr 28 2020

TK-999 added a comment to T248061: RFC: Remove IE 8 from basic support.

Thanks for reaching out! I've confirmed that IE 8 has no support status on either of our wiki products so there are no objections from our side.

Apr 28 2020, 1:42 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), MW-1.36-release, TechCom-RFC (TechCom-RFC-Closed), Tech-Ambassadors, User-notice, MediaWiki-General, Browser-Support-Internet-Explorer, Front-end-Standards-Group

Apr 25 2020

TK-999 added a comment to T247990: Tests leak memory under PHP 7.4 and 8.

Is there much we can do about this one? Other than waitng for an upstream fix, and a possible backport/similar?

Apr 25 2020, 8:57 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Workboards (External Code Reviews), Patch-For-Review, Upstream, PHP 7.4 support, PHP 8.0 support, MediaWiki-Core-Testing

Apr 4 2020

TK-999 added a comment to T247990: Tests leak memory under PHP 7.4 and 8.

I tried to debug this a bit today, and would like to post the results here in case it may be useful to somebody with better PHP internals knowledge than me (and that's a very low bar!)

Apr 4 2020, 10:45 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Workboards (External Code Reviews), Patch-For-Review, Upstream, PHP 7.4 support, PHP 8.0 support, MediaWiki-Core-Testing
TK-999 added a comment to T247990: Tests leak memory under PHP 7.4 and 8.

https://github.com/php/php-src/commit/0f2cdbf214efd98b4bdaf5ca41728faf00e7c037 looks to be a likely culprit (introduced as a fix for PHP bug 78903). Specifically the monotonically increasing rtd_counter appears to mean that each time a file containing a closure is included, a new entry will be generated in the function table for the closure. After some quick & dirty testing locally, removing the counter seems to stabilize memory usage.

Apr 4 2020, 1:39 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Workboards (External Code Reviews), Patch-For-Review, Upstream, PHP 7.4 support, PHP 8.0 support, MediaWiki-Core-Testing

Apr 3 2020

TK-999 added a comment to T247990: Tests leak memory under PHP 7.4 and 8.

@MaxSem I wonder if this is somehow related to https://bugs.php.net/bug.php?id=76982. Granted, that one seems to have been present on PHP 7.x as well, but perhaps PHP 8 exacerbated the issue.

Apr 3 2020, 11:27 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Workboards (External Code Reviews), Patch-For-Review, Upstream, PHP 7.4 support, PHP 8.0 support, MediaWiki-Core-Testing

Mar 28 2020

TK-999 added a comment to T248756: RevisionStore::getRevisionByTitle can fail for foreign wikis when called with TitleValue.

This looks to be caused by rMWaed6be4, which changed RevisionStore::getRevisionByTitle to convert the passed LinkTarget to a Title using Title::newFromLinkTarget, to resolve T206498. Unfortunately, this breaks when the given RevisionStore is operating in the context of a foreign wiki. In this scenario, when RevisionStoreRecord::__construct calls Title::getArticleID on the Title instance to perform a sanity check of the page ID against the page ID reference stored in the revision table for the given revision record, then Title::getArticleID will lazily fetch the page ID on the local, rather than the foreign wiki. This results in the aforementioned InvalidArgumentException being thrown.

Mar 28 2020, 7:24 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), MediaWiki-Revision-backend
TK-999 created T248756: RevisionStore::getRevisionByTitle can fail for foreign wikis when called with TitleValue.
Mar 28 2020, 7:14 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), MediaWiki-Revision-backend

Mar 24 2020

TK-999 added a comment to T248333: Schema change: Make page.page_restrictions column NULL.

It is looking good, thank you!

Mar 24 2020, 11:39 AM · Blocked-on-schema-change, DBA

Mar 23 2020

TK-999 added a subtask for T218446: Remove use of legacy page.page_restrictions field: T248333: Schema change: Make page.page_restrictions column NULL.
Mar 23 2020, 5:54 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), Schema-change, MediaWiki-General, Technical-Debt (Deprecation process)
TK-999 added a parent task for T248333: Schema change: Make page.page_restrictions column NULL: T218446: Remove use of legacy page.page_restrictions field.
Mar 23 2020, 5:54 PM · Blocked-on-schema-change, DBA
TK-999 created T248333: Schema change: Make page.page_restrictions column NULL.
Mar 23 2020, 5:53 PM · Blocked-on-schema-change, DBA

Mar 21 2020

TK-999 added a comment to T223099: Factor code for handling for options (preferences) out of User class.

@DannyS712 Thanks for reaching out :) Unfortunately this tasks seems to have stalled and I couldn't find the time to get back to it. I am not sure about next steps.

Mar 21 2020, 12:03 AM · Patch-For-Review, Platform Team Initiatives (Decoupling (CDP2)), Platform Team Workboards (S&F Workboard), Wikimedia-Hackathon-2019, MediaWiki-User-management, MediaWiki-User-preferences

Mar 18 2020

TK-999 placed T165981: Implement a prototype JavaScript review system for MediaWiki up for grabs.
Mar 18 2020, 5:43 PM · Security, Developer-Advocacy, MediaWiki-extension-requests, JavaScript, Wikimedia-Hackathon-2017

Mar 6 2020

Nemo_bis awarded T245582: Show "you are creating a new article" notification only once per session a Doubloon token.
Mar 6 2020, 3:53 PM · VisualEditor, VisualEditor-MediaWiki

Feb 19 2020

TK-999 added a comment to T245582: Show "you are creating a new article" notification only once per session.

If this is OK to implement, this could potentially be as simple as setting a cookie/session data in ApiVisualEditor when first showing the newarticletext notice to a registered user, and checking this data on subsequent calls so as not to show the notice again.

Feb 19 2020, 1:28 AM · VisualEditor, VisualEditor-MediaWiki
TK-999 created T245582: Show "you are creating a new article" notification only once per session.
Feb 19 2020, 1:26 AM · VisualEditor, VisualEditor-MediaWiki

Feb 13 2020

TK-999 awarded Blog Post: Parsoid in PHP, or There and Back Again a Love token.
Feb 13 2020, 2:06 AM · Parsoid

Feb 7 2020

TK-999 added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

Developing a new component library in any framework will need to be done in a way that aligns with Wikimedia’s existing design system. Integrating any new tools we adopt into this system is a precondition to production usage and should commence as soon as possible.

Feb 7 2020, 10:47 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team

Jan 31 2020

TK-999 added a comment to T238716: HTML for newly-created pages with VE on testwiki not stored in RESTBase.

@mobrovac I was able to reproduce this issue on mediawiki.org as well (screenshot attached).


It seems that when creating the page, VE first tries to request the page HTML from RESTBase, using the /page/html/{title} endpoint. Since the page doesn't exist, RESTBase will return a 404 cached for 5 minutes (cache-control: s-maxage=600).

Jan 31 2020, 5:05 PM · Platform Engineering (Icebox), RESTBase, VisualEditor

Jan 29 2020

TK-999 moved T228453: Fix the data-values/value-view repo to work on node10 from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Jan 29 2020, 9:48 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), ValueView, Continuous-Integration-Config, Release-Engineering-Team (CI & Testing services), Wikidata, JavaScript
TK-999 awarded T243051: A query builder for MediaWiki core a Party Time token.
Jan 29 2020, 3:37 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikimedia-Rdbms, Platform Team Workboards (Clinic Duty Team)

Jan 28 2020

TK-999 added a comment to T243868: VisualEditor ignores autogenerated parameter info for templates without TemplateData.

I think this is an un-intended side-effect of rEVED8fd621a. We could change the check on line 337 to only ignore the response if no param docs were returned.

Jan 28 2020, 11:10 PM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), VisualEditor, MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), TemplateData, VisualEditor-MediaWiki
TK-999 created T243868: VisualEditor ignores autogenerated parameter info for templates without TemplateData.
Jan 28 2020, 11:08 PM · User-Ryasmeen, Editing-team (FY2020-21 Kanban Board), VisualEditor, MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), TemplateData, VisualEditor-MediaWiki
TK-999 added a comment to T153256: Unable to overwrite services using MediaWikiServices hook.

Thanks for the review!

To what extent can invalid/early instantiation be avoided?

Jan 28 2020, 8:22 PM · Platform Engineering, Patch-For-Review, MediaWiki-ServiceContainer, User-Daniel, User-Nikerabbit

Jan 25 2020

TK-999 added a comment to T243606: Inserting a table breaks CodeMirror highlighting in NWE.

Looks like the source of this bug is the code changed here: https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/458490/8/src/dm/ve.dm.SourceConverter.js#82

The bug happens when we try to convert VisualEditor's data like "{type: 'paragraph'}|+ Caption {type: '/paragraph'}" to plain text expected by CodeMirror, and the result is just "|+ Caption" instead of "|+ Caption \n".

I think we just need to undo that, or in other words, add a newline at the end when converting full paragraphs.

Jan 25 2020, 3:53 PM · Editing-team (FY2020-21 Kanban Board), VisualEditor, Community-Tech, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror

Jan 24 2020

TK-999 added a comment to T243606: Inserting a table breaks CodeMirror highlighting in NWE.

I've tried to debug this a bit. It seems that the generated table caption is inserted in a separate paragraph after the table opening onto the VE surface, but on the CodeMirror surface, it is displayed on the same line as the table opening. Not yet sure why this happens.

Jan 24 2020, 4:20 PM · Editing-team (FY2020-21 Kanban Board), VisualEditor, Community-Tech, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
TK-999 created T243606: Inserting a table breaks CodeMirror highlighting in NWE.
Jan 24 2020, 4:00 PM · Editing-team (FY2020-21 Kanban Board), VisualEditor, Community-Tech, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror

Dec 15 2019

TK-999 committed rEAFY87f849bf35eb: SUS-857: Add rights descriptions for extension-specific user rights (authored by TyA).
SUS-857: Add rights descriptions for extension-specific user rights
Dec 15 2019, 12:19 AM

Dec 11 2019

TK-999 awarded T240307: Hook container with strong types and DI a Yellow Medal token.
Dec 11 2019, 6:08 PM · Platform Team Workboards (Epics), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), MW-1.33-notes, MW-1.31-release-notes, MW-1.34-notes, Platform Team Initiatives (New Hook System), MediaWiki-Core-Hooks, Dependency injection, TechCom-RFC (TechCom-RFC-Closed), User-Daniel, Platform Engineering

Nov 22 2019

TK-999 closed T238273: unconference: Presentation about Wikia/Fandom's solution to MW configuration management at scale as Resolved.
Nov 22 2019, 12:14 AM · Wikimedia-Technical-Conference-2019

Nov 14 2019

TK-999 added a comment to T238255: Unconference: How can we automate new wiki creation.

Suggestion from @akosiaris : T238273 ;)

Nov 14 2019, 10:39 PM · Wikimedia-Technical-Conference-2019
TK-999 added a comment to T238273: unconference: Presentation about Wikia/Fandom's solution to MW configuration management at scale.

Slides: https://docs.google.com/presentation/d/1sYvRVGUsK8bdX_olL2m8A2HUVeC3gvMQkVrbvP1z9gQ/edit?usp=sharing

Nov 14 2019, 10:26 PM · Wikimedia-Technical-Conference-2019

Nov 13 2019

TK-999 moved T238273: unconference: Presentation about Wikia/Fandom's solution to MW configuration management at scale from Backlog to Ideas for unconference on the Wikimedia-Technical-Conference-2019 board.
Nov 13 2019, 10:37 PM · Wikimedia-Technical-Conference-2019
TK-999 created T238273: unconference: Presentation about Wikia/Fandom's solution to MW configuration management at scale.
Nov 13 2019, 10:36 PM · Wikimedia-Technical-Conference-2019

Nov 5 2019

VIGNERON awarded T212881: addWiki.php broken creating ES tables a Like token.
Nov 5 2019, 10:20 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance

Nov 4 2019

TK-999 added a comment to T181658: Numeric page titles can cause query page reports to stop updating.

@Reedy Makes sense, who would be the person to ask for approval? :)

Nov 4 2019, 1:33 PM · MW-1.32-notes, MW-1.33-notes, MW-1.34-notes, MW-1.31-release-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikimedia-database-error, MediaWiki-Special-pages, Patch-For-Review

Oct 31 2019

TK-999 added a comment to T181658: Numeric page titles can cause query page reports to stop updating.

I've rebased the existing patchset, sorry about the undue delay incurred.

Oct 31 2019, 12:22 PM · MW-1.32-notes, MW-1.33-notes, MW-1.34-notes, MW-1.31-release-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikimedia-database-error, MediaWiki-Special-pages, Patch-For-Review
TK-999 added a comment to T181658: Numeric page titles can cause query page reports to stop updating.

Still an issue with 1.33

Oct 31 2019, 11:10 AM · MW-1.32-notes, MW-1.33-notes, MW-1.34-notes, MW-1.31-release-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikimedia-database-error, MediaWiki-Special-pages, Patch-For-Review

Oct 29 2019

TK-999 added a comment to T236810: Make private methods of Parser.php actually private.

@cscott I was wondering if there is a preferred migration path away from Parser::replaceLinkHolders for code that relied on it. I see that the mLinkHolders field in Parser is public, but I imagine that won't stay that way either, right? Thanks in advance!

Oct 29 2019, 7:02 PM · Technical-Debt, Parsing-Active-Work, Parsoid, MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Platform Team Workboards (Clinic Duty Team), MediaWiki-Parser

Oct 24 2019

TK-999 created T236374: ExternalStoreDB fails to connect for foreign wikis when custom external storage database names are used.
Oct 24 2019, 12:19 PM · MediaWiki-Revision-backend

Oct 16 2019

TK-999 added a comment to T235188: Preemptive refresh in getMultiWithSetCallback() and getMultiWithUnionSetCallback() pollutes cache.

Interesting, I've seen a similar caching issue where revision content got mixed up on a 1.33 wiki with $wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_NEW;. I haven't yet been able to consistently reproduce it, though.

Huh... I'd love to know more about this. Was that with external storage enabled, or without? What was the caching config?

Oct 16 2019, 11:05 PM · MediaWiki-Cache, MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), serviceops, Platform Team Workboards (Clinic Duty Team), User-ArielGlenn, Patch-For-Review, affects-translatewiki.net
TK-999 added a comment to T234091: Theme: People and Processes.

How to share the burden of technical debt (e.g. how to make the implementation of accepted RfCs like dependency injection or extension registration not take the better part of a decade) would also be a useful topic. (Maybe that falls under platform stewardship?)

Oct 16 2019, 9:34 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019

Oct 12 2019

TK-999 added a comment to T234634: Wikimedia Technical Conference 2019 Session: On-wiki documentation & documentation as code: strengths, weaknesses, and compromises.

@josephine_l Thank you for the offer! However, being a first-time attendee, I'm afraid I am not sure what this would entail and how I should prepare for the task.

Oct 12 2019, 10:40 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
TK-999 added a comment to T234646: Wikimedia Technical Conference 2019 Session: Self-service Stateless Microservices (for APIs).

Something to consider would be using a monorepo for hosting such services. This setup can bring some benefits (less administrative overhead as provisioning a new service wouldn't require creating a new repository/package, easier code and dependency sharing between services, the ability to share CI/CD configuration for all services).

Oct 12 2019, 3:44 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019

Oct 11 2019

TK-999 added a comment to T234634: Wikimedia Technical Conference 2019 Session: On-wiki documentation & documentation as code: strengths, weaknesses, and compromises.

Something I was thinking about is whether storing developer documentation in an open wiki format on mediawiki.org may be a double edged sword. While this setup allows anyone to edit and improve the documentation, it's not always clear exactly how the documentation should be changed and who should approve changes, if anybody. Storing documentation in a VCS repo, perhaps next to source code even, could be an interesting alternative to consider, as it might allow for an easier review and contribution process. The session could also look at some other open source projects to see how they store and curate documentation.

Oct 11 2019, 5:10 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
TK-999 added a comment to T235188: Preemptive refresh in getMultiWithSetCallback() and getMultiWithUnionSetCallback() pollutes cache.

Interesting, I've seen a similar caching issue where revision content got mixed up on a 1.33 wiki with $wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_NEW;. I haven't yet been able to consistently reproduce it, though.

Huh... I'd love to know more about this. Was that with external storage enabled, or without? What was the caching config?

Oct 11 2019, 12:57 AM · MediaWiki-Cache, MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), serviceops, Platform Team Workboards (Clinic Duty Team), User-ArielGlenn, Patch-For-Review, affects-translatewiki.net

Oct 10 2019

TK-999 added a comment to T235188: Preemptive refresh in getMultiWithSetCallback() and getMultiWithUnionSetCallback() pollutes cache.

Interesting, I've seen a similar caching issue where revision content got mixed up on a 1.33 wiki with $wgMultiContentRevisionSchemaMigrationStage = SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_NEW;. I haven't yet been able to consistently reproduce it, though.

Oct 10 2019, 10:44 PM · MediaWiki-Cache, MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), serviceops, Platform Team Workboards (Clinic Duty Team), User-ArielGlenn, Patch-For-Review, affects-translatewiki.net

Oct 7 2019

TK-999 added a comment to T234632: Wikimedia Technical Conference 2019 Session: Local development environment - MediaWiki core.

As more and more services and technologies enter the orbit of MediaWiki (at least MediaWiki as deployed by Wikimedia), I'm wondering if it is still feasible to try to create and maintain an environment on developers' computers for

Oct 7 2019, 4:18 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
TK-999 awarded T234654: Wikimedia Technical Conference 2019 Session: Componentization and sharing with the open source community a Love token.
Oct 7 2019, 9:12 AM · International-Developer-Events, Wikimedia-Technical-Conference-2019

Oct 5 2019

TK-999 awarded T234655: Wikimedia Technical Conference 2019 Session: Mediawiki Code Ownership a Love token.
Oct 5 2019, 3:01 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
TK-999 awarded T234662: Wikimedia Technical Conference 2019 Session: Integrating contributions from other teams or volunteers a Love token.
Oct 5 2019, 2:55 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
TK-999 awarded T234651: Wikimedia Technical Conference 2019 Session: 3rd Party MediaWiki development and support a Love token.
Oct 5 2019, 2:54 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
TK-999 awarded T234633: Wikimedia Technical Conference 2019 Unconference: Reducing barriers to entry for new developers a Love token.
Oct 5 2019, 2:54 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019

Oct 4 2019

TK-999 added a watcher for Wikimedia-Technical-Conference-2019: TK-999.
Oct 4 2019, 10:13 PM

Oct 3 2019

TK-999 awarded T232563: Drop IE6 and IE7 basic compatibility and security support a Like token.
Oct 3 2019, 7:30 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), MW-1.34-notes, User-notice, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-General

Sep 30 2019

TK-999 added a comment to T218446: Remove use of legacy page.page_restrictions field.

@WDoranWMF This was initially set for later I believe, but given Wikia has started work on it for us, perhaps CR could be provided earlier. Just leaving this here for now :)

Sep 30 2019, 10:55 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), Schema-change, MediaWiki-General, Technical-Debt (Deprecation process)

Sep 29 2019

TK-999 added a comment to T214035: DBError "Error: 1213 Deadlock found when trying to get lock" on WikiPage::doUpdateRestrictions.

Uploaded a tentative fix as per my hypothesis regarding the root cause.

Sep 29 2019, 10:38 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Wikimedia-production-error

Sep 25 2019

TK-999 added a comment to T214035: DBError "Error: 1213 Deadlock found when trying to get lock" on WikiPage::doUpdateRestrictions.

I thought about this a bit. My impression is that this may be caused by the locks set by DELETE statements issued from WikiPage::doUpdateRestrictions.

Sep 25 2019, 10:46 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Wikimedia-production-error
Ruthven awarded T212881: addWiki.php broken creating ES tables a Stroopwafel token.
Sep 25 2019, 9:21 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance
Quiddity awarded T212881: addWiki.php broken creating ES tables a Love token.
Sep 25 2019, 8:18 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance
Ankry awarded T212881: addWiki.php broken creating ES tables a Like token.
Sep 25 2019, 7:31 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, Patch-For-Review, MediaWiki-extensions-WikimediaMaintenance
TK-999 reopened T233165: Tag a new release of avro-php, a subtask of T233012: Make MediaWiki core compatible with PHP 7.4, as Open.
Sep 25 2019, 4:55 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-General, Patch-For-Review, PHP 7.4 support
TK-999 reopened T233165: Tag a new release of avro-php as "Open".
Sep 25 2019, 4:55 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), PHP 7.4 support
TK-999 closed T233165: Tag a new release of avro-php, a subtask of T233012: Make MediaWiki core compatible with PHP 7.4, as Resolved.
Sep 25 2019, 4:55 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-General, Patch-For-Review, PHP 7.4 support
TK-999 closed T233165: Tag a new release of avro-php as Resolved.
Sep 25 2019, 4:55 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), PHP 7.4 support

Sep 18 2019

TK-999 awarded Blog Post: Wikipedia's JavaScript initialisation on a budget a Love token.
Sep 18 2019, 11:33 PM

Sep 17 2019

TK-999 added a subtask for T233012: Make MediaWiki core compatible with PHP 7.4: T233165: Tag a new release of avro-php.
Sep 17 2019, 9:53 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-General, Patch-For-Review, PHP 7.4 support
TK-999 added a parent task for T233165: Tag a new release of avro-php: T233012: Make MediaWiki core compatible with PHP 7.4.
Sep 17 2019, 9:53 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), PHP 7.4 support