Page MenuHomePhabricator

Tacsipacsi
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 9 2014, 8:09 PM (343 w, 6 d)
Availability
Available
LDAP User
Tacsipacsi
MediaWiki User
Tacsipacsi [ Global Accounts ]

Recent Activity

Tue, May 11

Tacsipacsi added a comment to T274881: Change translation variable (tvar) syntax.

Using $ should be totally OK—this is how translators see it, which should be familiar for translation administrators as well. Actually, I’d write it this way manually, when it doesn’t matter which one is easier to produce. I found some other issues though that I noted on Gerrit. However, overall it’s nice work, thanks!

Tue, May 11, 10:23 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Language-Team (Language-2021-April-June), MediaWiki-extensions-Translate

Mon, May 10

Tacsipacsi added a comment to T280742: The page translation language list should use HTML list instead of literal bullet points.

There’s a getting started guide that should help you setting up your development environment. Also, you can simply grep for class names in the repo using your favorite tool after you cloned it, or on the web (rETRA  has a regex search field in the upper right corner).

Mon, May 10, 11:15 PM · good first task, Accessibility, MediaWiki-extensions-Translate

Sun, May 9

Tacsipacsi added a comment to T282374: Rethink the "Recent additions" group in Translate and translatewiki.

There are some links to it on mediawiki.org, although probably none of them as prominent as the translatewiki.net one.

Sun, May 9, 7:08 PM · MediaWiki-extensions-TwnMainPage, translatewiki.net
Tacsipacsi added a comment to T282374: Rethink the "Recent additions" group in Translate and translatewiki.

(If there are other ways that bring people to "Recent additions" except the blue button on the main page, please tell me what they are.)

[…]

This problem probably affects other wikis, too, such as Meta and mediawiki.org. I sometimes see people contributing minor translations to random recently created translatable pages. I'm not sure what brings them to "Recent additions", however; there's no such big blue button there as in translatewiki.

Sun, May 9, 6:14 PM · MediaWiki-extensions-TwnMainPage, translatewiki.net
Tacsipacsi created T282377: Specific video doesn’t play with video.js in Chrome.
Sun, May 9, 1:35 PM · Browser-Support-Google-Chrome, VideoJS player

Sat, May 8

Tacsipacsi added a comment to T274881: Change translation variable (tvar) syntax.

I don’t think it to be a critical feature (it’s a nice-to-have, though, of course), and given the problems I listed in T274881#7069958, I decided to give the patch a −1 on Gerrit.

Sat, May 8, 12:38 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Language-Team (Language-2021-April-June), MediaWiki-extensions-Translate

Fri, May 7

Tacsipacsi closed T282090: Language selector not visible on Hungarian Wikipedia in modern Vector with Javascript enabled as Resolved.

Oh, I just noticed that logged-out users still get the language links in the sidebar (which is collapsed by default – doesn’t seem like a very good UX decision…). So this bug report is actually only about logged-in users, which I hope to have fixed (JS, CSS).

Fri, May 7, 11:47 PM · Desktop Improvements, Vector
Tacsipacsi added a comment to T282090: Language selector not visible on Hungarian Wikipedia in modern Vector with Javascript enabled.

When logged out, it’s not there, not even in safe mode; it’s just missing from the DOM tree. When logged in, it’s there but the FlaggedRevs box overlaps it.

Fri, May 7, 9:11 PM · Desktop Improvements, Vector
Tacsipacsi added a comment to T274881: Change translation variable (tvar) syntax.

For example

<translate>The parameter’s value is {{#if:<tvar name="1">{{{param|}}}</tvar>|<tvar name="1">{{{param|}}}</tvar>|not specified}}.</translate>

This way translators are certain that this is the same text twice. The important thing is that they should contain byte-for-byte the same value, e.g. dropping the pipe in the second occurrence would potentially break it (I don’t remember whether the first or the last occurrence is used by Translate, but it doesn’t matter either—if you have different content, it’s wrong.)

Fri, May 7, 5:11 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Language-Team (Language-2021-April-June), MediaWiki-extensions-Translate
Tacsipacsi added a comment to T282204: Handle URLs for starting new sections.

Some gadgets/scripts, like huwiki’s warning.js, do a two-phase processing, where the user initiates the workflow in read mode, enters some data (clicks a button, types some text etc.), after which the script redirects them to the edit mode, passing the data in arbitrary GET query parameters, and in edit mode it modifies the text box’s content according to the parameters. If DiscussionTools, unaware of these parameters, takes over the request, the second phase of processing doesn’t happen, which practically results in data loss (technically the data is still in the query parameters, but the user is unlikely to be able to extract from there). (This particular gadget always opens up the whole page for editing, i.e. it uses no section=new, but it could, and actually that would probably result in a better UX in a pre-DT world. For testing, you can simply insert a section: 'new' field in the object in lines 402–406; it results in the templates sometimes inserted at wrong places, but that doesn’t matter if you just want to test how it works together with DT.)

Fri, May 7, 3:48 PM · Editing-team, DiscussionTools
Tacsipacsi added a comment to T278466: Let me switch to my normal wikitext editor when I start a new section.

I can imagine gadgets not available in the NDT (inserting standard messages, arbitrary templates, other blocks of code, reformatting etc.). Since gadgets are maintained (or not) by the community, there’s no guarantee they will ever be made compatible with the NDT; even if they could, sometimes they’re only for senior users, who are fine with the full-page editing, so it’s not worth the work making them compatible (at least not in the short term).

Fri, May 7, 10:44 AM · DiscussionTools
Tacsipacsi added a comment to T279483: When I reply to someone, please indicate the person's gender.

Current behavior
Languages that do NOT vary user namespace title by gender

The information is available through the API. I don’t think MediaWiki itself displays it anywhere, but e.g. Navigation-Popups-Gadget shows a ♂ or ♀ icon when one hovers over a user page/user talk/user subpage/whatever link of someone who has set their gender (i.e. it’s not neutral/unknown).

Fri, May 7, 12:43 AM · Editing-team (FY2020-21 Kanban Board), Gender-Support, DiscussionTools

Tue, May 4

Tacsipacsi updated the task description for T280605: Reduce parser cache retention temporarily for DiscussionTools.
Tue, May 4, 9:49 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), DBA, Patch-For-Review, Editing-team, Performance-Team, DiscussionTools

Mon, May 3

Tacsipacsi added a comment to T279483: When I reply to someone, please indicate the person's gender.

If you use the wording proposed in the description, Reply to {{GENDER:X|user}} X, the gender won’t become more visible in English (and in other languages that decide not to actually use the gender), it’s just a hint for people translating into languages that do use it. By the way, I often need this information in English, when I want to mention someone in third person (she/he/they), although the “Reply to…” message is probably not the best place to get it from.

Mon, May 3, 10:33 PM · Editing-team (FY2020-21 Kanban Board), Gender-Support, DiscussionTools

Sun, May 2

Tacsipacsi added a comment to T274881: Change translation variable (tvar) syntax.

I wouldn’t use it, either, if I named the translation variable, but the name was already there, so I decided to keep it instead of breaking and manually fixing dozens of translations.

Sun, May 2, 11:51 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Language-Team (Language-2021-April-June), MediaWiki-extensions-Translate

Sat, May 1

Tacsipacsi added a comment to T274881: Change translation variable (tvar) syntax.

Current status

Patch that implement support for <tvar name=1>value</tvar> syntax is in review. The new syntax is more strict about allowed chars in keys.

Sat, May 1, 2:15 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Language-Team (Language-2021-April-June), MediaWiki-extensions-Translate
Tacsipacsi added a comment to T280745: Ensure plain text is pasted into DiscussionTools source mode.

whereas a mainstream audience has been using the 2017 wikitext editor to reply to comments via full-page editing for years now...

Sat, May 1, 11:38 AM · Verified, MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Editing-team (FY2020-21 Kanban Board), DiscussionTools
Tacsipacsi changed the subtype of T281469: Support moving of translation pages to a different code from "Task" to "Feature Request".

I reflected to this as a feature request, so my questions still stand. However, if you’re willing to limit this feature to only changing the language code (instead of renaming to arbitrary titles), they’re probably easier to answer—the connection to the main page isn’t lost, the page doesn’t become freely editable, and the translation units can simply be also moved (because of the latter, it would make sense to limit the ability to do so similarly to moving root pages and probably commit the moves under FuzzyBot’s name).

Sat, May 1, 10:57 AM · MediaWiki-extensions-Translate

Thu, Apr 29

Tacsipacsi added a comment to T280766: Phase out legacy error, warning and success classes for usage outside the parser.

.error remains available for template authors to mark output as an error report, so this affects ONLY gadget/script authors from now on, NOT template authors, right?

Thu, Apr 29, 11:05 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, AbuseFilter, MediaWiki-extensions-Page_Forms, MediaWiki-extensions-CentralAuth, User-notice, Technical-Debt, MediaWiki-Core-Skin-Architecture
Tacsipacsi added a comment to T281469: Support moving of translation pages to a different code.

What do you expect to happen if you move a translated page? It would lose its connection to the main page. What to do with the translation unit pages (Translations: namespace)? Would the moved page become freely editable? What would happen with the original title? Turning into a redirect is not an option, since it has to use the translation page template, which is probably not a redirect.

Thu, Apr 29, 8:32 PM · MediaWiki-extensions-Translate
Tacsipacsi added a comment to T272102: Support substituting templates in MassMessage-delivered messages.

So you’re basically declining this (at least for now). Since T254481 takes the possibility for custom hacks away, it should support them natively. I do my best translating Tech News each week, but I’m getting burned out in not doing any creative work but just copying translations from last week 80% of the time. And it’s impossible to improve this situation without fixing this ticket (or switching back to the module-based hack).

Thu, Apr 29, 12:10 AM · MassMessage

Wed, Apr 28

Tacsipacsi updated the task description for T70672: hhvm: SolrTTMServerTest::testSearchableTTMServer BadMethodCallException: Call to a member function getMessage() on a non-object (NULL).
Wed, Apr 28, 9:38 PM · Discovery-Search, HHVM, CirrusSearch
Tacsipacsi updated the task description for T69295: Fatal error: Call to a member function getMessage() on a non-object in /mediawiki/extensions/Translate/tag/TranslatablePage.php on line 253.
Wed, Apr 28, 9:38 PM · MediaWiki-extensions-Translate
Tacsipacsi added a comment to T279150: Topic Subscriptions: Unsubscribe from Notifications from within dropdown.

Without the context of other icons (play, pause etc.), the stop icon doesn’t seem obvious for me. What about a ⛔ “no entry” sign? With less precedence I can imagine an X sign as well, or maybe an 🛑 octagonal STOP street sign.

Wed, Apr 28, 4:06 PM · Patch-For-Review, DiscussionTools, Editing-team (FY2020-21 Kanban Board)

Thu, Apr 22

Tacsipacsi added a comment to T280766: Phase out legacy error, warning and success classes for usage outside the parser.

ParserFunctions not only emits, but also consumes .error: rEPFN includes/ParserFunctions.php:169 (at b31c726461de) finds other ParserFunctions functions returning errors, but not only those, anything else that contains strong.error, span.error, p.error, div.error, like another extension’s/core’s error message, or even a template that uses the same error report mechanism. It’s also true the other way round, e.g. Lua modules may count on PF functions returning an element with class="error" on error. Even changing other extensions/core may break things, so I’m not sure how (or even whether) to proceed here. (Dropping .warning and .success is harmless in this regard.)

Thu, Apr 22, 10:06 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, AbuseFilter, MediaWiki-extensions-Page_Forms, MediaWiki-extensions-CentralAuth, User-notice, Technical-Debt, MediaWiki-Core-Skin-Architecture
Tacsipacsi updated the task description for T280766: Phase out legacy error, warning and success classes for usage outside the parser.
Thu, Apr 22, 10:06 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, AbuseFilter, MediaWiki-extensions-Page_Forms, MediaWiki-extensions-CentralAuth, User-notice, Technical-Debt, MediaWiki-Core-Skin-Architecture
Tacsipacsi added a comment to T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015).

As far as I recall, Microsoft states that they will support IE as long as they support the underlying operating system, for example Windows 10. They also state that they will support Windows 10 forever (or, to be a bit more realistic, for an unspecified amount of time). This means that we can count on IE remaining officially supported longer than we want it to, and we’ll need to stop supporting it before its official support ends.

Thu, Apr 22, 2:30 PM · Performance-Team, JavaScript, MediaWiki-ResourceLoader

Wed, Apr 21

Tacsipacsi added a comment to T280745: Ensure plain text is pasted into DiscussionTools source mode.

Why? I don’t really like the new wikitext editor, but I think this feature is particularly nice and handy. What’s the reason for deliberately taking it away? The user still has the option to paste the unformatted text, but also has the option to paste it with all the formatting.

Wed, Apr 21, 10:21 PM · Verified, MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Editing-team (FY2020-21 Kanban Board), DiscussionTools

Tue, Apr 20

Tacsipacsi created T280742: The page translation language list should use HTML list instead of literal bullet points.
Tue, Apr 20, 10:55 PM · good first task, Accessibility, MediaWiki-extensions-Translate
Tacsipacsi added a comment to T274040: In Special:Translate, insertables hide text in longer messages in Firefox.

this is making translating big strings using the translation interface impossible.

I think adding a blank line at the end should work this bug around. When saving the Translations-namespace page, this blank line is dropped, and I hope it’s dropped in the actual translatable page as well. However, I couldn’t test this, because…

Tue, Apr 20, 10:20 PM · Browser-Support-Firefox, MediaWiki-extensions-Translate

Sat, Apr 17

Tacsipacsi added a comment to T221795: Refactor Category::refreshCounts logic to a job and simplify.

Same bug? On hu:Kategória:Tudományos egyértelműsítő lapok, there are 189 pages and one subcategory listed, however, its parent category hu:Kategória:Egyértelműsítő lapok lists it as having 190 pages and zero subcategories. The subcategory hu:Kategória:Biológiai egyértelműsítő lapok was first accidentally created in the main namespace as hu:Biológiai egyértelműsítő lapok, then moved to the category namespace, then deleted and recreated in the category space.

Sat, Apr 17, 11:32 PM · Performance-Team (Radar), Platform Engineering Roadmap Decision Making, MediaWiki-Categories
Tacsipacsi added a comment to T53038: Extension styles not loaded when used in edit notice.

Still reproducible at https://commons.wikimedia.org/w/index.php?title=User_talk:Multichill&action=edit&section=new&safemode=1 (i.e. with Common.js, including its hotfix, disabled). Cf. with https://commons.wikimedia.org/wiki/User_talk:Multichill/Editnotice?safemode=1

Sat, Apr 17, 11:07 AM · MediaWiki-extensions-Babel

Fri, Apr 16

Tacsipacsi added a comment to T280383: Broadcast Reply Tool A/B test results and opt-out thinking.

Announcements

Planned publication date
late-April/early-May, 2020
late-April/early-May, 2020

You mean late April/early May, 2021, don’t you? You would be a bit late for 2020…

Fri, Apr 16, 8:00 PM · Editing-team (Tracking), DiscussionTools
Tacsipacsi added a comment to T279141: Discussion tools source mode should display navigation popups when enabled.

OK, I hope so. (Except for Kartographer, which is already broken for a long time, I was just too lazy to report it before: T280363).

Fri, Apr 16, 1:57 PM · Verified, Editing-team (FY2020-21 Kanban Board), MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), DiscussionTools
Tacsipacsi created T280363: Maplinks work only on the very first preview when using the live preview.
Fri, Apr 16, 1:57 PM · Maps (Kartographer)

Wed, Apr 14

Tacsipacsi added a comment to T279964: Dirty diffs that remove trailing empty lines from pages.

probably the best short-term solution is to simply ignore these dirty diffs (if possible, programmatically, i.e. not listing them in the dirty diff detector at all).

This was suggested for some other cases (T268833), but I don't like that, for two reasons:

  • It may not be a "real" dirty diff, but it's still a weird-looking one, and someone reviewing new comments from their watchlist is going to be confused by it.

Good point, I haven’t thought about that.

  • I don't want to make it seem as if we're gaming the numbers.

I don’t think it’s gaming the numbers, just removing useless clutter about things that are not DT’s fault. But I’m not the one who keeps track of the dirty diff detector, so I’m not really a stakeholder in this question. 🙂

Wed, Apr 14, 10:47 PM · MW-1.36-notes, Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), DiscussionTools, MediaWiki-Parser

Apr 12 2021

Tacsipacsi added a comment to T279964: Dirty diffs that remove trailing empty lines from pages.

I think in the long term, it should certainly be fixed in MediaWiki PST. Substitutions that cause unintended changes in the next edit should be avoided whenever possible, and this seems to be relatively easy to fix (although I don’t know exactly how PST works). In the short term, instructions may be moved to the edit notice in certain cases, but probably the best short-term solution is to simply ignore these dirty diffs (if possible, programmatically, i.e. not listing them in the dirty diff detector at all).

Apr 12 2021, 9:47 PM · MW-1.36-notes, Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), DiscussionTools, MediaWiki-Parser

Apr 9 2021

Tacsipacsi added a comment to T279750: [accepted revision] is white in FlaggedRevs diffs.

This bug is present also after I accept the revision using the JavaScript interface using the button highlighted below. I don’t know if they use the same code path, but if they don’t, JS should be accounted for as well.

Apr 9 2021, 8:01 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), User-Ladsgroup, Regression, MediaWiki-extensions-FlaggedRevs
Raymond awarded T279750: [accepted revision] is white in FlaggedRevs diffs a Heartbreak token.
Apr 9 2021, 5:31 AM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), User-Ladsgroup, Regression, MediaWiki-extensions-FlaggedRevs
Tacsipacsi added a comment to T279444: Single revision would be marked for translation multiple times by Translate extension.

In the past, Translate extension sometimes failed to update translation pages, so I make an effort to mark multiple times.

Apr 9 2021, 2:21 AM · MediaWiki-extensions-Translate
Tacsipacsi created T279750: [accepted revision] is white in FlaggedRevs diffs.
Apr 9 2021, 1:17 AM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), User-Ladsgroup, Regression, MediaWiki-extensions-FlaggedRevs
Tacsipacsi added a comment to T279141: Discussion tools source mode should display navigation popups when enabled.

Firing wikipage.content may however cause new issues as well. As far as I know, currently wikipage.content is always fired with the one and only content block on the page (although the documentation doesn’t state this). If it’s fired with the preview, this expectation is broken and this may cause undefined behavior regarding the rest of the page (as scripts may consider it to be removed from the DOM tree).

Apr 9 2021, 12:08 AM · Verified, Editing-team (FY2020-21 Kanban Board), MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), DiscussionTools

Apr 8 2021

Tacsipacsi created T279693: .plainlinks doesn’t work with Timeless.
Apr 8 2021, 4:55 PM · MediaWiki-Core-Skin-Architecture, Patch-For-Review, MW-1.36-release, Regression, MediaWiki-Interface, Timeless
Tacsipacsi added a comment to T47096: Add a way to transclude template or other page in the correct language.

But most of them already use the Translate extension, and thus have the page language properly set. And for the few that don’t, using {{TNT}} is still an option until they are migrated/have their page language manually set.

Apr 8 2021, 12:07 AM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Parsoid (Tracking), Language-Team (Language-2021-January-March), Platform Team Workboards (External Code Reviews), MediaWiki-extensions-Translate

Apr 7 2021

Tacsipacsi created T279535: Line breaks removed from nowiki by DiscussionTools edit.
Apr 7 2021, 1:25 PM · DiscussionTools
Tacsipacsi added a comment to T279099: Minor edit marker no longer bolded on diffs.

Backported

Apr 7 2021, 8:51 AM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, MediaWiki-Core-Skin-Architecture, MediaWiki-Interface
Tacsipacsi renamed T279472: Page previews show last revision instead of flagged revision from Navigation Popups show last revision instead of flagged revision to Page previews show last revision instead of flagged revision.
Apr 7 2021, 2:23 AM · Product-Infrastructure-Team-Backlog, Page-Previews (Tracking), Mobile-Content-Service, Readers-Web-Backlog (Tracking), MediaWiki-extensions-FlaggedRevs
Tacsipacsi edited projects for T279472: Page previews show last revision instead of flagged revision, added: Page-Previews; removed Navigation-Popups-Gadget.

The screenshot shows the Page previews feature, not Navigation Popups. While Navigation Popups may also be affected, it’s a power user tool, so eventual vandalism doesn’t seem to be an issue for me there. Page previews, on the other hand, is aimed at readers and should be fixed.

Apr 7 2021, 2:23 AM · Product-Infrastructure-Team-Backlog, Page-Previews (Tracking), Mobile-Content-Service, Readers-Web-Backlog (Tracking), MediaWiki-extensions-FlaggedRevs
Tacsipacsi added a comment to T251116: Have a shorter name for <syntaxhighlight>.

Never ever try to type elements and syntax from scratch.

Never ever tell us how to get things into the edit box. I can type pretty fast, so typing <source> is way faster for me than any smart method, which inevitably involves something other than the basic typing keys (Ctrl/Alt/whatever key, mouse etc.). And I don’t mistype it. Even typing <syntaxhighlight> is faster than any auxiliary methods if I happen to type it correctly for the first time. I do have methods to avoid typing things, but I save it for much more complicated/much longer snippets.

Apr 7 2021, 2:15 AM · SyntaxHighlight
Tacsipacsi created T279495: Page translation log should contain changed settings.
Apr 7 2021, 2:05 AM · MediaWiki-extensions-Translate

Apr 6 2021

Tacsipacsi added a comment to T274040: In Special:Translate, insertables hide text in longer messages in Firefox.

This looks like an upstream Firefox bug. The padding is still there (screenshot from version 88.0b6), and the same page still looks good in Firefox 78.9.0esr.

Apr 6 2021, 11:32 PM · Browser-Support-Firefox, MediaWiki-extensions-Translate

Apr 5 2021

Tacsipacsi added a comment to T279008: mw-parser-output now clears after block, which is a noticeable change for Category pages where infoboxes used to render floated alongside the automatic content.

Nothing is actually broken on these specific pages, but only because neither of them have anything floating at the end (which is the case on enwiki, but nothing prevents users from adding some floating elements). If I make the last elements float and do as if there were no categories on Special:BookSources (add class="catlinks-allhidden" to #catlinks), those floating elements get out of the content area:

BookSourcesCiteThisPage
Apr 5 2021, 7:01 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Readers-Web-Backlog (Kanbanana-FY-2020-21), Vector, CSS
Tacsipacsi added a comment to T279008: mw-parser-output now clears after block, which is a noticeable change for Category pages where infoboxes used to render floated alongside the automatic content.

What about special pages displaying wikitext pages like Special:BookSources and Special:CiteThisPage? They’re broken at the moment, of course, as the train hasn’t arrived yet, but will they be fixed once it does?

Apr 5 2021, 6:46 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Readers-Web-Backlog (Kanbanana-FY-2020-21), Vector, CSS
Tacsipacsi added a comment to T279285: List of variables is over the translated text.

This looks like an upstream Firefox bug. The padding is still there (screenshot from version 88.0b6), and the same page still looks good in Firefox 78.9.0esr.

Apr 5 2021, 4:25 PM · MediaWiki-extensions-Translate

Apr 2 2021

Tacsipacsi added a comment to T279099: Minor edit marker no longer bolded on diffs.

Thanks for fixing it! Is there a chance to have this backported, at least on Monday? (If anyone works on Easter Monday.)

Apr 2 2021, 11:21 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, MediaWiki-Core-Skin-Architecture, MediaWiki-Interface
Tacsipacsi added a comment to T276614: Consult with volunteers about the prototype.

T279141 Discussion tools source more should display navigation popups when enabled (note I can't test this on the prototype as the gadget is not installed; medium priority)

If you’re comfortable with the browser command line, you can load it with

mw.loader.load('https://en.wikipedia.org/w/load.php?modules=ext.gadget.Navigation_popups');

(It doesn’t work in DiscussionTools.)

Apr 2 2021, 9:14 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools
Tacsipacsi added a comment to T279008: mw-parser-output now clears after block, which is a noticeable change for Category pages where infoboxes used to render floated alongside the automatic content.

For example, Special like Special:Contributions and RecentChanges have bodyContent which was cleared before and includes user-generated content via interface messages at the top of the page, and for the bottom of the page via mw-contributions-footer and other such mechanisms.

And it’s not even only about user-generated content. If one uses the new watchlist and has hiding seen edits on, the (non-user-generated) help text can flow out of the content area:

Apr 2 2021, 12:36 AM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Readers-Web-Backlog (Kanbanana-FY-2020-21), Vector, CSS

Apr 1 2021

Tacsipacsi created T279099: Minor edit marker no longer bolded on diffs.
Apr 1 2021, 8:43 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, MediaWiki-Core-Skin-Architecture, MediaWiki-Interface

Mar 30 2021

Tacsipacsi created T278848: Allow keeping the default collapsible toggle in addition to a custom one.
Mar 30 2021, 4:45 PM · Readers-Web-Backlog (Tracking), MediaWiki-Interface (collapsible elements)

Mar 28 2021

Tacsipacsi added a comment to T17075: Per book, category and/or template CSS and JavaScript.

You was the one who started the C&P… But let’s forget this, and continue exclusively there.

Mar 28 2021, 11:56 PM · MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), MW-1.27-release-notes, Wikimedia-Hackathon-2016, WorkType-NewFunctionality, MediaWiki-General
Tacsipacsi added a comment to T241524: Parser function for loading gadgets.

I don’t see my point about sandboxes (especially sandboxes edited by non-IAs) answered. Also,

Mar 28 2021, 11:55 PM · MediaWiki-extensions-Gadgets
Tacsipacsi added a comment to T75299: Indicators (protected icon, featured icon) are not shown in Minerva.

• Indicators not using a supported type/class value will not be displayed at all.

I think that, while the one displayed initially (the assessment one) should be opt-in, the ones appearing in the dropdown should be opt-out—if there’s a dropdown anyway, real estate doesn’t seem to be a huge concern within that. Most indicators will probably work just fine within the dropdown, and even the ones that don’t, won’t break the page to the extent that would warrant making them opt-in (worst case: they overflow, forcing the user to scroll horizontally—but only if they open the dropdown).

Mar 28 2021, 11:55 PM · Readers-Web-Backlog, MinervaNeue
Tacsipacsi added a comment to T75299: Indicators (protected icon, featured icon) are not shown in Minerva.

DeltaBot is ought to fix the discrepancies, but it seems not to work. 🙁

Mar 28 2021, 9:37 PM · Readers-Web-Backlog, MinervaNeue
Tacsipacsi added a comment to T265875: On smaller screen width, pages with pending review do not show version history tab.

There should be a Weitere ▼ dropdown just left to the search field. If it isn’t there, it’s a bug. Maybe it manifests itself in this particular page only on mobile, but for example file description pages like Datei:WestAusMap-doton-Bayswater.png have extremely long tab bar: Lesen / Bearbeiten / Quelltext bearbeiten / Versionsgeschichte / Nach Wikimedia Commons exportieren; this doesn’t fit my computer screen either. However, I wasn’t able to reproduce this, for me Weitere ▼ menu always appears across different browsers and devices (Firefox on Debian GNU/Linux 10 “buster”, Samsung browser on Android 6 Marshmallow and Google Chrome on Android 4.4 KitKat).

Mar 28 2021, 9:07 PM · MediaWiki-extensions-FlaggedRevs, Mobile, Readers-Web-Backlog (Tracking)
Tacsipacsi added a comment to T278644: “Preview page with this template” broken with translatable templates.

As far as I know, this preview has never worked with translatable pages, neither with the legacy {{#switch:<translate></translate> hack (provided that you changed something within the empty branch of the switch, which is equivalent to the whole template in the new system).

Mar 28 2021, 6:22 PM · MediaWiki-extensions-TemplateSandbox, MediaWiki-extensions-Translate
Tacsipacsi added a comment to T75299: Indicators (protected icon, featured icon) are not shown in Minerva.

As far as I see, the main issue causing this not to be fixed for more than six years now is UI design, not the underlying technology. UI design should be independent of what the underlying technology is; if your proposal about using the tagline works for badges from Wikidata, it will work for badges from indicators as well. If it doesn’t work out for indicators, it won’t work out for WD badges either.

Mar 28 2021, 6:08 PM · Readers-Web-Backlog, MinervaNeue
Tacsipacsi updated the task description for T278466: Let me switch to my normal wikitext editor when I start a new section.
Mar 28 2021, 3:49 PM · DiscussionTools
Tacsipacsi added a comment to T124168: Show Navbox templates in mobile skins.

Because it builds on the same basic visual styles (colors, spacing etc., even the rule that collapses horizontal borders applies to table.navbox + table.navbox, not table.navbox + .whatever). If we used another class, we would need to duplicate all rules (quadruplicate in case of the border collapse rule: .navbox+.navbox, .navbox+.whatever, .whatever+.navbox, .whatever+.whatever). Actually last time I tried it with another template, not even navboxlike would work as all elements were deleted from the HTML source whose class attribute matched the .*navbox.* rule, even if it was not matched by the .navbox CSS selector…

Mar 28 2021, 1:50 PM · MobileFrontend (Tracking), Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, Mobile
Tacsipacsi added a comment to T75299: Indicators (protected icon, featured icon) are not shown in Minerva.

I don’t think relying on Wikidata is a great idea. The local templates and the Wikidata information should say the same, but nothing enforces it, inevitably leading to differences every now and then. So if Vector uses the local templates and Minerva uses Wikidata, they will have the same result only in 99% of the articles. I think adding some metadata to the indicator (e.g. <indicator name="topicon-Vorlage_Exzellent" category="assessment">) is a better solution—it requires some work to add it to templates around wikis, but then it guarantees 100% correct output, and it can even handle if wikis choose a different assessment system, which isn’t (yet) properly mapped in Wikidata (like Wikisources’ {{TextQuality}} template).

Mar 28 2021, 12:44 PM · Readers-Web-Backlog, MinervaNeue
Tacsipacsi added a comment to T276393: Reply links appear for users who can't edit the page.

I logged in as Mallory, and https://patchdemo.wmflabs.org/wikis/a8da9c890a/w/index.php?title=Talk:Normal_board&action=edit gives me:

[5db0d179a84316700496fd73] /wikis/a8da9c890a/w/index.php?title=Talk:Normal_board&action=edit RuntimeException: SFS IP file contents and file md5 do not match!
Mar 28 2021, 12:13 PM · Editing QA, Editing-team (FY2020-21 Kanban Board), DiscussionTools
Tacsipacsi added a comment to T249893: Add "Thanks" to talk page comments.

Also see https://www.mediawiki.org/w/index.php?title=Topic:W5wqmnpooz2meqe1&topic_showPostId=w60rj2bs5w7l6nkb#flow-post-w60rj2bs5w7l6nkb.

Mar 28 2021, 11:45 AM · Growth-Team-Filtering, DiscussionTools, Growth-Team, OWC2020, Editing-team (Tracking), Thanks

Mar 27 2021

Tacsipacsi added a comment to T274982: Disable fetching constraints from the wdqs updater.

Here are some examples for these rules: https://www.wikidata.org/wiki/Property:P50#constraints

If you go to its talk page, the constraint templates have links to the lists of constraint violations. The links labeled SPARQL (new) use wikibase:hasViolationForConstraint, which will break. Most constraints also have non-new SPARQL queries, but some (it’s only the allowed entity types constraint on P‌50, but AFAIR there are some others as well) don’t. So how to find these constraint violations? Even though the overall impact of the removal is small, its impact on this particular—rare but important—use case is very high. I’m open to all solutions, including a special page (not Special:ConstraintReport, as I want to search by predicate, not by subject), a Toolforge tool etc. The only important criteria are that it should provide (nearly) real-time results and it should have a stable URL that can be linked from the constraint template.

Mar 27 2021, 10:17 AM · Discovery-Search (Current work), Patch-For-Review, Wikidata

Mar 25 2021

Tacsipacsi added a comment to T124168: Show Navbox templates in mobile skins.

Please also note that .navbox doesn’t necessarily mean a such complex and non-mobile-friendly table-based thing. For example, the authority control box at the bottom of https://hu.wikipedia.org/wiki/Barack_Obama is responsive and looks good on mobile as well (the boxes above it don’t, I know), but not even an !important rule can display it as long as it’s not present in MobileFrontend’s HTML output.

Mar 25 2021, 12:44 AM · MobileFrontend (Tracking), Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, Mobile

Mar 22 2021

Tacsipacsi added a comment to T275958: Enable interlanguage links from multilingual Wikisource to other Wikisources.

There’s no overwhelming flood of comments, but all three commenters supported this change, and the Scriptorium section has been open for more than three weeks now, so everyone had the chance to express their opinion. Can we now move forward and enable the interlanguage links?

Mar 22 2021, 12:25 AM · Wikidata-Campsite, Wikimedia-Site-requests, Wikidata, Wikisource, wdwb-tech

Mar 21 2021

Tacsipacsi added a comment to T17075: Per book, category and/or template CSS and JavaScript.
  • T204201 Extend MediaWiki:Gadgets-definition capabilities would solve the JavaScript loading issues much better. It serves much more cases and is flexible enough, e.g. by loading JavaScript if a certain template is transcluded.

But what if not the template is transcluded, only its sandbox? The module may or may not need to be loaded; this is not deterministic and known only to the—potentially non-IA—user testing in the sandbox. Or when one wants to preview a change to a template that adds or removes a gadget dependency? This latter one is not only organizationally, but also technically impossible to support with the architecture you propose.

Mar 21 2021, 9:06 PM · MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), MW-1.27-release-notes, Wikimedia-Hackathon-2016, WorkType-NewFunctionality, MediaWiki-General
Tacsipacsi added a comment to T241524: Parser function for loading gadgets.
  • T204201 Extend MediaWiki:Gadgets-definition capabilities would solve the JavaScript loading issues much better. It serves much more cases and is flexible enough, e.g. by loading JavaScript if a certain template is transcluded.

But what if not the template is transcluded, only its sandbox? The module may or may not need to be loaded; this is not deterministic and known only to the—potentially non-IA—user testing in the sandbox. Or when one wants to preview a change to a template that adds or removes a gadget dependency? This latter one is not only organizationally, but also technically impossible to support with the architecture you propose.

Mar 21 2021, 9:05 PM · MediaWiki-extensions-Gadgets
Tacsipacsi added a comment to T276393: Reply links appear for users who can't edit the page.
  1. I think the likelihood of someone landing on a protected page that contains conversations transcluded from unprotected pages is low enough for us not to design for it.

I think it’s worth noting that nothing prevents this from happening the other way round, that is, the main page is not protected, but the transcluded page is. For example I recently came across a wiki (unfortunately I don’t remember which) where old request pages (requests for rights, as far as I remember) are protected. If these requests are transcluded for a short time after being closed, comments within these transcluded parts cannot be replied to, while eventual comments on the main page can. Probably this is also rare, but not impossible either.

Mar 21 2021, 6:56 PM · Editing QA, Editing-team (FY2020-21 Kanban Board), DiscussionTools
Tacsipacsi added a comment to T275822: WS Export download button doesn’t work on multilingual Wikisource.

Thanks for fixing it!

Mar 21 2021, 6:23 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Wikisource, Community-Tech (Kanban-2020-21-Q3), WS Export
Tacsipacsi added a comment to T277723: Enable local uploads on Irish Wikipedia.

I just helped the gawiki community with creating this task, I’m not part of it. I have absolutely no idea what they want more than what I already wrote down, any questions regarding the scope of this task should be directed to @Llywelyn2000.

Mar 21 2021, 5:01 PM · User-Urbanecm, User-Luke081515, Wikimedia-Site-requests
Tacsipacsi added a comment to T278002: messagebox styles breaks indentation in some lists.

(Hmm, did the subscribed folks explicitly asked to get subscribed? Just wondering about notification spam...)

Mar 21 2021, 4:56 PM · MediaWiki-Core-Skin-Architecture, MediaWiki-Interface, CSS
Tacsipacsi added a comment to T185664: Code stewardship review: FlaggedRevs.

So one more reason to resolve T197912—if the box’s position is tied to the indicators, wherever they are, it will work well on both new and legacy Vector (although fixing the JavaScript hack seems pretty easy, but it’s still not ideal and works only on huwiki). By the way, is there a wiki with FlaggedRevs on beta cluster, where I could test this change? If not, when is it expected to hit production as part of the (currently opt-in) new Vector? Never mind, I found out that the German one has it.

Mar 21 2021, 3:44 PM · User-notice, MediaWiki-extensions-FlaggedRevs, Code-Stewardship-Reviews
Tacsipacsi added a comment to T185664: Code stewardship review: FlaggedRevs.

"SimpleUI" will currently break the fiwikis page layout as it will collide with some templates.

Huwiki solves this issue by moving the FlaggedRevs box next to the page title. T197912 asks to have this as a built-in option, but not much happened around it in the past few years. If we want to simplify things, maybe making it the only option is also a possibility.

Mar 21 2021, 3:18 PM · User-notice, MediaWiki-extensions-FlaggedRevs, Code-Stewardship-Reviews
Tacsipacsi updated the task description for T197912: Option to have FlaggedRevs rating box as an indicator.
Mar 21 2021, 3:14 PM · MediaWiki-extensions-FlaggedRevs

Mar 17 2021

Tacsipacsi created T277723: Enable local uploads on Irish Wikipedia.
Mar 17 2021, 11:41 PM · User-Urbanecm, User-Luke081515, Wikimedia-Site-requests
Tacsipacsi added a comment to T75299: Indicators (protected icon, featured icon) are not shown in Minerva.

it seems as if "protected" status is currently shown on mobile via the edit icon

The indicators communicate more details: the padlock colors indicate the protection level (although this is probably not obvious for readers), including levels that don’t block the user from editing (e.g. an admin technically can edit a fully protected article, but often the protection policy forbids this except for some special conditions), and, more importantly, these padlocks link to pages explaining the protection policy—the edit buttons’ padlocks simply describe the situation (the what), the indicator padlocks explain the why. (Also, the what is described by the View source tab on desktop, so the situation is no different there, yet communities decided to place additional padlocks on pages.)

Mar 17 2021, 1:23 AM · Readers-Web-Backlog, MinervaNeue
Tacsipacsi added a comment to T47096: Add a way to transclude template or other page in the correct language.

Eventually we plan to add tags on Special:PageTranslation similar to what we do for pages that use old syntax.

Mar 17 2021, 12:57 AM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Parsoid (Tracking), Language-Team (Language-2021-January-March), Platform Team Workboards (External Code Reviews), MediaWiki-extensions-Translate

Mar 12 2021

Tacsipacsi added a comment to T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015).

Technical question: Do we know what our heuristic for browser support will look like when we drop IE11 (e.g. is it a feature detection test)?. I ask because we are logging a lot of JS errors from older versions of Firefox and I am wondering whether the heuristic will (or could) exclude these.

Mar 12 2021, 8:27 PM · Performance-Team, JavaScript, MediaWiki-ResourceLoader

Mar 11 2021

Tacsipacsi added a comment to T276990: Ensure duplicate notifications are *not* sent for the same talk page event.

What about simply dropping the DT notification if we know the user will get a mention notification anyways? Mention is a notification type Echo already handles, so implementing it in DT seems reinventing the wheel to me.

Mar 11 2021, 1:32 AM · Skipped QA, MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Editing-team (FY2020-21 Kanban Board), DiscussionTools

Mar 8 2021

Tacsipacsi updated subscribers of T47096: Add a way to transclude template or other page in the correct language.

@Tacsipacsi How many pages are there that would break?

Quite a number of. I have no exact figures, of course, but I’ve reverted nine edits by @Shirayuki so far that broke pages, despite of the fact that he deliberately changed them, just wasn’t aware of the broken pages. Some are templates that use the UI language instead of the page language (using the {{int:lang}} hack), others are templates used on pages translated without the Translate extension, where {{TNT}} recognizes the language suffix in the title, but Translate sees that Title::getPageLanguage() returns English.

Mar 8 2021, 12:59 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Parsoid (Tracking), Language-Team (Language-2021-January-March), Platform Team Workboards (External Code Reviews), MediaWiki-extensions-Translate

Mar 7 2021

Tacsipacsi added a comment to T275828: Make volunteers aware of New Discussion Tool's availability as beta feature.

@ppelberg, all projects or all Wikipedias? I see that you updated other tasks’ descriptions (e.g. T275827#6884719), but this one still says all projects.

Mar 7 2021, 5:51 PM · Editing-team (Tracking), DiscussionTools

Mar 6 2021

Tacsipacsi added a comment to T47096: Add a way to transclude template or other page in the correct language.

Is it possible to make this option checked by default for pages being marked for translation for the first time, but unchecked for pages being re-marked? The risk of breaking things is quite low in case of a newly translatable template, it’s high only for templates already in use. This way fewer pages would be left with supportsTransclusion set to false, yet the risk of breaking things would be considerably lower.

Mar 6 2021, 2:33 AM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Parsoid (Tracking), Language-Team (Language-2021-January-March), Platform Team Workboards (External Code Reviews), MediaWiki-extensions-Translate

Mar 5 2021

Tacsipacsi renamed T273388: Bot incorrectly changes "wayback" templates to "cite web" despite of them following other cite templates. [huwiki] from Bot incorrectly changes "wayback" templates to "cite web" despite existence of "cite book" template. [huwiki] to Bot incorrectly changes "wayback" templates to "cite web" despite of them following other cite templates. [huwiki].
Mar 5 2021, 5:20 PM · InternetArchiveBot

Mar 1 2021

Tacsipacsi added a comment to T275958: Enable interlanguage links from multilingual Wikisource to other Wikisources.

Yes, I want to have it hardwired, just like how it’s hardwired for all other Wikimedia wikis that are Wikidata clients.

Mar 1 2021, 12:25 AM · Wikidata-Campsite, Wikimedia-Site-requests, Wikidata, Wikisource, wdwb-tech

Feb 28 2021

Tacsipacsi added a comment to T275958: Enable interlanguage links from multilingual Wikisource to other Wikisources.

@Jarekt Multilingual Wikisource also has a Module:Interwiki, which can show interlanguage links based on Wikidata. It works well (although it requires the Qid to be passed manually, but it could be easily rewritten to fall back to the connected Wikidata item), but we’d like to have a native solution, like how c:Category:Javanese language links to w:en:Category:Javanese language when it’s not overridden by the infobox.

Feb 28 2021, 1:59 PM · Wikidata-Campsite, Wikimedia-Site-requests, Wikidata, Wikisource, wdwb-tech
Tacsipacsi changed the subtype of T49137: Add ability to generate a list of pages based on prefix to Scribunto/Lua from "Task" to "Feature Request".

To limit the need for cache invalidations, maybe this function could be limited to subpages rather than arbitrary prefixes—for example the equivalent of Special:PrefixIndex/Global message delivery/Targets/ would be something like mw.title.new( 'Global message delivery/Targets' ).subpages. This way, when Global message delivery/Targets/bar/foo is created or deleted, only the subpage list queries for Global message delivery/Targets/bar, Global message delivery/Targets and Global message delivery should be invalidated, while using special pages, Special:PrefixIndex/Global message delivery/Targets/bar/fo also lists it.

Feb 28 2021, 1:43 PM · MediaWiki-extensions-Scribunto

Feb 27 2021

Tacsipacsi added a comment to T230653: Use a parser function to encapsulate signatures.

To be clear, I’m not against this change, just want to make sure that this rather large impact is taken into account.

Feb 27 2021, 10:12 PM · DiscussionTools, Patch-For-Review, OWC2020, MediaWiki-Parser
Tacsipacsi added a comment to T138332: Interwiki links to/from Multilingual Wikisource.

I created the follow-up ticket at T275958.

Feb 27 2021, 10:53 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), User-notice, Wikisource, Wikidata
Tacsipacsi created T275958: Enable interlanguage links from multilingual Wikisource to other Wikisources.
Feb 27 2021, 10:51 AM · Wikidata-Campsite, Wikimedia-Site-requests, Wikidata, Wikisource, wdwb-tech
Tacsipacsi added a comment to T275814: Cursor does not appear in Reply Tool's source mode.

MediaWiki’s modern support for Firefox 52 ended years ago—according to mw:Compatibility#Browser support matrix, only latest and previous version of FF is supported, which is currently 86.0 and 85.0. Of course if there’s an actual bug in DT, it should be fixed, but otherwise MW doesn’t guarantee that fancy features like anything JavaScript-based will work.

Feb 27 2021, 12:53 AM · DiscussionTools

Feb 26 2021

Tacsipacsi added a comment to T47096: Add a way to transclude template or other page in the correct language.

Issue: translation aware transclusion is checked by default on Special:PageTranslation for legacy pages (not marked for translation since the deployment of this change). This will inevitably lead to accidentally breaking things, it should be unchecked by default.

Feb 26 2021, 11:54 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Parsoid (Tracking), Language-Team (Language-2021-January-March), Platform Team Workboards (External Code Reviews), MediaWiki-extensions-Translate