Page MenuHomePhabricator

Tacsipacsi
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 9 2014, 8:09 PM (397 w, 1 d)
Availability
Available
LDAP User
Tacsipacsi
MediaWiki User
Tacsipacsi [ Global Accounts ]

Recent Activity

Yesterday

Tacsipacsi created T308859: Wikibase frontend enforces stricter undo summary length limit than the backend.
Fri, May 20, 2:05 PM · MediaWiki-extensions-WikibaseRepository, Wikidata
Tacsipacsi added a comment to T45044: [Task] Edit auto summary not substituted in email notification.

With T215422: Migrate Wikibase to use comment_data field instead of SummaryFormatter implemented, the comment_text will be the summary parsed in the content language, so if the mailer uses that (I suppose it does), this bug will be automatically resolved—although the summary will be in content language even if the user’s UI language is different, this is consistent with the rest of the email.

Fri, May 20, 12:39 PM · Wikidata, patch-welcome, MediaWiki-extensions-WikibaseRepository
Tacsipacsi added a parent task for T215422: Migrate Wikibase to use comment_data field instead of SummaryFormatter: T45044: [Task] Edit auto summary not substituted in email notification.
Fri, May 20, 12:38 PM · MediaWiki-Comment-store, Wikidata
Tacsipacsi added a subtask for T45044: [Task] Edit auto summary not substituted in email notification: T215422: Migrate Wikibase to use comment_data field instead of SummaryFormatter.
Fri, May 20, 12:38 PM · Wikidata, patch-welcome, MediaWiki-extensions-WikibaseRepository
Tacsipacsi changed the subtype of T130834: [Bug] edit summary comment issue - missing */ from "Task" to "Bug Report".

T215422: Migrate Wikibase to use comment_data field instead of SummaryFormatter could maybe improve the situation? If the parameters will be stored in a more structured way, at least not the */ will be missing.

Fri, May 20, 11:29 AM · Wikidata
Tacsipacsi added a comment to T308788: Remove CompactUI setting for FlaggedRevs.

I’m pretty sure it would be possible—almost anything that can be done in PHP can be done in JS as well—, but I don’t see why would that be worth the effort, as this change would just move the complexity from PHP to JS, also causing more flash of unstyled content when the JS puts things in the right place.

Fri, May 20, 9:59 AM · Design, MediaWiki-extensions-FlaggedRevs
Tacsipacsi added a comment to T308788: Remove CompactUI setting for FlaggedRevs.

First, the second line is floated to the right by default, it’s just locally overridden on ruwiki:

Normal modeSafe mode (Common.css and gadgets turned off – no local overrides)
Screenshot 2022-05-20 at 11-36-02 Слободкин, Павел Яковлевич — Википедия.png (238×1 px, 59 KB)
Screenshot 2022-05-20 at 11-33-38 Слободкин, Павел Яковлевич — Википедия.png (235×1 px, 53 KB)
Fri, May 20, 9:44 AM · Design, MediaWiki-extensions-FlaggedRevs

Thu, May 19

Tacsipacsi added a comment to T306675: Reconcile conflict between latest comment indicator and siteSub message.

I like the indented version more, but that may be just because that’s what I’m used to—these margins haven’t changed for almost 18 years (since 1e30c02696f)! However, if a design expert says that the unindented version is objectively better for some reason, I can get used to it. (But with the promise that legacy Vector will be kept as is, I think this change should apply only to new Vector, not to legacy Vector or Monobook.)

Thu, May 19, 1:04 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools

Tue, May 17

Tacsipacsi added a comment to T308200: Remove keyboard shortcut helper text from mobile DiscussionTools dropdowns.

That’s also a good idea. Although not perfect (the perfect would be if we could display them on exactly those devices that have Ctrl key, but that’s impossible), it’s probably the second best solution.

Tue, May 17, 11:33 AM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), Design, DiscussionTools
Tacsipacsi reopened T210428: Review "about this page" page issues treatment of boxes at the top of talk pages as "Open".

With the new talk page empty state experience (T270323) now being available on mobile web where DiscussionTools is enabled [i], I think we can resolve this task

No, we can’t. The talk page empty state experience is about non-existent pages, while this task is about existing pages that contain only tmboxes. See for example https://simple.m.wikipedia.beta.wmflabs.org/wiki/Talk:Avalanche: it does exist, thus the empty state experience doesn’t appear, but it contains nothing but a talk page header, which is hidden on mobile, so no real content appears either (not even the About this page seems to appear for some reason):

Screen Shot 2022-05-17 at 13.16.28.png (2×1 px, 256 KB)

Tue, May 17, 11:19 AM · Editing-team, Talk Pages, MinervaNeue
Tacsipacsi reopened T210428: Review "about this page" page issues treatment of boxes at the top of talk pages, a subtask of T287805: Introduce talk page empty state experiences on mobile, as Open.
Tue, May 17, 11:19 AM · Editing-team (FY2021-22 Kanban Board), Mobile, DiscussionTools

Mon, May 16

Tacsipacsi added a comment to T308198: Following the "log in" or "create an account" links in reply tool not-logged-in warning loses extra URL parameters.

@EAkinloose, what’s your default skin on enwiki? It looks like you may have set new Vector in your (local or global) preferences. As far as I remember, the new table of contents is default on all wikis where new Vector is not default (for people who opted in to new Vector), so if new Vector is your default, you get the new TOC even at https://en.wikipedia.org/wiki/Talk:The_Fighting_Temeraire (i.e. without any URL parameters).

Mon, May 16, 6:44 PM · Verified, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Editing-team (FY2021-22 Kanban Board), DiscussionTools
Tacsipacsi added a comment to T308448: Comment not recognized for no obvious reason.

Thanks for the tip, it makes sense: I copied the second timestamp from the page history (only the time part, as I use Hungarian interface, so the date part would have been of no use), while I decided to retype the first one. To support already-existing such unsigned templates, it would be useful to remove all LTR/RTL marks from the text before recognizing the timestamps, but to prevent new ones, I think the page history shouldn’t contain them in the first place; incorrect positioning should be prevented at the HTML (<bdi>) / CSS (unicode-bidi) level instead.

Mon, May 16, 5:27 PM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Editing QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools
Tacsipacsi created T308448: Comment not recognized for no obvious reason.
Mon, May 16, 2:52 PM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Editing QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools

Sat, May 14

Tacsipacsi added a project to T308390: Avoid direct link to edit non-existing talk pages in Minerva : DiscussionTools.

Clicking on that link doesn’t redirect me anywhere. Clicking on the Talk page tab on the item page does (as the link contains action=edit), but it won’t once the New Discussion Tool is introduced on mobile.

Sat, May 14, 11:55 PM · DiscussionTools, MinervaNeue
Tacsipacsi added a parent task for T270537: Introduce New Discussion Tool on mobile: T308390: Avoid direct link to edit non-existing talk pages in Minerva .
Sat, May 14, 11:55 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Patch-For-Review, Mobile, Editing-team (Tracking), DiscussionTools
Tacsipacsi added a subtask for T308390: Avoid direct link to edit non-existing talk pages in Minerva : T270537: Introduce New Discussion Tool on mobile.
Sat, May 14, 11:55 PM · DiscussionTools, MinervaNeue

Fri, May 13

Tacsipacsi added a comment to T308216: New TOC doesn't show when reading the latest stable version of page (FlaggedRevs).

The parameter is read in FlaggablePageView::showingStableByRequest (rEFLR frontend/FlaggablePageView:141-165 (at 331e5101e4fa)). As far as I see, all or most interesting parts are in the same file.

Fri, May 13, 6:19 PM · MediaWiki-extensions-FlaggedRevs, Desktop Improvements
Tacsipacsi added a comment to T308021: Usability Problem: Consider a different visual treatment for the overflow menu on mobile Talk Pages.

The slight drawback of this option is that we would need to reduce the space given to the topic titles which would result in more line breaks with long titles.

You mean it would reduce the space of the topic title’s first line, don’t you? I see no reason for the second and further lines not to fill all horizontal place available, the overflow menu button is not taller than one line. This makes the drawback even slighter.

Fri, May 13, 5:00 PM · Design, Editing-team (FY2021-22 Kanban Board), DiscussionTools

Thu, May 12

Tacsipacsi added a comment to T308200: Remove keyboard shortcut helper text from mobile DiscussionTools dropdowns.

Hm, fair point. We should probably be consistent.

Yes, for sure. While I think the best would be to display the shortcuts everywhere, even consistently not showing them is better than the current inconsistency. (People might think that these shortcuts work only in DiscussionTools and not in regular VE because they appear only there. If the shortcuts don’t appear anywhere, the few people who discover them will probably confidently use them across interfaces.)

Thu, May 12, 8:29 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), Design, DiscussionTools
Tacsipacsi added a comment to T308200: Remove keyboard shortcut helper text from mobile DiscussionTools dropdowns.

Why should they be removed? They work on mobile as well, provided that the device has a Ctrl key. While it’s uncommon, it’s not impossible. For example, my Samsung tablet’s virtual keyboard does have a Ctrl key, and I could toggle bold, italic etc. using it.

Thu, May 12, 12:18 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), Design, DiscussionTools

Tue, May 10

Tacsipacsi added a comment to T308025: Usability Problem: Ensure mobile reply tool is in visual editor mode by default..

On desktop, DiscussionTools defaults to the same mode as normal article editing (as far as I remember). Isn’t this the case on mobile? It may be surprising for usability testers that they get the wikitext editor, but I think real users would be even more surprised if they got different editors by default in the article than on its talk page, since presumably most junior editors use the talk pages before or after attempting to edit the article (which is not the case for usability testers). If most wikis default to the wikitext editor on mobile, maybe that should be changed (together with DiscussionTools), and not DT alone.

Tue, May 10, 7:23 PM · Design, Editing-team (FY2021-22 Kanban Board), DiscussionTools
Tacsipacsi added a comment to T36716: Migrate FlaggedRevs "jsReviewNeedsChange" inline script to use OutputPage::addJsConfigVars.

Instead of moving to mw.config, I’d set an attribute (say data-jsdisabled) on the affected button (#mw-fr-submit-reject). This requires less refactoring and doesn’t pollute mw.config with a piece of information unlikely to be useful for script/gadget authors, or any code outside of this single FlaggedRevs module. It also keeps logically connected pieces of information together.

Tue, May 10, 2:00 PM · good first task, MediaWiki-extensions-FlaggedRevs
Tacsipacsi triaged T307972: Admins & Reviewers can't review revision as Unbreak Now! priority.

Was able to reproduce locally, with the following settings:

$wgFlaggedRevsProtection = true;
$wgFlaggedRevsTags = [
        'accuracy' => [ 'levels' => 2, 'quality' => 20, 'pristine' => 21 ],
];

If I change $wgFlaggedRevsTags['accuracy']['levels'] to 1, it works. It looks like protection mode with non-binary flagging isn’t supported.

Tue, May 10, 11:26 AM · MW-1.39-notes (1.39.0-wmf.10; 2022-05-02), WMDE-TechWish-Sprint-2022-05-11, Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2022-04-27, MediaWiki-extensions-FlaggedRevs

Mon, May 9

Tacsipacsi added a comment to T307824: Determine how the new ToC will handle pages that do not contain higher order sections.

I agree that the page content (i.e. content of #mw-content-text) should be garbage in, garbage out. As I wrote in T306364#7911275, I also think that the TOC output is currently (i.e. without DiscussionTools’ metadata) okay. IMO the only thing you (Web + Editing team) should pay attention to is that DiscussionTools’ metadata appears at the right place even the input is such “garbage”.

Mon, May 9, 11:36 PM · MediaWiki-Parser, Readers-Web-Backlog (Kanbanana-FY-2021-22), DiscussionTools
Tacsipacsi added a comment to T307860: No CentralNotice on Minerva when setting no device category when notice not set for unknown devices.

This task, as a bug report, is invalid: first, banners appear on mobile web when configured so; second, for me the checkboxes are clear. Yes, using the mobile site from a desktop computer counts as unknown, since, as explained on the screenshot, unknown includes all devices using the mobile web that are not iPads, iPhones or Android devices. Desktop/laptop computers are neither of them. (You can technically run Windows or Linux on Android devices after rooting it—as far as I know—, but don’t be surprised if things don’t work how they should in this silly setting…) Feel free to create a new feature request to create a new category for desktops using the mobile version, but I don’t think it’s very important, as using the mobile version on desktop is quite an edge case. (Using the desktop version on mobile is fairly common, but not the other way round.)

Mon, May 9, 2:11 PM · MinervaNeue, MediaWiki-extensions-CentralNotice
Tacsipacsi added a comment to T306141: Alt+Shift+D shortcut should press Skip button, not only giving it focus in Firefox.

Since access keys are not really standardized, it’s maybe an inconsistency rather than a bug from Firefox’ point of view. Also, as far as I remember it wasn’t an issue in December, when Firefox 91 was released in Debian’s APT repo, so it seems more likely for me that a change in Translate broke it rather than a change in Firefox.

Mon, May 9, 12:06 PM · Regression, MediaWiki-extensions-Translate, Browser-Support-Firefox

Sun, May 8

Tacsipacsi added a comment to T305806: Two tvars connected by hyphen-minus are regarded as one tvar.

Probably the best would be to just use exactly the same translation variables as the ones that are actually used when creating the translation page. Since they are parsed when creating the translation page, it should be possible to extract them for the translation helper as well—but this might require quite some engineering to do efficiently.

Sun, May 8, 1:31 PM · MediaWiki-extensions-Translate
Tacsipacsi closed T307860: No CentralNotice on Minerva when setting no device category when notice not set for unknown devices as Invalid.

And it definitely works if configured that way.

Sun, May 8, 12:22 PM · MinervaNeue, MediaWiki-extensions-CentralNotice

Sat, May 7

Tacsipacsi added a comment to T306364: Define treatment for H3 and H4 topics in ToC on talk page.

I think the issue you are raising/question you are posing [i] is better suited for the Web Team considering you are asking about the new ToC's underlying behavior which we are not currently planning for DiscussionTools to affect. Rather, we are planning for DiscussionTools to add information to the version of the ToC the Web Team will be providing.

It depends on what information you expect the Web Team to provide. On its own (i.e. in non-talk namespaces), I don’t think the table of contents’ appearance needs to be changed from how it currently looks like, only the DiscussionTools enhancements should be aware of it. Of course if you expect Vector to provide information on which heading level a given heading is (e.g. ==H2== or ===H3===), and not on how deep it is (e.g. top-level section or subsection), then Vector may also need changes.

Sat, May 7, 11:44 AM · DiscussionTools, Editing-team (FY2021-22 Kanban Board)
Tacsipacsi placed T307824: Determine how the new ToC will handle pages that do not contain higher order sections up for grabs.

The above code snippet is a handcrafted example, and there may not be that pages broken that much, but this Hungarian Wikipedia search highlights some talk pages starting with ===H3===s and ====H4====s. There are probably a lot of false negatives (the search doesn’t allow matching the beginning to the page, so I decided to search for pages that contain no equal signs between the WikiProject template and the first ===H3===, thus for example talk pages without WikiProject templates don’t appear in the results), and also a few false positives, but hopefully this will be enough for basic testing. The only talk page of these that contains ===H3=== both before the first ==H2== (which counts as a top-level section) and after it (which counts as a subsection) is Vita:Magyarországi Református Egyház, so you may want to start experimenting with that. (By the way, this page is totally messed up, so it may provide examples for several edge cases for the Editing team as well. 😀)

Sat, May 7, 11:44 AM · MediaWiki-Parser, Readers-Web-Backlog (Kanbanana-FY-2021-22), DiscussionTools

Fri, May 6

Tacsipacsi added a parent task for T73966: Show categories of a page in the Android app: T307785: Show parent categories in the Android app.
Fri, May 6, 1:11 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22), Mobile, Community-Wishlist-Survey-2016
Tacsipacsi added a subtask for T307785: Show parent categories in the Android app: T73966: Show categories of a page in the Android app.
Fri, May 6, 1:11 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22), Community-Wishlist-Survey-2016
Tacsipacsi created T307785: Show parent categories in the Android app.
Fri, May 6, 1:11 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22), Community-Wishlist-Survey-2016
Tacsipacsi added a comment to T307715: Freshness indicator should appear aligned with the Talk Page title.

This is how contentSub is presented on Vector (and Monobook and Modern; on the other hand, Minerva, Timeless and Cologne Blue have no indentation). I don’t think it looks bad, but if it’s changed, it should be changed in Vector, not in DiscussionTools, otherwise it’d get unaligned with other contentSub elements like breadcrumbs.

Fri, May 6, 11:57 AM · Editing-team, Design, DiscussionTools
Tacsipacsi renamed T307709: Remove icon from warning message in mobile view from Remove icon from error message in mobile view to Remove icon from warning message in mobile view.
Fri, May 6, 8:49 AM · Editing-team (FY2021-22 Kanban Board), DiscussionTools
Tacsipacsi updated the task description for T307642: [SPIKE] Decide on approach to inconsistencies between titles of talk pages and associated action pages.
Fri, May 6, 8:49 AM · Design, Editing-team (FY2021-22 Kanban Board), DiscussionTools, OWC2020

Thu, May 5

Tacsipacsi added a comment to T73966: Show categories of a page in the Android app.

Nice! However: I can see categories of an article, pages and subcategories in a category, but I can’t see categories of a category (i.e. parent categories). It’s strange that I can navigate in the category tree only in one direction (except for pressing the back button), as the category tree is not actually a tree in graph theory sense, usually only a directed acyclic graph (but sometimes not even that, e.g. en:Category:Hidden categories is a subcategory of itself). A category usually has more than one parent categories, of which only one can be reached: the one that I’ve already seen. Is there a task to show parent categories in the category view? If there isn’t, I think one should be created.

Thu, May 5, 4:54 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22), Mobile, Community-Wishlist-Survey-2016

Wed, May 4

Tacsipacsi added a comment to T293470: Easier language switching from Main page.

When you added the subtasks, I looked into them, and realized that special-casing the main page is actually not that great idea. Instead I prefer making Gadgets capable of loading an (in this case, CSS-only) gadget only on certain pages (I prefer T241524, but that’s not the only way to solve the problem). First, it’s a more general solution, solving much more problems and thus creating less technical debt; second, a page title hardcoded in software code means that those rules apply only on that one page, and not for example in yesterday’s main page, tomorrow’s main page, sandbox main page etc. There’s no staging environment, if one makes a mistake, it’s the main page which is broken.

Wed, May 4, 8:10 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), User-notice, Desktop Improvements
Tacsipacsi added a comment to T300560: Design persistent notification for when new comments are posted while drafting a reply.

To keep it as short as possible, using an ✖ instead of “Dismiss” is probably better, but I don’t like the two bubbles. What about using an icon and @Esanders’ text version, but having one (divided) bar, like in your first exploration?

Wed, May 4, 7:54 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Editing QA, Design, Editing-team (FY2021-22 Kanban Board), Goal, DiscussionTools
Tacsipacsi added a comment to T306730: [SPIKE] What skins will the Editing Team ensure Usability Improvements support?.

Task description updated.

Wed, May 4, 7:50 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools
Tacsipacsi added a comment to T306364: Define treatment for H3 and H4 topics in ToC on talk page.

No, I was referring to not whether, but how, the =H1=s should be included. And actually it’s even more complicated, as ===H3===s (and lower-level headings) not preceded by higher-level ones appear as top-level entries in the table of contents. For example,

=== Subheading ===
Lorem ipsum.
Wed, May 4, 7:50 PM · DiscussionTools, Editing-team (FY2021-22 Kanban Board)
Tacsipacsi added a project to T184941: Babel AutoCreate creating empty categories (already on page preview): MediaWiki-Parser.

This should have been fixed in T42159 (September 2012), but apparently either it wasn’t, or it regressed. Looking at the code, this thing didn’t change much in Babel in the last almost ten years, so it may be a core thing.

Wed, May 4, 1:16 AM · MediaWiki-Parser, MediaWiki-extensions-Babel

Tue, May 3

Tacsipacsi added a project to T307348: Enable Kartographer <mapframe> tag on remaining FlaggedRevision page-stabilized wikis: Hungarian-Sites.
Tue, May 3, 4:04 PM · Hungarian-Sites, Maps (Kartographer), WMDE-TechWish, WMDE-GeoInfo-FocusArea

Mon, May 2

Tacsipacsi added a comment to T295514: Score audio uses different players depending on whether the page has other embedded media.

This is a separate issue (and should be filed separately). The player loading broke when we switched the audio mode of videojs to become an inline loaded element.

Mon, May 2, 1:02 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), TimedMediaHandler, MediaWiki-extensions-Score
Tacsipacsi added a comment to T306836: Score audio players processed by videoJS are invisible.

It looks good but now it looks like this:

image.png (232×646 px, 17 KB)

We need to probably find a way to make it be display: block instead of inline-block for this specific usecase

Mon, May 2, 1:01 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), VideoJS player
Tacsipacsi reopened T307286: Allow users to browse the page when using VideoJS Player as "Open".

This task may be considered as a duplicate of T303387, but certainly not of T304723. This task is about audio files opening in a modal window (in case there are subtitles), while T304723 is about the progress bar opening in a modal-like way when the actual player won’t be modal (in case there are no subtitles). Since the progress bar appears only for a few seconds, I think files I considered “buggy” (not really a bug, rather just a minor annoyance) in T304723, are actually the ones that are fixed from this task’s point of view.

Mon, May 2, 12:40 PM · VideoJS player
Tacsipacsi added a comment to T290322: Parameter auto-detection picks up other syntax elements.

It appears like attempting to use a parameter like {{{a=b}}} in a template is valid syntax. But it's impossible to call this parameter.

Actually, it’s possible. Either by including a template in the parameter name (e.g. {{test|a{{=}}b=x}}, where Template:= contains a single equal sign), or for example using Scribunto—its expandTemplate takes its parameter as a Lua table, thus there’s no ambiguity, and frame:expandTemplate{ title = 'Test', args = { ['a=b'] = 'x' } } does return x if Template:Test’s content is {{{a=b}}}. However, it’s not less insane as putting newlines or braces in template names, so I agree that such parameter-like things shouldn’t be auto-detected as parameters, false positives are way more likely than true positives.

Mon, May 2, 12:27 PM · MW-1.38-notes (1.38.0-wmf.4; 2021-10-12), VisualEditor, User-thiemowmde, TemplateData
Tacsipacsi created T307350: Unexpected error message when the title passed to expandTemplate gets redirected by another extension.
Mon, May 2, 12:13 PM · MediaWiki-extensions-Scribunto

Sun, May 1

Tacsipacsi added a comment to T69486: Links: Add support for self-links to Parsoid.
  1. Alternatively, we could consider making self-link marking an extension, like the Disambiguator extension. No strong compelling reason here, other than to exercise the existing color hook and keep the Parsoid core as small as possible. While we're at it, we could probably make redlink marking an extension as well! That could reduce the size of Parsoid's data access API, and it would provide a good case study/example for a simple "post processing pass extension".

Marking red and self-links seems to be a pretty core thing of MediaWiki, so please don’t let system administrators have to enable them explicitly. If you think of a piece of code within the MediaWiki core repository that behaves somewhat like an extension but is loaded implicitly (and preferably doesn’t show up on Special:Version), it’s okay, but it should remain part of core from system administrators’ point of view.

Sun, May 1, 2:14 PM · Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Growth-Team-Filtering, Parsoid-Rendering, Growth-Team, StructuredDiscussions, Parsoid

Thu, Apr 28

Tacsipacsi added a comment to T304363: Remove message boxes with IDs in core.
  1. For the basic information in Tech News (I.e. readers thinking "do I need to look any further?") I imagine something like this is accurate and clear, but I need a confirmation or improvements, before I'll add it to the draft:

Several CSS IDs related to MediaWiki interface messages will be removed. Script developers should please review the list of IDs and links to their existing uses. These include #mw-anon-edit-warning, #mw-undelete-revision and 3 others.

Not only JavaScript (“script authors”) is affected, but also CSS—actually, as far as I remember (global search seems to be down right now), the majority of affected pages is CSS. I don’t have an idea how to communicate this briefly but precisely, though.

Thu, Apr 28, 9:54 PM · User-notice, Patch-For-Review, Platform Team Initiatives (MCR), MediaWiki-Page-editing, patch-welcome, good first task, MediaWiki-Core-Skin-Architecture, UI-Standardization
Tacsipacsi added a comment to T240364: Display previous edit summaries.

I also noticed another minor issue with longer dates. Firefox (99.0.1) on Linux on a 1920x1080 screen.

Actually this is already an improved situation. 🙂 See my comment a week ago.

Thu, Apr 28, 2:10 PM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Language-Team (Language-2022-April-June), Design, MediaWiki-extensions-Translate

Wed, Apr 27

Tacsipacsi added a comment to T299814: Create design concepts for clearer talking affordances and page frame.

Firefox ESR on Debian 10. According to the font inspector, the sans-serif font is DejaVu Sans Bold, the serif is Linux Libertine O. I did play a bit with my font settings (years ago), but I think these two happen to be the defaults.

Wed, Apr 27, 6:04 PM · Goal, Editing-team (FY2021-22 Kanban Board), Editing Design, DiscussionTools, OWC2020
Tacsipacsi edited projects for T191697: Deploy PageAssessments to Hungarian Wikipedia, added: Hungarian-Sites; removed Patch-For-Review.
Wed, Apr 27, 11:33 AM · Hungarian-Sites, MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Community-Tech, MediaWiki-extensions-PageAssessments
Tacsipacsi changed the subtype of T173485: HuWiki's RSS feed doesn't update from "Task" to "Bug Report".
Wed, Apr 27, 11:19 AM · Hungarian-Sites, WMF-General-or-Unknown, MediaWiki-extensions-FeaturedFeeds
Tacsipacsi added a comment to T240364: Display previous edit summaries.

It doesn’t look strange for me (otherwise I wouldn’t have proposed it 🙂). Skipping just the links (i.e. not the link texts) may also be an option, however it’s still not trivial: what should the text be? If there are three consecutive edits without summaries, one from a year ago, one from yesterday, and one from ten minutes ago, what should appear? If we pick any one timestamp, it’d be inaccurate, if we display the whole range (e.g. “1 year ago – 10 minutes ago”), it’d break the layout, which expects the timestamp to be relatively short.

Wed, Apr 27, 10:12 AM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Language-Team (Language-2022-April-June), Design, MediaWiki-extensions-Translate
Tacsipacsi added a comment to T304363: Remove message boxes with IDs in core.

Why should it be merged today to get on the train departing in 12 days? If it’s merged by May 10, 01:00 UTC, it still catches the same train. However, the Tech News note should be released ASAP (i.e. in the May 2 issue) to give communities as much time to prepare as possible.

Wed, Apr 27, 8:53 AM · User-notice, Patch-For-Review, Platform Team Initiatives (MCR), MediaWiki-Page-editing, patch-welcome, good first task, MediaWiki-Core-Skin-Architecture, UI-Standardization

Tue, Apr 26

Tacsipacsi added a comment to T299814: Create design concepts for clearer talking affordances and page frame.

@Quiddity regarding search, I'm seeing two different sets of results depending on whether or not a space is there:

Tue, Apr 26, 10:23 PM · Goal, Editing-team (FY2021-22 Kanban Board), Editing Design, DiscussionTools, OWC2020
Tacsipacsi added a comment to T240364: Display previous edit summaries.

The page history link is also confusing IMO. Why not just drop those links? Edits without summaries aren’t important here anyway.

Tue, Apr 26, 9:10 PM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Language-Team (Language-2022-April-June), Design, MediaWiki-extensions-Translate
Tacsipacsi changed the subtype of T306793: Double magnifying glass in the search bar from "Feature Request" to "Bug Report".

This is a bug, not a feature request. The interface appearing correctly is not a feature, it should be self-evident basics… That said, I couldn’t reproduce it in desktop Firefox, not even with new Vector, so the extra magnifying glass should be WebKit’s feature, not new Vector’s. I also wonder whether enabling new Vector is really necessary to reproduce it, or legacy Vector (or even other skins like Timeless) also look wrong.

Tue, Apr 26, 8:58 PM · Browser-Support-Apple-Safari, MediaWiki-extensions-Translate
Tacsipacsi renamed T306793: Double magnifying glass in the search bar from Doubled loop in the search bar to Double magnifying glass in the search bar.
Tue, Apr 26, 8:58 PM · Browser-Support-Apple-Safari, MediaWiki-extensions-Translate

Mon, Apr 25

Tacsipacsi added a comment to T306764: Substituting a page removed from translation should not substitute remaining translation page in source language.

Adding the <translate> tag did the trick. The only thing left here is to find and fix the bug. 🙂

Mon, Apr 25, 6:54 PM · MediaWiki-Templates, MediaWiki-extensions-Translate
Tacsipacsi added a comment to T306364: Define treatment for H3 and H4 topics in ToC on talk page.

I don’t see any decision on <h1>s. While that issue could be split off into a separate task so that this one is really only about what’s in the title, I think it naturally fits here.

Mon, Apr 25, 6:48 PM · DiscussionTools, Editing-team (FY2021-22 Kanban Board)
Tacsipacsi added a comment to T78418: Introduce MediaWiki:Mainpage.css.

Most of the styling should be done using TemplateStyles. The rest (e.g. styles affecting the page title) can be put in a gadget once T241524 is done (which is not bound to the main page, so the necessary styles can be loaded on localized main pages, yesterday/tomorrow pages, sandboxes and the like as well).

Mon, Apr 25, 6:16 PM · Performance-Team, Technical-Debt, MediaWiki-ResourceLoader
Tacsipacsi added a comment to T304363: Remove message boxes with IDs in core.

I think most of the work here is replacing on-wiki usage, the changes in code seem to be pretty straightforward, I’m sure there will be someone to do it. (Maybe me.) It’s not without precedent that changes are announced in Tech News months in advance, without an exact timeline yet, and then announced again right before the change as a heads-up. (If it has been announced before, it’s fine if the heads-up announcement appears in Tech News on Monday of the week it rides the train.)

Mon, Apr 25, 5:52 PM · User-notice, Patch-For-Review, Platform Team Initiatives (MCR), MediaWiki-Page-editing, patch-welcome, good first task, MediaWiki-Core-Skin-Architecture, UI-Standardization
Tacsipacsi added a comment to T248418: Roll out videojs as the only video/audio player on all Wikimedia wikis.

First, it’s not Score’s fault that TMH’s JavaScript tries to catch up a valid and working HTML element and breaks on it; if it can’t handle HTML output by third parties (which is not only Score, I’m pretty sure there are other extensions outputting <audio>), it shouldn’t try to do so (or at least it should fail gracefully, leaving the page intact in case it breaks). If TMH’s maintainers cannot fix a bug in Video.js, then Video.js shouldn’t be deployed.

Mon, Apr 25, 5:27 PM · User-Ladsgroup, Patch-For-Review, Readers-Web-Backlog, User-notice, Wikimedia-Site-requests, VideoJS player, Performance-Team (Radar), Multimedia, Wikimedia-Video
Tacsipacsi changed the subtype of T224810: Magic word to embed the translation language from "Task" to "Feature Request".
Mon, Apr 25, 4:40 PM · MediaWiki-extensions-Translate
Tacsipacsi added a comment to T306764: Substituting a page removed from translation should not substitute remaining translation page in source language.

Couldn’t reproduce locally. Maybe a caching issue?

Mon, Apr 25, 8:44 AM · MediaWiki-Templates, MediaWiki-extensions-Translate

Sun, Apr 24

Tacsipacsi added a comment to T258925: Do not warn about missing function doc comment when parameter and return types are fully specified by type hints.

Either we should require human-readable description for methods / parameters, or not require the doc block at all when the types are already fully specified.

I think both should be possible, probably the latter by default and the former as an opt-in sniff (if that’s possible?). Documenting beyond types is also important, especially on public interfaces—@param documentation should describe what the parameters mean (if it’s not obvious based on the type+parameter name, like @param string $input HTML-escaped input), @return documentation should document things that cannot be expressed in types (e.g. @return string[] [raw text, HTML-escaped text]) and both should point at edge cases (e.g. @return ?string The user input if it’s HTML-safe, null otherwise). Of course this is a burden and most people are just too lazy to do it (therefore only opt-in), but if a developer/team decides to require it, let them have a tool to enforce.

Sun, Apr 24, 6:06 PM · MediaWiki-Codesniffer
Tacsipacsi added a comment to T248418: Roll out videojs as the only video/audio player on all Wikimedia wikis.

This shouldn’t move further (or maybe even rolled back) until T295514 is fixed.

Sun, Apr 24, 3:57 PM · User-Ladsgroup, Patch-For-Review, Readers-Web-Backlog, User-notice, Wikimedia-Site-requests, VideoJS player, Performance-Team (Radar), Multimedia, Wikimedia-Video
Tacsipacsi added a comment to T295514: Score audio uses different players depending on whether the page has other embedded media.

I thought this has long been fixed. In the score+media case Score’s audio output simply disappears, making it impossible to play it. Since Video.js is already default on some wikis (which shouldn’t have happened without this bug being fixed, by the way), this should be fixed ASAP—either fix it really, or roll back everything to Kaltura, which is also inconsistent, but at least works (Kaltura provides a working UI for Score’s output). As a production example, https://fr.wikipedia.org/wiki/Chaconne_en_r%C3%A9_mineur_(Pachelbel) contains a score that should have MP3 output, but it disappears.

Sun, Apr 24, 3:55 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), TimedMediaHandler, MediaWiki-extensions-Score
Tacsipacsi added a subtask for T248418: Roll out videojs as the only video/audio player on all Wikimedia wikis: T295514: Score audio uses different players depending on whether the page has other embedded media.
Sun, Apr 24, 3:55 PM · User-Ladsgroup, Patch-For-Review, Readers-Web-Backlog, User-notice, Wikimedia-Site-requests, VideoJS player, Performance-Team (Radar), Multimedia, Wikimedia-Video
Tacsipacsi added a parent task for T295514: Score audio uses different players depending on whether the page has other embedded media: T248418: Roll out videojs as the only video/audio player on all Wikimedia wikis.
Sun, Apr 24, 3:54 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), TimedMediaHandler, MediaWiki-extensions-Score
Tacsipacsi updated the task description for T3954: <playlist> tag for audio playlists.
Sun, Apr 24, 3:29 PM · TimedMediaHandler, MediaWiki-extension-requests
Tacsipacsi closed T150127: Improve TimedMediaHandler git repo layout as Resolved.

Done by @Jdforrester-WMF in 3467d7214dc9e48b89ec2521571ffc171e8216cf.

Sun, Apr 24, 2:47 PM · TimedMediaHandler
Tacsipacsi added a comment to T230471: TMH audio player missing for clips inside <indicator> .

There is a way around this now. Add the following to Common.js:

	mw.hook( 'wikipage.indicators' ).add( function ( $content ) {
		$content.find( 'video, audio' ).loadVideoPlayer();
	} );
Sun, Apr 24, 2:26 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), VideoJS player, MediaWiki-Interface
Tacsipacsi updated subscribers of T306758: Media files on betacommons are not transcoding.

@Reedy How does this relate to T306697?

Sun, Apr 24, 1:14 PM · Beta-Cluster-Infrastructure, TimedMediaHandler-Transcode, Wikimedia-Video

Sat, Apr 23

Tacsipacsi added a comment to T227195: File description info button is useless for Score.

Since cf8a4f2133cb6a0f9fa4266ed93acea4f0729667, Score doesn’t use TMH anymore. Is it planned to use it again in the future, or can this task be declined?

Sat, Apr 23, 6:29 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), VideoJS player, MediaWiki-extensions-Score
Tacsipacsi added a comment to T306730: [SPIKE] What skins will the Editing Team ensure Usability Improvements support?.

Thanks @ppelberg, this looks much better (with @Esanders’ comment). However, I’d write “any other skins” instead of listing each skin—there are actually much more skins, just most skins aren’t installed on Wikimedia wikis. While using DiscussionTools outside of Wikimedia is not yet supported, I very much hope that it’ll be one day, and then it’d be good to be clear about third-party skins’ support status. Wikimedia wikis could also get new skins in the future, so if this support table will apply in the maintenance phase as well, those can also cause “holes” in support status.

Sat, Apr 23, 4:46 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools
Tacsipacsi updated the task description for T3605: [[Section::...]] variables.
Sat, Apr 23, 10:12 AM · Parsoid, Patch-For-Review, MediaWiki-extension-requests

Fri, Apr 22

Tacsipacsi changed the subtype of T15303: Implement HTML e-mail support in MediaWiki from "Task" to "Feature Request".
Fri, Apr 22, 8:18 PM · Outreach-Programs-Projects, MediaWiki-Email
Tacsipacsi added a comment to T306716: Watchlist email notifications not parsing full page url.

Watchlist notification emails are plain text, so it’s up to the user’s email software to convert URLs into links. Some email software are better, some are worse, some may not convert URLs into links at all. Until we have HTML support (T15303), I don’t think there’s much we can do about it (except for asking the user to use a different email program, but that’s not nice…).

Fri, Apr 22, 8:17 PM · MediaWiki-Email
Tacsipacsi added a comment to T306711: OgvJs crashes with syntax error on IE11.

This particular file has contained ES6 arrow syntax since d05543b61253fe358e243f75d488d91c95113e06 (September 2021), so either it’s been broken for months without anyone noticing, or something else broke it.

Fri, Apr 22, 8:03 PM · Browser-Support-Internet-Explorer, VideoJS player, ogv.js
Tacsipacsi added a comment to T306675: Reconcile conflict between latest comment indicator and siteSub message.

siteSub is for the tagline and only for the tagline. Additional information like breadcrumbs, FlaggedRevs indicators or the Wikidata description gadget go in contentSub, and DiscussionTools’ metadata should also do so (using OutputPage::addSubtitle). contentSub can contain multiple elements, so there’s no conflict.

Fri, Apr 22, 12:18 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools
Tacsipacsi added a comment to T305220: Enable people to add a summary within Topic Containers.

I thought the main purpose of this task is to provide a way to create and edit the summaries easily, not to provide a specific presentation (although a default presentation should be provided, of course, for small wikis). Simply a customization point doesn’t make it a purely on-wiki community project, because

  • there should be a default behavior, specified in DiscussionTools, not on wiki, and
  • the behavior (affordances to create and edit the summary) should stay in DiscussionTools.
Fri, Apr 22, 9:41 AM · DiscussionTools

Thu, Apr 21

Tacsipacsi added a comment to T293470: Easier language switching from Main page.

Where is there a functioning example of version 2, and how does it serve users without JavaScript enabled?
doesn’t work for me—there’s no event handler attached, so nothing happens when I click it.

Presumably you have this preference disabled:

Screen Shot 2022-04-20 at 7.05.38 PM.png (268×1 px, 39 KB)

I was sure I mentioned it, but I seem to have removed this information when I rephrased my comment for the n’th time: I was logged out. I have an account on beta cluster, but I’m just too lazy to try to remember its password… This means that all preferences should be at their defaults. I assumed compact language links are on by default everywhere on Wikimedia wikis, including beta cluster, but now I clicked on the language selector provided by the skin, and I got the non-ULS list indeed. Do you know why is this preference off on beta English Wikipedia, and whether it still needs to be off?

Thu, Apr 21, 11:06 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), User-notice, Desktop Improvements
Tacsipacsi added a comment to T240364: Display previous edit summaries.
  • Section is labelled as "Latest updates" to avoid creating n expectation of changes being recent.

Thanks, that sounds good to me as well.

Thu, Apr 21, 6:25 PM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Language-Team (Language-2022-April-June), Design, MediaWiki-extensions-Translate

Apr 21 2022

Tacsipacsi added a comment to T293470: Easier language switching from Main page.

@Tacsipacsi yeh that would work too. The class just needs to be present, doesn't matter if it's on the link or not. Check out https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Template:LanguageButton for example (shown on bottom of https://en.wikipedia.beta.wmflabs.org/)

Apr 21 2022, 12:24 AM · Readers-Web-Backlog (Kanbanana-FY-2021-22), MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), User-notice, Desktop Improvements
Tacsipacsi added a comment to T304363: Remove message boxes with IDs in core.
  • When the code is merged, we should add the User-notice tag to make clear these IDs have been removed.

I think it should be in Tech News before getting merged. #mw-anon-edit-warning has been around for almost 1.5 decades (since 7af20970abc), let’s give people a chance to fix usages before they break.

Apr 21 2022, 12:15 AM · User-notice, Patch-For-Review, Platform Team Initiatives (MCR), MediaWiki-Page-editing, patch-welcome, good first task, MediaWiki-Core-Skin-Architecture, UI-Standardization
Tacsipacsi updated the task description for T304363: Remove message boxes with IDs in core.
Apr 21 2022, 12:14 AM · User-notice, Patch-For-Review, Platform Team Initiatives (MCR), MediaWiki-Page-editing, patch-welcome, good first task, MediaWiki-Core-Skin-Architecture, UI-Standardization

Apr 20 2022

Tacsipacsi added a comment to T306364: Define treatment for H3 and H4 topics in ToC on talk page.

There are also discussion pages that contain <h1>s, for example hu:Wikipédia:Bürokraták üzenőfala. Here the old TOC presents <h1>s like how it presents <h2>s on other pages and <h2>s like <h3>s. However, the topics are still the <h2>s, so the activity metadata should be displayed there, not at the TOC’s top level (the <h1>s). (Actually the reason to use <h1>s is exactly that topics created with the (legacy, full-page) New topic affordance should be subsections of these general sections, even though this violates HTML semantic markup rules by having multiple <h1>s on the page.)

Apr 20 2022, 11:41 PM · DiscussionTools, Editing-team (FY2021-22 Kanban Board)
Tacsipacsi added a comment to T306257: Special:PageTranslation should not output one message box per invalid unit ID.

No problem. Actually maybe I was the only one to be really annoyed by this (who else would have a page with dozens of incorrect message keys years after they were banned?), so I fixed it for myself, and I thank you for reviewing and QAing it. 🙂

Apr 20 2022, 10:36 PM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Language-Team (Language-2022-April-June), MediaWiki-extensions-Translate
Tacsipacsi added a comment to T306528: Unify (un)deletion success message when the subject and talk page are (un)deleted together.

I was referring to the message appearing on the action=delete page, not the actual logs. Logging two deletions with two log entries is totally okay and actually better (logs are connected to page titles, so if there was only one log message, either the talk page or the content page didn’t have a log message, which would be very confusing).

Apr 20 2022, 5:20 PM · Community-Tech, Undelete-Associated-Talk-Page (2021)
Tacsipacsi added a comment to T306484: Make it easier to develop a high-level understanding of what is being discussed.

Beside thread collapsing/expanding, (and maybe comment/reply counting) being able to provide summaries might also be a good thing to consider.

Apr 20 2022, 8:26 AM · Design, DiscussionTools
Tacsipacsi renamed T305220: Enable people to add a summary within Topic Containers from Enable people to add a summary within Topic Containers to Enable people to add a summary within Topic Containers.
Apr 20 2022, 8:26 AM · DiscussionTools
Tacsipacsi added a comment to T293470: Easier language switching from Main page.

You can add the HTML <a class="mw-interlanguage-selector" href="#mp-lang">Read in another language</a> to your template and that will be automatically enhanced by the UniversalLanguageSelector. I presume that any of those templates in the description could be made using this technique, but I haven't explored it myself so I'd be interested to know if that's not the case. None of these templates exist at time of writing to my knowledge.

Apr 20 2022, 12:13 AM · Readers-Web-Backlog (Kanbanana-FY-2021-22), MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), User-notice, Desktop Improvements

Apr 19 2022

Tacsipacsi added a project to T249394: Deploy Reply Tool as opt-out Preference at the Arabic, Czech and Hungarian Wikipedias: Hungarian-Sites.
Apr 19 2022, 12:11 PM · Hungarian-Sites, Verified, Editing-team (FY2021-22 Kanban Board), OWC2020 (Reply Tool Opt Out), DiscussionTools

Apr 18 2022

Tacsipacsi added a comment to T306233: Translation memory does not display anymore.

Is it possible to backport this? If it’s backported today, maybe there’s enough information to find the real bug and let the fix ride the train this week.

Apr 18 2022, 1:44 PM · Unplanned-Sprint-Work, MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Language-Team (Language-2022-April-June), Regression, MediaWiki-extensions-Translate

Apr 17 2022

Tacsipacsi changed the subtype of T199126: Scribunto/Lua should have a built-in method for retrieving category members from "Task" to "Feature Request".
Apr 17 2022, 4:31 PM · MediaWiki-extensions-Scribunto

Apr 16 2022

Tacsipacsi renamed T305604: Cannot edit non-mainspace pages in Android app from Cannot edit Navbox template in Android mobile app to Cannot edit non-mainspace pages in Android app.
Apr 16 2022, 4:50 PM · Wikipedia-Android-App-Backlog (Android Release FY2021-22)