Page MenuHomePhabricator

Tam-edwin-microsoft (EdwinTam-MSFT)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 26 2019, 8:13 PM (121 w, 5 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Tam-edwin-microsoft [ Global Accounts ]

Recent Activity

Dec 19 2020

Tam-edwin-microsoft added a comment to T253417: Show/Hide description buttons are not accessible by keyboard.

There was a 2nd patch in this task that is still pending
https://gerrit.wikimedia.org/r/598116

Dec 19 2020, 8:04 AM · Growth-Team-Filtering, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Patch-For-Review, Accessibility, Growth-Team, StructuredDiscussions
Tam-edwin-microsoft added a comment to T260156: PopupToolGroup cannot be accessed by Keyboard unless PopupWidget is opened.

Just want to double check on the status of this patch. Looks like it's still pending review. Thanks!

Dec 19 2020, 7:48 AM · Patch-For-Review, OOUI

Sep 2 2020

Tam-edwin-microsoft updated subscribers of T260519: ToggleSwitchWidget: widget has wrong role 'checkbox' when it should be 'switch'.

@Volker_E merged the original patch with suggestion. Is there a need to link a separate item to track this feedback or is just documenting here enough?

Sep 2 2020, 6:56 AM · OOUI (OOUI-0.40.3), Accessibility

Aug 20 2020

Tam-edwin-microsoft added a comment to T256492: WindowsAzureStorage Extension - extension need to use latest Azure storage blob sdk..

Just wondering what is the usual procedure to handle patches for an orphaned extension like this?

Aug 20 2020, 2:26 AM · MediaWiki-extensions-Other

Aug 17 2020

Tam-edwin-microsoft closed T260505: Echo-SpecialHelpMenuWidget aria-label message not declared in extension.json as Resolved.
Aug 17 2020, 4:07 PM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), Growth-Team, Notifications
Tam-edwin-microsoft created T260519: ToggleSwitchWidget: widget has wrong role 'checkbox' when it should be 'switch'.
Aug 17 2020, 9:26 AM · OOUI (OOUI-0.40.3), Accessibility
Tam-edwin-microsoft added a comment to T260505: Echo-SpecialHelpMenuWidget aria-label message not declared in extension.json.

Just found out the old Phabricator task T244543 that the original patch was fixing had multiple issues and is still open.
Sorry for opening a duplicate Task

Aug 17 2020, 6:35 AM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), Growth-Team, Notifications
Tam-edwin-microsoft updated the task description for T244543: Ensures every ARIA input field has an accessible name.
Aug 17 2020, 6:33 AM · Growth-Team-Filtering, Patch-For-Review, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Accessibility, Growth-Team, Notifications
Tam-edwin-microsoft updated the task description for T244543: Ensures every ARIA input field has an accessible name.
Aug 17 2020, 6:32 AM · Growth-Team-Filtering, Patch-For-Review, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Accessibility, Growth-Team, Notifications
Tam-edwin-microsoft created T260505: Echo-SpecialHelpMenuWidget aria-label message not declared in extension.json.
Aug 17 2020, 2:35 AM · MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), Growth-Team, Notifications

Aug 12 2020

Tam-edwin-microsoft updated subscribers of T257269: Focus change on selecting item of booklet layout.

@Volker_E I am trying to re-run the main test build for this patch as the test result expired. "recheck" doesn't seem to work, can you help me re-run the test? Thanks!

Aug 12 2020, 5:02 PM · Patch-For-Review, Accessibility, OOUI

Aug 11 2020

Tam-edwin-microsoft renamed T260156: PopupToolGroup cannot be accessed by Keyboard unless PopupWidget is opened from Popup ToolGroup cannot be accessed by Keyboard unless PopupWidget is opened to PopupToolGroup cannot be accessed by Keyboard unless PopupWidget is opened.
Aug 11 2020, 4:25 PM · Patch-For-Review, OOUI
Tam-edwin-microsoft created T260156: PopupToolGroup cannot be accessed by Keyboard unless PopupWidget is opened.
Aug 11 2020, 3:48 PM · Patch-For-Review, OOUI

Aug 7 2020

Tam-edwin-microsoft created T259912: Keyboard Tabbing Order for PopupWidget in Reverse(shift-tabbing) is out-of-order.
Aug 7 2020, 6:48 PM · OOUI (OOUI-0.40.3)

Jul 14 2020

Tam-edwin-microsoft updated the task description for T247043: HTMLCheckboxMatrix (Preference -> Notifications must have label).
Jul 14 2020, 2:57 AM · Patch-For-Review, Accessibility, MediaWiki-User-preferences

Jul 10 2020

Tam-edwin-microsoft added a comment to T257165: OOUI PopupWidget : need to Notify caller when popup widget closes.

Awesome, thanks a lot @Volker_E! I have tagged a couple patches on the mediawiki side that use the new popup events for review. T257171 T257173 and T257175

Jul 10 2020, 6:18 PM · OOUI (OOUI-0.39.3), Accessibility
Tam-edwin-microsoft added a comment to T257165: OOUI PopupWidget : need to Notify caller when popup widget closes.

Hi, I just want to confirm if this T257165 and T257167 will make MW 1.35 next week.
Because I see in Gerrit the v0.39.3 tag happened on July 08 while the actual merge of the patches happened later on July 09

Jul 10 2020, 2:50 AM · OOUI (OOUI-0.39.3), Accessibility

Jul 9 2020

Tam-edwin-microsoft claimed T245899: Fix missing name(aria-label) in Images - Gallery.
Jul 9 2020, 4:56 AM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Skipped QA, Editing-team (FY2021-22 Kanban Board), Accessibility, VisualEditor
Tam-edwin-microsoft added a comment to T245899: Fix missing name(aria-label) in Images - Gallery.

Per Bartosz's comment in patch 574581 to move the change from VisualEditor to Mediawiki/core
I have uploaded the above new patch 610581

Jul 9 2020, 4:50 AM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Skipped QA, Editing-team (FY2021-22 Kanban Board), Accessibility, VisualEditor
Tam-edwin-microsoft added a comment to T257385: Window: focus lost when navigating with shift + tab key.

That's too bad. If there's a chance of to get T257165 in that would be great, there are a few patches on the Mediawiki side that has a dependency on that patch. T257167 on the OOUI side also is depending on that patch.
If it doesn't happen, we understand.

Jul 9 2020, 2:00 AM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), OOUI (OOUI-0.39.3), Accessibility

Jul 8 2020

Tam-edwin-microsoft updated subscribers of T257385: Window: focus lost when navigating with shift + tab key.

@Volker_E what is the cadence for integration of OOUI into MediaWiki? when is the last drop before the 1.35 branch fork?
Thanks

Jul 8 2020, 11:01 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), OOUI (OOUI-0.39.3), Accessibility
Tam-edwin-microsoft claimed T247043: HTMLCheckboxMatrix (Preference -> Notifications must have label).
Jul 8 2020, 10:11 AM · Patch-For-Review, Accessibility, MediaWiki-User-preferences
Tam-edwin-microsoft added a comment to T247043: HTMLCheckboxMatrix (Preference -> Notifications must have label).

Hi just want to follow up and see if we can get a set of eyes for this patch.
Thanks!

Jul 8 2020, 10:10 AM · Patch-For-Review, Accessibility, MediaWiki-User-preferences

Jul 6 2020

Tam-edwin-microsoft created T257177: Visual Editor: Help Popup close button does not have name property.
Jul 6 2020, 5:12 AM · OOUI (OOUI-0.39.3), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Accessibility
Tam-edwin-microsoft created T257175: Visual Editor - Help (?) Popup Widget is not accessible.
Jul 6 2020, 3:34 AM · User-Ryasmeen, Skipped QA, Editing-team (FY2021-22 Kanban Board), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Accessibility, VisualEditor
Tam-edwin-microsoft created T257173: VisualEditior - Added Category Popup in Page Options is not accessible.
Jul 6 2020, 2:32 AM · User-Ryasmeen, Skipped QA, Editing-team (FY2021-22 Kanban Board), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Accessibility, VisualEditor
Tam-edwin-microsoft claimed T257171: Watchlist popup dialog for changes and date limit button is clicked is not accessible.
Jul 6 2020, 1:51 AM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Accessibility, MediaWiki-Watchlist, Growth-Team
Tam-edwin-microsoft created T257171: Watchlist popup dialog for changes and date limit button is clicked is not accessible.
Jul 6 2020, 1:50 AM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Accessibility, MediaWiki-Watchlist, Growth-Team

Jul 5 2020

Tam-edwin-microsoft updated the task description for T257167: Narrator not announcing popup dialog when help button/icon is clicked..
Jul 5 2020, 11:42 PM · Accessibility, OOUI
Tam-edwin-microsoft created T257167: Narrator not announcing popup dialog when help button/icon is clicked..
Jul 5 2020, 11:39 PM · Accessibility, OOUI
Tam-edwin-microsoft created T257165: OOUI PopupWidget : need to Notify caller when popup widget closes.
Jul 5 2020, 10:52 PM · OOUI (OOUI-0.39.3), Accessibility
Tam-edwin-microsoft updated the task description for T246178: Watchlist_Settings: Settings control must have a label.
Jul 5 2020, 4:28 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Growth-Team, MediaWiki-Watchlist, Accessibility

Jun 26 2020

Aklapper awarded T256492: WindowsAzureStorage Extension - extension need to use latest Azure storage blob sdk. a Like token.
Jun 26 2020, 6:01 PM · MediaWiki-extensions-Other
Tam-edwin-microsoft added a comment to T256492: WindowsAzureStorage Extension - extension need to use latest Azure storage blob sdk..

Correct,
I have a patch ready to commit. I actually made a git-based PR a while back before i knew about all the contribution process.

Jun 26 2020, 6:00 PM · MediaWiki-extensions-Other
Tam-edwin-microsoft created T256492: WindowsAzureStorage Extension - extension need to use latest Azure storage blob sdk..
Jun 26 2020, 5:03 PM · MediaWiki-extensions-Other

May 14 2020

Tam-edwin-microsoft updated Tam-edwin-microsoft.
May 14 2020, 7:57 AM

Apr 24 2020

Tam-edwin-microsoft added a comment to T250762: UsersMultiselectWidget not announcing status message.

Thanks! This is for the core project, we are using the widget in a private extension, but Barbara's change is for the accessibility of the widget in general

Apr 24 2020, 6:53 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), MediaWiki-General, Accessibility

Apr 5 2019

Tam-edwin-microsoft added a comment to T219109: When using parsing API, Lingo Glossary terms in page content will break certain parameters.

we have a fix locally, but I will have to wait until wikitech start accepting developer account creation before i can submit a patch.

Apr 5 2019, 1:09 AM · MediaWiki-extensions-Lingo