Sun, Jun 16
Jun 16 21:35:07 wikidata-misc sudo: root : TTY=unknown ; PWD=/ ; USER=root ; COMMAND=/bin/systemctl is-active --quiet termbox Jun 16 21:35:07 wikidata-misc sudo: pam_unix(sudo:session): session opened for user root by (uid=0) Jun 16 21:35:07 wikidata-misc sudo: pam_unix(sudo:session): session closed for user root Jun 16 21:35:07 wikidata-misc systemd: Started Restart termbox.service, if new updates are available or if the service is not running.
Fri, Jun 14
Wed, Jun 12
Tue, Jun 11
@akosiaris Great! Thanks for that. We look forward to seeing how it all goes forward post-offsite :)
Downgraded to high since it seems the shared build is at least un-broken now
Fri, Jun 7
@akosiaris Thanks! Now https://gerrit.wikimedia.org/r/c/wikibase/termbox/+/515040 is merged the Healthcheck query should be correct :)
Thu, Jun 6
Mon, Jun 3
Looks like all the patches for this are already merged and thus done
Wed, May 29
Looks like SRE did this for us as part of T220402 :)
Tue, May 28
@Lea_WMDE Just a heads up that in general this message is configurable on mediawiki.
Moved to in prep in task breakdown because we decided it wasn't ready to pick-up
In the worst case they change something else, the first edit went through, and other people have edited the item in the meantime as well.
Mon, May 27
@mobrovac Thanks! I think we've now taken most of this onboard and merged it.
Seems this is done since we have a selection of new tickets and this has been sat unmoved in peer review for a whole iteration.
Thu, May 23
Tue, May 21
We had the event and it was successful ca. 15 attendees.
For the avoidance of confusion in order to make this work in the Wikibase-Containers environment we'll need to add Scributo so that these kind of templates work. For this there is a long standing task: T197649
May 18 2019
May 17 2019
May 10 2019
Thanks for digging into it so much. Seems perhaps somehow I wandered into a very edge case set-up by mistake :(. As I mentioned I only found it by testing our new termbox on a random item on beta; seems impossibly bad/good luck that I ran into it with the first request I made.
Sorry for the lack of explicit reproduction :/. The steps below use httpie and the mediawiki-docker-dev setup.
May 9 2019
From my side this is fine to leave. If the complexity were to change I would expect it to be encapsulated in T221833
May 8 2019
@Lea_WMDE : I think we agreed in the daily that the hike wouldn't instantly pick this up and instead we'd maybe see if camp would be looking at it as an API bug. In that case I've de-tagged the hike.
Anyway, looks like sufficient research is done! Woo!
I think this might refer to a much older version of MobileFrontend I looked in the current master and found as follows:
The create anonymous edit warnning is built here: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/MobileFrontend/+/199dad4243045af2dc9be90b1dddab09069f978c/src/mobile.editor.overlay/EditorOverlayBase.js#523
The author field for WikibaseLexeme (from extension.json not package.json) for example is "The Wikidata team". This might suffice?
After canvassing developer opinion on IRC the conclusion was that fixing T203337 is the right thing to do. We're not yet sure who should do this though (us or camp) but don't have strong opinions either way.
May 7 2019
I'm unable to replicate this bug in desktop "classic" termbox. Perhaps you could have a look @Pablo-WMDE ?
@Lea_WMDE Is the meant to have been added to the campsite? As I read it this task is only about changing the new (currently mobile) Termbox that the hike is working on.
in edit, term editing should ignore those terms with unsupported languages, allowing the user to intentionally be able to save their edits as well as remove those terms at once.
I think that the "right" solution is to fix up wbeditentity. Otherwise we start having to do some very nasty checking client side and lose the advantage of just bunging our edit entity to the server and not worrying about atomic changes. It looks like "fixing" wbeditentity to accept the empty set of aliases as blanking would be a good idea for other users too.
Looks like this is related: https://phabricator.wikimedia.org/T203337 i.e. it is unclear what the desired functionality should be
The situation is as follows. Sending an empty array to wbeditentity for the aliases doesn't empty the aliases for that language. However, sending any other array acts as an "overwrite" of that field.
Thanks for adding this comment that I overlooked. I guess I made a mistake somewhere. Let me double check what happened again
May 6 2019
I'd love some feedback. There is about 30mins of this timebox remaining given I spent some time chasing unrelated bugs.
New tickets created as children of the story.
@Jakob_WMDE I think if you wanted you could maybe make this a train blocker.