Page MenuHomePhabricator

Tchanders
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Sep 13 2015, 10:17 PM (179 w, 6 d)
Availability
Available
LDAP User
Tchanders
MediaWiki User
Unknown

Recent Activity

Yesterday

Tchanders added a comment to T216845: Account creation checkbox inappropriately checked at Special:Block/<Username>.

Our collective bad - it should've been in the acceptance criteria.

Fri, Feb 22, 6:27 PM · MediaWiki-User-management, Anti-Harassment
Tchanders added a comment to T211578: Replace Block::prevents with setters, getters and method that calculates the block's effects.

@dom_walden Ah, nasty - looks like it's is a new bug introduced by: T208510, merged not long before this. The JavaScript unchecks the checkbox because it's a partial block (with JavaScript disabled, it is checked). Filed as T216845.

Fri, Feb 22, 6:26 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management
Tchanders created T216845: Account creation checkbox inappropriately checked at Special:Block/<Username>.
Fri, Feb 22, 6:25 PM · MediaWiki-User-management, Anti-Harassment
Tchanders added a comment to T208355: TitlesMultiselectWidget for Partial blocks suggests and accepts special pages and other invalid namespaces.

@TBolliger They're not actually opposite, though I can see how it sounds that way...

Fri, Feb 22, 5:38 PM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-API, MediaWiki-General-or-Unknown
Tchanders added a comment to T212391: Special:Block options should be enable/disable, and not hide/show.

Here's what we discussed in estimation:

Fri, Feb 22, 2:29 PM · MediaWiki-User-management, Anti-Harassment

Thu, Feb 21

Tchanders moved T214508: Special:BlockList reports a blocked user's ability to edit their own user talk page incorrectly for partial blocks on ITWP from Review to QA/Testing on the Anti-Harassment (Dalet — ד) board.
Thu, Feb 21, 11:04 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review
Tchanders added a comment to T214508: Special:BlockList reports a blocked user's ability to edit their own user talk page incorrectly for partial blocks on ITWP.

The approach of making the ipb_allow_usertalk flag match the behaviour was abandoned (https://gerrit.wikimedia.org/r/488533) in favour of decoupling the block flags/logs/form on the one hand from the block's behaviour on the other hand (https://gerrit.wikimedia.org/r/489662).

Thu, Feb 21, 11:02 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review
Tchanders moved T211578: Replace Block::prevents with setters, getters and method that calculates the block's effects from Review to QA/Testing on the Anti-Harassment (Dalet — ד) board.
Thu, Feb 21, 9:11 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management
Tchanders moved T211578: Replace Block::prevents with setters, getters and method that calculates the block's effects from QA/Testing to Review on the Anti-Harassment (Dalet — ד) board.
Thu, Feb 21, 6:52 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management
Tchanders moved T214508: Special:BlockList reports a blocked user's ability to edit their own user talk page incorrectly for partial blocks on ITWP from QA/Testing to Review on the Anti-Harassment (Dalet — ד) board.
Thu, Feb 21, 6:52 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review
Tchanders moved T208355: TitlesMultiselectWidget for Partial blocks suggests and accepts special pages and other invalid namespaces from Review to QA/Testing on the Anti-Harassment (Dalet — ד) board.
Thu, Feb 21, 3:14 PM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-API, MediaWiki-General-or-Unknown
Tchanders added a comment to T208355: TitlesMultiselectWidget for Partial blocks suggests and accepts special pages and other invalid namespaces.

The patch seems to resolve all the acceptance criteria.

Thu, Feb 21, 3:09 PM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-API, MediaWiki-General-or-Unknown
Tchanders added a comment to T216309: Ignore the no-block block use case in Title::checkUserBlock().

The only supported hook appears to be in LiquidThreads and returns straight away if there is no block.

Thu, Feb 21, 2:20 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Anti-Harassment (Dalet — ד), MediaWiki-User-management

Tue, Feb 19

Tchanders moved T206163: Restrictions of overlapping blocks should be merged on enforcement from Ready to In progress on the Anti-Harassment (Dalet — ד) board.
Tue, Feb 19, 2:52 PM · Anti-Harassment (Dalet — ד), MediaWiki-User-management

Mon, Feb 18

Tchanders added a comment to T216075: Pressing backspace to delete a tag in namespace multiselect widget populates the input with the tag data instead of the tag label.

@Mooeypoo I think it makes sense to change to item.getLabel() in MenuTagMultiselectWidget because the label is what is exposed in the menu, so most users of this widget are probably more used to interacting with labels than data. (Incidentally the bug was reported for the NamespacesMultiselectWidget, so we'd want to change it there if not in the MenuTagMultiselectWidget.)

Mon, Feb 18, 7:09 PM · Patch-For-Review, OOUI (OOUI-0.30.3), Anti-Harassment
Tchanders moved T208510: "Prevent account creation" should be unchecked when the block is configured to be Partial. from Ready to Review on the Anti-Harassment (Dalet — ד) board.
Mon, Feb 18, 4:07 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Anti-Harassment (Dalet — ד), MediaWiki-User-management

Fri, Feb 15

Tchanders added a comment to T211578: Replace Block::prevents with setters, getters and method that calculates the block's effects.

This also explains why a block's entries in the logs at Special:Block/<BlockedUser> and Special:BlockList are sometimes different. The former is created at the time when the block is originally submitted, so it reflects the block flags in the database. But the latter is dynamically generated, meaning that it has to represent how the block behaves, because of the lack of a mechanism for getting the block properties without Block::prevents modifying them first. The form at Special:Block/<BlockedUser> is also dynamically generated, so it also has to reflect the block's behaviour, and contradicts the block log at the bottom of the page.

Fri, Feb 15, 3:47 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management
Tchanders updated the task description for T211578: Replace Block::prevents with setters, getters and method that calculates the block's effects.
Fri, Feb 15, 3:42 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management

Thu, Feb 14

Tchanders moved T210273: Quick UI changes to mobile web "you are blocked" message to increase helpfulness from Review to QA/Testing on the Anti-Harassment (Dalet — ד) board.
Thu, Feb 14, 6:12 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management, Readers-Web-Backlog (Tracking), MobileFrontend

Wed, Feb 13

Tchanders added a comment to T214197: 👩‍👧‍👦 Parent task: MultiSelectWidget & Special:Block UI issues/enhancements/changes.

The problems outlined in the task description have been separated into subtasks:

Wed, Feb 13, 9:20 PM · Anti-Harassment
Tchanders triaged T216078: Namespaces multiselect widget only displays namespaces that match the input value exactly as Normal priority.
Wed, Feb 13, 9:17 PM · Anti-Harassment
Tchanders triaged T216075: Pressing backspace to delete a tag in namespace multiselect widget populates the input with the tag data instead of the tag label as Normal priority.
Wed, Feb 13, 9:07 PM · Patch-For-Review, OOUI (OOUI-0.30.3), Anti-Harassment
Tchanders updated the task description for T216071: Namespaces multiselect widget selects an item on input change *before* filtering the items according to the changed input.
Wed, Feb 13, 9:02 PM · Anti-Harassment
Tchanders triaged T216071: Namespaces multiselect widget selects an item on input change *before* filtering the items according to the changed input as Normal priority.
Wed, Feb 13, 8:45 PM · Anti-Harassment
Tchanders moved T211578: Replace Block::prevents with setters, getters and method that calculates the block's effects from Ready to In progress on the Anti-Harassment (Dalet — ד) board.
Wed, Feb 13, 8:04 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management
Tchanders added a project to T211578: Replace Block::prevents with setters, getters and method that calculates the block's effects: Anti-Harassment (Dalet — ד).
Wed, Feb 13, 8:04 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management
jcrespo awarded T214735: Unexpected master connection on GET request (from Block->newLoad) a Love token.
Wed, Feb 13, 3:27 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Anti-Harassment (Bet — ב), Wikimedia-production-error, Performance-Team (Radar), MediaWiki-User-management

Tue, Feb 12

Tchanders moved T208510: "Prevent account creation" should be unchecked when the block is configured to be Partial. from Ready to In progress on the Anti-Harassment (Gimel — ג) board.
Tue, Feb 12, 5:35 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Anti-Harassment (Dalet — ד), MediaWiki-User-management
Tchanders moved T208510: "Prevent account creation" should be unchecked when the block is configured to be Partial. from Cards ready for development to Gimel — ג on the Anti-Harassment board.
Tue, Feb 12, 5:35 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Anti-Harassment (Dalet — ד), MediaWiki-User-management
Tchanders moved T214763: Deleting a page that is part of a partial block causes problems from Review to QA/Testing on the Anti-Harassment (Gimel — ג) board.
Tue, Feb 12, 4:15 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Anti-Harassment (Gimel — ג), Patch-For-Review, MediaWiki-User-management, MediaWiki-Page-deletion
Tchanders moved T214508: Special:BlockList reports a blocked user's ability to edit their own user talk page incorrectly for partial blocks on ITWP from In progress to Review on the Anti-Harassment (Gimel — ג) board.
Tue, Feb 12, 3:33 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review

Mon, Feb 11

Tchanders added a comment to T212892: Add in-product feedback mechanism for Partial Blocks.

Just looking at a couple of other examples where special pages ask for feedback, which are both inline.

Mon, Feb 11, 5:53 PM · MediaWiki-User-management, Anti-Harassment
Tchanders added a comment to T213101: Add help text to Special:Block for Partial Blocks.

@Prtksxna That looks good to me!

Mon, Feb 11, 5:18 PM · Anti-Harassment, MediaWiki-User-management
Tchanders moved T210273: Quick UI changes to mobile web "you are blocked" message to increase helpfulness from In progress to Review on the Anti-Harassment (Gimel — ג) board.
Mon, Feb 11, 2:55 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management, Readers-Web-Backlog (Tracking), MobileFrontend
Tchanders added a comment to T210273: Quick UI changes to mobile web "you are blocked" message to increase helpfulness.

@TBolliger @dbarratt Thanks, have updated the URL to Special:BlockList. The patch passes in the block ID param rather than the target, since the user attempting to edit might not be the target - e.g. if it's an autoblock or an IP range block.

Mon, Feb 11, 2:47 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management, Readers-Web-Backlog (Tracking), MobileFrontend

Fri, Feb 8

Tchanders moved T210273: Quick UI changes to mobile web "you are blocked" message to increase helpfulness from Ready to In progress on the Anti-Harassment (Gimel — ג) board.
Fri, Feb 8, 8:23 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management, Readers-Web-Backlog (Tracking), MobileFrontend
Tchanders moved T210273: Quick UI changes to mobile web "you are blocked" message to increase helpfulness from Cards ready for development to Gimel — ג on the Anti-Harassment board.
Fri, Feb 8, 8:23 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management, Readers-Web-Backlog (Tracking), MobileFrontend
Tchanders added a comment to T210273: Quick UI changes to mobile web "you are blocked" message to increase helpfulness.

...An additional concern might be that someone who is using English but isn't that confident in English might not understand "Got it"?

Fri, Feb 8, 2:44 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management, Readers-Web-Backlog (Tracking), MobileFrontend
Tchanders added a comment to T210273: Quick UI changes to mobile web "you are blocked" message to increase helpfulness.

I wasn't sure about lengthening the "OK" message on the blue button, given the narrow width of the screen and possible longer translations in other languages. Perhaps @Amire80 has a opinion?

Thanks a lot for asking!

No, I don't see a problem here at the moment. OK is a common button on all platforms and it has standard translations in many languages, e.g. here.

If there will be a problem, the translators will complain ;)

Fri, Feb 8, 2:41 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management, Readers-Web-Backlog (Tracking), MobileFrontend
Tchanders updated subscribers of T210273: Quick UI changes to mobile web "you are blocked" message to increase helpfulness.

@TBolliger Ok, that makes sense! The block details are present in the desktop version, but they still don't seem to be there in mobile frontend:

DestopMobile frontend
Fri, Feb 8, 2:27 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management, Readers-Web-Backlog (Tracking), MobileFrontend

Thu, Feb 7

Tchanders added a comment to T210273: Quick UI changes to mobile web "you are blocked" message to increase helpfulness.

@TBolliger Is the user's talk page the best page to link to? As far as I can see, it doesn't contain block information in mobile frontend, and it only contains block information on desktop if you go to the edit tab... Unless I'm missing something!

Thu, Feb 7, 11:19 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management, Readers-Web-Backlog (Tracking), MobileFrontend
Tchanders added a comment to T211238: Create technical plan for merging overlapping blocks.

We can gather any user account, block ID, or IP addresses of interest in User::getBlockedStatus, respecting the existing rules. We could then query for all relevant blocks at once - we could rename and modify Block::getBlocksForIPList for this purpose, since it's not used elsewhere (https://codesearch.wmflabs.org/search/?q=getBlocksForIPList&i=nope&files=&repos=).

Thu, Feb 7, 10:00 PM · Anti-Harassment (Bet — ב), MediaWiki-User-management
Tchanders claimed T210273: Quick UI changes to mobile web "you are blocked" message to increase helpfulness.
Thu, Feb 7, 8:59 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-User-management, Readers-Web-Backlog (Tracking), MobileFrontend
Tchanders updated the task description for T208510: "Prevent account creation" should be unchecked when the block is configured to be Partial..
Thu, Feb 7, 6:38 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Anti-Harassment (Dalet — ד), MediaWiki-User-management

Tue, Feb 5

Tchanders moved T214508: Special:BlockList reports a blocked user's ability to edit their own user talk page incorrectly for partial blocks on ITWP from Ready to In progress on the Anti-Harassment (Gimel — ג) board.
Tue, Feb 5, 8:07 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review
Tchanders moved T211238: Create technical plan for merging overlapping blocks from In progress to Review on the Anti-Harassment (Bet — ב) board.
Tue, Feb 5, 2:12 PM · Anti-Harassment (Bet — ב), MediaWiki-User-management
Tchanders moved T214508: Special:BlockList reports a blocked user's ability to edit their own user talk page incorrectly for partial blocks on ITWP from Ready to In progress on the Anti-Harassment (Bet — ב) board.
Tue, Feb 5, 2:12 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review
Tchanders moved T214508: Special:BlockList reports a blocked user's ability to edit their own user talk page incorrectly for partial blocks on ITWP from Cards ready for development to Bet — ב on the Anti-Harassment board.
Tue, Feb 5, 2:12 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review
Tchanders added a comment to T214508: Special:BlockList reports a blocked user's ability to edit their own user talk page incorrectly for partial blocks on ITWP.

The logic to determine whether a partial block allows a user to edit their own user talk page is currently executed in User::isBlockedFrom, at the point when the user attempts to edit their talk page. In order to make the block list correct, we'd either have to duplicate that logic when parsing the blocks for the block list, or move it to when the block is saved, and store it in the ipb_allow_usertalk flag rather than ignoring the flag for partial blocks, as discussed in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/477447/. I'm in favour of the second way, since it's more universal.

Tue, Feb 5, 2:11 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review
Tchanders moved T215205: `ipb_sitewide` is not being updated for Autoblocks when the parent block changes restriction type (partial/sitewide) from Review to Done on the Anti-Harassment (Bet — ב) board.
Tue, Feb 5, 1:49 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Anti-Harassment (Bet — ב), Patch-For-Review, MediaWiki-User-management
Tchanders added a comment to T211238: Create technical plan for merging overlapping blocks.

If it helps, we also discussed some implementation details...

Tue, Feb 5, 11:59 AM · Anti-Harassment (Bet — ב), MediaWiki-User-management

Sun, Feb 3

Tchanders added a comment to T211238: Create technical plan for merging overlapping blocks.

Here's a summary of what we've discussed so far.

Sun, Feb 3, 3:01 AM · Anti-Harassment (Bet — ב), MediaWiki-User-management

Wed, Jan 30

Tchanders moved T214735: Unexpected master connection on GET request (from Block->newLoad) from Ready to Review on the Anti-Harassment (Bet — ב) board.
Wed, Jan 30, 10:57 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Anti-Harassment (Bet — ב), Wikimedia-production-error, Performance-Team (Radar), MediaWiki-User-management
Tchanders added a comment to T214735: Unexpected master connection on GET request (from Block->newLoad).

It is indeed being called with the default $rigor='secure' from Skin::getUndeleteLink: https://gerrit.wikimedia.org/g/mediawiki/core/+/refs/changes/80/484780/1/includes/skins/Skin.php#722 (That patch made this problem happen less often, by changing the order in which conditions are checked.)

Wed, Jan 30, 10:51 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Anti-Harassment (Bet — ב), Wikimedia-production-error, Performance-Team (Radar), MediaWiki-User-management

Tue, Jan 29

Tchanders added a comment to T214735: Unexpected master connection on GET request (from Block->newLoad).

The call to User::getBlock from Title::checkUserBlock was introduced in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/478056/

Tue, Jan 29, 12:05 AM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Anti-Harassment (Bet — ב), Wikimedia-production-error, Performance-Team (Radar), MediaWiki-User-management

Fri, Jan 25

Tchanders added a comment to T214716: Block is incorrectly applied if partial block feature is enabled then disabled.

Thanks @TBolliger. Just to (probably over-) clarify, if we're ever in that situation and the admins do decide that any partially blocked users should be sitewide blocked, they'll have to make sure they unblock them first before setting a new sitewide block... Simply editing their partial block into a sitewide one won't work.

Fri, Jan 25, 8:05 PM · Anti-Harassment
Tchanders created T214716: Block is incorrectly applied if partial block feature is enabled then disabled.
Fri, Jan 25, 6:59 PM · Anti-Harassment

Jan 23 2019

Tchanders moved T214508: Special:BlockList reports a blocked user's ability to edit their own user talk page incorrectly for partial blocks on ITWP from Untriaged to Cards ready to be estimated on the Anti-Harassment board.
Jan 23 2019, 7:46 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review
Tchanders created T214508: Special:BlockList reports a blocked user's ability to edit their own user talk page incorrectly for partial blocks on ITWP.
Jan 23 2019, 7:05 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review
Tchanders added a comment to T213101: Add help text to Special:Block for Partial Blocks.

@Prtksxna Tooltips/inline text can currently be added to an OO.ui.FieldLayout or an OO.ui.FieldsetLayout, by setting a config option. There whole radio list is within one OO.ui.FieldLayout, and the options do not have their own, so it is not possible to add tooltips for each option in this way. We can implement this, but it didn't seem worth it for the demo on my previous comment.

Jan 23 2019, 12:15 PM · Anti-Harassment, MediaWiki-User-management

Jan 22 2019

Tchanders moved T204986: Update Special:Block, Special:Unblock, API:Block, and API:Unblock to set/remove namespace blocks from In progress to Review on the Anti-Harassment (Bet — ב) board.
Jan 22 2019, 1:47 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Anti-Harassment (Bet — ב), Patch-For-Review, MediaWiki-User-management
Tchanders updated subscribers of T214197: 👩‍👧‍👦 Parent task: MultiSelectWidget & Special:Block UI issues/enhancements/changes.

@TBolliger I have replicated the timing problem on The Good Place, you just have to type very fast.

Jan 22 2019, 12:26 PM · Anti-Harassment

Jan 18 2019

Tchanders added a comment to T204986: Update Special:Block, Special:Unblock, API:Block, and API:Unblock to set/remove namespace blocks.

By default, the Main namespace appears as "(Main)" in the dropdown list. Is this correct, or should it be "Main"?

Jan 18 2019, 8:04 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Anti-Harassment (Bet — ב), Patch-For-Review, MediaWiki-User-management
Tchanders moved T214173: Partial page block does not apply to page with title 0 from In progress to Done on the Anti-Harassment (Bet — ב) board.
Jan 18 2019, 7:49 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Anti-Harassment (Bet — ב)
Tchanders created T214173: Partial page block does not apply to page with title 0.
Jan 18 2019, 4:08 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Anti-Harassment (Bet — ב)

Jan 17 2019

Tchanders moved T204986: Update Special:Block, Special:Unblock, API:Block, and API:Unblock to set/remove namespace blocks from Review to In progress on the Anti-Harassment (Bet — ב) board.
Jan 17 2019, 8:23 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Anti-Harassment (Bet — ב), Patch-For-Review, MediaWiki-User-management
Tchanders added a comment to T210002: Oversighters should only be able to suppress a username for sitewide blocks (not partial blocks) via "Hide username from edits and lists" checkbox.

@dbarratt @TBolliger There's already a patch up for this - it might be better to merge that fix to ensure no partial-block suppressions accidentally get made, and then get to work on T213972.

Jan 17 2019, 7:57 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Anti-Harassment (Gimel — ג), Patch-For-Review, MediaWiki-User-management
Tchanders moved T211238: Create technical plan for merging overlapping blocks from Ready to In progress on the Anti-Harassment (Bet — ב) board.
Jan 17 2019, 6:02 PM · Anti-Harassment (Bet — ב), MediaWiki-User-management

Jan 15 2019

Tchanders moved T210002: Oversighters should only be able to suppress a username for sitewide blocks (not partial blocks) via "Hide username from edits and lists" checkbox from In progress to Review on the Anti-Harassment (Alef — א) board.
Jan 15 2019, 6:43 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Anti-Harassment (Gimel — ג), Patch-For-Review, MediaWiki-User-management
Tchanders moved T213707: Check "Editing" checkbox value on Special:Block when partial blocks are enabled from Review to Done on the Anti-Harassment (Alef — א) board.
Jan 15 2019, 5:30 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Anti-Harassment (Alef — א)
Tchanders added a comment to T210002: Oversighters should only be able to suppress a username for sitewide blocks (not partial blocks) via "Hide username from edits and lists" checkbox.
  • If the person changes a suppressed sitewide block to a partial block, it should become unsuppressed.

In order to do this, we need to uncheck the "hide user" checkbox whenever it is hidden. Otherwise, on reblocking the suppressed user with a partial block, the form will have the "hide user" checkbox checked and hidden, making it impossible to uncheck (without playing around with the parameters of the block).

Jan 15 2019, 1:14 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Anti-Harassment (Gimel — ג), Patch-For-Review, MediaWiki-User-management

Jan 14 2019

Tchanders moved T213707: Check "Editing" checkbox value on Special:Block when partial blocks are enabled from In progress to Review on the Anti-Harassment (Alef — א) board.
Jan 14 2019, 4:12 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Anti-Harassment (Alef — א)
Tchanders updated the task description for T213707: Check "Editing" checkbox value on Special:Block when partial blocks are enabled.
Jan 14 2019, 3:45 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Anti-Harassment (Alef — א)
Tchanders created T213707: Check "Editing" checkbox value on Special:Block when partial blocks are enabled.
Jan 14 2019, 2:47 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Anti-Harassment (Alef — א)
Tchanders claimed T210002: Oversighters should only be able to suppress a username for sitewide blocks (not partial blocks) via "Hide username from edits and lists" checkbox.
Jan 14 2019, 1:51 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Anti-Harassment (Gimel — ג), Patch-For-Review, MediaWiki-User-management
Tchanders moved T210002: Oversighters should only be able to suppress a username for sitewide blocks (not partial blocks) via "Hide username from edits and lists" checkbox from Ready to In progress on the Anti-Harassment (Alef — א) board.
Jan 14 2019, 1:51 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Anti-Harassment (Gimel — ג), Patch-For-Review, MediaWiki-User-management
Tchanders moved T210002: Oversighters should only be able to suppress a username for sitewide blocks (not partial blocks) via "Hide username from edits and lists" checkbox from Cards ready for development to Alef — א on the Anti-Harassment board.
Jan 14 2019, 1:51 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Anti-Harassment (Gimel — ג), Patch-For-Review, MediaWiki-User-management

Jan 11 2019

Tchanders added a comment to T210002: Oversighters should only be able to suppress a username for sitewide blocks (not partial blocks) via "Hide username from edits and lists" checkbox.

On Test Wiki this is limited to only indefinite blocks, but it may be different across our various wikis.

The "hide user" checkbox is hidden from the UI if the expiration is not set to "indefinite" - do we need to worry about this? (That said, I can't imagine a use case for a non-indefinite suppression.)

Jan 11 2019, 8:12 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Anti-Harassment (Gimel — ג), Patch-For-Review, MediaWiki-User-management
Tchanders added a comment to T208649: Remove hiding of oversight block option on Special:Block.

@Amorymeltzer It looks like the appearing/disappearing behaviour of the "hide user" option was introduced and discussed in T133036. When the page got broken, the option became always visible again; then when the page was fixed (T212808), the appearing/disappearing behaviour resumed. (The fix didn't touch the "hide user" option logic, it just unbroke the page.)

Jan 11 2019, 7:57 PM · Anti-Harassment (Alef — א), Regression, MediaWiki-User-management
Tchanders added a comment to T208649: Remove hiding of oversight block option on Special:Block.

This behaviour started after the fix for T212808 was merged. (In that sense it is indeed related to T209664.)

Jan 11 2019, 6:11 PM · Anti-Harassment (Alef — א), Regression, MediaWiki-User-management

Jan 10 2019

Tchanders added a comment to T202773: Update Special:Block to match the design.

@aezell Good idea to keep track of all this properly - filed as T213451, so this can stay closed.

Jan 10 2019, 4:28 PM · Patch-For-Review, Anti-Harassment (Alef — א), MediaWiki-User-management
Tchanders created T213451: Review Special:Block design once partial blocks are more fully implemented.
Jan 10 2019, 4:26 PM · MediaWiki-User-management, Anti-Harassment

Jan 9 2019

Tchanders added a comment to T202773: Update Special:Block to match the design.

I agree with @Volker_E

Jan 9 2019, 7:50 PM · Patch-For-Review, Anti-Harassment (Alef — א), MediaWiki-User-management
Tchanders added a comment to T202773: Update Special:Block to match the design.

@Prtksxna The "Confirm block" checkbox does only appear for re-blocks. I've separated considering what to do about this into T213292 - I imagine it's low priority, since the checkbox has been in place for some time.

Jan 9 2019, 3:38 PM · Patch-For-Review, Anti-Harassment (Alef — א), MediaWiki-User-management
Tchanders created T213292: Consider whether the "Confirm block" checkbox is needed on Special:Block.
Jan 9 2019, 3:36 PM · MediaWiki-User-management, Anti-Harassment
Tchanders moved T212964: Alterations to the Special:Block UI if partial blocks is disabled from Review to Done on the Anti-Harassment (Alef — א) board.
Jan 9 2019, 2:40 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, Anti-Harassment (Alef — א), MediaWiki-User-management
Tchanders moved T202773: Update Special:Block to match the design from Review to Done on the Anti-Harassment (Alef — א) board.
Jan 9 2019, 2:40 PM · Patch-For-Review, Anti-Harassment (Alef — א), MediaWiki-User-management
Tchanders moved T210369: Add @since 1.33 tags to every new public method in BlockRestriction from Review to Done on the Anti-Harassment (Alef — א) board.
Jan 9 2019, 2:40 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, Anti-Harassment (Alef — א), MediaWiki-User-management
Tchanders merged task T209664: "Prevent logged-in users from editing from this IP address" option is visible on Special:Block with accounts into T213229: "Prevent logged-in users from editing from this IP address" always shown when blocking accounts but has no effect.
Jan 9 2019, 2:32 PM · MediaWiki-User-management, UI-Standardization
Tchanders merged T209664: "Prevent logged-in users from editing from this IP address" option is visible on Special:Block with accounts into T213229: "Prevent logged-in users from editing from this IP address" always shown when blocking accounts but has no effect.
Jan 9 2019, 2:32 PM · Anti-Harassment (Alef — א), Regression, MediaWiki-User-management
Tchanders added a comment to T213229: "Prevent logged-in users from editing from this IP address" always shown when blocking accounts but has no effect.

I can confirm that this is fixed by the fix for T212808 - after this, the checkbox no longer reappears.

Jan 9 2019, 2:31 PM · Anti-Harassment (Alef — א), Regression, MediaWiki-User-management

Jan 8 2019

Tchanders added a comment to T204986: Update Special:Block, Special:Unblock, API:Block, and API:Unblock to set/remove namespace blocks.

Discussions about the behaviour of the checkbox for a partially blocked user editing their own user talk page can be found on T211073 and T210475.

Jan 8 2019, 5:33 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Anti-Harassment (Bet — ב), Patch-For-Review, MediaWiki-User-management
Tchanders claimed T210369: Add @since 1.33 tags to every new public method in BlockRestriction.
Jan 8 2019, 1:06 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, Anti-Harassment (Alef — א), MediaWiki-User-management
Tchanders moved T210369: Add @since 1.33 tags to every new public method in BlockRestriction from Ready to Review on the Anti-Harassment (Alef — א) board.
Jan 8 2019, 1:06 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, Anti-Harassment (Alef — א), MediaWiki-User-management

Jan 7 2019

Tchanders moved T212964: Alterations to the Special:Block UI if partial blocks is disabled from Ready to Review on the Anti-Harassment (Alef — א) board.
Jan 7 2019, 7:28 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, Anti-Harassment (Alef — א), MediaWiki-User-management
Tchanders moved T202773: Update Special:Block to match the design from In progress to Review on the Anti-Harassment (Alef — א) board.
Jan 7 2019, 7:28 PM · Patch-For-Review, Anti-Harassment (Alef — א), MediaWiki-User-management
Tchanders added a comment to T212964: Alterations to the Special:Block UI if partial blocks is disabled.

Link removed:

Jan 7 2019, 6:28 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, Anti-Harassment (Alef — א), MediaWiki-User-management
Tchanders added a comment to T202773: Update Special:Block to match the design.

@TBolliger Great, so I think that means that the following two acceptance criteria are the only ones still not met:

Jan 7 2019, 6:14 PM · Patch-For-Review, Anti-Harassment (Alef — א), MediaWiki-User-management
Tchanders added a comment to T202773: Update Special:Block to match the design.

@TBolliger With the messages to match the mockup, and the changes mentioned in T212964, it looks like this:

Jan 7 2019, 3:41 PM · Patch-For-Review, Anti-Harassment (Alef — א), MediaWiki-User-management
Tchanders added a comment to T212964: Alterations to the Special:Block UI if partial blocks is disabled.

Disabling the checkbox and using a link instead of a tooltip looks like this:


(Labels have also been updated in accordance with the discussion on T202773)

Jan 7 2019, 3:15 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, Anti-Harassment (Alef — א), MediaWiki-User-management