Tchanders
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Sep 13 2015, 10:17 PM (140 w, 18 h)
Availability
Available
LDAP User
Tchanders
MediaWiki User
Unknown

Recent Activity

Apr 4 2018

Tchanders added a comment to T188170: Historical visual diff behaves poorly for changes inside a container.

The reason I put it here is because the work I'm doing on lists diffs happens to solve this too, but happy to move it if that makes more sense...

Apr 4 2018, 7:43 PM · VisualEditor (Current work), VisualEditor-VisualDiffs

Apr 2 2018

Tchanders moved T187632: Historical visual diff sometimes shows extraneous changes for a single-line addition from Up next to In progress on the VisualEditor (Current work) board.
Apr 2 2018, 5:01 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders moved T188170: Historical visual diff behaves poorly for changes inside a container from Up next to In progress on the VisualEditor (Current work) board.
Apr 2 2018, 5:01 PM · VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders moved T187632: Historical visual diff sometimes shows extraneous changes for a single-line addition from TR6: Visual diffs to Current work on the VisualEditor board.
Apr 2 2018, 5:01 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders moved T188170: Historical visual diff behaves poorly for changes inside a container from TR6: Visual diffs to Current work on the VisualEditor board.
Apr 2 2018, 5:01 PM · VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders claimed T187632: Historical visual diff sometimes shows extraneous changes for a single-line addition.
Apr 2 2018, 4:58 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders claimed T188170: Historical visual diff behaves poorly for changes inside a container.
Apr 2 2018, 4:58 PM · VisualEditor (Current work), VisualEditor-VisualDiffs

Mar 24 2018

Tchanders moved T188682: Message about references defined in templates not being editable is sub-optimal in historical visual diffs. from Up next to In progress on the VisualEditor (Current work) board.
Mar 24 2018, 4:45 PM · MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders claimed T188682: Message about references defined in templates not being editable is sub-optimal in historical visual diffs..
Mar 24 2018, 4:45 PM · MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders added a comment to T188682: Message about references defined in templates not being editable is sub-optimal in historical visual diffs..

Indeed, not ideal. The reason we see this message in the diff is because we happen to be building it as a visual editor document, and this is the message that visual editor displays - there is no separate message just for the diff. We could make the message more generic so it would make sense in both the editing and diffing contexts.

Mar 24 2018, 4:44 PM · MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), VisualEditor (Current work), VisualEditor-VisualDiffs

Mar 14 2018

Tchanders added a comment to T186672: Handle form submission, data type validation, and inserting template markup into the WikiText (Infobox wizard).

That's a good idea. I've switched it to do so; see what you think.

Mar 14 2018, 11:18 PM · MediaWiki-extensions-TemplateWizard, Patch-For-Review, Community-Tech-Sprint, Community-Wishlist-Survey-2017
TheDJ awarded T180842: When VisualDiff times out, please tell the user a Love token.
Mar 14 2018, 3:25 PM · VisualEditor (Current work), VisualEditor-VisualDiffs

Mar 10 2018

Tchanders moved T188833: Display alien node changes in visual diff from Up next to In progress on the VisualEditor (Current work) board.
Mar 10 2018, 8:10 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-VisualDiffs
Tchanders moved T188833: Display alien node changes in visual diff from TR6: Visual diffs to Current work on the VisualEditor board.
Mar 10 2018, 8:09 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-VisualDiffs
Tchanders claimed T188833: Display alien node changes in visual diff.
Mar 10 2018, 6:38 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-VisualDiffs
Tchanders added a comment to T186672: Handle form submission, data type validation, and inserting template markup into the WikiText (Infobox wizard).

Have just been playing around with this - looks great.

Mar 10 2018, 1:09 PM · MediaWiki-extensions-TemplateWizard, Patch-For-Review, Community-Tech-Sprint, Community-Wishlist-Survey-2017

Mar 3 2018

Tchanders moved T187097: Newly inserted ref list not highlighted green from Up next to Code review and QA on the VisualEditor (Current work) board.
Mar 3 2018, 7:26 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders added a comment to T187613: Historic visual diff displays change completely unrelated to actual change.

On the other hand, even if something isn't editable visually, you could still show it in diffs. If it changed in some way, put the old version into del, and the new into ins, and the diff will be correct

Mar 3 2018, 6:21 PM · VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders added projects to T188833: Display alien node changes in visual diff: VisualEditor-VisualDiffs, VisualEditor.
Mar 3 2018, 6:18 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-VisualDiffs
Tchanders created T188833: Display alien node changes in visual diff.
Mar 3 2018, 6:17 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-VisualDiffs
Tchanders moved T180842: When VisualDiff times out, please tell the user from In progress to Code review and QA on the VisualEditor (Current work) board.
Mar 3 2018, 5:05 PM · VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders added a comment to T188170: Historical visual diff behaves poorly for changes inside a container.

In this particular case, the problem is caused by the diff timing out, at which point it just gives up and says everything in the old version was removed and everything in the new version was inserted... Once T180842 is fixed, we will at least show a message to explain that this has happened.

Mar 3 2018, 4:19 PM · VisualEditor (Current work), VisualEditor-VisualDiffs

Feb 28 2018

Tchanders added a comment to T160589: VisualDiffs: Add custom messages for reference changes.

Hmm, the task is phrased a bit strangely. We don't actually have custom messages for adding/removing/changing content for references - we just show the change.

Feb 28 2018, 9:33 PM · Verified, User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), VisualEditor (Current work), MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), VisualEditor-MediaWiki-References, Cite

Feb 24 2018

Tchanders added a comment to T187632: Historical visual diff sometimes shows extraneous changes for a single-line addition.

Thanks for this, I've seen other examples like it.

Feb 24 2018, 8:58 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders moved T187613: Historic visual diff displays change completely unrelated to actual change from In progress to Code review and QA on the VisualEditor (Current work) board.
Feb 24 2018, 6:16 PM · VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders added a comment to T187613: Historic visual diff displays change completely unrelated to actual change.

The fact that it isn't showing the blockquote diff is a separate issue. It seems blockquotes aren't even editable in visual editor, so it makes sense that the in-editor diff doesn't handle them.

Feb 24 2018, 6:15 PM · VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders merged T178499: Historical diffs show lots of unrelated reference changes into T187613: Historic visual diff displays change completely unrelated to actual change.
Feb 24 2018, 6:00 PM · VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders merged task T178499: Historical diffs show lots of unrelated reference changes into T187613: Historic visual diff displays change completely unrelated to actual change.
Feb 24 2018, 6:00 PM · VisualEditor, VisualEditor-VisualDiffs
Tchanders moved T187613: Historic visual diff displays change completely unrelated to actual change from Up next to In progress on the VisualEditor (Current work) board.
Feb 24 2018, 4:37 PM · VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders claimed T187613: Historic visual diff displays change completely unrelated to actual change.
Feb 24 2018, 4:35 PM · VisualEditor (Current work), VisualEditor-VisualDiffs

Feb 19 2018

TheDJ awarded T187070: Investigate the performance of visual diffs when user pastes a huge, complex article into another one a Like token.
Feb 19 2018, 2:11 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), VisualEditor (Current work), Performance, VisualEditor-VisualDiffs

Feb 17 2018

Tchanders claimed T180842: When VisualDiff times out, please tell the user.
Feb 17 2018, 1:23 PM · VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders moved T180842: When VisualDiff times out, please tell the user from Up next to In progress on the VisualEditor (Current work) board.
Feb 17 2018, 1:20 PM · VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders moved T180842: When VisualDiff times out, please tell the user from TR6: Visual diffs to Current work on the VisualEditor board.
Feb 17 2018, 1:20 PM · VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders moved T171587: When moving and reordering references the "References" list isn't being updated in the visual diff from Up next to Code review and QA on the VisualEditor (Current work) board.
Feb 17 2018, 1:19 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-VisualDiffs
Tchanders moved T171587: When moving and reordering references the "References" list isn't being updated in the visual diff from TR6: Visual diffs to Current work on the VisualEditor board.
Feb 17 2018, 10:36 AM · VisualEditor (Current work), Patch-For-Review, VisualEditor-VisualDiffs

Feb 13 2018

Elitre awarded T183118: Duplicated reference section a Like token.
Feb 13 2018, 4:16 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), User-Ryasmeen, VisualEditor, VisualEditor-VisualDiffs
RandomDSdevel awarded T178248: Move visual diff out of beta in visual and 2017 wikitext editors a Party Time token.
Feb 13 2018, 2:45 AM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), User-notice, Epic, VisualEditor, VisualEditor-VisualDiffs

Feb 12 2018

Tchanders added a comment to T187070: Investigate the performance of visual diffs when user pastes a huge, complex article into another one.

In the example given, a lot of the time was spent putting the visual diff document html together. The problem is, we make the html from the visual editor linear data, and given the way that works, <del> and <ins> have to be added as annotations to each character, so when we are dealing with several hundred paragraphs, all inserted or deleted in their entirety, this takes a long time. One way round this is to bypass the normal visual editor converter when making html for the diff document, so we can add those tags directly.

Feb 12 2018, 9:35 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), VisualEditor (Current work), Performance, VisualEditor-VisualDiffs

Feb 6 2018

Tchanders created T186640: References list dialog opens with unfocused input.
Feb 6 2018, 8:43 PM · Verified, MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Cite, User-Ryasmeen, VisualEditor-MediaWiki-References, VisualEditor

Feb 3 2018

Tchanders created T186407: Copying a reference list in visual editor copies the list's original state when the document was loaded.
Feb 3 2018, 12:37 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), User-Ryasmeen, VisualEditor-CopyPaste, VisualEditor

Jan 29 2018

Tchanders added a comment to T183118: Duplicated reference section.

These aren't quite duplicates.

Jan 29 2018, 11:53 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), User-Ryasmeen, VisualEditor, VisualEditor-VisualDiffs

Nov 17 2017

Elitre awarded T177378: Historical visual diff throwing uncaught exception a Like token.
Nov 17 2017, 2:22 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), VisualEditor-VisualDiffs, VisualEditor

Oct 22 2017

Tchanders added a comment to T177378: Historical visual diff throwing uncaught exception.

Looks like it's because these are timing out at the tree diff stage, because of the long bullet lists. We should do two things:

Oct 22 2017, 10:22 AM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), VisualEditor-VisualDiffs, VisualEditor

Oct 17 2017

Deskana awarded T178248: Move visual diff out of beta in visual and 2017 wikitext editors a Like token.
Oct 17 2017, 3:58 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), User-notice, Epic, VisualEditor, VisualEditor-VisualDiffs

Oct 15 2017

Tchanders created T178248: Move visual diff out of beta in visual and 2017 wikitext editors.
Oct 15 2017, 11:43 AM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), User-notice, Epic, VisualEditor, VisualEditor-VisualDiffs

Sep 5 2017

Tchanders claimed T171451: Stop showing excessive moves when moving a paragraph across the page.
Sep 5 2017, 4:12 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, VisualEditor, VisualEditor-VisualDiffs
Tchanders added a comment to T172141: Removal of template parameter inside the reference tag not shown in changes.

Ah it's because the reference name="bd-pratidin.com" is defined more than once in the page - so editing anything but the first one won't make a difference.

Sep 5 2017, 2:42 PM · VisualEditor, VisualEditor-VisualDiffs
Tchanders added a comment to T172141: Removal of template parameter inside the reference tag not shown in changes.

I don't think it's because there aren't visible changes on the page - the model of the page has still changed as far as the visual diff is concerned. I'm having trouble reproducing this behaviour locally, so I suspect it is not a visual diff problem.

Sep 5 2017, 2:25 PM · VisualEditor, VisualEditor-VisualDiffs
Tchanders added a comment to T169325: Consider clarifying the visual language for Visual Diffs.

I think I'd still be concerned about crowding the diff if the origin is highlighted, even if only a small excerpt is shown (see @Pginer-WMF's example C above)... But maybe we'd have to balance how common/bad this would be compared to how much there is to gain from knowing exactly where the origin was.

Sep 5 2017, 1:26 PM · VisualEditor, VisualEditor-VisualDiffs

Aug 29 2017

Tchanders added a comment to T170665: Inform users inside the editor that visual diffs are in beta .

@Whatamidoing-WMF Should the feedback link go here? https://www.mediawiki.org/wiki/Talk:VisualEditor/Diffs

Aug 29 2017, 8:49 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, Patch-For-Review, VisualEditor-VisualDiffs, VisualEditor

Aug 15 2017

Tchanders added a comment to T171862: Visual diff: Linear diff doesn't enforce balanced content in removed/inserted sections, throwing exception when rendering.

Correction: this isn't specific to historical diffs

Aug 15 2017, 10:03 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-VisualDiffs, VisualEditor

Aug 11 2017

Tchanders added a comment to T170235: Visual diff (on history page) shows changes to reference numbers caused by inserting more references.

Just to be clear, this behaviour should not be happening and should go away once T170269 is fixed.

Aug 11 2017, 10:57 PM · VisualEditor, VisualEditor-VisualDiffs
Tchanders added a comment to T170665: Inform users inside the editor that visual diffs are in beta .

That does @Deskana's suggestion but not @matmarex's...

Aug 11 2017, 7:16 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, Patch-For-Review, VisualEditor-VisualDiffs, VisualEditor
Tchanders added a comment to T171377: Changing a reference shows useless and confusing details in visual diff.

Has this been resolved now?

Aug 11 2017, 7:01 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, VisualEditor, Cite, VisualEditor-VisualDiffs
Tchanders claimed T171587: When moving and reordering references the "References" list isn't being updated in the visual diff.
Aug 11 2017, 3:56 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-VisualDiffs
Tchanders added a comment to T171862: Visual diff: Linear diff doesn't enforce balanced content in removed/inserted sections, throwing exception when rendering.

Interesting. This is another one of those cases (like historical reference diffs) where we rely on the assumption that the diff is between a document and some changes to it that have just been made in visual editor.

Aug 11 2017, 3:42 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, VisualEditor-VisualDiffs, VisualEditor
Tchanders created T173100: Historical visual diff crashes if reference has been removed.
Aug 11 2017, 3:21 PM · Verified, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), User-Ryasmeen, Patch-For-Review, VisualEditor

Aug 10 2017

Tchanders added a comment to T170269: Reference diffs not working correctly on historical diffs.

Oops, should've tagged: rGVED81a4760ea38c: VisualDiff: Refactor for historical diffs

Aug 10 2017, 8:01 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), VisualEditor-VisualDiffs, VisualEditor

Jul 31 2017

Tchanders added a comment to T169325: Consider clarifying the visual language for Visual Diffs.

In T169325#3477128, @Schnark wrote:
I'm wondering whether it is really necessary that the diff tells you exactly where each of the paragraphs moved.

I'm wondering the same thing. I agree that it's nice to know exactly what happened for a simple move, but that for anything more complicated it's probably more useful just to be aware that some moves have happened.

Jul 31 2017, 2:02 AM · VisualEditor, VisualEditor-VisualDiffs

Jul 24 2017

Tchanders added a comment to T169325: Consider clarifying the visual language for Visual Diffs.

I'm not sure the moved content should be shown twice in its entirety - it could make the diff quite complicated in cases where multiple paragraphs or whole sections are moved, or where multiple moves are made...

Jul 24 2017, 6:52 PM · VisualEditor, VisualEditor-VisualDiffs

Jul 18 2017

Tchanders added a comment to T162820: When two references switch positions their numbering is shown incorrectly in the preview..

This was fixed by https://gerrit.wikimedia.org/r/#/c/355716/ - the preview now matches the editor.

Jul 18 2017, 4:30 PM · User-Ryasmeen, VisualEditor, VisualEditor-VisualDiffs
Tchanders added a comment to T166755: JS error when trying to view visual diff after switching from source to visual with new annotation.

I just tried reproducing both of these examples, but looks like it's fixed now?

Jul 18 2017, 4:16 PM · User-Ryasmeen, VisualEditor-VisualDiffs, VisualEditor

Jul 15 2017

Tchanders added a comment to T170134: New comment shows up as an added space in the content in the VisualDiff.

Sorry, I meant any template that isn't visible when just reading the article.

Jul 15 2017, 9:54 PM · VisualEditor (Current work), VisualEditor-VisualDiffs

Jul 11 2017

TheDJ awarded T170136: Use <del> inside <p data-diff-action="remove"> in VisualDiffs a Doubloon token.
Jul 11 2017, 7:52 AM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), User-Ryasmeen, VisualEditor, Accessibility, VisualEditor-VisualDiffs

Jul 10 2017

Tchanders updated subscribers of T160589: VisualDiffs: Add custom messages for reference changes.

@Esanders Do you have any ideas about "columns setting changed"?

Jul 10 2017, 7:44 PM · Verified, User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), VisualEditor (Current work), MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), VisualEditor-MediaWiki-References, Cite
Tchanders updated the task description for T160589: VisualDiffs: Add custom messages for reference changes.
Jul 10 2017, 7:43 PM · Verified, User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), VisualEditor (Current work), MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), VisualEditor-MediaWiki-References, Cite
Tchanders claimed T170136: Use <del> inside <p data-diff-action="remove"> in VisualDiffs.
Jul 10 2017, 7:31 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), User-Ryasmeen, VisualEditor, Accessibility, VisualEditor-VisualDiffs
Tchanders added a comment to T170134: New comment shows up as an added space in the content in the VisualDiff.

This is a bit more complicated than it looks - we don't have a way yet of describing changes for a newly inserted/deleted node - only changes to an existing node. We should think about other cases that this would apply to (e.g. invisible templates) and come up with a general solution.

Jul 10 2017, 7:30 PM · VisualEditor (Current work), VisualEditor-VisualDiffs

Jun 26 2017

Tchanders added a comment to T149821: Visual Diff does not show changes related with "Comment".

Is this good to close now?

Jun 26 2017, 7:00 PM · Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), VisualEditor-VisualDiffs, VisualEditor

May 17 2017

Tchanders added a comment to T163727: Scrolling in the gallery search box causes image thumbnails to change size.

Yeah that's the culprit

May 17 2017, 4:44 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), MediaWiki-Gallery, VisualEditor, VisualEditor-MediaWiki-Media
Tchanders added a comment to T163727: Scrolling in the gallery search box causes image thumbnails to change size.

@Mooeypoo No worries, I'll look into it - thanks for the pointers.

May 17 2017, 3:56 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), MediaWiki-Gallery, VisualEditor, VisualEditor-MediaWiki-Media

May 16 2017

Liuxinyu970226 awarded T143350: Let users choose a visual or wikitext diff in the review-your-changes tab a Party Time token.
May 16 2017, 4:27 AM · VisualEditor-VisualDiffs, User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), User-notice, Category, VisualEditor-MediaWiki, Epic, VisualEditor

May 9 2017

Tchanders added a comment to T163727: Scrolling in the gallery search box causes image thumbnails to change size.

I'm having trouble replicating this, even when I search for "Sandbox". It could be that it's an odd case and the results have changed since... Is it still happening?

May 9 2017, 9:05 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), MediaWiki-Gallery, VisualEditor, VisualEditor-MediaWiki-Media

Mar 29 2017

RandomDSdevel awarded T143350: Let users choose a visual or wikitext diff in the review-your-changes tab a Mountain of Wealth token.
Mar 29 2017, 11:36 PM · VisualEditor-VisualDiffs, User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), User-notice, Category, VisualEditor-MediaWiki, Epic, VisualEditor

Mar 22 2017

Elitre awarded T143350: Let users choose a visual or wikitext diff in the review-your-changes tab a Barnstar token.
Mar 22 2017, 6:44 PM · VisualEditor-VisualDiffs, User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), User-notice, Category, VisualEditor-MediaWiki, Epic, VisualEditor

Mar 17 2017

TheDJ awarded T143350: Let users choose a visual or wikitext diff in the review-your-changes tab a Party Time token.
Mar 17 2017, 1:34 PM · VisualEditor-VisualDiffs, User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), User-notice, Category, VisualEditor-MediaWiki, Epic, VisualEditor

Mar 14 2017

Tchanders added a comment to T155145: The "Done" button remains disabled after making changes to json specifications section once in Graph dialog.

I'm having trouble replicating this - has it been fixed?

Mar 14 2017, 7:57 PM · Verified-in-Phase2, Verified-in-Phase0, Verified, User-Ryasmeen, Graphs, VisualEditor

Feb 23 2017

Tchanders added a project to T158895: Fix whitespace errors in visual diffs: VisualEditor.
Feb 23 2017, 7:22 PM · Verified-in-Phase2, Verified-in-Phase0, VisualEditor-VisualDiffs, Verified, User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), VisualEditor
Tchanders created T158895: Fix whitespace errors in visual diffs.
Feb 23 2017, 7:22 PM · Verified-in-Phase2, Verified-in-Phase0, VisualEditor-VisualDiffs, Verified, User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), VisualEditor

Feb 21 2017

Tchanders added a comment to T149821: Visual Diff does not show changes related with "Comment".

Some thoughts:

Feb 21 2017, 8:44 PM · Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), VisualEditor-VisualDiffs, VisualEditor

Feb 19 2017

Tchanders added a comment to T158294: Cell change missing in table diff.

The first example is fixed by correcting a few indices, but the second poses a more philosophical question about minimal-tree-diffing 2D matrices, so requires a bit more thinking...

Feb 19 2017, 9:58 PM · User-Ryasmeen, VisualEditor-VisualDiffs, MW-1.29-release (WMF-deploy-2017-02-28_(1.29.0-wmf.14)), VisualEditor-Tables, VisualEditor

Jan 25 2017

Tchanders added a comment to T151404: Have the visual diff system display node attribute changes.

The above commit addresses step 1 but not step 2 yet.

Jan 25 2017, 10:48 PM · VisualEditor-VisualDiffs, User-Ryasmeen, Design, VisualEditor-EditingTools, VisualEditor

Jan 24 2017

Tchanders added a comment to T151404: Have the visual diff system display node attribute changes.

We also need to display node type changes. The boundary between the two is not always obvious in VE (e.g. <p> to <h1> is a type change, but <h1> to <h2> is an attribute change), so we should treat these as the same problem.

Jan 24 2017, 9:33 PM · VisualEditor-VisualDiffs, User-Ryasmeen, Design, VisualEditor-EditingTools, VisualEditor
Tchanders created T156189: Have the visual diff system display content attribute changes.
Jan 24 2017, 9:32 PM · VisualEditor-VisualDiffs, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), VisualEditor-EditingTools, User-Ryasmeen, Design, VisualEditor
Tchanders added a comment to T152948: "Tech Talk" about visual diffs.

Yes, I'd like this to be user-oriented too!

Jan 24 2017, 9:26 PM · User-Ryasmeen, VisualEditor-VisualDiffs, Community-Liaisons, VisualEditor-MediaWiki, VisualEditor

Jan 14 2017

Tchanders renamed T155330: Disable 'done' action on live extension inspectors and extension preview dialogs by default from Disable 'done' action on inspectors and dialogs by default to Disable 'done' action on live extension inspectors and extension preview dialogs by default.
Jan 14 2017, 11:12 PM · User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), VisualEditor-EditingTools, VisualEditor
Tchanders added a parent task for T62311: VisualEditor: Opening and closing the gallery inspector without making any change causes a transaction: T155330: Disable 'done' action on live extension inspectors and extension preview dialogs by default.
Jan 14 2017, 10:29 PM · Verified-in-Phase2, Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), MediaWiki-Gallery, VisualEditor, VisualEditor-EditingTools
Tchanders added a subtask for T155330: Disable 'done' action on live extension inspectors and extension preview dialogs by default: T62311: VisualEditor: Opening and closing the gallery inspector without making any change causes a transaction.
Jan 14 2017, 10:29 PM · User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), VisualEditor-EditingTools, VisualEditor
Tchanders created T155330: Disable 'done' action on live extension inspectors and extension preview dialogs by default.
Jan 14 2017, 10:25 PM · User-Ryasmeen, MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), VisualEditor-EditingTools, VisualEditor

Jan 11 2017

Tchanders created T155107: Improve autocomplete in the math dialog.
Jan 11 2017, 6:37 PM · MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), Patch-For-Review, Math, VisualEditor

Jan 10 2017

Tchanders added a comment to T151589: Visual diffing: Document replacement causes differ to run slowly and then throw an exception.

This was caused by deciding a content branch node with content length 0 was modified to an alien node.

Jan 10 2017, 6:52 PM · User-Ryasmeen, VisualEditor-VisualDiffs, MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), VisualEditor

Dec 12 2016

Tchanders added a comment to T152981: Editing a gallery with pre-native code converts any alias name for "File:" namespace to canonical localized one.

@ssastry The version that relies on HTML-based serialization hasn't been deployed yet, but there have been some recent changes around the prefixes.

Dec 12 2016, 9:26 PM · VisualEditor-MediaWiki-Media, MediaWiki-Gallery, Parsoid, VisualEditor
Tchanders added a comment to T145417: CREDIT showcase for the 2017 wikitext editor.

Yes - very happy to do that

Dec 12 2016, 9:05 AM · Community-Liaisons, VisualEditor-MediaWiki-2017WikitextEditor, Notice, VisualEditor, VisualEditor-MediaWiki

Dec 3 2016

Tchanders added a comment to T151509: Gallery dialog's search results aspect ratio is different to the media dialog's search results.

I think this is because the space in the gallery dialog is narrower. After playing around a bit, setting a smaller row height seems to increase the probability of the images fitting better...

Dec 3 2016, 4:29 PM · MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)), VisualEditor-MediaWiki-Media, MediaWiki-Gallery, VisualEditor
Tchanders added a comment to T151482: Height of images in slideshow is not changing..

It would be less confusing if the gallery dialog disabled height, width, etc in the modes that they don't apply to.

Dec 3 2016, 3:09 PM · VisualEditor-MediaWiki-Media, MediaWiki-Gallery, VisualEditor
Tchanders added a comment to T151482: Height of images in slideshow is not changing..

There is a slightly complicated reason for this...

Dec 3 2016, 3:00 PM · VisualEditor-MediaWiki-Media, MediaWiki-Gallery, VisualEditor

Dec 2 2016

ArgonSim awarded T150638: Impossible to create a gallery on some wikis using VE a Baby Tequila token.
Dec 2 2016, 1:51 AM · MW-1.29-release (WMF-deploy-2016-11-15_(1.29.0-wmf.3)), VisualEditor-MediaWiki-Media, MediaWiki-Gallery, VisualEditor

Nov 30 2016

Tchanders claimed T151506: "Add new image" button in gallery is difficult to discover after adding 4/5 images, since the button floats down as the list grows.
Nov 30 2016, 8:44 PM · Verified, MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)), Design, VisualEditor-MediaWiki-Media, MediaWiki-Gallery, VisualEditor
Tchanders added a comment to T150638: Impossible to create a gallery on some wikis using VE.

@ArgonSim @Trizek-WMF Thanks for the examples. (The second gallery on the French page works because it has prefixes, but not the first gallery. The above patch fixes the no-prefix case.)

Nov 30 2016, 8:12 PM · MW-1.29-release (WMF-deploy-2016-11-15_(1.29.0-wmf.3)), VisualEditor-MediaWiki-Media, MediaWiki-Gallery, VisualEditor