Page MenuHomePhabricator

Tchanders
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Sep 13 2015, 10:17 PM (197 w, 2 d)
Availability
Available
LDAP User
Tchanders
MediaWiki User
Unknown

Recent Activity

Today

Tchanders claimed T212326: Overlapping blocks may display incorrect block notice.
Wed, Jun 26, 3:23 PM · Anti-Harassment (Mem - מ), MediaWiki-User-management
Tchanders moved T212326: Overlapping blocks may display incorrect block notice from Ready to In Progress on the Anti-Harassment (Mem - מ) board.
Wed, Jun 26, 3:23 PM · Anti-Harassment (Mem - מ), MediaWiki-User-management

Yesterday

Tchanders moved T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser from Review to QA/Testing on the Anti-Harassment (Mem - מ) board.
Tue, Jun 25, 5:34 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Anti-Harassment (Mem - מ), Patch-For-Review, MediaWiki-Email
Tchanders added a comment to T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does.

@Niharika Not that I'm aware of, it just came up in code review because of the messages

Tue, Jun 25, 5:03 PM · Anti-Harassment (Mem - מ), Patch-For-Review, MediaWiki-extensions-CentralAuth, Stewards-and-global-tools, MediaWiki-User-management
Tchanders added a comment to T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does.

@Niharika @dbarratt I have a question about how to display the list when there are a mix of local and global namespaces in the block.

Tue, Jun 25, 2:14 PM · Anti-Harassment (Mem - מ), Patch-For-Review, MediaWiki-extensions-CentralAuth, Stewards-and-global-tools, MediaWiki-User-management

Sat, Jun 22

Tchanders added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

@Niharika @dmaza There are a few places where the acceptance criteria don't match the behaviour of the patch (PS20). I suspect in some cases the acceptance criteria might just be old, so commenting here instead of in code review.

Sat, Jun 22, 12:33 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Anti-Harassment (Mem - מ), Patch-For-Review, MediaWiki-Email

Fri, Jun 21

Tchanders moved T225919: Single blocks are sometimes interpreted as multiple blocks from Review to QA/Testing on the Anti-Harassment (Mem - מ) board.
Fri, Jun 21, 4:37 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Anti-Harassment (Mem - מ)

Thu, Jun 20

Tchanders added a comment to T225919: Single blocks are sometimes interpreted as multiple blocks.

Steps to trigger the bug (needs $wgCookieSetOnAutoblock = true):

Thu, Jun 20, 7:06 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Anti-Harassment (Mem - מ)
Tchanders updated the task description for T225015: Communicate changes to Block class to the community.
Thu, Jun 20, 6:50 PM · Anti-Harassment (Mem - מ)
Tchanders updated the task description for T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock.
Thu, Jun 20, 2:56 PM · Anti-Harassment (Lāmed - ל), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, MediaWiki-User-management
Tchanders updated the task description for T221117: Special:Block checkboxes should remember checked state.
Thu, Jun 20, 1:52 PM · Anti-Harassment (Mem - מ)
Tchanders moved T225919: Single blocks are sometimes interpreted as multiple blocks from QA/Testing to Review on the Anti-Harassment (Lāmed - ל) board.
Thu, Jun 20, 11:13 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Anti-Harassment (Mem - מ)
Tchanders added a comment to T225919: Single blocks are sometimes interpreted as multiple blocks.

It seems worth fixing, since the block message will be more informative. In theory this problem could also arise in other ways; at the moment, autoblocks are only filtered out if they are found in the same database request as their parent block.

Thu, Jun 20, 11:02 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Anti-Harassment (Mem - מ)

Tue, Jun 18

Tchanders moved T225919: Single blocks are sometimes interpreted as multiple blocks from Review to QA/Testing on the Anti-Harassment (Lāmed - ל) board.
Tue, Jun 18, 1:43 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Anti-Harassment (Mem - מ)

Mon, Jun 17

Tchanders updated subscribers of T225939: System and composite block messages on mobile contain confusing information.
Mon, Jun 17, 1:29 PM · Anti-Harassment
Tchanders added a comment to T225748: Fix block message for CompositeBlocks.

@dom_walden I think this bug probably doesn't cover these problems, since they both apply to the existing SystemBlock messages too. However, they should be fixed. Filed as: T225939

Mon, Jun 17, 1:28 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
Tchanders created T225939: System and composite block messages on mobile contain confusing information.
Mon, Jun 17, 1:27 PM · Anti-Harassment
Tchanders moved T225919: Single blocks are sometimes interpreted as multiple blocks from Ready to Review on the Anti-Harassment (Lāmed - ל) board.
Mon, Jun 17, 12:35 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Anti-Harassment (Mem - מ)
Tchanders edited projects for T225919: Single blocks are sometimes interpreted as multiple blocks, added: Anti-Harassment (Lāmed - ל); removed Anti-Harassment.
Mon, Jun 17, 12:35 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Anti-Harassment (Mem - מ)
Tchanders updated subscribers of T225872: not possible to set email when email blocked.

Thanks for reporting. It looks like it has been this way for a while (e.g. rolling back to 1.33.0, before the refactoring). @Niharika @SPoore would you have any concerns about allowing a user who is blocked from sending email to change their email address?

Mon, Jun 17, 10:30 AM · User-DannyS712, Anti-Harassment, MediaWiki-Email, MediaWiki-User-management
Tchanders created T225919: Single blocks are sometimes interpreted as multiple blocks.
Mon, Jun 17, 10:17 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Anti-Harassment (Mem - מ)

Sat, Jun 15

Tchanders created T225860: HTMLSelectAndOtherField has some issues with the default value and validation.
Sat, Jun 15, 9:33 AM · MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), MediaWiki-HTMLForm, Patch-For-Review, Anti-Harassment

Fri, Jun 14

Tchanders added a comment to T225748: Fix block message for CompositeBlocks.

For testing/reviewing, this change affects:

  • the error shown on trying to edit a page if at least one of the blocks applies to that page
  • the error shown on Special:EmailUser if at least one of the blocks prevents email
Fri, Jun 14, 3:39 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
Tchanders moved T225748: Fix block message for CompositeBlocks from Ready to Review on the Anti-Harassment (Lāmed - ל) board.
Fri, Jun 14, 8:33 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management

Thu, Jun 13

Tchanders updated the task description for T225748: Fix block message for CompositeBlocks.
Thu, Jun 13, 6:55 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
Tchanders created T225748: Fix block message for CompositeBlocks.
Thu, Jun 13, 6:53 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
Tchanders moved T206163: Restrictions of overlapping blocks should be merged on enforcement from Review to QA/Testing on the Anti-Harassment (Lāmed - ל) board.
Thu, Jun 13, 2:16 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
Tchanders added a comment to T222170: InvalidArgumentException from SpecialBlock.php: "$comment can not be null".

@A2093064 The broken appearance of the page seems to be down to the MediaWiki:Group-sysop.js script.

Thu, Jun 13, 11:48 AM · Anti-Harassment, MediaWiki-User-management, MediaWiki-Comment-backend, Wikimedia-production-error, Chinese-Sites

Wed, Jun 12

Tchanders created T225654: Work out how to track blocks with a cookie if there are multiple trackable blocks.
Wed, Jun 12, 6:05 PM · MediaWiki-User-management, Anti-Harassment
Tchanders set the point value for T220642: Only show the feedback link on Special:Block to users who can access the page to 1.

(Didn't mean to remove the points value there, but since I did, replacing with something more accurate...)

Wed, Jun 12, 2:18 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
Tchanders removed the point value for T220642: Only show the feedback link on Special:Block to users who can access the page.

I notice that I do see the link if I am an admin user who is blocked, even though being blocked means I cannot use Special:Block. I am assuming this is not a major problem.

Wed, Jun 12, 2:00 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
Tchanders added a comment to T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities.

So I guess we use BlockManager to get the blocks of a user?

You can use either User::getBlock() or BlockManager::getUserBlock(). They are slightly different, but for your purposes, it should always return the same result.

Wed, Jun 12, 12:51 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Anti-Harassment, MediaWiki-extensions-WikibaseRepository, Wikidata

Tue, Jun 11

Tchanders moved T225141: Move cookie-related logic from User and Block to BlockManager from Review to QA/Testing on the Anti-Harassment (Lāmed - ל) board.
Tue, Jun 11, 3:39 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management

Mon, Jun 10

Tchanders claimed T225141: Move cookie-related logic from User and Block to BlockManager.
Mon, Jun 10, 4:50 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
Tchanders moved T225141: Move cookie-related logic from User and Block to BlockManager from Ready to Review on the Anti-Harassment (Lāmed - ל) board.
Mon, Jun 10, 4:50 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
Tchanders edited projects for T225141: Move cookie-related logic from User and Block to BlockManager, added: Anti-Harassment (Lāmed - ל); removed Anti-Harassment.
Mon, Jun 10, 4:50 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
Tchanders moved T220642: Only show the feedback link on Special:Block to users who can access the page from Review to QA/Testing on the Anti-Harassment (Lāmed - ל) board.
Mon, Jun 10, 1:41 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management

Fri, Jun 7

Tchanders updated subscribers of T225141: Move cookie-related logic from User and Block to BlockManager.

@dmaza, @dbarratt and I have discussed separating the cookie blocking service from the BlockManager. @daniel do you have an opinion on this?

Fri, Jun 7, 6:20 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
Tchanders added a comment to T222170: InvalidArgumentException from SpecialBlock.php: "$comment can not be null".

@A2093064 Thanks for the screenshot.

Fri, Jun 7, 4:08 PM · Anti-Harassment, MediaWiki-User-management, MediaWiki-Comment-backend, Wikimedia-production-error, Chinese-Sites

Thu, Jun 6

Tchanders added a comment to T225251: ApiBlockTest::testBlockingToManyPageRestrictions Failed asserting that exception of type "ApiUsageException" is thrown..

@Reedy Yes, that test should only be 1.33+

Thu, Jun 6, 9:28 PM · MW-1.32-release, MediaWiki-API, MW-1.31-release
Tchanders created T225250: Store block options as flags.
Thu, Jun 6, 8:27 PM · MediaWiki-User-management

Wed, Jun 5

Tchanders moved T220642: Only show the feedback link on Special:Block to users who can access the page from Ready to Review on the Anti-Harassment (Lāmed - ל) board.
Wed, Jun 5, 10:40 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
Tchanders claimed T220642: Only show the feedback link on Special:Block to users who can access the page.
Wed, Jun 5, 10:40 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
Tchanders added a comment to T221682: Improve Block handling where User::isBlocked() was used previously.

I can't remember if we said we'd split this up, but if so then the tagging is already filed as T221444

Wed, Jun 5, 8:55 PM · Anti-Harassment (Mem - מ), Patch-For-Review, Technical-Debt, MediaWiki-User-management
Tchanders moved T221383: SpecialBlock should not be aware of the container from Backlog to User blocking on the MediaWiki-User-management board.
Wed, Jun 5, 8:54 PM · Technical-Debt, MediaWiki-User-management
Tchanders moved T221066: Move methods from Block to BlockManager from Backlog to User blocking on the MediaWiki-User-management board.
Wed, Jun 5, 8:53 PM · Anti-Harassment (Mem - מ), MediaWiki-User-management
Tchanders moved T221444: Partially blocked users cannot tag revisions on unrelated pages, nor add, deactive or delete tags from Backlog to User blocking on the MediaWiki-User-management board.
Wed, Jun 5, 8:52 PM · Patch-For-Review, MediaWiki-User-management, MediaWiki-Change-tagging
Tchanders moved T221682: Improve Block handling where User::isBlocked() was used previously from Backlog to User blocking on the MediaWiki-User-management board.
Wed, Jun 5, 8:51 PM · Anti-Harassment (Mem - מ), Patch-For-Review, Technical-Debt, MediaWiki-User-management
Tchanders moved T221743: wgProxyList: Does/Should it work with CIDR ranges? from Backlog to User blocking on the MediaWiki-User-management board.
Wed, Jun 5, 8:51 PM · MediaWiki-User-management, MediaWiki-Documentation
Tchanders moved T222281: Add a way to disable a users session and log them out when blocking from Backlog to User blocking on the MediaWiki-User-management board.
Wed, Jun 5, 8:51 PM · MediaWiki-User-management
Tchanders moved T222382: Offer different time limits when blocking a user and their IP address from Backlog to User blocking on the MediaWiki-User-management board.
Wed, Jun 5, 8:50 PM · MediaWiki-User-management
Tchanders moved T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock from Backlog to User blocking on the MediaWiki-User-management board.
Wed, Jun 5, 8:49 PM · Anti-Harassment (Lāmed - ל), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, MediaWiki-User-management
Tchanders moved T224046: $wgProxyList allows account create from Backlog to User blocking on the MediaWiki-User-management board.
Wed, Jun 5, 8:49 PM · MediaWiki-User-management, MediaWiki-User-login-and-signup
Tchanders moved T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks from Backlog to User blocking on the MediaWiki-User-management board.
Wed, Jun 5, 8:49 PM · Anti-Harassment (Mem - מ), MediaWiki-User-management
Tchanders moved T225016: Make block objects immutable from Backlog to User blocking on the MediaWiki-User-management board.
Wed, Jun 5, 8:49 PM · MediaWiki-User-management
Tchanders moved T225141: Move cookie-related logic from User and Block to BlockManager from Backlog to User blocking on the MediaWiki-User-management board.
Wed, Jun 5, 8:49 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
Tchanders moved T225141: Move cookie-related logic from User and Block to BlockManager from Untriaged to Cards ready to be estimated on the Anti-Harassment board.
Wed, Jun 5, 8:42 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
Tchanders updated subscribers of T206163: Restrictions of overlapping blocks should be merged on enforcement.

@Mooeypoo @dmaza @dbarratt As discussed, MultipleBlock might be too easily confused with the concept of storing multiple blocks against exactly the same target; whereas this work is about enforcing (but not storing) multiple blocks against different targets that all apply to a given user.

Wed, Jun 5, 8:41 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
Tchanders created T225141: Move cookie-related logic from User and Block to BlockManager.
Wed, Jun 5, 7:24 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), MediaWiki-User-management
Tchanders moved T225011: Clean up code related to blocking from Backlog to User blocking on the MediaWiki-User-management board.
Wed, Jun 5, 7:18 PM · MediaWiki-User-management
Tchanders edited projects for T221117: Special:Block checkboxes should remember checked state, added: Anti-Harassment (Lāmed - ל); removed Anti-Harassment.
Wed, Jun 5, 6:25 PM · Anti-Harassment (Mem - מ)
Tchanders added a comment to T206163: Restrictions of overlapping blocks should be merged on enforcement.

(I had a quick check that it does allow a logged-in user to create an account if the block allows account creation)

Wed, Jun 5, 4:28 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
Tchanders added a comment to T206163: Restrictions of overlapping blocks should be merged on enforcement.

@dom_walden It turns out that is intentional, according to: https://github.com/wikimedia/mediawiki/blob/master/includes/user/User.php#L4377 - I can't find it documented anywhere else.

Wed, Jun 5, 4:18 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management

Tue, Jun 4

Tchanders committed rWTDTeebce876b036: T213490 Fix timezone of time picker (authored by dbarratt).
T213490 Fix timezone of time picker
Tue, Jun 4, 8:43 PM
Tchanders moved T213490: Takedown tools: Datepicker picking wrong dates, submitting totally different figures from Review to QA/Testing on the Anti-Harassment (Kaf - כ) board.
Tue, Jun 4, 8:41 PM · Anti-Harassment (Lāmed - ל), Wikimedia-Takedown-Tools
Tchanders updated the task description for T206163: Restrictions of overlapping blocks should be merged on enforcement.
Tue, Jun 4, 8:01 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
Tchanders moved T224704: CI build failing for some ext repos due to PhanUndeclaredClassMethod "undeclared class \Block" from In Progress to Done on the Anti-Harassment (Kaf - כ) board.
Tue, Jun 4, 7:39 PM · Anti-Harassment (Lāmed - ל), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Growth-Team, PageCuration, Wikimedia-production-error (Shared Build Failure)
Tchanders updated the task description for T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock.
Tue, Jun 4, 7:36 PM · Anti-Harassment (Lāmed - ל), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, MediaWiki-User-management
Tchanders added a parent task for T219441: Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP: T225011: Clean up code related to blocking.
Tue, Jun 4, 7:34 PM · Anti-Harassment (Yōd - י), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Core Platform Team Backlog (Watching / External), MediaWiki-User-management
Tchanders added subtasks for T225011: Clean up code related to blocking: T219441: Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP, T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock.
Tue, Jun 4, 7:34 PM · MediaWiki-User-management
Tchanders added a parent task for T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock: T225011: Clean up code related to blocking.
Tue, Jun 4, 7:34 PM · Anti-Harassment (Lāmed - ל), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, MediaWiki-User-management
Tchanders created T225016: Make block objects immutable.
Tue, Jun 4, 7:16 PM · MediaWiki-User-management
Tchanders added subtasks for T225011: Clean up code related to blocking: T221066: Move methods from Block to BlockManager, T221067: Move block-related methods on User to the BlockManager, T221075: Introduce a BlockStore service.
Tue, Jun 4, 5:58 PM · MediaWiki-User-management
Tchanders added a parent task for T221066: Move methods from Block to BlockManager: T225011: Clean up code related to blocking.
Tue, Jun 4, 5:58 PM · Anti-Harassment (Mem - מ), MediaWiki-User-management
Tchanders added a parent task for T221067: Move block-related methods on User to the BlockManager: T225011: Clean up code related to blocking.
Tue, Jun 4, 5:58 PM · MediaWiki-User-management
Tchanders added a parent task for T221075: Introduce a BlockStore service: T225011: Clean up code related to blocking.
Tue, Jun 4, 5:58 PM · Technical-Debt, MediaWiki-User-management
Tchanders created T225011: Clean up code related to blocking.
Tue, Jun 4, 5:55 PM · MediaWiki-User-management

Mon, Jun 3

Tchanders updated subscribers of T222170: InvalidArgumentException from SpecialBlock.php: "$comment can not be null".
Mon, Jun 3, 2:56 PM · Anti-Harassment, MediaWiki-User-management, MediaWiki-Comment-backend, Wikimedia-production-error, Chinese-Sites
Tchanders added a comment to T222170: InvalidArgumentException from SpecialBlock.php: "$comment can not be null".

We could display an error message, but if we do that then we should try to be consistent across all forms, ie always be prepared to handle submission of forms that haven't loaded properly.

Mon, Jun 3, 2:55 PM · Anti-Harassment, MediaWiki-User-management, MediaWiki-Comment-backend, Wikimedia-production-error, Chinese-Sites
Tchanders committed rEJADd0975af583c5: Use setter to set DatabaseBlock $hideName property (authored by Tchanders).
Use setter to set DatabaseBlock $hideName property
Mon, Jun 3, 2:46 PM

Fri, May 31

Tchanders committed rEJADbe0850f88446: Use MediaWiki\Block\DatabaseBlock instead of Block (authored by Tchanders).
Use MediaWiki\Block\DatabaseBlock instead of Block
Fri, May 31, 4:34 PM
Tchanders added a comment to T224704: CI build failing for some ext repos due to PhanUndeclaredClassMethod "undeclared class \Block".

Thanks @Jdforrester-WMF and @Umherirrender. The extensions that document @param Block, @var Block and @return Block should now have patches updating all their references to Block, tagged with this task.

Fri, May 31, 2:29 PM · Anti-Harassment (Lāmed - ל), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Growth-Team, PageCuration, Wikimedia-production-error (Shared Build Failure)

Thu, May 30

Tchanders added a comment to T224704: CI build failing for some ext repos due to PhanUndeclaredClassMethod "undeclared class \Block".

We can update the affected extensions.

Thu, May 30, 11:30 PM · Anti-Harassment (Lāmed - ל), MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), Growth-Team, PageCuration, Wikimedia-production-error (Shared Build Failure)
Tchanders added a comment to T224046: $wgProxyList allows account create.

AuthManager is calling BlockManager::isDnsBlacklisted directly, independently of checking the user's block. This leads to some odd effects:
(1) An unblocked user with the 'ipblock-exempt' right can still be blocked from creating an account from an affected IP, even though they will be unaffected by the block otherwise.
(2) As @dom_walden points out, DNS blacklisted IPs get special treatment, whereas proxy list IPs don't.

Thu, May 30, 9:25 PM · MediaWiki-User-management, MediaWiki-User-login-and-signup
Tchanders claimed T221066: Move methods from Block to BlockManager.
Thu, May 30, 4:42 PM · Anti-Harassment (Mem - מ), MediaWiki-User-management
Tchanders moved T221066: Move methods from Block to BlockManager from Ready to In Progress on the Anti-Harassment (Kaf - כ) board.
Thu, May 30, 4:41 PM · Anti-Harassment (Mem - מ), MediaWiki-User-management

Wed, May 29

Tchanders added a comment to T206163: Restrictions of overlapping blocks should be merged on enforcement.

@dom_walden Thanks for reporting these - they should be fixed now.

Wed, May 29, 8:42 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
Tchanders updated the task description for T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock.
Wed, May 29, 8:40 PM · Anti-Harassment (Lāmed - ל), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, MediaWiki-User-management
Tchanders updated the task description for T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock.
Wed, May 29, 8:38 PM · Anti-Harassment (Lāmed - ל), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, MediaWiki-User-management
Tchanders added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

What @dbarratt is describing is similar to how Special:Preferences currently works: you arrive at Special:Preferences with the current state and a disabled "Save" button. If you change the state, the "Save" button is enabled, signalling that you've made a change.

Wed, May 29, 4:58 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Anti-Harassment (Mem - מ), Patch-For-Review, MediaWiki-Email

Tue, May 28

Tchanders added a project to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks: Anti-Harassment.
Tue, May 28, 2:29 PM · Anti-Harassment (Mem - מ), MediaWiki-User-management
Tchanders added a comment to T224032: [BUG] Blocking from action "Editing their own talk page" is not effective unless "Editing" is also checked.

@dom_walden I agree - filed as T224468

Tue, May 28, 12:05 PM · MediaWiki-User-management, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Anti-Harassment (Kaf - כ)
Tchanders created T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.
Tue, May 28, 12:04 PM · Anti-Harassment (Mem - מ), MediaWiki-User-management
Tchanders moved T206163: Restrictions of overlapping blocks should be merged on enforcement from In Progress to Review on the Anti-Harassment (Kaf - כ) board.
Tue, May 28, 11:37 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management

May 24 2019

Tchanders moved T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock from Done to Review on the Anti-Harassment (Yōd - י) board.
May 24 2019, 1:24 PM · Anti-Harassment (Lāmed - ל), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, MediaWiki-User-management
Tchanders updated the task description for T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock.
May 24 2019, 1:24 PM · Anti-Harassment (Lāmed - ל), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, MediaWiki-User-management
Tchanders reopened T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock as "Open".

Reopening because the checklist isn't complete

May 24 2019, 1:24 PM · Anti-Harassment (Lāmed - ל), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, MediaWiki-User-management
Tchanders reopened T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock, a subtask of T206163: Restrictions of overlapping blocks should be merged on enforcement, as Open.
May 24 2019, 1:23 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
Tchanders updated the task description for T206163: Restrictions of overlapping blocks should be merged on enforcement.
May 24 2019, 1:20 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management
Tchanders moved T206163: Restrictions of overlapping blocks should be merged on enforcement from Review to In Progress on the Anti-Harassment (Yōd - י) board.
May 24 2019, 1:18 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management