Page MenuHomePhabricator

Tchanders
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 13 2015, 10:17 PM (213 w, 4 d)
Availability
Available
LDAP User
Tchanders
MediaWiki User
Unknown

Recent Activity

Yesterday

Tchanders moved T227110: Provide more informative block error message for Special:CreateAccount from Backlog to Cards ready to be discussed on the Anti-Harassment board.
Thu, Oct 17, 5:59 PM · Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-User-management, MediaWiki-User-login-and-signup
Tchanders added a comment to T221066: Move methods from Block to BlockManager.

@Niharika Yes that's fine

Thu, Oct 17, 2:05 PM · MediaWiki-User-management
Tchanders created T235762: Replace deprecated block methods in CheckUser.
Thu, Oct 17, 1:52 PM · Technical-Debt, CheckUser, Anti-Harassment
Tchanders updated subscribers of T233206: Block message for partial blocks is potentially misleading.

I've updated the description to go into more detail about some of the problems with the partial block message.

Thu, Oct 17, 1:07 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MediaWiki-User-management, Anti-Harassment
Tchanders updated the task description for T233206: Block message for partial blocks is potentially misleading.
Thu, Oct 17, 12:27 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MediaWiki-User-management, Anti-Harassment

Tue, Oct 15

Tchanders renamed T226990: Block messages are inconsistent if a user is blocked from email from Block messages are inconsistent if a user is partially blocked and blocked from email to Block messages are inconsistent if a user is blocked from email.
Tue, Oct 15, 4:22 PM · Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
Tchanders added a comment to T227174: Improve the consistency of block error notices.

@dom_walden The block message for Special:EmailUser is pretty broken... Before this task, if one of the blocks is sitewide the message looks like this:

Tue, Oct 15, 2:08 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Anti-Harassment (The Letter Song), MediaWiki-User-management
Tchanders updated subscribers of T233595: Clear block cookie when tracking block, not when checking block.
  • If you are logged in with an autoblock against your username, when you log out the block cookie is immediately removed. Previously, the cookie would remain, even after you perform a blockable action (e.g. editing). This seems to be a regression.
Tue, Oct 15, 12:37 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MediaWiki-User-management, Anti-Harassment (The Letter Song)

Thu, Oct 10

Tchanders moved T196575: Add block cookie for browser-based API edits (including VisualEditor & MobileFrontend) from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Thu, Oct 10, 8:36 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-User-management
Tchanders added a comment to T233594: Allow cookie-block tracking from any uncached web request.

@Niharika We should be able to close T227901 once all WMF sites are on 1.35.0-wmf.1. The logs will still be recording that warning until then.

Thu, Oct 10, 5:40 PM · Performance-Team (Radar), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-User-management, Anti-Harassment (The Letter Song)

Wed, Oct 9

Tchanders added a comment to T227901: PHP warning on attempting to set a block cookie after CentralAuth auto login.

@Krinkle Sorry should have clarified - this should be fixed in 1.35.0-wmf.1

Wed, Oct 9, 4:39 PM · MediaWiki-User-management, MediaWiki-extensions-CentralAuth, Anti-Harassment, Wikimedia-production-error
Tchanders updated subscribers of T233441: Autoblocks apply regardless of ipblock-exempt right.
Wed, Oct 9, 3:50 PM · MediaWiki-User-management
Tchanders updated the task description for T233595: Clear block cookie when tracking block, not when checking block.
Wed, Oct 9, 1:35 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MediaWiki-User-management, Anti-Harassment (The Letter Song)
Tchanders added a comment to T233595: Clear block cookie when tracking block, not when checking block.

@Niharika That's an interesting point.

Wed, Oct 9, 1:20 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MediaWiki-User-management, Anti-Harassment (The Letter Song)
Tchanders added a comment to T233595: Clear block cookie when tracking block, not when checking block.

@Niharika Thanks for providing the alternative perspective.

Wed, Oct 9, 12:32 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MediaWiki-User-management, Anti-Harassment (The Letter Song)
Tchanders added a comment to T233595: Clear block cookie when tracking block, not when checking block.

@Niharika I'd argue that the behaviour should be changed.

Wed, Oct 9, 10:33 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MediaWiki-User-management, Anti-Harassment (The Letter Song)

Tue, Oct 8

Tchanders added a comment to T233595: Clear block cookie when tracking block, not when checking block.

@Niharika should block cookies be a rolling 24 hours or a should it be a hard 24 hours? Right now, the block cookie is set for 24 hours, and regardless of how many attempts you make, it will expire in 24 hours. With this change, if you make an uncached request to MediaWiki, the block cookie expiration will be reset.

Tue, Oct 8, 10:53 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MediaWiki-User-management, Anti-Harassment (The Letter Song)
Tchanders added a comment to T227901: PHP warning on attempting to set a block cookie after CentralAuth auto login.

This should be fixed since https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/534933/ which removed the DeferredUpdates from the BlockManager.

Tue, Oct 8, 8:41 PM · MediaWiki-User-management, MediaWiki-extensions-CentralAuth, Anti-Harassment, Wikimedia-production-error
Tchanders merged task T230153: WebResponse: Cannot modify header information - headers already sent by SpecialCentralAutoLogin.php into T227901: PHP warning on attempting to set a block cookie after CentralAuth auto login.
Tue, Oct 8, 8:33 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-CentralAuth, Commons, Wikimedia-production-error
Tchanders merged T230153: WebResponse: Cannot modify header information - headers already sent by SpecialCentralAutoLogin.php into T227901: PHP warning on attempting to set a block cookie after CentralAuth auto login.
Tue, Oct 8, 8:33 PM · MediaWiki-User-management, MediaWiki-extensions-CentralAuth, Anti-Harassment, Wikimedia-production-error

Mon, Oct 7

Tchanders reopened T233594: Allow cookie-block tracking from any uncached web request, a subtask of T196575: Add block cookie for browser-based API edits (including VisualEditor & MobileFrontend), as Open.
Mon, Oct 7, 4:41 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-User-management
Tchanders reopened T233594: Allow cookie-block tracking from any uncached web request, a subtask of T233595: Clear block cookie when tracking block, not when checking block, as Open.
Mon, Oct 7, 4:41 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MediaWiki-User-management, Anti-Harassment (The Letter Song)
Tchanders reopened T233594: Allow cookie-block tracking from any uncached web request as "Open".

Just re-opening this until signed off by QA

Mon, Oct 7, 4:41 PM · Performance-Team (Radar), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-User-management, Anti-Harassment (The Letter Song)
Tchanders moved T232510: Add namespace filter to the interaction-timeline API from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Mon, Oct 7, 4:00 PM · Anti-Harassment (The Letter Song), InteractionTimeline
Tchanders added a comment to T233595: Clear block cookie when tracking block, not when checking block.

@dbarratt Yes - tagged.

Mon, Oct 7, 12:59 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MediaWiki-User-management, Anti-Harassment (The Letter Song)

Fri, Oct 4

Tchanders updated the task description for T227110: Provide more informative block error message for Special:CreateAccount.
Fri, Oct 4, 3:22 PM · Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-User-management, MediaWiki-User-login-and-signup

Wed, Oct 2

Tchanders added a comment to T233595: Clear block cookie when tracking block, not when checking block.

@dbarratt It will expire, but the block may be removed first.

Wed, Oct 2, 3:26 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MediaWiki-User-management, Anti-Harassment (The Letter Song)
Tchanders added a parent task for T227174: Improve the consistency of block error notices: T234406: Pass the relevant and necessary context information to UserBlockedError.
Wed, Oct 2, 12:07 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Anti-Harassment (The Letter Song), MediaWiki-User-management
Tchanders added a subtask for T234406: Pass the relevant and necessary context information to UserBlockedError: T227174: Improve the consistency of block error notices.
Wed, Oct 2, 12:06 AM · Patch-For-Review, MediaWiki-User-management, Anti-Harassment (The Letter Song)
Tchanders created T234406: Pass the relevant and necessary context information to UserBlockedError.
Wed, Oct 2, 12:06 AM · Patch-For-Review, MediaWiki-User-management, Anti-Harassment (The Letter Song)

Mon, Sep 30

Tchanders added a comment to T233996: Mobile block notice not showing block reason or block log entry for global blocks.

The problem seems to be that only the global block is being reported, but not the local block (e.g. see the reported blocker name).

Mon, Sep 30, 7:57 PM · Anti-Harassment (The Letter Song), Stewards-and-global-tools, VisualEditor, Mobile, MediaWiki-User-management

Tue, Sep 24

Tchanders added a comment to T233441: Autoblocks apply regardless of ipblock-exempt right.

I believe my argument for that patch was that cookie blocking should be a standard feature and thus be enabled by default in core.

Tue, Sep 24, 8:06 AM · MediaWiki-User-management

Mon, Sep 23

Tchanders updated subscribers of T233441: Autoblocks apply regardless of ipblock-exempt right.

@dmaza - do you have any thoughts on changing the config back to false in core?

Mon, Sep 23, 5:35 PM · MediaWiki-User-management
Tchanders added a subtask for T196575: Add block cookie for browser-based API edits (including VisualEditor & MobileFrontend): T233594: Allow cookie-block tracking from any uncached web request.
Mon, Sep 23, 10:07 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-User-management
Tchanders added a subtask for T233595: Clear block cookie when tracking block, not when checking block: T233594: Allow cookie-block tracking from any uncached web request.
Mon, Sep 23, 10:07 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MediaWiki-User-management, Anti-Harassment (The Letter Song)
Tchanders added parent tasks for T233594: Allow cookie-block tracking from any uncached web request: T196575: Add block cookie for browser-based API edits (including VisualEditor & MobileFrontend), T233595: Clear block cookie when tracking block, not when checking block.
Mon, Sep 23, 10:07 AM · Performance-Team (Radar), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-User-management, Anti-Harassment (The Letter Song)
Tchanders moved T233594: Allow cookie-block tracking from any uncached web request from Ready to Review on the Anti-Harassment (The Letter Song) board.
Mon, Sep 23, 10:05 AM · Performance-Team (Radar), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-User-management, Anti-Harassment (The Letter Song)
Tchanders moved T233595: Clear block cookie when tracking block, not when checking block from Ready to Review on the Anti-Harassment (The Letter Song) board.
Mon, Sep 23, 10:05 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MediaWiki-User-management, Anti-Harassment (The Letter Song)
Tchanders moved T233597: Refactor ApiMain to use OutputPage::sendCacheControl from Ready to Review on the Anti-Harassment (The Letter Song) board.
Mon, Sep 23, 10:05 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-API
Tchanders renamed T233597: Refactor ApiMain to use OutputPage::sendCacheControl from Refactor ApiMAin to use OutputPage::sendCacheControl to Refactor ApiMain to use OutputPage::sendCacheControl.
Mon, Sep 23, 10:05 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-API
Tchanders created T233597: Refactor ApiMain to use OutputPage::sendCacheControl.
Mon, Sep 23, 10:05 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-API
Tchanders created T233595: Clear block cookie when tracking block, not when checking block.
Mon, Sep 23, 10:02 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MediaWiki-User-management, Anti-Harassment (The Letter Song)
Tchanders created T233594: Allow cookie-block tracking from any uncached web request.
Mon, Sep 23, 10:00 AM · Performance-Team (Radar), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-User-management, Anti-Harassment (The Letter Song)
Tchanders moved T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages from Ready to Review on the Anti-Harassment (The Letter Song) board.
Mon, Sep 23, 9:42 AM · Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-User-management
Tchanders moved T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages from Cards ready to be discussed to The Letter Song on the Anti-Harassment board.
Mon, Sep 23, 9:41 AM · Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-User-management
Tchanders claimed T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages.
Mon, Sep 23, 9:41 AM · Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-User-management
Tchanders moved T227174: Improve the consistency of block error notices from In Progress to Review on the Anti-Harassment (The Letter Song) board.
Mon, Sep 23, 9:41 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Anti-Harassment (The Letter Song), MediaWiki-User-management

Sun, Sep 22

Tchanders added a comment to T231943: Uncheck "Automatically block the last IP address" by default on Special:Block on officewiki.

@DannyS712 Thanks for pointing out that task. (See T233441#5513467 - the problem is with cookie blocks and won't affect users on different devices.)

Sun, Sep 22, 8:50 AM · Anti-Harassment, Patch-For-Review, User-DannyS712, MediaWiki-User-management, MediaWiki-Special-pages, Wikimedia-Site-requests, Office-IT
Tchanders updated subscribers of T233441: Autoblocks apply regardless of ipblock-exempt right.

Thanks for reporting - this appears to be happening because of cookie blocks rather than autoblocks. Following the steps locally, I find:

  • the sysop is only blocked if cookie blocks are enabled ($wgCookieSetOnAutoblock = true)
  • the sysop sees the same block message as the blocked user, rather than the autoblock message
  • the block ID cookie is set
Sun, Sep 22, 8:42 AM · MediaWiki-User-management

Fri, Sep 20

Tchanders added a comment to T231943: Uncheck "Automatically block the last IP address" by default on Special:Block on officewiki.

I think the question of whether a logged-in user is ever expected to be blocked by an IP block on office wiki is relevant: if the answer is no, then the 'ipblock-exempt' right should be granted to all users, regardless of this task (and then the problem that this task is trying to fix would be solved).

Fri, Sep 20, 2:46 AM · Anti-Harassment, Patch-For-Review, User-DannyS712, MediaWiki-User-management, MediaWiki-Special-pages, Wikimedia-Site-requests, Office-IT

Thu, Sep 19

Tchanders added a comment to T231943: Uncheck "Automatically block the last IP address" by default on Special:Block on officewiki.

@Tchanders you're making a good point about this; however, this will only fix the underlying ask tangentially. It would mean that the checkbox being selected won't matter, but it won't actually unselect that checkbox.

Thu, Sep 19, 11:00 PM · Anti-Harassment, Patch-For-Review, User-DannyS712, MediaWiki-User-management, MediaWiki-Special-pages, Wikimedia-Site-requests, Office-IT
Tchanders updated subscribers of T217363: Consider minimizing the presence of Partial Blocks UI elements on Special:Block.

@Volker_E Are there any accessibility reasons for recommending enable/disable over hide/show?

Thu, Sep 19, 10:07 AM · Patch-For-Review, User-DannyS712, MediaWiki-Interface, WMF-Design, Design, MediaWiki-User-management, Anti-Harassment
Tchanders added a comment to T231943: Uncheck "Automatically block the last IP address" by default on Special:Block on officewiki.

I agree that it feels a bit problematic to make assumptions about autoblocks based on the $wgBlockDisablesLogin config. I'm not sure I agree the checking of $wgBlockDisablesLogin and isEveryoneAllowed('read') is much better - it's less impactful, but the principle is the same. (If a wiki with these settings wanted the checkbox checked by default, what would we do?)

Thu, Sep 19, 9:25 AM · Anti-Harassment, Patch-For-Review, User-DannyS712, MediaWiki-User-management, MediaWiki-Special-pages, Wikimedia-Site-requests, Office-IT

Sep 18 2019

Tchanders added a comment to T233119: Intended use of MinimumPasswordLengthToLogin not so clear.

@Anomie That's correct - thank you for summarising so clearly for future readers of this task.

Sep 18 2019, 9:19 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.31-release-notes, MW-1.32-notes, MW-1.33-notes, Documentation, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Trust-and-Safety, MediaWiki-Authentication-and-authorization, Anti-Harassment, MediaWiki-User-login-and-signup
Tchanders created T233206: Block message for partial blocks is potentially misleading.
Sep 18 2019, 11:29 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MediaWiki-User-management, Anti-Harassment

Sep 17 2019

Tchanders added a comment to T233119: Intended use of MinimumPasswordLengthToLogin not so clear.

I think this task is done, and we don't actually need to re-instate https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/534707/ as the behaviour is now as expected?

Sep 17 2019, 9:25 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.31-release-notes, MW-1.32-notes, MW-1.33-notes, Documentation, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Trust-and-Safety, MediaWiki-Authentication-and-authorization, Anti-Harassment, MediaWiki-User-login-and-signup
Tchanders added a comment to T233119: Intended use of MinimumPasswordLengthToLogin not so clear.

@Tgr OK, it sounds like we should be doing #2 then, but leaving MinimumPasswordLengthToLogin alone instead of discarding?

Sep 17 2019, 6:53 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.31-release-notes, MW-1.32-notes, MW-1.33-notes, Documentation, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Trust-and-Safety, MediaWiki-Authentication-and-authorization, Anti-Harassment, MediaWiki-User-login-and-signup
Tchanders added a comment to T233119: Intended use of MinimumPasswordLengthToLogin not so clear.
  • PasswordPolicyChecks::checkMinimumPasswordLengthToLogin calls Status::fatal (sets Status::ok to false).
Sep 17 2019, 6:52 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.31-release-notes, MW-1.32-notes, MW-1.33-notes, Documentation, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Trust-and-Safety, MediaWiki-Authentication-and-authorization, Anti-Harassment, MediaWiki-User-login-and-signup
Tchanders added a comment to T233119: Intended use of MinimumPasswordLengthToLogin not so clear.

Been looking into this with @dmaza - seems to be a difference in the type of status returned by the checks for the different policies:

Sep 17 2019, 6:24 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.31-release-notes, MW-1.32-notes, MW-1.33-notes, Documentation, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Trust-and-Safety, MediaWiki-Authentication-and-authorization, Anti-Harassment, MediaWiki-User-login-and-signup

Sep 16 2019

Tchanders added a comment to T196575: Add block cookie for browser-based API edits (including VisualEditor & MobileFrontend).

@daniel - see T231930#5496232

Sep 16 2019, 3:15 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-User-management
Tchanders added a comment to T231930: Introduce ActingUser to represent the user performing the current request.

T196575: Add block cookie for browser-based API edits (including VisualEditor & MobileFrontend) seems to indicate that we need to be able to manipulate the response (cookies) from the context of block management as well.

Sep 16 2019, 3:13 PM · MediaWiki-User-management, CPT Initiatives (Decoupling (CDP2))
Tchanders added a comment to T196575: Add block cookie for browser-based API edits (including VisualEditor & MobileFrontend).

Calling trackBlockWithCookie() as standard part of pre-shutdown on web requests will:

  • [...] Let getUserBlock remain predictable (no side-effect), and keep BlockManager separate from implicitly depending on WebResponse or otherwise making it unsafe to use post-send or outside web requests.
Sep 16 2019, 12:34 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-User-management

Sep 12 2019

Tchanders moved T231919: Don't pass global request object into BlockManager::getUserBlock constructor from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Sep 12 2019, 4:11 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-User-management, Anti-Harassment (The Letter Song)

Sep 11 2019

Tchanders moved T221682: Improve Block handling where User::isBlocked() was used previously from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Sep 11 2019, 8:47 AM · Epic, Anti-Harassment (The Letter Song), Technical-Debt, MediaWiki-User-management
Tchanders moved T228486: Partially blocked users cannot delete revisions from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Sep 11 2019, 8:47 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API, Patch-For-Review, Anti-Harassment (The Letter Song), Technical-Debt, MediaWiki-User-management

Sep 10 2019

Tchanders updated the task description for T229035: Deprecate 'GetBlockedStatus' hook and reduce visibility of User::mBlock, User::mBlockedBy and User::mHideName.
Sep 10 2019, 6:24 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-User-management
Tchanders moved T221444: Partially blocked users cannot tag revisions on unrelated pages, nor add, deactive or delete tags from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Sep 10 2019, 6:21 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-User-management, MediaWiki-Change-tagging
Tchanders added a comment to T231608: Security access for Tchanders.

Thanks everyone.

Sep 10 2019, 5:20 PM · Security-Team

Sep 7 2019

Tchanders committed rECPAb04dee519307: Use getter to get user block in SpecialContact (authored by Tchanders).
Use getter to get user block in SpecialContact
Sep 7 2019, 7:48 PM

Sep 6 2019

Tchanders updated the task description for T229035: Deprecate 'GetBlockedStatus' hook and reduce visibility of User::mBlock, User::mBlockedBy and User::mHideName.
Sep 6 2019, 2:59 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-User-management
Tchanders claimed T229035: Deprecate 'GetBlockedStatus' hook and reduce visibility of User::mBlock, User::mBlockedBy and User::mHideName.
Sep 6 2019, 12:32 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-User-management
Tchanders moved T229035: Deprecate 'GetBlockedStatus' hook and reduce visibility of User::mBlock, User::mBlockedBy and User::mHideName from Ready to Review on the Anti-Harassment (The Letter Song) board.
Sep 6 2019, 12:32 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-User-management
Tchanders moved T229035: Deprecate 'GetBlockedStatus' hook and reduce visibility of User::mBlock, User::mBlockedBy and User::mHideName from Cards ready to be discussed to The Letter Song on the Anti-Harassment board.
Sep 6 2019, 12:31 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-User-management
Tchanders updated the task description for T229035: Deprecate 'GetBlockedStatus' hook and reduce visibility of User::mBlock, User::mBlockedBy and User::mHideName.
Sep 6 2019, 12:30 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-User-management

Sep 5 2019

Tchanders moved T229035: Deprecate 'GetBlockedStatus' hook and reduce visibility of User::mBlock, User::mBlockedBy and User::mHideName from Untriaged to Cards ready to be discussed on the Anti-Harassment board.
Sep 5 2019, 6:01 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-User-management
Tchanders added a project to T229035: Deprecate 'GetBlockedStatus' hook and reduce visibility of User::mBlock, User::mBlockedBy and User::mHideName: Anti-Harassment.
Sep 5 2019, 6:00 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-User-management
Tchanders moved T228539: Partially blocked users should not be prevented from using the importImages maintenance script from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Sep 5 2019, 5:16 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Epic, Anti-Harassment (The Letter Song), Technical-Debt, MediaWiki-User-management

Sep 3 2019

Tchanders created T231919: Don't pass global request object into BlockManager::getUserBlock constructor.
Sep 3 2019, 5:06 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-User-management, Anti-Harassment (The Letter Song)

Sep 2 2019

Tchanders added a comment to T229692: Use GetUserBlockComplete hook instead of GetBlockedStatus in TorBlock extension.

But, it will change the behaviour of default installs.

Sep 2 2019, 4:14 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-extensions-TorBlock, MediaWiki-User-management

Aug 30 2019

Tchanders added a comment to T228950: Replace UserIsHidden with GetUserBlock in CentralAuth.

It sounds like the following would be a better approach:

  • If the user is unblocked, block them with the hidden SystemBlock
  • If the user is blocked, add the hidden SystemBlock to any existing blocks as a CompositeBlock (instead of overriding)
Aug 30 2019, 8:23 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), MediaWiki-extensions-CentralAuth

Aug 29 2019

Tchanders updated subscribers of T231608: Security access for Tchanders.
Aug 29 2019, 11:06 PM · Security-Team
Tchanders moved T229692: Use GetUserBlockComplete hook instead of GetBlockedStatus in TorBlock extension from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Aug 29 2019, 11:05 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-extensions-TorBlock, MediaWiki-User-management
Tchanders created T231608: Security access for Tchanders.
Aug 29 2019, 10:13 PM · Security-Team
Tchanders added a comment to T224468: Block list and log incorrectly report "cannot edit own talk page" for some blocks.

The error messages are fairly inconsistently located on Special:Block... These error messages are also located at the top (and only the first one encountered will be displayed):

  • already blocked
  • hide user with the wrong settings (e.g. with finite duration)
  • entering a time in the past in the expiry widget text input
Aug 29 2019, 5:59 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Anti-Harassment (The Letter Song), MediaWiki-User-management

Aug 28 2019

Tchanders moved T228948: PermissionManager::isBlockedFrom() can return true even if the user does not have a block from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Aug 28 2019, 11:19 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Anti-Harassment (The Letter Song), MediaWiki-User-management
Tchanders added a parent task for T228948: PermissionManager::isBlockedFrom() can return true even if the user does not have a block: T229692: Use GetUserBlockComplete hook instead of GetBlockedStatus in TorBlock extension.
Aug 28 2019, 11:18 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Anti-Harassment (The Letter Song), MediaWiki-User-management
Tchanders added a subtask for T229692: Use GetUserBlockComplete hook instead of GetBlockedStatus in TorBlock extension: T228948: PermissionManager::isBlockedFrom() can return true even if the user does not have a block.
Aug 28 2019, 11:18 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-extensions-TorBlock, MediaWiki-User-management

Aug 21 2019

Tchanders claimed T229692: Use GetUserBlockComplete hook instead of GetBlockedStatus in TorBlock extension.
Aug 21 2019, 4:54 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-extensions-TorBlock, MediaWiki-User-management
Tchanders moved T229692: Use GetUserBlockComplete hook instead of GetBlockedStatus in TorBlock extension from Ready to Review on the Anti-Harassment (The Letter Song) board.
Aug 21 2019, 4:54 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-extensions-TorBlock, MediaWiki-User-management
Tchanders moved T229692: Use GetUserBlockComplete hook instead of GetBlockedStatus in TorBlock extension from Untriaged to The Letter Song on the Anti-Harassment board.
Aug 21 2019, 4:54 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-extensions-TorBlock, MediaWiki-User-management
Tchanders added a project to T229692: Use GetUserBlockComplete hook instead of GetBlockedStatus in TorBlock extension: Anti-Harassment.
Aug 21 2019, 4:53 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-extensions-TorBlock, MediaWiki-User-management
Tchanders moved T228950: Replace UserIsHidden with GetUserBlock in CentralAuth from Ready to Review on the Anti-Harassment (The Letter Song) board.
Aug 21 2019, 4:53 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), MediaWiki-extensions-CentralAuth
Tchanders claimed T228950: Replace UserIsHidden with GetUserBlock in CentralAuth.
Aug 21 2019, 4:52 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), MediaWiki-extensions-CentralAuth
Tchanders renamed T228950: Replace UserIsHidden with GetUserBlock in CentralAuth from Replace UserIsHidden with GetBlockedStatus in CentralAuth to Replace UserIsHidden with GetUserBlock in CentralAuth.
Aug 21 2019, 4:51 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Anti-Harassment (The Letter Song), MediaWiki-extensions-CentralAuth
Tchanders moved T226468: [BUG] Block cookie interprets block expiry in local timezone: should be UTC from Ready to QA/Testing on the Anti-Harassment (The Letter Song) board.
Aug 21 2019, 4:30 PM · Anti-Harassment (The Letter Song), MediaWiki-User-management
Tchanders moved T226468: [BUG] Block cookie interprets block expiry in local timezone: should be UTC from Untriaged to The Letter Song on the Anti-Harassment board.
Aug 21 2019, 4:30 PM · Anti-Harassment (The Letter Song), MediaWiki-User-management
Tchanders claimed T226468: [BUG] Block cookie interprets block expiry in local timezone: should be UTC.

Saw this task too late, but should be fixed by: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/531270/

Aug 21 2019, 4:30 PM · Anti-Harassment (The Letter Song), MediaWiki-User-management
Tchanders moved T227678: Clear block cookie if the value is invalid from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Aug 21 2019, 12:20 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Anti-Harassment (The Letter Song), MediaWiki-User-management

Aug 20 2019

Tchanders moved T224958: Instrument Special:Mute from Review to QA/Testing on the Anti-Harassment (The Letter Song) board.
Aug 20 2019, 5:23 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Analytics, Anti-Harassment (The Letter Song)

Aug 14 2019

Tchanders added a comment to T197831: Add the Interaction Timeline to the tool directory.

Thanks @CC-TimidRobot!

Aug 14 2019, 9:19 PM · Anti-Harassment, InteractionTimeline