Tchanders
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 13 2015, 10:17 PM (161 w, 6 d)
Availability
Available
LDAP User
Tchanders
MediaWiki User
Unknown

Recent Activity

Mon, Oct 15

Tchanders updated the task description for T202575: Epic: Be more consistent about dialog availability in mobile visual editor.
Mon, Oct 15, 3:06 PM · Epic, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)

Wed, Oct 10

Tchanders added a comment to T203477: Improve gallery dialog for mobile visual editor.

Thanks for the feedback.

Wed, Oct 10, 7:46 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders moved T203477: Improve gallery dialog for mobile visual editor from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Wed, Oct 10, 4:56 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders added a comment to T203477: Improve gallery dialog for mobile visual editor.

After talking to @iamjessklein yesterday and in light of @Esanders' comments above, I've put something together along those lines:

Wed, Oct 10, 1:36 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders moved T203476: Improve diff dialog for mobile visual editor from Ready for Pick Up to QA on the VisualEditor (Current work) board.
Wed, Oct 10, 10:57 AM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)

Tue, Oct 9

iamjessklein awarded T206481: The syntax highlight dialog's Apply changes action is enabled and disabled erratically a Insectivore token.
Tue, Oct 9, 8:28 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), SyntaxHighlight, Patch-For-Review, VisualEditor (Current work)
Tchanders created T206534: The gallery dialog's Apply changes action is always enabled if there are images in the gallery .
Tue, Oct 9, 1:06 PM · VisualEditor (Current work)

Mon, Oct 8

Tchanders created T206481: The syntax highlight dialog's Apply changes action is enabled and disabled erratically.
Mon, Oct 8, 5:44 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), SyntaxHighlight, Patch-For-Review, VisualEditor (Current work)
Tchanders updated the task description for T206473: Opening the maps dialog causes a change in the maps node attributes.
Mon, Oct 8, 4:54 PM · User-Ryasmeen, Editing Q2 2018-19 mobile improvements, Verified, VisualEditor-DataModel, Maps (Kartographer), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work)
Tchanders created T206473: Opening the maps dialog causes a change in the maps node attributes.
Mon, Oct 8, 4:27 PM · User-Ryasmeen, Editing Q2 2018-19 mobile improvements, Verified, VisualEditor-DataModel, Maps (Kartographer), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work)
iamjessklein awarded T206000: Apply changes action is enabled on several dialogs before any changes are made a Like token.
Mon, Oct 8, 3:35 PM · VisualEditor (Current work)
Tchanders moved T206000: Apply changes action is enabled on several dialogs before any changes are made from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Mon, Oct 8, 3:32 PM · VisualEditor (Current work)
Tchanders claimed T206000: Apply changes action is enabled on several dialogs before any changes are made.
Mon, Oct 8, 3:32 PM · VisualEditor (Current work)
Tchanders moved T190885: Re-evaluate mobile editing for images from In progress to QA on the VisualEditor (Current work) board.
Mon, Oct 8, 3:31 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Tchanders updated subscribers of T190885: Re-evaluate mobile editing for images .
Mon, Oct 8, 3:28 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Thu, Oct 4

Ryasmeen awarded T206002: Target widget looks confusing without an outline a Like token.
Thu, Oct 4, 8:37 PM · Editing Q2 2018-19 mobile improvements, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor-MediaWiki, VisualEditor (Current work)
Tchanders added a comment to T206236: Dimensions widget inputs are unnecessarily large.

With the narrower inputs, there's no wrapping on a 320px-wide screen, and 4-digit numbers fit comfortably.

Thu, Oct 4, 4:01 PM · Editing Q2 2018-19 mobile improvements, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
Tchanders created T206236: Dimensions widget inputs are unnecessarily large.
Thu, Oct 4, 3:57 PM · Editing Q2 2018-19 mobile improvements, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)

Wed, Oct 3

Tchanders added a comment to T205615: OOUI fieldset layouts sometimes contain widgets in visual editor components.

While looking into this, I noticed the spacing between elements is affected by whether we have fieldset->widget or fieldset->field->widget. It's also affected by whether we use addItems() or append one element to the other. We should use these components properly to get a predictable appearance, and if there's a need to deviate, we should comment why.

Wed, Oct 3, 9:28 PM · Technical-Debt, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work)
Tchanders added a comment to T190885: Re-evaluate mobile editing for images .

Thinking more about point (4), that layout looks pretty crowded on a mobile screen:

Wed, Oct 3, 3:22 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Tchanders moved T206000: Apply changes action is enabled on several dialogs before any changes are made from To Triage to Quarterly Queue on the VisualEditor board.
Wed, Oct 3, 2:45 PM · VisualEditor (Current work)
Tchanders moved T205999: Target widget toolbar wraps awkwardly on narrow screens from To Triage to Quarterly Queue on the VisualEditor board.
Wed, Oct 3, 2:44 PM · VisualEditor, VisualEditor-MediaWiki-Mobile
Tchanders moved T206002: Target widget looks confusing without an outline from To Triage to Quarterly Queue on the VisualEditor board.
Wed, Oct 3, 2:43 PM · Editing Q2 2018-19 mobile improvements, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor-MediaWiki, VisualEditor (Current work)
Tchanders moved T206132: Remove "done" tool from mobile TargetWidgets from To Triage to Quarterly Queue on the VisualEditor board.
Wed, Oct 3, 2:42 PM · Editing Q2 2018-19 mobile improvements, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Tue, Oct 2

Tchanders added a comment to T190885: Re-evaluate mobile editing for images .

Thanks for the feedback, it's really helpful to have this all written out. I'd been thinking a couple of these things too - especially (2) and (5).

Tue, Oct 2, 6:06 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Tchanders created T206002: Target widget looks confusing without an outline.
Tue, Oct 2, 6:02 PM · Editing Q2 2018-19 mobile improvements, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor-MediaWiki, VisualEditor (Current work)
Tchanders updated the task description for T206000: Apply changes action is enabled on several dialogs before any changes are made.
Tue, Oct 2, 5:50 PM · VisualEditor (Current work)
Tchanders created T206000: Apply changes action is enabled on several dialogs before any changes are made.
Tue, Oct 2, 5:49 PM · VisualEditor (Current work)
Tchanders created T205999: Target widget toolbar wraps awkwardly on narrow screens.
Tue, Oct 2, 5:42 PM · VisualEditor, VisualEditor-MediaWiki-Mobile
Tchanders moved T205807: Dialog actions are inconsistent in visual editor from Code review to QA on the VisualEditor (Current work) board.
Tue, Oct 2, 11:38 AM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, VisualEditor (Current work)

Sun, Sep 30

Tchanders added a comment to T203476: Improve diff dialog for mobile visual editor.

A simple fix would be to make the sidebar narrower for smaller screen sizes.

Sun, Sep 30, 9:09 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders moved T205807: Dialog actions are inconsistent in visual editor from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Sun, Sep 30, 8:28 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, VisualEditor (Current work)
Tchanders created T205807: Dialog actions are inconsistent in visual editor.
Sun, Sep 30, 8:12 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, VisualEditor (Current work)

Fri, Sep 28

Tchanders updated subscribers of T205645: Remove useless "Make full size" button in media dialog.

Makes sense to me. As far as I can see, other than the media dialog, only the graph dialog uses the media size widget, and it configures it not to have the "full size" button.

Fri, Sep 28, 3:36 PM · Verified, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki

Thu, Sep 27

Tchanders added a comment to T205615: OOUI fieldset layouts sometimes contain widgets in visual editor components.

Thanks! I've commented on the patch - I think the fieldsets work semantically (unless I've misunderstood something) - particularly on the advanced tab.

Thu, Sep 27, 4:54 PM · Technical-Debt, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work)
Tchanders added a comment to T205615: OOUI fieldset layouts sometimes contain widgets in visual editor components.

I agree that ve.ui.MWMediaDialog should use FieldLayouts to wrap and labels its widgets, rather than FieldsetLayouts.

Thu, Sep 27, 3:33 PM · Technical-Debt, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work)
Tchanders moved T203467: Improve alignment in visual editor table dialog from Design review to QA on the VisualEditor (Current work) board.
Thu, Sep 27, 12:35 PM · Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Mobile, VisualEditor-Tables, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements
Tchanders moved T190885: Re-evaluate mobile editing for images from In progress to Code review on the VisualEditor (Current work) board.
Thu, Sep 27, 12:16 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Tchanders created T205615: OOUI fieldset layouts sometimes contain widgets in visual editor components.
Thu, Sep 27, 11:53 AM · Technical-Debt, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work)

Sun, Sep 23

Tchanders created T205231: Separate out node classes into separate files.
Sun, Sep 23, 10:49 PM · VisualEditor-DataModel, Technical-Debt, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), VisualEditor (Current work)

Sep 19 2018

Tchanders updated subscribers of T203580: Create technical debt heat map for VE codebase.

@dchan and I have made a plot of the whole project* though it's too big to display here at any resolution where the class names are readable. Plotting inheritance sideways (parent -> child), it's very tall and narrow, but chopped into four columns, it looks like this:

Sep 19 2018, 1:54 PM · VisualEditor (Current work), Technical-Debt
Tchanders added a comment to T203470: Fix graph dialog in mobile visual editor.

Thanks for this - I've filed it as T204820

Sep 19 2018, 12:44 PM · User-Ryasmeen, VisualEditor-MediaWiki-Mobile, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders created T204820: Graph dialog's table widget is too wide for narrow screens.
Sep 19 2018, 12:43 PM · VisualEditor

Sep 17 2018

Tchanders added a comment to T190885: Re-evaluate mobile editing for images .

I think this looks fine with a few fixes, so I think it should be re-enabled.

Sep 17 2018, 6:25 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Sep 16 2018

Tchanders moved T190885: Re-evaluate mobile editing for images from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Sep 16 2018, 6:51 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Tchanders edited projects for T190885: Re-evaluate mobile editing for images , added: VisualEditor (Current work); removed VisualEditor.
Sep 16 2018, 6:50 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Tchanders claimed T190885: Re-evaluate mobile editing for images .
Sep 16 2018, 6:50 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Tchanders moved T203470: Fix graph dialog in mobile visual editor from In progress to QA on the VisualEditor (Current work) board.
Sep 16 2018, 6:45 PM · User-Ryasmeen, VisualEditor-MediaWiki-Mobile, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders added a comment to T203470: Fix graph dialog in mobile visual editor.

Should I file a task for making the alignment responsive upstream?

Sep 16 2018, 6:44 PM · User-Ryasmeen, VisualEditor-MediaWiki-Mobile, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)

Sep 12 2018

Tchanders moved T203470: Fix graph dialog in mobile visual editor from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Sep 12 2018, 5:52 PM · User-Ryasmeen, VisualEditor-MediaWiki-Mobile, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders moved T201721: Exception thrown in list diff from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Sep 12 2018, 4:44 PM · Verified, VisualEditor-EditingTools, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders claimed T201721: Exception thrown in list diff.
Sep 12 2018, 4:42 PM · Verified, VisualEditor-EditingTools, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor (Current work), VisualEditor-VisualDiffs

Sep 11 2018

Tchanders updated subscribers of T203580: Create technical debt heat map for VE codebase.

It would be great to automate as much of this as possible, so it can be repeated in the future with minimal pain.

Sep 11 2018, 5:13 PM · VisualEditor (Current work), Technical-Debt
Tchanders added a comment to T203473: Fix maps dialog in mobile visual editor .

The left alignment looks a bit strange in wider mobile devices:

Sep 11 2018, 1:17 PM · VisualEditor-MediaWiki-Mobile, Patch-For-Review, Maps, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders added a comment to T203470: Fix graph dialog in mobile visual editor.

Appearance after that patch:

Sep 11 2018, 10:16 AM · User-Ryasmeen, VisualEditor-MediaWiki-Mobile, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)

Sep 10 2018

marcella awarded T203473: Fix maps dialog in mobile visual editor a Hungry Hippo token.
Sep 10 2018, 4:38 PM · VisualEditor-MediaWiki-Mobile, Patch-For-Review, Maps, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)

Sep 8 2018

Tchanders added a comment to T203467: Improve alignment in visual editor table dialog.

I think that works. Here it is in German:

DesktopMobile
Sep 8 2018, 2:28 PM · Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Mobile, VisualEditor-Tables, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements

Sep 6 2018

Tchanders moved T203474: Fix command help dialog in mobile visual editor on MinervaNeue from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Sep 6 2018, 12:15 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)

Sep 5 2018

Tchanders moved T203467: Improve alignment in visual editor table dialog from To Triage to Needs Discussion on the VisualEditor board.
Sep 5 2018, 4:44 PM · Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Mobile, VisualEditor-Tables, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements
Tchanders moved T201721: Exception thrown in list diff from To Triage to Needs Discussion on the VisualEditor board.
Sep 5 2018, 4:40 PM · Verified, VisualEditor-EditingTools, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders moved T202324: Visualdiff stuck on particular diff due to "null is not an object"-error from To Triage to Needs Discussion on the VisualEditor board.
Sep 5 2018, 4:40 PM · Verified, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), VisualEditor (Current work), VisualEditor-VisualDiffs

Sep 4 2018

Tchanders added a comment to T203470: Fix graph dialog in mobile visual editor.

In this case, I'd propose changing the booklet layout (menu at the side) to an index layout, like this (from the score inspector):


There's not really a good reason to use the booklet layout here, unlike with the gallery dialog, where the images need to be seen (T203477), or the math dialog, which has a very long menu.

Sep 4 2018, 5:45 PM · User-Ryasmeen, VisualEditor-MediaWiki-Mobile, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders added a comment to T203467: Improve alignment in visual editor table dialog.

It seems the the widget gets 60% of the width (as opposed to the label) by default. Where there are only narrow widgets (e.g. toggle switches, as here), perhaps this should be overridden.

Sep 4 2018, 4:00 PM · Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Mobile, VisualEditor-Tables, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements
Tchanders claimed T203467: Improve alignment in visual editor table dialog.
Sep 4 2018, 3:46 PM · Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Mobile, VisualEditor-Tables, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements
Tchanders triaged T203477: Improve gallery dialog for mobile visual editor as Normal priority.
Sep 4 2018, 3:44 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders edited parent tasks for T203476: Improve diff dialog for mobile visual editor, added: T202575: Epic: Be more consistent about dialog availability in mobile visual editor; removed: T203474: Fix command help dialog in mobile visual editor on MinervaNeue.
Sep 4 2018, 3:40 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders added a subtask for T202575: Epic: Be more consistent about dialog availability in mobile visual editor: T203476: Improve diff dialog for mobile visual editor.
Sep 4 2018, 3:40 PM · Epic, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders removed a subtask for T203474: Fix command help dialog in mobile visual editor on MinervaNeue: T203476: Improve diff dialog for mobile visual editor.
Sep 4 2018, 3:40 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders triaged T203476: Improve diff dialog for mobile visual editor as Normal priority.
Sep 4 2018, 3:38 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders triaged T203474: Fix command help dialog in mobile visual editor on MinervaNeue as Normal priority.
Sep 4 2018, 3:29 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders triaged T203473: Fix maps dialog in mobile visual editor as Normal priority.
Sep 4 2018, 3:26 PM · VisualEditor-MediaWiki-Mobile, Patch-For-Review, Maps, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders triaged T203470: Fix graph dialog in mobile visual editor as Normal priority.
Sep 4 2018, 3:16 PM · User-Ryasmeen, VisualEditor-MediaWiki-Mobile, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders added a subtask for T202575: Epic: Be more consistent about dialog availability in mobile visual editor: T203467: Improve alignment in visual editor table dialog.
Sep 4 2018, 3:04 PM · Epic, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders added a parent task for T203467: Improve alignment in visual editor table dialog: T202575: Epic: Be more consistent about dialog availability in mobile visual editor.
Sep 4 2018, 3:04 PM · Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Mobile, VisualEditor-Tables, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements
Tchanders created T203467: Improve alignment in visual editor table dialog.
Sep 4 2018, 3:03 PM · Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Mobile, VisualEditor-Tables, VisualEditor (Current work), Editing Q1 2018-19 mobile improvements
Tchanders added a comment to T202575: Epic: Be more consistent about dialog availability in mobile visual editor.

Thanks - I'll break those into subtasks.

Sep 4 2018, 2:28 PM · Epic, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)

Sep 2 2018

Tchanders added a comment to T202575: Epic: Be more consistent about dialog availability in mobile visual editor.

I've had a look at the dialogs, including those that are used for editing parts of the document (e.g. table dialog, math dialog), and those that aren't (e.g. save, command help tips, etc).

Sep 2 2018, 3:52 PM · Epic, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)

Aug 31 2018

Tchanders moved T203262: Description link message missing from gallery dialog in mobile from In progress to Code review on the VisualEditor (Current work) board.
Aug 31 2018, 4:41 PM · Verified, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, VisualEditor (Current work)
Tchanders created T203262: Description link message missing from gallery dialog in mobile.
Aug 31 2018, 4:38 PM · Verified, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, VisualEditor (Current work)

Aug 28 2018

Tchanders created T202980: Can't focus block image in mobile visual editor.
Aug 28 2018, 10:22 AM · User-Ryasmeen, Verified-in-Phase2, Verified, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Aug 27 2018

Tchanders added a comment to T196915: Give mobile editor a way to edit more than just a single section at once.

Should this be moved to QA?

Aug 27 2018, 2:14 PM · MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend

Aug 23 2018

Tchanders updated subscribers of T202575: Epic: Be more consistent about dialog availability in mobile visual editor.

Here are some examples of mobile dialogs for @iamjessklein

Aug 23 2018, 5:38 PM · Epic, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)

Aug 22 2018

Tchanders added a project to T190885: Re-evaluate mobile editing for images : VisualEditor-MediaWiki-Mobile.
Aug 22 2018, 9:58 PM · MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Tchanders created T202575: Epic: Be more consistent about dialog availability in mobile visual editor.
Aug 22 2018, 7:48 PM · Epic, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders added a comment to T202525: ve.ce.LinearSelection throws exception.

Looks like the (empty) input flashes red when you close the link inspector again, though this was already happening.

Aug 22 2018, 2:35 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), VisualEditor (Current work), VisualEditor-ContentEditable

Aug 21 2018

Tchanders moved T178780: Single line breaks shown a little strangely from Code review to QA on the VisualEditor (Current work) board.
Aug 21 2018, 3:22 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), VisualEditor (Current work), VisualEditor-VisualDiffs

Aug 17 2018

Tchanders added a comment to T178780: Single line breaks shown a little strangely.

This behaviour is caused by the CSS fix to T170114, which preserves whitespace in removed/inserted content, so we can see removed/inserted spaces properly. There's a slight inconsistency in this fix: whitespace is collapsed if content is unchanged, and preserved if content is changed.

Aug 17 2018, 7:04 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), VisualEditor (Current work), VisualEditor-VisualDiffs

Aug 16 2018

Tchanders moved T184166: Visual diff shows signature as tildes from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Aug 16 2018, 7:38 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders moved T184166: Visual diff shows signature as tildes from TR6: Visual diffs to Current work on the VisualEditor board.
Aug 16 2018, 7:37 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders claimed T184166: Visual diff shows signature as tildes.
Aug 16 2018, 7:36 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor (Current work), VisualEditor-VisualDiffs

Jul 27 2018

Tchanders added a comment to T200006: Visual diffs of categories are confusing since categories aren't rendered .

I agree, that might be the thing to do here... We could even start by always having that message (and not calculating/showing any metadata diffs), while we figure out how best to display this kind of thing in the visual diff.

Jul 27 2018, 8:44 PM · VisualEditor-VisualDiffs, VisualEditor

Jul 19 2018

Tchanders added a comment to T199298: Visual diff fails with "jQuery.Deferred exception: listContents is undefined".

so ideally we would just fix the placement of that comment node (which might be more in @dchan 's ball park)

Jul 19 2018, 1:20 PM · Verified-in-Phase2, MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders created T200006: Visual diffs of categories are confusing since categories aren't rendered .
Jul 19 2018, 1:02 PM · VisualEditor-VisualDiffs, VisualEditor

Jul 18 2018

Tchanders added a comment to T199298: Visual diff fails with "jQuery.Deferred exception: listContents is undefined".

It already is giving us a CommentMetaItem... Sounds like it's related to T189543

Jul 18 2018, 6:20 PM · Verified-in-Phase2, MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders added a comment to T197928: Visual diff shows non-minimal diff that could easily be improved.

This looks the same as T187589 and is probably due to something in the diff-patch-match library which does the linear diffs.

Jul 18 2018, 1:47 PM · VisualEditor, VisualEditor-VisualDiffs

Apr 4 2018

Tchanders added a comment to T188170: Historical visual diff behaves poorly for changes inside a container.

The reason I put it here is because the work I'm doing on lists diffs happens to solve this too, but happy to move it if that makes more sense...

Apr 4 2018, 7:43 PM · VisualEditor, VisualEditor-VisualDiffs

Apr 2 2018

Tchanders moved T187632: Historical visual diff sometimes shows extraneous changes for a single-line addition from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Apr 2 2018, 5:01 PM · MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders moved T188170: Historical visual diff behaves poorly for changes inside a container from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Apr 2 2018, 5:01 PM · VisualEditor, VisualEditor-VisualDiffs
Tchanders moved T187632: Historical visual diff sometimes shows extraneous changes for a single-line addition from TR6: Visual diffs to Current work on the VisualEditor board.
Apr 2 2018, 5:01 PM · MW-1.32-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), VisualEditor (Current work), VisualEditor-VisualDiffs
Tchanders moved T188170: Historical visual diff behaves poorly for changes inside a container from TR6: Visual diffs to Current work on the VisualEditor board.
Apr 2 2018, 5:01 PM · VisualEditor, VisualEditor-VisualDiffs