Tchanders
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Sep 13 2015, 10:17 PM (170 w, 2 d)
Availability
Available
LDAP User
Tchanders
MediaWiki User
Unknown

Recent Activity

Mon, Dec 17

Tchanders moved T202773: Update Special:Block to match the design from Ready to In progress on the Anti-Harassment (AHT Sprint 35) board.
Mon, Dec 17, 6:20 PM · Anti-Harassment (AHT Sprint 35), MediaWiki-User-management
Tchanders claimed T202773: Update Special:Block to match the design.
Mon, Dec 17, 6:20 PM · Anti-Harassment (AHT Sprint 35), MediaWiki-User-management
Tchanders moved T202773: Update Special:Block to match the design from Cards ready for development to AHT Sprint 35 on the Anti-Harassment board.
Mon, Dec 17, 6:19 PM · Anti-Harassment (AHT Sprint 35), MediaWiki-User-management
Tchanders moved T212142: API documentation for partial blocks page limit is incorrect from Ready to Review on the Anti-Harassment (AHT Sprint 35) board.
Mon, Dec 17, 5:56 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Anti-Harassment (AHT Sprint 35)
Tchanders created T212142: API documentation for partial blocks page limit is incorrect.
Mon, Dec 17, 5:52 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Anti-Harassment (AHT Sprint 35)
Tchanders moved T204986: Update Special:Block, Special:Unblock, API:Block, and API:Unblock to set/remove namespace blocks from In progress to Review on the Anti-Harassment (AHT Sprint 35) board.
Mon, Dec 17, 4:29 PM · Patch-For-Review, Anti-Harassment (AHT Sprint 35), MediaWiki-User-management

Thu, Dec 13

dbarratt awarded T211578: Replace Block::prevents with setters, getters and method that calculates the block's effects a Love token.
Thu, Dec 13, 6:57 PM · MediaWiki-User-management, Anti-Harassment

Mon, Dec 10

Tchanders created T211578: Replace Block::prevents with setters, getters and method that calculates the block's effects.
Mon, Dec 10, 1:14 PM · MediaWiki-User-management, Anti-Harassment

Fri, Dec 7

Tchanders moved T211223: TitlesMultiselectWidget displays too tall when first enabled on Special:Block from Review to Done on the Anti-Harassment (AHT Sprint 35) board.
Fri, Dec 7, 5:40 PM · Anti-Harassment (AHT Sprint 35), Patch-For-Review

Wed, Dec 5

Tchanders closed T210391: Do not indicate on Special:ActiveUsers if a user is partially blocked as Resolved.
Wed, Dec 5, 8:04 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 34), Patch-For-Review
Tchanders closed T208276: Do not indicate on Special:ListUsers if a user is partially blocked as Resolved.
Wed, Dec 5, 8:04 PM · Anti-Harassment (AHT Sprint 34), Patch-For-Review, MediaWiki-User-management
Tchanders moved T211223: TitlesMultiselectWidget displays too tall when first enabled on Special:Block from In progress to Review on the Anti-Harassment (AHT Sprint 34) board.
Wed, Dec 5, 5:19 PM · Anti-Harassment (AHT Sprint 35), Patch-For-Review
Tchanders added a comment to T211223: TitlesMultiselectWidget displays too tall when first enabled on Special:Block.

This appears to happen because the input widget inside the titles multiselect widget is wider than the max width of the titles multiselect widget at first.

Wed, Dec 5, 5:02 PM · Anti-Harassment (AHT Sprint 35), Patch-For-Review
Tchanders created T211223: TitlesMultiselectWidget displays too tall when first enabled on Special:Block.
Wed, Dec 5, 4:59 PM · Anti-Harassment (AHT Sprint 35), Patch-For-Review
Tchanders moved T211048: Audit classes that override Action::requiresUnblock method from Ready to In progress on the Anti-Harassment (AHT Sprint 34) board.
Wed, Dec 5, 3:24 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Anti-Harassment (AHT Sprint 35), MediaWiki-User-management
Tchanders added a comment to T208862: Title::checkUserBlock should call User::isBlockedFrom for every action.

Are we planning to reinstate this once T211048 is resolved?

Wed, Dec 5, 3:14 PM · Anti-Harassment (AHT Sprint 35), MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-User-management
Tchanders added a comment to T210953: Wikidata is editable for blocked users.

Just pointing to T211048, where we're auditing the affected classes - any feedback very welcome!

Wed, Dec 5, 3:14 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 34), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata, Security
Tchanders added a comment to T210914: Valid input in TagMultiselectWidget flagged as invalid on Special:ApiSandbox.

This is affecting the TitlesMultiSelectWidget on Special:Block too (with partial blocks enabled).

Wed, Dec 5, 2:51 PM · Patch-For-Review, OOUI

Tue, Dec 4

Tchanders added a comment to T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks).

Unless @dmaza disagrees, I don't think any of these options should be particularly complex.

Tue, Dec 4, 10:56 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), Patch-For-Review
Tchanders added a comment to T210475: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks).

I think we'll go with your middle proposal — [change] #2.A to say that the Page input containing the target's talk page should instead act like the checkbox was checked

Tue, Dec 4, 8:15 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), Patch-For-Review
Tchanders added a comment to T211048: Audit classes that override Action::requiresUnblock method.

I've updated the list of classes that don't explicitly override requiresUnblock to state the return value that they inherit (see above).

Tue, Dec 4, 6:44 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Anti-Harassment (AHT Sprint 35), MediaWiki-User-management

Mon, Dec 3

Tchanders added a comment to T211048: Audit classes that override Action::requiresUnblock method.

@Anomie Good point. searching "extends.*<className>" throws up one more result (PurgeAction in Flow) - updated the list above.

Mon, Dec 3, 9:21 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Anti-Harassment (AHT Sprint 35), MediaWiki-User-management
Tchanders updated subscribers of T211048: Audit classes that override Action::requiresUnblock method.

Method

  1. Search: https://codesearch.wmflabs.org/search/?q=requiresUnblock&i=nope&files=&repos=
  2. For each class where requiresUnblock returns false, search "extends <className>"; do this iteratively for all descendants until no more results
Mon, Dec 3, 8:44 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Anti-Harassment (AHT Sprint 35), MediaWiki-User-management
Tchanders created T211048: Audit classes that override Action::requiresUnblock method.
Mon, Dec 3, 7:50 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Anti-Harassment (AHT Sprint 35), MediaWiki-User-management

Fri, Nov 30

Tchanders added a comment to T208523: Partial blocks log entries display as malformed on Special:CheckUser.

This also affects sitewide blocks in the same way.

Fri, Nov 30, 6:48 PM · Anti-Harassment (AHT Sprint 35), CheckUser, MediaWiki-User-management

Wed, Nov 28

Tchanders claimed T204986: Update Special:Block, Special:Unblock, API:Block, and API:Unblock to set/remove namespace blocks.
Wed, Nov 28, 5:32 PM · Patch-For-Review, Anti-Harassment (AHT Sprint 35), MediaWiki-User-management
Tchanders moved T204986: Update Special:Block, Special:Unblock, API:Block, and API:Unblock to set/remove namespace blocks from Ready to In progress on the Anti-Harassment (AHT Sprint 34) board.
Wed, Nov 28, 5:32 PM · Patch-For-Review, Anti-Harassment (AHT Sprint 35), MediaWiki-User-management
Tchanders moved T204986: Update Special:Block, Special:Unblock, API:Block, and API:Unblock to set/remove namespace blocks from Cards ready for development to AHT Sprint 34 on the Anti-Harassment board.
Wed, Nov 28, 5:32 PM · Patch-For-Review, Anti-Harassment (AHT Sprint 35), MediaWiki-User-management
Tchanders moved T208276: Do not indicate on Special:ListUsers if a user is partially blocked from Review to Done on the Anti-Harassment (AHT Sprint 34) board.
Wed, Nov 28, 4:37 PM · Anti-Harassment (AHT Sprint 34), Patch-For-Review, MediaWiki-User-management
Tchanders added a comment to T205807: Dialog actions are inconsistent in visual editor.

@Ryasmeen Oops looks like I forgot to push the change - thanks for pointing that out!

Wed, Nov 28, 3:43 PM · User-Ryasmeen, Verified, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, VisualEditor (Current work)

Tue, Nov 27

Tchanders moved T208271: Clean up Expiry field on Special:Block on Mobile from In progress to Review on the Anti-Harassment (AHT Sprint 34) board.
Tue, Nov 27, 5:28 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
Tchanders updated subscribers of T208271: Clean up Expiry field on Special:Block on Mobile.

Here are some screenshots in the different skins with that patch:

Tue, Nov 27, 5:16 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management

Mon, Nov 26

Tchanders moved T208271: Clean up Expiry field on Special:Block on Mobile from Ready to In progress on the Anti-Harassment (AHT Sprint 33) board.
Mon, Nov 26, 3:46 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
Tchanders moved T208271: Clean up Expiry field on Special:Block on Mobile from Cards ready for development to AHT Sprint 33 on the Anti-Harassment board.
Mon, Nov 26, 3:45 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
Tchanders claimed T208271: Clean up Expiry field on Special:Block on Mobile.
Mon, Nov 26, 3:45 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Anti-Harassment (AHT Sprint 35), Patch-For-Review, MediaWiki-User-management
Tchanders closed T209630: Make TitlesMultiSelect widget display pending element as Declined.
Mon, Nov 26, 3:41 PM · Anti-Harassment (AHT Sprint 33)
Tchanders moved T208276: Do not indicate on Special:ListUsers if a user is partially blocked from In progress to Review on the Anti-Harassment (AHT Sprint 33) board.
Mon, Nov 26, 3:35 PM · Anti-Harassment (AHT Sprint 34), Patch-For-Review, MediaWiki-User-management
Tchanders moved T210391: Do not indicate on Special:ActiveUsers if a user is partially blocked from In progress to Review on the Anti-Harassment (AHT Sprint 33) board.
Mon, Nov 26, 3:35 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 34), Patch-For-Review
Tchanders added a comment to T208276: Do not indicate on Special:ListUsers if a user is partially blocked.

Special:ActiveUsers task filed as T210391

Mon, Nov 26, 2:04 PM · Anti-Harassment (AHT Sprint 34), Patch-For-Review, MediaWiki-User-management
Tchanders created T210391: Do not indicate on Special:ActiveUsers if a user is partially blocked.
Mon, Nov 26, 12:24 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 34), Patch-For-Review

Fri, Nov 23

Tchanders added a comment to T208276: Do not indicate on Special:ListUsers if a user is partially blocked.

Do we want to do the same for Special:ActiveUsers?

Fri, Nov 23, 4:07 PM · Anti-Harassment (AHT Sprint 34), Patch-For-Review, MediaWiki-User-management
Tchanders moved T208276: Do not indicate on Special:ListUsers if a user is partially blocked from Ready to In progress on the Anti-Harassment (AHT Sprint 33) board.
Fri, Nov 23, 12:41 PM · Anti-Harassment (AHT Sprint 34), Patch-For-Review, MediaWiki-User-management
Tchanders moved T208276: Do not indicate on Special:ListUsers if a user is partially blocked from Cards ready for development to AHT Sprint 33 on the Anti-Harassment board.
Fri, Nov 23, 12:41 PM · Anti-Harassment (AHT Sprint 34), Patch-For-Review, MediaWiki-User-management
Tchanders claimed T208276: Do not indicate on Special:ListUsers if a user is partially blocked.
Fri, Nov 23, 12:41 PM · Anti-Harassment (AHT Sprint 34), Patch-For-Review, MediaWiki-User-management
Tchanders moved T210080: Display pending element while the TitlesMultiselectWidget loads from In progress to Review on the Anti-Harassment (AHT Sprint 33) board.
Fri, Nov 23, 12:40 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 35), Patch-For-Review
Tchanders created T210257: Visual diff assumes extension nodes have body attribute.
Fri, Nov 23, 12:26 PM · Editing QA, VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review

Wed, Nov 21

Tchanders updated the task description for T210080: Display pending element while the TitlesMultiselectWidget loads.
Wed, Nov 21, 5:42 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 35), Patch-For-Review
Tchanders added a comment to T209630: Make TitlesMultiSelect widget display pending element.

It seems there are two points at which we need to show the loading bar:

  1. while the JS widget is loading, if the user has JS
  2. while the menu is loading, after the input has been changed

    After speaking to @Mooeypoo it seems this task is about point 2
Wed, Nov 21, 2:36 PM · Anti-Harassment (AHT Sprint 33)
Tchanders created T210080: Display pending element while the TitlesMultiselectWidget loads.
Wed, Nov 21, 12:23 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 35), Patch-For-Review
Tchanders added a comment to T209630: Make TitlesMultiSelect widget display pending element.

It seems there are two points at which we need to show the loading bar:

  1. while the JS widget is loading, if the user has JS
  2. while the menu is loading, after the input has been changed
Wed, Nov 21, 12:03 PM · Anti-Harassment (AHT Sprint 33)
Tchanders updated the task description for T209630: Make TitlesMultiSelect widget display pending element.
Wed, Nov 21, 11:57 AM · Anti-Harassment (AHT Sprint 33)

Tue, Nov 20

Tchanders claimed T209630: Make TitlesMultiSelect widget display pending element.
Tue, Nov 20, 3:16 PM · Anti-Harassment (AHT Sprint 33)
Tchanders moved T209630: Make TitlesMultiSelect widget display pending element from Ready to In progress on the Anti-Harassment (AHT Sprint 33) board.
Tue, Nov 20, 3:16 PM · Anti-Harassment (AHT Sprint 33)
Tchanders moved T209630: Make TitlesMultiSelect widget display pending element from Cards ready for development to AHT Sprint 33 on the Anti-Harassment board.
Tue, Nov 20, 3:16 PM · Anti-Harassment (AHT Sprint 33)
Tchanders moved T208876: TitlesMultiselectWidget does not suggest exact matches from In progress to Review on the Anti-Harassment (AHT Sprint 33) board.
Tue, Nov 20, 3:14 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33), OOUI, MediaWiki-User-management

Mon, Nov 19

Tchanders added a comment to T208876: TitlesMultiselectWidget does not suggest exact matches.

Looks like this isn't actually an exact matching problem, or anything affecting 1-character titles exclusively.

Mon, Nov 19, 4:04 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33), OOUI, MediaWiki-User-management
Tchanders claimed T208876: TitlesMultiselectWidget does not suggest exact matches.
Mon, Nov 19, 3:02 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33), OOUI, MediaWiki-User-management
Tchanders moved T208876: TitlesMultiselectWidget does not suggest exact matches from Ready to In progress on the Anti-Harassment (AHT Sprint 33) board.
Mon, Nov 19, 3:02 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33), OOUI, MediaWiki-User-management
Tchanders moved T208876: TitlesMultiselectWidget does not suggest exact matches from Cards ready for development to AHT Sprint 33 on the Anti-Harassment board.
Mon, Nov 19, 3:02 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33), OOUI, MediaWiki-User-management
Tchanders moved T209633: Track when block notices are displayed on VisualEditor client side from In progress to Review on the Anti-Harassment (AHT Sprint 33) board.
Mon, Nov 19, 2:35 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33)

Nov 16 2018

Tchanders claimed T209633: Track when block notices are displayed on VisualEditor client side.
Nov 16 2018, 2:00 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33)
Tchanders moved T209633: Track when block notices are displayed on VisualEditor client side from Ready to In progress on the Anti-Harassment (AHT Sprint 33) board.
Nov 16 2018, 1:59 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33)

Nov 15 2018

Tchanders added a comment to T206534: The gallery dialog's Apply changes action is always enabled if there are images in the gallery.
  1. Sometimes I am seeing the "Apply changes" button staying enabled even if there hasn't been any changes (Haven't found the exact steps yet for this, trying to).
Nov 15 2018, 5:15 PM · VisualEditor-EditingTools, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, VisualEditor (Current work)
Tchanders created T209599: Show block notices on mobile visual editor.
Nov 15 2018, 3:55 PM · VisualEditor-MediaWiki, VisualEditor

Nov 14 2018

Tchanders moved T208551: Suppress browser triggered drop down and field highlighting for TitlesMultiselectWidget from Review to Done on the Anti-Harassment (AHT Sprint 33) board.
Nov 14 2018, 3:59 PM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33), MediaWiki-HTMLForm, MediaWiki-User-management
Tchanders moved T208626: TitlesMultiselectWidget for Partial blocks suggests and accepts non-existent (aka redlink) pages from Review to Done on the Anti-Harassment (AHT Sprint 33) board.
Nov 14 2018, 3:59 PM · Patch-For-Review, Anti-Harassment (AHT Sprint 33), MediaWiki-User-management
Tchanders moved T208627: TitlesMultiselectWidget for Partial blocks suggests and accepts for more pages than the maximum from Review to Done on the Anti-Harassment (AHT Sprint 33) board.
Nov 14 2018, 3:59 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33), OOUI (OOUI-0.29.4), MediaWiki-User-management

Nov 13 2018

Tchanders moved T208551: Suppress browser triggered drop down and field highlighting for TitlesMultiselectWidget from In progress to Review on the Anti-Harassment (AHT Sprint 33) board.
Nov 13 2018, 7:31 PM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33), MediaWiki-HTMLForm, MediaWiki-User-management

Nov 12 2018

Tchanders claimed T208551: Suppress browser triggered drop down and field highlighting for TitlesMultiselectWidget.
Nov 12 2018, 12:59 PM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33), MediaWiki-HTMLForm, MediaWiki-User-management
Tchanders moved T208551: Suppress browser triggered drop down and field highlighting for TitlesMultiselectWidget from Ready to In progress on the Anti-Harassment (AHT Sprint 33) board.
Nov 12 2018, 12:58 PM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33), MediaWiki-HTMLForm, MediaWiki-User-management

Nov 9 2018

Tchanders added a comment to T208627: TitlesMultiselectWidget for Partial blocks suggests and accepts for more pages than the maximum.

The 'limit' value (renamed 'tagLimit' in T209057) is passed through in the patch on T208626.

Nov 9 2018, 2:37 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Anti-Harassment (AHT Sprint 33), OOUI (OOUI-0.29.4), MediaWiki-User-management

Nov 8 2018

Tchanders claimed T208626: TitlesMultiselectWidget for Partial blocks suggests and accepts non-existent (aka redlink) pages.
Nov 8 2018, 8:05 PM · Patch-For-Review, Anti-Harassment (AHT Sprint 33), MediaWiki-User-management
Tchanders moved T209057: New 'limit' config in OO.ui.TagMultiselectWidget conflicts with 'limit' in mw.widgets.TitleWidget from In progress to Review on the Anti-Harassment (AHT Sprint 32) board.
Nov 8 2018, 3:15 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), OOUI (OOUI-0.29.5), Anti-Harassment (AHT Sprint 33)
Tchanders created T209057: New 'limit' config in OO.ui.TagMultiselectWidget conflicts with 'limit' in mw.widgets.TitleWidget.
Nov 8 2018, 1:38 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), OOUI (OOUI-0.29.5), Anti-Harassment (AHT Sprint 33)
Tchanders moved T208966: TitlesMultiSelectWidget sometimes styles as invalid when all tags are valid from In progress to Review on the Anti-Harassment (AHT Sprint 32) board.
Nov 8 2018, 1:03 PM · OOUI (OOUI-0.29.5), Anti-Harassment (AHT Sprint 33)

Nov 7 2018

Tchanders moved T208966: TitlesMultiSelectWidget sometimes styles as invalid when all tags are valid from Ready to In progress on the Anti-Harassment (AHT Sprint 32) board.
Nov 7 2018, 5:44 PM · OOUI (OOUI-0.29.5), Anti-Harassment (AHT Sprint 33)
Tchanders created T208966: TitlesMultiSelectWidget sometimes styles as invalid when all tags are valid.
Nov 7 2018, 5:43 PM · OOUI (OOUI-0.29.5), Anti-Harassment (AHT Sprint 33)

Nov 4 2018

Tchanders moved T206534: The gallery dialog's Apply changes action is always enabled if there are images in the gallery from In progress to Code review on the VisualEditor (Current work) board.
Nov 4 2018, 10:35 PM · VisualEditor-EditingTools, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, VisualEditor (Current work)

Oct 29 2018

Tchanders added a comment to T205807: Dialog actions are inconsistent in visual editor.

@Ryasmeen Is it possible you're looking at inspectors? The extension dialogs are graph, math[1], chem[1], maps, syntax highlight and pre. These and other dialogs should all have "Apply changes" - do you see those?

Oct 29 2018, 3:07 PM · User-Ryasmeen, Verified, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), Patch-For-Review, VisualEditor (Current work)

Oct 15 2018

Tchanders updated the task description for T202575: Epic: Be more consistent about dialog availability in mobile visual editor.
Oct 15 2018, 3:06 PM · VisualEditor, Epic, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements

Oct 10 2018

Tchanders added a comment to T203477: Improve gallery dialog for mobile visual editor.

Thanks for the feedback.

Oct 10 2018, 7:46 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders moved T203477: Improve gallery dialog for mobile visual editor from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Oct 10 2018, 4:56 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders added a comment to T203477: Improve gallery dialog for mobile visual editor.

After talking to @iamjessklein yesterday and in light of @Esanders' comments above, I've put something together along those lines:

Oct 10 2018, 1:36 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)
Tchanders moved T203476: Improve diff dialog for mobile visual editor from Ready for Pick Up to QA on the VisualEditor (Current work) board.
Oct 10 2018, 10:57 AM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work)

Oct 9 2018

iamjessklein awarded T206481: The syntax highlight dialog's Apply changes action is enabled and disabled erratically a Insectivore token.
Oct 9 2018, 8:28 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), SyntaxHighlight, Patch-For-Review, VisualEditor (Current work)
Tchanders created T206534: The gallery dialog's Apply changes action is always enabled if there are images in the gallery.
Oct 9 2018, 1:06 PM · VisualEditor-EditingTools, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, VisualEditor (Current work)

Oct 8 2018

Tchanders created T206481: The syntax highlight dialog's Apply changes action is enabled and disabled erratically.
Oct 8 2018, 5:44 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), SyntaxHighlight, Patch-For-Review, VisualEditor (Current work)
Tchanders updated the task description for T206473: Opening the maps dialog causes a change in the maps node attributes.
Oct 8 2018, 4:54 PM · User-Ryasmeen, Editing Q2 2018-19 mobile improvements, Verified, VisualEditor-DataModel, Maps (Kartographer), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work)
Tchanders created T206473: Opening the maps dialog causes a change in the maps node attributes.
Oct 8 2018, 4:27 PM · User-Ryasmeen, Editing Q2 2018-19 mobile improvements, Verified, VisualEditor-DataModel, Maps (Kartographer), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work)
iamjessklein awarded T206000: Apply changes action is enabled on several dialogs before any changes are made a Like token.
Oct 8 2018, 3:35 PM · VisualEditor (Current work)
Tchanders moved T206000: Apply changes action is enabled on several dialogs before any changes are made from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Oct 8 2018, 3:32 PM · VisualEditor (Current work)
Tchanders claimed T206000: Apply changes action is enabled on several dialogs before any changes are made.
Oct 8 2018, 3:32 PM · VisualEditor (Current work)
Tchanders moved T190885: Re-evaluate mobile editing for images from In progress to QA on the VisualEditor (Current work) board.
Oct 8 2018, 3:31 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Tchanders updated subscribers of T190885: Re-evaluate mobile editing for images .
Oct 8 2018, 3:28 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Oct 4 2018

Ryasmeen awarded T206002: Target widget looks confusing without an outline a Like token.
Oct 4 2018, 8:37 PM · Editing Q2 2018-19 mobile improvements, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor-MediaWiki, VisualEditor (Current work)
Tchanders added a comment to T206236: Dimensions widget inputs are unnecessarily large.

With the narrower inputs, there's no wrapping on a 320px-wide screen, and 4-digit numbers fit comfortably.

Oct 4 2018, 4:01 PM · Editing Q2 2018-19 mobile improvements, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
Tchanders created T206236: Dimensions widget inputs are unnecessarily large.
Oct 4 2018, 3:57 PM · Editing Q2 2018-19 mobile improvements, Verified, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)

Oct 3 2018

Tchanders added a comment to T205615: OOUI fieldset layouts sometimes contain widgets in visual editor components.

While looking into this, I noticed the spacing between elements is affected by whether we have fieldset->widget or fieldset->field->widget. It's also affected by whether we use addItems() or append one element to the other. We should use these components properly to get a predictable appearance, and if there's a need to deviate, we should comment why.

Oct 3 2018, 9:28 PM · User-Ryasmeen, Technical-Debt, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), VisualEditor (Current work)
Tchanders added a comment to T190885: Re-evaluate mobile editing for images .

Thinking more about point (4), that layout looks pretty crowded on a mobile screen:

Oct 3 2018, 3:22 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
Tchanders moved T206000: Apply changes action is enabled on several dialogs before any changes are made from To Triage to Q3 on the VisualEditor board.
Oct 3 2018, 2:45 PM · VisualEditor (Current work)