Thu, Oct 29
Thanks @Huji - this is really helpful to know.
Wed, Oct 28
Tue, Oct 27
@Niharika I've made a second subtask to remove the code for Special:InvestigateLog and change the links that point to it.
Fri, Oct 23
Thu, Oct 22
Wed, Oct 21
@Niharika @dbarratt The copy feature sanitizes the HTML before sending it to the parser, rather than re-parsing the wikitext output from the parser - so the cleanest way to do this is to make the user links external links.
Summarizing a team discussion - we may want to split this into separate subtasks:
This is a deployment blocker.
Thanks @Jcross, it looks like we've added the information to this task description. Do you need anything else from us before the review can go ahead?
Tue, Oct 20
Mon, Oct 19
Thu, Oct 15
Thanks for pointing out that patch. I'm inclined to think we should revert the hard deprecations, and re-apply them in 1.37.
Wed, Oct 14
@dbarratt For local reviewing/testing you'll need to do a few things:
- Get the GeoLite2 databases: https://dev.maxmind.com/geoip/geoip2/geolite2/
- Put the .mmdb files in the same directory (similar to T264838#6534393)
- Set $wgIPInfoGeoIP2Path to the database file paths, up to the last common part of the filenames (actually, might want to rethink that to just the path, but that's how the patch currently works...)
Tue, Oct 13
@dbarratt For a better example of how DELETED_RESTRICTED works, here's what ApiQueryLogEvents does. TL;DR, as above, it suppresses whatever was deleted, rather than the full log entry. The full log entry is only hidden in some specific circumstances (example below).
Mon, Oct 12
Thanks for the thorough notes @dom_walden. I think proposal 3 looks the most correct - here's why...
Fri, Oct 9
Moving to Done since @dom_walden has tested: T265103#6531647
Thu, Oct 8
This is solved by the same patch as T264303. Nothing additional to review or test for this task.
Thanks @Krinkle, @Ladsgroup. Have documented that there are performance concerns in https://www.mediawiki.org/wiki/Extension:GuidedTour.
Wed, Oct 7
Deprecation was done in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/588104
Tue, Oct 6
Note that the error messages will be displayed in the content language (or fallback languages if that isn't available), rather than the user language, until T264777.
@Prtksxna How do you think the error looks, with the MessageWidget (type: error) styling?
Mon, Oct 5
@Ladsgroup Do you think it's worth documenting the performance issue with GuidedTour on the extension page: https://www.mediawiki.org/wiki/Extension:GuidedTour ? Could help teams in the future when weighing up whether to add a tour. Pinging also Growth-Team, who are listed as the maintainers (though they may no longer be!)
Fri, Oct 2
Thanks @Niharika - moved to QA since the fix has been merged, and I don't think a backport will be possible before it rolls out on the next train.