Page MenuHomePhabricator

Tchanders
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 13 2015, 10:17 PM (188 w, 1 d)
Availability
Available
LDAP User
Tchanders
MediaWiki User
Unknown

Recent Activity

Fri, Apr 19

Tchanders added a comment to T191549: Allow users to filter Special:BlockList on include/exclude partial blocks.

I did notice that blocks which don't block editing (i.e. only block account creation or emailing) are counted as partial.

Fri, Apr 19, 1:02 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management

Thu, Apr 18

Tchanders moved T208547: Just clicking on the empty space around should not change the type of block radio button selection from Review to QA/Testing on the Anti-Harassment (Heth - ח) board.
Thu, Apr 18, 4:03 PM · User-Ryasmeen, OOUI (OOUI-0.31.4), Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management
Tchanders moved T191549: Allow users to filter Special:BlockList on include/exclude partial blocks from Review to QA/Testing on the Anti-Harassment (Heth - ח) board.
Thu, Apr 18, 4:02 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management

Tue, Apr 16

Tchanders added a comment to T221117: Special:Block checkboxes should remember checked state.

I think it sends a misleading message that that option will be applied, e.g. that autoblocks would be applied for this block (and you can't prevent that from happening):

Tue, Apr 16, 5:56 PM · Anti-Harassment
Tchanders created T221117: Special:Block checkboxes should remember checked state.
Tue, Apr 16, 5:29 PM · Anti-Harassment
Tchanders updated the task description for T219441: Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP.
Tue, Apr 16, 11:58 AM · Anti-Harassment (Heth - ח), Patch-For-Review, Core Platform Team Backlog (Watching / External), MediaWiki-User-management
Tchanders added a comment to T219441: Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP.

Here's a suggestion for multiple iterations of the BlockManager, broken down in to manageable chunks that can fit around our Block refactoring work (T206163):

  1. Factor out the innards of User::getBlockedStatus, along with the helper methods (this task).
  2. Move over methods from Block that belong in the BlockManager - filed as T221066.
  3. Remove the block-related methods from User - filed as T221067. User::getBlockedStatus will need refactoring at that point. User::trackBlockWithCookie and User::getGlobalBlock interact with these methods, so this is the time to move those.
Tue, Apr 16, 11:56 AM · Anti-Harassment (Heth - ח), Patch-For-Review, Core Platform Team Backlog (Watching / External), MediaWiki-User-management
Tchanders created T221075: Introduce a BlockStore service.
Tue, Apr 16, 11:48 AM · Anti-Harassment
Tchanders created T221067: Move block-related methods on User to the BlockManager.
Tue, Apr 16, 10:41 AM · Anti-Harassment
Tchanders created T221066: Move methods from Block to BlockManager.
Tue, Apr 16, 10:17 AM · MediaWiki-User-management, Anti-Harassment

Mon, Apr 15

Tchanders added a comment to T191549: Allow users to filter Special:BlockList on include/exclude partial blocks.

Copying from gerrit, a question about the acceptance criterion:

Mon, Apr 15, 4:35 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management

Wed, Apr 10

Tchanders moved T204904: Create/update technical documentation for Partial Blocks from Review to Done on the Anti-Harassment (Zayin - ז) board.
Wed, Apr 10, 6:36 PM · Anti-Harassment (Zayin - ז), MediaWiki-User-management, Documentation
Tchanders created T220642: Only show the feedback link on Special:Block to users who can access the page.
Wed, Apr 10, 6:10 PM · Anti-Harassment

Thu, Apr 4

Tchanders added a comment to T218554: Make sure the "Account creation" checkbox on the Special:Block form reflects the wpCreateAccount query param.

@MarcoAurelio We have documented the partial blocks params wpEditingRestriction, wpPageRestrictions and wpNamespaceRestrictions at https://www.mediawiki.org/wiki/Manual:Block_and_unblock

Thu, Apr 4, 1:40 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Anti-Harassment (Zayin - ז), Documentation, MediaWiki-User-management
Tchanders renamed T218554: Make sure the "Account creation" checkbox on the Special:Block form reflects the wpCreateAccount query param from Update URL block parameters after partial blocks to Make sure the "Account creation" checkbox on the Special:Block form reflects the wpCreateAccount query param.
Thu, Apr 4, 1:11 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Anti-Harassment (Zayin - ז), Documentation, MediaWiki-User-management
Tchanders added a comment to T218554: Make sure the "Account creation" checkbox on the Special:Block form reflects the wpCreateAccount query param.

NB this problem is specific to wpCreateAccount - the fix makes sure we don't override the status of the "Create account" checkbox if the wpCreateAccount parameter is present.

Thu, Apr 4, 1:08 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Anti-Harassment (Zayin - ז), Documentation, MediaWiki-User-management
Tchanders moved T218554: Make sure the "Account creation" checkbox on the Special:Block form reflects the wpCreateAccount query param from Review to QA/Testing on the Anti-Harassment (Zayin - ז) board.
Thu, Apr 4, 12:55 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Anti-Harassment (Zayin - ז), Documentation, MediaWiki-User-management

Wed, Apr 3

Tchanders moved T218969: [Investigation - 4 hours] "You are blocked" message does not display when a user with a partial block attempts to take action with gadget on the page; page freezes instead from Ready to In Progress on the Anti-Harassment (Zayin - ז) board.
Wed, Apr 3, 6:04 PM · Anti-Harassment
Tchanders claimed T218969: [Investigation - 4 hours] "You are blocked" message does not display when a user with a partial block attempts to take action with gadget on the page; page freezes instead.
Wed, Apr 3, 6:03 PM · Anti-Harassment
Tchanders added a comment to T218969: [Investigation - 4 hours] "You are blocked" message does not display when a user with a partial block attempts to take action with gadget on the page; page freezes instead.

I've had a look into these issues:

Wed, Apr 3, 6:01 PM · Anti-Harassment
Tchanders added a comment to T219441: Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP.

What do we see the as eventual scope for the BlockManager?

Wed, Apr 3, 12:12 PM · Anti-Harassment (Heth - ח), Patch-For-Review, Core Platform Team Backlog (Watching / External), MediaWiki-User-management
Tchanders added a comment to T208768: Create a PermissionManager service.

AHT are discussing implementing a BlockManager: https://phabricator.wikimedia.org/T219441

Wed, Apr 3, 11:49 AM · Anti-Harassment, Core Platform Team Kanban (Contractor - Doing), Core Platform Team (Decoupling (CDP2)), Patch-For-Review, MediaWiki-Authentication-and-authorization, MediaWiki-User-management

Tue, Apr 2

Tchanders renamed T219441: Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP from Design an interface for a BlockManager class(es) to Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP.
Tue, Apr 2, 8:58 PM · Anti-Harassment (Heth - ח), Patch-For-Review, Core Platform Team Backlog (Watching / External), MediaWiki-User-management
Tchanders moved T212391: Special:Block options should be enable/disable, and not hide/show from In Progress to Review on the Anti-Harassment (Zayin - ז) board.
Tue, Apr 2, 3:41 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management
Tchanders moved T212892: Add in-product feedback mechanism for Partial Blocks from Review to QA/Testing on the Anti-Harassment (Zayin - ז) board.
Tue, Apr 2, 3:31 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז), MediaWiki-User-management
Tchanders added a comment to T212391: Special:Block options should be enable/disable, and not hide/show.

For testing (and reviewing), here's how everything behaves before the fix:

Tue, Apr 2, 2:11 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management
Tchanders moved T212391: Special:Block options should be enable/disable, and not hide/show from Ready to In Progress on the Anti-Harassment (Zayin - ז) board.
Tue, Apr 2, 10:54 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management
Tchanders moved T212391: Special:Block options should be enable/disable, and not hide/show from Cards ready for development to Zayin - ז on the Anti-Harassment board.
Tue, Apr 2, 10:53 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management
Tchanders claimed T212391: Special:Block options should be enable/disable, and not hide/show.
Tue, Apr 2, 10:53 AM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management

Mon, Apr 1

Tchanders moved T212892: Add in-product feedback mechanism for Partial Blocks from Review to QA/Testing on the Anti-Harassment (Zayin - ז) board.
Mon, Apr 1, 9:42 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז), MediaWiki-User-management
Tchanders added a comment to T212892: Add in-product feedback mechanism for Partial Blocks.

We're at the tail-end of the project here and won't be looking for feedback beyond a month or two. Hence putting it in core doesn't make sense.

Mon, Apr 1, 7:06 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז), MediaWiki-User-management

Sun, Mar 31

Tchanders added a comment to T212892: Add in-product feedback mechanism for Partial Blocks.

After more discussion, it seems there are concerns with adding any sort of feedback link in the core software. It's definitely worth resolving that question at some point, but since this task is blocking deployment to more wikis, and since we're (probably) more interested in WMF feedback in this case, it might be better to keep to the less controversial path.

Sun, Mar 31, 12:26 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז), MediaWiki-User-management

Fri, Mar 29

Tchanders added a comment to T212892: Add in-product feedback mechanism for Partial Blocks.

After some discussion, it seems that we need to distinguish between WMF-specific feedback and general mediawiki-related feedback.

Fri, Mar 29, 5:41 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז), MediaWiki-User-management
Tchanders added a comment to T216071: Namespaces multiselect widget selects an item on input change *before* filtering the items according to the changed input.

@Mooeypoo Do you expect this to be fixed now? It appears to behave according to the acceptance criteria as far as I can tell.

Fri, Mar 29, 1:05 PM · Anti-Harassment (Heth - ח), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26)
Tchanders moved T216831: Disabling JavaScript on Special:Block allows you to block user from "Special" namespace (namespace=-1) from Review to QA/Testing on the Anti-Harassment (Zayin - ז) board.
Fri, Mar 29, 12:47 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז), MediaWiki-User-management

Thu, Mar 28

Tchanders added a comment to T219305: Partially blocked admins are unable to undelete pages.

Undeleting is complicated by the fact that, once a page is deleted, the block no longer has a restriction against it, because the page ID is no longer in the page table. That means that a user blocked from Foo could undelete the page Foo if it is deleted.

Thu, Mar 28, 8:35 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז)
Tchanders added a comment to T212892: Add in-product feedback mechanism for Partial Blocks.

Thanks @SPoore!

Thu, Mar 28, 3:39 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז), MediaWiki-User-management
Tchanders claimed T212892: Add in-product feedback mechanism for Partial Blocks.
Thu, Mar 28, 3:39 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז), MediaWiki-User-management
Tchanders moved T212892: Add in-product feedback mechanism for Partial Blocks from In Progress to Review on the Anti-Harassment (Zayin - ז) board.
Thu, Mar 28, 2:40 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז), MediaWiki-User-management
Tchanders added a comment to T212892: Add in-product feedback mechanism for Partial Blocks.

The patch links to https://meta.wikimedia.org/wiki/Community_health_initiative/Blocking_tools_and_improvements/Feedback, but it looks like this hasn't been created yet?

Thu, Mar 28, 2:39 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז), MediaWiki-User-management
Tchanders moved T212892: Add in-product feedback mechanism for Partial Blocks from Ready to In Progress on the Anti-Harassment (Zayin - ז) board.
Thu, Mar 28, 9:08 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז), MediaWiki-User-management

Wed, Mar 27

Tchanders moved T216071: Namespaces multiselect widget selects an item on input change *before* filtering the items according to the changed input from QA/Testing to Review on the Anti-Harassment (Zayin - ז) board.
Wed, Mar 27, 6:55 PM · Anti-Harassment (Heth - ח), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26)
Tchanders moved T209097: FormSpecialPage::checkExecutePermissions should only block a FormSpecialPage if the user is sitewide blocked from Ready to QA/Testing on the Anti-Harassment (Zayin - ז) board.
Wed, Mar 27, 6:55 PM · Anti-Harassment (Zayin - ז), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, MediaWiki-User-management
Tchanders moved T209004: Deprecate User::isBlocked() from Ready to In Progress on the Anti-Harassment (Zayin - ז) board.
Wed, Mar 27, 6:54 PM · Anti-Harassment (Heth - ח), Patch-For-Review, Technical-Debt (Deprecation), MediaWiki-User-management
Tchanders moved T206163: Restrictions of overlapping blocks should be merged on enforcement from Ready to In Progress on the Anti-Harassment (Zayin - ז) board.
Wed, Mar 27, 6:53 PM · Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management
Tchanders moved T218905: Move logic for determining block behaviour to the Block class from Ready to Review on the Anti-Harassment (Zayin - ז) board.
Wed, Mar 27, 6:53 PM · Anti-Harassment (Zayin - ז), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review
Tchanders moved T219240: Special:Block form throws fatal error when re-loading with an error message from Review to QA/Testing on the Anti-Harassment (Zayin - ז) board.
Wed, Mar 27, 6:53 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Anti-Harassment (Zayin - ז), OOUI
Tchanders moved T219240: Special:Block form throws fatal error when re-loading with an error message from Ready to Review on the Anti-Harassment (Zayin - ז) board.
Wed, Mar 27, 6:53 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Anti-Harassment (Zayin - ז), OOUI
Tchanders added a comment to T219240: Special:Block form throws fatal error when re-loading with an error message.

@dom_walden It sounds like nobody else has been able to reproduce this, so would be great to know if this fix works for you once it gets to testwiki.

Wed, Mar 27, 11:39 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Anti-Harassment (Zayin - ז), OOUI
Tchanders moved T219240: Special:Block form throws fatal error when re-loading with an error message from Ready to QA/Testing on the Anti-Harassment (Vav — ו) board.
Wed, Mar 27, 11:37 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Anti-Harassment (Zayin - ז), OOUI
Tchanders moved T219240: Special:Block form throws fatal error when re-loading with an error message from Untriaged to Vav — ו on the Anti-Harassment board.
Wed, Mar 27, 11:37 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Anti-Harassment (Zayin - ז), OOUI

Tue, Mar 26

Tchanders moved T204904: Create/update technical documentation for Partial Blocks from In Progress to Review on the Anti-Harassment (Vav — ו) board.
Tue, Mar 26, 5:25 PM · Anti-Harassment (Zayin - ז), MediaWiki-User-management, Documentation
Tchanders updated the task description for T204904: Create/update technical documentation for Partial Blocks.
Tue, Mar 26, 5:24 PM · Anti-Harassment (Zayin - ז), MediaWiki-User-management, Documentation
Tchanders created T219305: Partially blocked admins are unable to undelete pages.
Tue, Mar 26, 5:06 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Anti-Harassment (Zayin - ז)

Mon, Mar 25

Tchanders created T219240: Special:Block form throws fatal error when re-loading with an error message.
Mon, Mar 25, 10:07 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Anti-Harassment (Zayin - ז), OOUI

Mar 22 2019

Tchanders added a comment to T216845: Account creation checkbox inappropriately checked at Special:Block/<Username>.

@Niharika @dom_walden - The URL bug has been filed here: T218554

Mar 22 2019, 5:44 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Anti-Harassment (Vav — ו), MediaWiki-User-management

Mar 21 2019

Ladsgroup awarded T218584: Enable partial blocks on Persian Wikipedia a Love token.
Mar 21 2019, 11:32 PM · Patch-For-Review, Anti-Harassment (Vav — ו)
Tchanders claimed T204904: Create/update technical documentation for Partial Blocks.
Mar 21 2019, 5:48 PM · Anti-Harassment (Zayin - ז), MediaWiki-User-management, Documentation
Tchanders moved T218905: Move logic for determining block behaviour to the Block class from In Progress to Review on the Anti-Harassment (Vav — ו) board.
Mar 21 2019, 5:48 PM · Anti-Harassment (Zayin - ז), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review
Tchanders moved T204904: Create/update technical documentation for Partial Blocks from Ready to In Progress on the Anti-Harassment (Vav — ו) board.
Mar 21 2019, 5:47 PM · Anti-Harassment (Zayin - ז), MediaWiki-User-management, Documentation
Tchanders moved T204904: Create/update technical documentation for Partial Blocks from Cards ready for development to Vav — ו on the Anti-Harassment board.
Mar 21 2019, 5:47 PM · Anti-Harassment (Zayin - ז), MediaWiki-User-management, Documentation
Tchanders moved T218892: Remove deprecated handling of multiple arguments from Block constructor from Review to Done on the Anti-Harassment (Vav — ו) board.
Mar 21 2019, 4:12 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Anti-Harassment (Vav — ו)
Tchanders created T218905: Move logic for determining block behaviour to the Block class.
Mar 21 2019, 2:54 PM · Anti-Harassment (Zayin - ז), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review
Tchanders moved T216845: Account creation checkbox inappropriately checked at Special:Block/<Username> from Review to QA/Testing on the Anti-Harassment (Vav — ו) board.
Mar 21 2019, 2:43 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Anti-Harassment (Vav — ו), MediaWiki-User-management
Tchanders moved T218892: Remove deprecated handling of multiple arguments from Block constructor from In Progress to Review on the Anti-Harassment (Vav — ו) board.
Mar 21 2019, 2:39 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Anti-Harassment (Vav — ו)
Tchanders created T218892: Remove deprecated handling of multiple arguments from Block constructor.
Mar 21 2019, 2:22 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Anti-Harassment (Vav — ו)
Tchanders moved T217255: Partially blocked users should be allowed to use Special:UploadWizard from Review to QA/Testing on the Anti-Harassment (Vav — ו) board.
Mar 21 2019, 1:45 PM · Anti-Harassment (Zayin - ז), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MediaWiki-User-management
Tchanders moved T209004: Deprecate User::isBlocked() from Review to In Progress on the Anti-Harassment (Vav — ו) board.
Mar 21 2019, 1:45 PM · Anti-Harassment (Heth - ח), Patch-For-Review, Technical-Debt (Deprecation), MediaWiki-User-management
Mill <mill@mail.com> committed rEBSUd6cf270cd026: 5(aaaaaaaaaaaa (authored by Tchanders).
5(aaaaaaaaaaaa
Mar 21 2019, 12:35 AM

Mar 20 2019

Tchanders moved T217255: Partially blocked users should be allowed to use Special:UploadWizard from QA/Testing to Review on the Anti-Harassment (Vav — ו) board.
Mar 20 2019, 10:21 PM · Anti-Harassment (Zayin - ז), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MediaWiki-User-management
Tchanders added a comment to T217255: Partially blocked users should be allowed to use Special:UploadWizard.

Thanks for pointing that out @dom_walden - it needed an additional patch in core.

Mar 20 2019, 10:20 PM · Anti-Harassment (Zayin - ז), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MediaWiki-User-management

Mar 19 2019

Tchanders added a project to T218554: Make sure the "Account creation" checkbox on the Special:Block form reflects the wpCreateAccount query param: Anti-Harassment.
Mar 19 2019, 2:34 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Anti-Harassment (Zayin - ז), Documentation, MediaWiki-User-management

Mar 18 2019

Tchanders moved T217255: Partially blocked users should be allowed to use Special:UploadWizard from Review to QA/Testing on the Anti-Harassment (Vav — ו) board.
Mar 18 2019, 4:11 PM · Anti-Harassment (Zayin - ז), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MediaWiki-User-management
Tchanders updated subscribers of T218584: Enable partial blocks on Persian Wikipedia.

A community representative has been in touch with @SPoore to indicate the community's approval for partial blocks to be enabled on Persian Wikipedia.

Mar 18 2019, 3:39 PM · Patch-For-Review, Anti-Harassment (Vav — ו)

Mar 14 2019

Tchanders moved T217255: Partially blocked users should be allowed to use Special:UploadWizard from In Progress to Review on the Anti-Harassment (Vav — ו) board.
Mar 14 2019, 2:56 PM · Anti-Harassment (Zayin - ז), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MediaWiki-User-management
Tchanders added a comment to T218172: Can't merge in master of UploadWizard; error thrown by MobileFrontend NearbyGateway.js _distanceMessage() test.

There's a similar failure here: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UploadWizard/+/494934/

Mar 14 2019, 2:44 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Wikimedia-production-error (Shared Build Failure), Multimedia, SDC Engineering, MobileFrontend, UploadWizard

Mar 12 2019

Tchanders added a comment to T206163: Restrictions of overlapping blocks should be merged on enforcement.

The proposal is to change User::getBlockedStatus to return a merged block combining the features of all blocks that apply to the user. This method is called from many places, and in the following ways:

Mar 12 2019, 12:10 PM · Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management

Mar 6 2019

Tchanders claimed T217693: Allow radio select input widget to pass help text through to individual radio input widgets.
Mar 6 2019, 1:01 PM · OOUI

Mar 5 2019

Tchanders updated subscribers of T217693: Allow radio select input widget to pass help text through to individual radio input widgets.

@matmarex Is there some reason for these differences in the radio options?

Mar 5 2019, 6:13 PM · OOUI
Tchanders added a project to T217693: Allow radio select input widget to pass help text through to individual radio input widgets: OOUI.
Mar 5 2019, 6:09 PM · OOUI
Tchanders created T217693: Allow radio select input widget to pass help text through to individual radio input widgets.
Mar 5 2019, 6:09 PM · OOUI

Mar 4 2019

Tchanders added a comment to T213101: Add help text to Special:Block for Partial Blocks.

@Volker_E Thanks for explaining about the precedence of <a> and <label>.

Mar 4 2019, 8:20 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Anti-Harassment (He — ה), MediaWiki-User-management
Tchanders added a comment to T213101: Add help text to Special:Block for Partial Blocks.

On the patch, @dbarratt points out that clicking on the help text selects the associated option. This is a problem because we have a "Learn more" link in the text for the "partial" option, and it doesn't seem user friendly that clicking on that link selects the option.

Mar 4 2019, 5:14 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Anti-Harassment (He — ה), MediaWiki-User-management
Tchanders updated subscribers of T211578: Replace Block::prevents with setters, getters and method that calculates the block's effects.

Thanks @dom_walden - I'll leave it to @TBolliger and/or any extension maintainers to request more testing

Mar 4 2019, 1:16 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (He — ה), Patch-For-Review, MediaWiki-User-management

Feb 28 2019

Tchanders updated the task description for T213101: Add help text to Special:Block for Partial Blocks.
Feb 28 2019, 9:02 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Anti-Harassment (He — ה), MediaWiki-User-management

Feb 27 2019

Tchanders moved T213101: Add help text to Special:Block for Partial Blocks from Ready to Review on the Anti-Harassment (He — ה) board.
Feb 27 2019, 10:26 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Anti-Harassment (He — ה), MediaWiki-User-management
Tchanders moved T213220: Title::checkUserBlock() should ensure the retrieved action matches the passed in restriction from Review to QA/Testing on the Anti-Harassment (Dalet — ד) board.
Feb 27 2019, 5:12 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Anti-Harassment (He — ה), Patch-For-Review, MediaWiki-User-management
Tchanders added a comment to T209097: FormSpecialPage::checkExecutePermissions should only block a FormSpecialPage if the user is sitewide blocked.

@TBolliger The patch addresses all pages in your list except for AbuseLog and UploadWizard, since they extend SpecialPage, instead of FormSpecialPage. It sounds like AbuseLog is already working. It looks like UploadWizard should be fixed in SpecialUploadWizard::isUserUploadAllowed.

Feb 27 2019, 1:54 PM · Anti-Harassment (Zayin - ז), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, MediaWiki-User-management
Tchanders updated the task description for T216845: Account creation checkbox inappropriately checked at Special:Block/<Username>.
Feb 27 2019, 12:40 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Anti-Harassment (Vav — ו), MediaWiki-User-management
Tchanders committed rERXB974dfa3b4f68: Replace calls to deprecated Block::prevents (authored by Tchanders).
Replace calls to deprecated Block::prevents
Feb 27 2019, 1:14 AM

Feb 26 2019

Tchanders committed rEBSUedd6adc30960: Replace calls to deprecated Block::prevents (authored by Tchanders).
Replace calls to deprecated Block::prevents
Feb 26 2019, 9:33 PM

Feb 25 2019

Tchanders added a comment to T214508: Special:BlockList reports a blocked user's ability to edit their own user talk page incorrectly for partial blocks on ITWP.

@dom_walden Thanks for finding that so quickly - it should be fixed by this: https://gerrit.wikimedia.org/r/492747

Feb 25 2019, 7:52 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review

Feb 22 2019

Tchanders added a comment to T216845: Account creation checkbox inappropriately checked at Special:Block/<Username>.

Our collective bad - it should've been in the acceptance criteria.

Feb 22 2019, 6:27 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Anti-Harassment (Vav — ו), MediaWiki-User-management
Tchanders added a comment to T211578: Replace Block::prevents with setters, getters and method that calculates the block's effects.

@dom_walden Ah, nasty - looks like it's is a new bug introduced by: T208510, merged not long before this. The JavaScript unchecks the checkbox because it's a partial block (with JavaScript disabled, it is checked). Filed as T216845.

Feb 22 2019, 6:26 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (He — ה), Patch-For-Review, MediaWiki-User-management
Tchanders created T216845: Account creation checkbox inappropriately checked at Special:Block/<Username>.
Feb 22 2019, 6:25 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Anti-Harassment (Vav — ו), MediaWiki-User-management
Tchanders added a comment to T208355: TitlesMultiselectWidget for Partial blocks suggests and accepts special pages and other invalid namespaces.

@TBolliger They're not actually opposite, though I can see how it sounds that way...

Feb 22 2019, 5:38 PM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review, MediaWiki-API, MediaWiki-General-or-Unknown
Tchanders added a comment to T212391: Special:Block options should be enable/disable, and not hide/show.

Here's what we discussed in estimation:

Feb 22 2019, 2:29 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Anti-Harassment (Heth - ח), Patch-For-Review, MediaWiki-User-management

Feb 21 2019

Tchanders moved T214508: Special:BlockList reports a blocked user's ability to edit their own user talk page incorrectly for partial blocks on ITWP from Review to QA/Testing on the Anti-Harassment (Dalet — ד) board.
Feb 21 2019, 11:04 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review
Tchanders added a comment to T214508: Special:BlockList reports a blocked user's ability to edit their own user talk page incorrectly for partial blocks on ITWP.

The approach of making the ipb_allow_usertalk flag match the behaviour was abandoned (https://gerrit.wikimedia.org/r/488533) in favour of decoupling the block flags/logs/form on the one hand from the block's behaviour on the other hand (https://gerrit.wikimedia.org/r/489662).

Feb 21 2019, 11:02 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Anti-Harassment (Dalet — ד), Patch-For-Review
Tchanders moved T211578: Replace Block::prevents with setters, getters and method that calculates the block's effects from Review to QA/Testing on the Anti-Harassment (Dalet — ד) board.
Feb 21 2019, 9:11 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Anti-Harassment (He — ה), Patch-For-Review, MediaWiki-User-management