Page MenuHomePhabricator

Tgr (Gergő Tisza)
Software Engineer, WMF

Projects (42)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 4:55 PM (411 w, 5 d)
Availability
Available
IRC Nick
tgr
LDAP User
Gergő Tisza
MediaWiki User
Tgr (WMF) [ Global Accounts ]

Things my team is working on: Growth-Team (kanban board)
Side projects I am working on (or planning to, eventually): User-Tgr
You can find more info about me on my user page.

Recent Activity

Today

Tgr added a comment to T306018: Instrument blocked account registration.
  • block type: I see there are 5 types in the Block.php interface. Are these the expected values for this field? Should they map to a meaningful string?
Thu, Aug 11, 6:52 AM · Product-Analytics, Patch-For-Review, Growth-Team (Current Sprint)
Tgr added a comment to T310390: Instrument blocked edit attempts.

Apparently there is an autoblockipblock event which is a subset of what's asked here. Not sure if it actually gets logged.

Thu, Aug 11, 6:41 AM · Product-Analytics (Kanban), Patch-For-Review, Goal, Editing-team (FY2021-22 Kanban Board), VisualEditor
Tgr added a comment to T314171: Incompatible skin: vector-2022.

This is being followed up in T314952: Misleading message shows in skins where VE is compatible but the page because of its state isn't (thanks for filing @Jdlrobson).

Thu, Aug 11, 6:17 AM · MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Readers-Web-Backlog (Kanbanana-2022-23-Q1), Wikimedia-production-error, VisualEditor
Tgr added a comment to T314948: Make channel(topic) a filterable field in logstash.

I wonder if there should be a separate warning and error channel. Errors typically should be treated no differently than exceptions - they are used e.g. when an exception was caught manually to provide graceful error handling, for logic errors (when some theoretically impossible condition occurs), for backend errors etc. I don't think they should be filtered out in general. The "Your skin is incompatible with VisualEditor" error should not be filtered out in theory either, as it is not supposed to happen in Wikimedia production (we have no such skins), that would have just been a temporary measure about a known bug with minimal impact.

Thu, Aug 11, 6:15 AM · Readers-Web-Backlog (Needs Prioritization (Tech)), Instrument-ClientError
Tgr added a comment to T314952: Misleading message shows in skins where VE is compatible but the page because of its state isn't.

Presence of the edit tab in SkinTemplate is conditional on Title::canExist() + Authority::probablyCan('read') + Authority::probablyCan('edit'). I think the read check is superfluous and only done as a performance optimization. The edit check is available on the JS side as mw.config.get('wgIsProbablyEditable'). The canExist check at a glance is not done by the permission system, and I don't think it is exposed via JS. But it's probably a pretty rare case - it only happens for some invalid titles, and I don't see the error there. Presumably the pageCanLoadEditor check already covers that.

Thu, Aug 11, 6:03 AM · Patch-For-Review, VisualEditor
Tgr added a comment to T312632: AddImage plugin sometimes does not load (Error: Your skin is incompatible with VisualEditor).

FWIW I can easily reproduce this error in an incognito window on https://en.wikipedia.org/wiki/Fritz_Scheyhing and https://en.wikipedia.org/wiki/File:SOB_RABe_526_105_Traverso_in_Kreuzlingen.jpg (Vector skin)

I think it's mostly happening on pages that don't exist and file pages ?

Thu, Aug 11, 5:48 AM · Wikimedia-production-error, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), VisualEditor, VisualEditor-Initialisation, Image-Suggestions, Growth-Team (Current Sprint)
Tgr added a comment to T269492: Selecting user language in the REST API.

Seems like a good proposal to me (but it would be nice to get wider feedback at some point).

Thu, Aug 11, 5:19 AM · MediaWiki-Internationalization, MediaWiki-REST-API
Tgr moved T314746: Flow edits don’t appear when viewing contributions for a CIDR range from Inbox to Needs Discussion/Analysis on the Growth-Team board.
Thu, Aug 11, 4:35 AM · Growth-Team, StructuredDiscussions
Tgr closed T314779: patch-cleanup-push_subscription-foreign-keys-indexes: SQL syntax error (MySQL 5.7.24) as Resolved.
Thu, Aug 11, 4:34 AM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Growth-Team (Current Sprint), Data-Persistence (Consultation), Notifications
Tgr moved T314627: "note: this page is only X minutes old" doesn't fire at the right times from Inbox to Triaged on the Growth-Team board.
Thu, Aug 11, 4:32 AM · Growth-Team, PageTriage
Tgr closed T314526: Stop welcoming LTAs as Declined.

MediaWiki doesn't really have a mechanism for delaying stuff, and we are not doing any new feature work on NewUserMessage (IMO it never made sense to put that functionality in a MediaWiki extension in the first place). You might be better served by a welcome but (e.g. Pywikibot has this functionality).

Thu, Aug 11, 4:27 AM · Growth-Team, Anti-Harassment, MediaWiki-extensions-NewUserMessage
Tgr moved T314672: RCFeed reports events with undocumented type "142" from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Thu, Aug 11, 4:21 AM · Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions
Tgr edited projects for T314672: RCFeed reports events with undocumented type "142", added: Growth-Team (Current Sprint); removed Growth-Team.
Thu, Aug 11, 4:20 AM · Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions
Tgr moved T314672: RCFeed reports events with undocumented type "142" from Inbox to Triaged on the Growth-Team board.
Thu, Aug 11, 4:18 AM · Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions
Tgr added a comment to T314672: RCFeed reports events with undocumented type "142".

Maybe there should be a config variable for mapping the IDs to human-readable names.

Thu, Aug 11, 4:18 AM · Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions
Tgr added a comment to T314672: RCFeed reports events with undocumented type "142".

I think Flow has switched from rc_type to rc_source for most internal purposes (T74157: [Story] Use rc_source and drop RC_TYPE) so could as well use one of the core types. But I'm not sure anyone has the bandwidth to experiment with that. Updated the docs (1, 2) for now.

Thu, Aug 11, 4:17 AM · Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions
Tgr moved T314691: [betalabs] Mentorship pages issues from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
Thu, Aug 11, 3:55 AM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-Mentorship
Tgr edited projects for T314691: [betalabs] Mentorship pages issues, added: Growth-Team (Current Sprint); removed Growth-Team.
Thu, Aug 11, 3:54 AM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-Mentorship
Tgr moved T314695: Make mention-success a `message` type notification from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Thu, Aug 11, 3:53 AM · Growth-Team (Current Sprint), User-notice, Patch-For-Review, Notifications
Tgr edited projects for T314695: Make mention-success a `message` type notification, added: Growth-Team (Current Sprint); removed Growth-Team.
Thu, Aug 11, 3:53 AM · Growth-Team (Current Sprint), User-notice, Patch-For-Review, Notifications
Tgr moved T314697: Allow use of wmf's MW CLI scripts on snapshot hosts instead of bypassing from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
Thu, Aug 11, 3:49 AM · Growth-Team (Current Sprint), Developer Productivity, serviceops, Datasets-General-or-Unknown
Tgr edited projects for T314697: Allow use of wmf's MW CLI scripts on snapshot hosts instead of bypassing, added: Growth-Team (Current Sprint); removed Growth-Team.
Thu, Aug 11, 3:48 AM · Growth-Team (Current Sprint), Developer Productivity, serviceops, Datasets-General-or-Unknown
Tgr moved T314762: Removing a disambiguation template should mark article as unreviewed from Inbox to Triaged on the Growth-Team board.
Thu, Aug 11, 3:42 AM · MediaWiki-extensions-Disambiguator, PageTriage, Growth-Team
Tgr moved T314779: patch-cleanup-push_subscription-foreign-keys-indexes: SQL syntax error (MySQL 5.7.24) from Incoming to Test in Production | Watching on the Growth-Team (Current Sprint) board.
Thu, Aug 11, 3:41 AM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Growth-Team (Current Sprint), Data-Persistence (Consultation), Notifications
Tgr edited projects for T314779: patch-cleanup-push_subscription-foreign-keys-indexes: SQL syntax error (MySQL 5.7.24), added: Growth-Team (Current Sprint); removed Growth-Team.
Thu, Aug 11, 3:41 AM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Growth-Team (Current Sprint), Data-Persistence (Consultation), Notifications
Tgr added a comment to T314779: patch-cleanup-push_subscription-foreign-keys-indexes: SQL syntax error (MySQL 5.7.24).

Per https://www.mediawiki.org/wiki/Compatibility#Database we require 10.3 for MediaWiki 1.39, which is when this commit was added. But yeah MySQL not supporting it (even in 8.0) is a problem.

Thu, Aug 11, 3:02 AM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Growth-Team (Current Sprint), Data-Persistence (Consultation), Notifications
Tgr moved T314965: DI sticky header causing issue with Flow sub-header from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
Thu, Aug 11, 2:47 AM · Patch-For-Review, Growth-Team (Current Sprint), StructuredDiscussions, Desktop Improvements
Tgr edited projects for T314965: DI sticky header causing issue with Flow sub-header , added: Growth-Team (Current Sprint); removed Growth-Team.

This looks the same as T311092: Sticky header conflicts with Structured Discussions sticky header on board pages, except that is marked as fixed.

Thu, Aug 11, 2:47 AM · Patch-For-Review, Growth-Team (Current Sprint), StructuredDiscussions, Desktop Improvements
Tgr moved T314923: Allow users to mute pages from generating mention notifications from Inbox to Triaged on the Growth-Team board.

Related: T115264: Notification panel: Control notification volume

Thu, Aug 11, 2:43 AM · Notifications, Growth-Team
Tgr moved T309941: IPInfo refuses to show IP informations if IP made only Flow modifications from Inbox to Triaged on the Growth-Team board.

Flow recentchanges entries use rc_source value flow (or Flow\Data\Listener\RecentChangesListener::SRC_FLOW if you want to be nice about it). Contributions / revisions aren't stored in the database in the normal way; check out the ContributionsQuery and DeletedContributionsQuery hooks. Although if you handle things close to the display side of MediaWiki, it shouldn't make much difference.

Thu, Aug 11, 2:38 AM · Growth-Team, StructuredDiscussions, IP Info

Yesterday

Tgr added a comment to T312632: AddImage plugin sometimes does not load (Error: Your skin is incompatible with VisualEditor).

The log spike corresponds to the logging code (rEVED591796df12d4: Log incompatible skin warnings) reaching enwiki. The actual bug (if it is indeed a bug) was probably around for a long time, we just did not log it before. The train deployment issues were apparently unrelated.

Wed, Aug 10, 5:12 PM · Wikimedia-production-error, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), VisualEditor, VisualEditor-Initialisation, Image-Suggestions, Growth-Team (Current Sprint)
Tgr moved T310320: Account creation + Growth tools: improve UX for newcomers who create an account while mid-edit from In Progress to Code Review on the Growth-Team (Current Sprint) board.

This is ready for desktop.

Wed, Aug 10, 6:20 AM · Patch-For-Review, Growth-Team (Current Sprint)
Tgr added a comment to T314909: Running update.php with an empty database should reinstall the tables, throws "Can not upgrade from versions older than 1.31" instead.

This is a side effect of rMW8b810330c288: Fail update if bot_passwords doesn't exist (and later rMWd66fe8b7c79e: Bump minimum required version for upgrade to 1.31). In theory pretty easy to fix, we just need to find a table that has always existed.

Wed, Aug 10, 3:41 AM · Patch-For-Review, MediaWiki-Installer
Tgr created T314909: Running update.php with an empty database should reinstall the tables, throws "Can not upgrade from versions older than 1.31" instead.
Wed, Aug 10, 1:43 AM · Patch-For-Review, MediaWiki-Installer
Tgr created T314908: MediaWiki database schemas should have a way to indicate the DB/cluster.
Wed, Aug 10, 1:27 AM · Performance-Team, MediaWiki-Core-Tests, Wikimedia-Rdbms
Tgr added a comment to T306636: UserOptionsManager: DBQueryError: Error 1213: Deadlock found when trying to get lock; try restarting transaction ([db])Function: MediaWiki\User\UserOptionsManager::saveOptionsInternalQuery.

I don't think that is a thing.

session1> insert into user_properties VALUES (42, 'C', 'x'), (43, 'B', 'x');
Query OK, 2 rows affected (0.00 sec)
Records: 2  Duplicates: 0  Warnings: 0
Wed, Aug 10, 1:13 AM · Data-Persistence (Consultation), Patch-For-Review, MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), PageTriage, User-brennen, MediaWiki-Core-Preferences, Wikimedia-production-error

Tue, Aug 9

Tgr added a comment to T306636: UserOptionsManager: DBQueryError: Error 1213: Deadlock found when trying to get lock; try restarting transaction ([db])Function: MediaWiki\User\UserOptionsManager::saveOptionsInternalQuery.

This doesn't make any sense to me. These are insert intention locks on a non-autoincrement table. They should only be exclusive for the specific index record they are inserting; they are not supposed to prevent other transations from writing in the same gap. The primary key is (up_user, up_property) so unless there is something weird we don't see because of the query text being truncated, it should not be possible for these two queries to deadlock.

Tue, Aug 9, 9:17 PM · Data-Persistence (Consultation), Patch-For-Review, MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), PageTriage, User-brennen, MediaWiki-Core-Preferences, Wikimedia-production-error
Tgr added a comment to T312666: Remove duplication in externallinks table.

I guess for searches you'd similarly split the query string, and then do a join with the relevant part of the query string applied to each table? Seems like that would work, and it would even allow domain-level statistics which could be useful but wouldn't be straightforward with the current DB structure.

Tue, Aug 9, 8:19 PM · Performance-Team (Radar), DBA, MediaWiki-General
Tgr added a comment to T312603: [mobile arwiki] Suggested articles with pending revision will open in diff view on mobile.

I mean the colours in the diff view that is discussed here. Compare:

DesktopMobile
Screenshot 2022-08-06 at 17-50-16 لونا-غلوب - ويكيبيديا.png (90×1 px, 11 KB)
Screenshot 2022-08-06 at 17-50-36 لونا-غلوب - ويكيبيديا.png (78×993 px, 24 KB)
Tue, Aug 9, 7:22 AM · Growth-Team (Current Sprint), MediaWiki-extensions-FlaggedRevs, GrowthExperiments
Tgr added a comment to T314697: Allow use of wmf's MW CLI scripts on snapshot hosts instead of bypassing.

Why do we even have a separate expanddblist and $multiversion/bin/expanddblist with basically identical content? It will in the end execute code in the multiversion repo anyway, so the security footprint is the same. Why isn't expanddblist just an alias/redirect to the other?

Tue, Aug 9, 3:58 AM · Growth-Team (Current Sprint), Developer Productivity, serviceops, Datasets-General-or-Unknown
Tgr added a comment to T269492: Selecting user language in the REST API.
  • mediawiki bootstrap (as it applies to this task) goes basically like this:
    1. load config
    2. load extensions
    3. service initialization
    4. initialize session
    5. load user
    6. load user preferences
Tue, Aug 9, 3:33 AM · MediaWiki-Internationalization, MediaWiki-REST-API
Tgr created T314833: Allow reusing the same translation unit during page translation.
Tue, Aug 9, 2:45 AM · MediaWiki-extensions-Translate

Fri, Aug 5

Tgr added a comment to T312592: Add ability to see good and bad edits to English Wikiquote.

No mention of enwikiquote in https://ores-support-checklist.toolforge.org/ though. So the first step would be for the wiki editors to label edits.

Fri, Aug 5, 3:56 AM · Machine-Learning-Team, ORES, Growth-Team, Edit-Review-Improvements-RC-Page
Tgr added a comment to T314518: Scale: deploy "add an image" to el, pl, zh, id, ro.

I didn't find any deployment docs, so created https://wikitech.wikimedia.org/wiki/Add_Image#Enabling_image_recommendations_on_a_new_wiki

Fri, Aug 5, 3:52 AM · Chinese-Sites, Growth-Team
Tgr added a comment to T287132: Notifications dropdown obscured in Timeless, Monobook, new Vector at small resolutions.

I can still reproduce this:

FirefoxChrome

(It seems Chrome doesn't allow decreasing the width below some limit.)

Fri, Aug 5, 1:44 AM · OOUI, Patch-For-Review, MonoBook (Responsive), Growth-Team (Current Sprint), Vector (Vector (Tracking)), Regression, Notifications, Timeless
Tgr added a comment to T287132: Notifications dropdown obscured in Timeless, Monobook, new Vector at small resolutions.

While testing a notification task I came across this issue. If I click "All notifications", on the resulting page, then I click the gear pull-down, the resulting list is off the screen. I'm not sure if this is related to this task or not.

Fri, Aug 5, 1:27 AM · OOUI, Patch-For-Review, MonoBook (Responsive), Growth-Team (Current Sprint), Vector (Vector (Tracking)), Regression, Notifications, Timeless
Tgr closed T313641: New Vector sidebar TOC is undiscoverable on tall sidebars as Invalid.

Thanks for the explanation.

Fri, Aug 5, 1:09 AM · Desktop Improvements

Thu, Aug 4

Tgr added a comment to T282477: [Placeholder] Image Suggestion API: K8 & Data Pipeline Infra Work.

I think this happened / is happening in T281132: Moving Image Suggestions Service to k8s?

Thu, Aug 4, 9:01 PM · Platform Engineering Roadmap
Tgr added a comment to T314608: DiscussionTools issues when wmf.23 is rolled back to wmf.22 ("Cannot set properties of undefined (setting 'parent')", visual glitches).

On all talk pages, it seems.

Thu, Aug 4, 7:49 PM · DiscussionTools
Tgr updated the task description for T314608: DiscussionTools issues when wmf.23 is rolled back to wmf.22 ("Cannot set properties of undefined (setting 'parent')", visual glitches).
Thu, Aug 4, 7:46 PM · DiscussionTools
Tgr added a comment to T314608: DiscussionTools issues when wmf.23 is rolled back to wmf.22 ("Cannot set properties of undefined (setting 'parent')", visual glitches).

I can't reproduce the exception in debug mode (although the link is still broken), probably some sort of race condition?

Thu, Aug 4, 7:44 PM · DiscussionTools
Tgr updated the task description for T314608: DiscussionTools issues when wmf.23 is rolled back to wmf.22 ("Cannot set properties of undefined (setting 'parent')", visual glitches).
Thu, Aug 4, 7:42 PM · DiscussionTools
Tgr created T314608: DiscussionTools issues when wmf.23 is rolled back to wmf.22 ("Cannot set properties of undefined (setting 'parent')", visual glitches).
Thu, Aug 4, 7:42 PM · DiscussionTools
Tgr added a comment to T314352: Investigate proof-of-work captchas for Wikimedia sites.
  • Latency sensitive for real users (they want to edit now, not 15 minutes from now or even 30 seconds from now)
Thu, Aug 4, 6:09 AM · Vuln-DoS, Security-Team, ConfirmEdit (CAPTCHA extension)
Tgr moved T314173: editgrowthconfig schema: '' should NOT have additional properties, from Code Review to QA on the Growth-Team (Current Sprint) board.

Thanks for the quick fix!

Thu, Aug 4, 1:36 AM · GrowthExperiments-CommunityConfiguration, Growth-Team (Current Sprint)
Tgr added a comment to T301096: Add a link: prioritize suggestions of underlinked articles.

@Tgr - you mentioned that it might be a fair amount of work to complete this task / reindex search results. Do you have a rough estimate of what it would take so we can decide if the impact is worth that effort?

Thu, Aug 4, 1:33 AM · Patch-For-Review, Growth-Team (Current Sprint), Add-Link
Tgr added a comment to T312248: Remove PagePreview popup from documentation link in MentorDashboard.

Hm, right, jqueryMsg can't expand interwiki prefixes for the same reason it can't detect external links. You could just add the extiw class via JS when the popup loads, I guess. Or use an external link as @Iniquity says.

Thu, Aug 4, 1:25 AM · Page-Previews, Growth-Team, GrowthExperiments-MentorDashboard

Wed, Aug 3

Tgr created T314544: Reduce page sizes for GrowthExperiments Selenium tests.
Wed, Aug 3, 9:46 PM · GrowthExperiments, Growth-Team (Current Sprint)
Tgr removed a project from T306888: Migrate ERANBOT project off of Strech Grid Engine: PageTriage.
Wed, Aug 3, 8:25 PM · Growth-Team, CopyPatrol
Tgr added a comment to T311324: Detach orange bar, notification read status and last pageview time for talk page notifications.

Please file a separate bug if something is causing duplicate notifications, we are generally trying to avoid those.

Wed, Aug 3, 8:21 PM · Growth-Team, Notifications
Tgr renamed T311324: Detach orange bar, notification read status and last pageview time for talk page notifications from Improved ability to use user talk pings as a todo list to Detach orange bar, notification read status and last pageview time for talk page notifications.
Wed, Aug 3, 8:18 PM · Growth-Team, Notifications
Tgr moved T314421: Find ways to exclude complex sentences constructed from proper nouns or personal names from Inbox to Needs Discussion/Analysis on the Growth-Team board.
Wed, Aug 3, 8:14 PM · Growth-Team, Add-Link
Tgr moved T314173: editgrowthconfig schema: '' should NOT have additional properties, from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
Wed, Aug 3, 7:52 PM · GrowthExperiments-CommunityConfiguration, Growth-Team (Current Sprint)
Tgr edited projects for T314173: editgrowthconfig schema: '' should NOT have additional properties,, added: Growth-Team (Current Sprint); removed Growth-Team.

Whoops, looks like our eventlogging error dashboard was missing the mediawiki.editgrowthconfig stream. Now fixed.

Wed, Aug 3, 7:52 PM · GrowthExperiments-CommunityConfiguration, Growth-Team (Current Sprint)
Tgr merged T314337: Number of mentees assigned to me always sets to average into T314050: On MentorDashboard the mentorship-weight always displays Average, regardless of the option stored.
Wed, Aug 3, 7:48 PM · GrowthExperiments-Mentorship, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Growth-Team (Current Sprint), GrowthExperiments-MentorDashboard
Tgr merged task T314337: Number of mentees assigned to me always sets to average into T314050: On MentorDashboard the mentorship-weight always displays Average, regardless of the option stored.
Wed, Aug 3, 7:47 PM · GrowthExperiments-Mentorship, GrowthExperiments-MentorDashboard, Growth-Team
Tgr moved T314232: Deletion sorting from Inbox to Triaged on the Growth-Team board.
Wed, Aug 3, 7:46 PM · Growth-Team, PageTriage
Tgr moved T314261: Allow pagetriage log entries to include wikitext/HTML markup from Inbox to Triaged on the Growth-Team board.
Wed, Aug 3, 7:45 PM · Growth-Team, PageTriage
Tgr moved T314430: Maintenance tags should follow MOS:ORDER from Inbox to Triaged on the Growth-Team board.
Wed, Aug 3, 7:44 PM · Growth-Team, PageTriage
Tgr claimed T314515: When CentralAuth is enabled, failing test files fail with a CentralAuth-related error rather than their actual failure.
Wed, Aug 3, 7:41 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Growth-Team (Current Sprint), MediaWiki-extensions-CentralAuth, GrowthExperiments
Tgr edited projects for T314515: When CentralAuth is enabled, failing test files fail with a CentralAuth-related error rather than their actual failure, added: Growth-Team (Current Sprint); removed Growth-Team.
Wed, Aug 3, 7:40 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Growth-Team (Current Sprint), MediaWiki-extensions-CentralAuth, GrowthExperiments
Tgr added a comment to T314515: When CentralAuth is enabled, failing test files fail with a CentralAuth-related error rather than their actual failure.

The table was added in rECAUd4289d11dc4c: Support for temporary user creation recently, as part of the IP masking / temp user work. UnitTestsAfterDatabaseSetup tries to recreate a table that wasn't removed in the teardown. I don't think this is related to the tests failing or not.

Wed, Aug 3, 7:39 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Growth-Team (Current Sprint), MediaWiki-extensions-CentralAuth, GrowthExperiments
Tgr updated subscribers of T313973: Exception: Invalid JSON response for page: Espejo.

Occurrences in the last 30 days:

Screenshot Capture - 2022-08-03 - 10-53-22.png (286×662 px, 20 KB)

Image recommendation stats in the last 90 days:
Screenshot Capture - 2022-08-03 - 10-51-38.png (807×1 px, 202 KB)

so this doesn't seem to have a visible impact on KPIs (but probably does result in some extra errors shown to users).

Wed, Aug 3, 6:36 PM · Patch-For-Review, Platform Engineering, MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Growth-Team (Current Sprint), Image-Suggestions, Growth-Structured-Tasks, Wikimedia-production-error
Tgr added a comment to T313658: Regression: special pages in search results are not visually separated on hover, in Vector 2022 (beta reproducible).

Not just a visual bug, they become unclickable too (the click always goes to the first element).

Wed, Aug 3, 9:07 AM · Readers-Web-Backlog, Design-Systems-Team, Codex, Beta-Cluster-reproducible, Regression, Desktop Improvements
Tgr moved T314050: On MentorDashboard the mentorship-weight always displays Average, regardless of the option stored from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Aug 3, 4:08 AM · GrowthExperiments-Mentorship, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Growth-Team (Current Sprint), GrowthExperiments-MentorDashboard
Tgr moved T312576: Structured mentor list should validate the maximum length of a mentor message from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Aug 3, 4:07 AM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Growth-Team (Current Sprint), GrowthExperiments-Mentorship
Tgr updated the task description for T314362: Ensure MentorWeightManager is not used with structured mentor list.
Wed, Aug 3, 4:06 AM · MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-Mentorship
Tgr moved T314361: Remove ApiSetMentorWeight from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Aug 3, 4:05 AM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), User-Urbanecm_WMF (Engineering), Growth-Team (Current Sprint), GrowthExperiments-Mentorship
Tgr updated the task description for T314361: Remove ApiSetMentorWeight.
Wed, Aug 3, 4:05 AM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), User-Urbanecm_WMF (Engineering), Growth-Team (Current Sprint), GrowthExperiments-Mentorship

Tue, Aug 2

Tgr closed T282146: Flow\Exception\InvalidReferenceException in CirrusSearch DataSender::sendData job as Declined.

Declining this was the right choice IMO. No user impact, doesn't happen a lot, Flow is abandonware so no point in doing unimportant work on it.

Tue, Aug 2, 8:42 PM · CirrusSearch, StructuredDiscussions, Wikimedia-production-error, Growth-Team
Tgr added a comment to T301096: Add a link: prioritize suggestions of underlinked articles.

@Tgr, a question from @Dyolf77_WMF: are ar.wiki prioritized articles reviewed (unflagged)?

Tue, Aug 2, 8:12 PM · Patch-For-Review, Growth-Team (Current Sprint), Add-Link
Tgr added a comment to T220143: Impact Module: Provide an option to show pageviews earlier than the 60-day limit from the PageViewInfo extension.

The (non-final, I think) mock for T313310: Impact module: Implement table list component includes a "past year" and "all time" option. The pageviews API can send data in daily or monthly increments, going back to about 2016 (it has data from 2015 July, not sure if it's reliable early on), with a different API serving 2008-2016 data. So "all time" will be since 2008 at best, since 2016 if we don't use the legacy API.

Tue, Aug 2, 7:36 AM · Growth-Team-Filtering, Wikimania-Hackathon-2019, Wikimedia-Hackathon-2019, GrowthExperiments, Growth-Team
Tgr added a comment to T220141: Impact Module: "sparkline" style graph that shows pageviews over time.

The mock uses a chartline which goes back five days (or five somethings, could be weekly I guess), is that the intention? I suspect the sparkline will be much less visually compelling if we try to make it use a much higher data resolution (e.g. daily views in the last 30 days), as page view data is relatively noisy.

Tue, Aug 2, 7:23 AM · Growth-Team-Filtering, Wikimania-Hackathon-2019, Wikimedia-Hackathon-2019, Growth-Team, GrowthExperiments
Tgr added a comment to T310649: Impact module: "Edit again" Call To Action.

This is not straightforward - either we'd have to do a separate search with a page ID filter for each task type (somewhat ugly and slow), or we need to fetch task type data from Cirrus directly (T243478: Newcomer tasks: fetch ElasticSearch data for search results).

Tue, Aug 2, 7:11 AM · Growth-Team, Growth-Positive-Reinforcement
Tgr added a comment to T314050: On MentorDashboard the mentorship-weight always displays Average, regardless of the option stored.

The fix looks good for the unstructured version, but Special:MentorDashboard with structured mentorship enabled also always shows Average, because there is no structured version of the weight manager. Is that tracked somewhere?

Tue, Aug 2, 7:03 AM · GrowthExperiments-Mentorship, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Growth-Team (Current Sprint), GrowthExperiments-MentorDashboard
Tgr added a comment to T314344: PHP Fatal error: Trait "League\OAuth2\Server\Entities\Traits\ClaimEntityTrait" not found in ClaimEntity.php on line 8.

composer.json has "league/oauth2-server": "dev-v9.0.0-alpha#61d770dc284898ea2905d66e12f8f7e5f6664092 as 9.0.0" so I guess one thing to check is whether your vendor repo actually has that revision. The other is whether the Composer autoloader is getting loaded. I think it's the second issue because...

14.5549  282019464  21. AutoLoader::autoload($className = 'MediaWiki\\Extension\\OAuth\\Entity\\ClaimEntity') /var/www/wiki/mediawiki/extensions/OAuth/tests/phpunit/Repository/ClaimStoreTest.php:33
14.5558  282021736  22. require('/var/www/wiki/mediawiki/extensions/OAuth/src/Entity/ClaimEntity.php') /var/www/wiki/mediawiki/core/includes/AutoLoader.php:244

otherwise there should be another autoloader call on the top of the stack (with a file not found error raised from within the ClaimEntityTrait autoloader, as opposed to the autoloader returning false and and an error being raised at the call site), no?

Tue, Aug 2, 5:38 AM · MediaWiki-extensions-OAuth
Tgr added a comment to T314343: Add a Link: suggest more relevant links.

What we could easily do on the PHP side is to make the score threshold or the link count somewhat dependent on how underlinked the article is. But that would require more effort from the Add Link service (more link candidates to check) so it might or might not turn out to be feasible, or might require performance improvements to the service (which would be nice to do anyway, but a bit outside our comfort zone).

Tue, Aug 2, 5:30 AM · Growth-Team
Tgr reopened T65975: Search results do not respect DISPLAYTITLE as "Open".
In T65975#4044854, @Tgr wrote:

for wikis with $wgRestrictDisplayTitle set to true (ie. displaytitle is same as real title, apart from capitalization and formatting) the search view just needs to fetch the displaytitle and use it instead of the raw title.

Tue, Aug 2, 5:22 AM · Discovery-Search, CirrusSearch, Discovery-ARCHIVED, MediaWiki-Search
Tgr reopened T65975: Search results do not respect DISPLAYTITLE, a subtask of T26139: Use display title from page_props as the displayed title everywhere (tracking), as Open.
Tue, Aug 2, 5:22 AM · MediaWiki-General, Tracking-Neverending, I18n
Tgr added a comment to T314271: [Hackathon 2022] Integrate Matrix chat with Wikipedia.

Someone would have to take stock of the current IRC / Slack / Discord bots (some IRC bots are documented at wikitech:Category:Bots) and see which of those would make sense for Matrix. I think the most common tasks are responding to !help and such, and handling wikilinks / phab IDs / QIDs.

Tue, Aug 2, 5:11 AM · Matrix, Wikimania-Hackathon-2022
Tgr added a comment to T241921: Fix Wikimedia captchas.

Today i came across https://mcaptcha.org/

Tue, Aug 2, 5:01 AM · Security, Security-Team, Stewards-and-global-tools, ConfirmEdit (CAPTCHA extension), UX-Debt, Accessibility, Epic
Tgr updated subscribers of T314352: Investigate proof-of-work captchas for Wikimedia sites.

mcaptcha seems interesting in that it appears to be OSI-compliant with its license and self-hosted by default, so there shouldn't be any privacy concerns. The things that would concern me about it, or any of these, are how proven they are within large-scale production environments like Wikimedia and other major websites (not seeing any case studies or users?) and how good they are from an accessibility and i18n standpoint, which would be two critical requirements for anything we'd wish to replace the existing FancyCaptcha, which currently meets none of those requirements. I also don't see any integration with something like Privacy Pass or one its derivatives, which I think would be an important consideration as well.

Tue, Aug 2, 5:01 AM · Vuln-DoS, Security-Team, ConfirmEdit (CAPTCHA extension)
Tgr added a comment to T314352: Investigate proof-of-work captchas for Wikimedia sites.

Today i came across https://mcaptcha.org/

  • It’s a proof of work captcha system
    • No visual or auditory accessibility problems
    • Language agnostic
  • can be self hosted
  • open source (AGPL)
  • API compatible with reCAPTCHA and hCAPTCHA
  • The server is written in rust, using Postgres and Redis.
  • The client is webassembly and a JS polyfill.

Seems to tick lots of our boxes. I’m not very familiar with the downsides of PoW captchas, perhaps the compute cost won’t be high enough to keep ppl out? I’m also curious if this requires presenting the captcha to plain trusted users a more than other captcha systems.

I found a few more
https://git.sequentialread.com/forest/pow-captcha
https://github.com/xenohunter/lapti-pow-captcha

There r also some online comments, that up to 1 minute of work (by the client), often meaning; between first interaction of user with form and submit, before pow is more expensive to solve than normal captcha solving services. Considering a login with password manager might only take half a second, that significantly limits the usability of pow captchas I suspect….

Some research on pow effectiveness TLDR u would inconvenience a lot of ppl if u make it truly uneconomical for bad actors
https://www.cl.cam.ac.uk/~rnc1/proofwork.pdf

Tue, Aug 2, 5:00 AM · Vuln-DoS, Security-Team, ConfirmEdit (CAPTCHA extension)
Tgr created T314352: Investigate proof-of-work captchas for Wikimedia sites.
Tue, Aug 2, 4:58 AM · Vuln-DoS, Security-Team, ConfirmEdit (CAPTCHA extension)
Tgr added a comment to T76158: Pitfalls checklist for software using AGPL.

This is marked resolved but was it actually resolved? If there is guidance on whether / how we can use AGPL licensed software (I think that's what resolved would mean here), where do I find it?

Tue, Aug 2, 4:38 AM · Software-Licensing, MediaWiki-General, WMF-Legal
Tgr added a comment to T269492: Selecting user language in the REST API.

The way to avoid both is to pass the language as a parameter to the service, directly or indirectly. This would typically take the form of an IContextSource being passed to a factory method, so the thing returned by the factory has access to a context.

Tue, Aug 2, 4:20 AM · MediaWiki-Internationalization, MediaWiki-REST-API
Tgr added a project to T312248: Remove PagePreview popup from documentation link in MentorDashboard: Page-Previews.
Tue, Aug 2, 3:02 AM · Page-Previews, Growth-Team, GrowthExperiments-MentorDashboard

Mon, Aug 1

Tgr added a comment to T312248: Remove PagePreview popup from documentation link in MentorDashboard.

Changing mediawiki.jqueryMsg is not hard (the relevant logic is in the wikilink method in resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js; in general, the parser is pretty easy to read once you wrap your head around the layout and the funky way it gets set up), but I don't think the list of interwiki prefixes is accessible from frontend code, and without that you can't tell whether it's an interwiki or a namespace or part of a mainspace title.

Mon, Aug 1, 11:37 PM · Page-Previews, Growth-Team, GrowthExperiments-MentorDashboard
Tgr added a comment to T308054: Suggested edits: separate presentation and business logic in SuggestedEdits class (server-side).

If we used a standard MVC setup, then getTaskSet(), resetTaskCache() and getSiteViews() would go to the model, state checks like isActivated(), getState(), canRender() etc. would go to the controller (plus it would mediate calls from the view to the model) and everything else would go to the view, which is about 900 out of 1000 lines. The part of the model that could likely be reusable elsewhere is something like 20 lines. So I'm not sure this is worth the effort.

Mon, Aug 1, 6:03 PM · Technical-Debt, Growth-Team, GrowthExperiments
Tgr updated the task description for T314271: [Hackathon 2022] Integrate Matrix chat with Wikipedia.
Mon, Aug 1, 6:36 AM · Matrix, Wikimania-Hackathon-2022