Tgr (Gergő Tisza)
Software Engineer, WMF Reading

Projects (30)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 4:55 PM (144 w, 5 d)
Availability
Available
IRC Nick
tgr
LDAP User
Gergő Tisza
MediaWiki User
Tgr (WMF)

Recent Activity

Today

Tgr added a watcher for css-sanitizer: Tgr.
Thu, Jun 29, 10:38 AM

Yesterday

Tgr updated subscribers of T53736: Consider changing wikipage redirects to be proper HTTP redirects.

@Tgr Do you have anyone in particular in mind? Feel free to ping anyone you think should be involved.

Wed, Jun 28, 4:50 PM · User-notice, ArchCom-RfC, SEO, MediaWiki-Redirects
Tgr added a comment to T164927: TemplateStyles style guidance outreach.

@Tgr, @Anomie, your extensive community experience begs a question: let's start with huwp and enwp? ;)

Wed, Jun 28, 3:55 PM · Community-Liaisons (Jul-Sep 2017), Reading-Infrastructure-Team-Backlog, TemplateStyles, Reading-Admin, User-Johan
Tgr added a comment to T168871: Introduct toc with page numbers during pdf post-processing.

Article concatenation can be done in PHP, by generating a concatenated HTML before sending to Electron. (It probably has to be, whether we use Electron or not, as we need to do HTML transformations based on it, such as making sure that two articles with the same section name have non-identical section ids). Title page also can be done that way. https://gerrit.wikimedia.org/r/#/c/361453/ has some PHP code that does both. Here is a book rendered with that patch (which uses Electron): sample.

Wed, Jun 28, 2:36 PM · Electron-PDFs, Reading-Web-Backlog
Tgr added a comment to T166188: Architecture of new rendering backend for Extension:Collection.

Have we decided on Electron vs. wktohtml?

Wed, Jun 28, 2:20 PM · Epic, Services (watching), Reading-Web-Backlog
Tgr added a comment to T53736: Consider changing wikipage redirects to be proper HTTP redirects.

Will there be anyone with UX expertise at the IRC discussion? This seems more like a user experience question than a technical one. And the UX is broken in multiple ways (for example, the "redirected from" text is at the top of the article, but when section targeting works the user does not see that message), so we might want to look for a more innovative solution.

Wed, Jun 28, 1:49 PM · User-notice, ArchCom-RfC, SEO, MediaWiki-Redirects
Tgr added a comment to T152801: "index-pack failed" when installing new MediaWiki-Vagrant box.

Unfortunately it does not seem like raising the post buffer solved this, although the error became less frequent.

Raising it even more helped, although I had to raise VM memory limits as well to make that work. I wonder if this is somehow related to the history of MediaWiki getting larger over time, so a larger and larger buffer is needed for some call.

Wed, Jun 28, 8:43 AM · Patch-For-Review, Gerrit, MediaWiki-Vagrant
Tgr added a comment to T118683: 1.27-alpha / TitleMoveComplete-closure has invalid call signature.

The simplest workaround I could find is to unpack/repack the parameter array:

global $hook;
$hook = function ( &$reference ) { echo "ok\n"; }
Wed, Jun 28, 8:01 AM · Patch-For-Review, MW-1.27-release, MediaWiki-General-or-Unknown
Tgr added a comment to T118683: 1.27-alpha / TitleMoveComplete-closure has invalid call signature.

Seems to be caused by the inherited parameter going out of scope. Here is a minimal reproduction:

global $hook;
$hook = function ( &$reference ) { echo "ok\n"; }
Wed, Jun 28, 7:55 AM · Patch-For-Review, MW-1.27-release, MediaWiki-General-or-Unknown

Tue, Jun 27

Tgr added a comment to T159105: ORES services should have vagrant roles.

pytz 2012c was required by revscoring until some days ago. The hack is taking the requirements from master which is why it ended up with the wrong version. pip helpfully omits requirements.txt from locally installed packages... I could probably parse the requires from the metadata.json file but that's an even more horrible hack.

Tue, Jun 27, 10:50 PM · Patch-For-Review, Scoring-platform-team, Wikilabels, ORES, MediaWiki-Vagrant
Tgr added a comment to T159105: ORES services should have vagrant roles.

SSL succeeds this time, but we run into the problem I documented above:

Tue, Jun 27, 4:27 PM · Patch-For-Review, Scoring-platform-team, Wikilabels, ORES, MediaWiki-Vagrant
Tgr added a comment to T159105: ORES services should have vagrant roles.

I have no idea what's going on there, the resource pip_install_revscoring_dependencies_hack should manually require all revscoring dependencies (I don't quite understand why that was necessary in the first place but seemed to be) and pytz is in there. Network error? Or maybe provisioning failed the first time and that role did not get executed on subsequent runs?

Tue, Jun 27, 9:47 AM · Patch-For-Review, Scoring-platform-team, Wikilabels, ORES, MediaWiki-Vagrant

Mon, Jun 26

Tgr added a comment to T159105: ORES services should have vagrant roles.

I think the ORES service might not be running.

Mon, Jun 26, 9:46 PM · Patch-For-Review, Scoring-platform-team, Wikilabels, ORES, MediaWiki-Vagrant
Tgr added a comment to T159105: ORES services should have vagrant roles.

==> default: Execution of '/bin/systemctl start ores-wsgi' returned 6: Failed to start ores-wsgi.service: Unit mediawiki-ready.service failed to load: No such file or directory.

Running provision a second time works, so this is probably just a missing dependency.

Mon, Jun 26, 9:38 PM · Patch-For-Review, Scoring-platform-team, Wikilabels, ORES, MediaWiki-Vagrant
Tgr added a comment to T166188: Architecture of new rendering backend for Extension:Collection.

Re: concatenation with RemexHTML, I put up a proof-of-concept patch at https://gerrit.wikimedia.org/r/#/c/361453/

Mon, Jun 26, 2:10 PM · Epic, Services (watching), Reading-Web-Backlog

Sat, Jun 24

Halfak awarded T159105: ORES services should have vagrant roles a Like token.
Sat, Jun 24, 5:26 PM · Patch-For-Review, Scoring-platform-team, Wikilabels, ORES, MediaWiki-Vagrant

Fri, Jun 23

Tgr added a comment to T152801: "index-pack failed" when installing new MediaWiki-Vagrant box.

Unfortunately it does not seem like raising the post buffer solved this, although the error became less frequent.

Fri, Jun 23, 5:11 PM · Patch-For-Review, Gerrit, MediaWiki-Vagrant
Tgr added a comment to T166188: Architecture of new rendering backend for Extension:Collection.

Electron has caused a couple outages lately by eating up too much memory, presumably due to the increased load as it has been enabled on all wikis a couple weeks ago. Load will increase a lot more once OCG is disabled / discouraged as a rendering option; should we expect a problem there? Or will that take care of itself as OCG decommissioning frees up resources?

Fri, Jun 23, 1:11 PM · Epic, Services (watching), Reading-Web-Backlog

Thu, Jun 22

Tgr added a comment to T168286: Run reader survey in multiple languages - Hungarian.

Done.

Thu, Jun 22, 3:05 PM · Research-and-Data

Wed, Jun 21

Tgr added a comment to T152540: Migrate to HTML5 section ids.

Perhaps leave Sanitizer::escapeId alone, so it emits "legacy anchors", and create two brand new escape methods for fragments and IDs.

Wed, Jun 21, 8:51 PM · Community-Wishlist-Survey-2016, Community-Tech, ContentTranslation, MediaWiki-Parser, Parsoid, Parsing-Team

Tue, Jun 20

Tgr added a comment to T166188: Architecture of new rendering backend for Extension:Collection.

Headless Chrome vs. Electron seems like a boring comparison from a product POV IMO since it's almost the same thing. Chrome headless is slightly more up-to-date (59 vs. 56 in Electron) but that's not a huge difference. It might be worth evaluating whether Electron should be replaced with it, but that's more of a devops issue and orthogonal to the OCG replacement project (so as long as that one is not done I wouldn't spend time on it).

Tue, Jun 20, 10:32 PM · Epic, Services (watching), Reading-Web-Backlog
Tgr added a comment to T168004: [Spike 6hrs] Investigate ability of vivliostyle to render single articles.

I spent some ours trying to extract the internal logic from the vivliostyle app but did not get far. The UI and the print simulation are separate libraries, but the internals are undocumented and rather complex (plus it uses knockout and google compiler so debugging is not a lot of fun). It would take significantly more effort; asking the vivliostyle developers is probably a better approach.

Tue, Jun 20, 10:21 PM · Electron-PDFs, Reading-Infrastructure-Team-Backlog, Reading-Web-Backlog
Multichill awarded T165540: Add CODE_OF_CONDUCT.md to Wikimedia repositories a Love token.
Tue, Jun 20, 7:07 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
Tgr closed T168417: OAuth consumer proposal form should not allow invalid callback URLs as Resolved.
Tue, Jun 20, 4:56 PM · MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), Patch-For-Review, MediaWiki-extensions-OAuth
Tgr created T168417: OAuth consumer proposal form should not allow invalid callback URLs.
Tue, Jun 20, 4:11 PM · MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), Patch-For-Review, MediaWiki-extensions-OAuth
Tgr added a comment to T167813: Requests with an owner-only consumers results in a "Invalid signature" error.

When I make a request to:
https://meta.wikimedia.org/wiki/Special:OAuth/identify
I get the following error:
An error occurred in the OAuth protocol: Invalid signature

Tue, Jun 20, 4:05 PM · MediaWiki-extensions-OAuth
Tgr added a comment to T53736: Consider changing wikipage redirects to be proper HTTP redirects.

Related use cases we don't want to break:

Tue, Jun 20, 11:02 AM · User-notice, ArchCom-RfC, SEO, MediaWiki-Redirects
Tgr added a comment to T168286: Run reader survey in multiple languages - Hungarian.

Done.

Tue, Jun 20, 10:23 AM · Research-and-Data

Mon, Jun 19

Tgr added a comment to T168004: [Spike 6hrs] Investigate ability of vivliostyle to render single articles.

infobox styling disappears. The text is still visible and has a table-like layout but table borders and background colors disappear. (Many other things such as thumbnails also become very plain.)

Mon, Jun 19, 7:57 PM · Electron-PDFs, Reading-Infrastructure-Team-Backlog, Reading-Web-Backlog
Tgr added a comment to T168069: MultimediaViewer opens black screen only.

Nevermind, that wasn't checked in 1.28.

Mon, Jun 19, 7:00 PM · MediaWiki-Configuration
Tgr edited projects for T168069: MultimediaViewer opens black screen only, added: MediaWiki-Configuration; removed MediaWiki-extensions-MultimediaViewer.

What's $wgUploadPath?

Mon, Jun 19, 6:58 PM · MediaWiki-Configuration
Tgr added a comment to T168004: [Spike 6hrs] Investigate ability of vivliostyle to render single articles.

Here are some quick tests with the standalone vivlio viewer (http://vivliostyle.github.io/vivliostyle.js/viewer/vivliostyle-viewer.html#x=<url>; note <url> must support CORS so RESTBase works but plain Wikipedia doesn't) + Chrome "Save as PDF" feature (default settings). This is not necessarily indicative of all that's possible with vivliostyle.js, for nicer display some CSS needs to be embedded into the page (e.g. they have some examples of doing TOC/page numbers that way). It might be good for spotting problems though.

Mon, Jun 19, 6:38 PM · Electron-PDFs, Reading-Infrastructure-Team-Backlog, Reading-Web-Backlog
Tgr added a comment to T168069: MultimediaViewer opens black screen only.

In that case, something seems misconfigured. ($wgResourceBasePath probably?)

Mon, Jun 19, 5:29 PM · MediaWiki-Configuration
Tgr added a comment to T168069: MultimediaViewer opens black screen only.

Is that path correct? Do you really have a C:\wamp64\www\resources folder, outside the MediaWiki root folder?

Mon, Jun 19, 5:19 PM · MediaWiki-Configuration
Tgr added a comment to T165540: Add CODE_OF_CONDUCT.md to Wikimedia repositories.

@Bawolff do you think that has been resolved now that a notification was sent to wikitech-l or should there be more / elsewhere?

Mon, Jun 19, 12:50 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
Tgr added a comment to T168286: Run reader survey in multiple languages - Hungarian.

@Tgr can you translate the text in this page? I've missed to ask you for translating this in the first round. Sorry.

Mon, Jun 19, 12:42 PM · Research-and-Data
Tgr added a comment to T165540: Add CODE_OF_CONDUCT.md to Wikimedia repositories.

This discussion has become hard to follow, so I'll try to summarize:

  • there was lots of debate over whether adding CODE_OF_CONDUCT.md to (almost) every repo is a good or bad idea. Quick tally: 16 were for it (I'm also counting people who awarded tokens), 10 against. (There were maybe half a dozen comments which could be read as implicitly implying one or the other; I tried to err on the side of not overinterpreting and did not count those.) So there was consensus to add the files, although not an overwhelming one. Several people pointed out though that adding the file would be weird or harmful for certain deployment-related repos (such as Debian packaging repos). So we should keep the files which have been added, and probably add CoC files to the other repos as well, as long as we can avoid build/deployment type repos.
  • several people objected against pushing directly to the repo (and thus not leaving an audit trail in gerrit). Several other people objected against using gerrit changesets which would cause a torrent of notification mails, and DoS Jenkins with pointless build jobs. Nobody objected to Chad's proposal in T165540#3316733 to use auto-merge so I am assuming that's the consensus approach.
  • some argued against using markdown, or a long filename, but neither opinion was popular.
Mon, Jun 19, 10:44 AM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
Tgr added a comment to T165540: Add CODE_OF_CONDUCT.md to Wikimedia repositories.

On the matter at hand, while I'm generally a proponent of the CoC, I find the addition of the blurb on every single Wikimedia repository a bit spammy as well, for reasons similar to those @ashley mentioned. GitHub is standardizing on adding it to the repositories because GitHub usually serves as a home page and issue tracker for many projects as well, or at least attempts to do so. In those cases, GitHub the primary medium over which people in a project communicate and collaborate, and for that reason, it makes sense. In our case, we usually don't use our Git repositories as our primary communication channels (I say primary, because I suppose it's conceivable someone may make an offensive or derogatory comment in a commit message). I think adding the CoC on prominent places on our technical wikis, as well as Phabricator, is enough to raise plenty of awareness to it. I cannot easily imagine situations where someone will be engaged with a project of ours but wouldn't first visit at least one of those two places.

Mon, Jun 19, 10:23 AM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
Tgr added a comment to T114616: Review and update GitHub mirror repo descriptions with standard text.

It would be be nice to get stats of how many of these projects actually use Github, as opposed to just fooling contributors into believing they are using it. E.g. https://github.com/wikimedia/puppet-kafka/pulls looks rather sad.

Mon, Jun 19, 9:10 AM · GitHub-Mirrors
Tgr added a comment to T153614: GitHub repository descriptions should point directly to the Gerrit projects.

Duplicate (or, I guess, alternative) of T109939: Actually give the source URL of the repo from GitHub?

Mon, Jun 19, 9:05 AM · GitHub-Mirrors

Sun, Jun 18

Tgr created T168199: Add #time length limit to parser limit report.
Sun, Jun 18, 12:28 PM · MediaWiki-extensions-ParserFunctions
Tgr added a comment to T156847: Core should be aware of the domain it is running on and render mobile domains where necessary.

Replacing domain names with their onion equivalents was mentioned as a similar problem.

Sun, Jun 18, 12:00 PM · Wikimedia-Hackathon-2017, Developer-Wishlist (2017), MediaWiki-General-or-Unknown
Tgr added a comment to T115958: Inform EU readers that we use cookies.

The cookie directive seems to be on the verge of death so if we have ignored this for so long, we can wait a little bit more and see if it's needed at all IMO.

Sun, Jun 18, 9:40 AM · Reading-Web-Backlog, WMF-Legal, Privacy
Tgr closed T168171: Add a Hook in OAuth extension in handleAuthorizationForm(), a subtask of T168170: Block Special:OAuth/authorize for WP Zero users, as Declined.
Sun, Jun 18, 9:37 AM · Wikimedia-Site-requests, MediaWiki-extensions-OAuth, Zero
Tgr closed T168171: Add a Hook in OAuth extension in handleAuthorizationForm() as Declined.

Declined per parent.

Sun, Jun 18, 9:37 AM · MediaWiki-extensions-OAuth
Tgr closed T168172: Add in WikimediaEvents extension a blocker for WP Zero by using Hook in OAuth extension, a subtask of T168170: Block Special:OAuth/authorize for WP Zero users, as Declined.
Sun, Jun 18, 9:35 AM · Wikimedia-Site-requests, MediaWiki-extensions-OAuth, Zero
Tgr closed T168172: Add in WikimediaEvents extension a blocker for WP Zero by using Hook in OAuth extension as Declined.

Declined per parent.

Sun, Jun 18, 9:35 AM · MediaWiki-extensions-WikimediaEvents, MediaWiki-extensions-OAuth
Tgr added a comment to T168170: Block Special:OAuth/authorize for WP Zero users.

Even apart from collateral damage, this does not seem particularly useful. There is no such thing as a Zero user; only a Zero request. Users could easily do the authorization via some proxy or different provider and do the file uploads via Zero. In the case of Phabricator, OAuth is only used to log you in, anyway (and it's not even the only way to do that); actual usage of Phabricator does not depend on OAuth in any way.

Sun, Jun 18, 9:34 AM · Wikimedia-Site-requests, MediaWiki-extensions-OAuth, Zero
Kaartic awarded T164990: RfC: Reading List service a Like token.
Sun, Jun 18, 7:56 AM · DBA, ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service

Sat, Jun 17

Tgr closed T28792: Add global variable to disable newPP limit report as Resolved.

Done since forever.

Sat, Jun 17, 8:28 PM · MediaWiki-Parser
Tgr added a comment to T862: Redesign Phabricator login page: LDAP login too prominent; position of MediaWiki SUL login not prominent enough.

Also, the MediaWiki logo is not necessarily recognizable (e.g. to Wikipedia editors who might want to report some UI bug). It would be nice to dislplay the other project logos around the login button.

Sat, Jun 17, 2:41 PM · Phabricator

Fri, Jun 16

Tgr added a comment to T168064: Possible issue with 2FA tokens.

As mentioned above, I have pasted on her behalf a scratch code at P5588 (visible only to members of Security) which may be helpful?

Fri, Jun 16, 5:02 PM · Wikimedia-General-or-Unknown
Tgr added a comment to T168069: MultimediaViewer opens black screen only.

@Smason3346 can you open that failed URL directly in the browser, or fetch it with curl -v, and paste the output somewhere?

Fri, Jun 16, 4:46 PM · MediaWiki-Configuration
Tgr added a comment to T168069: MultimediaViewer opens black screen only.

As far as I know it's http://wiki/index.php/File:Logo-epicolor.png?debug=true :)

Fri, Jun 16, 4:45 PM · MediaWiki-Configuration
Tgr added a comment to T168069: MultimediaViewer opens black screen only.

Can you repeat that screen capture with the network tab open?

Fri, Jun 16, 3:49 PM · MediaWiki-Configuration
Tgr added a comment to T168069: MultimediaViewer opens black screen only.

Which is to say, it is probably due to the JS failing to load. You should look at it in a dev console and check. You can try adding debug=1 to the URL to see if it is a ResourceLoader problem.

Fri, Jun 16, 2:38 PM · MediaWiki-Configuration
Tgr added a comment to T168069: MultimediaViewer opens black screen only.

Probably a similar issue to T68599: Browser window gets black without exit button when the browser is offline.

Fri, Jun 16, 2:36 PM · MediaWiki-Configuration
Tgr lowered the priority of T168064: Possible issue with 2FA tokens from Unbreak Now! to Normal.

Works fine with Google Authenticator as well.

Fri, Jun 16, 1:59 PM · Wikimedia-General-or-Unknown

Thu, Jun 15

Tgr added a comment to T166188: Architecture of new rendering backend for Extension:Collection.

See also (not really related to the choice of rendering tool): T167977: Test PDF rendering performance for multi-article books

Thu, Jun 15, 3:58 PM · Epic, Services (watching), Reading-Web-Backlog
Tgr created T167977: Test PDF rendering performance for multi-article books.
Thu, Jun 15, 3:57 PM · OfflineContentGenerator
Tgr added a comment to T166188: Architecture of new rendering backend for Extension:Collection.

Feature-wise wkhtmltopdf seems to be the clear winner right now (although that might change as CSS3 Paged Media browser support will pick up, since all the other solutions use significantly more recent browsers).

Thu, Jun 15, 3:50 PM · Epic, Services (watching), Reading-Web-Backlog
Tgr moved T164805: Investigate requirements for MySQL access in RESTBase from Kanban to Open Questions on the Reading-Infrastructure-Team-Backlog board.
Thu, Jun 15, 10:54 AM · Reading-Infrastructure-Team-Backlog, User-mobrovac, Services (watching), Reading List Service, DBA, RESTBase
Tgr moved T164990: RfC: Reading List service from Doing to Blocked on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Thu, Jun 15, 10:54 AM · DBA, ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr updated the task description for T164990: RfC: Reading List service.
Thu, Jun 15, 10:39 AM · DBA, ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr added a comment to T164990: RfC: Reading List service.

The RfC was discussed int the IRC office hour E615: ArchCom RFC Meeting: Reading List service (2017-06-14, #wikimedia-office). Option 1 was accepted and the RfC entered Final Comment Period.

Thu, Jun 15, 10:37 AM · DBA, ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr updated the task description for T164990: RfC: Reading List service.
Thu, Jun 15, 10:37 AM · DBA, ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr updated the event description for E615: ArchCom RFC Meeting: Reading List service (2017-06-14, #wikimedia-office).
Thu, Jun 15, 10:29 AM
Tgr added a comment to E615: ArchCom RFC Meeting: Reading List service (2017-06-14, #wikimedia-office).

Outline: http://tools.wmflabs.org/meetbot/wikimedia-office/2017/wikimedia-office.2017-06-14-21.02.html
Full logs: http://tools.wmflabs.org/meetbot/wikimedia-office/2017/wikimedia-office.2017-06-14-21.02.log.html

Thu, Jun 15, 10:29 AM
Tgr renamed E615: ArchCom RFC Meeting: Reading List service (2017-06-14, #wikimedia-office) from ArchCom RFC Meeting Wxx: <topic TBD> (<see "Starts" field>, #wikimedia-office) to ArchCom RFC Meeting: Reading List service (2017-06-14, #wikimedia-office).
Thu, Jun 15, 10:24 AM

Wed, Jun 14

Tgr added a comment to T167535: MW-1.30.0-wmf.6 deployment blockers.

https://gerrit.wikimedia.org/r/#/c/359047/ (or some other way of fixing T167922: [Regression wmf.5] On enhanced watchlists, boldness styling shows regardless of diffs being seen, and a gadget is broken in master) is a blocker.

Wed, Jun 14, 11:57 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
Tgr added a comment to T167922: [Regression wmf.5] On enhanced watchlists, boldness styling shows regardless of diffs being seen, and a gadget is broken.

It also appears that the data attributes added by this change don't actually get added for the most part, so we're not really losing much functionality there.

Wed, Jun 14, 10:50 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Regression, MediaWiki-Watchlist
Tgr added a comment to T167922: [Regression wmf.5] On enhanced watchlists, boldness styling shows regardless of diffs being seen, and a gadget is broken.

Classes should be added to $attribs only after isReservedDataAttribute has been called, otherwise it removes them.

Wed, Jun 14, 8:51 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Regression, MediaWiki-Watchlist
Tgr added a comment to T167922: [Regression wmf.5] On enhanced watchlists, boldness styling shows regardless of diffs being seen, and a gadget is broken.

Steps to reproduce:

  • watchlist a page
  • edit it from a different account/anon
  • view RC with the original account

The edit should be bold but is not.

Wed, Jun 14, 8:47 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Regression, MediaWiki-Watchlist
Tgr added a comment to T164990: RfC: Reading List service.

@CKoerner_WMF: outreach for technoogy RfCs is usually aimed at the developer community, wikitech-l is IMO the best place for that. Wider community outreach about use cases / product goals is nice (and hopefully already happened or has been planned) but it's product goals rather than implementation plans that's relevant to these communities.

Wed, Jun 14, 7:21 PM · DBA, ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr added a comment to T164990: RfC: Reading List service.

they are private data

Why?

Wed, Jun 14, 7:01 PM · DBA, ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr reassigned T141474: Automatic start of authentication workflow for link provider (if it's the only available one) from Tgr to cicalese.

This was fixed in https://gerrit.wikimedia.org/r/#/c/323646/ . The last change is not merged but I guess not strictly part of the task.

Wed, Jun 14, 5:04 PM · User-Tgr, Security-Reviews, Patch-For-Review, MediaWiki-Authentication-and-authorization
Tgr renamed T162379: Decide which non-standard CSS properties to support in TemplateStyles from Decide which CSS properties to support to Decide which non-standard CSS properties to support in TemplateStyles.
Wed, Jun 14, 4:06 PM · MediaWiki-Platform-Team, css-sanitizer, TemplateStyles
Tgr added a subtask for T483: RfC: Allow styling in templates: T162379: Decide which non-standard CSS properties to support in TemplateStyles.
Wed, Jun 14, 4:06 PM · ArchCom-RfC (ArchCom-Approved), VisualEditor, Parsing-Team, RfC, TemplateStyles, Wikimedia-Hackathon-2016
Tgr added a parent task for T162379: Decide which non-standard CSS properties to support in TemplateStyles: T483: RfC: Allow styling in templates.
Wed, Jun 14, 4:06 PM · MediaWiki-Platform-Team, css-sanitizer, TemplateStyles
Tgr moved T167210: [Spike] Investigate adding PDF TOC with PDF page numbers to electron from To Do to Doing on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Wed, Jun 14, 3:50 PM · Reading-Infrastructure-Team-Backlog (Kanban), Epic, Services (watching), Reading-Web-Backlog
Tgr added a comment to T167210: [Spike] Investigate adding PDF TOC with PDF page numbers to electron.

Actually there is a much simpler way. PDF documents contain the targets of internal links (such as the TOC link) as Destination objects (PDF spec 12.3.2.2) with the id value as the name, and the Destination object includes a reference to the parent page. So given an id (which is already provided by MCS for example) one can easily extract the page number:

Wed, Jun 14, 1:14 PM · Reading-Infrastructure-Team-Backlog (Kanban), Epic, Services (watching), Reading-Web-Backlog
Tgr added a comment to T167210: [Spike] Investigate adding PDF TOC with PDF page numbers to electron.

Marking up the PDF is possible but highly impractical.

Wed, Jun 14, 12:58 PM · Reading-Infrastructure-Team-Backlog (Kanban), Epic, Services (watching), Reading-Web-Backlog

Tue, Jun 13

Tgr awarded T165860: Request for +2 rights on mediawiki/* for Ladsgroup a Like token.
Tue, Jun 13, 11:10 AM · Release-Engineering-Team (Kanban), Repository-Ownership-Requests
Tgr updated subscribers of T167614: Bot that notifies Wikipedia when a file on Commons is nominated for deletion.

A long time ago, @daniel's bot CommonsTicker sent warnings to all wikis. Not sure if it just needs a maintainer or has stopped for some other reason.

Tue, Jun 13, 9:02 AM · Commons, Wiki-Project-Med

Mon, Jun 12

Tgr created T167739: Vagrant SSH occasionally fails after bringing up.
Mon, Jun 12, 9:20 PM · MediaWiki-Vagrant
Tgr closed T152588: Whitelist TSG for account creation as Declined.

Sure. Feel free to reopen if it is decided to be necessary after all.

Mon, Jun 12, 8:24 PM · Support-and-Safety, Patch-For-Review, Reading-Admin, Wikimedia-Site-requests
Tgr moved T156500: Document extensions' MediaWiki version compatibility better from Backlog to Pending on the User-Tgr board.
Mon, Jun 12, 12:11 PM · User-Tgr, MediaWiki-Stakeholders-Group, Documentation, Developer-Wishlist (2017)
Tgr moved T111731: Integrate a modern debug/error display tool into MediaWiki from Backlog to Pending on the User-Tgr board.
Mon, Jun 12, 12:11 PM · Patch-For-Review, User-Tgr, Wikimedia-Hackathon-2017, Developer-Wishlist (2017), MediaWiki-extension-requests
Tgr moved T158909: Automatically detect spambot registration using machine learning (like invisible reCAPTCHA) from Backlog to Next on the User-Tgr board.
Mon, Jun 12, 12:11 PM · User-Tgr, MediaWiki-extension-requests, artificial-intelligence
Tgr moved T109156: Investigate converting OAuth to use ContentHandler from Backlog to Next on the User-Tgr board.
Mon, Jun 12, 12:11 PM · User-Tgr, MediaWiki-extensions-OAuth
Tgr renamed T158909: Automatically detect spambot registration using machine learning (like invisible reCAPTCHA) from Spambot detection to Automatically detect spambot registration using machine learning (like invisible reCAPTCHA) .
Mon, Jun 12, 12:10 PM · User-Tgr, MediaWiki-extension-requests, artificial-intelligence

Fri, Jun 9

Tgr added a comment to T165540: Add CODE_OF_CONDUCT.md to Wikimedia repositories.

Anyways, as for the status of this task, someone needs to retroactively announce this, then we need to decide whether it's going to be a requirement that all Gerrit repos have this file (keeping in mind the technical exemptions I mentioned earlier), and what to do with the repos where it was reverted out.

Fri, Jun 9, 11:46 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
Tgr added a comment to T167210: [Spike] Investigate adding PDF TOC with PDF page numbers to electron.

Check out the vivlio link I gave above. At least for Obama, the pagination in the preview does match the print output exactly.

Fri, Jun 9, 5:36 PM · Reading-Infrastructure-Team-Backlog (Kanban), Epic, Services (watching), Reading-Web-Backlog
Halfak awarded T165540: Add CODE_OF_CONDUCT.md to Wikimedia repositories a Love token.
Fri, Jun 9, 5:34 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
MelodyKramer awarded T165540: Add CODE_OF_CONDUCT.md to Wikimedia repositories a Love token.
Fri, Jun 9, 5:19 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
JMinor awarded T165540: Add CODE_OF_CONDUCT.md to Wikimedia repositories a Love token.
Fri, Jun 9, 5:14 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
Tgr added a comment to T167210: [Spike] Investigate adding PDF TOC with PDF page numbers to electron.

@Tgr hmmm.... are you saying that you can't easily get the page rects with the current chromium ipc system?

Fri, Jun 9, 4:56 PM · Reading-Infrastructure-Team-Backlog (Kanban), Epic, Services (watching), Reading-Web-Backlog
Tgr added a comment to T165540: Add CODE_OF_CONDUCT.md to Wikimedia repositories.

As a member of the technical community entrusted with +2 access, you're expected to answer any reasonable questions and concerns raised by your actions.

Fri, Jun 9, 2:37 PM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
Tgr added a comment to T167465: "Key contains invalid characters" when using MultiWriteBagOStuff.

MultiWriteBagOStuff should probably unmake keys into arrays and passing them to the makeKey method of the bag it is proxying to, before calling that bag's get/set method.

Fri, Jun 9, 11:01 AM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Performance-Team, MediaWiki-Cache, Commons, Wikimedia-log-errors
Tgr added a comment to T165540: Add CODE_OF_CONDUCT.md to Wikimedia repositories.

Dead horses aside, what's the status of this task? It seems the file was added to a random subset of repos but omitted from others. Is there a logic behind that or should we just go through systematically and add it where it is absent, or should we just cycle through the rest? I put the push script into P5546, fixed the concerns in T165540#3316733 and some other issues (use the default branch even if it's not called master, ignore repos which already have the file, add a skip list).

Fri, Jun 9, 10:49 AM · MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations