Page MenuHomePhabricator

Tgr (Gergő Tisza)
Software Engineer, WMF

Projects (44)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 4:55 PM (346 w, 1 d)
Availability
Available
IRC Nick
tgr
LDAP User
Gergő Tisza
MediaWiki User
Tgr (WMF) [ Global Accounts ]

Things my team is working on: Growth-Team (kanban board)
Side projects I am working on (or planning to, eventually): User-Tgr
You can find more info about me on my user page.

Recent Activity

Yesterday

Tgr updated the task description for T282327: Mailman 3: Invalid Parameter "delivery_status": Accepted Values are: enabled, by_user, by_bounces, by_moderator, unknown..
Sat, May 8, 9:56 PM · SRE, Wikimedia-Mailing-lists
Tgr created T282328: Mailman 3: Changing email address seems to break subscription for listadmins list.
Sat, May 8, 9:54 PM · SRE, Wikimedia-Mailing-lists
Tgr created T282327: Mailman 3: Invalid Parameter "delivery_status": Accepted Values are: enabled, by_user, by_bounces, by_moderator, unknown..
Sat, May 8, 9:45 PM · SRE, Wikimedia-Mailing-lists
Tgr added a comment to T282279: Mailman 3: per-list language preferences don't work.

Apparently this happens if you try to unset the language (set it to the ---- option so it inherits global preferences).

Sat, May 8, 9:40 PM · SRE, Wikimedia-Mailing-lists
Tgr added a comment to T282320: Recursive service instantiation: Circular dependency when creating service! MainWANObjectCache.

Locally, there's no issue, with CentralAuth and GrowthExperiments installed.

vagrant@growth:~$ mwscript /vagrant/mediawiki/tests/phpunit/phpunit.php --wiki=wiki --filter MultiLock /vagrant/mediawiki/tests/phpunit/structure/SpecialPageFatalTest.php 
#!/usr/bin/env php
Using PHP 7.2.31-1+0~20200514.41+debian9~1.gbpe2a56b+wmf1
PHPUnit 8.5.15 by Sebastian Bergmann and contributors.
Sat, May 8, 7:43 PM · Growth-Team (Current Sprint)
Tgr added a comment to T282320: Recursive service instantiation: Circular dependency when creating service! MainWANObjectCache.

MultiLock is a CentralAuth special page so probably this is some conflict with that extension (which does use UserNameUtils a lot).

Sat, May 8, 7:41 PM · Growth-Team (Current Sprint)
Tgr added a comment to T282320: Recursive service instantiation: Circular dependency when creating service! MainWANObjectCache.

No idea what's happening here. The error seems to imply that the service factory function for MainWANObjectCache requests UserNameUtils from the service container, but it doesn't (and there is no reason why it would). The rest of the dependencies seem legit.

Sat, May 8, 7:25 PM · Growth-Team (Current Sprint)
Tgr created T282320: Recursive service instantiation: Circular dependency when creating service! MainWANObjectCache.
Sat, May 8, 7:10 PM · Growth-Team (Current Sprint)
Tgr moved T281462: Prevent link suggestions from appearing again after publishing an edit from Code Review to QA on the Growth-Team (Current Sprint) board.
Sat, May 8, 6:13 PM · Patch-For-Review, Growth-Team (Current Sprint), Add-Link

Fri, May 7

Tgr closed T269792: Flow\SubmissionHandler::commit was called with $blocks set to an empty array or a falsy value. as Resolved.

Thanks for the fix!

Fri, May 7, 8:56 PM · Growth-Team-Filtering, Growth-Team, StructuredDiscussions, Wikimedia-production-error
Tgr added a comment to T269792: Flow\SubmissionHandler::commit was called with $blocks set to an empty array or a falsy value..

This happens when a mentee sends a question to a mentor who has a Flow talk page (or to a Flow-enabled help desk), and saving the question fails for some reason (page is protected, AbuseFilter etc).

Fri, May 7, 8:52 PM · Growth-Team-Filtering, Growth-Team, StructuredDiscussions, Wikimedia-production-error
Tgr created T282281: growthsetmentor API error message growthexperiments-homepage-claimmentee-already-mentor assumes request is made by mentor.
Fri, May 7, 8:49 PM · Growth-Team, GrowthExperiments-Mentorship
Tgr created T282279: Mailman 3: per-list language preferences don't work.
Fri, May 7, 8:14 PM · SRE, Wikimedia-Mailing-lists
Tgr added a comment to T281977: Reconsidering of eligibility criteria for technical contributions in elections.

Thanks for bringing this up Jay. I agree those criteria are not great. A first attempt to improve it would be: users are eligible if they made a contribution to Wikimedia software between 1 October 2016 and 1 April 2017.

  • A contribution could be a merged commit, translation, documentation (although that can be handled by the editcount criteria), design, bug report etc. There could be some quantity limit too (one commit is a pretty low bar compared to the 500 edits in the editor eligibility criteria, although of course there are commits which take a lot of effort).
  • Wikimedia software is anything that's written primarily for the Wikimedia community to use (we don't want to give voting rights to e.g. Apache committers even though Apache is used on the Wikimedia servers, but we also don't want to exclude e.g. the maintainers of Wikiloop, who are technical contributors maintaining a Wikimedia tool, even though neither the tool itself nor its source code or issue tracker is hosted on Wikimedia infrastructure) and does get used to some extent by Wikimedia community members (we don't want to include completely theoretical projects that the movement doesn't actually benefit from).
Fri, May 7, 6:06 PM · User-brennen, Elections, User-Jayprakash12345
Tgr awarded T281977: Reconsidering of eligibility criteria for technical contributions in elections a Like token.
Fri, May 7, 5:40 PM · User-brennen, Elections, User-Jayprakash12345
Tgr added a comment to T282170: Move "Short Descriptions" outside Wikibase.git.

Isn't there a WMF team that is responsible for maintaining this API?

Fri, May 7, 1:35 PM · wdwb-tech

Thu, May 6

Tgr added a comment to T279829: Enable magic word SHORTDESC on German-language Wikipedia.

I am pretty sure that the short description will work in the same way as the sort key does right now; thus we of course need to review the revision (in the wikitext), but the description the page uses will come from the latest revision, even if not reviewed. That is of course not the ideal behaviour (same for DEFAULTSORT), but with the current status of the FlaggedRevs extension it is to be expected.

Thu, May 6, 6:33 PM · User-Urbanecm, User-Luke081515, wdwb-tech, Wikidata, Wikimedia-Site-requests
Tgr added a comment to T282170: Move "Short Descriptions" outside Wikibase.git.

There is Extension:ShortDescription which reimplements the same functionality and interface on a non-Wikibase basis. If the maintainer is up to it, maybe the Wikibase-related functionality could be moved over there.

Thu, May 6, 6:20 PM · wdwb-tech
Tgr created T282146: Flow\Exception\InvalidReferenceException in CirrusSearch DataSender::sendData job.
Thu, May 6, 2:29 PM · CirrusSearch, Discovery-Search, StructuredDiscussions, Wikimedia-production-error, Growth-Team
Tgr created T282145: ExternalStore makes primary read on GET requests.
Thu, May 6, 2:15 PM · MediaWiki-Revision-backend, Wikimedia-production-error
Tgr renamed T282069: Flow: PHP Notice: Trying to get property [...] of non-object from PHP Notice: Trying to get property [...] of non-object to Flow: PHP Notice: Trying to get property [...] of non-object.
Thu, May 6, 11:49 AM · StructuredDiscussions, Growth-Team, Wikimedia-production-error
Tgr renamed T281782: Flow: ContributionsFormatter times out for a certain user from Wikimedia\RequestTimeout\RequestTimeoutException: The maximum execution time of 60 seconds was exceeded to Flow: ContributionsFormatter times out for a certain user.
Thu, May 6, 11:49 AM · Parsoid, StructuredDiscussions, Growth-Team, Wikimedia-production-error
Tgr closed T275322: Some edits made by extended confirmed users are no longer automatically accepted as Resolved.

Thanks!

Thu, May 6, 11:29 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Regression, MediaWiki-extensions-FlaggedRevs
Tgr closed T275322: Some edits made by extended confirmed users are no longer automatically accepted, a subtask of T234743: User rights validation is sometimes malfunctioning (with FlaggedRevs only?), as Resolved.
Thu, May 6, 11:28 AM · Release-Engineering-Team, User-DannyS712, MediaWiki-User-management
Tgr added a comment to T279411: Determine why service responses are slow and what we can do about it.

I 'll admit that with a lack of clear SLO, I am not sure what that translates to for the service itself. Since it's being called by a maint script only (is that still true? I guess but doublechecking), there should be no user visible consequence which is a plus. maintenance script execution times must have increased but that might be fully ok right now.

Thu, May 6, 10:35 AM · Patch-For-Review, Growth-Team (Current Sprint), serviceops, Data-Persistence (Consultation), Add-Link
Tgr created T282090: Language selector not visible on Hungarian Wikipedia in modern Vector with Javascript enabled.
Thu, May 6, 8:33 AM · Desktop Improvements, Vector

Wed, May 5

Tgr added a comment to T275322: Some edits made by extended confirmed users are no longer automatically accepted.

As noted in the parent task (T234743#7063693), this might be fixed now. Your help with re-testing it would be appreciated!

Wed, May 5, 8:00 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Regression, MediaWiki-extensions-FlaggedRevs
Tgr added a subtask for T234743: User rights validation is sometimes malfunctioning (with FlaggedRevs only?): T275322: Some edits made by extended confirmed users are no longer automatically accepted.
Wed, May 5, 7:59 PM · Release-Engineering-Team, User-DannyS712, MediaWiki-User-management
Tgr added a parent task for T275322: Some edits made by extended confirmed users are no longer automatically accepted: T234743: User rights validation is sometimes malfunctioning (with FlaggedRevs only?).
Wed, May 5, 7:59 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Regression, MediaWiki-extensions-FlaggedRevs
Tgr added a comment to T234744: Enwikibooks: Rollback intermittently limited to administrators.

As noted in the parent task (T234743#7063693), this might be fixed now. Your help with re-testing it would be appreciated!

Wed, May 5, 7:56 PM · User-DannyS712, MediaWiki-User-management
Tgr added a comment to T233561: Pending changes: autoreview randomly fails.

As noted in the parent task (T234743#7063693), this might be fixed now. Your help with re-testing it would be appreciated!

Wed, May 5, 7:55 PM · Regression, MediaWiki-User-management, User-DannyS712, MediaWiki-extensions-FlaggedRevs
Tgr added a comment to T234743: User rights validation is sometimes malfunctioning (with FlaggedRevs only?).

We have recently deployed rEFLR90edbb9f7c01: Run setup from MediaWikiServices hook. and rOMWC9722a37ca149: flaggedrevs.php: Use MediaWikiServices, not an extension function which might fix the issue. If you have a way to check whether the issue is still happening, your testing would be appreciated.

Wed, May 5, 7:53 PM · Release-Engineering-Team, User-DannyS712, MediaWiki-User-management
Tgr added a comment to T273317: some users with access are unable to configure pending changes.

Presumably this was fixed by the changes indicated in T273317#6886636? I can't reproduce it and I'm sure if the pending protection interface were broken completely, as the task description states, we would have heard a lot more about it in the three months since opening the task.

Wed, May 5, 7:51 PM · Patch-For-Review, Platform Team Workboards (MW Expedition), Regression, MediaWiki-extensions-FlaggedRevs
Tgr added a comment to T282042: Investigate on how to use Template:Multiple Issues for Suggested edits.

You can also see templates in the page info, e.g. https://en.wikipedia.org/w/index.php?title=Original_brand_manufacturer&action=info#mw-pageinfo-templates

Wed, May 5, 6:52 PM · Growth-Team, GrowthExperiments-Homepage
Tgr added a comment to T279411: Determine why service responses are slow and what we can do about it.

The maintenance script was working fine during that time, no timeouts or anything.

Wed, May 5, 5:13 PM · Patch-For-Review, Growth-Team (Current Sprint), serviceops, Data-Persistence (Consultation), Add-Link
Tgr added a comment to T281529: HomepageModule: '.event.user_variant' should be string.

Something somewhere must be very broken if the errors were really caused by the variant string being called "null".

Wed, May 5, 5:03 PM · Growth-Team (Current Sprint), GrowthExperiments-Homepage
Tgr lowered the priority of T272904: PageTriage extension causes TypeError: format.replace is not a function in randomToken function im SearchSatisfaction schema from Unbreak Now! to High.

UBN implies a sense of urgency and this bug has been around for a long time so unless it became more disruptive recently e.g. due to improvements to the JS error dashboard, I don't think it's that urgent.

Wed, May 5, 1:52 PM · PageCuration, Growth-Team, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), JavaScript, Release-Engineering-Team (Logspam), Wikimedia-production-error
Tgr added a comment to T281960: TypeError: can't access property "setNotices", actionTools.notices is undefined.

On second thought, maybe not block notifications (they use the same display mechanism as edit notices in the wikitext editor, but maybe not in VE). Page protection notices would show up there, but we exclude protected pages anyway. FlagRev notices, maybe?

Wed, May 5, 9:53 AM · Add-Link, Growth-Team (Current Sprint), Wikimedia-production-error
Tgr added a comment to T281960: TypeError: can't access property "setNotices", actionTools.notices is undefined.

Edit notices are configurable per page or per namespace, although I can't really imagine one that would be relevant for someone using the add link tool.

Wed, May 5, 9:50 AM · Add-Link, Growth-Team (Current Sprint), Wikimedia-production-error

Tue, May 4

Tgr moved T281924: Uncaught TypeError: Cannot read property 'getData' of null at AddLinkSaveDialog.ve.ui.MWSaveDialog.updateReviewMode from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Tue, May 4, 9:27 PM · Growth-Team (Current Sprint), Add-Link, GrowthExperiments-NewcomerTasks
Tgr added a comment to T281924: Uncaught TypeError: Cannot read property 'getData' of null at AddLinkSaveDialog.ve.ui.MWSaveDialog.updateReviewMode.

It's probably caused by this part of ve.ui.MWSaveDialog.getSetupProcess:

this.reviewModeButtonSelect.selectItemByData(
    ve.userConfig( 'visualeditor-diffmode-' + surfaceMode ) || surfaceMode
);

getting confused by our custom surface mode.

Tue, May 4, 9:23 PM · Growth-Team (Current Sprint), Add-Link, GrowthExperiments-NewcomerTasks
Tgr created T281924: Uncaught TypeError: Cannot read property 'getData' of null at AddLinkSaveDialog.ve.ui.MWSaveDialog.updateReviewMode.
Tue, May 4, 9:14 PM · Growth-Team (Current Sprint), Add-Link, GrowthExperiments-NewcomerTasks
Tgr moved T281703: TypeError: Argument 1 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must implement interface UserIdentity, null given from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, May 4, 8:21 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link, GrowthExperiments-NewcomerTasks, Wikimedia-production-error
Tgr moved T281777: Add a link: link suggested inside red link from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, May 4, 7:12 PM · Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks

Mon, May 3

Tgr added a comment to T281777: Add a link: link suggested inside red link.

This is an instance of T267694: Add a link in VE: define exclusion rules for finding text in the DOM: the recommendation service only takes top-level plain text into account when calculating match offsets, and we don't replicate that behavior on the client side (we take all text into account that's not inside a template).

Mon, May 3, 10:37 PM · Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks
kostajh awarded T281727: Rename GrowthExperiments default user variant to 'control' a Like token.
Mon, May 3, 3:35 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Tgr created T281727: Rename GrowthExperiments default user variant to 'control'.
Mon, May 3, 3:28 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Tgr moved T266913: Add a link engineering: create tables in Wikimedia production from Ready for Development to Code Review on the Growth-Team (Current Sprint) board.
Mon, May 3, 2:20 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Add-Link
Tgr added a comment to T266913: Add a link engineering: create tables in Wikimedia production.
tgr@mwmaint1002:~$ for wiki in `cat /srv/mediawiki/dblists/growthexperiments.dblist | tail -n+2`; do sql $wiki --cluster=extension1 -- -e "show tables like 'growthexperiments%';"; done
+---------------------------------------+
| Tables_in_arwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_bnwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+----------------------------------------+
| Tables_in_cawiki (growthexperiments%)  |
+----------------------------------------+
| growthexperiments_link_recommendations |
| growthexperiments_link_submissions     |
| growthexperiments_mentee_data          |
| growthexperiments_mentor_mentee        |
+----------------------------------------+
+----------------------------------------+
| Tables_in_cswiki (growthexperiments%)  |
+----------------------------------------+
| growthexperiments_link_recommendations |
| growthexperiments_link_submissions     |
| growthexperiments_mentee_data          |
| growthexperiments_mentor_mentee        |
+----------------------------------------+
+---------------------------------------+
| Tables_in_dawiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+----------------------------------------+
| Tables_in_elwiki (growthexperiments%)  |
+----------------------------------------+
| growthexperiments_link_recommendations |
| growthexperiments_link_submissions     |
| growthexperiments_mentee_data          |
| growthexperiments_mentor_mentee        |
+----------------------------------------+
+---------------------------------------+
| Tables_in_eowiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_eswiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_euwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_fawiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_frwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------------+
| Tables_in_frwiktionary (growthexperiments%) |
+---------------------------------------------+
| growthexperiments_mentee_data               |
| growthexperiments_mentor_mentee             |
+---------------------------------------------+
+---------------------------------------+
| Tables_in_hewiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_hiwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_hrwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_huwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_hywiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_idwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_jawiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_kowiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_mswiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_nowiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_plwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_ptwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_rowiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_ruwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_shwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+-------------------------------------------+
| Tables_in_simplewiki (growthexperiments%) |
+-------------------------------------------+
| growthexperiments_mentee_data             |
| growthexperiments_mentor_mentee           |
+-------------------------------------------+
+---------------------------------------+
| Tables_in_sqwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_srwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_svwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_tawiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+-----------------------------------------+
| Tables_in_testwiki (growthexperiments%) |
+-----------------------------------------+
| growthexperiments_link_recommendations  |
| growthexperiments_link_submissions      |
| growthexperiments_mentee_data           |
| growthexperiments_mentor_mentee         |
+-----------------------------------------+
+---------------------------------------+
| Tables_in_tewiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_thwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_trwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+---------------------------------------+
| Tables_in_ukwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+
+----------------------------------------+
| Tables_in_urwiki (growthexperiments%)  |
+----------------------------------------+
| growthexperiments_link_recommendations |
| growthexperiments_link_submissions     |
| growthexperiments_mentee_data          |
| growthexperiments_mentor_mentee        |
+----------------------------------------+
+---------------------------------------+
| Tables_in_viwiki (growthexperiments%) |
+---------------------------------------+
| growthexperiments_mentee_data         |
| growthexperiments_mentor_mentee       |
+---------------------------------------+

So apparently not quite true.

Mon, May 3, 2:08 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Add-Link
Tgr added a comment to T266913: Add a link engineering: create tables in Wikimedia production.

I think this has happened everywhere because the tables are part of the createExtensionTables.php script which was run for other reasons, even on existing wikis (T279853: Migrate mentor/mentee relationship to a separate database table on Wikimedia wikis, probably).

Mon, May 3, 1:48 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Add-Link
Tgr updated the task description for T278710: Add a link: production deployment.
Mon, May 3, 1:45 PM · Patch-For-Review, Growth-Team (Current Sprint), Add-Link
Tgr updated the task description for T278710: Add a link: production deployment.
Mon, May 3, 1:45 PM · Patch-For-Review, Growth-Team (Current Sprint), Add-Link
Tgr added a comment to T278710: Add a link: production deployment.

This is now done for cswiki; you can use ge.utils.setUserVariant('linkrecommendation') to enable link recommendations and ge.utils.setUserVariant(null) to disable it. Tasks should start showing up within an hour.

Mon, May 3, 1:42 PM · Patch-For-Review, Growth-Team (Current Sprint), Add-Link
Tgr closed T281382: Make sure all GrowthExperiments DB writes handle readonly mode well as Resolved.
Mon, May 3, 1:34 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), GrowthExperiments, Growth-Team (Current Sprint)
Tgr claimed T281703: TypeError: Argument 1 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must implement interface UserIdentity, null given.
Mon, May 3, 12:52 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link, GrowthExperiments-NewcomerTasks, Wikimedia-production-error
Tgr moved T281703: TypeError: Argument 1 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must implement interface UserIdentity, null given from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Mon, May 3, 12:51 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link, GrowthExperiments-NewcomerTasks, Wikimedia-production-error
Tgr added a comment to T281703: TypeError: Argument 1 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must implement interface UserIdentity, null given.

Looks like Maintenance script is not a system user on cswiki so $this->searchUser = User::newSystemUser( 'Maintenance script' ); ends up setting it to null.

Mon, May 3, 12:48 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link, GrowthExperiments-NewcomerTasks, Wikimedia-production-error
Tgr created T281703: TypeError: Argument 1 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must implement interface UserIdentity, null given.
Mon, May 3, 12:44 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), Add-Link, GrowthExperiments-NewcomerTasks, Wikimedia-production-error
Tgr added a comment to T278710: Add a link: production deployment.

Steps:

  • add link recommendations to task type configuration (edit)
    • test (should have no visible effect)
  • run mwscript extensions/WikimediaMaintenance/createExtensionTables.php --wiki=cswiki GrowthExperiments (probably not needed as the tables were already created due to the mentor migration, but no harm in it)
  • make sure gerrit 684080 is backported
  • enable backend gerrit 684327
    • test; should be a no-op for users but allow running the refresh script
  • enable frontend gerrit 684331
    • test; should allow opt-in but otherwise still be a no-op
Mon, May 3, 10:59 AM · Patch-For-Review, Growth-Team (Current Sprint), Add-Link
Tgr changed the status of T278710: Add a link: production deployment from Stalled to Open.

Skipped last Thursday because the train had problems, doing it today.

Mon, May 3, 10:51 AM · Patch-For-Review, Growth-Team (Current Sprint), Add-Link
Tgr changed the status of T278710: Add a link: production deployment, a subtask of T261396: Add a link: engineering tasks for initial release, from Stalled to Open.
Mon, May 3, 10:51 AM · Add-Link, Growth-Structured-Tasks

Sun, May 2

Tgr added a comment to T281382: Make sure all GrowthExperiments DB writes handle readonly mode well.

Done but will need a backport.

Sun, May 2, 11:54 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), GrowthExperiments, Growth-Team (Current Sprint)
Tgr added a comment to T280129: Disable interactions with all context items except for RecommendedLinkContextItem.

After unregistering all the context items, clicking on an image still does something; at least the focus behavior changes. (If you click on an image, then click on a link suggestion, the suggestion won't activate.) Not sure if that's worth fixing.

Sun, May 2, 8:53 PM · Growth-Team (Current Sprint), Add-Link
Tgr merged T134912: vagrant git-update error "could not allocate 218103807 bytes for translation cache" into T233920: Vagrant: Composer runs out of memory during vagrant git-update.
Sun, May 2, 3:54 PM · Patch-For-Review, MediaWiki-Vagrant, Composer
Tgr merged task T134912: vagrant git-update error "could not allocate 218103807 bytes for translation cache" into T233920: Vagrant: Composer runs out of memory during vagrant git-update.
Sun, May 2, 3:54 PM · MediaWiki-Vagrant
Tgr added a comment to T134912: vagrant git-update error "could not allocate 218103807 bytes for translation cache".

I think this is the same as T233920: Vagrant: Composer runs out of memory during vagrant git-update, only with a HHVM-specific error message. We don't use HHVM anymore so let's merge it.

Sun, May 2, 3:54 PM · MediaWiki-Vagrant
Tgr merged T195534: Vagrant encounters OOM errors inside VM with default settings on 8-core / 16-thread box into T233920: Vagrant: Composer runs out of memory during vagrant git-update.
Sun, May 2, 3:54 PM · Patch-For-Review, MediaWiki-Vagrant, Composer
Tgr merged task T195534: Vagrant encounters OOM errors inside VM with default settings on 8-core / 16-thread box into T233920: Vagrant: Composer runs out of memory during vagrant git-update.
Sun, May 2, 3:54 PM · MediaWiki-Vagrant
Tgr renamed T233920: Vagrant: Composer runs out of memory during vagrant git-update from Vagrant: Composer runs out of memory to Vagrant: Composer runs out of memory during vagrant git-update.
Sun, May 2, 3:54 PM · Patch-For-Review, MediaWiki-Vagrant, Composer
Tgr added a comment to T279853: Migrate mentor/mentee relationship to a separate database table on Wikimedia wikis.

It would be nice to deploy SCHEMA_COMPAT_NEW before Wednesday as the x1 migration will cause the DB store to be readonly while the pref store is still writable. In theory a readonly error would cause both connections to be rolled back so they would not get out of sync, and in theory even if they do get out sync it shouldn't cause any issue - still, one less potential (if unlikely) source of trouble.

Sun, May 2, 9:50 AM · Patch-For-Review, User-Urbanecm_WMF (Engineering), Wikimedia-maintenance-script-run, Growth-Team (Current Sprint), GrowthExperiments-Mentorship

Sat, May 1

Tgr claimed T281232: '.event.referer_route' should be equal to one of the allowed values.
Sat, May 1, 9:36 PM · Growth-Team (Current Sprint), Wikimedia-production-error
Tgr moved T281382: Make sure all GrowthExperiments DB writes handle readonly mode well from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Sat, May 1, 4:38 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), GrowthExperiments, Growth-Team (Current Sprint)
Tgr added a comment to T281382: Make sure all GrowthExperiments DB writes handle readonly mode well.
  • ApiSetMentor: should be disabled in readonly mode
  • SpecialClaimMentee: should be disabled in readonly mode
Sat, May 1, 3:00 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), GrowthExperiments, Growth-Team (Current Sprint)
Tgr added a comment to T281382: Make sure all GrowthExperiments DB writes handle readonly mode well.

Code that does writes:

  • LinkRecommendationStore::insert()
    • RefreshLinkRecommendations. Probably easiest to just abort the script if the DB is readonly, it will be re-run in an hour. It's a long-running script so checking for readonly at start won't suffice.
  • LinkRecommendationStore::deleteByPageIds()
    • FixLinkRecommendationData: manual script, not worth the effort fixing.
    • HomepageHooks::onSearchDataForIndex(): probably just suppress the exception. We'll still want to delete the recommendation from the search index; leaving it in the DB doesn't affect anything.
    • AddLinkSubmissionHandler: same as above. In this case not deleting the DB record means the page will be considered unavailable for future task generation, but that fixes itself the next time it is edited so not such a big deal.
  • LinkRecommendationStore::deleteByLinkTarget() - not used
  • LinkRecommendationStore::recordSubmission()
    • AddLinkSubmissionHandler: when it's called, the edit is already saved so not much we can do, just accept it won't be recorded in the link_submission table.
  • DatabaseMentorStore::setMentorForUserReal()
    • ApiSetMentor: should be disabled in readonly mode
    • SpecialClaimMentee: should be disabled in readonly mode
    • MentorManager::getMentorForUser(): called from many places, selects a mentor if one isn't already selected. Should gracefully return null in readonly mode.
    • SetUserMentorDatabaseJob: called from the one above on GET requests. Fail the job and hopefully get rescheduled outside the maintenance window.
    • MigrateMentorMenteeRelationship: one-time script, not worth the effort fixing.
Sat, May 1, 2:27 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), GrowthExperiments, Growth-Team (Current Sprint)
Tgr added a comment to T269659: Add a link: post-edit dialog.

In terms of code complexity, it doesn't make much difference, all the options are trivial to implement. But I think it would feel confusing to me as a user if the "close" option would sometimes appear and sometimes not; whether the user accepted any recommendations does not have much to do with whether they might want to interact more with the article. (And there are other ways than the button to close the dialog, so removing the button doesn't remove the complexity of how to handle if the user clicks "Edit" again.)

Sat, May 1, 2:21 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks

Fri, Apr 30

Tgr moved T281382: Make sure all GrowthExperiments DB writes handle readonly mode well from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.
Fri, Apr 30, 4:54 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), GrowthExperiments, Growth-Team (Current Sprint)
Tgr added a comment to T281289: Exception related to OAuthAuthentication on Translate pages.

I'd recommend using WSOAuth instead. OAuthAuthentication will have more features when (if) it's finished, but using a WIP patchset that was written years ago is invitation for trouble.

Fri, Apr 30, 4:35 PM · MediaWiki-extensions-OAuthAuthentication, Lingua Libre
Tgr moved T269659: Add a link: post-edit dialog from Design Review to Code Review on the Growth-Team (Current Sprint) board.

Yeah, this wasn't implemented yet (it's just fairly similar to the existing feature). Also I think the design changes are not part of this task, the mocks include other tasks like T272664: Add a link: refresh button on post-edit dialog (nice to have).

Fri, Apr 30, 12:17 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Growth-Team (Current Sprint), GrowthExperiments, Add-Link, Growth-Structured-Tasks

Thu, Apr 29

Tgr created T281529: HomepageModule: '.event.user_variant' should be string.
Thu, Apr 29, 8:42 PM · Growth-Team (Current Sprint), GrowthExperiments-Homepage
Tgr created T281525: Invalid task type ID: {taskTypeId}.
Thu, Apr 29, 8:08 PM · Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks, Wikimedia-production-error
Tgr created T281523: Exception: Flow\Diff\FlowBoardContentDiffView: could not maintain backwards compatibility. Please use a SlotDiffRenderer..
Thu, Apr 29, 7:59 PM · MediaWiki-ContentHandler, StructuredDiscussions, Growth-Team, Wikimedia-production-error
Tgr created T281521: Revision not found in revisionCache: {alpha}.
Thu, Apr 29, 7:51 PM · Growth-Team, StructuredDiscussions, Wikimedia-production-error
Tgr updated the task description for T281519: Master connection on GET via Flow\TalkpageManager::getTalkpageManager --> CentralAuthUser::exists.
Thu, Apr 29, 7:47 PM · StructuredDiscussions, Wikimedia-production-error, Growth-Team
Tgr updated the task description for T281519: Master connection on GET via Flow\TalkpageManager::getTalkpageManager --> CentralAuthUser::exists.
Thu, Apr 29, 7:44 PM · StructuredDiscussions, Wikimedia-production-error, Growth-Team
Tgr removed a project from T281519: Master connection on GET via Flow\TalkpageManager::getTalkpageManager --> CentralAuthUser::exists: MediaWiki-extensions-CentralAuth.

The TalkPageManager uses CentralAuthUser::getMasterInstance() so this is a Flow issue.

Thu, Apr 29, 7:40 PM · StructuredDiscussions, Wikimedia-production-error, Growth-Team
Tgr updated the task description for T281519: Master connection on GET via Flow\TalkpageManager::getTalkpageManager --> CentralAuthUser::exists.
Thu, Apr 29, 7:39 PM · StructuredDiscussions, Wikimedia-production-error, Growth-Team
Tgr created T281519: Master connection on GET via Flow\TalkpageManager::getTalkpageManager --> CentralAuthUser::exists.
Thu, Apr 29, 7:38 PM · StructuredDiscussions, Wikimedia-production-error, Growth-Team
Tgr added a comment to T281462: Prevent link suggestions from appearing again after publishing an edit.

T269659 will probably involve adding a state flag to the suggested edit session (since it needs to differentiate between a real edit and a null edit). So it seems like a good place to handle this, one way or another.

Thu, Apr 29, 12:12 PM · Patch-For-Review, Growth-Team (Current Sprint), Add-Link
Tgr renamed T281416: Continuation for ReadingLists list entries does not work in the REST API from Unclear how to use continuation token for pagination in JSON query: "Invalid paging parameter" (which is an undocumented error) to Continuation for ReadingLists list entries does not work in the REST API.
Thu, Apr 29, 12:07 PM · Product-Infrastructure-Team-Backlog, Reading List Service
Tgr added a comment to T281185: Add a link: link inspector can obscure text.

I think the minimum-effort solution would be a button to either flip the popup position or to hide the popup while the button is pressed down. Both are fairly simple to implement and do not risk the user somehow "locking out" themselves from the workflow and not figuring out how to get back.

Thu, Apr 29, 12:06 PM · Growth-Team (Current Sprint), Add-Link, Growth-Team-Filtering, Growth-Structured-Tasks
Tgr added a comment to T281463: Set background color to recommended link context item.

Possibly a duplicate of T280129: Disable interactions with all context items except for RecommendedLinkContextItem - the blue overlay only shows up when hovering over the infobox, so if interactions are disabled it might not show up at all.

Thu, Apr 29, 12:03 PM · Growth-Team (Current Sprint), Add-Link
Tgr added a comment to T281382: Make sure all GrowthExperiments DB writes handle readonly mode well.

We do wfReadonly() checks in a few places but that's actually not the right thing to check since we use a non-default cluster and the default one will be writable. At a glance the most robust check is LoadBalancer::getReadOnlyReason() which will handle configuration-level readonly settings, DB-level readonly settings and temporary read blocks due to replication lag.

Thu, Apr 29, 11:38 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), GrowthExperiments, Growth-Team (Current Sprint)
Tgr claimed T281382: Make sure all GrowthExperiments DB writes handle readonly mode well.
Thu, Apr 29, 11:35 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), GrowthExperiments, Growth-Team (Current Sprint)
Marostegui awarded T281382: Make sure all GrowthExperiments DB writes handle readonly mode well a Love token.
Thu, Apr 29, 11:17 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), GrowthExperiments, Growth-Team (Current Sprint)

Wed, Apr 28

Tgr added a comment to T247710: Argument 3 passed to ApiAuthManagerHelper::formatMessage() must be an instance of Message, null given, called in ApiAuthManagerHelper.php on line 337.

Only a couple times a week. Suggests it's not something that happens when users do things correctly, but it does mean that when users use the API incorrectly, that it causes an increase in server-side errors (5xx) instead of client warnings (2xx/4xx)

Wed, Apr 28, 8:38 PM · Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-OATHAuth, MediaWiki-API, MediaWiki-Authentication-and-authorization, Wikimedia-production-error
Tgr added a comment to T250314: Investigate Privacy Pass for Wikimedia Sites.

See also T281397: Test trust tokens as a captcha alternative for Wikimedia.

Wed, Apr 28, 8:31 PM · Privacy Engineering, Privacy, Security-Team, Wikimedia-General-or-Unknown
Tgr added a comment to T281397: Test trust tokens as a captcha alternative for Wikimedia.

I see we already have T250314: Investigate Privacy Pass for Wikimedia Sites, wasn't aware of that task.

Wed, Apr 28, 8:30 PM · Privacy Engineering, Accessibility, Privacy, ConfirmEdit (CAPTCHA extension)
Tgr added a comment to T281397: Test trust tokens as a captcha alternative for Wikimedia.

Running our own Privacy Pass server doesn't really help with the problem that we can't reliably determine which devices can be trusted; at best it would be a way to decouple captchas from MediaWiki (which is nice in theory but not really worth the effort) or to provide anonymous trust assesments to third parties about already-vetted Wikimedia users, ie. the opposite direction to what's proposed here.

Wed, Apr 28, 8:28 PM · Privacy Engineering, Accessibility, Privacy, ConfirmEdit (CAPTCHA extension)
Tgr added a comment to T281397: Test trust tokens as a captcha alternative for Wikimedia.

Rough guess of the work needed:

  • research the Trust Tokens specification, and plan out how it can be integrated with MediaWiki
  • maybe run some lightweight RfC or community discussion to see if there are strong objections to the idea
  • refactor ConfirmEdit so it’s possible to have a fallback chain of captchas
  • implement trust tokens as a ConfirmEdits captcha variant
  • maybe improve logging for captchas (we track crude success/failure rate, but we might want something more informative for the experiment)
  • enable on (some?) Wikimedia wikis for a short period of time, see if spambot problems get worse or if it's otherwise problematic
Wed, Apr 28, 6:18 PM · Privacy Engineering, Accessibility, Privacy, ConfirmEdit (CAPTCHA extension)
Tgr created T281397: Test trust tokens as a captcha alternative for Wikimedia.
Wed, Apr 28, 6:07 PM · Privacy Engineering, Accessibility, Privacy, ConfirmEdit (CAPTCHA extension)