Page MenuHomePhabricator

Tgr (Gergő Tisza)
Software Engineer, WMF

Projects (44)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 4:55 PM (376 w, 1 d)
Availability
Available
IRC Nick
tgr
LDAP User
Gergő Tisza
MediaWiki User
Tgr (WMF) [ Global Accounts ]

Things my team is working on: Growth-Team (kanban board)
Side projects I am working on (or planning to, eventually): User-Tgr
You can find more info about me on my user page.

Recent Activity

Today

Tgr added a comment to T296620: TypeError: $.cookie is not a function.

This doesn't look like it relates to reading depth to me (...) The error is not just on this page.

Sat, Dec 4, 7:20 AM · JavaScript, MediaWiki-Interface (active libraries), Wikimedia-production-error
Tgr updated the task description for T265703: Replace jquery.cookie with js-cookie in MediaWiki.
Sat, Dec 4, 6:58 AM · Patch-For-Review, JavaScript, MediaWiki-General

Yesterday

Tgr added a comment to T294230: M1 mentee overview: Add a link to all/reverted/question-asking contributions or block log.

Maybe we should flag it as a risky patch for the next train

Fri, Dec 3, 10:19 AM · Performance-Team (Radar), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, User-Urbanecm_WMF (Engineering), Growth-Team (Current Sprint), GrowthExperiments-MentorDashboard, GrowthExperiments-Mentorship
Tgr added a comment to T293953: 1.38.0-wmf.12 deployment blockers.
  1. Risky Patch! 🚂🔥
Fri, Dec 3, 10:18 AM · Release-Engineering-Team (Next), Release, Train Deployments
Tgr added a hashtag to Growth-Team (Current Sprint): #growth-team-current-sprint.
Fri, Dec 3, 10:08 AM
Tgr added a comment to T291232: Add an image: exclude certain articles .

Two arwiki infobox templates that seemingly should have been picked up (they have the "instance of: Wikimedia infobox" property on Wikidata, the template page is not new and has been linked to Wikidata a long time ago, and the property is not new either) but haven't: قالب:بطاقة كهف, قالب:بطاقة_جهاز_معلوماتي. Some kind of bug in the script?

Fri, Dec 3, 5:15 AM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Image-Suggestions, Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks, Growth-Structured-Tasks

Thu, Dec 2

Tgr updated subscribers of T123243: Ability to alert when we get a sudden increase in bad passwords for privileged accounts.

@sbassett any thoughts? This is a very old task, not sure how relevant it is to the Security team's current thinking.

Thu, Dec 2, 11:32 PM · Security-Team, observability, Security
Tgr added a comment to T296818: Edit erroneously tagged with add image.

The way we tag edits (based on the Tracker class, ie. essentially setting an "in progress" flag on the page when the user clicks on the task card, clearing it when the article is saved or after 7 days, and looking at that flag for adding change tags) is inherently fragile. For non-structured edits that's unavoidable - they are just normal edits, so we don't really have a better way of detecting them. For structured edits, we might want to fix that and rely on onVisualEditorApiVisualEditorEditPreSave (a fairly reliable indicator of whether something was a structured edit) instead.

Thu, Dec 2, 5:44 PM · Image-Suggestions, Growth-Team (Current Sprint)
Tgr created T296922: Add an image: parallelize requests.
Thu, Dec 2, 10:10 AM · Growth-Team, Image-Suggestions
Tgr moved T296781: Suggested edits: Task count in pager changes when closing filter without saving from Code Review to QA on the Growth-Team (Current Sprint) board.
Thu, Dec 2, 6:17 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), GrowthExperiments, Growth-Team (Current Sprint)
Tgr moved T296438: [arwiki] Add image - a question mark not in RTL format from Code Review to QA on the Growth-Team (Current Sprint) board.
Thu, Dec 2, 6:02 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), I18n, RTL, Growth-Team (Current Sprint), Image-Suggestions
Tgr added a comment to T294186: Global preferences opt-out checkboxes should inherit the hide-if setting of the preference.

I can reproduce on beta enwiki.

  • add both settings to global preferences (enabled)
  • check both exception buttons locally
  • uncheck "Display newcomer homepage"
  • re-check "Display newcomer homepage"
Thu, Dec 2, 2:52 AM · Community-Tech (CommTech-Sprint-15), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MediaWiki-extensions-GlobalPreferences
Tgr added a comment to T296618: Flow: "could not locate workflow" errors when viewing history.

Old task with same error that may be related: T112954

Thu, Dec 2, 2:12 AM · StructuredDiscussions, Growth-Team, Wikimedia-production-error

Wed, Dec 1

Tgr added a comment to T294230: M1 mentee overview: Add a link to all/reverted/question-asking contributions or block log.

Looking for multiple change tags doesn't seem to affect that significantly; it will result in multiple rows per revision if the revision has multiple relevant tags, but that seems like a comparatively minor performance effect.

Wed, Dec 1, 10:25 PM · Performance-Team (Radar), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, User-Urbanecm_WMF (Engineering), Growth-Team (Current Sprint), GrowthExperiments-MentorDashboard, GrowthExperiments-Mentorship
Tgr created P17959 (An Untitled Masterwork).
Wed, Dec 1, 10:21 PM
Tgr created P17958 (An Untitled Masterwork).
Wed, Dec 1, 10:20 PM
Tgr added a comment to T294230: M1 mentee overview: Add a link to all/reverted/question-asking contributions or block log.
  1. I notice the change mentions that the internal code was already multi-tag aware, but I suspect it was not yet exposed to the API or via a special page before, is is true that this thus exposes user-controlled multi-tag revision queries for the first time?
Wed, Dec 1, 10:19 PM · Performance-Team (Radar), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, User-Urbanecm_WMF (Engineering), Growth-Team (Current Sprint), GrowthExperiments-MentorDashboard, GrowthExperiments-Mentorship
Tgr updated subscribers of T296810: Find a better way to have placeholder messages in GrowthExperiments.

Translatewiki has a "Message group" navigation bar which mostly maps to message directories via these files. I think files are nice for us as well - easy to move content, easy to keep track of what did and did not get finalized, if we keep the current spreadsheet workflow then easy to create that.

Wed, Dec 1, 9:34 PM · translatewiki.net, I18n, Growth-Team, GrowthExperiments
Tgr added a comment to T296620: TypeError: $.cookie is not a function.

This is happening on Special:CreateAccount where on-wiki code is disabled (though browser extensions of course aren't). And only happening there - if something changed $ I'd expect way more / worse breakage.

Wed, Dec 1, 9:20 PM · JavaScript, MediaWiki-Interface (active libraries), Wikimedia-production-error
Tgr created P17916 (An Untitled Masterwork).
Wed, Dec 1, 7:37 AM
Tgr created P17915 (An Untitled Masterwork).
Wed, Dec 1, 7:36 AM
Tgr moved T296810: Find a better way to have placeholder messages in GrowthExperiments from Inbox to Upcoming Work on the Growth-Team board.
Wed, Dec 1, 6:53 AM · translatewiki.net, I18n, Growth-Team, GrowthExperiments
Tgr created T296810: Find a better way to have placeholder messages in GrowthExperiments.
Wed, Dec 1, 6:51 AM · translatewiki.net, I18n, Growth-Team, GrowthExperiments
Tgr added a comment to T296610: Special:Homepage throws "Maximum function nesting level of '200' reached, aborting!".

I think production has some perversely high nesting limit because of something that Parsoid does

Wed, Dec 1, 6:14 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, GrowthExperiments-NewcomerTasks, Performance-Team, MediaWiki-Cache, Growth-Team
Tgr added a comment to T296712: MWException: File '/srv/mediawiki/php-master/extensions//static/images/wikibase/echoIcon.svg' does not exist.

You are right, that was clearly meant to be a URL. (Which is the same as the production one so the beta config can just be discarded.)

Wed, Dec 1, 6:08 AM · wdwb-tech, Wikidata, Performance-Team (Radar), Growth-Team, Notifications, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient, Beta-Cluster-reproducible
Tgr added a comment to T123243: Ability to alert when we get a sudden increase in bad passwords for privileged accounts.

There's also a login throttle hit dashboard, though probably less useful as a careful attacker could spread out his attempts and avoid being throttled.

Wed, Dec 1, 6:04 AM · Security-Team, observability, Security
Tgr added a comment to T123243: Ability to alert when we get a sudden increase in bad passwords for privileged accounts.

(There's also goodpass / goodpass-priv if you want to make it a ratio instead of an absolute number.)

Wed, Dec 1, 6:03 AM · Security-Team, observability, Security
Tgr added a comment to T123243: Ability to alert when we get a sudden increase in bad passwords for privileged accounts.

Not that I know. The relevant searches are type:mediawiki AND channel:badpass (all failed login attempts) and type:mediawiki AND channel:badpass-priv (failed login attempts into admin and similar accounts).
(Except the first search will match both channel names, not sure what's the right syntax there.)

Wed, Dec 1, 6:00 AM · Security-Team, observability, Security
Tgr added a comment to T296620: TypeError: $.cookie is not a function.

...which does have the right dependency so I have no idea what's going on here.

Wed, Dec 1, 5:02 AM · JavaScript, MediaWiki-Interface (active libraries), Wikimedia-production-error
Tgr added a project to T296620: TypeError: $.cookie is not a function: Readers-Web-Backlog.
Wed, Dec 1, 4:59 AM · JavaScript, MediaWiki-Interface (active libraries), Wikimedia-production-error
Tgr edited projects for T296620: TypeError: $.cookie is not a function, added: Reading Depth; removed Growth-Team.
Wed, Dec 1, 4:59 AM · JavaScript, MediaWiki-Interface (active libraries), Wikimedia-production-error
Tgr added a comment to T296620: TypeError: $.cookie is not a function.

One of the log events has normal stack trace (I suppose that comes down to ResourceLoader localStorage cache vs. normal loading) which implicates https://en.wikipedia.org/w/load.php?lang=en&modules=ext.centralNotice.geoIP%7Cext.centralauth.centralautologin%7Cext.cx.eventlogging.campaigns%7Cext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cjquery%7Cjquery.client%2Ccookie%2CtextSelection%7Cjquery.uls.data%7Cmediawiki.String%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cstorage%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.editfont.styles%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.ui.button%7Cskins.vector.legacy.js%7Cuser.defaults&skin=vector&version=12p7l line 54 column 880.

mw.requestIdleCallback(function(){if(ignoredSkins.indexOf(skin)===-1){sessionId=user.sessionId();if(isInSample(localConfig.readingDepthSamplingRate))...

That's from readingDepth.js.

Wed, Dec 1, 4:58 AM · JavaScript, MediaWiki-Interface (active libraries), Wikimedia-production-error
Tgr added a comment to T296620: TypeError: $.cookie is not a function.

The stack trace is not too useful, all anonymous methods. It suggests something is using mw.user.sessionId() without the appropriate dependency.

Wed, Dec 1, 4:49 AM · JavaScript, MediaWiki-Interface (active libraries), Wikimedia-production-error
Tgr added a comment to T296620: TypeError: $.cookie is not a function.

Presumably a dependency issue, something not loading the jquery.cookie module. Happening about four times a day. It's happening on enwiki Special:CreateAccount; we don't run any code there, and in any case we don't use cookies. The modules parameter is ext.centralNotice.geoIP|ext.centralauth.centralautologin|ext.cx.eventlogging.campaigns|ext.eventLogging,navigationTiming,wikimediaEvents|ext.uls.common,compactlinks,interface,preferences,webfonts|jquery|jquery.client,cookie,textSelection|jquery.uls.data|mediawiki.String,Title,Uri,api,base,cldr,cookie,experiments,jqueryMsg,language,storage,user,util,visibleTimeout|mediawiki.editfont.styles|mediawiki.libs.pluralruleparser|mediawiki.page.ready|mediawiki.ui.button|skins.vector.legacy.js|user.defaults so it could be any number of things but CentralAuth looks the likeliest.

Wed, Dec 1, 4:46 AM · JavaScript, MediaWiki-Interface (active libraries), Wikimedia-production-error
Tgr moved T296661: Welcome Survey: move cron job to analytics-product system user from Inbox to Upcoming Work on the Growth-Team board.
Wed, Dec 1, 4:29 AM · Growth-Team, Product-Analytics
Tgr moved T296761: Update secondary link destination directly to the library from Inbox to Triaged on the Growth-Team board.
Wed, Dec 1, 4:28 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban), Notifications, Growth-Team
Tgr closed T296619: '.event.referer_route' should be equal to one of the allowed values as Declined.

link to log (generated links don't work properly, same issue as T292037)
The submitted value is apparently specialcontribution/create. We don't use that in the code (closest is here) so I'd guess this was someone manually messing with the URL. We could validate it better but IMO not worth the maintenance costs.

Wed, Dec 1, 3:30 AM · Growth-Team, Wikimedia-production-error
Tgr moved T296618: Flow: "could not locate workflow" errors when viewing history from Inbox to Triaged on the Growth-Team board.

This was probably just one error, which was emitted for several history entries when someone was looking at page history.

Wed, Dec 1, 3:16 AM · StructuredDiscussions, Growth-Team, Wikimedia-production-error
Tgr renamed T296618: Flow: "could not locate workflow" errors when viewing history from Flow\Exception\FlowException: could not locate workflow for revision piimt3m9q9o1p127 to Flow: "could not locate workflow" errors when viewing history.
Wed, Dec 1, 3:09 AM · StructuredDiscussions, Growth-Team, Wikimedia-production-error
Tgr moved T296608: Adding LanguageConverter language conversion CI tests for topic title in Extension:StructuredDiscussions from Inbox to Triaged on the Growth-Team board.
Wed, Dec 1, 3:06 AM · MediaWiki-Language-converter, StructuredDiscussions, Growth-Team
Tgr moved T296610: Special:Homepage throws "Maximum function nesting level of '200' reached, aborting!" from Inbox to Triaged on the Growth-Team board.
Wed, Dec 1, 3:05 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, GrowthExperiments-NewcomerTasks, Performance-Team, MediaWiki-Cache, Growth-Team
Tgr added a comment to T296712: MWException: File '/srv/mediawiki/php-master/extensions//static/images/wikibase/echoIcon.svg' does not exist.

Wikibase's own documentation also says path should be relative to the extensions directory. So the simplest fix is to just prefix the path with Wikibase.

Wed, Dec 1, 3:02 AM · wdwb-tech, Wikidata, Performance-Team (Radar), Growth-Team, Notifications, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient, Beta-Cluster-reproducible
Tgr moved T296712: MWException: File '/srv/mediawiki/php-master/extensions//static/images/wikibase/echoIcon.svg' does not exist from Inbox to Triaged on the Growth-Team board.
Wed, Dec 1, 3:02 AM · wdwb-tech, Wikidata, Performance-Team (Radar), Growth-Team, Notifications, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient, Beta-Cluster-reproducible
Tgr moved T296703: Add an image: onboarding dialog does not handle Esc key on Minerva from Inbox to Triaged on the Growth-Team board.
Wed, Dec 1, 2:54 AM · Image-Suggestions, Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, Growth-Team
Tgr moved T296700: [EPIC] "Add an image" Iteration 1: desktop from Inbox to Upcoming Work on the Growth-Team board.
Wed, Dec 1, 2:54 AM · Growth-Team, Growth-Structured-Tasks, Image-Suggestions
Tgr moved T296700: [EPIC] "Add an image" Iteration 1: desktop from To Do to Epics on the Image-Suggestions board.
Wed, Dec 1, 2:54 AM · Growth-Team, Growth-Structured-Tasks, Image-Suggestions
Tgr moved T296646: Migration of front-end modules to Vue.js components from Inbox to Upcoming Work on the Growth-Team board.
Wed, Dec 1, 2:53 AM · Growth-Team
Tgr moved T296775: Support motion preferences in GrowthExperiments from Inbox to Triaged on the Growth-Team board.
Wed, Dec 1, 2:52 AM · Accessibility, Growth-Team, GrowthExperiments
Tgr added a comment to T264343: Have a special page for mentors to sign up.

we wouldn't be able to enforce any access control settings (MediaWiki is not built with support for per-page edit restriction settings, and while we can try to prevent users not meeting mentor criteria to enroll, there will always be ways to bypass that; part of the reasons why community configuration only does basic validation is this)

Wed, Dec 1, 2:43 AM · Growth-Team-Filtering, GrowthExperiments-MentorDashboard, GrowthExperiments-Mentorship, Growth-Team, Growth-Scaling
Tgr added a comment to T294886: Add Image: Track API performance.

What's a reasonable upper bound for the API requests?

Wed, Dec 1, 2:13 AM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Growth-Team (Current Sprint), Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, Image-Suggestions
Tgr added a comment to T296255: Add an image: additional matches to filter.

Disambiguation page are currently filtered via Wikidata properties, which aren't all that reliable. It would be more ideal if they were filtered via Wikipedia page properties.

Wed, Dec 1, 2:07 AM · Growth-Structured-Tasks, Image-Suggestions, Growth-Team
Tgr added a comment to T296702: Scale: enable Growth features for 100% of new accounts on most Wikipedias.

A related issue is what to do with autocreated accounts, ie. accounts which have been created when a user who already had an account on one wiki visited another wiki. Very experienced users might have low-editcount accounts or recent registration dates on wikis they rarely visit. OTOH new users might visit multiple wikis and would then benefit from Growth features on all of them.

Wed, Dec 1, 2:06 AM · User-notice, Growth-Scaling, Growth-Team (Current Sprint)
Tgr created T296800: Allow searching by canonical namespace name in namespace dropdown.
Wed, Dec 1, 1:08 AM · Advanced-Search

Tue, Nov 30

Tgr created T296775: Support motion preferences in GrowthExperiments.
Tue, Nov 30, 7:50 PM · Accessibility, Growth-Team, GrowthExperiments
Tgr updated the task description for T291349: Full community configuration support for suggested edits.
Tue, Nov 30, 7:18 PM · Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks, Growth-Scaling
Tgr updated the task description for T291349: Full community configuration support for suggested edits.
Tue, Nov 30, 7:17 PM · Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks, Growth-Scaling
Tgr updated the task description for T291349: Full community configuration support for suggested edits.
Tue, Nov 30, 7:16 PM · Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks, Growth-Scaling
Tgr added a comment to T296610: Special:Homepage throws "Maximum function nesting level of '200' reached, aborting!".

@Tgr are you still seeing this? I don't see it on enwiki beta. T296508: ERROR @wdio/sync: Error: socket hang up looks similar.

Tue, Nov 30, 3:32 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, GrowthExperiments-NewcomerTasks, Performance-Team, MediaWiki-Cache, Growth-Team
Tgr updated subscribers of T296334: Evaluate usefulness of linkrecommendation printed logging on each request.

I think we should just do this, it's about moving one line of code. Maybe a good task for @mewoph or @Sgs if they are interested in how the local setup & deployment process for the link recommendation service works.

Tue, Nov 30, 3:26 AM · Add-Link, observability, Growth-Team
Tgr added a comment to T296333: Add an image: exclude non-images.

I think the easiest way to test it would be to use the SubpageImageRecommendationProvider with some random Ogg file of your choice.

Tue, Nov 30, 3:23 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
Tgr added a subtask for T296700: [EPIC] "Add an image" Iteration 1: desktop: T296703: Add an image: onboarding dialog does not handle Esc key on Minerva.
Tue, Nov 30, 2:59 AM · Growth-Team, Growth-Structured-Tasks, Image-Suggestions
Tgr added a parent task for T296703: Add an image: onboarding dialog does not handle Esc key on Minerva: T296700: [EPIC] "Add an image" Iteration 1: desktop.
Tue, Nov 30, 2:59 AM · Image-Suggestions, Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, Growth-Team
Tgr created T296703: Add an image: onboarding dialog does not handle Esc key on Minerva.
Tue, Nov 30, 2:58 AM · Image-Suggestions, Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, Growth-Team
Tgr added a comment to T291232: Add an image: exclude certain articles .

Do we want to do T279010: [Placeholder] Filter out page types of higher scrutiny on our side? With category filtering, it should be straightforward.

Tue, Nov 30, 2:32 AM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Image-Suggestions, Growth-Team (Current Sprint), GrowthExperiments-NewcomerTasks, Growth-Structured-Tasks
Tgr added a comment to T276137: Exclude unillustrated articles that should not have images.

For future iterations we should robably also filter out decades (Q39911). Or maybe the whole subtree under Q1790144 unit of time?

Tue, Nov 30, 2:30 AM · Image-Suggestion-API, Image-Suggestions, Platform Team Workboards (Image Suggestion API)
Tgr added a comment to T295910: Yellow talk page message banner appearing inconsistently on edit page.

On desktop it's set via SubmitAction (called on save or preview). On mobile you'll probably have to set it via an AJAX call. A very ugly hack would be to call the login API, or Special:UserLogin, which always starts a session. A better way would be to just create a new dedicated API endpoint that creates a session.

Tue, Nov 30, 1:21 AM · Editing-team, MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), MobileFrontend, MinervaNeue, Readers-Web-Backlog (Kanbanana-FY-2021-22)
Tgr added a comment to T267273: [arwiki] Submitting a POST on a form redirected to immediately after account creation sometimes logs user out.

Can we use homepage discovery? In theory, after seeing the welcome survey, you should either land on the homepage or go somewhere else and get a popup telling how to access the homepage; the first has associated analytics events; the second maybe has an associated analytics event and if nothing else there's an associated user preference change.

Tue, Nov 30, 1:11 AM · Patch-For-Review, Platform Engineering, Growth-Team (Current Sprint), GrowthExperiments, MediaWiki-extensions-CentralAuth
Tgr added a comment to T296603: Discourse login broken.

As long as it's in read-only mode it doesn't really matter, login wouldn't work either way. I only encountered this because I took the site out of read-only mode to fix T296602: Space (Discourse) theme broken but couldn't log in as an admin (later I found out that I'm not an admin at all :) and that admins have an emergency login method via /u/admin-login which would work around this).

Tue, Nov 30, 12:33 AM · User-Tgr, Space, Discourse
Tgr added a comment to T222626: Turn logout link into a POST API call with refresh.

Also, I doubt it would help, T25227: Use token when logging out would probably break SAML logouts with or without POST. And we do want to have some kind of CSRF protection for logouts. Especially while we publish IP addresses for anonymous actions, third-party-initiated stealth logout can be abused to dox users.

Tue, Nov 30, 12:29 AM · Security, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-Hackathon-2019, User-Ladsgroup, MediaWiki-Authentication-and-authorization

Mon, Nov 29

Tgr moved T296441: Add an image: Remove tasks with "no suggestion" errors from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
Mon, Nov 29, 9:01 PM · Patch-For-Review, Growth-Team (Current Sprint), Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, Image-Suggestions
Tgr edited projects for T296441: Add an image: Remove tasks with "no suggestion" errors, added: Growth-Team (Current Sprint); removed Growth-Team.
Mon, Nov 29, 9:01 PM · Patch-For-Review, Growth-Team (Current Sprint), Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, Image-Suggestions
Tgr created T296610: Special:Homepage throws "Maximum function nesting level of '200' reached, aborting!".
Mon, Nov 29, 6:42 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, GrowthExperiments-NewcomerTasks, Performance-Team, MediaWiki-Cache, Growth-Team
Tgr updated the task description for T296602: Space (Discourse) theme broken.
Mon, Nov 29, 2:42 AM · User-Tgr, Space, Discourse
Tgr added a project to T296603: Discourse login broken: User-Tgr.
Mon, Nov 29, 2:41 AM · User-Tgr, Space, Discourse
Tgr added a project to T296602: Space (Discourse) theme broken: User-Tgr.
Mon, Nov 29, 2:41 AM · User-Tgr, Space, Discourse
Tgr added a comment to T296603: Discourse login broken.

Upstream task is paviliondev/discourse-wikimedia-auth#4.

Mon, Nov 29, 2:37 AM · User-Tgr, Space, Discourse
Tgr added a comment to T296603: Discourse login broken.

The error refers to user_name_suggester.rb line 7, which takes one argument, but the documentation mentions a second and discourse-wikimedia-auth indeed uses two, so probably a recent change.

Mon, Nov 29, 2:28 AM · User-Tgr, Space, Discourse
Tgr created T296603: Discourse login broken.
Mon, Nov 29, 2:22 AM · User-Tgr, Space, Discourse
Tgr created T296602: Space (Discourse) theme broken.
Mon, Nov 29, 2:22 AM · User-Tgr, Space, Discourse

Sun, Nov 28

Tgr updated the task description for T218277: Build statistics toolset to support WM-HU editor retention grant.
Sun, Nov 28, 9:27 PM · Technical-Tool-Request, Outreach-Programs-Projects, User-Tgr
Tgr updated the task description for T218277: Build statistics toolset to support WM-HU editor retention grant.
Sun, Nov 28, 8:59 PM · Technical-Tool-Request, Outreach-Programs-Projects, User-Tgr
Tgr closed T294529: CVE-2021-41163 and discourse-mediawiki.wmflabs.org as Resolved.

Updated both sites to current version (2.8.0.beta8).

Sun, Nov 28, 11:35 AM · SecTeam-Processed, Discourse, VPS-Projects, Security
Tgr added a comment to T244831: Discourse: Your Wikimedia email is associated with an existing account..

Upstream task is paviliondev/discourse-wikimedia-auth#3.

Sun, Nov 28, 11:00 AM · Discourse
Tgr added a comment to T244831: Discourse: Your Wikimedia email is associated with an existing account..

This is a bug in discourse-wikimedia-auth (2b6910f8) where the email address is checked for uniqueness, but the query isn't filtered to the mediawiki provider, so users who have a user_associated_accounts entry from a different authentication provider with the same email address get locked out.

Sun, Nov 28, 10:55 AM · Discourse

Fri, Nov 26

Tgr moved T286192: Error on Special:Notifications page when a page on my watchlist got deleted by another user: EchoEventPresentationModel::getTruncatedTitleText() must be an instance of Title, null given from Incoming to QA on the Growth-Team (Current Sprint) board.
Fri, Nov 26, 9:54 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Notifications
Tgr edited projects for T286192: Error on Special:Notifications page when a page on my watchlist got deleted by another user: EchoEventPresentationModel::getTruncatedTitleText() must be an instance of Title, null given, added: Growth-Team (Current Sprint); removed Growth-Team.
Fri, Nov 26, 9:54 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Notifications
Tgr updated the task description for T286192: Error on Special:Notifications page when a page on my watchlist got deleted by another user: EchoEventPresentationModel::getTruncatedTitleText() must be an instance of Title, null given.
Fri, Nov 26, 9:53 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Notifications
Tgr moved T296376: Investigate rendering speed variations starting around 10 November from Code Review to In Progress on the Growth-Team (Current Sprint) board.

Moving back to In Progress for the actual investigation (once some data has been collected).

Fri, Nov 26, 6:53 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Performance Issue, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Tgr moved T296491: Add an image: Investigate removing tasks from a user's queue after they have rejected them from Code Review to QA on the Growth-Team (Current Sprint) board.
Fri, Nov 26, 6:51 AM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Growth-Team (Current Sprint), Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, Image-Suggestions
Tgr moved T294518: Add Image: Allow disabling feature via community configuration from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Fri, Nov 26, 1:30 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, Growth-Team (Current Sprint), Image-Suggestions, Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, GrowthExperiments-CommunityConfiguration
Tgr added a comment to T294518: Add Image: Allow disabling feature via community configuration.

With the patches:

  • any task type can be disabled by wiki admins

communityconfig-tasktype-disable.png (84×267 px, 8 KB)

  • if a task type has been disabled via central (PHP) configuration, it won't show up on the special page
  • if link recommendations are partially disabled ($wgGELinkRecommendationsFrontendEnabled), a notice is shown

communityconfig-tasktype-disabled.png (91×262 px, 10 KB)

Fri, Nov 26, 1:30 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, Growth-Team (Current Sprint), Image-Suggestions, Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, GrowthExperiments-CommunityConfiguration

Thu, Nov 25

Tgr added a comment to T222626: Turn logout link into a POST API call with refresh.

If the issue is SAML specific, the extension should just provide an endpoint to call for logout.

Thu, Nov 25, 7:44 PM · Security, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-Hackathon-2019, User-Ladsgroup, MediaWiki-Authentication-and-authorization
Tgr added a comment to T296427: Add an image: use highest ranking valid image.

In any case, this is well outside the scope of this task. Moved to T296498: Add an image: Prefer images which match PageImages / PageContentServices criteria.

Thu, Nov 25, 7:13 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
Tgr moved T296498: Add an image: Prefer images which match PageImages / PageContentServices criteria from Inbox to Triaged on the Growth-Team board.
Thu, Nov 25, 7:13 PM · GrowthExperiments-NewcomerTasks, Growth-Structured-Tasks, Image-Suggestions, Growth-Team
Tgr created T296498: Add an image: Prefer images which match PageImages / PageContentServices criteria.
Thu, Nov 25, 7:13 PM · GrowthExperiments-NewcomerTasks, Growth-Structured-Tasks, Image-Suggestions, Growth-Team
Tgr added a comment to T296427: Add an image: use highest ranking valid image.

Are the IP/PCS criteria and our criteria aligned since these projects seem more general purpose? We were thinking that maybe it wouldn't be welcoming to show "explicit content" to newcomers. Not sure if this criteria makes sense in their context.

Thu, Nov 25, 7:08 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
Tgr updated subscribers of T296491: Add an image: Investigate removing tasks from a user's queue after they have rejected them.

Copying relevant comments from another task:

Thu, Nov 25, 6:49 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Growth-Team (Current Sprint), Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, Image-Suggestions
Tgr added a comment to T279025: Add a link: maintain task feed and position on reload/back button.

CirrusSearch supports pseudorandom sort now (although AIUI it's not guaranteed to be stable for long, just a day or so) which would be an easy way forward.

Thu, Nov 25, 6:46 PM · Growth-Team-Filtering, Add-Link, Growth-Structured-Tasks, Growth-Team
Tgr added a comment to T290315: Add Link: Ensure user does not see invalid tasks in task queue.

We now have a specific task for per-user queue removal: T296491: Add an image: Investigate removing tasks from a user's queue after they have rejected them

Thu, Nov 25, 6:44 PM · QTE-TestingOverview, MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Add-Link, Growth-Team (Current Sprint), GrowthExperiments
Tgr added a subtask for T293711: [EPIC] "Add an image" future iterations: T296491: Add an image: Investigate removing tasks from a user's queue after they have rejected them.
Thu, Nov 25, 4:58 PM · Growth-Structured-Tasks, Image-Suggestions, Growth-Team