Tgr (Gergő Tisza)
Software Engineer, WMF Reading

Projects (26)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 4:55 PM (135 w, 5 d)
Availability
Available
IRC Nick
tgr
LDAP User
Gergő Tisza
MediaWiki User
Tgr (WMF)

Recent Activity

Yesterday

Tgr added a comment to T163847: mobile web media viewer shows icons.

The mobile media viewer should blacklist images in/with noviwer/metadata classes like the desktop one does.

Wed, Apr 26, 10:55 PM · MobileFrontend, Reading-Web-Local-Wiki-Issues, Reading-Web-Backlog
Tgr added a comment to T163114: Regression: Fix config to disable related pages where it's not wanted.

Looks like we may have a lead :) T126306

Wed, Apr 26, 6:03 PM · Reading-Web-Sprint-96, Wikimedia-Site-requests, Regression, Reading-Web-Backlog

Tue, Apr 25

mmodell awarded T126306: Scap should touch symlinks when originals are touched a Baby Tequila token.
Tue, Apr 25, 8:19 PM · Scap (Scap3-MediaWiki-MVP), scap2
Tgr created User-Tgr.
Tue, Apr 25, 7:44 PM
Tgr added a comment to T163622: Unblock stuck global rename of Nouminouna to Bnhassin.

Probably some error prevented the process of user creation for Bnhassin, so the user table did get created but the central user database did not get updated.

Tue, Apr 25, 2:58 PM · GlobalRename, MediaWiki-extensions-CentralAuth, Wikimedia-Site-requests
Tgr added a comment to T163622: Unblock stuck global rename of Nouminouna to Bnhassin.

Probably some error prevented the process of user creation for Bnhassin, so the user table did get created but the central user database did not get updated. So the rename was allowed but broke when it reached enwiki since the account already existed there.

Tue, Apr 25, 2:55 PM · GlobalRename, MediaWiki-extensions-CentralAuth, Wikimedia-Site-requests
Tgr added a comment to T158909: Spambot detection.

Why would it be invasive? We already collect and correlate browser details and edit actions, and timing/velocity of typing and mouse movements on the registration page is not even PII.

Tue, Apr 25, 1:49 PM · artificial-intelligence

Mon, Apr 24

Tgr added a comment to T163622: Unblock stuck global rename of Nouminouna to Bnhassin.

There are two separate user accounts on enwiki (both 0 edits, one created in 2013, the other in 2014). The rename should never have started in the first place.

Mon, Apr 24, 9:50 PM · GlobalRename, MediaWiki-extensions-CentralAuth, Wikimedia-Site-requests
Tgr renamed T163622: Unblock stuck global rename of Nouminouna to Bnhassin from "Please unblock stuck global rename" to "Unblock stuck global rename of Nouminouna to Bnhassin".
Mon, Apr 24, 9:32 PM · GlobalRename, MediaWiki-extensions-CentralAuth, Wikimedia-Site-requests
Tgr added a comment to T163622: Unblock stuck global rename of Nouminouna to Bnhassin.

Both users exist on enwiki. That's not supposed to happen and not fixable by maintenance script.

Mon, Apr 24, 8:00 PM · GlobalRename, MediaWiki-extensions-CentralAuth, Wikimedia-Site-requests
Tgr added a comment to T163622: Unblock stuck global rename of Nouminouna to Bnhassin.

--ignorestatus means run the script even if the rename status is in progess (which normally means the rename is still ongoing and should not be messed with, but sometimes the rename fails so badly that it can't even update the status to failed). So not applicable here.

Mon, Apr 24, 7:46 PM · GlobalRename, MediaWiki-extensions-CentralAuth, Wikimedia-Site-requests
Tgr added a comment to T159753: Concerns about ores_classification table size on enwiki.

(the gerritbot issue is T161525)

Mon, Apr 24, 6:57 PM · MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Revision-Scoring-As-A-Service, Patch-For-Review, Performance, MediaWiki-extensions-ORES
Tgr added a comment to T163535: Upload verification-error possibly triggered by EXIF.

According to Netrenderer IE 5-6 is broken but IE7 works fine with Wikipedia.

Mon, Apr 24, 6:16 PM · Multimedia, MediaWiki-Uploading, Commons
Tgr closed T127830: Gerritbot didn't notify about patch in task. as "Invalid".

Not actionable as it is and no proposals in (almost) a year, let's close this.

Mon, Apr 24, 2:08 PM · GerritBot
Tgr added a comment to T161525: gerritbot doesn't add comment/patch-for-review when User:Ladsgroup creates patch in Gerrit.

Or maybe $author-username is problematic? There is no guarantee the author email can be resolved to a gerrit username.

Mon, Apr 24, 2:06 PM · Patch-For-Review, GerritBot
Tgr added a comment to T161525: gerritbot doesn't add comment/patch-for-review when User:Ladsgroup creates patch in Gerrit.

My guess is this has been broken by https://gerrit.wikimedia.org/r/#/c/340801/ - the timing matches roughly, and that's the last username-related change. Maybe something does not like spaces in the username.

Mon, Apr 24, 2:05 PM · Patch-For-Review, GerritBot
Tgr edited the description of T163687: Re-enable ORES data in action API.
Mon, Apr 24, 1:11 PM · Revision-Scoring-As-A-Service-Backlog, Operations, ORES
Tgr added a parent task for T163687: Re-enable ORES data in action API: T153688: Announce presence of "oresscores" in api.php.
Mon, Apr 24, 1:07 PM · Revision-Scoring-As-A-Service-Backlog, Operations, ORES
Tgr added a subtask for T153688: Announce presence of "oresscores" in api.php: T163687: Re-enable ORES data in action API.
Mon, Apr 24, 1:07 PM · Revision-Scoring-As-A-Service-Backlog, ORES
Tgr created T163687: Re-enable ORES data in action API.
Mon, Apr 24, 1:07 PM · Revision-Scoring-As-A-Service-Backlog, Operations, ORES
Tgr created P5319 DESCRIBE for Id35bca820822dc46caa5adf6450c81871465abc9.
Mon, Apr 24, 12:44 PM
Tgr added a comment to T163611: Temporary Tool Labs projectadmin right for Tgr.

Thanks! I did not get to use it in the end (the event ended up being mostly discussion and not much actual development) but it was nice to know we have that option.

Mon, Apr 24, 8:28 AM · User-bd808, Tool-Labs, Labs
Tgr added a comment to T118231: Proposal: any WMF software project willing to be prioritized requires a concept publicly available.

It would be also nice if any software project willing to be prioritized required a public implementation plan (ie. don't circumvent the RfC process for WMF software). I think lately we are getting better at that but it would still nice if it was called out explicitly.

Mon, Apr 24, 7:55 AM · Community-Liaisons (Jul-Sep 2017), Technical-Collaboration-Guidance, Liaisons-March-2016, Liaisons-February-2016, WMF-Product-Development-Process

Sun, Apr 23

Tgr added a project to T160529: Sender email spoofing: Security.

This seems like a pretty dangerous spear phishing vector when used by a skilled attacker.

Sun, Apr 23, 4:54 PM · Security, Operations, Mail, Wikimedia-Mailing-lists

Sat, Apr 22

Tgr added a comment to T163575: could not load image from.

I could reproduce this for a short time (minutes) after the bug report was made, but then not anymore. Might be coincidence, or else there was something wrong with the image thumbnails and then somebody purged them.

Sat, Apr 22, 9:46 PM · MediaWiki-extensions-MultimediaViewer
Luke081515 awarded T163611: Temporary Tool Labs projectadmin right for Tgr a Like token.
Sat, Apr 22, 12:00 PM · User-bd808, Tool-Labs, Labs

Fri, Apr 21

Zppix awarded T163611: Temporary Tool Labs projectadmin right for Tgr a Like token.
Fri, Apr 21, 10:24 PM · User-bd808, Tool-Labs, Labs
Tgr created T163611: Temporary Tool Labs projectadmin right for Tgr.
Fri, Apr 21, 10:23 PM · User-bd808, Tool-Labs, Labs
Tgr added a comment to T142134: Failing test BounceHandler/UnSubscribeUserTest::testUnSubscribeUser due to WANObjectCache::delete.

I don't remember the details, beyond that User::save did not seem to clear the cache: loading the same user again resulted in the old data. Maybe it was some sort of in-process caching, or consistent reads resulting in pre-update DB data - I can't recall if I looked at those possibilities.

Fri, Apr 21, 3:42 PM · Performance-Team, MediaWiki-Cache, MediaWiki-extensions-BounceHandler

Thu, Apr 20

Tgr committed rELGNf431bc71964b: Switch TestingAccessWrapper to librarized version (authored by Tgr).
Switch TestingAccessWrapper to librarized version
Thu, Apr 20, 7:17 PM
Tgr committed rELGN1af82f293c38: Switch TestingAccessWrapper to librarized version (authored by Tgr).
Switch TestingAccessWrapper to librarized version
Thu, Apr 20, 7:16 PM
Tgr closed T161452: Fix i18n documentation as "Resolved".

Looks like this was fixed at some point.

Thu, Apr 20, 1:11 PM · Revision-Scoring-As-A-Service, Edit-Review-Improvements, Collaboration-Team-Triage
Tgr added a comment to T163434: Librarize TestingAccessWrapper.

Jenkins seems to have tied itself into a knot over the switch from \TestingAccessWrapper to \Wikimedia\TestingAccessWrapper:

  • extension tests ignore the extension's composer.json and just use core/vendor (see mw-fetch-composer-dev.sh)
  • core patches run a couple extension tests as well, which fail
  • DonationInterface tests run with 1.27 core. (The tests pass, I have no idea why.)
Thu, Apr 20, 11:54 AM · MW-1.28-release-notes, MW-1.27-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Librarization
Tgr committed rEEMAb2c89d9aca4f: Switch TestingAccessWrapper to librarized version (authored by Tgr).
Switch TestingAccessWrapper to librarized version
Thu, Apr 20, 11:36 AM
Tgr committed rECKT11110f8c470e: Switch TestingAccessWrapper to librarized version (authored by Tgr).
Switch TestingAccessWrapper to librarized version
Thu, Apr 20, 11:36 AM
Tgr committed rESCCe5aad53946af: Switch TestingAccessWrapper to librarized version (authored by Tgr).
Switch TestingAccessWrapper to librarized version
Thu, Apr 20, 11:35 AM
Tgr created T163434: Librarize TestingAccessWrapper.
Thu, Apr 20, 11:31 AM · MW-1.28-release-notes, MW-1.27-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Librarization
Tgr committed rEEMAc858e6415dd1: Switch TestingAccessWrapper to librarized version (authored by Tgr).
Switch TestingAccessWrapper to librarized version
Thu, Apr 20, 11:26 AM
Tgr committed rECKT2aeca3bc1ab6: Switch TestingAccessWrapper to librarized version (authored by Tgr).
Switch TestingAccessWrapper to librarized version
Thu, Apr 20, 11:26 AM
Tgr committed rESCCde54f5de1fba: Switch TestingAccessWrapper to librarized version (authored by Tgr).
Switch TestingAccessWrapper to librarized version
Thu, Apr 20, 11:25 AM
Tgr committed rEEMA31b23bb504d2: Switch TestingAccessWrapper to librarized version (authored by Tgr).
Switch TestingAccessWrapper to librarized version
Thu, Apr 20, 9:46 AM
Tgr committed rELGNc0f279623556: Switch TestingAccessWrapper to librarized version (authored by Tgr).
Switch TestingAccessWrapper to librarized version
Thu, Apr 20, 7:09 AM
Tgr committed rESCCd6dc7f6db2aa: Switch TestingAccessWrapper to librarized version (authored by Tgr).
Switch TestingAccessWrapper to librarized version
Thu, Apr 20, 7:08 AM

Wed, Apr 19

Tgr committed rEEMA381c3ceb083d: Switch TestingAccessWrapper to librarized version (authored by Tgr).
Switch TestingAccessWrapper to librarized version
Wed, Apr 19, 10:18 PM
Tgr committed rESCC1d2c41e904ef: Switch TestingAccessWrapper to librarized version (authored by Tgr).
Switch TestingAccessWrapper to librarized version
Wed, Apr 19, 9:53 PM
Tgr committed rECKT20756885f06e: Switch TestingAccessWrapper to librarized version (authored by Tgr).
Switch TestingAccessWrapper to librarized version
Wed, Apr 19, 9:51 PM
Tgr committed rELGN6c439ab29180: Switch TestingAccessWrapper to librarized version (authored by Tgr).
Switch TestingAccessWrapper to librarized version
Wed, Apr 19, 9:49 PM
Tgr added a comment to T163272: [Spike] Determine changes necessary for concatenation support .

The main technical question IMO is what tool to use for HTML transformations: some npm library (that would mean putting the logic in the Electron service which seems less nice than making Collection self-contained), or simple text processing (that will end badly unless we are sure only very simple transformations will be needed), or DOM manipulation in PHP (that will create a dependency on RemexHtml as I don't think there is anything else out there able to deal with HTML5).

Wed, Apr 19, 7:57 PM · Reading-Infrastructure-Team-Backlog, Reading-Infrastructure-Team, Reading-Web-Backlog
Tgr added a comment to T163272: [Spike] Determine changes necessary for concatenation support .

One thing to consider for the future is that with TemplateStyles editors will be able to add print-specific styles for their templates. (It's already possible via MediaWiki:*.css but impractical.) It would probably be useful to have some kind of tutorial/guidelines/best practices document for that.

Wed, Apr 19, 5:55 PM · Reading-Infrastructure-Team-Backlog, Reading-Infrastructure-Team, Reading-Web-Backlog
Tgr added a comment to T163272: [Spike] Determine changes necessary for concatenation support .

FWIW the OCG HTML transformation logic is in the Visitor class and it does not seem to do anything interesting, beyond filtering out various things.

Wed, Apr 19, 5:00 PM · Reading-Infrastructure-Team-Backlog, Reading-Infrastructure-Team, Reading-Web-Backlog
Tgr committed rTAWRe18b87c86739: Initial commit (authored by Tgr).
Initial commit
Wed, Apr 19, 4:43 PM
Tgr committed rTAWR931735f90dab: Initial commit (authored by Tgr).
Initial commit
Wed, Apr 19, 4:39 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rTAWR555db6cb5ca2: Modified project settings (authored by Tgr).
Modified project settings
Wed, Apr 19, 4:31 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rTAWR761758bffd2c: Inherit ownership from 'mediawiki' (authored by Tgr).
Inherit ownership from 'mediawiki'
Wed, Apr 19, 3:37 PM
Tgr added a comment to T161346: MMV lacks support for HiDPI displays.

Wikimedia_beetle.png and Wikimedia_beetle.svg are different images. One of them is probably being preloaded.

Wed, Apr 19, 2:36 PM · MediaWiki-extensions-MultimediaViewer

Tue, Apr 18

Tgr created T163242: git-review fails with "The requested URL /changes/ was not found on this server.".
Tue, Apr 18, 7:13 PM · MediaWiki-Vagrant
Tgr added a comment to T121995: Switch FlaggedRevs on Hungarian Wikipedia to a "flagged protection" mode.

The first, I think? I'm not sure I understand the difference.

Tue, Apr 18, 6:32 PM · Patch-For-Review, Wikimedia-Site-requests, MediaWiki-extensions-FlaggedRevs
Tgr added a comment to T161346: MMV lacks support for HiDPI displays.

MMV does not realize SVGs can be scaled beyond their nominal size (that's T71237; it's labeled easy but might not be). Doesn't explain the blur though; that's some problem with the placeholder image (which is intentionally blurry but should go away as soon as the large image is loaded) that might or might not be HiDPI-related.

Tue, Apr 18, 5:57 PM · MediaWiki-extensions-MultimediaViewer
Tgr committed rTAWRce47b689fd66: Initial commit (authored by Tgr).
Initial commit
Tue, Apr 18, 5:23 PM
Tgr committed rTAWRe259f5a26887: Initial commit (authored by Tgr).
Initial commit
Tue, Apr 18, 5:23 PM

Mon, Apr 17

Tgr added a comment to T163116: Decide on persistance location for Push Notification Service.

Using s7 would be convenient because it has global user/watchlist data so it would be possible to do a join between watchlists and push subscription lists, which seems like the most performant way to handle watchlist push notifications. (The same thing could be achieved by setting up another replication stream for watchlist, but why do it twice?)

Mon, Apr 17, 9:19 PM · User-mobrovac, Services (designing), Push Notification Service (Project Setup), Reading Epics (Push Notifications)
Tgr added a comment to T163069: Technical documentation.

WikimediaMessages is a (somewhat hacky) way to keep the code clean of Wikimedia-specific references: define messages with a generic text and use the WikimediaMessages extension to replace it. Since it is not useful outside Wikimedia, not much effort went into documenting it.

Mon, Apr 17, 5:27 PM · Documentation, Collaboration-Team-Triage, Edit-Review-Improvements
Tgr added projects to T163096: Update Auth_remoteuser documentation with AuthManager information: MediaWiki-extensions-General-or-Unknown, MediaWiki-Authentication-and-authorization.
Mon, Apr 17, 9:54 AM · MediaWiki-extensions-Auth_remoteuser, Documentation, MediaWiki-Authentication-and-authorization
Tgr added a comment to T161448: ORES extension should fail gracefully when ORES service is unavailable.

Walking back from the throw clause in ORES\Api::request, this seems to happen when you are looking at a change list special page (trigger ChangesListSpecialPageStructuredFilters), ORES is enabled and the cache for ORES\Stats::fetchStats is cold.

Mon, Apr 17, 9:48 AM · Revision-Scoring-As-A-Service-Backlog, MediaWiki-extensions-ORES

Thu, Apr 13

Tgr added a comment to T161448: ORES extension should fail gracefully when ORES service is unavailable.

Just point $wgOresBaseUrl to something that does not exist (while looking at a recentchanges row that has not been cached in the local DB yet).

Thu, Apr 13, 3:27 PM · Revision-Scoring-As-A-Service-Backlog, MediaWiki-extensions-ORES

Wed, Apr 12

Tgr added a comment to T162201: Cleanup artifacts of related pages desktop beta feature.

@Tgr any ideas on how to cleanup user preferences after disabling a beta feature?

Wed, Apr 12, 9:03 PM · Unplanned-Sprint-Work, Reading-Web-Sprint-95, Patch-For-Review, RelatedArticles, Reading-Web-Backlog, Wikimedia-Site-requests
Tgr added a comment to T44138: VisualEditor: Toolbar "Save page" button is confusing as it merely opens the dialog to save the page.

On desktop it's very widely used. See e.g. Microsoft and Apple button design guidelines.

Wed, Apr 12, 2:22 PM · VisualEditor, VisualEditor-MediaWiki
Tgr added a comment to T156184: Make rawHTML mode not apply to system messages.

With the benefit of hindsight: this change should have included some logging so it is easy to spot when a given wiki is affected.

Wed, Apr 12, 7:51 AM · MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), MW-1.27-release-notes, MW-1.28-release-notes, MW-1.23-release, Patch-For-Review, MW-1.29-release-notes, MediaWiki-Interface, Security
Tgr added a comment to T156184: Make rawHTML mode not apply to system messages.

Broke zerowiki as well, see T162771.

Wed, Apr 12, 7:43 AM · MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), MW-1.27-release-notes, MW-1.28-release-notes, MW-1.23-release, Patch-For-Review, MW-1.29-release-notes, MediaWiki-Interface, Security

Tue, Apr 11

Tgr committed rTAWR490cd6182c13: Initial commit (authored by Tgr).
Initial commit
Tue, Apr 11, 3:20 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rTAWR08a453c4ed17: Modified project settings (authored by Tgr).
Modified project settings
Tue, Apr 11, 3:15 PM
Tgr added a comment to T44138: VisualEditor: Toolbar "Save page" button is confusing as it merely opens the dialog to save the page.

Do we know if there's an equivalent for the ellipsis for every language we support?

Tue, Apr 11, 3:06 PM · VisualEditor, VisualEditor-MediaWiki
Tgr added a comment to T162484: DRAFT: Use rate limiting for ORES Action API score retrieval.

Is it possible to do the following?

  1. Allow scores to be returned in Action API responses provided there are corresponding records in the recent changes corresponding to the revisions. Rely on existing limits for number of revisions.
  2. When revisions exist but they're not in the recent changes table, don't allow more than X unavailable revision scores to be fetched at a time. Use API continuation in batches of only X revisions at a time for some small X, but don't store them upon fetch; instead, delegate the decision on whether to store or somehow cache in the ORES backend to the ORES backend.
Tue, Apr 11, 1:03 PM · Revision-Scoring-As-A-Service-Backlog

Mon, Apr 10

Tgr added a comment to T145541: Make Hovercards work with Special:MyLanguage links.

Note that special page names can be localized, so that e.g. on the Persian Wikipedia the link might look like ویژه:زبان‌های_من/Beta_Features/Hovercards.

Mon, Apr 10, 5:28 PM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), MediaWiki-API, Reading-Web-Backlog, MediaWiki-extensions-Translate, Page-Previews

Thu, Apr 6

mmodell awarded T109140: Special:UserLogin?returnto=interwiki:foo will redirect to external sites a Love token.
Thu, Apr 6, 11:01 PM · Patch-For-Review, Security, Privacy, MediaWiki-User-login-and-signup
Gerrit Code Review <gerrit@wikimedia.org> committed rCSSSda946bb7d24d: Modified project settings (authored by Tgr).
Modified project settings
Thu, Apr 6, 8:05 PM
Tgr added a comment to T162333: Image won't load.

There have been a lot of similar reports lately (T162130, T161917, T160867) so something is probably up. At a glance, the only common factor that jumps our is that they all seem to be from HiDPI devices, based on the thumbnail dimensions.

Thu, Apr 6, 7:34 PM · MediaWiki-extensions-MultimediaViewer
Tgr added a comment to T162379: Decide which CSS properties to support.

IMO wiki code is typical enough that anyone else using css-sanitizer to purify user-generated CSS could make good use of the capability, so it makes more sense to do it there.

Thu, Apr 6, 7:25 PM · MediaWiki-Platform-Team, css-sanitizer, TemplateStyles
Tgr added a comment to T162379: Decide which CSS properties to support.

A list of sanitization errors for MediaWiki:*.css pages on Wikimedia projects:

.
Unsupported properties in the first 50 errors:

-moz-box-shadow, -webkit-box-shadow
-moz-linear-gradient, -webkit-gradient, -webkit-linear-gradient, -ms-linear-gradient, -o-linear-gradient, 
-moz-border-radius, -moz-border-radius-*, -webkit-border-radius, -webkit-border-*-radius
zoom (used for IE CSS hacks)
-webkit-background-size, -khtml-background-size, -moz-background-size, -o-background-size
-ms-filter, filter
-o-user-select
-webkit-min-device-pixel-ratio
-moz-column-count, -webkit-column-count
-webkit-column-gap, -moz-column-gap, -ms-column-gap
-moz-column-width, -webkit-column-width, -ms-column-width
-webkit-column-break-inside
-moz-font-feature-settings, -webkit-font-feature-settings
cursor: hand
-moz-box-shadow, -webkit-box-shadow
-webkit-transition, -moz-transition, -o-transition, -ms-transition
-webkit-text-decoration, -moz-text-decoration
-webkit-background-size
-webkit-print-color-adjust
<property>: <value>\9;, <property>: <value> !ie;, *<value> (these seem to be old IE CSS hacks)
list-style-type: -moz-kannada
will-change
pointer-events
-webkit-background-clip, -moz-background-clip
::-moz-placeholder, ::-webkit-input-placeholder, ::-ms-input-placeholder
-moz-box-sizing, -webkit-box-sizing
:-moz-first-node
Thu, Apr 6, 5:03 PM · MediaWiki-Platform-Team, css-sanitizer, TemplateStyles
Tgr created T162379: Decide which CSS properties to support.
Thu, Apr 6, 4:59 PM · MediaWiki-Platform-Team, css-sanitizer, TemplateStyles
Tgr added a watcher for TemplateStyles: Tgr.
Thu, Apr 6, 4:59 PM
Tgr changed the visibility for F7309850: test-zend.tgz.
Thu, Apr 6, 2:48 PM

Wed, Apr 5

Tgr committed rCSSS8ce3e33ebe28: [TEST] Run tests from SimonSapin/css-parsing-tests (authored by Tgr).
[TEST] Run tests from SimonSapin/css-parsing-tests
Wed, Apr 5, 7:53 PM
Tgr committed rCSSS29b6f8a1df5e: Standards-based CSS sanitizer (authored by Anomie).
Standards-based CSS sanitizer
Wed, Apr 5, 8:43 AM
Tgr committed rCSSS2156c1ee331e: Standards-based CSS grammar matcher (authored by Anomie).
Standards-based CSS grammar matcher
Wed, Apr 5, 8:43 AM

Tue, Apr 4

Tgr added a comment to T162129: Someone is parsing all enwiki pages using the action api at a rate of ~2M pages/hour.

I don't think it is malign, just parallelizing queries to load balancing source IPs (always the same ones).

Tue, Apr 4, 8:56 PM · Operations, DBA, MediaWiki-API, Traffic
Tgr added a comment to T162129: Someone is parsing all enwiki pages using the action api at a rate of ~2M pages/hour.

Seems to have restarted (at least based on raw GET volume, haven't looked at what type it is). See P5199#27747 for the ranges if someone wants to set up an IP block.

Tue, Apr 4, 7:54 PM · Operations, DBA, MediaWiki-API, Traffic
Tgr added a comment to T162129: Someone is parsing all enwiki pages using the action api at a rate of ~2M pages/hour.

Did the IPs change periodically or did they actually use 50 boxes to query the API in parallel? The second case sounds like a proper DDoS scenario; not sure we would have an easy way of protecting against that. If it's from a single IP at a time, some sort of per-IP connection limit would suffice.

Tue, Apr 4, 7:33 PM · Operations, DBA, MediaWiki-API, Traffic
Tgr added a comment to T162129: Someone is parsing all enwiki pages using the action api at a rate of ~2M pages/hour.

User agent was "-" (without quotes).

Tue, Apr 4, 7:29 PM · Operations, DBA, MediaWiki-API, Traffic
Tgr added a comment to T162181: Should we add psy/psysh to wmf vendor repo for use on WMF servers?.

It would be great to have it on the server, yes. psysh has all kinds of cool stuff (tab autocompletion, nice dumping, inspection, phpdoc extraction, recovering from fatals...). Not sure about the security impact, but it's only used from shell so intentionally malicious code is the only threat model I can think of, and all of the dependencies are reputable (Symfony, nikic, Jakub Onderka) or trivial (dnoegel/php-xdg-base-dir).

Tue, Apr 4, 7:25 PM · Wikimedia-General-or-Unknown, MediaWiki-Vendor
Tgr added a comment to T154182: [suggestion] NWE should allow shortcuts like Alt+Shift+P for preview etc..

A possible cause is that the preview shortcut does not work until you make some changes to the text.

Tue, Apr 4, 8:40 AM · User-Ryasmeen, User-Urbanecm, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Mon, Apr 3

Tgr added a comment to T5233: Send a cookie with each block.

The EU data protection working group advisory WP-194 section 3.3 ("cookies set for the specific task of increasing the security of the service that has been explicitly requested by the user") clearly applies here, as long as the cookie is only set on edit attempts (IIRC not the case with the current implementation, but would be a trivial change).

Mon, Apr 3, 7:21 PM · MW-1.29-release-notes, Community-Tech, User-notice, Support-and-Safety, MediaWiki-Authentication-and-authorization, MediaWiki-User-blocking

Sat, Apr 1

Tgr added a comment to T147618: Localize one or more major WMF software products related to new editor retention to hu.wikipedia .

Hi László,

Sat, Apr 1, 12:34 AM · Outreachy (Round-14), Google-Summer-of-Code (2017), Outreach-Programs-Projects, Possible-Tech-Projects

Fri, Mar 31

Tgr added a project to T161773: Make a plain text dump of Wikipedia available alongside the XML: Datasets-General-or-Unknown.

I thought TextExtracts stores article plaintext in the page_props table, but apparently it uses memcached. So there might be no easy way to dump that. I guess a script could just fetch it from the API, but that might be too slow or fragile.

Fri, Mar 31, 11:24 PM · Dumps-Generation

Thu, Mar 30

Tgr added a comment to T161860: Password reset link missing on mediawiki.org.

This seems to be a side effect of T154698: Prevent contributions attributed to private and WMF IP addresses:

tgr@terbium:~$ mwscript eval.php --wiki=mediawikiwiki
> $passwordReset = new PasswordReset( RequestContext::getMain()->getConfig(), \MediaWiki\Auth\AuthManager::singleton() );
Thu, Mar 30, 9:20 PM · Wikimedia-General-or-Unknown, MediaWiki-User-login-and-signup
Tgr created T161860: Password reset link missing on mediawiki.org.
Thu, Mar 30, 9:14 PM · Wikimedia-General-or-Unknown, MediaWiki-User-login-and-signup
Tgr created T161780: Flow should preserve editbox text when closed page is re-opened.
Thu, Mar 30, 7:08 AM · Collaboration-Team-Triage, Flow

Wed, Mar 29

Tgr added a comment to T161696: Oauth for PAWS fails - presumably because of username change.

Is T136114 related?

Wed, Mar 29, 5:57 PM · MediaWiki-extensions-OAuth, PAWS
Tgr added a comment to T147618: Localize one or more major WMF software products related to new editor retention to hu.wikipedia .

A possible microtask:

Wed, Mar 29, 10:25 AM · Outreachy (Round-14), Google-Summer-of-Code (2017), Outreach-Programs-Projects, Possible-Tech-Projects
Tgr added a comment to T126500: Organize a MediaWiki Documentation Day (similar to the Gerrit Cleanup Day).

If you are looking for tasks, here is a recent request: https://stackoverflow.com/questions/43007309/wheres-the-list-of-values-for-action-in-permissions-related-mediawiki-hooks

Wed, Mar 29, 8:16 AM · Developer-Wishlist (2017), Documentation, MediaWiki-Documentation, Developer-Relations