Page MenuHomePhabricator

Tgr (Gergő Tisza)
Software Engineer, WMF

Projects (45)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 4:55 PM (297 w, 2 d)
Availability
Available
IRC Nick
tgr
LDAP User
Gergő Tisza
MediaWiki User
Tgr (WMF) [ Global Accounts ]

Things my team is working on: Growth-Team (kanban board)
Side projects I am working on (or planning to, eventually): User-Tgr
You can find more info about me on my user page.

Recent Activity

Yesterday

Tgr added a comment to T241607: Wikispore on search engines.

Fixed robots.txt.

Sun, May 31, 2:43 PM · Wikispore
Tgr added a comment to T254092: RFC: to avoid CAPTCHA Security check on WikiSpore for trusted contributors?.

Are you autoconfirmed on Wikispore? I can't imagine why capcthas would show up then.
In any case, we can probably get rid of captchas entirely now that we rely on Wikimedia login.

Sun, May 31, 2:30 PM · Wikispore
Tgr added a comment to T254102: Make getContent() work for interwiki pages.

See T243931: Allow a module to load (require) another module from a global module repository wiki for a similar discussion.

Sun, May 31, 2:28 PM · Crosswiki, MediaWiki-extensions-Scribunto

Sat, May 30

Tgr reopened T222479: Display autogenerated extension information in Template:Extension as "Open".

Thanks a lot for your work on this, @Pppery!

Sat, May 30, 3:30 PM · Tool-extjsonuploader, MediaWiki-Documentation
Tgr added a comment to T230536: Write OAuth 1.0 auth plugin for Synapse (Matrix).

Synapse supports OpenID Connect now. We don't (filed as T254063: OAuth extension should support OpenID Connect), but that also seems like a realistic path towards identity integration with Synapse; maybe a more sustainable one.

Sat, May 30, 2:05 PM · Matrix
Tgr added a comment to T15631: Wikimedia should become an OpenID provider.

OpenID has little support today. To some extent it has been replaced by OpenID Connect (not as a federated identity system, but at least as a standard method of proving your identity at a specific website). IMO we can decline this in favor of T254063: OAuth extension should support OpenID Connect.

Sat, May 30, 2:02 PM · Wikimedia-Extension-setup
Tgr updated the task description for T254063: OAuth extension should support OpenID Connect.
Sat, May 30, 2:00 PM · MediaWiki-extensions-OAuth
Tgr created T254063: OAuth extension should support OpenID Connect.
Sat, May 30, 1:58 PM · MediaWiki-extensions-OAuth
Tgr added a comment to T241607: Wikispore on search engines.

Registered the site on Google Search Console as a first debugging step. Ping me if you need access.

Sat, May 30, 9:44 AM · Wikispore
Tgr updated the task description for T231911: Basic configuration for Wikispore.
Sat, May 30, 9:39 AM · Wikispore
Tgr closed T237815: Configure interwiki map as Resolved.

Done. I've opted for a puppetized approach since the Interwiki extension does not support export/import. See puppet/modules/role/manifests/wikispore/interwikis.pp in c546156.

Sat, May 30, 9:31 AM · Wikispore
Tgr added a comment to T248271: CC text in footer.

Current copyright holders:

vagrant@localhost:[wiki]> select user_name, count(*) edits from revision join revision_actor_temp on rev_id = revactor_rev join actor on revactor_actor = actor_id join user on actor_user = user_id left join ipblocks on user_id = ipb_user where ipb_user is null group by user_name order by edits desc;
+--------------------+-------+
| user_name          | edits |
+--------------------+-------+
| Pharos             |   394 |
| Koavf              |   125 |
| ChristianSW        |    49 |
| A12n               |    41 |
| Zblace             |    41 |
| Spinster           |    20 |
| Denny              |    17 |
| Ottawahitech       |    13 |
| Mvolz              |     9 |
| Sj                 |     9 |
| Perohanych         |     6 |
| Tgr                |     6 |
| PKM                |     6 |
| Funcrunch          |     6 |
| R9H9               |     6 |
| Ircpresident       |     6 |
| Sm8900             |     4 |
| 1234qwer1234qwer4  |     3 |
| DutchTreat         |     3 |
| Maintenance script |     2 |
| Sannita            |     2 |
| Bluerasberry       |     2 |
| FULBERT            |     2 |
| Killarnee          |     2 |
| Reify-tech         |     1 |
| Battleofalma       |     1 |
| TrMendenhall       |     1 |
+--------------------+-------+

We need their permission for making the switch.

Sat, May 30, 9:29 AM · WMF-Legal, Wikispore

Fri, May 29

Tgr added a project to T254045: One can register a username with an equals sign in it: Wikimedia-Site-requests.

Best we could do is prevent new usernames from being registered, unless someone takes it on themselves to rename all the users who have an equal sign in their name (which probably requires a global discussion first since the existing rename policy is pretty narrow).

Fri, May 29, 11:07 PM · Wikimedia-Site-requests, MediaWiki-Templates, MediaWiki-User-login-and-signup
Tgr added a comment to T250317: Add schema.org structured data to images on Commons and Wikipedia to meet Google's requirements.

Out of curiosity, what does it mean that Google requires us to do this? I imagine they won't skip indexing an image just because it does not have schema.org data associated with it...
Also, where do you plan taking the license metadata from? CommonsMetadata or do you expect the data model discussions to be wrapped up by then?

Fri, May 29, 9:45 PM · Readers-Web-Backlog, Structured-Data-Backlog (Current Work)
Tgr updated subscribers of T250317: Add schema.org structured data to images on Commons and Wikipedia to meet Google's requirements.

Changing uploaded files is scary (data loss if anything goes wrong, changing what data needs to be added is a major PITA, duplicate checking breaks during train rollout of changes to the image modification algorithm...). Adding metadata to thumbnails is fine (to some extent we do it already), although thumbnails are preserved forever so purging all existing thumbnails would take a while. The task for it is T5361: Embed image author, description, and copyright data in file metadata fields. Note though that sometimes we display the original file, not a thumbnail. It would be nice to get rid of that for a number of reasons (T67383: Generate optimised thumbnail even when dimensions match original) but it involves some gnarly areas of legacy code so I wouldn't expect to be easy. Although that task implies that it's already being done for Wikimedia production at least... maybe @Gilles can clarify.

Fri, May 29, 9:32 PM · Readers-Web-Backlog, Structured-Data-Backlog (Current Work)
Tgr added a comment to T254037: Add a interwiki prefix for Lingua Libre to MediaWiki.

This is normally done at https://meta.wikimedia.org/wiki/Talk:Interwiki_map.

Fri, May 29, 8:54 PM · Lingua Libre
Tgr added a comment to T254024: Thanks QUnit tests are broken in Special:JavaScriptTest.

I guess the question is, why is Thanks using $.cookie instead of mw.cookie?

Fri, May 29, 7:39 PM · Patch-For-Review, Thanks, Growth-Team
Tgr reopened T129931: VisualEditor: keyboard-based remove actions (such as removing links) should not require text to be selected. as "Open".

I think the most intuitive behavior would be to only remove the innermost element and only if it actually wraps the cursor. Also it probably shouldn't remove block formatting, especially paragraphs (the current selection-based mechanism doesn't do that either). So

  • <p>Foo<b>b|ar<a href="./baz">ban<i>g</i></a></b></p> -> Ctrl+M -> <p>Foob|ar<a href="./baz">ban<i>g</i></a></p> -> Ctrl+M -> (no effect)
  • <p>Foo<b>bar<a href="./baz">ban|<i>g</i></a></b></p> -> Ctrl+M -> <p>Foo<b>barban|<i>g</i></b></p> -> Ctrl+M -> (no effect)
Fri, May 29, 7:28 PM · VisualEditor
Tgr added a comment to T250767: [Skins] Uncaught Error: Call to a member function isLocal() on boolean.

I don't see anything relevant in the logs after May 2.

Fri, May 29, 5:31 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Readers-Web-Backlog, MobileFrontend, MediaWiki-Interface, Wikimedia-production-error
Tgr added a comment to T254024: Thanks QUnit tests are broken in Special:JavaScriptTest.

The test has a command $.cookie( mw.thanks.thanked.cookieName, escape( '17,11' ) ) which should set up a fixture for the cookie, but it doesn't. Seems to be some kind of cookie path mess, I have three otherwise identical cookies with the paths /w, /wiki and /wiki/JavaScriptTest, with only the middle one having the correct value.

Fri, May 29, 5:10 PM · Patch-For-Review, Thanks, Growth-Team
Tgr added a comment to T254009: MobileFrontend QUnit tests are broken in Special:JavaScriptTest.

Thanks for the super quick fix! Properly doing the build step fixes about 20 tests (filed T254023: MobileFrontend repo needs npm build step after code update in MediaWiki-Vagrant about that), the patch fixes 50-ish more. Only one error remains:

MobileFrontend mobile.startup/OverlayManager: #getSingleton (hash present and overlay not managed)
If a page is loaded with a hash fragment a new entry is placed before it to allow the user to go back.
Expected: 	true
Result: 	false

It passes in isolation, but only when started with an URL with no hash fragment. So probably some other test lets state bleed into the hash fragment, and this one doesn't start from a fixture.

Fri, May 29, 5:02 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Readers-Web-Backlog, Testing-Roadblocks, JavaScript, MobileFrontend
Tgr created T254024: Thanks QUnit tests are broken in Special:JavaScriptTest.
Fri, May 29, 4:36 PM · Patch-For-Review, Thanks, Growth-Team
Tgr updated the task description for T254023: MobileFrontend repo needs npm build step after code update in MediaWiki-Vagrant.
Fri, May 29, 4:32 PM · MobileFrontend, MediaWiki-Vagrant
Tgr created T254023: MobileFrontend repo needs npm build step after code update in MediaWiki-Vagrant.
Fri, May 29, 4:32 PM · MobileFrontend, MediaWiki-Vagrant
Tgr updated the task description for T253993: mediawiki.ForeignApi QUnit tests are broken in Special:JavaScriptTest.
Fri, May 29, 3:20 PM · Patch-For-Review, JavaScript, MediaWiki-Core-Testing
Tgr created T254015: Scaling: Use API requests in PageLoader::fetchConfig.
Fri, May 29, 2:36 PM · Growth-Team, Growth-Scaling
Tgr added a comment to T254009: MobileFrontend QUnit tests are broken in Special:JavaScriptTest.

Possibly some (but not all) is from T253993: mediawiki.ForeignApi QUnit tests are broken in Special:JavaScriptTest which seems to cause a number of unrelated tests to fail.

Fri, May 29, 1:41 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Readers-Web-Backlog, Testing-Roadblocks, JavaScript, MobileFrontend
Tgr created T254009: MobileFrontend QUnit tests are broken in Special:JavaScriptTest.
Fri, May 29, 1:37 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Readers-Web-Backlog, Testing-Roadblocks, JavaScript, MobileFrontend
Tgr added a comment to T253993: mediawiki.ForeignApi QUnit tests are broken in Special:JavaScriptTest.

Seems like actually only one test is broken, the others breaking is a knockover effect.

Fri, May 29, 12:12 PM · Patch-For-Review, JavaScript, MediaWiki-Core-Testing
Tgr created T253993: mediawiki.ForeignApi QUnit tests are broken in Special:JavaScriptTest.
Fri, May 29, 12:11 PM · Patch-For-Review, JavaScript, MediaWiki-Core-Testing

Thu, May 28

Tgr added a comment to T253133: mw.notify should support show on page reload.

I was planning to file something similar but slightly more generic based on MobileFrontend c596013 - in that case, not only the notice but also the hook should ideally be deferred to the next page load. I think it would be nice to have "deferred events" in Javascript where the event includes the name of the ResourceLoader module that handles it, and on next page load that module automatically gets loaded and then the event fired. GrowthExperiments c594780 implements something similar but use-case-specific, and I'd also much prefer that being done once well in core instead.

Thu, May 28, 2:08 PM · Readers-Web-Backlog, Growth-Team, Editing-team, MediaWiki-Interface

Wed, May 27

Tgr moved T253678: Help panel suggested edit screen: Allow scrolling contents from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, May 27, 12:17 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), GrowthExperiments-Homepage, NewcomerTasks 1.2, Growth-Team (Current Sprint)

Tue, May 26

Tgr added a comment to T245790: Newcomer tasks: post-edit dialog.

@Tgr -- if making that change is anything more than trivial, we'll file it separately and do it another time so that this task can proceed across the board. Let us know!

Tue, May 26, 10:34 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Patch-For-Review, NewcomerTasks 1.2, Growth-Team (Current Sprint)
Tgr updated the task description for T175224: Unclear expectations around path/module in $wgVirtualRestConfig.
Tue, May 26, 1:49 PM · Core Platform Team Legacy (Later), Services (later), Documentation, RESTBase

Mon, May 25

Tgr added a comment to T253461: Liberate the @ for AtEase.

As a compromise, it might be worthwhile changing at-ease to follow a more functional style

Mon, May 25, 11:18 PM · TechCom, MediaWiki-Codesniffer, Proposal, at-ease, MediaWiki-General
Tgr added a comment to T253541: Establish a standard way of overriding service wiring for end-to-end tests.

GrowthExperiments has a recommendation API where result ordering is intentionally randomized. In an browser test we'd want to test result navigation but don't care about testing the randomization (if we want to test it at all, easy to do in a unit test) and not knowing the order of results beforehand is unhelpful.

Mon, May 25, 5:31 PM · MediaWiki-Core-Testing, MediaWiki-ServiceContainer, Dependency injection
Tgr added a parent task for T253541: Establish a standard way of overriding service wiring for end-to-end tests: T253015: Set up api-testing in CI for mediawiki-extensions-GrowthExperiments.
Mon, May 25, 4:41 PM · MediaWiki-Core-Testing, MediaWiki-ServiceContainer, Dependency injection
Tgr added a subtask for T253015: Set up api-testing in CI for mediawiki-extensions-GrowthExperiments: T253541: Establish a standard way of overriding service wiring for end-to-end tests.
Mon, May 25, 4:41 PM · NewcomerTasks 1.2, Growth-Team (Current Sprint)
Tgr added a comment to T253461: Liberate the @ for AtEase.

The common concern about @ is that it encourages misuse because it seems very lightweight but it's actually not cheap (it changes php.ini settings dynamically, all the error message generation still happens even though the result is discarded, allegedly it even impacts compiler optimizations - although those are PHP 5 era claims, not sure if they still hold up).

Mon, May 25, 4:39 PM · TechCom, MediaWiki-Codesniffer, Proposal, at-ease, MediaWiki-General
Tgr updated the task description for T253568: Make the terminology of OAuth UI and documentation easy to understand.
Mon, May 25, 3:05 PM · Documentation, Voice & Tone, MediaWiki-extensions-OAuth
Tgr added a comment to T253447: OAuth2 docs seem confused/incomplete.

I filed T253568: Make the terminology of OAuth UI and documentation easy to understand although in hindsight I should have probably edited this task.

Mon, May 25, 3:03 PM · Core Platform Team Workboards (Green), Documentation, MediaWiki-extensions-OAuth
Tgr created T253568: Make the terminology of OAuth UI and documentation easy to understand.
Mon, May 25, 3:02 PM · Documentation, Voice & Tone, MediaWiki-extensions-OAuth
Tgr added a comment to T253541: Establish a standard way of overriding service wiring for end-to-end tests.

Yeah, that came up as an option (this task is the continuation of discussions from here and here) but especially for extensions having that code in the extension repo is probably the lesser evil (easier to ensure it stays current, for example).

Mon, May 25, 12:56 PM · MediaWiki-Core-Testing, MediaWiki-ServiceContainer, Dependency injection
Tgr added a comment to T147946: Display banners on diff pages.

The page title is set in DifferenceEngine::showDiffPage, you'd have to factor out that part into something that can be sanely overridden. Or, I guess, change the title from the DifferenceEngineOldHeaderNoOldRev and DifferenceEngineOldHeader hooks, although that's a rather ugly hack.

Mon, May 25, 12:47 PM · Readers-Web-Backlog (Design), Patch-For-Review, Wikidata-Page-Banner, MediaWiki-General
Tgr created T253541: Establish a standard way of overriding service wiring for end-to-end tests.
Mon, May 25, 11:06 AM · MediaWiki-Core-Testing, MediaWiki-ServiceContainer, Dependency injection
Tgr added a comment to T253114: Search autocompletion broken for recent articles (after April 30?) for some users / browsers.

Should this be in Tech News User-notice ?

Mon, May 25, 9:36 AM · CirrusSearch, Discovery-Search, Regression, Discovery
Tgr closed T243345: Email on Wikispore as Resolved.

Fixed in the latest version of the role::wikispore Vagrant patch.

Mon, May 25, 9:34 AM · Wikispore
Draceane awarded T253114: Search autocompletion broken for recent articles (after April 30?) for some users / browsers a Burninate token.
Mon, May 25, 9:02 AM · CirrusSearch, Discovery-Search, Regression, Discovery
Tgr added a comment to T253509: Make Vagrant SMTP server configurable via hiera.

Needs something like

$wgSMTP = [
	'host' => '<%= scope['::role::mediawiki::smtp'] %>',
	'IDHost' => '<%= scope['::role::mediawiki::hostname'] %>',
	'port' => 25,
	'auth' => false,
];

but only when the SMTP variable is set.

Mon, May 25, 8:43 AM · MediaWiki-Vagrant
Tgr created T253509: Make Vagrant SMTP server configurable via hiera.
Mon, May 25, 8:41 AM · MediaWiki-Vagrant

Sun, May 24

Tgr moved T244210: Newcomer tasks: Suggested article image should be repeated when image width is less than card width from Needs More Work to Code Review on the Growth-Team (Current Sprint) board.
Sun, May 24, 11:39 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Growth-Team (Current Sprint), NewcomerTasks 1.2
Tgr added a comment to T243345: Email on Wikispore.

The relevant docs are at Help:Email in Cloud VPS.

Sun, May 24, 11:15 PM · Wikispore
Tgr created T253491: Set up convos.by on Toolforge.
Sun, May 24, 11:09 PM · Technical-Tool-Request
Tgr added a comment to T235174: Add Mediawiki-Vagrant role for MailCatcher.

Can this be resolved then?

Sun, May 24, 10:59 PM · MediaWiki-Vagrant

Fri, May 22

Tgr added a comment to T245790: Newcomer tasks: post-edit dialog.

Comparing wgStableRevisionId to wgRevisionId seems like an easy and accurate way to tell whether the current version of the page is shown by default or pending review, so we can easily show different messages.

Fri, May 22, 11:50 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Patch-For-Review, NewcomerTasks 1.2, Growth-Team (Current Sprint)
Tgr added a comment to T249703: Automatically close Pull Requests in repos mirrored on Github.

It would be nice to link to or at least name the Gerrit repository name in the closing message. (It would be even cooler to provide specific instructions on how to submit the pull request to Gerrit, not sure how feasible that is though.)

Fri, May 22, 11:33 AM · Developer-Advocacy (Apr-Jun 2020), Release-Engineering-Team, User-Majavah, Wikimedia-GitHub
Tgr added a comment to T244210: Newcomer tasks: Suggested article image should be repeated when image width is less than card width.

Yeah, we are talking about the same thing, I just can't reproduce it happening.
Looking at your first example, it doesn't even seem related to the image being narrower than the card.

Fri, May 22, 11:17 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Growth-Team (Current Sprint), NewcomerTasks 1.2

Thu, May 21

Tgr added a comment to T244210: Newcomer tasks: Suggested article image should be repeated when image width is less than card width.

Yeah, we can just replace the size parameter in the URL to get what we want (unless the original image is narrower than 260px which should be very rare). The flip side is that it will load a bit slower as 260px is not a standard image width so the thumbnail is probably not pre-rendered. (Then again, I'm not sure the size offered by RESTBase is any different...)

Thu, May 21, 3:45 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Growth-Team (Current Sprint), NewcomerTasks 1.2
Tgr added a comment to T244210: Newcomer tasks: Suggested article image should be repeated when image width is less than card width.

@RHo looking at the app screenshots made me wonder why we don't just scale our images to full width. I originally assumed this problem occurs when the image is physically not wide enough to fill the card, but the app uses larger sizes so that cannot be the case (and I checked manually and indeed it isn't). So e.g.

instead of thislike this

Maybe that's just an artifact of what API we are using to get the image URL?

Thu, May 21, 3:00 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Growth-Team (Current Sprint), NewcomerTasks 1.2
Tgr added a comment to T244210: Newcomer tasks: Suggested article image should be repeated when image width is less than card width.
  • In betalabs, the images are cut off horizontally more than in production
Thu, May 21, 2:48 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Growth-Team (Current Sprint), NewcomerTasks 1.2
Tgr added a comment to T245790: Newcomer tasks: post-edit dialog.

TBH I don't think it matters too much whether the post-edit notification uses the exact same choice of word is as the editor submit button. The MediaWiki default post-edit notice is "Your edit was saved.", for example.

Thu, May 21, 2:37 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Patch-For-Review, NewcomerTasks 1.2, Growth-Team (Current Sprint)
Tgr added a comment to T245790: Newcomer tasks: post-edit dialog.

In some sense you are still publishing the edit, since it will be visible to anyone, even if it does not show in the default article view. It would be nice if it said something like "submit for review" but that's a bit too long for a button. (I don't think "Submit" tells anything useful to the user.)

Thu, May 21, 12:19 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Patch-For-Review, NewcomerTasks 1.2, Growth-Team (Current Sprint)

Wed, May 20

Tgr moved T251526: Newcomer tasks: create separate EventLogging schema for newcomer task impressions from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, May 20, 4:21 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Product-Analytics, Growth-Team (Current Sprint), NewcomerTasks 1.2
Tgr added a comment to T244210: Newcomer tasks: Suggested article image should be repeated when image width is less than card width.

This is surprisingly hard to get right:

  • As shown above, CSS blur spreads the image outside its original area (could be addressed in a number of ways, overflow:hidden, clip, background-clip...) and more problematically fades the edges out. Or more precisely, assumes the image is on a white background and uses that white color for the convolution when near the edges. SVG has an option to avoid this (edgeMode) but it does not seem to be implemented in any browser. I guess we could scale the background image to extend beyond the card a bit and then clip it, so this would be manageable, although it would add to the weirdness factor.
  • Some images have transparent areas, where the blurred background version shows through. I don't really see a way to deal with this. If we add a white background, there will be an edge between that background and the stretched or repeated background image - the same problem this task is trying to solve.
Wed, May 20, 3:44 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Growth-Team (Current Sprint), NewcomerTasks 1.2

Tue, May 19

Tgr added a project to T216356: Allow access to the page's short description via the title object: good first task.

Short description handling currently lives in Wikibase, so mw.wikibase makes sense nevertheless.

Tue, May 19, 10:29 PM · good first task, MediaWiki-extensions-WikibaseClient, Wikidata, MediaWiki-extensions-Scribunto
Tgr added a comment to T70468: Images with border parameter should display captions.

In any case, wikitext changes should probably be blocked on the parser unification for now.

Tue, May 19, 10:25 PM · MediaWiki-Interface
Tgr added a comment to T253114: Search autocompletion broken for recent articles (after April 30?) for some users / browsers.

As an aside, the search autocompleter honoring the namespace defaults set for advanced search seems highly counterintuitive to me. I seem to recall having reported that in the past but I'm unable to find any relevant task now.

Tue, May 19, 11:30 AM · CirrusSearch, Discovery-Search, Regression, Discovery
Tgr added a comment to T253114: Search autocompletion broken for recent articles (after April 30?) for some users / browsers.

So maybe this is the combination of a CompletionSuggester bug and some kind of obscure user setting resulting in the use of a different search method for one account?

Tue, May 19, 11:28 AM · CirrusSearch, Discovery-Search, Regression, Discovery
Tgr added a comment to T253114: Search autocompletion broken for recent articles (after April 30?) for some users / browsers.

Manually selecting the "Classic prefix search" user preference makes all browsers give the correct results.

Tue, May 19, 11:02 AM · CirrusSearch, Discovery-Search, Regression, Discovery
Tgr added a comment to T253114: Search autocompletion broken for recent articles (after April 30?) for some users / browsers.

Specifically, the working request has namespace= and the other one has namespace=0|1|2|3|4|5|6|7|8|9|10|11|12|13|14|15|90|91|92|93|100|101|828|829|2300|2301|2302|2303. And the response for the first says x-opensearch-type: prefix and the second one x-opensearch-type: comp_suggest. So maybe this is the combination of a CompletionSuggester bug and some kind of obscure user setting resulting in the use of a different search method for one account? Not sure what that would be though, both accounts have the Search completion user preference set to default.

Tue, May 19, 10:53 AM · CirrusSearch, Discovery-Search, Regression, Discovery
Tgr removed projects from T253114: Search autocompletion broken for recent articles (after April 30?) for some users / browsers: Traffic, Operations.

also if I directly request the API URL used by the search autocompletion JS code (this for the example above) it gives the correct result for all browsers

Tue, May 19, 10:39 AM · CirrusSearch, Discovery-Search, Regression, Discovery
Tgr updated the task description for T253114: Search autocompletion broken for recent articles (after April 30?) for some users / browsers.
Tue, May 19, 10:33 AM · CirrusSearch, Discovery-Search, Regression, Discovery
Tgr created P11231 T253114 - example of a request that does not work (via Chrome's "Copy as cURL" option).
Tue, May 19, 10:33 AM
Tgr created P11230 T253114 - example of a request that works (via Chrome's "Copy as cURL" option).
Tue, May 19, 10:32 AM
Tgr created T253114: Search autocompletion broken for recent articles (after April 30?) for some users / browsers.
Tue, May 19, 10:30 AM · CirrusSearch, Discovery-Search, Regression, Discovery
Tgr awarded T252345: Deploy an instance of Framadate on Toolforge a Love token.
Tue, May 19, 12:36 AM · Wikimedia-Hackathon-2020, Tools

Mon, May 18

Tgr added a comment to T191531: Create Lua module to expose local short descriptions of pages from other wikis to Lua.

This is unlikely to happen for the same reasons T243931: Allow a module to load (require) another module from a global module repository wiki didn't.

Mon, May 18, 11:49 PM · Wikidata, MediaWiki-extensions-WikibaseClient
Tgr added a comment to T246919: Newcomer tasks: guidance instrumentation.

hi @Tgr and @MMiller_WMF - do we also record time elapsed before someone dismisses the help panel? Asking as I wonder if this can be a proxy to determining the bounce rate somehow (e.g., if they close the panel before 5 seconds have elapsed and without interacting with the panel, this is a sign they do not find the information interesting or useful).

Mon, May 18, 10:25 PM · Patch-For-Review, NewcomerTasks 1.2, Growth-Team (Current Sprint)
Tgr added a comment to T250406: RFC: Hybrid extension management.

Maybe a good compromise would be to handle version conflicts in a user-friendly way. So the site won't technically break but display an error message telling the maintainer there is a version conflict (and maybe even a hint on how they can resolve it.)

Mon, May 18, 10:19 PM · MediaWiki-Stakeholders-Group, TechCom-RFC
Tgr added a parent task for T253010: Instrumentation for suggested edit screen tips: T246919: Newcomer tasks: guidance instrumentation.
Mon, May 18, 2:18 PM · NewcomerTasks 1.2, Growth-Team (Current Sprint)
Tgr added a subtask for T246919: Newcomer tasks: guidance instrumentation: T253010: Instrumentation for suggested edit screen tips.
Mon, May 18, 2:18 PM · Patch-For-Review, NewcomerTasks 1.2, Growth-Team (Current Sprint)

Sun, May 17

Tgr added a comment to T245905: Integrate CirrusSearch topic search capability with AdvancedSearch.
Topic filter, closedTopic filter, openTopic filter, with input field selected
Sun, May 17, 11:42 PM · Patch-For-Review, Wikimedia-Hackathon-2020, Discovery-Search, TCB-Team, CirrusSearch, Advanced-Search
Tgr awarded T252811: Requesting +2 rights for Mediawiki Group for DannyS712 a Like token.
Sun, May 17, 12:23 PM · User-DannyS712, MediaWiki-Gerrit-Group-Requests

Sat, May 16

Tgr added a comment to T217113: MediaWiki-Vagrant should use the same Node.js version as Wikimedia production.

Wrt using node 10 based CI tools on vagrant, my workaround is using nodeenv. It goes something like

sudo pip install nodeenv
cd <repo>
nodeenv ./nodeenv --node=10.20.1
source ./nodeenv/bin/activate
npm install
npm test
deactivate_node
Sat, May 16, 8:36 PM · Patch-For-Review, User-zeljkofilipin, MediaWiki-Vagrant

Fri, May 15

Tgr moved T246919: Newcomer tasks: guidance instrumentation from In Progress to Code Review on the Growth-Team (Current Sprint) board.

So, the general changes (and the changes needed to ensure consistency with EditAttemptStep) are handled in c593972, c594780 and c595224, those specific to the post-edit dialog in 595173; most of the help panel event logging was in place already (a little bit inconsistent, T250327: Newcomer tasks: clean up help panel EventLogging fixes that); the mobile peek is handled in c596719. All that's left is events related to guidance content; that's left for later since the functionality is still in progress.

Fri, May 15, 6:15 PM · Patch-For-Review, NewcomerTasks 1.2, Growth-Team (Current Sprint)
Tgr added a comment to T252591: REST API endpoints give confusing errors for invalid OAuth2 access tokens.

The fundamental issue here is that the session is initialized in Setup.php, which is outside of the main try..catch block of the API and so the exception would not go through the usual error logging / output formatting logic. So one option is to make that logic not rely on the try block and register it early as the PHP error handler; but it's probably easy to get into service dependency loops that way.

Fri, May 15, 2:41 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (Core REST API in PHP), MediaWiki-extensions-OAuth
Tgr added a comment to T251526: Newcomer tasks: create separate EventLogging schema for newcomer task impressions.

I guess technically it could also happen that the user queries the task API in the short timeframe between deleting a page and the ElasticSearch index being updated, so they receive a task card about an article that does not exist anymore, and since the ID is coming from a DB lookup and not ElasticSearch, it would be missing from the task data. It's a pretty unlikely edge case though.

Fri, May 15, 10:35 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Product-Analytics, Growth-Team (Current Sprint), NewcomerTasks 1.2
Tgr added a comment to T251526: Newcomer tasks: create separate EventLogging schema for newcomer task impressions.

@Tgr : I went and had another look at Schema:NewcomerTask. I noticed that page_id is not required, but page_title is required. In analyses, working with page IDs is preferable to titles, because the latter changes with page moves. In other words, for me page_id would also be required. Maybe there are cases where we have a title but not the page ID?

Fri, May 15, 10:30 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Product-Analytics, Growth-Team (Current Sprint), NewcomerTasks 1.2
Tgr added a comment to T252866: Restore old "merged" icon in Maniphest's Gerrit info block.

On a side note, the unresolved comment count (is that new, or have I just not payed attention before?) is pretty cool. Thanks for working on that!

Fri, May 15, 10:10 AM · Phabricator
Tgr created T252866: Restore old "merged" icon in Maniphest's Gerrit info block.
Fri, May 15, 10:07 AM · Phabricator

Thu, May 14

Tgr updated the task description for T252823: banana:docs fails on user-provided string.
Thu, May 14, 8:29 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Continuous-Integration-Config, Growth-Team, GrowthExperiments
Tgr created T252823: banana:docs fails on user-provided string.
Thu, May 14, 8:26 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Continuous-Integration-Config, Growth-Team, GrowthExperiments
Tgr moved T245790: Newcomer tasks: post-edit dialog from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Thu, May 14, 7:45 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Patch-For-Review, NewcomerTasks 1.2, Growth-Team (Current Sprint)
Tgr created T252808: Newcomer tasks: improve post-edit dialog display logic.
Thu, May 14, 7:00 PM · GrowthExperiments-NewcomerTasks
Tgr added a comment to T252794: EventLogging vagrant role fails to provision.

I'll remove the broken library when I get around to it. The error doesn't really break anything though.

Thu, May 14, 6:26 PM · Analytics, Event-Platform, MediaWiki-Vagrant
Tgr merged T252794: EventLogging vagrant role fails to provision into T251864: eventlogging vagrant role: 'ParsedRequirement' object has no attribute 'req'.
Thu, May 14, 6:25 PM · Analytics-EventLogging, Analytics, MediaWiki-Vagrant
Tgr merged task T252794: EventLogging vagrant role fails to provision into T251864: eventlogging vagrant role: 'ParsedRequirement' object has no attribute 'req'.
Thu, May 14, 6:25 PM · Analytics, Event-Platform, MediaWiki-Vagrant

Wed, May 13

Tgr added a comment to T252708: Child comments inherit indentation from end of parent comment.

Note that indentation style can change on a per-page or per-section basis. * or # is common for voting-style discussions.

Wed, May 13, 9:22 PM · OWC2020 (OWC2020 Replying 1.0), DiscussionTools, Editing-team (Q3 2019-2020 Kanban Board)
Tgr renamed T252665: After installing wikidiff2 on MediaWiki-Vagrant, the web server does not pick up the new settings without a manual restart from wikidiff2 is not available in MediaWiki-Vagrant web requests to After installing wikidiff2 on MediaWiki-Vagrant, the web server does not pick up the new settings without a manual restart.
Wed, May 13, 1:19 PM · wikidiff2, MediaWiki-Vagrant
Tgr added a comment to T252665: After installing wikidiff2 on MediaWiki-Vagrant, the web server does not pick up the new settings without a manual restart.

This went away after a restart, so I guess the real problem is the wikidiff2 role not triggering an Apache or PHP restart.

Wed, May 13, 1:16 PM · wikidiff2, MediaWiki-Vagrant