Page MenuHomePhabricator

Tgr (Gergő Tisza)
Software Engineer, WMF

Projects (43)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 4:55 PM (323 w, 4 d)
Availability
Available
IRC Nick
tgr
LDAP User
Gergő Tisza
MediaWiki User
Tgr (WMF) [ Global Accounts ]

Things my team is working on: Growth-Team (kanban board)
Side projects I am working on (or planning to, eventually): User-Tgr
You can find more info about me on my user page.

Recent Activity

Yesterday

Tgr added a comment to T268273: Missing content_model rows after importing templates and modules.

NameTableStore is pretty self-contained, callers (such as the import logic) should have no idea whether the record exists already or not. They just exchange the model name for an ID which might or might not be freshly created. So I would suspect a database-level issue here (writes fail, but somehow without MediaWiki noticing it, or maybe there is some over-eager exception handling happening; the rest of the import works due to NameTableStore having cached the model name / ID pair, but as soon as that cache expires things blow up).

Tue, Dec 1, 2:00 AM · MediaWiki-Revision-backend, MediaWiki-Export-or-Import, MW-1.35-release
Tgr added a comment to T267273: [arwiki] 'skip' Welcome survey redirects user to Special:UserLogin.

Here's the same on testwiki (where things work as expected) just to make the URLs easier to follow:

Tue, Dec 1, 1:53 AM · Growth-Team
Tgr added a comment to T269028: WikimediaDebug should avoid confusion on unsupported domains.

I would go with whatever is easiest. No one is going to get surprised that using the extension on Phabricator has no effect; for wikitech it is non-obvious.

Tue, Dec 1, 1:12 AM · Performance-Team, WikimediaDebug
Tgr added a comment to T266157: CSS error should be displayed while trying to save, not only when previewing.

TemplateStyles uses Content::prepareSave to reject invalid CSS; if you try to save it, you get an error (much like how you cannot save invalid Lua code). There is no such thing for user CSS - it's not sanitized, it's not parsed, any string is valid. (ResourceLoader might error out when you try to use it, not sure how that would go, but nothing prevents saving it.)

Tue, Dec 1, 1:11 AM · MediaWiki-Page-editing, TemplateStyles, Regression
Tgr added a comment to T268803: Add a link engineering: Search pipeline.

I'm curious about the details of this:

when a recommendation was reviewed without making an edit, trigger the index update manually (TBD)

Of course, it is marked "TBD" so it isn't fair to press for more information at this stage. But when we get there, I remain interested in how passive rejection will work.

Tue, Dec 1, 12:44 AM · Discovery-Search, Add-Link, Growth-Team

Mon, Nov 30

Tgr added a comment to T234743: User rights validation is sometimes malfunctioning (with FlaggedRevs only?).

This is caused by $wgGroupPermissions being incorrect and that patch only touched $wgFlaggedRevsAutopromote / $wgFlaggedRevsAutoconfirm so probably not.

Mon, Nov 30, 10:17 PM · Release-Engineering-Team, MediaWiki-User-management, User-DannyS712
Tgr added a comment to T268955: Allow to use the recent technologies of CSS and Javascript in Wikimedia Project.

Without the JS parts this would make sense as a TemplateStyles task. (There is a patch that I think does a lot of this but needs to be reviewed.) That is largely independent from the browser support matrix - it is fine to support CSS features not implemented by all browsers if we assume CSS editors will be responsible about providing graceful degradation.

Mon, Nov 30, 9:45 PM · MobileFrontend, css-sanitizer, Front-end-Standards-Group, TemplateStyles, JavaScript, CSS
Tgr moved T216897: Add 'width: -webkit-fill-available' to allowed syntax for TemplateStyles from Up next to External (css-sanitizer) on the TemplateStyles board.
Mon, Nov 30, 9:36 PM · css-sanitizer, TemplateStyles
Tgr moved T241946: Support @media (prefers-color-scheme: ...) rule from Up next to External (css-sanitizer) on the TemplateStyles board.
Mon, Nov 30, 9:36 PM · css-sanitizer, TemplateStyles
Tgr moved T255342: Support for linear-gradient from Up next to External (css-sanitizer) on the TemplateStyles board.
Mon, Nov 30, 9:36 PM · css-sanitizer, TemplateStyles
Tgr moved T255343: Support overflow-wrap: anywhere from Up next to External (css-sanitizer) on the TemplateStyles board.
Mon, Nov 30, 9:36 PM · css-sanitizer, TemplateStyles
Tgr moved T265675: RGBA hexadecimal value is not supported in background-color (no support for transparency value) from Up next to External (css-sanitizer) on the TemplateStyles board.
Mon, Nov 30, 9:36 PM · css-sanitizer, TemplateStyles
Tgr moved T269044: Support more CSS properties / rules in css-sanitizer from Up next to External (css-sanitizer) on the TemplateStyles board.
Mon, Nov 30, 9:35 PM · Tracking-Neverending, TemplateStyles, css-sanitizer
Tgr moved T238690: Add support for background-position-x and y from External to External (css-sanitizer) on the TemplateStyles board.
Mon, Nov 30, 9:35 PM · css-sanitizer, TemplateStyles
Tgr added a project to T265675: RGBA hexadecimal value is not supported in background-color (no support for transparency value): css-sanitizer.
Mon, Nov 30, 9:34 PM · css-sanitizer, TemplateStyles
Tgr added a project to T216897: Add 'width: -webkit-fill-available' to allowed syntax for TemplateStyles: css-sanitizer.
Mon, Nov 30, 9:33 PM · css-sanitizer, TemplateStyles
Tgr added a parent task for T162379: Decide which non-standard CSS properties to support in TemplateStyles: T269044: Support more CSS properties / rules in css-sanitizer.
Mon, Nov 30, 9:32 PM · Performance-Team (Radar), Platform Engineering, Patch-For-Review, css-sanitizer, TemplateStyles
Tgr added a parent task for T222678: Add image-rendering to cssImage3 set: T269044: Support more CSS properties / rules in css-sanitizer.
Mon, Nov 30, 9:32 PM · css-sanitizer
Tgr added a parent task for T216897: Add 'width: -webkit-fill-available' to allowed syntax for TemplateStyles: T269044: Support more CSS properties / rules in css-sanitizer.
Mon, Nov 30, 9:32 PM · css-sanitizer, TemplateStyles
Tgr added a parent task for T217722: Support (part of?) Selectors level 4 in css-sanitizer: T269044: Support more CSS properties / rules in css-sanitizer.
Mon, Nov 30, 9:32 PM · css-sanitizer
Tgr added a parent task for T241946: Support @media (prefers-color-scheme: ...) rule: T269044: Support more CSS properties / rules in css-sanitizer.
Mon, Nov 30, 9:32 PM · css-sanitizer, TemplateStyles
Tgr added a parent task for T238690: Add support for background-position-x and y: T269044: Support more CSS properties / rules in css-sanitizer.
Mon, Nov 30, 9:32 PM · css-sanitizer, TemplateStyles
Tgr added a parent task for T255342: Support for linear-gradient: T269044: Support more CSS properties / rules in css-sanitizer.
Mon, Nov 30, 9:32 PM · css-sanitizer, TemplateStyles
Tgr added a parent task for T265675: RGBA hexadecimal value is not supported in background-color (no support for transparency value): T269044: Support more CSS properties / rules in css-sanitizer.
Mon, Nov 30, 9:32 PM · css-sanitizer, TemplateStyles
Tgr added subtasks for T269044: Support more CSS properties / rules in css-sanitizer: T265675: RGBA hexadecimal value is not supported in background-color (no support for transparency value), T255343: Support overflow-wrap: anywhere, T255342: Support for linear-gradient, T241946: Support @media (prefers-color-scheme: ...) rule, T216897: Add 'width: -webkit-fill-available' to allowed syntax for TemplateStyles, T238690: Add support for background-position-x and y, T222678: Add image-rendering to cssImage3 set, T217722: Support (part of?) Selectors level 4 in css-sanitizer, T162379: Decide which non-standard CSS properties to support in TemplateStyles.
Mon, Nov 30, 9:32 PM · Tracking-Neverending, TemplateStyles, css-sanitizer
Tgr added a parent task for T255343: Support overflow-wrap: anywhere: T269044: Support more CSS properties / rules in css-sanitizer.
Mon, Nov 30, 9:32 PM · css-sanitizer, TemplateStyles
Tgr added a comment to T250957: TemplateStyles should tell users not to use vendor prefixes when it sees one.

That might be better as a CodeEditor lint rule.

Mon, Nov 30, 9:26 PM · css-sanitizer, TemplateStyles
Tgr added a project to T266157: CSS error should be displayed while trying to save, not only when previewing: MediaWiki-Page-editing.

Displaying parser errors is a MediaWiki core feature so this is probably not TemplateStyles specific.

Mon, Nov 30, 9:16 PM · MediaWiki-Page-editing, TemplateStyles, Regression
Tgr created T269044: Support more CSS properties / rules in css-sanitizer.
Mon, Nov 30, 9:12 PM · Tracking-Neverending, TemplateStyles, css-sanitizer
Tgr added a project to T268862: Update use of css-sanitizers Match class: css-sanitizer.
Mon, Nov 30, 9:09 PM · css-sanitizer, PHP 8.0 support, TemplateStyles
Tgr closed T268948: Add editprotected permission for interface-admin as Declined.

Giving admin-level privileges to people who are not admins would significantly affect the governance structure of the wikis, would require consulting with the affected communities, which costs a significant amount of developer and editor time. I'd rather not do that for a fairly arbitrary request like this.

Mon, Nov 30, 9:06 PM · MediaWiki-General
Tgr added a comment to T56947: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too.

Since this was last discussed we added the label editing field to mobile VE.

I think bringing that interface over to desktop would make these mistakes much less common as whenever you edit the link target, the link label is shown in an editable field right next to it.

By removing the existing edit label button that just puts the cursor into the surface, we would also push label editors to the same interface. Complex annotated labels could still be edited in the surface.

Mon, Nov 30, 8:44 PM · User-Tgr, VisualEditor-MediaWiki-Links, VisualEditor, VisualEditor-EditingTools

Thu, Nov 26

Tgr added a comment to T261407: Add a link engineering: Create event for event gate to update search index after obtaining link recommendations.

I wrote down the interaction between the MediaWiki extension and ElasticsSearch in T268803: Add a link engineering: Search pipeline; please correct me if I got something wrong.

Thu, Nov 26, 7:36 AM · Patch-For-Review, Growth-Team (Current Sprint), Discovery-Search, Discovery, Growth-Structured-Tasks
Tgr updated the task description for T268803: Add a link engineering: Search pipeline.
Thu, Nov 26, 7:35 AM · Discovery-Search, Add-Link, Growth-Team
Tgr created T268803: Add a link engineering: Search pipeline.
Thu, Nov 26, 7:32 AM · Discovery-Search, Add-Link, Growth-Team

Wed, Nov 25

Tgr added a comment to T261407: Add a link engineering: Create event for event gate to update search index after obtaining link recommendations.

I think if we focus on the recommendation/create event for now, we can make this move forward. @Tgr ping me when you update the schema patchset and I'll check it out.

Wed, Nov 25, 9:48 PM · Patch-For-Review, Growth-Team (Current Sprint), Discovery-Search, Discovery, Growth-Structured-Tasks
Tgr added a comment to T261407: Add a link engineering: Create event for event gate to update search index after obtaining link recommendations.

Gergo said the invalidate event might not be needed after all

Wed, Nov 25, 6:43 PM · Patch-For-Review, Growth-Team (Current Sprint), Discovery-Search, Discovery, Growth-Structured-Tasks
kostajh awarded T268700: Investigate setting up alerts for Growth dashboards a Like token.
Wed, Nov 25, 9:08 AM · Growth-Team
Tgr added a comment to T262877: Find and replace fails to highlight words when opened via F3.

I can confirm that this is now fixed in production.

Wed, Nov 25, 7:23 AM · User-Ryasmeen, Skipped QA, MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), Editing-team (FY2020-21 Kanban Board), VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Tgr created T268715: Occasional "Cannot access the database: Unknown error" in Wikimedia production.
Wed, Nov 25, 6:42 AM · Wikimedia-General-or-Unknown, Wikimedia-database-error, Wikimedia-production-error
Tgr added a comment to T261407: Add a link engineering: Create event for event gate to update search index after obtaining link recommendations.

Can we just have a single schema and stream, with the list (or just count?) of link recommendations for a revision? If the count is 0 (user has rejected them), the index can be updated accordingly. We could also add a field indicating that the change was made by a user rejections or a the link recommendation services. mediawiki/revision/recommendation-change schema? For future types of recommendations, we could do like mediawiki/revision/score does and use an array of maps types, as long as a generic enough model of a recommendation can be shared between the different types.

Wed, Nov 25, 6:30 AM · Patch-For-Review, Growth-Team (Current Sprint), Discovery-Search, Discovery, Growth-Structured-Tasks
Tgr added a comment to T268709: Add a link: mobile swiping gesture in suggested edits feed (nice to have).

Does "animate" mean just that, or some kind of drag mechanics (where the card moves in sync with your finger so it feels like dragging paper)? The latter is common on mobile apps but probably more effort.

Wed, Nov 25, 6:07 AM · GrowthExperiments, Add-Link, Growth-Structured-Tasks, Growth-Team
Tgr added a comment to T264378: ATS-BE Lua mitigations for cacheable responses w/ Set-Cookie seemingly not working.

Thanks for the thorough investigation!

Wed, Nov 25, 5:16 AM · Operations, Traffic
Tgr added a comment to T268284: Create a refresh token mechanism for owner-only OAuth 2.0 tokens.

The code could be ran by someone else. The token basically acts like a password; if the password is stolen, there must be a way to invalidate it. Disabling the key works, as long as whatever system consumes the token does check whether the key is valid. But the parent task talks about "APIs implemented in NodeJS or another system, which depend on the JavaScript Web Token (JWT) data to tell if a token is expired"; it doesn't make a lot of sense for such a system to not check with MediaWiki whether the token has been revoked, but do check whether the key has been disabled, so I assume it would do neither and just rely on the token as a cryptographic proof of authorization. In that case, infinite expiry does raise the exact same problem for owner-only tokens.

Wed, Nov 25, 4:50 AM · MediaWiki-extensions-OAuth
Tgr added a comment to T268679: [wmf.18] MentorPageMentorManager::setMentorForUser: Expectation (masterConns <= 0) by MediaWiki::main not met - GrowthExperiments.

I tried to write a core patch for this but it didn't feel convincing. The mentor manager in GrowthExperiments is the only thing using this pattern; only GrowthExperiments and flow use UserOptionsUpdateJob in the first place. And UserOptionsManager would require a new caching layer to handle this without breaking the use case that resulted in rMWff50d815a567: UserOptionsManager: take into account $queryFlags when caching which seems like a lot of complexity for something with such marginal utility. It also introduces various risks (what if the job gets lost or fails, but the updated user option gets stored somewhere else, resulting in loss of DB consistency? What if something tries to set the option between scheduling and running the job?) We can accept those risk for the specific use case of MentorPageMentorManager because we know the option is not going to be used in any way where that would be a serious problem, but providing it as a general-use interface seems fragile.

Wed, Nov 25, 4:30 AM · Growth-Team, Wikimedia-production-error
Tgr added a comment to T268679: [wmf.18] MentorPageMentorManager::setMentorForUser: Expectation (masterConns <= 0) by MediaWiki::main not met - GrowthExperiments.

This is the same issue mentioned in T250235#6605155.

Wed, Nov 25, 3:31 AM · Growth-Team, Wikimedia-production-error
Tgr renamed T268679: [wmf.18] MentorPageMentorManager::setMentorForUser: Expectation (masterConns <= 0) by MediaWiki::main not met - GrowthExperiments from [wmf.18] Expectation (masterConns <= 0) by MediaWiki::main not met - GrowthExperiments to [wmf.18] MentorPageMentorManager::setMentorForUser: Expectation (masterConns <= 0) by MediaWiki::main not met - GrowthExperiments.
Wed, Nov 25, 3:29 AM · Growth-Team, Wikimedia-production-error
Tgr moved T268519: [regression] Aliases for Growth features aren't working on Russian Wikipedia from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Nov 25, 3:22 AM · Verified, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Growth-Team (Current Sprint), Regression, Russian-Sites
Tgr added a comment to T267216: Slow load times for Special:Homepage on cswiki.

Filed T268700: Investigate setting up alerts for Growth dashboards about the alerts.

Wed, Nov 25, 1:04 AM · Patch-For-Review, DBA, mariadb-optimizer-bug, Wikimedia-production-error, Growth-Team (Current Sprint), GrowthExperiments
Tgr updated subscribers of T268700: Investigate setting up alerts for Growth dashboards.

It might be useful to set up some alerts on that dashboard, to be notified about incidents like this in the feature without having to keep on eye on the dashboard regularly. We can show you how our Grafana-based alerts currently work.

Wed, Nov 25, 12:53 AM · Growth-Team
Tgr added a comment to T240201: Performance review of GrowthExperiments extension, Special:Homepage Suggested Edits module.

Filed T268700: Investigate setting up alerts for Growth dashboards.

Wed, Nov 25, 12:53 AM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Patch-For-Review, Growth-Team, GrowthExperiments-NewcomerTasks, Performance-Team
Tgr created T268700: Investigate setting up alerts for Growth dashboards.
Wed, Nov 25, 12:52 AM · Growth-Team
Tgr edited projects for T248884: Documentation of client side error logging capabilities on mediawiki, added: Instrument-ClientError; removed Product-Infrastructure-Data.
Wed, Nov 25, 12:50 AM · Instrument-ClientError, Patch-For-Review, Analytics-Radar, Documentation, Performance-Team (Radar), Wikimedia-Logstash, User-fgiunchedi, Better Use Of Data

Tue, Nov 24

Tgr moved T265893: Add Link engineering: Deployment Pipeline setup from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Nov 24, 11:54 PM · Release-Engineering-Team, Growth-Team (Current Sprint), Add-Link, Growth-Structured-Tasks
Tgr added a comment to T231897: Wikibase install.

The LinkedWiki and Semantic Wikibase extensions would be possible options to explore.

Tue, Nov 24, 8:14 PM · Wikispore
Tgr added a comment to T261407: Add a link engineering: Create event for event gate to update search index after obtaining link recommendations.

What is not clear to me is how you reconcile the decision made by the add_link identification algorithm ran by the maint script and the user decision to refuse a recommendation.
What happens if you re-run the maint-script again after the users have refused some recommendations?

Tue, Nov 24, 11:13 AM · Patch-For-Review, Growth-Team (Current Sprint), Discovery-Search, Discovery, Growth-Structured-Tasks
Tgr added a comment to T258017: Variant D: difficulty overlay in onboarding.

This has been a recurring problem with our custom icons (see the icon before the result count at the bottom of the same dialog, the icons on the task card, the difficulty dialog etc), IIRC in other instances we either ignored it or just added some padding to the icon and tweaked the size until it looked right (with default zoom/font settings anyway). Would be nice to figure out what the proper fix is.

Tue, Nov 24, 10:56 AM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Growth-Team (Current Sprint), GrowthExperiments
Tgr added a comment to T267273: [arwiki] 'skip' Welcome survey redirects user to Special:UserLogin.

What is the URL of the survey, the URL the skip button (or whichever one you click) and the URL of the login page you end up at?

Tue, Nov 24, 10:48 AM · Growth-Team
Tgr moved T258016: Variant C: onboarding from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Nov 24, 10:45 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
Tgr added a comment to T261407: Add a link engineering: Create event for event gate to update search index after obtaining link recommendations.

IIUC, you are trying to emit 'revision link recommendation opportunity identified & link submitted' events?

Tue, Nov 24, 10:34 AM · Patch-For-Review, Growth-Team (Current Sprint), Discovery-Search, Discovery, Growth-Structured-Tasks
Tgr changed the status of Restricted Task, a subtask of T264370: User authentication security issue (Oct 1), from Invalid to Resolved.
Tue, Nov 24, 10:00 AM · Wikimedia-General-or-Unknown, Security
Tgr added a comment to T173955: Allow additional LocalSettings to be overriden by environment variables.

We could JSON encode arrays when needed, perhaps?

Tue, Nov 24, 9:10 AM · User-brennen, Developer-Wishlist (Next), MediaWiki-Configuration

Mon, Nov 23

Tgr closed T266737: Set up Python 3.7 on MediaWiki-Vagrant, a subtask of T266490: Add Link engineering: Vagrant role, as Resolved.
Mon, Nov 23, 11:52 PM · Patch-For-Review, MediaWiki-Vagrant, Growth-Structured-Tasks, Growth-Team (Current Sprint), Add-Link
Tgr closed T266737: Set up Python 3.7 on MediaWiki-Vagrant as Resolved.
Mon, Nov 23, 11:52 PM · Growth-Team (Current Sprint), MediaWiki-Vagrant
Tgr moved T268519: [regression] Aliases for Growth features aren't working on Russian Wikipedia from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Mon, Nov 23, 8:12 PM · Verified, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Growth-Team (Current Sprint), Regression, Russian-Sites
Tgr edited projects for T268519: [regression] Aliases for Growth features aren't working on Russian Wikipedia, added: Growth-Team (Current Sprint); removed Growth-Team.
Mon, Nov 23, 8:11 PM · Verified, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Growth-Team (Current Sprint), Regression, Russian-Sites
Tgr claimed T268519: [regression] Aliases for Growth features aren't working on Russian Wikipedia.
Mon, Nov 23, 8:06 PM · Verified, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Growth-Team (Current Sprint), Regression, Russian-Sites

Sat, Nov 21

Tgr added a comment to T268338: Cannot run MW 1.35 on MediaWiki-Vagrant.

I can't seem to get the version pinning right.

vagrant@test:~$ cat /etc/apt/preferences.d/sury-override.pref 
Package: libpcre2-* php-apcu php-igbinary php-redis php-tideways php-xdebug
Pin: release o=deb.sury.org
Pin-Priority: 1010
Sat, Nov 21, 6:41 AM · Patch-For-Review, MW-1.35-release, MediaWiki-Vagrant
Tgr renamed T151165: Increase the number of entries shown on the watchlist (wllimit) from Investigate: Increasing wllimit values to Increase the number of entries shown on the watchlist (wllimit).
Sat, Nov 21, 1:01 AM · Growth-Team, MediaWiki-Watchlist
Tgr merged T213265: Increase max number of edits in watchlist into T151165: Increase the number of entries shown on the watchlist (wllimit).
Sat, Nov 21, 1:00 AM · Growth-Team, MediaWiki-Watchlist
Tgr merged task T213265: Increase max number of edits in watchlist into T151165: Increase the number of entries shown on the watchlist (wllimit).
Sat, Nov 21, 1:00 AM · MediaWiki-Watchlist, Growth-Team

Fri, Nov 20

Tgr added a comment to T235812: Make Getting Started temporarily suppress the VE dialog by adding "vehidebetadialog" to the query string.

Opening VE will display correctly suppressed VE dialog - https://ca.wikipedia.beta.wmflabs.org/w/index.php?title=Pomezia&action=edit&vehidebetadialog=1. But if switching to wikitext editor (not making any edits in VE), then the both popups would be displayed:

Fri, Nov 20, 11:21 PM · Editing-team (FY2020-21 Kanban Board), MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Growth-Team-Leftovers, Growth-Team (Current Sprint), MediaWiki-extensions-GettingStarted
Tgr added a comment to T261407: Add a link engineering: Create event for event gate to update search index after obtaining link recommendations.

These are actual events though: add happens when a maintenance script generates recommendations, invalidate happens when a user acts on a recommendation (which can involve making an edit to the page, but doesn't have to). Is it a naming issue? add could be something like evaluate (to better resemble score), maybe? invalidate could be called something like submit? (accept/reject wouldn't work since a single recommendation contains multiple links, and the user could accept some and reject some in the same action.) We want to invalidate in situations other than the user accepting/rejecting, when the page has changed and recommendation is not current anymore, but we can probably use the normal MediaWiki index update mechanism for that.

Fri, Nov 20, 10:58 PM · Patch-For-Review, Growth-Team (Current Sprint), Discovery-Search, Discovery, Growth-Structured-Tasks
Tgr added a comment to T265300: Stop extending core's SpecialUpload.

The ideal solution would be, as in most similar cases, extracting the business logic from SpecialUpload into a separate class that any special page can use. That would, of course, take a fair amount of effort.

Fri, Nov 20, 10:45 PM · Social-Tools, SocialProfile, QuizGame, PollNY, PictureGame, FanBoxes, MediaWiki-extensions-General, MediaWiki-Uploading
Tgr added a comment to T173955: Allow additional LocalSettings to be overriden by environment variables.

Environment variables are strings while configuration settings are often arrays (sometimes deep arrays) so as a general mechanism env vars seem problematic.

Fri, Nov 20, 10:36 PM · User-brennen, Developer-Wishlist (Next), MediaWiki-Configuration
Tgr added a comment to T268338: Cannot run MW 1.35 on MediaWiki-Vagrant.

We can just install the Stretch backport from from https://packages.sury.org/php/

Fri, Nov 20, 10:28 PM · Patch-For-Review, MW-1.35-release, MediaWiki-Vagrant
Tgr added a comment to T261407: Add a link engineering: Create event for event gate to update search index after obtaining link recommendations.

@Ottomata I imagine the right way to send an event from MediaWiki is using EventBus? That will require configuring the event stream via $wgEventStreams. What's the preferred approach, should that happen in the extension or in mediawiki-config?

Fri, Nov 20, 7:42 AM · Patch-For-Review, Growth-Team (Current Sprint), Discovery-Search, Discovery, Growth-Structured-Tasks
Tgr added a comment to T262226: Consume new event from the AddLink feature.

The data will be stored in elastic within the predicted_classes field (currently named ores_articletopic, but renaming will happen at some point) along with the the ores predictions already stored there.

Fri, Nov 20, 7:40 AM · Discovery-Search (Current work)
Tgr moved T261407: Add a link engineering: Create event for event gate to update search index after obtaining link recommendations from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Fri, Nov 20, 3:45 AM · Patch-For-Review, Growth-Team (Current Sprint), Discovery-Search, Discovery, Growth-Structured-Tasks
Tgr added a comment to T261407: Add a link engineering: Create event for event gate to update search index after obtaining link recommendations.

After vacillating for a while I went with new events (mediawiki/revision/recommendation/add, mediawiki/revision/recommendation/invalidate) instead of reusing mediawiki.revision.score. Semantically it seemed wrong - the event does not contain any score, it is a notification that a recommendation was generated.

Fri, Nov 20, 3:43 AM · Patch-For-Review, Growth-Team (Current Sprint), Discovery-Search, Discovery, Growth-Structured-Tasks

Thu, Nov 19

Tgr edited projects for T268273: Missing content_model rows after importing templates and modules, added: MediaWiki-Export-or-Import, MediaWiki-Revision-backend; removed MediaWiki-General, Platform Team Initiatives (MCR), MediaWiki-Installer.

You shouldn't insert content IDs manually, the import script will do that. If you do insert by hand, you'll probably end up with a stale NameTableStore cache.

Thu, Nov 19, 11:34 PM · MediaWiki-Revision-backend, MediaWiki-Export-or-Import, MW-1.35-release
Tgr added a comment to T72152: AbuseFilter doesn't highlight the match cases at abuse log.

Some kind of mechanism for allowing variables in filter messages and/or allowing messages to be tied to wikitext offsets (where the filter author would have to specify what those parameters/offsets are) would probably be ideal, but it seems like a lot of effort to implement that,

Thu, Nov 19, 10:55 PM · AbuseFilter
Tgr added a project to T268207: mediawiki/core composer error: "The requested package monolog/monolog ^1.22 exists as monolog/monolog[2.0.2] but these are rejected by your constraint.": MediaWiki-Vagrant.

This is caused by Vagrant; I'll fix that. That said, a quick search gives these extensions/libraries which depend on Monolog 1:

  • DonationInterface
  • GoogleLogin
  • MachineVision
  • Shellbox
Thu, Nov 19, 6:19 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, MediaWiki-Vagrant, MediaWiki-General, Composer
Tgr updated subscribers of T268207: mediawiki/core composer error: "The requested package monolog/monolog ^1.22 exists as monolog/monolog[2.0.2] but these are rejected by your constraint.".
Thu, Nov 19, 6:15 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, MediaWiki-Vagrant, MediaWiki-General, Composer
Tgr updated the task description for T268207: mediawiki/core composer error: "The requested package monolog/monolog ^1.22 exists as monolog/monolog[2.0.2] but these are rejected by your constraint.".
Thu, Nov 19, 6:15 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, MediaWiki-Vagrant, MediaWiki-General, Composer
Tgr updated the task description for T268207: mediawiki/core composer error: "The requested package monolog/monolog ^1.22 exists as monolog/monolog[2.0.2] but these are rejected by your constraint.".
Thu, Nov 19, 6:14 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, MediaWiki-Vagrant, MediaWiki-General, Composer
Tgr created T268207: mediawiki/core composer error: "The requested package monolog/monolog ^1.22 exists as monolog/monolog[2.0.2] but these are rejected by your constraint.".
Thu, Nov 19, 6:07 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Patch-For-Review, MediaWiki-Vagrant, MediaWiki-General, Composer

Wed, Nov 18

Tgr added a comment to T268119: Gerrit: remote unpack failed: Missing tree / blob.

I did not enable the v2 protocol.

Wed, Nov 18, 10:37 PM · Release-Engineering-Team (Development services), Gerrit
Tgr added a comment to P13327 Image dumping ground.

Wed, Nov 18, 10:07 AM
Tgr created P13327 Image dumping ground.
Wed, Nov 18, 10:07 AM
Tgr created T268119: Gerrit: remote unpack failed: Missing tree / blob.
Wed, Nov 18, 9:31 AM · Release-Engineering-Team (Development services), Gerrit
Tgr added a comment to T263184: 1.36.0-wmf.18 deployment blockers.

We found the underlying issue (it was specific to the extension) so the logspam will be fixed soon.

Wed, Nov 18, 7:04 AM · Patch-For-Review, Release-Engineering-Team-TODO, Release, Train Deployments
Tgr added a comment to T268008: Argument 2 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must be of the type array, null given, called in /srv/mediawiki/php-1.36.0-wmf.16/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/NewcomerTasksCacheRefreshJob.php on line 35.

Change 641586 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fix NewcomerTasksCacheRefreshJob

https://gerrit.wikimedia.org/r/641586

Wed, Nov 18, 7:02 AM · MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), Platform Team Workboards (Clinic Duty Team), MediaWiki-JobQueue, GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint), Wikimedia-production-error
Tgr added a comment to T268008: Argument 2 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must be of the type array, null given, called in /srv/mediawiki/php-1.36.0-wmf.16/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/NewcomerTasksCacheRefreshJob.php on line 35.

@Pchelolo I apologize for the false alarm; the error was in the extension code after all. The Job contract that we broke is IMO rather obscure, I added two patches that hopefully clarify it.

Wed, Nov 18, 6:57 AM · MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), Platform Team Workboards (Clinic Duty Team), MediaWiki-JobQueue, GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint), Wikimedia-production-error
Tgr moved T268012: Call to a member function getDifficulty() on null from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Nov 18, 1:11 AM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint), Wikimedia-production-error
Tgr moved T268015: PHP Notice: Undefined index: society from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, Nov 18, 1:11 AM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint), Wikimedia-production-error

Tue, Nov 17

Tgr added a comment to T268008: Argument 2 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must be of the type array, null given, called in /srv/mediawiki/php-1.36.0-wmf.16/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/NewcomerTasksCacheRefreshJob.php on line 35.

It gets scheduled on cache misses, and the cache expires in a week. It also gets stale if the user changes filter settings, but it seems implausible that that would happen a few thousand times a week.

Tue, Nov 17, 11:51 PM · MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), Platform Team Workboards (Clinic Duty Team), MediaWiki-JobQueue, GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint), Wikimedia-production-error
Tgr added a comment to T263184: 1.36.0-wmf.18 deployment blockers.

@dancy the patch attached to that task would fix the problem, I think (cc @Tgr and @Catrope to review) but it seems like a bigger problem with the job queue infrastructure, not specific to that particular job.

Tue, Nov 17, 11:07 PM · Patch-For-Review, Release-Engineering-Team-TODO, Release, Train Deployments
Tgr added a comment to T268008: Argument 2 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must be of the type array, null given, called in /srv/mediawiki/php-1.36.0-wmf.16/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/NewcomerTasksCacheRefreshJob.php on line 35.

Not that I know of or have seen this before, but it's not entirely impossible that empty array, being falsy, would get somehow replaced with null over the course of json serialization/deserialization rounds...

Tue, Nov 17, 10:48 PM · MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), Platform Team Workboards (Clinic Duty Team), MediaWiki-JobQueue, GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint), Wikimedia-production-error
Tgr added a comment to T268008: Argument 2 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\CacheDecorator::suggest() must be of the type array, null given, called in /srv/mediawiki/php-1.36.0-wmf.16/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/NewcomerTasksCacheRefreshJob.php on line 35.

This is happening about 1000 times an hour, which is a pretty crazy rate for a job that's supposed to run once a week for opted-in users on select wikis only.

Tue, Nov 17, 8:32 PM · MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), Platform Team Workboards (Clinic Duty Team), MediaWiki-JobQueue, GrowthExperiments-NewcomerTasks, Growth-Team (Current Sprint), Wikimedia-production-error