Tgr (Gergő Tisza)
Software Engineer, WMF Reading

Projects (26)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 4:55 PM (139 w, 5 d)
Availability
Available
IRC Nick
tgr
LDAP User
Gergő Tisza
MediaWiki User
Tgr (WMF)

Recent Activity

Yesterday

Tgr added a project to T162181: Should we add psy/psysh to wmf vendor repo for use on WMF servers?: Security-Reviews.
Tue, May 23, 7:37 PM · Security-Reviews, Patch-For-Review, Wikimedia-General-or-Unknown, MediaWiki-Vendor
Tgr added a comment to T163272: [Spike] Determine changes necessary for concatenation support .

Concatenation is not particularly hard after or before the PDF conversion, either. PDF outlines could also be added by a separate tool (although it is a bit of a pain). Adding page numbers to the TOC is not possible without dedicated functionality in the converter tool though (target-counter() from CSS3 Generated Content for Paged Media could do it but it is not supported by any browser at this time).

Tue, May 23, 1:45 PM · Reading-Infrastructure-Team-Backlog (Kanban), Reading-Web-Kanban-Board, Reading-Web-Backlog
Tgr added a comment to T163434: Librarize TestingAccessWrapper.

Relevant patchsets which were not tagged with this task:

Tue, May 23, 8:54 AM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), MW-1.28-release-notes, MW-1.27-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Librarization
Tgr closed T163434: Librarize TestingAccessWrapper as "Resolved".

All merged except [https://gerrit.wikimedia.org/r/#/c/349092/ DonationInterface] which is related to fundraising and those extensions have their own release cadence. We can call this done.

Tue, May 23, 8:50 AM · MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), MW-1.28-release-notes, MW-1.27-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Librarization
Tgr committed rEWOP526b0f6ef32a: Create extension files (authored by Tgr).
Create extension files
Tue, May 23, 8:47 AM

Mon, May 22

Tgr added a comment to T114384: Standardise procedures for deprecating public-facing code.

What if Release-Engineering-Team would have veto power for any API breaks that haven't been properly announced, both to developers via deprecation flags and to the wider communities via tech News etc?

Mon, May 22, 1:57 PM · Release-Engineering-Team (Watching / External), WMF-Product-Development-Process, Architecture, MediaWiki-API, Developer-Relations, User-notice
Tgr added a comment to T141482: CentralAuth login attempt gives "No active login attempt is in progress for your session".

Note that the bug description basically amounts to "central login is not working". (Which is fair; CentralAuth is super complicated, and finding out exactly what is failing is probably the bigger part of the work. But saying "wiki X is also affected by this" as if there was a single issue affecting all WMF and non-WMF wikis, and everything could be fixed with the same debugging effort, is potentially misleading.) I don't think this task will move forward unless there is a wiki owner who can reliably reproduce the issue and is willing to do a serious amount of debugging.

Mon, May 22, 1:54 PM · MediaWiki-Authentication-and-authorization, MediaWiki-extensions-CentralAuth
GitHub <noreply@github.com> committed R1912:763eb460915f: Merge 72651d0c9b108d723786c91aaee4ee64c8ca1e73 into… (authored by Tgr).
Merge 72651d0c9b108d723786c91aaee4ee64c8ca1e73 into…
Mon, May 22, 11:43 AM
Tgr added a comment to T153256: Unable to overwrite services using MediaWikiServices hook.

So in general the order of things is:

  • extensions which do not use extension registration add their MediaWikiServices hooks
  • loadFromQueue runs, container gets created, those hooks run
  • extensions which use extension registration add their hooks
  • resetGlobalServices runs, all hooks run but those redefining a service have no effect since old service definitions override new ones.

Also, in theory some extension entry point could get the container singleton and thus trigger hook execution, somewhere halfway in the process of LocalSettings.php executing the non-extension-registration entry points.

Mon, May 22, 12:57 AM · User-Daniel, User-Nikerabbit, MediaWiki-General-or-Unknown

Sun, May 21

Tgr committed rEWOP593efb05c76a: Create extension files (authored by Tgr).
Create extension files
Sun, May 21, 11:11 PM
Tgr added a comment to T153256: Unable to overwrite services using MediaWikiServices hook.

MediaWikiServices::importWiring does what it says in the docs. I think the problem is that the first version of the container is set up in ExtensionRegistry::loadFromQueue before hooks have been exported. MediaWikiServices::resetGlobalServices then replaces it with a new object, and even though the MediaWikiServices hook does get called for that new object, the updated service definition gets overwritten by the new one that is copied over from the early container.

Sun, May 21, 4:35 PM · User-Daniel, User-Nikerabbit, MediaWiki-General-or-Unknown
Tgr created T166020: No exception displayed with action=render.
Sun, May 21, 4:26 PM · MediaWiki-Debug-Logger
Tgr added a comment to T152540: Migrate to HTML5 section ids.

It does work, but it's not valid per the spec. We can ignore that, but is there a good reason to? In wikilinks space and underscore is interchangeable so users might even expect that to continue.

Sun, May 21, 8:05 AM · Community-Wishlist-Survey-2016, Community-Tech, ContentTranslation, MediaWiki-Parser, Parsoid, Parsing-Team

Sat, May 20

Tgr added a comment to T152540: Migrate to HTML5 section ids.

The "html5" flavour means that the ID is completely unaltered.

Sat, May 20, 7:53 PM · Community-Wishlist-Survey-2016, Community-Tech, ContentTranslation, MediaWiki-Parser, Parsoid, Parsing-Team
Tgr edited the description of T160680: Improve OAuth log messages.
Sat, May 20, 5:58 PM · MediaWiki-extensions-OAuth
Tgr added a comment to T165209: Watchstar feature broken: Tapping the watchlist star while logged in results in "mobile-frontend-watchlist-error" popup message.

How probable is session loss right after a fresh login?

Sat, May 20, 9:07 AM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Unplanned-Sprint-Work, Reading-Web-Kanban-Board, MediaWiki-Watchlist, Reading-Web-Backlog
Tgr added a comment to T121995: Switch FlaggedRevs on Hungarian Wikipedia to a "flagged protection" mode.

My quick impression is that the consensus was just to make FlaggedRevs be "for informational purposes" as in Russian Wikipedia and others, but I've not reviewed the discussion extensively.

Sat, May 20, 7:41 AM · Patch-For-Review, Wikimedia-Site-requests, MediaWiki-extensions-FlaggedRevs

Fri, May 19

Tgr added a comment to T165209: Watchstar feature broken: Tapping the watchlist star while logged in results in "mobile-frontend-watchlist-error" popup message.

If the error is with the token specifically (and I have not verified that), then session loss is the most likely cause (since tokens are stored in the session). Feel free to ping me if you can reproduce the error and need help with debugging.

Fri, May 19, 10:25 AM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Unplanned-Sprint-Work, Reading-Web-Kanban-Board, MediaWiki-Watchlist, Reading-Web-Backlog
Tgr closed T164590: Specific image not displayed (in IE) as "Invalid".

So yes, your DNS server refuses to look up the IP belonging to upload.wikimedia.org. That's either a very severe misconfiguration, or (more likely) intentional filtering. Either way, you will have to take it up with the local sysadmins.

Fri, May 19, 10:22 AM · MediaWiki-extensions-MultimediaViewer

Thu, May 18

Tgr added a comment to T164590: Specific image not displayed (in IE).

That sounds like you are behind a firewall that messes with DNS lookups. Can you check what is output by the command nslookup upload.wikimedia.org?

Thu, May 18, 8:32 PM · MediaWiki-extensions-MultimediaViewer
Florian awarded T165540: Add CODE_OF_CONDUCT.md to Wikimedia projects a Yellow Medal token.
Thu, May 18, 11:32 AM · Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
Ladsgroup awarded T165540: Add CODE_OF_CONDUCT.md to Wikimedia projects a Love token.
Thu, May 18, 10:33 AM · Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
01tonythomas awarded T165540: Add CODE_OF_CONDUCT.md to Wikimedia projects a Yellow Medal token.
Thu, May 18, 10:17 AM · Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
greg awarded T165540: Add CODE_OF_CONDUCT.md to Wikimedia projects a Love token.
Thu, May 18, 10:17 AM · Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
Aklapper awarded T159788: Establish OAuth app policy for Wikimedia wikis a Love token.
Thu, May 18, 8:17 AM · MediaWiki-extensions-OAuth

Wed, May 17

Tgr added a comment to T163272: [Spike] Determine changes necessary for concatenation support .

Does not require another service to be created, can be used on third-party wikis with no support for node services.

Wed, May 17, 7:33 PM · Reading-Infrastructure-Team-Backlog (Kanban), Reading-Web-Kanban-Board, Reading-Web-Backlog
Tgr added a comment to T163272: [Spike] Determine changes necessary for concatenation support .

Re: performance, do we expect concatenated HTML to be exposed directly to users in some use cases? Do we expect HTML concatenation to be slower than or comparable to HTML -> PDF transform? If we expect neither then choosing the concatenation tool based on performance is probably not a useful optimization.

Wed, May 17, 8:50 AM · Reading-Infrastructure-Team-Backlog (Kanban), Reading-Web-Kanban-Board, Reading-Web-Backlog
Amire80 awarded T165540: Add CODE_OF_CONDUCT.md to Wikimedia projects a Like token.
Wed, May 17, 6:44 AM · Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations

Tue, May 16

Tgr added a project to T164990: RfC: Reading List service: ArchCom-RfC.
Tue, May 16, 11:29 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr edited the description of T164990: RfC: Reading List service.
Tue, May 16, 11:28 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr renamed T164990: RfC: Reading List service from "[DRAFT] RfC: Reading List service" to "RfC: Reading List service".
Tue, May 16, 11:27 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr added a comment to T164990: RfC: Reading List service.

Thanks for the feedback @jcrespo! I think it will be simpler if we go through the RfC first (so we get clarity in the MediaWiki vs RESTBase question) and then Reading management can choose between reducing scale or planning the new servers into the budget.

Tue, May 16, 11:27 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr edited the description of T164990: RfC: Reading List service.
Tue, May 16, 11:21 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr updated subscribers of T165540: Add CODE_OF_CONDUCT.md to Wikimedia projects.

(credits go to @NHarateh_WMF for spotting that link)

Tue, May 16, 9:48 PM · Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
Tgr created T165540: Add CODE_OF_CONDUCT.md to Wikimedia projects.
Tue, May 16, 9:47 PM · Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
Tgr created T165487: Could not find link to Sauce Labs job URL.
Tue, May 16, 12:23 PM · Release-Engineering-Team (Backlog), Browser-Tests-Infrastructure
Tgr added a comment to T107707: Login alert when user logs in from new machine.

The announcement says

This extension does not give you notifications when somebody successfully logs into your account from an unknown device or IP. It is technically possible to generate those, but if somebody else has logged in, they could just as easily see those notifications and do a password reset (which the notification encourages you to do). The ideal way to handle this is to issue email notifications for this case, but since most Wikipedia accounts do not have emails associated with them, this wouldn't be useful to majority of the users. So for the time being, we have settled for not issuing these notifications.

Tue, May 16, 12:21 PM · Community-Tech, Security-Core, MediaWiki-User-login-and-signup
Tgr added a comment to T165455: Go from "E" to "A+" on Securityheaders.io.

How would the third-party ensure the view is unauthenticated? Extra url parameter?

Tue, May 16, 12:04 PM · Wikimedia-General-or-Unknown, Security
Tgr updated subscribers of T165472: CheckUser shows IP instead of account name on account creation.
Tue, May 16, 11:40 AM · CheckUser
Tgr updated subscribers of T165472: CheckUser shows IP instead of account name on account creation.

The text I see is

(Logs) . . <time> . . <username> (talk | contribs | block) was created
    IP: ...
(Logs) . . <time> . . <username> (talk | contribs | block) User account <IP> was created
    IP: ...

The "was created" line (checkuser-create-action) is from the LocalUserCreated hook. The other line (logentry-newusers-create) is from the RecentChange_save hook and created via LogFormatter::newFromRow( $rc->getAttributes() ) from the recentchanges entry. The RC row has the correct user ID and name. The CU row ends up with the IP instead of the username.

Tue, May 16, 11:38 AM · CheckUser
Tgr created T165472: CheckUser shows IP instead of account name on account creation.
Tue, May 16, 10:17 AM · CheckUser
Tgr added a comment to T165455: Go from "E" to "A+" on Securityheaders.io.

We emit X-Frame-Options: DENY on all "sensitive" pages (pretty much everything that displays a form, e.g. action=edit or special pages). We probably can't do that on all pages (neither DENY nor SAMEORIGIN), since various community tools rely on including pages from Wikimedia wikis in frames (for example, Wikidata Game: https://tools.wmflabs.org/wikidata-game/#mode=commonscat).

Tue, May 16, 10:15 AM · Wikimedia-General-or-Unknown, Security
Tgr added a parent task for T165459: Warn about the possibility of owner-only consumers on action=login: T142282: Improve consumer registration experience for bot owners (owner-only consumers).
Tue, May 16, 8:44 AM · MediaWiki-API, MediaWiki-extensions-OAuth
Tgr added a subtask for T142282: Improve consumer registration experience for bot owners (owner-only consumers): T165459: Warn about the possibility of owner-only consumers on action=login.
Tue, May 16, 8:44 AM · MediaWiki-extensions-OAuth, Epic
Tgr created T165459: Warn about the possibility of owner-only consumers on action=login.
Tue, May 16, 8:44 AM · MediaWiki-API, MediaWiki-extensions-OAuth

Mon, May 15

Tgr added a comment to T165209: Watchstar feature broken: Tapping the watchlist star while logged in results in "mobile-frontend-watchlist-error" popup message.

Session loss, maybe?

Mon, May 15, 7:44 PM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Unplanned-Sprint-Work, Reading-Web-Kanban-Board, MediaWiki-Watchlist, Reading-Web-Backlog
Tgr updated subscribers of T157384: Document zerowiki setup better.

Thanks! @Mholloway any thoughts?

Mon, May 15, 7:44 PM · Documentation, Zero
Tgr added a comment to T165209: Watchstar feature broken: Tapping the watchlist star while logged in results in "mobile-frontend-watchlist-error" popup message.

Per the watch API doc you need A "watch" token retrieved from action=query&meta=tokens. So the patch above was wrong.

Mon, May 15, 7:13 PM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), Unplanned-Sprint-Work, Reading-Web-Kanban-Board, MediaWiki-Watchlist, Reading-Web-Backlog
Tgr edited the description of T164990: RfC: Reading List service.
Mon, May 15, 2:50 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr lowered the priority of T165115: action=mobileview sections delivering a div of class "mw-parser-output" without a matching closing div from "Unbreak Now!" to "High".
Mon, May 15, 2:44 PM · Patch-For-Review, Reading-Web-Backlog, Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, Android-app-Bugs, Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Wikipedia-Android-App-Backlog, MobileFrontend
Tgr added a comment to T165115: action=mobileview sections delivering a div of class "mw-parser-output" without a matching closing div.

https://gerrit.wikimedia.org/r/#/c/353566/ still has to be merged, right? And possibly the mobileview API cache needs to be purged or split as well.

Mon, May 15, 2:04 PM · Patch-For-Review, Reading-Web-Backlog, Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, Android-app-Bugs, Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Wikipedia-Android-App-Backlog, MobileFrontend
Tgr added a comment to T164990: RfC: Reading List service.

I meant global watchlists. I assume that has to involve the recentchanges table somehow, since you need a join between those two tables to display a Special:Watchlist-style change list.

Mon, May 15, 1:55 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr added a comment to T164805: Investigate requirements for MySQL access in RESTBase.

Come to think of it, MySQL access in RESTBase will be necessary anyway for push notifications, right?

Mon, May 15, 1:46 PM · Reading-Infrastructure-Team-Backlog (Kanban), User-mobrovac, Services (watching), Reading List Service, DBA, RESTBase
Tgr added a comment to T164990: RfC: Reading List service.

@jcrespo FWIW there is another related project with cross-wiki storage needs: T163116: Decide on persistence backend and location for the Push Notification Service

Mon, May 15, 12:48 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr edited the description of T164990: RfC: Reading List service.
Mon, May 15, 12:40 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr edited the description of T164990: RfC: Reading List service.
Mon, May 15, 12:40 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr added a comment to T164990: RfC: Reading List service.

(denormalized for the benefit of the /pages/ route) - int or bigint 4 or 8 bytes (not sure what you mean with denormalized, please clarify)

Mon, May 15, 12:24 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr added a comment to T165132: action=edit in URL doesn't load OWE when NWE is enabled.

Would it possible to keep the OWE accessible somehow? NWE has enough rough edges that I need to switch back all the time (especially on wikis with Translate).

Mon, May 15, 10:22 AM · Regression, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Tgr added a comment to T159788: Establish OAuth app policy for Wikimedia wikis.

Created OAuth app guidelines and an RfC about it.

Mon, May 15, 10:15 AM · MediaWiki-extensions-OAuth
Tgr added a parent task for T159789: Include information about OAuth app review process and criteria into the interface: T103587: Improve OAuth application approval workflow.
Mon, May 15, 10:13 AM · MediaWiki-extensions-OAuth
Tgr added a subtask for T103587: Improve OAuth application approval workflow: T159789: Include information about OAuth app review process and criteria into the interface.
Mon, May 15, 10:13 AM · Epic, MediaWiki-extensions-OAuth
Tgr edited the description of T159789: Include information about OAuth app review process and criteria into the interface.
Mon, May 15, 10:12 AM · MediaWiki-extensions-OAuth
Tgr added a comment to T164990: RfC: Reading List service.

That seems excessive. The pagelinks table on enwiki alone has 1B rows. There are only 30M enwiki users, most of them inactive, most of the active ones probably won't use this feature, and if Android users are any indication, there will be <100 list entries per user.

Mon, May 15, 9:36 AM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr edited the description of T164990: RfC: Reading List service.
Mon, May 15, 9:16 AM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service

Sun, May 14

Tgr closed T159790: Rewrite OAuth developer documentation page on mediawiki.org as "Resolved".

Done. Rewrote the developer docs and touched lightly the user docs, disambig page, extension page, owner-only docs.

Sun, May 14, 5:36 PM · Documentation, MediaWiki-extensions-OAuth

Sat, May 13

Framawiki awarded T142279: Simplify OAuth registration form for owner-only consumers a Love token.
Sat, May 13, 4:44 PM · MediaWiki-extensions-OAuth
Framawiki awarded T165219: Templates for owner-only OAuth consumers a Love token.
Sat, May 13, 4:43 PM · MediaWiki-extensions-OAuth
Tgr added a subtask for T142282: Improve consumer registration experience for bot owners (owner-only consumers): T165219: Templates for owner-only OAuth consumers.
Sat, May 13, 9:56 AM · MediaWiki-extensions-OAuth, Epic
Tgr added a parent task for T165219: Templates for owner-only OAuth consumers: T142282: Improve consumer registration experience for bot owners (owner-only consumers).
Sat, May 13, 9:56 AM · MediaWiki-extensions-OAuth
Tgr created T165219: Templates for owner-only OAuth consumers.
Sat, May 13, 9:55 AM · MediaWiki-extensions-OAuth
Tgr created T165217: HTMLCheckMatrix cannot be preloaded.
Sat, May 13, 8:58 AM · MediaWiki-HTMLForm
Tgr added a comment to T165132: action=edit in URL doesn't load OWE when NWE is enabled.

Typo, yes. The link in T165146 still does not work for me.

Sat, May 13, 8:03 AM · Regression, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Fri, May 12

Tgr added a comment to T165115: action=mobileview sections delivering a div of class "mw-parser-output" without a matching closing div.

Not sure if I understand how ParserCache works but it seems like ApiMobileView::getData calling ParserCache::getKey will result in this change getting ignored (at least for the duration of mobileview API result caching) as that seems to only take into account the parser options which had a non-default value when the page was last saved, so updating the wrapper parser option inside the API does not break the cache.

Fri, May 12, 5:45 PM · Patch-For-Review, Reading-Web-Backlog, Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, Android-app-Bugs, Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Wikipedia-Android-App-Backlog, MobileFrontend
Tgr added a comment to T165115: action=mobileview sections delivering a div of class "mw-parser-output" without a matching closing div.

All that seems to be happening here is that, originally, the section transformation was made inside the <body> tag, then at the end MobileFormatter::getText() unwrapped it. d154fa36b5c3
changed the transformation to happen inside <div class="mw-parser-output"> instead but nothing removes that element. MobileFormatter::getText() should just be updated to do it.

Fri, May 12, 4:59 PM · Patch-For-Review, Reading-Web-Backlog, Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, Android-app-Bugs, Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Wikipedia-Android-App-Backlog, MobileFrontend
Tgr added a comment to T165115: action=mobileview sections delivering a div of class "mw-parser-output" without a matching closing div.

Here is a minimal reproduction of the issue:

tgr@terbium:~$ mwscript eval.php --wiki=enwiki
Fri, May 12, 4:36 PM · Patch-For-Review, Reading-Web-Backlog, Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, Android-app-Bugs, Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Wikipedia-Android-App-Backlog, MobileFrontend
Tgr added a comment to T165115: action=mobileview sections delivering a div of class "mw-parser-output" without a matching closing div.

Action API responses are not cached unless you use the smaxage parameter. (In general you can avoid Varnish by using the X-Wikimedia-Debug header; there are browser plugins to do that.)

Fri, May 12, 3:59 PM · Patch-For-Review, Reading-Web-Backlog, Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, Android-app-Bugs, Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Wikipedia-Android-App-Backlog, MobileFrontend
Tgr added a comment to T156500: Document extensions' MediaWiki version compatibility better.

Added the compatibility policy parameter (doc, template, templatedoc, backlog). Time to update your extensions!

Fri, May 12, 1:13 PM · User-Tgr, MediaWiki-Stakeholders-Group, Documentation, Developer-Wishlist (2017)
Tgr added a comment to T165132: action=edit in URL doesn't load OWE when NWE is enabled.

Note that the source edit tab still links to ?veaction=sourceedit but that parameter does not do anything now.

Fri, May 12, 12:20 PM · Regression, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Tgr added a comment to T165146: veaction=editsource in the URL should load new wikitext editor.

On the other hand action=edit does load it, which did not happen in the past... (which makes the old editor inaccessible, which forces me to opt out of beta since NWE is too bug to always rely on, especially on translated pages).

Fri, May 12, 11:21 AM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), User-Ryasmeen, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Tgr created T165146: veaction=editsource in the URL should load new wikitext editor.
Fri, May 12, 11:19 AM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), User-Ryasmeen, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Tgr merged T28746: Document all caches and how to clear them into T156693: Complete documentation about different types of caching for extension developers.
Fri, May 12, 11:08 AM · MediaWiki-extensions-General, Documentation, MediaWiki-Documentation, Developer-Wishlist (2017)
Tgr merged task T28746: Document all caches and how to clear them into T156693: Complete documentation about different types of caching for extension developers.
Fri, May 12, 11:08 AM · Documentation, MediaWiki-Documentation
Tgr added a comment to T157384: Document zerowiki setup better.

Created doc page on wikitech, needs review.

Fri, May 12, 10:47 AM · Documentation, Zero
Tgr added a comment to T157757: Multiple MediaWiki hooks are not documented on mediawiki.org.

TBH this feels like a waste of manpower to me. hooks.txt is easily parsable so this can be automated (see T155029 for plans), we have plenty of other tasks which do require manual effort.

Fri, May 12, 10:41 AM · MediaWiki-Parser, MediaWiki-ContentHandler, MediaWiki-extensions-Scribunto, Analytics-EventLogging, Analytics, Collaboration-Team-Triage, Notifications, MediaWiki-Documentation, Documentation
Tgr created T165114: Evaluate search options for Reading List service.
Fri, May 12, 12:15 AM · Reading-Infrastructure-Team-Backlog, Reading List Service

Thu, May 11

Tgr added a comment to T153595: Unapproved article version shown in mobile apps.

Clients should also be prepared to handle thumbnail URLs which refer to some non-current version of the image (see also T66214#3256693). Presumably that's not happening right now due to this bug.

Thu, May 11, 8:13 PM · Services (next), RESTBase-API, RESTBase, Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, iOS-app-Bugs, Android-app-Bugs, Wikipedia-iOS-App-Backlog, MediaWiki-extensions-FlaggedRevs, Wikipedia-Android-App-Backlog
Tgr added a comment to T66214: Define an official thumb API.

We'll also need a way to display old versions of images. Clients can encounter old versions without expecting to due to FlaggedRevs hiding unreviewed image changes.

Thu, May 11, 8:10 PM · Reading Epics (Thumbnails), Services (next), ArchCom-Has-shepherd, RfC, Traffic, Operations, Services-next, ArchCom-RfC, Zero, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Reading-Admin, Commons, Performance-Team, Epic, RESTBase-API, Parsoid, Performance, Multimedia, MediaWiki-File-management
Tgr added a comment to T153595: Unapproved article version shown in mobile apps.

Note that users should be able to navigate to both versions of the article, it's just that anons vs. logged-in users should get a different version by default.

Thu, May 11, 8:07 PM · Services (next), RESTBase-API, RESTBase, Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, iOS-app-Bugs, Android-app-Bugs, Wikipedia-iOS-App-Backlog, MediaWiki-extensions-FlaggedRevs, Wikipedia-Android-App-Backlog
Tgr edited the description of T164990: RfC: Reading List service.
Thu, May 11, 5:45 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr updated subscribers of T164990: RfC: Reading List service.

@jcrespo could you give the Data storage section a look?

Thu, May 11, 3:00 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr added a comment to T164188: Check caching headers in ORES responses.

There are, very roughly, two mechanisms parties communicating via HTTP use for caching. The server can tell the client how long the reponse is valid, and then the client can just skip further requests for that time, and use a local copy of the data instead. That is maximally effective (there is no remote communication at all) but the server must know in advance that the data will not change. Alternatively, the client (which has a local copy of past data but no guarantee that it is still valid) can tell the server what version of the data it has, and the server can then either respond with "that is still good" (and skip processing and keep data transfer minimal) or send a more recent version of the data.

Thu, May 11, 2:55 PM · Scoring-platform-team-Backlog, ORES
Tgr edited the description of T164990: RfC: Reading List service.
Thu, May 11, 1:33 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr added a comment to T164291: Make title-related properties consistent.

Personally I find it most useful to have the prefixed database key e.g. 'Talk:Barack Obama' and the display title "Barack Obama". You can safely split the string of the database key on ':' to get the namespace.

Thu, May 11, 8:33 AM · Reading-Infrastructure-Team-Backlog, RESTBase-API, Services (designing)

Wed, May 10

Tgr moved T163272: [Spike] Determine changes necessary for concatenation support from To Do to Doing on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Wed, May 10, 9:25 PM · Reading-Infrastructure-Team-Backlog (Kanban), Reading-Web-Kanban-Board, Reading-Web-Backlog
Tgr moved T163272: [Spike] Determine changes necessary for concatenation support from Tracking to Kanban on the Reading-Infrastructure-Team-Backlog board.
Wed, May 10, 9:25 PM · Reading-Infrastructure-Team-Backlog (Kanban), Reading-Web-Kanban-Board, Reading-Web-Backlog
Tgr closed T164808: Compare sortkeys vs. linked lists for Reading List API providing sorting features as "Resolved".

Thanks. The first option seems simple enough, and avoiding premature optimization is good advice. I am going with that for now; we can discuss more in the RfC (T164990).

Wed, May 10, 8:55 PM · Reading-Infrastructure-Team-Backlog (Kanban), User-mobrovac, Services (watching), Reading List Service
Tgr moved T164990: RfC: Reading List service from To Do to Doing on the Reading-Infrastructure-Team-Backlog (Kanban) board.
Wed, May 10, 8:54 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr claimed T164990: RfC: Reading List service.
Wed, May 10, 8:54 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr moved T164990: RfC: Reading List service from Needs triage to Kanban on the Reading-Infrastructure-Team-Backlog board.
Wed, May 10, 8:53 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service
Tgr edited the description of T164990: RfC: Reading List service.
Wed, May 10, 8:52 PM · ArchCom-RfC, Reading Epics (Synchronized Reading Lists), RESTBase-API, Services (designing), User-mobrovac, Reading-Infrastructure-Team-Backlog (Kanban), Reading List Service