Page MenuHomePhabricator

Tgr (Gergő Tisza)
Software Engineer, WMF

Projects (46)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 4:55 PM (269 w, 4 d)
Availability
Available
IRC Nick
tgr
LDAP User
Gergő Tisza
MediaWiki User
Tgr (WMF) [ Global Accounts ]

Things my team is working on: Growth-Team (kanban board)
Side projects I am working on (or planning to, eventually): User-Tgr
You can find more info about me on my user page.

Recent Activity

Today

Tgr added a comment to T238178: Newcomer tasks: pageview count not appearing or inconsistent.

This is some kind of PageViewInfo bug that's somehow related to API continuation (continuation is incorrectly triggered in the pageviewinfo module, even for very small result sets like 10 pages).
I can look into it tomorrow, or we could hack around it temporarily by using pageviews data from the RESTBase/PCS summary endpoint instead.

Wed, Nov 20, 5:20 AM · Growth-Team (Current Sprint), NewcomerTasks 1.0
Tgr added a comment to T238322: Newcomer tasks: pageview info doesn't fit article card.

Also, we use raw numbers here, right? That could be up to 9 characters (million + two separators) for very popular pages.

Wed, Nov 20, 4:57 AM · User-PPham, NewcomerTasks 1.0 , Growth-Team (Current Sprint)
Tgr added a comment to T236050: Newcomer tasks: Footer for suggested edits module.

Ehhh right, that works for pageviews but not for uniques. I should probably recondsider that.

Wed, Nov 20, 3:46 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage
Tgr added a comment to T236050: Newcomer tasks: Footer for suggested edits module.

I didn't bother adding monthly metrics support to PageViewInfo because that's just daily data summed up in batches of 30 (or it can be aligned to calendar months if someone particularly cares; in any case, monthly data is contained in daily data). For hourly, I just doubted there'd be much need for it.

Wed, Nov 20, 3:30 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage
Tgr updated the task description for T208369: Welcome survey: anonymize data after one year.
Wed, Nov 20, 3:18 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Product-Analytics, Growth-Team (Current Sprint)
Tgr updated the task description for T208369: Welcome survey: anonymize data after one year.
Wed, Nov 20, 3:17 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Product-Analytics, Growth-Team (Current Sprint)
Tgr moved T208369: Welcome survey: anonymize data after one year from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Wed, Nov 20, 3:17 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Product-Analytics, Growth-Team (Current Sprint)
Tgr changed Due Date from Tue, Nov 19, 8:00 AM to Tue, Dec 3, 8:00 AM on T208369: Welcome survey: anonymize data after one year.
Wed, Nov 20, 3:17 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Product-Analytics, Growth-Team (Current Sprint)
Tgr moved T232513: Newcomer tasks: homepage changes based on initiation (mobile) from Ready for Development to Code Review on the Growth-Team (Current Sprint) board.
Wed, Nov 20, 3:05 AM · Patch-For-Review, NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage
Tgr added a comment to T238164: Newcomer tasks: mobile TaskExplanationWidget should be bottom sheet.

@RHo Kosta pointed out elsewhere that the design is similar to the drawer component of MobileFrontend, but when the MF drawer is open, the rest of the page is dimmed (and inaccessible) but in the mockup here the top navigation bar is still accessible. Would it be OK to use the standard drawer UX? Dimming only parts of the page might be complicated even if we use a custom component, and it would be nice to avoid the code duplication.

Wed, Nov 20, 2:36 AM · Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage
Tgr updated subscribers of T238716: HTML for newly-created pages with VE on testwiki not stored in RESTBase.

Ping @ssastry - this is on testwiki probably fairly recent so Parsoid-PHP seems like the most plausible culprit.

Wed, Nov 20, 1:58 AM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, VisualEditor
Tgr updated the task description for T238716: HTML for newly-created pages with VE on testwiki not stored in RESTBase.
Wed, Nov 20, 1:58 AM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, VisualEditor
Tgr created T238716: HTML for newly-created pages with VE on testwiki not stored in RESTBase.
Wed, Nov 20, 1:53 AM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, VisualEditor

Yesterday

Tgr added a comment to T222983: reviewer-bot sometimes not working.

Thanks a lot!

Tue, Nov 19, 9:47 PM · Gerrit
Tgr added a comment to T237084: Newcomer tasks: fix result interleaving.

We discussed this in the standup, but for the record, the code should alternate exactly, if it doesn't, that's a bug; but given that loading the next card can be slow and the navigation arrows are not disabled while the card loads, it's currently easy to accidentally skip tasks.
(Also, for now we filter out protected pages on the client side, so whenever that happens, there will be a gap, ie A followed by C. But that should be rare, affected something like 1% of the tasks in my tests. Eventually we'll probably move filtering to the server side and the issue will disappear, but it's considered low priority.)

Tue, Nov 19, 9:38 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Growth-Team (Current Sprint), NewcomerTasks 1.0
Tgr claimed T238037: Newcomer tasks: on mobile 'Suggested edits' activation will flash 'Start here' module and Homepage.

The steps are:

  1. user starts off at #/homepage/start, clicking on the Done button of the intro overlay (screenshot [1])
  2. dialog closes, exposing the start module detail view (without suggested edits) (screenshot [2], first flash)
  3. page reloads and at the same time navigates to #/homepage/suggested-edits
  4. while the JS spins up, user sees the server-side rendered page (fragment URL gets ignored), which is like #2 but with the suggested edits related changes (one less start module sub-item etc) (screenshot [3], second flash)
  5. JS overlays the suggested edits overlay, which is in the server-side rendered HTML but hidden by default (third flash)
  6. suggested edits overlay loads the first task suggestion card (fourth "flash" although this one is less jarring)
Tue, Nov 19, 9:28 AM · Growth-Team (Current Sprint), NewcomerTasks 1.0 , GrowthExperiments-Homepage
Tgr added a comment to T238179: Newcomer tasks: get rid of reload after suggested edits initiation.

I think the architectural constraints are:

  • we don't want to maintain the HTML structure in two different places (both client and server side)
  • we don't want to keep that structure in different places for different modules
  • we don't want to move it to the client side for all modules (eventually, maybe, but not now)
Tue, Nov 19, 9:11 AM · NewcomerTasks Future Release , Growth-Team, GrowthExperiments-Homepage
Tgr added a comment to T217867: Port domino (or another spec-compliant DOM library) to PHP.

Well, it looks like PHP 8 is anticipated in Q4 2020-Q1 2021, if they follow the release process.

Tue, Nov 19, 6:57 AM · Parsoid-PHP
Tgr updated the task description for T208369: Welcome survey: anonymize data after one year.
Tue, Nov 19, 3:52 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Product-Analytics, Growth-Team (Current Sprint)
Tgr added a comment to T208369: Welcome survey: anonymize data after one year.

I will wait a day just in case something went wrong, then repeat with kowiki.

Tue, Nov 19, 3:52 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Product-Analytics, Growth-Team (Current Sprint)
Tgr updated the task description for T208369: Welcome survey: anonymize data after one year.
Tue, Nov 19, 3:04 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Product-Analytics, Growth-Team (Current Sprint)
Tgr added a comment to T208369: Welcome survey: anonymize data after one year.

Dry run:

1$ for wiki in arwiki cswiki euwiki kowiki testwiki viwiki; do echo -e "== $wiki ==\n"; mwscript extensions/GrowthExperiments/maintenance/deleteOldSurveys.php $wiki --cutoff 350 --dry-run; echo -e "\n\n"; done
2
3== arwiki ==
4
5Deleting data before 20181204025146 (over 350 days old) (dry run)
6Processed users up to ID 1612656
7Deleted: 0, skipped: 0
8
9
10
11== cswiki ==
12
13Deleting data before 20181204025147 (over 350 days old) (dry run)
14Processed users up to ID 435266
15Deleted: 750, skipped: 8
16
17
18
19== euwiki ==
20
21Deleting data before 20181204025148 (over 350 days old) (dry run)
22Processed users up to ID 104292
23Deleted: 0, skipped: 0
24
25
26
27== kowiki ==
28
29Deleting data before 20181204025148 (over 350 days old) (dry run)
30Processed users up to ID 541632
31Deleted: 901, skipped: 2
32
33
34
35== testwiki ==
36
37Deleting data before 20181204025150 (over 350 days old) (dry run)
38Processed users up to ID 41572
39Deleted: 4, skipped: 5
40
41
42
43== viwiki ==
44
45Deleting data before 20181204025150 (over 350 days old) (dry run)
46Processed users up to ID 645792
47Deleted: 0, skipped: 1

Tue, Nov 19, 3:03 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Product-Analytics, Growth-Team (Current Sprint)
Tgr created P9660 GrowthExperiments/deleteOldSurveys.php --dry-run.
Tue, Nov 19, 2:53 AM
Tgr changed the status of T222983: reviewer-bot sometimes not working from Stalled to Open.

Seems to be defunct most of the time these days. E.g. notifications for GrowthExperiments pretty consistently don't work, none of the core patches I checked work...

Tue, Nov 19, 2:07 AM · Gerrit
Tgr edited Description on GerritBot.
Tue, Nov 19, 2:03 AM

Mon, Nov 18

Tgr moved T237084: Newcomer tasks: fix result interleaving from Ready for Development to Code Review on the Growth-Team (Current Sprint) board.
Mon, Nov 18, 11:25 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Growth-Team (Current Sprint), NewcomerTasks 1.0
Tgr added a comment to T217867: Port domino (or another spec-compliant DOM library) to PHP.

A PHP RFC has been accepted to implement the WHATWG Living Standard DOM as an extension in PHP 8.0.

Mon, Nov 18, 6:12 AM · Parsoid-PHP

Sun, Nov 17

ToBeFree awarded T230425: Page creation log should not display the content of deleted pages a Like token.
Sun, Nov 17, 1:51 AM · Performance-Team (Radar), Anti-Harassment, MediaWiki-Logging

Fri, Nov 15

Tgr added a comment to T216308: RFC Process: 2019 amendments (also: Wikimedia Technical Conference 2019 - Unconference).
Fri, Nov 15, 4:05 AM · Wikimedia-Technical-Conference-2019, TechCom-RFC, TechCom
Tgr added a comment to T228759: Merge the Phabricator Priority values "Low" and "Lowest".

I'd prefer to rename lowest to later

Every task is later than now (as long as you cannot travel back in time). My immediate thought would be "Later than what?" And there is no "sooner" priority.

Fri, Nov 15, 4:04 AM · Phabricator

Wed, Nov 13

Tgr updated the task description for T234654: Wikimedia Technical Conference 2019 Session: Componentization and sharing with the open source community.
Wed, Nov 13, 10:48 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
Tgr updated Tgr.
Wed, Nov 13, 10:43 PM
Tgr added a comment to T234634: Wikimedia Technical Conference 2019 Session: On-wiki documentation & documentation as code: strengths, weaknesses, and compromises.

One cluster of things that seems like low hanging fruit (useful and easy to do without dedicated staff time) is conventions for Gerrit / wiki sync:

  • Introduce a norm of linking to all affected documentation pages from gerrit changesets
  • Have a maintenance template for tracking pages which will be affected by a pending patch
    • Maybe make a parser function for telling whether a patch is still pending (more effort but still not crazy to have it as community-maintained code)
    • alternatively as a poor man's version use Tool-extjsonuploader and Lua tables for syncing that data
Wed, Nov 13, 10:42 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019

Mon, Nov 11

Tgr committed rGRBDfed4888f44d9: Add cswiki to beta env (authored by Tgr).
Add cswiki to beta env
Mon, Nov 11, 12:12 PM
Tgr added a comment to T236499: Pulling Vagrant up in Cloud VPS on buster fails with apparmor preventing the mount.

Yes but I don't know if I have restarted the vagrant box since then, and apart from the error during vagrant up I never saw any obvious effect in the first place. vagrant reload does work fine now.

Mon, Nov 11, 3:47 AM · Cloud-VPS, MediaWiki-Vagrant

Sun, Nov 10

Tgr added a comment to T234654: Wikimedia Technical Conference 2019 Session: Componentization and sharing with the open source community.

Librarization spreads code across various repositories and increases overhead:

Sun, Nov 10, 10:09 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
Tgr added a comment to T224487: Make RESTBase take full request template for Parsoid requests.

I thought Parsoid/PHP is not using RESTBase?

Sun, Nov 10, 10:01 PM · CPT Initiatives (Parsoid REST API in PHP (CDP2)), RESTBase
Tgr added a comment to T237885: Wikispore analytics.

Turns out HitCounters works fine despite the warning.

Sun, Nov 10, 9:30 PM · Patch-For-Review, Wikispore
Tgr added a comment to T237885: Wikispore analytics.

Matomo has a manual web-based installer and doesn't really support automated installs (that's in their paid version AIUI). In theory it's not super hard, just generate a config file and set up the database (they don't provide an SQL file or anything, but we can just snapshot the result of the manual setup I guess).

Sun, Nov 10, 9:10 PM · Patch-For-Review, Wikispore
Tgr closed T237860: MediaWiki-Vagrant: Operation not permitted @ chmod_internal - /srv/mediawiki-vagrant/cache/apt/partial as Resolved.

Fixed via sudo chown -R mwvagrant:wikidev cache/ (outside vagrant). No idea what caused it; oh well.

Sun, Nov 10, 9:06 PM · MediaWiki-Vagrant
Tgr created T237885: Wikispore analytics.
Sun, Nov 10, 8:19 PM · Patch-For-Review, Wikispore
Tgr added a comment to T237863: Cloud VPS proxies should handle subdomains.

We'd need some mechanism for it to be creating *.<yourname>.wmflabs.org certs for each one (right now everything is just on one big *.wmflabs.org cert which wouldn't match this), which would require some ACME automation we don't have at the moment.

Sun, Nov 10, 7:24 PM · Cloud-VPS, MediaWiki-Vagrant
Tgr created T237863: Cloud VPS proxies should handle subdomains.
Sun, Nov 10, 4:53 PM · Cloud-VPS, MediaWiki-Vagrant
Tgr updated the task description for T237860: MediaWiki-Vagrant: Operation not permitted @ chmod_internal - /srv/mediawiki-vagrant/cache/apt/partial.
Sun, Nov 10, 4:34 PM · MediaWiki-Vagrant
Tgr created T237860: MediaWiki-Vagrant: Operation not permitted @ chmod_internal - /srv/mediawiki-vagrant/cache/apt/partial.
Sun, Nov 10, 4:33 PM · MediaWiki-Vagrant
Tgr added a subtask for T231899: Wikidata property: T231903: Reasonator integration.
Sun, Nov 10, 4:40 AM · Wikispore
Tgr added a parent task for T231903: Reasonator integration: T231899: Wikidata property.
Sun, Nov 10, 4:40 AM · Wikispore
Tgr closed T231898: Namespaces configuration as Resolved.
Sun, Nov 10, 4:39 AM · Wikispore

Sat, Nov 9

Tgr added a comment to T231904: Wikidata templates.

Wikispore does not run on the normal Wikimedia infrastructure.

Sat, Nov 9, 11:26 PM · Wikispore
Tgr created T237821: Automate resetting the test Wikispore wiki.
Sat, Nov 9, 6:28 PM · Wikispore
Tgr created T237820: Set up automated backups on Wikispore.
Sat, Nov 9, 6:27 PM · Wikispore
Tgr added a comment to T231897: Wikibase install.

Note that this probably involves a lot more than just installing the Wikibase extension; we want to be able to be a client of wikidata.org, but currently Wikibase Client does not support repositories which it does not have direct database access to. T209880: [Investigation - 8h] technical overview of current db based Wikibase federation & blockers to get to an API based federation has some information on the topic.

Sat, Nov 9, 6:20 PM · Wikispore
Tgr added a comment to T237819: Install VisualEditor and Citoid on Wikispore.

The first attempt at this failed: wikispore-test has VE but existing content is not preserved (probably RESTBase is broken).
Vagrant seems to be in the middle of a Node migration (for some value of migration: some roles refuse to work without Node 10, some are still on Node 6; cf. T217113: MediaWiki-Vagrant should use the same Node.js version as Wikimedia production) which is probably one of the issues (maybe *the* issue).

Sat, Nov 9, 6:14 PM · Wikispore
Tgr updated the task description for T231911: Basic configuration for Wikispore.
Sat, Nov 9, 6:11 PM · Wikispore
Tgr updated the task description for T231911: Basic configuration for Wikispore.
Sat, Nov 9, 6:11 PM · Wikispore
Tgr created T237819: Install VisualEditor and Citoid on Wikispore.
Sat, Nov 9, 6:11 PM · Wikispore
Tgr added a comment to T229746: Enable OAuth registration with a Wikimedia account on Wikidocumentaries wiki.

Our plan to do the same for Wikispore is to use the OAuthAuthentication extension (T110460: Update OAuthAuthentication to use AuthManager needs to be finished first). Depending on how much of T197969: User registration tasks you want to coexist with OAuth-based identities, that might or might not be the right solution for you.

Sat, Nov 9, 6:02 PM · Wikidocumentaries
Tgr removed a parent task for T110460: Update OAuthAuthentication to use AuthManager: T229746: Enable OAuth registration with a Wikimedia account on Wikidocumentaries wiki.
Sat, Nov 9, 6:00 PM · Wikispore, User-Tgr, Patch-For-Review, MediaWiki-extensions-OAuthAuthentication, MediaWiki-Authentication-and-authorization
Tgr removed a subtask for T229746: Enable OAuth registration with a Wikimedia account on Wikidocumentaries wiki: T110460: Update OAuthAuthentication to use AuthManager.
Sat, Nov 9, 6:00 PM · Wikidocumentaries
Tgr added a parent task for T110460: Update OAuthAuthentication to use AuthManager: T229746: Enable OAuth registration with a Wikimedia account on Wikidocumentaries wiki.
Sat, Nov 9, 5:57 PM · Wikispore, User-Tgr, Patch-For-Review, MediaWiki-extensions-OAuthAuthentication, MediaWiki-Authentication-and-authorization
Tgr added a subtask for T229746: Enable OAuth registration with a Wikimedia account on Wikidocumentaries wiki: T110460: Update OAuthAuthentication to use AuthManager.
Sat, Nov 9, 5:57 PM · Wikidocumentaries
Tgr edited Description on Wikispore.
Sat, Nov 9, 5:47 PM
Tgr added a comment to T210230: MediaWiki tasks.

Seems like there's a lot of overlap with the Wikispore project! We should talk some time.

Sat, Nov 9, 5:44 PM · Wikidocumentaries
Tgr added a comment to T230558: Knowledge crystal: using Wikibase for structured discussion.

An example in English (and screenshots for posteriority): https://dev.tietokide.fi/?Q10

Sat, Nov 9, 5:32 PM · Wikimania-Hackathon-2019
Tgr added a comment to T198322: Archive the PubSubHubbub extension.

I note Extension:PubSubHubbubSubscriber was not archived; is that meaningful on its own?

Sat, Nov 9, 5:25 PM · User-MarcoAurelio, MediaWiki-extensions-PubSubHubbub, GitHub-Mirrors, Repository-Admins, Cleanup
Tgr added a comment to T231904: Wikidata templates.

I think in this task we are looking for a template that links to a wikidata page given as a parameter, not one that pulls data from a linked Wikidata item (Wikispore is not yet set up to do that, and I don't think Wikidata even supports it currently).

Sat, Nov 9, 5:17 PM · Wikispore
Tgr created T237815: Configure interwiki map.
Sat, Nov 9, 4:43 PM · Wikispore
Tgr added a comment to T231903: Reasonator integration.

This is blocked on T231899: Wikidata property, right?

Sat, Nov 9, 4:40 PM · Wikispore
Tgr updated the task description for T231911: Basic configuration for Wikispore.
Sat, Nov 9, 4:36 PM · Wikispore
Tgr moved T110460: Update OAuthAuthentication to use AuthManager from Backlog to Next-up on the Wikispore board.
Sat, Nov 9, 4:34 PM · Wikispore, User-Tgr, Patch-For-Review, MediaWiki-extensions-OAuthAuthentication, MediaWiki-Authentication-and-authorization
Tgr added a project to T237770: GlobalUserPage should not require the global wiki to be in the same database cluster: Wikispore.
Sat, Nov 9, 4:34 PM · Wikispore, GlobalUserPage
Tgr added a project to T110460: Update OAuthAuthentication to use AuthManager: Wikispore.
Sat, Nov 9, 4:34 PM · Wikispore, User-Tgr, Patch-For-Review, MediaWiki-extensions-OAuthAuthentication, MediaWiki-Authentication-and-authorization
Tgr moved T231989: Wikispore on Interwiki map from Backlog to Next-up on the Wikispore board.
Sat, Nov 9, 4:33 PM · Wikispore
Tgr added a comment to T231899: Wikidata property.

No property yet, but there's an item: Q67605965

Sat, Nov 9, 4:32 PM · Wikispore
Tgr added a comment to T231989: Wikispore on Interwiki map.

Proposal is at https://meta.wikimedia.org/wiki/Talk:Interwiki_map#Wikispore.

Sat, Nov 9, 4:30 PM · Wikispore
Tgr closed T231896: MediaWiki-Vagrant install as Resolved.

We have a [https://gerrit.wikimedia.org/r/c/mediawiki/vagrant/+/546156 Vagrant customization], a runbook for using it and two wikis (wikispore and wikispore-test) running on it. Marking as done.

Sat, Nov 9, 4:28 PM · Wikispore
Tgr closed T231896: MediaWiki-Vagrant install, a subtask of T231911: Basic configuration for Wikispore, as Resolved.
Sat, Nov 9, 4:28 PM · Wikispore
Tgr added a comment to T231898: Namespaces configuration.

SpecialNamespaces has been installed, and we have a runbook on how to use it. Can we resolve this task or should we keep it for tracking actually adding some namespaces?

Sat, Nov 9, 4:25 PM · Wikispore
Tgr added a subtask for T231908: Integrate Wikispore with SUL: T237770: GlobalUserPage should not require the global wiki to be in the same database cluster.
Sat, Nov 9, 3:48 PM · Wikispore
Tgr added a parent task for T237770: GlobalUserPage should not require the global wiki to be in the same database cluster: T231908: Integrate Wikispore with SUL.
Sat, Nov 9, 3:48 PM · Wikispore, GlobalUserPage

Fri, Nov 8

Tgr awarded T229934: Enable semantic relationship between code review changesets and maniphest tasks in phabricator a Love token.
Fri, Nov 8, 9:46 PM · GerritBot, Phabricator, Code-Review-Workgroup
Tgr created T237770: GlobalUserPage should not require the global wiki to be in the same database cluster.
Fri, Nov 8, 9:33 PM · Wikispore, GlobalUserPage
Tgr closed T237742: MediaWiki-Vagrant: git-review install/upgrade fails with TypeError: unsupported operand type(s) for -=: 'Retry' and 'int' as Invalid.

A vagrant reload made the error go away. Oh well. A mystery for another day.

Fri, Nov 8, 4:39 PM · MediaWiki-Vagrant
Tgr updated the task description for T237742: MediaWiki-Vagrant: git-review install/upgrade fails with TypeError: unsupported operand type(s) for -=: 'Retry' and 'int'.
Fri, Nov 8, 4:12 PM · MediaWiki-Vagrant
Tgr created T237742: MediaWiki-Vagrant: git-review install/upgrade fails with TypeError: unsupported operand type(s) for -=: 'Retry' and 'int'.
Fri, Nov 8, 4:11 PM · MediaWiki-Vagrant

Thu, Nov 7

Tgr added a comment to T236050: Newcomer tasks: Footer for suggested edits module.

I can replace B with billion etc, I'm sure that will be weird in some languages but still less bad than hardcoding.

Thu, Nov 7, 10:52 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, NewcomerTasks 1.0 , Growth-Team (Current Sprint), GrowthExperiments-Homepage
Tgr added a comment to T237301: Newcomer tasks: fix and migrate JSON config pages.

JSON pages can be edited by sysops and interface editors as well, so in that case we should have a task about restricting it.

Thu, Nov 7, 10:49 AM · Growth-Team, NewcomerTasks 1.0
Tgr renamed T224375: REST API Developer declares JSON validation parameters from API Developer declares JSON validation parameters to REST API Developer declares JSON validation parameters.
Thu, Nov 7, 12:32 AM · Core Platform Team Workboards (Green), Story, CPT Initiatives (Parsoid REST API in PHP (CDP2)), MediaWiki-REST-API
Tgr renamed T221162: System Adminstrator limits rate of MediaWiki REST API calls per client from System Adminstrator limits rate of API calls per client to System Adminstrator limits rate of MediaWiki REST API calls per client.
Thu, Nov 7, 12:32 AM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP), MediaWiki-REST-API
Tgr renamed T221167: REST API Client Developer uses Gzip content encoding from Client Developer uses Gzip content encoding to REST API Client Developer uses Gzip content encoding.
Thu, Nov 7, 12:31 AM · CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (User Stories), MediaWiki-REST-API

Wed, Nov 6

Tgr renamed T221742: REST API Sandbox in MediaWiki from API Sandbox in MediaWiki to REST API Sandbox in MediaWiki.
Wed, Nov 6, 9:30 PM · CPT Initiatives (Parsoid REST API in PHP (CDP2)), MediaWiki-REST-API, Services (watching)
Tgr updated subscribers of T237490: Collect feedback from module and gadget authors for Developer Productivity & onwiki tooling techconf session.

Apologies for mass-subscribing you; the name list is a combination of database queries for the most prolific gadget and module editors, and personal recollections about who had good insights about the topic. We would really value your feedback for TechConf 2019 in how the people working on developer productivity could help you with making your gadget or Lua module development work more productive. If you are not interested, I apologize for the spam, feel free to unsubscribe. (In case you are less familiar with Phabricator: the unsubscribe link is in the right-hand sidebar column.) If you are interested, please see the description of this task for the feedback format. (We are very interested in any other feedback too, but would like to have a uniform set of responses that the conference participants can work with.)

Wed, Nov 6, 2:50 AM · Wikimedia-Technical-Conference-2019
Tgr added a comment to T234661: Wikimedia Technical Conference 2019 Session: Developer Productivity & onwiki tooling.

I created a subtask for collecting the answers (hopefully helps with reducing the comment notification spam in both directions): T237490: Collect feedback from module and gadget authors for Developer Productivity & onwiki tooling techconf session

Wed, Nov 6, 2:32 AM · International-Developer-Events, Wikimedia-Technical-Conference-2019
Tgr created T237490: Collect feedback from module and gadget authors for Developer Productivity & onwiki tooling techconf session.
Wed, Nov 6, 2:31 AM · Wikimedia-Technical-Conference-2019
Tgr added a comment to T237347: [betalabs] Newcomer tasks - discrepancy in the counter .

Eventually should probably move protected status check to the server side (and ideally to ElasticSearch).
In the short term, probably just fetch 250 tasks and use the extra 50 as a reserve to replace protected articles?

Wed, Nov 6, 1:58 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Growth-Team (Current Sprint), NewcomerTasks 1.0
Tgr added a comment to T208369: Welcome survey: anonymize data after one year.
tgr@mwmaint1002:~$ mwscript extensions/GrowthExperiments/maintenance/deleteOldSurveys.php testwiki --cutoff 350 --verbose --dry-run
Deleting data before 20181121014408 (over 350 days old) (dry run)
  Skipping user:27425, past-cutoff survey submit date 20190607131714
  Skipping user:29950, past-cutoff survey submit date 20190724014701
  Skipping user:30833, past-cutoff survey submit date 20190918212454
  Skipping user:39901, past-cutoff survey submit date 20190607172958
  Skipping user:40269, past-cutoff survey submit date 20190709193716
  Deleting survey data for user:41446
  Deleting survey data for user:41447
  Deleting survey data for user:41448
  Deleting survey data for user:41449
  Deleting survey data for user:41450
  Deleting survey data for user:41462
  Stopping at user:41467 which has past-cutoff registration date 20181121105317
Processed users up to ID 41467
Deleted: 6, skipped: 5
27425 -> Etonkovidova
29950 -> Zilant18
30833 -> Zilant1
39901 -> MMiller (WMF)
40269 -> KHarlan (WMF)
41446 -> Zilant22
41446 -> Zilant22
41447 -> Roantest44
41448 -> Zilant23
41449 -> Jindrat
41450 -> Jindrad
41462 -> Nov-20-2018-test-account-to-suppress

That seems reasonable.

Wed, Nov 6, 1:49 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Product-Analytics, Growth-Team (Current Sprint)
Tgr added a comment to T121470: Central Global Repository for Templates, Lua modules, and Gadgets.

Well, a bot has been written with very much the same mindset.

Wed, Nov 6, 1:08 AM · Crosswiki, Language-strategy, Core Platform Team Legacy (Watching / External), Community-Tech (2015-2017), Epic, Wikimedia-General-or-Unknown, Phlogiston-Category, Community-Wishlist-Survey-2015
Tgr added a comment to T237140: Newcomer tasks module setup is not complete for kowiki betalabs .

Pageview counts are not displayed, even though that should work in theory. Something to look into eventually, but very minor.

Wed, Nov 6, 1:02 AM · NewcomerTasks 1.0 , Growth-Team
Tgr added a comment to T235717: Newcomer tasks: non-HTTP-based ConfigurationLoader and TaskSuggester.

Also, URLs have been added recently to the config; make sure those are safe.

Wed, Nov 6, 12:19 AM · NewcomerTasks Future Release , Growth-Team (Current Sprint), Patch-For-Review, Technical-Debt
Tgr closed T237140: Newcomer tasks module setup is not complete for kowiki betalabs , a subtask of T237301: Newcomer tasks: fix and migrate JSON config pages, as Resolved.
Wed, Nov 6, 12:18 AM · Growth-Team, NewcomerTasks 1.0