Page MenuHomePhabricator

Tgr (Gergő Tisza)
Software Engineer, WMF

Today

  • No visible events.

Tomorrow

  • No visible events.

Sunday

  • No visible events.

User Details

User Since
Sep 19 2014, 4:55 PM (629 w, 6 d)
Availability
Available
IRC Nick
tgr
LDAP User
Gergő Tisza
MediaWiki User
Tgr (WMF) [ Global Accounts ]

Things my team is working on: MediaWiki-Core-Platform-Team
Side projects I am working on (or planning to, eventually): User-Tgr
You can find more info about me on my user page.

Recent Activity

Yesterday

Tgr added a comment to T441262: Add a gu_touched field to the globaluser table for use with global preferences.

Depending on whether you also need to unlink users who have recently unset the preference, either setting wikimedia-donor to a timestamp rather than a boolean, or having a separate wikimedia-donor-last-touched field seems like the easiest way of keeping track of the time.

Thu, Oct 15, 2:19 PM · MediaWiki-Core-Platform-Team (Radar), MediaWiki-extensions-CentralAuth, MediaWiki-extensions-GlobalPreferences, FY26-27 WE5.4 Donor Identification and recognition
Tgr added a comment to T440873: Enable $wgOAuth2ClientCredentialsOwnerAuthCutover on Wikimedia wikis.

Communication:

Thu, Oct 15, 1:00 PM · MediaWiki-Core-Platform-Team (Kanban), User-notice, MediaWiki-extensions-OAuth
Tgr added a parent task for T440806: OAuth allows creating OAuth 2 client with empty callback URL, presents it confusingly: T420297: Allow OAuth 2 apps using client credentials flow to perform actions as the app's owner (i.e. be logged in).
Thu, Oct 15, 6:57 AM · Patch-For-Review, MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-OAuth
Tgr added a subtask for T420297: Allow OAuth 2 apps using client credentials flow to perform actions as the app's owner (i.e. be logged in): T440806: OAuth allows creating OAuth 2 client with empty callback URL, presents it confusingly.
Thu, Oct 15, 6:57 AM · MediaWiki-Core-Platform-Team, MediaWiki-extensions-OAuth
Tgr added a comment to T440873: Enable $wgOAuth2ClientCredentialsOwnerAuthCutover on Wikimedia wikis.

Hello @Tgr @Vesperio_ofc, responding to the usernotice tag. How will this be worded? Also are we featuring this in this week's tech news?

Thu, Oct 15, 6:56 AM · MediaWiki-Core-Platform-Team (Kanban), User-notice, MediaWiki-extensions-OAuth

Tue, Oct 13

Tgr added a comment to T440914: MediaWiki periodic job startupregistrystats failed.

This is the only thing in the job output that seems like an error:

arwiki Unknown component: ext.cite.visualEditor, ext.cite.wikiEditor, ext.cite.community-configuration-autoname, ext.cite.referencePreviews, ext.confirmEdit.CaptchaWidget, ext.confirmEdit.hCaptcha, ext.confirmEdit.hCaptcha.styles, ext.confirmEdit.hCaptcha.gradeC, ext.globalCssJs.user, ext.globalCssJs.user.styles, ext.wikimediaMessages.ipInfo.hooks, ext.abuseFilter.ace, ext.visualEditor.editCheck.checks, ext.wikimediaEvents.visualEditor, mw.cx.externalmessages, ext.checkUser.tempAccountOnboarding, ext.checkUser.ipInfo.hooks, ext.checkUser.suggestedInvestigations, ext.quicksurveys.survey.ReadingLists.beta.feature.survey, ext.quicksurveys.survey.Automatic.Translation.Feedback, mediawiki.messagePoster
Tue, Oct 13, 5:13 PM · MediaWiki-Core-Platform-Team (Kanban)
Tgr added a comment to T440997: Testwiki does not accept any anonymous edits: Could not establish an active session.

The new MediaWiki version is on group 0, but the authevents Logstash channel is sampled 1:1000 and has no group0 temp account creation events from the last day at all, and the Prometheus metric is not split by wiki (it made the dashboard slow to the point of uselessness). So I'm not sure there's a good way to assess impact other than waiting for the group 1 deployment, unless we can identify some non-sampled log event that would accompany the error.

Tue, Oct 13, 4:28 PM · Patch-For-Review, MediaWiki-Core-Platform-Team, MediaWiki-extensions-CentralAuth
Tgr added a comment to T440997: Testwiki does not accept any anonymous edits: Could not establish an active session.

Also a request ID would be useful.

Tue, Oct 13, 4:19 PM · Patch-For-Review, MediaWiki-Core-Platform-Team, MediaWiki-extensions-CentralAuth
Tgr added a comment to T440997: Testwiki does not accept any anonymous edits: Could not establish an active session.

If you can still reproduce, what's the chain of top-level HTTP requests / redirects?

Tue, Oct 13, 4:14 PM · Patch-For-Review, MediaWiki-Core-Platform-Team, MediaWiki-extensions-CentralAuth
Tgr added a comment to T440997: Testwiki does not accept any anonymous edits: Could not establish an active session.

Works for me on Chrome 154.0.8037.92 / Ubuntu in incognito mode. The browser is not redirected to the central domain though, and ends up with no central cookies. As far as I can see, that's a JS issue (the VE could should handle the redirect).

Tue, Oct 13, 4:13 PM · Patch-For-Review, MediaWiki-Core-Platform-Team, MediaWiki-extensions-CentralAuth
Tgr added a subtask for T438220: 1.47.0-wmf.24 deployment blockers: T440997: Testwiki does not accept any anonymous edits: Could not establish an active session.
Tue, Oct 13, 4:08 PM · User-brennen, Release-Engineering-Team (Priority Backlog 📥), Essential-Work, Release, Train Deployments
Tgr added a parent task for T440997: Testwiki does not accept any anonymous edits: Could not establish an active session: T438220: 1.47.0-wmf.24 deployment blockers.
Tue, Oct 13, 4:08 PM · Patch-For-Review, MediaWiki-Core-Platform-Team, MediaWiki-extensions-CentralAuth
Tgr added a comment to T440997: Testwiki does not accept any anonymous edits: Could not establish an active session.

Probably a train blocker?

Tue, Oct 13, 4:08 PM · Patch-For-Review, MediaWiki-Core-Platform-Team, MediaWiki-extensions-CentralAuth
Tgr added a comment to T440997: Testwiki does not accept any anonymous edits: Could not establish an active session.

Those seem like two very different errors.

Tue, Oct 13, 4:07 PM · Patch-For-Review, MediaWiki-Core-Platform-Team, MediaWiki-extensions-CentralAuth

Mon, Oct 12

Tgr added a comment to T411826: MediaWiki periodic job centralauth-backfilllocalaccounts.php-loginwiki failed.

Still (or again?) happening. Should be fixed (well, ignored) by T432613: backfilLocalAccounts.php should not send alerts when the account is blocked though.

Mon, Oct 12, 5:00 PM · MediaWiki-Core-Platform-Team
Tgr merged T439456: MediaWiki periodic job centralauth-backfilllocalaccounts.php-loginwiki failed into T411826: MediaWiki periodic job centralauth-backfilllocalaccounts.php-loginwiki failed.
Mon, Oct 12, 4:58 PM · MediaWiki-Core-Platform-Team
Tgr merged task T439456: MediaWiki periodic job centralauth-backfilllocalaccounts.php-loginwiki failed into T411826: MediaWiki periodic job centralauth-backfilllocalaccounts.php-loginwiki failed.
Mon, Oct 12, 4:58 PM · MediaWiki-Core-Platform-Team (Kanban)
Tgr added a comment to T439456: MediaWiki periodic job centralauth-backfilllocalaccounts.php-loginwiki failed.
extensions/CentralAuth/maintenance/backfillLocalAccounts.php: Finished run
  autoCreateUser failed for Marmelade1964:
  Error: '''Your IP address is in a range that has been [[m:Special:MyLanguage/Global blocks|blocked on all Wikimedia Foundation wikis]].'''
Mon, Oct 12, 4:58 PM · MediaWiki-Core-Platform-Team (Kanban)
Tgr closed T412052: MediaWiki periodic job centralauth-backfilllocalaccounts.php-metawiki failed as Resolved.

Mesh timeout was updated in T390972: Restart CronJobs on failure of the service mesh, this can probably be closed now.

Mon, Oct 12, 4:53 PM · MediaWiki-Core-Platform-Team
Tgr closed T410764: MediaWiki periodic job startupregistrystats-mediawikiwiki failed, a subtask of T412052: MediaWiki periodic job centralauth-backfilllocalaccounts.php-metawiki failed, as Resolved.
Mon, Oct 12, 4:53 PM · MediaWiki-Core-Platform-Team
Tgr closed T410764: MediaWiki periodic job startupregistrystats-mediawikiwiki failed, a subtask of T411654: MediaWiki periodic job startupregistrystats failed, as Resolved.
Mon, Oct 12, 4:53 PM · MediaWiki-Core-Platform-Team
Tgr closed T410764: MediaWiki periodic job startupregistrystats-mediawikiwiki failed, a subtask of T412469: MediaWiki periodic job startupregistrystats-testwiki failed, as Resolved.
Mon, Oct 12, 4:53 PM · MediaWiki-Core-Platform-Team
Tgr closed T410764: MediaWiki periodic job startupregistrystats-mediawikiwiki failed as Resolved.

Mesh timeout was updated in T390972: Restart CronJobs on failure of the service mesh, this can probably be closed now.

Mon, Oct 12, 4:53 PM · MediaWiki-Core-Platform-Team, SRE Observability, serviceops-deprecated
Tgr closed T412469: MediaWiki periodic job startupregistrystats-testwiki failed as Resolved.

Mesh timeout was updated in T390972: Restart CronJobs on failure of the service mesh, this can probably be closed now.

Mon, Oct 12, 4:52 PM · MediaWiki-Core-Platform-Team
Tgr closed T411654: MediaWiki periodic job startupregistrystats failed as Resolved.

Mesh timeout was updated in T390972: Restart CronJobs on failure of the service mesh, this can probably be closed now.

Mon, Oct 12, 4:52 PM · MediaWiki-Core-Platform-Team
Tgr created T440902: Elevated central login badtoken errors since wmf22 group2 deployment.
Mon, Oct 12, 4:43 PM · MediaWiki-Core-Platform-Team (Kanban), Wikimedia-production-error, MediaWiki-extensions-CentralAuth
Tgr created T440899: "LogicException: Unattached user at end of login" during SUL3 login to foundationwiki.
Mon, Oct 12, 4:33 PM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-CentralAuth, Wikimedia-production-error
Tgr added a comment to T439451: Strings within CSS attribute selectors get minified when they shouldn't.

This is a documented limitation of the minifier; similar changes have been rejected in the past to keep the code simpler (T37492: CSSMin::minify should not interfere with string values). Is there a real-world use case this bug is interfering with? The example in the task description is not something I'd expect to see in real code - it's brittle and there are almost certainly better ways to target a given hidden div.

Mon, Oct 12, 3:36 PM · MediaWiki-Core-Platform-Team, Wikimedia-Minify
Tgr added a comment to T432072: Notifications becoming highlighted randomly.

To clarify, when you say "old notifications become re-highlighted", you don't mean individual notifications (as in the number on the icon changing, or the blue dot reappearing in the upper right corner of a notification entry in the dropdown) but rather one of the menu icons becoming re-highlighted (going from gray to red/blue), right?

Mon, Oct 12, 2:45 PM · MediaWiki-Core-Platform-Team (Kanban), Notifications (Echo)
Tgr added a parent task for T440873: Enable $wgOAuth2ClientCredentialsOwnerAuthCutover on Wikimedia wikis: T420297: Allow OAuth 2 apps using client credentials flow to perform actions as the app's owner (i.e. be logged in).
Mon, Oct 12, 12:56 PM · MediaWiki-Core-Platform-Team (Kanban), User-notice, MediaWiki-extensions-OAuth
Tgr added a subtask for T420297: Allow OAuth 2 apps using client credentials flow to perform actions as the app's owner (i.e. be logged in): T440873: Enable $wgOAuth2ClientCredentialsOwnerAuthCutover on Wikimedia wikis.
Mon, Oct 12, 12:56 PM · MediaWiki-Core-Platform-Team, MediaWiki-extensions-OAuth
Tgr created T440873: Enable $wgOAuth2ClientCredentialsOwnerAuthCutover on Wikimedia wikis.
Mon, Oct 12, 12:55 PM · MediaWiki-Core-Platform-Team (Kanban), User-notice, MediaWiki-extensions-OAuth
Tgr renamed T440867: Make new OAuth 2 client-credentials apps authenticated by default (set $wgOAuth2ClientCredentialsOwnerAuthCutover default-on) from Make OAuth 2 client-credentials apps authenticated by default to Make new OAuth 2 client-credentials apps authenticated by default (set $wgOAuth2ClientCredentialsOwnerAuthCutover default-on).
Mon, Oct 12, 12:54 PM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-OAuth
Tgr added a comment to T420297: Allow OAuth 2 apps using client credentials flow to perform actions as the app's owner (i.e. be logged in).

Naming isn't the main problem. In any case let's continue this thread in a dedicated task -> T440867: Make new OAuth 2 client-credentials apps authenticated by default (set $wgOAuth2ClientCredentialsOwnerAuthCutover default-on)

Mon, Oct 12, 12:52 PM · MediaWiki-Core-Platform-Team, MediaWiki-extensions-OAuth
Tgr added a subtask for T420297: Allow OAuth 2 apps using client credentials flow to perform actions as the app's owner (i.e. be logged in): T440867: Make new OAuth 2 client-credentials apps authenticated by default (set $wgOAuth2ClientCredentialsOwnerAuthCutover default-on).
Mon, Oct 12, 12:51 PM · MediaWiki-Core-Platform-Team, MediaWiki-extensions-OAuth
Tgr added a parent task for T440867: Make new OAuth 2 client-credentials apps authenticated by default (set $wgOAuth2ClientCredentialsOwnerAuthCutover default-on): T420297: Allow OAuth 2 apps using client credentials flow to perform actions as the app's owner (i.e. be logged in).
Mon, Oct 12, 12:51 PM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-OAuth
Tgr created T440867: Make new OAuth 2 client-credentials apps authenticated by default (set $wgOAuth2ClientCredentialsOwnerAuthCutover default-on).
Mon, Oct 12, 11:53 AM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-OAuth
Tgr added a comment to T437078: ActionEntryPointTest::testMainPageIsDomainRoot failure with CentralAuth: Invalid wiki ID: my_wiki-unittest_.

WikiMap has changed recently, we should check whether this will be still an issue after T440863: Remove most uses of MockWikiMapTrait-

Mon, Oct 12, 11:47 AM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-CentralAuth
Tgr added a project to T440863: Remove most uses of MockWikiMapTrait: MediaWiki-Core-Platform-Team.

(Tagging as MediaWiki-Core-Platform-Team as we created the mock mainly for CentralAuth.)

Mon, Oct 12, 11:46 AM · MediaWiki-Core-Platform-Team (Kanban), Developer Productivity, MediaWiki-Core-Tests
Tgr created T440863: Remove most uses of MockWikiMapTrait.
Mon, Oct 12, 11:45 AM · MediaWiki-Core-Platform-Team (Kanban), Developer Productivity, MediaWiki-Core-Tests
Tgr added a comment to T440806: OAuth allows creating OAuth 2 client with empty callback URL, presents it confusingly.

We since a few days ago now not setting callback URLs on owner-only and client-credentials apps since they have no purpose, but yeah it should be displayed in a more meaningful way (probably by just hiding the whole field). If you are seeing it on an app with auth code grant or an OAuth 1 app, that's a bug in app validation.

Mon, Oct 12, 11:29 AM · Patch-For-Review, MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-OAuth

Fri, Oct 9

Tgr added a comment to T440619: OAuth tests failures blocking merging changes in WikimediaCustomizations.
09:09:14 1) MediaWiki\Extension\OATHAuth\Tests\Integration\Special\OATHManageTest::testDisplaysIrremovableWarning
09:09:14 Failed asserting that "
<snip>
(oathauth-2fa-groups-notice-multiple-links-entry: 2, (group-interface-admin-member: TestUser 94aa7c.09d)(and)(word-separator)(group-sysop-member: TestUser 94aa7c.09d), 127.0.0.1, <a rel="nofollow" class="external text" href="http://127.0.0.1:9413/wiki/SomePage">SomePage</a>)
<snip>
(oathauth-2fa-groups-notice-multiple-links-entry: 1, (group-suppress-member: TestUser 94aa7c.09d), 127.0.0.1, <a rel="nofollow" class="external text" href="http://127.0.0.1:9413/wiki/DefaultPage">DefaultPage</a>)
<snip>
(oathauth-2fa-groups-notice-multiple-links-entry: 1, (group-interface-admin-member: TestUser 94aa7c.09d), remote-wiki.local, <a rel="nofollow" class="external text" href="http://remote-wiki.local/wiki/SomePage">SomePage</a>)
<snip>
"
contains "(oathauth-2fa-groups-notice-multiple-links-entry: 2, (group-interface-admin-member: TestUser 94aa7c.09d)(and)(word-separator)(group-sysop-member: TestUser 94aa7c.09d), wikidb-unittest_.local".

so the $entry['wiki'] parameter differs. Not sure if that means the test finds the user on a different wiki than expected or something about wiki handling is broken (we know eg. WikiMap doesn't work well in unit tests).

Fri, Oct 9, 7:06 AM · Product Safety and Integrity, MediaWiki-extensions-OATHAuth, MediaWiki-Core-Platform-Team, WikimediaCustomizations
Tgr edited projects for T440619: OAuth tests failures blocking merging changes in WikimediaCustomizations, added: MediaWiki-extensions-OATHAuth; removed MediaWiki-extensions-OAuthAuthentication, MediaWiki-extensions-OAuth.
Fri, Oct 9, 6:53 AM · Product Safety and Integrity, MediaWiki-extensions-OATHAuth, MediaWiki-Core-Platform-Team, WikimediaCustomizations

Tue, Oct 6

Tgr added a comment to T438570: Scap's logstash checker for channels outside "error" and "exception".

(Wrt the current high number of memcached errors, there is an investigation ongoing in T420223: Increase in number of memcached errors in eqiad. For replag, I have no idea what would count as unusually high.)

Tue, Oct 6, 4:28 PM · MediaWiki-Core-Platform-Team (Radar), SRE Observability, Scap
Tgr added a comment to T438570: Scap's logstash checker for channels outside "error" and "exception".

Re: false alarms: having a look at throttle_warning tagged logs over the past 7 days, would a spike in any of these logs be actionable if raised during a deploy?

5,346,462 Cookies set on {url} with Cache-Control "{cache-control}"
Tue, Oct 6, 4:21 PM · MediaWiki-Core-Platform-Team (Radar), SRE Observability, Scap
Tgr added a comment to T382292: 'global_user_editcount' variable consistently returning 0 for the 'MediaWiki message delivery' account.

We'd need a fast system user check (e.g. T212720: System users should be in a dedicated user group).

Tue, Oct 6, 1:26 PM · Product Safety and Integrity, MassMessage, MediaWiki-extensions-CentralAuth, MediaWiki-Core-Platform-Team, AbuseFilter
Tgr added a comment to T440242: Authentication passcode grid.

What is the scenario in which an adversary can intercept the submitted code, but cannot intercept the challenge? Otherwise the combinatorics is entirely pointless, and each fragment can only be used once.

Tue, Oct 6, 8:02 AM · Product Safety and Integrity, MediaWiki-extensions-OATHAuth

Mon, Oct 5

Tgr edited projects for T440242: Authentication passcode grid, added: MediaWiki-extensions-OATHAuth; removed MediaWiki-Core-Platform-Team, MediaWiki-Core-AuthManager.

That seems like a more confusing variant of issuing recovery codes (which we do).

Mon, Oct 5, 9:06 PM · Product Safety and Integrity, MediaWiki-extensions-OATHAuth
Tgr updated Other Assignee for T438591: Commons account not attached with CentralAuth in account rename (SHB), added: Urbanecm.
Mon, Oct 5, 4:47 PM · MW-1.47-notes (1.47.0-wmf.23; 2026-10-06), MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-CentralAuth
Tgr closed T438591: Commons account not attached with CentralAuth in account rename (SHB) as Resolved.

CentralAuthUnattachUserJob jobs stopped being scheduled when the train reached group 2, so whatever was happening (still not sure what resulted in multiple jobs per minute) is fixed.

Screenshot Capture - 2026-10-05 - 18-45-11.png (1,464×708 px, 74 KB)

Mon, Oct 5, 4:47 PM · MW-1.47-notes (1.47.0-wmf.23; 2026-10-06), MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-CentralAuth
Tgr edited P96553 git-review hook to prevent accidental pushing of security patches.
Mon, Oct 5, 9:45 AM · Gerrit, Security

Sun, Oct 4

Tgr created T440109: Global rename is (sometimes?) slow on Wikidata.
Sun, Oct 4, 8:27 AM · MediaWiki-Core-Platform-Team (Kanban), Performance Issue, MediaWiki-extensions-CentralAuth
Tgr added a comment to T440060: REST Gateway: use the sxp field for token expiry.

Another approach would be to ignore all tokens where the iat (issued at) field is older than some given threshold. That's robust against accidental minting of tokens with no / far future expiry.

Sun, Oct 4, 8:18 AM · MediaWiki-API-Platform-Team (MediaWiki-Interfaces-Sprints), ServiceOps
Tgr added a comment to T438570: Scap's logstash checker for channels outside "error" and "exception".

I wonder if we should have some kind of suppression system (along the lines of the current production hack - an array with normalized message => sampling rate that overrides normal sampling settings).

Sun, Oct 4, 7:39 AM · MediaWiki-Core-Platform-Team (Radar), SRE Observability, Scap
Tgr added a comment to T438570: Scap's logstash checker for channels outside "error" and "exception".

The number of events with throttle warning is always going to be 1000 (or more generally 1000 x number of unique message strings that are being throttled), since that's the throttle limit, right? The real (unthrottled) number of events would be more informative as that tells you how much burden it is putting on the event intake, but I don't think that number is available within Logstash.

Sun, Oct 4, 7:38 AM · MediaWiki-Core-Platform-Team (Radar), SRE Observability, Scap

Sat, Oct 3

Tgr added a comment to T388247: Develop a means for preventing developers from accidentally pushing embargoed security patches to gerrit.

git-review automatically installs a commit-msg hook from https://gerrit.wikimedia.org/r/tools/hooks/commit-msg when setting up a new repository (to handle Change-Id); maybe that can be altered somehow.

Sat, Oct 3, 10:44 AM · Gerrit, SecTeam-Processed, Release-Engineering-Team, Security-Team, Security
Tgr added a comment to T388247: Develop a means for preventing developers from accidentally pushing embargoed security patches to gerrit.

Pushing Gerrit patches for low-risk security issues (which are nevertheless private) is not uncommon, and I think in that case we'd still want to link to the Phab task, so warn reject rather than reject would better. (Or allow the patch through when an I-Know-What-I-Am-Doing: Yes footer is present, or whatever.)

Sat, Oct 3, 10:29 AM · Gerrit, SecTeam-Processed, Release-Engineering-Team, Security-Team, Security
Tgr created P96553 git-review hook to prevent accidental pushing of security patches.
Sat, Oct 3, 10:26 AM · Gerrit, Security

Thu, Oct 1

Tgr added a comment to T438570: Scap's logstash checker for channels outside "error" and "exception".

How does it put pressure on the logging infra if it's a relatively small increase in total log traffic? 200K / 30 min is about 100/sec, IIRC the total MediaWiki log volume is a couple thousand per sec.

Thu, Oct 1, 2:36 PM · MediaWiki-Core-Platform-Team (Radar), SRE Observability, Scap
Tgr edited projects for T386205: RuntimeException: CAS update failed on user_touched. The version of the user to be saved is older than the current version. via SessionBackend, added: MediaWiki-Core-Platform-Team; removed MediaWiki-Core-Platform-Team (Radar).

Should be in backlog, not radar, since it's about a component we own.

Thu, Oct 1, 10:45 AM · MediaWiki-Core-Platform-Team, MediaWiki-Core-AuthManager, MediaWiki-User-management, Wikimedia-production-error

Tue, Sep 29

Tgr added a comment to T439489: OAuth deprecation message about virtual domains shows even when main cluster is used.

Oh, right, the service factory could be reinitialized at any time. Guess we'll just have to use Utils::getCentralWiki() everywhere then.

Tue, Sep 29, 7:55 PM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-OAuth
Tgr updated the task description for T253568: Make the terminology of OAuth UI and documentation easy to understand.
Tue, Sep 29, 7:25 PM · MediaWiki-Core-Platform-Team (Kanban), Documentation, Voice & Tone, MediaWiki-extensions-OAuth
Tgr added a comment to T439595: Unapproved client-credentials OAuth apps cannot be used by their owner.

OTOH if unapproved client-credentials apps would be usable by their owner, that would make approval pointless since client-credentials apps can only be used by their owner.

Tue, Sep 29, 5:21 PM · Patch-For-Review, MediaWiki-Core-Platform-Team, MediaWiki-extensions-OAuth
Tgr created T439595: Unapproved client-credentials OAuth apps cannot be used by their owner.
Tue, Sep 29, 5:18 PM · Patch-For-Review, MediaWiki-Core-Platform-Team, MediaWiki-extensions-OAuth
Tgr created T439578: Do not add change tags to actions taken by client-credentials OAuth apps.
Tue, Sep 29, 3:46 PM · Patch-For-Review, MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-OAuth
Tgr added a comment to T439569: Standardize what information is presented on OAuth list UIs and how.

Some ideas:

  • group information visually - "title information" (owner, name and version; should be made more prominent), description, protocol details (OAuth version, flow/grants, confidential flag, callback URI), abilities (scopes, applicable wiki, restrictions if user is allowed to view it), status (stage, maybe a log snippet on the detail page), IDs (client key, DB ID), navigation / action links
  • make it clear at a glance whether the app is for everyone of for the owner
  • make it clear at a glance whether the app has dangerous scopes
  • indicate whether the user viewing the page has authorized this application
Tue, Sep 29, 3:21 PM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-OAuth
Tgr closed T142276: Owner-only consumers should not appear in lists as Resolved.
Tue, Sep 29, 2:45 PM · MW-1.47-notes (1.47.0-wmf.22; 2026-09-29), Patch-For-Review, MediaWiki-Core-Platform-Team, MediaWiki-extensions-OAuth
Tgr closed T142276: Owner-only consumers should not appear in lists, a subtask of T413066: Improve OAuth list UIs, as Resolved.
Tue, Sep 29, 2:44 PM · MediaWiki-Core-Platform-Team (Kanban), Epic, MediaWiki-extensions-OAuth
Tgr added a subtask for T413066: Improve OAuth list UIs: T439569: Standardize what information is presented on OAuth list UIs and how.
Tue, Sep 29, 2:44 PM · MediaWiki-Core-Platform-Team (Kanban), Epic, MediaWiki-extensions-OAuth
Tgr added a parent task for T439569: Standardize what information is presented on OAuth list UIs and how: T413066: Improve OAuth list UIs.
Tue, Sep 29, 2:44 PM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-OAuth
Tgr created T439569: Standardize what information is presented on OAuth list UIs and how.
Tue, Sep 29, 2:44 PM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-OAuth
Tgr added a comment to T439489: OAuth deprecation message about virtual domains shows even when main cluster is used.

onMediaWikiServices is running well before onSetupAfterCache. Maybe something else is setting $wgMWOAuthCentralWiki in your wiki setup?

Tue, Sep 29, 10:15 AM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-OAuth
Tgr edited projects for T244635: CentralAuth deletes session cookies when gadgets make requests to another wiki on IPBE account, causing session loss, added: MediaWiki-Core-Platform-Team; removed MediaWiki-Core-Platform-Team (Radar).

Not sure how this ended up on MediaWiki-Core-Platform-Team (Radar), it's clearly within scope for the team.

Tue, Sep 29, 9:05 AM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-Core-AuthManager, Patch-For-Review, MediaWiki-extensions-CentralAuth, Chinese-Sites

Mon, Sep 28

Tgr updated the task description for T439485: Document response format for OAuth REST APIs.
Mon, Sep 28, 9:33 PM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-OAuth
Tgr created T439485: Document response format for OAuth REST APIs.
Mon, Sep 28, 9:31 PM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-OAuth
Tgr added a comment to T438591: Commons account not attached with CentralAuth in account rename (SHB).

I tried to get all unattached accounts but the query didn't turn up any results. I'm probably messing it up somehow.

hive (wmf_raw)> select count(*) from centralauth_localuser right join mediawiki_user where centralauth_localuser.snapshot='2026-08' and centralauth_localuser.wiki_db = 'centralauth' and mediawiki_user.snapshot=2026-08 and lu_name = user_name and lu_wiki = mediawiki_user.wiki_db and lu_name is null;
_c0
0
Mon, Sep 28, 4:49 PM · MW-1.47-notes (1.47.0-wmf.23; 2026-10-06), MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-CentralAuth
Tgr added a comment to T439345: installPreConfigured.php fails with "Container disabled!" on a single database server.

Similar to T437261: "Wikimedia\Services\ContainerDisabledException: Container disabled!" in JobQueue / WANObjectCache->getWithSetCallback / getDBLoadBalancer().

Mon, Sep 28, 7:40 AM · MediaWiki-Core-Platform-Team (Kanban), MW-1.47-notes (1.47.0-wmf.23; 2026-10-06), MediaWiki-libs-Rdbms, MediaWiki-Installer, MediaWiki-libs-BagOStuff

Sun, Sep 27

Tgr added a comment to T368125: Clean up existing unattached accounts.

Probably before the cleanup we should fix system users:
T275931: Have new system users be automatically attached to CentralAuth
T111686: Attach existing system users to CentralAuth

Sun, Sep 27, 9:11 PM · MediaWiki-Core-Platform-Team, MediaWiki-extensions-CentralAuth
Tgr added a comment to T438591: Commons account not attached with CentralAuth in account rename (SHB).

Spot-checking some random job entries:

tgr@mwlog1003:/srv/mw-log$ ack CentralAuthUnattachUserJob JobExecutor.log | head -n100 | ack 'username=([^=]+) wiki=([^ ]+)' --output='$2 $1' | sort | uniq -c
     12 cswiki Hovhannes Kirakosyan
      2 dewiki ~2026-52145-13
      2 enwiki ~2026-51810-00
      2 enwiki ~2026-52041-04
     14 fiwiki Hovhannes Kirakosyan
      2 frwiki Emmabsha.256
      6 hewiki Hovhannes Kirakosyan
      2 idwiki Hovhannes Kirakosyan
      2 itwiki ~2026-52026-69
     13 kowiki Hovhannes Kirakosyan
      2 metawiki ~2026-51810-00
      6 nowiki Hovhannes Kirakosyan
      6 ptwiki Hovhannes Kirakosyan
     15 rowiki Hovhannes Kirakosyan
     14 ukwiki Hovhannes Kirakosyan
Sun, Sep 27, 7:16 PM · MW-1.47-notes (1.47.0-wmf.23; 2026-10-06), MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-CentralAuth
Tgr added a comment to T438591: Commons account not attached with CentralAuth in account rename (SHB).

The only code path leading to CentralAuthUnattachUserJob is LocalUserNotFoundException thrown from localUserData(), which will log either Requested to load user data for unknown wiki {wikiId}. Was it deleted without data migration? (zero instances in the last 90 days) or Could not find local user data for {username}@{wikiId} (4 instances, all during global vanishing, but it does not include SHB). But it won't log if we are reading the replica, and the callers will schedule the job anyway. Oops.

Sun, Sep 27, 7:01 PM · MW-1.47-notes (1.47.0-wmf.23; 2026-10-06), MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-CentralAuth
Tgr added a comment to T359823: LogicException: Process cache for 'en' should be set by now.

There was a single spike of ~1500 events starting around 17:30 Wednesday and ending around 18:10. That matches the codfw depool time for T439010: codfw power outage, so probably it's just a bunch of memcached hosts being impacted by the power outage.

Sun, Sep 27, 3:07 PM · Patch-For-Review, Wikimedia-production-error, MediaWiki-Core-Platform-Team (Radar), NFDI-Germany, MediaWiki-Internationalization, affects-translatewiki.net
Tgr claimed T439275: PHPUnit test MediaWiki\Auth\ElevatedSecurityAuthenticationRequestTest::testLoadFromSubmission is flaky.
Sun, Sep 27, 2:45 PM · MW-1.47-notes (1.47.0-wmf.22; 2026-09-29), MediaWiki-Core-AuthManager, ci-test-error (WMF-deployed Build Failure), MediaWiki-Core-Tests, MediaWiki-Core-Platform-Team

Fri, Sep 25

Tgr added a comment to T438380: Account_on_central_wiki_is_not_attached_this_shouldn_t_happen errors during autologin.

Returned to old levels a while ago:

Screenshot Capture - 2026-09-25 - 19-18-56.png (846×534 px, 87 KB)

Probably a bot, but worth having a look at it.

Fri, Sep 25, 5:19 PM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-Core-AuthManager
Tgr added a comment to T423206: increase in session_fail_preview messages on enwiki.

All the metrics seem to be in the normal range now, except for T438380: Account_on_central_wiki_is_not_attached_this_shouldn_t_happen errors during autologin which is still generating a huge number of autologin errors, but presumably that doesn't affect established users who haven't been renamed recently.

Fri, Sep 25, 3:40 PM · MediaWiki-Core-Platform-Team (Radar), Data-Persistence, ServiceOps, MediaWiki-Page-editing
Tgr added a comment to T428231: PHP Warning: Undefined array key "DEBUG" in /srv/http/wiki1/includes/Logger/LegacyLogger.php on line 151.

This should be fixed in RemoteBoxedExecutor. The logger could be any PSR-3 implementation, not just Monolog or LegacyLogger; we explicitly allow site administrators to customize that. PSR-3 says

Fri, Sep 25, 3:06 PM · MediaWiki-Core-Platform-Team, MediaWiki-extensions-Score, MediaWiki-Debug-Logger, Shellbox
Tgr added a comment to T431146: Error “The refresh token is invalid.” after migrating Wikidata Lexeme Forms to OAuth 2.

@LucasWerkmeister three months have passed, should we just assume rEOAUe4424057b1be: Add a grace period for reusing refresh tokens has fixed the issue?

Fri, Sep 25, 2:48 PM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-extensions-OAuth, Tool-lexeme-forms

Thu, Sep 24

Tgr attached a referenced file: F104298989: image.png.
Thu, Sep 24, 2:08 PM · MediaWiki-Core-Platform-Team (Radar), Cassandra
Tgr updated the task description for T439139: Investigate session losses during 2026 September eqiad sessionstore depool.
Thu, Sep 24, 2:07 PM · MediaWiki-Core-Platform-Team (Radar), Cassandra
Tgr added a comment to T423206: increase in session_fail_preview messages on enwiki.

Discussing all session loss problems this year in the same task isn't really useful, so here's a dedicated one: T439139: Investigate session losses during 2026 September eqiad sessionstore depool

Thu, Sep 24, 2:05 PM · MediaWiki-Core-Platform-Team (Radar), Data-Persistence, ServiceOps, MediaWiki-Page-editing
Tgr renamed T439139: Investigate session losses during 2026 September eqiad sessionstore depool from Investigate session losses during eqiad sessionstore depool to Investigate session losses during 2026 September eqiad sessionstore depool.
Thu, Sep 24, 2:04 PM · MediaWiki-Core-Platform-Team (Radar), Cassandra
Tgr created T439139: Investigate session losses during 2026 September eqiad sessionstore depool.
Thu, Sep 24, 2:03 PM · MediaWiki-Core-Platform-Team (Radar), Cassandra
Tgr added a comment to T436899: kokkuri:setup-variables failing for repos/releng/release!268 (due to being a fork?).

I mean it doesn't show anything that would explain why the release tools or patchdemo repos would trigger that test.

Thu, Sep 24, 10:00 AM · Release-Engineering-Team, GitLab
Tgr added a comment to T425216: Varnish serving outdated version at original/non-thumb URL of overwritten file upload.

To not copy any more application-specific business logic into CDN edge logic than we absolutely have to (because it binds them together and makes future changes more complicated).

Thu, Sep 24, 8:40 AM · MW-1.47-notes (1.47.0-wmf.21; 2026-09-22), Patch-For-Review, MediaWiki-Core-Platform-Team (Kanban), SRE, Traffic, MediaWiki-File-management, Commons

Mon, Sep 21

Tgr added a comment to T438380: Account_on_central_wiki_is_not_attached_this_shouldn_t_happen errors during autologin.

Maybe caused by T438591: Commons account not attached with CentralAuth in account rename (SHB) although that was just one user, and the volume is quite large (50-100 errors per minute).

Mon, Sep 21, 2:50 PM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-Core-AuthManager
Tgr added a comment to T436899: kokkuri:setup-variables failing for repos/releng/release!268 (due to being a fork?).

Same happening at Patchdemo (https://gitlab.wikimedia.org/tgr/patchdemo/-/pipelines/229200/failures)

Mon, Sep 21, 12:12 PM · Release-Engineering-Team, GitLab

Sun, Sep 20

Tgr added a comment to T419684: Add restrictive CSP to auth.wikimedia.org.

Why would that involve auth.wikimedia.org though? We don't do temp user autologin until after the save was successful.

Sun, Sep 20, 7:17 PM · MW-1.47-notes (1.47.0-wmf.21; 2026-09-22), Patch-For-Review, MediaWiki-Core-Platform-Team (Kanban), SUL3, ContentSecurityPolicy, Security, MediaWiki-extensions-CentralAuth
Restricted Application added a project to T224749: OAuth consumer id should be exposed: MediaWiki-Core-Platform-Team.

In hindsight, maybe better to go the opposite direction and replace the DB ID with the key everywhere, so it becomes a completely internal detail.

Sun, Sep 20, 1:09 PM · MediaWiki-Core-Platform-Team (Kanban), MW-1.41-notes (1.41.0-wmf.19; 2023-07-25), MediaWiki-extensions-OAuth
Tgr created T438625: Patchdemo update instructions are outdated.
Sun, Sep 20, 9:00 AM · Catalyst (Luka Ijo Pimeja Jan), Documentation

Thu, Sep 17

Tgr created T438380: Account_on_central_wiki_is_not_attached_this_shouldn_t_happen errors during autologin.
Thu, Sep 17, 5:00 PM · MediaWiki-Core-Platform-Team (Kanban), MediaWiki-Core-AuthManager

Wed, Sep 16

Tgr added a comment to T393212: Implement Device Bound Session Credentials (DBSC) in MediaWiki.

The (not yet implemented on any browser) DBSC JS API explainer says

Wed, Sep 16, 6:53 PM · MW-1.48-notes (1.48.0-wmf.1; 2026-10-20), user-sbassett, Patch-For-Review, Product Safety and Integrity, MediaWiki-Core-Platform-Team, MediaWiki-Core-AuthManager, Security