Tgr (Gergő Tisza)
Software Engineer, WMF Reading

Projects (37)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 4:55 PM (203 w, 4 d)
Availability
Available
IRC Nick
tgr
LDAP User
Gergő Tisza
MediaWiki User
Tgr (WMF) [ Global Accounts ]

Things my team is working on: Reading-Infrastructure-Team-Backlog (kanban board)
Side projects I am working on (or planning to, eventually): User-Tgr
You can find more info about me on my user page.

Recent Activity

Yesterday

kerberizer awarded T187749: Make it possible to use code from an external repository for editor-controlled Javascript/CSS a Love token.
Tue, Aug 14, 5:09 PM · Wikimedia-Hackathon-2018, Patch-For-Review, MediaWiki-extension-requests, User-Tgr, Security-General, JavaScript, Gadgets
Tgr added a comment to T194731: Show diffs for all slots [MCR].

Moving back to review as all dependencies (452470, 452413) are also up for review.

Tue, Aug 14, 11:56 AM · Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Patch-For-Review, Structured-Data-Commons, Wikidata
Tgr moved T194731: Show diffs for all slots [MCR] from Blocked to Needs Review on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.
Tue, Aug 14, 11:55 AM · Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Patch-For-Review, Structured-Data-Commons, Wikidata
Tgr claimed T201842: Use ContentHandler to obtain DifferenceEngine in MobileFrontend.

Patch is up. In the future either InlineDifferenceEngine::getSlotHeader or InlineDiffFormatter should be improved so that slot headers look sanely, but that's not an immediate blocker, it's blocked on the main diff patch and slot headers need to be changed anyway when SlotRoleHandler lands, so that can wait.

Tue, Aug 14, 11:54 AM · Readers-Web-Backlog (Tracking), Patch-For-Review, MobileFrontend, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2)
Tgr moved T201842: Use ContentHandler to obtain DifferenceEngine in MobileFrontend from Backlog to Needs Review on the Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2) board.
Tue, Aug 14, 11:51 AM · Readers-Web-Backlog (Tracking), Patch-For-Review, MobileFrontend, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2)

Mon, Aug 13

Tgr added a comment to T194731: Show diffs for all slots [MCR].
  • MobileFrontend uses different DiffEngine (it's hardcoded), this is something you have to talk to Reading Web
Mon, Aug 13, 8:36 PM · Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Patch-For-Review, Structured-Data-Commons, Wikidata
Tgr added a comment to T201615: Wikibase on Vagrant: Class 'Wikibase\DataModel\Entity\ItemId' not found.

Vagrant throws this every time it tries to do something with MediaWiki (that is, run some maintenance script) so the full log is not super useful.

Mon, Aug 13, 3:36 PM · Wikidata, MediaWiki-Vagrant, MediaWiki-extensions-WikibaseRepository
Tgr added a comment to T194731: Show diffs for all slots [MCR].

We'll need a ticket for that, and we need to figure out who can do this, and when.

Mon, Aug 13, 3:21 PM · Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Patch-For-Review, Structured-Data-Commons, Wikidata
Tgr added a comment to T201842: Use ContentHandler to obtain DifferenceEngine in MobileFrontend.

This is not really an MCR problem (trying to show mobile diffs of Wikidata edits has the same issue) but will occur in many more places due to MCR. It's not a phase 1 blocker (we can preserve the current behavior with a simple patch as long as only main slots exist). It might be a phase 2 blocker if we want to show diffs of file page edits on mobile (which we do currently) but can be worked around by writing a custom InlineEntityContentDiffView engine for the Wikibase + mobile combination. Dealing with it in general is more complex. We might want to handle inline / non-inline at the DifferenceEngine::getEngine() level.

Mon, Aug 13, 3:21 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, MobileFrontend, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2)
Tgr created T201848: Make DifferenceEngine callers pass revisions, not contents.
Mon, Aug 13, 3:17 PM · MediaWiki-History-or-Diffs, Multi-Content-Revisions (MCR Deployment)
Tgr updated the task description for T201218: Viewing page's first revision via diff gives error.
Mon, Aug 13, 3:03 PM · Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Regression, MediaWiki-History-or-Diffs
Tgr created T201842: Use ContentHandler to obtain DifferenceEngine in MobileFrontend.
Mon, Aug 13, 2:46 PM · Readers-Web-Backlog (Tracking), Patch-For-Review, MobileFrontend, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2)
Tgr added a comment to T194731: Show diffs for all slots [MCR].

Went through the high and medium priority steps of the test plan.

  • MobileFrontend diffs break (use TextSlotDiffRenderer instead of InlineDifferenceEngine). MobileFrontend hand-creates the InlineDiffRenderer so it does not get used for the main slot; I don't think the diff patch can be improved to prevent that from happening (DifferenceEngine::getSlotDiffRenderers() could check its own class and replace TextSlotDiffRenderers with itself when it's not the base class, but that's scary and would probably break way more things). It needs to be fixed in MobileFrontend (and other extensions using a similar pattern).
  • Diffing with non-existent old revisions is somewhat broken due to a previous patch (T201218: Viewing page's first revision via diff gives error).
  • There are a bunch of callers which pass in a content object so non-main slots get ignored (edit conflict, for example). I think that's outside scope (better to keep patches small when possible) but should be tracked and eventually converted.
  • I get an exception when I try to make a Wikibase slot in a non-Wikibase namespace. I think that's expected.
  • Couldn't figure out what "diff should reflect user language" for Wikibase means.
  • Could not test VisualEditor (npm has random failures, probably because it hogs up all the memory and gets killed, and I haven't found a good way to detect or repair broken installs). Will have to test it on Beta.
Mon, Aug 13, 1:55 PM · Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Patch-For-Review, Structured-Data-Commons, Wikidata
Tgr added a comment to T201784: Implement option "require two-factor authentication only for dangerous actions".

This is basically T197136: Tie certain user rights to elevated security plus T197153: Make some providers optional for reauthentication, with extra configuration options for OATHAuth.

Mon, Aug 13, 6:01 AM · MediaWiki-extensions-OATHAuth, Security, MediaWiki-Authentication-and-authorization
Tgr closed T69924: Can't enter unicode into eval.php in production ? as Resolved.

Works fine these days, our HHVM version has been upgraded presumably.

Mon, Aug 13, 6:00 AM · HHVM, Upstream, Developer-Wishlist (2017), Wikimedia-General-or-Unknown
Tgr added a parent task for T197136: Tie certain user rights to elevated security: T197160: All security-sensitive MediaWiki functionality should require elevated security.
Mon, Aug 13, 5:55 AM · MediaWiki-User-management, Security-Core
Tgr added a subtask for T197160: All security-sensitive MediaWiki functionality should require elevated security: T197136: Tie certain user rights to elevated security.
Mon, Aug 13, 5:55 AM · User-Tgr, Epic, MediaWiki-Authentication-and-authorization, Security-General
Tgr added a comment to T201638: Quibble: shasum check failed.

No, haven't seen since. The patch was https://gerrit.wikimedia.org/r/c/mediawiki/core/+/451663 FWIW.

Mon, Aug 13, 5:30 AM · Continuous-Integration-Config, Quibble

Sat, Aug 11

Tgr committed rCSSSc20ea51f5c10: Add hoisting option to StyleRuleSanitizer selector handling (authored by Tgr).
Add hoisting option to StyleRuleSanitizer selector handling
Sat, Aug 11, 6:56 PM
Tgr created T201765: Mark FlaggedRevs pages as needing review when data fetched from Wikidata changes.
Sat, Aug 11, 5:59 PM · MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-FlaggedRevs, Wikidata
Tgr created T201746: CURLE_COULDNT_CONNECT when trying to use Conduit.
Sat, Aug 11, 8:54 AM · Phabricator
Tgr created T201745: OpenStackManager test fails with "Call to a member function doLogout() on boolean".
Sat, Aug 11, 8:44 AM · MediaWiki-extensions-OpenStackManager

Fri, Aug 10

Tgr committed rERLS94a456128257: Improve API documentation for query+readinglists project/title param (authored by Tgr).
Improve API documentation for query+readinglists project/title param
Fri, Aug 10, 7:45 PM
Tgr edited P7448 Primary auth provider for external database.
Fri, Aug 10, 7:22 PM
Tgr created P7448 Primary auth provider for external database.
Fri, Aug 10, 7:22 PM
Tgr added a comment to T201686: Cache issue in load.php.

I don't see that error, can you provide more specific reproduction steps?

Fri, Aug 10, 4:48 PM · Performance-Team, MediaWiki-ResourceLoader
Tgr added a comment to T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps.

And I don't see how it's better than the multiple-text-tags-with-attributes approach.

Fri, Aug 10, 11:35 AM · Dumps-Generation, User-ArielGlenn, User-Daniel, TechCom-RFC, Multi-Content-Revisions, Structured-Data-Commons, Wikidata
Tgr awarded Blog Post: Wikipedia goes 100% Forward Secret a Love token.
Fri, Aug 10, 11:10 AM · Traffic
Tgr added a comment to T199121: RFC: Spec for representing multiple content objects per revision (MCR) in XML dumps.

Or just drop the idea of a transitional format and keep the main slot one level higher forever (or at least until the next change that really needs to be a BC break). Old clients will not break, MCR-aware clients will maybe need very slightly less elegant parsing code, which does not seem like a bad trade-off.

Fri, Aug 10, 9:56 AM · Dumps-Generation, User-ArielGlenn, User-Daniel, TechCom-RFC, Multi-Content-Revisions, Structured-Data-Commons, Wikidata
Tgr added a comment to T201653: Missing documentation for pageviews dataset.

Someone just added it (the file is dated to two hours ago). Thanks!

Fri, Aug 10, 9:42 AM · Patch-For-Review, Analytics-Kanban, Datasets-General-or-Unknown, Documentation, Analytics

Thu, Aug 9

Tgr created T201653: Missing documentation for pageviews dataset.
Thu, Aug 9, 11:11 PM · Patch-For-Review, Analytics-Kanban, Datasets-General-or-Unknown, Documentation, Analytics
Tgr updated subscribers of T201200: Introduce soft assertions in MediaWiki.

@daniel any thoughts? Is this generic enough that maybe it should be discussed as an IRC? Or is it still in just-do-it-land?

Thu, Aug 9, 11:03 PM · Technical-Debt, MediaWiki-General-or-Unknown
Tgr created T201638: Quibble: shasum check failed.
Thu, Aug 9, 6:52 PM · Continuous-Integration-Config, Quibble
Tgr added a comment to T197563: Template styles get ignored when switching to Visual Editor.

These are not RL modules, just plain style tags with the CSS inlined.
If you do not load the page HTML, where does VE get the HTML from that gets displayed in the editable area?

Thu, Aug 9, 4:28 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Templates, TemplateStyles
Tgr added a comment to T110022: Create a library with HTTP related functions/code.

Localization questions aside, it seemed that in 2016 (on T139169), @Krinkle preferred Requests, while @Tgr preferred Guzzle. Do each of you still feel the same

Thu, Aug 9, 3:16 PM · Addwiki, Wikidata, Librarization
Tgr added a comment to T139169: Add non-parallel MultiHttpClient fallback for environments that don't have curl available.

Guzzle actually seems to have some amount of static state too. From a quick check it also allows at least default options to be statically overridden

Thu, Aug 9, 2:58 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, Services (watching), MediaWiki-General-or-Unknown
Tgr created T201615: Wikibase on Vagrant: Class 'Wikibase\DataModel\Entity\ItemId' not found.
Thu, Aug 9, 2:22 PM · Wikidata, MediaWiki-Vagrant, MediaWiki-extensions-WikibaseRepository
Isarra awarded T133410: Deploy TemplateStyles to WMF production a Love token.
Thu, Aug 9, 1:29 PM · Epic, Performance-Team (Radar), User-notice, Readers-Web-Backlog (Tracking), Traffic, Operations, Wikimedia-Extension-setup, TemplateStyles
Tgr closed T133410: Deploy TemplateStyles to WMF production as Resolved.
Thu, Aug 9, 11:23 AM · Epic, Performance-Team (Radar), User-notice, Readers-Web-Backlog (Tracking), Traffic, Operations, Wikimedia-Extension-setup, TemplateStyles
Tgr closed T133410: Deploy TemplateStyles to WMF production, a subtask of T37704: Drop support in wikitext for inline styles, as Resolved.
Thu, Aug 9, 11:23 AM · Community-consensus-needed, Epic, MediaWiki-Page-editing, Accessibility, MediaWiki-Interface
Tgr closed T133410: Deploy TemplateStyles to WMF production, a subtask of T17075: Per book, category and/or template CSS and JavaScript, as Resolved.
Thu, Aug 9, 11:23 AM · MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), MW-1.27-release-notes, Wikimedia-Hackathon-2016, WorkType-NewFunctionality, MediaWiki-General-or-Unknown
Tgr added a subtask for T199909: Deploy TemplateStyles everywhere on 2018-08-09: T199982: Announce that TemplateStyles is being deployed everywhere with mass messages.
Thu, Aug 9, 11:20 AM · Patch-For-Review, Wikimedia-Extension-setup, TemplateStyles
Tgr added a parent task for T199982: Announce that TemplateStyles is being deployed everywhere with mass messages: T199909: Deploy TemplateStyles everywhere on 2018-08-09.
Thu, Aug 9, 11:20 AM · CommRel-Specialists-Support (Jul-Sep-2018), TemplateStyles
Tgr added a subtask for T133410: Deploy TemplateStyles to WMF production: T199909: Deploy TemplateStyles everywhere on 2018-08-09.
Thu, Aug 9, 11:20 AM · Epic, Performance-Team (Radar), User-notice, Readers-Web-Backlog (Tracking), Traffic, Operations, Wikimedia-Extension-setup, TemplateStyles
Tgr added a parent task for T199909: Deploy TemplateStyles everywhere on 2018-08-09: T133410: Deploy TemplateStyles to WMF production.
Thu, Aug 9, 11:20 AM · Patch-For-Review, Wikimedia-Extension-setup, TemplateStyles
Tgr closed T199909: Deploy TemplateStyles everywhere on 2018-08-09 as Resolved.
Thu, Aug 9, 11:19 AM · Patch-For-Review, Wikimedia-Extension-setup, TemplateStyles

Wed, Aug 8

Tgr claimed T201218: Viewing page's first revision via diff gives error.
Wed, Aug 8, 2:50 PM · Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Regression, MediaWiki-History-or-Diffs
Tgr added a project to T201218: Viewing page's first revision via diff gives error: Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1).
Wed, Aug 8, 2:50 PM · Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Regression, MediaWiki-History-or-Diffs
Tgr added a comment to T200392: RfC: Release notes automation.

Ideally this would run on gerrit, not developers' machines. That does not seem to be case though.

Wed, Aug 8, 2:00 PM · MediaWiki-Documentation, TechCom-RFC
Tgr closed T201494: Fix permissions of /srv/mediawiki-staging/private/README_BEFORE_MODIFYING_ANYTHING on mwdeploy1001 as Resolved.
Wed, Aug 8, 10:14 AM · Operations

Tue, Aug 7

awight awarded T195779: MCR support in ORES a Goat token.
Tue, Aug 7, 11:37 PM · Epic, Multi-Content-Revisions, Scoring-platform-team, ORES
Tgr added a comment to T199909: Deploy TemplateStyles everywhere on 2018-08-09.

With the largest wikis already opted in, it's not too big a deal, it can be done in a regular SWAT window IMO. I'll add it now.
(BTW I'm taking "everywhere" as all wikis including private etc. - there doesn't seem to be any reason not to do it.)

Tue, Aug 7, 6:56 PM · Patch-For-Review, Wikimedia-Extension-setup, TemplateStyles
Tgr closed T200982: Undefined property: Parser::$extTemplateStylesCache in /srv/mediawiki/php-1.32.0-wmf.14/extensions/TemplateStyles/includes/TemplateStylesHooks.php on line 188 as Invalid.

No, it was a one-time thing, on last Thursday. Maybe some kind of deploy artifact with different versions of the code running in different contexts? Although that specific part of the code hasn't been touched for a year. Anyway, weird one-off, not worth the effort of investigating more unless it reoccurs.

Tue, Aug 7, 6:04 PM · Wikimedia-log-errors, TemplateStyles
Tgr added a comment to T190015: Create separate user group for editing sitewide CSS/JavaScript that does not include administrators by default.

@SpeedyGonsales right-hidden is/was a Commons hack to prevent a gadget from being used by anyone. Apparently whoever ported the gadget didn't bother to port the message as well. IIRC these days ResourceLoader has a hidden option so the hack is not needed anymore.
Anyway, this has nothing to do with editing, permissions shown on Special:Gadgets are for enabling gadgets.

Tue, Aug 7, 4:37 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core
Tgr added a comment to T201062: Load change tags into the Analytics Data Lake on a daily basis.

At a glance there's just a page.delete / page.undelete event (or mediawiki.revision-visibility-change if it's revision deletion).

Tue, Aug 7, 2:40 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, Services (watching), EventBus, Product-Analytics, Analytics
Tgr added a comment to T201305: ThumbnailRender jobs not including the width in the fetch URL.

Running the job manually from mwscript works fine. Does this failure happen on every job run or just some fraction of the attempts?

Tue, Aug 7, 2:31 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-File-management, Multimedia, WMF-JobQueue, Commons, Services (watching)
Tgr added a comment to T201305: ThumbnailRender jobs not including the width in the fetch URL.

T200346: wmf.14 failing to execute ThumbnailRender jobs "error: ThumbnailRenderJob::run: HTTP request failure" probably masked this error until recently.

Tue, Aug 7, 1:40 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-File-management, Multimedia, WMF-JobQueue, Commons, Services (watching)
Tgr updated subscribers of T201062: Load change tags into the Analytics Data Lake on a daily basis.

Change tags are added after the revision has been created and saved (and they can be added or removed much later, although that probably does not really happen in practice). So that would be some major refactoring, if at all desirable.

Tue, Aug 7, 1:11 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, Services (watching), EventBus, Product-Analytics, Analytics
Tgr closed T201394: The administrator continues to manage js/css without setting up an interface-admin at zh-classical Wikipedia. as Declined.

There is no way to do that, one of the goals is to have the same configuration of JS editing permissions on all wikis to make central monitoring easier. Feel free to add all your admins to the interface-admin group though if you think they all need access.

Tue, Aug 7, 1:00 PM · Wikimedia-Site-requests
Tgr added a comment to T197563: Template styles get ignored when switching to Visual Editor.

The styles are part of the page content (https://ru.wikipedia.org/api/rest_v1/page/html/Северное_море). Surely VE must load that?

Tue, Aug 7, 12:56 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Templates, TemplateStyles
Tgr closed T200698: Merge two hewiki user groups as Resolved.
Tue, Aug 7, 11:09 AM · Patch-For-Review, User-Urbanecm, Wikimedia-Site-requests

Mon, Aug 6

Tgr added a comment to T194731: Show diffs for all slots [MCR].

Test plan: https://www.mediawiki.org/wiki/User:Tgr_(WMF)/DifferenceEngine/test_plan

Mon, Aug 6, 8:57 PM · Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Patch-For-Review, Structured-Data-Commons, Wikidata
Tgr added a comment to T201305: ThumbnailRender jobs not including the width in the fetch URL.

The logstash errors (the error field, not the message) are all along the lines of ThumbnailRenderJob::run: incorrect HTTP status 404 when hitting //ms-fe.svc.eqiad.wmnet/wikipedia/commons/thumb/1/1c/Foo.tif/-Foo.tif.png

Mon, Aug 6, 8:11 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-File-management, Multimedia, WMF-JobQueue, Commons, Services (watching)
Tgr added a comment to T200690: Wrong umask when deploying from screen.

I wonder if there are git hooks we could setup on the deployment servers to address this without having to put any logic into scap?

Mon, Aug 6, 8:09 PM · Scap, Operations
Tgr added a comment to T201305: ThumbnailRender jobs not including the width in the fetch URL.

Weird. ImageHandler::makeParamString would throw an exception if the width wouldn't be specified, and that's not happening.

Mon, Aug 6, 12:22 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, MediaWiki-File-management, Multimedia, WMF-JobQueue, Commons, Services (watching)
Tgr added a comment to T200698: Merge two hewiki user groups.

@IKhitron copied the permissions, please go ahead and empty the interface-editor group.

Mon, Aug 6, 11:10 AM · Patch-For-Review, User-Urbanecm, Wikimedia-Site-requests
Tgr added a comment to T196950: Pages do not have stable identifiers.

I think this writeup misses the main problem: in MediaWiki, live revisions are associated with a page ID but deleted revisions are associated with a title. That allows for all kind of weird things through the creative use of delete/undelete and page move - merging pages, splitting a page into multiple parts, transferring parts of a page history into another page etc. This violates the assumption behind having a stable page identifier: that the page is an "atomic" building block that can be tracked over time as a single entity. Fixing that (if it should be fixed) is more of an UX / user expectations issue than a technical one.

Mon, Aug 6, 8:26 AM · TechCom-RFC, MediaWiki-Database, MediaWiki-Page-deletion
Tgr added a comment to T200880: Editor should flag mobile editing warnings.

I don't think this is viable as an edit warning if it cannot differentiate between problems in the wikitext of the current page and problems in templates (which is probably not possible with the PHP parser). Most articles are just text and the problems will come from the infobox, navbox etc. templates they include, so there will be lots of non-actionable warnings confusing editors. The Linter approach seems more feasible.

Mon, Aug 6, 8:14 AM · TechCom-RFC, Page-Issue-Warnings, Readers-Web-Backlog (Design), Reading-Web-Local-Wiki-Issues, MobileFrontend
Tgr added a comment to T200392: RfC: Release notes automation.

Have we tried merge=union? That seems vastly simpler.

Mon, Aug 6, 8:04 AM · MediaWiki-Documentation, TechCom-RFC

Sun, Aug 5

Tgr added a comment to T200176: Deletion of user js and css requires deletion and edituser* rights.

Reading rMW9dafa73b2f28: Test only against protection for deleting more closely, I don't think it requires edit rights for deletion. It only requires that the user is not prevented from editing by a page protection.

Sun, Aug 5, 9:53 PM · Security-Core, MediaWiki-User-management, Security
Tgr added a comment to T201052: Local interface-admin need to be sysop for some operations.

I think this can be closed in favor of the more specific T200176: Deletion of user js and css requires deletion and edituser* rights. Or am I misunderstanding what you are asking for?

Sun, Aug 5, 9:36 PM · MediaWiki-General-or-Unknown, Security-General, Trust-and-Safety
Tgr added a comment to T190015: Create separate user group for editing sitewide CSS/JavaScript that does not include administrators by default.

T200176: Deletion of user js and css requires deletion and edituser* rights has more discussion on this.

Sun, Aug 5, 9:35 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core
Tgr added a comment to T200176: Deletion of user js and css requires deletion and edituser* rights.

There isn't anything particularly secret about this and in any case it's being discussed in a number of public places so let's open it up.

Sun, Aug 5, 9:34 PM · Security-Core, MediaWiki-User-management, Security
Tgr added a project to T200176: Deletion of user js and css requires deletion and edituser* rights: Security-Core.
Sun, Aug 5, 9:33 PM · Security-Core, MediaWiki-User-management, Security
Tgr added a comment to T190015: Create separate user group for editing sitewide CSS/JavaScript that does not include administrators by default.

Global renaming bypasses any local restrictions

Sun, Aug 5, 9:00 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core
Tgr updated subscribers of T201273: Add option to discourse-chat-integration plugin to use plain message instead of channel notice for the Matrix provider.

Commit: https://github.com/tgr/discourse-chat-integration/tree/matrix-notice-option
Needs to be tested. @Qgil do we have a test site? Or can I just test on the live site? (Pretty simple patch, probably not worth the effort of setting up a local test environment.)

Sun, Aug 5, 8:53 PM · Discourse
Tgr added a comment to T176272: Decide on what to recommend for table style usecase.

Putting the template with the styles after the table might result in a FOUC (although not a huge deal as long as it's just colors and no layout-related rules).

Sun, Aug 5, 7:35 PM · TemplateStyles
Tgr added a comment to T200560: Upload to Wikimedia Commons fails with error "mustBeLoggedIn".

Re-login is not any different from login. It will clear the session (in general if the session times out there is no way to recover it), so you'll need new CSRF tokens.

Sun, Aug 5, 7:33 PM · MediaWiki-Authentication-and-authorization, MediaWiki-Uploading, Multimedia
Tgr committed rELGN97bbd18bdea7: Use accurate count when budling multiple login failure warnings (authored by Tgr).
Use accurate count when budling multiple login failure warnings
Sun, Aug 5, 6:51 PM
Tgr committed rELGN75db18b802c8: Use accurate count when budling multiple login failure warnings (authored by Tgr).
Use accurate count when budling multiple login failure warnings
Sun, Aug 5, 5:52 PM
Tgr committed rELGN6e78487463a7: Use accurate count when budling multiple login failure warnings (authored by Tgr).
Use accurate count when budling multiple login failure warnings
Sun, Aug 5, 5:52 PM
Tgr closed T194484: Bundled Echo notifications should be able to aggregate the parameters of the individual notifications as Invalid.
Sun, Aug 5, 5:47 PM · Growth-Team, Collaboration-Team-Triage, Notifications
Tgr added a comment to T198990: It should be possible to delete an entry by title from a reading list.
Sun, Aug 5, 5:35 PM · Reading List Service, Reading-Infrastructure-Team-Backlog, User-Jdlrobson
Tgr closed T198991: It should be possible to query the API to find out what lists an article is on as Invalid.

That's what project/title is for: action=query&meta=readinglists&rlproject=en.wikipedia.org&rltitle=Spain

Sun, Aug 5, 5:28 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, Reading List Service, Reading-Infrastructure-Team-Backlog, User-Jdlrobson
Tgr closed T198991: It should be possible to query the API to find out what lists an article is on, a subtask of T194441: [EPIC] Reading lists on desktop and mobile web, as Invalid.
Sun, Aug 5, 5:28 PM · Epic, Readers-Web-Backlog, User-Jdlrobson, MediaWiki-Interface, Reading Epics (Synchronized Reading Lists), Wikimedia-Hackathon-2018
Tgr added a subtask for T187634: IRC integration for Discourse: T201273: Add option to discourse-chat-integration plugin to use plain message instead of channel notice for the Matrix provider.
Sun, Aug 5, 5:19 PM · Discourse
Tgr added a parent task for T201273: Add option to discourse-chat-integration plugin to use plain message instead of channel notice for the Matrix provider: T187634: IRC integration for Discourse.
Sun, Aug 5, 5:19 PM · Discourse
Tgr created T201273: Add option to discourse-chat-integration plugin to use plain message instead of channel notice for the Matrix provider.
Sun, Aug 5, 5:19 PM · Discourse
Tgr added a comment to T200560: Upload to Wikimedia Commons fails with error "mustBeLoggedIn".

It seems I don't have permissions to create a paste with a custom policy.

Sun, Aug 5, 4:05 PM · MediaWiki-Authentication-and-authorization, MediaWiki-Uploading, Multimedia
Tgr added a member for Trusted-Contributors: maskaravivek.
Sun, Aug 5, 3:41 PM
Tgr closed T199404: MediaViewer displays alt text rather than caption or description for images in infoboxes as Invalid.

That's not the alt text, it's the caption (as understood by MediaWiki - ie. the first unnamed parameter in the image markup). What you are asking for is to use the caption parameter of the infobox instead of the MediaWiki caption. That should be fixed in the infobox.

Sun, Aug 5, 1:21 PM · MediaWiki-extensions-MultimediaViewer, Multimedia
Tgr added a comment to T199590: Deprecate and remove $wgHashedUploadDirectory feature (always on).

$wgHashedUploadDirectory is just convenience for setting $wgLocalFileRepo (and the same goes for $wgHashedSharedUploadDirectory and $wgForeignFileRepos) so (as proposed) this wouldn't change the fact that a file repo can have an arbitrary level of hash directories (including zero).

Sun, Aug 5, 1:16 PM · Multimedia, Commons, Technical-Debt (Deprecation), MediaWiki-File-management
Tgr added a comment to T128394: Deprecate and remove User::isSafeToLoad.

I think this is way too harsh for the current MediaWiki hook system (which makes it pretty much impossible to predict when certain callbacks are going to run). Getting an anonymous user is not a big deal most of the time; getting an exception is. (Although arguably an anonymous user exposing the IP is problematic and maybe should be replaced with some kinda system user created for this purpose.)

Sun, Aug 5, 1:07 PM · Technical-Debt (Deprecation), MediaWiki-User-login-and-signup
Tgr added a comment to T110022: Create a library with HTTP related functions/code.

We'd basically map the exception class to a localisation message somewhere, quite similar to what we already do for various exception types in various places. Perhaps we could centralise that a bit within MediaWiki :)

Sun, Aug 5, 11:47 AM · Addwiki, Wikidata, Librarization
Tgr added a comment to T200997: Add raw HTML messages in WMF-deployed extensions to $wgRawHtmlMessages.
Sun, Aug 5, 11:10 AM · Patch-For-Review, Security-General, I18n, MediaWiki-Internationalization

Fri, Aug 3

Tgr added a comment to T187634: IRC integration for Discourse.

Asked about it upstream: https://meta.discourse.org/t/change-communication-with-matrix-from-notice-to-message/93874
Not sure what caused the bot to un-identify. Halted it for now.

Fri, Aug 3, 8:01 PM · Discourse
Tgr created T201200: Introduce soft assertions in MediaWiki.
Fri, Aug 3, 7:02 PM · Technical-Debt, MediaWiki-General-or-Unknown
Tgr added a comment to T200698: Merge two hewiki user groups.

Can you empty the old group? It should probably be removed from all users before the definition is deleted.

Fri, Aug 3, 1:40 PM · Patch-For-Review, User-Urbanecm, Wikimedia-Site-requests
Tgr added a comment to T200823: Site stats not updating when links added to pages.

Also, do we need to run initSiteStats.php on all wikis? (Is that even feasible on large ones?)

Fri, Aug 3, 1:38 PM · MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review, Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1), Regression, Core-Platform-Team, MediaWiki-General-or-Unknown
Tgr added a comment to T201157: [TemplateStyles] styles.css page is not included when exporting a template.

the styles.css page isn't transcluded into other pages (that is, it's not actually a template)

Fri, Aug 3, 1:33 PM · MediaWiki-Export-or-Import, TemplateStyles