TheDJ (Derk-Jan Hartman)
Volunteer developer

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:32 PM (176 w, 2 d)
Availability
Available
IRC Nick
thedj
LDAP User
TheDJ
MediaWiki User
TheDJ

Recent Activity

Today

TheDJ added a comment to T187955: Page preview shows icon instead of thumbnail.

For awareness, there were reports by users on the help desk and the VP/T of this issue.

Thu, Feb 22, 1:04 AM · Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), Page-Previews, Readers-Web-Backlog
TheDJ updated subscribers of T185552: Math rendering behavior change for \limits.

@Physikerwelt do you remember what was up with \operatorname* I remember at some point it wasn't supported by MathJax, but apparently now it is: https://github.com/mathjax/MathJax/issues/739

Thu, Feb 22, 12:56 AM · Mathoid, Math

Yesterday

Volker_E awarded T187808: Complete switch of toc styling from id #toc to class .toc a Grey Medal token.
Wed, Feb 21, 6:20 PM · Patch-For-Review, MediaWiki-Interface, CSS, Technical-Debt
zhuyifei1999 awarded T3790: Allow uploading of 3D files to Wikimedia Commons a Party Time token.
Wed, Feb 21, 3:56 PM · Community-Wishlist-Survey-2016, Wikimania-Hackathon-2016, Wikimedia-Hackathon-2016, MediaWiki-File-management, Community-Wishlist-Survey-2015, Commons, Contributors-Team, Epic, Multimedia
TheDJ closed T17449: Table sorting icons' alt text: ↓ and ↑ not showing up in IE as Declined.

The tablesorter hasn't used these arrows since 2010/2011.

Wed, Feb 21, 12:17 PM · TestMe, MediaWiki-Parser, Browser-Support-Internet-Explorer
TheDJ added a comment to T100081: Support point cloud files on commons.

Could some of the original authors of this tickets please update the description of this ticket with something more detailed than the one liner that is the result of the mentioned hackathon discussion ? :)

Wed, Feb 21, 12:03 PM · Discovery, MediaWiki-File-management, Maps, Commons, Multimedia
TheDJ added a parent task for T187844: Support the glTF 2.0 3D file format: T44725: Multimedia file format support (tracking).
Wed, Feb 21, 11:58 AM · Epic, Multimedia, 3D
TheDJ added a subtask for T44725: Multimedia file format support (tracking): T187844: Support the glTF 2.0 3D file format.
Wed, Feb 21, 11:58 AM · Tracking, Wikimedia-General-or-Unknown
TheDJ added a parent task for T187867: Support .blend files for 3D scenes/objects in Blender format: T44725: Multimedia file format support (tracking).
Wed, Feb 21, 11:58 AM · Multimedia, 3D
TheDJ added a subtask for T44725: Multimedia file format support (tracking): T187867: Support .blend files for 3D scenes/objects in Blender format.
Wed, Feb 21, 11:58 AM · Tracking, Wikimedia-General-or-Unknown
TheDJ closed T158830: Communicate enabling Extension:3d on Commons, a subtask of T3790: Allow uploading of 3D files to Wikimedia Commons, as Resolved.
Wed, Feb 21, 11:14 AM · Community-Wishlist-Survey-2016, Wikimania-Hackathon-2016, Wikimedia-Hackathon-2016, MediaWiki-File-management, Community-Wishlist-Survey-2015, Commons, Contributors-Team, Epic, Multimedia
TheDJ closed T158830: Communicate enabling Extension:3d on Commons as Resolved.

As there is now a blogpost on this, I'm calling it resolved. :)

Wed, Feb 21, 11:14 AM · Community-Liaisons (Jan-Mar-2018), Goal, Readers-Community-Engagement, Multimedia, Reading-Admin, Commons, Wikimedia-Blog-Content, 3D
TheDJ closed T3790: Allow uploading of 3D files to Wikimedia Commons as Resolved.

As there is now a blogpost on this, I'm calling it resolved.

Wed, Feb 21, 11:14 AM · Community-Wishlist-Survey-2016, Wikimania-Hackathon-2016, Wikimedia-Hackathon-2016, MediaWiki-File-management, Community-Wishlist-Survey-2015, Commons, Contributors-Team, Epic, Multimedia
TheDJ closed T3790: Allow uploading of 3D files to Wikimedia Commons, a subtask of T100081: Support point cloud files on commons, as Resolved.
Wed, Feb 21, 11:13 AM · Discovery, MediaWiki-File-management, Maps, Commons, Multimedia
TheDJ closed T3790: Allow uploading of 3D files to Wikimedia Commons, a subtask of T107410: Wiki 3d warehouse, as Resolved.
Wed, Feb 21, 11:13 AM · Possible-Tech-Projects, Maps, Commons, Discovery
TheDJ closed T3790: Allow uploading of 3D files to Wikimedia Commons, a subtask of T44725: Multimedia file format support (tracking), as Resolved.
Wed, Feb 21, 11:13 AM · Tracking, Wikimedia-General-or-Unknown
TheDJ added a comment to T187808: Complete switch of toc styling from id #toc to class .toc.

I've looked into this a little bit, but almost all of these cases still use tables (which the proper toc does no longer), or they have layouts that can be provided by maintained ToC templates, or they should be using wikitable class or completely different structures.

Wed, Feb 21, 10:37 AM · Patch-For-Review, MediaWiki-Interface, CSS, Technical-Debt
TheDJ added a comment to T184000: Magic word on English WP to override display of Wikidata short description.

@Tgr Hmm. I just realised that pageterms module also reflects the wikidata content in the language as indicated by uselang... that's another potential api breaking point.

Wed, Feb 21, 9:43 AM · Reading-Infrastructure-Team-Backlog (Kanban), MediaWiki-extensions-WikibaseClient, Wikidata, Community-Tech
TheDJ added a comment to T187808: Complete switch of toc styling from id #toc to class .toc.

Quite a few have id=toc AND class=toc, but yes, quite a few. Seems doable with an AWB run though.

Wed, Feb 21, 2:10 AM · Patch-For-Review, MediaWiki-Interface, CSS, Technical-Debt
TheDJ added a comment to T183869: Collect AICaptcha data from WikimediaEvents extension.

Is there a way to get data from such users specifically?
My hope is that the typing part (since everyone has to type during registration) is similar enough in all three cases and dissimilar enough from bots that all three get grouped together by the classifier. But we don't have any way currently to check if that really happens.

Wed, Feb 21, 1:55 AM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, MediaWiki-extensions-WikimediaEvents, AICaptcha

Tue, Feb 20

TheDJ added a comment to T183869: Collect AICaptcha data from WikimediaEvents extension.

I was unaware of this project and I have two questions:
1: can we use this to finally solve our problem with the accessibility of captchas for blind users ?
2: the machine learning part, can we make sure we not only identify ‘normal’ users, but also keyboard navigation and screenreader users, or at least be careful to not mark them as bots ?

Tue, Feb 20, 8:54 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, MediaWiki-extensions-WikimediaEvents, AICaptcha
TheDJ added a comment to T187636: tables with id "toc" are invisible in VisualEditor but can be (acidentally) deleted.

We should use .toc instead of #toc, I deprecated the latter in mw core a while ago.

Tue, Feb 20, 5:06 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), VisualEditor (Current work), VisualEditor-ContentEditable
TheDJ updated the task description for T187808: Complete switch of toc styling from id #toc to class .toc.
Tue, Feb 20, 5:01 PM · Patch-For-Review, MediaWiki-Interface, CSS, Technical-Debt
TheDJ created T187808: Complete switch of toc styling from id #toc to class .toc.
Tue, Feb 20, 5:01 PM · Patch-For-Review, MediaWiki-Interface, CSS, Technical-Debt
TheDJ added a comment to T187636: tables with id "toc" are invisible in VisualEditor but can be (acidentally) deleted.

We should use .toc instead of #toc, I deprecated the latter in mw core a while ago.

Tue, Feb 20, 4:27 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), VisualEditor (Current work), VisualEditor-ContentEditable
TheDJ added a comment to T187636: tables with id "toc" are invisible in VisualEditor but can be (acidentally) deleted.

It's actually the id #toc that these templates use that is the problem:

Tue, Feb 20, 4:15 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), VisualEditor (Current work), VisualEditor-ContentEditable
TheDJ renamed T187636: tables with id "toc" are invisible in VisualEditor but can be (acidentally) deleted from tables with class "toc" are invisible in VisualEditor but can be (acidentally) deleted to tables with id "toc" are invisible in VisualEditor but can be (acidentally) deleted.
Tue, Feb 20, 4:14 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), VisualEditor (Current work), VisualEditor-ContentEditable
TheDJ triaged T187780: Historical diffs should be hidden when user agent has disabled Javascript as Lowest priority.
Tue, Feb 20, 1:51 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), VisualEditor (Current work), VisualEditor-VisualDiffs
TheDJ created T187780: Historical diffs should be hidden when user agent has disabled Javascript.
Tue, Feb 20, 1:45 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), VisualEditor (Current work), VisualEditor-VisualDiffs
TheDJ updated the task description for T187757: Thanks thanking the wrong edit.
Tue, Feb 20, 11:24 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice, Thanks
TheDJ awarded T187749: Make it possible to use code from an external repository for editor-controlled Javascript/CSS a Love token.
Tue, Feb 20, 11:08 AM · MediaWiki-extension-requests, User-Tgr, Security-General, JavaScript, Gadgets
TheDJ awarded T185383: iabot flagged as a malicious agent by external sites a Barnstar token.
Tue, Feb 20, 11:05 AM · InternetArchiveBot (v1.6), cloud-services-team, Tools
TheDJ added a comment to T184000: Magic word on English WP to override display of Wikidata short description.

@Tgr I'm assuming no markup (like in wikidata). What about text length restrictions ?

Tue, Feb 20, 10:54 AM · Reading-Infrastructure-Team-Backlog (Kanban), MediaWiki-extensions-WikibaseClient, Wikidata, Community-Tech

Mon, Feb 19

TheDJ added a comment to T187616: "element.setAttribute is not a function" error due to comment nodes, when switching to historic visual diff.

Small note, it seems that the following patchset of T187070, will make changes in this area already, not sure what the effect will be.

Mon, Feb 19, 2:14 PM · VisualEditor-VisualDiffs, VisualEditor
TheDJ awarded T187070: Investigate the performance of visual diffs when user pastes a huge, complex article into another one a Like token.
Mon, Feb 19, 2:11 PM · VisualEditor (Current work), Patch-For-Review, Performance, VisualEditor-VisualDiffs
TheDJ renamed T187726: Historical Visual diff annotation column overlaps other content in certain diffs from Visual diff annotation column overlaps other content to Historical Visual diff annotation column overlaps other content in certain diffs.
Mon, Feb 19, 2:09 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), VisualEditor (Current work), VisualEditor-VisualDiffs
TheDJ created T187726: Historical Visual diff annotation column overlaps other content in certain diffs.
Mon, Feb 19, 2:08 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), VisualEditor (Current work), VisualEditor-VisualDiffs
TheDJ renamed T187616: "element.setAttribute is not a function" error due to comment nodes, when switching to historic visual diff from "element.setAttribute is not a function" error when switching to historic visual diff due to comment nodes to "element.setAttribute is not a function" error due to comment nodes, when switching to historic visual diff.
Mon, Feb 19, 2:03 PM · VisualEditor-VisualDiffs, VisualEditor
TheDJ renamed T187616: "element.setAttribute is not a function" error due to comment nodes, when switching to historic visual diff from "element.setAttribute is not a function" error when switching to historic visual diff to "element.setAttribute is not a function" error when switching to historic visual diff due to comment nodes.
Mon, Feb 19, 2:03 PM · VisualEditor-VisualDiffs, VisualEditor
TheDJ added a comment to T187616: "element.setAttribute is not a function" error due to comment nodes, when switching to historic visual diff.

nodeType = 8 (comment), which indeed has no setAttribute of course.

Mon, Feb 19, 2:03 PM · VisualEditor-VisualDiffs, VisualEditor
TheDJ claimed T187710: Transcluding Special:Contributions adds JS to the destination page and throws JS error.
Mon, Feb 19, 11:56 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), UI-Standardization, MediaWiki-Special-pages, JavaScript
TheDJ triaged T187710: Transcluding Special:Contributions adds JS to the destination page and throws JS error as Lowest priority.
Mon, Feb 19, 11:56 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), UI-Standardization, MediaWiki-Special-pages, JavaScript
TheDJ created T187710: Transcluding Special:Contributions adds JS to the destination page and throws JS error.
Mon, Feb 19, 11:50 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), UI-Standardization, MediaWiki-Special-pages, JavaScript
Amire80 awarded T171180: Gadget with target=mobile should not be enqueued on desktop (Warning from mw.loader.load) a Like token.
Mon, Feb 19, 10:40 AM · Gadgets
TheDJ awarded T187591: TMH file pages on PHP 7.2: "Warning: A non-numeric value encountered in includes/Message.php on line 1363" a Love token.
Mon, Feb 19, 10:00 AM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, TimedMediaHandler

Fri, Feb 16

TheDJ added a comment to T166024: Once it's not patent-encumbered, enable MPEG-2 support for Commons uploads and TMH/etc. playback.

If you are concerned of DVD rips, these used to be either the full .iso's rips, or they were the VIDEO_TS folders within them. VIDEO_TS is a structure around mpeg-ps files that includes the DVD metadata etc. BTW. DVDs are kinda special, if you'd play their raw files then likely you wouldn't enjoy the movie much, as they are divided in chapters, and sometimes this is quite messy.

Fri, Feb 16, 10:15 AM · Patch-For-Review, UploadWizard, TimedMediaHandler, WMF-Legal, Commons, Multimedia

Thu, Feb 15

TheDJ added a comment to T187044: Navigation Popups remain when a link is hoovered on Recent Changes, using live update mode and Chrome.

I couldn't reproduce it either. But, i wouldn't be surprised if there are some timing issues / race conditions. I don't think any one of us really understands how this code works/behaves, so :)

Thu, Feb 15, 1:24 PM · Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage, Navigation-Popups
TheDJ added a comment to T164511: Better indicate to users that 3D models can be interacted with.

This is a link of a video of what FB uses right now for 360 panorama controls.

  • It has the 360 degree animation in the center straight after initial loading, this disappears quickly and is to be able to quickly recognise this content.
  • Then it has the 'orientation' compass in the the top right, which indicates the current angle within the panorama. This is permanently present.
  • And lastly at the bottom, after a few seconds, it will show an animated 'how-to' to explain how to change the orientation. This is platform dependent. On desktop it tells you u can use a mouse drag, on mobile it tells you to rotate your phone. This is on screen long enough for people to process the instructions, about 3 seconds. It will not show if you already engaged with the content.
Thu, Feb 15, 10:36 AM · Design, Multimedia, 3D
TheDJ added a comment to T166024: Once it's not patent-encumbered, enable MPEG-2 support for Commons uploads and TMH/etc. playback.

This task first needs to answer, in which file format it wants to support the codec. Codec detection happens in the file format parsing, so for each file format you want the codec to be supported in, you will have to take separate technical steps on that level (and thus likely separate tickets).

Thu, Feb 15, 9:26 AM · Patch-For-Review, UploadWizard, TimedMediaHandler, WMF-Legal, Commons, Multimedia
TheDJ added a comment to T166025: Once it's not patent-encumbered, enable AAC-LC support for Commons uploads and TMH/etc. playback.

This task first needs to answer, in which file format it wants to support the codec. Codec detection happens in the file format parsing, so for each file format you want the codec to be supported in, you will have to take separate technical steps on that level (and thus likely separate tickets).

Thu, Feb 15, 9:26 AM · UploadWizard, TimedMediaHandler, WMF-Legal, Commons, Multimedia

Wed, Feb 14

TheDJ added a comment to T184000: Magic word on English WP to override display of Wikidata short description.

I'll remind everyone that any sort of community RFC only has an advisory influence to development. Development is not and never has been subject to any individual wiki's consensus model, which is something a certain subset of the community seems to have convinced themselves off. They exist as two cross pollinating pillars of the movement.

Wed, Feb 14, 11:25 AM · Reading-Infrastructure-Team-Backlog (Kanban), MediaWiki-extensions-WikibaseClient, Wikidata, Community-Tech
TheDJ awarded T187261: Showing Commons 3D file on a local Wikpedia file page results into a warning "...malicious code" a Love token.
Wed, Feb 14, 11:06 AM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Multimedia-Team-Working-Board, Multimedia, 3D
TheDJ added a comment to T39192: Add syntax highlight for AbuseFilter.

Seems to me like it should be possible to have CodeEditor as an optional dependency.

Wed, Feb 14, 9:57 AM · Patch-For-Review, Contributors-Team, AbuseFilter
TheDJ added a comment to T187285: Magic word on English WP to replace Wikidata short descriptions.

As on Wikipedia, we don't do content splits over differences in opinion.

Wed, Feb 14, 9:19 AM · MediaWiki-extensions-WikibaseClient, Wikidata
TheDJ merged T187285: Magic word on English WP to replace Wikidata short descriptions into T184000: Magic word on English WP to override display of Wikidata short description.
Wed, Feb 14, 9:19 AM · Reading-Infrastructure-Team-Backlog (Kanban), MediaWiki-extensions-WikibaseClient, Wikidata, Community-Tech
TheDJ merged task T187285: Magic word on English WP to replace Wikidata short descriptions into T184000: Magic word on English WP to override display of Wikidata short description.
Wed, Feb 14, 9:19 AM · MediaWiki-extensions-WikibaseClient, Wikidata

Tue, Feb 13

TheDJ added a comment to T39192: Add syntax highlight for AbuseFilter.

Well, 410173 needs to be merged or jenkins won't test the commit. BTW, I'm testing this latest build and it seems to work, except for a thing: if I Ctrl+f inside the edit box, the searchbox won't show up and instead in JS console I get: Refused to execute script from 'xxxxxxxx/Speciale:FiltroAntiAbusi/ext-searchbox.js' because its MIME type ('text/html') is not executable, and strict MIME type checking is enabled." With the previous build I could fix this by adding ext-searchbox to extension.json, though I don't know how to fix it now :D

CodeEditor had the ext-searchbox.js file, but it doesn't seem to be loaded into a RL module. A patch to CodeEditor should be easy enough to fix that

Tue, Feb 13, 3:34 PM · Patch-For-Review, Contributors-Team, AbuseFilter
TheDJ added a comment to T39192: Add syntax highlight for AbuseFilter.

For some reason my gerrit access isn't working, so leaving a comment here. I suspect the current proposed patch might break when a user has JS disabled in his browser. Please double check (we have quite a few admins who disable JS). Looking pretty spiffy otherwise, but i'd have to setup vagrant + AF at home for a proper test.

Tue, Feb 13, 2:31 PM · Patch-For-Review, Contributors-Team, AbuseFilter
TheDJ added a comment to T39192: Add syntax highlight for AbuseFilter.

@Daimona ext.codeEditor.ace is just the ace files from CodeEditor:
https://github.com/wikimedia/mediawiki-extensions-CodeEditor/blob/master/extension.json#L78

Tue, Feb 13, 1:19 PM · Patch-For-Review, Contributors-Team, AbuseFilter
TheDJ added a comment to T39192: Add syntax highlight for AbuseFilter.

Well you can at least just load the RL module "ext.codeEditor.ace"

Tue, Feb 13, 1:01 PM · Patch-For-Review, Contributors-Team, AbuseFilter
TheDJ added a comment to T183991: UI for notifying users about data collection.

@Nirzar. "about you to detect bots"

Tue, Feb 13, 10:47 AM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, AICaptcha

Mon, Feb 12

TheDJ updated the task description for T187071: Investigate performance of old diff system where user pastes a huge, complex article into another one.
Mon, Feb 12, 2:28 PM · Performance, VisualEditor-VisualDiffs, VisualEditor
TheDJ added a comment to T187071: Investigate performance of old diff system where user pastes a huge, complex article into another one.

I've done both (wiki text diff and visual diff) and i've been able to reproduce a browser lock up in both situations (took a few tries) (with Safari in my case). I think we should recognise that certain levels of complexity will cause problems, and that we need to make sure that we fail safely in those cases, and communicate this to the user.

Mon, Feb 12, 2:27 PM · Performance, VisualEditor-VisualDiffs, VisualEditor
TheDJ triaged T181712: Navigation popup repositions on open as Lowest priority.

Popups has some very primitive lazy loading logic and no fixed width. This is a bit outdated honestly.. I've made a small change to call limitHorizontalPosition from showSoonIfStable, though the whole logic here is quite convoluted.. Hopefully this improves it slightly

Mon, Feb 12, 1:45 PM · Navigation-Popups
TheDJ moved T187064: Navigation popups ignores bad image list from Backlog to Technical debt backlog on the Navigation-Popups board.
Mon, Feb 12, 1:40 PM · Navigation-Popups
TheDJ triaged T187064: Navigation popups ignores bad image list as Low priority.
Mon, Feb 12, 1:01 PM · Navigation-Popups
TheDJ added a parent task for T138803: Use action=parse to get previews: T187064: Navigation popups ignores bad image list.
Mon, Feb 12, 1:01 PM · Navigation-Popups
TheDJ added a subtask for T187064: Navigation popups ignores bad image list: T138803: Use action=parse to get previews.
Mon, Feb 12, 1:01 PM · Navigation-Popups
TheDJ created T187064: Navigation popups ignores bad image list.
Mon, Feb 12, 1:00 PM · Navigation-Popups
TheDJ closed T184324: Navigation popups gadget minor issues as Resolved.

1: is because popups uses it's own parser. See also T138803: Use action=parse to get previews for very long term goals.
2: Fixed by setting word-wrap: break-word on the CSS of navigation popups.

Mon, Feb 12, 12:49 PM · Navigation-Popups
TheDJ removed a project from T187011: Desktop diff-view has lesser functionality than the mobile version: Community-Tech.

Don't see how community tech team is involved here.. Please don't use them as an inbox for "anything that the community finds regarding technology".

Mon, Feb 12, 12:38 PM · Edit-Review-Improvements, Collaboration-Team-Triage, MediaWiki-History-or-Diffs

Sun, Feb 11

TheDJ closed T186844: Media viewer discarding sub / sup markup in captions as Resolved.

I noticed "span" is in the list at mmv.HtmlUtils.js - will that drag any inline "style=" markup with it if attached to the span?

I guess so.

Sun, Feb 11, 12:52 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), MediaWiki-extensions-MultimediaViewer, Readers-Web-Backlog, Multimedia

Fri, Feb 9

TheDJ added a comment to T180972: Create prototype for new edit conflict merge approach.

From what I've seen, this seems a LOT better than the previous prototype. Really liking it so far, nice work !

Fri, Feb 9, 1:08 PM · WMDE-QWERTY-Team-Board, Two-Column-Edit-Conflict-Merge, Design, TCB-Team, WMDE-Design
Jan_Dittrich awarded T186875: Selected state of radio buttons for merge interface not accessible to those with visual impairments a Love token.
Fri, Feb 9, 1:07 PM · Accessibility, WMDE-QWERTY-Team-Board, Design, Two-Column-Edit-Conflict-Merge, WMDE-Design, TCB-Team
Jan_Dittrich awarded T186875: Selected state of radio buttons for merge interface not accessible to those with visual impairments a Love token.
Fri, Feb 9, 1:06 PM · Accessibility, WMDE-QWERTY-Team-Board, Design, Two-Column-Edit-Conflict-Merge, WMDE-Design, TCB-Team
TheDJ added a comment to T152139: Update Maintenance scripts in extensions to use $this->requireExtension().

I have a question. Maintenance::requireExtension() is used to load the extension. But how does it load the extension? Via extension.json?

Fri, Feb 9, 1:06 PM · Need-volunteer, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Easy, Google-Code-In-2016, MediaWiki-extensions-General, MediaWiki-Maintenance-scripts
TheDJ added a comment to T152139: Update Maintenance scripts in extensions to use $this->requireExtension().

This will only work for extensions that use extension.json.

So should RevisionCommentSupplement extension be ruled out? This extension does not have extension.json.

Fri, Feb 9, 1:04 PM · Need-volunteer, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Easy, Google-Code-In-2016, MediaWiki-extensions-General, MediaWiki-Maintenance-scripts
TheDJ added a project to T186875: Selected state of radio buttons for merge interface not accessible to those with visual impairments: Accessibility.
Fri, Feb 9, 12:55 PM · Accessibility, WMDE-QWERTY-Team-Board, Design, Two-Column-Edit-Conflict-Merge, WMDE-Design, TCB-Team
TheDJ triaged T186875: Selected state of radio buttons for merge interface not accessible to those with visual impairments as Normal priority.
Fri, Feb 9, 12:55 PM · Accessibility, WMDE-QWERTY-Team-Board, Design, Two-Column-Edit-Conflict-Merge, WMDE-Design, TCB-Team
TheDJ added a comment to T184993: Have a tour to introduce the new Interface.

Might require a bit more attention to narrow screens :)

Fri, Feb 9, 12:46 PM · User-Addshore, WMDE-QWERTY-Sprint-2018-02-06, Patch-For-Review, WMDE-QWERTY-Sprint-2018-01-23, WMDE-QWERTY-Team-Board, TCB-Team, Two-Column-Edit-Conflict-Merge, WMDE-Design (WMDE-Design-Workboard Doing), Design
TheDJ added a comment to T186844: Media viewer discarding sub / sup markup in captions.

These elements are intentionally filtered, but i see no reason not to add sub and sup to the whitelisted elements.

Fri, Feb 9, 9:45 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), MediaWiki-extensions-MultimediaViewer, Readers-Web-Backlog, Multimedia

Thu, Feb 8

TheDJ added a comment to T107561: MediaWiki support for Composer equivalent for JavaScript packages.

Note.. I suspect that package.lock is not supported by the version of npm that we currently run in production ?

Thu, Feb 8, 5:45 PM · Performance-Team, MediaWiki-ResourceLoader, Developer-Wishlist (2017), TechCom-RFC, Front-end-Standards-Group
TheDJ added a subtask for T176558: AJAX "Show changes" doesn't work when creating a page: "TypeError: response[0].query.pages[0].revisions is undefined": T109166: Show changes in Live preview indicates no changes in a brand new page, data loss results.
Thu, Feb 8, 5:37 PM · MediaWiki-Page-editing
TheDJ added a parent task for T109166: Show changes in Live preview indicates no changes in a brand new page, data loss results: T176558: AJAX "Show changes" doesn't work when creating a page: "TypeError: response[0].query.pages[0].revisions is undefined".
Thu, Feb 8, 5:37 PM · Patch-Needs-Improvement, MediaWiki-API, MediaWiki-Page-editing
TheDJ added a comment to T156548: Disallow adding Czech language tag (cs-CZ) into citation templates on cswiki.

When I read: "I do not understand why developers do not want to accept the fact that each Wiki has citation templates built a little differently and according to some other standards."

Thu, Feb 8, 3:49 PM · Wikimedia-Site-requests, Citoid, VisualEditor
TheDJ added a comment to T184000: Magic word on English WP to override display of Wikidata short description.

improve communication with developers

Thu, Feb 8, 1:13 PM · Reading-Infrastructure-Team-Backlog (Kanban), MediaWiki-extensions-WikibaseClient, Wikidata, Community-Tech

Wed, Feb 7

TheDJ added a comment to T186636: Only show 15px of left margin from historical visual diffs when the diff contains a move.

I like that solution Ed ! nice work.

Wed, Feb 7, 4:05 PM · Verified, MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), User-Ryasmeen, VisualEditor-VisualDiffs, VisualEditor
TheDJ added a comment to T100106: Replace Kaltura player with Video.js.

And a list of some of my abandoned work for TMH: https://gerrit.wikimedia.org/r/#/q/status:abandoned+project:mediawiki/extensions/TimedMediaHandler+owner:TheDJ

Wed, Feb 7, 3:14 PM · Performance-Team (Radar), Multimedia, TimedMediaHandler-Player, Wikimedia-Video, Wikimedia-Hackathon-2015, TimedMediaHandler
TheDJ added a comment to T185263: Add audio/video subtitles to media endpoint response?.

When dealing with this, please take note of T111552: Create an API to serve subtitles

Wed, Feb 7, 3:09 PM · Reading-Infrastructure-Team-Backlog, Page Content Service, Reading Epics (Platform JS CSS and HTML consolidation)
TheDJ added a comment to T184871: Add encoding HTML header to LilyPond output.

While you are at it, you could also use Content-Disposition header to make browser download it, and to name the downloaded file.

Wed, Feb 7, 10:49 AM · MediaWiki-extensions-Score
TheDJ added a comment to T184871: Add encoding HTML header to LilyPond output.

I'd just use Content-Type: text/x-lilypond; charset=utf-8. A convention good enough for KDE, seems good enough to follow for us.

Wed, Feb 7, 10:48 AM · MediaWiki-extensions-Score

Tue, Feb 6

TheDJ added a comment to T185708: Make historical VisualDiffs a BetaFeature.


Any reason the visualdiff content adds 15px of left padding ? It's a bit jarring for historical diffs, as it messes with the alignment in the view, which gives it a more 'busy' look then needed.

Tue, Feb 6, 4:20 PM · Verified, VisualEditor (Current work), User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), User-notice, Beta-Feature, VisualEditor-VisualDiffs
TheDJ added a comment to T100106: Replace Kaltura player with Video.js.

On the topic of audio subtitles:
https://github.com/walsh9/videojs-transcript

Tue, Feb 6, 3:43 PM · Performance-Team (Radar), Multimedia, TimedMediaHandler-Player, Wikimedia-Video, Wikimedia-Hackathon-2015, TimedMediaHandler
TheDJ added a comment to T183704: class="wikitable plainrowheaders" does not work in mobile.

@Izno, ah right. It's because Minerva on Desktop does load MediaWiki:Common.css and Minerva on mobile does not. So yes. For things in Common.css, their counterpart should be Mobile.css. For things usually in Vector.css -> Minerva.css

Tue, Feb 6, 3:29 PM · Reading-Web-Local-Wiki-Issues, CSS, MediaWiki-jQuery-Tablesorter
TheDJ closed T185129: Download as PDF feature is producing tiny font sizes as Resolved.
Tue, Feb 6, 2:05 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Easy, CSS, Electron-PDFs, Readers-Web-Backlog
TheDJ closed T181432: [BUG] Some articles are showing with horizontal scrolling as Resolved.

I adapted the lua module to have the noresize class

Tue, Feb 6, 1:57 PM · Verified, Reading-Web-Local-Wiki-Issues, Graphs, Readers-Web-Backlog (Tracking), MobileFrontend, Wikipedia-Android-App-Backlog, Android-app-Bugs
TheDJ added a comment to T183704: class="wikitable plainrowheaders" does not work in mobile.

no, minerva.css

Tue, Feb 6, 12:34 PM · Reading-Web-Local-Wiki-Issues, CSS, MediaWiki-jQuery-Tablesorter
TheDJ added a comment to T186458: Bug in image sizes in mobile view on Meta.

@Mrjohncummings that template is broken. I'll look at it in a bit. In the mean time, i applied a bit of flex box layout to that primary page.

Tue, Feb 6, 12:31 PM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, MinervaNeue
TheDJ added a comment to T186458: Bug in image sizes in mobile view on Meta.

Ideally that whole page would be built with flex box layouting, but we sort of need TemplateStyles for that, otherwise it will be hella messy.

Tue, Feb 6, 10:39 AM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, MinervaNeue
TheDJ added a comment to T186458: Bug in image sizes in mobile view on Meta.

Don't use tables :)

Tue, Feb 6, 10:31 AM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, MinervaNeue