# User Details

User Since
Oct 6 2014, 10:32 PM (196 w, 6 d)
Availability
Available
IRC Nick
thedj
LDAP User
TheDJ
MediaWiki User
• Open Source dev since 2001
• Wikipedian since 2005
• MediaWiki dev (+2) since 2009

Uses Safari most of the time (because someone has to)

# Sat, Jul 14

Most tasks are neglected, because we have too much stuff to do. Trying to “me first” a task will not change that, just annoy people.

# Fri, Jul 13

TheDJ added a comment to T199041: Pswikivoyage content pages counting issues.

So what led you to conclude that you have over 360 content pages then ? Where is that number coming from ?

# Thu, Jul 12

Will need a fix for the api module. Makes me wonder what the implied behavior of isAllowed (and the corresponding api flag) is actually supposed to be. Would be nice if we could track down what the original intent was 'relevant to the user' or 'allowed for the user'. Did the first just get slapped onto the latter ?

TheDJ triaged T199478: Gadgets should use the current skin, instead of the skin preference as Normal priority.

It's a simple fix, but it was stalled waiting review. If the issue is still relevant a year and half later and someone wants to review I'm happy to rebase. The main thing I personally wasn't sure of was if my test was any good or made any sense.

TheDJ added a comment to T199150: Audio player is non-functional on first load in Chrome.

See it on Safari too at times. Cause is more likely that they use Javascript to move the fragment, while the player is loading. This probably messes up some logic. They should be using something like https://www.mediawiki.org/wiki/Help:Page_status_indicators instead.

# Wed, Jul 11

TheDJ renamed T199366: Allow InputBox parameters to be defined as XML attributes from Allow InputBox parameters to be defined as XML attributes to Allow InputBox parameters to be defined as HTML attributes.

# Tue, Jul 10

TheDJ added a comment to T199258: Make global preferences global.

You do not need check all wikis, just to have a hardcoded list of extensions that use global preferences.

TheDJ added a comment to T199258: Make global preferences global.

For example, It includes education extension notifications only on wikis that have this extension deployed. [..] This means, for example, that all extensions in the world should be there, in any wiki, so this page will be the same on all wikis.

TheDJ added a comment to T199258: Make global preferences global.

New issues require new tickets. Which is not the same as sub tickets. subtickets are 'a part of' a parent task. Normally, they would be resolved before a parent task ever can be resolved. Here the parent task can be resolved without implementing this ticket.

# Mon, Jul 9

TheDJ added a comment to T197655: <mapframe> JavaScript runtime error.

wgKartographerMapServer is provided by module ext.kartographer, which is a dependency of ext.kartographer.box, but is not a dependency of ext.kartographer.settings. That seems like a mistake in the RL definitions indeed.

Another example: https://nl.wikipedia.org/w/index.php?title=Wikipedia:De_kroeg&oldid=51923141#<mapframe>
Compare the 2nd and the 3rd map in that row.

TheDJ updated the task description for T193455: <mapframe>: Automatic zoom and centering only works on page preview.

@Mholloway we have since concluded that T193455: <mapframe>: Automatic zoom and centering only works on page preview is a more likely match of the issue described.

TheDJ edited Description on Discovery.
TheDJ edited Description on Discovery.
TheDJ added a comment to T197735: Kartographer full page view cuts off longer captions.

Can you please provide links for the items shown in the screenshots ?

The ground work for this has been done, but it is not actually used. Depends on volunteers building new tools that work with the production services.

Some of this has happened, esp since T172065: Hunt for Toolforge tools that load resources from third party sites became more of an issue.

TheDJ closed T137255: Establish map search goals as Declined.

Seems this never really got off the ground

TheDJ closed T137255: Establish map search goals, a subtask of T137254: Improve map search, as Declined.
TheDJ closed T103801: *.tiles.wmflabs.org should be served over https as Resolved.

It seems that at some point this was resolved.

Not even in 8 years ?

TheDJ placed T156330: Motorway links missing from Maps up for grabs.

I guess at the very least this is no longer on your plate ;)

That distinction is internal politics to me. Effectively, i'm waiting on a product manager to be made available to do his work.

TheDJ reopened T156330: Motorway links missing from Maps as "Stalled".

It has been decided that because we don't have a dedicated user-focused product manager for maps changes we can't make material product changes for maps, so the new styles work will not be deployed.

Considering this closed

# Sat, Jul 7

TheDJ added a comment to T178370: Automatic zoom and positioning doesn't work for geomasks.

Are we sure this is just with wikidata ids etc ? I see something like this with even a simple .map page

<mapframe width=300 height=300 zoom=17>
{
"type": "ExternalData",
"service": "page",
"title": "Haarlem/Grote Kerk.map"
}
</mapframe>

Rendered on nl.wp, as if it is located in Algeria instead of in Utrecht, Netherlands

Are we sure this is just with wikidata ids etc ? I see something like this with even a simple .map page

# Wed, Jul 4

TheDJ added a comment to T197534: CodeMirror toggle buttons need to indicate the current state.

asked for a distinguished tooltip which tells a blind user the current state of the toggle.

We don't use tooltips for that, we use aria state, the screenreader should be able to communicate this information just fine.

# Wed, Jun 27

Some minor bootstrap like changes:

        /* equal cells which wrap, with 1em of space in between */
.mw-rcfilters-ui-row {
display:flex;
flex-wrap: wrap;
justify-content: space-between;
margin: 0 -0.5em;
}
.mw-rcfilters-ui-cell {
flex: 1 1;
}
/* overrides */
.mw-rcfilters-ui-watchlistTopSectionWidget-watchlistDetails {
min-width: 20em;
}
.mw-rcfilters-ui-watchlistTopSectionWidget-editWatchlistButton,
.mw-rcfilters-ui-filterTagMultiselectWidget-cell-save,
.mw-rcfilters-ui-filterTagMultiselectWidget-cell-reset,
.mw-rcfilters-ui-filterTagMultiselectWidget-views-select,
align-self: flex-end;
flex: 0 1;
}
.mw-rcfilters-ui-filterTagMultiselectWidget-views-select {
}
.mw-rcfilters-ui-filterTagMultiselectWidget-views-input {
}
.mw-rcfilters-ui-filterTagMultiselectWidget-views-select {
/* This a bug in the current styling ? */
width: auto;
}
.mw-rcfilters-ui-watchlistTopSectionWidget-editWatchlistButton .oo-ui-buttonWidget {
margin-left: 0;
}

same style, without even using media queries to further optimize

TheDJ added a comment to T198276: VE Wikitext editor cursor is misplaced on Minerva desktop.

The surfaces ve-ce-documentNode and CodeMirror don't overlap. I could fix the problem by setting a 1.5em padding on CodeMirror, to match what the document node has in padding. We need to check how the settings are adapted for things like monobook.

# Sun, Jun 24

@Deneben No they are hard requirements for all new software deployed to Wikimedia properties, and we are continuously fixing and reworking the last of the existing code that doesn't comply with it yet. JS causing reflowing is the latest focus of the now 6 year effort to improve performance of MediaWiki and Wikipedia.

# Sat, Jun 23

Please note your browser and version, the wiki in question etc etc etc.

Dear TheDJ,

At English Wikinews we are being told a configuration change would be made by WMF even though local consensus (so far I think about 4 people had their say and said 'no') is against it. Surely this should not happen? I was assuming there is an open ticket somewhere and this is it.

TheDJ updated subscribers of T20871: Include at least some EXIF metadata in resized pictures.

All filetypes ?

It's actually bothering me, because i use vector in responsive mode, so i might get around to it at some point ;)

This feels like something that should be fixed with some flexbox magic. ;)

Then we force everyone who should be concerned about it to give us feedback before putting further work into it.

@TheDJ Since you were involved in the client-side mathjax project of the past, it would be nice if you could help us to avoid problems that killed it last time.

# Tue, Jun 19

@Base please don't use words as 'corrupted'. It's not conductive to the conversation.

TheDJ added a comment to T197622: [wmf.8] Misplaced 'x' on the first load on Watchlist page .

FYI, production has a similar problem in Monobook.

TheDJ added a comment to T197534: CodeMirror toggle buttons need to indicate the current state.

@matmarex the state is, it works, it's accessible, but it's just... a kludge on top of wiki editor ;)

# Mon, Jun 18

TheDJ added a comment to T174635: Middle-click to paste text doesn't work in CodeMirror on Linux.

@Pamputt I consider https://github.com/codemirror/CodeMirror/issues/931 to be the upstream ticket and it clearly indicates that it is not yet fixed, and that the FF fixes are imcomplete.

# Sun, Jun 17

TheDJ closed T13627: Add syntax highlighting to Edit box as Resolved.

With MediaWiki-extensions-CodeMirror now deployed, I'm calling this fixed.

i'm pretty sure this was fixe a while ago.

TheDJ added a project to T197239: CodeMirror – icon extends from bar: WikiEditor.

I've checked. The other buttons have the same issue, it's just that they don't have an outline and backgroundcolor set as this button does in the active state.

TheDJ added a comment to T196512: CodeMirror load breaks at \$button.toggleClass(...) .

Ah, I found this too.

TheDJ changed the status of T174635: Middle-click to paste text doesn't work in CodeMirror on Linux from Open to Stalled.

This ticket is stalled on the upstream issue.

TheDJ added a comment to T197534: CodeMirror toggle buttons need to indicate the current state.

Hmm, this proved more annoying than i figured. Notes

TheDJ added a comment to T197534: CodeMirror toggle buttons need to indicate the current state.

Just tried it again in FF on my mac, and for me tab moves to the editsummary. This matches what is defined in the code, which basically tells CodeMirror to ignore interpreting tabs (Same spot as where my patch will disable shift-tab)

TheDJ added a comment to T197534: CodeMirror toggle buttons need to indicate the current state.

With CodeMirror enabled, ⇥ in edit textarea has another effect and does not navigate any longer through the form

# Jun 15 2018

TheDJ added a comment to T197087: Remove or limit edituserjs and similar rights.

There is also the ease of it--TheDJ would have to fork the page in question, make the changes, then ask the user to copy his changes, and then nuke whatever copy he had made, if he could not edit the pages directly. This ease is valuable (for the same reason that it is a dangerous vector).

TheDJ added a comment to T189806: Deploy GlobalPrefs on production.

@Niharika now filed separately as T197450: test.wp is using test2.wp's message cache

# Jun 14 2018

TheDJ added a project to T30684: Collapse templates in editor: MediaWiki-extensions-CodeMirror.

This should probably be moved to the CodeMirror functionality now.

TheDJ added a comment to T197263: insertTags shift cursor position to start of the line.

It's not the same issue I think. I had breakpoints on all the textSelection functions and this setSelection is the last in the sequence, and I just verified with codemirror.doc.getCursor() in the console that the setFocus() causes the move of the cursor.

TheDJ added a comment to T184857: Problems with editing huge pages.

workTime, workDelay: number
Highlighting is done by a pseudo background-thread that will work for workTime milliseconds, and then use timeout to sleep for workDelay milliseconds. The defaults are 200 and 300, you can change these options to make the highlighting more or less aggressive.

TheDJ awarded T197070: +2 for MarcoAurelio in mediawiki/* a Like token.
TheDJ added a comment to T189806: Deploy GlobalPrefs on production.

Not sure where this project is, but I just noticed that on test.wikipedia.org, I see the gadgets from test2.wikipedia.org

# Jun 13 2018

TheDJ added a comment to T197035: Do not print navboxes.

Ideally, it would be cool if we could detect problems like this, so that local communities can be more aware. Something like Special:Linter but for common mobile and print problems that we detect and then linking to advise on how to fix etc..

wasn't page previews set like that because it'd conflict

No, it has a separate mechanism for that, which just stops it from presenting when it detects that Navigation Popups is active (so not really disabled, just not showing).

# Jun 12 2018

TheDJ added a comment to T197035: Do not print navboxes.

enwiki hides them through https://en.wikipedia.org/wiki/MediaWiki:Print.css

Why doesnt the watchstar work without javascript ? No link fallback ? Shouldnt it have that ?

# Jun 11 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rEWIS68b66cac5e9b: Update patch set 1 (authored by TheDJ).
Update patch set 1
Gerrit Code Review <gerrit@wikimedia.org> committed rEWIS22bade89e4c2: Update patch set 1 (authored by TheDJ).
Update patch set 1

# Jun 10 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rESCC9d54312dd5a6: Update patch set 1 (authored by TheDJ).
Update patch set 1
Gerrit Code Review <gerrit@wikimedia.org> committed rERSLbf526ef360f3: Update patch set 1 (authored by TheDJ).
Update patch set 1

# Jun 8 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rQUIBBLE77c1eb7ff672: Update patch set 1 (authored by TheDJ).
Update patch set 1

# Jun 7 2018

TheDJ added a comment to T195256: Implement accessibility jump links with pure CSS.

@Volker_E the intent was using it for ourselves, not for script authors. Easier to find back than a freeform todo comment in some random repo. Also scannable with automation tools within the live website, which seems like it could be useful

TheDJ added a comment to T195256: Implement accessibility jump links with pure CSS.

@Krinkle As i was reading your commit i came up with #jump-to-nav:not(:empty)
I was also thinking: If we leave dom in place that is deprecated, for the sake of scripts... What if we add a class="mw-deprecated" or something to that ?

# Jun 5 2018

I'm not very familiar with the way MediaWiki is structured, so I'm curious to learn more. Why does mw core care about the CSS of a skin?

# Jun 4 2018

TheDJ added a comment to T195256: Implement accessibility jump links with pure CSS.

Hmm, I think we need to remove:

	#jump-to-nav {
/* Negate #contentSub's margin and replicate it so that the jump to links don't affect the spacing */
margin-top: -1.4em;
margin-bottom: 1.4em;
}

https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.skinning/interface.css#L66

# Jun 2 2018

TheDJ added a comment to T196213: Set mobile breakpoint smaller for responsive MonoBook.

You can also consider to query on device-width (which should be zoom level proof right?). It's generally bad practice to do that, but here it might be worthwile. or combine both.

# Jun 1 2018

TheDJ added a comment to T194814: Reduce amount of headers sent from web responses.
X-Varnish	521726689 533337780, 225083667 220092282, 525815818 515121340
Server	mw1238.eqiad.wmnet

Especially these two can be handy. In the past I've used them to quickly help identify everything from varnish servers that got cut of from the cache invalidation streams, to accidentally pooled servers which were running outdated or incorrectly configured setups.

TheDJ updated subscribers of T184871: Add encoding HTML header to LilyPond output.

Fixing cors or just adding the right mime type, probably requires some work with the media-storage ppl / someone with some swift file backend experience.

TheDJ updated the task description for T66819: PDF of article does not display "[who?]" as superscript but "Wikipedia:Avoid weasel words" instead.