Page MenuHomePhabricator

TheDJ (Derk-Jan Hartman)
Volunteer developer

Projects (38)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:32 PM (363 w, 20 h)
Availability
Available
IRC Nick
thedj
LDAP User
TheDJ
MediaWiki User
TheDJ [ Global Accounts ]
  • Open Source dev since 2001
  • Wikipedian since 2005
  • Wikipedia admin 2008-2019
  • Commons admin 2010-2015
  • MediaWiki dev (+2) since 2009

Uses Safari most of the time (because someone has to)

Recent Activity

Sat, Sep 18

TheDJ added a comment to T284921: Remove "auto-number headings" preference .

I can't confirm this. I don't have any performance issues caused by this feature and I never heard of anyone who had some. Are there any bug reports or discussions in which someone mentions problems caused by this feature?

Sat, Sep 18, 8:56 AM · Performance-Team (Radar), MediaWiki-User-preferences, MediaWiki-Parser, Platform Engineering

Fri, Sep 17

TheDJ committed rECHB21ceb45b382f: Improve validation of PGN (authored by Wugapodes).
Improve validation of PGN
Fri, Sep 17, 8:45 AM
TheDJ committed rECHB424b6958da6e: Fix legend positioning (authored by TheDJ).
Fix legend positioning
Fri, Sep 17, 1:22 AM

Thu, Sep 16

TheDJ committed rECHBf0afa52e0294: Add aria live captioning for moves (authored by TheDJ).
Add aria live captioning for moves
Thu, Sep 16, 11:59 PM
TheDJ added a comment to T291096: Menus should open via tab + enter.

This ticket is about keyboard accessibility primarily. I do note however that both controls the Personal Tools dropdown and the Language dropdown don't work properly in screenreaders either (the latter works a bit better than the first). The More dropdown works reasonably well in a screenreader.

Thu, Sep 16, 10:06 AM · Desktop Improvements, Accessibility, Readers-Web-Backlog
TheDJ added a comment to T247697: Rethink mathoids SVG to PNG conversion.
  • Thumbor at WMF has no owner, an issue we constantly keep running into.
Thu, Sep 16, 10:01 AM · Platform Engineering Roadmap Decision Making, Math, Wikimedia-SVG-rendering, User-Physikerwelt, Mathoid
TheDJ added a comment to T275350: Postgres replication lagging on maps[12]008.

Since the entire maps cluster is?/was? rebuilt, can this ticket be closed ?

Thu, Sep 16, 7:50 AM · Discovery-Search, Maps

Wed, Sep 15

TheDJ added a comment to T239446: Behavior on mobile, with screen readers, and without javascript.

These two patches should provide a decent amount of screenreader accessibility. It wasn't easy. Lessons learned:

  • CSS grids cannot be aria grids (no rows)
  • Aria grids are aria tables and thus can have headers, which could be used for the position (H4), but.....
  • Only the header in the direction you move the cursor is generally pronounced. Screenreaders often still pronounce the column/row offset in numbers in ADDITION to the columnheader. This made pronunciations very confusing as with headers, the grid becomes 10x10. You get things like:. "c, column 4 of 10" and "5, row 6 of 10".
  • I therefore chose NOT to use headers, but instead use labels for each individual cell.
  • aria-label doesn't work for empty cells.
  • i18n for so many variations is hard.
Wed, Sep 15, 10:25 AM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Accessibility, Mobile, ChessBrowser

Tue, Sep 14

TheDJ committed rECHB2432c9a20b17: Remove collapsible dependency and move to php (authored by TheDJ).
Remove collapsible dependency and move to php
Tue, Sep 14, 11:26 AM

Mon, Sep 13

TheDJ added a comment to T239446: Behavior on mobile, with screen readers, and without javascript.

This might be a reason to consider a css-grid layout over a table. From reading some web posts ( 1 and 2 ), it seems that grids are better for interactive content like this. Rather than each cell being it sown focus, the whole grid is a focus that can be navigated using keys and such.

Mon, Sep 13, 10:48 AM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Accessibility, Mobile, ChessBrowser
TheDJ added a comment to T289794: Add basic functionality for real-time previews.

Note. One concern that I identified which I didn’t see addressed in the spike, is with side by side and that it just doesnt work on narrow screens. I worked around this in ALP by disabling the functionality below a certain width. But it turns out this sometimes surprises ppl. I have received “complaints” in the past, both because ALP didn’t work (use enabled, but his screen was too small so it seemed the preference didn’t do anything) and “what the hell is this all of a sudden” (user had had the option enabled for ages but all of a sudden started using a bigger screen and the functionality “magically” appeared.

Mon, Sep 13, 7:41 AM · Community-Tech, Real-Time-Preview-Wish-2021-Aug-Nov, MediaWiki-Page-editing

Thu, Sep 9

TheDJ added a comment to T283164: Let's Encrypt issuance chains update.

Note, it’s September !

Thu, Sep 9, 8:05 PM · SRE, Traffic

Tue, Sep 7

TheDJ added a comment to T256935: Add a configuration to provide the fallback of og:image.

Sounds like this can be closed ?

Tue, Sep 7, 6:00 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Patch-For-Review, MediaWiki-extensions-OpenGraphMeta
TheDJ added a comment to T290468: Create an additional argument to image syntax to mark the image as page image.

Wasnt there already a ticket for this ???

Tue, Sep 7, 5:57 PM · Commons, Maps (Kartographer), PageImages, MediaWiki-File-management
TheDJ closed T267466: TypeError: Cannot read property 'parentMap' of null in modules/dialog/index.js:94 as Resolved.
Tue, Sep 7, 5:56 PM · MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), Maps (Kartographer)

Fri, Sep 3

TheDJ added a comment to T289714: [Sticky header] Restrict sticky header experience to logged in users on desktop with JavaScript enabled..

@nray i was thinking that maybe its acceptable to auto hide the header upon navigating to an anchor after a couple ms. Then whenever you scroll it would unhide ? might be worth an experiment.

Fri, Sep 3, 9:02 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
TheDJ added a comment to T290345: Create thumbnail for animated WebP files.

For Animated PNG, we render to a still frame png when we thumbnail. Note that this is primarily a side effect of the pipeline if i'm not mistaken. It was never much of an active decision.

Fri, Sep 3, 8:31 PM · Commons, MediaWiki-File-management, Thumbor
TheDJ closed T282665: Remove whitespace between PGN controls / buttons as Resolved.
Fri, Sep 3, 5:51 PM · ChessBrowser
TheDJ added a comment to T262067: Skin templateDirectory option should be relative to the skin.

I can confirm that i updated Vector first, MIGHT have loaded a page, and then updated core.

Fri, Sep 3, 5:50 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), MW-1.37-release, Patch-For-Review, MediaWiki-Configuration, MediaWiki-Core-Skin-Architecture

Thu, Sep 2

TheDJ created T290285: Make it possible to specify initial state of playboard.
Thu, Sep 2, 10:35 PM · Patch-For-Review, ChessBrowser
TheDJ added a comment to T289800: RTL display is flipped.

Based on the Hebrew Wikipedia's implementation, I think the moves should be RTL in those locales. The game details are currently set up as a table, and since that's text it should probably be RTL though he Wiki has the metadata in English it seems.

Thu, Sep 2, 10:27 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), I18n, RTL, ChessBrowser
TheDJ added a comment to T239446: Behavior on mobile, with screen readers, and without javascript.

I did some work on keyboard accessibility for the button/actions. TODO:

  • Make the titles/labels of the stateful controls reflect that state (so split play/pause, and have flip announcing the side of white)
  • I notice we send all the pieces into the payload of the html, but then in the JS we seem to throw all that away ? Is there anything useful we can do with outputting the pieces in HTML ? I mean which state of the game would you even show ? If they are really only made in JS, we should remove them from the HTML output
  • We'd definitely want to make it so that state changes get announced using aria-live right ? (White Queen to F3, check) This shouldn't be too hard, with some parameterized messages i guess...
  • Even better would be if you could also navigate the entire board and it announced which position you are on and what piece is on that spot if any... This would require some thought about how to build the dom for the board however. We'd need an additional overlay on the board, which is a grid that announces the position, but also looks up the position and announces which piece is on that position...
Thu, Sep 2, 10:12 PM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Accessibility, Mobile, ChessBrowser
TheDJ moved T282665: Remove whitespace between PGN controls / buttons from Needs triage to In Progress on the ChessBrowser board.
Thu, Sep 2, 9:56 PM · ChessBrowser
TheDJ closed T290230: Flip board animation broken as Resolved.
Thu, Sep 2, 9:45 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), ChessBrowser
TheDJ committed rECHB40d134ab4dcd: Repair flip board animation (authored by TheDJ).
Repair flip board animation
Thu, Sep 2, 8:30 PM
TheDJ added a comment to T285668: tiles.wmflabs.org OSM is outdated.

I've not been able to get it to draw a tile that looks like a current tile.. I'm not sure why. I don't have the experience to deal with problems like these unfortunately. Maybe we need to ask wikitech-l ?

Thu, Sep 2, 6:23 PM · Patch-For-Review, Data-Services, cloud-services-team (Kanban), Maps
TheDJ added a comment to T290201: [Spike] How does the sticky header work for screen reader users?.

I'm wondering if accessibility takes a hit if we do this. Consider a user landing on a page, scrolling down to trigger the sticky header and then hitting tab.

Thu, Sep 2, 5:31 PM · Patch-For-Review, Accessibility, Spike, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
TheDJ added a comment to T245377: Video.js player doesn’t work with Score.

This happens when a page has a Score and also a TMH element. The TMH player script tries to load it's JS on top of the Score player, but we probably never tested that in the last couple of years (because everything was broken).

Thu, Sep 2, 1:31 PM · Regression, TimedMediaHandler, MediaWiki-extensions-Score
TheDJ added a comment to T290251: Review CodeMirror tickets about cursor position/text selections being misaligned.

Apparently there are also situations where the cursor is misaligned an entire line up/down. This might be related to extremely long articles, or specific skins.

Thu, Sep 2, 1:23 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, WMDE-TechWish-Sprint-2021-09-01, WMDE-Templates-FocusArea, MediaWiki-extensions-CodeMirror, WMDE-TechWish
TheDJ created T290230: Flip board animation broken.
Thu, Sep 2, 8:35 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), ChessBrowser
TheDJ closed T289983: Add image resources to ChessBrowser extension as Resolved.
Thu, Sep 2, 8:34 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), ChessBrowser
TheDJ committed rECHB2587a3ab20f0: Load images as HTML resources not through CSS (authored by Wugapodes).
Load images as HTML resources not through CSS
Thu, Sep 2, 6:30 AM

Wed, Sep 1

TheDJ added a comment to T285668: tiles.wmflabs.org OSM is outdated.

Was not able to confirm this yet, will have to look tomorrow.

Wed, Sep 1, 10:37 PM · Patch-For-Review, Data-Services, cloud-services-team (Kanban), Maps
TheDJ added a comment to T239446: Behavior on mobile, with screen readers, and without javascript.

Current state.

Wed, Sep 1, 10:28 PM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Accessibility, Mobile, ChessBrowser
TheDJ committed rECHBc5a691185ef4: Fix advance (authored by TheDJ).
Fix advance
Wed, Sep 1, 10:06 PM
TheDJ committed rECHB9c554e6acd91: Fix edge case of mixed rtl ltr rendering (authored by TheDJ).
Fix edge case of mixed rtl ltr rendering
Wed, Sep 1, 9:50 PM
TheDJ moved T282503: Fallback text displays even when javascript is enabled from In Progress to Completed on the ChessBrowser board.
Wed, Sep 1, 9:47 PM · ChessBrowser
TheDJ closed T282503: Fallback text displays even when javascript is enabled as Resolved.
Wed, Sep 1, 9:47 PM · ChessBrowser
TheDJ closed T282503: Fallback text displays even when javascript is enabled, a subtask of T287990: Make ChessBrowser's user-facing error reporting more specific, as Resolved.
Wed, Sep 1, 9:47 PM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), ChessBrowser
TheDJ added a comment to T42763: Implement repeated/fixed/floating table headers.

I'm going to be deploying an update to my gadget on en.wp soon. This includes the fix for the collapsed borders + sticky. Unfortunately it seems that in Safari 14 there are now several problems with sticky table elements. The most noticeable is that the space that a table caption takes up is added above the sticky element. All these problems should be fixed in Safari 15 pretty soon however (according to the upstream tickets)

Wed, Sep 1, 2:14 PM · MediaWiki-Interface (Tables), JavaScript
TheDJ edited projects for T280154: TypeError: undefined is not an object (evaluating '$('#'+id)[0].timedText'), added: Kaltura player; removed TimedMediaHandler.
Wed, Sep 1, 8:31 AM · Kaltura player, JavaScript, Unstewarded-production-error, Wikimedia-production-error

Tue, Aug 31

TheDJ added a comment to T257066: Extension:Score / Lilypond is disabled on all wikis.

Just a thank you to Tim and Lego for working on this for all that time. I know its been quite a bit of work.

Tue, Aug 31, 10:05 AM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), User-notice, Security-Team, Security, Wikimedia-General-or-Unknown, MediaWiki-extensions-Score, SRE
TheDJ added a comment to T239446: Behavior on mobile, with screen readers, and without javascript.
  • The RL modules need to be spec'ed as being compatible with mobile in order for them to work on mobile
  • The buttons need to become actual buttons
  • The buttons need to be not just image buttons
  • The notation might possible have to be indicated as buttons...
  • The play state change should probably be announced via aria-live... (though I'm not sure if PGN notation in screenreaders can be easily understood, I'll give it a try).
Tue, Aug 31, 9:50 AM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Accessibility, Mobile, ChessBrowser
TheDJ moved T282503: Fallback text displays even when javascript is enabled from Needs triage to In Progress on the ChessBrowser board.
Tue, Aug 31, 9:40 AM · ChessBrowser
TheDJ closed T289800: RTL display is flipped as Resolved.
Tue, Aug 31, 9:40 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), I18n, RTL, ChessBrowser
TheDJ moved T289800: RTL display is flipped from Needs triage to Completed on the ChessBrowser board.
Tue, Aug 31, 9:39 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), I18n, RTL, ChessBrowser
TheDJ added a comment to T285668: tiles.wmflabs.org OSM is outdated.

Yes likely we will need to set a state file from before we got out of sync... Determining when that was exactly is probably going to be the hard part however... I think it was at least about a year or so....

Tue, Aug 31, 8:41 AM · Patch-For-Review, Data-Services, cloud-services-team (Kanban), Maps
Aklapper awarded T285668: tiles.wmflabs.org OSM is outdated a Orange Medal token.
Tue, Aug 31, 8:11 AM · Patch-For-Review, Data-Services, cloud-services-team (Kanban), Maps
TheDJ committed rECHBc3ec9cba8287: Don't flip directionality of chessboards in RTL env. (authored by TheDJ).
Don't flip directionality of chessboards in RTL env.
Tue, Aug 31, 3:14 AM
TheDJ committed rECHBd7ae50323e59: Prevent default on click events (authored by TheDJ).
Prevent default on click events
Tue, Aug 31, 3:13 AM

Mon, Aug 30

TheDJ added a comment to T289800: RTL display is flipped.

I've also made some significant changes in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ChessBrowser/+/715603/
That still requires a bit more work, which I hope to do later this week.

Mon, Aug 30, 10:13 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), I18n, RTL, ChessBrowser
TheDJ added a comment to T262067: Skin templateDirectory option should be relative to the skin.

hmmmm. now it disappeared.. i'm guessing some sort of RL caching ???

Mon, Aug 30, 9:55 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), MW-1.37-release, Patch-For-Review, MediaWiki-Configuration, MediaWiki-Core-Skin-Architecture
TheDJ committed rECHB901a705ded5e: Mark dependency on mw-collapsible (authored by TheDJ).
Mark dependency on mw-collapsible
Mon, Aug 30, 8:57 PM
TheDJ added a comment to T262067: Skin templateDirectory option should be relative to the skin.

Small guess.. it doesn't like symlinks very well ?

ls -la ./skins
lrwxr-xr-x   1 hartman  staff    28 Dec  6  2016 Vector -> ../../mediawiki-skins/Vector
Mon, Aug 30, 8:49 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), MW-1.37-release, Patch-For-Review, MediaWiki-Configuration, MediaWiki-Core-Skin-Architecture
TheDJ added a comment to T262067: Skin templateDirectory option should be relative to the skin.

Is this with the core patch applied? https://gerrit.wikimedia.org/r/c/mediawiki/core/+/712998/
I'll take a look.

Mon, Aug 30, 8:46 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), MW-1.37-release, Patch-For-Review, MediaWiki-Configuration, MediaWiki-Core-Skin-Architecture
TheDJ added a comment to T262067: Skin templateDirectory option should be relative to the skin.

I update Vector, and this seems to have broken my installation...

Mon, Aug 30, 8:40 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), MW-1.37-release, Patch-For-Review, MediaWiki-Configuration, MediaWiki-Core-Skin-Architecture
TheDJ added a comment to T289800: RTL display is flipped.

And what about the game details, the steps and the table ? what should their directionality be ?

Mon, Aug 30, 6:24 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), I18n, RTL, ChessBrowser
TheDJ updated the task description for T289983: Add image resources to ChessBrowser extension.
Mon, Aug 30, 11:10 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), ChessBrowser
TheDJ added a comment to T282665: Remove whitespace between PGN controls / buttons.

sounds like a missing event.preventDefault() or something. I'll check this later tonight.

Mon, Aug 30, 10:27 AM · ChessBrowser
TheDJ created T289983: Add image resources to ChessBrowser extension.
Mon, Aug 30, 10:26 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), ChessBrowser
TheDJ added a comment to T282503: Fallback text displays even when javascript is enabled.

this can be easily fixed by using the .client-js class to hide the element, instead of JS. I'll do that tonight.

Mon, Aug 30, 10:23 AM · ChessBrowser
TheDJ added a comment to T289800: RTL display is flipped.

Ah, another reason I didn't see this problem in the same way, was because I was using
https://he.wikipedia.beta.wmflabs.org/wiki/משתמש:קיפודנחש1/ChessBrowser_test_cases?uselang=en instead of
https://he.wikipedia.beta.wmflabs.org/wiki/משתמש:קיפודנחש1/ChessBrowser_test_cases?uselang=he

Mon, Aug 30, 10:16 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), I18n, RTL, ChessBrowser
TheDJ added a comment to T289800: RTL display is flipped.

Hmm. does anyone know about the class pgn-pgn-display ? This sets a direction, but apparently it is never used in the source code of the player... Was it renamed perhaps at some point ?

Mon, Aug 30, 9:46 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), I18n, RTL, ChessBrowser

Sun, Aug 29

TheDJ added a comment to T289800: RTL display is flipped.

Well I can easily hardcode the direction to ltr for the checkerboard, that fixes the legend…. But apparently not the piece position. That can be for various reasons, I’ll have to check if it’s because they are calculated only once…..

Sun, Aug 29, 8:49 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), I18n, RTL, ChessBrowser
TheDJ added a comment to T289800: RTL display is flipped.

can you make screenshots of what it looks like and how it should like ? That makes interpretation a lot easier...
And is this a new issue, or was it already like that for a while but no one noticed ?

Sun, Aug 29, 2:12 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), I18n, RTL, ChessBrowser

Sat, Aug 28

TheDJ closed T256069: [Bug] Table images disappear on scroll as Resolved.

This specific bug was fixed, and the more general 'problem' is already tracked at T116318: Images in tables are too small

Sat, Aug 28, 9:51 PM · MinervaNeue (Tracking), Reading-Web-Local-Wiki-Issues, Wikipedia-iOS-App-Backlog, iOS-app-Bugs
TheDJ closed T253430: [OTRS bug] "Sojourner (rover)" article shows text-on-text as Resolved.

ok.. the original issue with text overlaying the other text, was actually because someone added a heigh limit which was insufficient for the contents... this has been fixed.

Sat, Aug 28, 9:41 PM · Reading-Web-Local-Wiki-Issues, Product-Infrastructure-Team-Backlog, Wikipedia-iOS-App-Backlog
TheDJ closed T255781: On several WMF sites, CSS of Twinkle gadget is interference leading the constant display of drop down menus as Resolved.

calling this fixed

Sat, Aug 28, 9:14 PM · Reading-Web-Local-Wiki-Issues
TheDJ added a comment to T233128: Available on sister projects template has layout problems.

I rewrote this template. Not yet deployed, but https://en.wikipedia.org/wiki/Template_talk:Subject_bar#Better_responsiveness

Sat, Aug 28, 9:02 PM · Product-Infrastructure-Team-Backlog, Reading-Web-Local-Wiki-Issues, Wikipedia-iOS-App-Backlog
TheDJ closed T231243: missing {{col-end}} breaks collapsing section functionality on mobile devices as Resolved.

I don't see the problem. If you break the html, other things are going to break. Don't break the html.

Sat, Aug 28, 7:23 PM · Parsing-Team--ARCHIVED, Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues
TheDJ closed T225978: Persian Wikipedia main page appears shifted to the right. as Resolved.

i don't see this problem any longer

Sat, Aug 28, 7:22 PM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues
TheDJ added a comment to T282588: images wrapped in flex item styling get really small in Timeless/Minerva.

Related ticket: T116318: Images in tables are too small

Sat, Aug 28, 7:13 PM · Reading-Web-Local-Wiki-Issues, Mobile
TheDJ added a comment to T240509: PHP7 exif_read_data doesn't read all the EXIF key/values that HHVM version did.

@Molgreen Its fixed in PHP, but not in the version of PHP that the WMF currently runs.

Sat, Aug 28, 6:53 PM · Upstream, MediaWiki-File-management, Commons

Fri, Aug 27

TheDJ added a comment to T184871: Fix mime type and text encoding in Content-Type HTTP header of LilyPond .ly file output.

@fgiunchedi you know if that patch makes sense ?

Fri, Aug 27, 9:32 PM · Patch-For-Review, SRE-swift-storage, I18n, MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), MediaWiki-extensions-Score
TheDJ closed T223903: php cli reports Unable to load dynamic library /usr/lib/php/20151012/zip.so, a subtask of T183759: MediaWiki::shell with parameter fails on Windows, as Resolved.
Fri, Aug 27, 8:07 PM · MW-1.31-release-notes, MW-1.34-notes, MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Platform Team Workboards (Clinic Duty Team), Patch-For-Review, SyntaxHighlight, MediaWiki-Shell, MediaWiki-extensions-Score
TheDJ closed T223903: php cli reports Unable to load dynamic library /usr/lib/php/20151012/zip.so as Resolved.

I'm calling this fixed.... we'd likely seen more reports by now if it wasn't

Fri, Aug 27, 8:07 PM · Continuous-Integration-Infrastructure
TheDJ added a comment to T285022: MIME type "filemime:audio/webm" search on Wikimedia Commons lists some WebM videos (which should be "video/webm").

Found the ticket on this problem: T226311: Full size videos displayed as small videos in gallery

Fri, Aug 27, 8:04 PM · Wikimedia-General-or-Unknown, Commons
TheDJ merged T239140: [WIP] Replace `mw-content-ltr` and `mw-content-rtl` classes with a general class and a `dir` attribute selector` into T287701: Review usages of `.mw-content-ltr` and `.mw-content-rtl`.
Fri, Aug 27, 7:52 PM · I18n, User-notice
TheDJ merged task T239140: [WIP] Replace `mw-content-ltr` and `mw-content-rtl` classes with a general class and a `dir` attribute selector` into T287701: Review usages of `.mw-content-ltr` and `.mw-content-rtl`.
Fri, Aug 27, 7:51 PM · UI-Standardization-Kanban, CSS, UI-Standardization
TheDJ added a comment to T240509: PHP7 exif_read_data doesn't read all the EXIF key/values that HHVM version did.
Fri, Aug 27, 7:44 PM · Upstream, MediaWiki-File-management, Commons
TheDJ added a comment to T288161: Enable CodeMirror's Syntax Highlighting on English Wikipedia by default.

I suspect some of the performance-related concerns raised here are from users who experienced this before January 2021. That issue is fixed.

Fri, Aug 27, 10:19 AM · Wikimedia-Site-requests

Thu, Aug 26

TheDJ added a comment to T184871: Fix mime type and text encoding in Content-Type HTTP header of LilyPond .ly file output.

I guess this is a FileBackend detail..

Thu, Aug 26, 11:24 AM · Patch-For-Review, SRE-swift-storage, I18n, MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), MediaWiki-extensions-Score

Wed, Aug 25

TheDJ created T289748: Reading of vorbis comment values containing the = character is broken.
Wed, Aug 25, 10:51 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Patch-For-Review, TimedMediaHandler
TheDJ added a comment to T63900: Invalid Ogg file: Stream Undecodable.

So I took a quick look at specifically: https://commons.wikimedia.org/wiki/File:Klaviersonate_Nr._31_As-Dur_op._110_-_I._Moderato_cantabile,_molto_espressivo.ogg from T288896: Some Ogg files show "Invalid Ogg file: Stream Undecodable"

Wed, Aug 25, 10:43 PM · TimedMediaHandler
TheDJ added a comment to T51097: Use figure and figcaption HTML5 elements when possible.

I also see all the VE JS being loaded (with debug=true).. that's not normal....

Wed, Aug 25, 8:18 PM · Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure), Parsoid, MediaWiki-ResourceLoader, Parsoid-Media-Structure, MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Patch-For-Review, HTML5, Parsing-Active-Work, MediaWiki-Parser, Parsing-Team--ARCHIVED, Accessibility, MediaWiki-Interface
TheDJ added a comment to T285668: tiles.wmflabs.org OSM is outdated.

i mean. it's infra that no one wants to be responsible for, i get it, but we gotta put some sort of tag on it...

Wed, Aug 25, 7:26 PM · Patch-For-Review, Data-Services, cloud-services-team (Kanban), Maps
TheDJ added a comment to T285668: tiles.wmflabs.org OSM is outdated.

not thats just the rendering. This is about the postgres DB with the database..

Wed, Aug 25, 7:24 PM · Patch-For-Review, Data-Services, cloud-services-team (Kanban), Maps
TheDJ added a comment to T51097: Use figure and figcaption HTML5 elements when possible.

ok... now thumbframes on mediawiki.org are loading late.. seems like the parsoid CSS module is not added with addModuleStyles() to ensure its loaded before the page rendering starts ?

Wed, Aug 25, 7:22 PM · Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure), Parsoid, MediaWiki-ResourceLoader, Parsoid-Media-Structure, MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Patch-For-Review, HTML5, Parsing-Active-Work, MediaWiki-Parser, Parsing-Team--ARCHIVED, Accessibility, MediaWiki-Interface
TheDJ added a comment to T288161: Enable CodeMirror's Syntax Highlighting on English Wikipedia by default.

they are for implementing the results of those discussions.

Wed, Aug 25, 7:06 PM · Wikimedia-Site-requests
TheDJ updated subscribers of T285668: tiles.wmflabs.org OSM is outdated.

@Majavah I didn't know we kept separate tags for the DB replicas of Toolforge. Do you know what the project tag for that is ?

Wed, Aug 25, 6:59 PM · Patch-For-Review, Data-Services, cloud-services-team (Kanban), Maps
TheDJ added a comment to T289714: [Sticky header] Restrict sticky header experience to logged in users on desktop with JavaScript enabled..

of note.. if you add a sticky header, your anchor (section links) will anchor to behind ur header... which can be rather confusing.. might want to think about that as well when implementing this..

Wed, Aug 25, 6:45 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
TheDJ added a comment to T258584: Align VideoJS player to Wikimedia UI design.

@Iniquity can we add a white outline to that play button ? When you have a dark background in the thumb, it blends in a LOT now...

Wed, Aug 25, 6:26 PM · MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikimedia-Video, Design, UI-Standardization, VideoJS player
TheDJ closed T252795: Ogg Vorbis audio from the Score extension is not transcoded to MP3 on iOS as Resolved.

forgot to close

Wed, Aug 25, 3:26 PM · Browser-Support-Apple-Safari, MediaWiki-extensions-Score
TheDJ added a comment to T289403: Abc notation: not able to control the beaming of notes as intended by the abc music standard.

this seems interesting though...

Wed, Aug 25, 3:14 PM · Upstream, MediaWiki-extensions-Score
TheDJ merged T286089: Karthotherian geoshapes improperly handles superroutes from OpenStreetMap into T288400: New imposm3 setup provides some broken links for geoshapes when requesting linestrings.
Wed, Aug 25, 11:36 AM · Product-Infrastructure-Team-Backlog (Kanban), Maps (Kartotherian)
TheDJ merged task T286089: Karthotherian geoshapes improperly handles superroutes from OpenStreetMap into T288400: New imposm3 setup provides some broken links for geoshapes when requesting linestrings.
Wed, Aug 25, 11:35 AM · Maps (Kartotherian)
TheDJ merged T289669: Zero in math-block not visible in rendering into T288846: TypeError: Argument 1 passed to HookHandlers\ParserHooksHandler::mathTagHook() must be of the type string, null given.
Wed, Aug 25, 10:03 AM · MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Math, Wikimedia-production-error
TheDJ added a comment to T289669: Zero in math-block not visible in rendering.

known issue, see linked task

Wed, Aug 25, 10:03 AM · Math, wikipedia.de
TheDJ merged task T289669: Zero in math-block not visible in rendering into T288846: TypeError: Argument 1 passed to HookHandlers\ParserHooksHandler::mathTagHook() must be of the type string, null given.
Wed, Aug 25, 10:03 AM · Math, wikipedia.de
TheDJ added a comment to T287326: upload.wikimedia.org does not set content-encoding headers for Score-generated lilypond files.

Somewhat related: T184871: Fix mime type and text encoding in Content-Type HTTP header of LilyPond .ly file output

Wed, Aug 25, 8:53 AM · SRE-swift-storage, SRE, MediaWiki-extensions-Score