Page MenuHomePhabricator

TheDJ (Derk-Jan Hartman)
Volunteer developer

Projects (36)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:32 PM (299 w, 2 d)
Availability
Available
IRC Nick
thedj
LDAP User
TheDJ
MediaWiki User
TheDJ [ Global Accounts ]
  • Open Source dev since 2001
  • Wikipedian since 2005
  • Wikipedia admin 2008-2019
  • Commons admin 2010-2015
  • MediaWiki dev (+2) since 2009

Uses Safari most of the time (because someone has to)

Recent Activity

Today

TheDJ awarded T256933: Alter the look of SDC GUI to hide input fields for properties which are not beeing edited a Like token.
Thu, Jul 2, 8:51 AM · Structured-Data-Backlog, Wikidata, Structured Data Engineering, SDC General

Yesterday

TheDJ added a comment to T256758: Safari creates phone links for numbers in format ###-####.

I think this is a good idea, as long as it is configurable via LocalSettings. I'm not entirely sure about what the default value for mediawiki should be however. On the one side, maybe sites currently depend on on this and want to keep, but also having mw.org defaults out of sync with wmf defaults, tends to be annoying for system adminitrators as well, so.....

Wed, Jul 1, 12:15 PM · MediaWiki-Interface, Browser-Support-Apple-Safari

Tue, Jun 30

TheDJ added a comment to T256718: Implementing WikimediaUI theme in an extension is a bad idea.

This is rather unavoidable.

  1. the introduction of ooui is still in progress
  2. the conversion of modules to less (a prerequisite in order to use the style variables) is still in progress
  3. there are some very specialized controls included in various components, for which centralization won't make sense, these will always require such overrides
  4. there are still a lot of mistakes in modules that core developers will never notice, because they only use one skin.
Tue, Jun 30, 9:53 AM · UI-Standardization, patch-welcome, MediaWiki-extensions-General

Tue, Jun 23

Krinkle awarded T167956: Remove printable version mode a Orange Medal token.
Tue, Jun 23, 5:48 PM · Performance-Team (Radar), Desktop Improvements, MediaWiki-ResourceLoader, Technical-Debt, MediaWiki-General

Mon, Jun 22

TheDJ added a comment to T255961: 2017 source editor has math equation issue.

Possibly same as T255785: Template insertion fails in 2017 wikitext editor (including citation templates via citoid)

Mon, Jun 22, 1:24 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, Math
TheDJ edited projects for T255961: 2017 source editor has math equation issue, added: VisualEditor-MediaWiki-2017WikitextEditor; removed VisualEditor.
Mon, Jun 22, 1:22 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, Math

Thu, Jun 18

TheDJ edited projects for T255721: Uncaught TypeError: Cannot read property 'getMIMEType' of undefined, added: Kaltura player; removed TimedMediaHandler.

This is a code path in the Kaltura JS player.

Thu, Jun 18, 9:26 AM · Kaltura player, Wikimedia-production-error

Mon, Jun 15

TheDJ added a comment to T60443: Tablesorter should sort 'invalid' values alphabetically ("natural sorting").

This would require redoing the sort value formatting. Currently all numeric is formatted with formatDigit and then assigned -Infinity if it is not a number, before being sorted. In order to keep natural sorting here would require applying natural sort on the remaining items that now share -Infinity. Bit hard to do as we just 'removed' that information in the previous step.

Mon, Jun 15, 12:38 PM · MediaWiki-jQuery-Tablesorter, JavaScript, MediaWiki-Interface
TheDJ renamed T60443: Tablesorter should sort 'invalid' values alphabetically ("natural sorting") from Tablesorter should sort 'invalid' values alphabeticaly ("natural sorting") to Tablesorter should sort 'invalid' values alphabetically ("natural sorting").
Mon, Jun 15, 11:30 AM · MediaWiki-jQuery-Tablesorter, JavaScript, MediaWiki-Interface
TheDJ renamed T60443: Tablesorter should sort 'invalid' values alphabetically ("natural sorting") from Tablesorter should sort non-numerical values alphabeticaly ("natural sorting") to Tablesorter should sort 'invalid' values alphabeticaly ("natural sorting").
Mon, Jun 15, 11:30 AM · MediaWiki-jQuery-Tablesorter, JavaScript, MediaWiki-Interface
TheDJ updated the task description for T60443: Tablesorter should sort 'invalid' values alphabetically ("natural sorting").
Mon, Jun 15, 11:29 AM · MediaWiki-jQuery-Tablesorter, JavaScript, MediaWiki-Interface
TheDJ merged T17403: tablesorter should provide a way to have a particular column be sorted in reverse order by default into T33332: Provide a way to set the initial sort for sortable tables.
Mon, Jun 15, 11:23 AM · MediaWiki-jQuery-Tablesorter
TheDJ merged task T17403: tablesorter should provide a way to have a particular column be sorted in reverse order by default into T33332: Provide a way to set the initial sort for sortable tables.
Mon, Jun 15, 11:23 AM · MediaWiki-jQuery-Tablesorter, JavaScript, MediaWiki-Interface
TheDJ closed T226697: Make a third click on a sortable header reset the table as Resolved.
Mon, Jun 15, 11:20 AM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), User-notice, patch-welcome, MediaWiki-jQuery-Tablesorter

Sat, Jun 13

TheDJ added a comment to T161256: multi-component wmflabs.org subdomains doesn't work under simple wildcard TLS cert.

I replaced the redirects with a general http -> https redirect protocol upgrade.

Sat, Jun 13, 11:49 AM · cloud-services-team (Kanban), Operations, Traffic, Maps, Cloud-VPS, DNS
TheDJ added a comment to T225640: Video.js mode doesn't show subtitles by default on non-English sites.

https://www.mediawiki.org/wiki/Bug_management/Phabricator_etiquette

Report status and priority fields summarize and reflect reality and do not cause it. Read about the meaning of the Priority field values and, when in doubt, do not change them, but add a comment suggesting the change and convincing reasons for it.
As a general rule, the fastest way to see a bug resolved is to provide a patch; +2 is one policy for approving proposed code.
Convincing reasons for raising the priority of a bug include evidence that it affects normal, everyday work significantly. Contrived examples or problems that only appear under unlikely circumstances are generally evidence for treating the problem as "low" or "lowest" priority, since the limits of any non-trivial software can be exceeded if you try hard enough.

Sat, Jun 13, 10:15 AM · VideoJS player, TimedMediaHandler-TimedText

Wed, Jun 10

TheDJ added a comment to T254693: Same origin policy access between tools deliberately broken by toolforge.org migration.

I suspect this is because of the always added response header: x-clacks-overhead: GNU Terry Pratchett
I suggest that if toolforge wants to add global headers, it should probably also 'globally' add that header to Access-Control-Allow-Headers.

Wed, Jun 10, 8:56 AM · Maps

Tue, Jun 9

TheDJ added a comment to T254669: There is a problem in displaying the infoboxes on mobile and android application.

This is in part because the templates use a table inside of a table (infobox). The default CSS doesn't account for that. I also agree that this should be fixed using TemplateStyles on the local wiki.

Tue, Jun 9, 7:53 AM · Page Content Service, Product-Infrastructure-Team-Backlog, Reading-Web-Local-Wiki-Issues, MinervaNeue (Tracking), Wikipedia-Android-App-Backlog, Android-app-Bugs

Mon, Jun 8

TheDJ added a comment to T254557: Thumbor doesn't save Content-Disposition: inline headers to Swift for webp thumbnails.

Good detective work @Gilles !

Mon, Jun 8, 10:13 AM · Patch-For-Review, Operations, Thumbor, MediaWiki-File-management, Commons, Browser-Support-Firefox
TheDJ added a comment to T254693: Same origin policy access between tools deliberately broken by toolforge.org migration.

@Kolossos did you try adding access-control-allow-methods: "OPTIONS,GET" at the same time ?

Mon, Jun 8, 7:32 AM · Maps

Sun, Jun 7

TheDJ added a comment to T234617: Toolforge. introduce new domain toolforge.org.

i haven't been able to find info on tools-static.wmflabs.org.. can someone provide that info and update https://wikitech.wikimedia.org/wiki/Help:Toolforge/Web#Static_file_server

Sun, Jun 7, 8:37 PM · Patch-For-Review, Goal, Toolforge, cloud-services-team (Kanban), Kubernetes
TheDJ added a comment to T254693: Same origin policy access between tools deliberately broken by toolforge.org migration.

ugh. this is a mess

Sun, Jun 7, 7:49 PM · Maps

Fri, Jun 5

TheDJ added a subtask for T27611: Support optimized WebP thumbnails as alternative to JPEG, PNG: T254557: Thumbor doesn't save Content-Disposition: inline headers to Swift for webp thumbnails.
Fri, Jun 5, 10:27 AM · Performance-Team, Commons, Multimedia, MediaWiki-File-management
TheDJ added a parent task for T254557: Thumbor doesn't save Content-Disposition: inline headers to Swift for webp thumbnails: T27611: Support optimized WebP thumbnails as alternative to JPEG, PNG.
Fri, Jun 5, 10:27 AM · Patch-For-Review, Operations, Thumbor, MediaWiki-File-management, Commons, Browser-Support-Firefox
TheDJ updated the task description for T254557: Thumbor doesn't save Content-Disposition: inline headers to Swift for webp thumbnails.
Fri, Jun 5, 9:33 AM · Patch-For-Review, Operations, Thumbor, MediaWiki-File-management, Commons, Browser-Support-Firefox
TheDJ updated the task description for T254557: Thumbor doesn't save Content-Disposition: inline headers to Swift for webp thumbnails.
Fri, Jun 5, 9:31 AM · Patch-For-Review, Operations, Thumbor, MediaWiki-File-management, Commons, Browser-Support-Firefox
TheDJ updated subscribers of T254557: Thumbor doesn't save Content-Disposition: inline headers to Swift for webp thumbnails.
Fri, Jun 5, 9:22 AM · Patch-For-Review, Operations, Thumbor, MediaWiki-File-management, Commons, Browser-Support-Firefox
TheDJ created T254557: Thumbor doesn't save Content-Disposition: inline headers to Swift for webp thumbnails.
Fri, Jun 5, 9:21 AM · Patch-For-Review, Operations, Thumbor, MediaWiki-File-management, Commons, Browser-Support-Firefox

May 28 2020

TheDJ added a comment to T249486: Change Content Security Policy on betacommons to allow api.flickr.com.

Note, the flickr thing is part of the uploadwizard extension, not a gadget or anything like that. Most of the other things like that had builtin exceptions, at least in the short term (in the spirit of stabilizing the status quo before changing things)

I'm not seeing anything in the labs CS.php/IS.php for anything outside of the standard Wikimedia domains, nor in the headers when I load any beta pages.

May 28 2020, 3:20 PM · Security-Team, ContentSecurityPolicy, Wikimedia-Site-requests, Beta-Cluster-Infrastructure
TheDJ added a comment to T208188: RFC: Partial opt-out method for Content security policy.

I don't get it.

Content Security Policy: The page’s settings blocked the loading of a resource at https://api.flickr.com/services/rest/?&api_key=e9d…=json&nojsoncallback=1&method=flickr.photos.licenses.getInfo (“default-src”).

That’s why there is T249486: Change Content Security Policy on betacommons to allow api.flickr.com as well. But it has nothing to do with this ticket.

May 28 2020, 3:12 PM · Privacy Engineering, Security, Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, ContentSecurityPolicy, TechCom-RFC, TechCom, Security-Team

May 26 2020

TheDJ added a comment to T215713: Missing dependencies in extension snapshots.

Thank you @Bawolff

May 26 2020, 10:46 AM · MW-1.34-release, MW-1.33-release, VPS-project-Extdist, MW-1.32-release, ExtensionDistributor

May 25 2020

TheDJ closed T57345: Code Editor not being recognised as input field on iPad Safari (need upstream iOS support) as Resolved.
May 25 2020, 10:38 AM · Upstream, CodeEditor, Browser-Support-Apple-Safari
TheDJ added a comment to T251545: Error when using search in CodeEditor: dom.buildDom is not a function.

I suspect this was due to cached code being executed after T202121: Update Ace Editor library to a more recent version somehow...

May 25 2020, 10:31 AM · JavaScript, Editing-team, Wikimedia-production-error, Regression, CodeEditor
TheDJ added a comment to T178261: Add option to not create DjVu but just upload PDF.

"It's becoming less clear as time goes on why we want to turn PDFs into DjVus anyway!"

May 25 2020, 10:20 AM · Community-Tech, IA Upload
TheDJ added a comment to T253522: TimedMediaHandler should report FFmpeg, Fluidsynth, Soundfont version info in onSoftwareInfo.

One note here.. The software used for TMH (and most of the media processing) runs on servers that are not the same as those rendering the pages. And the pages can only access the software version on the server rendering the page. So there is a potential disjunction here (assuming that ffmpeg is even installed on the web server).

May 25 2020, 9:59 AM · TimedMediaHandler
TheDJ awarded T253522: TimedMediaHandler should report FFmpeg, Fluidsynth, Soundfont version info in onSoftwareInfo a Like token.
May 25 2020, 9:56 AM · TimedMediaHandler
TheDJ added a comment to T228546: geomask discards inner rings.

This is a relatively easy fix, which i've not yet made, because i was trying to figure out if there is some sort of historical reason for omitting the innershapes. I couldn't find one.

May 25 2020, 9:53 AM · Maps (Kartographer)

May 20 2020

TheDJ added a comment to T248718: Provide performance guidelines on when and how to load code.

There's only one way to do that really, and that's documented. To lazy-load, you use mw.loader.using().

May 20 2020, 1:49 PM · Performance-Team, Desktop Improvements, Documentation
TheDJ added a comment to T248526: Review referer configuration of origin/origin-when-crossorigin/origin-when-cross-origin.

origin-when-crossorigin: Safari pre 11.1 (spec implementation error, 2017-2018)
origin-when-cross-origin: Safari post 11.1 and all other modern browsers
Origin: browsers from between 2015 and 2017

May 20 2020, 11:48 AM · Analytics-Radar, Readers-Web-Backlog (Tracking), Performance-Team

May 19 2020

TheDJ closed T161742: Disappearing building as Invalid.

I don't think this is much of an actual problem. I'm pretty sure that it is just the pink/purple highlight (for amenity:hospital and amenity:university) being applied to the buildings instead of to the plot of land. Between z17 and z18, buildings become flat (instead of 3d'ish) and (transparent) landuse and amenity highlighting starts applying. Because the amenity highlight is applied to the building, instead of the 'plot of land', the transparent highlight and the building occupy the same space and it looks like it 'disappears'.

May 19 2020, 1:30 PM · Maps (Map-Styles)
TheDJ merged T76945: "center" does not center non-thumb image on tablets in Minerva into T193595: [Bug] <div class="center">> does not center content.
May 19 2020, 1:13 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Readers-Web-Kanbanana-Board-Old, MinervaNeue, MobileFrontend
TheDJ merged task T76945: "center" does not center non-thumb image on tablets in Minerva into T193595: [Bug] <div class="center">> does not center content.
May 19 2020, 1:13 PM · Readers-Web-Backlog (Design), MobileFrontend
TheDJ added a comment to T252976: Charinsert in editnotice does not work in NWE.

I don't think there is any intention to support this going forward. It was never what the functionality was supposed to be used for and near impossible to support reliably across multiple platforms (like iOS/Android apps for instance).

May 19 2020, 1:06 PM · VisualEditor, CharInsert, VisualEditor-MediaWiki-2017WikitextEditor
TheDJ added a comment to T70468: Images with border parameter should display captions.

@Aklapper no more than what is in the mediawiki page. I guess the WMF team decided that it wasn't worth their time to continue to work on this.

May 19 2020, 1:03 PM · MediaWiki-Interface
TheDJ added a comment to T190120: Parse warnings not visible with live preview.

I do have a patch for this.. somewhere...
I believe I never completed it, because i had wanted to use templated html instead, but then I never finished that rework.

May 19 2020, 10:39 AM · Patch-For-Review, MediaWiki-Page-editing
TheDJ added a comment to T248526: Review referer configuration of origin/origin-when-crossorigin/origin-when-cross-origin.

@Krinkle for the origin-when-crossorigin fallback.. The spec compliant origin-when-cross-origin has been supported since March 2018, starting with Safari 11.1. So in order to remove that, the question to answer would be: How much traffic we still get for Safari versions older than 11.1 and does Analytics care about being able to accurately track 'internal referrers' for that number of browser sessions.

May 19 2020, 10:33 AM · Analytics-Radar, Readers-Web-Backlog (Tracking), Performance-Team
Pppery awarded T191531: Create Lua module to expose local short descriptions of pages from other wikis to Lua a Like token.
May 19 2020, 12:52 AM · Wikidata, MediaWiki-extensions-WikibaseClient

May 15 2020

TheDJ added a comment to T233995: Setup a dedicated HTTPS terminating proxy for maps project.

where are b and c ?

May 15 2020, 10:07 AM · cloud-services-team (Kanban), VPS-Projects, Cloud-VPS

May 14 2020

TheDJ awarded T252811: Requesting +2 rights for Mediawiki Group for DannyS712 a Like token.
May 14 2020, 9:53 PM · User-DannyS712, MediaWiki-Gerrit-Group-Requests
TheDJ added a comment to T181604: it:voy needs Kartographer to shows ordered POI on specific template.

So Template:Citylist (implemented using module:itemlist), wrapping listing templates, wrapping marker templates, which in turn invoke the Map module. The list function re-sorts, but has no way of passing this information to the individual items.

May 14 2020, 10:06 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Maps (Kartographer)

May 9 2020

TheDJ updated subscribers of T250393: Use monospace font (or editfont preference) for diffs.

If ppl are really interested in undoing this, in my opinion, you need to do a better job at explaining why you have NOT set your editor font to a sans-serif font, leaving it monospace, yet require a sans-serif font in diffs.

May 9 2020, 11:25 AM · Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), User-notice, MediaWiki-Page-Diffs

May 8 2020

TheDJ closed T211072: Page preview stopped working when it contains a map and user has "preview without reload" enabled as Resolved.
May 8 2020, 12:06 PM · Maps (Kartographer)

May 5 2020

TheDJ added a comment to T209837: Smaller font in euwiki PDF downloads than in other wikis.

@Nemo_bis yes its because of the tables. Chrome (which PDF printing via Proton is based on) automatically compresses the size of pages to fit tables that are too wide to otherwise fit on the page

May 5 2020, 9:06 PM · Proton, PDF-Rendering, Product-Infrastructure-Team-Backlog

Apr 30 2020

TheDJ removed a project from T250620: Visual Editor fails during save dialog on specific page containing a Kartographer map: Patch-For-Review.
Apr 30 2020, 12:30 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Editing QA, Maps (Kartographer), Editing-team (Q3 2019-2020 Kanban Board), VisualEditor
TheDJ closed T250620: Visual Editor fails during save dialog on specific page containing a Kartographer map as Resolved.
Apr 30 2020, 12:29 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Editing QA, Maps (Kartographer), Editing-team (Q3 2019-2020 Kanban Board), VisualEditor
TheDJ added a comment to T250733: Read only time for extension 1 (x1) primary database on 2020-04-30.

should be in GMT and not UTC.

Apr 30 2020, 7:27 AM · CommRel-Specialists-Support (Apr-Jun-2020)

Apr 29 2020

Jan_Kepler awarded T250620: Visual Editor fails during save dialog on specific page containing a Kartographer map a Like token.
Apr 29 2020, 3:31 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Editing QA, Maps (Kartographer), Editing-team (Q3 2019-2020 Kanban Board), VisualEditor
TheDJ added a comment to T234729: Links to line anchors of modules in Scribunto error popup do not jump to line of that Module's source code.

The analysis by Anomie is correct:

With CodeEditor, it looks like there's currently a race where WikiEditor is triggering the "doneInitialSections" event before CodeEditor registers for it, so CodeEditor never manages to register its hashchange listener.

Apr 29 2020, 2:33 PM · WikiEditor, CodeEditor

Apr 28 2020

TheDJ claimed T251218: <mapframe>: Javascript exception while rendering a fullscreen map with dialogs.
Apr 28 2020, 7:09 AM · OOjs, JavaScript, Maps (Kartographer)

Apr 24 2020

TheDJ added a comment to T250970: interactive map zooms to around 0N 0W.

0,0 (aka null island) is just the default position of the map, and in this case basically means that the query to OSM for a map relations tagged with wikidata:Q683705 returned no results.

Apr 24 2020, 8:06 AM · Maps
TheDJ closed T250970: interactive map zooms to around 0N 0W as Invalid.

Kartographer doesn't care about what is in WikiData. It gets its shapes from Openstreetmap. So that means that likely someone broke the shape in OSM.

Apr 24 2020, 7:57 AM · Maps

Apr 23 2020

TheDJ added a comment to T250620: Visual Editor fails during save dialog on specific page containing a Kartographer map.

This issue really only surfaced in VE+static img maps. On livepreview, we always use dynamic maps and then the wikipage.content loop of staticframe usually only triggers once. Except when using VE.

Apr 23 2020, 12:10 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Editing QA, Maps (Kartographer), Editing-team (Q3 2019-2020 Kanban Board), VisualEditor

Apr 22 2020

TheDJ updated the task description for T134618: Epic: Implement spreadsheet-like cell editing for tabular data.
Apr 22 2020, 7:54 AM · Epic, Commons-Datasets
TheDJ updated the task description for T134618: Epic: Implement spreadsheet-like cell editing for tabular data.
Apr 22 2020, 7:54 AM · Epic, Commons-Datasets
TheDJ added a comment to T134618: Epic: Implement spreadsheet-like cell editing for tabular data.

@Fuzheado @Keilana there is a csv/excel import/export gadget for that that I made a couple years back. https://commons.wikimedia.org/wiki/MediaWiki:Gadget-TabularImportExport.js

Apr 22 2020, 7:43 AM · Epic, Commons-Datasets
TheDJ claimed T250620: Visual Editor fails during save dialog on specific page containing a Kartographer map.
Apr 22 2020, 7:15 AM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Editing QA, Maps (Kartographer), Editing-team (Q3 2019-2020 Kanban Board), VisualEditor

Apr 20 2020

TheDJ added a comment to T250463: Kartographer maps don't appear after first added while using the preview function on the 2017 wikitext editor.

Confirmed. this issue is blocked on Parsoid/WE2017 not supporting JS modules in preview (unless the old page version already has these loaded).

Apr 20 2020, 1:52 PM · Parsing-Team, Editing-team (Tracking), VisualEditor, Maps (Kartographer), VisualEditor-MediaWiki-2017WikitextEditor
TheDJ added a parent task for T162399: Parsoid doesn't add JS modules to <head> in its output: T250463: Kartographer maps don't appear after first added while using the preview function on the 2017 wikitext editor.
Apr 20 2020, 1:51 PM · Parsoid-Rendering, Parsoid
TheDJ added a subtask for T250463: Kartographer maps don't appear after first added while using the preview function on the 2017 wikitext editor: T162399: Parsoid doesn't add JS modules to <head> in its output.
Apr 20 2020, 1:51 PM · Parsing-Team, Editing-team (Tracking), VisualEditor, Maps (Kartographer), VisualEditor-MediaWiki-2017WikitextEditor

Apr 17 2020

TheDJ closed T250463: Kartographer maps don't appear after first added while using the preview function on the 2017 wikitext editor as Invalid.
  1. That's not a Kartographer map on that page, just a simple image.
  2. Preview seems to work for me.

Apr 17 2020, 12:01 PM · Parsing-Team, Editing-team (Tracking), VisualEditor, Maps (Kartographer), VisualEditor-MediaWiki-2017WikitextEditor
TheDJ claimed T250463: Kartographer maps don't appear after first added while using the preview function on the 2017 wikitext editor.
Apr 17 2020, 8:04 AM · Parsing-Team, Editing-team (Tracking), VisualEditor, Maps (Kartographer), VisualEditor-MediaWiki-2017WikitextEditor

Apr 15 2020

TheDJ added a comment to T247221: Special:Nearby should allow users to input their location (coordinates) manually too.

Fyi, I run a nominatim proxy on toollabs to make sure other toollabs projects using nominatim can use it without leaking userinfo.

Apr 15 2020, 4:50 PM · Maps, NearbyPages
TheDJ added a comment to T229800: Map thumbnail does not show sometimes.

I think this is mostly fixed now..
Unfortunately I also think these were multiple issues happening at once. Probably the php7 parser and broken Json inclusion. But also cached out of date static images and possibly the bug with mobile static images not working.

Apr 15 2020, 10:46 AM · Maps (Kartotherian)

Apr 13 2020

TheDJ closed T249129: ResourceLoader breaks Leaflet library as Invalid.

I had sent this by mail as well but, this is not a resourceloader problem.

Apr 13 2020, 8:04 PM · Performance-Team, MediaWiki-ResourceLoader
TheDJ added a project to T160767: Inconsistent coordinates with different page widths: User-TheDJ.
Apr 13 2020, 7:55 PM · User-TheDJ, Russian-Sites, Maps (Kartographer)
TheDJ closed T199641: stroke-width can't be set (JSON content is not valid GeoJSON+simplestyle) as Invalid.

This is because stroke-width takes a number, not a string:

<mapframe width="200" height="200">
[{
  "type": "Feature",
  "properties": { "fill": "#ff3333", "stroke-width": 5 },
  "geometry": { "type": "Polygon", "coordinates": [] }
}]
</mapframe>
Apr 13 2020, 7:42 PM · Documentation, Maps (Kartographer)
TheDJ removed a project from T181604: it:voy needs Kartographer to shows ordered POI on specific template: Patch-For-Review.

@Andyrom75 just wondering what the status of this is. Is there anything still needed to fix your problem ? Do you have an example page with the problem ?

Apr 13 2020, 7:31 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Maps (Kartographer)
TheDJ closed T180909: <maplink> doesn't add nearby and layer controls in full-screen view as Resolved.
Apr 13 2020, 7:23 PM · MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Maps (Kartographer)
TheDJ added a comment to T151524: Maps fast preview is broken on 2nd attempt.

This is basically the same as T125263: Interactive maps get resized to a thumbnail

Apr 13 2020, 2:57 PM · Patch-For-Review, User-TheDJ, Maps (Kartographer)
TheDJ added a comment to T246314: Map cannot be displayed in simplified Chinese: "GroupId not available".

Note for later. Keep in mind T168601: Wikicode in map data is always rendered in enwiki if data is from Sparql

Apr 13 2020, 2:19 PM · Chinese-Sites, Maps (Kartographer)
TheDJ added a comment to T168601: Wikicode in map data is always rendered in enwiki if data is from Sparql.
    // TODO: we shouldn't use it directly,
    // but instead refactor out mwapi lib from node_service_template
    // and use the proper host
const mwapi = core.getConfiguration().mwapi_req;
config.mwapi = (mwapi && mwapi.uri) || 'https://en.wikipedia.org/w/api.php';

https://github.com/wikimedia/mediawiki-services-kartotherian/blob/4592692ddc14dc2fb3f20f5756fa2cf92dc6023a/packages/geoshapes/index.js#L43

Apr 13 2020, 2:17 PM · Maps (Kartotherian), Product-Infrastructure-Team-Backlog
TheDJ edited projects for T168601: Wikicode in map data is always rendered in enwiki if data is from Sparql, added: Maps (Kartotherian); removed Maps (Kartographer).

Confirm that this is still a problem. Kartotherian seems to do all its parsing against en.wikipedia.org, instead of the domain it should be using...

Apr 13 2020, 2:14 PM · Maps (Kartotherian), Product-Infrastructure-Team-Backlog
TheDJ added a watcher for Maps: TheDJ.
Apr 13 2020, 1:42 PM
TheDJ edited projects for T196191: Support SPARQL returning WKT data as GeoJSON for Kartographer, added: Maps (Kartotherian); removed Maps (Kartographer).

This requires implementation in Kartotherian, Kartographer has no idea about Wikidata (or any non-local source honestly). Should be relatively easy to wrap wkt as geojson. Open question.. can there be more than one column of wkt ?

Apr 13 2020, 1:40 PM · Maps (Kartotherian), Wikidata
TheDJ updated the task description for T196191: Support SPARQL returning WKT data as GeoJSON for Kartographer.
Apr 13 2020, 1:30 PM · Maps (Kartotherian), Wikidata

Apr 12 2020

TheDJ closed T203319: way (route) throws a triangular shade as Resolved.

Possibly Kartographer should ignore fill value for geolines?

Apr 12 2020, 3:35 PM · Maps (Kartographer)
TheDJ closed T70008: PDF-related improvements needed at Wikivoyage, especially for dynamic maps as Resolved.
Apr 12 2020, 3:29 PM · Browser-support-print-media, Maps (Kartographer), Collection
TheDJ closed T70008: PDF-related improvements needed at Wikivoyage, especially for dynamic maps, a subtask of T43307: Alow comparison with old revisions while editing an old version of a page, as Resolved.
Apr 12 2020, 3:29 PM · MediaWiki-Page-History, MediaWiki-Page-Diffs
TheDJ closed T120809: Generate location maps dynamically, producing actual images, a subtask of T52714: VisualEditor: Location map template does not display correctly, as Resolved.
Apr 12 2020, 2:36 PM · User-Ryasmeen, VisualEditor, VisualEditor-ContentEditable
TheDJ closed T120809: Generate location maps dynamically, producing actual images, a subtask of T32702: PDF export extension problem with <div style="position:> and any location templates, as Resolved.
Apr 12 2020, 2:36 PM · OCG-General
TheDJ closed T120809: Generate location maps dynamically, producing actual images, a subtask of T64572: Media Viewer and location map overlays, as Resolved.
Apr 12 2020, 2:36 PM · Multimedia, Readers-Web-Backlog, MediaViewer
TheDJ closed T120809: Generate location maps dynamically, producing actual images, a subtask of T70008: PDF-related improvements needed at Wikivoyage, especially for dynamic maps, as Resolved.
Apr 12 2020, 2:36 PM · Browser-support-print-media, Maps (Kartographer), Collection
TheDJ closed T120809: Generate location maps dynamically, producing actual images, a subtask of T92535: Exclude {{location map}} images from PageImages, as Resolved.
Apr 12 2020, 2:36 PM · Readers-Web-Backlog, Page-Previews, PageImages
TheDJ closed T120809: Generate location maps dynamically, producing actual images, a subtask of T169507: Fix vector map visualisations once the user clicks them on an article, as Resolved.
Apr 12 2020, 2:36 PM · Wikimedia-General-or-Unknown
TheDJ closed T120809: Generate location maps dynamically, producing actual images as Resolved.

i'm calling this resolved. Wether or not communities use it or not.

Apr 12 2020, 2:36 PM · Maps (Kartographer), Commons, MediaWiki-extension-requests
TheDJ closed T141777: Track map usage on wikipedias as Declined.
Apr 12 2020, 2:34 PM · Contributors-Team, Maps (Kartographer)
TheDJ closed T150397: Switch to "content pages" vs "non-content pages" categories for maps tracking as Declined.

tracking categories seem to have been removed a while ago. (probably in favor of statistics tracking?)

Apr 12 2020, 2:31 PM · Maps (Kartographer)
TheDJ added a comment to T226454: Template:Maplink does not display thumbnail with frame-align=center setting.

This might be fixed next week because of

Apr 12 2020, 2:18 PM · wikimedia-page-library, Parsoid, Maps (Kartographer)
TheDJ changed the subtype of T193406: Provide a user interface to switch language for interactive map labels from "Task" to "Feature Request".
Apr 12 2020, 1:41 PM · Maps (Kartographer), User-Abbe98, I18n

Apr 11 2020

TheDJ claimed T180909: <maplink> doesn't add nearby and layer controls in full-screen view.
Apr 11 2020, 11:17 PM · MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Maps (Kartographer)