Mon, Sep 30
Sat, Sep 28
I will claim this as I do intend to work on it after the time frame mentioned by @Jdforrester-WMF .
@Masumrezarock100 Well...I went to fix it today and just realized that there is actually nothing that needs fixing here.....it is "mw.user.tokens.set" vs "mw.user.tokens.get", the latter of which needs updating - not the former to my understanding. Closing.
Fri, Sep 27
Wed, Sep 25
Emails seem to be coming through again. Just sent one using the interface and immediately had my copy of it in my inbox. Haven't received any via the interface to check otherwise though (for the other half of the problem).
You're welcome @Krinkle ! I'm glad that I could help. This was my first contribution to core :)
Tue, Sep 24
@Zoranzoki21 we edit conflicted closing this :P
Mon, Sep 23
@Krinkle This is one of the last remaining WMF deployed ones needing updating. If you think that another task should be made regarding line 46, I can go ahead and create it if you wish. When it comes to addressing it, I guess the first move would be to just remove it and see what happens (if anything) in a test environment(?)
Been working on a proposed commit to add this. Will submit for review soon.
@Krinkle tried submitting a patch just now but keep getting the following error. It was working previously for extensions without issue.
$ git review -R remote: Unauthorized fatal: Authentication failed for 'https://gerrit.wikimedia.org/r/mediawiki/core.git/'
@DannyS712 you have rights to the github version. Could you please take a look at my pull request there? Thanks!
Pull request created on GitHub.
Pull request made on GitHub.
Pull request also made on GitHub.
@DannyS712 we just did the phabricator version of an edit conflict on this haha.