Page MenuHomePhabricator

ThomasEugeneBishop
User

Projects

User does not belong to any projects.

Today

  • No visible events.

Tomorrow

  • No visible events.

Thursday

  • No visible events.

User Details

User Since
Jul 3 2017, 6:24 PM (437 w, 22 h)
Availability
Available
LDAP User
Unknown
MediaWiki User
ThomasEugeneBishop [ Global Accounts ]

Recent Activity

Mar 17 2019

ThomasEugeneBishop added a comment to T116145: Atom feed should not be advertised if $wgFeed is false.

Hurray, thank you!

Mar 17 2019, 4:54 PM · MediaWiki-General, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review
ThomasEugeneBishop added a comment to T116145: Atom feed should not be advertised if $wgFeed is false.

It does reproduce for me on 1.32.0 using the Vector skin. Did you try going to "Recent Changes"? That's where I see the "Atom" link in the left sidebar with an orange RSS icon. I don't see it on other pages.

Mar 17 2019, 4:08 PM · MediaWiki-General, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review

Mar 14 2019

ThomasEugeneBishop placed T116145: Atom feed should not be advertised if $wgFeed is false up for grabs.
Mar 14 2019, 1:20 PM · MediaWiki-General, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review

Jan 29 2018

ThomasEugeneBishop added a comment to T116145: Atom feed should not be advertised if $wgFeed is false.

Saper has updated here, with added testing:

Jan 29 2018, 2:57 PM · MediaWiki-General, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review

Jul 4 2017

ThomasEugeneBishop added a comment to T116145: Atom feed should not be advertised if $wgFeed is false.

I raised the priority of this task from Low to Normal. A documented feature ($wgFeed) clearly fails to work. This is a bug fix, not a feature enhancement. The bug has been encountered in actual usage by different people. Someone made the effort, long ago, to create this task and provide a solution. Someone else studied the solution and expressed approval. I've brought it up to date with changes that occurred in the meantime. Following through and merging the solution, before it gets out of sync with the master branch again, can't reasonably be considered a low priority.

Jul 4 2017, 7:52 AM · MediaWiki-General, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review
ThomasEugeneBishop raised the priority of T116145: Atom feed should not be advertised if $wgFeed is false from Low to Medium.
Jul 4 2017, 7:30 AM · MediaWiki-General, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review
ThomasEugeneBishop added a comment to T116145: Atom feed should not be advertised if $wgFeed is false.

Change 247821 was written before the addition of the hook AfterBuildFeedLinks. In order to make the equivalent change now, it's necessary to decide whether AfterBuildFeedLinks should be called unconditionally, or only when $wgFeed is true.

Jul 4 2017, 5:34 AM · MediaWiki-General, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review

Jul 3 2017

ThomasEugeneBishop added a comment to T116145: Atom feed should not be advertised if $wgFeed is false.

Until the bug is fixed, a workaround for hiding the Atom link in the sidebar of the RecentChanges page is to make these arrays empty in LocalSettings.php:

Jul 3 2017, 7:14 PM · MediaWiki-General, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review
ThomasEugeneBishop claimed T116145: Atom feed should not be advertised if $wgFeed is false.
Jul 3 2017, 6:41 PM · MediaWiki-General, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review
ThomasEugeneBishop added a comment to T116145: Atom feed should not be advertised if $wgFeed is false.

Patches were submitted to fix this bug a year and a half ago, but never merged. The bug still exists. What needs to happen now? Can I help?

Jul 3 2017, 6:38 PM · MediaWiki-General, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review