Page MenuHomePhabricator

Tiago.Martinho (Tiago Martinho)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 5 2018, 5:27 AM (315 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Tiago.martinho [ Global Accounts ]

Recent Activity

May 3 2018

GitHub <noreply@github.com> committed rAPIOS91038b2168b6: Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into… (authored by Tiago.Martinho).
Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into…
May 3 2018, 6:45 AM

May 2 2018

GitHub <noreply@github.com> committed rAPIOS7828658f462f: Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into… (authored by Tiago.Martinho).
Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into…
May 2 2018, 8:09 PM
GitHub <noreply@github.com> committed rAPIOS7b6c9a94e3c7: Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into… (authored by Tiago.Martinho).
Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into…
May 2 2018, 3:14 PM
GitHub <noreply@github.com> committed rAPIOSbc65561fac23: Merge aa9de9b9a996c41655bbdfcdbdfd033de9649014 into… (authored by Tiago.Martinho).
Merge aa9de9b9a996c41655bbdfcdbdfd033de9649014 into…
May 2 2018, 3:06 PM

May 1 2018

GitHub <noreply@github.com> committed rAPIOS611db1c36f4d: Merge d613514a5669a53af2c0bca3bc34ad3566f8f26a into… (authored by Tiago.Martinho).
Merge d613514a5669a53af2c0bca3bc34ad3566f8f26a into…
May 1 2018, 5:14 PM

Apr 30 2018

GitHub <noreply@github.com> committed rAPIOSc5eeb02fabe3: Merge d613514a5669a53af2c0bca3bc34ad3566f8f26a into… (authored by Tiago.Martinho).
Merge d613514a5669a53af2c0bca3bc34ad3566f8f26a into…
Apr 30 2018, 8:16 PM
GitHub <noreply@github.com> committed rAPIOS7e7764cc171d: Merge 5002f1d7b3bbfc0d64c195df1cfbdf92509b5da2 into… (authored by Tiago.Martinho).
Merge 5002f1d7b3bbfc0d64c195df1cfbdf92509b5da2 into…
Apr 30 2018, 6:13 PM
GitHub <noreply@github.com> committed rAPIOS0faba2ce7f42: Merge 5002f1d7b3bbfc0d64c195df1cfbdf92509b5da2 into… (authored by Tiago.Martinho).
Merge 5002f1d7b3bbfc0d64c195df1cfbdf92509b5da2 into…
Apr 30 2018, 5:06 PM
GitHub <noreply@github.com> committed rAPIOS64aeb87773f3: Merge 02035dcc1579f4d804d6ff2feef611ee933c216b into… (authored by Tiago.Martinho).
Merge 02035dcc1579f4d804d6ff2feef611ee933c216b into…
Apr 30 2018, 1:45 PM

Apr 29 2018

GitHub <noreply@github.com> committed rAPIOS50763666be3e: Merge 02035dcc1579f4d804d6ff2feef611ee933c216b into… (authored by Tiago.Martinho).
Merge 02035dcc1579f4d804d6ff2feef611ee933c216b into…
Apr 29 2018, 7:16 PM
Tiago.Martinho committed rAPIOS02035dcc1579: Share GIF.
Share GIF
Apr 29 2018, 7:16 PM
Tiago.Martinho added a comment to T139519: When copying an animated gif image from the gallery view, it only copies a still png image.

This PR solves the sharing GIF bug.

Apr 29 2018, 7:14 PM · iOS-app-v5.8.2-Manatee-On-A-Model-T, Upstream, User-Josve05a, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
Tiago.Martinho added a comment to T139519: When copying an animated gif image from the gallery view, it only copies a still png image.

The fix in the library NYTPhotoViewer fork was not enough. Seems that 'WMFImageGalleryViewController' is overriding the sharing and copying behavior.

Apr 29 2018, 5:18 PM · iOS-app-v5.8.2-Manatee-On-A-Model-T, Upstream, User-Josve05a, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Apr 28 2018

Tiago.Martinho added a comment to T139519: When copying an animated gif image from the gallery view, it only copies a still png image.

I opened a PR to fix the bug in the NYTPhotoViewer fork https://github.com/wikimedia/NYTPhotoViewer/pull/1

Apr 28 2018, 12:59 PM · iOS-app-v5.8.2-Manatee-On-A-Model-T, Upstream, User-Josve05a, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
GitHub <noreply@github.com> committed rAPIOS6c27461f952a: Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into… (authored by Tiago.Martinho).
Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into…
Apr 28 2018, 9:14 AM
Tiago.Martinho claimed T139519: When copying an animated gif image from the gallery view, it only copies a still png image.

I found the bug in the NYTimes library, I did a [[ PR | https://github.com/NYTimes/NYTPhotoViewer/pull/263/commits/828f43c00d5f60ed38e2807233c8f0fd122962bb ]], I still need to rebase the changes in the Wikimedia fork and test in the Wikipedia iOS app.

Apr 28 2018, 8:42 AM · iOS-app-v5.8.2-Manatee-On-A-Model-T, Upstream, User-Josve05a, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Apr 27 2018

GitHub <noreply@github.com> committed rAPIOSb7bad2adbfce: Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into… (authored by Tiago.Martinho).
Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into…
Apr 27 2018, 5:52 PM

Apr 26 2018

GitHub <noreply@github.com> committed rAPIOS7841c66eeede: Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into… (authored by Tiago.Martinho).
Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into…
Apr 26 2018, 8:25 PM
GitHub <noreply@github.com> committed rAPIOS317cc3ce8df5: Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into… (authored by Tiago.Martinho).
Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into…
Apr 26 2018, 12:32 AM

Apr 21 2018

GitHub <noreply@github.com> committed rAPIOSd14651e00e20: Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into… (authored by Tiago.Martinho).
Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into…
Apr 21 2018, 8:18 AM

Apr 20 2018

GitHub <noreply@github.com> committed rAPIOSe6289d44d09b: Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into… (authored by Tiago.Martinho).
Merge 74365ba5488d2710eebec29f4a305b5b1ff3ebed into…
Apr 20 2018, 6:49 AM
Tiago.Martinho committed rAPIOS74365ba5488d: Fix self before super init error.
Fix self before super init error
Apr 20 2018, 6:49 AM

Apr 11 2018

Tiago.Martinho added a comment to T136774: Audit App Labels to Ensure Longer Translations Aren't Truncated.

I set the language to Urdu using the arguments passed on launch:

arguments.png (132×575 px, 12 KB)

The language app when I run seems correct:
urdu.png (2×1 px, 924 KB)

However this assertion fails when I tap the search bar:
assert.png (1×2 px, 644 KB)

Moreover if I disable the assertion and try to find something that doesn't exist the message I get is different from the one reported no?
Simulator Screen Shot - iPhone X - 2018-04-11 at 08.53.45.png (2×1 px, 77 KB)

Apr 11 2018, 6:54 AM · I18n, iOS-app-feature-Multilingual, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
Tiago.Martinho added a comment to T185256: [BUG] When scrolling ref panels side-to-side there should be no left-right margin.

This can be closed https://github.com/wikimedia/wikipedia-ios/pull/2176

Apr 11 2018, 6:24 AM · good first task, Regression, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Apr 5 2018

GitHub <noreply@github.com> committed rAPIOS4918713b43ed: Merge 563b16893552b4b72d8e6b0353a0bf0872a9bbff into… (authored by Tiago.Martinho).
Merge 563b16893552b4b72d8e6b0353a0bf0872a9bbff into…
Apr 5 2018, 10:52 PM
GitHub <noreply@github.com> committed rAPIOS10806fefffec: Merge 563b16893552b4b72d8e6b0353a0bf0872a9bbff into… (authored by Tiago.Martinho).
Merge 563b16893552b4b72d8e6b0353a0bf0872a9bbff into…
Apr 5 2018, 9:43 PM
GitHub <noreply@github.com> committed rAPIOS71a6560e8927: Merge 563b16893552b4b72d8e6b0353a0bf0872a9bbff into… (authored by Tiago.Martinho).
Merge 563b16893552b4b72d8e6b0353a0bf0872a9bbff into…
Apr 5 2018, 5:36 PM
Tiago.Martinho added a comment to T127376: Should capitilze first letter after colon, in "Did you mean User:foo".

Correct @JMinor, the displayed string comes from the API:

Captura de pantalla 2018-04-05 a las 8.30.03.png (1×2 px, 393 KB)

Apr 5 2018, 6:32 AM · User-Josve05a, Wikipedia-iOS-App-Backlog
Tiago.Martinho added a comment to T185256: [BUG] When scrolling ref panels side-to-side there should be no left-right margin.

Final result:

Apr 5 2018, 6:17 AM · good first task, Regression, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
Tiago.Martinho added a comment to T185256: [BUG] When scrolling ref panels side-to-side there should be no left-right margin.

I submitted a Pull Request on GitHub.

Apr 5 2018, 6:17 AM · good first task, Regression, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
GitHub <noreply@github.com> committed rAPIOS5de355fdb15d: Merge 563b16893552b4b72d8e6b0353a0bf0872a9bbff into… (authored by Tiago.Martinho).
Merge 563b16893552b4b72d8e6b0353a0bf0872a9bbff into…
Apr 5 2018, 6:17 AM
Tiago.Martinho committed rAPIOS563b16893552: Remove margin from scrolling reference panels.
Remove margin from scrolling reference panels
Apr 5 2018, 6:16 AM
Tiago.Martinho claimed T185256: [BUG] When scrolling ref panels side-to-side there should be no left-right margin.
Apr 5 2018, 6:13 AM · good first task, Regression, iOS-app-Bugs, Wikipedia-iOS-App-Backlog