Page MenuHomePhabricator

Tjlsangria
Disabled

Projects

User does not belong to any projects.

User Details

User Since
Sep 7 2016, 12:21 AM (186 w, 1 d)
Roles
Disabled
LDAP User
Unknown
MediaWiki User
Tjlsangria [ Global Accounts ]

Recent Activity

Oct 2 2016

Tjlsangria added a comment to T147160: Add NS_TEMPLATE to wgNamespacesWithSubpages in DefaultSettings.php.

Is this change important enough that it needs to be noted in the release notes?

Oct 2 2016, 7:33 PM · MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), MW-1.29-release-notes, Patch-For-Review, good first task, MediaWiki-General
Tjlsangria created T147160: Add NS_TEMPLATE to wgNamespacesWithSubpages in DefaultSettings.php.
Oct 2 2016, 7:10 PM · MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), MW-1.29-release-notes, Patch-For-Review, good first task, MediaWiki-General
Tjlsangria renamed T70298: Give sysops deletelogentry and deleterevision rights by default from Give sysops deleterevision rights by default to Give sysops deletelogentry and deleterevision rights by default.
Oct 2 2016, 6:00 PM · Patch-For-Review, MediaWiki-Revision-deletion
Tjlsangria renamed T147154: Add an "affected revisions" link to items in the deletion log from Add an "affected revisions" link to the deletion log to Add an "affected revisions" link to items in the deletion log.
Oct 2 2016, 5:42 PM · MediaWiki-Special-pages, MediaWiki-Page-deletion
Tjlsangria added a comment to T146852: Clear out some cruft from interwiki.sql.

How do we decide which Wikimedia sites to keep in the table? Are we limiting it to actual wikis? I notice we have wikimedia: on there, but not policy: which is on the interwiki map.

Oct 2 2016, 5:25 PM · MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), Patch-For-Review, MediaWiki-Interwiki
Tjlsangria updated the task description for T147154: Add an "affected revisions" link to items in the deletion log.
Oct 2 2016, 5:14 PM · MediaWiki-Special-pages, MediaWiki-Page-deletion
Tjlsangria added a parent task for T147154: Add an "affected revisions" link to items in the deletion log: T71047: Develop countermeasures to the merge page histories attack.
Oct 2 2016, 5:06 PM · MediaWiki-Special-pages, MediaWiki-Page-deletion
Tjlsangria created T147154: Add an "affected revisions" link to items in the deletion log.
Oct 2 2016, 5:04 PM · MediaWiki-Special-pages, MediaWiki-Page-deletion
Tjlsangria added a comment to T146852: Clear out some cruft from interwiki.sql.

Can we agree in this task on some stuff to cut out of the table, and then file separate tasks proposing adding other stuff?

Oct 2 2016, 2:14 AM · MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), Patch-For-Review, MediaWiki-Interwiki

Oct 1 2016

Tjlsangria added a comment to T146852: Clear out some cruft from interwiki.sql.

So I'm thinking the ones that will be kept will be:

Oct 1 2016, 11:18 PM · MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), Patch-For-Review, MediaWiki-Interwiki
Tjlsangria added a comment to T17441: Some tables lack unique or primary keys, may allow confusing duplicate data.

If this is being actively worked on, I'd like to note one other thing that should probably be changed along with this: a lot of our tables have primary keys, but also don't at the same time. Basically, the maintenance/tables.sql file doesn't list the table as having a primary key, but MySQL behavior is to choose the first non-null unique key as use it as a primary key anyway. In other words, the tables don't *look* like they have primary keys in their definitions, but they actually do when created. It'd be simpler and less misleading to just explicitly declare the primary keys.

Oct 1 2016, 10:44 PM · MediaWiki-General, Wikimedia-database-error, PostgreSQL, DBA, Schema-change
Tjlsangria added a comment to T146570: Give user_properties a primary key.

So what's the upshot? Should the addition of user_properties.up_id be removed from https://gerrit.wikimedia.org/r/#/c/313670/ ?

Oct 1 2016, 6:53 PM · DBA, Wikimedia-Rdbms
Tjlsangria created T147125: On page deletion, put the page_len in log_params.
Oct 1 2016, 6:40 PM · MediaWiki-Logging, MediaWiki-Page-deletion
Tjlsangria added a comment to T17441: Some tables lack unique or primary keys, may allow confusing duplicate data.

Will this patch completely resolve this task, or are there more primary keys that remain to be added?

Oct 1 2016, 6:21 PM · MediaWiki-General, Wikimedia-database-error, PostgreSQL, DBA, Schema-change
Tjlsangria added a comment to T146570: Give user_properties a primary key.

Oh, so I guess user_properties actually does have a unique index? Does it still need a primary key, then?

Oct 1 2016, 5:25 PM · DBA, Wikimedia-Rdbms
Tjlsangria added a comment to T146585: Add a primary key to user_newtalk.

What should we call the primary key? un_id? unt_id? user_newtalk_id? I was thinking, maybe down the road we would want to use the un_ prefix for something more important.

Oct 1 2016, 3:35 PM · Wikimedia-database-error, Schema-change, MediaWiki-General, Patch-For-Review

Sep 28 2016

Tjlsangria added a project to T146852: Clear out some cruft from interwiki.sql: MediaWiki-Interwiki.
Sep 28 2016, 1:59 AM · MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), Patch-For-Review, MediaWiki-Interwiki
Tjlsangria created T146852: Clear out some cruft from interwiki.sql.
Sep 28 2016, 1:59 AM · MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), Patch-For-Review, MediaWiki-Interwiki
Tjlsangria created T146850: Add WikiApiary to interwiki.sql, the default interwiki table at time of wiki installation.
Sep 28 2016, 1:56 AM · MediaWiki-Interwiki

Sep 26 2016

Tjlsangria added a comment to T51087: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so.

Other useful parameters could include the prefixed page title and the revision ID presented as a clickable link to [[Special:Diff/xxx|revision xxx]].

Sep 26 2016, 1:18 AM · Pywikibot, Growth-Team, Pywikibot-Thanks, Collaboration-Team-Triage, Thanks
Tjlsangria added a comment to T146601: Make redirect creation a separate recent changes event from moving a page.

The same logic or principle that justifies T145991 might also justify this. When two separate rows in the page table are modified by an action, this should be recorded as two separate events.

Sep 26 2016, 12:21 AM · MediaWiki-Redirects, MediaWiki-Recent-changes
Tjlsangria created T146601: Make redirect creation a separate recent changes event from moving a page.
Sep 26 2016, 12:20 AM · MediaWiki-Redirects, MediaWiki-Recent-changes

Sep 25 2016

Tjlsangria added a comment to T146599: Create a way to make Special:AllPages hide redirects by default.

I'm trying to figure out the best way to implement this. The patch I wrote simply changes the checkbox to a "Show redirects" checkbox rather than a "Hide redirects" checkbox. But should there be a config setting that will allow the wiki owners to choose the default behavior?

Sep 25 2016, 11:42 PM · MediaWiki-Redirects, MediaWiki-Special-pages
Tjlsangria created T146599: Create a way to make Special:AllPages hide redirects by default.
Sep 25 2016, 11:06 PM · MediaWiki-Redirects, MediaWiki-Special-pages
Tjlsangria added a comment to T17441: Some tables lack unique or primary keys, may allow confusing duplicate data.

Note that some of the above (T17441#2658709) are scheduled for deletion or further alters are proposed for short term (oldimage -> image archive).

Sep 25 2016, 8:23 PM · MediaWiki-General, Wikimedia-database-error, PostgreSQL, DBA, Schema-change
Tjlsangria added a comment to T17441: Some tables lack unique or primary keys, may allow confusing duplicate data.
Sep 25 2016, 8:22 PM · MediaWiki-General, Wikimedia-database-error, PostgreSQL, DBA, Schema-change
Tjlsangria added a parent task for T146570: Give user_properties a primary key: T17441: Some tables lack unique or primary keys, may allow confusing duplicate data.
Sep 25 2016, 6:45 PM · DBA, Wikimedia-Rdbms
Tjlsangria added a subtask for T17441: Some tables lack unique or primary keys, may allow confusing duplicate data: T146570: Give user_properties a primary key.
Sep 25 2016, 6:45 PM · MediaWiki-General, Wikimedia-database-error, PostgreSQL, DBA, Schema-change
Tjlsangria added a parent task for T146591: Add a primary key to l10n_cache: T17441: Some tables lack unique or primary keys, may allow confusing duplicate data.
Sep 25 2016, 6:44 PM · Blocked-on-schema-change, Patch-For-Review, Wikimedia-Rdbms
Tjlsangria added a subtask for T17441: Some tables lack unique or primary keys, may allow confusing duplicate data: T146591: Add a primary key to l10n_cache.
Sep 25 2016, 6:44 PM · MediaWiki-General, Wikimedia-database-error, PostgreSQL, DBA, Schema-change
Tjlsangria created T146591: Add a primary key to l10n_cache.
Sep 25 2016, 6:44 PM · Blocked-on-schema-change, Patch-For-Review, Wikimedia-Rdbms
Tjlsangria added a parent task for T146586: Add a primary key to querycachetwo table: T17441: Some tables lack unique or primary keys, may allow confusing duplicate data.
Sep 25 2016, 5:50 PM · Schema-change, MediaWiki-Special-pages
Tjlsangria created T146586: Add a primary key to querycachetwo table.
Sep 25 2016, 4:40 PM · Schema-change, MediaWiki-Special-pages
Tjlsangria added a subtask for T17441: Some tables lack unique or primary keys, may allow confusing duplicate data: T146585: Add a primary key to user_newtalk.
Sep 25 2016, 4:40 PM · MediaWiki-General, Wikimedia-database-error, PostgreSQL, DBA, Schema-change
Tjlsangria added a parent task for T146585: Add a primary key to user_newtalk: T17441: Some tables lack unique or primary keys, may allow confusing duplicate data.
Sep 25 2016, 4:40 PM · Wikimedia-database-error, Schema-change, MediaWiki-General, Patch-For-Review
Tjlsangria created T146585: Add a primary key to user_newtalk.
Sep 25 2016, 4:39 PM · Wikimedia-database-error, Schema-change, MediaWiki-General, Patch-For-Review
Tjlsangria added a parent task for T146571: Add a primary key to querycache table: T17441: Some tables lack unique or primary keys, may allow confusing duplicate data.
Sep 25 2016, 7:29 AM · Schema-change, MediaWiki-Special-pages, Patch-For-Review
Tjlsangria added a subtask for T17441: Some tables lack unique or primary keys, may allow confusing duplicate data: T146571: Add a primary key to querycache table.
Sep 25 2016, 7:29 AM · MediaWiki-General, Wikimedia-database-error, PostgreSQL, DBA, Schema-change
Tjlsangria created T146571: Add a primary key to querycache table.
Sep 25 2016, 7:27 AM · Schema-change, MediaWiki-Special-pages, Patch-For-Review
Tjlsangria created T146570: Give user_properties a primary key.
Sep 25 2016, 7:26 AM · DBA, Wikimedia-Rdbms
Tjlsangria added a project to T146568: Add a primary key to oldimage: Wikimedia-Rdbms.
Sep 25 2016, 7:25 AM · MediaWiki-Comment-backend, Schema-change, Wikimedia-Rdbms
Tjlsangria created T146568: Add a primary key to oldimage.
Sep 25 2016, 7:25 AM · MediaWiki-Comment-backend, Schema-change, Wikimedia-Rdbms
Tjlsangria created T146566: When a page is undeleted, store the ar_page_id of each undeleted revision in log_params.
Sep 25 2016, 5:53 AM · MediaWiki-Logging, MediaWiki-Page-deletion

Sep 10 2016

Tjlsangria added a comment to T51087: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so.

I created this nifty maintenance script to retroactively populate the thanks log with revision IDs. https://www.mediawiki.org/wiki/User:Tjlsangria/populateThanksLogParams.php

Sep 10 2016, 4:04 PM · Pywikibot, Growth-Team, Pywikibot-Thanks, Collaboration-Team-Triage, Thanks
Tjlsangria added a comment to T51087: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so.

What do you want to call the $wg setting?

Sep 10 2016, 5:12 AM · Pywikibot, Growth-Team, Pywikibot-Thanks, Collaboration-Team-Triage, Thanks

Sep 7 2016

Tjlsangria added a comment to T51087: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so.

I've written a hack that doesn't require you to set a $wg; it would just be a 5::revid parameter that you could display by changing MediaWiki:Logentry-thanks-thank to, e.g., $1 thanked $3 for revision $5.

Sep 7 2016, 10:38 AM · Pywikibot, Growth-Team, Pywikibot-Thanks, Collaboration-Team-Triage, Thanks
Tjlsangria added a comment to T3991: Hide redirects from Special:Allpages.

I think the box should be checked by default.

Sep 7 2016, 2:16 AM · MediaWiki-Special-pages
Tjlsangria updated the task description for T144882: Add revision ID as a thank log parameter.
Sep 7 2016, 1:16 AM · MediaWiki-Logging, Collaboration-Team-Triage, Thanks
Tjlsangria created T144882: Add revision ID as a thank log parameter.
Sep 7 2016, 1:16 AM · MediaWiki-Logging, Collaboration-Team-Triage, Thanks
Tjlsangria added a project to T144878: Include the most recent page length in deletion log entries: MediaWiki-Page-deletion.
Sep 7 2016, 12:29 AM · MediaWiki-Page-deletion, MediaWiki-Logging
Tjlsangria updated the task description for T144878: Include the most recent page length in deletion log entries.
Sep 7 2016, 12:28 AM · MediaWiki-Page-deletion, MediaWiki-Logging
Tjlsangria created T144878: Include the most recent page length in deletion log entries.
Sep 7 2016, 12:27 AM · MediaWiki-Page-deletion, MediaWiki-Logging