Page MenuHomePhabricator

Tsiruot (Ishan Saini)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 4 2021, 5:52 AM (28 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Tsiruot [ Global Accounts ]

Recent Activity

Jun 22 2021

Tsiruot claimed T285135: Move development build assets into a 'dev' folder.
Jun 22 2021, 2:24 AM · Patch-For-Review, Wikimedia-Portals

May 20 2021

Tsiruot closed T274886: Wikimedia Portals repo has trouble running on Windows OS as Resolved.
May 20 2021, 9:02 AM · Wikimedia-Portals

Apr 25 2021

Tsiruot closed T278931: Search box doesn't show suggestions on focus ( wikipedia.org ) as Resolved.
Apr 25 2021, 1:05 PM · Wikimedia-Portals

Apr 15 2021

Tsiruot placed T262658: Update/Fix npm dependencies for wikimedia/portals.git up for grabs.
Apr 15 2021, 8:47 AM · SecTeam-Processed, Security, Wikimedia-Portals, Discovery-Portal-Backlog, Discovery, Security-Team
Tsiruot moved T279156: GSoC 2021 - Project Proposal : Update the front-page of Wikimedia projects from Backlog to Proposals Submitted on the Google-Summer-of-Code (2021) board.
Apr 15 2021, 2:00 AM · Google-Summer-of-Code (2021)

Apr 13 2021

Tsiruot added a subtask for T273179: Update the front-page of Wikimedia projects: T279156: GSoC 2021 - Project Proposal : Update the front-page of Wikimedia projects.
Apr 13 2021, 5:59 PM · Google-Summer-of-Code (2021), Wikimedia-Portals, Outreach-Programs-Projects
Tsiruot added a parent task for T279156: GSoC 2021 - Project Proposal : Update the front-page of Wikimedia projects: T273179: Update the front-page of Wikimedia projects.
Apr 13 2021, 5:58 PM · Google-Summer-of-Code (2021)
Tsiruot updated the task description for T279156: GSoC 2021 - Project Proposal : Update the front-page of Wikimedia projects.
Apr 13 2021, 8:29 AM · Google-Summer-of-Code (2021)

Apr 12 2021

Tsiruot updated the task description for T279156: GSoC 2021 - Project Proposal : Update the front-page of Wikimedia projects.
Apr 12 2021, 4:08 AM · Google-Summer-of-Code (2021)

Apr 4 2021

Tsiruot updated the task description for T279156: GSoC 2021 - Project Proposal : Update the front-page of Wikimedia projects.
Apr 4 2021, 8:27 AM · Google-Summer-of-Code (2021)

Apr 3 2021

Tsiruot added a comment to T262658: Update/Fix npm dependencies for wikimedia/portals.git.

Hey @VrushtiMody , fixing rest of the dependencies require a larger refactor.

Apr 3 2021, 2:15 PM · SecTeam-Processed, Security, Wikimedia-Portals, Discovery-Portal-Backlog, Discovery, Security-Team
Tsiruot updated the task description for T279156: GSoC 2021 - Project Proposal : Update the front-page of Wikimedia projects.
Apr 3 2021, 2:12 PM · Google-Summer-of-Code (2021)
Tsiruot added a comment to T274886: Wikimedia Portals repo has trouble running on Windows OS.
Apr 3 2021, 12:15 PM · Wikimedia-Portals
Tsiruot updated the task description for T279156: GSoC 2021 - Project Proposal : Update the front-page of Wikimedia projects.
Apr 3 2021, 2:37 AM · Google-Summer-of-Code (2021)

Apr 2 2021

Tsiruot updated the task description for T279156: GSoC 2021 - Project Proposal : Update the front-page of Wikimedia projects.
Apr 2 2021, 5:01 PM · Google-Summer-of-Code (2021)
Tsiruot added a comment to T279156: GSoC 2021 - Project Proposal : Update the front-page of Wikimedia projects.

Hey @Jdrewniak, this is my draft proposal for the project under GSoC 2021. Kindly provide your valuable feedback for the same.

Apr 2 2021, 4:53 PM · Google-Summer-of-Code (2021)
Tsiruot created T279156: GSoC 2021 - Project Proposal : Update the front-page of Wikimedia projects.
Apr 2 2021, 4:43 PM · Google-Summer-of-Code (2021)
Tsiruot added a comment to T262658: Update/Fix npm dependencies for wikimedia/portals.git.

I am sorry @VrushtiMody , I have already started working on it. However, I'd inform you if I get stuck anywhere, you could give it a shot then.

Apr 2 2021, 11:34 AM · SecTeam-Processed, Security, Wikimedia-Portals, Discovery-Portal-Backlog, Discovery, Security-Team
Tsiruot added a comment to T262658: Update/Fix npm dependencies for wikimedia/portals.git.

@Bharatkhatri351
No one claimed this task at the time I started working on it. Plus, you unassigned yourself a few days back.
It is always better to ask first mate :)
Anyhow, I will continue with the work.

Apr 2 2021, 10:01 AM · SecTeam-Processed, Security, Wikimedia-Portals, Discovery-Portal-Backlog, Discovery, Security-Team
Tsiruot added a comment to T262658: Update/Fix npm dependencies for wikimedia/portals.git.

Hey @Bharatkhatri351 , It'd be appreciated if you could ask people if they're working on a task already because it creates a room for merge conflicts sometimes. Also, I have been working on this (claimed the task) :)

Apr 2 2021, 9:39 AM · SecTeam-Processed, Security, Wikimedia-Portals, Discovery-Portal-Backlog, Discovery, Security-Team
Tsiruot added a comment to T262658: Update/Fix npm dependencies for wikimedia/portals.git.

I have fixed two warnings from gulp-cssnano in this patch.
Started working on gulp-svg-sprite now. Hopefully, I will be able to fix it.

Apr 2 2021, 8:56 AM · SecTeam-Processed, Security, Wikimedia-Portals, Discovery-Portal-Backlog, Discovery, Security-Team
Tsiruot claimed T262658: Update/Fix npm dependencies for wikimedia/portals.git.
Apr 2 2021, 8:52 AM · SecTeam-Processed, Security, Wikimedia-Portals, Discovery-Portal-Backlog, Discovery, Security-Team

Mar 31 2021

Tsiruot renamed T278931: Search box doesn't show suggestions on focus ( wikipedia.org ) from Search box doesn't show suggestions on focus to Search box doesn't show suggestions on focus ( wikipedia.org ).
Mar 31 2021, 10:09 AM · Wikimedia-Portals
Tsiruot created T278931: Search box doesn't show suggestions on focus ( wikipedia.org ).
Mar 31 2021, 10:07 AM · Wikimedia-Portals
Tsiruot added a comment to T273179: Update the front-page of Wikimedia projects.

@Shivas1000 https://gerrit.wikimedia.org/r/admin/repos/wikimedia/portals
This is the link to the repository.

Mar 31 2021, 6:51 AM · Google-Summer-of-Code (2021), Wikimedia-Portals, Outreach-Programs-Projects

Mar 29 2021

Tsiruot claimed T274886: Wikimedia Portals repo has trouble running on Windows OS.
Mar 29 2021, 7:50 AM · Wikimedia-Portals

Mar 25 2021

Tsiruot added a watcher for Wikimedia-Portals: Tsiruot.
Mar 25 2021, 11:58 AM

Mar 21 2021

Tsiruot closed T278039: Add a pre-commit hook to run `npm run test` as Resolved.
Mar 21 2021, 1:02 PM · Wikimedia-Portals
Tsiruot added a comment to T278035: Rename dev folder to src.

@Saudshaikh99 You can always claim a microtask if you have started working on it already by clicking on Add Action... and then Assign / Claim.

Mar 21 2021, 12:57 PM · Wikimedia-Portals
Tsiruot claimed T278039: Add a pre-commit hook to run `npm run test`.
Mar 21 2021, 11:23 AM · Wikimedia-Portals

Mar 18 2021

Tsiruot added a comment to T274579: Upgrade WebdriverIO to v7 in all repositories.

@Vidhi-Mody I was actually talking about the third micro-task in which we have to make a change in tests/selenium/README.md and push it here. But I get it, we're not supposed to do it yet.

Mar 18 2021, 8:23 AM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Patch-For-Review, User-zeljkofilipin, Quality-and-Test-Engineering-Team (QTE), Google-Summer-of-Code (2021)
Tsiruot added a comment to T274579: Upgrade WebdriverIO to v7 in all repositories.

Hey, good to see that the task has not been discarded yet. I was quite interested in it. I have a question though, Can we start doing the microtasks already, like, can we push the patch with a trivial change here?

Mar 18 2021, 6:35 AM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Patch-For-Review, User-zeljkofilipin, Quality-and-Test-Engineering-Team (QTE), Google-Summer-of-Code (2021)

Mar 17 2021

Tsiruot claimed T277408: Remove IE<9 CSS hacks from portals CSS.
Mar 17 2021, 7:23 AM · Wikimedia-Portals
Tsiruot added a comment to T277406: Remove unnecessary Javascript polyfills from portals repo.

@Aklapper Oh, I thought we remove it once the task gets resolved.

Mar 17 2021, 7:21 AM · Wikimedia-Portals
Tsiruot placed T254611: Portals default root language code `html lang=mul` seems insufficient up for grabs.
Mar 17 2021, 6:58 AM · Wikimedia-Portals
Tsiruot closed T254611: Portals default root language code `html lang=mul` seems insufficient as Resolved.
Mar 17 2021, 6:58 AM · Wikimedia-Portals

Mar 15 2021

Tsiruot placed T277406: Remove unnecessary Javascript polyfills from portals repo up for grabs.
Mar 15 2021, 5:10 PM · Wikimedia-Portals
Tsiruot closed T277406: Remove unnecessary Javascript polyfills from portals repo, a subtask of T277404: [EPIC] Modernize portals code for browser support and maintainability, as Resolved.
Mar 15 2021, 5:10 PM · Epic, Wikimedia-Portals
Tsiruot closed T277406: Remove unnecessary Javascript polyfills from portals repo as Resolved.
Mar 15 2021, 5:10 PM · Wikimedia-Portals
Tsiruot added a comment to T277407: Replace add/removeEvent methods with add/removeEventListener .

@Palak199 I am not a mentor. I was just helping you out in writing commits the correct way.

Mar 15 2021, 4:26 PM · Patch-For-Review, Wikimedia-Portals
Tsiruot added a comment to T273179: Update the front-page of Wikimedia projects.

@Deveshprasad577 Please ask these type of questions on Zulip. You'll get your solutions there :)
As for now, I think you didn't run npm install.
Switch to Zulip for further development setup related queries.

Mar 15 2021, 4:23 PM · Google-Summer-of-Code (2021), Wikimedia-Portals, Outreach-Programs-Projects
Tsiruot added a comment to T274886: Wikimedia Portals repo has trouble running on Windows OS.

@Jdrewniak I tried to implement this and it is working fine. But the lines of code have increased significantly.

Mar 15 2021, 3:02 PM · Wikimedia-Portals
Tsiruot added a comment to T277405: Refactor Gulpfile.js tasks into separate files.

@Jdrewniak I have moved the code of gulpfile.js into gulpfile.js/index.js. Kindly review the changes and merge them so that @Bharatkhatri351 can proceed further.

Mar 15 2021, 4:03 AM · Patch-For-Review, Wikimedia-Portals
Tsiruot added a comment to T277407: Replace add/removeEvent methods with add/removeEventListener .

Hey @Palak199 , I think you missed on these guidelines.

Mar 15 2021, 1:27 AM · Patch-For-Review, Wikimedia-Portals

Mar 14 2021

Tsiruot placed T277408: Remove IE<9 CSS hacks from portals CSS up for grabs.
Mar 14 2021, 5:09 PM · Wikimedia-Portals
Tsiruot closed T277408: Remove IE<9 CSS hacks from portals CSS, a subtask of T277404: [EPIC] Modernize portals code for browser support and maintainability, as Resolved.
Mar 14 2021, 5:07 PM · Epic, Wikimedia-Portals
Tsiruot closed T277408: Remove IE<9 CSS hacks from portals CSS as Resolved.
Mar 14 2021, 5:07 PM · Wikimedia-Portals
Tsiruot added a comment to T277405: Refactor Gulpfile.js tasks into separate files.

@Bharatkhatri351 We could discuss about it on Zulip.

Mar 14 2021, 5:05 PM · Patch-For-Review, Wikimedia-Portals
Tsiruot added a comment to T277406: Remove unnecessary Javascript polyfills from portals repo.

This patch removes all the methods mentioned above and fulfills all the criterias.

Mar 14 2021, 4:51 PM · Wikimedia-Portals
Tsiruot added a comment to T277405: Refactor Gulpfile.js tasks into separate files.

@Bharatkhatri351 I am sorry if it felt like it was unfair to you but I have already submitted two patches for other tasks and now I have also started working on this task. Like @Jdrewniak said this task can be divided into multiple patches, so let's work together on this task and get it done :)

Mar 14 2021, 4:47 PM · Patch-For-Review, Wikimedia-Portals
Tsiruot claimed T277405: Refactor Gulpfile.js tasks into separate files.
Mar 14 2021, 4:12 PM · Patch-For-Review, Wikimedia-Portals
Tsiruot added a comment to T277406: Remove unnecessary Javascript polyfills from portals repo.
Mar 14 2021, 4:03 PM · Wikimedia-Portals
Tsiruot claimed T277406: Remove unnecessary Javascript polyfills from portals repo.
Mar 14 2021, 3:19 PM · Wikimedia-Portals
Tsiruot added a comment to T277408: Remove IE<9 CSS hacks from portals CSS.

I have added a patch which fulfill all the criterias mentioned above.

Mar 14 2021, 3:13 PM · Wikimedia-Portals
Tsiruot claimed T277408: Remove IE<9 CSS hacks from portals CSS.
Mar 14 2021, 2:59 PM · Wikimedia-Portals

Mar 13 2021

Tsiruot added a comment to T274886: Wikimedia Portals repo has trouble running on Windows OS.

@Jdrewniak , Have a look at this package node-cmd.
I was wondering if this could be useful in our case. This could help in running cli/bash style commands in windows.

Mar 13 2021, 6:14 AM · Wikimedia-Portals

Mar 12 2021

Tsiruot claimed T254611: Portals default root language code `html lang=mul` seems insufficient.
Mar 12 2021, 12:14 PM · Wikimedia-Portals
Tsiruot added a comment to T254611: Portals default root language code `html lang=mul` seems insufficient.
Mar 12 2021, 11:13 AM · Wikimedia-Portals
Tsiruot added a comment to T246299: Add small Wikipedias like Balinese and Sakizaya to Wikipedia portal page.

Hi guys, look like not just 2 of this wikis, many wikis not included in wikipedia portal page. I will try to edit and add the list here sorted by name:

  1. Balinese wikipedia (ban)
  2. Gorontalo wikipedia (gor)
  3. Khmer (km)
  4. Madurese wikipedia (mad)
  5. Nias wikipedia (nia)
  6. Northern Sotho (nso)
  7. Sakizaya wikipedia (szy)
  8. Tarantino wikipedia (roa-tara)
  9. Western Armenian (hyw)
Mar 12 2021, 6:20 AM · Discovery, Wikimedia-Portals

Mar 11 2021

Tsiruot added a comment to T262783: Support Eastern Arabic numerals in project portals.

@Jdrewniak Yeah this totally makes sense afterall we don't want any type of ambiguity.

Mar 11 2021, 2:15 PM · I18n, Wikimedia-Portals
Tsiruot added a comment to T273179: Update the front-page of Wikimedia projects.

Hey @veeru153 , are you saying seperate templates for every portal? If yes, then wouldn't that be redundant?

Mar 11 2021, 2:07 PM · Google-Summer-of-Code (2021), Wikimedia-Portals, Outreach-Programs-Projects
Tsiruot added a comment to T232797: Search suggestions override right/middle-clicking behaviour.

I have added a patch which fixes this behaviour. It adds a click event when a search suggestion loses focus or when the blur event is triggered. Earlier, the link was followed because there was no click event which would allow only left clicks to open the link.

Mar 11 2021, 11:23 AM · Wikimedia-Portals

Mar 10 2021

Tsiruot added a comment to T273179: Update the front-page of Wikimedia projects.

hi @Jdrewniak I cloned the repo but i am unable to start the server using npm start. as suggested i installed npm using npm install.
it ran on the server but it's displayed as in the picture uploaded.

Screenshot (4).png (1×1 px, 132 KB)
. pls suggest what steps should i take furthur?

Mar 10 2021, 5:47 AM · Google-Summer-of-Code (2021), Wikimedia-Portals, Outreach-Programs-Projects

Mar 9 2021

Tsiruot added a comment to T262783: Support Eastern Arabic numerals in project portals.

i have a doubt if you do any kind of changes regarding language.
Are you able to see in your local host.
Because in my case
local host is only showing page in english language inspite of selected language is persian.

Mar 9 2021, 11:45 AM · I18n, Wikimedia-Portals
Tsiruot added a comment to T262783: Support Eastern Arabic numerals in project portals.

After hours of going through the codebase this is what I know :

Mar 9 2021, 10:51 AM · I18n, Wikimedia-Portals
Tsiruot added a comment to T262783: Support Eastern Arabic numerals in project portals.

in this comment i am only telling you a way to observe isssue......

Mar 9 2021, 6:04 AM · I18n, Wikimedia-Portals
Tsiruot added a comment to T262783: Support Eastern Arabic numerals in project portals.

their is no button to change wikipedia portal language.
You have to change your browser language to "persian" to observe this issue.

Mar 9 2021, 4:44 AM · I18n, Wikimedia-Portals
Tsiruot added a comment to T262783: Support Eastern Arabic numerals in project portals.

Hey , Where exactly do we not have Eastern Arabic Numerals?
Are we talking about count of articles being displayed on portals like this

Screenshot from 2021-03-09 09-06-47.png (921×1 px, 158 KB)

Mar 9 2021, 3:47 AM · I18n, Wikimedia-Portals

Mar 8 2021

Tsiruot added a comment to T273179: Update the front-page of Wikimedia projects.

Hey @Jdrewniak ,
I have been reading about this task and related tasks for quite a while now. I really find this project quite interesting and I have a basic understanding of this project now. If I had to summarise my understanding , it'd be like :
We have to create a common folder having templates which would be used by all the sister projects and the wikipedia.org itself. But that won't be as easy because we will also have to modify the gulp.js build pipeline.
I might be wrong but this is what I know so far. I think it'd be better to discuss further on IRC.

Mar 8 2021, 8:14 AM · Google-Summer-of-Code (2021), Wikimedia-Portals, Outreach-Programs-Projects
Tsiruot added a comment to T273179: Update the front-page of Wikimedia projects.
Mar 8 2021, 4:41 AM · Google-Summer-of-Code (2021), Wikimedia-Portals, Outreach-Programs-Projects

Mar 4 2021

Tsiruot added a comment to T274579: Upgrade WebdriverIO to v7 in all repositories.

Oh, that's unfortunate. So does that mean there is a slight chance of this project being dropped from GSOC'21?

Mar 4 2021, 12:08 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Patch-For-Review, User-zeljkofilipin, Quality-and-Test-Engineering-Team (QTE), Google-Summer-of-Code (2021)
Tsiruot added a comment to T274579: Upgrade WebdriverIO to v7 in all repositories.

Hey, I am Ishan. I was going through the project idea list and found this project quite interesting. I also read @Vidhi-Mody 's blog posts on the same project (v6 last year) which were quite helpful and interesting. I am trying to get familiar with WebdriverIO. I just wanted to ask if we could just go ahead with micro tasks without asking the mentors to assign them to us because I read the guide for new developers and found that we don't have to do that. I am sorry if that sounds a bit too obvious.

Mar 4 2021, 11:27 AM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Patch-For-Review, User-zeljkofilipin, Quality-and-Test-Engineering-Team (QTE), Google-Summer-of-Code (2021)