Page MenuHomePhabricator

Turnstep (Greg Sabino Mullane)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 25 2014, 1:07 PM (507 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Turnstep [ Global Accounts ]

Recent Activity

Jun 11 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rEEDIe2d8dec217cc: Final NoteDb migration updates (authored by Turnstep).
Final NoteDb migration updates
Jun 11 2018, 9:51 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEEDIf508f10129ba: Update patch set 1 (authored by Turnstep).
Update patch set 1
Jun 11 2018, 9:51 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEEDIb4fce827e707: Update patch set 1 (authored by Turnstep).
Update patch set 1
Jun 11 2018, 9:51 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEEDI5139d2a55b7d: Create change (authored by Turnstep).
Create change
Jun 11 2018, 9:51 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEEDIf92469027c72: Final NoteDb migration updates (authored by Turnstep).
Final NoteDb migration updates
Jun 11 2018, 9:50 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEEDI21fb7d102f8f: Create change (authored by Turnstep).
Create change
Jun 11 2018, 9:50 PM

Aug 17 2017

Turnstep added a watcher for PostgreSQL: Turnstep.
Aug 17 2017, 4:57 PM
Turnstep added a comment to T164898: PostgreSQL schema change for consistency with MySQL.

Rename tables mwuser to user, and pagecontent to text. Table names are always quoted, so
it doesn't matter if they are keywords. A table prefix can be used if desired to avoid having
table names that are keywords.

Aug 17 2017, 4:40 PM · MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), MW-1.36-notes, MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), User-Ladsgroup, Platform Engineering, TechCom-RFC (TechCom-RFC-Closed), Technical-Debt, PostgreSQL
Turnstep added a comment to T164898: PostgreSQL schema change for consistency with MySQL.

Not sure how I missed this task until now. I'm mostly okay with this, but the timestamp change in particular seems a step in the wrong direction.

Aug 17 2017, 4:37 PM · MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), MW-1.36-notes, MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), User-Ladsgroup, Platform Engineering, TechCom-RFC (TechCom-RFC-Closed), Technical-Debt, PostgreSQL

Aug 9 2017

Turnstep added a comment to T172845: What makes a high quality MediaWiki extension? - Hackathon session.

A good extension name, that explains intuitively what it does and avoids generic words

Aug 9 2017, 1:36 PM · MediaWiki-extensions-General, Wikimania-Hackathon-2017

Oct 16 2016

Turnstep added a comment to T147599: Cannot install 1.28 alpha with PostgreSQL database.

Ok, well it was just a quick idea. If I get some time I will test this out but most of my test boxes cannot handle 1.28 at the moment due to the recent PHP requirement.

Oct 16 2016, 3:44 PM · PostgreSQL, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), Patch-For-Review, MW-1.28-release, Regression, MediaWiki-libs-Rdbms, MediaWiki-Installer
Turnstep added a comment to T147599: Cannot install 1.28 alpha with PostgreSQL database.

@Turnstep hi, I carn't seem to find $conn->query("createdb") in PostgresInstaller.php.

Oct 16 2016, 3:18 PM · PostgreSQL, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), Patch-For-Review, MW-1.28-release, Regression, MediaWiki-libs-Rdbms, MediaWiki-Installer
Turnstep added a comment to T147599: Cannot install 1.28 alpha with PostgreSQL database.

What about simply changing the $conn->query("createdb") to $conn->doQuery in PostgresInstaller.php? We lose some random sanity checks and profiling, but this is a one-time create database call so those are not really important.

Oct 16 2016, 12:44 PM · PostgreSQL, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), Patch-For-Review, MW-1.28-release, Regression, MediaWiki-libs-Rdbms, MediaWiki-Installer

Sep 28 2016

Turnstep added a comment to T6323: Send a diff in email on page changes in addition to URL.

This extension is at mediawiki.org as EmailDiff

Sep 28 2016, 12:26 PM · MediaWiki-Email

Sep 6 2016

Turnstep added a comment to T134200: [RFC] RESTBase: Drop support for node 0.10 (and 0.12?).

A basic first step for questions like this is to see what the major distros (especially the LTS ones) are providing for node versions. As a point of data, looks like CentOS 7 is providing 0.10.46. On the other hand, we usually end up installing a local node anyway, so it won't affect us very much.

Sep 6 2016, 3:59 PM · Proposal, Services, RESTBase

Mar 24 2016

Turnstep added a comment to T129435: RFC: drop support for running without mbstring.

As a heavy "third-party MediaWiki operator", I am fine with requiring mbstring. It's standard, in all packaging systems, easy to enable, and seems a low cost for a high payoff.

Mar 24 2016, 2:15 PM · TechCom-RFC (TechCom-RFC-Closed), MW-1.27-release-notes, Technical-Debt

Mar 13 2016

Turnstep added a comment to T6323: Send a diff in email on page changes in addition to URL.
In T6323#2114893, @scfc wrote:

The extension looks great, but AFAIU the notification paradigm, MediaWiki only sends one notification for each page until the user visits that page again. So you get the diff for the first page and then nothing. IMHO that makes no sense.

Mar 13 2016, 8:16 PM · MediaWiki-Email

Feb 22 2016

Turnstep added a comment to T6323: Send a diff in email on page changes in addition to URL.

FWIW, this is now a full-blown extension:

Feb 22 2016, 7:28 PM · MediaWiki-Email

Jan 31 2016

Turnstep updated the task description for T125322: Change ParserFunctions license to GPL-2.0+.
Jan 31 2016, 3:30 PM · MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), Software-Licensing, ParserFunctions

Jan 6 2016

Turnstep added a comment to T70320: MediaViewer ignores EXIF rotation for original size image.

Are there any temporary workarounds? Willing to monkeypatch as heavy as needed....

Jan 6 2016, 6:56 PM · Multimedia, MediaViewer

Dec 3 2015

Turnstep added a comment to T118932: RfC: Raise MediaWiki's PHP version requirement to 5.5 and update coding standards.

"If one other person (any pre-existing Phabricator user) wants to put their name down as being unequivocally opposed to releasing 1.27.0 with a PHP 5.5 requirement" Barring better arguments for 5.5 than "has some neat stuff we would like to maybe use", and as someone who has hacked production code to get MW installed on machines with a too-low-but-still-works PHP versions :), I'm opposed for now.

Dec 3 2015, 7:36 PM · TechCom-RFC (TechCom-RFC-Closed), Proposal, MW-1.27-release

Nov 12 2015

Turnstep added a comment to T76566: Search is not functional after upgrade to MW 1.24.

Time for a new release!

Nov 12 2015, 5:42 PM · MediaWiki-extensions-SphinxSearch
Turnstep added a comment to T76566: Search is not functional after upgrade to MW 1.24.

Looks like this was fixed in acd40b8fa82c04e80d390f650ee368bbdd4628cd

Nov 12 2015, 5:42 PM · MediaWiki-extensions-SphinxSearch

Oct 29 2015

Turnstep added a comment to T68485: runJobs not following redirect.

Worked around this with a cronjob executing runJobs and turning off all async calls, but this is a very nasty bug.

Oct 29 2015, 2:54 PM · MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-08-30_(1.28.0-wmf.17)), Patch-For-Review, MediaWiki-Core-JobQueue

Jul 14 2015

Turnstep committed rMRELdfd1bb443de1: No time to fix, but leave a note about odd behavior of this extension for….
No time to fix, but leave a note about odd behavior of this extension for…
Jul 14 2015, 6:09 PM
Turnstep committed rMRELef71cac5a9b5: Use the new sequence name.
Use the new sequence name
Jul 14 2015, 6:09 PM
Turnstep committed rMRELaf7b82c61d63: Postgres schema updates, per request at ticket 18537..
Postgres schema updates, per request at ticket 18537.
Jul 14 2015, 6:08 PM
Turnstep committed rMREL1affe9e0744d: Modified version of patch from Brad Jorsch, updates Postgres schema to match….
Modified version of patch from Brad Jorsch, updates Postgres schema to match…
Jul 14 2015, 6:08 PM
Turnstep committed rMRELdde242bc8318: Quick Postgres support. Still have to remove some mysqlisms before it will….
Quick Postgres support. Still have to remove some mysqlisms before it will…
Jul 14 2015, 6:06 PM

Dec 10 2014

Turnstep committed rETIKf89d15b41b44: Use correct schema file when running an update..
Use correct schema file when running an update.
Dec 10 2014, 6:19 PM
Turnstep committed rETIK2cc166e4bbc4: Postgres version of schema..
Postgres version of schema.
Dec 10 2014, 6:19 PM
Turnstep committed rESMW709414627c1e: Postgres: fix incorrect code in getIndexInfo so that column names are now….
Postgres: fix incorrect code in getIndexInfo so that column names are now…
Dec 10 2014, 6:16 PM
Turnstep committed rESMW5e32affea872: Postgres changes: ALTER TABLE uses TYPE, not ENGINE Compare column type names….
Postgres changes: ALTER TABLE uses TYPE, not ENGINE Compare column type names…
Dec 10 2014, 6:16 PM
Turnstep committed rESPRb1a86b2241e7: Quick tweaks.
Quick tweaks
Dec 10 2014, 6:12 PM
Turnstep committed rESPR501c9809ca7a: Quick Postgres conversion..
Quick Postgres conversion.
Dec 10 2014, 6:12 PM
Turnstep committed rESPR93581b0b0fa6: First pass at Postgres support: schema transalation only, app code not tested..
First pass at Postgres support: schema transalation only, app code not tested.
Dec 10 2014, 6:12 PM
Turnstep committed rESPR0f79cd875132: Quick Postgres per request..
Quick Postgres per request.
Dec 10 2014, 6:12 PM
Turnstep committed rESMW9389b3c4a10c: We don't want the quoted table name when we are doing a direct lookup via a….
We don't want the quoted table name when we are doing a direct lookup via a…
Dec 10 2014, 6:12 PM
Turnstep committed rESMWb6e316aeabff: First pass at Postgres support..
First pass at Postgres support.
Dec 10 2014, 6:03 PM
Turnstep committed rESMW629c230f4bba: Typos..
Typos.
Dec 10 2014, 6:03 PM
Turnstep committed rESMW47b3e6641d0a: Add space before GROUP BY call..
Add space before GROUP BY call.
Dec 10 2014, 6:03 PM
Turnstep committed rESPO5d19ef339571: Postgres version of schema - untested..
Postgres version of schema - untested.
Dec 10 2014, 5:54 PM
Turnstep committed rEREN454611709704: Remember checkbox setting, properly quote SQL..
Remember checkbox setting, properly quote SQL.
Dec 10 2014, 5:51 PM
Turnstep committed rERIM6df4344c123d: Use an ORDER BY to enhance randomness.
Use an ORDER BY to enhance randomness
Dec 10 2014, 5:50 PM
Turnstep committed rERQT9e48acce35e7: Bump version to 1.11.
Bump version to 1.11
Dec 10 2014, 5:48 PM
Turnstep committed rERQT570bee32ed2e: A custom field may have multiple entries, don't show disabled ones..
A custom field may have multiple entries, don't show disabled ones.
Dec 10 2014, 5:48 PM
Turnstep committed rERQTeb48572694e0: Add missing rt-badcfield message..
Add missing rt-badcfield message.
Dec 10 2014, 5:48 PM
Turnstep committed rERQT7b26113f327b: Allow filtering by custom fields. Redo the way we build queries..
Allow filtering by custom fields. Redo the way we build queries.
Dec 10 2014, 5:48 PM
Turnstep committed rERQT38da46f13a42: Extract epoch to make all date columns sortable..
Extract epoch to make all date columns sortable.
Dec 10 2014, 5:48 PM
Turnstep committed rERQTb946b01b0d05: Allow limit=xx as an alias for l=xx.
Allow limit=xx as an alias for l=xx
Dec 10 2014, 5:48 PM
Turnstep committed rERQT1abd0287273b: Allow tables to be sortable, both globally and per invocation. Bump to version….
Allow tables to be sortable, both globally and per invocation. Bump to version…
Dec 10 2014, 5:48 PM
Turnstep committed rERQT6408001d9de8: Extension for interaction with the Request Tracker system..
Extension for interaction with the Request Tracker system.
Dec 10 2014, 5:47 PM
Turnstep committed rEPFN731f78b05e01: Trim the value passed to switchHook..
Trim the value passed to switchHook.
Dec 10 2014, 5:38 PM
Turnstep committed rEOVS1b9c628d6528: Quick schema for Postgres.
Quick schema for Postgres
Dec 10 2014, 5:34 PM
Turnstep committed rEOVS77c5bec3414d: Applied patch from Brad Jorsch, per bug 15834. Fixed Postgres schema and some….
Applied patch from Brad Jorsch, per bug 15834. Fixed Postgres schema and some…
Dec 10 2014, 5:34 PM
Turnstep committed rEOID8e5031a6f88a: Remove the SQL comments.
Remove the SQL comments
Dec 10 2014, 5:34 PM
Turnstep committed rEOVS8ddf31fb15e5: Use single quote, not double, inside SQL statement..
Use single quote, not double, inside SQL statement.
Dec 10 2014, 5:34 PM
Turnstep committed rEOID6f0ec873ee10: Postgres version of schema. Extension not tested with Postgres yet..
Postgres version of schema. Extension not tested with Postgres yet.
Dec 10 2014, 5:33 PM
Turnstep committed rENUK29163f9b2821: Adjust GROUP BY for databases that need all items from SELECT.
Adjust GROUP BY for databases that need all items from SELECT
Dec 10 2014, 5:30 PM
Turnstep committed rELQT5cff0197275c: Postgres version of the schema..
Postgres version of the schema.
Dec 10 2014, 5:07 PM
Turnstep committed rEGUSd8e92755bb2e: Add Postgres version of schema..
Add Postgres version of schema.
Dec 10 2014, 4:53 PM
Turnstep committed rEGUSbb9a9332f3c7: Clean up SQL..
Clean up SQL.
Dec 10 2014, 4:53 PM
Turnstep committed rEDYM1f5a8fcc14c7: Add Postgres support. Refactor touchpages concept..
Add Postgres support. Refactor touchpages concept.
Dec 10 2014, 4:36 PM
Turnstep committed rEFLRa34a58cd7a27: Change hard-coding to useIndexClause().
Change hard-coding to useIndexClause()
Dec 10 2014, 4:29 PM
Turnstep committed rEDRA78e6ef8d5ef7: Postgres version of schema for Drafts extension..
Postgres version of schema for Drafts extension.
Dec 10 2014, 4:25 PM
Turnstep committed rECNT34f71a90f777: Postgres version of table.
Postgres version of table
Dec 10 2014, 4:22 PM
Turnstep committed rECOE44094778b290: Fix syntax errors in last commit..
Fix syntax errors in last commit.
Dec 10 2014, 4:19 PM
Turnstep committed rECOE9aafa888c02f: Skip words if they don't contain all letters..
Skip words if they don't contain all letters.
Dec 10 2014, 4:19 PM
Turnstep committed rECHU6a71a06d9039: Put old indexes back in, minor cleanups..
Put old indexes back in, minor cleanups.
Dec 10 2014, 4:05 PM
Turnstep committed rECHUea8cf0eb97f7: No sense in storing timestamp in three separate indexes..
No sense in storing timestamp in three separate indexes.
Dec 10 2014, 4:05 PM
Turnstep committed rECHU2e4e056183b5: Don't use non-standard FORCE INDEX, but call useIndexClause() instead.
Don't use non-standard FORCE INDEX, but call useIndexClause() instead
Dec 10 2014, 4:05 PM
Turnstep committed rECNNf51d982be90b: Fix GROUP BY for databases not using implicitGroupby.
Fix GROUP BY for databases not using implicitGroupby
Dec 10 2014, 4:05 PM
Turnstep committed rECHU6af62fe8e39d: Existing index should be fine for Postgres..
Existing index should be fine for Postgres.
Dec 10 2014, 4:05 PM
Turnstep committed rECHUe46ecd0dc28e: Remove debug drop stuff..
Remove debug drop stuff.
Dec 10 2014, 4:05 PM
Turnstep committed rECHU3029d2014c4a: Tweak indexes..
Tweak indexes.
Dec 10 2014, 4:05 PM
Turnstep committed rECHU64cf8471edf9: Load alternate sql file when using Postgres. Make sure we check that blockStart….
Load alternate sql file when using Postgres. Make sure we check that blockStart…
Dec 10 2014, 4:05 PM
Turnstep committed rECHUd01d1e24bb00: Add indexes..
Add indexes.
Dec 10 2014, 4:04 PM
Turnstep committed rECHU3620946165e7: IPv6 xff should contain a "xff". Fix array offset..
IPv6 xff should contain a "xff". Fix array offset.
Dec 10 2014, 4:04 PM
Turnstep committed rECHU5841b73da227: Add Postgres support..
Add Postgres support.
Dec 10 2014, 4:04 PM
Turnstep committed rECAC702962b857ec.
Dec 10 2014, 3:59 PM
Turnstep committed rECACfc0423380512: Minor SQL changes..
Minor SQL changes.
Dec 10 2014, 3:59 PM
Turnstep committed rECAC4f625df8adb9: Minor tweaks, per Aaron.
Minor tweaks, per Aaron
Dec 10 2014, 3:59 PM
Turnstep committed rECAC7abe64d14a3d: Further clarifications..
Further clarifications.
Dec 10 2014, 3:59 PM
Turnstep committed rECAC54c365662d75: Add some newlines..
Add some newlines.
Dec 10 2014, 3:59 PM
Turnstep committed rECAC678b9fff161b: Use database timestamp() function for things passed directly to db..
Use database timestamp() function for things passed directly to db.
Dec 10 2014, 3:59 PM
Turnstep committed rECAC895a7cdb5f7d: Revert: gotta stop editing early in the morning..
Revert: gotta stop editing early in the morning.
Dec 10 2014, 3:59 PM
Turnstep committed rECAC57b6a95af2bc: Set default for acr_deleted, as code sometimes inserts a null..
Set default for acr_deleted, as code sometimes inserts a null.
Dec 10 2014, 3:59 PM
Turnstep committed rECAC3104a1921f0b: Pretty sure this was supposed to match the line below it..
Pretty sure this was supposed to match the line below it.
Dec 10 2014, 3:59 PM
Turnstep committed rECACe227a2601944: Wrong column name..
Wrong column name.
Dec 10 2014, 3:59 PM
Turnstep committed rECACdf93b8228802: Add primary key, fix errant commas.
Add primary key, fix errant commas
Dec 10 2014, 3:59 PM
Turnstep committed rECNOf5d66a6063f5: Use properly formatted timestamp versions when building list of notices..
Use properly formatted timestamp versions when building list of notices.
Dec 10 2014, 3:39 PM
Turnstep committed rECNOb88883b3f2ce: Use databases concept of a timestamp, not MW's.
Use databases concept of a timestamp, not MW's
Dec 10 2014, 3:39 PM
Turnstep committed rECNO61147b349d9a: Use the correct vars for not_start and not_end in the update..
Use the correct vars for not_start and not_end in the update.
Dec 10 2014, 3:39 PM
Turnstep committed rECNOfd1512ac65ff: Postgres version of the schema..
Postgres version of the schema.
Dec 10 2014, 3:39 PM
Turnstep committed rECNOe939c4031d04: Fix some minor space vs. tabs issues..
Fix some minor space vs. tabs issues.
Dec 10 2014, 3:39 PM
Turnstep committed rECTRafc4b79463ab: Change to more standard CASE WHEN THEN form..
Change to more standard CASE WHEN THEN form.
Dec 10 2014, 3:38 PM
Turnstep committed rEBCR947c17d740a4: Don't try to access array if it's empty..
Don't try to access array if it's empty.
Dec 10 2014, 3:36 PM
Turnstep committed rEANS3f4921e50897: Remove odd WHERE clause condition and standardize DB call, per bug 14989..
Remove odd WHERE clause condition and standardize DB call, per bug 14989.
Dec 10 2014, 3:38 AM
Turnstep committed rEABFdfd1bb443de1: No time to fix, but leave a note about odd behavior of this extension for….
No time to fix, but leave a note about odd behavior of this extension for…
Dec 10 2014, 2:14 AM
Turnstep committed rEABFef71cac5a9b5: Use the new sequence name.
Use the new sequence name
Dec 10 2014, 2:14 AM