Page MenuHomePhabricator

Umherirrender (Umherirrender)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 2:31 PM (492 w, 6 d)
Availability
Available
LDAP User
Umherirrender
MediaWiki User
Umherirrender [ Global Accounts ]

Recent Activity

Yesterday

Umherirrender committed rEREI5839499579a9: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Mon, Mar 18, 9:46 PM
Umherirrender moved T334615: Consolidate all Wikimedia CI tools into a single Wikimedia GitLab project group from Untriaged to Meta & Jenkins config on the MediaWiki-Codesniffer board.
Mon, Mar 18, 9:05 PM · MediaWiki-Platform-Team (Radar), Wikimedia-Hackathon-2023, MinusX, MediaWiki-Codesniffer, phan-taint-check-plugin, phan, Platform Team Initiatives (API Integration Tests), CSSJanus, Code-Health, GitLab (Project Migration), Wikimedia-GitHub
Umherirrender moved T355986: phpunit-coverage-php74-docker-publish failure in mediawiki/tools/codesniffer about TokenPolyfill from Untriaged to Meta & Jenkins config on the MediaWiki-Codesniffer board.
Mon, Mar 18, 9:04 PM · MediaWiki-Codesniffer, Continuous-Integration-Config, Test-Coverage
Umherirrender moved T356447: New upstream release for composer/semver from Untriaged to Meta & Jenkins config on the MediaWiki-Codesniffer board.
Mon, Mar 18, 9:04 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, Essential-Work, Content-Transform-Team-WIP, Parsoid, MediaWiki-Vendor, MediaWiki-General, MediaWiki-Codesniffer
Umherirrender closed T347440: SpaceBeforeClassBrace.BraceNotOnOwnLine handles anonymous classes incorrectly as Resolved.
Mon, Mar 18, 9:04 PM · MediaWiki-Codesniffer
Umherirrender committed rEVTEfa7f823995df: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Mon, Mar 18, 8:56 PM
Umherirrender added projects to T360361: Flaky Cite cypress tests in ve-cite/veCiteIntegration.cy.js: BlueSpice, MediaWiki-extensions-Other.

(It is possible this is a real issue with the extension, not sure how to find the different)

Mon, Mar 18, 7:34 PM · ci-test-error (WMF-deployed Build Failure), MediaWiki-extensions-Other, BlueSpice, Browser-Tests, Cite
Umherirrender added a comment to T358940: GerritBot comments for 7-digit Gerrit changes conflict with Diffusion commit hashes.

Phabricator adds backlinks on the change sets, which makes it harder to see a dependency between all these links get generated by random. A fix would be nice. Using the has to make it a number sounds good.

Mon, Mar 18, 7:27 PM · Phabricator, GerritBot
Umherirrender added a comment to T360026: Skip and then fix flapping reuseRefs tests.

Timeout does not help at all, seen on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalCssJs/+/1011716
https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/88828/console

Mon, Mar 18, 7:16 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), ci-test-error, WMDE-TechWish-Sprint-2024-03-13, Patch-For-Review, WMDE-TechWish-Sprint-2024-02-28, VisualEditor, WMDE-References-FocusArea, Cite
Umherirrender updated subscribers of T360361: Flaky Cite cypress tests in ve-cite/veCiteIntegration.cy.js.
Mon, Mar 18, 7:12 PM · ci-test-error (WMF-deployed Build Failure), MediaWiki-extensions-Other, BlueSpice, Browser-Tests, Cite
Umherirrender created T360361: Flaky Cite cypress tests in ve-cite/veCiteIntegration.cy.js.
Mon, Mar 18, 7:10 PM · ci-test-error (WMF-deployed Build Failure), MediaWiki-extensions-Other, BlueSpice, Browser-Tests, Cite
Izno awarded T326746: Add a dropdown for common undelete reasons on Special:Undelete a Like token.
Mon, Mar 18, 6:43 PM · User-notice, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Page-deletion
Umherirrender closed T360352: change to WatchedItemQueryServiceExtension signature type hint causes phan error for ORES as Resolved.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ORES/+/1011172/1 was prepared to fix the signature, but the other patch set does the same

Mon, Mar 18, 5:34 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Machine-Learning-Team, MediaWiki-extensions-ORES

Sat, Mar 16

Umherirrender moved T360250: phan-taint-check-plugin should do select wrapper special handling for IReadableDatabase interface from Backlog to MediaWiki mode on the phan-taint-check-plugin board.
Sat, Mar 16, 2:10 PM · phan-taint-check-plugin
Umherirrender moved T360251: Use namespaced HTMLForm class in phan-taint-check from Backlog to MediaWiki mode on the phan-taint-check-plugin board.
Sat, Mar 16, 2:10 PM · phan-taint-check-plugin
Umherirrender created T360251: Use namespaced HTMLForm class in phan-taint-check.
Sat, Mar 16, 2:09 PM · phan-taint-check-plugin
Umherirrender created T360250: phan-taint-check-plugin should do select wrapper special handling for IReadableDatabase interface.
Sat, Mar 16, 1:34 PM · phan-taint-check-plugin

Fri, Mar 15

Umherirrender closed T353305: API resetpassword should allow user and email use together as Resolved.
Fri, Mar 15, 11:12 PM · MW-1.41-notes, MW-1.39-notes, MW-1.40-notes, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Community-Tech, Password-Reset-Update, MediaWiki-Action-API, MediaWiki-User-login-and-signup

Wed, Mar 13

Umherirrender added a comment to T283198: Database deadlock in Wikibase\Lib\Store\Sql\Terms\Util\ReplicaMasterAwareRecordIdsAcquirer::insertNonExistingRecordsIntoMaster query.

As the data stored in the database are from parsing a page (via SecondaryDataUpdates), the fixes for T355877: [CLIENT] Investigate potential references to wrong ParserOutput in WikibaseClient code could be fix this as well.

Wed, Mar 13, 8:39 PM · [DEPRECATED] wdwb-tech, Wikidata, Wikimedia-production-error
Umherirrender added a comment to T359425: API:alllinks and API:alltransclusions query fails with RequestTimeout for several wikis.

At least the unique mode seems fixable

Wed, Mar 13, 8:06 PM · Patch-For-Review, MediaWiki-Action-API, Wikimedia-production-error, Wikimedia-Slow-DB-Query, WME-API-Usability
Umherirrender renamed T359425: API:alllinks and API:alltransclusions query fails with RequestTimeout for several wikis from API:alllinks query fails with RequestTimeout for several wikis to API:alllinks and API:alltransclusions query fails with RequestTimeout for several wikis.
Wed, Mar 13, 7:53 PM · Patch-For-Review, MediaWiki-Action-API, Wikimedia-production-error, Wikimedia-Slow-DB-Query, WME-API-Usability

Tue, Mar 12

Umherirrender closed T353469: MediaWiki\Title\MalformedTitleException: The requested page title contains invalid characters: "%20". as Resolved.
Tue, Mar 12, 10:48 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), User-brennen, ExternalGuidance, Wikimedia-production-error
Umherirrender committed rMLIP97b4f648b182: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Tue, Mar 12, 10:45 PM
Umherirrender committed rCSSS670d199d67b1: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Tue, Mar 12, 10:36 PM
Umherirrender committed rMLID7ff4da607dfc: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Tue, Mar 12, 10:29 PM
Umherirrender committed R1907:b8aa0a8fa7f5: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Tue, Mar 12, 10:21 PM
Umherirrender added a comment to T358911: LibUp has to allow the dealerdirect/phpcodesniffer-composer-installer plugin on codesniffer update.

I have upgraded codesniffer on wmf deployed extensions/skins and some libs where autofix changed something or manual fixes are needed. Even with libup these patch sets would need manual attention for review of the autofix.
For the remaining wmf-deployed repos only the bump in composer plus the allow-plugins-change is needed. It would be nice to get this by/leave this to libup as libup is allowed to self-submit these simple patch sets.

Tue, Mar 12, 10:05 PM · MediaWiki-Codesniffer, LibUp
Umherirrender committed rEHIE77d8046641a4: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Tue, Mar 12, 8:22 PM
Umherirrender committed rESCC9853c17b8d16: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Tue, Mar 12, 8:13 PM
Umherirrender committed rMSWAacd28fa850ff: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Tue, Mar 12, 8:08 PM
Umherirrender committed rEPHN0d6a0cfc803b: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Tue, Mar 12, 9:35 AM
Umherirrender committed rEISU94ecd78fb8a6: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Tue, Mar 12, 9:33 AM
Umherirrender committed rELGN0cf9669e85ea: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Tue, Mar 12, 9:11 AM
Umherirrender committed rEIWSc3587b0bf9ee: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Tue, Mar 12, 8:41 AM

Mon, Mar 11

Umherirrender closed T358325: Unsuppress Phan issues MediaWikiNoBaseException and MediaWikiNoEmptyIfDefined in Wikibase as Resolved.
Mon, Mar 11, 7:24 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Technical-Debt, wmde-wikidata-tech, Wikidata
Umherirrender committed rEWLC8fcc108ef109: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Mon, Mar 11, 12:18 AM
Umherirrender committed rESVUc2b9cf417af8: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Mon, Mar 11, 12:09 AM

Sun, Mar 10

Umherirrender added a comment to T334996: Add a sniff to verify that code is indented correctly depending on its scope's indentation.

Also false positives when inline php tags are used - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1009913/2..3/includes/installer/WebInstallerOutput.php and in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Collection/+/1009879 the autofix was looking strange for the inline php tags.

Sun, Mar 10, 11:16 PM · MediaWiki-Codesniffer
Umherirrender committed rEEPS049466efde21: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Sun, Mar 10, 11:05 PM
Umherirrender added a comment to T359765: fullurl: works incorrectly if the page name has a semi-colon.

Its there since 7e5472dea3e5b1ae020658be470efd5796494ac9, it is related to T28781: Leading asterisk, hash, colon or semicolon in parser function output incorrectly parsed as if beginning a line

Sun, Mar 10, 8:55 PM · MediaWiki-extensions-FlaggedRevs, MediaWiki-Parser
Umherirrender added a comment to T358956: Phpcs complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing.

The update to the latest codesniffer does not work on Translate extension with this error, not sure if that is related to the phpstorm comments here, because it fails with plain composer from command line.

> parallel-lint . --exclude vendor --exclude node_modules --no-progress
> phpcs -p -s --cache
Script phpcs -p -s --cache handling the phpcs event returned with error code 3
Script @phpcs was called via test
PHP 8.2.13 | 10 parallel jobs
Checked 519 files in 46.5 seconds
No syntax error found
ERROR: Referenced sniff "Universal.Constants.LowercaseClassResolutionKeyword" does not exist
Sun, Mar 10, 7:39 PM · Upstream, MediaWiki-Codesniffer
Umherirrender closed T195165: Translate extension is missing @covers tags as Resolved.

Should be fixed with cd3e80e969e8450e29a77586707277bc514d8a15

Sun, Mar 10, 7:09 PM · Technical-Debt, Test-Coverage, MediaWiki-extensions-Translate
Umherirrender added a comment to T334996: Add a sniff to verify that code is indented correctly depending on its scope's indentation.

There seems some false positives, but I have not checked if there are already tasks or fixes upstream:

		$rawResponse['createdPaymentOutput']
			['payment']
			['paymentOutput']
			['amountOfMoney'] = [
				'amount' => $donorTestData['amount'] * 100,
				'currencyCode' => $donorTestData['currency']
			];
Sun, Mar 10, 5:56 PM · MediaWiki-Codesniffer
Umherirrender committed rECHB1f26dce08323: build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0 (authored by Umherirrender).
build: Upgrade mediawiki/mediawiki-codesniffer to v43.0.0
Sun, Mar 10, 5:41 PM
Umherirrender closed T246630: Auto-fix misses to add a required newline to single-line if() as Resolved.

Squiz.ControlStructures.ControlSignature.NewlineAfterOpenBrace is now enabled to cover this case (d0b5fd3ff730e33a2d5ffd1fa3798a06a565695b)

Sun, Mar 10, 5:30 PM · Upstream, MediaWiki-Codesniffer
Umherirrender added a comment to T359765: fullurl: works incorrectly if the page name has a semi-colon.

The url is https://ru.wikipedia.org/w/index.php?title=%D0%9A%D0%B0%D1%82%D0%B5%D0%B3%D0%BE%D1%80%D0%B8%D1%8F:%D0%92%D0%B8%D0%BA%D0%B8%D0%BF%D0%B5%D0%B4%D0%B8%D1%8F:%D0%A1%D1%82%D0%B0%D1%82%D1%8C%D0%B8_%D0%B1%D0%B5%D0%B7_%D0%B8%D1%81%D1%82%D0%BE%D1%87%D0%BD%D0%B8%D0%BA%D0%BE%D0%B2_(%D1%82%D0%B8%D0%BF:_%D1%87%D0%B5%D0%BB%D0%BE%D0%B2%D0%B5%D0%BA%26&stableid=79331611#59;_%D1%80%D0%BE%D0%B4_%D0%B7%D0%B0%D0%BD%D1%8F%D1%82%D0%B8%D0%B9:_%D0%B1%D0%B8%D0%BE%D1%85%D0%B8%D0%BC%D0%B8%D0%BA)

Sun, Mar 10, 2:31 PM · MediaWiki-extensions-FlaggedRevs, MediaWiki-Parser

Fri, Mar 8

Umherirrender created T359665: Refactor Vector skin to remove use of RequestContext::getMain in service wiring code.
Fri, Mar 8, 7:27 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Web-Team-Backlog (FY2023-24 Q3 Sprint 5), Technical-Debt, Desktop Improvements (Vector 2022)

Thu, Mar 7

Umherirrender closed T326746: Add a dropdown for common undelete reasons on Special:Undelete as Resolved.

It is now possible to create MediaWiki:Undelete-comment-dropdown or MediaWiki:Undelete-comment-dropdown-unsuppress system messages on a wiki to use the new feature after the new version is active there - see roadmap https://www.mediawiki.org/wiki/MediaWiki_1.42/Roadmap for 1.42.0-wmf.22

Thu, Mar 7, 7:45 PM · User-notice, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Page-deletion
Umherirrender closed T357757: Auto-select reason per wpReasonList parameter value on Special:Movepage as Resolved.
Thu, Mar 7, 7:42 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Page-rename

Wed, Mar 6

Umherirrender updated subscribers of T359425: API:alllinks and API:alltransclusions query fails with RequestTimeout for several wikis.

Could be related to the pagelinks schema migration T351237: Set beta and production to read new for pagelinks migration / T352010: Gradually drop old pagelinks columns

Wed, Mar 6, 7:01 PM · Patch-For-Review, MediaWiki-Action-API, Wikimedia-production-error, Wikimedia-Slow-DB-Query, WME-API-Usability
Umherirrender edited projects for T359425: API:alllinks and API:alltransclusions query fails with RequestTimeout for several wikis, added: Wikimedia-Slow-DB-Query, Wikimedia-production-error, MediaWiki-Action-API; removed Infrastructure-Foundations, MediaWiki-libs-RequestTimeout.
Wed, Mar 6, 7:00 PM · Patch-For-Review, MediaWiki-Action-API, Wikimedia-production-error, Wikimedia-Slow-DB-Query, WME-API-Usability

Tue, Mar 5

Umherirrender added a comment to T301651: De-duplicate the action reason dropdown building code, which is copied around multiple times.

Special:Block is using a similiar reason dropdown via the HTMLSelectAndOtherField as part of a HTMLForm.

Tue, Mar 5, 11:29 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-User-Interface (actions), Technical-Debt, MediaWiki-Page-deletion
Umherirrender added a comment to T358934: Convert Special:Block Form UI to Codex.

T359012: Migrate Special:Block to CodexHTMLForm looks a bit like a duplicate. Maybe merge and add the subtasks under T359015: Implement Codex versions of HTMLFormFields needed for Special:Block?

Tue, Mar 5, 10:00 PM · Patch-For-Review, Story, Multiblocks, Community-Tech (CommTech-Kanban)

Mon, Mar 4

Umherirrender claimed T357757: Auto-select reason per wpReasonList parameter value on Special:Movepage.

action=delete is using fields from the HTMLForm class, while Special:MovePage builds the html form directly from OOUI widgets, that makes the technical different in the code. These widgets does not take url parameter in to account by default.

Mon, Mar 4, 11:10 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Page-rename
Umherirrender claimed T326746: Add a dropdown for common undelete reasons on Special:Undelete.
Mon, Mar 4, 9:45 PM · User-notice, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MediaWiki-Page-deletion
Umherirrender added a comment to T358961: Clarify use of OrExpressionGroup / AndExpressionGroup as both are not stable and constructor is internal to rdbms.

I can understand your comment for factorConds, for small lists it is not a big improvement in the final sql and it is a new function to know about, but it is a bit older as the expression system.

Mon, Mar 4, 8:27 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MediaWiki-libs-Rdbms
Umherirrender created T359099: MediaWikiNoEmptyIfDefined issue in Cite extension with parsoid class.
Mon, Mar 4, 7:33 PM · phan

Sun, Mar 3

Umherirrender added a comment to T358998: libup web view should mark library bundled in mediawiki/vendor as wmf deployed.

This feature request would covers mostly composer packages.
This could also or additional use foreign-resources.yaml from core and the extensions as a source for the repos used on wmf wikis to also include npm package.
Maybe that is a new task or could be done here as well.

Sun, Mar 3, 4:26 PM · LibUp
Umherirrender created T358998: libup web view should mark library bundled in mediawiki/vendor as wmf deployed.
Sun, Mar 3, 4:22 PM · LibUp
Umherirrender created T358997: libup web view should mark mediawiki/core as wmf deployed and bundled with tarball.
Sun, Mar 3, 4:22 PM · LibUp
Umherirrender removed a project from T268526: Use a dedicated mechanism to track page dependencies: Patch-For-Review.
Sun, Mar 3, 4:06 PM · Schema-change, MediaWiki-Page-derived-data, Epic, MediaWiki-Parser
Umherirrender closed T355952: "PHP Deprecated: Use of MediaWiki\Parser\ParserOutput::setTOCHTML was deprecated in MediaWiki 1.40" in PHPUnit tests as Resolved.
Sun, Mar 3, 4:06 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Content-Transform-Team-WIP, ci-test-error (WMF-deployed Build Failure), MediaWiki-Parser, MediaWiki-Core-Tests

Sat, Mar 2

Umherirrender created T358961: Clarify use of OrExpressionGroup / AndExpressionGroup as both are not stable and constructor is internal to rdbms.
Sat, Mar 2, 7:59 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MediaWiki-libs-Rdbms
Umherirrender added a comment to T358956: Phpcs complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing.

Parsoid was updated to codesniffer 43.0.0 with 51baccc8741108a9e3f763f2c19c6ce6eda55ac4

Sat, Mar 2, 6:56 PM · Upstream, MediaWiki-Codesniffer

Fri, Mar 1

Umherirrender closed T356352: Upgrading to codesniffer 43.0.0 in an MW extension gives composer plugin error as Invalid.

It is expected to allow the plugin in each composer.json. LibUp should be teached to do this while upgrading via T358911: LibUp has to allow the dealerdirect/phpcodesniffer-composer-installer plugin on codesniffer update

Fri, Mar 1, 9:27 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), ci-test-error (WMF-deployed Build Failure), MediaWiki-Codesniffer
Umherirrender created T358911: LibUp has to allow the dealerdirect/phpcodesniffer-composer-installer plugin on codesniffer update.
Fri, Mar 1, 9:26 PM · MediaWiki-Codesniffer, LibUp
Umherirrender created T358900: Jenkins 'test' pipeline is not running on rebase of patch set with CodeReview+2.
Fri, Mar 1, 6:51 PM · Continuous-Integration-Config
Umherirrender added a comment to T358830: Uploads fail due to 401 error from swift on wednesdays.

There are some information about the 401 status in T228292#7490101
There is also T206252: Spike of HTTP errors from SwiftFileBackend::doStoreInternal, which could be related, but other function

Fri, Mar 1, 5:42 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MediaWiki-Engineering, Commons, MediaWiki-File-management, SRE-swift-storage
Umherirrender committed rESVUe412b25c468b: build: Updating grunt-banana-checker to 0.11.1 (authored by Umherirrender).
build: Updating grunt-banana-checker to 0.11.1
Fri, Mar 1, 5:07 AM

Thu, Feb 29

Umherirrender committed rEVTEa162891c2101: build: Updating grunt-banana-checker to 0.11.1 (authored by Umherirrender).
build: Updating grunt-banana-checker to 0.11.1
Thu, Feb 29, 11:02 PM
Umherirrender closed T334655: Analyse if Equivset should use static array file instead of ".ser" file (serialised php text), a subtask of T212460: Adopt static array files for local disk storage of values (epic), as Resolved.
Thu, Feb 29, 10:33 PM · MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), Patch-For-Review, Wikimedia-Performance-publish, Epic, Performance-Team
Umherirrender closed T334655: Analyse if Equivset should use static array file instead of ".ser" file (serialised php text) as Resolved.
Thu, Feb 29, 10:33 PM · Performance Issue, MediaWiki-Platform-Team (Radar), Equivset
Umherirrender committed rEREI5728e7a99e1d: build: Updating grunt-banana-checker to 0.11.1 (authored by Umherirrender).
build: Updating grunt-banana-checker to 0.11.1
Thu, Feb 29, 10:26 PM
Umherirrender closed T290194: Some pages unavailable due to PostconditionException: makeTitleSafe() should always return a Title as Resolved.

Still fails after the patch is deployed. But it shows the error handling of mediawiki and not the white error page of Wikimedia. That means the skin building code now passed, but something other still calls function which fails.

Thu, Feb 29, 9:27 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MediaWiki-Engineering, API Platform, MediaWiki-General, Wikimedia-production-error
Umherirrender added a project to T358376: Error Message "TypeError: isMediaViewerEnabledOnClick is not a function" on various Wikipedia Pages: JavaScript.
Thu, Feb 29, 9:24 PM · Web-Team-Backlog, JavaScript, Wikimedia-production-error, MediaViewer
Umherirrender added a project to T299979: Error: cannot call methods on dialog prior to initialization; attempted to call method 'destroy': JavaScript.
Thu, Feb 29, 9:23 PM · JavaScript, MediaWiki-Recent-changes, Growth-Team, Wikimedia-production-error

Wed, Feb 28

Umherirrender added a comment to T358521: Add us_timestamp to the us_user index on table uploadstash.

This task is not about a prodution schema change, it seems I have clicked the wrong project Schema-change-in-production on phabricator and does not spot that before saving, to use Schema-change.

Wed, Feb 28, 8:37 PM · Schema-change, Data-Persistence (work done), MediaWiki-Uploading
Umherirrender committed rEWSD80695b927d37: tests: Add missing api help message (authored by Umherirrender).
tests: Add missing api help message
Wed, Feb 28, 8:11 PM
Umherirrender committed rEWSD26c67e8f5da7: tests: Add database group to RecordingAnnotationsMcrCrudTest (authored by Umherirrender).
tests: Add database group to RecordingAnnotationsMcrCrudTest
Wed, Feb 28, 8:07 PM
Umherirrender committed rEWSDafea1280badf: build: Suppress phan issue for backward code (authored by Umherirrender).
build: Suppress phan issue for backward code
Wed, Feb 28, 7:59 PM

Mon, Feb 26

Umherirrender closed T335629: Special:UploadStash timeout with large upload (slow query: SELECT FROM uploadstash) as Resolved.

The special pages now shows only a limited result and should not have timeouts as in this task.
If the page cannot be open with the default limit it is okay to set a ?limit=10 on the url to get less results, up to limit=1 and paginate through the result if needed.

Mon, Feb 26, 7:40 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Wikimedia-Slow-DB-Query, Unstewarded-production-error, Commons, MediaWiki-File-management, Wikimedia-production-error
Umherirrender created T358521: Add us_timestamp to the us_user index on table uploadstash.
Mon, Feb 26, 7:39 PM · Schema-change, Data-Persistence (work done), MediaWiki-Uploading

Sat, Feb 24

Umherirrender added a project to T358372: TypeError: Cannot read properties of null (reading 'nodeName'): JavaScript.
Sat, Feb 24, 9:32 PM · Verified, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), JavaScript, Web-Team-Backlog (FY2023-24 Q3 Sprint 4), Wikimedia-production-error
Umherirrender added a comment to T336504: Transcluding Special:Prefixindex can force the default skin.

The initalize of the OOUIHTMLForm triggers this, which also happen in the include modus of Special:PrefixIndex, b08b6a7785e5ff3f152fdaf8f7b7cc13023212b8 was a first try to fix this, but got reverted. Cross-linking T352592

Sat, Feb 24, 9:28 PM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Patch-For-Review, MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Beta-Cluster-reproducible, Growth-Team, GrowthExperiments, Wikimedia-production-error, Regression

Fri, Feb 23

Umherirrender added a comment to T298315: Deleting Ns:104 in it:voy.

Please run namespaceDupes.php on this wiki due to that config change to fix the pages.

Fri, Feb 23, 6:38 PM · Platform Engineering, User-Juan90264, Wikimedia-maintenance-script-run, Wikimedia-Site-requests
Umherirrender added a comment to T358338: PAGENAME returns - instead of - if title starts with a - (hyphen-minus).

That is the result of 3fc635dcb20add63d844dc6f313b41319d6dda30, which is in 1.42.0-wmf.16, not that long ago.

Fri, Feb 23, 5:12 PM · Content-Transform-Team-WIP, MediaWiki-Parser

Thu, Feb 22

Umherirrender committed rELGN7fdd24ac9b06: Use LogicException instead of Exception (authored by Umherirrender).
Use LogicException instead of Exception
Thu, Feb 22, 10:55 PM
Umherirrender claimed T358208: Wikimedia\Assert\PreconditionException: Expected MediaWiki\Block\AbstractBlock to belong to the local wiki, but it belongs to 'huwiki'.

3a1c95e9 is the trigger for this, but not the cause in code

Thu, Feb 22, 8:42 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, Trust and Safety Product Team, MediaWiki-Blocks, Wikimedia-production-error
Umherirrender added a comment to T358243: PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id.

Looks like the fixed tasks for wmf.19
T357700: PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id was deprecated in MediaWiki 1.42. [Called from FRInclusionCache::{closure}]
T357687: PHP Deprecated: Use of MediaWiki\Content\Renderer\ContentRenderer::getParserOutput with integer revision id was deprecated in MediaWiki 1.42. [Called from MediaWiki\Extension\TemplateSandbox\Hooks::onAlternateEditPreview]

Thu, Feb 22, 7:57 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Content-Transform-Team, TemplateStyles, MediaWiki-extensions-FlaggedRevs, MediaWiki-Core-Revision-backend, Wikimedia-production-error

Wed, Feb 21

Umherirrender updated subscribers of T358149: InvalidArgumentException: Invalid username: Https//www.cocororo.net/.

New code this week from 2f11c59344c33edadc3c2e2c135678a6df4557b2 / T343963

Wed, Feb 21, 9:10 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, Wikimedia-production-error
Umherirrender added a comment to T358076: Filters for account creation firing for non-existing logs.

The users showing on Special:Contributions the message "User account "..." is not registered.", also Special:ListUsers does not list them. No accocunt exists to have a newusers log for.

Wed, Feb 21, 8:46 PM · AbuseFilter

Tue, Feb 20

Umherirrender committed rEHIE7fab4cc094e1: modules: Resolve no-var eslint warning (authored by Umherirrender).
modules: Resolve no-var eslint warning
Tue, Feb 20, 11:38 PM
Umherirrender added a comment to T348803: Account consisting of spacelike characters (Hangul fillers) only.

The linked patch sets needs a new release of the equivset package, that could be happen in some months.

Tue, Feb 20, 9:46 PM · AntiSpoof, Equivset
Umherirrender added a comment to T356704: PageTriage CI broken (PHPUnit: There was 1 error: HooksTest::testOnPageUndelete: Container disabled).

Flow holds a reference to an older UserGroupManager, maybe the TalkpageManager already created in an previous test.

Tue, Feb 20, 9:27 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Moderator-Tools-Team (Kanban), Growth-Team, StructuredDiscussions, ci-test-error (WMF-deployed Build Failure), PageTriage

Mon, Feb 19

Umherirrender committed rESVU665a49730200: build: Updating mediawiki/mediawiki-phan-config to 0.14.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-phan-config to 0.14.0
Mon, Feb 19, 9:17 PM
Umherirrender committed rEREId55362484ce0: build: Updating mediawiki/mediawiki-phan-config to 0.14.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-phan-config to 0.14.0
Mon, Feb 19, 9:17 PM
Umherirrender committed rEHIE663f3eae72f6: build: Updating mediawiki/mediawiki-phan-config to 0.14.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-phan-config to 0.14.0
Mon, Feb 19, 9:13 PM

Sun, Feb 18

Umherirrender added a comment to T357855: Further extensions to ccnorm.

Antispoof detects different scripts, not sure if needs a mapping for A in that case. It seems AbuseFilter does not have this feature.

Sun, Feb 18, 7:53 PM · Equivset, AntiSpoof
Umherirrender added a comment to T357574: MediaWiki:antispoof-unassigned is unclear to users.

AntiSpoof has a feature to detect mixed script styles and avoid that user names are created with mixed scripts.
It has a list of known scripts and the range 2000–206F "General Punctuation" is not known and gives this messages.

Sun, Feb 18, 7:37 PM · AntiSpoof
Umherirrender committed rECHB4f7e9d7e806c: build: Remove explicit eslint depencency (authored by Umherirrender).
build: Remove explicit eslint depencency
Sun, Feb 18, 4:54 PM