Page MenuHomePhabricator

Umherirrender (Umherirrender)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 2:31 PM (409 w, 6 d)
Availability
Available
LDAP User
Umherirrender
MediaWiki User
Umherirrender [ Global Accounts ]

Recent Activity

Yesterday

Umherirrender added a comment to T315195: FORCE INDEX is placed incorrectly by the SQL Builder when also using a JOIN for MariaDB.

I have downloaded refs/changes/62/808262/29 and it works for me (on mariadb/mysql)

SELECT cuc_namespace,cuc_title,cuc_user,cuc_user_text,cuc_comment,cuc_actiontext,cuc_timestamp,cuc_minor,cuc_page_id,cuc_type,cuc_this_oldid,cuc_last_oldid,cuc_ip,cuc_xff,cuc_agent FROM `cu_changes` FORCE INDEX (cuc_ip_hex_time) JOIN `user` ON ((cuc_user=user_id)) WHERE cuc_ip_hex = 'v6-00000000000000000000000000000001' AND (cuc_user != 0) AND ((user_editcount < 500) OR (user_registration > '20220716210205')) ORDER BY cuc_timestamp DESC LIMIT 5001
Mon, Aug 15, 9:06 PM · Performance-Team, Wikimedia-Rdbms
Umherirrender added a project to T315177: Database error when attempting to create an abuse filter on cswiki: DBA.
MariaDB [cswiki_p]> select max(af_id) from abuse_filter;
+------------+
| max(af_id) |
+------------+
|        138 |
+------------+
1 row in set (0.002 sec)
Mon, Aug 15, 8:51 PM · DBA, Wikimedia-production-error, AbuseFilter
Umherirrender added a comment to T315195: FORCE INDEX is placed incorrectly by the SQL Builder when also using a JOIN for MariaDB.

That looks to be the same problem as here. I'll try that out and see if it works.

I'm not sure this addresses this task, unless I'm misunderstanding something, as it's not possible to use a FORCE INDEX on a JOIN condition. I say this because otherwise the SQL query validator would have said it was valid (as it doesn't know what tables a index corresponds to). As such there IMO needs to either be a more descriptive error (something that says you can't have a FORCE INDEX with a JOIN unless the index is attached to a table) or the SQL Builder needs to understand that by default the index goes before any joins.

Mon, Aug 15, 8:39 PM · Performance-Team, Wikimedia-Rdbms
Umherirrender added a comment to T315225: Defaults for integer columns in cu_changes need to be updated from strings.

Have found the corresponding bug for your "feature" request: T274618: Return actual integers when selecting integer fields from the DB

Mon, Aug 15, 8:25 PM · SQLite, CheckUser
Umherirrender added a comment to T315224: Triple equals comparison to RC_LOG et. al. on sqlite fails as sqlite returns a string..

Ah. Okay. Thanks for that information.

Mon, Aug 15, 8:22 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), SQLite, CheckUser
Umherirrender added a comment to T315225: Defaults for integer columns in cu_changes need to be updated from strings.

All returns from the database are strings. If the database does not convert a wrongly given default, that sounds like a bug there. Mysql has accept the default, because it can cast the string 0 to a numeric 0.

Mon, Aug 15, 8:19 PM · SQLite, CheckUser
Umherirrender added a comment to T315224: Triple equals comparison to RC_LOG et. al. on sqlite fails as sqlite returns a string..

The mediawiki database layer returns everything as string, even it is integer in the database.

Mon, Aug 15, 8:14 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), SQLite, CheckUser
Umherirrender added a comment to T315195: FORCE INDEX is placed incorrectly by the SQL Builder when also using a JOIN for MariaDB.

Sounds similiar to T253489#6163546, just say for which table the index is

Mon, Aug 15, 8:01 PM · Performance-Team, Wikimedia-Rdbms

Sat, Aug 13

Umherirrender added a comment to T315167: CI job mediawiki-quibble-composer-mysql-php80-docker on mediawiki/core gate-and-submit is flaky failing with Segmentation fault.

It now passed on the the patch https://gerrit.wikimedia.org/r/c/mediawiki/core/+/822708 from today
FAILURE: https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php80-docker/407/consoleFull
PASS: https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php80-docker/408/consoleFull

Sat, Aug 13, 8:13 PM · PHP 8.0 support, Continuous-Integration-Infrastructure, MediaWiki-Core-Tests, ci-test-error
Umherirrender added a comment to T315167: CI job mediawiki-quibble-composer-mysql-php80-docker on mediawiki/core gate-and-submit is flaky failing with Segmentation fault.

I have also seen the segfault on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/816261, but assumed it was for the changed tests, not flaky.

Sat, Aug 13, 7:59 PM · PHP 8.0 support, Continuous-Integration-Infrastructure, MediaWiki-Core-Tests, ci-test-error
Umherirrender added a comment to T300463: Make PHP 8.0 voting on MW master.

Mentioned in SAL (#wikimedia-releng) [2022-07-27T13:55:56Z] <James_F> Zuul: [mediawiki/core] Add a non-vendor php80 job for main branch T300463

Sat, Aug 13, 7:53 PM · PHP 8.0 support, Continuous-Integration-Config
Umherirrender created T315167: CI job mediawiki-quibble-composer-mysql-php80-docker on mediawiki/core gate-and-submit is flaky failing with Segmentation fault.
Sat, Aug 13, 7:50 PM · PHP 8.0 support, Continuous-Integration-Infrastructure, MediaWiki-Core-Tests, ci-test-error

Fri, Aug 12

Umherirrender committed rERNM05f9795e0cd8: Migrate deprecated $wgUser to IContextSource::getUser (authored by Umherirrender).
Migrate deprecated $wgUser to IContextSource::getUser
Fri, Aug 12, 7:35 PM
Umherirrender added a project to T314964: TypeError: itemsById[id]: JavaScript.
Fri, Aug 12, 7:11 PM · JavaScript, Growth-Team (Current Sprint), Wikimedia-production-error, StructuredDiscussions, Commons
Umherirrender committed rECDI88a7cb8415e3: Make $wgUser overwrite only for older versions (authored by Umherirrender).
Make $wgUser overwrite only for older versions
Fri, Aug 12, 7:05 PM

Tue, Aug 9

Umherirrender added a comment to T306636: UserOptionsManager: DBQueryError: Error 1213: Deadlock found when trying to get lock; try restarting transaction ([db])Function: MediaWiki\User\UserOptionsManager::saveOptionsInternalQuery.

The inserted options rcenhancedfilters-seen-tour and wlenhancedfilters-seen-tour are set in LocalUserCreated hook (from the WikimediaMessages extensions, but there are more extensions as well).

Tue, Aug 9, 10:09 PM · Data-Persistence (Consultation), Patch-For-Review, MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), PageTriage, User-brennen, MediaWiki-Core-Preferences, Wikimedia-production-error

Mon, Aug 8

Umherirrender added a project to T285217: TypeError: textblock.getHtml is not a function: JavaScript.
Mon, Aug 8, 8:35 PM · JavaScript, Wikimedia-production-error, CX-cxserver
Umherirrender added a subtask for T296083: Avoid using User::getOption: T314817: Refactor preprocessorFuzzTest.php user handling with PPFuzzUser.
Mon, Aug 8, 8:06 PM · MW-1.38-notes, MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Documentation, MediaWiki-extensions-General, MediaWiki-General, Patch-For-Review, Technical-Debt (Deprecation process), Platform Team Workboards (MW Expedition)
Umherirrender added a parent task for T314817: Refactor preprocessorFuzzTest.php user handling with PPFuzzUser: T296083: Avoid using User::getOption.
Mon, Aug 8, 8:06 PM · MediaWiki-Maintenance-system, MediaWiki-Parser
Umherirrender created T314817: Refactor preprocessorFuzzTest.php user handling with PPFuzzUser.
Mon, Aug 8, 8:06 PM · MediaWiki-Maintenance-system, MediaWiki-Parser
Umherirrender created T314816: Wikimedia\Rdbms\LBFactory/LoadBalancer gives wrong database connection on postgres when passing the current wiki id and $wgDBmwschema has default value.
Mon, Aug 8, 7:57 PM · Patch-For-Review, Performance-Team, PostgreSQL, Wikimedia-Rdbms
Umherirrender claimed T314779: patch-cleanup-push_subscription-foreign-keys-indexes: SQL syntax error (MySQL 5.7.24).

The best support for mysql is to remove the EXISTS check. It seems only exists on DROP TABLE, but not on other DDL statements

Mon, Aug 8, 5:48 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Growth-Team (Current Sprint), Data-Persistence (Consultation), Notifications

Sun, Aug 7

Umherirrender added a comment to T312605: Duplicate entry for key 'cx_translation_ref' in ContentTranslation\Translation::createQuery.
UNIQUE INDEX cx_translation_ref (
  translation_source_title, translation_source_language,
  translation_target_language, translation_started_by
),

The refered unique index contains a user id, so this could be a double-click or something which is trying to store the same thing twice over the api (ApiContentTranslationSave)

Sun, Aug 7, 7:25 PM · Language-Team (Language-2022-July-September), ContentTranslation, Wikimedia-production-error
Umherirrender merged task T314057: Wikimedia\Rdbms\DBTransactionSizeError: Transaction spent {time}s in writes, exceeding the 3s limit into T295054: Wikimedia\Rdbms\DBTransactionSizeError: Transaction spent 14.199902057648 second(s) in writes, exceeding the limit of 3.
Sun, Aug 7, 7:12 PM · Platform Engineering, Commons, Wikimedia-production-error
Umherirrender merged T314057: Wikimedia\Rdbms\DBTransactionSizeError: Transaction spent {time}s in writes, exceeding the 3s limit into T295054: Wikimedia\Rdbms\DBTransactionSizeError: Transaction spent 14.199902057648 second(s) in writes, exceeding the limit of 3.
Sun, Aug 7, 7:12 PM · Commons, Wikimedia-production-error
Umherirrender closed T284785: Calculating version for "ext.growthExperiments.Help" failed: Wikimedia\RequestTimeout\RequestTimeoutException: The maximum execution time of 60 seconds was exceeded in /srv/mediawiki/php-1.37.0-wmf.7/vendor/wikimedia/request-timeout/src/Detail/ExcimerTimerWrapper.php:59 as Resolved.

The log message cannot longer happen since https://gerrit.wikimedia.org/r/c/mediawiki/core/+/758592, because Timeouts are rethrown and not logged anymore

Sun, Aug 7, 6:42 PM · Growth-Team, Wikimedia-production-error
Umherirrender closed T302918: Linter: PHP Warning: in_array() expects parameter 2 to be array, null given as Resolved.
Sun, Aug 7, 6:33 PM · MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early), MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), MediaWiki-extensions-Linter, User-brennen, Wikimedia-production-error
Umherirrender merged task T282173: Possible uptick in "DBTransactionSizeError: Transaction spent [n] second(s) in writes, exceeding the limit of 3" into T295054: Wikimedia\Rdbms\DBTransactionSizeError: Transaction spent 14.199902057648 second(s) in writes, exceeding the limit of 3.
Sun, Aug 7, 6:19 PM · Platform Team Workboards (Clinic Duty Team), User-brennen, Wikimedia-production-error
Umherirrender merged T282173: Possible uptick in "DBTransactionSizeError: Transaction spent [n] second(s) in writes, exceeding the limit of 3" into T295054: Wikimedia\Rdbms\DBTransactionSizeError: Transaction spent 14.199902057648 second(s) in writes, exceeding the limit of 3.
Sun, Aug 7, 6:19 PM · Commons, Wikimedia-production-error
Umherirrender closed T294015: TypeError: Argument 1 passed to MediaWiki\Extensions\OAuth\Entity\UserEntity::newFromMWUser() must be an instance of User, boolean given, called in /srv/mediawiki/php-1.38.0-wmf.5/extensions/OAuth/src/Repository/ScopeRepository.php on line 79 as Resolved.
Sun, Aug 7, 6:17 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Platform Engineering, MediaWiki-extensions-OAuth, Wikimedia-production-error
Umherirrender committed rENUT09819fb02532: Replace deprecated User::getOption/$wgUser (authored by Umherirrender).
Replace deprecated User::getOption/$wgUser
Sun, Aug 7, 12:50 AM

Sat, Aug 6

Umherirrender added a project to T276699: Loading RC on en.wikipedia with a specific set of filters throws out an exception: Wikimedia-Slow-DB-Query.
Sat, Aug 6, 11:35 PM · Wikimedia-Slow-DB-Query, Growth-Team-Filtering, Performance Issue, Wikimedia-production-error, Growth-Team, MediaWiki-Recent-changes
Umherirrender merged T308765: UploadStashFileNotFoundException: La chiave "<filename>.gif" non è stata trovata nello stash into T204827: Special:Upload responds with UploadStashFileNotFoundException "Key .. not found in stash".
Sat, Aug 6, 11:28 PM · Structured-Data-Backlog, Structured Data Engineering, Multimedia, MediaWiki-Uploading, Wikimedia-production-error
Umherirrender merged task T308765: UploadStashFileNotFoundException: La chiave "<filename>.gif" non è stata trovata nello stash into T204827: Special:Upload responds with UploadStashFileNotFoundException "Key .. not found in stash".
Sat, Aug 6, 11:28 PM · Unstewarded-production-error, MediaWiki-Special-pages, Wikimedia-production-error
Umherirrender closed T314373: On examine of abuse filters the variable old_links contains duplicate protocol-relative URL as Resolved.
Sat, Aug 6, 10:59 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Performance-Team, DBA, AbuseFilter
Umherirrender committed rELSR12499da70b57: Migrate $wgUser/$wgLang to RequestContext::getMain() (authored by Umherirrender).
Migrate $wgUser/$wgLang to RequestContext::getMain()
Sat, Aug 6, 10:56 PM
Umherirrender added a comment to T243602: templatelinks table on Commons SQL database is not updating properly.

The backlog for that template is now processed after a fresh recursive link update has been started via api's action=purge

Sat, Aug 6, 3:20 PM · MediaWiki-Core-JobQueue, Contributors-Team, Commons
Umherirrender added a comment to T243602: templatelinks table on Commons SQL database is not updating properly.

The job queue is designed to do the reparses, because that does not fit into one only transaction, wikitext processing is expensive.

Sat, Aug 6, 1:02 PM · MediaWiki-Core-JobQueue, Contributors-Team, Commons
Umherirrender added a comment to T314666: Sqoop will fail on 2022-09-01 unless we fix templatelinks query.

Sounds like a sub task of T304979 or at least related

Sat, Aug 6, 12:09 AM · Data Pipelines, Patch-For-Review, Data Engineering Planning
Umherirrender closed T250654: Remove FORCE INDEX (tl_namespace) from an STRAIGHT_JOIN on an API query against templatelinks table as Declined.

The index get dropped with T314041

Sat, Aug 6, 12:06 AM · Platform Engineering (Icebox), MediaWiki-Action-API

Fri, Aug 5

Umherirrender edited projects for T204926: ApiQueryRevisions::run has bad performance across API hosts, added: Wikimedia-Slow-DB-Query; removed Wikimedia-database-issue.
Fri, Aug 5, 11:58 PM · Wikimedia-Slow-DB-Query, MediaWiki-Action-API
Umherirrender closed T243602: templatelinks table on Commons SQL database is not updating properly as Invalid.

The deletion of templatelinks is done via the job queue, because reparsing many pages takes some time. The counts are at 0 now.

Fri, Aug 5, 11:53 PM · MediaWiki-Core-JobQueue, Contributors-Team, Commons
Umherirrender added a project to T281223: MediaWiki\Revision\RevisionAccessException: Failed to load data blob from tt:9375723: Bad data in text row 9375723. Use findBadBlobs.php to remedy.. If this problem persist, use the findBadBlobs maintenance script to investigate the issue and mark bad blobs.: Wikimedia-database-issue (Bad data).
Fri, Aug 5, 11:43 PM · Wikimedia-database-issue (Bad data), MediaWiki-Core-Revision-backend, Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error
Umherirrender added a project to T299387: Bad revision in German Wikipedia: Wikimedia-database-issue (Bad data).
Fri, Aug 5, 11:42 PM · Wikimedia-database-issue (Bad data), Platform Engineering, MediaWiki-Core-Revision-backend, Wikimedia-production-error
Umherirrender added a project to T314672: RCFeed reports events with undocumented type "142": StructuredDiscussions.

Flow produce its own recent changes line and set the type RC_FLOW to 142, that is what you are seeing. As the core types are known there are mapped to the string values (via RecentChange::parseFromRCType), but flow is not known there.

Fri, Aug 5, 7:50 PM · Growth-Team (Current Sprint), StructuredDiscussions
Umherirrender committed rERGU4cc69dd76a70: Remove comment out code about $wgUser (authored by Umherirrender).
Remove comment out code about $wgUser
Fri, Aug 5, 7:29 PM

Thu, Aug 4

Umherirrender added a comment to T279585: Content serialization failed: Failed to decode as application/json (when parsing edit summary via API).

Hm, thanks. If I add contentmodel text/x-wiki, I get an internal error instead: https://www.wikidata.org/w/api.php?action=parse&format=json&summary=summary&prop=&contentformat=text%2Fx-wiki

{
    "error": {
        "code": "internal_api_error_InvalidArgumentException",
        "info": "[0009a4bd-06fa-48c2-a925-b7875275e3d3] Caught exception of type InvalidArgumentException",
        "errorclass": "InvalidArgumentException"
    },
    "servedby": "mw1346"
}

I guess that must be because of the missing text. If I add text as empty, then it works. (But there are also more warnings, because it’s still not a proper content parse request – except I’m not interested in parsing content in the first place, only the edit summary. But apparently something changed that makes parsing the summary alone more difficult?)

Anyways – if this is indeed exclusive to Wikidata (and Test Wikidata, I guess – do we have other wikis where the main namespace is not wikitext?), then this probably doesn’t need to block the train.

Thu, Aug 4, 10:59 PM · Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error, wdwb-tech, Wikidata, Regression, MediaWiki-Action-API
Umherirrender added a comment to T295054: Wikimedia\Rdbms\DBTransactionSizeError: Transaction spent 14.199902057648 second(s) in writes, exceeding the limit of 3.

Without further parameter on the request url it is hard to tell which api module is affected, but this is commons and long transactions on upload was improved with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/735762 (part of T283045)

Thu, Aug 4, 10:22 PM · Commons, Wikimedia-production-error
Umherirrender added a comment to T304528: PHP Deprecated: Deprecated cross-wiki access to MediaWiki\Revision\RevisionRecord. Expected: the local wiki, Actual: 'guwwiki'. Pass expected $wikiId. [Called from MediaWiki\Revision\RevisionRecord::getPageId].

addWiki.php is documented to get run on another wiki, while creating a new wiki and this is the addition of the main page to the new wiki (https://guw.wikipedia.org/w/index.php?oldid=1&uselang=en matched also this bug creation timestamp)

Thu, Aug 4, 10:16 PM · MediaWiki-extensions-WikimediaMaintenance, Wikimedia-production-error
Umherirrender closed T243526: Lingo needs uses of global $wgUser removed as Resolved.

Fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Lingo/+/700839

Thu, Aug 4, 6:24 PM · User-DannyS712, MediaWiki-extensions-Lingo, Technical-Debt
Umherirrender closed T243526: Lingo needs uses of global $wgUser removed, a subtask of T247793: Non-WMF deployed extensions need uses of global $wgUser removed [tracking], as Resolved.
Thu, Aug 4, 6:24 PM · Epic, MediaWiki-extensions-General, Technical-Debt, User-DannyS712
Umherirrender added a comment to T202411: The use of $wgUser and $wgTitle in UserBoard.php is scary.

$wgUser was already removed with T242679, $wgTitle and $wgOut still there

Thu, Aug 4, 5:36 PM · Technical-Debt, Social-Tools, SocialProfile
Umherirrender updated the task description for T159283: Deprecate non-configuration globals.
Thu, Aug 4, 4:07 PM · Platform Engineering Roadmap, Epic, MediaWiki-General, Technical-Debt
Umherirrender closed T160811: Deprecate and remove $wgParser, a subtask of T159283: Deprecate non-configuration globals, as Resolved.
Thu, Aug 4, 4:06 PM · Platform Engineering Roadmap, Epic, MediaWiki-General, Technical-Debt
Umherirrender closed T160811: Deprecate and remove $wgParser as Resolved.
Thu, Aug 4, 4:06 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), User-TheSandDoctor, Parsing-Team--ARCHIVED, MediaWiki-Parser, Technical-Debt (Deprecation process)

Wed, Aug 3

Umherirrender added a comment to T306636: UserOptionsManager: DBQueryError: Error 1213: Deadlock found when trying to get lock; try restarting transaction ([db])Function: MediaWiki\User\UserOptionsManager::saveOptionsInternalQuery.

There are also some unneeded deletion on the preferences, which could hold locks as well, see T301506

Wed, Aug 3, 12:58 PM · Data-Persistence (Consultation), Patch-For-Review, MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), PageTriage, User-brennen, MediaWiki-Core-Preferences, Wikimedia-production-error
Umherirrender removed a project from T314225: Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in WebRequest.php on line 541: Patch-For-Review.
Wed, Aug 3, 12:42 PM · MW-1.35-notes, MW-1.37-notes, MW-1.38-notes, MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), PHP 8.1 support, MediaWiki-Categories

Tue, Aug 2

Umherirrender updated the task description for T312972: Rename index su_normalized on table spoofuser on wmf wikis.
Tue, Aug 2, 5:02 PM · Schema-change-in-production, DBA
Umherirrender updated the task description for T161671: Compacting the revision table.
Tue, Aug 2, 4:58 PM · Platform Team Workboards (Epics), Platform Team Initiatives (Revision Storage Schema Improvements), MediaWiki-Core-Revision-backend, Multi-Content-Revisions, Epic, Patch-For-Review, Schema-change
Umherirrender closed T243985: Translate table `revtag` lacks a primary key, a subtask of T17441: Some tables lack unique or primary keys, may allow confusing duplicate data, as Resolved.
Tue, Aug 2, 11:38 AM · MediaWiki-General, Wikimedia-database-issue, PostgreSQL, DBA, Schema-change
Umherirrender closed T243985: Translate table `revtag` lacks a primary key as Resolved.
Tue, Aug 2, 11:38 AM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Technical-Debt, MediaWiki-extensions-Translate, User-DannyS712, Schema-change
Umherirrender created T314377: Add primary key and drop unique index on revtag on wmf wikis.
Tue, Aug 2, 11:38 AM · Schema-change-in-production, DBA
Umherirrender renamed T314141: Add primary key and drop unique index on translate_tmt on wmf wikis from Add primary key and drop unique index on translate_tmt wmf wikis to Add primary key and drop unique index on translate_tmt on wmf wikis.
Tue, Aug 2, 11:38 AM · Schema-change-in-production, DBA
Umherirrender added projects to T314373: On examine of abuse filters the variable old_links contains duplicate protocol-relative URL: DBA, Performance-Team.

@DBA, @Performance Team:

Tue, Aug 2, 11:32 AM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Performance-Team, DBA, AbuseFilter
Umherirrender created T314373: On examine of abuse filters the variable old_links contains duplicate protocol-relative URL.
Tue, Aug 2, 11:27 AM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Performance-Team, DBA, AbuseFilter

Mon, Aug 1

Umherirrender closed T314307: "Call to a member function numRows on string" error on Merge and Delete user as Resolved.
Mon, Aug 1, 7:16 PM · MediaWiki-extensions-UserMerge
Umherirrender added a comment to T314307: "Call to a member function numRows on string" error on Merge and Delete user.

I fixed that indirectly with a replacement in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UserMerge/+/759828 which is in 1.38

Mon, Aug 1, 7:03 PM · MediaWiki-extensions-UserMerge

Sun, Jul 31

Umherirrender added a comment to T188180: Read from and write to `actor` table in AbuseFilter.

$wgAbuseFilterNotifications = 'rc' or 'rcandudp' is broken as well and throws CannotCreateActorException (it's post send, not visible to the wiki), the proposal does not fix that part (because CheckUser would be called from RecentChanges for that configs)

Sun, Jul 31, 1:53 PM · AbuseFilter (Overhaul-2020), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Schema-change

Sat, Jul 30

Umherirrender merged T314224: Contributions page of new editors appearing on the User Creation Log are automatically blue-linked, even though they haven’t edited anything yet. into T314216: Links with .mw-usertoollinks-contribs-no-edits are not red in Minerva on mobile platform.
Sat, Jul 30, 9:21 PM · Regression, MobileFrontend, MinervaNeue
Umherirrender merged task T314224: Contributions page of new editors appearing on the User Creation Log are automatically blue-linked, even though they haven’t edited anything yet. into T314216: Links with .mw-usertoollinks-contribs-no-edits are not red in Minerva on mobile platform.
Sat, Jul 30, 9:21 PM

Fri, Jul 29

Umherirrender closed T191694: AbuseFilter list not sorted correctly when ordered by Status as Resolved.
Fri, Jul 29, 5:11 PM · MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), AbuseFilter (Overhaul-2020), MW-1.35-notes (1.35.0-wmf.8; 2019-11-26)
Umherirrender added a comment to T313251: Collect and fix schema drifts of wmf-deployed extension tables in production.

First collection with the abstract schema file names (as of now) and some dblist entries

Fri, Jul 29, 5:08 PM · Epic, Data-Persistence
Umherirrender closed T312260: Convert Unique Index to Primary Key on table translate_tmt as Resolved.
Fri, Jul 29, 12:45 PM · MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), MediaWiki-extensions-Translate, Schema-change
Umherirrender closed T312258: Convert Unique Index to Primary Key on table translate_messageindex as Resolved.
Fri, Jul 29, 12:45 PM · MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), MediaWiki-extensions-Translate, Schema-change
Umherirrender triaged T314141: Add primary key and drop unique index on translate_tmt on wmf wikis as Lowest priority.
Fri, Jul 29, 12:44 PM · Schema-change-in-production, DBA
Umherirrender triaged T314140: Add primary key and drop unique index on translate_messageindex on wmf wikis as Lowest priority.
Fri, Jul 29, 12:44 PM · Schema-change-in-production, DBA
Umherirrender created T314141: Add primary key and drop unique index on translate_tmt on wmf wikis.
Fri, Jul 29, 12:44 PM · Schema-change-in-production, DBA
Umherirrender created T314140: Add primary key and drop unique index on translate_messageindex on wmf wikis.
Fri, Jul 29, 12:44 PM · Schema-change-in-production, DBA
Umherirrender updated the task description for T314138: generateSchemaChangeSql.php should provide atomic DDL when changing UNIQUE INDEX to PRIMARY KEY.
Fri, Jul 29, 12:32 PM · MediaWiki-Installer, Platform Team Initiatives (Abstract Schema)
Umherirrender added a comment to T314087: Add primary key and drop unique index on cx_translators on wmf wikis.

We can just do it in the same transaction: alter table cx_translators drop key cx_translation_translators, add PRIMARY KEY ( translator_user_id, translator_translation_id );

Fri, Jul 29, 12:29 PM · Schema-change-in-production, DBA
Umherirrender created T314138: generateSchemaChangeSql.php should provide atomic DDL when changing UNIQUE INDEX to PRIMARY KEY.
Fri, Jul 29, 12:28 PM · MediaWiki-Installer, Platform Team Initiatives (Abstract Schema)
Umherirrender added a comment to T231973: Implement recognition of persian integers in int function.

The equivset is to handle "Visually similar characters". The persian digits are semantical identical and mediawiki already supports that with $digitTransformTable in the language file.

Fri, Jul 29, 3:54 AM · Patch-For-Review, Equivset
Umherirrender added a comment to T164180: Equivset should normalize some diacriticals.

There is already another mapping for that character

Fri, Jul 29, 2:54 AM · Patch-For-Review, Equivset
Umherirrender added a comment to T65217: Augment our AntiSpoof normalization data with Unicode/CLDR data.

I think mass importing Unicode's confusables is the best option @kaldari

Fri, Jul 29, 2:54 AM · Equivset, I18n, AntiSpoof

Thu, Jul 28

Umherirrender added a project to T20447: AntiSpoof confused by users differing only in capitalisation (mysql case-insensitivity): Schema-change.

The database field spoofuser.su_name should be made binary to be equal to the field user.user_name and behaviour correctly when the database collation not defaults to binary

Thu, Jul 28, 11:15 PM · Schema-change, AntiSpoof
Umherirrender closed T208268: New AbuseFilterCentralDb class to fix using the wrong credentials for external databases. as Resolved.

Handled by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/634652

Thu, Jul 28, 10:30 PM · AbuseFilter
Umherirrender closed T268156: Partial blocks from namespaces are displayed odd as Resolved.

Just as note to avoid confusing: The fix only applied to new log entries after the deployment, because the changed code is used on store into check user, not on read of the stored data

Thu, Jul 28, 9:52 PM · MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Anti-Harassment, User-DannyS712, CheckUser, MediaWiki-Blocks
Umherirrender added a comment to T313893: Backport "Deprecated" fix for getEffectiveGroups to REL1_37.

A deprecation notice should not break your wiki, the message may be shown and it looks broken.

Thu, Jul 28, 9:09 PM · MediaWiki-extensions-EditAccount
Umherirrender added a project to T311308: DBTransactionSizeError: Transaction spent {time}s in writes, exceeding the 3s limit: MediaWiki-extensions-GlobalPreferences.
Thu, Jul 28, 9:03 PM · Platform Engineering, MediaWiki-Core-Preferences
Umherirrender added a comment to T311308: DBTransactionSizeError: Transaction spent {time}s in writes, exceeding the 3s limit.

I'm thinking maybe this is a kind of edit conflict, my script changes two different preferences at practically the same time. I wouldn't expect an issue since it's not the same preference, but maybe it's an issue anyway.

Thu, Jul 28, 9:01 PM · Platform Engineering, MediaWiki-Core-Preferences
Umherirrender added a project to T314065: MalformedTitleException: The requested page title contains invalid characters: "}".: Move-Files-To-Commons.
Thu, Jul 28, 8:28 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2022-07-20, WMDE-TechWish-Maintenance, Move-Files-To-Commons, Commons, Wikimedia-production-error
Umherirrender added a comment to T314077: Gendered aliases for non-user NS.

There is a setting named for that: https://www.mediawiki.org/wiki/Manual:$wgExtraGenderNamespaces

Thu, Jul 28, 8:14 PM · MediaWiki-General
Umherirrender triaged T312280: Convert Unique Index to Primary Key on table securepoll_properties as Lowest priority.
Thu, Jul 28, 8:00 PM · Patch-For-Review, MediaWiki-extensions-SecurePoll, Schema-change
Umherirrender triaged T312277: Convert Unique Index to Primary Key on table revsrc as Lowest priority.
Thu, Jul 28, 8:00 PM · Patch-For-Review, MediaWiki-extensions-CreditsSource, Schema-change
Umherirrender triaged T312276: Convert Unique Index to Primary Key on table swsource_links as Lowest priority.
Thu, Jul 28, 8:00 PM · Patch-For-Review, MediaWiki-extensions-CreditsSource, Schema-change
Umherirrender triaged T312275: Convert Unique Index to Primary Key on table swauthor_links as Lowest priority.
Thu, Jul 28, 8:00 PM · Patch-For-Review, MediaWiki-extensions-CreditsSource, Schema-change
Umherirrender triaged T312274: Convert Unique Index to Primary Key on table cn_notice_regions as Lowest priority.
Thu, Jul 28, 8:00 PM · Patch-For-Review, MediaWiki-extensions-CentralNotice, Schema-change
Umherirrender triaged T312273: Convert Unique Index to Primary Key on table cn_notice_countries as Lowest priority.
Thu, Jul 28, 8:00 PM · Patch-For-Review, MediaWiki-extensions-CentralNotice, Schema-change
Umherirrender triaged T312272: Convert Unique Index to Primary Key on table cn_notice_projects as Lowest priority.
Thu, Jul 28, 8:00 PM · Patch-For-Review, MediaWiki-extensions-CentralNotice, Schema-change
Umherirrender triaged T312270: Convert Unique Index to Primary Key on table cn_notice_languages as Lowest priority.
Thu, Jul 28, 8:00 PM · Patch-For-Review, MediaWiki-extensions-CentralNotice, Schema-change