Page MenuHomePhabricator

Umherirrender (Umherirrender)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 2:31 PM (280 w, 5 d)
Availability
Available
LDAP User
Umherirrender
MediaWiki User
Umherirrender [ Global Accounts ]

Recent Activity

Today

Umherirrender added a comment to T102581: Create a separate list of suppression-only reasons for Special:RevisionDelete.

@Umherirrender, et al.: this is much appreciated, but as-yet incomplete. AFAICT, the dropdown for AbuseFilter entries still only draws from MediaWiki:Revdelete-reason-dropdown and doesn't account for the new page. I can open a new task if you like, but since AF logs can only be suppressed, not revision-deleted, that means the new page can't really be used.
It would seem reasonable to me for the AF dropdown to only pull from this new page, but in practice it should probably take both as well.

Sun, Feb 23, 8:41 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), good first task, MediaWiki-Revision-deletion

Yesterday

Umherirrender closed T243721: Autofix of sniff MediaWiki.Commenting.DocComment fails / produce invalid file as Resolved.
Sat, Feb 22, 3:17 PM · MediaWiki-Codesniffer
Umherirrender committed rMTPS7d77d1467b9e: Update PHPUnit to 8.5 (authored by Umherirrender).
Update PHPUnit to 8.5
Sat, Feb 22, 2:22 PM
Umherirrender closed T244633: Constant inheritance not detected in phan, blocking merge of a patch as Resolved.
Sat, Feb 22, 9:39 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Upstream, phan, Performance-Team, Release-Engineering-Team (CI & Testing services)

Fri, Feb 21

Umherirrender closed T244157: Special:BlockList paginates on a non-unique column as Resolved.
Fri, Feb 21, 7:51 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Anti-Harassment (The Letter Song)
Umherirrender added a comment to T244157: Special:BlockList paginates on a non-unique column.

@dmaza It's explained in T244157#5892494

I don't understand. Why do we care about timestamp when ipb_id is unique and auto-increment?

Fri, Feb 21, 7:47 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Anti-Harassment (The Letter Song)
Umherirrender added a comment to T245234: Add ar_del_time (timestamp of page deletion).

Timestamps are often not the right choose when it is possible to have duplicates of it for different actions from different users (Yes, it is possible to have two edits of one page in the same second, so it could be possible to have two deletion of different revisions in the same second, maybe not very likly to get, but possible).

Fri, Feb 21, 7:34 PM · Patch-For-Review, MediaWiki-Page-deletion
Umherirrender added a comment to T245364: Encourage void for non-abortable MW hook functions.

Maybe phan can do the work better (In my opinion phan can do things with many files involved or dependenies between files, codesniffer is better when only check one file)

Fri, Feb 21, 7:25 PM · MediaWiki-Codesniffer

Thu, Feb 20

Umherirrender committed rEOALc18c36bbf7e0: build: Remove unneeded .jscsrc (authored by Umherirrender).
build: Remove unneeded .jscsrc
Thu, Feb 20, 6:37 PM
Umherirrender committed R1893:fb5219fd5bcf: build: Updating composer dependencies (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating composer dependencies
Thu, Feb 20, 5:50 PM

Wed, Feb 19

Umherirrender committed rSEXAMPLEfdec70cfdb5c: build: Updating composer dependencies (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating composer dependencies
Wed, Feb 19, 11:11 PM
Umherirrender committed rSEXAfdec70cfdb5c: build: Updating composer dependencies (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating composer dependencies
Wed, Feb 19, 11:11 PM
Umherirrender committed rEFLI19be34b1bf1a: build: Updating composer dependencies (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating composer dependencies
Wed, Feb 19, 9:36 PM
Umherirrender added a comment to T214332: Enable Squiz.ControlStructures.ForLoopDeclaration/ForEachLoopDeclaration sniff.

https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.5.4 contains one fix:

Squiz.ControlStructures.ForLoopDeclaration now has a setting to ignore newline characters

  • Default remains FALSE, so newlines are not allowed within for definitions
  • Override the ignoreNewlines setting in a ruleset.xml file to change
Wed, Feb 19, 9:08 PM · Upstream, MediaWiki-Codesniffer
Umherirrender committed rEWLC505f8d19010f: build: Updating composer dependencies (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating composer dependencies
Wed, Feb 19, 8:29 PM
Umherirrender committed rEMMA71b33bf55fd8: Enable MediaWiki.Usage.IsNull.IsNull and make pass (authored by Umherirrender).
Enable MediaWiki.Usage.IsNull.IsNull and make pass
Wed, Feb 19, 2:10 AM
Umherirrender committed rMLZEdf3e198b1c7e: build: Updating composer dependencies (authored by Umherirrender).
build: Updating composer dependencies
Wed, Feb 19, 1:30 AM

Tue, Feb 18

Umherirrender committed rEMMAf1bcf10f1738: Enable MediaWiki.Usage.ForbiddenFunctions.isset and make pass (authored by Umherirrender).
Enable MediaWiki.Usage.ForbiddenFunctions.isset and make pass
Tue, Feb 18, 9:22 PM

Mon, Feb 17

Amorymeltzer awarded T102581: Create a separate list of suppression-only reasons for Special:RevisionDelete a Grey Medal token.
Mon, Feb 17, 11:08 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), good first task, MediaWiki-Revision-deletion

Tue, Feb 11

Umherirrender committed rSCBLd3b55d164a3f: build: Updating composer dependencies (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating composer dependencies
Tue, Feb 11, 7:42 PM
Umherirrender added a comment to T232265: Add sniff to ensure use of spaces (not tabs) between variable and assignment operator.

Another test case - https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Auth_remoteuser/+/571076/5..6/src/AuthRemoteuserSessionProvider.php

Tue, Feb 11, 7:35 PM · Upstream, MediaWiki-Codesniffer

Sat, Feb 8

Umherirrender added a comment to T242780: Small improve on autofix of MediaWiki.Usage.IsNullSniff possible to avoid unneeded parenthesis.

It seems the following code does not take function call in account

Sat, Feb 8, 8:56 PM · MediaWiki-Codesniffer
Umherirrender claimed T243721: Autofix of sniff MediaWiki.Commenting.DocComment fails / produce invalid file.
Sat, Feb 8, 8:52 PM · MediaWiki-Codesniffer
Umherirrender closed T242787: MediaWiki CodeSniffer destroys @param lines when the text contains an & as Resolved.
Sat, Feb 8, 8:52 PM · MediaWiki-Codesniffer
Umherirrender added a comment to T244602: Linker::userToolLinks uses $wgUser.

You could also bring it to the LinkRenderer service as it holds some other Linker class function.
But that maybe include more technical debt, because this function needs the permission manager, the current function of LinkRenderer does not

Sat, Feb 8, 7:14 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), User-DannyS712, MediaWiki-General, Technical-Debt

Fri, Feb 7

Umherirrender committed rENBVd0fb882b1347: build: Update symfony/process to ^5 (authored by Umherirrender).
build: Update symfony/process to ^5
Fri, Feb 7, 9:04 PM

Thu, Feb 6

Umherirrender added a comment to T240141: Phan should handle always-throw-function like ApiBase::dieWithError better.

Have found in phan's BlockExitStatusChecker.php:

Thu, Feb 6, 8:14 PM · Upstream, phan
Umherirrender added a comment to T244471: dewiki: Wikimedia\Assert\ParameterAssertionException; page histories and diffs inaccessible; actor table seems affected.

A similar issue is tracked with T232451 where also a invalid user name is a problem

Thu, Feb 6, 6:22 PM · Wikimedia-production-error, MediaWiki-User-management, MediaWiki-Page-History, MediaWiki-Page-Diffs

Wed, Feb 5

Umherirrender committed rCSSS8d981309d127: build: Updating composer dependencies (authored by Umherirrender).
build: Updating composer dependencies
Wed, Feb 5, 8:59 PM
Umherirrender committed rECACe03e146ecf36: build: Replace jscs, jshint and jsonlint by eslint (authored by Umherirrender).
build: Replace jscs, jshint and jsonlint by eslint
Wed, Feb 5, 6:44 PM

Tue, Feb 4

Umherirrender updated the task description for T210365: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable).
Tue, Feb 4, 8:40 PM · good first task, Patch-For-Review, Google-Code-in-2019, MediaWiki-extensions-General, Google-Code-in-2018
Umherirrender created T244269: New release of ockcyp/covers-validator for symfony/console v5 needed to update minusX.
Tue, Feb 4, 6:18 PM · Patch-For-Review, Upstream, Composer, LibUp

Mon, Feb 3

Umherirrender committed rLLUP61f3e0e71b8b: Do not assume Gruntfile.js exists everywhere (authored by Umherirrender).
Do not assume Gruntfile.js exists everywhere
Mon, Feb 3, 11:44 PM
Umherirrender committed rEMMS187a951b6e92: build: Replace jscs, jshint and jsonlint by eslint (authored by Umherirrender).
build: Replace jscs, jshint and jsonlint by eslint
Mon, Feb 3, 9:30 PM
Umherirrender committed rELNT45967780d272: build: Replace jscs, jshint and jsonlint by eslint (authored by Umherirrender).
build: Replace jscs, jshint and jsonlint by eslint
Mon, Feb 3, 9:28 PM
Umherirrender committed rENSI4e0ef96ae2ff: build: Replace jscs, jshint and jsonlint by eslint (authored by Umherirrender).
build: Replace jscs, jshint and jsonlint by eslint
Mon, Feb 3, 9:10 PM
Umherirrender committed rECNS3b8629ad9b56: build: Replace jscs, jshint and jsonlint by eslint (authored by Umherirrender).
build: Replace jscs, jshint and jsonlint by eslint
Mon, Feb 3, 9:06 PM
Umherirrender committed rEIVSc882f6f9f934: build: Replace jscs, jshint and jsonlint by eslint (authored by Umherirrender).
build: Replace jscs, jshint and jsonlint by eslint
Mon, Feb 3, 9:04 PM
Umherirrender updated the task description for T210365: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable).
Mon, Feb 3, 8:57 PM · good first task, Patch-For-Review, Google-Code-in-2019, MediaWiki-extensions-General, Google-Code-in-2018
Umherirrender updated the task description for T195542: Convert all Wikimedia-deployed extensions and skins to lint JavaScript via eslint, not jshint/jscs.
Mon, Feb 3, 8:36 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Google-Code-in-2019, Technical-Debt, JavaScript
Umherirrender added a project to T244163: Usernames suppressed from all edits and log entries are visible in "Performer" search list in Special:Log: MediaWiki-Revision-deletion.

It seems the user name is not suppressed. Suppression logs and suppression a user are different actions

Mon, Feb 3, 8:16 PM · MediaWiki-Revision-deletion
Umherirrender updated the task description for T210365: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable).
Mon, Feb 3, 8:11 PM · good first task, Patch-For-Review, Google-Code-in-2019, MediaWiki-extensions-General, Google-Code-in-2018

Sun, Feb 2

Umherirrender updated the task description for T210365: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable).
Sun, Feb 2, 6:28 PM · good first task, Patch-For-Review, Google-Code-in-2019, MediaWiki-extensions-General, Google-Code-in-2018

Sat, Feb 1

Umherirrender updated the task description for T195542: Convert all Wikimedia-deployed extensions and skins to lint JavaScript via eslint, not jshint/jscs.
Sat, Feb 1, 10:04 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Google-Code-in-2019, Technical-Debt, JavaScript
Umherirrender updated the task description for T210365: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable).
Sat, Feb 1, 10:02 AM · good first task, Patch-For-Review, Google-Code-in-2019, MediaWiki-extensions-General, Google-Code-in-2018

Thu, Jan 30

Umherirrender added projects to T243964: Special:Diff localization does not work on trwiki: translatewiki.net, I18n.

The export of aliases from translatewiki.net has stopped some ages ago.

Thu, Jan 30, 7:24 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), User-Urbanecm, I18n, MediaWiki-Special-pages
Umherirrender committed rEOLY00c961c43754: build: Replace jscs, jshint and jsonlint by eslint (authored by Umherirrender).
build: Replace jscs, jshint and jsonlint by eslint
Thu, Jan 30, 6:22 PM
Umherirrender committed rEEUS67f3bc830012: build: Replace jscs, jshint and jsonlint by eslint (authored by Umherirrender).
build: Replace jscs, jshint and jsonlint by eslint
Thu, Jan 30, 6:21 PM

Wed, Jan 29

Umherirrender closed T118084: Fix jscs error as Invalid.

mediawiki/core is using eslint now

Wed, Jan 29, 9:03 PM · MediaWiki-General
Umherirrender updated the task description for T225325: LibraryUpgrader CI normalisation tasks, June/July 2019.
Wed, Jan 29, 9:01 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, LibUp, Continuous-Integration-Config
Umherirrender updated the task description for T210365: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable).
Wed, Jan 29, 8:53 PM · good first task, Patch-For-Review, Google-Code-in-2019, MediaWiki-extensions-General, Google-Code-in-2018
Umherirrender committed rECAC7d25ff700c41: fixed grammar error (authored by Apap04).
fixed grammar error
Wed, Jan 29, 7:01 PM
Umherirrender updated subscribers of T243599: special pages has not been updated since November 2019 in jawiki and several other projects.

from [mwmaint1002:/var/log/mediawiki/updateSpecialPages/s6@16-AncientPages.log] $

  1 -------------------------------------
  2 #
  3 -------------------------------------
  4 no version entry for `#`.
  5 Fatal error: no version entry for `#`.
  6  in /srv/mediawiki/multiversion/MWMultiVersion.php on line 423
~              
And this Fatal error shows up in all the other shards as well for the same crons.
Wed, Jan 29, 6:30 PM · serviceops-radar, Operations, Wikimedia-maintenance-script-run
Umherirrender added a comment to T243652: Calls to LogPage::addEntry should pass a user.

Noted. Perhaps it should officially be deprecated? Its currently not even soft deprecated.

That would certainly make sense. I do want to note that for things like SocialProfile, the reason why it's still using the old class instead of the newer class is that I'm not sure how to properly migrate old log entries over. Migrating the code to use the newer classes would also help improve the i18n as well as overall aesthetic appearance of the relevant log entries (see, for example, the user profile edit log on Brickipedia to see how the entries currently display).

Wed, Jan 29, 6:16 PM · MediaWiki-extensions-CloseWikis, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), MediaWiki-extensions-LiquidThreads, MediaWiki-extensions-Interwiki, MediaWiki-extensions-Other, MediaWiki-extensions-Cargo, MediaWiki-extensions-BlockAndNuke, MediaWiki-extensions-AutoProxyBlock, MediaWiki-extensions-Approved-Revs, GlobalBlocking, SocialProfile, MediaWiki-extensions-CentralAuth, Social-Tools, User-DannyS712, MediaWiki-General, Technical-Debt
Umherirrender updated subscribers of T243862: Why libup does not run update of jakub-onderka/php-console-highlighter and mediawiki/minus-x as bundle?.
Wed, Jan 29, 6:06 PM · LibUp
Umherirrender added a comment to T243862: Why libup does not run update of jakub-onderka/php-console-highlighter and mediawiki/minus-x as bundle?.

Thanks for the explaination, I am happy to see that it now uploads one patch set for both upgrading.

Wed, Jan 29, 6:06 PM · LibUp

Tue, Jan 28

Umherirrender added a comment to T243652: Calls to LogPage::addEntry should pass a user.

I just want noted that LogPage::addEntry is an old way to provide log entries on Special:Log.
The new way is direct use of LogFormatter class.
In my opinion there must be no complex actions to avoid global state in that class.
It would be more future proofed (but sometimes more complex) to migrate the extension to the new logging
But when the caller already have a context, than it is okay to avoid the fallback to $wgUser. That are simpel patch sets.

Tue, Jan 28, 9:43 PM · MediaWiki-extensions-CloseWikis, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), MediaWiki-extensions-LiquidThreads, MediaWiki-extensions-Interwiki, MediaWiki-extensions-Other, MediaWiki-extensions-Cargo, MediaWiki-extensions-BlockAndNuke, MediaWiki-extensions-AutoProxyBlock, MediaWiki-extensions-Approved-Revs, GlobalBlocking, SocialProfile, MediaWiki-extensions-CentralAuth, Social-Tools, User-DannyS712, MediaWiki-General, Technical-Debt
Umherirrender created T243862: Why libup does not run update of jakub-onderka/php-console-highlighter and mediawiki/minus-x as bundle?.
Tue, Jan 28, 9:33 PM · LibUp
Umherirrender added a comment to T243599: special pages has not been updated since November 2019 in jawiki and several other projects.

In puppet is mediawiki::maintenance::updatequerypages::ancientpages which is running the update with the override option to get the special page updated.

Tue, Jan 28, 8:30 PM · serviceops-radar, Operations, Wikimedia-maintenance-script-run
Umherirrender created T243861: Unit tests of FanBoxes extension failing on updater related to SocialProfile/SystemGifts.
Tue, Jan 28, 8:09 PM · Patch-For-Review, MediaWiki-Installer, ci-test-error, Social-Tools, SocialProfile, FanBoxes
Umherirrender created T243859: Qunit tests of DebugMode extension failing on invalid json.
Tue, Jan 28, 8:02 PM · ci-test-error, MediaWiki-extensions-Other
Umherirrender added a comment to T242913: MW's new API tests are a breaking change which cause OpenStackManager and other extensions to fail to pass CI.

Other extensions:

  • GoogleAppEngine
  • EditSubpages
Tue, Jan 28, 7:56 PM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), ci-test-error, MediaWiki-extensions-WikimediaIncubator, CPT Initiatives (API Integration Tests), MediaWiki-extensions-OpenStackManager, Wikimedia-production-error (Shared Build Failure)
Umherirrender added a project to T242913: MW's new API tests are a breaking change which cause OpenStackManager and other extensions to fail to pass CI: ci-test-error.
Tue, Jan 28, 7:42 PM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), ci-test-error, MediaWiki-extensions-WikimediaIncubator, CPT Initiatives (API Integration Tests), MediaWiki-extensions-OpenStackManager, Wikimedia-production-error (Shared Build Failure)
Umherirrender added a project to T196436: EditSubpages extension fails mediawiki/core webdriver.io tests: ci-test-error.
Tue, Jan 28, 7:28 PM · ci-test-error, Release-Engineering-Team (Unit & Int & System Tooling), Release-Engineering-Team-TODO, MediaWiki-Core-Testing, User-zeljkofilipin, MediaWiki-extensions-Other
Umherirrender created T243856: Unit tests of ActiveAbstract extension failing on test class DroppingReturnValueMap.
Tue, Jan 28, 7:22 PM · MediaWiki-Core-Testing, ci-test-error, ActiveAbstract
Umherirrender committed rEMWF6b78c5963b84: build: Update grunt to fix security issue (authored by Umherirrender).
build: Update grunt to fix security issue
Tue, Jan 28, 2:29 AM

Mon, Jan 27

Umherirrender created T243792: Upgrade dev dependencies of repositiory wikimedia/portals.
Mon, Jan 27, 9:26 PM · LibUp, Wikimedia-Portals
Umherirrender updated the task description for T243790: Upgrade nyc to latest version.
Mon, Jan 27, 9:21 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Navigation-Popups, Readers-Web-Backlog (Tracking), Growth-Team, WikibaseMediaInfo, MobileFrontend, GrowthExperiments
Umherirrender created T243791: Upgrade karma and related packages to latest version in libraries.
Mon, Jan 27, 9:21 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), User-Ryasmeen, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), OOUI, VisualEditor, Utilities-UnicodeJS, OOjs
Umherirrender created T243790: Upgrade nyc to latest version.
Mon, Jan 27, 9:00 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Navigation-Popups, Readers-Web-Backlog (Tracking), Growth-Team, WikibaseMediaInfo, MobileFrontend, GrowthExperiments
Umherirrender committed rLLUP03553c15ec6f: Remove deprecated "eslint-config-node-services" (authored by Umherirrender).
Remove deprecated "eslint-config-node-services"
Mon, Jan 27, 8:48 PM
Umherirrender added a comment to T243788: libup run of repo Popups fails on npm test with warnings.

MobileFronted also says about differences

Mon, Jan 27, 7:51 PM · LibUp
Umherirrender created T243788: libup run of repo Popups fails on npm test with warnings.
Mon, Jan 27, 7:48 PM · LibUp
Umherirrender created T243787: libup run of repo WikibaseMediaInfo fails on npm ci with failing wikibase dependencies.
Mon, Jan 27, 7:43 PM · LibUp
Umherirrender closed T243719: libup has problems to run karma as Resolved.

karma runs now, thanks for the fix

Mon, Jan 27, 6:24 PM · LibUp

Sun, Jan 26

Umherirrender committed rEHTW108049b03020: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-codesniffer to 29.0.0
Sun, Jan 26, 9:10 PM
Umherirrender added a comment to T243717: libup should not assume Gruntfile.js exists everywhere.

MobileFrontend would have the same error, but fails at other location for the moment - https://libraryupgrader2.wmflabs.org/r/mediawiki/extensions/MobileFrontend

Sun, Jan 26, 8:11 PM · LibUp
Umherirrender committed rEWIS24aa5aabd1db: build: Updating dependencies (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating dependencies
Sun, Jan 26, 7:53 PM
Umherirrender added a comment to T243718: libup web ui returns sometimes 500 Internal Server Error.

Another one:
https://libraryupgrader2.wmflabs.org/r/mediawiki/services/parsoid

Sun, Jan 26, 7:27 PM · Patch-For-Review, LibUp
Umherirrender committed rEFLI8edec4efab71: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-codesniffer to 29.0.0
Sun, Jan 26, 7:25 PM
Umherirrender added a comment to T243718: libup web ui returns sometimes 500 Internal Server Error.

On Html2Wiki there is an issue with autofix - T243721 - but I have no idea if that produce the error in the web ui

Sun, Jan 26, 7:09 PM · Patch-For-Review, LibUp
Umherirrender created T243721: Autofix of sniff MediaWiki.Commenting.DocComment fails / produce invalid file.
Sun, Jan 26, 7:09 PM · MediaWiki-Codesniffer
Umherirrender created T243719: libup has problems to run karma.
Sun, Jan 26, 6:48 PM · LibUp
Umherirrender created T243718: libup web ui returns sometimes 500 Internal Server Error.
Sun, Jan 26, 6:47 PM · Patch-For-Review, LibUp
Umherirrender committed rEPRR2388fc655798: build: Updating dependencies (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating dependencies
Sun, Jan 26, 6:44 PM
Umherirrender created T243717: libup should not assume Gruntfile.js exists everywhere.
Sun, Jan 26, 6:30 PM · LibUp
Umherirrender committed rEBTR6d9817c9d9be: Use unix newline style in extension.json (authored by Umherirrender).
Use unix newline style in extension.json
Sun, Jan 26, 1:51 PM
Umherirrender committed rEBSG0635395b01fe: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-codesniffer to 29.0.0
Sun, Jan 26, 9:14 AM
Umherirrender committed rEBTM3088110eaab4: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-codesniffer to 29.0.0
Sun, Jan 26, 7:35 AM
Umherirrender committed rEBSJ6461f61999c0: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-codesniffer to 29.0.0
Sun, Jan 26, 7:34 AM
Umherirrender committed rEBTSf45839a8606d: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-codesniffer to 29.0.0
Sun, Jan 26, 7:31 AM
Umherirrender committed rEBSL92757b0eb3d8: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-codesniffer to 29.0.0
Sun, Jan 26, 7:30 AM
Umherirrender committed rEBTX7f8124fe2406: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-codesniffer to 29.0.0
Sun, Jan 26, 7:30 AM
Umherirrender committed rEBTF511288887653: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-codesniffer to 29.0.0
Sun, Jan 26, 7:01 AM

Sat, Jan 25

Umherirrender committed rESRX055b1be8ff85: Type hint `$updater` parameter in onLoadExtensionSchemaUpdates (authored by Ammarpad).
Type hint `$updater` parameter in onLoadExtensionSchemaUpdates
Sat, Jan 25, 7:30 PM
Umherirrender closed T219139: Avoid use of isset( ..., ..., [...] ) function construct / syntax as Resolved.

The last question is, if this should be done also for unset()
I would say yes, because it makes the code easier when doing one thing in one line and not combine multi unsets in one line.

Sat, Jan 25, 10:32 AM · MediaWiki-Codesniffer
Umherirrender added a comment to T242762: Expand PHPUnitAssertEqualsSniff to better auto-fix comparisons with count().

Is there an easy way to skip the first parameter in a method call, no matter how complicated the code is?

Sat, Jan 25, 10:31 AM · User-thiemowmde, MediaWiki-Codesniffer

Fri, Jan 24

Umherirrender committed rLLUP85126698407f: Handle single string for grunt file list before expand (authored by Umherirrender).
Handle single string for grunt file list before expand
Fri, Jan 24, 11:48 PM

Jan 17 2020

Umherirrender committed rEAFY09334e75de8d: build: Add php-parallel-lint, MinusX and banana-checker (authored by Umherirrender).
build: Add php-parallel-lint, MinusX and banana-checker
Jan 17 2020, 7:53 PM
Umherirrender committed rEAFYed761c803b67: Add missing action-abusefilter-bypass message (authored by Umherirrender).
Add missing action-abusefilter-bypass message
Jan 17 2020, 7:53 PM