Umherirrender (Umherirrender)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 2:31 PM (206 w, 4 d)
Availability
Available
LDAP User
Umherirrender
MediaWiki User
Umherirrender [ Global Accounts ]

Recent Activity

Yesterday

Umherirrender added a comment to T194585: Expose whether a user is blocked from editing a specific page via the API.

@Umherirrender I get a true value even if the user is blocked (on master), so this doesn't resolve the use case.

should User::isBlockedFrom be executed from Title::userCan? If not, then another property should be created, or I suppose this property should take both into consideration?

Sat, Sep 22, 2:23 PM · Patch-For-Review, Anti-Harassment (AHT Sprint 29), MediaWiki-User-management, MediaWiki-API
Umherirrender added a comment to T200238: API can exceed GenderCache's miss limit, thus returning titles with the default-gendered namespace prefix.

The magic transformation sounds good, because it does not need to fill the cache in each api module, but for a quick win it seems easier to fill the cache in fileusage - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/462122/

Sat, Sep 22, 10:13 AM · Russian-Sites, MediaWiki-API

Fri, Sep 21

Umherirrender added a comment to T194585: Expose whether a user is blocked from editing a specific page via the API.

The partial block changes have to add some checks to Title::userCan to support namespace or page depending user blocks in all places of mediawiki (like edit tabs in the navigation etc.)

Fri, Sep 21, 10:13 PM · Patch-For-Review, Anti-Harassment (AHT Sprint 29), MediaWiki-User-management, MediaWiki-API
Umherirrender added a comment to T194585: Expose whether a user is blocked from editing a specific page via the API.

It seems this already works:

Fri, Sep 21, 7:39 PM · Patch-For-Review, Anti-Harassment (AHT Sprint 29), MediaWiki-User-management, MediaWiki-API

Thu, Sep 20

Umherirrender committed rEMEM8782ce9c826c: Use short array syntax in i18n alias file (authored by Umherirrender).
Use short array syntax in i18n alias file
Thu, Sep 20, 10:17 PM
Umherirrender committed rEPFM735733a677cc: Remove @codingStandardsIgnoreFile from i18n alias file (authored by Umherirrender).
Remove @codingStandardsIgnoreFile from i18n alias file
Thu, Sep 20, 8:15 PM
Umherirrender committed rMSBC235b92be9507: Fix json indent in composer.json (authored by Umherirrender).
Fix json indent in composer.json
Thu, Sep 20, 4:41 PM
Umherirrender committed rMSBC073c524e556f: Fix json indent in composer.json (authored by Umherirrender).
Fix json indent in composer.json
Thu, Sep 20, 4:41 PM

Wed, Sep 19

Umherirrender claimed T64863: AntiSpoof: Error in debug log and API should not be localised.

It would work when using a Status object inside the code and giving it the language you want when converting to a string

Wed, Sep 19, 8:44 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Technical-Debt, Easy, AntiSpoof
Umherirrender closed T91660: Add escaping tests for global function wfEscapeShellArg as Declined.

wfEscapeShellArg now calls Shell::escape which is tested

Wed, Sep 19, 7:22 PM · Easy, MediaWiki-Core-Tests
Umherirrender added a project to T200839: PHP Notice: Undefined index from PagedTiffHandler_body.php:269: Multimedia.
Wed, Sep 19, 7:16 PM · Multimedia, Wikimedia-production-error, Reading-Infrastructure-Team-Backlog, MediaWiki-extensions-PagedTiffHandler
Umherirrender added a comment to T200839: PHP Notice: Undefined index from PagedTiffHandler_body.php:269.

The tiff has 212 pages, mediawiki metadata sees only 199. The page number 1 is missing, therefor the first and second page on the image page is same, because the page with the lowest number (2) is the first page, but when requesting a page per parameter, the page with that number is returned. That results in two pages which are the same

Wed, Sep 19, 7:15 PM · Multimedia, Wikimedia-production-error, Reading-Infrastructure-Team-Backlog, MediaWiki-extensions-PagedTiffHandler

Tue, Sep 18

Umherirrender claimed T102581: Create a separate list of suppression-only reasons for Special:RevisionDelete.
Tue, Sep 18, 7:24 PM · Patch-For-Review, Easy, MediaWiki-Revision-deletion
Umherirrender closed T142882: `usergroups` field label entity-encoded twice in Special:Preferences as Resolved.

It works for me now.

Tue, Sep 18, 6:55 PM · Patch-For-Review, Easy, MediaWiki-Special-pages
Umherirrender closed T175301: Special:Filepath sometimes throws "MWException: SpecialFilepath doesn't redirect!" as Resolved.

The url above looks good on beta labs: https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=Special:FilePath&file=Konrad_Alexander_M%25C3%25BCller-Kurzwelly_-_Stornas.jpg

Tue, Sep 18, 6:12 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, MediaWiki-Special-pages, Multimedia, Commons, MediaWiki-File-management, Wikimedia-production-error

Sun, Sep 16

Umherirrender claimed T169005: StructureTest::testUnitTestFileNamesEndWithTest() should not shell out.
Sun, Sep 16, 8:03 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Easy, MediaWiki-Core-Tests
Umherirrender closed T96418: MassAction string extraction: Complete i18n for end-user interface as Resolved.

Have not found any english text inside the extension, except some exception text

Sun, Sep 16, 6:58 PM · Patch-For-Review, Google-Code-in-2017, I18n, MassAction
Krinkle awarded T203805: codesniffer detects unparenthesized ternary in mediawiki/core Article.php a Orange Medal token.
Sun, Sep 16, 3:48 PM · Wikidata, Structured-Data-Commons, MediaWiki-General-or-Unknown
Umherirrender committed rEGAU22890c03ac15: build: Add php-parallel-lint, MinusX and grunt-jsonlint (authored by Umherirrender).
build: Add php-parallel-lint, MinusX and grunt-jsonlint
Sun, Sep 16, 11:47 AM
Umherirrender committed rMSBC9f5c19ff30d6: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces (authored by Umherirrender).
Require MediaWiki 1.31 in extension.json for AutoloadNamespaces
Sun, Sep 16, 8:52 AM

Fri, Sep 14

Umherirrender committed rESCCff2bea655598: Add @group Database to unit test (authored by Umherirrender).
Add @group Database to unit test
Fri, Sep 14, 8:03 PM
Umherirrender committed rEBTR02c357ac8be8: Add @group Database to unit test (authored by Umherirrender).
Add @group Database to unit test
Fri, Sep 14, 7:42 PM
Umherirrender committed rSECCbf34a849581b: Add phan config file (authored by Umherirrender).
Add phan config file
Fri, Sep 14, 4:44 PM
Umherirrender committed rSECCed36ac9c35a8: Add phan config file (authored by Umherirrender).
Add phan config file
Fri, Sep 14, 4:41 PM
Umherirrender created T204357: Add sniff for order of public and static in class property declaration.
Fri, Sep 14, 3:22 PM · MediaWiki-Codesniffer
Umherirrender committed rEAPU4bd5f7b83108: build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-codesniffer to 22.0.0
Fri, Sep 14, 12:42 PM

Thu, Sep 13

Umherirrender added a comment to T204176: Decide how to configure ESLint rules and ignores.

Having one config file per tool is okay, so having the ignores in .eslintrc.json would be okay.
But I have no idea if eslint supports such a key in the config or is that okay for the concept of that file

Thu, Sep 13, 7:36 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Front-end-Standards-Group
Umherirrender updated subscribers of T204176: Decide how to configure ESLint rules and ignores.

Having less files in the root folder is more hygiene than some lines in a file not looking often at, because there are many linters or tools wanting such config files

Thu, Sep 13, 4:03 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Front-end-Standards-Group

Wed, Sep 12

Umherirrender committed rEBSL43b308c7ab1b: Add @group Database to unit test (authored by Umherirrender).
Add @group Database to unit test
Wed, Sep 12, 8:51 PM
Umherirrender committed rECPVa866977a066a: Add @group Database to unit test (authored by Umherirrender).
Add @group Database to unit test
Wed, Sep 12, 8:42 PM

Tue, Sep 11

Umherirrender updated subscribers of T203312: Add sniff that preg_quote should not be used with 1 argument.

The special regular expression characters are: . \ + * ? [ ^ ] $ ( ) { } = ! < > | : -
From http://www.php.net/manual/en/function.preg-quote.php

Tue, Sep 11, 7:57 PM · MediaWiki-Codesniffer
Umherirrender added a comment to T202149: Exception thrown for failure to save settings appears ~ 1000 times/day.

It is not possible to move the User::load( User::READ_LATEST ); and User::saveSettings() near together.

Tue, Sep 11, 5:01 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, BetaFeatures, Wikimedia-production-error, MediaWiki-Authentication-and-authorization

Mon, Sep 10

Umherirrender added a comment to T203980: Disallow use of @private and @protected using MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation.

It seems it should only be documented in the sniff and there must stay.
Some @protected have comments about unit tests etc.

Mon, Sep 10, 7:55 PM · MediaWiki-Codesniffer
Umherirrender closed T189990: Rename FullTextQueryStringQueryBuilder.php to let phpunit run it as Resolved.
Mon, Sep 10, 7:44 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Discovery-Search (Current work), Patch-For-Review, Discovery, CirrusSearch
Umherirrender committed rEULC4c27fdae7103: Require MediaWiki 1.29 in extension.json for manifest_version 2 (authored by Umherirrender).
Require MediaWiki 1.29 in extension.json for manifest_version 2
Mon, Sep 10, 6:45 PM
Umherirrender created T203980: Disallow use of @private and @protected using MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation.
Mon, Sep 10, 6:20 PM · MediaWiki-Codesniffer
Umherirrender added a comment to T195009: Cite extension does not pass phan-taint-check 1.2.0.

It is now failing also for 1.1.0 and blocks merges

Mon, Sep 10, 4:25 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, Cite, phan-taint-check-plugin

Sun, Sep 9

Umherirrender updated the task description for T203922: Allow deprecated @type in MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation.
Sun, Sep 9, 7:36 PM · MediaWiki-Codesniffer
Umherirrender updated the task description for T203922: Allow deprecated @type in MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation.
Sun, Sep 9, 7:35 PM · MediaWiki-Codesniffer
Umherirrender created T203922: Allow deprecated @type in MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation.
Sun, Sep 9, 7:30 PM · MediaWiki-Codesniffer
Umherirrender updated the task description for T203916: MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation reports @@ as error.
Sun, Sep 9, 7:14 PM · MediaWiki-Codesniffer
Umherirrender created T203916: MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation reports @@ as error.
Sun, Sep 9, 6:12 PM · MediaWiki-Codesniffer
Umherirrender added a comment to T202386: Add phan-taint-check-plugin to FundraisingEmailUnsubscribe extension.

Huh. Currently failing due to:
Package mediawiki/phan-taint-check-plugin at version 1.5.0 has a PHP requirement incompatible with your PHP version (5.6.33)

I suppose that is due to the config line in composer.json that this extension has.

Run taint-check-plugin with --ignore-platform-reqs because it is not used in production?

That was my initial thought, but I'm worried about that causing problems later on. I played around a bit and with some advice from bawolff I got CI to install the plugin in a separate directory so it won't be affected by the extensions' own config. This will also fix the problem of BlueSpice* depending upon ext-tidy, which wasn't installed in the docker container.

Sun, Sep 9, 7:05 AM · Patch-For-Review, Fundraising-Backlog, MediaWiki-extensions-Other, phan-taint-check-plugin

Sat, Sep 8

Umherirrender added a comment to T203331: libraryupgrader missed WikibaseQualityConstraints to update phan-taint-check-plugin.

It seems Linter, MassMessage and VisualEditor also missed on taint-check update to 1.5.0

Sat, Sep 8, 11:43 AM · VPS-project-libraryupgrader
Umherirrender added a comment to T203867: LinksUpdate job is not being triggered when it should.

There is no LinksUpdate T30876

Sat, Sep 8, 11:40 AM · MediaWiki-JobQueue
Umherirrender added a comment to T203331: libraryupgrader missed WikibaseQualityConstraints to update phan-taint-check-plugin.

WikibaseQualityConstraints also missed on update of taint-check to 1.5.0

Sat, Sep 8, 8:41 AM · VPS-project-libraryupgrader
Umherirrender updated subscribers of T202386: Add phan-taint-check-plugin to FundraisingEmailUnsubscribe extension.

Huh. Currently failing due to:
Package mediawiki/phan-taint-check-plugin at version 1.5.0 has a PHP requirement incompatible with your PHP version (5.6.33)

I suppose that is due to the config line in composer.json that this extension has.

Sat, Sep 8, 7:21 AM · Patch-For-Review, Fundraising-Backlog, MediaWiki-extensions-Other, phan-taint-check-plugin

Fri, Sep 7

Umherirrender committed rESCCb69e2df08a90: Empty return statement not required (authored by Umherirrender).
Empty return statement not required
Fri, Sep 7, 9:51 PM
Umherirrender added a subtask for T201219: Enable phan-taint-check-plugin on all Wikimedia-deployed repositories where it is currently passing: T203843: Add phan-taint-check-plugin to SkinPerPage extension.
Fri, Sep 7, 8:17 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, Wikimedia-General-or-Unknown, Continuous-Integration-Config, phan-taint-check-plugin
Umherirrender added a parent task for T203843: Add phan-taint-check-plugin to SkinPerPage extension: T201219: Enable phan-taint-check-plugin on all Wikimedia-deployed repositories where it is currently passing.
Fri, Sep 7, 8:17 PM · MediaWiki-extensions-Other, phan-taint-check-plugin
Umherirrender created T203843: Add phan-taint-check-plugin to SkinPerPage extension.
Fri, Sep 7, 8:17 PM · MediaWiki-extensions-Other, phan-taint-check-plugin
Umherirrender committed rEULC10265852bea2: Init $magicWords in magic alias file (authored by Umherirrender).
Init $magicWords in magic alias file
Fri, Sep 7, 7:17 PM
Umherirrender added a subtask for T123943: Add extension licenses to extension.json so they appear correctly on Special:Version: T203832: Document license state of extension SkinPerPage.
Fri, Sep 7, 6:15 PM · Google-Code-in-2018, Epic, MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), Software-Licensing, Patch-For-Review, Google-Code-In-2015, MediaWiki-extensions-General
Umherirrender added a parent task for T203832: Document license state of extension SkinPerPage: T123943: Add extension licenses to extension.json so they appear correctly on Special:Version.
Fri, Sep 7, 6:15 PM · Software-Licensing, MediaWiki-extensions-Other
Umherirrender created T203832: Document license state of extension SkinPerPage.
Fri, Sep 7, 6:12 PM · Software-Licensing, MediaWiki-extensions-Other
Umherirrender renamed T203831: libraryupgrader is downloading mediawiki/minus-x over and over from libraryupdater is downloading mediawiki/minus-x over and over to libraryupgrader is downloading mediawiki/minus-x over and over.
Fri, Sep 7, 6:00 PM · VPS-project-libraryupgrader
Umherirrender created T203831: libraryupgrader is downloading mediawiki/minus-x over and over.
Fri, Sep 7, 6:00 PM · VPS-project-libraryupgrader
Umherirrender created T203830: libraryupgrader missed some repos due to Generic.Files.LineLength.TooLong.
Fri, Sep 7, 5:57 PM · VPS-project-libraryupgrader
Umherirrender created T203829: libraryupgrader missed some git repos due to network problems.
Fri, Sep 7, 5:51 PM · VPS-project-libraryupgrader
Umherirrender added a comment to T203331: libraryupgrader missed WikibaseQualityConstraints to update phan-taint-check-plugin.

It seems AutoCreateCategoryPages was ignored on codesniffer run - no logs https://libraryupgrader.wmflabs.org/logs/2018-09-02/

Fri, Sep 7, 5:51 PM · VPS-project-libraryupgrader
Umherirrender created T203805: codesniffer detects unparenthesized ternary in mediawiki/core Article.php.
Fri, Sep 7, 3:57 PM · Wikidata, Structured-Data-Commons, MediaWiki-General-or-Unknown
Umherirrender added a comment to T203800: Add sniff to replace !! by explicit boolean cast (bool).

I note we purposely seem to choose this "pattern" for javascript (I guess for less characters)

Fri, Sep 7, 3:14 PM · MediaWiki-Codesniffer
Umherirrender created T203800: Add sniff to replace !! by explicit boolean cast (bool).
Fri, Sep 7, 3:12 PM · MediaWiki-Codesniffer
Umherirrender created T203799: Add sniff to remove space after not operator.
Fri, Sep 7, 3:11 PM · MediaWiki-Codesniffer
Umherirrender added a comment to T203346: phan-taint-check-plugin failing for Renameuser extension.

Would the extension pass the new version 1.5.0?

Fri, Sep 7, 12:19 PM · Patch-For-Review, MediaWiki-extensions-Renameuser, phan-taint-check-plugin

Thu, Sep 6

Umherirrender added a comment to T203689: REVISIONYEAR magic word returns empty result.

Maybe fixed with T203583

Thu, Sep 6, 5:02 PM · Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Regression, MediaWiki-Parser
Umherirrender added a comment to T203649: quibble-vendor-mysql-hhvm-docker no space left on device, write.

Sounds like handled in T202457

Thu, Sep 6, 4:54 PM · Continuous-Integration-Infrastructure, Math, Operations
Umherirrender added a project to T203689: REVISIONYEAR magic word returns empty result: Multi-Content-Revisions.
Thu, Sep 6, 4:51 PM · Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Regression, MediaWiki-Parser
Umherirrender committed rEDTB77edcf0e06fd: Remove obsolete "constructor" comments documenting constructors as such (authored by thiemowmde).
Remove obsolete "constructor" comments documenting constructors as such
Thu, Sep 6, 4:49 PM
Umherirrender updated the task description for T203690: phan-taint-check-plugin failing for LiquidThreads extension.
Thu, Sep 6, 4:23 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), phan-taint-check-plugin, MediaWiki-extensions-LiquidThreads
Umherirrender created T203690: phan-taint-check-plugin failing for LiquidThreads extension.
Thu, Sep 6, 4:16 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), phan-taint-check-plugin, MediaWiki-extensions-LiquidThreads
Umherirrender closed T202057: BadMethodCallException from line 98 of ApiCategoryTree.php: Call to a member function getDBkey() on a non-object as Resolved.
Thu, Sep 6, 4:08 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, Wikimedia-production-error, MediaWiki-extensions-CategoryTree
Umherirrender closed T196684: PHP Notice: Undefined index from extensions/Quiz/Question.php on line 380 as Resolved.
Thu, Sep 6, 4:06 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, VisualEditor, Editing-team, MediaWiki-extensions-Quiz, Wikimedia-production-error
Umherirrender closed T198285: Renameuser producing a lot of errors as Resolved.
Thu, Sep 6, 4:04 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, MediaWiki-extensions-Renameuser
Umherirrender closed T198285: Renameuser producing a lot of errors, a subtask of T41480: Issues affecting translatewiki.net, as Resolved.
Thu, Sep 6, 4:04 PM · Tracking, MediaWiki-General-or-Unknown
Umherirrender committed rEDTBd34a4b7891d0: Add missing types to @param PHPDoc tags (authored by thiemowmde).
Add missing types to @param PHPDoc tags
Thu, Sep 6, 4:02 PM

Sun, Sep 2

Umherirrender created T203351: api help for query=filerepoinfo are missing messages for optional filerepo properties.
Sun, Sep 2, 10:38 AM · Documentation, I18n, MediaWiki-API
Umherirrender updated subscribers of T203325: BotPasswords right selection form shows plain-text html.

I am not sure, but the regression could be in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/448190/

Sun, Sep 2, 9:21 AM · MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, MediaWiki-Special-pages, Regression, MediaWiki-Authentication-and-authorization
Umherirrender created T203346: phan-taint-check-plugin failing for Renameuser extension.
Sun, Sep 2, 8:51 AM · Patch-For-Review, MediaWiki-extensions-Renameuser, phan-taint-check-plugin
Umherirrender added a comment to T202922: Add sniff to remove semicolon after class declaration.

PSR2.Classes.ClassDeclaration would detect the issue as PSR2.Classes.ClassDeclaration.CloseBraceSameLine when the closing } is not on a line by itself (except whitespace and comments), but the sniff cannot fix the issue for the semicolon case

Sun, Sep 2, 8:28 AM · MediaWiki-Codesniffer
Umherirrender placed T203312: Add sniff that preg_quote should not be used with 1 argument up for grabs.
Sun, Sep 2, 8:21 AM · MediaWiki-Codesniffer
Umherirrender added a comment to T203312: Add sniff that preg_quote should not be used with 1 argument.

I have never seen brackets as delimiter, but it is okay from documentation http://php.net/manual/de/regexp.reference.delimiters.php
and such brackets are already escaped by `preg_quote
`
With codesniffer it is not possible to detect the context of preg_quote, so this needs a phan plugin or the phan-taint-check-plugin needs a new category to check user supplied input to regex. Phan can also see the call in array_map

Sun, Sep 2, 8:15 AM · MediaWiki-Codesniffer

Sat, Sep 1

Krinkle awarded T203312: Add sniff that preg_quote should not be used with 1 argument a Orange Medal token.
Sat, Sep 1, 8:18 PM · MediaWiki-Codesniffer
Umherirrender created T203331: libraryupgrader missed WikibaseQualityConstraints to update phan-taint-check-plugin.
Sat, Sep 1, 5:30 PM · VPS-project-libraryupgrader
Umherirrender added a comment to T203312: Add sniff that preg_quote should not be used with 1 argument.

The expaned sniff does not detect the function at location where callables are allowed:

Sat, Sep 1, 12:48 PM · MediaWiki-Codesniffer
Umherirrender created T203312: Add sniff that preg_quote should not be used with 1 argument.
Sat, Sep 1, 11:56 AM · MediaWiki-Codesniffer
Umherirrender added a subtask for T191065: 1.32.0-wmf.19 deployment blockers: T203294: Text "reviewWrapped" is displayed above diffs.
Sat, Sep 1, 8:15 AM · Release-Engineering-Team (Kanban), Release, Train Deployments
Umherirrender added a parent task for T203294: Text "reviewWrapped" is displayed above diffs: T191065: 1.32.0-wmf.19 deployment blockers.
Sat, Sep 1, 8:15 AM · MediaWiki-History-or-Diffs, Regression
Umherirrender assigned T203294: Text "reviewWrapped" is displayed above diffs to PeterBowman.

Fixed by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FlaggedRevs/+/456759/

Sat, Sep 1, 8:15 AM · MediaWiki-History-or-Diffs, Regression
Umherirrender closed T195129: ActiveAbstract extension is missing @covers tags as Resolved.
Sat, Sep 1, 8:09 AM · MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Test-Coverage, ActiveAbstract
Umherirrender added a comment to T203202: Beta features tab lead message in Special:Preferences doesn't play nicely with OOUI.

The code is also used in Gadgets extension.

Sat, Sep 1, 8:06 AM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), UI-Standardization, MediaWiki-User-preferences

Fri, Aug 31

Umherirrender added a comment to T200679: Add sniff to prevent using config globals when Config is available.

This could be tricky, because the sniff has to decide between config globals and objects/non-config globals. That means the sniff needs the way to set globals in .phpcs.xml as input for use in extensions. The core list can be found on T159283 and should be hard coded.

Fri, Aug 31, 7:54 PM · MediaWiki-Codesniffer
Umherirrender merged T203274: Entries in Block list are not accurate into T199174: Special:BlockList gives faulty results after an admin changes another admin's block.
Fri, Aug 31, 7:47 PM · MediaWiki-User-management
Umherirrender merged task T203274: Entries in Block list are not accurate into T199174: Special:BlockList gives faulty results after an admin changes another admin's block.
Fri, Aug 31, 7:47 PM · MediaWiki-User-management
Umherirrender closed T203089: Link to extension documentation in extension configuration is wrong as Resolved.

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FormWizard/+/456441/

Fri, Aug 31, 7:28 PM · Easy, FormWizard
Umherirrender closed T203089: Link to extension documentation in extension configuration is wrong, a subtask of T198769: Rewrite FormWizard as an extension, as Resolved.
Fri, Aug 31, 7:28 PM · FormWizard-Gadget, FormWizard
Umherirrender closed T168970: Add sniff to detect spaces before comma in argument lists as Resolved.

It seems there is no standard sniff for the comma in implements or even a sniff to check for spacing around implements

Fri, Aug 31, 7:13 PM · MediaWiki-Codesniffer
Umherirrender closed T123258: Notice: Undefined index: 0 in /srv/mediawiki/php-1.27.0-wmf.9/extensions/MassMessage/includes/MassMessage.php on line 391 as Resolved.
Fri, Aug 31, 6:41 PM · MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Editing-team, Wikimedia-production-error, MassMessage

Thu, Aug 30

Umherirrender committed rEFWZ3d06539bea00: Fix case of description message and url (authored by Umherirrender).
Fix case of description message and url
Thu, Aug 30, 8:38 PM

Tue, Aug 28

Umherirrender added a comment to T183218: PHPCS should make sure @covers tags are absolute.

That is correct, the trait is not used everywhere. It could be enforced with phpcs when a class extends the PHPUnit\Framework\TestCase class. Than the test itself and all tests extends that test class also run the validation of the trait.

Tue, Aug 28, 4:11 PM · MediaWiki-Codesniffer