Page MenuHomePhabricator

Umherirrender (Umherirrender)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 2:31 PM (343 w, 5 d)
Availability
Available
LDAP User
Umherirrender
MediaWiki User
Umherirrender [ Global Accounts ]

Recent Activity

Yesterday

Umherirrender committed rESMX873c7ced513b: Replace deprecated Language functions (authored by Umherirrender).
Replace deprecated Language functions
Sun, May 9, 5:23 PM

Sat, May 8

Umherirrender committed rEAPU809f1f73f4d9: Replace compact() with real array (authored by Umherirrender).
Replace compact() with real array
Sat, May 8, 9:26 AM
Umherirrender committed rEAPUecbc2531ee70: build: Updating grunt to 1.4.0 (authored by LibUp-bot).
build: Updating grunt to 1.4.0
Sat, May 8, 9:26 AM
Umherirrender committed rEMASf5a6015775b3: Remove CreateDB2MathTable.php (authored by Umherirrender).
Remove CreateDB2MathTable.php
Sat, May 8, 5:11 AM

Fri, May 7

Umherirrender committed rEGLW4cfbf24e01bf: Use ::class for class name (authored by Umherirrender).
Use ::class for class name
Fri, May 7, 10:43 PM
Umherirrender added a comment to T282278: libup possible has issues with npm audit to get all vulnerability removed.

I have no idea how to handle this at best. The loop would be a workaround, but that sounds okay. Is npm audit giving an return code when there is still something to fix? But also without it calling it twice would be okay.

Fri, May 7, 10:10 PM · Patch-For-Review, LibUp
Umherirrender added a comment to T281223: MediaWiki\Revision\RevisionAccessException: Failed to load data blob from tt:9375723: Bad data in text row 9375723. Use findBadBlobs.php to remedy.. If this problem persist, use the findBadBlobs maintenance script to investigate the issue and mark bad blobs..

The same blob number on zhwiki also mention under T212428#4886442, possible a duplicate

Fri, May 7, 8:47 PM · Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error
Umherirrender closed T187491: ApiUpload throws MWException "No specifications provided to ArchivedFile constructor" as Resolved.

UploadBase::mTempPath is documented to have null values, nothing more to fix from my point of view

Fri, May 7, 8:45 PM · Structured-Data-Backlog, Structured Data Engineering, MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-Uploading, Wikimedia-production-error
Umherirrender added a comment to T282173: Possible uptick in "DBTransactionSizeError: Transaction spent [n] second(s) in writes, exceeding the limit of 3".

There are also other issues on action=upload with big files, see T278389 or T280926, possible all related

Fri, May 7, 8:42 PM · Platform Engineering, User-brennen, Wikimedia-production-error
Umherirrender added a comment to T282278: libup possible has issues with npm audit to get all vulnerability removed.

On AbuseFilter is now twiced updated for hosted-git-info possible by this problem

Fri, May 7, 8:36 PM · Patch-For-Review, LibUp
Umherirrender created T282278: libup possible has issues with npm audit to get all vulnerability removed.
Fri, May 7, 8:11 PM · Patch-For-Review, LibUp
Umherirrender committed rEBSU32631a3f6a3b: build: Updating lodash to 4.17.21 (authored by LibUp-bot).
build: Updating lodash to 4.17.21
Fri, May 7, 8:09 PM
Umherirrender committed rECOS5666e63d961b: build: Updating npm dependencies (authored by LibUp-bot).
build: Updating npm dependencies
Fri, May 7, 8:08 PM
Umherirrender committed rECOS94d23d25feab: Suppress phan issue on fallback code (authored by Umherirrender).
Suppress phan issue on fallback code
Fri, May 7, 7:59 PM
Umherirrender committed rEBSU2cc096857b8b: Revert "Use new method to get "changeableGroups"" (authored by Umherirrender).
Revert "Use new method to get "changeableGroups""
Fri, May 7, 7:58 PM
Umherirrender added a reverting change for rEBSUb2bef2855b5f: Use new method to get "changeableGroups": rEBSU2cc096857b8b: Revert "Use new method to get "changeableGroups"".
Fri, May 7, 7:58 PM
Umherirrender added a reverting change for rEBSUb2bef2855b5f: Use new method to get "changeableGroups": rEBSU4b11fae98072: Revert "Use new method to get "changeableGroups"".
Fri, May 7, 7:58 PM
Umherirrender committed rEBSU4b11fae98072: Revert "Use new method to get "changeableGroups"" (authored by Umherirrender).
Revert "Use new method to get "changeableGroups""
Fri, May 7, 7:58 PM
Umherirrender added a project to T282203: MediaWiki:Rev-deleted-text-permission displays instead of MediaWiki:Rev-suppressed-text-permission when a non-oversighter tries to view a suppressed diff: MediaWiki-Revision-deletion.

rev-suppressed-text-permission is only used on Special:Undelete. All other places does not make a different between normal and restricted, if the user is not able to see the content.

Fri, May 7, 4:23 PM · MediaWiki-Revision-deletion, MediaWiki-General

Thu, May 6

Umherirrender added a comment to T282070: After unblocking autoblock, Special:Log and Special:RecentChanges gives ParameterAssertionException: Bad value for parameter $dbKey.

The api shows that the database contains

Thu, May 6, 5:14 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Patch-For-Review, Platform Team Workboards (MW Expedition)
Umherirrender closed T206246: MassMessageJob failures due to invalid ChangeTags call as Resolved.
Thu, May 6, 4:17 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MassMessage, Wikimedia-production-error

Wed, May 5

Umherirrender added a comment to T280438: libup committed and uploaded an upgrade twice for the same package on the same repo.

Happen again:

Wed, May 5, 5:41 PM · Patch-For-Review, LibUp
Umherirrender added a comment to T249032: Hard deprecate ParserCache::singleton and remove a release later.

Removed as part of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/630299

Wed, May 5, 5:26 PM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), MediaWiki-Parser, Technical-Debt (Deprecation process)

Tue, May 4

Umherirrender committed rECAC1d324197ebbc: Replace uses of DB_MASTER with DB_PRIMARY (authored by Umherirrender).
Replace uses of DB_MASTER with DB_PRIMARY
Tue, May 4, 11:16 PM
Umherirrender closed T269403: ParameterTypeException when `diff`ing invalid MassMessageListContent as Resolved.
Tue, May 4, 8:48 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Release-Engineering-Team (Logspam), User-DannyS712, MediaWiki-ContentHandler, MassMessage, MediaWiki-Page-editing, Wikimedia-production-error
Umherirrender committed rEGNEd00c73175975: Avoid Message::toString in hook handler (authored by Umherirrender).
Avoid Message::toString in hook handler
Tue, May 4, 8:36 PM
Umherirrender committed rEWIS3831c8f2eaf8: Use static closures where safe to use (authored by Umherirrender).
Use static closures where safe to use
Tue, May 4, 7:51 PM
Umherirrender added a comment to T252946: Report implicit or explict usage of Message::__toString in the phan-taint-check-plugin.

There are some changes to Message::toString - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/681818

Tue, May 4, 7:18 PM · phan
Umherirrender added a comment to T220719: Standardize return type hint spacing.

The upstream sniff PSR12.Functions.ReturnTypeDeclaration is for PS12 without spaces between ) and :

Tue, May 4, 6:53 PM · Patch-For-Review, MediaWiki-Documentation, MediaWiki-Codesniffer
Umherirrender triaged T281914: Add phan-template annotations to wikimedia/testing-access-wrapper as Lowest priority.
Tue, May 4, 6:29 PM · phan, MediaWiki-Core-Tests
Umherirrender created T281914: Add phan-template annotations to wikimedia/testing-access-wrapper.
Tue, May 4, 6:29 PM · phan, MediaWiki-Core-Tests
Umherirrender committed rELGNb34445b90aa1: Use static closures where safe to use (authored by Umherirrender).
Use static closures where safe to use
Tue, May 4, 6:03 PM
Umherirrender created T281910: Analzye if MediaWiki.PHPUni.tAssertionOrder could handle more complex cases.
Tue, May 4, 6:03 PM · User-DannyS712, MediaWiki-Codesniffer
Umherirrender closed T274036: Use static closures where appropriate in MW Core as Resolved.
Tue, May 4, 5:03 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Patch-For-Review, MediaWiki-General
Umherirrender closed T274036: Use static closures where appropriate in MW Core, a subtask of T274038: Enforce use of static closures, as Resolved.
Tue, May 4, 5:03 PM · phan

Mon, May 3

Umherirrender closed T279651: Special:NewcomerTasksInfo: Error: Call to undefined method Status::getTotalCount() as Resolved.
Mon, May 3, 7:34 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Growth-Team (Current Sprint), GrowthExperiments, Wikimedia-production-error

Fri, Apr 30

Umherirrender closed T203830: libraryupgrader missed some repos due to Generic.Files.LineLength.TooLong as Declined.

That sounds okay to me, too.

Fri, Apr 30, 8:58 PM · LibUp
Umherirrender added a comment to T203830: libraryupgrader missed some repos due to Generic.Files.LineLength.TooLong.

Happen on canary right now: https://libraryupgrader2.wmcloud.org/logs2/256097

Fri, Apr 30, 7:04 PM · LibUp

Thu, Apr 29

Umherirrender added a comment to T281294: Drop CI for REL1_31 branch once it's EOL.

Other places to remove some pieces

Thu, Apr 29, 11:21 PM · Patch-For-Review, MW-1.31-release, Continuous-Integration-Infrastructure
Umherirrender added a comment to T241827: CheckUser causes a foreign key constraint failure on PostgreSQL when creating a new user.

The fk no longer exists, see T164898 - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/678426

Thu, Apr 29, 10:55 PM · Patch-For-Review, PostgreSQL, CheckUser
Umherirrender updated subscribers of T281526: TypeError: Return value of User::getEmail() must be of the type string, null returned.

Type hints were added in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/676444

Thu, Apr 29, 8:55 PM · MediaWiki-User-management, Platform Team Workboards (MW Expedition), Wikimedia-production-error
Umherirrender added a comment to T281400: TypeError: Argument 1 passed to EditPage::displayViewSourcePage() must implement interface Content, null given.

When Content::getSection fails in EditPage::getContentObject it is returning $def_content which is null here.

Thu, Apr 29, 8:46 PM · Patch-For-Review, MediaWiki-Revision-backend, MediaWiki-Page-editing, Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error
Umherirrender closed T281455: PHP Notice: Undefined variable: endTags as Resolved.

Could fail on wmf/1.36.0-wmf.38 as well (suggest no backport)

Thu, Apr 29, 8:28 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MassMessage, Wikimedia-production-error
Umherirrender added a comment to T281521: Revision not found in revisionCache: {alpha}.

The message is in the flow extension at:

Thu, Apr 29, 8:14 PM · Growth-Team, StructuredDiscussions, Wikimedia-production-error
Umherirrender updated the task description for T281524: Analyze why phan does not report a possible undeclared variable on short-circuit code with pass-by-ref variable.
Thu, Apr 29, 8:01 PM · Upstream, phan
Umherirrender created T281524: Analyze why phan does not report a possible undeclared variable on short-circuit code with pass-by-ref variable.
Thu, Apr 29, 8:00 PM · Upstream, phan
Umherirrender closed T281395: Error on Special:BlockList if there's a partial block against a page that is deleted as Resolved.

This can happen since https://gerrit.wikimedia.org/r/c/mediawiki/core/+/554947

Thu, Apr 29, 7:31 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-Blocks, Anti-Harassment (The Letter Song)
Umherirrender updated subscribers of T281455: PHP Notice: Undefined variable: endTags.

Regression from https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MassMessage/+/649670

Thu, Apr 29, 7:16 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MassMessage, Wikimedia-production-error
Umherirrender closed T278282: Files don't comply with psr-4 autoloading standard as Resolved.

the mention files here are tests files and test files are not part of the package. There is no message when using the older package as well.
From my point of view there is nothing to fix.

Thu, Apr 29, 7:07 PM · Composer, MediaWiki-Codesniffer
Umherirrender closed T273264: PHPCS incorrectly autofixing array key access over multiple lines as Resolved.

Now part of 36.0.0

Thu, Apr 29, 6:38 PM · User-DannyS712, Regression, MediaWiki-Codesniffer
Umherirrender closed T274016: Document sniffs that support configuration properties as Resolved.
Thu, Apr 29, 6:32 PM · Documentation, User-DannyS712, MediaWiki-Codesniffer

Wed, Apr 28

Umherirrender added a comment to T212101: Lock wait timeout exceeded in UploadFromChunks::updateChunkStatus.

There is logging in the code (UploadFromChunks::updateChunkStatus), not sure if that can be found for this request:

Wed, Apr 28, 6:41 PM · Wikimedia-production-error, Structured Data Engineering, Structured-Data-Backlog, MediaWiki-Uploading
Umherirrender closed T271356: The Title object yields no ID. Perhaps the page doesn't exist? as Resolved.

That will be fixed as part of T281340, there is nothing which could be fixed here, because the error was happen on a rollback / error situation already.

Wed, Apr 28, 6:18 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-derived-data, Wikimedia-production-error
Umherirrender added a comment to T281303: API : Service Unavailable error but page partially saved.

It looks like the data stream was interrupt and the server assumed a connection closed by the client.

Wed, Apr 28, 6:10 PM · MediaWiki-Page-editing, MediaWiki-API
Umherirrender added a comment to T187491: ApiUpload throws MWException "No specifications provided to ArchivedFile constructor".

The merged patch set does not fix the problem with $mTempPath not set, but it avoids the notice/failure.

Wed, Apr 28, 5:42 PM · Structured-Data-Backlog, Structured Data Engineering, MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-Uploading, Wikimedia-production-error

Tue, Apr 27

Umherirrender added a comment to T271356: The Title object yields no ID. Perhaps the page doesn't exist?.

Still seen as of 2021-04-14. Seen 63 times in the past 24 hours. Primarily on fawiki, but seen across wikipedia versions on 1.36.0-wmf.38

Tue, Apr 27, 11:27 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-derived-data, Wikimedia-production-error
Umherirrender added a comment to T272904: PageTriage extension causes TypeError: format.replace is not a function in randomToken function im SearchSatisfaction schema.

For me it is https://test.wikipedia.org/wiki/Special:NewPagesFeed where the resource loader module with that script is loaded.

Tue, Apr 27, 10:36 PM · PageCuration, Growth-Team, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), JavaScript, Release-Engineering-Team (Logspam), Wikimedia-production-error
Umherirrender closed T273506: [M] Sporadic “TypeError: Return value of EntityContentFactory::getTitleForId() must be an instance of Title, null returned” for Special:EntityData on Commons as Resolved.

Now shows:

Bad Request
Invalid ID: M4.
Tue, Apr 27, 9:57 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Structured-Data-Backlog, User-brennen, wdwb-tech, Commons, SDC General, Wikidata, Wikimedia-production-error
Umherirrender closed T273506: [M] Sporadic “TypeError: Return value of EntityContentFactory::getTitleForId() must be an instance of Title, null returned” for Special:EntityData on Commons, a subtask of T272518: Watch for extensions broken by WikiPage now deprecating construction on bad titles, as Resolved.
Tue, Apr 27, 9:56 PM · Patch-For-Review, ci-test-error, MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), MediaWiki-Revision-backend, Platform Team Workboards (MW Expedition)
Umherirrender closed T273808: DeferredUpdates: Deferred update 'AtomicSectionUpdate_EchoNotificationMapper::insert' failed to run. as Resolved.

Are there still issues in the logs?

Tue, Apr 27, 9:55 PM · Growth-Team-Filtering, wikitech.wikimedia.org, cloud-services-team (Kanban), Growth-Team, Notifications, Wikimedia-production-error
Umherirrender added a comment to T269376: Error: Invalid LatLng object: (NaN, NaN).

Error is thrown here: https://gerrit.wikimedia.org/g/mediawiki/extensions/Kartographer/+/ef6964df043285e91fb7c6e69ff48c9db2969582/lib/external/mapbox/mapbox-lib.js#1720

Tue, Apr 27, 9:37 PM · JavaScript, Product-Infrastructure-Team-Backlog, Browser-Support-Apple-Safari, Maps (Kartographer), Wikimedia-production-error
Umherirrender added a comment to T281050: Edit API with appendtext & a contentmodel change gives an internal api error.
ApiEditPage.php
			// @todo Add support for appending/prepending to the Content interface
Tue, Apr 27, 9:02 PM · Platform Team Workboards (Clinic Duty Team), MediaWiki-ContentHandler, MediaWiki-API
Umherirrender updated subscribers of T281134: action=protect is no longer rendering wikilinks in section legends.

There is a note about this on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/663327

Note: The fieldset legend is not parsed when it should be.

Tue, Apr 27, 6:13 PM · MediaWiki-Page-protection, Regression
Umherirrender added a comment to T281211: Provide option to move template documentation pages along with parent page.

There is a feature to move subpages on Special:MovePage, but that is typically not enabled in the template namespace, because the namespace itself is not a page which allows subpages (by definition of mediawiki)

Tue, Apr 27, 6:08 PM · MediaWiki-Page-rename
Umherirrender added a comment to T281274: Eliminator not able to edit "cascade-protected" pages despite having the right on urwiki.
In task description:

the "protect" right i.e. "Change protection levels, edit and move protected pages, and edit cascade-protected pages"

Tue, Apr 27, 6:06 PM · Wikimedia-Site-requests

Mon, Apr 26

Umherirrender renamed T281134: action=protect is no longer rendering wikilinks in section legends from special:protect is no longer rendering wikilinks in section legends to action=protect is no longer rendering wikilinks in section legends.
Mon, Apr 26, 6:17 PM · MediaWiki-Page-protection, Regression
Umherirrender added a comment to T281134: action=protect is no longer rendering wikilinks in section legends.

There is no Special:Protect. Did you mean action=protect or Special:ProtectedPages or Special:ProtectedTitles?

Mon, Apr 26, 6:17 PM · MediaWiki-Page-protection, Regression

Sun, Apr 25

Umherirrender committed rESNV6bada9f61c5c: build: Updating dependencies (authored by Umherirrender).
build: Updating dependencies
Sun, Apr 25, 7:02 PM

Sat, Apr 24

Umherirrender closed T253910: Sniff for wrong order of PHPUnit assert parameters as Resolved.
Sat, Apr 24, 10:58 PM · User-DannyS712, MediaWiki-Codesniffer
Umherirrender removed a project from T258227: Sniff or phan rule against use `?:` and `if` on returns that may be a string: MediaWiki-Codesniffer.
Sat, Apr 24, 10:56 PM · Patch-For-Review, phan
Umherirrender added a comment to T146644: Add cache support to PHPCode_Sniffer jobs.

eslint also allows caching and it is enabled on all repos, but there is not a task to enable/use the cache on CI for eslint.

Sat, Apr 24, 10:53 PM · MediaWiki-Codesniffer, Continuous-Integration-Config
Umherirrender claimed T274016: Document sniffs that support configuration properties.
Sat, Apr 24, 10:49 PM · Documentation, User-DannyS712, MediaWiki-Codesniffer
Umherirrender closed T279968: MediaWiki.NamingConventions.ValidGlobalName stops validation after php reserved global as Resolved.
Sat, Apr 24, 10:16 PM · User-DannyS712, MediaWiki-Codesniffer
Umherirrender committed rWSWF409d2fb2d0f1: build: Updating eslint-config-wikimedia to 0.20.0 (authored by Umherirrender).
build: Updating eslint-config-wikimedia to 0.20.0
Sat, Apr 24, 6:09 PM
Umherirrender committed rMSFSb9679b33f00d: build: Cleanup phpcs command in composer.json (authored by Umherirrender).
build: Cleanup phpcs command in composer.json
Sat, Apr 24, 5:32 PM
Umherirrender committed rMSFS0425b4af10ce: build: Updating eslint-config-wikimedia to 0.20.0 (authored by Umherirrender).
build: Updating eslint-config-wikimedia to 0.20.0
Sat, Apr 24, 5:30 PM
Umherirrender committed rMTPP5613ce53a182: build: Run phan with --allow-polyfill-parser on phpunit (authored by Umherirrender).
build: Run phan with --allow-polyfill-parser on phpunit
Sat, Apr 24, 1:24 PM
Umherirrender closed T279814: ValidGlobalNameSniff assumes that allowed global variable name prefix always consists of two characters as Resolved.
Sat, Apr 24, 8:53 AM · MediaWiki-Codesniffer
Umherirrender closed T274038: Enforce use of static closures as Resolved.
Sat, Apr 24, 8:48 AM · phan

Thu, Apr 22

Umherirrender added a comment to T274684: libup should remove exclude of vendor/node_modules from .phpcs.xml.

Now also coverage is ignored (done by https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/681483) and libup can remove it, for this part the version is v36.0.0 (release planned as of this now)

Thu, Apr 22, 5:50 PM · LibUp

Tue, Apr 20

Umherirrender added a comment to T280728: Widget not found on search pages.

Not sure if #searchText could be omitted on a page view, but this is the closed code I have found in the javascript URL1

searchWidget=OO.ui.infuse($('#searchText'))

https://gerrit.wikimedia.org/g/mediawiki/core/+/04956b4349513f8072dc803586533aa39f6c9938/resources/src/mediawiki.special.search/search.js#24

Tue, Apr 20, 10:30 PM · JavaScript, MediaWiki-Search, Discovery, Discovery-Search, Wikimedia-production-error
Umherirrender added a comment to T278635: composer test command cleanup where they use `composer foo`.

Without spaces to work for me:

		"test": [
			"@lint",
			"@phpcs",
			"minus-x check ."
		],
Tue, Apr 20, 10:19 PM · LibUp
Umherirrender updated subscribers of T279409: [8h] Logspam about an "ignored error" in Wikibase\Repo\Content\DataUpdateAdapter::doUpdate.
Tue, Apr 20, 7:29 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wdwb-tech, Wikidata, Wikimedia-production-error
Umherirrender added a project to T279321: TypeError: Cannot read property 'isWrapped' of null in shallowCloneFromRange: JavaScript.
Tue, Apr 20, 7:27 PM · JavaScript, VisualEditor, Wikimedia-production-error
Umherirrender added a comment to T277331: Widget not found error on pages I don't have permission to access.

Also occurs on action=delete and Special:GlobalPreferences presumably for other reasons.

Tue, Apr 20, 7:26 PM · MediaWiki-User-preferences, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Readers-Web-Backlog (Tracking), MediaWiki-extensions-GlobalPreferences, MediaWiki-Interface (actions), Community-Tech, Wikimedia-production-error, MassMessage

Mon, Apr 19

Umherirrender created T280590: Special:ImportFile does not check permissions from own config FileImporterRequiredRight.
Mon, Apr 19, 7:59 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2021-04-28, Move-Files-To-Commons, Security, Security-Team
Umherirrender added a comment to T280438: libup committed and uploaded an upgrade twice for the same package on the same repo.

I am not sure if that race condition is tracked by the moved code.

Mon, Apr 19, 7:01 PM · Patch-For-Review, LibUp

Sun, Apr 18

Umherirrender added a comment to T273354: Set $status->value in EditFilterMergedContentHookConstraint::checkConstraint() properly to display error message.

In Change 680687, @Umherirrender wrote:
Returning false with that value acts the same as returning true with a fatal Status?

Why this change? What does this change fix? Is there an error with the hook to fix?

If this is for the deprecation of the fatal Status usage here, that should be done with a deprecation cycles.

@Umherirrender, I noticed that you commented on Change 680687 before here (in the order of emails)?

  1. Not only "that value", but also any customized status value can work to display error message properly on mediawiki version 1.36 and before. Not required to set the value now, just for backward compatibility.
  2. Changes related to T280312 are aim to display error message to user properly, maybe I didn't explain it clearly in commit message.
  3. These changes could fix T271037 indirectly though, but I think the core should be fixed too.
  4. I think the deprecation cycles is too tough for me, I just mentioned it once above but get no reply (T273354#6806753).
Sun, Apr 18, 7:44 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MediaWiki-Core-Hooks, MediaWiki-Page-editing
Umherirrender committed rEWTL5620ae5da824: Cleanup related to the PHPCS (authored by Kizule).
Cleanup related to the PHPCS
Sun, Apr 18, 7:04 PM

Sat, Apr 17

Umherirrender added a comment to T273354: Set $status->value in EditFilterMergedContentHookConstraint::checkConstraint() properly to display error message.

Some extensions running this hook (not using it) - https://codesearch.wmcloud.org/search/?q=%27EditFilterMergedContent%27&i=nope&files=&excludeFiles=&repos=

Sat, Apr 17, 10:54 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MediaWiki-Core-Hooks, MediaWiki-Page-editing
Umherirrender added a comment to T277434: LibUp: "None: None → None" in commit messages.

Again - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventLogging/+/680607

Sat, Apr 17, 10:19 AM · LibUp
Umherirrender created T280438: libup committed and uploaded an upgrade twice for the same package on the same repo.
Sat, Apr 17, 10:07 AM · Patch-For-Review, LibUp

Fri, Apr 16

Umherirrender closed T190817: Getting Call to a member function on null in Extension:GlobalContributions as Resolved.
Fri, Apr 16, 8:17 PM · Patch-For-Review, MediaWiki-extensions-Other
Umherirrender committed rEBKK4fb441904943: build: Run grunt-banana-checker (authored by Umherirrender).
build: Run grunt-banana-checker
Fri, Apr 16, 6:47 AM

Thu, Apr 15

Umherirrender committed rEFLI24c0a2851794: Remove actor arg from UserIdentityValue in FileRevisionFromRemoteUrl (authored by Umherirrender).
Remove actor arg from UserIdentityValue in FileRevisionFromRemoteUrl
Thu, Apr 15, 10:58 PM
Umherirrender committed rEFLIf176f0e297fd: Set empty hook handlers on ExtensionRegistry for testing (authored by Umherirrender).
Set empty hook handlers on ExtensionRegistry for testing
Thu, Apr 15, 10:58 PM
Umherirrender closed T275292: LibUp hasn't successfully run on AutoCreateCategoryPages for 7 weeks as Resolved.

There is a run today - https://libraryupgrader2.wmcloud.org/logs2/228424

Thu, Apr 15, 9:11 PM · LibUp
Umherirrender closed T182546: Require indentation of CASE statements in PHP code as Resolved.

Do we need the following error? I will upload a patch set with the fixes for core to have a look at

Thanks; it looks a little ugly, but I appreciate it.

20:46:30 FILE: /src/includes/poolcounter/PoolCounterWork.php
20:46:30 ----------------------------------------------------------------------
20:46:30 FOUND 1 ERROR AFFECTING 1 LINE
20:46:30 ----------------------------------------------------------------------
20:46:30  160 | ERROR | There must be a comment when fall-through is
20:46:30      |       | intentional in a non-empty case body
20:46:30      |       | (PSR2.ControlStructures.SwitchDeclaration.TerminatingComment)
20:46:30 ----------------------------------------------------------------------

In general, yes.

Thu, Apr 15, 7:28 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.35-notes, Patch-For-Review, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), MediaWiki-Codesniffer
Umherirrender committed rEAKLd0ce1010210e: build: Add grunt-banana-checker (authored by Umherirrender).
build: Add grunt-banana-checker
Thu, Apr 15, 6:27 PM
Umherirrender committed rEWTL8e72d587972b: build: Do not require extension in composer which is in gerrit (authored by Umherirrender).
build: Do not require extension in composer which is in gerrit
Thu, Apr 15, 5:58 PM