Mon, Nov 19

Umherirrender committed rENUAC9d6380edbf01: Add missing @covers tag (authored by Zoranzoki21).

Add missing @covers tag

Mon, Nov 19, 7:17 PM

Fri, Nov 16

Umherirrender updated the task description for T209724: parser tests in DynamicPageList.tests.txt failing for intersection extension.

Fri, Nov 16, 7:59 PM · DynamicPageList (Wikimedia)

Umherirrender created T209724: parser tests in DynamicPageList.tests.txt failing for intersection extension.

Fri, Nov 16, 7:59 PM · DynamicPageList (Wikimedia)

Nov 15 2018

Umherirrender closed T203418: Libraryupgrader ignores phpcs properties as Resolved.

Works - https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Arrays/+/473354/

Nov 15 2018, 8:15 PM · MediaWiki-extensions-Arrays, VPS-project-libraryupgrader, MediaWiki-extensions-Variables

Umherirrender closed T209552: FlaggedRevs causes unbounded growth of ParserCache objects as Resolved.

Nice catch. Thanks for the patch set

Nov 15 2018, 7:44 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Regression, Patch-For-Review, MediaWiki-extensions-FlaggedRevs

Umherirrender added a comment to T209394: Enforce usage of phpdoc's @api and @internal tags to indicate public and private structural elements.

When adding annotation to an interface it also apply to the implemented function in classes implementing this interface? Same for abstract functions?

Nov 15 2018, 6:13 PM · MediaWiki-Codesniffer, MediaWiki-General-or-Unknown

Umherirrender renamed T209614: SpecialPageFatalTest::testSpecialPageDoesNotFatal is risky in Collection extension from Collection extensions has unstable php7 tests in gate-and-submit to SpecialPageFatalTest::testSpecialPageDoesNotFatal is risky in Collection extension.

Nov 15 2018, 6:02 PM · Electron-PDFs, Wikimedia-production-error (Shared Build Failure), Collection

Umherirrender created T209614: SpecialPageFatalTest::testSpecialPageDoesNotFatal is risky in Collection extension.

Nov 15 2018, 5:59 PM · Electron-PDFs, Wikimedia-production-error (Shared Build Failure), Collection

Umherirrender added a comment to T209486: PHP Codesniffer errors and warnings misleading(?).

The comment must placed directly before the class to be a class comment.
A comment not before the class are file comments and in a file comment the annoation is useless, because phpunit does not read it.

Nov 15 2018, 5:44 PM · MediaWiki-Codesniffer

Nov 12 2018

Umherirrender added a comment to T208253: [Wikibase] Update wikibase/wikibase-codesniffer to ^0.5.0/0.5.1.

In T208253#4738720, @hashar wrote:

I am assuming the codesniffer update fixed the php 7.3 issue.

Nov 12 2018, 6:45 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), wikidata-tech-focus, Patch-For-Review, Wikidata, PHP 7.3 support

Nov 11 2018

Umherirrender closed T203980: Disallow use of @private and @protected using MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation as Declined.

Nov 11 2018, 8:33 PM · Patch-For-Review, MediaWiki-Codesniffer

Nov 10 2018

Umherirrender committed rEGRE609a4e7738e8: Add phan-taint-check-plugin (authored by Umherirrender).

Add phan-taint-check-plugin

Nov 10 2018, 12:34 PM

Umherirrender added a comment to T209212: Postmerge test failure investigation.

The extension does not have phpunit tests yet, so there is nothing with @cover tags to publish in the postmerge job

Nov 10 2018, 12:24 PM · Growth-Team, Jenkins, MediaWiki-extensions-GrowthExperiments

Umherirrender added a comment to T208253: [Wikibase] Update wikibase/wikibase-codesniffer to ^0.5.0/0.5.1.

In T208253#4705596, @hashar wrote:

In T208253#4703946, @D3r1ck01 wrote:

@hashar, loots of errors & warnings now: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/22738/console, my system doesn't run PHP 7.3 :( Maybe someone can take it from here? Invoking @Legoktm maybe?

I guess those errors are related to new rules added by codesniffer.
Legoktm stated on T208234 that mediawiki code sniffer 19+ does get support for PHP7.3. So we can trust his word and just assume it will be fixed. That can be checked in CI though by commenting check experimental on the change, that runs jobs using PHP7.3 (among other jobs).