Umherirrender (Umherirrender)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 2:31 PM (227 w, 6 d)
Availability
Available
LDAP User
Umherirrender
MediaWiki User
Umherirrender [ Global Accounts ]

Recent Activity

Sat, Feb 16

Umherirrender committed rEGQL6cc08551e2a6: Avoid Closure::fromCallable from php71 (authored by Umherirrender).
Avoid Closure::fromCallable from php71
Sat, Feb 16, 7:52 PM
Umherirrender committed rEGQL61039972ade6: Avoid Closure::fromCallable from php71 (authored by Umherirrender).
Avoid Closure::fromCallable from php71
Sat, Feb 16, 7:52 PM
Umherirrender committed rEWCS75d38e8919a5: Use tabs for indent in json files (authored by Umherirrender).
Use tabs for indent in json files
Sat, Feb 16, 7:05 PM
Umherirrender committed rEGQLb356a4af946f: Avoid Closure::fromCallable from php71 (authored by Umherirrender).
Avoid Closure::fromCallable from php71
Sat, Feb 16, 6:32 PM
Umherirrender committed rEGQL304e2130ee34: Add missing special page alias (authored by Umherirrender).
Add missing special page alias
Sat, Feb 16, 6:00 PM
Umherirrender committed rEPSd37eca148781: build: Set private: true in package.json (authored by Umherirrender).
build: Set private: true in package.json
Sat, Feb 16, 3:26 PM
Umherirrender committed rEIDS10ff7ae76dec: build: Set private: true in package.json (authored by Umherirrender).
build: Set private: true in package.json
Sat, Feb 16, 3:15 PM
Umherirrender committed rEJAD834e8cf4a3ad: build: Set private: true in package.json (authored by Umherirrender).
build: Set private: true in package.json
Sat, Feb 16, 3:00 PM
Umherirrender committed rERSL8dc39ccf8600: build: Set private: true in package.json (authored by Umherirrender).
build: Set private: true in package.json
Sat, Feb 16, 2:54 PM
Umherirrender committed rEPFM5a02df4f59d1: build: Set private: true in package.json (authored by Umherirrender).
build: Set private: true in package.json
Sat, Feb 16, 2:27 PM
Umherirrender committed rEGQLb5075134c653: Consistency fixes in preparation for translatewiki.net (authored by Raymond).
Consistency fixes in preparation for translatewiki.net
Sat, Feb 16, 2:18 PM
Umherirrender committed rEGQL08b94a38cbff: Consistency fixes in preparation for translatewiki.net (authored by Raymond).
Consistency fixes in preparation for translatewiki.net
Sat, Feb 16, 2:08 PM
Umherirrender committed rEGQL6b10fb52f1e0: Consistency fixes in preparation for translatewiki.net (authored by Raymond).
Consistency fixes in preparation for translatewiki.net
Sat, Feb 16, 2:02 PM

Fri, Feb 15

Umherirrender closed T216276: Error at package.json of MassMessage extension as Resolved.

No other extensions have this problem, there have a boolean there.

Fri, Feb 15, 10:13 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, User-Zoranzoki21, MassMessage
Umherirrender added a comment to T208691: Fatal exception from ApiQueryBase: Call to getNamespace() on non-object null.

Yah, it needs to be "with continue=". The api returns in most cases the requested limit and a continue or less than the limit and no continue. I know some modules, which have a hint, that there can return less pages. But I was unsure if that was required or not. But it is okay for me, when it is up to the maintainer.

Fri, Feb 15, 8:17 PM · Core Platform Team Backlog (Watching / External), PageViewInfo, MediaWiki-API, Wikimedia-production-error
Umherirrender committed rESTB2cb1faff8bb9: Use tabs for json indent in extension.json (authored by Umherirrender).
Use tabs for json indent in extension.json
Fri, Feb 15, 7:29 PM
Umherirrender committed rEGQLa5d338d0fd4f: Add missing special page alias (authored by Umherirrender).
Add missing special page alias
Fri, Feb 15, 7:24 PM
Umherirrender committed rEMDOb7e2ad3d5b28: Fix json indent in extension.json (authored by Umherirrender).
Fix json indent in extension.json
Fri, Feb 15, 7:13 PM
Umherirrender committed rESTB3afe3fb8cdb9: build: Add php-parallel-lint, MinusX and banana-checker (authored by Umherirrender).
build: Add php-parallel-lint, MinusX and banana-checker
Fri, Feb 15, 7:09 PM
Umherirrender committed rEWCSe5e4cfb637fc: build: Add banana-checker (authored by Umherirrender).
build: Add banana-checker
Fri, Feb 15, 7:04 PM
Umherirrender committed rEWCS685c51d57516: build: Add banana-checker (authored by Umherirrender).
build: Add banana-checker
Fri, Feb 15, 7:04 PM
Umherirrender updated subscribers of T208691: Fatal exception from ApiQueryBase: Call to getNamespace() on non-object null.

Change 489929 merged by jenkins-bot:
[mediawiki/extensions/PageViewInfo@master] Skip invalid titles from pageview API in ApiQueryMostViewed

https://gerrit.wikimedia.org/r/489929

Fri, Feb 15, 6:51 PM · Core Platform Team Backlog (Watching / External), PageViewInfo, MediaWiki-API, Wikimedia-production-error
Umherirrender closed T208544: SpecialDeletedContributions emits PHP error "Undefined index: deletedcontribs" as Resolved.
Fri, Feb 15, 6:46 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Growth-Team, MediaWiki-Special-pages, Wikimedia-production-error
Umherirrender committed rEGQL4f6516ddf49d: build: Add MinusX and banana-checker (authored by Umherirrender).
build: Add MinusX and banana-checker
Fri, Feb 15, 6:40 PM
Umherirrender committed rEGQLb7797f7f7a56: build: Add MinusX and banana-checker (authored by Umherirrender).
build: Add MinusX and banana-checker
Fri, Feb 15, 4:45 PM
Umherirrender created T216254: taint-check does not checks undeclared class properties.
Fri, Feb 15, 4:39 PM · phan-taint-check-plugin

Sat, Feb 9

Umherirrender added a comment to T215635: Run refreshImageMetadata.php for new media type of DjVu files.

Thanks. Will wait for the next regular run to get new stats on https://commons.wikimedia.org/wiki/Special:MediaStatistics

Sat, Feb 9, 10:41 PM · SDC Engineering, Wikimedia-maintenance-script-run, Multimedia
Umherirrender committed rEGQL763fc966cb96: build: Add MinusX and banana-checker (authored by Umherirrender).
build: Add MinusX and banana-checker
Sat, Feb 9, 10:08 PM
Umherirrender committed rESTBdc2acb0da02e: build: Add php-parallel-lint, MinusX and banana-checker (authored by Umherirrender).
build: Add php-parallel-lint, MinusX and banana-checker
Sat, Feb 9, 9:51 PM
Umherirrender committed rEWCSa13a09f8a754: Add banana-checker (authored by Umherirrender).
Add banana-checker
Sat, Feb 9, 9:51 PM

Fri, Feb 8

Umherirrender placed T215635: Run refreshImageMetadata.php for new media type of DjVu files up for grabs.
Fri, Feb 8, 5:48 PM · SDC Engineering, Wikimedia-maintenance-script-run, Multimedia
Umherirrender added a comment to T215632: UploadStash should use a valid regex.

It seems the fix already backported to REL1_31

Fri, Feb 8, 5:18 PM · MW-1.31-release-notes, Patch-For-Review, MediaWiki-Debian, MediaWiki-Releasing, PHP 7.3 support, MW-1.31-release
Umherirrender added a comment to T215632: UploadStash should use a valid regex.

Your copy of KEY_FORMAT_REGEX includes an escaped -, your php example does not use a escaped -

Fri, Feb 8, 5:17 PM · MW-1.31-release-notes, Patch-For-Review, MediaWiki-Debian, MediaWiki-Releasing, PHP 7.3 support, MW-1.31-release
Umherirrender updated subscribers of T215219: [Extension:WikimediaEvents] CI is broken.

A workaround exists: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaEvents/+/489140/

Fri, Feb 8, 5:13 PM · Wikimedia-production-error (Shared Build Failure), MediaWiki-extensions-WikimediaEvents
Umherirrender added a comment to T212852: Index DjVu files as OFFICE instead of BITMAP?.

Confirmed that newly uploaded DjVu files are indexed as office. Will keep this ticket open for a bit longer while we see if Cirrus does reindex old files properly.

Fri, Feb 8, 5:04 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), SDC Engineering, Multimedia
Umherirrender triaged T215635: Run refreshImageMetadata.php for new media type of DjVu files as Normal priority.
Fri, Feb 8, 5:03 PM · SDC Engineering, Wikimedia-maintenance-script-run, Multimedia

Thu, Feb 7

Umherirrender created T215545: libraryupgrader sometimes doing unneeded changes with empty rule tag in .phpcs.xml.
Thu, Feb 7, 7:37 PM · VPS-project-libraryupgrader
Umherirrender added a project to T215219: [Extension:WikimediaEvents] CI is broken: Wikimedia-production-error (Shared Build Failure).

This affects TorBlock, which is wmf deployed.

Thu, Feb 7, 6:17 PM · Wikimedia-production-error (Shared Build Failure), MediaWiki-extensions-WikimediaEvents
Umherirrender added a comment to T215484: Unable to get page redirect targets when using list=allpages.

Have you try prop=redirect? Your linked doc is for the case to resolve redirect, that means going from redirect to page. Try the the other way, going from page to all its redirects (0..N)

Thu, Feb 7, 6:12 PM · MediaWiki-API
Umherirrender added a comment to T215219: [Extension:WikimediaEvents] CI is broken.

Also broken on PronunciationRecording:
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/33879/console

Thu, Feb 7, 4:26 AM · Wikimedia-production-error (Shared Build Failure), MediaWiki-extensions-WikimediaEvents
Umherirrender committed rERLSa49c59e34b79: build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
Thu, Feb 7, 4:15 AM

Wed, Feb 6

Umherirrender created T215460: npm is failing with eslint on Kartographer extension.
Wed, Feb 6, 8:53 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Maps (Kartographer)
Umherirrender created T215459: Unit tests of Jade extensions failing.
Wed, Feb 6, 8:36 PM · Jade
Umherirrender updated the task description for T215452: Unit tests of Arrays extensions are failing with Invalid static property access.
Wed, Feb 6, 7:10 PM · MediaWiki-extensions-Loops, MediaWiki-extensions-Arrays
Umherirrender created T215452: Unit tests of Arrays extensions are failing with Invalid static property access.
Wed, Feb 6, 7:09 PM · MediaWiki-extensions-Loops, MediaWiki-extensions-Arrays
Umherirrender committed rEGNEdc24c2c5f11a: build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
Wed, Feb 6, 6:47 PM
Umherirrender committed rEDTB26fc3e47b05a: build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
Wed, Feb 6, 6:43 PM
Umherirrender committed rECOS645883214134: build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
Wed, Feb 6, 6:30 PM
Umherirrender committed rEBUBc09e4d2ce0b0: build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 24.0.0
Wed, Feb 6, 6:19 PM

Tue, Feb 5

Umherirrender added a comment to T215144: Enforce @covers… tags to have full qualified class names starting with backslash.

So a patch set is needed to validate @covers on class and function level and it have to validate @coversDefaultClass on class level and ignore @covers starting with :: on function level

Tue, Feb 5, 6:57 PM · MediaWiki-Codesniffer

Fri, Feb 1

D3r1ck01 awarded T211471: taint-checks for Renameuser failing a Like token.
Fri, Feb 1, 6:14 PM · Patch-For-Review, MediaWiki-extensions-Renameuser, phan-taint-check-plugin
Umherirrender merged T212876: phan-taint-check-plugin failing for Renameuser extension into T211471: taint-checks for Renameuser failing.
Fri, Feb 1, 6:08 PM · Patch-For-Review, MediaWiki-extensions-Renameuser, phan-taint-check-plugin
Umherirrender merged task T212876: phan-taint-check-plugin failing for Renameuser extension into T211471: taint-checks for Renameuser failing.
Fri, Feb 1, 6:08 PM · MediaWiki-extensions-Renameuser, phan-taint-check-plugin

Thu, Jan 31

matej_suchanek awarded T200679: Add sniff to prevent using config globals when Config is available a Yellow Medal token.
Thu, Jan 31, 12:36 PM · Patch-For-Review, MediaWiki-Codesniffer

Wed, Jan 30

Umherirrender closed T200679: Add sniff to prevent using config globals when Config is available as Resolved.
Wed, Jan 30, 8:24 PM · Patch-For-Review, MediaWiki-Codesniffer
Umherirrender closed T203800: Add sniff to replace !! by explicit boolean cast (bool) as Resolved.
Wed, Jan 30, 6:11 PM · Patch-For-Review, MediaWiki-Codesniffer
Umherirrender closed T209486: PHP Codesniffer errors and warnings misleading for phpunitannotations sniff as Resolved.
Wed, Jan 30, 6:11 PM · Patch-For-Review, MediaWiki-Codesniffer

Mon, Jan 28

Umherirrender added a comment to T214823: Make <style> an inline element.

Thanks for the feedback

Mon, Jan 28, 7:47 PM · RemexHtml
Umherirrender merged T214823: Make <style> an inline element into T208901: TemplateStyles breaks a paragraph if a file is inserted inline.
Mon, Jan 28, 7:46 PM · Patch-For-Review, Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Parsoid, TemplateStyles, MediaWiki-Parser
Umherirrender merged task T214823: Make <style> an inline element into T208901: TemplateStyles breaks a paragraph if a file is inserted inline.
Mon, Jan 28, 7:46 PM · RemexHtml
Umherirrender added a comment to T214823: Make <style> an inline element.

Sounds similar to T208901, but I am not sure

Mon, Jan 28, 6:56 PM · RemexHtml
Umherirrender removed projects from T214761: Unit test Wikibase\Test\ClientDefaultsTest::testDefaults is flaky on MW Jenkins jobs: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review.
Mon, Jan 28, 6:33 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Wikidata, MediaWiki-extensions-WikibaseClient, Wikimedia-production-error (Shared Build Failure)

Sat, Jan 26

Umherirrender added a comment to T214761: Unit test Wikibase\Test\ClientDefaultsTest::testDefaults is flaky on MW Jenkins jobs.

It also fails on CheckUser, so this can affect the whole gate

Sat, Jan 26, 7:57 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Wikidata, MediaWiki-extensions-WikibaseClient, Wikimedia-production-error (Shared Build Failure)
Umherirrender created T214761: Unit test Wikibase\Test\ClientDefaultsTest::testDefaults is flaky on MW Jenkins jobs.
Sat, Jan 26, 12:16 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Wikidata, MediaWiki-extensions-WikibaseClient, Wikimedia-production-error (Shared Build Failure)

Fri, Jan 25

Umherirrender committed rEFILEEXPORTb5cb01dace32: build: Remove duplicate in .gitignore (authored by Umherirrender).
build: Remove duplicate in .gitignore
Fri, Jan 25, 8:07 PM
Umherirrender added a comment to T214652: Resort composer.json scripts.fix so minus-x fix comes before phpcbf.

I am not sure, if there could be more tools in the futher with this exit codes.
Maybe a wrapper script can reset the unwanted exit codes.
Upstream does not change this (I have read that month ago in a issue or so)

Fri, Jan 25, 3:18 PM · VPS-project-libraryupgrader, MediaWiki-extensions-General

Thu, Jan 24

Umherirrender added a comment to T214580: Add a behaviour switch to exclude MassMessage from some pages.

Okay, that information was missing for me in the task description.

Thu, Jan 24, 7:09 PM · WorkType-NewFunctionality, MassMessage
Umherirrender added a comment to T214565: Pages that autofill the username of an account get cut off with usernames that contain '?' within it.

MediaWiki is encoding the ? to %3F when using it in forms.

Thu, Jan 24, 6:53 PM · MediaWiki-Special-pages, MediaWiki-General-or-Unknown
Umherirrender added a comment to T214580: Add a behaviour switch to exclude MassMessage from some pages.

"The MassMessage extension allows a user to send a message to a list of pages via special page Special:MassMessage"

Thu, Jan 24, 6:43 PM · WorkType-NewFunctionality, MassMessage
Umherirrender closed T214595: Enable Gadgets tab in preferences of atj.wp as Invalid.

According to https://atj.wikipedia.org/wiki/Kotakahi:Version the extension is installed.

Thu, Jan 24, 6:37 PM · Wikimedia-Site-requests
Umherirrender added a comment to T214591: MediaWiki Codesniffer not catching irrelevant characters after PHPDoc return types.

It is looking for punctations (regex class \p{P} which include \ when looking at https://www.fileformat.info/info/unicode/category/Po/list.htm

Thu, Jan 24, 6:25 PM · good first bug, MediaWiki-Codesniffer

Tue, Jan 22

Umherirrender added a comment to T174339: Allow use of phan 0.8.5+ in wikimedia CI.

For mediawiki-codesniffer the upstream version is always bundled with a new version. That is needed to install it correctly with composer.

Tue, Jan 22, 9:25 PM · Patch-For-Review, User-Addshore, Continuous-Integration-Config
Umherirrender added a comment to T214397: Gerrit: reviewers-by-blame plugin improvements.

I support "Get reviewers based on paste code-reviews votes"
Use Code-Review+1/+2/-1/-2 to find new reviewers, because that would let people review the code and repository which already does it. Using git blame and searching for authors must not find people able to merge patch sets. With the Code-Review that is possible.

Tue, Jan 22, 9:18 PM · Release-Engineering-Team, Gerrit

Mon, Jan 21

Umherirrender renamed T214332: Enable Squiz.ControlStructures.ForLoopDeclaration/ForEachLoopDeclaration sniff from Enable Squiz.ControlStructures.ForLoopDeclaration sniff to Enable Squiz.ControlStructures.ForLoopDeclaration/ForEachLoopDeclaration sniff.
Mon, Jan 21, 8:59 PM · Upstream, MediaWiki-Codesniffer
Umherirrender added a project to T214332: Enable Squiz.ControlStructures.ForLoopDeclaration/ForEachLoopDeclaration sniff: Upstream.
Mon, Jan 21, 8:56 PM · Upstream, MediaWiki-Codesniffer
Umherirrender changed the status of T214332: Enable Squiz.ControlStructures.ForLoopDeclaration/ForEachLoopDeclaration sniff from Open to Stalled.
Mon, Jan 21, 8:56 PM · Upstream, MediaWiki-Codesniffer
Umherirrender created T214332: Enable Squiz.ControlStructures.ForLoopDeclaration/ForEachLoopDeclaration sniff.
Mon, Jan 21, 8:55 PM · Upstream, MediaWiki-Codesniffer

Jan 18 2019

Umherirrender committed rEWSO660088f3ae86: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces (authored by Umherirrender).
Require MediaWiki 1.31 in extension.json for AutoloadNamespaces
Jan 18 2019, 5:27 PM

Jan 16 2019

Umherirrender merged task T213886: PHP Fatal error: Class SphinxMWSearch contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods into T213675: SphinxSearch Extension incompatible with MediaWiki 1.32 due to missing abstract methods.
Jan 16 2019, 7:49 PM · MediaWiki-extensions-SphinxSearch
Umherirrender merged T213886: PHP Fatal error: Class SphinxMWSearch contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods into T213675: SphinxSearch Extension incompatible with MediaWiki 1.32 due to missing abstract methods.
Jan 16 2019, 7:49 PM · MediaWiki-extensions-SphinxSearch
Umherirrender added a comment to T179229: Decide whether we want the package-lock.json to commit or ignore.

Just for information: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/483614/

Jan 16 2019, 7:43 PM · Core Platform Team Backlog (Designing), Services (designing), Front-end-Standards-Group, Continuous-Integration-Infrastructure, MediaWiki-extensions-General

Jan 15 2019

Umherirrender closed T209614: SpecialPageFatalTest::testSpecialPageDoesNotFatal is risky in Collection extension as Resolved.
Jan 15 2019, 7:40 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Electron-PDFs, Wikimedia-production-error (Shared Build Failure), Collection

Jan 14 2019

Umherirrender closed T209234: Use of User::setPassword was deprecated in MediaWiki 1.27. as Resolved.
Jan 14 2019, 5:48 PM · Patch-For-Review, Technical-Debt, MediaWiki-extensions-OAuthAuthentication

Jan 11 2019

Umherirrender committed rEJADba044e274bfc: Use RecentChange::getAttribute instead of property access (authored by Umherirrender).
Use RecentChange::getAttribute instead of property access
Jan 11 2019, 7:51 PM
Umherirrender committed rSEXAMPLE5cd7c553915c: Exclude vendor folder from stylelint run (authored by Umherirrender).
Exclude vendor folder from stylelint run
Jan 11 2019, 4:56 PM

Jan 4 2019

Umherirrender added a comment to T202922: Add sniff to remove semicolon after class declaration.

phpcs3.4.0 contains new sniff Generic.CodeAnalysis.EmptyPHPStatement, needs check if that works in this case

Jan 4 2019, 11:03 PM · MediaWiki-Codesniffer
Umherirrender added a comment to T199768: Discourage use of is_null() with PHPCS.

The sniff for review under https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/codesniffer/+/446271/ has a autofix and works pretty well from my point of view.

Jan 4 2019, 10:43 PM · Patch-For-Review, MediaWiki-Codesniffer
Umherirrender committed rECKT99bed55545cb: Add missing return value to SpecialCreateCollaborationHub::onSubmit (authored by Umherirrender).
Add missing return value to SpecialCreateCollaborationHub::onSubmit
Jan 4 2019, 2:49 PM
Umherirrender committed rECKTc77b8f6f51c7: Add missing return value to SpecialCreateCollaborationHub::onSubmit (authored by Umherirrender).
Add missing return value to SpecialCreateCollaborationHub::onSubmit
Jan 4 2019, 2:43 PM
Umherirrender committed rEJADa00eb72e6dff: Improve param docs (authored by Umherirrender).
Improve param docs
Jan 4 2019, 2:25 PM

Jan 3 2019

Umherirrender committed rEWBId2dac80bfb2a: Add missing null to @param (authored by Umherirrender).
Add missing null to @param
Jan 3 2019, 4:14 PM
Umherirrender committed rEWLEa62a860d25e7: Add missing null to @param (authored by Umherirrender).
Add missing null to @param
Jan 3 2019, 4:14 PM
Umherirrender claimed T212846: Sniff UnusedUseStatement does not find all unused use statements.
Jan 3 2019, 1:36 PM · Need-volunteer, Patch-For-Review, MediaWiki-Codesniffer
D3r1ck01 awarded T212846: Sniff UnusedUseStatement does not find all unused use statements a Like token.
Jan 3 2019, 11:46 AM · Need-volunteer, Patch-For-Review, MediaWiki-Codesniffer
Umherirrender created T212846: Sniff UnusedUseStatement does not find all unused use statements.
Jan 3 2019, 11:40 AM · Need-volunteer, Patch-For-Review, MediaWiki-Codesniffer

Jan 2 2019

Umherirrender closed T203799: Add sniff to remove space after not operator as Resolved.
Jan 2 2019, 10:45 PM · Patch-For-Review, MediaWiki-Codesniffer
Umherirrender closed T212510: Enable Generic.WhiteSpace.IncrementDecrementSpacing in mediawiki ruleset as Resolved.
Jan 2 2019, 10:34 PM · Patch-For-Review, MediaWiki-Codesniffer
Umherirrender closed T209095: Disallow use of @access using MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation as Resolved.
Jan 2 2019, 10:33 PM · Patch-For-Review, MediaWiki-Codesniffer
Umherirrender committed rEJAD32e4847b6285: Add missing use for JADE\JudgmentTarget (authored by Umherirrender).
Add missing use for JADE\JudgmentTarget
Jan 2 2019, 10:24 PM
Umherirrender added a comment to T212738: Deprecate $wgVersion and move to a constant.

Using a define sounds good to me, but it seems modern code is not using this style. So having a class constant is also a way to do it. I did not prefer any way here.

Jan 2 2019, 9:33 PM · MW-1.33-release, MediaWiki-Configuration, Patch-For-Review, Technical-Debt (Deprecation), MediaWiki-General-or-Unknown