Page MenuHomePhabricator

Umherirrender (Umherirrender)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 2:31 PM (320 w, 4 d)
Availability
Available
LDAP User
Umherirrender
MediaWiki User
Umherirrender [ Global Accounts ]

Recent Activity

Today

Umherirrender added a subtask for T216348: Suppress or fix non-double escape phan-taint-check warnings for MW core: T268920: taint-check 3.1.0 showing more issues from type SecurityCheck-OTHER.
Sat, Nov 28, 5:48 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Security-Team, MediaWiki-Core-Testing, phan-taint-check-plugin
Umherirrender added a parent task for T268920: taint-check 3.1.0 showing more issues from type SecurityCheck-OTHER: T216348: Suppress or fix non-double escape phan-taint-check warnings for MW core.
Sat, Nov 28, 5:48 PM · phan-taint-check-plugin
Umherirrender created T268920: taint-check 3.1.0 showing more issues from type SecurityCheck-OTHER.
Sat, Nov 28, 5:47 PM · phan-taint-check-plugin
Umherirrender closed T258789: Add username to page title of Special:DeletedContributions as Resolved.
Sat, Nov 28, 11:30 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MediaWiki-Special-pages
Umherirrender added a subtask for T216348: Suppress or fix non-double escape phan-taint-check warnings for MW core: T268905: taint-check has trouble for taintedness of unknown array keys and reports possible false positives.
Sat, Nov 28, 1:23 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Security-Team, MediaWiki-Core-Testing, phan-taint-check-plugin
Umherirrender added a parent task for T268905: taint-check has trouble for taintedness of unknown array keys and reports possible false positives: T216348: Suppress or fix non-double escape phan-taint-check warnings for MW core.
Sat, Nov 28, 1:22 AM · Patch-For-Review, phan-taint-check-plugin
Umherirrender renamed T268905: taint-check has trouble for taintedness of unknown array keys and reports possible false positives from taint-check has trouble for taintedness of arrays or array-keys to taint-check has trouble for taintedness of unknown array keys and reports possible false positives.
Sat, Nov 28, 1:21 AM · Patch-For-Review, phan-taint-check-plugin
Umherirrender added a comment to T268905: taint-check has trouble for taintedness of unknown array keys and reports possible false positives.

WebRequest::getRequestId() is using $_SERVER['UNIQUE_ID'] which means the return could contain user input?

Sat, Nov 28, 1:20 AM · Patch-For-Review, phan-taint-check-plugin
Umherirrender added a comment to T216348: Suppress or fix non-double escape phan-taint-check warnings for MW core.

I'd have to investigate, could you please copy these comments to a new task while I take a look?

Sat, Nov 28, 1:17 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Security-Team, MediaWiki-Core-Testing, phan-taint-check-plugin
Umherirrender renamed T268905: taint-check has trouble for taintedness of unknown array keys and reports possible false positives from taint-check has trouble for taintness for arrays to taint-check has trouble for taintedness of arrays or array-keys.
Sat, Nov 28, 1:16 AM · Patch-For-Review, phan-taint-check-plugin
Umherirrender created T268905: taint-check has trouble for taintedness of unknown array keys and reports possible false positives.
Sat, Nov 28, 1:15 AM · Patch-For-Review, phan-taint-check-plugin
Umherirrender added a comment to T216348: Suppress or fix non-double escape phan-taint-check warnings for MW core.
13:49:09 includes/jobqueue/utils/BacklinkJobUtils.php:102 SecurityCheck-SQLInjection Calling method \BacklinkCache::partition() in \BacklinkJobUtils::partitionBacklinkJob that outputs using tainted argument #1 (`$params['table']`). (Caused by: includes/cache/BacklinkCache.php +443) (Caused by: includes/jobqueue/utils/BacklinkJobUtils.php +90)

This could be a false positive: Variable $params has taintedness: YES

The annotation still doesn't print the whole taintedness object. Could you please tryapplying the following hack to vendor/mediawiki/phan-taint-check-plugin/src/SecurityCheckPlugin.php

$msg = "Variable {CODE} has taintedness: {DETAILS}"; // Line 246
echo "\n\n$taint\n\n"; // Add this line

and then re-running phan. It should print the whole shape.

Sat, Nov 28, 1:00 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Security-Team, MediaWiki-Core-Testing, phan-taint-check-plugin

Yesterday

Umherirrender added a comment to T216348: Suppress or fix non-double escape phan-taint-check warnings for MW core.
13:49:09 includes/jobqueue/utils/BacklinkJobUtils.php:102 SecurityCheck-SQLInjection Calling method \BacklinkCache::partition() in \BacklinkJobUtils::partitionBacklinkJob that outputs using tainted argument #1 (`$params['table']`). (Caused by: includes/cache/BacklinkCache.php +443) (Caused by: includes/jobqueue/utils/BacklinkJobUtils.php +90)
Fri, Nov 27, 6:30 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Security-Team, MediaWiki-Core-Testing, phan-taint-check-plugin
Umherirrender added a comment to T268891: taint-check fails on array-plus and assumed int|float type.

Not sure if related, but also related to types:

Fri, Nov 27, 5:08 PM · Patch-For-Review, phan-taint-check-plugin
Umherirrender added a comment to T216348: Suppress or fix non-double escape phan-taint-check warnings for MW core.
13:49:09 includes/GlobalFunctions.php:913 PhanRedundantCondition Redundant attempt to cast $wgDebugRawPage of type true to truthy
13:49:09 includes/GlobalFunctions.php:1310 PhanRedundantCondition Redundant attempt to cast $wgShowHostnames of type true to truthy
13:49:09 includes/user/User.php:316 PhanImpossibleCondition Impossible attempt to cast $wgFullyInitialised of type ?''|?'0'|?0|?0.0|?array{}|?false to truthy
13:49:09 includes/user/User.php:338 PhanImpossibleCondition Impossible attempt to cast $wgFullyInitialised of type ?''|?'0'|?0|?0.0|?array{}|?false to truthy
13:49:09 includes/user/User.php:494 PhanImpossibleCondition Impossible attempt to cast $wgFullyInitialised of type ?''|?'0'|?0|?0.0|?array{}|?false to truthy
13:49:09 includes/user/User.php:775 UnusedPluginSuppression Plugin BuiltinSuppressionPlugin suppresses issue PhanImpossibleCondition on this line but this suppression is unused or suppressed elsewhere
13:49:09 includes/user/User.php:824 UnusedPluginSuppression Plugin BuiltinSuppressionPlugin suppresses issue PhanRedundantCondition on this line but this suppression is unused or suppressed elsewhere
13:49:09 includes/user/User.php:1489 PhanImpossibleCondition Impossible attempt to cast $wgFullyInitialised of type ?''|?'0'|?0|?0.0|?array{}|?false to truthy
Fri, Nov 27, 4:54 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Security-Team, MediaWiki-Core-Testing, phan-taint-check-plugin
Umherirrender added a subtask for T216348: Suppress or fix non-double escape phan-taint-check warnings for MW core: T268891: taint-check fails on array-plus and assumed int|float type.
Fri, Nov 27, 4:32 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Security-Team, MediaWiki-Core-Testing, phan-taint-check-plugin
Umherirrender added a parent task for T268891: taint-check fails on array-plus and assumed int|float type: T216348: Suppress or fix non-double escape phan-taint-check warnings for MW core.
Fri, Nov 27, 4:32 PM · Patch-For-Review, phan-taint-check-plugin
Umherirrender added a comment to T268890: Some Wikibase API tests fail if Instant Commons is enabled.

That possible could be set to false for all tests in core, because it always triggers https connection.

Fri, Nov 27, 4:22 PM · wdwb-tech-focus, Wikidata
Umherirrender created T268891: taint-check fails on array-plus and assumed int|float type.
Fri, Nov 27, 4:20 PM · Patch-For-Review, phan-taint-check-plugin
Umherirrender added a comment to T250170: Upgrade to phan/phan 3.2.3 or later in mediawiki/tools/phan.

This is about phan in the config, not in taint-check (even there are bundled)

Oh, right, done.

On update should be suppressed

  • PhanParamNameIndicatingUnused
  • PhanParamNameIndicatingUnusedInClosure
  • PhanProvidingUnusedParameter

I see that indeed, there are many instances of this issues on core. Unsure if we should suppress it in the base config file, perhaps suppressing in core's config.php would be a better choice.

Fri, Nov 27, 4:09 PM · Patch-For-Review, phan-taint-check-plugin, phan
Umherirrender reopened T250170: Upgrade to phan/phan 3.2.3 or later in mediawiki/tools/phan as "Open".

This is about phan in the config, not in taint-check (even there are bundled)

Fri, Nov 27, 3:20 PM · Patch-For-Review, phan-taint-check-plugin, phan

Tue, Nov 24

Umherirrender committed rESPR383f2550ec7d: Prepare special page constructor for service injection in core (authored by Umherirrender).
Prepare special page constructor for service injection in core
Tue, Nov 24, 5:41 PM
Umherirrender committed rEPGAe3d20449acdc: Prepare special page constructor for service injection in core (authored by Umherirrender).
Prepare special page constructor for service injection in core
Tue, Nov 24, 5:38 PM
Umherirrender committed rCSSS30c300e2bd46: build: Updating mediawiki/mediawiki-phan-config to 0.10.4 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-phan-config to 0.10.4
Tue, Nov 24, 5:31 PM

Mon, Nov 23

Umherirrender committed R1893:2944efbb5dba: build: Updating mediawiki/mediawiki-phan-config to 0.10.4 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-phan-config to 0.10.4
Mon, Nov 23, 5:51 PM
Umherirrender closed T268360: captcha error text no longer shown as parsed message on Special:Contact, a subtask of T263186: 1.36.0-wmf.20 deployment blockers, as Resolved.
Mon, Nov 23, 5:24 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Release, Train Deployments
Umherirrender closed T268360: captcha error text no longer shown as parsed message on Special:Contact as Resolved.
Mon, Nov 23, 5:24 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MediaWiki-extensions-ContactPage
Umherirrender added a comment to T14019: ifexist function uses pagelinks table in lieu of better options.

Indeed, T221795 may also benefit from it. Category counts have at times become inaccurate (see T224321) and the blame has been put on issues with cache invalidation. Having a distinctive mechanism for tracking page dependency and cache invalidation could help resolve that issue.

Mon, Nov 23, 5:05 PM · Community-Wishlist-Survey-2015, ParserFunctions

Sun, Nov 22

Umherirrender committed rECPA581f9145b829: Improve error messages on Special:Contact (authored by Umherirrender).
Improve error messages on Special:Contact
Sun, Nov 22, 6:43 AM

Sat, Nov 21

Umherirrender added a comment to T14019: ifexist function uses pagelinks table in lieu of better options.

Such a feature would also be helpful for core and should be usable by the extensions.

Sat, Nov 21, 8:44 PM · Community-Wishlist-Survey-2015, ParserFunctions

Fri, Nov 20

Umherirrender added a subtask for T263186: 1.36.0-wmf.20 deployment blockers: T268360: captcha error text no longer shown as parsed message on Special:Contact.
Fri, Nov 20, 5:54 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Release, Train Deployments
Umherirrender added a parent task for T268360: captcha error text no longer shown as parsed message on Special:Contact: T263186: 1.36.0-wmf.20 deployment blockers.
Fri, Nov 20, 5:54 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MediaWiki-extensions-ContactPage
Umherirrender created T268360: captcha error text no longer shown as parsed message on Special:Contact.
Fri, Nov 20, 5:52 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MediaWiki-extensions-ContactPage
Umherirrender added a comment to T203210: Extension:RSS shouldn't invent its own way to escape and parse things.

One issue seems fixed with newer taint - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/RSS/+/642406

Fri, Nov 20, 2:55 PM · Security, Security-Team, Technical-Debt, MediaWiki-extensions-RSS
Umherirrender added a comment to T268304: importfailed output is poor when multiple errors.

There is a nowiki around everything, see T245922

Fri, Nov 20, 1:01 PM · MediaWiki-Export-or-Import
Umherirrender added a comment to T155147: Do not initialise the database in tests when not needed.

This can have a big impact, I was playing with it in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/618757

Fri, Nov 20, 12:59 PM · Patch-For-Review, MediaWiki-Core-Testing

Thu, Nov 19

Umherirrender created T268287: Disallow multi class property declaration with code sniff.
Thu, Nov 19, 10:07 PM · MediaWiki-Codesniffer
Umherirrender committed rEBSU92c6fc762bf9: i18n: Use tabs to indent in en.json (authored by Umherirrender).
i18n: Use tabs to indent in en.json
Thu, Nov 19, 8:53 PM
Umherirrender created T268276: Archive the BlueSpiceEditNotifyConnector extension.
Thu, Nov 19, 7:58 PM · BlueSpice, User-Kizule, translatewiki.net, Wikimedia-GitHub, Diffusion-Repository-Administrators, Projects-Cleanup
Umherirrender added a comment to T264949: Move the jsdoc-wmf-theme package on npmjs.org into the wikimedia organisation so that other people can publish it.

Who can do this task? Is there a list of people we could link from here to get attention?

Thu, Nov 19, 7:47 PM · JSDoc WMF theme
Umherirrender added a comment to T268254: Add a list of failing repos or an indicator in lists for failing repos on libup web.

The following repositories have some kind of error (as of now).

Thu, Nov 19, 7:33 PM · LibUp
Umherirrender committed rELSA3cd5e5b09d71: Add metadata to i18n files to pass banana (authored by Umherirrender).
Add metadata to i18n files to pass banana
Thu, Nov 19, 7:24 PM
Umherirrender created T268271: Enable xdebug on libup to run tests for mediawiki/libs/Equivset.
Thu, Nov 19, 7:21 PM · Patch-For-Review, LibUp
Umherirrender added a comment to T268254: Add a list of failing repos or an indicator in lists for failing repos on libup web.

Can you also look at https://libraryupgrader2.wmcloud.org/r/mediawiki/extensions/EventLogging where the web ui crashed?

Thu, Nov 19, 7:19 PM · LibUp
Umherirrender added a comment to T268247: Bug: <noinclude> creates <pre> text, if is put after paragraph.

This looks like T14974

Thu, Nov 19, 6:04 PM · MediaWiki-Parser
Umherirrender added a comment to T268254: Add a list of failing repos or an indicator in lists for failing repos on libup web.

It seems not linked from anywhere or I missed it.
But thanks for the link

Thu, Nov 19, 6:01 PM · LibUp
Umherirrender renamed T268254: Add a list of failing repos or an indicator in lists for failing repos on libup web from Add a list of failing repos on libup web to Add a list of failing repos or an indicator in lists for failing repos on libup web.
Thu, Nov 19, 5:52 PM · LibUp
Umherirrender created T268254: Add a list of failing repos or an indicator in lists for failing repos on libup web.
Thu, Nov 19, 5:50 PM · LibUp

Wed, Nov 18

Umherirrender created T268170: Unit tests without database group can still have access to the database.
Wed, Nov 18, 7:54 PM · MediaWiki-Core-Testing
Umherirrender created T268168: Improve performance of file pages by checking redirect state in "file usage" section in batches.
Wed, Nov 18, 7:46 PM · Patch-For-Review, Performance Issue, MediaWiki-General
Umherirrender created T268166: Special:PagesWithProp could be slow with high limit of pages to show.
Wed, Nov 18, 7:39 PM · Patch-For-Review, Performance Issue, MediaWiki-Special-pages
Umherirrender committed rELSA6e0029489e3c: build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
Wed, Nov 18, 1:32 AM
Umherirrender committed R1985:f340f2313b3f: build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
Wed, Nov 18, 1:07 AM
Umherirrender committed R1985:027f3865f66c: Use assertEqualsWithDelta in unit tests (authored by Umherirrender).
Use assertEqualsWithDelta in unit tests
Wed, Nov 18, 1:07 AM
Umherirrender committed rEFLId7c8bd8c585e: Inject WikiPageFactory into ImportableOldRevisionImporter (authored by Umherirrender).
Inject WikiPageFactory into ImportableOldRevisionImporter
Wed, Nov 18, 12:25 AM
Umherirrender committed rEADL46a87b6d46d3: build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
Wed, Nov 18, 12:21 AM
Umherirrender committed rESNVc3081b018923: build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
Wed, Nov 18, 12:06 AM

Tue, Nov 17

Umherirrender committed rMLZEe55aec12b64e: build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
Tue, Nov 17, 11:35 PM
Umherirrender committed rMTPS6576f02f7e72: build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 (authored by Umherirrender).
build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
Tue, Nov 17, 11:21 PM
Umherirrender added a comment to T268087: False positive MediaWiki.Commenting.PropertyDocumentation.NotPunctuationVarType.

Should be checked as well: MediaWiki.Commenting.FunctionDocumentation.NotPunctuationReturnType/MediaWiki.Commenting.FunctionDocumentation.NotPunctuationParamName

Tue, Nov 17, 11:05 PM · MediaWiki-Codesniffer
Umherirrender created T268087: False positive MediaWiki.Commenting.PropertyDocumentation.NotPunctuationVarType.
Tue, Nov 17, 10:56 PM · MediaWiki-Codesniffer
Umherirrender created T268085: Archive the BlueSpiceBookshelfUI extension.
Tue, Nov 17, 10:38 PM · BlueSpice, translatewiki.net, Wikimedia-GitHub, Diffusion-Repository-Administrators, Projects-Cleanup

Fri, Nov 13

Umherirrender added a comment to T267837: Move in intestactions doesn't pick up if the page is only covered by cascading protection.

Why this needs special handling when Special:MovePage also does not take account of the cascade on inital view?

Fri, Nov 13, 5:51 PM · User-DannyS712, MediaWiki-Page-protection, Platform Engineering, MediaWiki-API

Wed, Nov 11

Umherirrender created T267765: Extension is instance core service ImportableOldRevisionImporter itself, but that is not part of stable policy/interface.
Wed, Nov 11, 10:34 PM · Dependency injection, Move-Files-To-Commons, MediaWiki-Export-or-Import
Umherirrender added a comment to T267565: Add a clone-like feature to copy pages within a MediaWiki installation.

Maybe you want the Extension:InputBox with the preload options. Just type in the new page name and click to have the content preloaded.

Wed, Nov 11, 8:48 PM · MediaWiki-General
Umherirrender added a comment to T267669: MediaWiki 1.36.0-wmf.16 requires php-intl extension.

To be remove: Checks for extension_loaded( 'intl' ) and the phan-stub for intl seems useless as well.

Wed, Nov 11, 8:40 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), MediaWiki-Internationalization, MediaWiki-General

Fri, Nov 6

Umherirrender added a comment to T265348: MediaWiki.Classes.UnsortedUseStatements.UnsortedUse gets confused about top level anonymous function use statements.

Have tested with the new version 33.0.0 and it works. Can you update the patch set to see if it also works with CI?

Fri, Nov 6, 11:53 PM · MediaWiki-Codesniffer
Umherirrender added a comment to T267316: FileImporter throws backend errors on Special:SpecialPages.

Service NullRevisionCreator is using a database connection to DB_MASTER, pass just the load balancer and instance the connection when needed? Special:SpecialPages is supposed to be "read only" and not touching the master

Fri, Nov 6, 11:42 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), WMDE-QWERTY-Sprint-2020-11-04, Unplanned-Sprint-Work, Wikimedia-production-error, WMDE-Technical-Wishes-Maintenance, WMDE-Technical-Wishes-Team
Umherirrender added a comment to T151291: "User::loadFromSession called before the end of Setup.php" warning due to AbuseFilter.

For #2 there was a change with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/622418 to use a message localizer to avoid global state on parse.
For #3 there was a change with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/622415 to use the LinkRenderer from the LogFormatter

Fri, Nov 6, 11:10 PM · Platform Engineering (Icebox), AbuseFilter, Wikimedia-production-error
Umherirrender closed T266741: Please teach PropertyDocumentation sniff about @inheritDoc as Resolved.
Fri, Nov 6, 9:55 PM · MediaWiki-Codesniffer

Thu, Nov 5

Umherirrender committed rEPLL92c026c61117: build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
Thu, Nov 5, 8:23 PM
Umherirrender committed rEPLLd2f00230ad0e: Fix AuthManager creation in test (authored by Umherirrender).
Fix AuthManager creation in test
Thu, Nov 5, 8:23 PM
Umherirrender added a comment to T266739: Autofix for switch indentation adds indentation to the wrong places.
Thu, Nov 5, 8:20 PM · User-DannyS712, MediaWiki-Codesniffer
Umherirrender added a comment to T243220: Create logstash monitoring dashboard for Technical Wishes products.

Should/Could you tag them as Wikimedia-production-error ? Or there are not production errors like the tag handled?

Thu, Nov 5, 4:21 PM · WMDE-QWERTY-Sprint-2020-11-04, WMDE-Technical-Wishes-Maintenance, WMDE-Technical-Wishes-Team
Umherirrender added a comment to T265628: Identify which extensions' tests make HTTP requests and so are now broken post-T262443.

HTTP request blocked: https://onionoo.torproject.org/details?type=relay&running=true&flag=Exit by TorExitNodes::fetchExitNodesFromOnionooServer. Use MockHttpTrait.

What test triggers this error? TorBlock itself doesn't appear to have any tests.

Thu, Nov 5, 4:11 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Platform Team Workboards (Clinic Duty Team), ci-test-error, MediaWiki-extensions-TorBlock, Patch-For-Review, UploadWizard, User-zeljkofilipin
Umherirrender committed rEWIS4db6aac65168: build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
Thu, Nov 5, 12:38 AM

Wed, Nov 4

Umherirrender added a comment to T228911: DBTransactionError "transaction round 'LinksUpdate::doUpdate' still running" (via RunSingleJob.php).

The only place where 'LinksUpdate::doUpdate' is in use is:

Wed, Nov 4, 10:54 PM · Wikimedia-production-error, MediaWiki-Page-derived-data, Performance-Team (Radar), WMF-JobQueue, MediaWiki-JobQueue, Platform Engineering (Icebox)
Umherirrender committed rEWTM3658f189871d: build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
Wed, Nov 4, 10:41 PM
Umherirrender committed rERLSbf619fe92c34: build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
Wed, Nov 4, 10:15 PM
Umherirrender added a comment to T257731: LibUp cannot vote +1 on VisualEditor/VisualEditor and unicodejs.

This can found also patch sets:
https://gerrit.wikimedia.org/r/q/committer:tools.libraryupgrader%2540tools.wmflabs.org+status:merged+-label:Verified%252B1%252Cowner+-label:Code-Review%252B2%252Cowner

Wed, Nov 4, 10:08 PM · Gerrit-Privilege-Requests, LibUp
Umherirrender updated subscribers of T267263: Wikimedia\Rdbms\Database::makeList: empty input for field eps_token.

Empty list from api could be coming since https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/619570 - because IS_MULTI also includes empty list (even when required)

Wed, Nov 4, 9:38 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Product-Infrastructure-Team-Backlog (Kanban), Notifications, Growth-Team, Wikimedia-production-error
Umherirrender added a project to T267267: Banner on German Wikipedia and wikidata.org throwing NS_ERROR_FILE_CORRUPTED: error: JavaScript.
Wed, Nov 4, 9:28 PM · WMDE-FUN-Funban-2020, WMDE-FUN-Team, WMDE-Fundraising-Tech, JavaScript, Wikimedia-production-error, Wikidata
Umherirrender updated subscribers of T267265: Language missing bracket in its name.
Wed, Nov 4, 8:57 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Upstream, I18n, MediaWiki-extensions-CLDR
Umherirrender added projects to T267265: Language missing bracket in its name: MediaWiki-extensions-CLDR, I18n.

Coming from CLDR - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/cldr/+/550965/1/CldrNames/CldrNamesYo.php

Wed, Nov 4, 8:56 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Upstream, I18n, MediaWiki-extensions-CLDR
Umherirrender added a project to T265628: Identify which extensions' tests make HTTP requests and so are now broken post-T262443: ci-test-error.
Wed, Nov 4, 8:25 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Platform Team Workboards (Clinic Duty Team), ci-test-error, MediaWiki-extensions-TorBlock, Patch-For-Review, UploadWizard, User-zeljkofilipin
Umherirrender added a project to T265628: Identify which extensions' tests make HTTP requests and so are now broken post-T262443: MediaWiki-extensions-TorBlock.

HTTP request blocked: https://onionoo.torproject.org/details?type=relay&running=true&flag=Exit by TorExitNodes::fetchExitNodesFromOnionooServer. Use MockHttpTrait.

Wed, Nov 4, 8:23 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Platform Team Workboards (Clinic Duty Team), ci-test-error, MediaWiki-extensions-TorBlock, Patch-For-Review, UploadWizard, User-zeljkofilipin
Umherirrender created T267264: Stop extending PermissionManager service.
Wed, Nov 4, 8:11 PM · MediaWiki-extensions-General, Dependency injection
Umherirrender committed rELUA00fc2c3f1e9a: build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
Wed, Nov 4, 6:23 PM
Umherirrender committed rESPR18cea4ead764: build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
Wed, Nov 4, 5:40 PM
Umherirrender committed rEPFM40de183532b8: build: Updating mediawiki/mediawiki-codesniffer to 33.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 33.0.0
Wed, Nov 4, 5:37 PM
Umherirrender added a comment to T267236: Libup should mention failing eslint rules when adding profiles like wikimedia/mediawiki.

If you need an example: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TocTree/+/639188

Wed, Nov 4, 4:51 PM · LibUp
Umherirrender created T267236: Libup should mention failing eslint rules when adding profiles like wikimedia/mediawiki.
Wed, Nov 4, 4:50 PM · LibUp

Tue, Nov 3

Umherirrender closed T266739: Autofix for switch indentation adds indentation to the wrong places as Resolved.

upstream reported - https://github.com/squizlabs/PHP_CodeSniffer/issues/3157

Tue, Nov 3, 7:25 PM · User-DannyS712, MediaWiki-Codesniffer
Umherirrender removed projects from T254537: UserGroupManager/PermissionManager cyclic dependency: MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Patch-For-Review.
Tue, Nov 3, 7:09 PM · Platform Team Initiatives (Decoupling (CDP2)), Platform Team Workboards (Clinic Duty Team), User-DannyS712, Dependency injection
Umherirrender created T267150: CI job mw-tools-codesniffer-mwcore-testrun fails on clean run.
Tue, Nov 3, 7:07 PM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Config
Umherirrender added a comment to T267112: Implement UUID helper class.

There is a GlobalIdGenerator in core, which could be used for UUIDs

Tue, Nov 3, 2:52 PM · Wikispeech-Jobrunner (Sprint), Wikispeech-WMSE, Wikispeech-Speech-Data-Collector, User-kalle
Umherirrender closed T266871: Forbid use of class ReflectionObject and suggest use of TestingAccessWrapper::newFromObject instead as Declined.

There are too much cases where the use of ReflectionClass is still valid and not possible to replace with TestingAccessWrapper, so just decline the idea to document the fact.

Tue, Nov 3, 9:54 AM · MediaWiki-Codesniffer

Mon, Nov 2

Umherirrender added a comment to T267013: How to replace deprecated User::getTokenFromOption for the watchlisttoken?.

There is also User::resetTokenFromOption, but the function is not deprecated.

Mon, Nov 2, 7:53 PM · MediaWiki-Watchlist, Growth-Team, MediaWiki-User-management, Technical-Debt (Deprecation process)
Umherirrender merged T264624: Backlog of pending translation updates for wikimedia/iegreview.git into T266876: Have a look at failing l10n-bot patch sets on wikimedia/iegreview.
Mon, Nov 2, 6:41 PM · translatewiki.net, I18n, Wikimedia-IEG-grant-review
Umherirrender merged task T264624: Backlog of pending translation updates for wikimedia/iegreview.git into T266876: Have a look at failing l10n-bot patch sets on wikimedia/iegreview.
Mon, Nov 2, 6:41 PM · Wikimedia-IEG-grant-review