In T194585#4607666, @dbarratt wrote:

@Umherirrender I get a true value even if the user is blocked (on master), so this doesn't resolve the use case.

should User::isBlockedFrom be executed from Title::userCan? If not, then another property should be created, or I suppose this property should take both into consideration?

The magic transformation sounds good, because it does not need to fill the cache in each api module, but for a quick win it seems easier to fill the cache in fileusage - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/462122/

The partial block changes have to add some checks to Title::userCan to support namespace or page depending user blocks in all places of mediawiki (like edit tabs in the navigation etc.)

It seems this already works:

It would work when using a Status object inside the code and giving it the language you want when converting to a string

wfEscapeShellArg now calls Shell::escape which is tested

The tiff has 212 pages, mediawiki metadata sees only 199. The page number 1 is missing, therefor the first and second page on the image page is same, because the page with the lowest number (2) is the first page, but when requesting a page per parameter, the page with that number is returned. That results in two pages which are the same

It works for me now.

The url above looks good on beta labs: https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=Special:FilePath&file=Konrad_Alexander_M%25C3%25BCller-Kurzwelly_-_Stornas.jpg

Have not found any english text inside the extension, except some exception text

Having one config file per tool is okay, so having the ignores in .eslintrc.json would be okay.
But I have no idea if eslint supports such a key in the config or is that okay for the concept of that file

Having less files in the root folder is more hygiene than some lines in a file not looking often at, because there are many linters or tools wanting such config files

The special regular expression characters are: . \ + * ? [ ^ ] $ ( ) { } = ! < > | : -
From http://www.php.net/manual/en/function.preg-quote.php

It is not possible to move the User::load( User::READ_LATEST ); and User::saveSettings() near together.

It seems it should only be documented in the sniff and there must stay.
Some @protected have comments about unit tests etc.

It is now failing also for 1.1.0 and blocks merges

In T202386#4569562, @Legoktm wrote:

In T202386#4568801, @Umherirrender wrote:

In T202386#4568661, @Bawolff wrote:

Huh. Currently failing due to:
Package mediawiki/phan-taint-check-plugin at version 1.5.0 has a PHP requirement incompatible with your PHP version (5.6.33)

I suppose that is due to the config line in composer.json that this extension has.

Run taint-check-plugin with --ignore-platform-reqs because it is not used in production?

That was my initial thought, but I'm worried about that causing problems later on. I played around a bit and with some advice from bawolff I got CI to install the plugin in a separate directory so it won't be affected by the extensions' own config. This will also fix the problem of BlueSpice* depending upon ext-tidy, which wasn't installed in the docker container.

It seems Linter, MassMessage and VisualEditor also missed on taint-check update to 1.5.0

There is no LinksUpdate T30876

WikibaseQualityConstraints also missed on update of taint-check to 1.5.0

In T202386#4568661, @Bawolff wrote:

Huh. Currently failing due to:
Package mediawiki/phan-taint-check-plugin at version 1.5.0 has a PHP requirement incompatible with your PHP version (5.6.33)

I suppose that is due to the config line in composer.json that this extension has.

It seems AutoCreateCategoryPages was ignored on codesniffer run - no logs https://libraryupgrader.wmflabs.org/logs/2018-09-02/

In T203800#4566644, @Reedy wrote:

I note we purposely seem to choose this "pattern" for javascript (I guess for less characters)

Would the extension pass the new version 1.5.0?

Maybe fixed with T203583

Sounds like handled in T202457

I am not sure, but the regression could be in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/448190/

PSR2.Classes.ClassDeclaration would detect the issue as PSR2.Classes.ClassDeclaration.CloseBraceSameLine when the closing } is not on a line by itself (except whitespace and comments), but the sniff cannot fix the issue for the semicolon case

I have never seen brackets as delimiter, but it is okay from documentation http://php.net/manual/de/regexp.reference.delimiters.php
and such brackets are already escaped by `preg_quote
`
With codesniffer it is not possible to detect the context of preg_quote, so this needs a phan plugin or the phan-taint-check-plugin needs a new category to check user supplied input to regex. Phan can also see the call in array_map

The expaned sniff does not detect the function at location where callables are allowed:

Fixed by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FlaggedRevs/+/456759/

The code is also used in Gadgets extension.

This could be tricky, because the sniff has to decide between config globals and objects/non-config globals. That means the sniff needs the way to set globals in .phpcs.xml as input for use in extensions. The core list can be found on T159283 and should be hard coded.

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FormWizard/+/456441/

It seems there is no standard sniff for the comma in implements or even a sniff to check for spacing around implements

That is correct, the trait is not used everywhere. It could be enforced with phpcs when a class extends the PHPUnit\Framework\TestCase class. Than the test itself and all tests extends that test class also run the validation of the trait.