Fri, Feb 21
Timestamps are often not the right choose when it is possible to have duplicates of it for different actions from different users (Yes, it is possible to have two edits of one page in the same second, so it could be possible to have two deletion of different revisions in the same second, maybe not very likly to get, but possible).
Maybe phan can do the work better (In my opinion phan can do things with many files involved or dependenies between files, codesniffer is better when only check one file)
Thu, Feb 20
Wed, Feb 19
https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.5.4 contains one fix:
Squiz.ControlStructures.ForLoopDeclaration now has a setting to ignore newline characters
- Default remains FALSE, so newlines are not allowed within for definitions
- Override the ignoreNewlines setting in a ruleset.xml file to change
Tue, Feb 18
Mon, Feb 17
Tue, Feb 11
Sat, Feb 8
It seems the following code does not take function call in account
You could also bring it to the LinkRenderer service as it holds some other Linker class function.
But that maybe include more technical debt, because this function needs the permission manager, the current function of LinkRenderer does not
Fri, Feb 7
Thu, Feb 6
Have found in phan's BlockExitStatusChecker.php:
A similar issue is tracked with T232451 where also a invalid user name is a problem
Wed, Feb 5
Tue, Feb 4
Mon, Feb 3
It seems the user name is not suppressed. Suppression logs and suppression a user are different actions
Sun, Feb 2
Sat, Feb 1
Thu, Jan 30
The export of aliases from translatewiki.net has stopped some ages ago.
Wed, Jan 29
mediawiki/core is using eslint now
Thanks for the explaination, I am happy to see that it now uploads one patch set for both upgrading.
Tue, Jan 28
I just want noted that LogPage::addEntry is an old way to provide log entries on Special:Log.
The new way is direct use of LogFormatter class.
In my opinion there must be no complex actions to avoid global state in that class.
It would be more future proofed (but sometimes more complex) to migrate the extension to the new logging
But when the caller already have a context, than it is okay to avoid the fallback to $wgUser. That are simpel patch sets.
In puppet is mediawiki::maintenance::updatequerypages::ancientpages which is running the update with the override option to get the special page updated.
Mon, Jan 27
MobileFronted also says about differences
karma runs now, thanks for the fix
Sun, Jan 26
MobileFrontend would have the same error, but fails at other location for the moment - https://libraryupgrader2.wmflabs.org/r/mediawiki/extensions/MobileFrontend
On Html2Wiki there is an issue with autofix - T243721 - but I have no idea if that produce the error in the web ui
Sat, Jan 25
Is there an easy way to skip the first parameter in a method call, no matter how complicated the code is?