@Tgr I'm not sure about cases where the request would be mentee-originated (it doesn't necessarily have to be mentor-originated, through). AFAIK the only possible ways to use the API is a) by admins/staff to set mentors arbitrarily [this is what I use when mass-reassigning mentees manually] b) claimmentee-like functionality.

In T273092#7031357, @Urbanecm_WMF wrote:

Hello @CBogen! I would like to put a few notes here about the general feeling i have when testing the image reccomendation system you created

• I mention this for almost every algorithm: you likely dont want disambigs to be considered at all. They are used for stuff like "John Smith", a name that is likely used by multiple notable people. For this article, image of any John Smith would be unsuitable, because it is not displaying the topic at all :). In 99.9% cases, disambigs just should have no image at all
• The tool looks to suggest some images based on word similarity. That leads to funny cases, such as "Vánek" (breeze) vs "Vaněk" (a surname). Those words are very similar, but actually mean different things. There are other word pairs as well - for example, "Vláda" (government) vs "Vláďa" (a name) vs "Vlada" (yet another name). So far, "vánek" vs "vaněk" is the only case that appeared in suggestions.

Im not yet done with the evaluation, so it is possible I will add some more comments as I go through the images.

Hope it helps.

In T281896#7077951, @Trizek-WMF wrote:

@Urbanecm_WMF, can you change the Manual of style link in the help panel?
"How to write a good article" should go to https://en.wikipedia.org/wiki/Help:Introduction_to_the_Manual_of_Style/1

Acknowledged. I think we should wait for this to be moved to "current
sprint" before incorporating anything (plus we might want to use the same
topic set as we use for suggested edits, which IIRC doesn't need any config
on community end).

Yes.

I can confirm this by reading the code, it doesn't have a check for reverted edits AFAICS (Impact::queryArticleEdits never mentions tags or ChangeTags::TAG_REVERTED, which is how you can tell if an edit is reverted).

The Growth's code for sugested edits use the same data as the templatelinks table/search index. You can see the list of recognized templates for a given article by opening it in the edit source mode, scrolling down (below the editor), finding "Pages transcluded onto the current version of this page". Any template that's listed there will be recognized by suggested edits.

...and i actually did this because of the mentor/mentee migration anyway.

@Trizek-WMF The wiki was just pushed to the dark mode.

@Trizek-WMF Wiki was pushed to the dark mode.

In T273092#7057559, @CBogen wrote:

Here are the updated numbers:

327 | ar
560 | bn - DONE
267 | ceb
112 | cs
181 | en
371 | vi

@PPham , @Dyolf77_WMF , and @Urbanecm_WMF , can you let me know how much time you've spent so far? We're supposed to be complete tomorrow, but we can extend if necessary.

In T279853#7051005, @Urbanecm_WMF wrote:

In T279853#7050971, @Tgr wrote:

It would be nice to deploy SCHEMA_COMPAT_NEW before Wednesday as the x1 migration will cause the DB store to be readonly while the pref store is still writable. In theory a readonly error would cause both connections to be rolled back so they would not get out of sync, and in theory even if they do get out sync it shouldn't cause any issue - still, one less potential (if unlikely) source of trouble.

I originally planned to do it last week, but I failed to. The patch should be safe, and I hope to deploy it on Monday or Tuesday.

In T266913#7052970, @Tgr wrote:

I think this has happened everywhere because the tables are part of the createExtensionTables.php script which was run for other reasons, even on existing wikis (T279853: Migrate mentor/mentee relationship to a separate database table on Wikimedia wikis, probably).

In T279853#7050971, @Tgr wrote:

It would be nice to deploy SCHEMA_COMPAT_NEW before Wednesday as the x1 migration will cause the DB store to be readonly while the pref store is still writable. In theory a readonly error would cause both connections to be rolled back so they would not get out of sync, and in theory even if they do get out sync it shouldn't cause any issue - still, one less potential (if unlikely) source of trouble.

This is actually in progress (implementing the rest of the features).

For the record: the tables are being created on new wikis with GrowthExpeirments deployed (as running createExtensionTables.php is a standard part of installing an extension that has database tables). The tables are only needed on the older target wikis.

In T280307#7036035, @MMiller_WMF wrote:

@Urbanecm_WMF @OTichonova -- I don't think we should allow mentors to retire by simply clicking a button unless we also allow them to sign up with some sort of click of a button. And we won't allow that until we make a Special page for signing up mentors (because if you're not a mentor yet, you don't have a mentor dashboard, so there is nowhere to put the button). And in that vein, I think it would be better to have the retirement option located on that special page, where the signup option is, for consistency. So I think we should remove the specification to have the "retire" button on the mentor dashboard, and instead include it on the task for the Special page for signing up mentors.

@Trizek-WMF Sorry, I thought I did share it already. Here you go!

This was done.

In T275773#7026603, @Etonkovidova wrote:

Thanks, @Urbanecm_WMF - marking the task as Resolved.

In T278347#7037339, @LarsWirzenius wrote:

Filed T281229: InvalidArgumentException: GrowthExperiments\Config\WikiPageConfigWriter::getCurrentWikiConfig failed to load config but not yet as a blocker

Note: I deleted MediaWiki:GrowthExperimentsConfig.json from test.wikipedia, which should suppress this error. Once the patch I have for this task will get backported, I'll undo my deletion and make sure the error doesn't happen anymore.

I'll work on this.

In T278347#7037339, @LarsWirzenius wrote:

Filed T281229: InvalidArgumentException: GrowthExperiments\Config\WikiPageConfigWriter::getCurrentWikiConfig failed to load config but not yet as a blocker

On-wiki config: https://bg.wikipedia.org/wiki/%D0%9C%D0%B5%D0%B4%D0%B8%D1%8F%D0%A3%D0%B8%D0%BA%D0%B8:NewcomerTasks.json.

@geraki @Trizek-WMF I just changed elwiki's configuration to have mentorship features enabled, and to use the new help panel links. Let me know if there is anything else I should change!

In T280307#7034024, @Trizek-WMF wrote:

Side comment: retiring permanently as a mentor should be as simple as removing your name from a list.

In T278235#7026748, @Etonkovidova wrote:

Checked with a new account on eswiki. I corrected Special:WelcomeSurvey alias in the task description to Especial:Encuesta_de_bienvenida. I'm moving the task to Test in Production|Watching to monitor it for possible issues/feedback etc.

In T215911#7027621, @Urbanecm_WMF wrote:

In T215911#7027467, @Trizek-WMF wrote:

Will this be included in the next version of the configuration page?

That depends on @Tgr's ability to code-review it. My patch to make it possible should work :).

@MMiller_WMF @Trizek-WMF FYI, I enabled the offswitch on all wikis but testwiki and the beta wikis. That means community configuration will not be immediately working on our target wikis when the train releases it. It also gives us more control over deployment of this feature.

@Etonkovidova Hello, moving this to QA. Special:EditGrowthConfig now should not have any checkboxes.

In T280307#7030426, @MMiller_WMF wrote:

[...]
@Urbanecm_WMF -- I want to note that if there are capabilities in this module that we don't have yet (e.g. a way to quit mentoring), we should discuss and prioritize those before you work on this module. In other words, I think that these specifications may have dependencies that don't exist yet, and that may be a lot of work. There may also be shortcuts we'll want to take. For instance, rather than building a dialog to Claim Mentees from the dashboard, perhaps we would just link the user over to Special:ClaimMentee. Please identify those kinds of shortcuts so we can decide whether to use them.

In T278971#7030536, @MMiller_WMF wrote:

In T278971#6981721, @Urbanecm_WMF wrote:

@OTichonova A follow-up question: Does "question asked" include both mentorship and help panel questions? Help panel is not actively propagated anymore, but since we'll allow communities to configure it soon, it's possible it will be used (again).

@Urbanecm_WMF -- I think you're talking about help desk questions, not help panel questions. We do want the mentee overview to count all questions to mentors, whether they came from homepage or help panel. But we do not want it to count help desk questions. Right?

Hello @CBogen! I would like to put a few notes here about the general feeling i have when testing the image reccomendation system you created

In T215911#7027467, @Trizek-WMF wrote:

Will this be included in the next version of the configuration page?

In T275773#7025570, @Etonkovidova wrote:

Questions to @Urbanecm_WMF
(1)

In T275773#6861342, @Tgr wrote:

We should probably double-check if it's OK for the mentor-mentee relationship to be public (it is sort of public with {{#mentor}} already but that's still different from publishing the entire dump).

Looking at the testwiki (wmf.1via quarry.wmflabs.org the tables growthexperiments_mentee_data and growthexperiments_mentor_mentee are not listed. I guess that's expected?

In T280067#7025332, @MMiller_WMF wrote:

@Trizek-WMF @Urbanecm_WMF -- can you add a due date for when this comes out of dark mode?

@Trizek-WMF Spanish Wikipedia just got promoted out of dark mode!

@Etonkovidova Hello Elena, please do ping me if there is anything wrong with mentorship features. Migration was completed, and the new database table is now the source of truth. I'll wait a week before stopping writing to the old mentorship store.

Script finished everywhere, with the number of rows mostly matching (there were few of other discrepancies, similar to the ruwiki one). We should be ready for READ_NEW everywhere.

@Trizek-WMF urwiki is now in dark mode.

@Trizek-WMF el.wikipedia was pushed to dark mode.

@Trizek-WMF I just pushed cawiki to dark mode.

Table should be live, nothing else needed.

On-wiki config: https://ca.wikipedia.org/wiki/MediaWiki:NewcomerTasks.json

On-wiki config: https://el.wikipedia.org/wiki/MediaWiki:NewcomerTasks.json

In T280172#7019883, @Trizek-WMF wrote:

Thank you @kostajh! :)

@Urbanecm_WMF, we are good to go on dark mode. I will ask the community about the missing Copyedit article template when I will inform them about the upcoming deployment.