I added tasks with patches blocked by this issue as parent tasks of this one, so this is tracked.

Adding T315489 as a subtask, so we have a list of tasks with unmerged patches because of that CI issue.

Adding T315489 as a subtask, so we have a list of tasks with unmerged patches because of that CI issue.

Adding T315489 as a subtask, so we have a list of tasks with unmerged patches because of that CI issue.

Thanks for checking @Etonkovidova! "No recently active mentees" should show when the mentor has no mentees assigned (can be verified by https://test.wikipedia.org/w/api.php?action=query&list=growthmentormentee&gemmmentor=Martin%20Urbanec%20(WMF)&format=xml API call). I tested this in testwiki, and I can't reproduce this either, so there's definitely a bug somewhere. Re-checking the patch shows that it only changed the non-Vue experience, not the Vue experience. Moving back to In progress, so I can investigate and fix this.

In T315525#8164316, @STran wrote:

From T280808#8152977:

The cs.wikipedia deployment for Action Blocks was originally meant to happen today (Aug 11, 2022).

@Niharika I know there's a talk page somewhere confirming cswiki as a pilot wiki but can't find it atm, could you link it? 🙇

In T272146#8162275, @Iniquity wrote:

Considering that subscriptions to topics from DiscussionTools will soon come to all projects, I think this can be used in addition to the bot.
T284489: Deploy topic subscriptions as opt-out feature at all projects

The regression itself should be fixed now, moving to QA. CI failed on the master patch because of T315489, so it didn't get merged. We should keep this task open until the master patch is successfully merged.

The issue here is that MediaWiki:GrowthMentors.json already contained a mentor with a message longer than what's allowed (enrolled yesterday). This shouldn't be possible anymore since T312576: Structured mentor list should validate the maximum length of a mentor message was resolved, but the user enrolled with the too long message about an hour before wmf.25 arrived on testwiki.

In T315097#8155567, @Tgr wrote:

When an admin adds a message longer than 240 characters via a manual edit to MediaWiki:GrowthMentors.json, the edit is rejected.

Done as stated, but IMO it would be nice if it were rejected with some indication of which user had the problematic message.

In T312248#8155691, @Etonkovidova wrote:

@Urbanecm_WMF - there is some additional hint displayed to users when they hover over mw links, e.g.

Should such a hint be added to mw:Special:MyLanguage/Growth/Feature_summary#NH?

In T314691#8155002, @Tgr wrote:

In T314691#8148912, @Urbanecm_WMF wrote:

This was originally my plan, but then I figured the message is usually displayed in Special:EnrollAsMentor (or the Mentor dashboard), rather than when someone edits the list manually. Should we make the validator aware of who the current user is, so it can switch "User X's message is too long" and "Your message is too long" as appropriate? Or is there a better way of doing that?

I would pass the user's name as a message parameter (which doesn't require changes to the validator other than keeping track of the array key), and discard "Your message is too long" and just use errors from the validator as they are. They will be a bit awkwardly phrased for EnrollAsMentor, but users can only see them if they work around the frontend length validation somehow, so that's fine; and they are still specific enough to allow figuring out what's wrong.

In T313205#8160456, @RhinosF1 wrote:

P31294 and P31296 are linked to this task. Any reason for them to remain private?

This is not really an epic, but I moved this to Epics in Progress, since it pretty much overlaps with T264343. Not having it in In progress helps me to orient better on the sprint board.

Moving to code review, assuming there is no other bug at cswiki to fix.

Automated comment: Community configuration usage (2022-08-14)

Review done, keeping opened to ensure the ❗ items from T310906#8153006 are addressed. Fortunately, doesn't affect any pilots, and from technical perspective, should be easily fixable when we're ready for deployment. Not sure whether kswiki will be happy about the structured list though, because of how their list of mentors looks like (might be a part of teahouse or similar), see https://ks.wikipedia.org/wiki/%D9%88%D9%90%DA%A9%DB%8C%D9%96%D9%BE%DB%8C%D9%96%DA%88%DB%8C%D8%A7:%DA%86%D8%A7%D8%A6%DB%92_%D8%AC%D8%A7%D8%A6%DB%92/Hosts.

Noticed again when working on T310906: Review existing wikitext-based mentor lists for inconsistencies/errors. We plan to switch to structured mentor list soon, and fixing this bug will help with that (to ensure the message is not lost as the list is migrated). This is not a blocker for rollout to pilots, as it only affects arwiki (which has two affected mentors => easily fixable during rollout), but it is a blocker for a wider rollout.

While working on this task, I came up with this notebook.

In T280808#8145638, @Tchanders wrote:

The cs.wikipedia deployment for Action Blocks was originally meant to happen today (Aug 11, 2022). Few days ago, I was informed by @Niharika that an extension was requested, until Aug 30, 2022 (so +14 days), to work on this task.

This is the first I've heard of either of these deadlines - thanks for highlighting this @Urbanecm_WMF.

Thanks for reviewing, @Etonkovidova. I checked beta cswiki as well, because
the description says "On enwiki betalabs or cswiki betalabs go to
Special:MentorDashboard and change "Number of mentees assigned to me"". If
it was never present at cswiki, then I think this should be all-solved once
the pending patch
is merged.

In T314050#8149429, @Etonkovidova wrote:

Re-checking in cswiki betalabs and testwiki wmf.23.

The original issue (see the steps below) - is still present, i.e. reloading Special:Mentor page after changing "Number of mentees assigned to me" (and after the confirmation message was displayed and gone) will always return to the initial value (not to Average (default), but to the value that was initially displayed).

Go to Special:MentorDashboard
Change the "Number of mentees assigned to me" from Average to something else
See the confirmation toast
Reload Special:MentorDashboard

In T314691#8147428, @Tgr wrote:

I think it would be nice to mention the affected user name in the error; if the problem does occur somehow, that will make it easy for the wiki admins to understand and fix what is wrong. Other than that, I would ignore it.

In T298328#8108238, @MShilova_WMF wrote:

@Urbanecm_WMF , tagging you again in case you missed the last comment from Kosta.

In T312248#8145910, @DMburugu wrote:

@Urbanecm_WMF Have you been able to apply the solution that @Tgr has shared?

In T314691#8145076, @Urbanecm_WMF wrote:

Thanks @Etonkovidova. Both en.wikipedia issues are caused by the same underlying bug. Dev console's Networking tab shows the API response:

{
  "error": {
    "code": "growthexperiments-mentor-writer-error-message-too-long",
    "info": "Introduction message is too long. Maximum length is 240.",
    "*": "See https://en.wikipedia.beta.wmflabs.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/postorius/lists/mediawiki-api-announce.lists.wikimedia.org/> for notice of API deprecations and breaking changes."
  },
  "servedby": "deployment-mediawiki11"
}