Thanks! I'll take a look at that repo and share any questions I have (if any). Back to actionable tasks on our board then :).

Perfect, thanks for the quick response (as always)! In that case, let's do only the wikis from the description (for them it is important, as it's practically guaranteed we'd miss them next time we need a schema change; we do not intend a deployment there in foreseeable future, so dropping seems the easiest solution to me).

It seems this did the trick, I don't see the warnings anymore. FWIW, in addition to the one mentioned in the description, I also saw this:

This would've helped to prevent two errorbursts in the past ~2 months: T417195, T408531. Moving to Current Quarter Backlog (no objections if someone pulls to sprint if they have time).

I filled T417208: Cover HomepageHooks::onCirrusSearchAddQueryFeatures and HelpPanelHooks::getPreferredEditor with integration testing to not forget about the instrumentation testing.

This will completely disable Newcomer tasks if not fixed. Making it a train blocker.

Let's (at least) investigate within this sprint.

In T416894#11603638, @Sgs wrote:

Removing ExperimentUserDefaultsManager leaves ConditionalDefaultOptionsAddConditionHook without any consumer, any thoughts @Urbanecm_WMF ?

Adding DBA to help here: Would it be possible to help with verifying the tables? I recall @Ladsgroup created a tool for audits like this one, but I don't remember the details. Happy to follow docs if we have any.

And done:

List of wikis that have GrowthExperiments tables but aren't in growthexperiments.dblist:

From Growth's perspective, this is a low-priority cleanup. Triaging accordingly.

FWIW, if it would be helpful, we can probably disable GrowthExperiments on other closed wikis and drop the tables there as well. But, that doesn't need to be done (unless it would be useful for eg. DBAs).

I wrote a small bash script to identify Wikipedias that have GrowthExperiments tables:

@KStoller-WMF and me discussed the desired user experience lasgt week, and we decided against implementing this task.

I updated T304052 with a checklist of tasks. I think this can be closed now.

Unable to reproduce when enabling on a new wiki.

According to the spike tasks we did, there is no change needed in GrowthExperiments, it actually already behaves correctly.

Blocked on T417019: Enable GrowthExperiments on all wikis where growthexperiments tables exist.

This happened, because the schema change task used growthexperiments.dblist as the list of wikis to perform the change on. Unfortunately, that dblist has wikis where GrowthExperiments is _enabled_ (which is a subset of the wikis where growthexperiments tables exist).

Let's start with removing the code itself. I'll work on cleaning up requirements.txt (and hopefully the overall size of the image) once we know the code removal doesn't break anything.

This task is technically in code review.

Unassigning, as I don't think the remainder is Growth facing. Happy to help with specifics if there's something I can ehlp with!

The problem is the pandas dependency (we install a very old version of it, which is no longer compatible with the base Debian image for some reason). Installing pandas 3.0.0 works (I have not checked other dependencies will pass when I do that).

This is important, as it blocks our ability to make changes to the service.