wrong task...

In T274031#6809311, @Iniquity wrote:

Hello! :) I don't know if this was discussed, but it's worth remembering that not everyone should be given the right to change the templates used.

@Iniquity If you can just give me a reason (in Russian) that should appear in the notification for the reassigned mentees, I'd appreciate it. I usually use something like "your previous mentor is no longer available, so we assigned you a new one", but the choice is up to you.

In T275972#6867006, @Iniquity wrote:

In T275972#6867001, @Urbanecm_WMF wrote:

mysql:research@dbstore1005.eqiad.wmnet [ruwiki]> SELECT user_name, COUNT(*) FROM user_properties JOIN user ON up_value=user_id WHERE up_property="growthexperiments-mentor-id" AND user_name IN ("QBA-II-bot", "IluvatarBot") GROUP BY user_id ORDER BY COUNT(*) DESC;
+-------------+----------+
| user_name   | COUNT(*) |
+-------------+----------+
| IluvatarBot |      313 |
| QBA-II-bot  |      287 |
+-------------+----------+
2 rows in set (0.382 sec)

Can we reassign them? :)

Indeed. The list of mentors is determined by the links to NS_USER from the mentorship page. I just removed a link to both bots, and I can confirm they aren't in the list of available mentors anymore (for the record, see P14516).

In T275771#6861200, @RHo wrote:

Good idea @Urbanecm_WMF - maybe GrowthExperiments-MentorDashboard? And any existing related tasks can be like T239234 have this tag appended to it.

In T275908#6865337, @MMiller_WMF wrote:

@Urbanecm_WMF -- could you look this over and make sure I've written it correctly? Please make any needed changes, and then it is Ready for Development.

I'll do it next week then.

In T275789#6864141, @kostajh wrote:

Could we use extension.json for using the defaults? Using Wikidata seems like it might get complicated quickly, and would be more difficult to set up for local development and testing.

@Trizek-WMF Since you are the one who prepares a set of configuration variables for me to use when deploying, can you have a look at this one, please?

In T244734#5914098, @Tgr wrote:

The API patch has been merged so should we do this?

Sysadmin's help will still be required to get the users

Sounds like maybe that could use an API as well?

@OTichonova @RHo Was tis done? :-)

Inddeed it was, thanks.

@Trizek-WMF I removed T275130 as the parent task, as it doesn't sound to be blocked by deploying to Romanian Wikipedia. Is there any other parent task it is supposed to have?

@Strainu So, you want the description to be kept for editing guide, but link to the MW manual in Romanian, and link the images link to Wikipedia:Imagini? Is that right?

@kostajh Yes, there is. I personally vote for implementing @Tgr's idea. I'll talk about it with Marshall later today, and will update this task according to what he says.

In T256126#6858724, @Etonkovidova wrote:

In T256126#6814576, @Urbanecm_WMF wrote:

Thanks @Etonkovidova! I'm wondering what "some account upon creation have a prompt (on a page, not a popup) to enable Homepage" refers to? I'm not sure if that's right behavior.

I observed the same behavior on thwiki where Homepage is in silent mode. After a new account is created, there is a landing page saying "you can enable Homepage via Preferences", that's all. It seems ok for the silent mode though.

Unfortunately, I do not have a screenshot available and could not reproduce the issue with two newly created accounts.

Thanks @nettrom_WMF. Moving to code review then.

(clearing assignee as no one actually fixed this one)

@Trizek-WMF @Strainu Hi, I'm going to change links in the following way:

Certainly, will do later today.

Done, thanks Kosta.

@kostajh It seems you created those files. Can they be deleted?

We are heading towards making wiki config editor a fully featured special page that would be self-explanatory. Not worth the effort.

Agreed, this is much better :). Confirmed via calling new mw.Api().saveOption('growthexperiments-mentor-id', null).done( function() { window.location.reload() }); with homepage loaded that the mentor is stored permanently now.

Thank you for asking this question. I am implementing this feature as a class implementing the standard Config interface. That means it should not be extremely hard to move the implementation in the GrowthExperiments to MediaWIki core if something like this would be wanted by multiple parties.

No way to QA this, closing right away.

I just ran the command @Pchelolo suggested, and I'm indeed seeing the expected jobs there. However, the job is apparently not getting executed for quite a long time, judging by the following query:

In T275429#6850602, @Pchelolo wrote:

This ticket is referenced from a ticket about problems with job execution. Which job is responsible for this feature? I see GrowthExperiments have 2 jobs, but I don't know the codebase enough to understand which of the 2 jobs is responsible for this feature.

In T275437#6850596, @Pchelolo wrote:

This ticket is not a UBN. We've had issues with mass message before, and there's no indication of widespread jobs failures.

Preliminary prioritising this as UBN, unless we figure out this is not as serious as it looks like.