Page MenuHomePhabricator

Urbanecm_WMF (Martin Urbanec / Urbanecm)
Senior Software Engineer, Growth Team

Projects (11)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 21 2020, 11:05 AM (170 w, 6 d)
Availability
Available
IRC Nick
urbanecm
LDAP User
Urbanecm work
MediaWiki User
Martin Urbanec (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Urbanecm_WMF moved T352284: Move user-options classes to the MediaWiki\User\Options namespace from Incoming to Doing on the Growth-Team (Sprint 4 (Growth Team)) board.
Thu, Nov 30, 11:51 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Patch-For-Review, Growth-Team (Sprint 4 (Growth Team)), MediaWiki-Core-Preferences
Urbanecm_WMF triaged T352080: GrowthExperiment 0 edits message is unclear (does not mention that the count is article edits) as Low priority.
Thu, Nov 30, 11:49 PM · Growth-Team (Sprint 4 (Growth Team)), Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule, Patch-For-Review
Urbanecm_WMF edited projects for T352080: GrowthExperiment 0 edits message is unclear (does not mention that the count is article edits), added: Growth-Team (Sprint 4 (Growth Team)); removed Growth-Team.

Thanks everyone. Those points make a lot of sense. In that case, let's go ahead and merge @Soda's patch that implements the change. +2'ed in Gerrit and moving this to QA.

Thu, Nov 30, 11:49 PM · Growth-Team (Sprint 4 (Growth Team)), Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule, Patch-For-Review
Urbanecm_WMF added a comment to T352438: Unable to log in to SUL account.

I cannot reproduce the issue anymore. Looks like someone was failing logins for too long and blocked everyone else. We might want to alter the message to say something else than "Invalid password", to avoid similar surprises in the future.

Thu, Nov 30, 3:48 PM · MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
Urbanecm_WMF triaged T352438: Unable to log in to SUL account as Unbreak Now! priority.

This is an urgent problem.

Thu, Nov 30, 3:18 PM · MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
Urbanecm_WMF created T352438: Unable to log in to SUL account.
Thu, Nov 30, 3:18 PM · MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
Urbanecm_WMF committed rESCC90e20ac607e5: Update UserOptionsLookup's FQN (authored by gerritbot).
Update UserOptionsLookup's FQN
Thu, Nov 30, 3:06 PM
Urbanecm_WMF added a comment to T352309: Gerrit maintenance bot should throttle uploading patches.

The biggest complexity here is not deploying it, is that it is done on a web service, so if add a minute between each patch, the author needs to keep the tab open for hours (if browser/nginx doesn't kill the connection) so it clearly needs to trigger a job but I'm not sure how that can be done in toolforge via k8s. Do we have some API to trigger a k8s job via python?

Thu, Nov 30, 11:02 AM · LSC

Wed, Nov 29

Urbanecm_WMF removed a project from T352284: Move user-options classes to the MediaWiki\User\Options namespace: Wikimedia-Performance-recommendation.
Wed, Nov 29, 12:26 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Patch-For-Review, Growth-Team (Sprint 4 (Growth Team)), MediaWiki-Core-Preferences
Urbanecm_WMF created T352284: Move user-options classes to the MediaWiki\User\Options namespace.
Wed, Nov 29, 12:26 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Patch-For-Review, Growth-Team (Sprint 4 (Growth Team)), MediaWiki-Core-Preferences
Urbanecm_WMF added a comment to T321527: Support dynamic defaults for user properties.

I started working on this today by reorganizing classes responsible for user options a bit (they were in MediaWiki\User, I moved them to MediaWiki\User\Options instead). I'm now working on a class to load conditional user defaults from configuration. After that, we'll also need to do this:

Wed, Nov 29, 12:18 PM · Patch-For-Review, Growth-Team (Sprint 4 (Growth Team)), Wikimedia-Performance-recommendation, Proposal, MediaWiki-Core-Preferences

Tue, Nov 28

Urbanecm_WMF claimed T351266: enable the T342353 checkbox on the Welcome Survey allowing new account holders to consent to being contacted for design research.
Tue, Nov 28, 5:44 PM · Growth-Team (Sprint 4 (Growth Team))
Urbanecm_WMF moved T352174: Track the number of messages posted on StructuredDiscussions on a daily basis from Incoming to Ready on the Growth-Team (Sprint 4 (Growth Team)) board.
Tue, Nov 28, 5:13 PM · Growth-Team (Sprint 4 (Growth Team))
Urbanecm_WMF claimed T321527: Support dynamic defaults for user properties.
Tue, Nov 28, 5:11 PM · Patch-For-Review, Growth-Team (Sprint 4 (Growth Team)), Wikimedia-Performance-recommendation, Proposal, MediaWiki-Core-Preferences
Urbanecm_WMF moved T343288: Leveling Up: Community configuration for Leveling up notifications from QA to Doing on the Growth-Team (Sprint 3 (Growth Team)) board.
Tue, Nov 28, 2:12 PM · Growth-Team (Sprint 4 (Growth Team)), MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Growth-Positive-Reinforcement, GrowthExperiments-LevelingUp
Urbanecm_WMF set the point value for T352174: Track the number of messages posted on StructuredDiscussions on a daily basis to 4.
Tue, Nov 28, 1:20 PM · Growth-Team (Sprint 4 (Growth Team))
Urbanecm_WMF triaged T352031: Improve UserImpact coverage: Test UserImpact::VERSION is bumped when required as Medium priority.
Tue, Nov 28, 11:57 AM · GrowthExperiments-ImpactModule, Growth-Team
Urbanecm_WMF moved T352031: Improve UserImpact coverage: Test UserImpact::VERSION is bumped when required from Inbox to Current Maintenance Focus on the Growth-Team board.
Tue, Nov 28, 11:57 AM · GrowthExperiments-ImpactModule, Growth-Team
Urbanecm_WMF set the point value for T350745: Thank You page experiment: custom account creation page for English Wikipedia experiment to 2.
Tue, Nov 28, 11:56 AM · Growth-Team (Sprint 3 (Growth Team)), Thank-You-Page
Urbanecm_WMF set the point value for T351898: Reduce size of growthexperiments_user_impact.geui_data json blobs to 4.
Tue, Nov 28, 11:56 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments
Urbanecm_WMF set the point value for T346327: Track impressions, success and abandonment rate on the signup form to 4.
Tue, Nov 28, 11:56 AM · Growth-Team (Sprint 4 (Growth Team)), Patch-For-Review, IP-Masking-Growth-Team, MediaWiki-User-login-and-signup, Temporary accounts
Urbanecm_WMF set the point value for T300273: [IP Masking] Temporary account to registered account creation flow to 4.
Tue, Nov 28, 11:56 AM · Growth-Team (Sprint 4 (Growth Team)), MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Patch-For-Review, IP-Masking-Growth-Team, MediaWiki-User-login-and-signup, Temporary accounts
Urbanecm_WMF closed T350137: importOresTopics script fails to import topics as Resolved.
Tue, Nov 28, 11:53 AM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Growth-Team (Sprint 3 (Growth Team)), Machine-Learning-Team, GrowthExperiments
Urbanecm_WMF moved T300271: [IP Masking] Temporary Account Expiration from Doing to QA on the Growth-Team (Sprint 3 (Growth Team)) board.
Tue, Nov 28, 11:53 AM · Growth-Team (Sprint 3 (Growth Team)), IP-Masking-Growth-Team, Temporary accounts
Urbanecm_WMF changed the status of T344694: [IP Masking] Alert temporary accounts 10 days before expiration from In Progress to Open.
Tue, Nov 28, 11:53 AM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Growth-Team (Sprint 3 (Growth Team)), MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), IP-Masking-Growth-Team
Urbanecm_WMF changed the status of T344694: [IP Masking] Alert temporary accounts 10 days before expiration, a subtask of T300271: [IP Masking] Temporary Account Expiration, from In Progress to Open.
Tue, Nov 28, 11:53 AM · Growth-Team (Sprint 3 (Growth Team)), IP-Masking-Growth-Team, Temporary accounts

Mon, Nov 27

Urbanecm_WMF closed T349757: [RFC] Community configuration 2.0: Validating site configuration as Resolved.

Thank you everyone for the comments here. As far as I can see, all of the suggestions gathered in this discussion were logged as Phabricator tasks. With that in mind, I'm resolving the task. Any future feedback is welcomed at the project MW.org talk page.

Mon, Nov 27, 8:19 PM · Growth-Team (Sprint 3 (Growth Team)), MediaWiki-Platform-Team (Radar), GrowthExperiments-CommunityConfiguration (2.0)
Urbanecm_WMF closed T349757: [RFC] Community configuration 2.0: Validating site configuration, a subtask of T323811: [EPIC] Community configuration 2.0: Factor Community configuration out of GrowthExperiments, as Resolved.
Mon, Nov 27, 8:19 PM · GrowthExperiments-CommunityConfiguration (2.0), MediaWiki-Configuration, Growth-Team, Epic
Urbanecm_WMF moved T352080: GrowthExperiment 0 edits message is unclear (does not mention that the count is article edits) from Inbox to Needs Discussion on the Growth-Team board.

Thank you very much for taking the time to report the task and to submit a patch. At the very moment, the empty state of the Impact module is displayed when the user has some mainspace edits. However, once the Impact module gets enabled (=you have at least one mainspace edit), it looks like this:

Mon, Nov 27, 7:54 PM · Growth-Team (Sprint 4 (Growth Team)), Growth-Positive-Reinforcement, GrowthExperiments-ImpactModule, Patch-For-Review
Urbanecm_WMF added a comment to T329700: Clean up GrowthExperiments UserImpact timezone handling.

FTR: I ended up backporting this to make the T351898 fixes easier to backport.

Mon, Nov 27, 2:48 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Growth-Team (Sprint 2 (Growth Team)), Maintenance-Worktype, GrowthExperiments-ImpactModule
Urbanecm_WMF created T352031: Improve UserImpact coverage: Test UserImpact::VERSION is bumped when required.
Mon, Nov 27, 2:47 PM · GrowthExperiments-ImpactModule, Growth-Team
Urbanecm_WMF added a comment to T351873: Enable action blocks in Serbian Wikipedia.

This is not deployed because a comment from @Niharika is needed. ;)

Mon, Nov 27, 2:33 PM · Patch-For-Review, User-Kizule, Anti-Harassment, Serbian-Sites, Wikimedia-Site-requests
Urbanecm_WMF lowered the priority of T351898: Reduce size of growthexperiments_user_impact.geui_data json blobs from Unbreak Now! to High.

Hi @Ladsgroup, this should now be done in production. One last huge batch of upserts is to be expected (because of an unrelated issue, we've bumped the version constant, resulting in regenerating all user impact data). Once that finishes, the size of queries should be considerably smaller. Leaving it open for you to verify – happy to make further changes if needed.

Mon, Nov 27, 2:09 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments
Urbanecm_WMF added a comment to T285423: Deploy Special:EditGrowthConfig to all wikis.

Automated comment: Community configuration usage (2023-11-26)

Mon, Nov 27, 1:00 PM · User-notice-archive, GrowthExperiments-CommunityConfiguration, User-Urbanecm_WMF (Engineering), Growth-Team (Sprint 0 (Growth Team)), Growth-Scaling
Urbanecm_WMF added a comment to T329700: Clean up GrowthExperiments UserImpact timezone handling.

FTR: I ended up backporting this to make the T351898 fixes easier to backport.

Mon, Nov 27, 12:19 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Growth-Team (Sprint 2 (Growth Team)), Maintenance-Worktype, GrowthExperiments-ImpactModule
Urbanecm_WMF moved T352013: Revise UserImpactFormatter logic for noPageViewDataYet from Inbox to Triaged on the Growth-Team board.
Mon, Nov 27, 11:42 AM · Growth-Team, GrowthExperiments
Urbanecm_WMF triaged T352013: Revise UserImpactFormatter logic for noPageViewDataYet as Low priority.
Mon, Nov 27, 11:42 AM · Growth-Team, GrowthExperiments
Urbanecm_WMF added a comment to T351603: When Levelling up features are disabled, browsing Special:EditGrowthConfig errors out.

Added basic Regression tests to this as well, to prevent it from happening in the future.

Mon, Nov 27, 11:26 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Regression, Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments-CommunityConfiguration, Wikimedia-production-error
Urbanecm_WMF placed T341305: Talk page notification alert bar: revised styling to meet WCAG color contrast AA requirements up for grabs.
Mon, Nov 27, 9:36 AM · Growth-Team, User-notice, IP-Masking-Growth-Team, Patch-For-Review, Notifications, Accessibility, Temporary accounts
Urbanecm_WMF moved T343288: Leveling Up: Community configuration for Leveling up notifications from Doing to QA on the Growth-Team (Sprint 3 (Growth Team)) board.
Mon, Nov 27, 9:16 AM · Growth-Team (Sprint 4 (Growth Team)), MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Growth-Positive-Reinforcement, GrowthExperiments-LevelingUp
Urbanecm_WMF moved T351898: Reduce size of growthexperiments_user_impact.geui_data json blobs from Incoming to Code Review on the Growth-Team (Sprint 3 (Growth Team)) board.
Mon, Nov 27, 8:49 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments

Sun, Nov 26

Urbanecm_WMF closed T351888: Flow integration tests block GrowthExperiments merges with an unexpected ContainerDisabledException as Resolved.

Just removing this Container call in the test shows other places with failure from AbuseFilter/CheckUser involved, clearing the hooks works in that situation, not sure if that is the best fix.

Sun, Nov 26, 6:04 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), ci-test-error (WMF-deployed Build Failure), GrowthExperiments, StructuredDiscussions, Growth-Team
Urbanecm_WMF moved T351415: Users who opted-out mentorship get a mentor assigned to them from Code Review to QA on the Growth-Team (Sprint 3 (Growth Team)) board.
Sun, Nov 26, 5:53 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Growth-Team (Sprint 3 (Growth Team)), Community Feedback (Growth), GrowthExperiments-Mentorship
Urbanecm_WMF updated subscribers of T351888: Flow integration tests block GrowthExperiments merges with an unexpected ContainerDisabledException.

The issue is caused by 946538: Replace MediaWikiIntegrationTestCase::$tablesUsed with automatic query tracking. I don't currently understand why, but reverting that patch locally makes the issue go away. Pinging @Daimona @tstarling as the patch author/reviewer – can you help with fixing this problem, please?

Sun, Nov 26, 12:03 AM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), ci-test-error (WMF-deployed Build Failure), GrowthExperiments, StructuredDiscussions, Growth-Team

Fri, Nov 24

Urbanecm_WMF added a comment to T351898: Reduce size of growthexperiments_user_impact.geui_data json blobs.

FYI: T351888: Flow integration tests block GrowthExperiments merges with an unexpected ContainerDisabledException kind of blocks this, since tests failing (not sure why).

Fri, Nov 24, 11:03 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments
Urbanecm_WMF triaged T351920: Special:Impact with no parameters returns an unclear error message to logged-out users as Low priority.

Hi @Trizek-WMF, thanks for reporting. I tried that at Czech Wikipedia (https://cs.wikipedia.org/w/index.php?title=Speci%C3%A1ln%C3%AD:Dosah_p%C5%99%C3%ADsp%C4%9Bvk%C5%AF&uselang=en), and I got this:

Fri, Nov 24, 9:46 AM · Growth-Team, GrowthExperiments-ImpactModule
Urbanecm_WMF added a comment to T351898: Reduce size of growthexperiments_user_impact.geui_data json blobs.

Hi @Ladsgroup, I've uploaded a patch if you want to review. I think that omitting the days with zeros is going to be the biggest change in that patch, since impact data aren't calculated for a lot of bots already anyway. On enwiki, we apparently have user impact data generated only for nine bots in total (P53863). We can certainly explicitly exclude bots from the automated generation (they'd still be included for manual requests via /w/rest.php/growthexperiments/v0/user-impact/%23USERID, and I think that's behaviour that we should keep).

Fri, Nov 24, 9:40 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments
Urbanecm_WMF edited P53863 (An Untitled Masterwork).
Fri, Nov 24, 9:27 AM
Urbanecm_WMF created P53863 (An Untitled Masterwork).
Fri, Nov 24, 9:22 AM
Urbanecm_WMF renamed T351888: Flow integration tests block GrowthExperiments merges with an unexpected ContainerDisabledException from Exception while running phpunit tests to Flow integration tests block GrowthExperiments merges with an unexpected ContainerDisabledException.
Fri, Nov 24, 9:20 AM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), ci-test-error (WMF-deployed Build Failure), GrowthExperiments, StructuredDiscussions, Growth-Team
Urbanecm_WMF claimed T351898: Reduce size of growthexperiments_user_impact.geui_data json blobs.

This is most likely a fallback from T336203: Positive reinforcement: Deploy the new Impact module to all Wikipedias, where we enabled the feature on all Wikipedias. The serialization format was not changed recently, but deploying this everywhere (esp enwiki I guess) probably made this issue way more visible. I'll look into this and upload some patches to make the blob size smaller.

Fri, Nov 24, 12:21 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments

Thu, Nov 23

Urbanecm_WMF moved T343288: Leveling Up: Community configuration for Leveling up notifications from Test in Production to Doing on the Growth-Team (Sprint 3 (Growth Team)) board.

Thanks for testing @Etonkovidova. I reviewed in test.wikipedia production as well, and the notification not appearing is most definitely a bug – moving back to Doing. @Cyndymediawiksim, can you please check why this is happening and fix the bug Elena found?

Thu, Nov 23, 11:48 PM · Growth-Team (Sprint 4 (Growth Team)), MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Growth-Positive-Reinforcement, GrowthExperiments-LevelingUp
Urbanecm_WMF added a comment to T351603: When Levelling up features are disabled, browsing Special:EditGrowthConfig errors out.

Ack, thank you for the confirmation. Leaving the task open for it to go through Growth's QA.

Thu, Nov 23, 11:43 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Regression, Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments-CommunityConfiguration, Wikimedia-production-error
Urbanecm_WMF added a comment to T350598: Add an Image: Invalidate accepted suggestions .

Hi @Etonkovidova, thanks for the tests. As T306349: Public-facing API for querying image suggestion recommendations and submitting user feedback is not resolved, we currently do not have a publicly available API for the image recommendation service. In other words, the current image recommendation API can be only called from Wikimedia production, and it is not available in Wikimedia cloud (including the beta sites). To make the image recommendation feature at least somehow testable in beta, we mirror production recommendations in beta (if Foo article has an image recommendation in production enwiki, the Foo article in beta enwiki will have the same image recommended). If you accept an image in production for one article, the same article in beta should lose the recommendation as well.

Thu, Nov 23, 9:48 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Growth-Team (Sprint 2 (Growth Team)), Community Feedback (Growth), Image-Suggestions
Urbanecm_WMF added a comment to T351888: Flow integration tests block GrowthExperiments merges with an unexpected ContainerDisabledException.

I can reproduce the issue locally, but only when I run all Flow tests together (composer phpunit:entrypoint extensions/Flow/tests/phpunit/). When I run only composer phpunit:entrypoint extensions/Flow/tests/phpunit/Api/ApiFlowEditTopicSummaryTest.php, everything passes. This makes me think the issue is caused by another Flow test not being perfectly self-contained and breaking the service container by somehow calling MediaWikiServices::destroy and not re-initing the container afterwards, which appears to be the only way how this exception can be triggered. The question is why this happens.

Thu, Nov 23, 8:10 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), ci-test-error (WMF-deployed Build Failure), GrowthExperiments, StructuredDiscussions, Growth-Team
Urbanecm_WMF triaged T351888: Flow integration tests block GrowthExperiments merges with an unexpected ContainerDisabledException as High priority.
Thu, Nov 23, 7:05 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), ci-test-error (WMF-deployed Build Failure), GrowthExperiments, StructuredDiscussions, Growth-Team
Urbanecm_WMF added a project to T351888: Flow integration tests block GrowthExperiments merges with an unexpected ContainerDisabledException: ci-test-error.
Thu, Nov 23, 7:05 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), ci-test-error (WMF-deployed Build Failure), GrowthExperiments, StructuredDiscussions, Growth-Team
Urbanecm_WMF added a comment to T349757: [RFC] Community configuration 2.0: Validating site configuration.

Thank you for doing that. While I agree an i18n layer should exist, I'm not sure whether it's 100% required, as during normal operation, you'd only see the error message when doing direct edits to the JSON file. However, we're trying to include the i18n layer if at all possible, just wanted to note this aspect as well, in case you have any thoughts on this.

That's a good point. I still think it would be fairly important given how much we care about i18n, but clearly this is just a personal opinion :)

I agree with that general sentiment, I just happen to challenge it at the same time.

Thu, Nov 23, 7:04 PM · Growth-Team (Sprint 3 (Growth Team)), MediaWiki-Platform-Team (Radar), GrowthExperiments-CommunityConfiguration (2.0)
Urbanecm_WMF moved T350745: Thank You page experiment: custom account creation page for English Wikipedia experiment from Incoming to QA on the Growth-Team (Sprint 3 (Growth Team)) board.
Thu, Nov 23, 6:47 PM · Growth-Team (Sprint 3 (Growth Team)), Thank-You-Page
Urbanecm_WMF added a comment to T350745: Thank You page experiment: custom account creation page for English Wikipedia experiment.

As promised, I looked into this. It looks like the Thank You page is specified in the same way as in T321370 (including the campaign parameter format). In addition to that, it also look we didn't undeploy any of the T321370 changes.

Thu, Nov 23, 6:46 PM · Growth-Team (Sprint 3 (Growth Team)), Thank-You-Page

Wed, Nov 22

Urbanecm_WMF moved T351428: [IP Masking] purgeTemporaryAccounts.php tries to revoke access for non-temporary accounts from Incoming to QA on the Growth-Team (Sprint 3 (Growth Team)) board.
Wed, Nov 22, 5:09 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), IP-Masking-Growth-Team, Growth-Team (Sprint 3 (Growth Team))
Urbanecm_WMF claimed T350745: Thank You page experiment: custom account creation page for English Wikipedia experiment.

I'll look into this.

Wed, Nov 22, 5:02 PM · Growth-Team (Sprint 3 (Growth Team)), Thank-You-Page
Urbanecm_WMF moved T351545: Create a list of configuration option needs for Community configuration 2.0 from Inbox to Backlog on the Growth-Team board.
Wed, Nov 22, 4:09 PM · Growth-Team (Sprint 4 (Growth Team)), GrowthExperiments-CommunityConfiguration (2.0)
Urbanecm_WMF closed T351227: Community configuration 2.0: Rewrite the CommunityConfiguration PoC extension so it does not require extension.json schema changes as Resolved.
Wed, Nov 22, 3:46 PM · Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments-CommunityConfiguration (2.0)

Tue, Nov 21

Urbanecm_WMF added a comment to T351227: Community configuration 2.0: Rewrite the CommunityConfiguration PoC extension so it does not require extension.json schema changes.

This is now done. I managed to miss a critical point in the documentation, so I attempted to clarify the docs as well.

Tue, Nov 21, 9:23 AM · Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments-CommunityConfiguration (2.0)
Urbanecm_WMF moved T351227: Community configuration 2.0: Rewrite the CommunityConfiguration PoC extension so it does not require extension.json schema changes from Ready to Code Review on the Growth-Team (Sprint 3 (Growth Team)) board.
Tue, Nov 21, 9:17 AM · Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments-CommunityConfiguration (2.0)

Mon, Nov 20

Urbanecm_WMF added a comment to T351603: When Levelling up features are disabled, browsing Special:EditGrowthConfig errors out.

Hello @Pppery, this problem should now be fixed in production. Can you please try again and let us know if Community configuration works properly now?

Mon, Nov 20, 7:15 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Regression, Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments-CommunityConfiguration, Wikimedia-production-error
Urbanecm_WMF added a comment to T285423: Deploy Special:EditGrowthConfig to all wikis.

Automated comment: Community configuration usage (2023-11-19)

Mon, Nov 20, 1:00 PM · User-notice-archive, GrowthExperiments-CommunityConfiguration, User-Urbanecm_WMF (Engineering), Growth-Team (Sprint 0 (Growth Team)), Growth-Scaling
Urbanecm_WMF added a comment to T344695: [IP Masking] Expire temporary accounts in 1 year.

Thanks @Etonkovidova for the tests. I think this is caused by the fact that the expiry logic runs daily at a specific time (14:27 UTC, to be precise), which means the account expires once it is at least a day old at 14:27 UTC. I personally don't think this is a problem (there'd be at most a day delay over a year) though. If @KStoller-WMF thinks this is problematic behaviour, we can certainly revisit.

Mon, Nov 20, 11:56 AM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Growth-Team (Sprint 3 (Growth Team)), Trust and Safety Product Sprint, Trust and Safety Product Team, Patch-For-Review, IP-Masking-Growth-Team
Urbanecm_WMF moved T351603: When Levelling up features are disabled, browsing Special:EditGrowthConfig errors out from Incoming to QA on the Growth-Team (Sprint 3 (Growth Team)) board.
Mon, Nov 20, 10:53 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Regression, Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments-CommunityConfiguration, Wikimedia-production-error
Urbanecm_WMF updated the task description for T351603: When Levelling up features are disabled, browsing Special:EditGrowthConfig errors out.
Mon, Nov 20, 10:05 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Regression, Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments-CommunityConfiguration, Wikimedia-production-error
Urbanecm_WMF updated the task description for T351603: When Levelling up features are disabled, browsing Special:EditGrowthConfig errors out.
Mon, Nov 20, 10:05 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Regression, Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments-CommunityConfiguration, Wikimedia-production-error
Urbanecm_WMF renamed T351603: When Levelling up features are disabled, browsing Special:EditGrowthConfig errors out from MWException: Fatal error browsing Special:EditGrowthConfig to When Levelling up features are disabled, browsing Special:EditGrowthConfig errors out.
Mon, Nov 20, 9:52 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Regression, Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments-CommunityConfiguration, Wikimedia-production-error
Urbanecm_WMF claimed T351603: When Levelling up features are disabled, browsing Special:EditGrowthConfig errors out.

I'll investigate, thanks for reporting.

Mon, Nov 20, 9:12 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Regression, Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments-CommunityConfiguration, Wikimedia-production-error

Fri, Nov 17

Urbanecm_WMF created T351545: Create a list of configuration option needs for Community configuration 2.0.
Fri, Nov 17, 3:51 PM · Growth-Team (Sprint 4 (Growth Team)), GrowthExperiments-CommunityConfiguration (2.0)
Urbanecm_WMF moved T351415: Users who opted-out mentorship get a mentor assigned to them from Incoming to Code Review on the Growth-Team (Sprint 3 (Growth Team)) board.

I figured the root cause here. Even before the fix above, GrowthExperiments did drop the mentor/mentee relationship from the database and features like the Homepage or Help panel checked the mentorship state (enabled/opt-out) before directing the user to a mentor. However, in the case of the Help panel, the check only happened in the user interface. Backend still attempted to assign the mentor and pass that information to the Help panel UI. This is now fixed by checking for opt-out within MentorManager itself, so that any other part of GrowthExperiments receives correct data about mentorship from now on.

Fri, Nov 17, 3:23 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Growth-Team (Sprint 3 (Growth Team)), Community Feedback (Growth), GrowthExperiments-Mentorship
Urbanecm_WMF triaged T351415: Users who opted-out mentorship get a mentor assigned to them as High priority.
Fri, Nov 17, 2:31 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Growth-Team (Sprint 3 (Growth Team)), Community Feedback (Growth), GrowthExperiments-Mentorship
Urbanecm_WMF moved T351517: Improve behaviour when the configuration page does not exist from Inbox to Backlog on the Growth-Team board.
Fri, Nov 17, 2:06 PM · Growth-Team, GrowthExperiments-CommunityConfiguration (2.0)
Urbanecm_WMF updated the task description for T351517: Improve behaviour when the configuration page does not exist.
Fri, Nov 17, 1:35 PM · Growth-Team, GrowthExperiments-CommunityConfiguration (2.0)
Urbanecm_WMF created T351517: Improve behaviour when the configuration page does not exist.
Fri, Nov 17, 1:35 PM · Growth-Team, GrowthExperiments-CommunityConfiguration (2.0)
Urbanecm_WMF added a comment to T351241: Assignment script log comment should be improved.

Thanks for the reply. Does that mean that in this task, the message should only change for the (one-off) T330071 reassignment? I originally understood it as change the message for any mentor/mentee reassignment (whether done by the script, or by a mentor quitting themselves, or by an admin removing). But, maybe I got that incorrectly.

Fri, Nov 17, 10:31 AM · Growth-Team, GrowthExperiments-Mentorship

Thu, Nov 16

Urbanecm_WMF added a comment to T351415: Users who opted-out mentorship get a mentor assigned to them.

So, upon an initial investigation, I have some thoughts about how this bug can be fixed. I'll need more time to be able to prepare a correct fix for the problem. Thank you for your patience!

Thu, Nov 16, 4:48 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Growth-Team (Sprint 3 (Growth Team)), Community Feedback (Growth), GrowthExperiments-Mentorship
Urbanecm_WMF added a comment to T351428: [IP Masking] purgeTemporaryAccounts.php tries to revoke access for non-temporary accounts.

There are two sub-bugs here.

Thu, Nov 16, 4:44 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), IP-Masking-Growth-Team, Growth-Team (Sprint 3 (Growth Team))
Urbanecm_WMF claimed T351428: [IP Masking] purgeTemporaryAccounts.php tries to revoke access for non-temporary accounts.
Thu, Nov 16, 4:09 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), IP-Masking-Growth-Team, Growth-Team (Sprint 3 (Growth Team))
Urbanecm_WMF created T351428: [IP Masking] purgeTemporaryAccounts.php tries to revoke access for non-temporary accounts.
Thu, Nov 16, 4:09 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), IP-Masking-Growth-Team, Growth-Team (Sprint 3 (Growth Team))
Urbanecm_WMF triaged T351241: Assignment script log comment should be improved as Medium priority.
Thu, Nov 16, 4:03 PM · Growth-Team, GrowthExperiments-Mentorship
Urbanecm_WMF added a comment to T351241: Assignment script log comment should be improved.

@Trizek-WMF Hello, thanks for filling this task! There is a second, similar, message used when an admin removes a mentor using Special:ManageMentors. Currently, it reads $admin removed $oldmentor from mentorship. Do you think we should update that message as well? If so, would Automated reassignment of mentees since $admin removed $oldmentor from mentorship work? Or would you prefer if we use a different copy for that scenario?

Thu, Nov 16, 4:03 PM · Growth-Team, GrowthExperiments-Mentorship
Urbanecm_WMF changed the subtype of T351415: Users who opted-out mentorship get a mentor assigned to them from "Task" to "Bug Report".

Thanks @Trizek-WMF and @Janui, thanks for the report. I investigated this bug, and I can see that @Janui is opted out of mentorship, but they have a mentor assigned regardless. This is definitely a bug somewhere, but I'm not yet sure where exactly.

Thu, Nov 16, 3:22 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Growth-Team (Sprint 3 (Growth Team)), Community Feedback (Growth), GrowthExperiments-Mentorship
Urbanecm_WMF moved T343322: IP Masking: Update Recent changes filters user registration filters for IP Masking from Code Review to QA on the Growth-Team (Sprint 3 (Growth Team)) board.
Thu, Nov 16, 2:22 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Growth-Team (Sprint 3 (Growth Team)), MediaWiki-Watchlist, MediaWiki-Recent-changes, IP-Masking-Growth-Team, Temporary accounts
Urbanecm_WMF moved T350549: De-deprecate gt.defineTour from Needs Discussion to Triaged on the Growth-Team board.

Hey @Urbanecm_WMF , is there any progress on this?

Thu, Nov 16, 7:44 AM · Growth-Team, MediaWiki-extensions-GuidedTour
Urbanecm_WMF moved T350137: importOresTopics script fails to import topics from Code Review to QA on the Growth-Team (Sprint 3 (Growth Team)) board.
Thu, Nov 16, 7:39 AM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Growth-Team (Sprint 3 (Growth Team)), Machine-Learning-Team, GrowthExperiments

Tue, Nov 14

Urbanecm_WMF set the point value for T351241: Assignment script log comment should be improved to 2.
Tue, Nov 14, 11:34 PM · Growth-Team, GrowthExperiments-Mentorship
Urbanecm_WMF set the point value for T344695: [IP Masking] Expire temporary accounts in 1 year to 4.
Tue, Nov 14, 11:34 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Growth-Team (Sprint 3 (Growth Team)), Trust and Safety Product Sprint, Trust and Safety Product Team, Patch-For-Review, IP-Masking-Growth-Team
Urbanecm_WMF set the point value for T343322: IP Masking: Update Recent changes filters user registration filters for IP Masking to 4.
Tue, Nov 14, 11:33 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Growth-Team (Sprint 3 (Growth Team)), MediaWiki-Watchlist, MediaWiki-Recent-changes, IP-Masking-Growth-Team, Temporary accounts
Urbanecm_WMF moved T349024: [mobile] Section level image suggestions: intro tour images do not fit viewport width from Code Review to QA on the Growth-Team (Sprint 3 (Growth Team)) board.
Tue, Nov 14, 10:55 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Growth-Team (Sprint 3 (Growth Team)), Section-Level-Image-Suggestions
Urbanecm_WMF moved T351227: Community configuration 2.0: Rewrite the CommunityConfiguration PoC extension so it does not require extension.json schema changes from Incoming to Ready on the Growth-Team (Sprint 3 (Growth Team)) board.
Tue, Nov 14, 10:53 PM · Growth-Team (Sprint 3 (Growth Team)), GrowthExperiments-CommunityConfiguration (2.0)
Urbanecm_WMF moved T351241: Assignment script log comment should be improved from Incoming to Ready on the Growth-Team (Sprint 3 (Growth Team)) board.
Tue, Nov 14, 10:53 PM · Growth-Team, GrowthExperiments-Mentorship
Urbanecm_WMF moved T343288: Leveling Up: Community configuration for Leveling up notifications from Code Review to QA on the Growth-Team (Sprint 3 (Growth Team)) board.
Tue, Nov 14, 10:47 PM · Growth-Team (Sprint 4 (Growth Team)), MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Growth-Positive-Reinforcement, GrowthExperiments-LevelingUp
Urbanecm_WMF updated subscribers of T344695: [IP Masking] Expire temporary accounts in 1 year.

@Etonkovidova This is now testable at beta wikis where IP Masking is enabled. I set the expiry to 1 day as requested. Please let me know what you think and whether it is OK to increase the expiry to a year, as requested. For now, moving to QA. The other part (T344694) is still in CR.

Tue, Nov 14, 10:47 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Growth-Team (Sprint 3 (Growth Team)), Trust and Safety Product Sprint, Trust and Safety Product Team, Patch-For-Review, IP-Masking-Growth-Team
Urbanecm_WMF moved T344695: [IP Masking] Expire temporary accounts in 1 year from Doing to QA on the Growth-Team (Sprint 3 (Growth Team)) board.
Tue, Nov 14, 10:44 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Growth-Team (Sprint 3 (Growth Team)), Trust and Safety Product Sprint, Trust and Safety Product Team, Patch-For-Review, IP-Masking-Growth-Team