Victorbarbu (Victorbarbu)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Dec 14 2015, 12:40 PM (144 w, 3 d)
Availability
Available
LDAP User
Victorbarbu
MediaWiki User
Unknown

Recent Activity

Jan 9 2017

Victorbarbu added a comment to T61113: Remove MediaWiki code marked for removal in a past release.

Is code marked with deprecated, use ... instead considered good to remove?

Jan 9 2017, 6:54 AM · MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, User-Matthewrbowker, Google-Code-In-2016, Technical-Debt, Easy, MediaWiki-General-or-Unknown

Dec 16 2016

Victorbarbu added a comment to T117740: Convert Special:RecentChanges to OOUI.

Currently Jenkins is complaining about the rcdays undefined index in $preferences ($preferences being the array holding the preferences generated by Preferences.php and extensions), when the Setup.php script is run. This is normal, because I changed the rcdays to rcmaxage so as to allow more time values (since this is expressed in seconds).

Dec 16 2016, 10:08 PM · Growth-Team, MediaWiki-Recent-changes, User-notice, Collaboration-Team-Triage, Patch-For-Review, Google-Code-In-2016, UI-Standardization

Dec 9 2016

Victorbarbu updated subscribers of T152779: Provide a way of creating fake infusion data.
Dec 9 2016, 2:40 PM · OOUI
Victorbarbu created T152779: Provide a way of creating fake infusion data.
Dec 9 2016, 2:38 PM · OOUI

Dec 8 2016

Victorbarbu added a comment to T117740: Convert Special:RecentChanges to OOUI.

@Florian, with the newest patch on Gerrit, the page looks like the image above on a 1920x1080 screen.

Dec 8 2016, 8:17 PM · Growth-Team, MediaWiki-Recent-changes, User-notice, Collaboration-Team-Triage, Patch-For-Review, Google-Code-In-2016, UI-Standardization
Victorbarbu added a comment to T117740: Convert Special:RecentChanges to OOUI.

The user still has to interact with the form to see the more important list of changes

Dec 8 2016, 5:46 PM · Growth-Team, MediaWiki-Recent-changes, User-notice, Collaboration-Team-Triage, Patch-For-Review, Google-Code-In-2016, UI-Standardization
Victorbarbu added a comment to T117740: Convert Special:RecentChanges to OOUI.

I finally got the patch out of the WIP status.

Dec 8 2016, 2:33 PM · Growth-Team, MediaWiki-Recent-changes, User-notice, Collaboration-Team-Triage, Patch-For-Review, Google-Code-In-2016, UI-Standardization

Dec 3 2016

Victorbarbu updated subscribers of T152321: Implement a HiddenInputWidget to reflect the 'hidden' input.
Dec 3 2016, 7:33 PM · OOUI (OOjs-UI-0.22.0)
Victorbarbu created T152321: Implement a HiddenInputWidget to reflect the 'hidden' input.
Dec 3 2016, 7:30 PM · OOUI (OOjs-UI-0.22.0)
Victorbarbu added a comment to T117740: Convert Special:RecentChanges to OOUI.

@Haritha28 I cannot reach you on IRC. Can we talk there, please?

Dec 3 2016, 8:43 AM · Growth-Team, MediaWiki-Recent-changes, User-notice, Collaboration-Team-Triage, Patch-For-Review, Google-Code-In-2016, UI-Standardization

Dec 1 2016

Victorbarbu claimed T117740: Convert Special:RecentChanges to OOUI.

I will claim this in GCI very soon!

Dec 1 2016, 10:44 PM · Growth-Team, MediaWiki-Recent-changes, User-notice, Collaboration-Team-Triage, Patch-For-Review, Google-Code-In-2016, UI-Standardization

Nov 30 2016

Victorbarbu created T151988: Migrate Wikibase to OOUI.
Nov 30 2016, 8:58 AM · Wikibase-Quality, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, Wikidata
Victorbarbu added a comment to T114473: Provide a special page to list all available badges.

Is there anyone that could review my patch, please?

Nov 30 2016, 8:52 AM · Patch-For-Review, Wikidata-Former-Sprint-Board, Google-Code-In-2016, Easy, MediaWiki-Special-pages, MediaWiki-extensions-WikibaseRepository, Wikidata

Nov 28 2016

Victorbarbu updated subscribers of T114473: Provide a special page to list all available badges.
Nov 28 2016, 10:20 PM · Patch-For-Review, Wikidata-Former-Sprint-Board, Google-Code-In-2016, Easy, MediaWiki-Special-pages, MediaWiki-extensions-WikibaseRepository, Wikidata
Victorbarbu added a comment to T114473: Provide a special page to list all available badges.

The API in its current shape is inconsistent in my opinion, since one query would not be enough for anything else than getting the Item ID (not label, description etc.)

Nov 28 2016, 10:19 PM · Patch-For-Review, Wikidata-Former-Sprint-Board, Google-Code-In-2016, Easy, MediaWiki-Special-pages, MediaWiki-extensions-WikibaseRepository, Wikidata

Nov 11 2016

Victorbarbu added a comment to T150234: Wrap MediaWiki in a fixed size container.

@matmarex any thoughts on that, please?

Nov 11 2016, 8:50 AM · Vector, Design

Nov 10 2016

Victorbarbu added a comment to T150234: Wrap MediaWiki in a fixed size container.

I made some refactorings of the code and then I came up with this

Nov 10 2016, 4:08 PM · Vector, Design

Nov 9 2016

Victorbarbu added a comment to T150234: Wrap MediaWiki in a fixed size container.

I will see what I can do about that and I will come up with a patch soon.

Nov 9 2016, 6:41 PM · Vector, Design
Victorbarbu added a comment to T150234: Wrap MediaWiki in a fixed size container.

I started working on this. Vector seems to have a lot of problems and seems to be really hacky. ALmost all the styles must be refactored, IMO.

Nov 9 2016, 6:33 PM · Vector, Design
Victorbarbu added a comment to T150234: Wrap MediaWiki in a fixed size container.

I agree with you that this is not a easy thing, but it can certainly be
achieved.

Nov 9 2016, 4:52 AM · Vector, Design

Nov 8 2016

Victorbarbu updated the task description for T150234: Wrap MediaWiki in a fixed size container.
Nov 8 2016, 8:52 AM · Vector, Design
Victorbarbu created T150234: Wrap MediaWiki in a fixed size container.
Nov 8 2016, 8:52 AM · Vector, Design

Nov 7 2016

Victorbarbu added a comment to T148596: Create a gadget that displays the Wikidata ID of a page near the title.

I know that, thank you. I will claim it when the contest begins!

Nov 7 2016, 7:56 PM · Easy, Google-Code-In-2016
Victorbarbu claimed T114473: Provide a special page to list all available badges.

Not a mentor, but I would like to do this if that's ok!

Nov 7 2016, 5:41 PM · Patch-For-Review, Wikidata-Former-Sprint-Board, Google-Code-In-2016, Easy, MediaWiki-Special-pages, MediaWiki-extensions-WikibaseRepository, Wikidata
Victorbarbu claimed T148596: Create a gadget that displays the Wikidata ID of a page near the title.

Not a mentor, but still wanna do this if that's ok!

Nov 7 2016, 5:40 PM · Easy, Google-Code-In-2016

Aug 4 2016

Victorbarbu added a comment to T142080: HTTP API typechecking method is very confusing and intimidating.

I thought I would be a good idea because adding a new type to the already existing code is pretty hard already. If you remember my task in Google Code-in, when I implemented a new parameter type, it was pretty ambiguous where error reporting, type checking etc. would come.

Aug 4 2016, 3:13 PM · Patch-For-Review, MediaWiki-API, Technical-Debt
Victorbarbu created T142080: HTTP API typechecking method is very confusing and intimidating.
Aug 4 2016, 11:16 AM · Patch-For-Review, MediaWiki-API, Technical-Debt

Feb 10 2016

Victorbarbu closed T126116: ClassCollector does not read traits as Resolved.
Feb 10 2016, 7:03 PM · MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), MediaWiki-General-or-Unknown, Patch-For-Review

Feb 6 2016

Victorbarbu created T126116: ClassCollector does not read traits.
Feb 6 2016, 2:05 PM · MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), MediaWiki-General-or-Unknown, Patch-For-Review

Jan 29 2016

Victorbarbu added a comment to T31661: Link to the page of the downloaded extension on Special:ExtensionDistributor.

@Kghbln, I am really glad you see this feature useful!

Jan 29 2016, 4:47 PM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, Google-Code-In-2015, Easy, ExtensionDistributor

Jan 22 2016

Victorbarbu claimed T124326: Flash of unstyled content on experimental GatherEditFeed.
Jan 22 2016, 8:18 PM · Patch-For-Review, Google-Code-In-2015, Easy, Gather
Victorbarbu triaged T124326: Flash of unstyled content on experimental GatherEditFeed as Low priority.
Jan 22 2016, 8:18 PM · Patch-For-Review, Google-Code-In-2015, Easy, Gather

Jan 17 2016

Victorbarbu closed T70716: [AutoProxyBlock] PHP Strict standards: non-static method AutoProxyBlock::checkProxy() should not be called statically as Resolved.
Jan 17 2016, 1:43 PM · Patch-For-Review, Google-Code-In-2015, Easy, MediaWiki-extensions-Other
Victorbarbu reopened T119934: MW 1.26.0: Vector stylesheet doesn't load if temporary directory is unwritable as "Open".

Marking it back as "Open" so people don't get offended.

Jan 17 2016, 12:24 PM · MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)), MW-1.27-release-notes, Patch-For-Review, Google-Code-In-2015, MediaWiki-Installer, MW-1.26-release, Vector
Victorbarbu closed T119934: MW 1.26.0: Vector stylesheet doesn't load if temporary directory is unwritable as Invalid.

I downloaded the MediaWIki 1.26.2 from mediawiki.org. I completed the normal installation process and my Wiki works perfectly. (see the screenshot).

Jan 17 2016, 12:19 PM · MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)), MW-1.27-release-notes, Patch-For-Review, Google-Code-In-2015, MediaWiki-Installer, MW-1.26-release, Vector
Victorbarbu closed T123368: Allow sending message parameters through Linker::titleAttrib as Resolved.

Resolved with T123365

Jan 17 2016, 11:18 AM · MediaWiki-General-or-Unknown
Victorbarbu closed T123365: Add support for message parameters for Toolbox links' tooltips as Resolved.
Jan 17 2016, 11:16 AM · MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, MediaWiki-General-or-Unknown

Jan 15 2016

Victorbarbu updated the task description for T70701: [ErrorHandler] PHP Notice: Undefined index: en in extensions/ErrorHandler/ErrorHandler.php on line 223.
Jan 15 2016, 6:58 PM · Patch-For-Review, Google-Code-In-2015, Easy, MediaWiki-extensions-Other
Victorbarbu updated the task description for T70701: [ErrorHandler] PHP Notice: Undefined index: en in extensions/ErrorHandler/ErrorHandler.php on line 223.
Jan 15 2016, 6:58 PM · Patch-For-Review, Google-Code-In-2015, Easy, MediaWiki-extensions-Other

Jan 12 2016

Victorbarbu updated subscribers of T123368: Allow sending message parameters through Linker::titleAttrib.
Jan 12 2016, 2:21 PM · MediaWiki-General-or-Unknown
Victorbarbu created T123368: Allow sending message parameters through Linker::titleAttrib.
Jan 12 2016, 2:18 PM · MediaWiki-General-or-Unknown
Victorbarbu created T123365: Add support for message parameters for Toolbox links' tooltips.
Jan 12 2016, 12:18 PM · MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, MediaWiki-General-or-Unknown
Victorbarbu added a comment to T104836: Talk overlay inputs don't have borders.

@violetto, you cannot check that page because the changes have not been deployed yet, apparently, that's not my version...

Jan 12 2016, 6:12 AM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, Google-Code-In-2015, MobileFrontend, Design

Jan 11 2016

Victorbarbu closed T28123: Special:Undelete doesn't use ar_page_id as Resolved.
Jan 11 2016, 11:18 PM · Google-Code-In-2015, MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), MW-1.27-release-notes, MediaWiki-General-or-Unknown
Victorbarbu closed T28123: Special:Undelete doesn't use ar_page_id, a subtask of T30124: Rewrite deletion system, as Resolved.
Jan 11 2016, 11:18 PM · Goal, MediaWiki-General-or-Unknown
Victorbarbu claimed T28123: Special:Undelete doesn't use ar_page_id.
Jan 11 2016, 11:18 PM · Google-Code-In-2015, MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), MW-1.27-release-notes, MediaWiki-General-or-Unknown
Victorbarbu created T123299: Redesign pages to use the OOjs-UI instead of the old forms.
Jan 11 2016, 10:42 PM · MediaWiki-General-or-Unknown
Victorbarbu added a comment to T28123: Special:Undelete doesn't use ar_page_id.

I know that, that's why I don't understand why grabbing the page id may be problematic (as @Catrope, @Platonides and @Rich_Farmbrough stated)

Jan 11 2016, 8:32 PM · Google-Code-In-2015, MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), MW-1.27-release-notes, MediaWiki-General-or-Unknown
Victorbarbu added a comment to T28123: Special:Undelete doesn't use ar_page_id.

I might not completely understand this, but since the pageid column uses auto_increment , how could the ID of a deleted page not be in use since it once was there? Suppose I have:

Jan 11 2016, 8:26 PM · Google-Code-In-2015, MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), MW-1.27-release-notes, MediaWiki-General-or-Unknown
Victorbarbu added a comment to T31661: Link to the page of the downloaded extension on Special:ExtensionDistributor.

@Kghbln, glad to hear that you were looking for this! I hope you'll find it useful!

Jan 11 2016, 8:19 PM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, Google-Code-In-2015, Easy, ExtensionDistributor

Jan 9 2016

Victorbarbu claimed T31661: Link to the page of the downloaded extension on Special:ExtensionDistributor.

I am trying to solve this!

Jan 9 2016, 10:02 PM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, Google-Code-In-2015, Easy, ExtensionDistributor
Victorbarbu closed T122952: convertExtensionToRegistration.php script should die on global functions (like it does for closures) as Resolved.
Jan 9 2016, 10:02 PM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), MW-1.27-release-notes, Patch-For-Review, Google-Code-In-2015, Easy, MediaWiki-Configuration
Victorbarbu claimed T122952: convertExtensionToRegistration.php script should die on global functions (like it does for closures).

I am working on it!

Jan 9 2016, 7:19 PM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), MW-1.27-release-notes, Patch-For-Review, Google-Code-In-2015, Easy, MediaWiki-Configuration

Jan 8 2016

Victorbarbu added a comment to T104836: Talk overlay inputs don't have borders.

I decided not to set the panel to fit the screen's width, It seems to look better. Also, the max-width seems to only show on desktops, because on mobile, the panel has width 100%.

Jan 8 2016, 9:53 PM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, Google-Code-In-2015, MobileFrontend, Design

Jan 7 2016

Victorbarbu added a comment to T104836: Talk overlay inputs don't have borders.

So the changes we want set will be the ones listed below. Also with the additions of new classes.

Changes:

  1. Double the size of left/right padding to align with the arrow
  2. Remove margin-bottom on input so they stack
  3. Make fields full-screen or edge-to-edge on the screen
  4. Set border-radius to 0
Jan 7 2016, 5:26 PM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, Google-Code-In-2015, MobileFrontend, Design
Victorbarbu claimed T104836: Talk overlay inputs don't have borders.

I am going to try to solve this :)

Jan 7 2016, 5:16 PM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, Google-Code-In-2015, MobileFrontend, Design
Victorbarbu closed T87986: Convert TranslationNotifications to use extension registration as Resolved.
Jan 7 2016, 4:26 PM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, Google-Code-In-2015, MediaWiki-extensions-TranslationNotifications
Victorbarbu closed T87986: Convert TranslationNotifications to use extension registration, a subtask of T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration, as Resolved.
Jan 7 2016, 4:26 PM · MediaWiki-extensions-General, Goal, MediaWiki-Configuration
Victorbarbu claimed T87986: Convert TranslationNotifications to use extension registration.
Jan 7 2016, 9:28 AM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, Google-Code-In-2015, MediaWiki-extensions-TranslationNotifications

Jan 4 2016

Victorbarbu added a comment to T122439: Provide short URL to file description page in imageinfo API.

@Tgr, here is the model I am trying to implement:

Jan 4 2016, 9:08 PM · MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)), MW-1.27-release-notes, Patch-For-Review, MediaWiki-API, Google-Code-In-2015
Victorbarbu added a comment to T122439: Provide short URL to file description page in imageinfo API.

@Anomie, comments starting with no are, most often not helpful. This doesn't help me understand how you would like it to be.

Jan 4 2016, 6:18 PM · MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)), MW-1.27-release-notes, Patch-For-Review, MediaWiki-API, Google-Code-In-2015
Victorbarbu added a comment to T122439: Provide short URL to file description page in imageinfo API.

Adding curid key to imageinfo should do it, right? Or should the url key be modified?

Jan 4 2016, 12:06 PM · MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)), MW-1.27-release-notes, Patch-For-Review, MediaWiki-API, Google-Code-In-2015
Victorbarbu closed T122761: Non-static methods are called statically as Resolved.
Jan 4 2016, 11:37 AM · Patch-For-Review, Spelling-Dictionary

Jan 3 2016

Victorbarbu updated subscribers of T122439: Provide short URL to file description page in imageinfo API.
Jan 3 2016, 5:28 PM · MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)), MW-1.27-release-notes, Patch-For-Review, MediaWiki-API, Google-Code-In-2015
Victorbarbu created T122761: Non-static methods are called statically.
Jan 3 2016, 9:55 AM · Patch-For-Review, Spelling-Dictionary

Jan 1 2016

Victorbarbu created T122722: The cancel event handler closes the ULS even if a descendant of the trigger is clicked.
Jan 1 2016, 2:56 PM · MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), Patch-For-Review, UniversalLanguageSelector

Dec 30 2015

Victorbarbu added a comment to T87244: Use ULS for language selection.

@Ankitashukla this still needs clarification. You haven't mentioned:

Dec 30 2015, 6:45 PM · Technical-Debt, Patch-For-Review, Google-Code-In-2015, Spelling-Dictionary

Dec 18 2015

Victorbarbu added a comment to T121389: Should Special:Contributions be converted to a table.

This would look very broken on mobile. We want to be moving away from tables...

Dec 18 2015, 10:23 PM · Accessibility, Patch-For-Review, Google-Code-In-2015, Design, MediaWiki-Special-pages
Victorbarbu added a comment to T121389: Should Special:Contributions be converted to a table.

After a few days, are there any ideas about how something like this should actually look?

Dec 18 2015, 9:00 PM · Accessibility, Patch-For-Review, Google-Code-In-2015, Design, MediaWiki-Special-pages

Dec 15 2015

Victorbarbu added a comment to T110904: Banners should support extraClassNames parameter.

My pleasure!

Dec 15 2015, 6:59 PM · MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)), Patch-For-Review, Google-Code-In-2015, Easy, Wikidata-Page-Banner

Dec 14 2015

Victorbarbu added a comment to T110904: Banners should support extraClassNames parameter.

You can let the classes remain separated by space, as in the example.

Dec 14 2015, 7:24 PM · MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)), Patch-For-Review, Google-Code-In-2015, Easy, Wikidata-Page-Banner
Victorbarbu added a comment to T110904: Banners should support extraClassNames parameter.

I am currently working on implementing this feature. The model I have in mind is this one: property name will be extraClasses.

Dec 14 2015, 6:58 PM · MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)), Patch-For-Review, Google-Code-In-2015, Easy, Wikidata-Page-Banner
Victorbarbu added a comment to T121389: Should Special:Contributions be converted to a table.

I could probably help and come up with a model for this problem, if the decision is taken and the solution is found :)

Dec 14 2015, 1:38 PM · Accessibility, Patch-For-Review, Google-Code-In-2015, Design, MediaWiki-Special-pages
Victorbarbu updated subscribers of T121389: Should Special:Contributions be converted to a table.
Dec 14 2015, 12:41 PM · Accessibility, Patch-For-Review, Google-Code-In-2015, Design, MediaWiki-Special-pages