WMDE-Fisch (Christoph Jauera (WMDE))
Software Engineer, Wikimedia Deutschland

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 20 2014, 8:59 AM (156 w, 6 d)
Availability
Available
LDAP User
WMDE-Fisch
MediaWiki User
Christoph Jauera (WMDE)

Recent Activity

Yesterday

WMDE-Fisch created T181056: Use package 'qunit' instead of 'qunitjs' in package.json.
Tue, Nov 21, 2:35 PM · MediaWiki-General-or-Unknown, Patch-For-Review, JavaScript
WMDE-Fisch committed rEASRe68b3b08a10d: Track usage of features (authored by kai.nissen).
Track usage of features
Tue, Nov 21, 1:52 PM
WMDE-Fisch moved T180043: Invalidate the diff cache if the engine producing the diff changes from Review to Done on the WMDE-QWERTY-Sprint-2017-11-14 board.
Tue, Nov 21, 11:51 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), WMDE-QWERTY-Sprint-2017-11-14, MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), Patch-For-Review, MediaWiki-History-or-Diffs, WMDE-QWERTY-Team-Board, TCB-Team
WMDE-Fisch moved T166882: Add tooltip to elements indicating a moved paragraph from Review to Done on the WMDE-QWERTY-Sprint-2017-11-14 board.
Tue, Nov 21, 11:51 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team
WMDE-Fisch added a comment to T180602: Add placeholder for title tags to the moved indicators.

See https://gerrit.wikimedia.org/r/#/c/392588

Tue, Nov 21, 7:50 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team

Mon, Nov 20

WMDE-Fisch added a comment to T179469: Investigation: Rollback nicely if any part of the move fails.

Another note here: The exception triggered in T176871, that occurs in the middle of the import seems to lead to an automatic "rollback" of the changes imported so far. Though I did not manage to figure yet how that works exactly.

Mon, Nov 20, 2:43 PM · WMDE-QWERTY-Sprint-2017-11-14, TCB-Team, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Team-Board, Move-Files-To-Commons
WMDE-Fisch moved T180602: Add placeholder for title tags to the moved indicators from Done to Doing on the WMDE-QWERTY-Sprint-2017-11-14 board.
Mon, Nov 20, 12:00 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team
WMDE-Fisch updated the task description for T180602: Add placeholder for title tags to the moved indicators.
Mon, Nov 20, 11:59 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team
WMDE-Fisch updated subscribers of T180602: Add placeholder for title tags to the moved indicators.

@Legoktm Is it possible to remove a version tag? Or do we just remove the code and tag 1.5.3?

Mon, Nov 20, 11:55 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team
WMDE-Fisch added a comment to T180602: Add placeholder for title tags to the moved indicators.

Ok totally makes sense, a bit bad luck that the changes to wikidiff2 moved really quickly this time and we have the placeholder in there already - but nothing set in stone yet we will just revert the patch and I will use the classes as hooks for the title.

Mon, Nov 20, 11:49 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team
WMDE-Fisch added a comment to T180602: Add placeholder for title tags to the moved indicators.

@Krinkle yeah the info is already there form the CSS that's true and I also could have used these to sneak in the title attributes. But I thought it might be better to separate things here so and avoid bounding... sure, thinking of it, with JS I just would have don the same depending on the classes to set the title tags, and I really did that in a first attempt but got the remark, that it would be nicer to have this in PHP so it does not depend on JS. ..... hmmm :-)

Mon, Nov 20, 9:29 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team

Fri, Nov 17

WMDE-Fisch moved T180602: Add placeholder for title tags to the moved indicators from Review to Done on the WMDE-QWERTY-Sprint-2017-11-14 board.
Fri, Nov 17, 6:51 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team
WMDE-Fisch added a comment to T176871: Importing https://commons.wikimedia.org/wiki/File:Labs_Tools_topology.png using FileImporter fails "Failed to commit operations.".

Looked a bit into it and it always seems to fail when trying to import
https://upload.wikimedia.org/wikipedia/commons/archive/8/8c/20151121185130%21Labs_Tools_topology.png
"Update for current state of tool labs"

Fri, Nov 17, 6:06 PM · WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Team-Board, User-Addshore, TCB-Team, Move-Files-To-Commons
WMDE-Fisch committed rERSLe868a33116a4: Refactor RevisionSlider toggle button CSS (authored by Volker E <volker.e@wikimedia.org>).
Refactor RevisionSlider toggle button CSS
Fri, Nov 17, 12:29 PM
WMDE-Fisch added a comment to T179277: Test moved paragraph behavior on test cluster.

Also tested and fixed the timeless skin. see T180663

Fri, Nov 17, 10:25 AM · WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Team-Board
WMDE-Fisch updated the task description for T179277: Test moved paragraph behavior on test cluster.
Fri, Nov 17, 10:21 AM · WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Team-Board
WMDE-Fisch moved T180663: Timless skin: moved paragraph indicator show dots on hover from Review to Done on the WMDE-QWERTY-Sprint-2017-11-14 board.
Fri, Nov 17, 10:20 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-History-or-Diffs, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, TCB-Team
WMDE-Fisch assigned T180602: Add placeholder for title tags to the moved indicators to jkroll.
Fri, Nov 17, 8:33 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team
WMDE-Fisch moved T180602: Add placeholder for title tags to the moved indicators from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2017-11-14 board.
Fri, Nov 17, 8:33 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team
WMDE-Fisch moved T166882: Add tooltip to elements indicating a moved paragraph from Doing to Review on the WMDE-QWERTY-Sprint-2017-11-14 board.
Fri, Nov 17, 8:33 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team

Thu, Nov 16

WMDE-Fisch added a comment to T177891: Update and use php-wikidiff2 1.5.1 & MovedParagraphDetectionCutoff in production.

> Also the RSS feeds just show the dots since no styles are applied: https://www.mediawiki.org/w/api.php?hidebots=1&days=14&limit=50&target=Category%3AOpen_requests_for_comment&translations=filter&action=feedrecentchanges&feedformat=atom&hidecategorization=1 though I think that's probably OK, it's just a limitation of the RSS format.
I'm not sure if it's actually possible for this feature, but it might be avoidable if you can add appropriate replacements to FeedUtils::applyDiffStyle().

Thu, Nov 16, 1:07 PM · WMDE-QWERTY-Sprint-2017-11-01, Patch-For-Review, Operations, User-Addshore, WMDE-QWERTY-Team-Board, wikidiff2
WMDE-Fisch claimed T180663: Timless skin: moved paragraph indicator show dots on hover.
Thu, Nov 16, 12:41 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-History-or-Diffs, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, TCB-Team
WMDE-Fisch moved T180663: Timless skin: moved paragraph indicator show dots on hover from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2017-11-14 board.
Thu, Nov 16, 12:41 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-History-or-Diffs, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, TCB-Team
WMDE-Fisch moved T180663: Timless skin: moved paragraph indicator show dots on hover from Proposed to Currently in sprint on the WMDE-QWERTY-Team-Board board.
Thu, Nov 16, 10:37 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-History-or-Diffs, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, TCB-Team
WMDE-Fisch created T180663: Timless skin: moved paragraph indicator show dots on hover.
Thu, Nov 16, 9:02 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), MediaWiki-History-or-Diffs, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, TCB-Team

Wed, Nov 15

WMDE-Fisch moved T180602: Add placeholder for title tags to the moved indicators from Proposed to Currently in sprint on the WMDE-QWERTY-Team-Board board.
Wed, Nov 15, 2:28 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team
WMDE-Fisch placed T180602: Add placeholder for title tags to the moved indicators up for grabs.
Wed, Nov 15, 2:27 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team
WMDE-Fisch created T180602: Add placeholder for title tags to the moved indicators.
Wed, Nov 15, 2:17 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team
WMDE-Fisch updated the task description for T179277: Test moved paragraph behavior on test cluster.
Wed, Nov 15, 1:08 PM · WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Team-Board
WMDE-Fisch added a comment to T179277: Test moved paragraph behavior on test cluster.

Looked into random mobile diffs on test.wikipedia.org and created some new changes and looked at the diffs. Got no error pages.

Wed, Nov 15, 10:19 AM · WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Team-Board
WMDE-Fisch added a comment to T179277: Test moved paragraph behavior on test cluster.

Tested ( Vector ):

  • Firefox 56 LTR / RTL
  • Chrome 62 LTR / RTL
  • Internet Explorer 9 / 10 / 11 LTR / RTL
  • Edge 14 LTR / RTL
  • Safari 11 LTR / RTL
Wed, Nov 15, 9:35 AM · WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Team-Board

Tue, Nov 14

WMDE-Fisch added a comment to T160181: Display new location in source wiki .

While working on this and starting a first approach with calling the API of the source wiki via CentralAuth token, we decided that the proper/better to do this is would be submitting a job on the sourcewiki that does the edit. We will work on that in another sprint and postpone the issue for now.

Tue, Nov 14, 5:32 PM · WMDE-QWERTY-Sprint-2017-11-01, Patch-For-Review, WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Sprint-2017-09-19, Move-Files-To-Commons, WMDE-QWERTY-Team-Board, TCB-Team
WMDE-Fisch claimed T180335: Link from beta feature to help page on mediawiki.org.
Tue, Nov 14, 11:58 AM · MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Team-Board, TCB-Team, Advanced-Search
WMDE-Fisch committed rEASRa4e3f23494bd: Change BetaFeatures links to Help: namespace pages (authored by WMDE-Fisch).
Change BetaFeatures links to Help: namespace pages
Tue, Nov 14, 11:57 AM
WMDE-Fisch committed rEASR44b033ed06db: Change BetaFeatures links to Help: namespace pages (authored by WMDE-Fisch).
Change BetaFeatures links to Help: namespace pages
Tue, Nov 14, 11:52 AM
WMDE-Fisch added a comment to T179469: Investigation: Rollback nicely if any part of the move fails.

Looking at Special:Import and the connected classes, there seems to be no special handling for failed imports. It just failes and stops the import where it is. E.g.: When importing a huge dump via Special:Import and it times out, the import will be done until some revision and nothing else will happen.

Tue, Nov 14, 10:36 AM · WMDE-QWERTY-Sprint-2017-11-14, TCB-Team, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Team-Board, Move-Files-To-Commons
WMDE-Fisch added a comment to T179469: Investigation: Rollback nicely if any part of the move fails.

So some findings from our yesterdays discussion ( feel free to add more ):

Tue, Nov 14, 9:29 AM · WMDE-QWERTY-Sprint-2017-11-14, TCB-Team, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Team-Board, Move-Files-To-Commons
WMDE-Fisch moved T161014: Support continuation in ApiDetailRetriever from Review to Done on the WMDE-QWERTY-Sprint-2017-11-01 board.
Tue, Nov 14, 9:05 AM · WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Sprint-2017-10-17, Patch-For-Review, WMDE-QWERTY-Sprint-2017-09-19, WMDE-QWERTY-Team-Board, Move-Files-To-Commons, TCB-Team, German-Community-Wishlist, MediaWiki-extension-requests, Commons
WMDE-Fisch created T180430: RevisionSlider overwrites Twinkle shortcuts.
Tue, Nov 14, 8:57 AM · WMDE-QWERTY-Team-Board, Revision-Slider, TCB-Team
WMDE-Fisch created T180429: Expose tags via the tooltip metadata .
Tue, Nov 14, 8:47 AM · Revision-Slider, TCB-Team

Mon, Nov 13

WMDE-Fisch added a comment to T169323: Change title of revision slider to "Browse history interactively".

Anyone with gerrit account and git / gerrit skills can do that. But also for a dev its a 1min task. So also feel free to add it to qwerty board.

Mon, Nov 13, 4:25 PM · WMDE-QWERTY-Team-Board, Revision-Slider, WMDE-Design, TCB-Team, Design
WMDE-Fisch added a comment to T180259: Investigate possible regression due to wikidiff2 1.5 change detection.

Thanks for all the example diffs, it's really important to see a bunch of variants in diffs to further improve the algorithm there.

Mon, Nov 13, 2:07 PM · WMDE-QWERTY-Sprint-2017-11-01, wikidiff2, WMDE-QWERTY-Team-Board, meta-ci-docker-diffs, TCB-Team
WMDE-Fisch added a comment to T180259: Investigate possible regression due to wikidiff2 1.5 change detection.

I am adding screenshots for the last examples. I think we got the idea now and will write something to that in the next post.

Mon, Nov 13, 1:50 PM · WMDE-QWERTY-Sprint-2017-11-01, wikidiff2, WMDE-QWERTY-Team-Board, meta-ci-docker-diffs, TCB-Team

Fri, Nov 10

WMDE-Fisch added a comment to T180259: Investigate possible regression due to wikidiff2 1.5 change detection.

Next diff: https://de.wikipedia.org/w/index.php?diff=170728571

Fri, Nov 10, 6:09 PM · WMDE-QWERTY-Sprint-2017-11-01, wikidiff2, WMDE-QWERTY-Team-Board, meta-ci-docker-diffs, TCB-Team
WMDE-Fisch added a comment to T180259: Investigate possible regression due to wikidiff2 1.5 change detection.

Next example: https://de.wikipedia.org/w/index.php?title=Benutzer:PDD/markAdmins.js&curid=3238133&diff=96378622&oldid=95771630

Fri, Nov 10, 5:52 PM · WMDE-QWERTY-Sprint-2017-11-01, wikidiff2, WMDE-QWERTY-Team-Board, meta-ci-docker-diffs, TCB-Team
WMDE-Fisch added a comment to T180259: Investigate possible regression due to wikidiff2 1.5 change detection.

Next example from the post: https://de.wikipedia.org/wiki/Spezial:Diff/170818650

Fri, Nov 10, 5:38 PM · WMDE-QWERTY-Sprint-2017-11-01, wikidiff2, WMDE-QWERTY-Team-Board, meta-ci-docker-diffs, TCB-Team
WMDE-Fisch added a comment to T180259: Investigate possible regression due to wikidiff2 1.5 change detection.

I imported an example from the thread to my local wiki and opened the diff with an older version of wikidiff2 and the current version. Results:

Fri, Nov 10, 5:13 PM · WMDE-QWERTY-Sprint-2017-11-01, wikidiff2, WMDE-QWERTY-Team-Board, meta-ci-docker-diffs, TCB-Team
WMDE-Fisch updated the task description for T180259: Investigate possible regression due to wikidiff2 1.5 change detection.
Fri, Nov 10, 5:00 PM · WMDE-QWERTY-Sprint-2017-11-01, wikidiff2, WMDE-QWERTY-Team-Board, meta-ci-docker-diffs, TCB-Team
WMDE-Fisch created T180259: Investigate possible regression due to wikidiff2 1.5 change detection.
Fri, Nov 10, 4:59 PM · WMDE-QWERTY-Sprint-2017-11-01, wikidiff2, WMDE-QWERTY-Team-Board, meta-ci-docker-diffs, TCB-Team
WMDE-Fisch added a comment to T180204: AdvancedSearch does not reliably show up on beta.

Hmm tried it about 30-40 times and it always worked for me. ... There is an error in the JS console showing each time. But it's not coming from any AdvSearch code. :-/

Fri, Nov 10, 1:24 PM · WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Team-Board, Advanced-Search, TCB-Team
WMDE-Fisch added a project to T180204: AdvancedSearch does not reliably show up on beta: WMDE-QWERTY-Sprint-2017-11-01.
Fri, Nov 10, 1:06 PM · WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Team-Board, Advanced-Search, TCB-Team
WMDE-Fisch committed rEASR83fea963515c: Get the original input when comming from a standard search (authored by WMDE-Fisch).
Get the original input when comming from a standard search
Fri, Nov 10, 12:50 PM
WMDE-Fisch claimed T180206: Words entered in the normal title search are not added to Special:Search forms.
Fri, Nov 10, 12:49 PM · MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-01, TCB-Team, WMDE-QWERTY-Team-Board, Advanced-Search
WMDE-Fisch added a project to T180206: Words entered in the normal title search are not added to Special:Search forms: WMDE-QWERTY-Sprint-2017-11-01.
Fri, Nov 10, 12:45 PM · MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-01, TCB-Team, WMDE-QWERTY-Team-Board, Advanced-Search
WMDE-Fisch moved T180206: Words entered in the normal title search are not added to Special:Search forms from Proposed to Currently in sprint on the WMDE-QWERTY-Team-Board board.
Fri, Nov 10, 12:45 PM · MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-01, TCB-Team, WMDE-QWERTY-Team-Board, Advanced-Search
WMDE-Fisch committed rERSLbad0276ae10d: Refactor RevisionSlider toggle button CSS (authored by Volker E <volker.e@wikimedia.org>).
Refactor RevisionSlider toggle button CSS
Fri, Nov 10, 10:49 AM

Thu, Nov 9

WMDE-Fisch committed rERSLb75c45b46830: Refactor RevisionSlider toggle button CSS (authored by Volker E <volker.e@wikimedia.org>).
Refactor RevisionSlider toggle button CSS
Thu, Nov 9, 8:47 AM

Wed, Nov 8

WMDE-Fisch updated subscribers of T180043: Invalidate the diff cache if the engine producing the diff changes.
Wed, Nov 8, 3:23 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), WMDE-QWERTY-Sprint-2017-11-14, MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), Patch-For-Review, MediaWiki-History-or-Diffs, WMDE-QWERTY-Team-Board, TCB-Team
WMDE-Fisch moved T180043: Invalidate the diff cache if the engine producing the diff changes from Proposed to Todo on the WMDE-QWERTY-Team-Board board.
Wed, Nov 8, 3:22 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), WMDE-QWERTY-Sprint-2017-11-14, MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), Patch-For-Review, MediaWiki-History-or-Diffs, WMDE-QWERTY-Team-Board, TCB-Team
WMDE-Fisch added a parent task for T180043: Invalidate the diff cache if the engine producing the diff changes: T146781: Show changes in moved text chunks (C++).
Wed, Nov 8, 3:21 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), WMDE-QWERTY-Sprint-2017-11-14, MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), Patch-For-Review, MediaWiki-History-or-Diffs, WMDE-QWERTY-Team-Board, TCB-Team
WMDE-Fisch added a subtask for T146781: Show changes in moved text chunks (C++): T180043: Invalidate the diff cache if the engine producing the diff changes.
Wed, Nov 8, 3:21 PM · WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Sprint-2017-07-25, wikidiff2, Patch-For-Review, WMDE-QWERTY-Team-Board, WMDE-QWERTY-Team-Experimental-Sprint, German-Community-Wishlist, TCB-Team, MediaWiki-History-or-Diffs
WMDE-Fisch created T180043: Invalidate the diff cache if the engine producing the diff changes.
Wed, Nov 8, 3:20 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), WMDE-QWERTY-Sprint-2017-11-14, MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), Patch-For-Review, MediaWiki-History-or-Diffs, WMDE-QWERTY-Team-Board, TCB-Team
WMDE-Fisch committed rEASRc967019ae7d5: Minor fixes in the help texts (authored by WMDE-Fisch).
Minor fixes in the help texts
Wed, Nov 8, 3:09 PM
WMDE-Fisch moved T176486: Add CSS to style moved paragraphs marker in the diff view from Review to Done on the WMDE-QWERTY-Sprint-2017-11-01 board.
Wed, Nov 8, 3:09 PM · WMDE-QWERTY-Sprint-2017-11-01, Patch-For-Review, WMDE-QWERTY-Sprint-2017-10-17, WMDE-Design, MediaWiki-History-or-Diffs, WMDE-QWERTY-Sprint-2017-09-19, WMDE-QWERTY-Team-Board, Design, TCB-Team
WMDE-Fisch committed rEASRd9591a7c40d7: Replace kittens by goats in placeholder (authored by WMDE-Fisch).
Replace kittens by goats in placeholder
Wed, Nov 8, 11:51 AM
WMDE-Fisch committed rERSL7d46c9321109: Refactor RevisionSlider toggle button CSS (authored by Volker E <volker.e@wikimedia.org>).
Refactor RevisionSlider toggle button CSS
Wed, Nov 8, 9:45 AM
WMDE-Fisch committed rERSL1c040ae6d617: Refactor RevisionSlider toggle button CSS (authored by Volker E <volker.e@wikimedia.org>).
Refactor RevisionSlider toggle button CSS
Wed, Nov 8, 9:45 AM
WMDE-Fisch added a comment to T177891: Update and use php-wikidiff2 1.5.1 & MovedParagraphDetectionCutoff in production.

Then I guess we can cherry pick that to the wmf branch? :)

+1 @Addshore

Wed, Nov 8, 8:54 AM · WMDE-QWERTY-Sprint-2017-11-01, Patch-For-Review, Operations, User-Addshore, WMDE-QWERTY-Team-Board, wikidiff2

Tue, Nov 7

WMDE-Fisch claimed T166882: Add tooltip to elements indicating a moved paragraph.
Tue, Nov 7, 11:55 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team
WMDE-Fisch added a comment to T166882: Add tooltip to elements indicating a moved paragraph.

If I remember it right from month back when we already discussed this once, this was more an architecture/coupling question to do it or not to do it: "Putting out HTML via C++ makes it hard to change and hard to reason where this comes from, so it > should be kept to a minimum" would be one hypothesis that spoke against need-to-be-translated tooltips in HTML.

Tue, Nov 7, 10:31 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team

Sat, Nov 4

WMDE-Fisch added a comment to T166882: Add tooltip to elements indicating a moved paragraph.

D'oh! Yeah your right, we do not necessarily need JS for that. Somehow I thought "parsing" HTML the output of wikidiff2 and doing things there is kind of ugly.

Sat, Nov 4, 9:27 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team

Wed, Nov 1

WMDE-Fisch added a comment to T166882: Add tooltip to elements indicating a moved paragraph.

Paragraph was moved. Click to jump to new location

Wed, Nov 1, 6:51 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team
WMDE-Fisch added a comment to T179056: Disable TwoColumnEditClonflit on Wikisource waiting for ProofreadPage support.

Hey, the last weeks a major refactoring of the EditPage[1] and TwoColConflict[2] took place to change the way it hooks into the EditPage. TwoColConflict now does not override the EditPage and so it should work with ProofreadPage when it's deployed.

Wed, Nov 1, 10:00 AM · Patch-For-Review, Wikimedia-Site-requests, Wikisource, TCB-Team, Two-Column-Edit-Conflict-Merge

Mon, Oct 30

WMDE-Fisch committed rESCC9160f4bfe9b5: Refactor to extend TextConflictHelper instead of EditPage (authored by Legoktm).
Refactor to extend TextConflictHelper instead of EditPage
Mon, Oct 30, 3:25 PM
WMDE-Fisch committed rESCC76b5b6acbc64: Refactor to extend TextConflictHelper instead of EditPage (authored by Legoktm).
Refactor to extend TextConflictHelper instead of EditPage
Mon, Oct 30, 3:01 PM
WMDE-Fisch committed rERSL971205698212: Use LESS nesting features (authored by Esanders).
Use LESS nesting features
Mon, Oct 30, 12:58 PM
WMDE-Fisch claimed T176393: TwoColConflict is overriding EditPage for all ContentFormats.
Mon, Oct 30, 12:09 PM · WMDE-QWERTY-Sprint-2017-10-17, MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), WMDE-QWERTY-Team-Board, MediaWiki-Page-editing, Patch-For-Review, TCB-Team, Two-Column-Edit-Conflict-Merge, ProofreadPage, Wikisource
WMDE-Fisch moved T176393: TwoColConflict is overriding EditPage for all ContentFormats from Watching/Blocked/External to Todo on the WMDE-QWERTY-Team-Board board.
Mon, Oct 30, 12:09 PM · WMDE-QWERTY-Sprint-2017-10-17, MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), MediaWiki-Platform-Team (MWPT-Q2-Oct-Dec-2017), WMDE-QWERTY-Team-Board, MediaWiki-Page-editing, Patch-For-Review, TCB-Team, Two-Column-Edit-Conflict-Merge, ProofreadPage, Wikisource

Fri, Oct 27

WMDE-Fisch added a comment to T160181: Display new location in source wiki .

Also for clarification: The plan here is to have a default message hardcoded (without i18n) but with the option to be customized via a config var ($wgFileImporter....) - see T160182#3714953

Fri, Oct 27, 9:43 AM · WMDE-QWERTY-Sprint-2017-11-01, Patch-For-Review, WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Sprint-2017-09-19, Move-Files-To-Commons, WMDE-QWERTY-Team-Board, TCB-Team
WMDE-Fisch added a comment to T160182: Display original location in Commons.

So after a quick talk with @Lea_WMDE : The plan here is to have a default message hardcoded (without i18n) but with the option to be customized via a config var ($wgFileImporter....)

Fri, Oct 27, 9:41 AM · WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Sprint-2017-09-19, Patch-For-Review, WMDE-QWERTY-Sprint-2017-09-05, Move-Files-To-Commons, German-Community-Wishlist, WMDE-QWERTY-Team-Board, TCB-Team
WMDE-Fisch updated subscribers of T166882: Add tooltip to elements indicating a moved paragraph.

So my current idea to solve this would be:

  • Adding some JS that looks out for the classes indicating a move paragraph in the wikidiff2 output.
  • The JS runs wherever a diff is present and then dynamically adds a translatable title attribute to the tags there.
Fri, Oct 27, 9:20 AM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, WMDE-QWERTY-Sprint-2017-11-14, WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team

Thu, Oct 26

WMDE-Fisch moved T161013: Check in CentralAuth to see if users can be maintained on the import from Review to Done on the WMDE-QWERTY-Sprint-2017-10-17 board.
Thu, Oct 26, 1:59 PM · WMDE-QWERTY-Sprint-2017-10-17, User-Addshore, WMDE-QWERTY-Sprint-2017-09-19, WMDE-QWERTY-Sprint-2017-09-05, Move-Files-To-Commons, WMDE-QWERTY-Team-Board, TCB-Team
WMDE-Fisch moved T177382: Broken and unneeded(?) Link to Editnotice from Doing to Review on the WMDE-QWERTY-Sprint-2017-10-17 board.
Thu, Oct 26, 1:28 PM · MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)), Patch-For-Review, WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Team-Board, Two-Column-Edit-Conflict-Merge, TCB-Team
WMDE-Fisch committed rESCC92d5ffbc79f1: Deactivate page specific edit notices on conflict simulation page (authored by WMDE-Fisch).
Deactivate page specific edit notices on conflict simulation page
Thu, Oct 26, 1:22 PM
WMDE-Fisch claimed T177382: Broken and unneeded(?) Link to Editnotice.
Thu, Oct 26, 1:20 PM · MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)), Patch-For-Review, WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Team-Board, Two-Column-Edit-Conflict-Merge, TCB-Team
WMDE-Fisch committed rESCCb38f0c51c25a: Refactor to extend TextConflictHelper instead of EditPage (authored by Legoktm).
Refactor to extend TextConflictHelper instead of EditPage
Thu, Oct 26, 8:30 AM
WMDE-Fisch committed rESCC0373c5cc7ea6: Refactor to extend TextConflictHelper instead of EditPage (authored by Legoktm).
Refactor to extend TextConflictHelper instead of EditPage
Thu, Oct 26, 8:27 AM
WMDE-Fisch committed rESCC9a487177fdde: Refactor to extend TextConflictHelper instead of EditPage (authored by Legoktm).
Refactor to extend TextConflictHelper instead of EditPage
Thu, Oct 26, 8:25 AM

Wed, Oct 25

WMDE-Fisch committed rESCC43e0ece0cb01: Refactor to extend TextConflictHelper instead of EditPage (authored by Legoktm).
Refactor to extend TextConflictHelper instead of EditPage
Wed, Oct 25, 3:56 PM
WMDE-Fisch moved T176486: Add CSS to style moved paragraphs marker in the diff view from Doing to Review on the WMDE-QWERTY-Sprint-2017-10-17 board.
Wed, Oct 25, 2:42 PM · WMDE-QWERTY-Sprint-2017-11-01, Patch-For-Review, WMDE-QWERTY-Sprint-2017-10-17, WMDE-Design, MediaWiki-History-or-Diffs, WMDE-QWERTY-Sprint-2017-09-19, WMDE-QWERTY-Team-Board, Design, TCB-Team
WMDE-Fisch claimed T176486: Add CSS to style moved paragraphs marker in the diff view.
Wed, Oct 25, 1:02 PM · WMDE-QWERTY-Sprint-2017-11-01, Patch-For-Review, WMDE-QWERTY-Sprint-2017-10-17, WMDE-Design, MediaWiki-History-or-Diffs, WMDE-QWERTY-Sprint-2017-09-19, WMDE-QWERTY-Team-Board, Design, TCB-Team
WMDE-Fisch committed rESCC9d6acc8a2011: Improve keyboard navigation on simulation page (authored by WMDE-Fisch).
Improve keyboard navigation on simulation page
Wed, Oct 25, 11:29 AM
WMDE-Fisch committed rESCCc12a3ac9b265: Improve keyboard navigation on simulation page (authored by WMDE-Fisch).
Improve keyboard navigation on simulation page
Wed, Oct 25, 11:29 AM
WMDE-Fisch committed rESCCf66b1314edce: Address Safari issues with broken IE mixin (authored by WMDE-Fisch).
Address Safari issues with broken IE mixin
Wed, Oct 25, 11:29 AM
WMDE-Fisch committed rESCC7bd889a78119: Improve keyboard navigation on simulation page (authored by WMDE-Fisch).
Improve keyboard navigation on simulation page
Wed, Oct 25, 11:02 AM
WMDE-Fisch claimed T178353: jQuery.IME broken in Two column edit conflict.
Wed, Oct 25, 10:49 AM · WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Team-Board, MediaWiki-extensions-UniversalLanguageSelector, TCB-Team, Two-Column-Edit-Conflict-Merge
WMDE-Fisch committed rESCC4a76bed81836: Address Safari issues with broken IE mixin (authored by WMDE-Fisch).
Address Safari issues with broken IE mixin
Wed, Oct 25, 10:45 AM
WMDE-Fisch moved T178164: Two Column Edit Conflict doesn't show two columns in Safari from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2017-10-17 board.
Wed, Oct 25, 10:44 AM · MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)), Patch-For-Review, WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Team-Board, Browser-Support-Apple-Safari, TCB-Team, Two-Column-Edit-Conflict-Merge
WMDE-Fisch added a comment to T178164: Two Column Edit Conflict doesn't show two columns in Safari.

Ok found a way to reproduce it. A patch is underway :-).

Wed, Oct 25, 10:43 AM · MW-1.31-release-notes (WMF-deploy-2017-10-31 (1.31.0-wmf.6)), Patch-For-Review, WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Team-Board, Browser-Support-Apple-Safari, TCB-Team, Two-Column-Edit-Conflict-Merge

Tue, Oct 24

WMDE-Fisch added a comment to T178353: jQuery.IME broken in Two column edit conflict.

Ok it's me again. I just tried to reproduce it by looking at the steps in the ticket linked ( T176104 ). I adjusted the steps to use the conflict simulation page

Tue, Oct 24, 12:45 PM · WMDE-QWERTY-Sprint-2017-11-01, WMDE-QWERTY-Sprint-2017-10-17, WMDE-QWERTY-Team-Board, MediaWiki-extensions-UniversalLanguageSelector, TCB-Team, Two-Column-Edit-Conflict-Merge