Fri, Jan 14
Aaaaand another edge case: What should the user see, when there are no parameters at all?
Wed, Jan 12
While implementing this: What should happen, if no parameter is used and you hide the unused. Should there be some text or do we show an empty nothing :-D?
Tue, Jan 11
Mon, Jan 10
While reviewing this I stumbled a bit over All changes will be lost and cannot be undone.. Personally I would find it more clear if the text somewhat emphasizes on pending changes. Just to make clear, that the "original" values still remain.
awight moved this task from Done to Sprint Backlog on the WMDE-TechWish-XMAS-Sprint-2021-12-15 board.
Ah just saw that now ... any reason for that?
The fix was applied and the issue was resolved on Github.
Tue, Jan 4
Thu, Dec 23
Wed, Dec 22
Soo I looked at the last available 25 daily test runs. Mostly it's random but two cases stood out:
Tue, Dec 21
It even works with an arbitrary number of newlines and space in between. I wonder if this is really used somewhere .... If done from scratch I would say, that newlines should be forbidden in parameter names. But if the system is currently allowing this in source code it should be made sure, that it does not break when your editing a page with VE or any other tool.
Mon, Dec 20
Ok this does not seem to make sense without JS anyways. Soooo is it relevant?
Dec 16 2021
Dec 14 2021
Dec 13 2021
Dec 7 2021
We'll for now not work on the progress bar. A third option to consider here would be disabling the Edit button as long as the dialog loads. This way users might get a better understanding, that something happens and will not start clicking several times. - This would be easy to implement.
- The instructions are currently arranged in a way that makes it sound like you need to select a part with space first before you can move/remove it. That's only partially true. The selected state only matters when you continue pressing tab and navigate down to the toolbar. The toolbar buttons act on the selected part. But that's not what the ARIA description is about. Ctrl+Shift+Cursor and Ctrl+Del act on the focused part. No need to press space first. Selection doesn't matter. That would be confusing for a screenreader user as they can't easily see which element is selected the moment they press Ctrl+Shift+Cursor and Ctrl+Del. Instead the hotkeys act on the same element that contains the description where the hotkeys are mentioned, i.e. the focused element.
- Because of this the ARIA description is almost always the shortest "Press Space to select the template.". This includes all parts of a multi-part template, as long as none is selected.
Summary: As of now the hotkeys almost always work (the only exception are the move keys on single-parts), but are almost never announced because of the 2 problems described above.
- The message "If known, enter undocumented parameter names. Note that only parameters known by the template will have an effect. You may find information about existing parameters on the template's page." should also get a link to http://www.mediawiki.org/wiki/Special:MyLanguage/Help:VisualEditor/User_guide#Adding_undocumented_parameters. While this message might appear together with the other message that talks about undocumented parameters, this is rare. Repeating the link seems helpful. @ECohen_WMDE, ok for you?
I guess this can be closed now. Please feel free re-open if there's anything remaining that needs to be taken care of.