Page MenuHomePhabricator

WMDE-leszek (Leszek Manicki)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 3 2015, 10:26 AM (198 w, 6 d)
Availability
Available
LDAP User
WMDE-leszek
MediaWiki User
Leszek Manicki (WMDE) [ Global Accounts ]

Recent Activity

Today

WMDE-leszek added a comment to T218921: Federated remote entities in diffs show as deleted.

Update: I tried disabling "old style" federation, and it immediately and totally broke (PHP fatal, "No entity source provides properties!").

Tue, Mar 26, 9:37 AM · Multimedia-Current-Work, SDC Engineering, SDC-Depicts (Depicts-Crawling), Multimedia, Wikidata, Wikidata-Campsite

Fri, Mar 22

WMDE-leszek added a comment to T218907: $UNIQ[hash]$ on Special:Undelete for items.

I believe this would mean "backporting" to the production branch in a SWAT deployment window. Given it's Friday today, this would need to wait until Monday?
@Addshore @Tarrow @Lucas_Werkmeister_WMDE as deployers, could you please assist with this?

Fri, Mar 22, 11:50 AM · Wikidata-Termbox-Iteration-12 ✓, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Wikidata-Termbox-Iteration-11, Wikidata

Thu, Mar 21

WMDE-leszek added a comment to T218825: PHP Fatal Error: Argument 1 passed to Wikibase\Rdf\RdfBuilder::addEntityRedirect() must be an instance of Wikibase\DataModel\Entity\EntityId, null given.

Caused by 493096?

Thu, Mar 21, 8:21 AM · Wikidata-Campsite, Wikidata, User-zeljkofilipin, Wikimedia-production-error
Mill <mill@mail.com> committed rADES409bfe43111e: bibaaaaaaaaaaa (authored by WMDE-leszek).
bibaaaaaaaaaaa
Thu, Mar 21, 12:19 AM

Wed, Mar 20

WMDE-leszek added a comment to T217157: Make sure federation works on beta.

When given Q-id or P-id as a search term to beta commons' wbsearchentities API, the API returns search results matching the item/property from beta Wikidata

This won't work, as the local search index doesn't contain wikidata items. We think this is ok, because we can (and do) call wbsearchentities on wikidata directly from commons

Wed, Mar 20, 7:49 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Multimedia-Current-Work, Patch-For-Review, SDC-Depicts (Depicts-Crawling), Wikidata, Wikidata-Campsite, SDC Engineering (Depicts-Crawling), Multimedia
WMDE-leszek set the point value for T217334: Allow adding of a not yet existing language to 13.
Wed, Mar 20, 3:32 PM · Wikidata, Wikidata-Termbox-Hike
WMDE-leszek moved T218291: Model ULS dependency from In preparation to should dos on the Wikidata-Termbox-Hike board.
Wed, Mar 20, 3:13 PM · Wikidata, Wikidata-Termbox-Hike
WMDE-leszek set the point value for T218291: Model ULS dependency to 1.
Wed, Mar 20, 3:13 PM · Wikidata, Wikidata-Termbox-Hike
WMDE-leszek added a comment to T218291: Model ULS dependency.

For the time being, hard dependency on ULS is fine from Product side. This decision is going to be revisited before using the new termbox on Desktop.

Wed, Mar 20, 3:12 PM · Wikidata, Wikidata-Termbox-Hike
Restricted Application updated subscribers of T215217: deployment-prep: Code stewardship request.
Wed, Mar 20, 12:43 PM · Beta-Cluster-Infrastructure, Code-Stewardship-Reviews
WMDE-leszek moved T205279: Add tooltip for statements linking to Form from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Mar 20, 12:42 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Lexicographical data, Wikidata

Mon, Mar 18

WMDE-leszek added a comment to T218456: mwselenium-quibble-docker test broken for WikibaseLexeme.

Wikibase might be affected too https://integration.wikimedia.org/ci/job/mwselenium-quibble-docker/10022/console

Mon, Mar 18, 2:04 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), CirrusSearch, Discovery-Search, Patch-For-Review, User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error (Shared Build Failure), Wikidata, Lexicographical data
WMDE-leszek added a comment to T217157: Make sure federation works on beta.

The ones @Cparle has added to the task description looks pretty good, and for the file page it might be it.
A list of possible further things to check, admittedly often not that end-user-facing ones. I'll let @Cparle and @Ramsey-WMF decide which of these deserve to be promoted to "acceptance criteria", and which are just things to test the verify that all works (tm).

Mon, Mar 18, 12:17 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Multimedia-Current-Work, Patch-For-Review, SDC-Depicts (Depicts-Crawling), Wikidata, Wikidata-Campsite, SDC Engineering (Depicts-Crawling), Multimedia

Sat, Mar 16

WMDE-leszek awarded T212521: RFC: Let's stop using QUnit as a mechanism for integration tests a Like token.
Sat, Mar 16, 3:50 PM · TechCom-RFC, Patch-For-Review, User-Jdlrobson
WMDE-leszek awarded T199004: RFC: Add a frontend build step to skins/extensions to our deploy process a Like token.
Sat, Mar 16, 3:50 PM · TechCom-RFC, Proposal, User-Jdlrobson

Wed, Mar 13

WMDE-leszek added a comment to T216692: Security review for WikibaseSchema.

@Reedy: I understand the concern. The extension is under active development of team of four developers, hence the significant commit count. The major part of the extension's functionality is there, and its general structure is considered set, so (arguably of course) ,the extension is ready for the security readiness review.

Wed, Mar 13, 6:01 PM · Security-Team-Review-Active, Shape Expressions, Wikidata
WMDE-leszek added a comment to T212189: New Service Request: Wikidata Termbox SSR.

Final question and just for verification, this ain't going to be exposed directly to the internet after all, right? Rather this will be called by mediawiki, per the architectural diagrams attached to this task.

Wed, Mar 13, 9:34 AM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations
WMDE-leszek added a comment to T213483: Fatal error: null EntityId argument passed to addEntityRedirect (Special:EntityData broken for some items).

@Jdforrester-WMF yup.
Those config changes would be rather straightforward, and I am sure you'd be able to cook them yourselves. I've drafted https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/490586 and https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/490587 a while back. I wouldn't object if those were SWAT'ed. If helpful WMDE would try to help with deployment these (verification etc), although as you already know, we're generally only available in those crazy European times

Wed, Mar 13, 8:31 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review, Wikimedia-production-error, WikibaseMediaInfo, StructuredDataOnCommons
WMDE-leszek added a comment to T218135: +2 in mediawiki/* for WMDE engineers.

Jeroen De Dauw already has 2 failed requests for +2 in mediawiki/core 1 2. Admittedly this was a long time ago, but the last time he did anything non-trivial in MW core was in 2013. I feel like this is sort of a backdoor around previous community consensus.

Wed, Mar 13, 8:26 AM · MediaWiki-Gerrit-Group-Requests
WMDE-leszek updated the task description for T218135: +2 in mediawiki/* for WMDE engineers.
Wed, Mar 13, 8:07 AM · MediaWiki-Gerrit-Group-Requests
WMDE-leszek updated the task description for T218135: +2 in mediawiki/* for WMDE engineers.
Wed, Mar 13, 8:07 AM · MediaWiki-Gerrit-Group-Requests
WMDE-leszek updated the task description for T218135: +2 in mediawiki/* for WMDE engineers.
Wed, Mar 13, 7:34 AM · MediaWiki-Gerrit-Group-Requests

Tue, Mar 12

WMDE-leszek updated the task description for T218135: +2 in mediawiki/* for WMDE engineers.
Tue, Mar 12, 6:47 PM · MediaWiki-Gerrit-Group-Requests
WMDE-leszek updated the task description for T218135: +2 in mediawiki/* for WMDE engineers.
Tue, Mar 12, 5:46 PM · MediaWiki-Gerrit-Group-Requests
Addshore awarded T218135: +2 in mediawiki/* for WMDE engineers a Like token.
Tue, Mar 12, 5:42 PM · MediaWiki-Gerrit-Group-Requests
WMDE-leszek created T218135: +2 in mediawiki/* for WMDE engineers.
Tue, Mar 12, 5:41 PM · MediaWiki-Gerrit-Group-Requests
WMDE-leszek awarded T173156: Goat t-shirts for goatification advancement a Meh! token.
Tue, Mar 12, 5:17 PM · Wikimania-Hackathon-2017, Goatification, WMF-Communications
WMDE-leszek added a comment to T212189: New Service Request: Wikidata Termbox SSR.

I have to say I am wondering a bit about the latency as the low end seems to be quite high (500ms?). It's your service of course and I am fine with it.

Tue, Mar 12, 11:32 AM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations

Mon, Mar 11

WMDE-leszek set Sprint Start Date to Sun, Mar 10, 11:00 PM on Wikidata-Termbox-Iteration-11.
Mon, Mar 11, 7:44 AM
WMDE-leszek created Wikidata-Termbox-Iteration-11.
Mon, Mar 11, 7:43 AM

Thu, Mar 7

WMDE-leszek placed T213483: Fatal error: null EntityId argument passed to addEntityRedirect (Special:EntityData broken for some items) up for grabs.
Thu, Mar 7, 3:42 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review, Wikimedia-production-error, WikibaseMediaInfo, StructuredDataOnCommons
WMDE-leszek moved T213483: Fatal error: null EntityId argument passed to addEntityRedirect (Special:EntityData broken for some items) from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Mar 7, 3:42 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review, Wikimedia-production-error, WikibaseMediaInfo, StructuredDataOnCommons
WMDE-leszek added a comment to T216730: Enable musical notation datatype.

Rock'n'roll!

Thu, Mar 7, 3:15 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
WMDE-leszek added a comment to T213483: Fatal error: null EntityId argument passed to addEntityRedirect (Special:EntityData broken for some items).

No, RDF is not working for MediaInfo in general, and hence we (WMDE) suggested to disable it until the RDF mapping is done, and Structured Data on Commons team decides to enable RDF output back.

Thu, Mar 7, 3:12 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review, Wikimedia-production-error, WikibaseMediaInfo, StructuredDataOnCommons
WMDE-leszek updated subscribers of T212189: New Service Request: Wikidata Termbox SSR.

@akosiaris thanks for listing up information needed by SRE. This is very helpful.
Before I add those to the task description, we'd appreciated you having a look at these (especially SLOs) and advice in case we are somehow off. In particular, given the service is going to be accessed via MediaWiki, its availability is depending on availability of MW. As we don't know what is the uptime of Wikipedia, so please tell us if we're going over board here.

Thu, Mar 7, 8:45 AM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations

Wed, Mar 6

WMDE-leszek updated subscribers of T217157: Make sure federation works on beta.

I _guess_ this might be a different manifestation of T214544 ?

Wed, Mar 6, 10:17 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Multimedia-Current-Work, Patch-For-Review, SDC-Depicts (Depicts-Crawling), Wikidata, Wikidata-Campsite, SDC Engineering (Depicts-Crawling), Multimedia

Tue, Mar 5

WMDE-leszek updated the task description for T217335: Call to the Wikibase API for entity types that are not enabled it should been handled gracefully, not surface as an exception.
Tue, Mar 5, 4:26 PM · Wikidata, Wikidata-Campsite
WMDE-leszek moved T213483: Fatal error: null EntityId argument passed to addEntityRedirect (Special:EntityData broken for some items) from Incoming to Ready to go on the Wikidata-Campsite board.
Tue, Mar 5, 1:33 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review, Wikimedia-production-error, WikibaseMediaInfo, StructuredDataOnCommons
WMDE-leszek added a project to T213483: Fatal error: null EntityId argument passed to addEntityRedirect (Special:EntityData broken for some items): Wikidata-Campsite.
Tue, Mar 5, 1:32 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review, Wikimedia-production-error, WikibaseMediaInfo, StructuredDataOnCommons

Mon, Mar 4

WMDE-leszek moved T217569: Enable publishing of SSR service to the Wikimedia Registry from should dos to Backlog on the Wikidata-Termbox-Hike board.
Mon, Mar 4, 4:25 PM · Wikidata, Wikidata-Termbox-Hike
WMDE-leszek moved T217569: Enable publishing of SSR service to the Wikimedia Registry from Backlog to should dos on the Wikidata-Termbox-Hike board.
Mon, Mar 4, 4:24 PM · Wikidata, Wikidata-Termbox-Hike

Fri, Mar 1

WMDE-leszek added a comment to T216050: Set up the Github mirror for Gerrit repository wikibase/termbox.

Understood, thanks @hashar. We'll be able to ask more precise questions next time.

Fri, Mar 1, 12:16 PM · Wikidata, GitHub-Mirrors, Gerrit
WMDE-leszek added a comment to T216050: Set up the Github mirror for Gerrit repository wikibase/termbox.

thanks!

Fri, Mar 1, 9:50 AM · Wikidata, GitHub-Mirrors, Gerrit
WMDE-leszek awarded Blog Post: Choosing tools for continuous integration a Like token.
Fri, Mar 1, 8:27 AM
WMDE-leszek added a comment to T216050: Set up the Github mirror for Gerrit repository wikibase/termbox.

Thanks @Reedy. https://github.com/wikimedia/wikibase-termbox seems empty though.

Fri, Mar 1, 8:17 AM · Wikidata, GitHub-Mirrors, Gerrit

Thu, Feb 28

WMDE-leszek updated subscribers of T216050: Set up the Github mirror for Gerrit repository wikibase/termbox.

Shamelessly pinging @Reedy as was recently seen doing similar thing in T216692

Thu, Feb 28, 5:20 PM · Wikidata, GitHub-Mirrors, Gerrit
WMDE-leszek added a comment to T217285: commonswiki / wikibase: Postcondition failed: Namespace for entity type property must be defined!.

This indeed sounds like a good idea @hashar. Filed T217335.

Thu, Feb 28, 3:18 PM · SDC General, Wikidata-Campsite, MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), WikibaseMediaInfo, Wikidata, Wikimedia-production-error
WMDE-leszek created T217335: Call to the Wikibase API for entity types that are not enabled it should been handled gracefully, not surface as an exception.
Thu, Feb 28, 3:17 PM · Wikidata, Wikidata-Campsite

Wed, Feb 27

WMDE-leszek set the point value for T217244: Column layout breaks in Chrome when using Emoji to 2.
Wed, Feb 27, 3:58 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Wikidata-Termbox-Iteration-11, Wikidata-Termbox-Iteration-10, Patch-For-Review, Wikidata
WMDE-leszek set the point value for T215951: Cancel edit mode to return to reading mode to 5.
Wed, Feb 27, 3:51 PM · Wikidata, Epic, Wikidata-Termbox-Hike
WMDE-leszek updated the task description for T215951: Cancel edit mode to return to reading mode.
Wed, Feb 27, 3:43 PM · Wikidata, Epic, Wikidata-Termbox-Hike
WMDE-leszek set the point value for T217000: Support users when editing an entry to 2.
Wed, Feb 27, 3:39 PM · Wikidata, Wikidata-Termbox-Hike
WMDE-leszek updated the task description for T217000: Support users when editing an entry.
Wed, Feb 27, 3:35 PM · Wikidata, Wikidata-Termbox-Hike
WMDE-leszek set the point value for T217248: Enforce a character limit to entry fields of the label and description fields to 5.
Wed, Feb 27, 3:35 PM · Wikidata, Wikidata-Termbox-Hike
WMDE-leszek created T217248: Enforce a character limit to entry fields of the label and description fields.
Wed, Feb 27, 3:35 PM · Wikidata, Wikidata-Termbox-Hike
WMDE-leszek updated the task description for T217000: Support users when editing an entry.
Wed, Feb 27, 3:30 PM · Wikidata, Wikidata-Termbox-Hike
WMDE-leszek updated the task description for T217000: Support users when editing an entry.
Wed, Feb 27, 3:29 PM · Wikidata, Wikidata-Termbox-Hike
WMDE-leszek updated the task description for T217000: Support users when editing an entry.
Wed, Feb 27, 3:27 PM · Wikidata, Wikidata-Termbox-Hike
WMDE-leszek set the point value for T215494: Make all page actions fit new (less high) id header to 2.
Wed, Feb 27, 3:22 PM · Wikidata-Termbox-Iteration-12 ✓, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Wikidata-Termbox-Iteration-11, Wikidata-Termbox-Iteration-10, Patch-For-Review
WMDE-leszek updated the task description for T215494: Make all page actions fit new (less high) id header.
Wed, Feb 27, 3:19 PM · Wikidata-Termbox-Iteration-12 ✓, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Wikidata-Termbox-Iteration-11, Wikidata-Termbox-Iteration-10, Patch-For-Review
WMDE-leszek updated the task description for T215494: Make all page actions fit new (less high) id header.
Wed, Feb 27, 3:16 PM · Wikidata-Termbox-Iteration-12 ✓, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Wikidata-Termbox-Iteration-11, Wikidata-Termbox-Iteration-10, Patch-For-Review
WMDE-leszek updated the task description for T215494: Make all page actions fit new (less high) id header.
Wed, Feb 27, 3:14 PM · Wikidata-Termbox-Iteration-12 ✓, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Wikidata-Termbox-Iteration-11, Wikidata-Termbox-Iteration-10, Patch-For-Review
WMDE-leszek added a comment to T205608: Floating button to collapse „All entered languages“.

Implementation details (and also complexity) of this story will become more clear once investigation T216720 is done.

Wed, Feb 27, 3:10 PM · Wikidata Mobile, Wikidata, Wikidata-Termbox-Hike
WMDE-leszek added a subtask for T205608: Floating button to collapse „All entered languages“: T216720: Research: floating button [1*4h].
Wed, Feb 27, 3:09 PM · Wikidata Mobile, Wikidata, Wikidata-Termbox-Hike
WMDE-leszek added a parent task for T216720: Research: floating button [1*4h]: T205608: Floating button to collapse „All entered languages“.
Wed, Feb 27, 3:09 PM · Wikidata-Termbox-Iteration-11
WMDE-leszek renamed T214969: Investigate where fallback languages come from [8h] from Investigate where fallback languages come from to Investigate where fallback languages come from [8h].
Wed, Feb 27, 3:03 PM · Wikidata, Wikidata-Termbox-Hike

Tue, Feb 26

WMDE-leszek closed T217128: HHVM job of the Wikibase Travis CI builds failing (non-Wikibase test being the issue) as Resolved.

Looks it is fixed https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/498678262

Tue, Feb 26, 3:15 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), User-Ladsgroup, Patch-For-Review, Wikidata-Campsite, Wikidata
WMDE-leszek updated the task description for T216730: Enable musical notation datatype.
Tue, Feb 26, 11:23 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
WMDE-leszek added a comment to T216730: Enable musical notation datatype.

@Lydia_Pintscher: asking for clarification. The "child ticket" the task description refers to is T216728?

Tue, Feb 26, 10:57 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
WMDE-leszek moved T217128: HHVM job of the Wikibase Travis CI builds failing (non-Wikibase test being the issue) from Incoming to Ready to go on the Wikidata-Campsite board.
Tue, Feb 26, 10:55 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), User-Ladsgroup, Patch-For-Review, Wikidata-Campsite, Wikidata
WMDE-leszek created T217128: HHVM job of the Wikibase Travis CI builds failing (non-Wikibase test being the issue).
Tue, Feb 26, 10:52 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), User-Ladsgroup, Patch-For-Review, Wikidata-Campsite, Wikidata

Mon, Feb 25

WMDE-leszek changed the status of T212189: New Service Request: Wikidata Termbox SSR from Stalled to Open.

Unstalling as the RFC requested above is now approved! (see: T213318)

Mon, Feb 25, 7:22 PM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations
WMDE-leszek added a comment to T213318: Wikibase Front-End Architecture.

With the Last-Call period ended on Feb, 20th 1:00 PM PST, and Technical Comittee having approved the RFC on the same day (per https://lists.wikimedia.org/pipermail/wikitech-l/2019-February/091589.html), I guess this RFC ticket should be marked resolved, or maybe moved to TechCom-RFC (TechCom-Approved) ? I don't know what is the process, please advise. Thanks!

Mon, Feb 25, 7:17 PM · TechCom-RFC (TechCom-Approved), Wikidata

Feb 22 2019

WMDE-leszek added a comment to T216686: beta wikidata API: LogicException (UnusableEntitySource used).

Caused by sloppy work of mine under umbrella of T214557. Not related to the recent beta outage/beta being in read only state.

Feb 22 2019, 8:43 AM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wikidata-tech-focus, Wikidata

Feb 20 2019

WMDE-leszek set Sprint Start Date to Sun, Feb 24, 11:00 PM on Wikidata-Termbox-Iteration-10.
Feb 20 2019, 6:00 PM
WMDE-leszek created Wikidata-Termbox-Iteration-10.
Feb 20 2019, 5:58 PM

Feb 19 2019

WMDE-leszek updated the task description for T216419: Security review - Wikibase Termbox Front End.
Feb 19 2019, 11:57 AM · Security-Team-Review-Active
WMDE-leszek updated the task description for T216419: Security review - Wikibase Termbox Front End.
Feb 19 2019, 9:21 AM · Security-Team-Review-Active

Feb 18 2019

WMDE-leszek renamed T216419: Security review - Wikibase Termbox Front End from Security review Action Items - Wikibase Termbox Front End to Security review - Wikibase Termbox Front End.
Feb 18 2019, 5:04 PM · Security-Team-Review-Active
WMDE-leszek updated subscribers of T216050: Set up the Github mirror for Gerrit repository wikibase/termbox.
Feb 18 2019, 4:33 PM · Wikidata, GitHub-Mirrors, Gerrit
WMDE-leszek created T216419: Security review - Wikibase Termbox Front End.
Feb 18 2019, 4:24 PM · Security-Team-Review-Active
WMDE-leszek added a comment to T214692: Users may add so-called descriptions to MediaInfo entities.

I don't claim to understand all details on how MediaInfo is implemented, but if I understood the problem, and I were to "fix" it, I would see three steps:

  1. Make Special:SetDescriptions and relevant API actions really only work with items and properties (unless already done in all places, description of this task suggests it might not be the case yet).
  2. Adjust the code turning the PHP object into JSON object for storage, and the opposite when loading JSON object from the database, so it ignores anything which claims to be a description. E.g. skip "descriptions" key etc. This would prevent storing any "description" data even if it somehow made up to the storage layer, and also unexpected leaking of incorrect data should it be already stored in historical revisions etc.
  3. Adjust the code turning the loaded the PHP object for JSON output, e.g. in API results. This code should be able to control what data is used for presentation, e.g. what "elements" of the MediaInfo object to display. This would prevent exposing any "descriptions" even if they for whatever reason ended up to be stored in the database.
Feb 18 2019, 2:03 PM · Patch-For-Review, Multimedia, SDC General, Wikidata

Feb 14 2019

WMDE-leszek claimed T213483: Fatal error: null EntityId argument passed to addEntityRedirect (Special:EntityData broken for some items).

I take this one on. Per the internal discussion with @Addshore and @Lydia_Pintscher the other day, it seems reasonable to actually turn off RDF output for MediaInfo entities for now, as it is not really defined. Doing it from the start has apparently slipped our attention, so I am going to do it now.

Feb 14 2019, 9:01 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review, Wikimedia-production-error, WikibaseMediaInfo, StructuredDataOnCommons
WMDE-leszek added a comment to T212189: New Service Request: Wikidata Termbox SSR.

We do not intend to maintain the "proper" UI logic in PHP. SSR service will render the page on the server side which will (via MediaWiki etc) make it to reader's browser. We do want Wikidata readers and editors have an access to data even if they decide to disable JS in their browser, hence the request for this service.

Feb 14 2019, 8:48 AM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations
WMDE-leszek added a comment to T213318: Wikibase Front-End Architecture.

Can we make it an explicit requirement?

Feb 14 2019, 8:23 AM · TechCom-RFC (TechCom-Approved), Wikidata

Feb 13 2019

WMDE-leszek created T216050: Set up the Github mirror for Gerrit repository wikibase/termbox.
Feb 13 2019, 4:55 PM · Wikidata, GitHub-Mirrors, Gerrit
WMDE-leszek added a comment to T193641: track number of editors from other Wikimedia projects who also edit on Wikidata over time.

Much appreciated @JAllemandou !

Feb 13 2019, 9:50 AM · Analytics-Kanban, Analytics, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Patch-For-Review, WMDE-Analytics-Engineering, Wikidata
WMDE-leszek added a comment to T190022: Separate the CirrusSearch/Elastic-specific code from Wikibase code base.

Apologies @Smalyshev for super late reply. We've got snowed under with some urgent Structured Data on Commons work.

Feb 13 2019, 9:42 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, Discovery-Search (Current work), CirrusSearch, Discovery, User-Smalyshev, Wikidata
WMDE-leszek added a comment to T208381: mediawiki - node SSR HTTP request follow-up [2*2h].

I had a quick chat with @Addshore, and I'll try to point to WMF teams we believe are the best suited to provide information on those topics, the particular team member who is to our knowledge the best suited/approachable (e.g. based in Europe) in the particular topic area, and also IRC channels where teams in questions are generally present. This if of course does not mean IRC is the only way to get answers, and the mentioned individuals are the ones you must be in contact with.
Email addresses of WMF staff can be found through the staff page https://wikimediafoundation.org/role/staff-contractors/

Feb 13 2019, 9:18 AM · Wikidata-Termbox-Iteration-10, Wikidata-Termbox-Iteration-9, Wikidata

Feb 12 2019

WMDE-leszek closed T215869: Wikibase Travis CI builds fails due to removal of deprecated entry point of cldr extension as Resolved.

back on green https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/492233987 thanks!

Feb 12 2019, 5:02 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-CLDR, Wikidata
WMDE-leszek added a comment to T212189: New Service Request: Wikidata Termbox SSR.

@Smalyshev I believe the approach we are suggesting really makes a difference when thinking beyond just rendering a template for a particular part of an Item page. I can definitely be blamed for not making it clear enough in the description of this task that we are NOT intending to build the template renderer, but the UI application which determines what data to load (from what APIs), what actions (APIs) to call etc, and also what to render. Also, it should be noted the ultimate goal of ours is not to just change the way this particular element of the item page (i.e. the "termbox") is handled in the Wikibase front end code, but it is about the Wikibase front end as a whole, with termbox being the first step only.

Feb 12 2019, 4:43 PM · Core Platform Team Backlog (Later), User-Addshore, serviceops, Services (next), Wikidata-Termbox-Hike, Wikidata, Service-deployment-requests, Operations
Gerrit Code Review <gerrit@wikimedia.org> committed rAWWP3a8d03f59300: Created project (authored by WMDE-leszek).
Created project
Feb 12 2019, 12:16 PM
WMDE-leszek created T215869: Wikibase Travis CI builds fails due to removal of deprecated entry point of cldr extension.
Feb 12 2019, 9:08 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-CLDR, Wikidata

Feb 11 2019

WMDE-leszek added a comment to T213318: Wikibase Front-End Architecture.

Regarding the Structured Data on Commons topic: as per what's been stated in the last point of the "Solution proposal", we intend to move the whole of Wikibase entity page UI towards the new architecture. So that would include statement part of the item and property pages.
We want to stop using the old front end code and infrastructure, and finally, stop maintaining it/delete it. With how the current SDC UI is built, as @Cparle states, using the some "components" from the old Wikibase UI code this would indeed mean changes required to the SDC part as well.
There is no intention to drop the old UI "framework" over night of course. It will only happen once all relevant uses are moved to the new architecture, starting with the complete item and property page. This is definitely not going to happen in 2019.
We are quite convinced that once item pages have switched fully to the Single Patch Application approach, transition for other users should be easier. The server side renderer service would be there, handling what is required by non-item-page cases (e.g. statements).

Feb 11 2019, 4:14 PM · TechCom-RFC (TechCom-Approved), Wikidata

Feb 10 2019

WMDE-leszek archived Wikidata-Termbox-Iteration-6.
Feb 10 2019, 12:58 PM
WMDE-leszek archived Wikidata-Termbox-Iteration-5.
Feb 10 2019, 12:58 PM
WMDE-leszek set Sprint Start Date to Feb 10 2019, 11:00 PM on Wikidata-Termbox-Iteration-9.
Feb 10 2019, 12:57 PM
WMDE-leszek closed T205261: Add the ability to show terms in all entered languages on mobile as Resolved.

@Lea_WMDE closing this one. Please re-open if it was not expected to be closed.

Feb 10 2019, 12:57 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Wikidata-Termbox-Iteration-7, Wikidata-Termbox-Iteration-6, Wikidata-Termbox-Iteration-5, Wikidata Mobile, Wikidata
WMDE-leszek created Wikidata-Termbox-Iteration-9.
Feb 10 2019, 12:55 PM

Feb 6 2019

WMDE-leszek set Sprint Start Date to Feb 10 2019, 11:00 PM on Shape Expressions Sprint 2.
Feb 6 2019, 10:55 AM