User Details
- User Since
- Feb 11 2022, 9:56 AM (19 w, 4 d)
- Availability
- Available
- LDAP User
- Wangombe
- MediaWiki User
- Unknown
Thu, Jun 16
Following some investigation, I've found that this message is parsed from the serverside. The target translation language could be sent to the API and parsed through APIQueryMessageGroups::formatGroup() in order to meet the requirements in the mockup (e.g when a user changes the language using the ULS on Special:Translate) but it is not. Looking at WikiPageMessageGroup::getDescription(IContextSource), we could essentially pass in the target language but it would require altering the MessageGroup::getDescription(IContextSource) interface to do so. The interface is implemented by the following classes:
Wed, Jun 15
Wed, Jun 8
Mon, Jun 6
Tue, May 31
Mon, May 30
May 26 2022
As of this comment, I have managed to reduce the number of messages by ~13. There might be a bigger number due to the fact that one of the patches added a few items to the safe tags list.
May 25 2022
May 24 2022
As of this comment, the number or messages has reduced by >10. This patch handles a number of these messages by adding some tags onto the safe list.
May 19 2022
After some investigation, it appears that there is no way to keep track of reminders sent but not processed by the job queue. Once an admin clicks on 'Send reminder' an email job is sent to the queue through TranslateSandbox::sendMail();. In ManageTranslatorSandboxSpecialPage::makeList() there is a property reminderscount that takes count of the reminders that were successfully processed. The variable is used to display a count against how long ago a reminder was sent as shown below.
May 18 2022
May 17 2022
May 16 2022
This screenshot is from Timeless theme
This screenshot if from Vector theme
May 12 2022
May 10 2022
Apr 27 2022
It looks strange. I suggest we add a greyed out text in it's place
Apr 26 2022
Apr 20 2022
Here are the results of previous comment.
After some testing, there are some items that we found that need some discussion.
- As you can see from the image below, there might be an instance where summary may be long. The text wraps well but I propose we truncate it and add ellipsis.
- In grouping of the summaries without a message, the image below is what I came up with. Which diffLink should be attached for the grouped messages? At the moment, I am using the diffLink of the last summary without a message (just by sequentially looping through the list of summaries that came from the API).
Apr 7 2022
Apr 5 2022
When a user uploads their translations and clicks on 'load file' button, both the diff and 'new messages' will be shown (If the user has modified or added a new translation).
Once they have reviewed their message, this is the feedback the user will receive .
The expected result is that unless the user clicks on the 'Execute' button, these translations are not saved.
Apr 4 2022
It makes sense that the message appears after following the bug reproduction steps.
Importing the translation and clicking on 'Load file' button runs MessageWebImporter::execute()
- Once the file is loaded, the next UI shows the list of new messages (translations).
- But clicking on 'execute' runs MessageWebImporter::execute() again.
This call-stack suggests that the new messages will be imported [regardless] and saved before the messages are reviewed. Clicking 'execute' button which, I assume, is intended to allow the user to actually save the new messages after reviewing them, doesn't actually do what is intended of it. This issue might be bigger than just the message not showing correctly and is currently under investigation.
Mar 24 2022
! In T240364#7759663, @Pginer-WMF wrote:
For example, the placeholder text could explicitly ask ("Optional summary: Why was the translation changed?"). This could make it more clear the purpose of the summary.
Mar 14 2022
T193166 | Convert Translate to PSR-4 has a patch 724782 with classes that depend on some of the work done for this task such as MachineTranslationAid.php, QueryAggregatorAwareTranslationAid.php, TranslationAidsActionApi.php & TTMServerAid.php . As a result, I think the build for this task will always fail without making necessary updates to the aforementioned classes. I have made updates to the classes but haven't committed the changes since I don't believe they are part of the scope for this task. Could you advise on the best way to approach this?
- I am concerned about the sorting of the suggestions using both the quality and count properties. Which one should take precedence?
Mar 8 2022
Mar 3 2022
Feb 21 2022
One can no longer insert a translate suggestion into the translation editor without translator rights. I have added
cursor: not-allowed
when a user attempts to click on a translation suggestion to give a cue that the action is not possible/allowed without logging in
Feb 16 2022
Task is now resolved
Feb 15 2022
Message content now appears as intended.