Ping?

@Krinkle, the shared hosting at the Masterhost company (https://masterhost.ru/), gives the system-wide PHP installation and doesn't allow to give custom php.ini completely.

Ping?

Just now I sent a new patch to resolve the given notices.

Ping? Any news on this?

Just now I had to resolve conflict and I rebased my commit to the top.

Hello again!
What the current state of the patch review? I reminding again after two months waiting.

Hello!
Do you have any news? Here is a patch I have sent more than one month ago https://gerrit.wikimedia.org/r/538404
Can you review and merge it, or comment it out if any questions are still?

So, what do you think now? @Krinkle

Just now I have sent the 8'th patch to fix an error that was reported by that bot.

Can anyone poke a verifying again? https://gerrit.wikimedia.org/r/538404
A week ago I have sent a 7'th patch to that, and which isn't tested yet.

Okay, just now I have added the secret key requirement. Without a secret key, it will don't work.

MW-side rate-limiting of some sort.

Just my small trivia:
Anyway, it's just sad to drop the support for GeSHi as it worked anywhere without any Popen requirement. I understand that Pygments gives much better support and much more set of languages to highlight, however, it:

• won't work if Popen is blocked (A reason why I made this feature)
• it's python code which requires also python interpreter be installed in the system
• Python can't work as fast-cgi to serve many queries, and every need runs an extra python instance.

Also, it's worth thinking about abuse vectors and security. We would normally expose this although through the API so that we can rate limit it within a session or by other means. Not sure how to do that in this case.

It seems odd I think for a host to allow Popen in Python but not in PHP? Should we ship and maintain this as built-in functionality for that use case?

Okay, I have replaced the "toString()" with "text()", I hope this will work...

is a condition "is Ok?" and when it's NOT ok, the 337 works

$error = 'Failed to invoke Pygments: ' . $status->getMessage()->toString();

Do you mean I should un-escape the output of $status->getMessage()->toString() to stop this thing blame? Or use a different function to get non-escaped string?

line 337

Okay, all 3 first tests are now passing, however, this, 4'th unit test, just looks odd: https://integration.wikimedia.org/ci/job/mwext-php72-phan-seccheck-docker/11181/console, it fails because of rsync:

16:57:24 rsync: failed to set times on "/cache/.": Operation not permitted (1)
16:57:30 rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1668) [generator=3.1.2]

Thanks!

The problem I don't see any "abandon" at all... All patches I have uploaded by Gerrit Uploader, and that just probably that robot is only who can do that, but it just can't. Therefore is only privileged person can help me to do that...

P.S. Can someone nuke this garbage (these three reviews I have post), IDK how to do that myself, or I just have no permission to do that:

• https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/SyntaxHighlight_GeSHi/+/538405/ (sent by accidental, it should be sent as update of older version, however, it was sent as a new copy)
• https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/SyntaxHighlight_GeSHi/+/474518/ Old review, how to abound it?
• https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/SyntaxHighlight_GeSHi/+/474517/ This is first that was sent with mistakes and should be removed

Just now I made a fix of notices:

• added config option into "extension.json"
• changed that new option's type into just bool with default "false"

Okay, I have finally found a time window to replace CURL with MWHttpRequest which I have tested on my end and it works:
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/SyntaxHighlight_GeSHi/+/538404/

Ok, thanks for a tip, @Daimona. I'm pretty familiar with CLI git as I using it for a long time (since 2014) for my own projects. Once I'll make a proper thing, I'll try to upload it again.

Ok, @TheDJ, will try to change the CURL with MWHttpRequest thing and then, will post an updated patch. I have pulled your minor fixes, thanks for them!

Thanks, @Daimona for help!
Anyway, I see it does a test of old errors I have fixed in an updated patch:

Hi, @Aklapper , I did next:

# re-clonned repo from Gerrit
git clone ssh://wohlstand@gerrit.wikimedia.org:29418/mediawiki/extensions/SyntaxHighlight_GeSHi.git
cd SyntaxHighlight_GeSHi
# applied my patch with a change (added a new commit)
git am --signoff < 0001-Allow-Pygments-to-be-run-via-CGI.patch
# Then
git review -r origin -s
# and finally
git review -r origin -R

I'll try to ask the question on the forum, but this whole thing looks like a weird mess...

Okay, I have installed git-review 1.28.0 by pip, however, it still fails:

$ git review -R
remote: 
remote: Processing changes: refs: 1
remote: Processing changes: refs: 1, done            
To ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SyntaxHighlight_GeSHi.git
 ! [remote rejected] HEAD -> refs/for/master (cannot add patch set to 474518.)
error: failed to push some refs to 'ssh://wohlstand@gerrit.wikimedia.org:29418/mediawiki/extensions/SyntaxHighlight_GeSHi.git'
$ git branch
  master
* review/gerrit_patch_uploader/474518

Sorry for waiting, I did the change, however, I can't submit it with no way:

I see here some sort of code style / static analysis failure... Okay, will re-check this and will submit an update...

The reason for that V-1 was NOT my issue, it happened because of another issue that was in the state that was in a moment where I have submitted my patch. I think I'll try to re-poke it to trigger the re-check...

Hello!
Almost half of the year has been passed. Are you too busy and can't review this patch and give a rate on it?

Hello! I want to ask you how are you? I have seen your Jenkins bot said "Verify -1" because of some weird "quibble-vendor-mysql-hhvm-docker" failure... Can anyone poke that bot to re-check the patch?

Sent just now:
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/SyntaxHighlight_GeSHi/+/474518/

Oh, nice! I have sent the raw patch because I hadn't any sort of understanding where to submit this, I'll try out this...