Apr 28 2016
I haven't seen the issue re-occur since the change went live, so I think it should be OK to close this issue now. I just clicked on "Random page" about 50 times and all articles had correct TOCs. Thanks to everyone who helped investigate.
Apr 21 2016
While I haven't noticed the issue in the past week, if there's no harm in doing so I would leave this open for another week just to be certain. The weekly (Wednesday?) software release seems to have been a trigger for this issue in the past, but if I'm reading https://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#Server_switch_2016 ("There will be a code freeze for the week of 18 April") correctly then there was no release this week.
Apr 13 2016
Apr 6 2016
If the template was at fault the behavior should be consistent - currently if a page is edited or flushed from the cache the banner always shows correctly, but after some time passes TOCs start showing up within articles, which doesn't seem like a template issue to me. I can update the template, but doing so will flush all banners on the site and it will be several days until the problem shows up again - if you don't need to see any example pages to debug further let me know if it's safe to update the template. Also, are you certain you want NOTOC? That would suppress the TOC from both the article and the banner if I'm understanding correctly, which doesn't seem right.
Apr 5 2016
Cache is cleared fairly regularly even if articles aren't edited - I've made minor updates to Template:Pagebanner numerous times over the past months, which forces a cache flush of all articles with page banners.
Pinging Jdlrobson as I believe that this issue is the one being referenced in the English Wikivoyage discussion earlier today: https://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#Pagebanner_-_why_cannot_it_not_be_fixed
Jan 20 2016
ListingEditor2 is just the beta listing editor gadget (not enabled by default), used to test changes to the listing editor (which is enabled by default). At the moment there are no beta features being tested, but the next time something comes up I'll make sure that your changes aren't lost.
Jan 12 2016
When the issue occurs it happens on a random subset of articles. I saw it several times last night, and after hitting "random page" many, many times this morning I found the following two articles which are showing an in-article TOC:
Jan 7 2016
The issue is re-occurring today, even with the cache-buster param:
Jan 5 2016
I'll need to test out the query param the next time the issue occurs. I just forced a cache flush yesterday, so it will probably be at least 2-3 days.
Not sure if the following might reveal a pattern that anyone recognizes, but here are the times that I've purged the pagebanner cache on English Wikivoyage after encountering in-article TOCs during the past two weeks (per https://en.wikivoyage.org/w/index.php?title=Template:Pagebanner&action=history):
Dec 28 2015
I'm not aware of any other TOC extensions. I suspect that the behavior may occur during the weekly(?) Mediawiki software updates. Is it possible the banner extension isn't enabled until after the cache has started rebuilding following a software update?
Dec 27 2015
Just to clarify (since it seems there may be some confusion), the problem on both Russian and English Wikivoyage isn't that the banner does not appear, it is that the TOC appears within the article rather than as part of the banner.
Yes, this problem occurs regularly on English Wikivoyage. French Wikivoyage has also reported seeing this issue. Forcing an update to https://en.wikivoyage.org/wiki/Template:Pagebanner typically resolves the issue, but it seems like we have to do so on almost a weekly basis.
Nov 29 2015
Nov 3 2015
I don't recall seeing a "1" for the TOC since we purged the cache for all articles last week, so it's probably safe to call this issue resolved now.
Oct 29 2015
On English Wikivoyage I just made a minor edit to https://en.wikivoyage.org/wiki/Template:Pagebanner which should hopefully force a cache purge for all pages using that template. It seems to have done the trick for the handful of pages that I checked - https://en.wikivoyage.org/wiki/Culver_City showed the problem earlier this morning but is displaying correctly now.
It may be too early for feedback since the updated extension apparently just went out today, but in a random sample of articles on Wikivoyage just now I would say that the majority of them exhibited the behavior with the incorrect TOC, so it may be premature to mark this issue as "resolved".
Oct 21 2015
I'm not sure if this is helpful or not, but when this issue first surfaced it was proposed that it might be a caching issue, and that over time it would go away. https://en.wikivoyage.org/wiki/Morro_Bay is an article that I have edited since the extension was updated (most recently on 15-October), it was working fine when I edited it, and today it is showing "1" for the TOC, so I think that rules out a cache problem.
Oct 1 2015
Sep 15 2015
Sep 10 2015
The individual who originally reported this issue now also says it is fixed. Thanks again Sumit - this task can now be closed.
I was unable to reproduce the issue just now, but have also asked for feedback from the original reporters at https://en.wikivoyage.org/wiki/Wikivoyage:Travellers'_pub#banner_not_displaying.
The fix seems to be working on Wikivoyage, this issue can be closed.
Sep 8 2015
@Jdlrobson I tried the code you provided in my local common.js, and I also tried executing it on window.load (since the JQuery load event handler can be flaky) but was still able to reproduce the issue.
Sep 7 2015
Sep 5 2015
Thanks for the quick response & patch!
Apr 2 2015
Mar 9 2015
Mar 8 2015
Mar 2 2015
Feb 28 2015
If this proposal does move forward there needs to be a way to locally override the Wikidata property, as has been previously mentioned. Additionally, if possible, a major shortcoming of the current banners is that they require hiding the <h1> tag with "display:none" CSS, and the banner then uses a <div> for the article name in the banner (using a h1 tag in wiki source causes the page name to appear in the TOC), which is horrible for SEO. If there was a way to move this functionality to an extension and have an <h1> tag in the banner that contains the article name without causing a TOC update, that would be an additional win.