Page MenuHomePhabricator

Xover
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 16 2017, 6:32 PM (271 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Xover [ Global Accounts ]

Recent Activity

Sun, Jun 5

Xover added a comment to T238285: Pages whose title ends with semicolon (;) are intermittently inaccessible (likely due to ATS).

@BBlack The last status update on this bug was ~18 months ago, and indicated the issue was an upstream bug and you were following up there, with a fallback to a WMF-specific patch if upstream got stuck. I see no indication there is any question this behaviour is a bug (cf. eg. Krinkle's comment above). It's also a problem that makes certain pages inaccessible on all projects, breaks contribution histories and other core features for certain users, and necessitates manually prohibiting a character in page and user names that is intended to be permitted.

Sun, Jun 5, 4:48 PM · Traffic-Icebox, affects-Kiwix-and-openZIM, WMF-General-or-Unknown, SRE, User-DannyS712

Mar 6 2022

Xover added a comment to T296847: Third-party resources policy.

Hmm. Then I think the problem statement is a little bit the wrong way around: it reads as if the aim is to lock down a currently reigning "Wild West" state of affairs, but in light of your clarification it sounds like the focus is more to enable a use of third-party resources that are difficult or impossible to (legally) do today but which would be of benefit to the Movement. And, obviously, when enabling such use it is desirable to do so in a controlled way that prioritises privacy, is sustainable, does not negatively impact performance, and so forth; but this then is not the focus so much as the consequence.

Mar 6 2022, 10:42 AM · SecTeam-Processed, Privacy Engineering, tech-decision-forum

Mar 2 2022

Xover added a comment to T296847: Third-party resources policy.

I'm confused by this problem statement. The Privacy Policy already forbids anything on Wikimedia projects that causes the UA to contact any third-party website, including Toolforge and WMCS, for any purpose (any HTTP header and the client IP are covered by the definition of "Personal information"). So regardless of whether it's executable code, an image, a webfont, JSON/JSONP data, etc. it is currently bright-line forbidden. What, then, would this "clear Wikimedia policy on the use of third-party resources" cover?

Mar 2 2022, 9:42 AM · SecTeam-Processed, Privacy Engineering, tech-decision-forum

Feb 25 2022

Xover added a comment to T277267: Displayed Number in TopPanel is offset for numbers lower than 100.

is it possible to have the link of the page please ?

Feb 25 2022, 5:32 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Patch-For-Review, MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), good first task, ProofreadPage

Feb 24 2022

Xover added a comment to T277267: Displayed Number in TopPanel is offset for numbers lower than 100.

in addition each label is now inline rather than block

That was already the case before, but there were hidden 0 to fill the space you highlighted as empty.

Feb 24 2022, 8:08 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Patch-For-Review, MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), good first task, ProofreadPage
Xover added a comment to T277267: Displayed Number in TopPanel is offset for numbers lower than 100.

what do you prefer ?

Feb 24 2022, 8:00 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Patch-For-Review, MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), good first task, ProofreadPage
Xover added a comment to T277267: Displayed Number in TopPanel is offset for numbers lower than 100.

The layout changes for the pagelist in this task are kinda suboptimal. There seems to be significantly increased margins around each page label, and in addition each label is now inline rather than block so the containers (on which the background is applied) collapse down to essentially just the character boxes. See the before—after screenshots below:

Feb 24 2022, 10:42 AM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Patch-For-Review, MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), good first task, ProofreadPage

Feb 13 2022

Xover created P20618 git-review output with outstanding patches.
Feb 13 2022, 8:36 AM

Feb 12 2022

Xover created T301610: upload.create_warnings_list() throws KeyError when ignore_warnings is true.
Feb 12 2022, 1:42 PM · Pywikibot

Jan 31 2022

Xover created T300531: imagetransfer.py doesn't support async and chunked upload.
Jan 31 2022, 3:10 PM · Pywikibot

Jan 30 2022

Xover created T300467: Expose section identifier in HTML output.
Jan 30 2022, 7:46 PM · MediaWiki-Parser
Xover created T300465: Documentation for "section" parameter of Edit API says "number" but should be "identifier".
Jan 30 2022, 7:20 PM · MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), MediaWiki-Documentation, MediaWiki-Action-API

Jan 24 2022

Xover added a comment to T299880: Wikisource book download buttons don't work.

Dollars to dimes they're just scraping works for some ebook site based on the OPML.

Jan 24 2022, 3:49 PM · WS Export, Community-Tech

Jan 17 2022

Xover added a comment to T299124: ProofreadPage frontend makes a request to the page before and after in every page view.

Then it can make a request to the thumbnail instead of the page. I think this at least reduces the pressure on the appservers.

Jan 17 2022, 9:13 AM · ProofreadPage

Jan 13 2022

Xover added a comment to T299124: ProofreadPage frontend makes a request to the page before and after in every page view.

It is probably worth revisiting, yes, but note that interactive performance here depends on dynamically generated "thumbnail" images, where the generation involves shelling out to ghostscript (for PDFs) and ddjvu (for DjVu) to extract a given page from a possibly ~1GB multi-page document and rendering it to a JPEG. Ghostscript, in particular, can (anecdotally) take ~20 seconds to do this.

Jan 13 2022, 2:32 PM · ProofreadPage

Jan 12 2022

Xover updated subscribers of T298992: ProofreadPages: incorrect spacing between words in rendered PDF page.

Last I heard (I could be wrong), MediaWiki-extensions-PdfHandler (ping @Tgr) uses Ghostscript to render PDFs to JPEG thumbnails, meaning this is most likely an upstream bug affecting certain born-digital PDFs. Best case for fixing it is probably using a newer version of ghostscript, which I'm guessing would be blocked on T289228. If it can be reproduced in base latest-version ghostscript it should probably reported upstream, and a fix here would then also depend on when upstream makes a release with a fix. Alternately, there is T38594; but I suspect it'd be fairly resource-intensive on the MediaWiki side, and I have no idea what the relative merits of Ghostscript and MuPDF are. A switch might conceivably have a positive effect on the problem described in T242169 (or it might not; or it might make it worse).

Jan 12 2022, 12:33 PM · MediaWiki-extensions-PdfHandler, ProofreadPage

Jan 7 2022

Xover added a comment to T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

The user that first reported this issue on enWS has tested and confirmed that it is now fixed for them. And my own testing concurs.

Jan 7 2022, 12:54 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage
Xover added a comment to T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

Crap, I notice we don't have any regular backport windows until Monday. While this wasn't train-blocking/rollback when noticed, it's probably UBL-y enough that it needs to go out as an emergency backport. It doesn't break the primary workflow in that the Wikisourcen can still edit pages, it does break the zoom/pan for the reference page image (which is highly-used functionality) and partially breaks (blocks) the UI for setting page status (particularly for people with page zoom on in the browser, which is a major accessibility issue and primary workflow).

Jan 7 2022, 11:04 AM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Jan 6 2022

Xover added a comment to T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

Updated patch looks good to me, but I'm not sufficiently familiar with the context there for that to mean much.

Jan 6 2022, 7:33 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage
Xover added a comment to T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

Patchdemo looks good to me: no console errors, all the OSD stuff (zoom, rotate, etc.) looks like it works, and it even seems to fix the unresponsive radio buttons that were reported on-wiki.

Jan 6 2022, 4:43 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage
Xover added a comment to T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

How big is the impact? Should this be a train blocker?

Jan 6 2022, 3:20 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage
Xover added a comment to T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

Ah, oh, yes, I see. When we start, $imgContHorizontal is initialized to null (what's the point of that long chain of vars getting set to null at the top? They should either be set to something useful or their initialization might as well be deferred until first used.). It doesn't actually get assigned any value until toggleLayout() is called, and there it's wrapped inside a conditional such that it is only initialized if the layout is already horizontal (if (!isLayoutHorizontal)). When we start in vertical mode the var is never initialized, until something actually triggers toggleLayout(); but then a few lines later $imgContHorizontal.add() is called regardless of which branch was picked in the preceding conditional.

Jan 6 2022, 2:35 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage
Xover updated subscribers of T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

But why is $imgContHorizontal undefined here?

Jan 6 2022, 2:09 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Jan 5 2022

Xover added a comment to T298613: Update GentiumPlus to 6.001.

@santhosh You're listed as the maintainer for jQuery.WebFonts so I tagged you on this. If this isn't your bailiwick I'd appreciate a pointer in the right direction.

Jan 5 2022, 2:33 PM · Unplanned-Sprint-Work, Language-Team (Language-2022-January-March), All-and-every-Wikisource, UniversalLanguageSelector
Xover created T298613: Update GentiumPlus to 6.001.
Jan 5 2022, 2:30 PM · Unplanned-Sprint-Work, Language-Team (Language-2022-January-March), All-and-every-Wikisource, UniversalLanguageSelector

Jan 3 2022

Xover added a comment to T298417: Undeleted djvu files show incorrect metadata: 0x0 size, no page number info.

… I found only 100 deleted djvu files in the db …

Jan 3 2022, 8:31 AM · MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), Commons, MediaWiki-File-management, MediaWiki-DjVu

Dec 29 2021

Xover added a comment to T137584: Allow Scribunto code to add a category without changing output.

@Agabi10 Did you give up on this patch? It looks really useful to me, and from the review comments it didn't look like there were any insurmountable problems (just maybe some documentable limitations due to the architecture context).

Dec 29 2021, 11:38 AM · Platform Engineering, Patch-For-Review, MediaWiki-extensions-Scribunto
Xover added a comment to T209310: Consider implementing Module:No globals / Log globals in Scribunto itself.

There's no obvious reason Scribunto should unconditionally enforce this when Lua as such doesn't, but that's an issue of defaults and somewhat orthogonal, IMO.

Dec 29 2021, 11:06 AM · MediaWiki-extensions-Scribunto
Xover updated subscribers of T283758: Specific page on English Wikipedia generates numerous "Lua error: not enough memory" errors.

@RoySmith I've updated the task description to point at the relevant thread in the archives. But perhaps you (or perhaps @Pppery) could summarise the information learned in that thread for the benefits of others stumbling across similar issues and searches Phabricator?

Dec 29 2021, 10:43 AM · covid-19, Performance Issue, MediaWiki-extensions-Scribunto
Xover updated the task description for T283758: Specific page on English Wikipedia generates numerous "Lua error: not enough memory" errors.
Dec 29 2021, 10:33 AM · covid-19, Performance Issue, MediaWiki-extensions-Scribunto
Xover added a comment to T277203: Add support for derived MCR slots.

This sounds really cool, but I am having trouble seeing what the use case for it is. What kind of data would one put in a "derived slot"? And since it is programatically generated, why not handle it in the parser and its cache?

Dec 29 2021, 10:20 AM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Multi-Content-Revisions (New Features)

Dec 22 2021

Xover merged task T297420: Landscape View in Edit Mode not possible: TypeError: can't redefine non-configurable property "SetCookie" into T297338: Switching to horizontal mode in ProofreadPage leaves the edit window narrow.
Dec 22 2021, 8:21 AM · ProofreadPage
Xover merged T297420: Landscape View in Edit Mode not possible: TypeError: can't redefine non-configurable property "SetCookie" into T297338: Switching to horizontal mode in ProofreadPage leaves the edit window narrow.
Dec 22 2021, 8:21 AM · ProofreadPage

Dec 16 2021

Xover updated subscribers of T297420: Landscape View in Edit Mode not possible: TypeError: can't redefine non-configurable property "SetCookie".

Based on that error message it smells like a namespace collision. deWS has a lot of site-local JS that uses (and defines) a "SetCookie" function. That's a pretty generic name for such a function, so it may well be clashing with a name from elsewhere (e.g. the recent OSD stuff).

Dec 16 2021, 3:24 PM · ProofreadPage
Xover added a comment to T297861: I can't proofread after upload to new version of a PDF file..

@Satirdan_kahraman The cover image (page 1) just needed a null edit, so there was apparently some kind of caching issue. I checked a few of the pages that have not yet been proofread and they appeared to load correctly.

Dec 16 2021, 2:52 PM · ProofreadPage

Dec 2 2021

Xover added a comment to T296893: Replace Diffusion integration with Gitlab integration in Striker (toolsadmin).

@bd808 I still can't find any mention of Toolforge on mw:GitLab or its subpages, so do we need a separate task to set policy for access/groups/directory layout in GitLab? What's currently documented only deals with WMF and WMDE components, and I am not immediately convinced that the assumptions for those hold in the context of Toolforge.

Dec 2 2021, 5:50 AM · GitLab (Project Migration), Tools, Striker

Dec 1 2021

Xover added a comment to T285610: Pages corresponding to tables of contents' second links are not provided the first link as the "prev" parameter for headers generated with <pages>.

@Tpt As best I can tell, the automatic next link on the main page was the existing behaviour. When the work's title was in $indexLinks[0], the if test inside the for loop would get a hit and set $current. The prev link test then explicitly excluded it by skipping index 0, but the next test just checked that it wasn't the last entry in the array ($i + 1 < $indexLinksCount) and so would add a next link on the page corresponding to the work's title.

Dec 1 2021, 5:52 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Nov 30 2021

Xover added a comment to T285610: Pages corresponding to tables of contents' second links are not provided the first link as the "prev" parameter for headers generated with <pages>.

Hmm. I may be insufficiently caffeinated just now, but…

Nov 30 2021, 10:38 AM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Nov 24 2021

Xover added a comment to T288141: ProofreadPage: use OpenSeadragon for the Page NS image viewer.

@Xover Can you suggest a place (can be phabricator as well) where users can interact with more expert ones to discuss such technical issues? I reckon that this is a specific case where such help is needed and requires a longer discussion.

Nov 24 2021, 9:51 AM · ProofreadPage
Xover added a comment to T288141: ProofreadPage: use OpenSeadragon for the Page NS image viewer.

@Alex_brollo I don't think reversing a change that brings big improvements is the way to go (and this cannot function as a gadget), but your use case is interesting. Instead of trying to manually undo the changes I would suggest you try to find ways to use the new facilities to do what you're after. A lot of it I would expect to already be possible (OSD has an API exposed that can be used), and what's missing are probably good candidates for adding. If you explain your needs it might be possible to suggest alternate approaches for them.

Nov 24 2021, 9:08 AM · ProofreadPage

Nov 20 2021

Xover added a comment to T215558: Proofread Page extension on Wikisource is displaying wrong pages; purge on Commons file fails.

Hmm. No smoking gun there that I can find.

Nov 20 2021, 3:02 PM · Multimedia, MediaWiki-DjVu, Commons, ProofreadPage, All-and-every-Wikisource

Nov 18 2021

Xover added a comment to T296001: DjVuHandler: getDimensionInfoFromMetaTree: PHP Notice: Undefined index: pages.

Dollars to dimes it's choking on c:File:Cyclopaedia of English Literature 1844 Volume 1 page 548.djvu which is in that category and is currently showing up with 0x0 dimensions and 0 pages. The djvudump structure for this files is:

Nov 18 2021, 5:43 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, DBA, User-Ladsgroup, MediaWiki-DjVu, Structured-Data-Backlog, Wikimedia-production-error
Xover updated subscribers of T296001: DjVuHandler: getDimensionInfoFromMetaTree: PHP Notice: Undefined index: pages.

Possibly triggered by the changes from T275268. Ping @Ladsgroup.

Nov 18 2021, 5:10 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, DBA, User-Ladsgroup, MediaWiki-DjVu, Structured-Data-Backlog, Wikimedia-production-error

Nov 17 2021

Xover added a comment to T215558: Proofread Page extension on Wikisource is displaying wrong pages; purge on Commons file fails.

That said...the real problem is clearly that MediaWiki or Thumbor or Varnish is not able to purge all the thumbnails. If someone has an example from the past 7 days it might be possible to look through the logs to get an idea of where the failure is happening (or at least rule out some stuff).

Nov 17 2021, 6:59 PM · Multimedia, MediaWiki-DjVu, Commons, ProofreadPage, All-and-every-Wikisource
Xover updated subscribers of T215558: Proofread Page extension on Wikisource is displaying wrong pages; purge on Commons file fails.

Hmm. Something is wonky here…

Nov 17 2021, 7:38 AM · Multimedia, MediaWiki-DjVu, Commons, ProofreadPage, All-and-every-Wikisource

Nov 16 2021

Xover added a comment to T268400: IA Upload 504 Gateway Timeouts.

Is this perhaps simply another symptom of T292954?

Nov 16 2021, 8:43 PM · IA Upload
Xover added a comment to T293010: IA Upload : All jobs are in error.

So this task can probably be closed?

Nov 16 2021, 8:34 PM · IA Upload
Xover added a comment to T294558: Tool:IA Upload stuck.

@2db Which file (IA identifier) was this? Do you still get the error if you retry now? (There have been some rather big changes to relevant bits of the code recently that might conceivably have affected this)

Nov 16 2021, 8:31 PM · IA Upload
Xover merged T222756: Upload of monumentistorici01bind failed into T215647: IA-Upload script cannot find djvm to merge files converted from JP2 back into a single DJVU..
Nov 16 2021, 8:23 PM · IA Upload
Xover merged task T222756: Upload of monumentistorici01bind failed into T215647: IA-Upload script cannot find djvm to merge files converted from JP2 back into a single DJVU..
Nov 16 2021, 8:23 PM · IA Upload
Xover merged task T192735: IA-upload log throws "Command not found: "djvm -c "" error message into T215647: IA-Upload script cannot find djvm to merge files converted from JP2 back into a single DJVU..
Nov 16 2021, 8:20 PM · Internet-Archive, IA Upload
Xover merged T192735: IA-upload log throws "Command not found: "djvm -c "" error message into T215647: IA-Upload script cannot find djvm to merge files converted from JP2 back into a single DJVU..
Nov 16 2021, 8:20 PM · IA Upload
Xover closed T162520: IA Upload unable to convert a JPEG2000 to JPEG as Resolved.

I just retried this file and intervening hosting environment changes appear to have fixed the issue. The file is now available at c:File:Indemnities of War- Subsidies and Loans (1920).djvu

Nov 16 2021, 8:17 PM · IA Upload
Xover closed T265640: phe-tools: Match&Split bot is not running because of python2 deprecation in pywikibot as Resolved.

This task is strictly speaking stale: the problem here was fixed a long time ago, then Match&Split broke again due to T280806, and has now been ported (more or less) to Pywikibot 6.x and Python 3. And while my ability to commit to owning phetools in toto is limited, I now have access to the tools account and have dug around in the code enough that if anything breaks then please tag me in and I'll see what I can do.

Nov 16 2021, 3:56 PM · Tools
Xover updated subscribers of T240562: Text extraction fails on seemingly bog standard DjVu file.

@Ladsgroup Testing suggests gerrit:738638 resolves this issue as well.

Nov 16 2021, 3:39 PM · User-Ladsgroup, MediaWiki-DjVu, All-and-every-Wikisource
Xover added a comment to T192866: Some DjVu files have too much metadata to fit in their database column.

Verified: all the files mentioned above show correct dimensions and thumbnails, both on Commons and Wikisource, and Proofread Page is now able to work with them without choking.

Nov 16 2021, 9:20 AM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), User-Ladsgroup, Structured-Data-Backlog, Multi-Content-Revisions, Structured Data Engineering, User-TheDJ, MediaWiki-File-management, MediaWiki-DjVu, Commons

Nov 10 2021

Xover added a watcher for GitLab: Xover.
Nov 10 2021, 9:02 AM
Xover added a watcher for Codex: Xover.
Nov 10 2021, 6:44 AM

Nov 8 2021

Xover added a comment to T192866: Some DjVu files have too much metadata to fit in their database column.

But stripping that out of the xml and storing it in a more efficient structure, probably would make sense, based on the numbers you are listing..

Nov 8 2021, 3:52 PM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), User-Ladsgroup, Structured-Data-Backlog, Multi-Content-Revisions, Structured Data Engineering, User-TheDJ, MediaWiki-File-management, MediaWiki-DjVu, Commons
Xover added a comment to T192866: Some DjVu files have too much metadata to fit in their database column.

Just in case it's useful, some info about the file itself:

Nov 8 2021, 1:13 PM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), User-Ladsgroup, Structured-Data-Backlog, Multi-Content-Revisions, Structured Data Engineering, User-TheDJ, MediaWiki-File-management, MediaWiki-DjVu, Commons

Nov 1 2021

Xover added a comment to T294484: <Code Stewardship Review> Thumbor.

To be clear, thumbor is just one part of the problem, the entire file management stack needs a dedicated owner.

Nov 1 2021, 8:47 PM · Performance-Team (Radar), Thumbor, Code-Stewardship-Reviews, Foundational Technology Requests

Oct 31 2021

Xover added a comment to T192866: Some DjVu files have too much metadata to fit in their database column.

c:File:A_Latin_Dictionary_(1984).djvu shows up with the right dimensions, thumbnails, etc.

s:File:A Latin Dictionary (1984).djvu shows up with 0x0 dimensions, no thumbs, etc.

Oct 31 2021, 12:34 PM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), User-Ladsgroup, Structured-Data-Backlog, Multi-Content-Revisions, Structured Data Engineering, User-TheDJ, MediaWiki-File-management, MediaWiki-DjVu, Commons
Xover added a comment to T292954: [epic] large file uploads to commons.

Ok, just reuploaded a 1.67GB (1,792,272,952 bytes) file that failed a week and a half ago (it took literally 24 hours to regenerate it from scans: I really need to get a faster laptop): c:File:A Latin Dictionary (1984).djvu

Oct 31 2021, 11:39 AM · Epic, MediaWiki-Uploading
Xover added a comment to T288382: Difficulty uploading video file to Commons via multiple methods.

@Gwennie-nyan @Askeuhd There's been a patch applied that fixes one problem that gave symptoms exactly like those described in this task. Could you both retry the uploads you mentioned to see if they go through now?

Oct 31 2021, 11:11 AM · Wikimedia-Video, Commons, UploadWizard
Xover added a comment to T288481: Unexpected upload speed to commons.

@aborrero Did you specify a -chunked to pwb.py, and if so what (5MB perhaps?)? And did you give it -async?

Oct 31 2021, 11:02 AM · MediaWiki-Uploading, SRE
Xover added a comment to T278389: File upload to Commons via UploadWizard fails with "Caught exception of type Wikimedia\Rdbms\DBQueryError".

Based on T292954 and related tasks I'd say it'd be worthwhile to retry the various failed uploads mentioned in this task. Some or all of them may now succeed, and if any still fail then at least one big potential cause has been eliminated (the locking stuff looks like it could be a separate issue from the one recently fixed in T292954).

Oct 31 2021, 10:19 AM · Structured-Data-Backlog, Structured Data Engineering, Wikimedia-production-error, UploadWizard, Commons
Xover added a comment to T287241: Add https://ia-upload.wmcloud.org to the wgCopyUploadsDomains allowlist of Wikimedia Commons .

@Inductiveload Is this resolved now?

Oct 31 2021, 10:05 AM · IA Upload, Wikimedia-Site-requests, Commons
Xover added a comment to T291805: Batch Upload for Blackwood's Magazine.

@Inductiveload Time to retry?

Oct 31 2021, 10:02 AM · User-Inductiveload

Oct 30 2021

Xover added a comment to T292954: [epic] large file uploads to commons.

Then I tried to upload 8 files with a different tool. 5 failed (not found in upload stash), 3 uploaded (the smallest files?)

Oct 30 2021, 1:25 PM · Epic, MediaWiki-Uploading
Xover added a comment to T292954: [epic] large file uploads to commons.

Ok, reupload of a previously problematic file—c:File:Frank Leslie's Illustrated Newspaper Vol. 18.djvu—using Rillke's BCU.

Oct 30 2021, 9:22 AM · Epic, MediaWiki-Uploading

Oct 29 2021

Xover added a comment to T285944: Toolforge: beta phase for the new jobs framework.

[lots of sensible things]

Oct 29 2021, 5:38 PM · Toolforge Jobs framework, cloud-services-team (Kanban)
Xover added a comment to T275752: Jobrunner timeouts on cross-DC file uploads because of HTTP/2.

"Delivering HTTP/2 upload speed improvements" from Cloudflare may be of use for Swift people looking into this or similar issues. I haven't mapped the lab numbers they use to the scenario here, but high-bandwidth+high-latency usually means you run into the Long Fat Pipe problem where TCP window scaling comes into play. And since HTTTP/2 is essentially reinventing TCP at the application layer (just with "frames" instead of "packets") it seems likely that what we're seeing here is essentially broken "HTTP window scaling" (cf. RFC7540 6.9.2): the receiver (in this case Swift) sets the window size, and is here using the 64k default size which libcurl faithfully obeys (curl itself, for downloads, switched its default to ~32MB in 7.52.0). In other words, it looks like this can't actually be tuned on the MW (libcurl) side but must happen on the Swift side if it's to be supported.

Oct 29 2021, 3:45 PM · MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Patch-For-Review, Sustainability, serviceops, SRE
Xover added a comment to T275752: Jobrunner timeouts on cross-DC file uploads because of HTTP/2.

setting curl_setopt( $ch, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_1); in the code fixes it

Oct 29 2021, 10:54 AM · MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Patch-For-Review, Sustainability, serviceops, SRE
Xover added a comment to T275752: Jobrunner timeouts on cross-DC file uploads because of HTTP/2.

#2709 landed in libcurl 7.62.0 and enabled HTTP/2 multiplexing by default when available, so Buster would indeed have changed the behaviour here as Lego suggested in T275752#7467345.

Oct 29 2021, 10:48 AM · MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Patch-For-Review, Sustainability, serviceops, SRE
Xover added a comment to T275752: Jobrunner timeouts on cross-DC file uploads because of HTTP/2.

I don't think curl sends Expect: 100-continue for chunked transfers to begin with, and I don't think chunks need to be ack'ed before sending the next in HTTP/1.1.

Oct 29 2021, 10:12 AM · MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Patch-For-Review, Sustainability, serviceops, SRE

Oct 28 2021

Xover added a comment to T285944: Toolforge: beta phase for the new jobs framework.
  • Ultimately, I probably can’t use toolforge-jobs for wd-shex-infer because no single image has all the programs needed by the tool.
Oct 28 2021, 8:57 AM · Toolforge Jobs framework, cloud-services-team (Kanban)
Xover added a comment to T285944: Toolforge: beta phase for the new jobs framework.

I should probably take the time to write some docs that helps tool maintainers understand how to interact with the service, …

Oct 28 2021, 7:44 AM · Toolforge Jobs framework, cloud-services-team (Kanban)

Oct 21 2021

Xover updated subscribers of T192866: Some DjVu files have too much metadata to fit in their database column.

The observed end-user affect of metadata numbers missing is not itself a production error.

Oct 21 2021, 9:24 AM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), User-Ladsgroup, Structured-Data-Backlog, Multi-Content-Revisions, Structured Data Engineering, User-TheDJ, MediaWiki-File-management, MediaWiki-DjVu, Commons

Oct 15 2021

Xover added a comment to T293022: LivePreview doesn't work with ProofreadPage pages.

@Daimona I am finding if I go to a new proofreading page (e.g. https://en.wikisource.beta.wmflabs.org/w/index.php?title=Page:Wind_in_the_Willows_(1913).djvu/249&action=edit ) and immediately click "Show change", I see <references/>.

Oct 15 2021, 4:26 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Community-Tech (CommTech-Sprint-11), MediaWiki-Page-editing, ProofreadPage

Oct 14 2021

Xover added a comment to T293022: LivePreview doesn't work with ProofreadPage pages.

Does the CI-related patch to PRP's tests from T292676 need to be backed out also or is that in practice unrelated?

Oct 14 2021, 6:33 AM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Community-Tech (CommTech-Sprint-11), MediaWiki-Page-editing, ProofreadPage

Oct 11 2021

Xover added a comment to T292676: New wikidiff2 version has broken ProofreadPage's PageSlotDiffRendererTest::testGetDiff and MW's REST API DiffCompare test.

See this page: open it for editing and hit "Show changes". The displayed diff should be empty, but isn't.

Cannot reproduce, the diff is empty for me, as it should be.

Oct 11 2021, 3:15 PM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), wikidiff2, Composer, ProofreadPage, MediaWiki-Core-Tests, ci-test-error (WMF-deployed Build Failure)
Xover added a comment to T292676: New wikidiff2 version has broken ProofreadPage's PageSlotDiffRendererTest::testGetDiff and MW's REST API DiffCompare test.

See this page: open it for editing and hit "Show changes". The displayed diff should be empty, but isn't.

Cannot reproduce, the diff is empty for me, as it should be.

Oct 11 2021, 1:58 PM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), wikidiff2, Composer, ProofreadPage, MediaWiki-Core-Tests, ci-test-error (WMF-deployed Build Failure)
Xover added a comment to T292954: [epic] large file uploads to commons.

Ah. "Large uploads to Commons are broken and need to be fixed" seems like a good Epic, when it manifests in multiple ways (see subtasks) and will require multiple interventions to resolve (moving imginfo to bulk storage, moving OCR out of metadata, "do something" so the job queue doesn't choke on publishing these out of stash, etc.). That satisfies the "can be fixed, even if it takes time" criterion.

Oct 11 2021, 11:38 AM · Epic, MediaWiki-Uploading
Xover added a comment to T292676: New wikidiff2 version has broken ProofreadPage's PageSlotDiffRendererTest::testGetDiff and MW's REST API DiffCompare test.

Note that the ProofreadPage test failure was not a broken test, it detected actual breakage. ProofreadPage stores multiple semi-structured parts of a page using noinclude sections (it predates MCR and other relevant facilities), and then hides these from users by hooking into the diff.

Oct 11 2021, 11:28 AM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), wikidiff2, Composer, ProofreadPage, MediaWiki-Core-Tests, ci-test-error (WMF-deployed Build Failure)

Aug 10 2021

Xover updated the task description for T286947: Determine whether the shared component library should support IE11.
Aug 10 2021, 11:59 AM · Deprecated-Design-Systems-team-board (Deprecated -DST Kanban Board 2021-2022)
Xover added a comment to T288504: ProofreadPage: hyphenation not suppressed on adjacent pages with onlysections.

It's the same issue as with references: <section> is an extension tag so the content is processed by Extension:Labeled Section Transclusion, much like <ref> is processed by Extension:Cite. I've never dived into why exactly that is, but in general there are issues with ordering and recursion that makes extension tag content inside extension tag content hard to support in the general case. Which means both these issues will need specific support in the respective extensions to solve.

Aug 10 2021, 8:25 AM · ProofreadPage

Aug 5 2021

Xover added a comment to T288191: substituting {{#tag:ref}} tags and templates; and pipe tricks fail in Page namespace.

I guess this bug only affects the advanced editors using the {{subs: feature …

Aug 5 2021, 9:11 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), MediaWiki-ContentHandler, Platform Team Workboards (MW Expedition), Regression, ProofreadPage

Aug 1 2021

Xover added a comment to T168759: -{{{ doesn't work through frame:preprocess after being unstripped from nowiki tags.

I just ran into (what I think is) this with the construct:

Aug 1 2021, 7:41 AM · MediaWiki-extensions-Scribunto, MediaWiki-Parser

Jul 20 2021

Xover updated subscribers of T166138: Please add Petit Formal Script to the UniversalLanguageSelector.

I was not aware of this concern about fontcdn. I was in the impression that it solves the issues with Google fonts. Thanks @Aklapper.

Jul 20 2021, 9:28 AM · All-and-every-Wikisource, Privacy Engineering, Patch-For-Review, UniversalLanguageSelector
Xover added a comment to T166138: Please add Petit Formal Script to the UniversalLanguageSelector.

Can that be solved by filing ticket to support WOFF2 in commons?

Jul 20 2021, 9:13 AM · All-and-every-Wikisource, Privacy Engineering, Patch-For-Review, UniversalLanguageSelector

Jul 19 2021

Xover updated subscribers of T269818: New OCR tool should be able to OCR part of a page.

ImageMagick will do this in about 20 lines of code all-in including bounds checking.

Jul 19 2021, 8:39 PM · Community-Tech (CommTech-Sprint-7), Wikimedia OCR
Xover added a comment to T230689: Preload the next page's image on proofreading view.

Sounds like a reasonable tradeoff to me.

Jul 19 2021, 6:53 PM · Community-Tech (CommTech-Sprint-7), MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Patch-For-Review, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), ProofreadPage
Xover updated subscribers of T166138: Please add Petit Formal Script to the UniversalLanguageSelector.

It does not fall strictly within "language support" in terms of i18n/i10n.

Jul 19 2021, 4:21 PM · All-and-every-Wikisource, Privacy Engineering, Patch-For-Review, UniversalLanguageSelector
Xover added a comment to T166138: Please add Petit Formal Script to the UniversalLanguageSelector.

The intention is that ULS does not become generic web fonts provider in MediaWiki.

Jul 19 2021, 2:05 PM · All-and-every-Wikisource, Privacy Engineering, Patch-For-Review, UniversalLanguageSelector
Xover added a comment to T269818: New OCR tool should be able to OCR part of a page.

apparently Mediawiki doesn't support this (according to #wikimedia-tech).

Jul 19 2021, 11:09 AM · Community-Tech (CommTech-Sprint-7), Wikimedia OCR
Xover added a comment to T230689: Preload the next page's image on proofreading view.

… an average of under half a MB is nearly nothing.

Jul 19 2021, 10:47 AM · Community-Tech (CommTech-Sprint-7), MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Patch-For-Review, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), ProofreadPage

Jul 17 2021

Xover added a comment to T230689: Preload the next page's image on proofreading view.

I think we're overcomplicating this.

Jul 17 2021, 6:54 PM · Community-Tech (CommTech-Sprint-7), MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Patch-For-Review, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), ProofreadPage

Jul 9 2021

Xover added a comment to T286356: WS OCR: Cache next page(s) for even faster loading.

If resource consumption is a concern, I think a single page will cover the wast majority of cases; and the exceptions have a fairly benign failure mode (it's an additional optimisation). But, yeah, "what Inductiveload said", essentially.

Jul 9 2021, 3:24 PM · QTE-TestingOverview, Community-Tech (CommTech-Sprint-7), MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), Patch-For-Review, Wikimedia OCR
Xover added a comment to T285712: Optimize "Extract text" button concerns.

Ok, an attempt at some concrete suggestions…

Jul 9 2021, 3:19 PM · Community-Tech (CommTech-Sprint-7), MW-1.37-notes (1.37.0-wmf.16; 2021-07-26), Wikimedia OCR

Jul 8 2021

Xover added a comment to T283897: Clean up OCR gadgets.
  • If we were to change the position of the transcribe button and instead place it in the tool bar, with a drop down, as noted in this ticket, would you still be opposed to the gadget clean up?
Jul 8 2021, 9:50 PM · Community-Tech (CommTech-Sprint-4), Wikimedia OCR