Page MenuHomePhabricator

Xover
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 16 2017, 6:32 PM (309 w, 1 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Xover [ Global Accounts ]

Recent Activity

Wed, Mar 15

Xover added a comment to T331138: FileBackendMultiWrite multi-dc and thumbnail handling.

I checked maintainer's page on MediaWiki to find a good team tag and came up empty

Wed, Mar 15, 3:29 PM · SRE-swift-storage, MediaWiki-File-management
Xover added a comment to T331138: FileBackendMultiWrite multi-dc and thumbnail handling.

Also: if pre-generation of thumbs makes sense (does it? do we have any numbers on this stuff?) …

Wed, Mar 15, 3:03 PM · SRE-swift-storage, MediaWiki-File-management

Wed, Feb 22

Xover added a comment to T313945: [EPIC] Enable gadget and user-script developers to use Vue and Codex.

Could we add to the checks for this epic:

Wed, Feb 22, 9:14 AM · Front-end Modernization, Design-Systems-Team, Codex, Epic

Feb 16 2023

Xover reopened T329432: Add a tracking category when the section name given to the #lst parser function does not exist as "Open".
Feb 16 2023, 3:55 PM · MW-1.40-notes (1.40.0-wmf.24; 2023-02-20), MediaWiki-extensions-LabeledSectionTransclusion
Xover added a comment to T329432: Add a tracking category when the section name given to the #lst parser function does not exist.

At least one of these $parser->addTrackingCategory("lst-invalid-section-category"); calls is bogus. s:Category:Pages transcluding nonexistent sections is filling up with entries for pages that are quite correctly transcluding a named section. My guess is the last one, but I haven't traced it.

Feb 16 2023, 3:55 PM · MW-1.40-notes (1.40.0-wmf.24; 2023-02-20), MediaWiki-extensions-LabeledSectionTransclusion

Jan 28 2023

Xover added a comment to T320236: Some Oxford University Press resources are unavailable.

So... still no news?

Jan 28 2023, 4:22 PM · The-Wikipedia-Library

Jan 14 2023

Xover changed the subtype of T305792: Allow per-work CSS inside references from "Feature Request" to "Bug Report".
Jan 14 2023, 8:38 AM · All-and-every-Wikisource, TemplateStyles, ProofreadPage

Jan 2 2023

Xover merged task T204020: OCR extracted from DjVu files is incorrectly assigned to pages into T219376: retrieveMetaData() in DjVuImage.php creates knock-on error when a page has invalid text layer.
Jan 2 2023, 3:31 PM · All-and-every-Wikisource, ProofreadPage, Multimedia, MediaWiki-DjVu
Xover merged T204020: OCR extracted from DjVu files is incorrectly assigned to pages into T219376: retrieveMetaData() in DjVuImage.php creates knock-on error when a page has invalid text layer.
Jan 2 2023, 3:31 PM · Multimedia, MediaWiki-DjVu

Dec 8 2022

Xover merged T324772: Transcribe text error message into T324740: Wikimedia OCR fails with 400 status.
Dec 8 2022, 6:50 PM · Community-Tech (CommTech-Sprint-39), MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, Wikimedia OCR
Xover merged task T324772: Transcribe text error message into T324740: Wikimedia OCR fails with 400 status.
Dec 8 2022, 6:50 PM · ProofreadPage
Xover created T324775: Setting PRP/OSD zoom factor pref to 1.0 disables zooming.
Dec 8 2022, 4:35 PM · ProofreadPage
Xover merged T324758: Link broken into T324740: Wikimedia OCR fails with 400 status.
Dec 8 2022, 3:41 PM · Community-Tech (CommTech-Sprint-39), MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, Wikimedia OCR
Xover merged task T324758: Link broken into T324740: Wikimedia OCR fails with 400 status.
Dec 8 2022, 3:40 PM · Community-Tech, Wikimedia OCR
Xover added a comment to T200704: TemplateStyles don't work when the template is inside a link.

I guess one way to fix this is to just wait for parser unification.

Dec 8 2022, 1:43 PM · MediaWiki-Parser, TemplateStyles
Xover added a comment to T324740: Wikimedia OCR fails with 400 status.

I think we can use the pattern="/regex/" to bypass the default URL checking ?

Dec 8 2022, 9:09 AM · Community-Tech (CommTech-Sprint-39), MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, Wikimedia OCR
Xover added a comment to T324740: Wikimedia OCR fails with 400 status.

There's still an issue (with Firefox at any rate) of the form field (which is of type url) not accepting protocol-relative URLs.

Dec 8 2022, 9:05 AM · Community-Tech (CommTech-Sprint-39), MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, Wikimedia OCR
Xover added a comment to T324740: Wikimedia OCR fails with 400 status.

Checked on the web interface (ocr.wmclod) by manually adding "https:" to the URL and it worked fine, so it does indeed seem to be just a dumb regex match problem. Easy bugs are the bestest bugs! :-)

Dec 8 2022, 7:48 AM · Community-Tech (CommTech-Sprint-39), MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, Wikimedia OCR
Xover updated subscribers of T309267: JS error when editing Page NS pages that don't exist.

@Soda I think you're touching code related to this for other reasons, so you may want to be aware of this task. In addition to $prpImage being undefined, pages such as this also trigger an error notification from OSD that there's no image.

Dec 8 2022, 7:43 AM · MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), Wikimedia OCR
Xover updated the task description for T324740: Wikimedia OCR fails with 400 status.
Dec 8 2022, 7:26 AM · Community-Tech (CommTech-Sprint-39), MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, Wikimedia OCR
Xover created T324740: Wikimedia OCR fails with 400 status.
Dec 8 2022, 7:23 AM · Community-Tech (CommTech-Sprint-39), MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Patch-For-Review, Wikimedia OCR

Dec 1 2022

Xover added a comment to T200704: TemplateStyles don't work when the template is inside a link.

This is really annoying for the Wikisourcen since their formatting needs follow whatever the text they are reproducing used, rather than a project-specific manual of style. It is very common to have typical linkable phrases (names of authors, say) formatted with multiple styles (i.e. multiple formatting templates) such that the template(s) cannot be moved outside the link.

Dec 1 2022, 8:23 AM · MediaWiki-Parser, TemplateStyles

Nov 10 2022

Xover added a comment to T322873: Transcluded page not showing as expected.

Transclusion with PRP does not show the page image, but rather the wikitext of the associated Page:-namespace page. Does this wikipage have any contents? And if so, what is it? If you check the mainspace page in your web browser’s Web Inspector, do you find a node with #prp-pages-output?

Nov 10 2022, 8:02 PM · ProofreadPage
Xover added a comment to T322849: Proofread's SpecialPagesWithoutScans makes extremely slow queries.

Ok, I can confirm that all the pages in the query results above are "naked" pages (not connected to a scan).

Nov 10 2022, 2:56 PM · DBA, MW-1.40-notes (1.40.0-wmf.8; 2022-10-31), ProofreadPage
Xover added a comment to T322849: Proofread's SpecialPagesWithoutScans makes extremely slow queries.

For sanity-checking you can use Phe-tools' statistics, where the "w/o scans" column for a given language Wikisource should show a number roughly the same as the (COUNT) number of results of your query. I can also probably dig up the exact query Phe's tool is using if interesting, but it'll be several years since it was tweaked (I think Phe went inactive around 2015/2016 or so).

Nov 10 2022, 2:36 PM · DBA, MW-1.40-notes (1.40.0-wmf.8; 2022-10-31), ProofreadPage
Xover added a comment to T322849: Proofread's SpecialPagesWithoutScans makes extremely slow queries.

Possibly related: T311901, T317992, T310648

Nov 10 2022, 2:23 PM · DBA, MW-1.40-notes (1.40.0-wmf.8; 2022-10-31), ProofreadPage

Nov 5 2022

Xover created T322470: Support multiple pages in API:Delete.
Nov 5 2022, 9:08 AM · ProofreadPage, All-and-every-Wikisource, MediaWiki-Action-API

Nov 2 2022

Xover updated subscribers of T305792: Allow per-work CSS inside references.

Oh, indeed. Normal TableStyles are scoped to .mw-parser-output, but Index:-styles are scoped additionally to .prp-pages-output in mainspace and .pagetext in the Page: namespace. In Page: namespace the whole content (including header/footer) is contained within .pagetext and so it works fine. But in mainspace the rendered references are not mediated through Proofread Page (it uses Cite directly) and so are not contained within .prp-pages-output and the selectors cannot match.

Nov 2 2022, 3:09 PM · All-and-every-Wikisource, TemplateStyles, ProofreadPage
Xover added a comment to T296847: Third-party resources policy.

… I'm not sure why gadget security would not fall into security team's purview, at least on the high level of where code can be loaded from..?

Nov 2 2022, 8:08 AM · SecTeam-Processed, Privacy Engineering, tech-decision-forum

Oct 29 2022

Xover added a comment to T321446: ProofreadPage index JSON access not working.

@Umherirrender: Thank you! Will this default to the main slot like other API calls, or will the slot need to always be specified explicitly?

Oct 29 2022, 9:16 PM · Patch-For-Review, ProofreadPage
Xover added a watcher for All-and-every-Wikisource: Xover.
Oct 29 2022, 9:08 PM
Xover added a member for All-and-every-Wikisource: Xover.
Oct 29 2022, 9:08 PM
Xover added a comment to T305792: Allow per-work CSS inside references.

@Candalua Do you have a page exhibiting this problem? And do you mean .prp-pages-output or .mw-parser-output (to which TemplateStyles are normally scoped)?

Oct 29 2022, 3:21 PM · All-and-every-Wikisource, TemplateStyles, ProofreadPage
Xover added a comment to T285173: Allow @import of local sanitised CSS files into other sanitised CSS files on same wiki.

… Still it seems like a lot of effort for something that can already be handled by normal template transclusion mechanics (use separate stylesheets and an intermediary template to group them together).

Oct 29 2022, 3:17 PM · TemplateStyles, css-sanitizer

Oct 28 2022

Xover added a comment to T311901: Special:PagesWithoutScans shows only one entry repeated 5000 times.

Given there weren't reports of duplicated scans for a bit, marking this as resolved. Feel free to re-open if I'm wrong :)

Oct 28 2022, 10:49 AM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), ProofreadPage
Xover renamed T311901: Special:PagesWithoutScans shows only one entry repeated 5000 times from Special:PagesWithoutScans displays duplicated results to Special:PagesWithoutScans shows only one entry repeated 5000 times.
Oct 28 2022, 10:44 AM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), ProofreadPage

Oct 26 2022

Xover added a comment to T204201: Extend MediaWiki:Gadgets-definition capabilities.

[…] Namespaces could be less urgent/relevant.

Oct 26 2022, 1:59 PM · Patch-For-Review, MediaWiki-extensions-Gadgets

Sep 6 2022

Xover added a comment to T313409: Hide article toolbar/tab-bar if there is only one item/tab.

Gah. I'm religiously in favour of trimming away unneeded stuff in the UI (cf. T163098), but as I read the above comments I realise I rely on that behaviour too: for lots of pages I use the tab to get a "clean" (or just specific or predictable) version of the page, or a related page (i.e. talk vs. main vs. history etc.). And perhaps key here, not just on special pages. That is, if just special pages change (no tab but grow a reset button in the page-specific UI) I can't just retrain muscle memory, it'll end up being a constant impedance.

Sep 6 2022, 6:08 AM · MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Readers-Web-Backlog (Kanbanana-2022-23-Q1), MediaWiki-Core-Skin-Architecture (Menus 2.0), Desktop Improvements (Vector 2022)
Xover added a comment to T316908: [Potentially breaking change in Vector 2022] #p-namespaces element being replaced by #p-associated-pages.

Note that only the following are documented targets of mw.util.addPortletLink():

Sep 6 2022, 5:47 AM · User-notice-archive

Aug 25 2022

Xover added a comment to T311647: [Goal] Develop a new menu system API in core.
  • A lot of gadgets add menu items (which are essentially launch buttons) to the sidebar, but it might have sense to have a dedicated gadgets menu (consider e.g. the plugins dropdown menu in Chrome).
Aug 25 2022, 5:19 PM · Readers-Web-Backlog (Kanbanana-2022-23-Q1), Goal, MediaWiki-Core-Skin-Architecture (Menus 2.0)
Xover added a comment to T316169: Left tab bar wraps each item into a new line on all Wikisource.

The "Source" tab is a proper peer to "Page" and "Discussion" on Proofread page-based wikis (like the Wikisourcen), so mw.util.addPortletLink() is not an appropriate fix for this problem.

Aug 25 2022, 4:40 PM · MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), ProofreadPage, Patch-For-Review, All-and-every-Wikisource

Aug 13 2022

Xover added a comment to T123174: Code from MediaWiki:Base.js removes the linebreak before "|-", breaking table on Wikisource.

@He7d3r Is this task still relevant? It seems to refer to a specific bug in a specific on-wiki/community maintained script on mulWS (possibly cross-loaded on ptWS, but not on e.g. enWS where Easy LST is a local Gadget),and one that has either been fixed or mooted by subsequent changes. Perhaps this task can be closed as (now) Invalid?

Aug 13 2022, 12:26 PM · All-and-every-Wikisource, JavaScript, Regression
Xover added a comment to T172276: Tool "bub" loads assets from ajax.googleapis.com.

@Nemo_bis @Samwilson @8ohit.dua If BUB is dead can't this task be closed as Invalid? Or did it get resurrected somewhere and where this task is still relevant?

Aug 13 2022, 12:10 PM · All-and-every-Wikisource, Tools
Xover added a comment to T71445: Implement a proper code-review process for MediaWiki JS/CSS pages on Wikimedia sites.

Quick idea version 2 for an extension + workflow

Aug 13 2022, 11:25 AM · Security, Developer-Wishlist (2017), Developer-Advocacy, MediaWiki-extensions-Gadgets, JavaScript, WMF-General-or-Unknown

Jul 27 2022

Xover added a comment to T279421: Update Vue and Codex documentation for WMF staff and community developers.

Ok, since the Vue.js decision announcement I've been looking for some kind of status or guidance or roadmap for client-side UI for Gadget and User script developers. That used to be jQuery UI, but upstream put that in maintenance-only mode in 2018 and it was deprecated in MW 1.29. The new hotness was OOUI, but it was never very suitable for this use case and realistically now will never be. Where the puck is going is, from all appearances, Codex; but try as I might I can't find more than incidental mentions of User scripts and Gadgets as a use case (and mostly in the "select a framework" Phab task). There's all of one open task on the Codex workboard (T311099) related to this, and that's just the icons.

Jul 27 2022, 7:18 AM · Design-Systems-Team (Design-Systems-Sprint), User-AKlapper, Wikimedia-Developer-Portal, Documentation, Wikimedia Design Style Guide, Front-end-Standards-Group, OOUI
Xover added a comment to T279421: Update Vue and Codex documentation for WMF staff and community developers.

@egardner wrote:

  • Archive, delete, or prune old Vue Migration Team pages as necessary (may need help from someone with admin privileges to delete pages).
Jul 27 2022, 6:42 AM · Design-Systems-Team (Design-Systems-Sprint), User-AKlapper, Wikimedia-Developer-Portal, Documentation, Wikimedia Design Style Guide, Front-end-Standards-Group, OOUI

Jul 13 2022

Xover added a comment to T309451: Live preview shows incorrect proofread status and headers.

Absent further comments let me be a bit more direct: looking at T304303 I see no upside that to me justifies breaking this long-standing and core end-user-visible functionality. Page-spanning constructs (e.g. tables, like the tables of contents in just about every book) are now literally impossible to work with when live previews are on, and it is in practice impossible for a user (even experienced users) to tell what's going on or how to work around it. IMO, if this cannot be fixed some other way relatively soon the triggering change will have to be rolled back.

Jul 13 2022, 9:38 AM · MediaWiki-Page-editing, ProofreadPage

Jul 7 2022

Xover added a comment to T312513: ws_ocr_daemon is not running on German Wikisource.

Is there a way or is it even planned to remove the old non-working OCR buttons from the toolbar?

https://de.wikisource.org/wiki/Spezial:Einstellungen#mw-prefsection-gadgets lists an item "OCR Buttons deaktivieren". Per https://de.wikisource.org/wiki/MediaWiki:Gadgets-definition its code is at https://de.wikisource.org/wiki/MediaWiki:Gadget-PR-ocr.js . That one line of code implies that it comes from ProofreadPage maybe? I guess that something (ProofreadPage?) loads https://wikisource.org/w/index.php?title=MediaWiki:OCR.js which loads phetools.

Jul 7 2022, 12:52 PM · Tools
Xover added a comment to T312513: ws_ocr_daemon is not running on German Wikisource.

Those two buttons use the phetools OCR system, which is no longer maintained.

Jul 7 2022, 12:33 PM · Tools

Jul 6 2022

Xover added a comment to T309490: Add book search functionality to mainspace books in Wikisource.

… For the Page: namespace, prpIndexTitle is the variable you want to use to get the Index: page …

Jul 6 2022, 9:10 AM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), ProofreadPage, Patch-For-Review, All-and-every-Wikisource

Jul 5 2022

Xover added a comment to T309451: Live preview shows incorrect proofread status and headers.

This bug affects not just the proofread status, which is more cosmetic than anything, but also all other uses of the header and footer, which is a lot more troublesome. Most obviously it means you can't preview any changes to the content in the header/footer (a running header, for example); but it also breaks the use of any page-spanning templates. For example, on enWS Template:TOCstyle generates a table and relies on having {{TOCstyle|header=yes}} in the header so that when invoked in the body with {{TOCstyle|continues=yes}} it can output only a markup fragment. Since the preview doesn't have the header the body ends up being parsed as generic unordered list markup. enWS has a number of templates that operate on this model. And without testing I imagine it also will affect any other page-spanning constructs such as basic table wikimarkup (multipage tables are common in all sorts of works).

Jul 5 2022, 10:14 AM · MediaWiki-Page-editing, ProofreadPage
Xover added a project to T309490: Add book search functionality to mainspace books in Wikisource: ProofreadPage.
Jul 5 2022, 9:38 AM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), ProofreadPage, Patch-For-Review, All-and-every-Wikisource
Xover added a comment to T309490: Add book search functionality to mainspace books in Wikisource.

I don't think this change will affect the Translation: namespace at all, since we filter only main namespace pages before we add these variables/information.

Jul 5 2022, 9:27 AM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), ProofreadPage, Patch-For-Review, All-and-every-Wikisource
Xover added a comment to T309490: Add book search functionality to mainspace books in Wikisource.

Ok, I've checked all usages on enWS (and noWS, incidentally) and apart from user scripts for inactive users, there is only one remaining instance. I've notified the user, but I suspect the script isn't actually in use currently (it hasn't been modified since 2011). In other words, enWS should be fine when the train rolls around tomorrow. But I'm still a little worried about the other projects.

Jul 5 2022, 9:14 AM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), ProofreadPage, Patch-For-Review, All-and-every-Wikisource
Xover added a comment to T309490: Add book search functionality to mainspace books in Wikisource.

Incidentally, this change seems to have some sort of bearing on T53980 (from 2013!), though I'm not sure of in what way yet (makes it easier? harder? fixes it as an incidental effect? makes on-wiki workarounds easier?).

Jul 5 2022, 8:43 AM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), ProofreadPage, Patch-For-Review, All-and-every-Wikisource
Xover added a comment to T309490: Add book search functionality to mainspace books in Wikisource.

This change removes the proofreadpage_source_href JS variable from mw.configand replaces it with a new variable prpSourceIndexPage.

Jul 5 2022, 7:47 AM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), ProofreadPage, Patch-For-Review, All-and-every-Wikisource

Jun 5 2022

Xover added a comment to T238285: Pages whose title ends with semicolon (;) are intermittently inaccessible (likely due to ATS).

@BBlack The last status update on this bug was ~18 months ago, and indicated the issue was an upstream bug and you were following up there, with a fallback to a WMF-specific patch if upstream got stuck. I see no indication there is any question this behaviour is a bug (cf. eg. Krinkle's comment above). It's also a problem that makes certain pages inaccessible on all projects, breaks contribution histories and other core features for certain users, and necessitates manually prohibiting a character in page and user names that is intended to be permitted.

Jun 5 2022, 4:48 PM · Traffic-Icebox, affects-Kiwix-and-openZIM, WMF-General-or-Unknown, SRE, User-DannyS712

Mar 6 2022

Xover added a comment to T296847: Third-party resources policy.

Hmm. Then I think the problem statement is a little bit the wrong way around: it reads as if the aim is to lock down a currently reigning "Wild West" state of affairs, but in light of your clarification it sounds like the focus is more to enable a use of third-party resources that are difficult or impossible to (legally) do today but which would be of benefit to the Movement. And, obviously, when enabling such use it is desirable to do so in a controlled way that prioritises privacy, is sustainable, does not negatively impact performance, and so forth; but this then is not the focus so much as the consequence.

Mar 6 2022, 10:42 AM · SecTeam-Processed, Privacy Engineering, tech-decision-forum

Mar 2 2022

Xover added a comment to T296847: Third-party resources policy.

I'm confused by this problem statement. The Privacy Policy already forbids anything on Wikimedia projects that causes the UA to contact any third-party website, including Toolforge and WMCS, for any purpose (any HTTP header and the client IP are covered by the definition of "Personal information"). So regardless of whether it's executable code, an image, a webfont, JSON/JSONP data, etc. it is currently bright-line forbidden. What, then, would this "clear Wikimedia policy on the use of third-party resources" cover?

Mar 2 2022, 9:42 AM · SecTeam-Processed, Privacy Engineering, tech-decision-forum

Feb 25 2022

Xover added a comment to T277267: Displayed Number in TopPanel is offset for numbers lower than 100.

is it possible to have the link of the page please ?

Feb 25 2022, 5:32 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Patch-For-Review, MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), good first task, ProofreadPage

Feb 24 2022

Xover added a comment to T277267: Displayed Number in TopPanel is offset for numbers lower than 100.

in addition each label is now inline rather than block

That was already the case before, but there were hidden 0 to fill the space you highlighted as empty.

Feb 24 2022, 8:08 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Patch-For-Review, MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), good first task, ProofreadPage
Xover added a comment to T277267: Displayed Number in TopPanel is offset for numbers lower than 100.

what do you prefer ?

Feb 24 2022, 8:00 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Patch-For-Review, MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), good first task, ProofreadPage
Xover added a comment to T277267: Displayed Number in TopPanel is offset for numbers lower than 100.

The layout changes for the pagelist in this task are kinda suboptimal. There seems to be significantly increased margins around each page label, and in addition each label is now inline rather than block so the containers (on which the background is applied) collapse down to essentially just the character boxes. See the before—after screenshots below:

Feb 24 2022, 10:42 AM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Patch-For-Review, MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), good first task, ProofreadPage

Feb 13 2022

Xover created P20618 git-review output with outstanding patches.
Feb 13 2022, 8:36 AM

Feb 12 2022

Xover created T301610: upload.create_warnings_list() throws KeyError when ignore_warnings is true.
Feb 12 2022, 1:42 PM · Pywikibot

Jan 31 2022

Xover created T300531: imagetransfer.py doesn't support async and chunked upload.
Jan 31 2022, 3:10 PM · Pywikibot

Jan 30 2022

Xover created T300467: Expose section identifier in HTML output.
Jan 30 2022, 7:46 PM · MediaWiki-Parser
Xover created T300465: Documentation for "section" parameter of Edit API says "number" but should be "identifier".
Jan 30 2022, 7:20 PM · MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), MediaWiki-Documentation, MediaWiki-Action-API

Jan 24 2022

Xover added a comment to T299880: Wikisource book download buttons don't work.

Dollars to dimes they're just scraping works for some ebook site based on the OPML.

Jan 24 2022, 3:49 PM · WS Export, Community-Tech

Jan 17 2022

Xover added a comment to T299124: ProofreadPage frontend makes a request to the page before and after in every page view.

Then it can make a request to the thumbnail instead of the page. I think this at least reduces the pressure on the appservers.

Jan 17 2022, 9:13 AM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Performance-Team (Radar), ProofreadPage

Jan 13 2022

Xover added a comment to T299124: ProofreadPage frontend makes a request to the page before and after in every page view.

It is probably worth revisiting, yes, but note that interactive performance here depends on dynamically generated "thumbnail" images, where the generation involves shelling out to ghostscript (for PDFs) and ddjvu (for DjVu) to extract a given page from a possibly ~1GB multi-page document and rendering it to a JPEG. Ghostscript, in particular, can (anecdotally) take ~20 seconds to do this.

Jan 13 2022, 2:32 PM · MW-1.40-notes (1.40.0-wmf.7; 2022-10-24), Performance-Team (Radar), ProofreadPage

Jan 12 2022

Xover updated subscribers of T298992: ProofreadPages: incorrect spacing between words in rendered PDF page.

Last I heard (I could be wrong), MediaWiki-extensions-PdfHandler (ping @Tgr) uses Ghostscript to render PDFs to JPEG thumbnails, meaning this is most likely an upstream bug affecting certain born-digital PDFs. Best case for fixing it is probably using a newer version of ghostscript, which I'm guessing would be blocked on T289228. If it can be reproduced in base latest-version ghostscript it should probably reported upstream, and a fix here would then also depend on when upstream makes a release with a fix. Alternately, there is T38594; but I suspect it'd be fairly resource-intensive on the MediaWiki side, and I have no idea what the relative merits of Ghostscript and MuPDF are. A switch might conceivably have a positive effect on the problem described in T242169 (or it might not; or it might make it worse).

Jan 12 2022, 12:33 PM · MediaWiki-extensions-PdfHandler, ProofreadPage

Jan 7 2022

Xover added a comment to T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

The user that first reported this issue on enWS has tested and confirmed that it is now fixed for them. And my own testing concurs.

Jan 7 2022, 12:54 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage
Xover added a comment to T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

Crap, I notice we don't have any regular backport windows until Monday. While this wasn't train-blocking/rollback when noticed, it's probably UBL-y enough that it needs to go out as an emergency backport. It doesn't break the primary workflow in that the Wikisourcen can still edit pages, it does break the zoom/pan for the reference page image (which is highly-used functionality) and partially breaks (blocks) the UI for setting page status (particularly for people with page zoom on in the browser, which is a major accessibility issue and primary workflow).

Jan 7 2022, 11:04 AM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Jan 6 2022

Xover added a comment to T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

Updated patch looks good to me, but I'm not sufficiently familiar with the context there for that to mean much.

Jan 6 2022, 7:33 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage
Xover added a comment to T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

Patchdemo looks good to me: no console errors, all the OSD stuff (zoom, rotate, etc.) looks like it works, and it even seems to fix the unresponsive radio buttons that were reported on-wiki.

Jan 6 2022, 4:43 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage
Xover added a comment to T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

How big is the impact? Should this be a train blocker?

Jan 6 2022, 3:20 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage
Xover added a comment to T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

Ah, oh, yes, I see. When we start, $imgContHorizontal is initialized to null (what's the point of that long chain of vars getting set to null at the top? They should either be set to something useful or their initialization might as well be deferred until first used.). It doesn't actually get assigned any value until toggleLayout() is called, and there it's wrapped inside a conditional such that it is only initialized if the layout is already horizontal (if (!isLayoutHorizontal)). When we start in vertical mode the var is never initialized, until something actually triggers toggleLayout(); but then a few lines later $imgContHorizontal.add() is called regardless of which branch was picked in the preceding conditional.

Jan 6 2022, 2:35 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage
Xover updated subscribers of T298694: ProofreadPage: zoom/pan not working in side-by-side editing mode.

But why is $imgContHorizontal undefined here?

Jan 6 2022, 2:09 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Jan 5 2022

Xover added a comment to T298613: Update GentiumPlus to 6.001.

@santhosh You're listed as the maintainer for jQuery.WebFonts so I tagged you on this. If this isn't your bailiwick I'd appreciate a pointer in the right direction.

Jan 5 2022, 2:33 PM · Unplanned-Sprint-Work, Language-Team (Language-2022-January-March), All-and-every-Wikisource, UniversalLanguageSelector
Xover created T298613: Update GentiumPlus to 6.001.
Jan 5 2022, 2:30 PM · Unplanned-Sprint-Work, Language-Team (Language-2022-January-March), All-and-every-Wikisource, UniversalLanguageSelector

Jan 3 2022

Xover added a comment to T298417: Undeleted djvu files show incorrect metadata: 0x0 size, no page number info.

… I found only 100 deleted djvu files in the db …

Jan 3 2022, 8:31 AM · MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), Commons, MediaWiki-File-management, MediaWiki-DjVu

Dec 29 2021

Xover added a comment to T137584: Allow Scribunto code to add a category without changing output.

@Agabi10 Did you give up on this patch? It looks really useful to me, and from the review comments it didn't look like there were any insurmountable problems (just maybe some documentable limitations due to the architecture context).

Dec 29 2021, 11:38 AM · Patch-Needs-Improvement, Platform Engineering, MediaWiki-extensions-Scribunto
Xover added a comment to T209310: Consider implementing Module:No globals / Log globals in Scribunto itself.

There's no obvious reason Scribunto should unconditionally enforce this when Lua as such doesn't, but that's an issue of defaults and somewhat orthogonal, IMO.

Dec 29 2021, 11:06 AM · User-notice-archive, MW-1.40-notes (1.40.0-wmf.6; 2022-10-17), MediaWiki-extensions-Scribunto
Xover updated subscribers of T283758: Specific page on English Wikipedia generates numerous "Lua error: not enough memory" errors.

@RoySmith I've updated the task description to point at the relevant thread in the archives. But perhaps you (or perhaps @Pppery) could summarise the information learned in that thread for the benefits of others stumbling across similar issues and searches Phabricator?

Dec 29 2021, 10:43 AM · covid-19, Performance Issue, MediaWiki-extensions-Scribunto
Xover updated the task description for T283758: Specific page on English Wikipedia generates numerous "Lua error: not enough memory" errors.
Dec 29 2021, 10:33 AM · covid-19, Performance Issue, MediaWiki-extensions-Scribunto
Xover added a comment to T277203: Add support for derived MCR slots.

This sounds really cool, but I am having trouble seeing what the use case for it is. What kind of data would one put in a "derived slot"? And since it is programatically generated, why not handle it in the parser and its cache?

Dec 29 2021, 10:20 AM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Multi-Content-Revisions (New Features)

Dec 22 2021

Xover merged task T297420: Landscape View in Edit Mode not possible: TypeError: can't redefine non-configurable property "SetCookie" into T297338: Switching to horizontal mode in ProofreadPage leaves the edit window narrow.
Dec 22 2021, 8:21 AM · ProofreadPage
Xover merged T297420: Landscape View in Edit Mode not possible: TypeError: can't redefine non-configurable property "SetCookie" into T297338: Switching to horizontal mode in ProofreadPage leaves the edit window narrow.
Dec 22 2021, 8:21 AM · ProofreadPage

Dec 16 2021

Xover updated subscribers of T297420: Landscape View in Edit Mode not possible: TypeError: can't redefine non-configurable property "SetCookie".

Based on that error message it smells like a namespace collision. deWS has a lot of site-local JS that uses (and defines) a "SetCookie" function. That's a pretty generic name for such a function, so it may well be clashing with a name from elsewhere (e.g. the recent OSD stuff).

Dec 16 2021, 3:24 PM · ProofreadPage
Xover added a comment to T297861: I can't proofread after upload to new version of a PDF file..

@Satirdan_kahraman The cover image (page 1) just needed a null edit, so there was apparently some kind of caching issue. I checked a few of the pages that have not yet been proofread and they appeared to load correctly.

Dec 16 2021, 2:52 PM · ProofreadPage

Dec 2 2021

Xover added a comment to T296893: Replace Diffusion integration with Gitlab integration in Striker (toolsadmin).

@bd808 I still can't find any mention of Toolforge on mw:GitLab or its subpages, so do we need a separate task to set policy for access/groups/directory layout in GitLab? What's currently documented only deals with WMF and WMDE components, and I am not immediately convinced that the assumptions for those hold in the context of Toolforge.

Dec 2 2021, 5:50 AM · Developer-Advocacy (Jul-Sep 2022), User-bd808, Goal, GitLab (Project Migration), Tools, Striker

Dec 1 2021

Xover added a comment to T285610: Pages corresponding to tables of contents' second links are not provided the first link as the "prev" parameter for headers generated with <pages>.

@Tpt As best I can tell, the automatic next link on the main page was the existing behaviour. When the work's title was in $indexLinks[0], the if test inside the for loop would get a hit and set $current. The prev link test then explicitly excluded it by skipping index 0, but the next test just checked that it wasn't the last entry in the array ($i + 1 < $indexLinksCount) and so would add a next link on the page corresponding to the work's title.

Dec 1 2021, 5:52 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Nov 30 2021

Xover added a comment to T285610: Pages corresponding to tables of contents' second links are not provided the first link as the "prev" parameter for headers generated with <pages>.

Hmm. I may be insufficiently caffeinated just now, but…

Nov 30 2021, 10:38 AM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), ProofreadPage

Nov 24 2021

Xover added a comment to T288141: ProofreadPage: use OpenSeadragon for the Page NS image viewer.

@Xover Can you suggest a place (can be phabricator as well) where users can interact with more expert ones to discuss such technical issues? I reckon that this is a specific case where such help is needed and requires a longer discussion.

Nov 24 2021, 9:51 AM · ProofreadPage
Xover added a comment to T288141: ProofreadPage: use OpenSeadragon for the Page NS image viewer.

@Alex_brollo I don't think reversing a change that brings big improvements is the way to go (and this cannot function as a gadget), but your use case is interesting. Instead of trying to manually undo the changes I would suggest you try to find ways to use the new facilities to do what you're after. A lot of it I would expect to already be possible (OSD has an API exposed that can be used), and what's missing are probably good candidates for adding. If you explain your needs it might be possible to suggest alternate approaches for them.

Nov 24 2021, 9:08 AM · ProofreadPage

Nov 20 2021

Xover added a comment to T215558: Proofread Page extension on Wikisource is displaying wrong pages; purge on Commons file fails.

Hmm. No smoking gun there that I can find.

Nov 20 2021, 3:02 PM · Multimedia, MediaWiki-DjVu, Commons, ProofreadPage, All-and-every-Wikisource

Nov 18 2021

Xover added a comment to T296001: DjVuHandler: getDimensionInfoFromMetaTree: PHP Notice: Undefined index: pages.

Dollars to dimes it's choking on c:File:Cyclopaedia of English Literature 1844 Volume 1 page 548.djvu which is in that category and is currently showing up with 0x0 dimensions and 0 pages. The djvudump structure for this files is:

Nov 18 2021, 5:43 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, DBA, User-Ladsgroup, MediaWiki-DjVu, Structured-Data-Backlog, Wikimedia-production-error
Xover updated subscribers of T296001: DjVuHandler: getDimensionInfoFromMetaTree: PHP Notice: Undefined index: pages.

Possibly triggered by the changes from T275268. Ping @Ladsgroup.

Nov 18 2021, 5:10 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, DBA, User-Ladsgroup, MediaWiki-DjVu, Structured-Data-Backlog, Wikimedia-production-error

Nov 17 2021

Xover added a comment to T215558: Proofread Page extension on Wikisource is displaying wrong pages; purge on Commons file fails.

That said...the real problem is clearly that MediaWiki or Thumbor or Varnish is not able to purge all the thumbnails. If someone has an example from the past 7 days it might be possible to look through the logs to get an idea of where the failure is happening (or at least rule out some stuff).

Nov 17 2021, 6:59 PM · Multimedia, MediaWiki-DjVu, Commons, ProofreadPage, All-and-every-Wikisource