Because of this bug, Structured Discussion does not work in conjunction with PluggableAuth.

WSOAuth has now been updated to support PluggableAuth 6.0.

@LucasWerkmeister The last compatible commit is 520da2faa62349dcc3fd76c63df15f56ad15317d.

It seems that PluggableAuth was still automatically updated to master (6.0-dev), since logging in with WSOAuth is now failing.

@LucasWerkmeister Sorry for letting you wait, I don't check Phabricator that often. WSOAuth is not compatible with the latest version of PluggableAuth (6.0-dev), but it should be compatible with version 5.7. The error @valerio.bozzolan is referring to happens because 6.0-dev is installed on notwikilambda.toolforge.org.

This is unfortunately taking longer than expected. I am currently very busy with other duties at Wikibase Solutions, and the update is more complex than I initially thought. I hope to have it finished in February, though!

Thank you for your bug report. It should be fixed in the above commit. @Wargo can you take a look?

WSOAuth is currently not compatible with the latest version of PluggableAuth. I will update it as soon as possible and let you know through this task!

I would like for this to be merged soon, so other people can also benefit from these changes. @valerio.bozzolan do you know someone who might have time to review these changes in the near future?

One issue I still found with the current implementation is that the following scenario may occur:

I have implemented the requested changes above and created a patch set for them. @valerio.bozzolan could you take a look at it?

I would like to clarify that WSOAuth does not provide support for multiple external identity providers, nor does PluggableAuth. There is currently an open initiative to add this support to PluggableAuth.

I have deleted the defunct REL1_35 branch.

It looks like this task has mostly been resolved. The only issue that still remains is that the REL1_35 branch still seems to have the old version. How can this be fixed?

@Aklapper I have uploaded a new patchset that fixes the error generated by PHPUnit.

I was not asking for permission, but rather wanted to make sure it was an OK thing to do from a DevOps perspective.

@Aklapper Would it be possible to remove the current test suite? I looked at doing this before with a colleague, but we could not figure out how to lay a commit on top of an unmerged commit in Gerrit. After that, I forgot about it. I do not have time currently to rewrite the tests and using $this-setMwGlobals('wgOAuthUri', '...'); seems like a bodge to me.

What would be the best approach to move on from here? Writing proper tests would be great, but it is out of the scope of this task. The current code base needs to be rewritten to be testable and doing that now would make the move to Gerrit much more cumbersome.

To be honest, I think the current suite of unit tests is useless and they might as well be removed.

This is not an issue with Gerrit, but rather a mistake on my part. I requested a new Gerrit repository to be forked from the current repository a while back (see here), but I sort of forgot about it and continued to push updates to GitHub.