Fri, May 20
Because of this bug, Structured Discussion does not work in conjunction with PluggableAuth.
Fri, Apr 29
Apr 7 2022
Apr 2 2022
WSOAuth has now been updated to support PluggableAuth 6.0.
Feb 25 2022
Feb 24 2022
It seems that PluggableAuth was still automatically updated to master (6.0-dev), since logging in with WSOAuth is now failing.
@LucasWerkmeister Sorry for letting you wait, I don't check Phabricator that often. WSOAuth is not compatible with the latest version of PluggableAuth (6.0-dev), but it should be compatible with version 5.7. The error @valerio.bozzolan is referring to happens because 6.0-dev is installed on notwikilambda.toolforge.org.
Feb 14 2022
Feb 12 2022
This is unfortunately taking longer than expected. I am currently very busy with other duties at Wikibase Solutions, and the update is more complex than I initially thought. I hope to have it finished in February, though!
Feb 6 2022
Thank you for your bug report. It should be fixed in the above commit. @Wargo can you take a look?
Jan 26 2022
WSOAuth is currently not compatible with the latest version of PluggableAuth. I will update it as soon as possible and let you know through this task!
Dec 15 2021
Dec 14 2021
Oct 27 2021
I would like for this to be merged soon, so other people can also benefit from these changes. @valerio.bozzolan do you know someone who might have time to review these changes in the near future?
Jun 7 2021
One issue I still found with the current implementation is that the following scenario may occur:
Jun 6 2021
Jun 3 2021
Jun 2 2021
May 29 2021
I would like to clarify that WSOAuth does not provide support for multiple external identity providers, nor does PluggableAuth. There is currently an open initiative to add this support to PluggableAuth.
Jan 29 2021
I have deleted the defunct REL1_35 branch.
Jan 22 2021
It looks like this task has mostly been resolved. The only issue that still remains is that the REL1_35 branch still seems to have the old version. How can this be fixed?
Nov 20 2020
@Aklapper I have uploaded a new patchset that fixes the error generated by PHPUnit.
Nov 12 2020
I was not asking for permission, but rather wanted to make sure it was an OK thing to do from a DevOps perspective.
Nov 11 2020
@Aklapper Would it be possible to remove the current test suite? I looked at doing this before with a colleague, but we could not figure out how to lay a commit on top of an unmerged commit in Gerrit. After that, I forgot about it. I do not have time currently to rewrite the tests and using $this-setMwGlobals('wgOAuthUri', '...'); seems like a bodge to me.
Sep 29 2020
What would be the best approach to move on from here? Writing proper tests would be great, but it is out of the scope of this task. The current code base needs to be rewritten to be testable and doing that now would make the move to Gerrit much more cumbersome.
Sep 28 2020
To be honest, I think the current suite of unit tests is useless and they might as well be removed.
Sep 27 2020
This is not an issue with Gerrit, but rather a mistake on my part. I requested a new Gerrit repository to be forked from the current repository a while back (see here), but I sort of forgot about it and continued to push updates to GitHub.