Page MenuHomePhabricator

Xxmarijnw
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Sep 17 2016, 8:00 AM (296 w, 1 d)
Availability
Available
IRC Nick
Xxmarijnw
LDAP User
Unknown
MediaWiki User
Xxmarijnw [ Global Accounts ]

Recent Activity

Fri, May 20

Xxmarijnw added a comment to T308865: Calling 'userCanAuthenticate' results in a PHP error.

Because of this bug, Structured Discussion does not work in conjunction with PluggableAuth.

Fri, May 20, 2:47 PM · Patch-For-Review, MediaWiki-extensions-Pluggable-Auth
Xxmarijnw renamed T308865: Calling 'userCanAuthenticate' results in a PHP error from Calling `userCanAuthenticate` results in `PHP Error` to Calling 'userCanAuthenticate' results in a PHP error.
Fri, May 20, 2:45 PM · Patch-For-Review, MediaWiki-extensions-Pluggable-Auth
Xxmarijnw created T308865: Calling 'userCanAuthenticate' results in a PHP error.
Fri, May 20, 2:44 PM · Patch-For-Review, MediaWiki-extensions-Pluggable-Auth

Fri, Apr 29

Xxmarijnw created T307214: Special:RecentChanges and Special:Watchlist become extremely slow with large number of namespaces when enhanced filters are enabled.
Fri, Apr 29, 12:41 PM · Performance Issue, OOUI, MediaWiki-Watchlist, Growth-Team, Edit-Review-Improvements-Integrated-Filters, MediaWiki-Recent-changes

Apr 7 2022

Xxmarijnw created T305623: Links with anchors are not rendered when the anchor is the same as the text.
Apr 7 2022, 11:45 AM · MediaWiki-extensions-DisplayTitle

Apr 2 2022

Xxmarijnw added a comment to T299934: notwikilambda Toolforge service down.

WSOAuth has now been updated to support PluggableAuth 6.0.

Apr 2 2022, 11:36 AM · MediaWiki-extensions-Pluggable-Auth, MediaWiki-extensions-WSOAuth, Abstract Wikipedia team

Feb 25 2022

Xxmarijnw added a comment to T299934: notwikilambda Toolforge service down.

@LucasWerkmeister The last compatible commit is 520da2faa62349dcc3fd76c63df15f56ad15317d.

Feb 25 2022, 9:02 AM · MediaWiki-extensions-Pluggable-Auth, MediaWiki-extensions-WSOAuth, Abstract Wikipedia team

Feb 24 2022

Xxmarijnw added a comment to T299934: notwikilambda Toolforge service down.

It seems that PluggableAuth was still automatically updated to master (6.0-dev), since logging in with WSOAuth is now failing.

Feb 24 2022, 7:43 PM · MediaWiki-extensions-Pluggable-Auth, MediaWiki-extensions-WSOAuth, Abstract Wikipedia team
Xxmarijnw added a comment to T298351: Extension WSOAuth problems with account existence checking during registration.

@LucasWerkmeister Sorry for letting you wait, I don't check Phabricator that often. WSOAuth is not compatible with the latest version of PluggableAuth (6.0-dev), but it should be compatible with version 5.7. The error @valerio.bozzolan is referring to happens because 6.0-dev is installed on notwikilambda.toolforge.org.

Feb 24 2022, 7:41 PM · MediaWiki-extensions-WSOAuth

Feb 14 2022

valerio.bozzolan awarded T298351: Extension WSOAuth problems with account existence checking during registration a Pterodactyl token.
Feb 14 2022, 8:10 PM · MediaWiki-extensions-WSOAuth

Feb 12 2022

Xxmarijnw added a comment to T299934: notwikilambda Toolforge service down.

This is unfortunately taking longer than expected. I am currently very busy with other duties at Wikibase Solutions, and the update is more complex than I initially thought. I hope to have it finished in February, though!

Feb 12 2022, 8:01 PM · MediaWiki-extensions-Pluggable-Auth, MediaWiki-extensions-WSOAuth, Abstract Wikipedia team
Xxmarijnw closed T298351: Extension WSOAuth problems with account existence checking during registration as Resolved.
Feb 12 2022, 7:59 PM · MediaWiki-extensions-WSOAuth

Feb 6 2022

Xxmarijnw added a comment to T298351: Extension WSOAuth problems with account existence checking during registration.

Thank you for your bug report. It should be fixed in the above commit. @Wargo can you take a look?

Feb 6 2022, 6:53 PM · MediaWiki-extensions-WSOAuth

Jan 26 2022

Xxmarijnw claimed T299934: notwikilambda Toolforge service down.

WSOAuth is currently not compatible with the latest version of PluggableAuth. I will update it as soon as possible and let you know through this task!

Jan 26 2022, 3:24 PM · MediaWiki-extensions-Pluggable-Auth, MediaWiki-extensions-WSOAuth, Abstract Wikipedia team

Dec 15 2021

valerio.bozzolan awarded T283908: Implement a modern auto-verification for the WSOAuth extension a Mountain of Wealth token.
Dec 15 2021, 10:00 AM · MediaWiki-extensions-WSOAuth, WMCH-Infrastructure

Dec 14 2021

Xxmarijnw closed T283908: Implement a modern auto-verification for the WSOAuth extension as Resolved.
Dec 14 2021, 7:26 PM · MediaWiki-extensions-WSOAuth, WMCH-Infrastructure
Xxmarijnw closed T283908: Implement a modern auto-verification for the WSOAuth extension, a subtask of T278135: Implement OAuth login for WMCH's members wiki, as Resolved.
Dec 14 2021, 7:26 PM · WMCH-Infrastructure

Oct 27 2021

Xxmarijnw added a comment to T283908: Implement a modern auto-verification for the WSOAuth extension.

I would like for this to be merged soon, so other people can also benefit from these changes. @valerio.bozzolan do you know someone who might have time to review these changes in the near future?

Oct 27 2021, 12:16 PM · MediaWiki-extensions-WSOAuth, WMCH-Infrastructure

Jun 7 2021

Xxmarijnw updated subscribers of T283908: Implement a modern auto-verification for the WSOAuth extension.

One issue I still found with the current implementation is that the following scenario may occur:

Jun 7 2021, 12:22 PM · MediaWiki-extensions-WSOAuth, WMCH-Infrastructure

Jun 6 2021

Xxmarijnw updated Xxmarijnw.
Jun 6 2021, 2:48 PM

Jun 3 2021

Xxmarijnw edited projects for T281888: extensions/WSOAuth - Use UserGroupManager instead of User group methods, added: MediaWiki-extensions-WSOAuth; removed MediaWiki-extensions-Other.
Jun 3 2021, 1:28 PM · Platform Team Workboards (MW Expedition), MediaWiki-extensions-WSOAuth, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-notes (1.36.0-wmf.37; 2021-03-30)

Jun 2 2021

Xxmarijnw moved T283908: Implement a modern auto-verification for the WSOAuth extension from In Progress to Waiting for Merge on the MediaWiki-extensions-WSOAuth board.
Jun 2 2021, 2:42 PM · MediaWiki-extensions-WSOAuth, WMCH-Infrastructure
Xxmarijnw moved T283908: Implement a modern auto-verification for the WSOAuth extension from Backlog to In Progress on the MediaWiki-extensions-WSOAuth board.
Jun 2 2021, 2:42 PM · MediaWiki-extensions-WSOAuth, WMCH-Infrastructure
Xxmarijnw added a comment to T283908: Implement a modern auto-verification for the WSOAuth extension.

I have implemented the requested changes above and created a patch set for them. @valerio.bozzolan could you take a look at it?

Jun 2 2021, 2:35 PM · MediaWiki-extensions-WSOAuth, WMCH-Infrastructure
Xxmarijnw claimed T283908: Implement a modern auto-verification for the WSOAuth extension.
Jun 2 2021, 9:02 AM · MediaWiki-extensions-WSOAuth, WMCH-Infrastructure

May 29 2021

Xxmarijnw added a comment to T283908: Implement a modern auto-verification for the WSOAuth extension.

I would like to clarify that WSOAuth does not provide support for multiple external identity providers, nor does PluggableAuth. There is currently an open initiative to add this support to PluggableAuth.

May 29 2021, 5:06 PM · MediaWiki-extensions-WSOAuth, WMCH-Infrastructure

Jan 29 2021

Xxmarijnw closed T263955: mediawiki/extensions/WSOAuth Github and Gerrit repo have diverged as Resolved.

I have deleted the defunct REL1_35 branch.

Jan 29 2021, 3:57 PM · Gerrit, Wikimedia-GitHub

Jan 22 2021

Xxmarijnw added a comment to T263955: mediawiki/extensions/WSOAuth Github and Gerrit repo have diverged.

It looks like this task has mostly been resolved. The only issue that still remains is that the REL1_35 branch still seems to have the old version. How can this be fixed?

Jan 22 2021, 3:35 PM · Gerrit, Wikimedia-GitHub

Nov 20 2020

Xxmarijnw added a comment to T263955: mediawiki/extensions/WSOAuth Github and Gerrit repo have diverged.

@Aklapper I have uploaded a new patchset that fixes the error generated by PHPUnit.

Nov 20 2020, 8:23 PM · Gerrit, Wikimedia-GitHub

Nov 12 2020

Xxmarijnw added a comment to T263955: mediawiki/extensions/WSOAuth Github and Gerrit repo have diverged.

I was not asking for permission, but rather wanted to make sure it was an OK thing to do from a DevOps perspective.

Nov 12 2020, 2:26 PM · Gerrit, Wikimedia-GitHub

Nov 11 2020

Xxmarijnw added a comment to T263955: mediawiki/extensions/WSOAuth Github and Gerrit repo have diverged.

@Aklapper Would it be possible to remove the current test suite? I looked at doing this before with a colleague, but we could not figure out how to lay a commit on top of an unmerged commit in Gerrit. After that, I forgot about it. I do not have time currently to rewrite the tests and using $this-setMwGlobals('wgOAuthUri', '...'); seems like a bodge to me.

Nov 11 2020, 2:46 PM · Gerrit, Wikimedia-GitHub

Sep 29 2020

Xxmarijnw added a comment to T263955: mediawiki/extensions/WSOAuth Github and Gerrit repo have diverged.

What would be the best approach to move on from here? Writing proper tests would be great, but it is out of the scope of this task. The current code base needs to be rewritten to be testable and doing that now would make the move to Gerrit much more cumbersome.

Sep 29 2020, 4:35 PM · Gerrit, Wikimedia-GitHub

Sep 28 2020

Xxmarijnw added a comment to T263955: mediawiki/extensions/WSOAuth Github and Gerrit repo have diverged.

To be honest, I think the current suite of unit tests is useless and they might as well be removed.

Sep 28 2020, 2:12 PM · Gerrit, Wikimedia-GitHub
Xxmarijnw committed rEWAU00d066bb464c: Allow consumer to specify callback URI for applications that have prefixed… (authored by Xxmarijnw).
Allow consumer to specify callback URI for applications that have prefixed…
Sep 28 2020, 8:10 AM

Sep 27 2020

Xxmarijnw updated Xxmarijnw.
Sep 27 2020, 8:51 PM
Xxmarijnw updated Xxmarijnw.
Sep 27 2020, 8:50 PM
Xxmarijnw added a comment to T263955: mediawiki/extensions/WSOAuth Github and Gerrit repo have diverged.

This is not an issue with Gerrit, but rather a mistake on my part. I requested a new Gerrit repository to be forked from the current repository a while back (see here), but I sort of forgot about it and continued to push updates to GitHub.

Sep 27 2020, 7:55 PM · Gerrit, Wikimedia-GitHub

Jul 3 2020

Xxmarijnw committed rEWAUf67196c2f360: Fix issue where realname is used instead of email address (authored by Xxmarijnw).
Fix issue where realname is used instead of email address
Jul 3 2020, 2:04 PM
Xxmarijnw committed rEWAUa1545dd6c2d3: Return true instead of implicitly returning null (authored by Xxmarijnw).
Return true instead of implicitly returning null
Jul 3 2020, 2:04 PM
Xxmarijnw committed rEWAUa804304689ad: Gracefully exit and show error instead of throwing exception (authored by Xxmarijnw).
Gracefully exit and show error instead of throwing exception
Jul 3 2020, 2:04 PM
Xxmarijnw committed rEWAUe7a9cd6121f3: Add Facebook login (authored by Xxmarijnw).
Add Facebook login
Jul 3 2020, 2:04 PM
Xxmarijnw committed rEWAU0cf7e7d58def: Improve error handling (authored by Xxmarijnw).
Improve error handling
Jul 3 2020, 2:04 PM

Sep 25 2016

Xxmarijnw removed a watcher for MediaWiki-extensions-TwoFactorAuthentication: Xxmarijnw.
Sep 25 2016, 10:48 AM
Xxmarijnw added a watcher for MediaWiki-extensions-TwoFactorAuthentication: Xxmarijnw.
Sep 25 2016, 10:45 AM