Page MenuHomePhabricator

YOUR1 (Yvdb)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2016, 9:42 AM (420 w, 1 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
YOUR1 [ Global Accounts ]

Recent Activity

Jan 3 2024

YOUR1 added a comment to T329928: Wrong value displayed using token input type and display titles.

Is there any way you could re-submit your fixes? Presumably the patch required would be smaller than before, given that some parts of it, like the getLabelsFromDisplayTitle() function, have already been added to the code.

Holidays are now over, so I'll try submit a new patch within two weeks.

Jan 3 2024, 8:13 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Dec 22 2023

YOUR1 added a comment to T329928: Wrong value displayed using token input type and display titles.

The original bug is reintroduced, and it seems my fixes are not working in any way I fixed them before. Thus to sum it up (its all about the tokens field):

  • It should do remote autocompletion whenever the possible values exceeds the maximum allowed value;
  • It should display values like "DisplayTitle (real page title)" - it just displays the real page title now. This was partly done in the 'ext.pf.select2.tokens.js' file
    • And the 'reverse lookup' mechanism, where the actual post values would be translated to just save the 'real page titles'.
Dec 22 2023, 7:42 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Dec 21 2023

YOUR1 added a comment to T329928: Wrong value displayed using token input type and display titles.

The patch was functioning correctly in previous versions, but with the recent update to PageForms, it appears that similar code has been partially integrated. However, this integration seems incomplete, as certain components are missing. Consequently, the solution I originally implemented is no longer effective.

Dec 21 2023, 7:44 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Dec 6 2023

YOUR1 added a comment to T351489: Tokens ignoring order.

Thanks, you've pointed me to https://github.com/wikimedia/mediawiki-extensions-PageForms/commit/77bbf48769c37a13ef217e7a4bb32b268fccd4bc. This issue can be closed!

Dec 6 2023, 3:28 PM · MediaWiki-extensions-Page_Forms
YOUR1 added a comment to T351489: Tokens ignoring order.

We've tried that and the same problem exists, but that was expected - since nothing has been changed regarding ordering and tokens field between those versions.

Dec 6 2023, 7:46 AM · MediaWiki-extensions-Page_Forms

Dec 1 2023

YOUR1 added a comment to T351489: Tokens ignoring order.

So, I made the same test case on discoursedb.org as I did on the SMW sandbox. You can check it on: https://discoursedb.org/wiki/Special:FormEdit/Test_order/Test_order. The order issue did not occur that; thus I think its SMW related.

Dec 1 2023, 7:28 AM · MediaWiki-extensions-Page_Forms

Nov 30 2023

YOUR1 added a comment to T351489: Tokens ignoring order.

Okay, that's good to know. Yes, since you offered - could you replicate this problem on https://discoursedb.org?

Nov 30 2023, 6:20 AM · MediaWiki-extensions-Page_Forms

Nov 29 2023

YOUR1 reopened T351489: Tokens ignoring order as "Open".
Nov 29 2023, 7:00 AM · MediaWiki-extensions-Page_Forms
YOUR1 added a comment to T351489: Tokens ignoring order.

It's not a problem of old code. We're running 5.6 (and up) and the same problem occurs there. Do you have a sandbox wiki where I can demonstrate it? I'm pretty sure it's in every version of PF.

Nov 29 2023, 7:00 AM · MediaWiki-extensions-Page_Forms

Nov 17 2023

YOUR1 created T351489: Tokens ignoring order.
Nov 17 2023, 7:43 AM · MediaWiki-extensions-Page_Forms

Oct 27 2023

YOUR1 added a comment to T132128: Mapping fails with remote autocompletion.

I fixed this before; the merge request was not merged; but the current version of PF somewhat includes my code, but not all... What's happened?

Oct 27 2023, 1:01 PM · MediaWiki-extensions-Page_Forms

Oct 18 2023

YOUR1 reopened T243730: DBQueryError on Wikitech Static Search as "Open".

I know this is a rather old issue; but we've encountered the same issue.

Oct 18 2023, 8:34 AM · Wikimedia-production-error, cloud-services-team (Kanban), CirrusSearch, Discovery-Search, wikitech.wikimedia.org

Mar 2 2023

YOUR1 placed T329928: Wrong value displayed using token input type and display titles up for grabs.
Mar 2 2023, 9:53 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Mar 1 2023

YOUR1 added a comment to T329928: Wrong value displayed using token input type and display titles.

So, after extensively testing with this fix I don't have this issue anymore on my branch. We did encounter a other issue, which is similar to T283161 and T132128.

Our scenario is that we have one category that has a lot of pages in it (around 10.000). Each page in that category has its own display title. Whenever we edit that for, the 'possible' values are limited to whatever $wgPageFormsMaxAutocompleteValues is set to. This is problematic, because whenever we search (through the autocomplete) on a value that's further away then the 1000 prefilled values in the form, it doesn't get resolved correctly.

I've already written a fix for this, but its written on the same change (https://gerrit.wikimedia.org/r/890002) above. Do you want me to submit another patch, or fix this issue in the same change?

Mar 1 2023, 12:34 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Feb 24 2023

YOUR1 added a comment to T329928: Wrong value displayed using token input type and display titles.

So, after extensively testing with this fix I don't have this issue anymore on my branch. We did encounter a other issue, which is similar to T283161 and T132128.

Feb 24 2023, 1:28 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Feb 17 2023

YOUR1 updated subscribers of T329928: Wrong value displayed using token input type and display titles.
Feb 17 2023, 9:51 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms
YOUR1 claimed T329928: Wrong value displayed using token input type and display titles.

I will have a patch ready today.

Feb 17 2023, 9:45 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms
YOUR1 created T329928: Wrong value displayed using token input type and display titles.
Feb 17 2023, 9:44 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Feb 1 2022

YOUR1 added a comment to T203061: Mediawiki 1.31 break symlinked, cause LocalSettings.php failed to load..

To bad nobody did anything with the patches I wrote above.. This seems like a useful solution..

Feb 1 2022, 7:28 AM · Platform Engineering (Icebox), MediaWiki-Debian, MediaWiki-General

Oct 29 2020

YOUR1 added a comment to T262040: Displaytitle not honored with remote autocompletion.

I think you set $wgPageFormsMaxAutocompleteValues to 25 or something to reproduce it.

Oct 29 2020, 4:21 PM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms
YOUR1 added a comment to T262040: Displaytitle not honored with remote autocompletion.

I tested it with pageforms 4.9.5; field definition:

Oct 29 2020, 3:43 PM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms
YOUR1 added a comment to T262040: Displaytitle not honored with remote autocompletion.

This change doesn't work as expected. You introduce a new bug by changing item.id = item.displaytitle, while it 'looks' okay; it's really not, because once you save the form, the selected value will be the displaytitle, and not the pagetitle (id) of the page.

Oct 29 2020, 11:18 AM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms
YOUR1 added a comment to T262040: Displaytitle not honored with remote autocompletion.
Oct 29 2020, 7:03 AM · Patch-Needs-Improvement, MediaWiki-extensions-Page_Forms
YOUR1 triaged T195281: Instant "edit with form" tab on saving #default_form: as High priority.
Oct 29 2020, 7:00 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Oct 18 2019

YOUR1 added a comment to T203061: Mediawiki 1.31 break symlinked, cause LocalSettings.php failed to load..

I've written some patches for 1.31 which enables you to use symlinks, but we're also using the same strategy for 1.27 and so on.

Oct 18 2019, 7:44 AM · Platform Engineering (Icebox), MediaWiki-Debian, MediaWiki-General

Oct 17 2019

YOUR1 added a comment to T203061: Mediawiki 1.31 break symlinked, cause LocalSettings.php failed to load..
Oct 17 2019, 3:08 PM · Platform Engineering (Icebox), MediaWiki-Debian, MediaWiki-General

Aug 30 2019

YOUR1 added a comment to T231297: Git branches not up to date.

This extension is tagged meaning that it does not follow WMF branches. You need to do a git checkout 1.3.0 instead following the branch. Leaving this to Yaron to confirm.

Aug 30 2019, 11:01 AM · MediaWiki-extensions-Widgets

Aug 27 2019

YOUR1 created T231297: Git branches not up to date.
Aug 27 2019, 11:54 AM · MediaWiki-extensions-Widgets

Aug 13 2019

YOUR1 added a comment to T227801: ApprovedRevs: indexing current state .

@Rcdeboer - what's the status of the patch? Are you still working on it?

Aug 13 2019, 6:21 AM · MediaWiki-extensions-Approved-Revs

Aug 7 2019

YOUR1 added a comment to T227801: ApprovedRevs: indexing current state .

There are still issues with the patch, which we couldn't solve:

Aug 7 2019, 1:54 PM · MediaWiki-extensions-Approved-Revs
YOUR1 added a comment to T227801: ApprovedRevs: indexing current state .

@Yaron_Koren are you planning to update ApprovedRevs? As of now its kinda broken..

Aug 7 2019, 1:43 PM · MediaWiki-extensions-Approved-Revs

Jul 12 2019

YOUR1 awarded T227801: ApprovedRevs: indexing current state a Burninate token.
Jul 12 2019, 1:51 PM · MediaWiki-extensions-Approved-Revs
YOUR1 updated the task description for T227801: ApprovedRevs: indexing current state .
Jul 12 2019, 11:13 AM · MediaWiki-extensions-Approved-Revs
YOUR1 renamed T227801: ApprovedRevs: indexing current state from Broken when using SMW to ApprovedRevs: indexing current state .
Jul 12 2019, 9:47 AM · MediaWiki-extensions-Approved-Revs
YOUR1 updated the task description for T227801: ApprovedRevs: indexing current state .
Jul 12 2019, 6:38 AM · MediaWiki-extensions-Approved-Revs
YOUR1 updated the task description for T227801: ApprovedRevs: indexing current state .
Jul 12 2019, 6:36 AM · MediaWiki-extensions-Approved-Revs

Jul 11 2019

YOUR1 created T227801: ApprovedRevs: indexing current state .
Jul 11 2019, 4:44 PM · MediaWiki-extensions-Approved-Revs

Mar 21 2019

Mill <mill@mail.com> committed rEPFM916f75496b33: %5ewaaaaaaaaaaaa (authored by YOUR1).
%5ewaaaaaaaaaaaa
Mar 21 2019, 12:24 AM
Mill <mill@mail.com> committed rEPFMee76c90b1192: 6hbaaaaaaaaaaa (authored by YOUR1).
6hbaaaaaaaaaaa
Mar 21 2019, 12:24 AM
Mill <mill@mail.com> committed rEGAU5bee0a1b3d45: libaaaaaaaaaaa (authored by YOUR1).
libaaaaaaaaaaa
Mar 21 2019, 12:21 AM

Feb 25 2019

YOUR1 committed rEPFM3e6d096e7289: Workaround for https://phabricator.wikimedia.org/T216805. (authored by YOUR1).
Workaround for https://phabricator.wikimedia.org/T216805.
Feb 25 2019, 4:11 PM

Feb 22 2019

YOUR1 added a comment to T216805: [PageForms] Loading form input JS libraries (like datepicker) fix doesn't work.

Btw; https://github.com/wikimedia/mediawiki-extensions-PageForms/blob/master/libs/PageForms.js#L340 the function is not always a function, sometimes a string

Feb 22 2019, 9:42 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms
YOUR1 updated the task description for T216805: [PageForms] Loading form input JS libraries (like datepicker) fix doesn't work.
Feb 22 2019, 9:28 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms
YOUR1 updated the task description for T216805: [PageForms] Loading form input JS libraries (like datepicker) fix doesn't work.
Feb 22 2019, 9:28 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms
YOUR1 created T216805: [PageForms] Loading form input JS libraries (like datepicker) fix doesn't work.
Feb 22 2019, 9:27 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Sep 13 2018

YOUR1 committed rEGAU915d9717a538: Added email rescue (authored by YOUR1).
Added email rescue
Sep 13 2018, 3:50 PM
YOUR1 committed rEGAU9d2151b35929: Changed verification process (stops generating new codes every time during the… (authored by YOUR1).
Changed verification process (stops generating new codes every time during the…
Sep 13 2018, 3:50 PM
YOUR1 committed rEGAU678c91e44322: Set correct code length (authored by YOUR1).
Set correct code length
Sep 13 2018, 3:50 PM
YOUR1 committed rEGAU9f0461fb919f: Incorrect version number (authored by YOUR1).
Incorrect version number
Sep 13 2018, 3:50 PM
YOUR1 committed rEGAUe3f09c132543: Changed date (authored by YOUR1).
Changed date
Sep 13 2018, 3:50 PM
YOUR1 committed rEGAUfe7d6f0c48a9: Updated readme (authored by YOUR1).
Updated readme
Sep 13 2018, 3:50 PM
YOUR1 committed rEGAUb5e0064f1227: Added GA class (authored by YOUR1).
Added GA class
Sep 13 2018, 3:50 PM
YOUR1 committed rEGAU03400b568bcb: Removed external library. (authored by YOUR1).
Removed external library.
Sep 13 2018, 3:50 PM
YOUR1 committed rEGAUbc315b7f9431: Typo fix (authored by YOUR1).
Typo fix
Sep 13 2018, 3:50 PM
YOUR1 committed rEGAU8280490852aa: Added README (authored by YOUR1).
Added README
Sep 13 2018, 3:50 PM
YOUR1 committed rEGAUacf142515af6: Removed some files (authored by YOUR1).
Removed some files
Sep 13 2018, 3:50 PM
YOUR1 committed rEGAUd2cd5dd65e2c: Initial commit (authored by YOUR1).
Initial commit
Sep 13 2018, 3:50 PM
YOUR1 committed rEGAU6b883cae631b: Slighty changed readme (authored by YOUR1).
Slighty changed readme
Sep 13 2018, 10:56 AM
YOUR1 committed rEGAU36108d943ffb: Initial commit (imported from Github: https://github.com/YOUR1/mediawiki… (authored by YOUR1).
Initial commit (imported from Github: https://github.com/YOUR1/mediawiki…
Sep 13 2018, 10:53 AM

Jul 2 2018

YOUR1 committed rEPFMa182d72fec0d: Whitespace fixes (authored by YOUR1).
Whitespace fixes
Jul 2 2018, 10:36 AM

Jun 19 2018

YOUR1 committed rEPFM320e0096a797: Fix for Thttps://phabricator.wikimedia.org/T195281 (authored by YOUR1).
Fix for Thttps://phabricator.wikimedia.org/T195281
Jun 19 2018, 11:54 AM
YOUR1 closed T195281: Instant "edit with form" tab on saving #default_form: as Resolved.

Fix available on: https://github.com/wikimedia/mediawiki-extensions-PageForms/pull/3

Jun 19 2018, 11:37 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms
YOUR1 added a comment to T195281: Instant "edit with form" tab on saving #default_form:.

I've fixed the problem. I will push it upstream.

Jun 19 2018, 11:25 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Jun 18 2018

YOUR1 added a comment to T195281: Instant "edit with form" tab on saving #default_form:.

Alright. Well, I'm tempted to mark this as "Declined", since I don't know if there's anything that can be done about this problem within the Page Forms code, unless anyone has any ideas...

Jun 18 2018, 2:08 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Feb 10 2016

YOUR1 added a comment to T58269: Uncommitted DB writes (transaction from DatabaseBase::query (Block::newLoad)).

Can anyone verify whether disabling these lines in OutpuPage.php solves the issue for them too? Does anyone understand how these particular lines could trigger Uncommitted DB writes?

Feb 10 2016, 9:45 AM · affects-translatewiki.net, Wikimedia-production-error, MediaWiki-libs-Rdbms