Page MenuHomePhabricator

Yaron_Koren (Yaron Koren)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Nov 14 2014, 3:01 AM (275 w, 6 d)
Availability
Available
LDAP User
Yaron Koren
MediaWiki User
Unknown

Recent Activity

Yesterday

Yaron_Koren committed rEPFM8b879fbbf18e: Switch away from Title::getUserPermissionsErrors for MW 1.33+ (authored by DannyS712).
Switch away from Title::getUserPermissionsErrors for MW 1.33+
Wed, Feb 26, 8:10 PM
Yaron_Koren added a comment to T246199: WikiEditor not show up in PageForms Section Textarea.

What version of Page Forms are you running? I assume it's not 0.5.2.

Wed, Feb 26, 2:22 PM · MediaWiki-extensions-Page_Forms, WikiEditor
Yaron_Koren added a comment to T246188: Page Forms undefined error when using #formlink.

Do you mean, when saving a page that happens to contain a call to #formlink?

Wed, Feb 26, 4:40 AM · MediaWiki-extensions-Page_Forms

Tue, Feb 25

Yaron_Koren closed T245034: Please change extension name in the manifest to match the actual folder name as Resolved.

Patch was merged in a while ago.

Tue, Feb 25, 7:17 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren closed T246082: Use of Title::userCan was deprecated in MediaWiki 1.33. [Called from PFHelperFormAction::displayTab as Resolved.
Tue, Feb 25, 7:08 PM · User-DannyS712, MediaWiki-extensions-Page_Forms
Yaron_Koren closed T246082: Use of Title::userCan was deprecated in MediaWiki 1.33. [Called from PFHelperFormAction::displayTab, a subtask of T246139: Remove remaining Title::userCan calls, as Resolved.
Tue, Feb 25, 7:08 PM · Technical-Debt, User-DannyS712, MediaWiki-General
Yaron_Koren added a comment to T246082: Use of Title::userCan was deprecated in MediaWiki 1.33. [Called from PFHelperFormAction::displayTab.

Sorry about that. I fixed this, and the other calls to useCan and isAllowed(), in 47c680f124e8.

Tue, Feb 25, 7:08 PM · User-DannyS712, MediaWiki-extensions-Page_Forms
Yaron_Koren committed rEPFM47c680f124e8: Replace userCan() and isAllowed() for MW 1.33+ (authored by Yaron_Koren).
Replace userCan() and isAllowed() for MW 1.33+
Tue, Feb 25, 6:21 PM
Yaron_Koren renamed T246088: Fix for handling of sections with special characters in their name such as "(", ")", "+" from Find Issues when section title has special characters such as "(", ")", "+" to Fix for handling of sections with special characters in their name such as "(", ")", "+".
Tue, Feb 25, 2:19 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Mon, Feb 24

Yaron_Koren added a comment to T241565: Replace $wgParser in SemanticDrilldown.

Thank you, @TheSandDoctor !

Mon, Feb 24, 8:25 PM · MediaWiki-extensions-SemanticDrilldown, User-TheSandDoctor
Yaron_Koren committed rEPFM1697639ab811: Fix PFMultiPageEdit::getQueryInfo() (authored by Yaron_Koren).
Fix PFMultiPageEdit::getQueryInfo()
Mon, Feb 24, 8:12 PM
Yaron_Koren committed rEPFMc9b650ac96e9: Fix for 6dab00f5bc17 for addToCargoTablesLinks() (authored by Yaron_Koren).
Fix for 6dab00f5bc17 for addToCargoTablesLinks()
Mon, Feb 24, 2:29 PM
Yaron_Koren added a comment to T72704: Autoedit no longer refreshes pages with MW 1.23.3.

@Nocodes - yes, definitely!

Mon, Feb 24, 3:45 AM · MediaWiki-extensions-Page_Forms

Fri, Feb 21

Yaron_Koren added a comment to T242973: Special:CargoQuery autocompletion appearance should be standardized.

That's good to know! Well, this needs to be fixed within the Cargo code. So either the class should be removed, or, if that's not possible, there should be local CSS added within Cargo to override the CSS being set for that class.

Fri, Feb 21, 4:48 PM · Patch-For-Review, MediaWiki-extensions-Cargo

Thu, Feb 20

Yaron_Koren committed rEPFMd4cb0ce2517c: Fix for 5ce64ef5270b - get uploads working again (authored by Yaron_Koren).
Fix for 5ce64ef5270b - get uploads working again
Thu, Feb 20, 3:07 AM

Wed, Feb 19

Yaron_Koren added a comment to T242973: Special:CargoQuery autocompletion appearance should be standardized.

Ooh, sorry about that! You found a bug that got into the code a few weeks ago. I checked in a fix for it earlier today. If you get the latest code, this will hopefully work.

Wed, Feb 19, 6:29 PM · Patch-For-Review, MediaWiki-extensions-Cargo
Yaron_Koren committed rEPFMbad4849e0c01: Reorder rules in .phpcs.xml per alphabet (authored by Zoranzoki21).
Reorder rules in .phpcs.xml per alphabet
Wed, Feb 19, 4:10 PM
Yaron_Koren added a comment to T245457: allow for comments in headers for CSV files.

Do all of your CSV files have thousands of rows? If so, it sounds like you have a bigger problem than comments in the files.

Wed, Feb 19, 3:33 PM · MediaWiki-extensions-ExternalData
Yaron_Koren committed rEPFM6dab00f5bc17: Change Special:MultiPageEdit to use one class (authored by Yaron_Koren).
Change Special:MultiPageEdit to use one class
Wed, Feb 19, 3:27 PM
Yaron_Koren committed rEPFMd05437a45189: Change Special:Forms and Special:Templates to use one class each (authored by Yaron_Koren).
Change Special:Forms and Special:Templates to use one class each
Wed, Feb 19, 2:56 AM
Yaron_Koren committed rEPFM868ec458db95: Bump mediawiki/mediawiki-codesniffer from 19.2.0 to 29.0.0 (authored by Zoranzoki21).
Bump mediawiki/mediawiki-codesniffer from 19.2.0 to 29.0.0
Wed, Feb 19, 1:19 AM

Tue, Feb 18

Yaron_Koren updated the task description for T184251: Upgrade Select2 in Page Forms (was formerly: Upgrade JS libraries included in Page Forms).
Tue, Feb 18, 9:58 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T245457: allow for comments in headers for CSV files.

Okay, I get it. I don't know what the best approach is here - it would be easy to have the code just ignore lines that start with a "#", but on the other hand, commented lines like this are not part of the standard CSV specification, and there's always the small chance that a row is actually supposed to start with a "#".

Tue, Feb 18, 2:51 PM · MediaWiki-extensions-ExternalData
Yaron_Koren added a comment to T184251: Upgrade Select2 in Page Forms (was formerly: Upgrade JS libraries included in Page Forms).

Not any immediate plans, but I do still want to get this done, yes.

Tue, Feb 18, 2:33 PM · MediaWiki-extensions-Page_Forms

Mon, Feb 17

Yaron_Koren added a comment to T245457: allow for comments in headers for CSV files.

@ahmad - how do you include comments in a CSV file?

Mon, Feb 17, 9:43 PM · MediaWiki-extensions-ExternalData
Yaron_Koren added a comment to T69409: Prevent double save on double click on "Save page" button.

Hi @Swayamsrk - thank you for your interest. This itself might be a microtask... the amount of code required to fix it might be very short - maybe just one or two lines of JavaScript.

Mon, Feb 17, 12:15 AM · MediaWiki-extensions-Page_Forms

Thu, Feb 13

Yaron_Koren added a comment to T217517: Page Forms: Checkboxes should be farther apart.

Great! Now you need to create a form that includes an input with type "checkboxes". Look at the Page Forms documentation for how to do that:

Thu, Feb 13, 3:30 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Wed, Feb 12

Yaron_Koren added a comment to T217517: Page Forms: Checkboxes should be farther apart.

@Rexsteroxy - you need to set up MediaWiki and install Page Forms on it, if I understand the question correctly...

Wed, Feb 12, 4:28 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T241632: Remove use of jQuery UI from Page Forms.

@Sahajsk - people are only actively looking into T242973 and T217517, I think, so you can definitely take one of the other two. Or even one of these two, at this point.

Wed, Feb 12, 4:27 PM · Google-Summer-of-Code (2020), MediaWiki-extensions-Page_Forms
Yaron_Koren committed rEPFM206e2fa10174: Drop backwards-compatibility with MW 1.28; raise to 1.29 (authored by Ammarpad).
Drop backwards-compatibility with MW 1.28; raise to 1.29
Wed, Feb 12, 1:10 AM

Mon, Feb 10

Yaron_Koren added a comment to T241632: Remove use of jQuery UI from Page Forms.

@Rexsteroxy - great! Please pick a microtask and try to do it. Let me know if you have any questions.

Mon, Feb 10, 3:48 PM · Google-Summer-of-Code (2020), MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T217516: Page Forms: Checkboxes labels in multiple-instance templates are not clickable.

There's a lot of documentation here: https://www.mediawiki.org/wiki/Extension:Page_Forms

Mon, Feb 10, 2:55 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T217516: Page Forms: Checkboxes labels in multiple-instance templates are not clickable.

The type specified might need to "String".

Mon, Feb 10, 5:39 AM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T217516: Page Forms: Checkboxes labels in multiple-instance templates are not clickable.

Right, those are Cargo field types, which are different from Page Forms input types. You can't directly specify an input type in Special:CreateClass, unfortunately. But actually, if in Special:CreateClass you click on the "List of values?" checkbox and add a set of values to the "Allowed values" input for any one field, I think checkboxes will show up for that field in the resulting form.

Mon, Feb 10, 4:48 AM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T241632: Remove use of jQuery UI from Page Forms.

No problem, I should have said that beforehand.

Mon, Feb 10, 3:46 AM · Google-Summer-of-Code (2020), MediaWiki-extensions-Page_Forms

Sun, Feb 9

Yaron_Koren added a comment to T241632: Remove use of jQuery UI from Page Forms.

@Prondubuisi - are you trying to become a Google Summer of Code student? In either case, please just pick one microtask and stick to that, instead of trying to do all of them.

Sun, Feb 9, 10:20 PM · Google-Summer-of-Code (2020), MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T217516: Page Forms: Checkboxes labels in multiple-instance templates are not clickable.

Yes, this is still an issue. You need to specify "input type=checkboxes" for at least one field in the form.

Sun, Feb 9, 10:17 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T242973: Special:CargoQuery autocompletion appearance should be standardized.

You need to create at least one Cargo table in order to see the autocompletion in effect.

Sun, Feb 9, 10:16 PM · Patch-For-Review, MediaWiki-extensions-Cargo
Yaron_Koren added a comment to T217517: Page Forms: Checkboxes should be farther apart.

Yes, this is still an issue. This refers to checkboxes in user-defined forms, defined with "input type=checkboxes".

Sun, Feb 9, 3:34 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Wed, Feb 5

Yaron_Koren committed rEPFMb8b4598006ed: Version 4.7 (authored by Yaron_Koren).
Version 4.7
Wed, Feb 5, 3:35 PM

Tue, Feb 4

Yaron_Koren added a comment to T241632: Remove use of jQuery UI from Page Forms.

Great! You can start by going to Special:CreateClass and filling in the form. Although it might be helpful to install the Cargo extension first, so you can see the full working of the overall system. As to beginner-friendly issues: check out the list of microtasks above.

Tue, Feb 4, 3:41 AM · Google-Summer-of-Code (2020), MediaWiki-extensions-Page_Forms

Sun, Feb 2

Yaron_Koren committed rETMCdb4e7a41b58f: Dragging and dropping images and macro inserts resulted in invalid html being… (authored by aoxomoxoa).
Dragging and dropping images and macro inserts resulted in invalid html being…
Sun, Feb 2, 3:14 AM

Thu, Jan 30

Yaron_Koren added a comment to T243939: List of Integer and List of Boolean only storing one value.

I don't think a field holding a list of Boolean values makes sense; maybe Cargo should simply prohibit users from declaring this.

Thu, Jan 30, 5:06 AM · MediaWiki-extensions-Cargo

Jan 27 2020

Yaron_Koren committed rEPFMe0486eed62af: Update a few pieces of documentation (authored by thiemowmde).
Update a few pieces of documentation
Jan 27 2020, 4:57 AM
Yaron_Koren added a comment to T241632: Remove use of jQuery UI from Page Forms.

@BamLifa - okay, thanks for offering to help You should know that I'd prefer to have a co-mentor who has significant MediaWiki development experience - and ideally, someone with Page Forms development experience. But I'll let you know.

Jan 27 2020, 4:48 AM · Google-Summer-of-Code (2020), MediaWiki-extensions-Page_Forms
Yaron_Koren committed rEPFMf9f6ae8354aa: Fix "post edit cookie" (authored by JeroenDeDauw).
Fix "post edit cookie"
Jan 27 2020, 4:38 AM
Yaron_Koren committed rEPFMb2bd9c74386d: Do not expect the Parser by reference (authored by thiemowmde).
Do not expect the Parser by reference
Jan 27 2020, 4:02 AM
Yaron_Koren committed rEPFMdc6ea54da588: Remove unused argument in PFParserFunctions (authored by thiemowmde).
Remove unused argument in PFParserFunctions
Jan 27 2020, 3:44 AM
Yaron_Koren committed rEPFMd52457073c5b: Simplify Hooks section in extension.json (authored by thiemowmde).
Simplify Hooks section in extension.json
Jan 27 2020, 3:12 AM
Yaron_Koren committed rEPFMe8587f616d17: Remove dead, unused parameter from PFCreatePageJob (authored by thiemowmde).
Remove dead, unused parameter from PFCreatePageJob
Jan 27 2020, 3:09 AM

Jan 26 2020

Kap_cool awarded T241632: Remove use of jQuery UI from Page Forms a Like token.
Jan 26 2020, 3:36 PM · Google-Summer-of-Code (2020), MediaWiki-extensions-Page_Forms

Jan 24 2020

Yaron_Koren committed rEPFMc921950b06d0: Partial revert of 11ed5bd2831f (authored by Yaron_Koren).
Partial revert of 11ed5bd2831f
Jan 24 2020, 5:28 PM
Yaron_Koren added a comment to T241632: Remove use of jQuery UI from Page Forms.

@BamLifa - no, I don't have co-mentors yet. Who are you?

Jan 24 2020, 3:33 PM · Google-Summer-of-Code (2020), MediaWiki-extensions-Page_Forms
Yaron_Koren created T243576: Replace jQuery UI with OOUI in Header Tabs extension.
Jan 24 2020, 5:08 AM · MediaWiki-extensions-Other, UI-Standardization

Jan 23 2020

Yaron_Koren added a comment to T242708: Conflict between Extension:PageForms and Extension:Lingo.

Thanks for letting me know - I don't think I saw that other patch before.

Jan 23 2020, 1:50 PM · MediaWiki-extensions-Page_Forms

Jan 21 2020

Yaron_Koren committed rEPFM8133fbbe64af: Add optional popup warning if user closes unsaved form (authored by Yaron_Koren).
Add optional popup warning if user closes unsaved form
Jan 21 2020, 9:21 PM

Jan 20 2020

Yaron_Koren updated the task description for T241632: Remove use of jQuery UI from Page Forms.
Jan 20 2020, 1:40 AM · Google-Summer-of-Code (2020), MediaWiki-extensions-Page_Forms

Jan 17 2020

Yaron_Koren committed rEPFM47af1201813e: Add "max height" param for textarea with VE (authored by Yaron_Koren).
Add "max height" param for textarea with VE
Jan 17 2020, 7:41 PM
Yaron_Koren committed rEPFMbd0079a47385: Fix for handling of underscores in template/field names in form def (authored by Yaron_Koren).
Fix for handling of underscores in template/field names in form def
Jan 17 2020, 6:09 PM
Yaron_Koren updated the task description for T241632: Remove use of jQuery UI from Page Forms.
Jan 17 2020, 3:28 PM · Google-Summer-of-Code (2020), MediaWiki-extensions-Page_Forms
Yaron_Koren committed rEPFMcaad415825a8: Change some vars to camelcase (authored by Samwilson).
Change some vars to camelcase
Jan 17 2020, 3:36 AM

Jan 16 2020

Yaron_Koren committed rEPFM78ce712807bf: Display CAPTCHA from Extension:ConfirmEdit on Special:FormEdit (authored by edwardspec).
Display CAPTCHA from Extension:ConfirmEdit on Special:FormEdit
Jan 16 2020, 8:04 PM
Yaron_Koren committed rEADL647fc414a4a9: Version 0.4 (authored by Yaron_Koren).
Version 0.4
Jan 16 2020, 7:20 PM
Yaron_Koren committed rEPFM503be9055524: Override permission check in PFFormPrinter unit test (authored by Osnard).
Override permission check in PFFormPrinter unit test
Jan 16 2020, 7:09 PM
Yaron_Koren committed rEPFMc45f84686f0d: Fix an UI bug in type=tokens when double-clicking near Delete button (authored by edwardspec).
Fix an UI bug in type=tokens when double-clicking near Delete button
Jan 16 2020, 5:47 PM
Yaron_Koren added a comment to T241019: Recruit ideas for projects and mentors for Google Summer of Code 2020 and Outreachy Round 20.

This thing is coming up fast! I added a few microtasks to my project.

Jan 16 2020, 2:26 PM · Outreachy (Round 20), Google-Summer-of-Code (2020), Developer-Advocacy (Jan-Mar 2020)
Yaron_Koren updated the task description for T241632: Remove use of jQuery UI from Page Forms.
Jan 16 2020, 2:25 PM · Google-Summer-of-Code (2020), MediaWiki-extensions-Page_Forms
Yaron_Koren created T242973: Special:CargoQuery autocompletion appearance should be standardized.
Jan 16 2020, 2:20 PM · Patch-For-Review, MediaWiki-extensions-Cargo
Yaron_Koren closed T76964: [SF][3.0] Wrong Combobox position in popup with scrollbar as Resolved.

I'm guessing this is no longer an issue...

Jan 16 2020, 2:13 PM · MediaWiki-extensions-Page_Forms

Jan 15 2020

Yaron_Koren committed rEPFM5ce64ef5270b: Restore support for MW 1.28 (authored by Yaron_Koren).
Restore support for MW 1.28
Jan 15 2020, 10:03 PM

Jan 13 2020

Yaron_Koren committed rEADL42c7117f50ec: Put each class from AdminLinks_body.php into a separate file (authored by Zoranzoki21).
Put each class from AdminLinks_body.php into a separate file
Jan 13 2020, 4:01 PM
Yaron_Koren committed rEADLe2f81cc31dc5: Officially removed support for MW < 1.28 (authored by Yaron_Koren).
Officially removed support for MW < 1.28
Jan 13 2020, 2:43 PM

Jan 7 2020

Yaron_Koren added a comment to T182507: Extension:Cargo Lua Module does not escape query values leading to potential SQL injection..

Yes, sure. I don't think this bug report was ever valid - at least, the way it was described - so there's no harm in making it public.

Jan 7 2020, 10:28 PM · Security, MediaWiki-extensions-Cargo
Yaron_Koren closed T182507: Extension:Cargo Lua Module does not escape query values leading to potential SQL injection. as Invalid.

I'm marking this again as "Invalid", for the reasons stated above.

Jan 7 2020, 9:38 PM · Security, MediaWiki-extensions-Cargo

Jan 6 2020

Yaron_Koren committed rEPFM58b305574fc9: Fix suppressWarnings() and restoreWarnings() calls for MW 1.34+ (authored by Pastakhov).
Fix suppressWarnings() and restoreWarnings() calls for MW 1.34+
Jan 6 2020, 6:14 PM
Yaron_Koren committed rEPFM302befbaceec: Allow for setting the free text value from the query string (authored by Pastakhov).
Allow for setting the free text value from the query string
Jan 6 2020, 2:28 PM

Dec 31 2019

Yaron_Koren added a comment to T241568: Replace $wgParser in DataTransfer.

Thank you!

Dec 31 2019, 7:06 AM · MediaWiki-extensions-DataTransfer, User-TheSandDoctor
Yaron_Koren added a comment to T241609: Cargo needs uses of global $wgUser replaced.

@DannyS712 - thank you for the patch!

Dec 31 2019, 4:53 AM · MediaWiki-extensions-Cargo, Technical-Debt, User-DannyS712
Yaron_Koren added a comment to T241019: Recruit ideas for projects and mentors for Google Summer of Code 2020 and Outreachy Round 20.

For the 2020 Google Summer of Code, I would like to mentor a project to remove some or all of the usage of jQuery UI from the Page Forms extension - this is detailed at T241632.

Dec 31 2019, 4:36 AM · Outreachy (Round 20), Google-Summer-of-Code (2020), Developer-Advocacy (Jan-Mar 2020)
Yaron_Koren created T241632: Remove use of jQuery UI from Page Forms.
Dec 31 2019, 4:30 AM · Google-Summer-of-Code (2020), MediaWiki-extensions-Page_Forms

Dec 30 2019

Yaron_Koren added a comment to T234366: Truncate string values before row insertion.

@HertzDevil, @Tombolano - I just checked in an attempted fix for this problem, at 60ddb9cfc3dd . It would be great if either or both of you could test out my fix and see if it seems to work for you.

Dec 30 2019, 5:30 PM · MediaWiki-extensions-Cargo
Yaron_Koren closed T231665: PageForms: Drop support for PHP 5.3 as Resolved.
Dec 30 2019, 5:01 AM · MediaWiki-extensions-Page_Forms

Dec 27 2019

Yaron_Koren closed T230939: Category information should be saved to _pageData table on FIRST save of page as Resolved.

This was indeed implemented in the Cargo code, using hooks, a few weeks ago in ce51277d7ed2. I'm marking this bug as "resolved", though feel free to re-open if there are any issues.

Dec 27 2019, 6:44 PM · MediaWiki-extensions-Cargo

Dec 19 2019

Yaron_Koren committed rEPFM0a64fef79eb8: Fix FormPrinter::formHTML for pages created by formredlink parser function (authored by Pastakhov).
Fix FormPrinter::formHTML for pages created by formredlink parser function
Dec 19 2019, 3:14 PM
Yaron_Koren committed rEPFMce7d30ab6139: Add validation for Integer fields (authored by Yaron_Koren).
Add validation for Integer fields
Dec 19 2019, 4:49 AM

Dec 18 2019

Yaron_Koren committed rEPFM70b834a17286: Add identifying class for VE textareas holding template fields (authored by Yaron_Koren).
Add identifying class for VE textareas holding template fields
Dec 18 2019, 9:15 PM
Yaron_Koren added a comment to T234366: Truncate string values before row insertion.

Sorry for the long delay. I understand the problem, but I don't think this specific patch will work, because fields of type "Text" and "Wikitext" don't get truncated at all in the database - or if they do, it's after many more characters than the value of $wgCargoDefaultStringBytes. The same goes for fields of type "String", "Page", etc., if they have a "size" value that's set to more than 1000 - they get stored in the database as just a "Text" field. So I think it makes sense to do the truncation in doesRowAlreadyExist() instead - compare a substring of the new value with a substring of the database value, I guess by using both mb_substr() and SUBSTR().

Dec 18 2019, 6:15 PM · MediaWiki-extensions-Cargo
Yaron_Koren added a comment to T239506: External Data: automatically create the table ed_url_cache on running update.php.

@alex-mashin - sorry about the delay. I've reviewed, and the code looks fine. I'm just not sure yet that the ed_url_cache table should get created automatically. I just need to decide on this one way or the other. But that SQL should indeed be improved either way.

Dec 18 2019, 5:26 PM · Patch-For-Review, MediaWiki-extensions-ExternalData

Dec 17 2019

Yaron_Koren committed rEPFM74b7874dd497: Fix for 6883c309a061 - fix ToggleDisplay handling (authored by Yaron_Koren).
Fix for 6883c309a061 - fix ToggleDisplay handling
Dec 17 2019, 10:53 PM
Yaron_Koren added a comment to T192752: Convert Page Forms to use OOUI.

@Samwilson - that sounds good; a JS timepicker is generally a lot less useful than a datepicker anyway. Yes, masked inputs get used a lot in Page Forms already, if I understand what you're asking...

Dec 17 2019, 8:13 PM · UI-Standardization, MediaWiki-extensions-Page_Forms
Yaron_Koren committed rEPFMabb8079e214b: Add "minor" param to #autoedit (authored by Yaron_Koren).
Add "minor" param to #autoedit
Dec 17 2019, 7:52 PM

Dec 16 2019

Yaron_Koren committed rEPFM20067c7f8fac: Add JS hook to get around occasional VEForAll data loss issue (authored by Yaron_Koren).
Add JS hook to get around occasional VEForAll data loss issue
Dec 16 2019, 4:13 PM
Yaron_Koren committed rEPFMd7b2a4ff5d2f: Fix for 7bdac7e9c9d9 for "one-step process" (authored by Yaron_Koren).
Fix for 7bdac7e9c9d9 for "one-step process"
Dec 16 2019, 3:06 PM

Dec 13 2019

Yaron_Koren added a comment to T192752: Convert Page Forms to use OOUI.

Okay, got it. Well, I hope you do look again into it - and, as I noted a while ago, if you do update the patch, I think the "datepicker" and "datetimepicker" inputs should just be replaced completely, instead of adding separate input types or some "ooui" parameter.

Dec 13 2019, 8:11 PM · UI-Standardization, MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T240656: EditNotify cannot be restricted to page creations in certain namespaces. It always notifies about any page creation..

Sorry, I must be missing something obvious. Are these two separate issues? They seem to be two conflicting descriptions of the same issue. This one says that you can't ever track a single namespace or category, the other one says that you can't track a single namespace or category, but only when the NewUserNotif extension is installed.

Dec 13 2019, 3:31 PM · MediaWiki-extensions-EditNotify
Yaron_Koren added a comment to T240656: EditNotify cannot be restricted to page creations in certain namespaces. It always notifies about any page creation..

I thought this bug report is saying that the namespace restriction is not respected even without NewUserNotif.

Dec 13 2019, 1:54 PM · MediaWiki-extensions-EditNotify
Yaron_Koren added a comment to T240656: EditNotify cannot be restricted to page creations in certain namespaces. It always notifies about any page creation..

So is T240391 incorrect? What's the impact that the NewUserNotif extension has, if any?

Dec 13 2019, 1:27 PM · MediaWiki-extensions-EditNotify

Dec 12 2019

Yaron_Koren added a comment to T192752: Convert Page Forms to use OOUI.

Okay, that makes sense, and I agree.

Dec 12 2019, 2:34 PM · UI-Standardization, MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T233914: Allow hiding columns on Special:MultiPageEdit to make the view clearer.

Sorry about that! I did an incomplete code check-in before. If you get the latest code now, you should see the "x"s.

Dec 12 2019, 2:31 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren committed rEPFM5feab446bcf8: Fix for 9f5fc7587c2b - add missing "x" characters (authored by Yaron_Koren).
Fix for 9f5fc7587c2b - add missing "x" characters
Dec 12 2019, 3:52 AM