Page MenuHomePhabricator

Yaron_Koren (Yaron Koren)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 14 2014, 3:01 AM (375 w, 3 d)
Availability
Available
LDAP User
Yaron Koren
MediaWiki User
Unknown

Recent Activity

Yesterday

Yaron_Koren added a comment to T299864: Autocompletion: search in interwikis.

Very interesting. This could be a very useful feature, though I have some high-level questions and comments. My main questions are about this particular combination of parameters: why is "values from namespace" more useful than, say, "values from category"? And why allow querying of more than one wiki? That seems strange to me - especially because you might want to only include the values from, say, the main namespace for wiki #1, and the "Category" namespace from wiki #2. Okay, I admit that that's unlikely, but then again, it's unlikely that people would want to autocomplete on more than one namespace anyway. A more likely scenario is, if "values from category" ever supported the interwiki feature, you might want only the values from the "People" category from wiki #1, and the "Employees" category from wiki #2. So I guess, really what I'm saying is, if more than one wiki can be queried at the same time, the syntax should be more complicated. Maybe the syntax should instead look like:

Sun, Jan 23, 11:19 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Fri, Jan 21

Yaron_Koren added a comment to T284307: `editor=wikieditor` does not work - no toolbar shown.

Sorry for the long delay on this. As noted in the Page Forms documentation (https://www.mediawiki.org/wiki/Extension:Page_Forms/Input_types#textarea), the WikiEditor versions that correspond to MediaWiki 1.34 and 1.35 don't work with Page Forms by default - you need to apply this patch to the code: https://github.com/Nikerabbit/mediawiki-extensions-WikiEditor/commit/9a1188d0850418d8ae64bd06b7f39d9a8cbf127f . Could that be the issue here?

Fri, Jan 21, 5:43 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T299618: Two-digit inputs in OOUI DateTimeInputWidget are too narrow in MS Windows.

It does! @matmarex and @Jdforrester-WMF - thank you.

Fri, Jan 21, 1:12 AM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), MediaWiki-Interface (mediawiki.widgets)

Thu, Jan 20

Yaron_Koren committed rEADL746b2545b1c1: Change to short array syntax (finally) (authored by Yaron_Koren).
Change to short array syntax (finally)
Thu, Jan 20, 9:53 PM
Yaron_Koren committed rEFLDaf452e428acb: Add .phpcs.xml file (authored by Yaron_Koren).
Add .phpcs.xml file
Thu, Jan 20, 9:30 PM
Yaron_Koren added a comment to T299618: Two-digit inputs in OOUI DateTimeInputWidget are too narrow in MS Windows.

Ah, the box-sizing thing explains it. I just tried out the "API sandbox" page on that "patch demo" wiki (very neat service, by the way, this "patch demo" thing), and it displays great in Windows on the four browsers I tried it on: Chrome, Opera, MS Edge and Firefox.

Thu, Jan 20, 1:45 AM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), MediaWiki-Interface (mediawiki.widgets)
Yaron_Koren added a comment to T299618: Two-digit inputs in OOUI DateTimeInputWidget are too narrow in MS Windows.

Okay, I have a new theory: the actual formula should be (1 * x + 0.5). (At minimum.) In other words, 1ch for each digit is fine, but there's an extra bit of padding, at least in Windows, on the left or right or both, that needs to be handled. To test that out, I reduced the width of the year input (4 digits) from 4.6ch to 4.5ch, and it still shows up fine. So that's my new theory.

Thu, Jan 20, 1:23 AM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), MediaWiki-Interface (mediawiki.widgets)
Yaron_Koren added a comment to T299618: Two-digit inputs in OOUI DateTimeInputWidget are too narrow in MS Windows.

Oh, I didn't know that! I should have looked up "ch". That makes it even stranger. But the digits are definitely not all the same width, at least in Windows - "1", at least, is narrower than the other digits.

Thu, Jan 20, 1:16 AM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), MediaWiki-Interface (mediawiki.widgets)
Yaron_Koren added a comment to T299483: [HeaderTabs] Composer name is not registered.

Alright fine - I just requested it at T299619.

Thu, Jan 20, 12:42 AM · Header Tabs
Yaron_Koren created T299619: Create project tag for Header Tabs extension.
Thu, Jan 20, 12:41 AM · Project-Admins
Yaron_Koren created T299618: Two-digit inputs in OOUI DateTimeInputWidget are too narrow in MS Windows.
Thu, Jan 20, 12:33 AM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), MediaWiki-Interface (mediawiki.widgets)

Wed, Jan 19

Yaron_Koren closed T297455: Blank Cargo Table Diagram as Resolved.

Okay, great. I'm marking this bug as "Resolved", then, and if other validation issues come up, they can get their own tasks.

Wed, Jan 19, 9:32 PM · MediaWiki-extensions-Cargo
Yaron_Koren added a comment to T299483: [HeaderTabs] Composer name is not registered.

Oh, sorry. Well, if that's what it says, then I guess people should indeed just send bug reports and requests via email. Of course, if people create tasks on Phabricator, then I'll respond to them here. Probably there should be a Phabricator tag for Header Tabs, though - and actually, I think a fair number of extensions I maintain are still lacking a tag.

Wed, Jan 19, 9:29 PM · Header Tabs
Yaron_Koren closed T299483: [HeaderTabs] Composer name is not registered as Resolved.

I assume this is fixed now... feel free to re-open if not.

Wed, Jan 19, 7:49 PM · Header Tabs
Yaron_Koren added a comment to T299483: [HeaderTabs] Composer name is not registered.

Okay - what should I do about the Composer problem?

Wed, Jan 19, 1:30 PM · Header Tabs
Yaron_Koren committed rEFLDde1d287a619c: Add support for diagrams.net with new "Drawio" namespace (authored by Techwizzie).
Add support for diagrams.net with new "Drawio" namespace
Wed, Jan 19, 12:46 AM

Mon, Jan 17

Yaron_Koren added a comment to T299274: Add a Lua function formatting an arbitrary Lua table to Cargo.

That's fair... oh well. Hopefully there will be no errors!

Mon, Jan 17, 3:16 PM · MediaWiki-extensions-Cargo
Yaron_Koren closed T299274: Add a Lua function formatting an arbitrary Lua table to Cargo as Resolved.

I assume this is resolved now.

Mon, Jan 17, 2:15 PM · MediaWiki-extensions-Cargo
Yaron_Koren added a comment to T288526: regular file upload in uploadable field not working.

Well, I can't really help with old versions of the code - you really should upgrade to the latest version of Page Forms. If that getName() problem (which I don't understand) really is an issue, please create a separate Phabricator task for it.

Mon, Jan 17, 2:37 AM · MediaWiki-extensions-Page_Forms

Fri, Jan 14

Yaron_Koren added a comment to T288526: regular file upload in uploadable field not working.

@rijvirajib - that sounds like a totally different error. What version of Page Forms are you running?

Fri, Jan 14, 11:50 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T299060: Feature request: Add possible solution for "remote autocompletion" on "mapping template" problem.

Sorry, what does all this have to do with the name of the parameter?

Fri, Jan 14, 7:53 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T299060: Feature request: Add possible solution for "remote autocompletion" on "mapping template" problem.

Why add two new parameters - can't the existing "mapping template" parameter be used for one of them?

Fri, Jan 14, 5:53 PM · MediaWiki-extensions-Page_Forms

Wed, Jan 12

Yaron_Koren closed T299058: PHP Deprecated: Use of Wikimedia\Rdbms\DBConnRef::fetchRow (and others) was deprecated in MediaWiki 1.38 as Resolved.
Wed, Jan 12, 6:04 PM · Technical-Debt, MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T299058: PHP Deprecated: Use of Wikimedia\Rdbms\DBConnRef::fetchRow (and others) was deprecated in MediaWiki 1.38.

Yes, I saw the problem - I fixed this in a54cd6f54f58.

Wed, Jan 12, 6:03 PM · Technical-Debt, MediaWiki-extensions-Page_Forms

Tue, Jan 4

Yaron_Koren closed T298506: PageForms saves form only after two clicks on "Save page" button if VEforAll is used as Resolved.

Fixed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageForms/+/751194 . Thanks for letting me know!

Tue, Jan 4, 5:39 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren closed T234555: Upload file form does not update file name if the provided file name is not valid as Resolved.

@Tombolano - thank you for this patch, and sorry for the extremely long delay on checking it in. Better late than never, hopefully!

Tue, Jan 4, 4:02 PM · MediaWiki-extensions-Page_Forms

Mon, Jan 3

Yaron_Koren updated the task description for T183213: Page Forms review checklist.
Mon, Jan 3, 8:28 PM · MediaWiki-extensions-Page_Forms

Fri, Dec 31

Yaron_Koren updated the task description for T183213: Page Forms review checklist.
Fri, Dec 31, 3:55 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren closed T243487: PageForms needs uses of global $wgUser removed as Resolved.

I'm not sure when this was fully fixed, but Page Forms now no longer calls $wgUser! (And it no longer supports MW < 1.32.)

Fri, Dec 31, 4:25 AM · User-DannyS712, MediaWiki-extensions-Page_Forms, Technical-Debt
Yaron_Koren closed T243487: PageForms needs uses of global $wgUser removed, a subtask of T247793: Non-WMF deployed extensions need uses of global $wgUser removed [tracking], as Resolved.
Fri, Dec 31, 4:24 AM · Epic, MediaWiki-extensions-General, User-DannyS712, Technical-Debt

Thu, Dec 30

Yaron_Koren committed rEGDCa606f4390e42: Version 2.0 (authored by Yaron_Koren).
Version 2.0
Thu, Dec 30, 6:08 PM
Yaron_Koren closed T297694: PageForms combobox input ignores existing values only option as Resolved.

I'm marking this as resolved - this was mostly fixed before, but now I believe it's fully fixed.

Thu, Dec 30, 3:58 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Wed, Dec 29

Yaron_Koren added a comment to T297046: PHP 7.4 causes OOMs with MediaWiki.

What version of Cargo are/were you running? There was a change to the Cargo code on November 17 (e5c93104078e) that I think dramatically sped up page saves. Unfortunately, there hasn't been an official version release yet since then.

Wed, Dec 29, 10:17 PM · MediaWiki-extensions-Cargo, MW-1.37-release, User-RhinosF1, Performance Issue, MediaWiki-General, PHP 7.4 support
Yaron_Koren committed rEGDC1c9e70e79b1d: Delete CODE_OF_CONDUCT.md (authored by Yaron_Koren).
Delete CODE_OF_CONDUCT.md
Wed, Dec 29, 12:24 AM

Dec 22 2021

Yaron_Koren added a comment to T297455: Blank Cargo Table Diagram.

@Tenbergen - is this issue now fixed, on your wiki?

Dec 22 2021, 3:19 PM · MediaWiki-extensions-Cargo
Yaron_Koren closed T298129: Error from line 87 of /../PageForms/includes/forminputs/PF_RegExpInput.php: Cannot access private property PFFormPrinter::$mInputTypeClasses as Resolved.

Sorry about that!

Dec 22 2021, 3:04 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T297046: PHP 7.4 causes OOMs with MediaWiki.

The bug report created by Paladox.

Dec 22 2021, 12:01 AM · MediaWiki-extensions-Cargo, MW-1.37-release, User-RhinosF1, Performance Issue, MediaWiki-General, PHP 7.4 support

Dec 21 2021

Yaron_Koren added a comment to T297046: PHP 7.4 causes OOMs with MediaWiki.

Is the original bug Cargo-related too? If not, this may be two separate issues.

Dec 21 2021, 5:25 PM · MediaWiki-extensions-Cargo, MW-1.37-release, User-RhinosF1, Performance Issue, MediaWiki-General, PHP 7.4 support
Yaron_Koren closed T297940: Edit Form hangs on loading if a multi instance template uses checkbox with show on select as Resolved.

I think this is fixed now! @Bethoniel - sorry about the problem, and thanks for reporting it. And feel free to re-open if it's still an issue.

Dec 21 2021, 5:04 PM · MediaWiki-extensions-Page_Forms

Dec 20 2021

Yaron_Koren added a comment to T298013: Please add Version to ExtensionDependencyError.

That's too bad about the problems. I don't know if this is something that can be fixed in Page Forms... the "ExtensionDependencyError" message is not coming from Page Forms, but from somewhere else - presumably core MediaWiki. And I also don't know why "^5.2.1" would select 5.3.

Dec 20 2021, 4:21 PM · MediaWiki-extensions-Page_Forms

Dec 19 2021

Yaron_Koren added a comment to T298013: Please add Version to ExtensionDependencyError.

Is this a problem with Page Forms, or Pymediawikidocker? (Or something else?) By the way, Page Forms dropped support for MW 1.31 in version 5.3.

Dec 19 2021, 6:47 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren closed T297929: move Special Page "Cargo table diagram" as Resolved.

Congratulations on (I think) your first-ever MediaWiki patch! And thank you for the code improvement! I believe this bug can be closed.

Dec 19 2021, 3:07 PM · MediaWiki-extensions-Cargo

Dec 17 2021

Yaron_Koren closed T278567: PageForms saves form only after two clicks on "Save page" button if VEforAll is used as Resolved.

@Urfiner and @M4rkusd89 - thanks for your help with this. And sorry that it took so long to fix! Hopefully everything works fine now.

Dec 17 2021, 5:13 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren closed T285176: Cargo: #cargo_store fails when non-mandatory Boolean/Integer/Float fields are omitted, because it tries to insert empty string into INTEGER field, etc. as Resolved.

Sorry for the problem - I checked in a change a few days ago that I believe fixes it. I'm closing this, but feel free to re-open if not.

Dec 17 2021, 4:36 PM · MediaWiki-extensions-Cargo, User-RhinosF1
Yaron_Koren added a comment to T297940: Edit Form hangs on loading if a multi instance template uses checkbox with show on select.

Did you mean 5.3 and 5.3.1?

Dec 17 2021, 3:20 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T287175: Decide on most suitable underlying technical platform.

It might be too late now, but are you aware of the MintyDocs MediaWiki extension (https://www.mediawiki.org/wiki/Extension:MintyDocs)? It's already in use for technical documentation at at least one company (Genesys), and, in conjunction with extensions like Cargo, Page Forms and Approved Revs, I think it provides all the structure, ownership, and control over content that is required. And, of course, it means you get to use MediaWiki. Granted, I'm the main author of all four of these extensions, so I may be biased.

Dec 17 2021, 2:42 PM · Developer-Advocacy (Oct-Dec 2021), Wikimedia-Developer-Portal

Dec 15 2021

Yaron_Koren added a comment to T278567: PageForms saves form only after two clicks on "Save page" button if VEforAll is used.

@M4rkusd89 - sorry for the delay. There are now three different suggested fixes in this bug report. Do you believe yours is the best of the three?

Dec 15 2021, 10:39 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren closed T290165: Leaving out fields from #cargo_store results in duplicate entries as Resolved.

I think this bug was added in version 2.8, and I believe it's fixed now. Sorry about the problem.

Dec 15 2021, 9:06 PM · MediaWiki-extensions-Cargo
Yaron_Koren added a comment to T297530: Cargo gives SQL query error after updating.

Sorry, I meant - what's the #cargo_query call?

Dec 15 2021, 7:47 PM · MediaWiki-extensions-Cargo
Yaron_Koren renamed T290165: Leaving out fields from #cargo_store results in duplicate entries from Storing into a Cargo table without providing all fields results in duplicate entries to Leaving out fields from #cargo_store results in duplicate entries.
Dec 15 2021, 6:14 PM · MediaWiki-extensions-Cargo
Yaron_Koren added a comment to T297530: Cargo gives SQL query error after updating.

Sorry for the delay on this. What does the original Cargo query look like?

Dec 15 2021, 5:36 PM · MediaWiki-extensions-Cargo

Dec 13 2021

Yaron_Koren committed rEMDO574a593e5995: Version 0.9 (authored by Yaron_Koren).
Version 0.9
Dec 13 2021, 5:26 PM

Dec 10 2021

Yaron_Koren added a comment to T297455: Blank Cargo Table Diagram.

If you look in the browser console, do you see any JS errors?

Dec 10 2021, 9:52 PM · MediaWiki-extensions-Cargo

Dec 9 2021

Yaron_Koren created T297335: OOUI PHP demos page is down.
Dec 9 2021, 3:46 AM · OOUI

Dec 8 2021

Yaron_Koren updated the task description for T183213: Page Forms review checklist.
Dec 8 2021, 11:45 PM · MediaWiki-extensions-Page_Forms

Dec 6 2021

Yaron_Koren closed T292119: Let PFFormUtils::buttonHTML to add classes to ButtonInputWidget (or, let save and continue button work) as Resolved.

I think this is fixed now - that previous patch didn't really work, but now it should work.

Dec 6 2021, 7:58 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren closed T294563: "Save and continue" button does not work with MW 1.35 and PF 5.3-alpha as Resolved.

Sorry about that! I think all these problems are fixed now.

Dec 6 2021, 7:57 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren closed T69409: Prevent double save on double click on "Save page" button as Resolved.

I believe this is fixed now, seven years later!

Dec 6 2021, 4:01 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Dec 2 2021

Yaron_Koren committed rEMDO7672867fd0c4: Remove support for MW 1.29-1.31 (authored by Yaron_Koren).
Remove support for MW 1.29-1.31
Dec 2 2021, 10:38 PM
Yaron_Koren committed rEMDO7f73c1097e85: Replace $wgUser (authored by Yaron_Koren).
Replace $wgUser
Dec 2 2021, 8:08 PM
Yaron_Koren closed T292637: PageForms is not compatible with MediaWiki 1.37: Class 'Revision' not found as Resolved.

I assume this can be closed for good now...

Dec 2 2021, 5:22 PM · MediaWiki-extensions-Page_Forms, affects-translatewiki.net

Dec 1 2021

Yaron_Koren committed rEMDOf85b8fa160aa: Replace deprecated Parser::doBlockLevels() (authored by Yaron_Koren).
Replace deprecated Parser::doBlockLevels()
Dec 1 2021, 3:19 PM
Yaron_Koren committed rEMDO88f40e0a57c2: JS fix for 57df3a43953f (authored by Yaron_Koren).
JS fix for 57df3a43953f
Dec 1 2021, 3:05 PM
Yaron_Koren committed rEMDObe4738b75312: Change from deprecated userCan hook to getUserPermissionsErrors (authored by Yaron_Koren).
Change from deprecated userCan hook to getUserPermissionsErrors
Dec 1 2021, 2:37 PM

Nov 24 2021

Yaron_Koren added a comment to T296435: Title::getLinksTo() appears to be broken.

Correction: it looks like the patch wasn't merged in until September, which makes this bug more plausible.

Nov 24 2021, 9:23 PM · MediaWiki-General
Yaron_Koren created T296435: Title::getLinksTo() appears to be broken.
Nov 24 2021, 8:46 PM · MediaWiki-General

Nov 23 2021

Yaron_Koren added a comment to T296262: using <unique number;start=#> and <template-name[field-name]>does not increment unique number.

This is actually the correct behavior. The <unique number> tag is not meant to be an incrementing counter; rather, it finds the lowest number (greater than or equal to "start", that is) for which a page by that name does not yet exist. Maybe the documentation should be clearer about this.

Nov 23 2021, 4:02 AM · MediaWiki-extensions-Page_Forms

Nov 22 2021

Yaron_Koren reopened T273028: PF does not recognize "Allows value list" feature from SMW as "Open".
Nov 22 2021, 4:23 PM · MediaWiki-extensions-Page_Forms

Nov 18 2021

Yaron_Koren committed rEFLDc223e7d81e31: Upgrade Mermaid to latest version, 8.13.4 (authored by Yaron_Koren).
Upgrade Mermaid to latest version, 8.13.4
Nov 18 2021, 8:19 PM
Yaron_Koren committed rEFLD18ceb93374bd: Fix mermaid handling for MW >= 1.31 (?) (authored by Yaron_Koren).
Fix mermaid handling for MW >= 1.31 (?)
Nov 18 2021, 6:21 PM

Nov 11 2021

Yaron_Koren committed rEPGE59d6d64fce6c: Version 0.4 (authored by Yaron_Koren).
Version 0.4
Nov 11 2021, 8:28 PM
Yaron_Koren committed rEPGE6a9ee58f98b5: Remove support for MW < 1.33 (authored by Yaron_Koren).
Remove support for MW < 1.33
Nov 11 2021, 5:24 PM

Nov 10 2021

Yaron_Koren added a comment to T267571: Add filtering to Special:MultiPageEdit .

Now that this feature request no longer is about jsGrid specifically, it makes more sense to discuss it. :) I looked into filtering in jExcel (which is now called Jspreadsheet), and it turned out be pretty easy to implement, so I just added it. If you can, please try it out and let me know what you think.

Nov 10 2021, 4:06 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren renamed T267571: Add filtering to Special:MultiPageEdit from add JSGrid "filtering" option to improve Special:MultiPageEdit to Add filtering to Special:MultiPageEdit .
Nov 10 2021, 3:29 PM · MediaWiki-extensions-Page_Forms

Nov 4 2021

Yaron_Koren closed T295042: Restricted date(-time) fields are not rendered as disabled fields as Resolved.

Thank you for this patch! Hopefully everything works now.

Nov 4 2021, 4:07 PM · MediaWiki-extensions-Page_Forms

Nov 3 2021

Yaron_Koren committed rEVFAd0aec153e80b: Version 0.4 (authored by Yaron_Koren).
Version 0.4
Nov 3 2021, 1:56 PM

Nov 1 2021

Yaron_Koren committed rEVFA3613a60ac8e3: Further removal of support for MW < 1.32 (authored by Yaron_Koren).
Further removal of support for MW < 1.32
Nov 1 2021, 4:51 PM

Oct 28 2021

Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

Good enough for me! Thank you for this great patch, and for all your patience with my questions and comments.

Oct 28 2021, 2:30 PM · MediaWiki-extensions-ExternalData
Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

Okay, let me make sure I understand this, because I just want to make sure that there's no security leak here.

Oct 28 2021, 4:52 AM · MediaWiki-extensions-ExternalData
Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

Great. Sorry, I have another question, which I should have asked before: I see now that that the variables $edgDirectoryPath and $edgFilePath have both been replaced with the parameter 'path' - given that, how does the code know whether this is a directory or a file?

Oct 28 2021, 12:39 AM · MediaWiki-extensions-ExternalData

Oct 27 2021

Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

Sorry again for the delay. I rewrote the main commit message (the top line), changed some of the formatting in the README file (like changing the {{#function_name:}} style to just #function_name, which I prefer), and upgraded the version number to 3.0-alpha. Please let me know if you have objections to any of these changes.

Oct 27 2021, 7:15 PM · MediaWiki-extensions-ExternalData

Oct 26 2021

Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

Alright. This patch looks pretty much ready to go - I'm excited about the changes. I only have some minor comments:

Oct 26 2021, 4:51 AM · MediaWiki-extensions-ExternalData

Oct 25 2021

Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

Oh, how interesting. Does it work? And if so, how - do you pass in the source type as a parameter?

Oct 25 2021, 7:19 PM · MediaWiki-extensions-ExternalData
Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

Sorry for the delay. What is #get_external_data? I hadn't noticed that addition before.

Oct 25 2021, 5:03 PM · MediaWiki-extensions-ExternalData

Oct 24 2021

Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

Okay - sorry that I wasn't clear about it: I meant that I thought it made sense to have these separate variables instead of (what was then known as) $edgSources. I still think there's an argument to have these separate variables - although I admit there are also valid reasons to have a single variable like $wgExternalDataSources. But I never thought it made sense to have both; sorry that it sounded like I did.

Oct 24 2021, 2:42 AM · MediaWiki-extensions-ExternalData

Oct 22 2021

Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

Sorry for the delay. Overall this is looking good. I'm wondering about those other new global variables, $wgExternalDataDatabases, $wgExternalDataSites, $wgExternalDataFiles, $wgExternalDataDirectories and $wgExternalDataPrograms - I didn't notice those before. What are they there for?

Oct 22 2021, 6:44 PM · MediaWiki-extensions-ExternalData
Yaron_Koren added a comment to T282977: InvalidArgumentException when accessing Special:MultiPageEdit.

Does this only happen for templates that aren't yet called by any pages? That part wasn't clear.

Oct 22 2021, 2:42 AM · User-RhinosF1, MediaWiki-extensions-Page_Forms

Oct 21 2021

Yaron_Koren changed the status of T293769: Replacement announced but effectively not done ... from Resolved to Invalid.

Okay, good to know. That commit's not tagged because it's on a branch (REL1_35); I only add tags to the master branch, which is what should be used for Replace Text anyway.

Oct 21 2021, 5:54 PM · MediaWiki-extensions-ReplaceText
Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

Well, there's really only one reason for the whitelist, and that's to prevent people from finding out the values of the string replacements. Let's say that you have a key for some API, but you want it kept private - you would add something like this to LocalSettings.php (to borrow the example from the documentation):

Oct 21 2021, 1:59 PM · MediaWiki-extensions-ExternalData
Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

That's interesting. How would "allow external data from" work on a per-host level?

Oct 21 2021, 3:16 AM · MediaWiki-extensions-ExternalData
Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

Oh, okay - I didn't realize that all the information was in the commit message. Reading through it, it does look pretty good.

Oct 21 2021, 2:58 AM · MediaWiki-extensions-ExternalData
Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

Okay, thanks for that clarification. I'm getting more comfortable with this whole $edgSources idea, I have to say. But could you explain the current proposed structure - meaning the set of allowed parameters? Neither the main description of this feature at the top, nor your listing from October 15, seem to be accurate any more.

Oct 21 2021, 1:52 AM · MediaWiki-extensions-ExternalData

Oct 20 2021

Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

Alright. If the real goal with the $edgSources settings for #get_web_data and #get_soap_data is to avoid overloading the outside service, maybe a better ID to use is the domain of the website rather than the whole URL, e.g. 'worlddata.com' rather than 'http://worlddata.com/api/1234"?

Oct 20 2021, 5:44 PM · MediaWiki-extensions-ExternalData

Oct 19 2021

Yaron_Koren added a comment to T293769: Replacement announced but effectively not done ....

I can't replicate this issue, even with the quotation marks. Maybe the jobs haven't run yet?

Oct 19 2021, 11:07 PM · MediaWiki-extensions-ReplaceText

Oct 18 2021

Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

I'm still not sure about this, but I'm glad we are discussing it further. First of all, I don't think something like $edgSources['throttle key'] is a good idea, because it looks like 'throttle key' is a source ID. (And what if there really is a source ID named 'throttle key'? There probably won't be, but still.) $edgSources['*']['throttle key'] would be better. ('*' makes more sense than 0, I think.)

Oct 18 2021, 11:42 PM · MediaWiki-extensions-ExternalData
Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

Okay, I get it. I was confused by your statement above, "Otherwise, any wikiuser could overload both the wiki and the data source." I think that, even with this proposed change, any user could overload the wiki, and just about any data source, if they really wanted to, at least for a short time, using #get_web_data. (Until their change was reverted, that is.) They could overload the wiki by pointing to some URL (or many URLs, for that matter) that is not in LocalSettings.php; and even for URLs that are in in that $edgSources variable, a user could get around the cache restrictions by slightly changing the URL, for example by removing or adding "www." from the URL, etc.

Oct 18 2021, 6:41 PM · MediaWiki-extensions-ExternalData
Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

Sorry for the delay. Thinking about it again now, I'm still not sure I understand this proposal. Would this new variable be used for #get_web_data as well? If so, what would be the value for "data source name" for #get_web_data calls? Would #get_web_data (and #get_soap_data) switch to using IDs, like the other functions do? And if so, doesn't $edgSources require parameters like "URL" and "Format"?

Oct 18 2021, 3:47 PM · MediaWiki-extensions-ExternalData
Yaron_Koren added a comment to T233914: Allow hiding columns on Special:MultiPageEdit to make the view clearer.

That's great! I'm looking forward to having this feature again.

Oct 18 2021, 1:46 PM · MediaWiki-extensions-Page_Forms

Oct 17 2021

Yaron_Koren added a comment to T289616: Redesign ExternalData configuration settings storing secrets.

I do like minimizing the number of variables, but this may be going too far. I still think it makes sense to have a separate variable for each source type (although I guess two for local files, one for files and one for directories). And I think LocalSettings.php should only hold settings that can't be set from the wiki, i.e. that need to be reserved for administrators. I don't think it make sense to set "use stale cache", for instance, in LocalSettings.php. (Unless it's a sitewide default setting - but that's different from a per-connection setting.) If it can be set from the wiki, i.e. from a parser function like #get_web_data or a Lua call, then it's better to do that, to allow for more flexibility.

Oct 17 2021, 1:20 AM · MediaWiki-extensions-ExternalData

Oct 15 2021

Yaron_Koren committed rEDPT4f3f66c52446: Fix for fragments leading to blank links (authored by Yaron_Koren).
Fix for fragments leading to blank links
Oct 15 2021, 9:59 PM