Page MenuHomePhabricator

Yaron_Koren (Yaron Koren)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 14 2014, 3:01 AM (264 w, 2 d)
Availability
Available
LDAP User
Yaron Koren
MediaWiki User
Unknown

Recent Activity

Wed, Dec 4

Yaron_Koren committed rEPFM0f927ee8b573: Fix for 7865d640d86b - better HTML layout (authored by Yaron_Koren).
Fix for 7865d640d86b - better HTML layout
Wed, Dec 4, 4:50 AM

Tue, Dec 3

Yaron_Koren changed the status of T238397: PageForms: On a mandatory field, if null is passed as cur_value to PFRadioButtonInput::getHTML(), "None" should not be an option from Declined to Resolved.

In a rare move, I'm changing this bug from "Declined" to "Resolved"! We didn't talk much about the stated subject of this bug report here, but we did talk about it elsewhere, and I was convinced to remove "None" and simply make all the radiobutton options unselected for a mandatory field, which I did here: fd34992e34a2

Tue, Dec 3, 10:19 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren committed rEPFMfd34992e34a2: Remove "None" option for mandatory radiobuttons (authored by Yaron_Koren).
Remove "None" option for mandatory radiobuttons
Tue, Dec 3, 9:53 PM
Yaron_Koren committed rEPFM284f657f1ef9: i18n-ify the error message for $wgPageFormsAutoeditNamespaces (authored by MarkAHershberger).
i18n-ify the error message for $wgPageFormsAutoeditNamespaces
Tue, Dec 3, 6:29 PM
Yaron_Koren closed T231310: ApprovedRevs should have approve latest link on approval lists as Declined.

I'm marking this as "Declined", and after some private discussion, I think Krabina is okay with that decision. The reason I'm declining this request is that, for pages whose approved revision is not their latest, the admin presumably should first look at the difference between the two before deciding whether to approve the latest revision - so the "approve" link should be on the diff page (where it is already), not on Special:ApprovedRevs.

Tue, Dec 3, 6:07 PM · MediaWiki-extensions-Approved-Revs
Yaron_Koren added a comment to T236628: ArticleRevisionViewCustom hook is unusable.

I just updated Approved Revs to use the ArticleRevisionViewCustom hook for new-ish versions of MediaWiki. I plan to do the same thing for my (still-unreleased) diagrams extension.

Tue, Dec 3, 4:45 AM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MW-1.32-notes, MW-1.33-notes, Multi-Content-Revisions
Yaron_Koren closed T186646: ApprovedRevs should show the page approver on the page itself as Resolved.

I guess this was done...

Tue, Dec 3, 3:33 AM · MediaWiki-extensions-Approved-Revs
Yaron_Koren closed T207849: add exposed JS wgRevisionId as a magic word as Declined.

Marking this as "Declined"... I hope that's okay.

Tue, Dec 3, 3:33 AM · MediaWiki-extensions-Approved-Revs
Yaron_Koren closed T216010: "Call to a member function getContentHandler() on null" in ApprovedRevs.hooks.php as Resolved.

This was fixed in 1dd2b204755e, about a month after this bug was reported.

Tue, Dec 3, 3:31 AM · MediaWiki-extensions-Approved-Revs
Yaron_Koren closed T218693: Add --latest option to approveAllPages.php as Resolved.

This was done, though with the flag renamed to "--force".

Tue, Dec 3, 3:28 AM · MediaWiki-extensions-Approved-Revs
Yaron_Koren closed T227801: ApprovedRevs: indexing current state as Resolved.

Closing this; feel free to re-open...

Tue, Dec 3, 3:27 AM · MediaWiki-extensions-Approved-Revs
Yaron_Koren closed T239184: Approved Revs extension uses deprecated hook ArticleAfterFetchContentObject (cause CI builds to fail) as Resolved.

@hashar - okay, thanks, that was very helpful. I knew about the changeover to ArticleRevisionViewCustom (I actually created the mediawiki.org page for that hook!), but I wasn't expecting that change to Jenkins behavior. Anyway, I just checked in a fix for this to Approved Revs.

Tue, Dec 3, 3:26 AM · ci-test-error, MediaWiki-extensions-Approved-Revs

Mon, Dec 2

Yaron_Koren closed T239525: Do not echo the message externaldata-db-could-not-get-url as Resolved.

@alex-mashin, @DannyS712 - thank you!

Mon, Dec 2, 6:23 PM · User-DannyS712, MediaWiki-extensions-ExternalData
Yaron_Koren added a comment to T239506: External Data: automatically create the table ed_url_cache on running update.php.

@alex-mashin: I've been thinking about this patch. It seems well-constructed; I'm just not sure that it's a good idea to create this caching table automatically. As far as I know, most usages of External Data don't need it - there are wikis that don't use #get_web_data at all, and of the ones that do, I think most hit APIs where server downtime is not a big issue. That's my assumption anyway, just judging by the relatively few questions I've gotten about caching. But maybe you have a different perspective. What do you think?

Mon, Dec 2, 2:31 PM · Patch-For-Review, MediaWiki-extensions-ExternalData
Yaron_Koren renamed T239506: External Data: automatically create the table ed_url_cache on running update.php from Sort out sql/ExternalData.sql to External Data: automatically create the table ed_url_cache on running update.php.
Mon, Dec 2, 2:27 PM · Patch-For-Review, MediaWiki-extensions-ExternalData

Sun, Dec 1

Yaron_Koren added a comment to T239512: Allow use of stale cache in {{#get_web_data:}}.

By the way - I think it makes sense to split up this patch into at least two, maybe even three patches. There are a lot of changes there that are unrelated to the topic of the patch, which is using a stale cache - the biggest set are the ones where array() is changed into []. That's a useful change, but it would be clearer if it were in a separate patch.

Sun, Dec 1, 4:19 PM · Patch-For-Review, MediaWiki-extensions-ExternalData
Yaron_Koren committed rEMDOb37123a6ddd3: Add license information for Extension:MintyDocs (authored by jeropbrenda).
Add license information for Extension:MintyDocs
Sun, Dec 1, 3:22 PM

Tue, Nov 26

Yaron_Koren committed rEPFM26c1cc73a049: Drop use of $wgParser for MW >= 1.29 (authored by MarkAHershberger).
Drop use of $wgParser for MW >= 1.29
Tue, Nov 26, 9:27 PM
Yaron_Koren created T239184: Approved Revs extension uses deprecated hook ArticleAfterFetchContentObject (cause CI builds to fail).
Tue, Nov 26, 4:41 AM · ci-test-error, MediaWiki-extensions-Approved-Revs

Mon, Nov 25

Yaron_Koren added a comment to T137701: Fix default value for field tag, for existing and new pages..

Yes, I'm talking about both of those comments. For the refactoring - it may be good, but, as I said, (a) it's outside the scope of this bug fix, and (b) I'm not sure that this kind of partial refactor is better than no refactor at all.

Mon, Nov 25, 9:42 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms
Yaron_Koren closed T238806: PageForms: "Select a form..." shown for action=formedit when no forms are available as Resolved.

I decided to go with a more comprehensive solution, which displays an error, or otherwise handles things, in other cases when a list of forms is supposed to be displayed (like #forminput). Hopefully this solution makes sense...

Mon, Nov 25, 3:38 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren committed rEPFMc5d26e884ae8: Add error messages when no forms have been defined (authored by Yaron_Koren).
Add error messages when no forms have been defined
Mon, Nov 25, 3:29 PM

Sun, Nov 24

Yaron_Koren closed T239023: wikieditor is not loaded when using the editor=wikieditor option in texarea fiels on MediaWiki 1.33.1 as Resolved.

Thank you for this patch! It looks great.

Sun, Nov 24, 11:34 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren committed rEPFM55c46ed95724: Fix for wikieditor not being loaded on MediaWiki 1.33 (authored by Tombolano).
Fix for wikieditor not being loaded on MediaWiki 1.33
Sun, Nov 24, 9:26 PM
Yaron_Koren added a comment to T239023: wikieditor is not loaded when using the editor=wikieditor option in texarea fiels on MediaWiki 1.33.1.

@Tombolano - thank you for this fix. Is this backward-compatible? Page Forms is still meant to support MediaWiki (and thus WikiEditor) versions going back to 1.28.

Sun, Nov 24, 5:46 PM · MediaWiki-extensions-Page_Forms

Fri, Nov 22

Yaron_Koren added a comment to T137701: Fix default value for field tag, for existing and new pages..

Oh, that's interesting - I never thought to check the W3C standard.

Fri, Nov 22, 10:02 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T137701: Fix default value for field tag, for existing and new pages..

I don't understand what you mean by "if a problem is reported, fix it". What would the fix be?

Fri, Nov 22, 8:30 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T137701: Fix default value for field tag, for existing and new pages..

Okay, I think I get it - it sounds like what you're talking about now is just leaving the radiobutton unselected, as opposed to having a "None" value. Which is sort of an aesthetic issue, unrelated to whether there's a default value, although it's still potentially an improvement.

Fri, Nov 22, 4:51 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms
Yaron_Koren closed T233914: Allow hiding columns on Special:MultiPageEdit to make the view clearer as Resolved.

@Nicolas_NALLET - that's a good idea, and I just checked in some code that is meant to do this - if there are 7 or more columns, little "x"s show up for each column header that let you remove it from the spreadsheet. It would be great if you tried the latest Page Forms code, and let me know what you think. I'm marking this as "Resolved", but feel free to re-open if there is a problem.

Fri, Nov 22, 4:27 AM · MediaWiki-extensions-Page_Forms
Yaron_Koren committed rEPFM9f5fc7587c2b: Allow dynamic hiding of columns in Special:MultiPageEdit (authored by Yaron_Koren).
Allow dynamic hiding of columns in Special:MultiPageEdit
Fri, Nov 22, 4:16 AM
Yaron_Koren added a comment to T137701: Fix default value for field tag, for existing and new pages..

I'm confused about the first thing you wrote - "Even if we posit that you are correct". Correct that the default value should not be used when editing existing pages? Because that seems to be the entire underlying issue.

Fri, Nov 22, 2:45 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Thu, Nov 21

Yaron_Koren added a comment to T137701: Fix default value for field tag, for existing and new pages..

Oh, yes, that's true - there's no "restricted" parameter in the field tag. I got confused because the commit message for the patch talks about restricted fields.

Thu, Nov 21, 2:17 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T137701: Fix default value for field tag, for existing and new pages..

Alright, thanks. I haven't run the import, but I think I see the issue. The problem comes about when:

Thu, Nov 21, 3:33 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T238806: PageForms: "Select a form..." shown for action=formedit when no forms are available.

I never thought about that case... maybe it would be better to show an error message, like "No forms have been defined on this wiki", so it's clearer what's going on?

Thu, Nov 21, 2:22 AM · MediaWiki-extensions-Page_Forms

Wed, Nov 20

Yaron_Koren committed rEPFMe811db45776e: Add VE textareas to inputs displayed during instance minimization (authored by Yaron_Koren).
Add VE textareas to inputs displayed during instance minimization
Wed, Nov 20, 7:29 PM

Mon, Nov 18

Yaron_Koren committed rEPFM2d46cc7441d1: Avoid some jQuery 3 warnings (authored by Yaron_Koren).
Avoid some jQuery 3 warnings
Mon, Nov 18, 6:36 PM
Yaron_Koren closed T221360: Make SimpleUpload working again - with solution as Resolved.

@Filburt - sorry for the long delay, and thank you for the fix!

Mon, Nov 18, 4:03 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren committed rEPFM280811a11f7e: Fix for "simple upload" for more recent MW versions (authored by Yaron_Koren).
Fix for "simple upload" for more recent MW versions
Mon, Nov 18, 4:01 PM
Yaron_Koren closed T238397: PageForms: On a mandatory field, if null is passed as cur_value to PFRadioButtonInput::getHTML(), "None" should not be an option as Declined.

Marking this as "Declined", although of course I'm grateful for the new tests. If you still want to talk about the original topic, feel free to re-open this.

Mon, Nov 18, 3:32 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren committed rEPFM43051ed6ba50: Fix for map display in multiple-instance templates (authored by Yaron_Koren).
Fix for map display in multiple-instance templates
Mon, Nov 18, 2:48 PM

Sun, Nov 17

Yaron_Koren added a comment to T238397: PageForms: On a mandatory field, if null is passed as cur_value to PFRadioButtonInput::getHTML(), "None" should not be an option.

Great, thank you!! Unit tests such as these are a big step in bringing Page Forms to the next level.

Sun, Nov 17, 5:15 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren committed rEPFMb201fd4d0f08: Add suite of RadioButton tests (authored by MarkAHershberger).
Add suite of RadioButton tests
Sun, Nov 17, 5:14 PM

Fri, Nov 15

Yaron_Koren added a comment to T238397: PageForms: On a mandatory field, if null is passed as cur_value to PFRadioButtonInput::getHTML(), "None" should not be an option.

Great - I'm looking forward to checking in the additional tests. Page Forms could really use more tests!

Fri, Nov 15, 9:23 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T238397: PageForms: On a mandatory field, if null is passed as cur_value to PFRadioButtonInput::getHTML(), "None" should not be an option.

Well, it's true that "None" is not valid, but I believe (and hope!) that the JS prevents the form from being submitted if that invalid value is chosen.

Fri, Nov 15, 7:04 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T238397: PageForms: On a mandatory field, if null is passed as cur_value to PFRadioButtonInput::getHTML(), "None" should not be an option.

Right, this issue has come up before. You probably saw it in the code, but the current logic is that the "None" value is only removed when the field is mandatory *and* it has a default value. (I think the same approach is used for the "dropdown" input.) The thinking there is that, when a new page is being created, we don't want the form to accidentally dictate a value for that field when the user hasn't consciously selected one. I think the current behavior is that, if it's a mandatory field (with no default value) and the user keeps the field selection at "None", when the user goes to submit the form the JavaScript kicks in and tells them they have to select a value.

Fri, Nov 15, 2:43 PM · MediaWiki-extensions-Page_Forms

Thu, Nov 14

Yaron_Koren committed rEPFM6883c309a061: Add $wgPageFormsShowExpandAllLink (authored by Yaron_Koren).
Add $wgPageFormsShowExpandAllLink
Thu, Nov 14, 10:43 PM

Wed, Nov 13

Yaron_Koren renamed T192752: Convert Page Forms to use OOUI from Convert Extension:Page_Forms to use OOUI to Convert Page Forms to use OOUI.
Wed, Nov 13, 3:37 AM · UI-Standardization, MediaWiki-extensions-Page_Forms

Mon, Nov 11

Yaron_Koren added a comment to T149869: Security review for PageForms.

@Bawolff - well, it's been a long time. But I just checked in a change that I think fixes the 4th major security issue listed, the one that starts with "<div data-bar". The change can be found here:

Mon, Nov 11, 9:42 PM · Security, MediaWiki-extensions-Page_Forms, Security-Team-Reviews
Yaron_Koren committed rEPFM7865d640d86b: Security improvements for form parsing (authored by Yaron_Koren).
Security improvements for form parsing
Mon, Nov 11, 8:53 PM
Yaron_Koren committed rEPFM3828ee974b0e: PF_jsGrid.js - call toLowerCase() only on string values (authored by Yaron_Koren).
PF_jsGrid.js - call toLowerCase() only on string values
Mon, Nov 11, 7:01 PM

Sun, Nov 10

Yaron_Koren added a comment to T231665: PageForms: Drop support for PHP 5.3.

I finally removed support for MW < 1.28 from Page Forms a few days ago, so now you could say that Page Forms no longer supports PHP 5.3 by proxy. (Actually, it no longer supports any version of PHP below 5.5.9, for the same reason.) But what was this request specifically for - replacing "array()" with "[]"?

Sun, Nov 10, 4:14 PM · MediaWiki-extensions-Page_Forms

Nov 8 2019

Yaron_Koren committed rEPFM3a1fdb3f540b: Remove support for MW < 1.28 (authored by Yaron_Koren).
Remove support for MW < 1.28
Nov 8 2019, 2:31 AM

Nov 4 2019

Yaron_Koren committed rEPFMfbfa6a4ae19e: Set removeDuplicates = true for PFCreatePageJob (authored by Pastakhov).
Set removeDuplicates = true for PFCreatePageJob
Nov 4 2019, 10:17 PM
Yaron_Koren committed rEPFMe3ef0f341fdb: Another attempted fix for URLs in Special:RunQuery (authored by Yaron_Koren).
Another attempted fix for URLs in Special:RunQuery
Nov 4 2019, 9:09 PM

Oct 31 2019

Yaron_Koren committed rETMC358969eaa712: fixes for handling <pre> tags and tables (authored by aoxomoxoa).
fixes for handling <pre> tags and tables
Oct 31 2019, 8:21 PM

Oct 28 2019

Yaron_Koren added a comment to T236628: ArticleRevisionViewCustom hook is unusable.

@Tgr - thanks, that's helpful. It's great to know that everything I need can be accomplished with this new hook. I submitted a patch for the DifferenceEngine.php bug here:

Oct 28 2019, 3:22 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MW-1.32-notes, MW-1.33-notes, Multi-Content-Revisions
Yaron_Koren added a comment to T236604: Input type 'leaflet' permits entry of longitude beyond ±180°.

@Samwilson - thanks for the fix!

Oct 28 2019, 2:20 PM · Wikimedia Australia, MediaWiki-extensions-Page_Forms
Yaron_Koren committed rEPFM41e0c198a3fb: Prevent Leaflet markers from being outside -180° to 180°. (authored by Samwilson).
Prevent Leaflet markers from being outside -180° to 180°.
Oct 28 2019, 2:18 PM
Yaron_Koren added a comment to T236628: ArticleRevisionViewCustom hook is unusable.

Alright, I'll submit a patch for that DifferenceEngine.php bug.

Oct 28 2019, 4:53 AM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MW-1.32-notes, MW-1.33-notes, Multi-Content-Revisions

Oct 27 2019

Yaron_Koren created T236628: ArticleRevisionViewCustom hook is unusable.
Oct 27 2019, 6:15 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MW-1.32-notes, MW-1.33-notes, Multi-Content-Revisions

Oct 24 2019

Yaron_Koren committed rEPFM09652a9392df: Add "loading mask" to prevent clicking during form load (authored by Yaron_Koren).
Add "loading mask" to prevent clicking during form load
Oct 24 2019, 6:41 PM

Oct 23 2019

Yaron_Koren committed rEPFMd72c7ba6aa45: Fix for 2561599c90e1 (authored by Yaron_Koren).
Fix for 2561599c90e1
Oct 23 2019, 3:26 PM

Oct 17 2019

Yaron_Koren closed T189019: since 3b702fe, list fields can cause sql to break as Resolved.

Setting to "Resolved" - feel free to re-open if this is still an issue.

Oct 17 2019, 2:01 AM · MediaWiki-extensions-Cargo
Yaron_Koren closed T230303: Data in Cargo table is not the approved ones as Resolved.

I'm guessing that this has been fixed with Approved Revs 1.2... feel free to re-open if not.

Oct 17 2019, 2:00 AM · MediaWiki-extensions-Cargo
Yaron_Koren closed T235310: More results link fails if group-by clause contains exactly one identifier as Resolved.

Sorry about the problem, and thanks for the fix! I'm assuming all of this works now.

Oct 17 2019, 1:57 AM · MediaWiki-extensions-Cargo

Oct 16 2019

Yaron_Koren committed rEPFM93a9cd3891b1: Fixes for "save and continue", VE for asynchronous JS loading (authored by Yaron_Koren).
Fixes for "save and continue", VE for asynchronous JS loading
Oct 16 2019, 6:27 PM

Oct 14 2019

Yaron_Koren committed rEPFM8350fbdeb571: Error check for bad form definition formatting (authored by Yaron_Koren).
Error check for bad form definition formatting
Oct 14 2019, 6:30 PM
Yaron_Koren committed rEPFMdfa647648e6a: jQuery fix - removeAttr() should not be called for boolean attributes (authored by Yaron_Koren).
jQuery fix - removeAttr() should not be called for boolean attributes
Oct 14 2019, 2:58 PM
Yaron_Koren committed rEPFMdd5f18fc5e71: fix issue to allow unclosed singles brackets ( { or [ ) in pages (authored by Pyro853).
fix issue to allow unclosed singles brackets ( { or [ ) in pages
Oct 14 2019, 2:14 PM
Yaron_Koren closed T216805: [PageForms] Loading form input JS libraries (like datepicker) fix doesn't work as Resolved.

Fixed now, I guess? Thanks for the patch, and sorry for the delay!

Oct 14 2019, 1:17 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms
Yaron_Koren committed rEPFM8da34231e015: Don't stop spinner before form rendering is completed (authored by MarkAHershberger).
Don't stop spinner before form rendering is completed
Oct 14 2019, 2:52 AM

Oct 10 2019

Yaron_Koren committed rETMC820277c74b85: Fix to wikicode for internal links with spaces (authored by aoxomoxoa).
Fix to wikicode for internal links with spaces
Oct 10 2019, 12:46 PM

Oct 8 2019

Yaron_Koren committed rETMC6b768940090b: Fix to upload to remove namespace from filename (authored by aoxomoxoa).
Fix to upload to remove namespace from filename
Oct 8 2019, 10:01 PM
Yaron_Koren committed rEPFM0e0ac50cf153: Changes to multi-instance templates CSS (authored by Yaron_Koren).
Changes to multi-instance templates CSS
Oct 8 2019, 5:14 PM
Yaron_Koren committed rEPFMaacabb11ca24: Fix the form preview display (authored by Pastakhov).
Fix the form preview display
Oct 8 2019, 3:01 AM

Oct 7 2019

Yaron_Koren committed rEPFMbfc219356e56: Add some images (authored by Paladox).
Add some images
Oct 7 2019, 8:21 PM

Oct 3 2019

Yaron_Koren committed rEVFA3032e349e351: Fix for handling title when called from Page Forms (authored by Yaron_Koren).
Fix for handling title when called from Page Forms
Oct 3 2019, 8:11 PM
Yaron_Koren committed rEPFM7bdac7e9c9d9: Add $wgPageFormsTargetName global variable (authored by Yaron_Koren).
Add $wgPageFormsTargetName global variable
Oct 3 2019, 7:11 PM

Oct 2 2019

Yaron_Koren closed T232825: When the field is marked as optional the #if call doesn't have two closing curly brackets as Resolved.

@KatkovYury - sorry for the long delay. This was actually a Page Forms bug. I believe it's fixed now, though I can't test it because it only happens when SMW is installed. I'm setting the bug to "Resolved" - please re-open it if the fix didn't actually work.

Oct 2 2019, 4:50 PM · MediaWiki-extensions-PageSchemas
Yaron_Koren committed rEPFM28104f94bda0: Fix for template creation with Page Schemas + SMW (T232825) (authored by Yaron_Koren).
Fix for template creation with Page Schemas + SMW (T232825)
Oct 2 2019, 4:44 PM
Yaron_Koren committed rEPFMa111b6e07f02: Change Parser::Title() to Parser::setTitle() - fix for MW 1.34 (authored by Yaron_Koren).
Change Parser::Title() to Parser::setTitle() - fix for MW 1.34
Oct 2 2019, 4:27 PM

Sep 30 2019

Yaron_Koren added a comment to T202246: AdminLinks::makelink() doesn't HTML escape properly.

Sure.

Sep 30 2019, 8:44 PM · MediaWiki-extensions-Approved-Revs, MediaWiki-extensions-AdminLinks, Security
Yaron_Koren added a comment to T202246: AdminLinks::makelink() doesn't HTML escape properly.

I forgot to say - thank you, @Legoktm, for your help with improving the security of all three extensions.

Sep 30 2019, 7:05 PM · MediaWiki-extensions-Approved-Revs, MediaWiki-extensions-AdminLinks, Security
Yaron_Koren closed T202246: AdminLinks::makelink() doesn't HTML escape properly as Resolved.

Okay, I believe all three patches are now merged in. In the case of Approved Revs, the code checked in was simpler than the original patch because support for MW < 1.28 was removed, soon after the original patches were created.

Sep 30 2019, 7:04 PM · MediaWiki-extensions-Approved-Revs, MediaWiki-extensions-AdminLinks, Security

Sep 29 2019

Yaron_Koren committed rEADLfb0c02edafdf: Improve link escaping - patch by Legoktm (T202246) (authored by Yaron_Koren).
Improve link escaping - patch by Legoktm (T202246)
Sep 29 2019, 5:01 PM
Yaron_Koren committed rEADL0c6062b53a66: Fix for 00e17c71c248 - formatting fix (authored by Yaron_Koren).
Fix for 00e17c71c248 - formatting fix
Sep 29 2019, 4:19 PM
Yaron_Koren closed T216421: cargoRecreateData line 150 getcontent() on null as Resolved.

That's a good idea - I added in this code in 0069ae1265dc.

Sep 29 2019, 3:48 PM · MediaWiki-extensions-Cargo

Sep 27 2019

Yaron_Koren committed rEPFM4c7e3b5733e9: PageForms: Replace deprecated editToken with csrfToken (authored by TheSandDoctor).
PageForms: Replace deprecated editToken with csrfToken
Sep 27 2019, 3:42 PM
Yaron_Koren committed rEPFMfe77b8d0506a: Add "namespace selector" #forminput param (authored by Yaron_Koren).
Add "namespace selector" #forminput param
Sep 27 2019, 2:52 PM
Yaron_Koren committed rEPFM2561599c90e1: Add hooks: FormInputEnd, TreeNodeDisplay (authored by Yaron_Koren).
Add hooks: FormInputEnd, TreeNodeDisplay
Sep 27 2019, 2:23 PM
Yaron_Koren committed rEPFM95881862023a: implement mapping using translate (authored by Pyro853).
implement mapping using translate
Sep 27 2019, 12:49 PM
Yaron_Koren committed rEPFM5b5806cccbd0: Add translatable behaviour to add translate tags in text inputs (authored by Pyro853).
Add translatable behaviour to add translate tags in text inputs
Sep 27 2019, 12:28 PM
Yaron_Koren edited projects for T202246: AdminLinks::makelink() doesn't HTML escape properly, added: MediaWiki-extensions-Approved-Revs; removed MediaWiki-extensions-Cargo.
Sep 27 2019, 11:35 AM · MediaWiki-extensions-Approved-Revs, MediaWiki-extensions-AdminLinks, Security
Yaron_Koren added a comment to T202246: AdminLinks::makelink() doesn't HTML escape properly.

@Aklapper - sorry for not responding here before. I believe I took care of the Cargo patch with the commits 9b8d3a0a2d10 and 3407fb767040. I still need to take care of the Approved Revs and Admin Links patches.

Sep 27 2019, 11:35 AM · MediaWiki-extensions-Approved-Revs, MediaWiki-extensions-AdminLinks, Security

Sep 11 2019

Yaron_Koren closed T218353: Proposal: Improve the interface of Special:ViewData in the Cargo extension as Resolved.
Sep 11 2019, 11:11 PM · Google-Summer-of-Code (2019)

Sep 9 2019

Yaron_Koren closed T217493: GSoC 2019 Proposal: Page Forms - add an editable calendar interface as Resolved.
Sep 9 2019, 8:54 PM · Patch-For-Review, Google-Summer-of-Code (2019)

Sep 6 2019

Yaron_Koren closed T232127: Deferred display formats fail with cargo_compound_query as Resolved.

Sorry about that! This was a bug from January. I just checked in a fix for it; hopefully it will get to you soon.

Sep 6 2019, 2:15 PM · MediaWiki-extensions-Cargo
Yaron_Koren closed T232116: cargo_compound_query: "group by" and "having" fields are swapped as Resolved.

Wow! It looks like that bug has been in place for a long time. Sorry about that. I just checked in a fix - hopefully it will get to you soon.

Sep 6 2019, 12:21 AM · MediaWiki-extensions-Cargo

Sep 5 2019

Yaron_Koren added a comment to T231958: PageForms: Hidden mandatory fields without defaults can keep the user from submitting the form without any error message.

That seems like the right approach, yes. I think someone else made that request too recently, but I can't remember where. Hopefully this is easy to do.

Sep 5 2019, 6:00 PM · MediaWiki-extensions-Page_Forms

Sep 4 2019

Yaron_Koren added a comment to T231957: PageForms: Should allow user to submit a form if there are restricted mandantory fields without defaults that the user cannot fill.

I should probably know this, but how do you restrict an entire form?

Sep 4 2019, 4:37 PM · MediaWiki-extensions-Page_Forms