Good point - I didn't think about that. I just checked in what I think is a fix for this.
Tue, Aug 20
Oh! That's good to know in general, outside of this bug. And @Darenwelsh - thanks for translating between the two bug reports. :) I'm back to having no idea - I think someone will have to go into the code and see exactly what's happening.
Thinking about this again, I still think that this is somehow due to $smwgEnabledCompatibilityMode, if only because I haven't heard of this problem outside of that variable. Maybe this variable is not being handled correctly in recent versions of SMW?
Mon, Aug 19
Okay, I just checked in a modified version of this patch, at 8c75f7b5aad5 . Sorry, @Rcdeboer - I forgot to credit you when I checked in the code. But I definitely thank you. This code is working a lot better for me - if there are still any issues, with SMW data or anything else, maybe it should go into a separate bug/task.
Oh. I don't know, then.
It's not a bug, it's a "feature". A very strange feature - SMW shuts itself off if Cargo is installed on the wiki, unless the following is added to LocalSettings.php:
Fri, Aug 16
There's no difference in terms of pull/push between DPL and the rest - the only difference is that Cargo and SMW are querying their own database tables, while DPL queries core MediaWiki database tables.
Thu, Aug 15
Tue, Aug 13
Oh, I didn't realize (or forgot) that you work together, and that "we" thus included him. I guess I'll have to look into this, then...
Mon, Aug 12
@Rcdeboer - what's the status of the patch? Are you still working on it?
I believe this is an Approved Revs issue - and the one already covered in T227801. That one is waiting for a patch from someone else - I need to see what the status is of it.
Wed, Aug 7
I'm still waiting for @Rcdeboer's full patch. Or is there something I can do already?
Tue, Aug 6
Sorry for the delay in responding. I believe the "placeholder" parameter has been supported for section tags for a long time, but it just wasn't listed in the documentation. I just added it to the documentation - sorry about that.
Mon, Aug 5
Sorry for the delay. I don't understand this request - what is that you want to do, that can't be done already?
Fri, Aug 2
What's the page, and how are you associating it with a form?
Fri, Jul 26
@dlo - thanks for the patch! I added it to the code; hopefully Cargo works well with SQLite now...
Wed, Jul 24
Jul 16 2019
Oh, okay. That's too bad.
Oh, okay - I knew about that "compatibility policy" parameter, but never went through all of my extensions' pages to make sure it's there. I just added "compatibility policy=master" to the Page Forms extension's main page. (The compatibility policy is "master" for all of my extensions.)
Unfortunately, phan will complain about undefined classes if SMW is not installed in the test environment,
@Daimona - thanks for putting this together, and of course for your work on the actual patch, which looks like it will make a lot of improvements to the code. Just to clarify one thing: Page Forms doesn't require Semantic MediaWiki, and is often used without SMW, so SMW doesn't need to be loaded for any testing.
@Nikerabbit - thanks for that explanation. Some of these tasks, there are already plans to implement, like adding in more tests. I'd say more, but I don't know if a closed bug report is the best place to have this kind of discussion. :)
Hi - I don't know if this is a good title for this task either, since, whatever you think of Page Forms' current compatibility policy, it is clearly stated on the extension's main wiki page, where it says that "MW 1.23+" is supported:
Jul 15 2019
Would it make sense, then, to rename this to something like "Add phan to Page Forms"?
Sorry about the problem! I fixed this in 59c1d49f8d43.
@Nikerabbit - what do you mean by that?
Is this a task, or what?
Jul 12 2019
Great. I didn't know about the SecondaryDataUpdates hook! I'm reading about it now - it looks like it was deprecated in March 2018, in favor of the RevisionDataUpdates hook:
That's great to hear!
Jul 9 2019
Jul 8 2019
I just checked in a patch based on this one (at 82039d9d661c), though first making some changes to the autocompletion code, to eliminate the code duplication that your patch reminded me about. Thanks!
Jul 5 2019
I don't know the right way to mark a bug as a duplicate, but anyway, this is a duplicate of T225685.
Jul 1 2019
@Kghbln - thanks for including me; no, I didn't see this before. I just checked in what I think is a fix for this.
Jun 30 2019
I was hoping to get confirmation that the fix actually works, but sure - no need to draw out this discussion any more. Feel free to re-open if this still an issue, of course.
Jun 27 2019
Thank you for debugging the problem and finding the fix! I just checked in your suggested change.
Okay, I just checked in a fix for this. It's different from what you have, but hopefully it works!
Jun 25 2019
Jun 21 2019
Jun 20 2019
Jun 18 2019
Jun 17 2019
I'm happy to upgrade to DB_REPLICA in Page Forms and all of my other extensions - I just want to preserve backward compatibility. Thankfully there's a pretty easy way to do that. I just modified the Page Forms patch to add changes to PageForms.php and PF_Hooks.php to do this.
Jun 10 2019
I have now also released a new version of Cargo. Closing this bug.
Jun 9 2019
And yes, I should release a new version of Cargo, with all the bug fixes from the last few months...
Sorry - I meant to say "LIKE", not "HOLDS". But "MATCHES" is probably an even better idea.
Jun 7 2019
Sorry about the first problem - I just checked in what I think is a fix for it.
Sorry about that; I just checked in what I think is a fix for the problem.
Jun 6 2019
Also, what's a page where I can see this happening?
Do you know why this problem is showing up now? Was there a recent upgrade of Page Forms or MediaWiki? That particular code hasn't changed in a long time.
Jun 5 2019
Jun 4 2019
Okay, I just released a new version of PF, so I think this bug report can be closed. Sorry about the problem.
Jun 3 2019
Fixed, I think.
I think this was fixed on March 30 - I should release a new version.