Page MenuHomePhabricator

aaron (Aaron Schulz)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 20 2014, 5:25 PM (243 w, 1 d)
Availability
Available
IRC Nick
AaronSchulz
LDAP User
Aaron Schulz
MediaWiki User
Aaron Schulz [ Global Accounts ]

Recent Activity

Yesterday

aaron claimed T224422: Implement logic to filter bogus GTIDs.
Tue, Jun 18, 3:36 PM · Patch-For-Review, Performance-Team, Core Platform Team Backlog (Watching / External), Services (watching), Core Platform Team (Multi-DC (TEC1)), MediaWiki-Database
aaron closed T191668: Define varargs in \IDatabase::buildLike() in a way phan can understand it as Resolved.
Tue, Jun 18, 3:28 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), phan, Performance-Team, Wikimedia-production-error (Shared Build Failure), MediaWiki-Database
aaron updated the task description for T215740: Create Icinga check for ArcLamp (xenon-log) service health.
Tue, Jun 18, 10:09 AM · observability, Wikimedia-Incident, Performance-Team

Mon, Jun 17

aaron updated the task description for T225968: Per component/extension profiling of hooks and pre-send DeferredUpdates with Grafana dashboards.
Mon, Jun 17, 8:37 PM · Performance-Team
aaron created T225969: Per template/module profiling with Grafana dashboards.
Mon, Jun 17, 8:36 PM · Performance-Team
aaron created T225968: Per component/extension profiling of hooks and pre-send DeferredUpdates with Grafana dashboards.
Mon, Jun 17, 8:33 PM · Performance-Team
aaron added a comment to T225775: Investigate purging expired watchlist items as a result of .

I assume a mixture of opportunistic (limited row count) purging of rows during existing watchlist row changes along with WHERE clause filtering on SELECT to ignore expired rows would work (e.g. similar to blocks and page protections).

Mon, Jun 17, 8:10 PM · Performance-Team (Radar), Community-Tech
aaron created T225961: Add wiki group breakdown of backend save timing to grafana.
Mon, Jun 17, 5:14 PM · Performance-Team
aaron created T225957: Investigate front end saving timing regression starting April 20, 2019.
Mon, Jun 17, 4:59 PM · Performance-Team
aaron closed T220470: Investigate backend save timing regression starting at 2019-04-08 19:15:00 as Resolved.

This was likely due to an APC change. Filing a separate task for the 4/20 group 2 regression (which seems out of band for deployments).

Mon, Jun 17, 4:56 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Page-editing, Performance-Team
aaron added a comment to T208934: mcrouter does not remove a memcached shard from consistent hashing when timeouts happen.

Some sort of meeting sounds reasonable.

Mon, Jun 17, 8:20 AM · Performance-Team (Radar), User-Elukey, MediaWiki-Cache, Operations

Sun, Jun 16

aaron committed rEATHb77da7a5a465: Use DB_REPLICA instead of DB_SLAVE (authored by aaron).
Use DB_REPLICA instead of DB_SLAVE
Sun, Jun 16, 10:37 PM
aaron committed rEPSO4c96ab681cac: Use DB_REPLICA instead of DB_SLAVE (authored by aaron).
Use DB_REPLICA instead of DB_SLAVE
Sun, Jun 16, 10:04 AM
aaron committed rERPGf708bfd186dd: Use DB_REPLICA instead of DB_SLAVE (authored by aaron).
Use DB_REPLICA instead of DB_SLAVE
Sun, Jun 16, 9:49 AM
aaron committed rEPFM63b6b46496c7: Use DB_REPLICA instead of DB_SLAVE (authored by aaron).
Use DB_REPLICA instead of DB_SLAVE
Sun, Jun 16, 9:49 AM
aaron committed rEGCN69a6b334fcbe: Use DB_REPLICA instead of DB_SLAVE (authored by aaron).
Use DB_REPLICA instead of DB_SLAVE
Sun, Jun 16, 9:39 AM
aaron committed rETMC3cb997180f3d: Use DB_REPLICA instead of DB_SLAVE (authored by aaron).
Use DB_REPLICA instead of DB_SLAVE
Sun, Jun 16, 9:27 AM
aaron committed rEMDO28eb7bdad600: Use DB_REPLICA instead of DB_SLAVE (authored by aaron).
Use DB_REPLICA instead of DB_SLAVE
Sun, Jun 16, 9:24 AM
aaron committed rEDBE2405e0077ff5: Use DB_REPLICA instead of DB_SLAVE (authored by aaron).
Use DB_REPLICA instead of DB_SLAVE
Sun, Jun 16, 9:21 AM
aaron committed rEENF5c936a96c0a1: Use DB_REPLICA instead of DB_SLAVE (authored by aaron).
Use DB_REPLICA instead of DB_SLAVE
Sun, Jun 16, 9:20 AM
aaron committed rEATH6dcd3c7e8d1c: Use DB_REPLICA instead of DB_SLAVE (authored by aaron).
Use DB_REPLICA instead of DB_SLAVE
Sun, Jun 16, 9:14 AM

Sat, Jun 15

aaron committed rEATHb2c5bbd278b2: Use DB_REPLICA instead of DB_SLAVE (authored by aaron).
Use DB_REPLICA instead of DB_SLAVE
Sat, Jun 15, 7:25 PM

Fri, Jun 14

aaron closed T204742: Unable to store parser output in StashEdit (Memcached error: ITEM TOO BIG) as Resolved.
Fri, Jun 14, 11:52 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Performance-Team, MediaWiki-Page-editing, Patch-For-Review, User-Elukey, Regression, Wikimedia-production-error

Thu, Jun 13

aaron added a comment to T225719: HashRingTest::testHashRingKetamaMode takes 3+ seconds.

I assume the slow part would be $ketama_test( 1e5 ). It could probably use 1e4 if there is a speed problem.

Thu, Jun 13, 5:11 PM · MW-1.32-notes, MW-1.33-notes, Performance-Team, MediaWiki-JobQueue, MediaWiki-Core-Testing

Wed, Jun 12

aaron added a comment to T203786: Mcrouter periodically reports soft TKOs for mc1029 (was mc1035, mc1022) leading to MW Memcached exceptions.

After the last round of rolling restarts (happened days ago) I didn't see any TKO event related to mc1* shards. The only ones that I can see now, very sporadically, are related connection timeouts related to codfw proxies (causing very little impact but worth to investigate in a separate task).

I think that we reached the end of this infinite task, and we can close it. @Krinkle or @aaron let me know your thoughts :)

Wed, Jun 12, 9:57 AM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Performance-Team (Radar), Wikimedia-production-error, User-Elukey, MediaWiki-Cache, Operations

Fri, Jun 7

aaron closed T220986: [Regression] Increase in APCBagOStuff::get cost as Resolved.

This looks OK again.

Fri, Jun 7, 2:53 PM · MediaWiki-Cache, Performance-Team

Thu, Jun 6

aaron moved T224619: Make perfsite nav visible on mobile from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Thu, Jun 6, 11:41 AM · Performance-Team
aaron moved T224896: Deploy and test WebPageTest agent in Cape Town (early 2020) from Inbox to Backlog: Future Goals on the Performance-Team board.
Thu, Jun 6, 11:41 AM · Performance-Team, WebPageTest
aaron edited projects for T225059: Consider adding per-shard metrics to the prometheus mcrouter exporter, added: Performance-Team (Radar); removed Performance-Team.
Thu, Jun 6, 11:41 AM · Performance-Team (Radar), observability, User-Elukey, Operations
aaron moved T225074: Test usage of igbinary with apcu with MediaWiki from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Thu, Jun 6, 11:40 AM · serviceops, Operations, Performance-Team
aaron claimed T225103: LBFactory destructor causes unexpected exception at shutdown.
Thu, Jun 6, 11:40 AM · MediaWiki-Database, Performance-Team, Wikimedia-production-error
aaron moved T225103: LBFactory destructor causes unexpected exception at shutdown from Inbox to Next in Quarter (FY1819Q4 Apr-Jun) on the Performance-Team board.
Thu, Jun 6, 11:40 AM · MediaWiki-Database, Performance-Team, Wikimedia-production-error
aaron moved T205342: Release performance data on a regular schedule from Backlog: Future Goals to Blocked on the Performance-Team board.
Thu, Jun 6, 11:28 AM · Performance-Team
aaron edited projects for T200709: MediaWiki phpunit databaseless fails, because it's trying to access the database, added: Performance-Team (Radar); removed Performance-Team.
Thu, Jun 6, 11:24 AM · MediaWiki-Core-Testing
aaron moved T113916: Redesign ResourceLoader's file dependency tracking (module_deps) from Backlog: Future Goals to Next in Quarter (FY1819Q4 Apr-Jun) on the Performance-Team board.
Thu, Jun 6, 11:05 AM · Epic, Performance-Team, MediaWiki-ResourceLoader
aaron moved T110353: Audit use of cookies from Backlog: Future Goals to Blocked on the Performance-Team board.
Thu, Jun 6, 11:04 AM · Performance-Team, Epic, Sysadmin-notice, Wikimedia-General-or-Unknown
aaron edited projects for T99060: Create a dashboard of key user-centric metrics, added: Performance-Team (Radar); removed Performance-Team.
Thu, Jun 6, 10:52 AM · Performance-Team (Radar), Product-Analytics
aaron renamed T99060: Create a dashboard of key user-centric metrics from Create a dashboard of key user-centric performance metrics to Create a dashboard of key user-centric metrics.
Thu, Jun 6, 10:51 AM · Performance-Team (Radar), Product-Analytics
aaron moved T68598: mw.loader state of module stuck at "loading" if request was aborted from Backlog: Future Goals to Backlog: Small & Maintenance on the Performance-Team board.
Thu, Jun 6, 10:49 AM · Performance-Team, JavaScript, MediaWiki-ResourceLoader
aaron triaged T221795: Refactor Category::refreshCounts logic to a job and simplify as Low priority.
Thu, Jun 6, 10:45 AM · MediaWiki-Categories, Performance-Team
aaron moved T220811: Test Thumbor OpenCL smart cropping on stat1005 from Backlog: Small & Maintenance to Next in Quarter (FY1819Q4 Apr-Jun) on the Performance-Team board.
Thu, Jun 6, 10:43 AM · User-jijiki, Thumbor, Performance-Team
aaron lowered the priority of T218339: Deprecate and remove mediawiki.RegExp from Normal to Lowest.
Thu, Jun 6, 10:41 AM · MW-1.34-release, patch-welcome, MediaWiki-General-or-Unknown, Performance-Team, Technical-Debt (Deprecation)
aaron triaged T217754: Add FileBackend statsd metrics and a dashboard as Low priority.
Thu, Jun 6, 10:39 AM · observability, media-storage, Performance-Team
aaron triaged T215740: Create Icinga check for ArcLamp (xenon-log) service health as Normal priority.
Thu, Jun 6, 10:34 AM · observability, Wikimedia-Incident, Performance-Team
aaron moved T211220: Update Save Timing grafana dashboards to break down by content model from Backlog: Small & Maintenance to Next in Quarter (FY1819Q4 Apr-Jun) on the Performance-Team board.
Thu, Jun 6, 10:26 AM · Performance-Team
aaron lowered the priority of T202715: "Lock wait timeout exceeded" when a user edits fast (from User::incEditCountImmediate) from Normal to Low.
Thu, Jun 6, 10:19 AM · Performance-Team-publish, Performance-Team, MediaWiki-Page-editing, Commons, Wikimedia-production-error
aaron edited projects for T202252: Lazy loaded images: [Spike, 2hrs] Test out lazy loading images in Chrome, added: Performance-Team (Radar); removed Performance-Team.
Thu, Jun 6, 10:18 AM · Performance-Team (Radar), Browser-Support-Google-Chrome, Multimedia, Readers-Web-Backlog, Spike
aaron triaged T201220: Gather statistics on accesskey usage as Low priority.
Thu, Jun 6, 10:18 AM · MediaWiki-Interface, Performance-Team
aaron triaged T200313: HTTP 500 error for some larger thumbnails of 14MB file File:Lençóis_Maranhenses_2018.jpg on Commons as Low priority.
Thu, Jun 6, 10:09 AM · Performance-Team (Radar), Thumbor, Commons
aaron edited projects for T200313: HTTP 500 error for some larger thumbnails of 14MB file File:Lençóis_Maranhenses_2018.jpg on Commons, added: Performance-Team (Radar); removed Performance-Team.
Thu, Jun 6, 10:09 AM · Performance-Team (Radar), Thumbor, Commons
aaron triaged T200109: Move Arc Lamp code to a Scap-deployed repository as Low priority.
Thu, Jun 6, 10:07 AM · Performance-Team
aaron closed T190936: navtiming.py: When processing metrics, include effectiveConnectionType as a factor, a subtask of T175087: Create a navtiming processor for Prometheus, as Declined.
Thu, Jun 6, 9:58 AM · Performance-Team
aaron closed T190936: navtiming.py: When processing metrics, include effectiveConnectionType as a factor as Declined.

This can be done in the Prometheus migration, but it is already available in Hive and turnilo.

Thu, Jun 6, 9:58 AM · Performance-Team
aaron renamed T190936: navtiming.py: When processing metrics, include effectiveConnectionType as a factor from navtiming.py: When processing metrics, include connectionType as a factor to navtiming.py: When processing metrics, include effectiveConnectionType as a factor.
Thu, Jun 6, 9:56 AM · Performance-Team
aaron triaged T188204: Test and create a WPT Agent on Cloud VPS as Low priority.
Thu, Jun 6, 9:53 AM · WebPageTest, Performance-Team
aaron lowered the priority of T185724: Publish Doxygen for RunningStat library from Normal to Lowest.
Thu, Jun 6, 9:47 AM · patch-welcome, Librarization, Performance-Team, RunningStat, Continuous-Integration-Config
aaron moved T176262: Consider adding mw.loader.preload / OutputPage::preloadModules() from Backlog: Small & Maintenance to Backlog: Future Goals on the Performance-Team board.
Thu, Jun 6, 9:42 AM · Performance-Team, MediaWiki-ResourceLoader
aaron renamed T175708: Add annotations per URL tested in WebPageTest from Add annotations per URL tested in WebPagetest to Add annotations per URL tested in WebPageTest.
Thu, Jun 6, 9:42 AM · WebPageReplay, Performance-Team, WebPageTest
aaron triaged T142542: LoggedOut cookie not set anymore as Lowest priority.
Thu, Jun 6, 9:20 AM · Core Platform Team Backlog (Watching / External), Performance-Team, Regression, MediaWiki-User-login-and-signup
aaron moved T121440: Dedicated post-edit cache busting cookie to prevent stale reads (session consistency) from Backlog: Small & Maintenance to Backlog: Future Goals on the Performance-Team board.
Thu, Jun 6, 8:59 AM · Performance-Team

Wed, Jun 5

aaron created T225074: Test usage of igbinary with apcu with MediaWiki.
Wed, Jun 5, 9:56 AM · serviceops, Operations, Performance-Team

Tue, Jun 4

jcrespo awarded T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: LinksUpdate does not have outer scope a Party Time token.
Tue, Jun 4, 11:52 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Wikidata, Wikidata-Campsite, Patch-For-Review, Performance-Team, Multimedia, MediaWiki-Database, GlobalUsage, MediaWiki-extensions-PageAssessments, Discovery-Search, GeoData, Wikimedia-production-error
aaron created T224980: Compare /common in mediawiki-staging and /usr directories at the start of scap .
Tue, Jun 4, 11:45 AM · Scap, Release-Engineering-Team

Sun, Jun 2

aaron closed T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: LinksUpdate does not have outer scope as Resolved.
Sun, Jun 2, 6:37 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Wikidata, Wikidata-Campsite, Patch-For-Review, Performance-Team, Multimedia, MediaWiki-Database, GlobalUsage, MediaWiki-extensions-PageAssessments, Discovery-Search, GeoData, Wikimedia-production-error

Sat, Jun 1

aaron added a comment to T200471: LBFactorySimple breaks ExternalStorage, trying to connect to external server with local database name.

What is the status of this after the above patches are applied?

Sat, Jun 1, 8:33 AM · MW-1.32-notes, MW-1.33-notes, Performance-Team, Regression, MW-1.31-release, MediaWiki-Database

Fri, May 31

aaron updated the task description for T220470: Investigate backend save timing regression starting at 2019-04-08 19:15:00.
Fri, May 31, 7:33 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Page-editing, Performance-Team

Wed, May 29

aaron committed rEURD27ac542efc43: Add import statement for IDatabase (authored by aaron).
Add import statement for IDatabase
Wed, May 29, 6:22 PM
aaron committed rERXB67147b94c834: Clean up ResultWrapper type hints and related code (authored by aaron).
Clean up ResultWrapper type hints and related code
Wed, May 29, 9:04 AM
aaron committed rEURDba92c57b34f3: Add import statement for IDatabase (authored by aaron).
Add import statement for IDatabase
Wed, May 29, 8:58 AM

Tue, May 28

aaron added a comment to T219528: Make RESTBagOStuff::incr() atomic.

While having an atomic incr() method would certainly be nice, this task doesn't make sense to me for two reasons:

  1. The BagOStuff interface doesn't require or even suggest incr() to be atomic, and non-atomic implementations exist (e.g. in RedisBagOStuff). Because of this, there should be no callers that require atomic semantics.
  2. RESTBagOStuff is designed to work with any RESTish CRUD service. There's a variety of ways to implement atomic increment on top of such an interface, but all of them require some level of cooperation from the backend, and all of them come with cost in terms of latency or failure modes. It's unclear which mechanism RESTBagOStuff should use, this would have to be left to a subclass.

    Overall, BagOStuff is overloaded and under-specified. We should introduce new, more narrow interfaces that provide more guarantees about the semantics of the methods they define. An interface that is designed to fit any key-value-store will lack the guarantees that would make it useful in any but the most trivial use cases.
Tue, May 28, 9:09 PM · Core Platform Team Backlog (Designing)

Thu, May 23

aaron closed T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) as Resolved.
Thu, May 23, 9:51 PM · Patch-For-Review, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-notice, Growth-Team, MediaWiki-Watchlist

Wed, May 22

aaron added a comment to T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold).

Note that the above patches should be live.

Wed, May 22, 7:02 PM · Patch-For-Review, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-notice, Growth-Team, MediaWiki-Watchlist

Tue, May 21

aaron moved T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: LinksUpdate does not have outer scope from Doing to Blocked on the Performance-Team board.
Tue, May 21, 9:06 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Wikidata, Wikidata-Campsite, Patch-For-Review, Performance-Team, Multimedia, MediaWiki-Database, GlobalUsage, MediaWiki-extensions-PageAssessments, Discovery-Search, GeoData, Wikimedia-production-error
aaron moved T191668: Define varargs in \IDatabase::buildLike() in a way phan can understand it from Doing to Blocked on the Performance-Team board.
Tue, May 21, 9:06 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), phan, Performance-Team, Wikimedia-production-error (Shared Build Failure), MediaWiki-Database
aaron placed T92357: Fix problematic database master queries performed on HTTP GET/HEAD up for grabs.
Tue, May 21, 9:04 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Availability (MediaWiki-MultiDC), MediaWiki-General-or-Unknown
aaron placed T185724: Publish Doxygen for RunningStat library up for grabs.
Tue, May 21, 9:03 PM · patch-welcome, Librarization, Performance-Team, RunningStat, Continuous-Integration-Config
aaron added a comment to T212129: Use a multi-dc aware store for ObjectCache's MainStash if needed..

They preferably would happen in the main DC via POST, but that is not a hard requirement. This is partly why there are WRITE_SYNC and READ_LATEST flags in BagOStuff. A write should work in any DC and will should replicate asynchronously. If the backend supports WRITE_SYNC, then it should make the write best-effort synchronous.

Tue, May 21, 8:54 PM · User-mobrovac, Services (doing), User-jijiki, Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Performance-Team (Radar), Operations, MediaWiki-Cache, serviceops

Mon, May 20

aaron added a comment to T193832: JobQueue not working with certain config ($wgLocalDatabases set to the default value of an empty array()).

What version (or git hash) of MediaWiki are you currently running and do you still have unresolved problems? I've since made patches like 9df277a4ba3b1dc86e11f469d742c3781141da70 and some mediawiki.org documentation changes.

Mon, May 20, 8:37 PM · Performance-Team, MediaWiki-JobQueue
aaron updated the task description for T223737: Increase Memory Limit for Scribunto.
Mon, May 20, 8:11 PM · serviceops, Performance-Team (Radar), Performance, Patch-For-Review, Operations, Wikimedia-Site-requests

May 16 2019

aaron closed T215850: LoadBalancer.php uses $wgDBname even though $wgDBservers is defined as Resolved.

Thanks for working on this, @aaron. I'm not familiar with the Mediawiki source code but your change seems reasonable to me. Assuming I understand this correctly, could I suggest updating https://www.mediawiki.org/wiki/Manual:$wgDBservers and/or https://www.mediawiki.org/wiki/Manual:$wgDBname and mentioning that $wgDBname should be set even if $wgDBservers is used? And that they should have the same value? I think that would have helped me. It looks like I probably have access to update those pages, but I think you'd probably do a better job since you're familiar with the rationale behind the requirement.

May 16 2019, 8:01 PM · Performance-Team, Patch-For-Review, MediaWiki-Database
aaron added a comment to T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold).

Group 1 deployed, the problem continues.

May 16 2019, 7:42 AM · Patch-For-Review, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-notice, Growth-Team, MediaWiki-Watchlist
aaron added a comment to T223310: Investigate increase in tx bandwidth usage for mc1033.
May 16 2019, 7:41 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Growth-Team, Wikidata-Campsite, Wikidata, Performance-Team, User-jijiki, serviceops, Operations

May 10 2019

aaron placed T212881: addWiki.php broken creating ES tables up for grabs.
May 10 2019, 2:47 AM · Performance-Team (Radar), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MediaWiki-extensions-WikimediaMaintenance
aaron added a comment to T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold).

Thanks for the patch. Things are much better today, but still not entirely fixed.

On my watchlist, for example, I haven't looked at any pages for about two hours. One page has had 17 changes today, including three in the past two hours. It is marked in my Watchlist as completely read, and is not bold, with the following notation:

(17 changes | history)

It should instead be bold and should say:

(14 changes | 3 since last visit | history)

Most other pages are displayed correctly (for me). I know that makes it frustrating to track down the cause of the problem. I hope that this help you track down the cause. Post here if you need further information.

May 10 2019, 1:26 AM · Patch-For-Review, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-notice, Growth-Team, MediaWiki-Watchlist

May 8 2019

aaron closed T151903: Special:Search performs DB writes on GET request as Resolved.
May 8 2019, 10:08 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Performance-Team (Radar), Patch-For-Review, Availability (MediaWiki-MultiDC), Discovery-Search, Discovery, CirrusSearch
aaron closed T151903: Special:Search performs DB writes on GET request, a subtask of T92357: Fix problematic database master queries performed on HTTP GET/HEAD, as Resolved.
May 8 2019, 10:08 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Availability (MediaWiki-MultiDC), MediaWiki-General-or-Unknown

May 7 2019

aaron added a comment to T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: LinksUpdate does not have outer scope.

It's the new use of DeferredUpdates::attemptUpdate/addCallableUpdate in that change instead of plain doUpdate() calls that gives them outer scope.

May 7 2019, 4:29 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Wikidata, Wikidata-Campsite, Patch-For-Review, Performance-Team, Multimedia, MediaWiki-Database, GlobalUsage, MediaWiki-extensions-PageAssessments, Discovery-Search, GeoData, Wikimedia-production-error

May 6 2019

aaron moved T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) from Inbox to Doing on the Performance-Team board.
May 6 2019, 7:52 PM · Patch-For-Review, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-notice, Growth-Team, MediaWiki-Watchlist
aaron placed T203786: Mcrouter periodically reports soft TKOs for mc1029 (was mc1035, mc1022) leading to MW Memcached exceptions up for grabs.
May 6 2019, 7:05 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Performance-Team (Radar), Wikimedia-production-error, User-Elukey, MediaWiki-Cache, Operations

May 3 2019

aaron closed T216306: Avoid extra parse/save delay for users with non-canonical parser options as Resolved.

Confirmed via xhgui on page that is known to log "MediaWiki\Revision\RenderedRevision::outputVariesOnRevisionMetaData: Prepared output has vary-revision"

May 3 2019, 11:12 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MediaWiki-Page-derived-data, Performance-Team, MediaWiki-Parser
aaron added a comment to T158929: Librarize MediaWiki database layer and drop official support for non-MySQL engines.

Yes, even Oracle can go under /libs once the foreign key mess is dealt with.

May 3 2019, 10:10 PM · Librarization, Proposal, MediaWiki-Database
aaron added a comment to T218511: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold).

After struggling to reproduce anything, I saw T222431 mentioned the old non-default watchlist (that doesn't use JS). I can reproduce some problems when setting that preference on.

May 3 2019, 7:52 PM · Patch-For-Review, Performance-Team (Radar), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), User-notice, Growth-Team, MediaWiki-Watchlist
aaron added a comment to T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: LinksUpdate does not have outer scope.

Is it worth back-porting that patch? Or is it too risky?

May 3 2019, 7:22 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Wikidata, Wikidata-Campsite, Patch-For-Review, Performance-Team, Multimedia, MediaWiki-Database, GlobalUsage, MediaWiki-extensions-PageAssessments, Discovery-Search, GeoData, Wikimedia-production-error

May 1 2019

aaron placed T219592: Frequent Echo DB_MASTER write queries on HTTP GET up for grabs.
May 1 2019, 5:30 PM · Growth-Team, Notifications, Services (watching), Core Platform Team Backlog (Watching / External), Core Platform Team (Multi-DC (TEC1)), Performance-Team (Radar), Availability (MediaWiki-MultiDC)

Apr 30 2019

aaron added a comment to T221577: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: LinksUpdate does not have outer scope.

https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/497537/ might fix that (by giving each update it's own transaction round)...but that patch still has some CI issues.

Apr 30 2019, 4:46 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Wikidata, Wikidata-Campsite, Patch-For-Review, Performance-Team, Multimedia, MediaWiki-Database, GlobalUsage, MediaWiki-extensions-PageAssessments, Discovery-Search, GeoData, Wikimedia-production-error
aaron added a comment to T211721: Establish an SLA for session storage.

The SET metric for redis is very slow, so wouldn't use 10x that figure.

CentralAuth (CA) logins involves HTTP POST, redirect => HTTP GET, redirect HTTP GET. In terms of session store writes there is:
a) POST localwiki: session backend set + CA start-token set
b) GET centralwiki: session backend set + CA start-token delete + CA completion-token set
c) GET localwiki: session backend set + CA completion-token delete

Apr 30 2019, 3:26 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Core Platform Team Backlog (Later), Performance-Team (Radar), TechCom, Services (next), Operations, User-Clarakosi, Core Platform Team (Session Management Service (CDP2)), User-Eevans

Apr 26 2019

aaron added a comment to T220470: Investigate backend save timing regression starting at 2019-04-08 19:15:00.

The original cause of this task was deploy related and was probably fixed in d256b472f73956ee8e2503e0254a1107baa1f00a . The later timing increase is probably from something else on-wiki.

Apr 26 2019, 8:44 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MediaWiki-Page-editing, Performance-Team
aaron added a comment to T218207: Use disk-based LCStore by default in MediaWiki 1.34.

Did you try sqlite LCStore (with journal_mode = WAL and synchronous = NORMAL? like the installer uses)?

Apr 26 2019, 7:44 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Performance-Team, Core Platform Team Backlog (Later), Core Platform Team (Security, stability, performance and scalability (TEC1)), Language-Team, MediaWiki-Internationalization, MW-1.34-release

Apr 25 2019

aaron added a comment to T204606: Some requests time out after 60 seconds in MobileFrontend transforms. What to do?.

Right, so this isn't really about LazyImageTransform, but rather than is just one thing used the parsed DOM object. I guess the summary through me off.

Apr 25 2019, 12:06 AM · Performance-Team (Radar), Wikimedia-production-error, MobileFrontend, Readers-Web-Backlog

Apr 24 2019

aaron added a comment to T204606: Some requests time out after 60 seconds in MobileFrontend transforms. What to do?.

What other things are there other than <img> tags? Maybe you could start moving off those things that can be changed to avoid the DOM and document the rest. As I described above, I don't mind hybrid regex/DomElement logic. You could also have a simple state machine that reads the HTML body string, looking for certain tags and when the corresponding terminating tag is found, recording the positions, and using those to get chunk of strings to parse as DOMElements. That would require some assumptions about HTML being balanced/correct (I assume our Parser should handle that already with Tidy/Remex). I'm thinking of something simple kind of like Language::truncateHtml().

Apr 24 2019, 9:05 AM · Performance-Team (Radar), Wikimedia-production-error, MobileFrontend, Readers-Web-Backlog