Page MenuHomePhabricator

alaa_wmde (Alaa Sarhan)
Disabled

User Details

User Since
Feb 1 2019, 1:19 PM (90 w, 19 h)
Roles
Disabled
IRC Nick
alaa_wmde
LDAP User
Alaa Sarhan
MediaWiki User
Alaa Sarhan (WMDE) [ Global Accounts ]
This account has been disabled.

Recent Activity

Sat, Oct 17

Thayts awarded T194023: Expose siteGlobalID in Lua a Like token.
Sat, Oct 17, 8:25 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Lua, Wikidata

Dec 10 2019

Marostegui awarded T229407: Spikes in DB traffic and rows/s reads when reading from new terms store a Love token.
Dec 10 2019, 10:42 AM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Dec 9 2019

alaa_wmde updated the task description for T232040: Add label and description collision detectors for new terms store.
Dec 9 2019, 1:10 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde added a comment to T239470: Check the success of the initial terms migration (does it have holes).

I ran the rebuild script over one of the bugged items, and this correctly fixed the entries in the new store.

🎉 not-surprising yet great news :)

Dec 9 2019, 10:55 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Wikidata

Dec 6 2019

alaa_wmde committed rEWCS7a3edace21ab: Update DataAccessSettings constructor with new argument (authored by alaa_wmde).
Update DataAccessSettings constructor with new argument
Dec 6 2019, 2:58 PM

Dec 5 2019

Addshore awarded T229407: Spikes in DB traffic and rows/s reads when reading from new terms store a Baby Tequila token.
Dec 5 2019, 1:02 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Dec 4 2019

alaa_wmde triaged T239839: Wire up PrefetchingItemTermLookup as High priority.
Dec 4 2019, 7:45 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde moved T239839: Wire up PrefetchingItemTermLookup from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Dec 4 2019, 7:44 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde updated the task description for T232040: Add label and description collision detectors for new terms store.
Dec 4 2019, 6:10 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde created T239839: Wire up PrefetchingItemTermLookup.
Dec 4 2019, 4:39 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde updated the task description for T232040: Add label and description collision detectors for new terms store.
Dec 4 2019, 4:37 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde moved T225057: Switch `tmpItemTermsMigrationStages` to MIGRATION_WRITE_NEW from Peer Review to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

We moved to new store to up to Q1000. We wait for a while and move to a higher limit later

Dec 4 2019, 11:03 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata

Nov 30 2019

alaa_wmde claimed T239522: Fix short edit summary message and add missing messages.
Nov 30 2019, 9:13 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde added a subtask for T224013: Implement Shortend version: T239522: Fix short edit summary message and add missing messages.
Nov 30 2019, 9:13 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde added a parent task for T239522: Fix short edit summary message and add missing messages: T224013: Implement Shortend version.
Nov 30 2019, 9:13 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde created T239522: Fix short edit summary message and add missing messages.
Nov 30 2019, 9:12 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)

Nov 29 2019

alaa_wmde updated the task description for T232040: Add label and description collision detectors for new terms store.
Nov 29 2019, 12:17 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde updated the task description for T232040: Add label and description collision detectors for new terms store.
Nov 29 2019, 12:17 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde updated the task description for T232040: Add label and description collision detectors for new terms store.
Nov 29 2019, 12:03 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata

Nov 28 2019

alaa_wmde updated the task description for T232040: Add label and description collision detectors for new terms store.
Nov 28 2019, 10:07 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata

Nov 27 2019

alaa_wmde updated the task description for T232040: Add label and description collision detectors for new terms store.
Nov 27 2019, 2:18 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata

Nov 26 2019

alaa_wmde closed T234329: Investigate, fix and reimport failing item terms into new store, a subtask of T219123: Migrate to and read from new store for item terms, as Resolved.
Nov 26 2019, 2:02 PM · User-Addshore, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing
alaa_wmde closed T234329: Investigate, fix and reimport failing item terms into new store as Resolved.
Nov 26 2019, 2:02 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata
alaa_wmde closed T232248: The Wikibase web interface shows non-functional sitelink groups as Resolved.
Nov 26 2019, 2:01 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata
alaa_wmde closed T235261: Investigate why Termbox CSR failed to override mismatching SSR markup as Resolved.

We haven't experience any failures in production.. although it might be because we didn't yet introduce any breaking changes in CSR compared to SSR yet.

Nov 26 2019, 1:59 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde closed T237731: Do not catch DBError in new store db implementations, a subtask of T237723: PHP Warning: [data-update-failed]: Fail-safe exception. Number of ids to be restored is not equal to the number of records that are about to be inserted into master.….) [Called from Wikibase/repo/includes/Content/DataUpdateAdapter.php], as Resolved.
Nov 26 2019, 1:56 PM · Wikidata-Campsite, Wikidata, Wikimedia-production-error
alaa_wmde closed T237731: Do not catch DBError in new store db implementations as Resolved.

Let's remove catching DBError from DatabaseItemTermStore#storeTerms and DatabasePropertyTermStore#storeTerms separately, as they don't really provide that much valuable info in the error on top of the DBError anyway

Nov 26 2019, 1:56 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde closed T232595: Make it possible to collapse the "All entered languages" section when at the end of the section as Resolved.
Nov 26 2019, 1:50 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata-Termbox, Wikidata
alaa_wmde closed T229280: Wikibase\DataModel\Services\Lookup\EntityLookupException: Call to a member function getTargetId() on a non-object (null) as Resolved.
Nov 26 2019, 1:49 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Structured-Data-Backlog (Current Work), StructuredDataOnCommons, Structured Data Engineering, WikibaseMediaInfo, Wikidata, Wikibase-DataModel, Wikibase-DataModel-Services, Wikimedia-production-error
alaa_wmde updated the task description for T232040: Add label and description collision detectors for new terms store.
Nov 26 2019, 11:43 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde updated the task description for T232040: Add label and description collision detectors for new terms store.
Nov 26 2019, 11:32 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata

Nov 25 2019

alaa_wmde updated the task description for T232040: Add label and description collision detectors for new terms store.
Nov 25 2019, 8:52 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata

Nov 22 2019

alaa_wmde updated the task description for T232040: Add label and description collision detectors for new terms store.
Nov 22 2019, 2:45 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde updated the task description for T232040: Add label and description collision detectors for new terms store.
Nov 22 2019, 2:23 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde moved T232040: Add label and description collision detectors for new terms store from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

First patch is ready for review again

Nov 22 2019, 2:20 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata

Nov 12 2019

alaa_wmde moved T232595: Make it possible to collapse the "All entered languages" section when at the end of the section from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Nov 12 2019, 3:04 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata-Termbox, Wikidata
alaa_wmde placed T234322: Remove autojump of focus from property field to value field up for grabs.
Nov 12 2019, 2:46 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde moved T237984: Some property labels are not displayed on Item pages from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

@Lea_Lacroix_WMDE this should be solved. Anything else to look at from your side before we resolve?

Nov 12 2019, 2:45 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), User-Addshore, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde moved T229407: Spikes in DB traffic and rows/s reads when reading from new terms store from Ready to estimate to Blocked / Waiting / External on the Wikidata-Campsite board.
Nov 12 2019, 1:54 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.

Waiting on T236681: SqlEntityInfoBuilder reads and writes from the old term store regardless of the config as caching entity info stuff might solve this problem

Nov 12 2019, 1:54 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde added a parent task for T236681: SqlEntityInfoBuilder reads and writes from the old term store regardless of the config: T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.
Nov 12 2019, 1:53 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde added a subtask for T229407: Spikes in DB traffic and rows/s reads when reading from new terms store: T236681: SqlEntityInfoBuilder reads and writes from the old term store regardless of the config.
Nov 12 2019, 1:53 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde moved T234221: Change the datatype of P4839 from string to identifier from Ready to estimate to Ready to pick up on the Wikidata-Campsite board.
Nov 12 2019, 1:50 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde updated the task description for T236901: Use elastic for SpecialEntitiesWithoutPage (EntitiesWithoutTermFinder).
Nov 12 2019, 1:48 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde updated the task description for T237499: Sitelink tables corrupted after merge of items.
Nov 12 2019, 1:43 PM · Wikidata-Campsite, Wikidata
alaa_wmde added a comment to T232040: Add label and description collision detectors for new terms store.

True. Option 1 is the status quo, and since those race-conditions are quite rare to begin with, and the point made by @Lucas_Werkmeister_WMDE about this validation not being a strict integrity check (@Lydia_Pintscher please correct us if we are making wrong assumptions here) sounds reasonable, I will continue with option 1 for now.

Nov 12 2019, 12:21 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata

Nov 11 2019

alaa_wmde moved T232040: Add label and description collision detectors for new terms store from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

For the new store, we are saving terms in a deferred update. This makes uniqueness checks:
a) if done during request, they might not catch possible collisions with values that are in deferred updates at the moment but haven't been written to db yet.
b) if done as part of the deferred update, they don't have the chance to report back collisions to the user.

Nov 11 2019, 10:43 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde added a comment to T237731: Do not catch DBError in new store db implementations.

https://tools.wmflabs.org/versions/
We have wmf.5 in production now. This one is tagged for wmf.8. is that going to be the branch for this week's train?

Nov 11 2019, 9:00 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde updated the task description for T237731: Do not catch DBError in new store db implementations.
Nov 11 2019, 8:59 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde moved T237731: Do not catch DBError in new store db implementations from Doing to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Nov 11 2019, 8:59 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)

Nov 8 2019

alaa_wmde moved T237731: Do not catch DBError in new store db implementations from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Nov 8 2019, 3:06 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde added projects to T237731: Do not catch DBError in new store db implementations: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata.
Nov 8 2019, 3:06 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde added a comment to T237723: PHP Warning: [data-update-failed]: Fail-safe exception. Number of ids to be restored is not equal to the number of records that are about to be inserted into master.….) [Called from Wikibase/repo/includes/Content/DataUpdateAdapter.php].

No sure how catching DBError could lead to these exceptions yet. I just removed the only place where we do that (mistakenly apparently) in a sub-task, but cannot think of a way to test that it does really solve this issue.

Nov 8 2019, 3:06 PM · Wikidata-Campsite, Wikidata, Wikimedia-production-error
alaa_wmde added a subtask for T237723: PHP Warning: [data-update-failed]: Fail-safe exception. Number of ids to be restored is not equal to the number of records that are about to be inserted into master.….) [Called from Wikibase/repo/includes/Content/DataUpdateAdapter.php]: T237731: Do not catch DBError in new store db implementations.
Nov 8 2019, 3:05 PM · Wikidata-Campsite, Wikidata, Wikimedia-production-error
alaa_wmde added a parent task for T237731: Do not catch DBError in new store db implementations: T237723: PHP Warning: [data-update-failed]: Fail-safe exception. Number of ids to be restored is not equal to the number of records that are about to be inserted into master.….) [Called from Wikibase/repo/includes/Content/DataUpdateAdapter.php].
Nov 8 2019, 3:05 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde created T237731: Do not catch DBError in new store db implementations.
Nov 8 2019, 2:59 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde added a parent task for T237723: PHP Warning: [data-update-failed]: Fail-safe exception. Number of ids to be restored is not equal to the number of records that are about to be inserted into master.….) [Called from Wikibase/repo/includes/Content/DataUpdateAdapter.php]: T208425: [EPIC] Kill the wb_terms table.
Nov 8 2019, 2:51 PM · Wikidata-Campsite, Wikidata, Wikimedia-production-error
alaa_wmde added a subtask for T208425: [EPIC] Kill the wb_terms table: T237723: PHP Warning: [data-update-failed]: Fail-safe exception. Number of ids to be restored is not equal to the number of records that are about to be inserted into master.….) [Called from Wikibase/repo/includes/Content/DataUpdateAdapter.php].
Nov 8 2019, 2:51 PM · Wikibase wb_terms leftovers 2020, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), User-Addshore, wdwb-tech-focus, Wikidata-Ugly-Cat-Trailblaze (wb_terms trail blazing), Wikidata

Nov 7 2019

alaa_wmde moved T232040: Add label and description collision detectors for new terms store from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

first patch ready for review again .. left some comments where I'd love to have a second (or more) thought

Nov 7 2019, 7:26 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde moved T234322: Remove autojump of focus from property field to value field from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Woohoo finally this can be tested on beta

Nov 7 2019, 10:33 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde updated the task description for T234322: Remove autojump of focus from property field to value field.
Nov 7 2019, 10:33 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde placed T224013: Implement Shortend version up for grabs.
Nov 7 2019, 10:32 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde moved T232040: Add label and description collision detectors for new terms store from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

I'm doing some cleanup work on first patch now

Nov 7 2019, 10:06 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata

Nov 5 2019

jcrespo awarded T234329: Investigate, fix and reimport failing item terms into new store a Like token.
Nov 5 2019, 2:03 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata

Nov 3 2019

Pppery awarded T194023: Expose siteGlobalID in Lua a Dislike token.
Nov 3 2019, 2:55 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Lua, Wikidata
alaa_wmde moved T232040: Add label and description collision detectors for new terms store from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

First patch reworked and ready for peer review again

Nov 3 2019, 2:22 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata

Nov 1 2019

alaa_wmde moved T232595: Make it possible to collapse the "All entered languages" section when at the end of the section from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

@Hanna_Petruschat_WMDE @Jan_Dittrich
The behavior described in AC should be available fully in beta. Please have a look and test for any problems that fall into not fulfilling the AC of this task. Once you approve it, we can plan for shipping it to production on next train.

Nov 1 2019, 8:26 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata-Termbox, Wikidata
alaa_wmde moved T232040: Add label and description collision detectors for new terms store from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Nov 1 2019, 8:23 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata

Oct 31 2019

alaa_wmde committed rWBTB619db56cf873: Scroll to and focus on "All entered languages" after collapsing (authored by alaa_wmde).
Scroll to and focus on "All entered languages" after collapsing
Oct 31 2019, 2:46 PM

Oct 30 2019

alaa_wmde moved T232040: Add label and description collision detectors for new terms store from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

first patch for collision detector interfance+implementations is up for review

Oct 30 2019, 10:18 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde updated the task description for T232040: Add label and description collision detectors for new terms store.
Oct 30 2019, 10:18 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde updated the task description for T232040: Add label and description collision detectors for new terms store.
Oct 30 2019, 10:18 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde updated the task description for T232040: Add label and description collision detectors for new terms store.
Oct 30 2019, 3:09 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde moved T232040: Add label and description collision detectors for new terms store from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Oct 30 2019, 3:05 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde moved T232595: Make it possible to collapse the "All entered languages" section when at the end of the section from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Oct 30 2019, 2:57 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata-Termbox, Wikidata
alaa_wmde claimed T232040: Add label and description collision detectors for new terms store.
Oct 30 2019, 1:31 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde moved T232040: Add label and description collision detectors for new terms store from Ready to pick up to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.
Oct 30 2019, 1:31 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde moved T224013: Implement Shortend version from Wikidata-Campsite-Iteration-∞ to Ready to pick up on the Wikidata-Campsite board.
Oct 30 2019, 1:31 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde placed T232040: Add label and description collision detectors for new terms store up for grabs.
Oct 30 2019, 12:54 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde moved T232040: Add label and description collision detectors for new terms store from Incoming to Ready to pick up on the Wikidata-Campsite board.
Oct 30 2019, 12:53 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde edited projects for T232040: Add label and description collision detectors for new terms store, added: Wikidata-Campsite; removed Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).
Oct 30 2019, 12:53 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde renamed T232040: Add label and description collision detectors for new terms store from Add LabelConflictFinder implementation for new terms store to Add label and description collision detectors for new terms store.
Oct 30 2019, 12:53 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde moved T224013: Implement Shortend version from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Oct 30 2019, 12:48 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde moved T232040: Add label and description collision detectors for new terms store from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Oct 30 2019, 12:48 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde moved T232595: Make it possible to collapse the "All entered languages" section when at the end of the section from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Oct 30 2019, 12:48 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata-Termbox, Wikidata
alaa_wmde placed T235117: Investigate possible optimizations writes to new term store up for grabs.
Oct 30 2019, 12:47 PM · User-Addshore, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde moved T235117: Investigate possible optimizations writes to new term store from Peer Review to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Moving back to To Do to cover the other bit (the unchecked Database Transactions documentation for other possible optimizations).

Oct 30 2019, 12:47 PM · User-Addshore, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde renamed T235117: Investigate possible optimizations writes to new term store from Investigate possible optimizations on number of writes to new term store to Investigate possible optimizations writes to new term store.
Oct 30 2019, 12:46 PM · User-Addshore, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde updated the task description for T235117: Investigate possible optimizations writes to new term store.
Oct 30 2019, 12:46 PM · User-Addshore, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde added a comment to T235117: Investigate possible optimizations writes to new term store.

Per @Ladsgroup manual testing, there doesn't seem, number of writes per edit seem to be (near-)optimal .. marking that bit with a check.

Oct 30 2019, 12:46 PM · User-Addshore, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde added a comment to T220696: [Story] Create better edit summaries for wbeditentity API endpoint.

Here is a diff where one of the new fallback summaries failed to be translated to a human-readable form: https://www.wikidata.org/w/index.php?title=Property:P571&diff=1040450905&oldid=1038877052

Oct 30 2019, 11:43 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata
alaa_wmde updated the task description for T220696: [Story] Create better edit summaries for wbeditentity API endpoint.
Oct 30 2019, 11:19 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata
alaa_wmde updated the task description for T224013: Implement Shortend version.
Oct 30 2019, 11:18 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde added a comment to T224013: Implement Shortend version.

After talking to @Lydia_Pintscher , we decided to go with a simpler version of the shortend version as suggested in the last comment. Task and parent Task descriptions will updated accordingly.

Oct 30 2019, 11:17 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde moved T232595: Make it possible to collapse the "All entered languages" section when at the end of the section from Doing to To Do (prioritised from top to bottom) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Oct 30 2019, 11:17 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata-Termbox, Wikidata
alaa_wmde moved T224013: Implement Shortend version from Stalled/Waiting to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Oct 30 2019, 11:17 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde added a comment to T225497: Update Wikibase Lua documentation.

Another possible improvement could be to reorder the functions alphabetically, not sure if that's a commonly desired thing so I'll leave if for someone else to pick that up :)

Oct 30 2019, 10:53 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-Documentation, Wikidata, Wikibase-Lua
alaa_wmde closed T225497: Update Wikibase Lua documentation as Resolved.

Looks great! Resolving this as the original missing functions has been covered.

Oct 30 2019, 10:52 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-Documentation, Wikidata, Wikibase-Lua
alaa_wmde moved T234322: Remove autojump of focus from property field to value field from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Oct 30 2019, 10:45 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
alaa_wmde moved T234322: Remove autojump of focus from property field to value field from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Oct 30 2019, 10:36 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata