Page MenuHomePhabricator

alaa_wmde (Alaa Sarhan)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 1 2019, 1:19 PM (28 w, 3 d)
Availability
Available
IRC Nick
alaa_wmde
LDAP User
Alaa Sarhan
MediaWiki User
Alaa Sarhan (WMDE) [ Global Accounts ]

Recent Activity

Today

alaa_wmde added a comment to T220829: Wikidata edit (rollback) not propagated to Wikipedia after 10 days.

There's no hint to what might have gone wrong here. We will try to reproduce this in production (sandbox entities).

Mon, Aug 19, 1:43 PM · Wikidata-Campsite, Wikidata, MediaWiki-extensions-WikibaseRepository
alaa_wmde moved T228299: ModifyEntity.php database error from Needs Work to Ready to estimate on the Wikidata-Campsite board.
Mon, Aug 19, 1:35 PM · Wikidata-Campsite, Wikidata, Wikimedia-production-error
alaa_wmde moved T228293: RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job) from Needs Work to Ready to estimate on the Wikidata-Campsite board.
Mon, Aug 19, 1:35 PM · Wikidata-Campsite, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error
alaa_wmde added a comment to T227032: Find a way to tag wdqs UI images.

Let's pull specific commits instead of pulling master of wikidata-query-gui into latest, and tag them with a dynamic tag name (e.g month-year)

Mon, Aug 19, 1:25 PM · Wikidata-Campsite, Wikidata Query UI, Wikibase-Containers, Wikidata
alaa_wmde added a comment to T227811: wdqs-frontend can't be assigned with a port number.

Looking into T207133: SPARQL service returns entities with broken URLs, seems that we might not need to do this (customize wikibase port) at all.

Mon, Aug 19, 1:15 PM · Wikidata-Campsite, Wikibase-Containers, Wikidata
alaa_wmde changed the status of T225053: Switch `tmpPropertyTermsMigrationStage` to MIGRATION_WRITE_NEW, a subtask of T219301: Run migration of property terms, from Stalled to Open.
Mon, Aug 19, 12:42 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing
alaa_wmde changed the status of T225053: Switch `tmpPropertyTermsMigrationStage` to MIGRATION_WRITE_NEW from Stalled to Open.
Mon, Aug 19, 12:42 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde added a comment to T225053: Switch `tmpPropertyTermsMigrationStage` to MIGRATION_WRITE_NEW.

Rescheduled for deployment 20th of August, with a priory backport
https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20190820T1100

Mon, Aug 19, 12:41 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde closed T230119: New term store connects to the wrong host in clients, a subtask of T225053: Switch `tmpPropertyTermsMigrationStage` to MIGRATION_WRITE_NEW, as Resolved.
Mon, Aug 19, 10:35 AM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde closed T230119: New term store connects to the wrong host in clients as Resolved.

Tested on beta, english wikipedia
https://en.wikipedia.beta.wmflabs.org/wiki/Draft:Wikidata_Test
https://en.wikipedia.beta.wmflabs.org/wiki/Module:Wikidata_test

Mon, Aug 19, 10:35 AM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing, User-Ladsgroup
alaa_wmde claimed T225053: Switch `tmpPropertyTermsMigrationStage` to MIGRATION_WRITE_NEW.
Mon, Aug 19, 10:33 AM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde moved T225053: Switch `tmpPropertyTermsMigrationStage` to MIGRATION_WRITE_NEW from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Aug 19, 10:32 AM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde moved T225055: Switch `tmpItemTermsMigrationStages` to MIGRATION_WRITE_BOTH from Doing to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Aug 19, 10:32 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing
alaa_wmde closed T230050: OutOfBoundsException in WikibaseQualityConstraints setup on Beta Wikidata, a subtask of T220744: 1.34.0-wmf.19 deployment blockers, as Resolved.
Mon, Aug 19, 10:24 AM · User-zeljkofilipin, Release-Engineering-Team-TODO (201908), Release-Engineering-Team (Deployment services), Release, Train Deployments
alaa_wmde closed T230050: OutOfBoundsException in WikibaseQualityConstraints setup on Beta Wikidata as Resolved.

This seems to have been resolved. I can access api sandbox on beta, as well as https://wikidata.beta.wmflabs.org/wiki/Special:ConstraintReport successfully.

Mon, Aug 19, 10:24 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikidata
alaa_wmde added a project to T224010: Implement Fallback version: Patch-For-Review.
Mon, Aug 19, 10:18 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde added a comment to T224010: Implement Fallback version.

(mimicking gerrit 😄)

Mon, Aug 19, 9:42 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde updated the task description for T224010: Implement Fallback version.
Mon, Aug 19, 9:39 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Fri, Aug 16

alaa_wmde moved T230630: Prepare case for RL/Webpack trailblazing from Todo: Focus to Doing on the User-Alaa board.
Fri, Aug 16, 8:53 PM · User-Alaa
alaa_wmde triaged T230630: Prepare case for RL/Webpack trailblazing as High priority.
Fri, Aug 16, 8:53 PM · User-Alaa
alaa_wmde created T230630: Prepare case for RL/Webpack trailblazing.
Fri, Aug 16, 8:52 PM · User-Alaa

Tue, Aug 13

alaa_wmde moved T88258: Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration from Campsite Candidates to In Investigation (cost/impact) on the Wikidata-Trailblazing-Exploration board.
Tue, Aug 13, 12:31 PM · Wikidata-Trailblazing-Exploration, Story, Technical-Debt, wikidata-tech-focus, Wikidata-Turtles-Tech-Debt, Wikidata-Ministry-Of-Magic-Tech-Debt, Wikidata-Sprint-2017-12-20, Wikidata-Sprint-2015-08-11, Wikidata-Sprint-2015-06-30, Wikidata-Sprint-2015-06-16, Wikidata-Sprint-2015-06-02, MediaWiki-extensions-WikibaseRepository, Wikidata, MediaWiki-extensions-WikibaseClient
alaa_wmde updated the task description for T230399: Entity Schema editor should be warning users about a blank edit summary.
Tue, Aug 13, 12:24 PM · Shape Expressions, Wikidata-Campsite, Wikidata
alaa_wmde updated the task description for T230399: Entity Schema editor should be warning users about a blank edit summary.
Tue, Aug 13, 12:22 PM · Shape Expressions, Wikidata-Campsite, Wikidata
alaa_wmde moved T230399: Entity Schema editor should be warning users about a blank edit summary from Ready to estimate to Ready to pick up on the Wikidata-Campsite board.
Tue, Aug 13, 12:21 PM · Shape Expressions, Wikidata-Campsite, Wikidata
alaa_wmde set the point value for T230399: Entity Schema editor should be warning users about a blank edit summary to 5.
Tue, Aug 13, 12:21 PM · Shape Expressions, Wikidata-Campsite, Wikidata
alaa_wmde moved T230398: Adjust the save button of the Entity Schema editor from Ready to estimate to Ready to pick up on the Wikidata-Campsite board.
Tue, Aug 13, 12:16 PM · Wikidata-Campsite, Wikidata
alaa_wmde set the point value for T230398: Adjust the save button of the Entity Schema editor to 3.
Tue, Aug 13, 12:16 PM · Wikidata-Campsite, Wikidata
alaa_wmde moved T227811: wdqs-frontend can't be assigned with a port number from Ready to estimate to Needs Work on the Wikidata-Campsite board.
Tue, Aug 13, 12:12 PM · Wikidata-Campsite, Wikibase-Containers, Wikidata
alaa_wmde closed T205192: Create a property link formatter that uses cache instead of wb_terms table, a subtask of T196882: Create a code abstraction for "display entity link" use-case, as Resolved.
Tue, Aug 13, 11:53 AM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Wikidata, Wikidata-Ugly-Cat-Trailblaze (wb_terms trail blazing)
alaa_wmde closed T205192: Create a property link formatter that uses cache instead of wb_terms table as Resolved.
Tue, Aug 13, 11:53 AM · Wikidata
alaa_wmde added a comment to T205192: Create a property link formatter that uses cache instead of wb_terms table.

Done in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/441010

Tue, Aug 13, 11:53 AM · Wikidata
alaa_wmde updated subscribers of T227032: Find a way to tag wdqs UI images.

@LucasWerkmeister @Smalyshev how does releasing versions of https://github.com/wikimedia/wikidata-query-gui/releases .. there are only two from 2016, but I guess we can release more often, now that we rely on it for shipping wikibase-docker images?

Tue, Aug 13, 10:17 AM · Wikidata-Campsite, Wikidata Query UI, Wikibase-Containers, Wikidata
alaa_wmde closed T227121: Browser test fails with "old revisions do not have an edit link" blocking merges in Minerva skin as Resolved.

The test has been skipped in T227266: Find out why 'old revisions do not have edit links' selenium test is flaky on CI is being checked for improvements on its flakiness. This task serves no more purpose beyond this point, apart from documenting the same error we are aware of already.

Tue, Aug 13, 9:45 AM · Wikidata-Campsite, ci-test-error, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata, Wikimedia-production-error (Shared Build Failure)

Mon, Aug 12

alaa_wmde added a comment to T225053: Switch `tmpPropertyTermsMigrationStage` to MIGRATION_WRITE_NEW.

Scheduled for Monday 19th of August. Fix T230119: New term store connects to the wrong host in clients moved to be tested on beta (to be deployed).

Mon, Aug 12, 3:20 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde moved T225053: Switch `tmpPropertyTermsMigrationStage` to MIGRATION_WRITE_NEW from Stalled/Waiting to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Aug 12, 3:11 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde moved T230119: New term store connects to the wrong host in clients from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Aug 12, 3:10 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing, User-Ladsgroup
alaa_wmde added a comment to T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities.

@dbarratt @Niharika have you tested this? is it good?

Mon, Aug 12, 3:05 PM · Anti-Harassment (The Letter Song), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, MediaWiki-extensions-WikibaseRepository, Wikidata
alaa_wmde closed T217245: [Story] Call WikibaseLexeme API with baserevid parameter from the UI as Resolved.

Works as expected in the scenario of self-conflict and of real conflict!

Mon, Aug 12, 3:04 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde closed T227450: Many `request has exceeded memory limit` fatal errors for wikidata jobrunner as Resolved.
Mon, Aug 12, 2:51 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikidata, Wikimedia-production-error
alaa_wmde closed T223995: BadMethodCallException wbgetentities when getting Lexeme subentities (forms, senses) as Resolved.
Mon, Aug 12, 2:46 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikimedia-production-error, Lexicographical data, Wikidata
alaa_wmde moved T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Aug 12, 2:41 PM · User-Ladsgroup, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Performance, Wikidata
alaa_wmde added a comment to T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase.

I think the reason is that the graphs are in log scale

can't see where they are in log scale, they are all in time or percentage here https://grafana.wikimedia.org/d/000000615/wikibase-editentity?orgId=1

Mon, Aug 12, 2:41 PM · User-Ladsgroup, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Performance, Wikidata
alaa_wmde closed T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers, a subtask of T202154: Audit modules 2018: Reduce registry overhead, as Resolved.
Mon, Aug 12, 2:28 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Performance-Team-publish, MediaWiki-ResourceLoader, Performance-Team
alaa_wmde closed T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers as Resolved.
Mon, Aug 12, 2:28 PM · Performance-Team-publish, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseClient, Patch-For-Review, Performance-Team (Radar), Wikidata
alaa_wmde added a comment to T226818: Diff when updating wbc_entity_usage.

@Ladsgroup is there a way to test this locally and/or on beta?

Mon, Aug 12, 2:24 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, wikidata-tech-focus, User-Addshore, MediaWiki-extensions-WikibaseClient, Wikidata
alaa_wmde updated the task description for T224961: miscellaneous minor tweaks for the ShEx editor.
Mon, Aug 12, 1:37 PM · Wikidata-Campsite, Wikidata, Shape Expressions
alaa_wmde moved T227811: wdqs-frontend can't be assigned with a port number from Needs Work to Ready to estimate on the Wikidata-Campsite board.
Mon, Aug 12, 1:04 PM · Wikidata-Campsite, Wikibase-Containers, Wikidata
alaa_wmde changed the subtype of T228299: ModifyEntity.php database error from "Task" to "Bug Report".
Mon, Aug 12, 12:59 PM · Wikidata-Campsite, Wikidata, Wikimedia-production-error
alaa_wmde added a comment to T214884: linking Schemas in statements.

Deadline added for the decision, 02.09.2019 end of work day.

Mon, Aug 12, 12:45 PM · Wikidata-Campsite, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), User-Ladsgroup, Wikidata, Shape Expressions
alaa_wmde added a comment to T214884: linking Schemas in statements.

Waiting on discussion regarding which direction to go with this.

Mon, Aug 12, 12:44 PM · Wikidata-Campsite, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), User-Ladsgroup, Wikidata, Shape Expressions
alaa_wmde moved T214884: linking Schemas in statements from Wikidata-Campsite-Iteration-∞ to Blocked / Waiting / External on the Wikidata-Campsite board.
Mon, Aug 12, 12:43 PM · Wikidata-Campsite, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), User-Ladsgroup, Wikidata, Shape Expressions
alaa_wmde moved T214884: linking Schemas in statements from in progress to needs discussion or investigation on the Wikidata board.
Mon, Aug 12, 12:43 PM · Wikidata-Campsite, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), User-Ladsgroup, Wikidata, Shape Expressions
alaa_wmde closed T224398: Configure 'grunt fix' task for eslint on Wikibase.git as Resolved.
Mon, Aug 12, 12:41 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), good first bug, Developer Productivity, Wikidata
alaa_wmde updated the task description for T229816: RebuildItemTerms (and probably RebuildPropertyTerms) explodes when there's a (double) redirect.
Mon, Aug 12, 12:35 PM · User-Ladsgroup, Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde triaged T229816: RebuildItemTerms (and probably RebuildPropertyTerms) explodes when there's a (double) redirect as High priority.

This will block migration of item terms to new store

Mon, Aug 12, 12:33 PM · User-Ladsgroup, Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde moved T229816: RebuildItemTerms (and probably RebuildPropertyTerms) explodes when there's a (double) redirect from Test (Verification) to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Aug 12, 12:31 PM · User-Ladsgroup, Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde added a comment to T229816: RebuildItemTerms (and probably RebuildPropertyTerms) explodes when there's a (double) redirect.

This doesn't fix the issue. When testing the updated script with double-redirects, it still failed due to the actual exceptipon being thrown is ItemLookupException and not RevisionedUnresolvedRedirectException.

Mon, Aug 12, 12:31 PM · User-Ladsgroup, Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde closed T222606: Create Maintenance Script to Remove Terms in a Language from Current Revision, a subtask of T200432: Labels/aliases/descriptions in Toki Pona need to be removed, as Resolved.
Mon, Aug 12, 12:19 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wikidata-tech-focus, Wikidata.org, Wikidata
alaa_wmde closed T222606: Create Maintenance Script to Remove Terms in a Language from Current Revision as Resolved.
Mon, Aug 12, 12:19 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wikidata-tech-focus, Wikidata.org, Wikidata
alaa_wmde renamed T221602: [Story] Discontinued support of a language breaks edits in Terms from [Problem] Discontinued support of a language breaks edits in Terms to [Story] Discontinued support of a language breaks edits in Terms.
Mon, Aug 12, 12:11 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde moved T221602: [Story] Discontinued support of a language breaks edits in Terms from incoming to in progress on the Wikidata board.
Mon, Aug 12, 12:10 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde edited projects for T221602: [Story] Discontinued support of a language breaks edits in Terms, added: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

Since all sub-tasks are in iteration now

Mon, Aug 12, 12:10 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde added a comment to T217770: [Story] Never show anything from a language that is not currently Wikidata conform.

@WMDE-leszek 100% agree. I actually was just asking out of curiosity (that that small change would fix the issues mentioned here). We should definitely go down the route of having Wikibase allow to manage a layer of supported languages on top of languages providers that it integrates with.

Mon, Aug 12, 12:09 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Patch-For-Review
alaa_wmde added a comment to T223552: external ID linking issue on Factgrid.

@Olaf_Simons is this still an issue on your side, or have you managed to fix it?

Mon, Aug 12, 12:00 PM · FactGrid, Wikidata, Wikidata-Campsite
alaa_wmde moved T228734: Hook automatically fixing js formatting issues into git precommit from Incoming to Blocked / Waiting / External on the Wikidata-Campsite board.

Waiting on feedback from campers

Mon, Aug 12, 11:45 AM · Wikidata, Wikidata-Campsite
alaa_wmde edited projects for T228734: Hook automatically fixing js formatting issues into git precommit, added: Wikidata-Campsite; removed Wikidata-Trailblazing-Exploration.
Mon, Aug 12, 11:44 AM · Wikidata, Wikidata-Campsite
alaa_wmde updated subscribers of T228734: Hook automatically fixing js formatting issues into git precommit.

thanks @noarave for preparing the task description.

Mon, Aug 12, 11:44 AM · Wikidata, Wikidata-Campsite
alaa_wmde claimed T230119: New term store connects to the wrong host in clients.
Mon, Aug 12, 11:26 AM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing, User-Ladsgroup
alaa_wmde moved T230119: New term store connects to the wrong host in clients from Test (Verification) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Another database access needed to be updated the same way

Mon, Aug 12, 11:19 AM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata wb_terms Trailblazing, User-Ladsgroup
alaa_wmde updated the task description for T66315: Move "Data item" link outside of sidebar toolbox.
Mon, Aug 12, 10:47 AM · Patch-For-Review, User-notice, User-Ladsgroup, User-Noarave, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseClient
alaa_wmde placed T66315: Move "Data item" link outside of sidebar toolbox up for grabs.
Mon, Aug 12, 10:45 AM · Patch-For-Review, User-notice, User-Ladsgroup, User-Noarave, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseClient
alaa_wmde moved T66315: Move "Data item" link outside of sidebar toolbox from Test (Verification) to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Aug 12, 10:45 AM · Patch-For-Review, User-notice, User-Ladsgroup, User-Noarave, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseClient
alaa_wmde added a comment to T66315: Move "Data item" link outside of sidebar toolbox.

@stjn good question.

Mon, Aug 12, 10:24 AM · Patch-For-Review, User-notice, User-Ladsgroup, User-Noarave, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseClient
alaa_wmde added a comment to T228495: Check Phabricator API for setting up some team lead-time and throughput metrics.

For lead/cycle-times, it can as well be used, but then I need to do two calls to that endpoint to get when the task was created, and to get when it was closed. using maniphest.search kinda was easier here as it gives me both in the response, and it must be as well less overhead on the backend as there's no need to search transaction history for specific changes, I reckon.

Mon, Aug 12, 6:42 AM · User-Alaa
alaa_wmde added a comment to T228495: Check Phabricator API for setting up some team lead-time and throughput metrics.

that's very nice that you went over the code, thanks!

Mon, Aug 12, 6:24 AM · User-Alaa

Fri, Aug 9

alaa_wmde added a comment to T230201: Investigate the failures in 'can add a statement using the keyboard' browser test'.

For this one, we got back to the original problems we faced with it and why we had to introduce browser.pause in the first place. It appears that sometimes the 1 second we pause might not always be enough, as locally watching the test we could see that the element approached almost a second to appear (at least it didn't feel that instant) so we imagined that it could be in some runs of the test that it takes more than a second which makes it fail, due to invalid form as the keys entered using browser.keys either do not end up in any input (making qualifier input invalid as it is empty) or end up in qualifier property input field (making it invalid too for a wrong property id/label there).

Fri, Aug 9, 2:34 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde created T230201: Investigate the failures in 'can add a statement using the keyboard' browser test'.
Fri, Aug 9, 2:15 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)

Thu, Aug 8

alaa_wmde moved T222606: Create Maintenance Script to Remove Terms in a Language from Current Revision from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Aug 8, 1:36 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wikidata-tech-focus, Wikidata.org, Wikidata
alaa_wmde moved T224189: Use thumbnail preferences for thumbnail of Commons media file from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Aug 8, 1:34 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, MediaWiki-User-preferences, Multimedia, Wikidata

Wed, Aug 7

alaa_wmde updated the task description for T66315: Move "Data item" link outside of sidebar toolbox.
Wed, Aug 7, 8:53 PM · Patch-For-Review, User-notice, User-Ladsgroup, User-Noarave, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseClient
alaa_wmde moved T224472: Investigate the timeout of Wikibase browser tests after the change/fix in MediaWiki's DeferredUpdated from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Aug 7, 11:04 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde added a comment to T214894: Grafana Datamodel References dashboard broken (daily data).

is there a way to test this on Beta, or just in production?

Wed, Aug 7, 9:15 AM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, WMDE-Analytics-Engineering
alaa_wmde moved T214894: Grafana Datamodel References dashboard broken (daily data) from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Aug 7, 9:14 AM · Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, WMDE-Analytics-Engineering
alaa_wmde added a comment to T224189: Use thumbnail preferences for thumbnail of Commons media file.

One quite expensive way to do this is to define CommonsMedia value type, inject the thumbsize in the value type (by defining CommonsMediaValueParser that takes ParserOptions) and then use it in the CommonsInlineImageFormatter, that would be two days of work at least. Unless I'm missing something obvious.

Wed, Aug 7, 9:13 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, MediaWiki-User-preferences, Multimedia, Wikidata
alaa_wmde moved T227121: Browser test fails with "old revisions do not have an edit link" blocking merges in Minerva skin from Incoming to Needs Work on the Wikidata-Campsite board.
Wed, Aug 7, 8:54 AM · Wikidata-Campsite, ci-test-error, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata, Wikimedia-production-error (Shared Build Failure)
alaa_wmde lowered the priority of T227121: Browser test fails with "old revisions do not have an edit link" blocking merges in Minerva skin from Unbreak Now! to Normal.

The mentioned patch has been merged and it failed "only" once due to flakiness in that test. We have a few tests that are still a bit flaky.

Wed, Aug 7, 8:31 AM · Wikidata-Campsite, ci-test-error, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Wikidata, Wikimedia-production-error (Shared Build Failure)
alaa_wmde placed T229574: Make logging warning or info of not finding entity for revision configurable up for grabs.
Wed, Aug 7, 8:03 AM · Patch-For-Review, Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde added a comment to T229574: Make logging warning or info of not finding entity for revision configurable .

This is now failing because Elastic is using that class internally and need to be updated so that it instantiate with the new argument, merge that into master, then run Wikibase's CI again. Though I will look first into comment https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/527015/7/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php#148 to figure out what to do next. It can be that we don't need the warning after all.

Wed, Aug 7, 8:03 AM · Patch-For-Review, Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde moved T229574: Make logging warning or info of not finding entity for revision configurable from Peer Review to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Aug 7, 8:00 AM · Patch-For-Review, Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
alaa_wmde updated subscribers of T228495: Check Phabricator API for setting up some team lead-time and throughput metrics.

@darthmon_wmde here's what we agreed on to measure as outcome of this:

Wed, Aug 7, 7:40 AM · User-Alaa

Tue, Aug 6

alaa_wmde added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.

Thanks @Ladsgroup for all the investigation so far. Even after looking into hadoop, we cannot identify any specific requests that might be responsible for those spikes. In order to move forward, we will add another layer of caching for property terms for now. If the issue persists or appears again for item terms, then we can invest more time in figuring out the root cause of these spikes.

Tue, Aug 6, 4:00 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde moved T229816: RebuildItemTerms (and probably RebuildPropertyTerms) explodes when there's a (double) redirect from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Tue, Aug 6, 3:09 PM · User-Ladsgroup, Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)

Fri, Aug 2

alaa_wmde renamed T229407: Spikes in DB traffic and rows/s reads when reading from new terms store from Wrap new terms store with caching to Spikes in DB traffic and rows/s reads when reading from new terms store.
Fri, Aug 2, 12:51 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.

@Ladsgroup any new findings you wanna add on this here?

Fri, Aug 2, 12:50 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde placed T229407: Spikes in DB traffic and rows/s reads when reading from new terms store up for grabs.

As I will not be able to work on it before next Monday. Feel free to pick up and continue.

Fri, Aug 2, 12:01 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Thu, Aug 1

alaa_wmde added a comment to T229407: Spikes in DB traffic and rows/s reads when reading from new terms store.

After second deployment, we can see spikes on database (rows per second, but also db traffic) every two hours.
https://grafana.wikimedia.org/dashboard/snapshot/qsMbl3Y5NG68EyxYmoAqXoa8FuqoxvQZ

Thu, Aug 1, 10:33 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde added a comment to T224010: Implement Fallback version.

@alaa_wmde For the next change, I guess we should count the languages from the changeOps array then another change will be to modify the edit summary based on the counts result.

Thu, Aug 1, 3:36 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde closed T226008: Lookup obtained via SingleEntitySourceServices::getPrefetchingTermLookup must obey EntitySource, a subtask of T225053: Switch `tmpPropertyTermsMigrationStage` to MIGRATION_WRITE_NEW, as Resolved.
Thu, Aug 1, 2:32 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
alaa_wmde closed T226008: Lookup obtained via SingleEntitySourceServices::getPrefetchingTermLookup must obey EntitySource as Resolved.
Thu, Aug 1, 2:32 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata wb_terms Trailblazing, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)