In T287328#7241874, @Yaron_Koren wrote:

What if the admin put in something like "DELETE * FROM Table" into the prepared statement - would the code check against that? Or is it assumed that an admin would not sabotage his own system?

Yes, this is the assumption. Anyone with access to PHP code and database credentials can send a DROP query, even without *ExternalData* extension.

In T287328#7241793, @Yaron_Koren wrote:

Sorry for the delay. I don't understand the last thing you wrote: "arbitrary SQL queries are effectively disallowed". Would this change remove support for the standard #get_db_data approach?

If LocalSettings.php defines one or more prepared statements for a database connection, then for that connection only those prepared statements can be invoked by {{#get_db_data:}}, and arbitrary queries will not be allowed for them. For such connections, the task of writing SQL queries is transferred to the *MediaWiki* server administrator.

No, only the user themselves can do that by logging into Phabricator via their mw.org/SUL account and removing their LDAP account from their Phab account at https://phabricator.wikimedia.org/settings/panel/external/

I have removed the only LDAP external account from my (Alex Mashin) Phabricator account.

Yes please, as Alex Mashin.

I confirm the request and thank @Kizule for the trouble he took.

Parameter 'default xmlns prefix' is added to be used as default prefix for xmlns when no prefix is provided in the XML.

In T243667#6987257, @jhsoby-WMNO wrote:

We are having this problem on https://lokalhistoriewiki.no/ after upgrading from 1.31 to 1.35.1. The PHP version is 7.4.16. Any idea how to fix it?

Try purging the browser cache and cookies.

@RolandUnger, I don't understand why the task is resolved. Isn't the mw.text library still broken?

Closing this task as, most probaly, resolved during the recent refactoring.

@Platinops, you can upgrade and check.

@Yaron_Koren, please review https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ExternalData/+/648655/.

Does the error persist after updating *ExternalData*?

@Marquerose, after updating *ExternalData*, is there still an error?

It seems that TSRMLS_C, TSRMLS_DC and TSRMLS_CC are not used under PHP 8.0 and have to be redefined as empty, if the extension is built for PHP 8.0. See https://github.com/Imagick/imagick/pull/334/commits.

Somebody please review the patchset. It corrects a bug.

In T49799#6469152, @tstarling wrote:

If the point is just to enable the coroutine module then the proposed change seems unnecessarily complex. As far as I'm concerned, coroutine can be enabled if it passes a security review.

And the security review isn't likely to happen any time soon?

Is the extension still maintained?

Please review the change https://gerrit.wikimedia.org/r/626884.

Cannot reproduce. See https://traditio.wiki/Project:Test/ED/2equals.

Could anybody review the change https://gerrit.wikimedia.org/r/620525?

To enable ModgoDB under PHP 7.4, mongodb extension should be enabled (sudo apt install php-mongodb && sudo phpenmod mongodb; and also mongodb library should be installed with Composer: composer require mongodb/mongodb "^1.6.0" (this will be necessary until bug T259743 is resolved).

Can automated tests read extension.json's requires.platform section and add to the testing environment whatever is missing?

I'll try to implement S for English ordinals, for the time being, and make it overloadable.

Why not jS (see https://www.php.net/manual/en/function.date.php)?

It seems a strange idea to me. Changes in MediaWiki or extensions codebase (per @gh87), Lua modules, templates and pages with Semantic MediaWiki annotations do not propagate themselves along dependencies in realtime; and neither is even the parser cache invalidation.

Will adding |ignore regex parameter to {{#get_web_data:}} help? For comments starting wish hashes, set |ignore regex=/#.*$/m.

Can the bug's author or anybody else share connection settings for LocalSettings.php that allow to connect to a publically accessible MongoDB base?

Do you want to pass the key in an HTTP header?

Have you tried to curl Special:GetData/Fruits_data from your webserver's console?

Shouldn't this be closed as resolved?

Examples of __time usage:

• https://traditio.wiki/Project:Test/ED/XML/XPath (the Retrieved line),
• https://traditio.wiki/WikiApiary (the lines at the bottom of the two collapsible sections of the gray infobox).

Thank you, @Reedy, I have managed, though with great difficulty, to re-synchronise REL1_34 with it origin.

In T254887#6206246, @Yaron_Koren wrote:

That's interesting. What's a use case for parsing HTML with External Data?