Page MenuHomePhabricator

alex-mashin (Alexander Mashin)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Nov 29 2014, 10:11 AM (481 w, 5 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Alex Mashin [ Global Accounts ]

Recent Activity

Wed, Feb 21

alex-mashin added a comment to T354890: Expose cached query page outputs to lua.

See LuaSpecials.

Wed, Feb 21, 9:59 AM · MediaWiki-Special-pages, MediaWiki-extensions-Scribunto

Thu, Feb 15

alex-mashin added a comment to T357668: TypeError: Argument 1 passed to MediaWiki\Parser\Sanitizer::encodeAttribute() must be of the type string, null given, called in /srv/mediawiki/php-1.42.0-wmf.18/includes/xml/Xml.php on line 81.

I think this might happen since Set target to $wgExternalLinkTarget because, in Parser::getExternalLinkAttribs(), the $rel returned by getExternalLinkTarget() can actually be null?

Thu, Feb 15, 3:10 PM · MW-1.39-notes, MW-1.41-notes, MW-1.40-notes, MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), MediaWiki-Parser, Editing-team, ImageMap, Wikimedia-production-error

Wed, Feb 14

alex-mashin added a comment to T66460: Dynamically generate files with Scribunto.

https://gerrit.wikimedia.org/r/113759

Now that graphs are no more,

Wed, Feb 14, 2:53 AM · Patch-Needs-Improvement, MediaWiki-extensions-Scribunto

Wed, Feb 7

alex-mashin closed T356730: Open links in a new tab, if $wgExternalLinkTarget = '_blank' as Resolved.
Wed, Feb 7, 10:24 AM · ImageMap
alex-mashin added a comment to T354050: Allow grid-template-columns: subgrid;.

@Tgr, could you please approve the change, or reject it, or send it to someone else for reviewing?

Wed, Feb 7, 7:05 AM · Patch-For-Review, TemplateStyles, css-sanitizer

Tue, Feb 6

alex-mashin changed the status of T356730: Open links in a new tab, if $wgExternalLinkTarget = '_blank' from Open to In Progress.
Tue, Feb 6, 6:05 AM · ImageMap
alex-mashin created T356730: Open links in a new tab, if $wgExternalLinkTarget = '_blank'.
Tue, Feb 6, 3:34 AM · ImageMap

Mon, Jan 29

alex-mashin added a comment to T354050: Allow grid-template-columns: subgrid;.

Bump.

Mon, Jan 29, 1:33 PM · Patch-For-Review, TemplateStyles, css-sanitizer

Jan 19 2024

alex-mashin added a comment to T355208: "start line" parameter should work for data retrieval from csv-files.

@Kghbln, have you managed to show a fragment of a CSV-file?

Jan 19 2024, 7:10 AM · MediaWiki-extensions-ExternalData

Jan 17 2024

alex-mashin added a comment to T355208: "start line" parameter should work for data retrieval from csv-files.

With start line > 1 CSV with headers will not work. start line and end line are applied to the file before it is parsed and header line is taken into account. You can use header lines = 1 to guarantee that the headers are included, and, therefore, columns have correct names.

Thanks for the info. Good to know. Hmm, this is a noob question, but how can I retrieve just the content from the lines, e.g., five to ten, disregarding the lines one to four? Looks like this is not directly possible. Probably, I have to go via the #store_external_table: parser function and query the data wherever and however I stored them.

Jan 17 2024, 6:10 PM · MediaWiki-extensions-ExternalData
alex-mashin changed the status of T355208: "start line" parameter should work for data retrieval from csv-files from Open to In Progress.
Jan 17 2024, 12:17 PM · MediaWiki-extensions-ExternalData
alex-mashin added a comment to T355208: "start line" parameter should work for data retrieval from csv-files.

With start line > 1 CSV with headers will not work. start line and end line are applied to the file before it is parsed and header line is taken into account. You can use header lines = 1 to guarantee that the headers are included, and, therefore, columns have correct names.

Jan 17 2024, 12:17 PM · MediaWiki-extensions-ExternalData

Dec 30 2023

alex-mashin added a comment to T354050: Allow grid-template-columns: subgrid;.

Subgrid is currently at editor's draft, which is not usually sufficiently stable to add to CSS sanitizer.

Dec 30 2023, 9:50 AM · Patch-For-Review, TemplateStyles, css-sanitizer
alex-mashin added a comment to T354092: Links from Lua modules not listed in [[Special:WhatLinksHere]] or [[Special:WantedPages]].

require 'Module:…' and mw.loadData '…' clauses are effectively links.

Dec 30 2023, 5:03 AM · MediaWiki-extensions-Scribunto, MediaWiki-Special-pages

Dec 29 2023

alex-mashin closed T354090: Malformed JSONpath can cause a PHP warning as Resolved.
Dec 29 2023, 8:04 AM · MediaWiki-extensions-ExternalData
alex-mashin changed the status of T354090: Malformed JSONpath can cause a PHP warning from Open to In Progress.
Dec 29 2023, 5:12 AM · MediaWiki-extensions-ExternalData
alex-mashin created T354090: Malformed JSONpath can cause a PHP warning.
Dec 29 2023, 5:12 AM · MediaWiki-extensions-ExternalData

Dec 27 2023

alex-mashin created T354050: Allow grid-template-columns: subgrid;.
Dec 27 2023, 12:03 PM · Patch-For-Review, TemplateStyles, css-sanitizer

Dec 8 2023

alex-mashin added a comment to T352894: Scribunto / Github integration.

Have you tried Page Exchange?

Dec 8 2023, 3:56 PM · MediaWiki-extensions-Scribunto

Dec 6 2023

alex-mashin closed T351000: Removing table prefixes in column names (EDConnectorDb.php) as Resolved.
Dec 6 2023, 1:34 PM · MediaWiki-extensions-ExternalData
alex-mashin closed T350297: #get_db_data ignores 'join on' clause as Resolved.
Dec 6 2023, 1:34 PM · MediaWiki-extensions-ExternalData

Dec 3 2023

alex-mashin changed the status of T351000: Removing table prefixes in column names (EDConnectorDb.php) from Open to In Progress.
Dec 3 2023, 2:50 PM · MediaWiki-extensions-ExternalData

Nov 26 2023

alex-mashin added a comment to T350297: #get_db_data ignores 'join on' clause.

@Sugarbravo, does it work now?

Nov 26 2023, 8:21 AM · MediaWiki-extensions-ExternalData

Nov 15 2023

alex-mashin added a comment to T350297: #get_db_data ignores 'join on' clause.

Waiting till the 24th of November.

Nov 15 2023, 2:33 AM · MediaWiki-extensions-ExternalData

Nov 14 2023

alex-mashin added a comment to T351052: Exception if {{#get_db_data:}} returns no results.

Already fixed in January.

Nov 14 2023, 12:21 PM · MediaWiki-extensions-ExternalData
alex-mashin closed T351052: Exception if {{#get_db_data:}} returns no results as Invalid.
Nov 14 2023, 12:21 PM · MediaWiki-extensions-ExternalData

Nov 13 2023

alex-mashin created T351052: Exception if {{#get_db_data:}} returns no results.
Nov 13 2023, 3:27 AM · MediaWiki-extensions-ExternalData

Nov 12 2023

alex-mashin added a comment to T350297: #get_db_data ignores 'join on' clause.

@Sugarbravo, have you updated the extension and made sure that JOINs work, so that this task can be closed?

Nov 12 2023, 9:15 AM · MediaWiki-extensions-ExternalData

Nov 11 2023

alex-mashin changed the status of T350297: #get_db_data ignores 'join on' clause from Open to In Progress.
Nov 11 2023, 6:15 AM · MediaWiki-extensions-ExternalData

Nov 10 2023

alex-mashin added a comment to T350297: #get_db_data ignores 'join on' clause.

Thank you fixing this quickly. Will it be ported back to 3.2 or is this for the next version?

Nov 10 2023, 4:30 AM · MediaWiki-extensions-ExternalData

Nov 8 2023

alex-mashin added a comment to T350297: #get_db_data ignores 'join on' clause.

I have updated my patch so that it reproduces the old behaviour of join on. Please note that, in mySQL or MariaDB, that join will always be an inner join, since there is no way to set the type of join in this syntax.

Nov 8 2023, 5:25 AM · MediaWiki-extensions-ExternalData

Nov 2 2023

alex-mashin added a comment to T350297: #get_db_data ignores 'join on' clause.

I have never heard that a table used in a query could be omitted from the from clause, and that mentioning it in the join on would be enough. However, I have submitted a patch allowing this.

Nov 2 2023, 2:41 PM · MediaWiki-extensions-ExternalData
alex-mashin added a comment to T350297: #get_db_data ignores 'join on' clause.

What is the database engine, to which {{#get_db_data:}} connects?

Nov 2 2023, 2:26 AM · MediaWiki-extensions-ExternalData

Sep 21 2023

alex-mashin closed T346856: Type mismatch in EDConnectorExe->run() as Resolved.
Sep 21 2023, 12:10 PM · MediaWiki-extensions-ExternalData

Sep 20 2023

alex-mashin changed the status of T346856: Type mismatch in EDConnectorExe->run() from Open to In Progress.
Sep 20 2023, 2:20 AM · MediaWiki-extensions-ExternalData
alex-mashin created T346856: Type mismatch in EDConnectorExe->run().
Sep 20 2023, 2:20 AM · MediaWiki-extensions-ExternalData

Aug 26 2023

alex-mashin closed T344967: Page Forms JavaScript hangs forever, if free text contains unbalanced double brackets followed by a pipe character as Resolved.
Aug 26 2023, 6:38 AM · MediaWiki-extensions-Page_Forms

Aug 25 2023

alex-mashin created T344967: Page Forms JavaScript hangs forever, if free text contains unbalanced double brackets followed by a pipe character.
Aug 25 2023, 5:32 AM · MediaWiki-extensions-Page_Forms

Aug 21 2023

alex-mashin closed T344578: $this in static methods PFUploadWindow::getInitialPageText() and PFUploadWindow::getExistsWarning() as Invalid.
Aug 21 2023, 2:53 PM · MediaWiki-extensions-Page_Forms
alex-mashin added a comment to T344578: $this in static methods PFUploadWindow::getInitialPageText() and PFUploadWindow::getExistsWarning().

It sounds like you are using the REL1_35 branch of Page Forms. You should switch to the most recent version of Page Forms, which thankfully still supports MW 1.35 - I think this particular bug, or set of bugs, was fixed a long time ago.

Aug 21 2023, 2:53 PM · MediaWiki-extensions-Page_Forms
alex-mashin renamed T344578: $this in static methods PFUploadWindow::getInitialPageText() and PFUploadWindow::getExistsWarning() from $this in static method PFUploadWindow::getInitialPageText() to $this in static methods PFUploadWindow::getInitialPageText() and PFUploadWindow::getExistsWarning().
Aug 21 2023, 8:26 AM · MediaWiki-extensions-Page_Forms
alex-mashin updated the task description for T344578: $this in static methods PFUploadWindow::getInitialPageText() and PFUploadWindow::getExistsWarning().
Aug 21 2023, 6:18 AM · MediaWiki-extensions-Page_Forms
alex-mashin created T344578: $this in static methods PFUploadWindow::getInitialPageText() and PFUploadWindow::getExistsWarning().
Aug 21 2023, 6:11 AM · MediaWiki-extensions-Page_Forms

Jul 27 2023

alex-mashin changed the status of T342898: Column names should be case sensitive in mySQL views from Open to In Progress.
Jul 27 2023, 2:52 PM · MediaWiki-extensions-ExternalData
alex-mashin created T342898: Column names should be case sensitive in mySQL views.
Jul 27 2023, 2:51 PM · MediaWiki-extensions-ExternalData

Jul 19 2023

alex-mashin changed the status of T342098: Type mismatch in MongoDB connector from Open to In Progress.
Jul 19 2023, 3:26 AM · MediaWiki-extensions-ExternalData

Jul 18 2023

alex-mashin claimed T342098: Type mismatch in MongoDB connector.
Jul 18 2023, 10:31 AM · MediaWiki-extensions-ExternalData
alex-mashin created T342098: Type mismatch in MongoDB connector.
Jul 18 2023, 10:29 AM · MediaWiki-extensions-ExternalData

May 11 2023

alex-mashin added a comment to T336457: Add web API caller to Scribunto.

I would like to note that it is already doable with External Data.

May 11 2023, 1:08 AM · MediaWiki-extensions-Scribunto

May 9 2023

alex-mashin closed T335935: SQLite error: Cannot access the database: DB path or directory required as Resolved.
May 9 2023, 9:56 AM · MediaWiki-extensions-ExternalData

May 8 2023

alex-mashin added a comment to T335935: SQLite error: Cannot access the database: DB path or directory required.

@Platinops, please upgrade and see if the patch has helped.

May 8 2023, 3:00 PM · MediaWiki-extensions-ExternalData

May 7 2023

alex-mashin changed the status of T335935: SQLite error: Cannot access the database: DB path or directory required from Open to In Progress.
May 7 2023, 2:10 AM · MediaWiki-extensions-ExternalData

Apr 19 2023

alex-mashin added a comment to T66460: Dynamically generate files with Scribunto.

Why don't you enable inline SVG, which can be generated by whatever mechanism that is available in MediaWiki, including Scribunto, templates or parser functions?

Apr 19 2023, 2:34 AM · Patch-Needs-Improvement, MediaWiki-extensions-Scribunto

Mar 15 2023

alex-mashin updated the task description for T329417: Cross-site scripting in fancy signatures.
Mar 15 2023, 2:05 AM · SecTeam-Processed, MediaWiki-Parser, Security, Security-Team
alex-mashin added a comment to T329417: Cross-site scripting in fancy signatures.

@alex-mashin - I also cannot seem to reproduce this issue under REL1_35 using MediaWiki Docker to serve/test locally. I've tried several variations of the signature within the task description and I can't get an XSS payload to actually execute. Can you tell us a little more about the wiki and/or test environment where this issue was confirmed? Perhaps it's doing something a bit different from a basic MediaWiki install...

Mar 15 2023, 2:03 AM · SecTeam-Processed, MediaWiki-Parser, Security, Security-Team

Mar 13 2023

alex-mashin created T331861: AbuseFliter: Re-storing serialized dumps as JSON-encoded arrays for all rows fails.
Mar 13 2023, 10:43 AM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), AbuseFilter
alex-mashin updated subscribers of T330485: Does the extension ExternalData require "composer/installers": "~2.1"?.
Mar 13 2023, 1:55 AM · NFDI, MediaWiki-extensions-ExternalData
alex-mashin added a comment to T330485: Does the extension ExternalData require "composer/installers": "~2.1"?.

This dependency was introduced by f5f258a by rvogel (@Osnard).

Mar 13 2023, 1:53 AM · NFDI, MediaWiki-extensions-ExternalData

Mar 9 2023

freephile awarded T331588: Allow #get_soap_data to work with private services a 100 token.
Mar 9 2023, 6:45 PM · MediaWiki-extensions-ExternalData
alex-mashin changed the status of T331588: Allow #get_soap_data to work with private services from Open to In Progress.
Mar 9 2023, 12:02 PM · MediaWiki-extensions-ExternalData

Feb 26 2023

alex-mashin closed T287940: Allow {{#get_file_data:}} and {{#get_web_data:}} to enter archives as Resolved.
Feb 26 2023, 10:36 AM · MediaWiki-extensions-ExternalData

Feb 24 2023

alex-mashin updated subscribers of T330485: Does the extension ExternalData require "composer/installers": "~2.1"?.
Feb 24 2023, 5:14 PM · NFDI, MediaWiki-extensions-ExternalData

Feb 14 2023

alex-mashin updated the task description for T329605: Missing Composer dependency wikimedia/avro in MW 1.35.
Feb 14 2023, 7:15 AM · MW-1.35-release, Composer
alex-mashin updated the task description for T329605: Missing Composer dependency wikimedia/avro in MW 1.35.
Feb 14 2023, 7:12 AM · MW-1.35-release, Composer
alex-mashin updated the task description for T329605: Missing Composer dependency wikimedia/avro in MW 1.35.
Feb 14 2023, 7:12 AM · MW-1.35-release, Composer
alex-mashin updated the task description for T329605: Missing Composer dependency wikimedia/avro in MW 1.35.
Feb 14 2023, 7:07 AM · MW-1.35-release, Composer
alex-mashin updated the task description for T329605: Missing Composer dependency wikimedia/avro in MW 1.35.
Feb 14 2023, 7:06 AM · MW-1.35-release, Composer
alex-mashin created T329605: Missing Composer dependency wikimedia/avro in MW 1.35.
Feb 14 2023, 7:06 AM · MW-1.35-release, Composer

Feb 11 2023

alex-mashin updated the task description for T329417: Cross-site scripting in fancy signatures.
Feb 11 2023, 7:28 AM · SecTeam-Processed, MediaWiki-Parser, Security, Security-Team
alex-mashin created T329417: Cross-site scripting in fancy signatures.
Feb 11 2023, 6:52 AM · SecTeam-Processed, MediaWiki-Parser, Security, Security-Team

Feb 4 2023

alex-mashin updated the task description for T293325: Enable use of ShellBox in {{#get_program_data:}}.
Feb 4 2023, 12:35 PM · Shellbox, MediaWiki-extensions-ExternalData

Jan 20 2023

alex-mashin closed T327501: Error on empty resultset from get_db_data with prepared statements as Resolved.
Jan 20 2023, 4:33 PM · MediaWiki-extensions-ExternalData
alex-mashin changed the status of T327501: Error on empty resultset from get_db_data with prepared statements from Open to In Progress.
Jan 20 2023, 2:33 PM · MediaWiki-extensions-ExternalData

Jan 10 2023

alex-mashin closed T326514: CSV files with line breaks in fields are not parsed correctly as Resolved.
Jan 10 2023, 1:33 AM · MediaWiki-extensions-ExternalData

Jan 9 2023

alex-mashin changed the status of T326514: CSV files with line breaks in fields are not parsed correctly from Open to In Progress.
Jan 9 2023, 2:02 PM · MediaWiki-extensions-ExternalData
alex-mashin created T326514: CSV files with line breaks in fields are not parsed correctly.
Jan 9 2023, 3:11 AM · MediaWiki-extensions-ExternalData

Jan 7 2023

alex-mashin updated the task description for T326461: Add universal filtering, sorting and grouping to External Data.
Jan 7 2023, 10:20 AM · MediaWiki-extensions-ExternalData
alex-mashin created T326464: Create a generic parser function for External Data.
Jan 7 2023, 10:18 AM · MediaWiki-extensions-ExternalData
alex-mashin updated the task description for T326463: Add SMW and Cargo queries as types of data sources to External Data.
Jan 7 2023, 10:14 AM · MediaWiki-extensions-ExternalData
alex-mashin created T326463: Add SMW and Cargo queries as types of data sources to External Data.
Jan 7 2023, 10:13 AM · MediaWiki-extensions-ExternalData
alex-mashin created T326462: Create an External Data Querying language.
Jan 7 2023, 10:09 AM · MediaWiki-extensions-ExternalData
alex-mashin created T326461: Add universal filtering, sorting and grouping to External Data.
Jan 7 2023, 9:59 AM · MediaWiki-extensions-ExternalData
alex-mashin created T326460: Register template links.
Jan 7 2023, 9:46 AM · MediaWiki-extensions-ExternalData
alex-mashin updated the task description for T294706: Register external data retrievals for pages.
Jan 7 2023, 9:03 AM · MediaWiki-extensions-Semantic-MediaWiki, MediaWiki-extensions-ExternalData
alex-mashin updated the task description for T294706: Register external data retrievals for pages.
Jan 7 2023, 9:03 AM · MediaWiki-extensions-Semantic-MediaWiki, MediaWiki-extensions-ExternalData
alex-mashin updated the task description for T294706: Register external data retrievals for pages.
Jan 7 2023, 9:03 AM · MediaWiki-extensions-Semantic-MediaWiki, MediaWiki-extensions-ExternalData

Nov 18 2022

alex-mashin changed the status of T318030: Refactor connector and parser choice mechanisms in External Data from Open to In Progress.
Nov 18 2022, 2:54 AM · MediaWiki-extensions-ExternalData

Sep 29 2022

alex-mashin closed T315589: Integrate data retrieval and data display functions as Resolved.
Sep 29 2022, 7:16 AM · MediaWiki-extensions-ExternalData

Sep 19 2022

alex-mashin added a comment to T318029: Quibble fails with UnicodeDecodeError when test output has invalid unicode.

And the failing tests were caused by bug 76584.

Sep 19 2022, 11:04 AM · Release-Engineering-Team (Blocking 🧱), MediaWiki-extensions-ExternalData, ci-test-error, Quibble
alex-mashin added a comment to T318029: Quibble fails with UnicodeDecodeError when test output has invalid unicode.

Thank you, @hashar. I tried to output some diagnostic information, which contained binary data, for a test that had succeeded on my development server but failed when run on MediaWiki gerrit. I sanitised the output, and this issue disappeared, although the test still fails.

Sep 19 2022, 9:00 AM · Release-Engineering-Team (Blocking 🧱), MediaWiki-extensions-ExternalData, ci-test-error, Quibble

Sep 17 2022

alex-mashin updated the task description for T318029: Quibble fails with UnicodeDecodeError when test output has invalid unicode.
Sep 17 2022, 9:15 PM · Release-Engineering-Team (Blocking 🧱), MediaWiki-extensions-ExternalData, ci-test-error, Quibble
alex-mashin updated the task description for T318030: Refactor connector and parser choice mechanisms in External Data.
Sep 17 2022, 12:55 PM · MediaWiki-extensions-ExternalData
alex-mashin created T318030: Refactor connector and parser choice mechanisms in External Data.
Sep 17 2022, 12:52 PM · MediaWiki-extensions-ExternalData
alex-mashin created T318029: Quibble fails with UnicodeDecodeError when test output has invalid unicode.
Sep 17 2022, 12:35 PM · Release-Engineering-Team (Blocking 🧱), MediaWiki-extensions-ExternalData, ci-test-error, Quibble

Sep 16 2022

alex-mashin changed the status of T287940: Allow {{#get_file_data:}} and {{#get_web_data:}} to enter archives from Open to In Progress.
Sep 16 2022, 5:03 AM · MediaWiki-extensions-ExternalData

Sep 10 2022

alex-mashin removed a project from T239512: Allow use of stale cache in {{#get_web_data:}}: Patch-For-Review.
Sep 10 2022, 12:12 PM · MediaWiki-extensions-ExternalData
alex-mashin removed a project from T254551: Configure HTTP request options for {{#get_web_data}}: Patch-For-Review.
Sep 10 2022, 12:11 PM · MediaWiki-extensions-ExternalData

Sep 7 2022

alex-mashin added a comment to T315589: Integrate data retrieval and data display functions.

Basically, I think this can be done by adding three new parameters to the #get_*_data functions: "display template", "additional values" and "display format". This would then allow us to get rid of the #external_value and all the "...external_table" parser functions.

Sep 7 2022, 3:36 PM · MediaWiki-extensions-ExternalData
alex-mashin changed the status of T315589: Integrate data retrieval and data display functions from Open to In Progress.
Sep 7 2022, 3:30 PM · MediaWiki-extensions-ExternalData

Sep 3 2022

alex-mashin closed T315402: Allow secret data sources as Resolved.
Sep 3 2022, 3:51 AM · MediaWiki-extensions-ExternalData