Page MenuHomePhabricator

alex-mashin (alex-mashin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 29 2014, 10:11 AM (242 w, 2 d)
Availability
Available
LDAP User
Alexander Mashin
MediaWiki User
Alex Mashin [ Global Accounts ]

Recent Activity

Tue, Jul 16

alex-mashin added a comment to T215726: MessageCache does not work due to WAN cache stub.

My $wgMainCacheType was set to CACHE_ACCEL, as well as the task author's.

Tue, Jul 16, 1:09 AM · Performance-Team (Radar), MediaWiki-Cache

Mon, Jul 15

alex-mashin renamed T215726: MessageCache does not work due to WAN cache stub from MessageCache does not work due to empty hash to MessageCache does not work due to WAN cache stub.
Mon, Jul 15, 5:02 AM · Performance-Team (Radar), MediaWiki-Cache

Sun, Jul 14

alex-mashin added a comment to T215726: MessageCache does not work due to WAN cache stub.

I killed my whole weekend to find a workaround for this bug.

Sun, Jul 14, 4:26 PM · Performance-Team (Radar), MediaWiki-Cache

Wed, Jul 10

alex-mashin renamed T215726: MessageCache does not work due to WAN cache stub from MessageCache failed with/without $wgMessageCacheType+$wgCacheDirectory to MessageCache does not work due to empty hash.
Wed, Jul 10, 1:42 AM · Performance-Team (Radar), MediaWiki-Cache

Sat, Jul 6

alex-mashin added a comment to T215726: MessageCache does not work due to WAN cache stub.

It seems that I have a similar problem, too (MW 1.31.1).

Sat, Jul 6, 7:15 AM · Performance-Team (Radar), MediaWiki-Cache

Dec 4 2018

alex-mashin added a comment to T207952: wikiapiary not updating.

https://www.wikiapiary.com/wiki/Traditio not updated.

Dec 4 2018, 11:56 AM · WikiApiary

Nov 11 2018

alex-mashin closed T208335: ExternalData doesn't load if $wgDevelopmentWarnings = true or MW version is 1.29 as Resolved.
Nov 11 2018, 7:01 AM · MediaWiki-extensions-ExternalData
alex-mashin closed T208643: TimedMediaHandler is not fully configurable: Class 'WebVideoTranscode' not found as Resolved.
Nov 11 2018, 7:01 AM · TimedMediaHandler
alex-mashin added a comment to T208643: TimedMediaHandler is not fully configurable: Class 'WebVideoTranscode' not found.

OK, thanks, I changed the configuration accordingly.

Nov 11 2018, 7:00 AM · TimedMediaHandler
alex-mashin closed T208669: MobileFrontend breaks MediaWiki 1.31 as Invalid.
Nov 11 2018, 6:59 AM · Readers-Web-Backlog (Tracking), Reading-Web-Third-Party-Support, MobileFrontend
alex-mashin added a comment to T208669: MobileFrontend breaks MediaWiki 1.31.

The issue has gone away. Most probably due to rebuilding the localisation cachem which I had done in connection to another bug.

Nov 11 2018, 6:59 AM · Readers-Web-Backlog (Tracking), Reading-Web-Third-Party-Support, MobileFrontend
alex-mashin added a comment to T208669: MobileFrontend breaks MediaWiki 1.31.

You also may want to check you have the latest Minerva version installed in case it might be trying to use this class.

Nov 11 2018, 6:58 AM · Readers-Web-Backlog (Tracking), Reading-Web-Third-Party-Support, MobileFrontend
alex-mashin updated the task description for T208669: MobileFrontend breaks MediaWiki 1.31.
Nov 11 2018, 6:43 AM · Readers-Web-Backlog (Tracking), Reading-Web-Third-Party-Support, MobileFrontend

Nov 8 2018

alex-mashin added a comment to T208643: TimedMediaHandler is not fully configurable: Class 'WebVideoTranscode' not found.

I used this:

$wgEnabledTranscodeSet = [
    '160p.webm',
    '240p.webm',
    '360p.webm',
    '480p.webm',
    '720p.webm',
    '1080p.webm',
];
Nov 8 2018, 7:07 PM · TimedMediaHandler

Nov 7 2018

alex-mashin added a comment to T208335: ExternalData doesn't load if $wgDevelopmentWarnings = true or MW version is 1.29.

Checking out branch 1.32 (MW stayed at 1.31) and running php maintenance/rebuildLocalisationCache.php --force helped. The extension loads with wfLoadExtension ().

Nov 7 2018, 2:13 PM · MediaWiki-extensions-ExternalData

Nov 4 2018

alex-mashin updated the task description for T208669: MobileFrontend breaks MediaWiki 1.31.
Nov 4 2018, 8:36 AM · Readers-Web-Backlog (Tracking), Reading-Web-Third-Party-Support, MobileFrontend
alex-mashin created T208669: MobileFrontend breaks MediaWiki 1.31.
Nov 4 2018, 8:35 AM · Readers-Web-Backlog (Tracking), Reading-Web-Third-Party-Support, MobileFrontend
alex-mashin added a comment to T208335: ExternalData doesn't load if $wgDevelopmentWarnings = true or MW version is 1.29.

What is in your line 903, as there is no foreach in https://phabricator.wikimedia.org/diffusion/EXDA/browse/REL1_29/ED_Utils.php$903 ?

Nov 4 2018, 7:13 AM · MediaWiki-extensions-ExternalData
alex-mashin renamed T208335: ExternalData doesn't load if $wgDevelopmentWarnings = true or MW version is 1.29 from ExternalData doesn't load to ExternalData doesn't load if $wgDevelopmentWarnings = true or MW version is 1.29.
Nov 4 2018, 6:02 AM · MediaWiki-extensions-ExternalData
alex-mashin added a comment to T208335: ExternalData doesn't load if $wgDevelopmentWarnings = true or MW version is 1.29.

Also see https://lists.wikimedia.org/pipermail/mediawiki-l/2015-February/044096.html

Read the thread, and don't think it is relevant here.

Nov 4 2018, 6:01 AM · MediaWiki-extensions-ExternalData
alex-mashin added a comment to T208643: TimedMediaHandler is not fully configurable: Class 'WebVideoTranscode' not found.

The idea is to add three items to a array at once. This is not the problem. That the class WebVideoTranscode is not available from LocalSettings.php is.

Nov 4 2018, 4:28 AM · TimedMediaHandler

Nov 3 2018

alex-mashin added a comment to T208335: ExternalData doesn't load if $wgDevelopmentWarnings = true or MW version is 1.29.

However, under MediaWiki 1.29 it doesn't work anyway.

Nov 3 2018, 5:15 PM · MediaWiki-extensions-ExternalData
alex-mashin added a comment to T208335: ExternalData doesn't load if $wgDevelopmentWarnings = true or MW version is 1.29.

This error happens only if $wgDevelopmentWarnings = true. Don't know if this is ExternalData's or MediaWiki's bug.

Nov 3 2018, 4:44 PM · MediaWiki-extensions-ExternalData
alex-mashin added a project to T208335: ExternalData doesn't load if $wgDevelopmentWarnings = true or MW version is 1.29: MediaWiki-ResourceLoader.
Nov 3 2018, 2:03 PM · MediaWiki-extensions-ExternalData
alex-mashin added a project to T208335: ExternalData doesn't load if $wgDevelopmentWarnings = true or MW version is 1.29: VisualEditor.
Nov 3 2018, 2:02 PM · MediaWiki-extensions-ExternalData
alex-mashin added a comment to T208335: ExternalData doesn't load if $wgDevelopmentWarnings = true or MW version is 1.29.

The same story after upgrading to MediaWiki 1.31.1, but the backtrace now involves Visual Editor and ResourceLoader:

PHP message: PHP Stack trace:
PHP message: PHP   1. {main}() /var/www/wiki/w/index.php:0
PHP message: PHP   2. MediaWiki->run() /var/www/wiki/w/index.php:42
PHP message: PHP   3. MWExceptionHandler::handleException() /var/www/wiki/w/includes/MediaWiki.
2018/11/03 20:57:33 [error] 32644#32644: *306 FastCGI sent in stderr: "PHP message: PHP Notice:  "" is not a valid magic word for "get_web_data" [Called from Language::getMagic in /var/www/wiki/w/languages/Language.php at line 3181] in /var/www/wiki/w/includes/debug/MWDebug.php on line 309
PHP message: PHP Stack trace:
PHP message: PHP   1. {main}() /var/www/wiki/w/load.php:0
PHP message: PHP   2. ResourceLoader->respond() /var/www/wiki/w/load.php:51
PHP message: PHP   3. ResourceLoader->getCombinedVersion() /var/www/wiki/w/includes/resourceloader/ResourceLoader.php:759
PHP message: PHP   4. array_map() /var/www/wiki/w/includes/resourceloader/ResourceLoader.php:678
PHP message: PHP   5. ResourceLoader->{closure:/var/www/wiki/w/includes/resourceloader/ResourceLoader.php:663-678}() /var/www/wiki/w/includes/resourceloader/ResourceLoader.php:678
PHP message: PHP   6. ResourceLoaderStartUpModule->getVersionHash() /var/www/wiki/w/includes/resourceloader/ResourceLoader.php:665
PHP message: PHP   7. ResourceLoaderStartUpModule->getDefinitionSummary() /var/www/wiki/w/includes/resourceloader/ResourceLoaderModule.php:831
PHP message: PHP   8. ResourceLoaderStartUpModule->getAllModuleHashes() /var/www/wiki/w/includes/resourceloader/ResourceLoaderStartUpModule.php:422
PHP message: PHP   9. ResourceLoader->getCombinedVersion() /var/www/wiki/w/includes/resourceloader/ResourceLoaderStartUpModule.php:449
PHP message: PHP  10. array_map() /var/www/wiki/w/includes/resourceloader/ResourceLoader.php:678
PHP message: PHP  11. ResourceLoader->{closure:/var/www/wiki/w/includes/resourceloader/ResourceLoader.php:663-678}() /var/www/wiki/w/includes/resourceloader/ResourceLoader.php:678
PHP message: PHP  12. VisualEditorDataModule->getVersionHash() /var/www/wiki/w/includes/resourceloader/ResourceLoader.php:665
PHP message: PHP  13. VisualEditorDataModule->getModuleContent() /var/www/wiki/w/includes/resourceloader/ResourceLoaderModule.php:828
PHP message: PHP  14. VisualEditorDataModule->buildContent() /var/www/wiki/w/includes/resourceloade
Nov 3 2018, 2:01 PM · MediaWiki-extensions-ExternalData
alex-mashin renamed T208643: TimedMediaHandler is not fully configurable: Class 'WebVideoTranscode' not found from TimedMediaHandler is not loaded: Class 'WebVideoTranscode' not found to TimedMediaHandler is not fully configurable: Class 'WebVideoTranscode' not found.
Nov 3 2018, 12:10 PM · TimedMediaHandler
alex-mashin created T208643: TimedMediaHandler is not fully configurable: Class 'WebVideoTranscode' not found.
Nov 3 2018, 12:10 PM · TimedMediaHandler

Nov 1 2018

alex-mashin added a comment to T208335: ExternalData doesn't load if $wgDevelopmentWarnings = true or MW version is 1.29.

Anybody reads this?

Nov 1 2018, 3:00 AM · MediaWiki-extensions-ExternalData

Oct 30 2018

alex-mashin created T208335: ExternalData doesn't load if $wgDevelopmentWarnings = true or MW version is 1.29.
Oct 30 2018, 5:12 PM · MediaWiki-extensions-ExternalData

Oct 17 2018

alex-mashin updated the task description for T207262: Incorrect treatment of Javascript template literal by ResourceLoader.
Oct 17 2018, 8:35 AM · Performance-Team, MediaWiki-ResourceLoader
alex-mashin created T207262: Incorrect treatment of Javascript template literal by ResourceLoader.
Oct 17 2018, 8:32 AM · Performance-Team, MediaWiki-ResourceLoader

May 6 2018

alex-mashin added a comment to T176370: Migrate to PHP 7 in WMF production.

but I think we should also have Scribunto for other frameworks, notably Javascript/ECMASCript like Node.js,

It will not be easy to expand Scribunto in any way. See comments in T189767. It seems that the authors of Scribunto view any proposals regarding it as an attack.

May 6 2018, 3:54 AM · Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations

Mar 16 2018

alex-mashin updated the task description for T189767: RFC: Future of Scribunto.
Mar 16 2018, 6:38 AM · Proposal, LuaSandbox, MediaWiki-extensions-Scribunto
alex-mashin added a comment to T189767: RFC: Future of Scribunto.

Several years before Scribunto, a proposal to install Winter extension on WikiMedia sites was rejected.

Do you have a link to that discussion?

Sorry, it was abot ten years ago, and I did not take part in it, only watched; and cannot find it now. Could be in some mailing list or IRC.

Mar 16 2018, 5:01 AM · Proposal, LuaSandbox, MediaWiki-extensions-Scribunto

Mar 15 2018

alex-mashin added a comment to T189767: RFC: Future of Scribunto.

The first three bugs that you have mentioned were created by myself (I intend to close them in favour of this one). I came to a conclusion that those issues are parts of a bigger picture.

Mar 15 2018, 12:02 PM · Proposal, LuaSandbox, MediaWiki-extensions-Scribunto
alex-mashin created T189767: RFC: Future of Scribunto.
Mar 15 2018, 10:48 AM · Proposal, LuaSandbox, MediaWiki-extensions-Scribunto

Feb 24 2018

alex-mashin renamed T178136: Encourage type hints for function parameters and return after moving MediaWiki to PHP 7 from Make type hints for function parameters and return compulsory after moving MediaWiki to PHP 7 to Rncougare type hints for function parameters and return after moving MediaWiki to PHP 7.
Feb 24 2018, 6:05 AM · MediaWiki-Codesniffer, Technical-Debt, MediaWiki-General
alex-mashin added a comment to T178136: Encourage type hints for function parameters and return after moving MediaWiki to PHP 7.

PHP 8 is expected to use JIT, which means that performance is lilkely to be boosted by strict typing.

Feb 24 2018, 5:58 AM · MediaWiki-Codesniffer, Technical-Debt, MediaWiki-General

Feb 22 2018

alex-mashin closed T187670: Allow functions in $wgGrammarForms as Declined.
Feb 22 2018, 3:37 PM · I18n, Patch-For-Review, MediaWiki-General

Feb 21 2018

alex-mashin added a comment to T187670: Allow functions in $wgGrammarForms.

If {{GRAMMAR}} is indeed called client-side, then it's pointless.

Feb 21 2018, 3:16 PM · I18n, Patch-For-Review, MediaWiki-General

Feb 20 2018

alex-mashin added a comment to T187670: Allow functions in $wgGrammarForms.
  1. Who talks about JavaScript? $wgGrammarForms is meant to be set in LocalSettings.php.
  2. How on earth can I know when and where wiki contributors will use {{grammar:}}? They can justifiably do it anywhere; in templates meant for the main namespace, for example.
Feb 20 2018, 12:22 PM · I18n, Patch-For-Review, MediaWiki-General

Feb 19 2018

alex-mashin added a comment to T187670: Allow functions in $wgGrammarForms.

To be able to look up in a dictionary, for example. Or to programmatically implement inflectional paradigms that are more complicated than regular expressions.

Feb 19 2018, 3:00 PM · I18n, Patch-For-Review, MediaWiki-General
alex-mashin created T187670: Allow functions in $wgGrammarForms.
Feb 19 2018, 2:01 AM · I18n, Patch-For-Review, MediaWiki-General

Jan 21 2018

alex-mashin updated the task description for T185406: Composer doesn't enable GraphViz.
Jan 21 2018, 7:32 AM · Composer, GraphViz
alex-mashin created T185406: Composer doesn't enable GraphViz.
Jan 21 2018, 7:30 AM · Composer, GraphViz

Oct 17 2017

alex-mashin updated the task description for T178136: Encourage type hints for function parameters and return after moving MediaWiki to PHP 7.
Oct 17 2017, 6:01 PM · MediaWiki-Codesniffer, Technical-Debt, MediaWiki-General

Oct 15 2017

alex-mashin added a comment to T178136: Encourage type hints for function parameters and return after moving MediaWiki to PHP 7.

declare(strict_types=1); seems more attractive but there could be some problems with hooks. Unless they are restricted to callable, perhaps.

Oct 15 2017, 6:42 AM · MediaWiki-Codesniffer, Technical-Debt, MediaWiki-General

Oct 13 2017

alex-mashin updated the task description for T178146: Add support for Lua 5.2 or 5.3 to luasandbox.
Oct 13 2017, 9:28 AM · LuaSandbox, MediaWiki-extensions-Scribunto
alex-mashin updated the task description for T178146: Add support for Lua 5.2 or 5.3 to luasandbox.
Oct 13 2017, 9:21 AM · LuaSandbox, MediaWiki-extensions-Scribunto
alex-mashin added a project to T178146: Add support for Lua 5.2 or 5.3 to luasandbox: MediaWiki-extensions-Scribunto.
Oct 13 2017, 9:15 AM · LuaSandbox, MediaWiki-extensions-Scribunto
alex-mashin created T178146: Add support for Lua 5.2 or 5.3 to luasandbox.
Oct 13 2017, 9:14 AM · LuaSandbox, MediaWiki-extensions-Scribunto
alex-mashin added a comment to T176370: Migrate to PHP 7 in WMF production.

I therefore suggest a more ambitious goal: make strict typing compulsory in MediaWiki code. This requirement can be enforced by automated testing, as far as I understand.

That's well off-topic for this task. You're welcome to file a separate task for such a proposal.

Done: T178136.

Oct 13 2017, 4:43 AM · Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations
alex-mashin created T178136: Encourage type hints for function parameters and return after moving MediaWiki to PHP 7.
Oct 13 2017, 4:41 AM · MediaWiki-Codesniffer, Technical-Debt, MediaWiki-General

Oct 12 2017

alex-mashin added a comment to T176370: Migrate to PHP 7 in WMF production.

Is there a reason to migrate only to PHP 7.0 and not to PHP 7.1 of even 7.2, as it is going to be released soon?

Oct 12 2017, 2:18 AM · Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations

Oct 8 2017

alex-mashin added a comment to T175229: rebuildLocalisationCache demands a localisation cache.

--force doesn't help.

Oct 8 2017, 12:41 PM · MediaWiki-Maintenance-scripts

Oct 2 2017

alex-mashin added a comment to T174532: Uncacheable queries.

Thank you, now I know that those queries could be cached in spite of the initial SET; that was my concern.

Oct 2 2017, 7:12 AM · MediaWiki-Database

Sep 30 2017

alex-mashin created T177134: Nulls passed to preg_match in Cite.
Sep 30 2017, 6:55 AM · Patch-For-Review, Cite

Sep 24 2017

alex-mashin closed T176552: modding luasandbox as Resolved.
Sep 24 2017, 4:51 AM · MediaWiki-extensions-Scribunto

Sep 23 2017

alex-mashin added a comment to T176552: modding luasandbox.

Formally, this is a request to enhance documentation on linking extra libraries to luasandbox. But if there is no such feature (which, I suspect is the case), then I think this can be closed as resolved by myself.

Sep 23 2017, 7:03 PM · MediaWiki-extensions-Scribunto
alex-mashin added a comment to T176552: modding luasandbox.

Found a more correct way to link extra libraries:

Sep 23 2017, 5:56 PM · MediaWiki-extensions-Scribunto
alex-mashin created T176552: modding luasandbox.
Sep 23 2017, 3:04 PM · MediaWiki-extensions-Scribunto

Sep 11 2017

alex-mashin added a comment to T174549: MessageCache::loadFromDB makes too many slow queries with wrong index.

UPD: I did OPTIMIZE TABLE page; and CHECK TABLE page; (it's a TokuDB table) and the query without the index hint started to use the right one. Don't know, if it was a broken index.

Sep 11 2017, 2:02 PM · Performance-Team (Radar), Wikimedia-database-error, MediaWiki-Cache
alex-mashin updated the task description for T174549: MessageCache::loadFromDB makes too many slow queries with wrong index.
Sep 11 2017, 1:12 PM · Performance-Team (Radar), Wikimedia-database-error, MediaWiki-Cache
alex-mashin renamed T174549: MessageCache::loadFromDB makes too many slow queries with wrong index from Too many queries for messages not using index to Too many slow queries for messages with wrong index.
Sep 11 2017, 1:11 PM · Performance-Team (Radar), Wikimedia-database-error, MediaWiki-Cache
alex-mashin added a comment to T174549: MessageCache::loadFromDB makes too many slow queries with wrong index.

Even worse: these queries use a wrong index on page, at least under MariaDB 10.2.8!

SELECT SQL_NO_CACHE /* MessageCache::loadFromDB(en)-small  */  page_title,old_id,old_text,old_flags  FROM `page`,`revision`,`text`    WHERE page_is_redirect = '0' AND page_namespace = '8' AND (page_title LIKE '%/en' ESCAPE '`' ) AND (page_latest=rev_id) AND (rev_text_id=old_id) AND (page_len <= 131072);
...
1 row in set (2.41 sec)

But if I force the index page_redirect_namespace_len:

SELECT SQL_NO_CACHE /* MessageCache::loadFromDB(en)-small  */  page_title,old_id,old_text,old_flags  FROM `page` USE INDEX (page_redirect_namespace_len),`revision`,`text`    WHERE page_is_redirect = '0' AND page_namespace = '8' AND (page_title LIKE '%/en' ESCAPE '`' ) AND (page_latest=rev_id) AND (rev_text_id=old_id) AND (page_len <= 131072);
...
1 row in set (0.02 sec)

One hundred times faster.
Query plan with the wrong index:

EXPLAIN SELECT /* MessageCache::loadFromDB(en)-small  */  page_title,old_id,old_text,old_flags  FROM `page`,`revision`,`text`    WHERE page_is_redirect = '0' AND page_namespace = '8' AND (page_title LIKE '%/en' ESCAPE '`' ) AND (page_latest=rev_id) AND (rev_text_id=old_id) AND (page_len <= 131072);
+------+-------------+----------+--------+-------------------------------------------------+----------+---------+-----------------------------------+------+-------------+
| id   | select_type | table    | type   | possible_keys                                   | key      | key_len | ref                               | rows | Extra       |
+------+-------------+----------+--------+-------------------------------------------------+----------+---------+-----------------------------------+------+-------------+
|    1 | SIMPLE      | page     | range  | name_title,page_len,page_redirect_namespace_len | page_len | 4       | NULL                              |   81 | Using where |
|    1 | SIMPLE      | revision | eq_ref | rev_id                                          | rev_id   | 4       | (my wiki).page.page_latest     |    1 |             |
|    1 | SIMPLE      | text     | eq_ref | PRIMARY                                         | PRIMARY  | 4       | (my wiki).revision.rev_text_id |    1 |             |
+------+-------------+----------+--------+-------------------------------------------------+----------+---------+-----------------------------------+------+-------------+
3 rows in set (0.01 sec)

With the right index:

EXPLAIN SELECT /* MessageCache::loadFromDB(en)-small  */  page_title,old_id,old_text,old_flags  FROM `page` USE INDEX (page_redirect_namespace_len),`revision`,`text`    WHERE page_is_redirect = '0' AND page_namespace = '8' AND (page_title LIKE '%/en' ESCAPE '`' ) AND (page_latest=rev_id) AND (rev_text_id=old_id) AND (page_len <= 131072);
+------+-------------+----------+--------+-----------------------------+-----------------------------+---------+-----------------------------------+------+-------------+
| id   | select_type | table    | type   | possible_keys               | key                         | key_len | ref                               | rows | Extra       |
+------+-------------+----------+--------+-----------------------------+-----------------------------+---------+-----------------------------------+------+-------------+
|    1 | SIMPLE      | page     | range  | page_redirect_namespace_len | page_redirect_namespace_len | 9       | NULL                              |  493 | Using where |
|    1 | SIMPLE      | revision | eq_ref | rev_id                      | rev_id                      | 4       | (my wiki).page.page_latest     |    1 |             |
|    1 | SIMPLE      | text     | eq_ref | PRIMARY                     | PRIMARY                     | 4       | (my wiki).revision.rev_text_id |    1 |             |
+------+-------------+----------+--------+-----------------------------+-----------------------------+---------+-----------------------------------+------+-------------+
3 rows in set (0.00 sec)

Note the different indices on page.
If I add the following in the line 521 of includes/cache/MessageCache.php:

['USE INDEX' => ['page' => 'page_redirect_namespace_len']]

, my nearly-dead wiki immediately comes back to life..

Sep 11 2017, 1:11 PM · Performance-Team (Radar), Wikimedia-database-error, MediaWiki-Cache
alex-mashin renamed T174549: MessageCache::loadFromDB makes too many slow queries with wrong index from Too many queries for messages to Too many queries for messages not using index.
Sep 11 2017, 12:49 PM · Performance-Team (Radar), Wikimedia-database-error, MediaWiki-Cache

Sep 9 2017

alex-mashin added a comment to T175442: Moving Minerva out of MobileFrontend creates confusing compatibility exception (empty branches).

There is one topic here: empty branches. That master requires MobileFrontend 2.0 is not necessarily an error itself, it just makes using master branch instead of REL1_29 impossible.

Sep 9 2017, 12:58 PM · MinervaNeue (3rd party support), Readers-Web-Backlog (Tracking)
alex-mashin created T175442: Moving Minerva out of MobileFrontend creates confusing compatibility exception (empty branches).
Sep 9 2017, 3:31 AM · MinervaNeue (3rd party support), Readers-Web-Backlog (Tracking)

Sep 7 2017

alex-mashin created T175229: rebuildLocalisationCache demands a localisation cache.
Sep 7 2017, 5:25 AM · MediaWiki-Maintenance-scripts

Aug 30 2017

alex-mashin added a project to T174549: MessageCache::loadFromDB makes too many slow queries with wrong index: MediaWiki-Cache.
Aug 30 2017, 12:59 PM · Performance-Team (Radar), Wikimedia-database-error, MediaWiki-Cache
alex-mashin updated the task description for T174532: Uncacheable queries.
Aug 30 2017, 12:58 PM · MediaWiki-Database
alex-mashin created T174549: MessageCache::loadFromDB makes too many slow queries with wrong index.
Aug 30 2017, 12:57 PM · Performance-Team (Radar), Wikimedia-database-error, MediaWiki-Cache
alex-mashin created T174532: Uncacheable queries.
Aug 30 2017, 7:01 AM · MediaWiki-Database

May 24 2017

alex-mashin added a comment to T163646: HHVM 3.19 incompability: TypeError: Argument 1 passed to mysql_real_escape_string() must be an instance of string, int given.

BTW, why is a deprecated function used at all?

Which deprecated function?

Forget it, I wrote the comment before reading the code, thinking that mysql_real_escape_string () is a standard PHP function, not a method.

May 24 2017, 11:49 AM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.30-release, MW-1.29-release, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), MediaWiki-Database

May 17 2017

alex-mashin added a comment to T163646: HHVM 3.19 incompability: TypeError: Argument 1 passed to mysql_real_escape_string() must be an instance of string, int given.

I worked around this bug with the following change to (path to mediawiki)/includes/libs/rdbms/database/DatabaseMysqli.php:
in line 314 within protected function mysqlRealEscapeString( $s ) replace:
return $conn->real_escape_string( $s );
with:
return $conn->real_escape_string( (string) $s );.

May 17 2017, 6:14 AM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.30-release, MW-1.29-release, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), MediaWiki-Database

Apr 29 2017

alex-mashin updated the task description for T163646: HHVM 3.19 incompability: TypeError: Argument 1 passed to mysql_real_escape_string() must be an instance of string, int given.
Apr 29 2017, 2:56 AM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.30-release, MW-1.29-release, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), MediaWiki-Database

Apr 23 2017

alex-mashin updated the task description for T163646: HHVM 3.19 incompability: TypeError: Argument 1 passed to mysql_real_escape_string() must be an instance of string, int given.
Apr 23 2017, 6:46 PM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.30-release, MW-1.29-release, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), MediaWiki-Database
alex-mashin created T163646: HHVM 3.19 incompability: TypeError: Argument 1 passed to mysql_real_escape_string() must be an instance of string, int given.
Apr 23 2017, 6:37 PM · MW-1.29-release-notes, MW-1.30-release-notes, MW-1.30-release, MW-1.29-release, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), MediaWiki-Database

Feb 1 2017

alex-mashin added a comment to T64356: SquidPurgeClient.php provides no hooks for extensions to purge individual files from non-Squid, non-Varnish content delivery networks.

Such a hook should definitely be added.

Feb 1 2017, 4:57 AM · MediaWiki-General
alex-mashin added a comment to T34454: ArticlePurge hook is broken after r86041.

Looks like the submitted patch has been applied.

Feb 1 2017, 4:38 AM · MediaWiki-General

Jan 29 2017

alex-mashin renamed T156594: VisualEditor-MediaWiki's REL1.28 makes ResourceLoader module session-dependent from Visual Editor breaks Javascript making ResourceLoader module session-dependent to Visual Editor makes ResourceLoader module session-dependent.
Jan 29 2017, 5:33 PM · Performance-Team (Radar), MediaWiki-ResourceLoader, VisualEditor-MediaWiki, VisualEditor
alex-mashin updated the task description for T156594: VisualEditor-MediaWiki's REL1.28 makes ResourceLoader module session-dependent.
Jan 29 2017, 5:32 PM · Performance-Team (Radar), MediaWiki-ResourceLoader, VisualEditor-MediaWiki, VisualEditor
alex-mashin created T156594: VisualEditor-MediaWiki's REL1.28 makes ResourceLoader module session-dependent.
Jan 29 2017, 4:21 PM · Performance-Team (Radar), MediaWiki-ResourceLoader, VisualEditor-MediaWiki, VisualEditor

Jan 24 2017

alex-mashin added a comment to T151523: Unexpected output from Pygments encountered.

Will it be backported to REL1_28?

Jan 24 2017, 2:28 AM · MW-1.28-release, MW-1.27-release, MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), Patch-For-Review, HHVM, SyntaxHighlight

Jan 5 2017

alex-mashin added a comment to T86156: maintenance/updateSearchIndex.php gives Error: 1100 Table 'page_restrictions' was not locked with LOCK TABLES.

Issue present under MW 1.28 (table user_properties).

Jan 5 2017, 6:57 PM · MW-1.25-release, Patch-For-Review, MediaWiki-Maintenance-scripts
alex-mashin added a comment to T42302: maintenance/updateSearchIndex.php gives Error: 1100 Table 'intranet_user' was not locked with LOCK TABLES (localhost).

The same thing with user_properties unde MW 1.28.

Jan 5 2017, 6:56 PM · MediaWiki-Maintenance-scripts

Sep 25 2016

alex-mashin added a comment to T113160: Super-short URLs are formed incorrectly for articles with titles starting with a slash.

And as of MW 1.26.3 and 1.27, this workaround no longer helps.

Sep 25 2016, 3:53 AM · MediaWiki-General

Aug 13 2016

alex-mashin added a comment to T141444: Incorrect treatment of titles starting with a slash when URLs are ultra-short.

You don't understand the logic behind this patch, and I don't fully undestand the logic behind URL processing.

Aug 13 2016, 5:40 AM · MediaWiki-General

Aug 2 2016

alex-mashin added a comment to T140554: Semantic Forms can't be properly installed through Composer autoloading.

Why version "3.5.*" for SF? "3.6.*" would be better anyway to solve this issue, since Yaron removed Composer autoloading for SF.
And which MediaWiki and Semantic MediaWiki versions?

MW 1.27.0, SMW 2.4.1, SF 3.6.

Aug 2 2016, 12:36 PM · MediaWiki-extensions-Page_Forms

Aug 1 2016

alex-mashin added a comment to T140554: Semantic Forms can't be properly installed through Composer autoloading.

Is SMW installed on your wiki?

Yes, it is.

Aug 1 2016, 12:17 PM · MediaWiki-extensions-Page_Forms

Jul 31 2016

alex-mashin added a comment to T140554: Semantic Forms can't be properly installed through Composer autoloading.

Installation with Composer by composer require --prefer-source mediawiki/semantic-forms "3.5.*" is broken totally:

Fatal error: Uncaught Error: Call to undefined method stdClass::getPropertyLabels() in /var/www/wiki/w/extensions/SemanticForms/includes/SF_Utils.php:257\nStack trace:\n#0 /var/www/wiki/w/includes/Hooks.php(195): SFUtils::initProperties()\n#1 /var/www/wiki/w/extensions/SemanticMediaWiki/src/PropertyRegistry.php(420): Hooks::run()\n#2 /var/www/wiki/w/extensions/SemanticMediaWiki/src/PropertyRegistry.php(79): SMW\\PropertyRegistry->registerPredefinedProperties()\n#3 /var/www/wiki/w/extensions/SemanticMediaWiki/includes/dataitems/SMW_DI_Property.php(412): SMW\\PropertyRegistry::getInstance()\n#4 /var/www/wiki/w/extensions/SemanticForms/includes/SF_Utils.php(187): SMW\\DIProperty::newFromUserLabel()\n#5 /var/www/wiki/w/extensions/SemanticForms/includes/SF_FormLinker.php(164): SFUtils::getSMWPropertyValues()\n#6 /var/www/wiki/w/extensions/SemanticForms/includes/SF_FormLinker.php(384): SFFormLinker::getFormsThatPagePointsTo()\n#7 /var/www/wiki/w/extensions/SemanticForms/includes/SF_FormEditAction.php(59): SFFormLinker::getDefaultFormsForPage()\n#8 /var/www/wiki/w/extensions/SemanticForms/includes/SF_FormEditAction.php(145): SFFormEditAction::displayTab()\n#9 /var/www/wiki/w/includes/Hooks.php(195): SFFormEditAction::displayTab2()\n#10 /var/www/wiki/w/includes/skins/SkinTemplate.php(1076): Hooks::run()\n#11 /var/www/wiki/w/includes/skins/SkinTemplate.php(474): SkinTemplate->buildContentNavigationUrls()\n#12 /var/www/wiki/w/includes/skins/SkinTemplate.php(247): SkinTemplate->prepareQuickTemplate()\n#13 /var/www/wiki/w/includes/OutputPage.php(2282): SkinTemplate->outputPage()\n#14 /var/www/wiki/w/includes/MediaWiki.php(756): OutputPage->output()\n#15 /var/www/wiki/w/includes/MediaWiki.php(520): MediaWiki->main()\n#16 /var/www/wiki/w/index.php(43): MediaWiki->run()\n#17 {main}
Jul 31 2016, 5:24 PM · MediaWiki-extensions-Page_Forms
alex-mashin added a comment to T141444: Incorrect treatment of titles starting with a slash when URLs are ultra-short.

Somehow, I've managed to submit this: https://gerrit.wikimedia.org/r/#/c/302088/. I'm afraid this learning curve is too steep for me.

Jul 31 2016, 1:30 PM · MediaWiki-General
alex-mashin added a comment to T141444: Incorrect treatment of titles starting with a slash when URLs are ultra-short.

I think this can be worked around by setting $wgArticlePath to a full URL? Like:

$wgArticlePath = 'https://example.com/$1';

No, it can't. URLs in incoming HTTP requests are treated incorrectly, not wikilinks on pages.

Jul 31 2016, 6:28 AM · MediaWiki-General

Jul 30 2016

alex-mashin added a comment to T141444: Incorrect treatment of titles starting with a slash when URLs are ultra-short.

This configuration is generally not recommended, so I doubt any MediaWiki developers would consider this high priority. We're always happy to accept patches though!

Jul 30 2016, 6:45 PM · MediaWiki-General
alex-mashin added a comment to T141444: Incorrect treatment of titles starting with a slash when URLs are ultra-short.

I think this can be worked around by setting $wgArticlePath to a full URL? Like:

$wgArticlePath = 'https://example.com/$1';

No, it can't. URLs in incoming HTTP requests are treated incorrectly, not wikilinks on pages.

Jul 30 2016, 6:40 PM · MediaWiki-General
alex-mashin added a comment to T141444: Incorrect treatment of titles starting with a slash when URLs are ultra-short.

Anydody here?

Jul 30 2016, 6:22 PM · MediaWiki-General

Jul 28 2016

alex-mashin updated the task description for T141444: Incorrect treatment of titles starting with a slash when URLs are ultra-short.
Jul 28 2016, 4:45 AM · MediaWiki-General
alex-mashin added a comment to T49799: Scribunto should allow coroutines in Lua.

Coroutines, for example, are a natural way to iterate through a nested table.

Jul 28 2016, 3:21 AM · MediaWiki-extensions-Scribunto

Jul 27 2016

alex-mashin created T141444: Incorrect treatment of titles starting with a slash when URLs are ultra-short.
Jul 27 2016, 3:09 PM · MediaWiki-General