In T230379#5813533, @Jdlrobson wrote:

@alexhollender logo is here: https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/565549/2/static/images/mobile/copyright/wikipedia-wordmark-et.svg if you have time to take a look.

Seems like I never replied here. I remember we had a similar task about this regarding Wikipedia. I am still in favor of keeping the welcome message.

In T242310#5790853, @Masumrezarock100 wrote:

4. Possible diff style issues

I am noticing some style issues. Background colors (red and green) extend to the whole line (covers up the spaces without any content). Is this intended or a bug?

Diff in https://commons.m.wikimedia.org/wiki/Special:MobileDiff/386331930

@Jdlrobson @Masumrezarock100 I am having trouble reviewing these fixes.

In T171701#5814080, @Jdlrobson wrote:

Good to think about as we go into the desktop refresh where there's a hamburger given @Nirzar's suggestion that "The hamburger menu UI pattern is not meant for desktops or tablets"

Moving this along. Known issue that the map icon still has this bug, e.g. https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain

@Jdlrobson ok, since it's a gadget I'd be okay with moving this task along without fixing that, however if it's easy to fix at the same time that'd be great.

Looks fixed to me.

two things I'm seeing:

@Ammarpad thanks for the screenshots. It looks great and I think this is sufficient for testing.

Looks good on beta:

I'm unable to access la.wikipedia on the beta cluster. Based on the screenshot here (T240728#5778454) I'm fine with moving this to signoff.

@Ammarpad where should I test this?

Re-opening this task based on T204691#5752221. I've added a revised solution in the description.

In T231205#5779359, @Jdlrobson wrote:

The border-radius is being used on the overflow menu and now the main menu and this menu share code. I assume we want to keep the border radius here?

Ok awesome, looks great

Ah right, I forgot to check desktop. I've updated my comment above to include screenshots from desktop.

In T240728#5776084, @Ammarpad wrote:

I updated the patch

In T204691#5752221, @Krinkle wrote:

[clipped]
I am curious whether you share this perception and consider this darkening a compromise or a universal improvement you would have considered even without this task for the reading experience.
If not, then perhaps the border suggestion that was initially used in the mockup is worth considering?

@N3rsti ok for now I think all that needs to be done is removing the border-radius.

There seems to be one issue here (only affecting iOS) — not sure if we want to re-open this task or create a new one?

@Jdrewniak the menu looks great. With javascript turned off I am not seeing any kind of transition (just wanted to confirm that's expected):

The wordmark looks good. I attempted to make a new SVG file without the extra whitespace.

where and how would we like this to be reviewed?

On beta it looks like the correct shadow is being applied.

screenshot of beta	shadow css

I'm also not sure that login needs to be a top level action, and don't know how we would achieve

The login / create an account page can be accessed with one click

on mobile

In T237019#5751858, @Jdlrobson wrote:

@alexhollender should this apply to all icons? The icon margin is the same for the page actions as the menu items for example under the hamburger - do these need to change too or are we saying that we want label specific behaviour for the page actions?

I wonder if the navigation menu might be thought of the exception here. These are not standard buttons, and since they are presented in a vertical list I find the reduced spacing between the icon and the text to feel a bit tight. I'm not sure if we've explored the readability implications of lists with icon + text in any formal way, @Volker_E?

noting that the same issue seems to be happening with the Contributions icon and the Map icon:

In T232653#5738052, @nray wrote:

@ovasileva @alexhollender Please verify that the screenshots above reflect the current AC of this ticket (everything should be the same in the toolbar and overflow menu across all modes on user pages/user talk pages).

Apologies for the delay. Logo looks great. Resolving this.

I just noticed that the font-weight on the labels is a bit light. According to OOUI we should be using 700, though that looks a bit heavy. Would 500 be an acceptable alternative here @Volker_E?

@olga Jan and I reviewed the prototype. I've updated the task description with a prioritized to-do list. We think all items are achievable by Monday.

as @nray pointed out it might make sense to fix this as part of T232653.

In T232653#5729550, @nray wrote:

@alexhollender @ovasileva On user talk pages, should the contributions icon be in the toolbar for logged in users as well (and link to the same contributions page as when on the associated user page)? Is that part of T235681?

In T230695#5691655, @nray wrote:

I recommend opening a new ticket if this is still a problem as I don't think the fix will be trivial

In T240254#5725522, @Masumrezarock100 wrote:

Talk page messages without a section header are not shown. Are you going to address that issue too?

I've re-scoped this task to logged-out users since logged-in is now taken care of via T232594.

In T233172#5719833, @Jdlrobson wrote:

@alexhollender T238681 fix possibly also fixed this?

@ovasileva @nray just to further clarify: for user pages viewed by anons there should be no changes, e.g.

@Jdlrobson where can I test this?

In T230695#5665085, @Jdlrobson wrote:

If I open a discussion and then click the back button (without adding a reply), when I return to the main talk page it's scrolled all the way down.

From what I can see it scrolls to the thing that was clicked on. Going back takes me to where I was before in the document. Are you saying we want to scroll back to the top of the page in this circumstance? We can do that, we just need to make sure that's the appropriate behaviour here.

@nray two things I've just noticed:

@Volker_E I had imagined something like this (perhaps with the list items rearranged):

another alternative:

I agree that we should increase to 12pt

Checked this out and it looks good. I've added T237019 as a subtask to this and think we should address the spacing issue there.

In T211006#5630616, @Trizek-WMF wrote:

Have you considered to add a link to an help page that would provide best practices to create articles?

In T237561#5642698, @Niedzielski wrote:

@alexhollender, is it important to represent this new setting as a suboption?
...
I haven't looked yet but it may be easier on the tech side to move to the top level so I was curious.

In T236328#5641344, @Volker_E wrote:

How's the behavior on tablet? Same?

In T236328#5637075, @Jdlrobson wrote:

Does this need more discussion or can we go ahead with the original plan (note we can always do follow ups - that patch is pretty small)

I agree with T235737#5639644. Here are two ways we could do that:

In T237230#5637304, @Masumrezarock100 wrote:

That's definitely not the Watchlist page. :-)

@Jdlrobson where are you seeing this? Here is what it looks like for me on History:

iOS / Safari	Mac / Chrome	Android / Chrome

There have been complaints about the size of links and how close together they are (see T237204) so theoretically this could help with that. Increasing the font-size seems worth considering as well.

If possible links to sections or footnotes within the same page should not open in a new tab.

@Masumrezarock100 thanks for creating this task