Page MenuHomePhabricator

alistair3149
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jun 13 2018, 10:31 PM (129 w, 2 d)
Availability
Available
LDAP User
Alistair3149
MediaWiki User
Alistair3149 [ Global Accounts ]

Recent Activity

Oct 15 2020

alistair3149 added a member for Cosmos: alistair3149.
Oct 15 2020, 7:56 PM

Oct 13 2020

alistair3149 added a comment to T265355: MW 1.35 'noindex,nofollow' robot tag on every page.

I'm seeing a very weird bug with MW 1.35 and the Citizen Skin (uses mustache).
Using the Timeless with ?useskin=timeless the robot tag disappears (correct behaviour).
...I've narrowed it down to line 1019 in Article.php.

If it's not happening in 'Timeless', then how are you sure the issue is not from the skin where you're seeing it?. It seems strange also to be skin specific.

You should try another skin, Vector or Monobook to see. And you should also check what's the value of $wgDefaultRobotPolicy in your LocalSettings.php as well as other related variables. It'd be good to also check for NOINDEX magic word usages there.

Oct 13 2020, 11:09 PM · Patch-For-Review, MediaWiki-HTML-Templating
alistair3149 added a project to T265355: MW 1.35 'noindex,nofollow' robot tag on every page: MediaWiki-HTML-Templating.
Oct 13 2020, 1:07 PM · Patch-For-Review, MediaWiki-HTML-Templating

Aug 20 2020

alistair3149 closed T259815: Provide a method to disable core search suggestion as Resolved.

Patch merged to 1.35 in T250851

Aug 20 2020, 3:29 PM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Vue.js (Vue.js-Search), MW-1.35-release

Aug 12 2020

alistair3149 added a comment to T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped.

@Legoktm I cherry-picked the patches required and merged them into a single one.
I am not sure if it is the right way to do it so please let me know if any changes needed to be made.
https://gerrit.wikimedia.org/r/619157

We prefer that commits are cherry-picked just as they were merged in master. If you could cherry-pick it as a stack of patches that would be ideal.

Or if you could list the specific commits that need backporting I can take care of it.

Aug 12 2020, 4:25 PM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Performance-Team (Radar), Vue.js (Vue.js-Search), MediaWiki-Interface, Desktop Improvements

Aug 11 2020

alistair3149 added a comment to T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped.

@Legoktm I cherry-picked the patches required and merged them into a single one.
I am not sure if it is the right way to do it so please let me know if any changes needed to be made.
https://gerrit.wikimedia.org/r/619157

Aug 11 2020, 3:58 PM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Performance-Team (Radar), Vue.js (Vue.js-Search), MediaWiki-Interface, Desktop Improvements
alistair3149 added a comment to T259815: Provide a method to disable core search suggestion.

Relevant discussion and cherry-picked patch are in T250851,

Aug 11 2020, 1:24 AM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Vue.js (Vue.js-Search), MW-1.35-release

Aug 9 2020

alistair3149 added a comment to T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped.

Can this be backported to 1.35? T233677 removed the ability to stop mediawiki.searchSuggest from being loaded and there is no alternatives to do so in 1.35.

Aug 9 2020, 7:30 AM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Performance-Team (Radar), Vue.js (Vue.js-Search), MediaWiki-Interface, Desktop Improvements

Aug 6 2020

alistair3149 updated the task description for T259815: Provide a method to disable core search suggestion.
Aug 6 2020, 5:05 PM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Vue.js (Vue.js-Search), MW-1.35-release
alistair3149 updated the task description for T259815: Provide a method to disable core search suggestion.
Aug 6 2020, 5:01 PM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Vue.js (Vue.js-Search), MW-1.35-release
alistair3149 updated the task description for T259815: Provide a method to disable core search suggestion.
Aug 6 2020, 5:00 PM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Vue.js (Vue.js-Search), MW-1.35-release
alistair3149 added a project to T259815: Provide a method to disable core search suggestion: MediaWiki-Search.
Aug 6 2020, 4:58 PM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Vue.js (Vue.js-Search), MW-1.35-release
alistair3149 updated the task description for T259815: Provide a method to disable core search suggestion.
Aug 6 2020, 4:51 PM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Vue.js (Vue.js-Search), MW-1.35-release
alistair3149 updated the task description for T259815: Provide a method to disable core search suggestion.
Aug 6 2020, 4:49 PM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Vue.js (Vue.js-Search), MW-1.35-release
alistair3149 created T259815: Provide a method to disable core search suggestion.
Aug 6 2020, 4:46 PM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Vue.js (Vue.js-Search), MW-1.35-release

Jun 30 2020

alistair3149 awarded T255100: Consider CSS naming convention/methodology as coding guideline for Wikimedia projects a Love token.
Jun 30 2020, 7:44 AM · CSS, Front-end-Standards-Group

Jun 19 2020

alistair3149 awarded T241946: Support @media (prefers-color-scheme: ...) rule a Love token.
Jun 19 2020, 11:18 PM · css-sanitizer, TemplateStyles
alistair3149 added a comment to T241946: Support @media (prefers-color-scheme: ...) rule.

How many skins have a night mode? There seems little point in having night-mode-compatible templates if the site doesn't actually have a night mode.

The Citizen skin has a night mode. I can't adapt templates to support night mode in my wiki cuz of this. But apparently the skin's original user and creator, the Star Citizen Wiki (starcitizen.tools), have some custom TemplateStyles with support for prefers-color-scheme...

Jun 19 2020, 7:29 AM · css-sanitizer, TemplateStyles

Jun 18 2020

alistair3149 added a comment to T255122: Add project Skin:Citizen to translatewiki.net.

@alistair3149 ,

  1. How often are changes from master deployed to the production server? We don't want translations pushed out from translatewiki to sit idle without being used for long periods of time.
Jun 18 2020, 6:17 PM · Patch-For-Review, Language-Team (Language-2020-Focus-Sprint), translatewiki.net

Jun 16 2020

alistair3149 added a comment to T255122: Add project Skin:Citizen to translatewiki.net.

@alistair3149 -

We've accepted the Github request.

  1. We'll be pushing translations to the master branch on Github.
  2. We're going to be using the following project icon on translatewiki - https://translatewiki.net/wiki/File:Starcitizen-logo.svg
  3. New translations are pushed out twice a week. How often do you release / deploy a new version of the skin?
Jun 16 2020, 12:55 AM · Patch-For-Review, Language-Team (Language-2020-Focus-Sprint), translatewiki.net

Jun 12 2020

alistair3149 added a comment to T255122: Add project Skin:Citizen to translatewiki.net.

@abi_ Thanks for adding the project!
I added the project information to Translatewiki, and commit access is granted too.
Please let me know if there's anything I can do to help.

Jun 12 2020, 8:51 AM · Patch-For-Review, Language-Team (Language-2020-Focus-Sprint), translatewiki.net
alistair3149 awarded T255122: Add project Skin:Citizen to translatewiki.net a Love token.
Jun 12 2020, 8:25 AM · Patch-For-Review, Language-Team (Language-2020-Focus-Sprint), translatewiki.net

Apr 13 2020

alistair3149 added a comment to T219590: Search proposals dropdown (jquery autocomplete) do not work on mobile devices e.g. Vector, Timeless.

@Isarra the portal implementation could theoretically replace the current jQuery autocomplete in the core as a drop-in replacement. One of the major benefit of the new search suggestions (OOUI, Portal, etc.) is that it has rich suggestions with images and descriptions. With both PageImage and TextExtract as default extensions, it might be a decent starting point to replace the jQuery solution.

Apr 13 2020, 8:26 PM · MediaWiki-Interface (autocomplete search), Vue.js, Desktop Improvements, Mobile, Discovery-Search, CirrusSearch

Feb 15 2020

alistair3149 closed T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor as Resolved.

Seems to be a misconfiguration issue on my end.
The issue was resolved after a reinstall of Parsoid, now everything works fine.

Feb 15 2020, 6:35 AM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles

Feb 14 2020

alistair3149 added a comment to T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor.

The Parsoid output is as follow:

madmin@scw-u18lts:/home/www-data/public_html$ grep -C5 parsoid LocalSettings.php
#  'redisServer'    => '127.0.0.1:6379',
Feb 14 2020, 10:20 PM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles
alistair3149 added a comment to T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor.

although I can't tell if it's a bug or misconfiguration

If Parsoid is returning the literal representation then it's failing to recognize the extension tag as being installed. Does <templatestyles> show up on Special:Version? What about in "extensiontags" in action=query&meta=siteinfo?

Feb 14 2020, 9:26 PM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles

Feb 7 2020

alistair3149 added a comment to T243508: Suggestion: Enable the user to choose up-to-date fonts, more legible on LCD screens.

I have to learn about those performance measurements. Could you give some links?

As @Volker_E mentioned, WMF decided to not provide web fonts for large scale projects for now as the trade off on performance and UX is not worth the investment. When a website uses a webfont, the client needs to make a HTTP request then download the font, it is an additional delay on the critical rendering path. Take Roboto as an example, the WOFF2 (most compressed format) for Roboto Regular (400) with basic latin is 16KB. Plus the latency introduced in the HTTP request, it could easily be 2-3 seconds load delay on a slow 3G network. Page load time can be solved with font-display:swap or lazyload, but that will introduce other UX issues such as font popping when web font is loaded. For a site like Wikipedia that serves a lot of people with slower and capped connections, the negative performance impact is significant.

Feb 7 2020, 4:16 AM · User-Demian, Design Research and product team collaboration, Design-Research, Readers-Web-Backlog (Design), Design

Feb 6 2020

alistair3149 added a comment to T243508: Suggestion: Enable the user to choose up-to-date fonts, more legible on LCD screens.

@Volker_E if web fonts are out of the picture for now, I suggest that we should focus on updating the hierarchy on the current Vector skin first to match with the style guide to improve readability. However, it might introduce a lot of problems with existing templates or layout hack uses on WMF sites.

Feb 6 2020, 9:12 PM · User-Demian, Design Research and product team collaboration, Design-Research, Readers-Web-Backlog (Design), Design
alistair3149 added a comment to T243508: Suggestion: Enable the user to choose up-to-date fonts, more legible on LCD screens.

@AronManning The typography that the style guide suggested is not adopted at all by Vector, I suggest that instead of focusing on font choices first, we need to focus on adopting the hierarchy (size, styles, weight, etc.) defined in the style guide as it is more suited for modern day screens. Adopting the hierarchy first will improve the readability issues across different platforms, and also builds a foundation for studying other font choices.

Feb 6 2020, 9:06 PM · User-Demian, Design Research and product team collaboration, Design-Research, Readers-Web-Backlog (Design), Design
alistair3149 added a comment to T243508: Suggestion: Enable the user to choose up-to-date fonts, more legible on LCD screens.

Just curious, is there a particular reason to deviate from the fonts used in the style guide? It would make more sense to adopt the Wikimedia styles that is also used on Minerva and native apps instead of picking other fonts for UI standardizations and many reasons.

Feb 6 2020, 6:46 PM · User-Demian, Design Research and product team collaboration, Design-Research, Readers-Web-Backlog (Design), Design

Feb 5 2020

alistair3149 added a comment to T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor.

@matmarex thanks for looking into it and the praise! Not sure if the following information helps but we don't have RESTBase on the wiki.
Also another weird behavior is that templates placed inside the <tabber> tags (from Extension:Tabber) seems to be not affected.

Feb 5 2020, 12:20 AM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles

Feb 4 2020

alistair3149 added a comment to T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor.

@Ryasmeen instead of inserting a template, it was simply visual editing a page that already has a template in there.

Feb 4 2020, 8:26 PM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles
alistair3149 added a comment to T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor.

@Ryasmeen it is on a non-WMF wiki, here's an example page containing templates using TemplateStyles: https://scwdev.czen.me/Defender
Since it is a dev site, registration is locked and edits are permission only. However, I hope that the following screenshot would help:

Feb 4 2020, 3:49 AM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles

Jan 30 2020

alistair3149 added a comment to T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor.

@Ryasmeen templates with TemplateStyles transclusion means using a template that uses TemplateStyles, aka having <templatestyles src="Template:Foo/style.css">.

Jan 30 2020, 6:33 PM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles

Jan 8 2020

alistair3149 added a comment to T241921: Fix Wikimedia captchas.

@Tgr Agreed. A lot of Mediawiki installations outside of WMF are infested with spam bots. The recommended solution nowadays for third party wiki is to use Questy Captcha, but it is easily beatable. An implementation that will also works on other MW installations will benefit the ecosystem. Maybe an implementation to core or continue on the ConfirmEdit extension?

Jan 8 2020, 6:44 PM · Security, Security-Team, Stewards-and-global-tools, ConfirmEdit (CAPTCHA extension), UX-Debt, Accessibility, Epic
alistair3149 awarded T241921: Fix Wikimedia captchas a Love token.
Jan 8 2020, 6:34 PM · Security, Security-Team, Stewards-and-global-tools, ConfirmEdit (CAPTCHA extension), UX-Debt, Accessibility, Epic
alistair3149 added a comment to T241921: Fix Wikimedia captchas.

As mentioned in T176589, the concept of strength (T179635, T189546) should also be considered to better separate human and bots. From what I recalled, AICaptcha is working towards that and also that's what ReCaptcha V3 is using.

Jan 8 2020, 6:28 AM · Security, Security-Team, Stewards-and-global-tools, ConfirmEdit (CAPTCHA extension), UX-Debt, Accessibility, Epic

Jan 5 2020

alistair3149 committed rESHAf8a67c698671: Fixed various php errors (authored by alistair3149).
Fixed various php errors
Jan 5 2020, 11:44 PM

Dec 29 2019

alistair3149 committed rESHD033542c38abd: Removed extra comma in composer json (authored by alistair3149).
Removed extra comma in composer json
Dec 29 2019, 11:09 PM

Dec 20 2019

alistair3149 committed rESHD151f4e201780: Updated README.md to use the Wikimedia repo (authored by alistair3149).
Updated README.md to use the Wikimedia repo
Dec 20 2019, 8:27 PM

Dec 14 2019

alistair3149 committed rESHD471aebf6f96e: Changed the text on old PHP entry point (authored by alistair3149).
Changed the text on old PHP entry point
Dec 14 2019, 11:24 PM
alistair3149 committed rESHDdcd215bd4210: Merge branch 'master' of github.com:StarCitizenTools/mediawiki-extensions… (authored by alistair3149).
Merge branch 'master' of github.com:StarCitizenTools/mediawiki-extensions…
Dec 14 2019, 11:24 PM
alistair3149 committed rESHDc1a8cc548c3c: Updated link to the extension page (authored by alistair3149).
Updated link to the extension page
Dec 14 2019, 11:24 PM
alistair3149 committed rESHDcd3979a61ddf: Initial commit (authored by alistair3149).
Initial commit
Dec 14 2019, 11:24 PM
alistair3149 committed rESHD6bd45529983d: Updated README.md (authored by alistair3149).
Updated README.md
Dec 14 2019, 11:24 PM

Dec 12 2019

alistair3149 added a comment to T219590: Search proposals dropdown (jquery autocomplete) do not work on mobile devices e.g. Vector, Timeless.

@Oznogon The OOUI search uses a different search widget as I remembered, so it is not affected.
@Jdlrobson I ended up implementing WMTypeAhead with success but I don't know how or where to make a patch, I have given the code to @Isarra and see what he will do with it.

Dec 12 2019, 4:28 AM · MediaWiki-Interface (autocomplete search), Vue.js, Desktop Improvements, Mobile, Discovery-Search, CirrusSearch

Dec 11 2019

alistair3149 added a comment to T219590: Search proposals dropdown (jquery autocomplete) do not work on mobile devices e.g. Vector, Timeless.

@Jdlrobson do you have a pointer on where can I look up the repo for the discovery portal?

Dec 11 2019, 6:55 PM · MediaWiki-Interface (autocomplete search), Vue.js, Desktop Improvements, Mobile, Discovery-Search, CirrusSearch
alistair3149 added a comment to T219590: Search proposals dropdown (jquery autocomplete) do not work on mobile devices e.g. Vector, Timeless.

@Jdlrobson It wasn't a problem in the older MW build like 1.27 so my best guess is that it could be related to the jQuery update to 3.X. Anyways thanks for the pointer, I'll share the result if I can find a solution that would help to migrate this issue.

Dec 11 2019, 6:05 PM · MediaWiki-Interface (autocomplete search), Vue.js, Desktop Improvements, Mobile, Discovery-Search, CirrusSearch
alistair3149 added a comment to T219590: Search proposals dropdown (jquery autocomplete) do not work on mobile devices e.g. Vector, Timeless.

To add onto my comment before, the issue seems to be very widespread. Apart from the WMF wikis, I'm also able to replicate the same bug on RuneScape Wiki (without MF) and PCGamingWiki, in which both of them use a custom skin.

Dec 11 2019, 8:51 AM · MediaWiki-Interface (autocomplete search), Vue.js, Desktop Improvements, Mobile, Discovery-Search, CirrusSearch

Dec 4 2019

alistair3149 added a comment to T219590: Search proposals dropdown (jquery autocomplete) do not work on mobile devices e.g. Vector, Timeless.

@Jdlrobson I am able to replicate the same issue on MW 1.31.3 with a custom skin that I have been developing from scratch without using MobileFrontend. This is clearly not a skin-specific issue.
To add onto what @Wess mentioned, the dropdown only worked when:

  • Through a desktop browser.
  • Through a desktop browser with mobile emulation
  • Through the mobile browser when remote connected to a desktop using Chrome DevTools, but only works when interact through the desktop not the mobile.
Dec 4 2019, 5:01 PM · MediaWiki-Interface (autocomplete search), Vue.js, Desktop Improvements, Mobile, Discovery-Search, CirrusSearch
alistair3149 added a comment to T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor.

Related to the issue I mentioned above, the style transcluded in the template only appear in Visual Edit when it is inside of the <includeonly> tags or when no <includeonly> tags are present in the template. However, in both scenario, the above not parsed bug still present. Not sure if it is the intended behavior.

Dec 4 2019, 5:50 AM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles

Nov 29 2019

Restricted Application added a project to T145541: Make Hovercards work with Special:MyLanguage links: Platform Engineering.
Nov 29 2019, 7:32 PM · MediaWiki-Internationalization, Readers-Web-Backlog, MediaWiki-API, Page-Previews

Nov 27 2019

alistair3149 updated the task description for T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor.
Nov 27 2019, 4:28 AM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles
alistair3149 created T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor.
Nov 27 2019, 2:29 AM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles

Aug 19 2019

alistair3149 created T230756: Syntax highlight overlay misalignment with text area in 2017 wikitext editor.
Aug 19 2019, 10:44 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), User-Ryasmeen, Community-Tech, MediaWiki-extensions-CodeMirror, VisualEditor, Timeless