Page MenuHomePhabricator

alistair3149
Pixel polisher

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jun 13 2018, 10:31 PM (218 w, 2 d)
Availability
Available
LDAP User
Alistair3149
MediaWiki User
Alistair3149 [ Global Accounts ]

I am new to the MediaWiki ecosystem! Currently running the Star Citizen Wiki with a bunch of awesome folks.

I'm a product designer by trade. In my spare time I make pixels fancier or uglier, with code if needed. Here's some of my projects with MW:

Recent Activity

Jun 10 2022

alistair3149 added a comment to T96797: Top-queue stylesheets should be versioned for improved caching.

Just want to chime in some information for community use cases outside of WMF.

Jun 10 2022, 7:28 AM · Performance-Team, MediaWiki-ResourceLoader

Jun 7 2022

alistair3149 added a comment to T213778: Update link colors in Vector 2022 for improved UX (and consistency).

Would it be possible to have a separate high contrast mode with legacy link colors (maybe through prefers-contrast media query)? That might address both the contrast and the technical debt issue.

Jun 7 2022, 5:48 PM · Design-Systems-Team (Design-Systems-Sprint), MW-1.39-notes (1.39.0-wmf.23; 2022-08-01), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2022-23-Q1), User-notice, Editing-team, DiscussionTools, OWC2020 (OWC2020 Replying 2.0), Desktop Improvements, UI-Standardization, Vector

May 27 2022

alistair3149 added a comment to T309398: Article toolbar styling.

For the active tab style, there might be accessibility issue since the only visual difference is the text color and the border color. I would suggest adding an inset box shadow on the active tab so the border would be thicker without causing any wrapping.

May 27 2022, 5:28 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements

May 23 2022

alistair3149 awarded T272624: Menus 2.0: Simplify how we modify menus in MediaWiki a Love token.
May 23 2022, 6:39 PM · MediaWiki-Core-Skin-Architecture (Menus 2.0), Epic
alistair3149 added a comment to T272624: Menus 2.0: Simplify how we modify menus in MediaWiki.

Would it be possible to add some kind of short description associated with the menu item?
It will be useful for providing additional context as secondary text or tooltip.

May 23 2022, 6:39 PM · MediaWiki-Core-Skin-Architecture (Menus 2.0), Epic
alistair3149 awarded T301722: Add interface ComponentRegistryContext a Love token.
May 23 2022, 6:28 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), MediaWiki-Core-Skin-Architecture (Menus 2.0)
alistair3149 added a comment to T270437: "Cannot access the database: Unknown error (localhost)" after installing Mediawiki-Docker.

Adding to what @Soda mentioned above:

May 23 2022, 6:15 PM · MediaWiki-Docker
alistair3149 added a comment to T276962: Job runner in single-MySQL environment fails to obtain a DB connection on `docker-compose up`.
May 23 2022, 6:14 PM · MediaWiki-Docker
alistair3149 awarded T284569: Installing mediawiki-docker on Windows fails a Love token.
May 23 2022, 6:06 PM · MediaWiki-Docker
alistair3149 added a comment to T301812: Add empty state (aka presults) to search to help people discover more knowledge.

To add to the suggestions, some of the existing features in other WMF extensions might be useful and they can be reused:

May 23 2022, 5:00 PM · Codex, Desktop Improvements, Readers-Web-Backlog

May 21 2022

alistair3149 added a comment to T306440: Add markup to article headings to distinguish between the namespace and the title.

Separating namespace and base page name in HTML is an awesome addition. I am commenting here instead of T236215 since this is tagged for MediaWiki-Core-Skin-Architecture.

May 21 2022, 8:48 PM · User-notice, Skipped QA, MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), TPP-Phase1, Editing-team (FY2021-22 Kanban Board), Design, MediaWiki-Core-Skin-Architecture
alistair3149 awarded T301812: Add empty state (aka presults) to search to help people discover more knowledge a Love token.
May 21 2022, 6:20 PM · Codex, Desktop Improvements, Readers-Web-Backlog

May 20 2022

alistair3149 created T308882: Make site stats accessible through Mustache.
May 20 2022, 6:23 PM · MediaWiki-Core-Skin-Architecture
alistair3149 added a watcher for MediaWiki-Core-Skin-Architecture: alistair3149.
May 20 2022, 5:36 PM

May 17 2022

alistair3149 added a comment to T307747: Native image lazyloading should not apply to images above the fold.

Thanks for the quick reply.

May 17 2022, 11:24 PM · Performance-Team (Radar), MediaWiki-General
alistair3149 added a comment to T307747: Native image lazyloading should not apply to images above the fold.

@Krinkle Thanks for the through insights, it's very helpful!

May 17 2022, 10:38 PM · Performance-Team (Radar), MediaWiki-General
alistair3149 committed rESHA0597e62735a2: Fix incorrect MW requirements in readme (authored by alistair3149).
Fix incorrect MW requirements in readme
May 17 2022, 5:04 AM
alistair3149 closed T277659: VE should respect the size set by the thumbnail rather than the intrinsic size as Resolved.

The issue stemmed from how NativeSvgHandler build the thumbnail originally. It is mitigated in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NativeSvgHandler/+/699969

May 17 2022, 3:52 AM · Parsoid (Third-party), Editing-team (Third-party), VisualEditor, VisualEditor-MediaWiki-Media

May 15 2022

alistair3149 added a comment to T183137: "Prefix could not be added to the interwiki table" error with SQLite.

I can reproduce the same issue on the current master branch (1.39) with the local docker setup documented in DEVELOPER.md, which is also using SQLite as database.

May 15 2022, 10:25 PM · Patch-For-Review, MediaWiki-extensions-Interwiki, SQLite

May 14 2022

alistair3149 added a comment to T294885: Add Extension:WikiSEO to English Wikiversity.

Please let me apologize for replying to an old comment, as I just stumbled upon this task no long ago.
I have been reading the related tasks and have caught up with the conversation.

May 14 2022, 8:54 PM · Patch-For-Review, Wikimedia-extension-review-queue, Wikimedia-Site-requests, Wikimedia-Extension-setup

May 13 2022

alistair3149 updated alistair3149.
May 13 2022, 9:08 PM
alistair3149 updated alistair3149.
May 13 2022, 9:06 PM

May 5 2022

alistair3149 created T307747: Native image lazyloading should not apply to images above the fold.
May 5 2022, 9:51 PM · Performance-Team (Radar), MediaWiki-General

Apr 28 2022

alistair3149 added a comment to T304558: WikiApiary.com appears down.

I can also confirm that it has been the issue regularly for the last week. The main page and some of the extension and skin pages are resulting in a 504.

Apr 28 2022, 5:31 AM · WikiApiary

Apr 21 2022

alistair3149 created T306659: Add Extension:TabberNeue to translatewiki.net.
Apr 21 2022, 7:26 PM · Language-Team (Language-2022-April-June), translatewiki.net

Oct 18 2021

alistair3149 added a comment to T293623: Key 8:apihelp-query+description-* already belongs to ext-wikibase-client-api, conflict with mwgithub-shortdescription-api.

It is intentional to use the same description since the ShortDescription is duplicating the feature from Wikibase.

Oct 18 2021, 1:03 PM · Language-Team (Language-2021-October-December), translatewiki.net, affects-translatewiki.net, Wikidata

Jul 30 2021

alistair3149 awarded T287767: Make table of contents available in data format a Love token.
Jul 30 2021, 4:43 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Patch-For-Review, MediaWiki-Parser, MediaWiki-Core-Skin-Architecture
alistair3149 added a comment to T283396: Revisit core thumbnail styles for a more pleasant and predictable default.

Citizen skin (which Alistair works on) does something quite interesting which might be worth considering - the image expands on hover which I think is a much better indication that the image can be interacted with:

Wikiwand also has an alternative solution by overlaying a magnifying icon on hover. However, both solution suffer from the issue that there is lower discoverability because it the image has to be hovered first. I think the core research question would be how does the magnifying icon change the click rate of the thumbnail, and how might we convey the interaction more clearly.

Jul 30 2021, 3:36 PM · Design, MediaWiki-Core-Skin-Architecture
alistair3149 added a comment to T283836: Give skin developers decent default table of contents styles.

@alistair3149: Feel free to file a separate Feature Request covering use cases, the situation, and explaining what "easy" means. Thanks!

Jul 30 2021, 3:15 PM · MediaWiki-Core-Skin-Architecture
alistair3149 added a comment to T283396: Revisit core thumbnail styles for a more pleasant and predictable default.

In any case removing it without reimplementing in a skin like Vector should be user tested before putting into action.

Jul 30 2021, 5:37 AM · Design, MediaWiki-Core-Skin-Architecture
alistair3149 added a comment to T283836: Give skin developers decent default table of contents styles.

Might not be completely related but would it be possible to have an easy way for skin authors to get the content of the ToC and disable the default? In that way skin authors don't have to rely on CSS hacks or JS tricks to duplicate or move the ToC outside of the article.

Jul 30 2021, 5:09 AM · MediaWiki-Core-Skin-Architecture
alistair3149 added a comment to T283396: Revisit core thumbnail styles for a more pleasant and predictable default.

I'm unsure about removing the background since it can cause issues with transparent images. There can be a default solid background which is the same color as the lazyloading placeholder color (base80/90?), so that the UI is unified with other UI components like the search suggestions, Minerva, and the mobile apps.

Jul 30 2021, 5:05 AM · Design, MediaWiki-Core-Skin-Architecture

Jul 28 2021

alistair3149 added a comment to T185284: Timeless WTE2017 preview has inconsistent styling.

Cherry-picked patch to latest stable and LTS

Jul 28 2021, 8:56 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Parsoid (Tracking), VisualEditor-MediaWiki-2017WikitextEditor, Timeless, VisualEditor

Jun 27 2021

alistair3149 added a comment to T135963: Add support for Content-Security-Policy (CSP) headers in MediaWiki.

@Bawolff - What is now the correct way to import images to Commons from 3rd party websites on the client-side? For example, when I currently try to import images from Flickr using UploadWizard, I get the following error:

[Report Only] Refused to connect to 'https://api.flickr.com/services/rest/?&format=json&nojsoncallback=1&method=flickr.photos.licenses.getInfo' because it violates the following Content Security Policy directive: "default-src 'self' data: blob: https://upload.wikimedia.org meta.wikimedia.org *.wikimedia.org *.wikipedia.org *.wikinews.org *.wiktionary.org *.wikibooks.org *.wikiversity.org *.wikisource.org wikisource.org *.wikiquote.org *.wikidata.org *.wikivoyage.org *.mediawiki.org wikimedia.org". Note that 'connect-src' was not explicitly set, so 'default-src' is used as a fallback.

Should we add api.flickr.com to the CSP or does UploadWizard need to be refactored somehow?

Jun 27 2021, 1:28 AM · MediaWiki-General, ContentSecurityPolicy, Platform Team Legacy (Watching / External), TechCom-RFC (TechCom-RFC-Closed), Patch-For-Review, Epic, Security-Team
alistair3149 awarded T135963: Add support for Content-Security-Policy (CSP) headers in MediaWiki a Love token.
Jun 27 2021, 1:21 AM · MediaWiki-General, ContentSecurityPolicy, Platform Team Legacy (Watching / External), TechCom-RFC (TechCom-RFC-Closed), Patch-For-Review, Epic, Security-Team

Jun 15 2021

alistair3149 committed rESHA5bb936c099eb: Bump version and raise minimum MW requirement to 1.35 (authored by alistair3149).
Bump version and raise minimum MW requirement to 1.35
Jun 15 2021, 7:35 PM
alistair3149 committed rESHA7a51fd90b71e: Update SvgImage class with MediaTransformOutput in core (authored by alistair3149).
Update SvgImage class with MediaTransformOutput in core
Jun 15 2021, 7:30 PM
alistair3149 committed rESHA9bca567f2118: Add decoding sync to the img attributes (authored by alistair3149).
Add decoding sync to the img attributes
Jun 15 2021, 7:23 PM
alistair3149 committed rESHA618d52c4c2e1: Add support for native lazyloading in core (authored by alistair3149).
Add support for native lazyloading in core
Jun 15 2021, 7:23 PM

Jun 10 2021

alistair3149 added a comment to T277587: Add Extension:ShortDescription to translatewiki.net.

@alistair3149 - Can you give the user: https://github.com/translatewiki access to push translations to the repository?

Jun 10 2021, 1:26 PM · Language-Team (Language-2021-April-June), translatewiki.net

Jun 4 2021

alistair3149 added a comment to T225529: Article tagline should be set by a hook, not by code highly coupled with Wikibase.

The above all makes sense to me @alistair3149 .

Would this replace the site tag line or would this be additional to that?

Screen Shot 2021-06-03 at 5.39.50 PM.png (164×858 px, 28 KB)

Jun 4 2021, 12:42 PM · Readers-Web-Backlog (Needs Prioritization (Tech)), MediaWiki-Core-Skin-Architecture, wdwb-tech, Technical-Debt, MediaWiki-extensions-WikibaseClient, Wikidata

Jun 2 2021

alistair3149 added a comment to T185284: Timeless WTE2017 preview has inconsistent styling.

The mediawiki.skinning.content.parsoid module is loaded here? https://gerrit.wikimedia.org/g/mediawiki/extensions/VisualEditor/+/10c84cbf34ab026310c3412e9809a2126c0e1b82/extension.json#1729

I'm not sure what is loading mediawiki.skinning.interface... but that's not done by core.

Jun 2 2021, 5:29 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Parsoid (Tracking), VisualEditor-MediaWiki-2017WikitextEditor, Timeless, VisualEditor

May 30 2021

alistair3149 added projects to T185284: Timeless WTE2017 preview has inconsistent styling: MediaWiki-Core-Skin-Architecture, Parsoid.
May 30 2021, 5:17 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Parsoid (Tracking), VisualEditor-MediaWiki-2017WikitextEditor, Timeless, VisualEditor
alistair3149 added a comment to T185284: Timeless WTE2017 preview has inconsistent styling.

After some investigation I discovered that VE is made to load new modules provided by the API on preview (T147702).
Take the output of Gladius page on Wikipedia for example:

May 30 2021, 5:16 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Parsoid (Tracking), VisualEditor-MediaWiki-2017WikitextEditor, Timeless, VisualEditor

May 27 2021

alistair3149 created T283825: Switch project Skin:Citizen branch from master to main.
May 27 2021, 2:41 PM · translatewiki.net

May 26 2021

alistair3149 added a comment to T185284: Timeless WTE2017 preview has inconsistent styling.

For some reason, after clicking preview in VE, it loads core styles (maybe skinning interface but I'm not sure) inline in the head element. Because it is loaded in a <style/>element in <head/>, it overrides any styles with the same specificity and breaks any skins that styles any content element.

May 26 2021, 1:44 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Parsoid (Tracking), VisualEditor-MediaWiki-2017WikitextEditor, Timeless, VisualEditor

May 21 2021

alistair3149 added a comment to T283317: Add Citizen skin on Github to Codesearch.

Thanks :)

May 21 2021, 11:22 PM · VPS-project-Codesearch
alistair3149 added a comment to T225529: Article tagline should be set by a hook, not by code highly coupled with Wikibase.

Yeah I think this should be a core hook, not a skin hook.

Yes it should be a core hook that is accessible by both skins and extensions.

May 21 2021, 6:41 PM · Readers-Web-Backlog (Needs Prioritization (Tech)), MediaWiki-Core-Skin-Architecture, wdwb-tech, Technical-Debt, MediaWiki-extensions-WikibaseClient, Wikidata
alistair3149 created T283317: Add Citizen skin on Github to Codesearch.
May 21 2021, 6:05 AM · VPS-project-Codesearch
alistair3149 added a comment to T225529: Article tagline should be set by a hook, not by code highly coupled with Wikibase.

@alistair3149 I think that would be a great idea. Are you wanting to consume this in a skin that uses SkinMustache or BaseTemplate?

I guess T282170 would need to happen first, as we'd need to get Wikibase and MobileFrontend's handling out of the picture first. Then hopefully it's as simple as adding a value to both template's data.

May 21 2021, 2:07 AM · Readers-Web-Backlog (Needs Prioritization (Tech)), MediaWiki-Core-Skin-Architecture, wdwb-tech, Technical-Debt, MediaWiki-extensions-WikibaseClient, Wikidata

May 20 2021

alistair3149 added a comment to T225529: Article tagline should be set by a hook, not by code highly coupled with Wikibase.

Would there be a possibility to provide a hook in core to override the site tagline so that the same feature can be used by other extensions and skins?
Currently there is no clean way to reproduce the said feature from MF without hardcoding it in the skin like Minerva does.

May 20 2021, 6:08 AM · Readers-Web-Backlog (Needs Prioritization (Tech)), MediaWiki-Core-Skin-Architecture, wdwb-tech, Technical-Debt, MediaWiki-extensions-WikibaseClient, Wikidata

May 19 2021

alistair3149 added a parent task for T278472: UploadWizard should add Flickr API to Content Security Policy when required: T249486: Change Content Security Policy on betacommons to allow api.flickr.com.
May 19 2021, 2:11 PM · ContentSecurityPolicy, UploadWizard
alistair3149 added a subtask for T249486: Change Content Security Policy on betacommons to allow api.flickr.com: T278472: UploadWizard should add Flickr API to Content Security Policy when required.
May 19 2021, 2:11 PM · Security-Team, ContentSecurityPolicy, Wikimedia-Site-requests, Beta-Cluster-Infrastructure

May 7 2021

alistair3149 added a comment to T282170: Move "Short Descriptions" feature outside of main Wikibase.git code.

There is Extension:ShortDescription which reimplements the same functionality and interface on a non-Wikibase basis. If the maintainer is up to it, maybe the Wikibase-related functionality could be moved over there.

@alistair3149: You may be interested to move this extension to Gerrit.

Note as I said in T282172: Make short description work independent of Wikibase (create new short description extension), we need a version that can be co-operated with Wikibase.

May 7 2021, 1:22 AM · Wikidata, Platform Engineering, Product-Infrastructure-Team-Backlog, wdwb-tech

Apr 26 2021

alistair3149 committed rSCOSda7a53949163: Hide action button when VE is active (authored by alistair3149).
Hide action button when VE is active
Apr 26 2021, 4:12 PM

Apr 22 2021

alistair3149 added a comment to T264684: "Invalid response from server." when using hCaptcha and Visual Editor.

Thanks for everyone's help! Cherry-picked the patch for REL1_35.

Apr 22 2021, 5:28 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), VisualEditor, ConfirmEdit (CAPTCHA extension)

Mar 27 2021

alistair3149 added a comment to T278624: Consider `background-repeat: no-repeat` as star selector rule for MediaWiki core.

@alistair3149 A mixin doesn't provide the benefit that I'm aiming at with this proposal. We're throwing down x-dozen repeated background-repeat: no-repeat rules to the client, and would save well on (render-blocking) CSS and unnecessary repetition by devs.
As repeat is the absolute exception.

Mar 27 2021, 10:33 PM · UI-Standardization
alistair3149 added a comment to T217921: Support for prefers-color-scheme CSS @media feature in default skins.

Speaking from experience as a dark skin author, just using @media (prefers-color-scheme: dark) only allow users to manually toggle dark mode though the browser/OS settings. The more useful way is to detect the client's media query flag and adjust the site though JS.

Mar 27 2021, 7:03 PM · MediaWiki-Interface, MediaWiki-Core-Skin-Architecture
alistair3149 awarded T278560: Remove Parsoid specific modules inside ResourceLoaderSkinModule a Love token.
Mar 27 2021, 6:24 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Epic, Technical-Debt, MediaWiki-Core-Skin-Architecture, Parsoid
alistair3149 added a comment to T278624: Consider `background-repeat: no-repeat` as star selector rule for MediaWiki core.

Making more things not-default is not user-friendly.

Mar 27 2021, 4:37 PM · UI-Standardization

Mar 25 2021

alistair3149 created T278472: UploadWizard should add Flickr API to Content Security Policy when required.
Mar 25 2021, 6:49 PM · ContentSecurityPolicy, UploadWizard
alistair3149 added a comment to T264684: "Invalid response from server." when using hCaptcha and Visual Editor.

Submitted a patch based on the NoCaptchaReCaptcha implementation. The config flags are also refactored to not use global variables.

Mar 25 2021, 3:22 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), VisualEditor, ConfirmEdit (CAPTCHA extension)

Mar 23 2021

alistair3149 added a project to T278219: Explicit cookie consent in banner: Privacy.
Mar 23 2021, 2:47 PM · Privacy Engineering, Privacy, Patch-For-Review, MediaWiki-extensions-CookieWarning
alistair3149 updated the task description for T278219: Explicit cookie consent in banner.
Mar 23 2021, 2:46 PM · Privacy Engineering, Privacy, Patch-For-Review, MediaWiki-extensions-CookieWarning
alistair3149 awarded T278219: Explicit cookie consent in banner a Love token.
Mar 23 2021, 12:30 PM · Privacy Engineering, Privacy, Patch-For-Review, MediaWiki-extensions-CookieWarning

Mar 22 2021

alistair3149 added a project to T257936: Support the WebRequest / WebResponse SameSite behavior on the JS side: MW-1.35-release.
Mar 22 2021, 5:40 PM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Growth-Team-Leftovers, Growth-Team (Current Sprint), JavaScript, MediaWiki-General
alistair3149 added a comment to T257936: Support the WebRequest / WebResponse SameSite behavior on the JS side.

Change 674106 had a related patch set uploaded (by Alistair3149; owner: Gergő Tisza):
[mediawiki/core@REL1_35] Support the WebRequest / WebResponse SameSite behavior on the JS side

https://gerrit.wikimedia.org/r/674106

Mar 22 2021, 5:39 PM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Growth-Team-Leftovers, Growth-Team (Current Sprint), JavaScript, MediaWiki-General
alistair3149 added a comment to T132993: mediawiki.cookie JavaScript should set 'secure' attribute for HTTPS-only wikis.

I found it weird that mediawiki.cookie does not honor $wgCookieSecure, as $wgCookieSecure should not be set to true in a mix HTTP/HTTPS configuration anyways. Besides since the introduction of $wgForceHTTPS, mediawiki.cookie should be able to set secure cookies.

Mar 22 2021, 5:29 PM · JavaScript, MediaWiki-General

Mar 20 2021

alistair3149 awarded T274891: [EPIC] MediaUploader MVP a Love token.
Mar 20 2021, 9:42 PM · Epic, MediaUploader

Mar 17 2021

alistair3149 added a comment to T277659: VE should respect the size set by the thumbnail rather than the intrinsic size.

It should be respecting them. Can you provide more detailed instructions on how to reproduce this problem?

Mar 17 2021, 5:59 PM · Parsoid (Third-party), Editing-team (Third-party), VisualEditor, VisualEditor-MediaWiki-Media
alistair3149 created T277659: VE should respect the size set by the thumbnail rather than the intrinsic size.
Mar 17 2021, 1:35 PM · Parsoid (Third-party), Editing-team (Third-party), VisualEditor, VisualEditor-MediaWiki-Media

Mar 16 2021

alistair3149 removed a project from T277589: Archive the ShortDescription extension from Gerrit/CI: Other-skins.
Mar 16 2021, 7:21 PM · User-Kizule, translatewiki.net, MediaWiki-extensions-Other, Wikimedia-GitHub, Diffusion-Repository-Administrators, Projects-Cleanup
alistair3149 created T277589: Archive the ShortDescription extension from Gerrit/CI.
Mar 16 2021, 7:21 PM · User-Kizule, translatewiki.net, MediaWiki-extensions-Other, Wikimedia-GitHub, Diffusion-Repository-Administrators, Projects-Cleanup
alistair3149 added a comment to T277587: Add Extension:ShortDescription to translatewiki.net.

The extension was originally set up in Wikimedia Gerrit, but the Gerrit repo has ceased development and move to GitHub (T277589).

Mar 16 2021, 6:49 PM · Language-Team (Language-2021-April-June), translatewiki.net
alistair3149 created T277587: Add Extension:ShortDescription to translatewiki.net.
Mar 16 2021, 6:48 PM · Language-Team (Language-2021-April-June), translatewiki.net

Mar 11 2021

alistair3149 committed rSCOSb00f5ec5d04a: [Cosmos] tweak rail spacing (authored by alistair3149).
[Cosmos] tweak rail spacing
Mar 11 2021, 6:32 PM
alistair3149 closed T259858: Sitenotice: Button for dismissing content isn't in the right place and does nothing as Resolved.

Patch merged into core

Mar 11 2021, 3:41 AM · MW-1.35-release, MediaWiki-HTML-Templating, Vector (Vector (Tracking)), Regression, DismissableSiteNotice

Mar 9 2021

alistair3149 added a comment to T259858: Sitenotice: Button for dismissing content isn't in the right place and does nothing.

Reopen due to still being an issue on 1.35

Mar 9 2021, 1:46 PM · MW-1.35-release, MediaWiki-HTML-Templating, Vector (Vector (Tracking)), Regression, DismissableSiteNotice
alistair3149 reopened T259858: Sitenotice: Button for dismissing content isn't in the right place and does nothing as "Open".
Mar 9 2021, 1:45 PM · MW-1.35-release, MediaWiki-HTML-Templating, Vector (Vector (Tracking)), Regression, DismissableSiteNotice

Mar 7 2021

alistair3149 added a project to T259858: Sitenotice: Button for dismissing content isn't in the right place and does nothing: MW-1.35-release.
Mar 7 2021, 7:51 PM · MW-1.35-release, MediaWiki-HTML-Templating, Vector (Vector (Tracking)), Regression, DismissableSiteNotice
alistair3149 added a comment to T259872: Echo new message alert has no orange background in vector.

Cherry-picked the fix to 1.35 because of T259858.
Would someone mind to review it?
https://gerrit.wikimedia.org/r/668813

Mar 7 2021, 7:48 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), Vector, Growth-Team, Regression, Notifications
alistair3149 committed rSCOS9ebd20a91b80: [Cosmos] add margin left to indicator (authored by alistair3149).
[Cosmos] add margin left to indicator
Mar 7 2021, 7:41 PM
alistair3149 added a comment to T259858: Sitenotice: Button for dismissing content isn't in the right place and does nothing.

Cherry-picked the core fix to 1.35 instead:
https://gerrit.wikimedia.org/r/668813

Mar 7 2021, 7:37 PM · MW-1.35-release, MediaWiki-HTML-Templating, Vector (Vector (Tracking)), Regression, DismissableSiteNotice

Mar 4 2021

alistair3149 committed rSCOS23273debf546: [Cosmos] align ToC style with thumbnail styles (authored by alistair3149).
[Cosmos] align ToC style with thumbnail styles
Mar 4 2021, 7:00 PM
alistair3149 committed rSCOS4d79af232986: [Cosmos] Reduce page header bottom padding (authored by alistair3149).
[Cosmos] Reduce page header bottom padding
Mar 4 2021, 7:00 PM
alistair3149 committed rSCOS19a31053f0df: [Cosmos] thumbnail should use border-color (authored by alistair3149).
[Cosmos] thumbnail should use border-color
Mar 4 2021, 6:35 PM
alistair3149 committed rSCOS57e41f7db662: [Cosmos] tweak thumbnail styles (authored by alistair3149).
[Cosmos] tweak thumbnail styles
Mar 4 2021, 5:42 PM
alistair3149 committed rSCOSa42d48d22136: [Cosmos] Reimplement 668155 (authored by alistair3149).
[Cosmos] Reimplement 668155
Mar 4 2021, 5:17 PM
alistair3149 committed rSCOSce3943f24a2f: [Cosmos] clean up body styles (authored by alistair3149).
[Cosmos] clean up body styles
Mar 4 2021, 4:52 PM
alistair3149 committed rSCOS39ef0e48118b: [Cosmos] implement idiomatic order (authored by alistair3149).
[Cosmos] implement idiomatic order
Mar 4 2021, 3:52 AM

Feb 20 2021

alistair3149 added a comment to T259858: Sitenotice: Button for dismissing content isn't in the right place and does nothing.

@Ammarpad Would the patch be backported to 1.35 in the form of either core or the extension?
1.35 is the LTS version and the extension is widely used on many wikis.

Feb 20 2021, 9:34 PM · MW-1.35-release, MediaWiki-HTML-Templating, Vector (Vector (Tracking)), Regression, DismissableSiteNotice

Jan 30 2021

alistair3149 added a comment to T271047: CookieWarning appears confusingly inside dismissable sitenotice.

Why? Can't we just make it an absolutely-positioned thing on all skins, at the bottom of the page, like most of the Internet? Also keeping the banner at the top of the page on desktop skins is not optimal, as it obscures vital UI components such as the search box or the site's name on skins like Timeless and Vector.

Jan 30 2021, 4:19 PM · User-RhinosF1, DismissableSiteNotice, MediaWiki-extensions-CookieWarning

Oct 15 2020

alistair3149 added a member for Cosmos: alistair3149.
Oct 15 2020, 7:56 PM

Oct 13 2020

alistair3149 added a comment to T265355: MW 1.35 'noindex,nofollow' robot tag on every page.

I'm seeing a very weird bug with MW 1.35 and the Citizen Skin (uses mustache).
Using the Timeless with ?useskin=timeless the robot tag disappears (correct behaviour).
...I've narrowed it down to line 1019 in Article.php.

If it's not happening in 'Timeless', then how are you sure the issue is not from the skin where you're seeing it?. It seems strange also to be skin specific.

You should try another skin, Vector or Monobook to see. And you should also check what's the value of $wgDefaultRobotPolicy in your LocalSettings.php as well as other related variables. It'd be good to also check for NOINDEX magic word usages there.

Oct 13 2020, 11:09 PM · Patch-For-Review, MediaWiki-HTML-Templating
alistair3149 added a project to T265355: MW 1.35 'noindex,nofollow' robot tag on every page: MediaWiki-HTML-Templating.
Oct 13 2020, 1:07 PM · Patch-For-Review, MediaWiki-HTML-Templating

Aug 20 2020

alistair3149 closed T259815: Provide a method to disable core search suggestion as Resolved.

Patch merged to 1.35 in T250851

Aug 20 2020, 3:29 PM · MediaWiki-Search, Discovery-Search, Desktop Improvements, Design-Systems-team-20200324-20220422 (Vue.js Search Experience (Vector modern)), MW-1.35-release

Aug 12 2020

alistair3149 added a comment to T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped.

@Legoktm I cherry-picked the patches required and merged them into a single one.
I am not sure if it is the right way to do it so please let me know if any changes needed to be made.
https://gerrit.wikimedia.org/r/619157

We prefer that commits are cherry-picked just as they were merged in master. If you could cherry-pick it as a stack of patches that would be ideal.

Or if you could list the specific commits that need backporting I can take care of it.

Aug 12 2020, 4:25 PM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Performance-Team (Radar), Design-Systems-team-20200324-20220422 (Vue.js Search Experience (Vector modern)), MediaWiki-Interface, Desktop Improvements

Aug 11 2020

alistair3149 added a comment to T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped.

@Legoktm I cherry-picked the patches required and merged them into a single one.
I am not sure if it is the right way to do it so please let me know if any changes needed to be made.
https://gerrit.wikimedia.org/r/619157

Aug 11 2020, 3:58 PM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Performance-Team (Radar), Design-Systems-team-20200324-20220422 (Vue.js Search Experience (Vector modern)), MediaWiki-Interface, Desktop Improvements
alistair3149 added a comment to T259815: Provide a method to disable core search suggestion.

Relevant discussion and cherry-picked patch are in T250851,

Aug 11 2020, 1:24 AM · MediaWiki-Search, Discovery-Search, Desktop Improvements, Design-Systems-team-20200324-20220422 (Vue.js Search Experience (Vector modern)), MW-1.35-release

Aug 9 2020

alistair3149 added a comment to T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped.

Can this be backported to 1.35? T233677 removed the ability to stop mediawiki.searchSuggest from being loaded and there is no alternatives to do so in 1.35.

Aug 9 2020, 7:30 AM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Performance-Team (Radar), Design-Systems-team-20200324-20220422 (Vue.js Search Experience (Vector modern)), MediaWiki-Interface, Desktop Improvements