Page MenuHomePhabricator

alistair3149
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jun 13 2018, 10:31 PM (171 w, 2 d)
Availability
Available
LDAP User
Alistair3149
MediaWiki User
Alistair3149 [ Global Accounts ]

Recent Activity

Jul 30 2021

alistair3149 awarded T287767: Make table of contents available in data format a Love token.
Jul 30 2021, 4:43 PM · Desktop Improvements, Patch-For-Review, MediaWiki-Parser, MediaWiki-Core-Skin-Architecture
alistair3149 added a comment to T283396: Revisit core thumbnail styles for a more pleasant and predictable default.

Citizen skin (which Alistair works on) does something quite interesting which might be worth considering - the image expands on hover which I think is a much better indication that the image can be interacted with:

Wikiwand also has an alternative solution by overlaying a magnifying icon on hover. However, both solution suffer from the issue that there is lower discoverability because it the image has to be hovered first. I think the core research question would be how does the magnifying icon change the click rate of the thumbnail, and how might we convey the interaction more clearly.

Jul 30 2021, 3:36 PM · Design, MediaWiki-Core-Skin-Architecture
alistair3149 added a comment to T283836: Give skin developers decent default table of contents styles.

@alistair3149: Feel free to file a separate Feature Request covering use cases, the situation, and explaining what "easy" means. Thanks!

Jul 30 2021, 3:15 PM · MediaWiki-Core-Skin-Architecture
alistair3149 added a comment to T283396: Revisit core thumbnail styles for a more pleasant and predictable default.

In any case removing it without reimplementing in a skin like Vector should be user tested before putting into action.

Jul 30 2021, 5:37 AM · Design, MediaWiki-Core-Skin-Architecture
alistair3149 added a comment to T283836: Give skin developers decent default table of contents styles.

Might not be completely related but would it be possible to have an easy way for skin authors to get the content of the ToC and disable the default? In that way skin authors don't have to rely on CSS hacks or JS tricks to duplicate or move the ToC outside of the article.

Jul 30 2021, 5:09 AM · MediaWiki-Core-Skin-Architecture
alistair3149 added a comment to T283396: Revisit core thumbnail styles for a more pleasant and predictable default.

I'm unsure about removing the background since it can cause issues with transparent images. There can be a default solid background which is the same color as the lazyloading placeholder color (base80/90?), so that the UI is unified with other UI components like the search suggestions, Minerva, and the mobile apps.

Jul 30 2021, 5:05 AM · Design, MediaWiki-Core-Skin-Architecture

Jul 28 2021

alistair3149 added a comment to T185284: Timeless WTE2017 preview has inconsistent styling.

Cherry-picked patch to latest stable and LTS

Jul 28 2021, 8:56 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Parsoid (Tracking), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, Timeless

Jun 27 2021

alistair3149 added a comment to T135963: Add support for Content-Security-Policy (CSP) headers in MediaWiki.

@Bawolff - What is now the correct way to import images to Commons from 3rd party websites on the client-side? For example, when I currently try to import images from Flickr using UploadWizard, I get the following error:

[Report Only] Refused to connect to 'https://api.flickr.com/services/rest/?&format=json&nojsoncallback=1&method=flickr.photos.licenses.getInfo' because it violates the following Content Security Policy directive: "default-src 'self' data: blob: https://upload.wikimedia.org meta.wikimedia.org *.wikimedia.org *.wikipedia.org *.wikinews.org *.wiktionary.org *.wikibooks.org *.wikiversity.org *.wikisource.org wikisource.org *.wikiquote.org *.wikidata.org *.wikivoyage.org *.mediawiki.org wikimedia.org". Note that 'connect-src' was not explicitly set, so 'default-src' is used as a fallback.

Should we add api.flickr.com to the CSP or does UploadWizard need to be refactored somehow?

Jun 27 2021, 1:28 AM · MediaWiki-General, ContentSecurityPolicy, Platform Team Legacy (Watching / External), TechCom-RFC (TechCom-RFC-Closed), Patch-For-Review, Epic, Security-Team
alistair3149 awarded T135963: Add support for Content-Security-Policy (CSP) headers in MediaWiki a Love token.
Jun 27 2021, 1:21 AM · MediaWiki-General, ContentSecurityPolicy, Platform Team Legacy (Watching / External), TechCom-RFC (TechCom-RFC-Closed), Patch-For-Review, Epic, Security-Team

Jun 15 2021

alistair3149 committed rESHA5bb936c099eb: Bump version and raise minimum MW requirement to 1.35 (authored by alistair3149).
Bump version and raise minimum MW requirement to 1.35
Jun 15 2021, 7:35 PM
alistair3149 committed rESHA7a51fd90b71e: Update SvgImage class with MediaTransformOutput in core (authored by alistair3149).
Update SvgImage class with MediaTransformOutput in core
Jun 15 2021, 7:30 PM
alistair3149 committed rESHA9bca567f2118: Add decoding sync to the img attributes (authored by alistair3149).
Add decoding sync to the img attributes
Jun 15 2021, 7:23 PM
alistair3149 committed rESHA618d52c4c2e1: Add support for native lazyloading in core (authored by alistair3149).
Add support for native lazyloading in core
Jun 15 2021, 7:23 PM

Jun 10 2021

alistair3149 added a comment to T277587: Add Extension:ShortDescription to translatewiki.net.

@alistair3149 - Can you give the user: https://github.com/translatewiki access to push translations to the repository?

Jun 10 2021, 1:26 PM · Language-Team (Language-2021-April-June), translatewiki.net

Jun 4 2021

alistair3149 added a comment to T225529: Article tagline should be set by a hook, not by code highly coupled with Wikibase.

The above all makes sense to me @alistair3149 .

Would this replace the site tag line or would this be additional to that?

Screen Shot 2021-06-03 at 5.39.50 PM.png (164×858 px, 28 KB)

Jun 4 2021, 12:42 PM · MediaWiki-Core-Skin-Architecture, wdwb-tech, Readers-Web-Backlog (Tracking), Technical-Debt, MediaWiki-extensions-WikibaseClient, Wikidata

Jun 2 2021

alistair3149 added a comment to T185284: Timeless WTE2017 preview has inconsistent styling.

The mediawiki.skinning.content.parsoid module is loaded here? https://gerrit.wikimedia.org/g/mediawiki/extensions/VisualEditor/+/10c84cbf34ab026310c3412e9809a2126c0e1b82/extension.json#1729

I'm not sure what is loading mediawiki.skinning.interface... but that's not done by core.

Jun 2 2021, 5:29 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Parsoid (Tracking), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, Timeless

May 30 2021

alistair3149 added projects to T185284: Timeless WTE2017 preview has inconsistent styling: MediaWiki-Core-Skin-Architecture, Parsoid.
May 30 2021, 5:17 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Parsoid (Tracking), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, Timeless
alistair3149 added a comment to T185284: Timeless WTE2017 preview has inconsistent styling.

After some investigation I discovered that VE is made to load new modules provided by the API on preview (T147702).
Take the output of Gladius page on Wikipedia for example:

May 30 2021, 5:16 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Parsoid (Tracking), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, Timeless

May 27 2021

alistair3149 created T283825: Switch project Skin:Citizen branch from master to main.
May 27 2021, 2:41 PM · translatewiki.net

May 26 2021

alistair3149 added a comment to T185284: Timeless WTE2017 preview has inconsistent styling.

For some reason, after clicking preview in VE, it loads core styles (maybe skinning interface but I'm not sure) inline in the head element. Because it is loaded in a <style/>element in <head/>, it overrides any styles with the same specificity and breaks any skins that styles any content element.

May 26 2021, 1:44 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Parsoid (Tracking), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, Timeless

May 21 2021

alistair3149 added a comment to T283317: Add Citizen skin on Github to Codesearch.

Thanks :)

May 21 2021, 11:22 PM · VPS-project-Codesearch
alistair3149 added a comment to T225529: Article tagline should be set by a hook, not by code highly coupled with Wikibase.

Yeah I think this should be a core hook, not a skin hook.

Yes it should be a core hook that is accessible by both skins and extensions.

May 21 2021, 6:41 PM · MediaWiki-Core-Skin-Architecture, wdwb-tech, Readers-Web-Backlog (Tracking), Technical-Debt, MediaWiki-extensions-WikibaseClient, Wikidata
alistair3149 created T283317: Add Citizen skin on Github to Codesearch.
May 21 2021, 6:05 AM · VPS-project-Codesearch
alistair3149 added a comment to T225529: Article tagline should be set by a hook, not by code highly coupled with Wikibase.

@alistair3149 I think that would be a great idea. Are you wanting to consume this in a skin that uses SkinMustache or BaseTemplate?

I guess T282170 would need to happen first, as we'd need to get Wikibase and MobileFrontend's handling out of the picture first. Then hopefully it's as simple as adding a value to both template's data.

May 21 2021, 2:07 AM · MediaWiki-Core-Skin-Architecture, wdwb-tech, Readers-Web-Backlog (Tracking), Technical-Debt, MediaWiki-extensions-WikibaseClient, Wikidata

May 20 2021

alistair3149 added a comment to T225529: Article tagline should be set by a hook, not by code highly coupled with Wikibase.

Would there be a possibility to provide a hook in core to override the site tagline so that the same feature can be used by other extensions and skins?
Currently there is no clean way to reproduce the said feature from MF without hardcoding it in the skin like Minerva does.

May 20 2021, 6:08 AM · MediaWiki-Core-Skin-Architecture, wdwb-tech, Readers-Web-Backlog (Tracking), Technical-Debt, MediaWiki-extensions-WikibaseClient, Wikidata

May 19 2021

alistair3149 added a parent task for T278472: UploadWizard should add Flickr API to Content Security Policy when required: T249486: Change Content Security Policy on betacommons to allow api.flickr.com.
May 19 2021, 2:11 PM · ContentSecurityPolicy, UploadWizard
alistair3149 added a subtask for T249486: Change Content Security Policy on betacommons to allow api.flickr.com: T278472: UploadWizard should add Flickr API to Content Security Policy when required.
May 19 2021, 2:11 PM · Security-Team, ContentSecurityPolicy, Wikimedia-Site-requests, Beta-Cluster-Infrastructure

May 7 2021

alistair3149 added a comment to T282170: Move "Short Descriptions" feature outside of main Wikibase.git code.

There is Extension:ShortDescription which reimplements the same functionality and interface on a non-Wikibase basis. If the maintainer is up to it, maybe the Wikibase-related functionality could be moved over there.

@alistair3149: You may be interested to move this extension to Gerrit.

Note as I said in T282172: Make short description work independent of Wikibase (create new short description extension), we need a version that can be co-operated with Wikibase.

May 7 2021, 1:22 AM · Wikidata, Platform Engineering, Product-Infrastructure-Team-Backlog, wdwb-tech

Apr 26 2021

alistair3149 committed rSCOSda7a53949163: Hide action button when VE is active (authored by alistair3149).
Hide action button when VE is active
Apr 26 2021, 4:12 PM

Apr 22 2021

alistair3149 added a comment to T264684: "Invalid response from server." when using hCaptcha and Visual Editor.

Thanks for everyone's help! Cherry-picked the patch for REL1_35.

Apr 22 2021, 5:28 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), VisualEditor, ConfirmEdit (CAPTCHA extension)

Mar 27 2021

alistair3149 added a comment to T278624: Consider `background-repeat: no-repeat` as star selector rule for MediaWiki core.

@alistair3149 A mixin doesn't provide the benefit that I'm aiming at with this proposal. We're throwing down x-dozen repeated background-repeat: no-repeat rules to the client, and would save well on (render-blocking) CSS and unnecessary repetition by devs.
As repeat is the absolute exception.

Mar 27 2021, 10:33 PM · UI-Standardization
alistair3149 added a comment to T217921: Support for prefers-color-scheme CSS @media feature in default skins.

Speaking from experience as a dark skin author, just using @media (prefers-color-scheme: dark) only allow users to manually toggle dark mode though the browser/OS settings. The more useful way is to detect the client's media query flag and adjust the site though JS.

Mar 27 2021, 7:03 PM · MediaWiki-Interface, MediaWiki-Core-Skin-Architecture
alistair3149 awarded T278560: Remove Parsoid specific modules inside ResourceLoaderSkinModule a Love token.
Mar 27 2021, 6:24 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Epic, Technical-Debt, MediaWiki-Core-Skin-Architecture, Parsoid
alistair3149 added a comment to T278624: Consider `background-repeat: no-repeat` as star selector rule for MediaWiki core.

Making more things not-default is not user-friendly.

Mar 27 2021, 4:37 PM · UI-Standardization

Mar 25 2021

alistair3149 created T278472: UploadWizard should add Flickr API to Content Security Policy when required.
Mar 25 2021, 6:49 PM · ContentSecurityPolicy, UploadWizard
alistair3149 added a comment to T264684: "Invalid response from server." when using hCaptcha and Visual Editor.

Submitted a patch based on the NoCaptchaReCaptcha implementation. The config flags are also refactored to not use global variables.

Mar 25 2021, 3:22 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), VisualEditor, ConfirmEdit (CAPTCHA extension)

Mar 23 2021

alistair3149 added a project to T278219: Explicit cookie consent in banner: Privacy.
Mar 23 2021, 2:47 PM · Privacy Engineering, Privacy, Patch-For-Review, MediaWiki-extensions-CookieWarning
alistair3149 updated the task description for T278219: Explicit cookie consent in banner.
Mar 23 2021, 2:46 PM · Privacy Engineering, Privacy, Patch-For-Review, MediaWiki-extensions-CookieWarning
alistair3149 awarded T278219: Explicit cookie consent in banner a Love token.
Mar 23 2021, 12:30 PM · Privacy Engineering, Privacy, Patch-For-Review, MediaWiki-extensions-CookieWarning

Mar 22 2021

alistair3149 added a project to T257936: Support the WebRequest / WebResponse SameSite behavior on the JS side: MW-1.35-release.
Mar 22 2021, 5:40 PM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Growth-Team-Leftovers, Growth-Team (Current Sprint), JavaScript, MediaWiki-General
alistair3149 added a comment to T257936: Support the WebRequest / WebResponse SameSite behavior on the JS side.

Change 674106 had a related patch set uploaded (by Alistair3149; owner: Gergő Tisza):
[mediawiki/core@REL1_35] Support the WebRequest / WebResponse SameSite behavior on the JS side

https://gerrit.wikimedia.org/r/674106

Mar 22 2021, 5:39 PM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Growth-Team-Leftovers, Growth-Team (Current Sprint), JavaScript, MediaWiki-General
alistair3149 added a comment to T132993: mediawiki.cookie JavaScript should set 'secure' attribute for HTTPS-only wikis.

I found it weird that mediawiki.cookie does not honor $wgCookieSecure, as $wgCookieSecure should not be set to true in a mix HTTP/HTTPS configuration anyways. Besides since the introduction of $wgForceHTTPS, mediawiki.cookie should be able to set secure cookies.

Mar 22 2021, 5:29 PM · JavaScript, MediaWiki-General

Mar 20 2021

alistair3149 awarded T274891: [EPIC] MediaUploader MVP a Love token.
Mar 20 2021, 9:42 PM · Epic, MediaUploader

Mar 17 2021

alistair3149 added a comment to T277659: VE should respect the size set by the thumbnail rather than the intrinsic size.

It should be respecting them. Can you provide more detailed instructions on how to reproduce this problem?

Mar 17 2021, 5:59 PM · Parsoid (Third-party), Editing-team (Third-party), VisualEditor, VisualEditor-MediaWiki-Media
alistair3149 created T277659: VE should respect the size set by the thumbnail rather than the intrinsic size.
Mar 17 2021, 1:35 PM · Parsoid (Third-party), Editing-team (Third-party), VisualEditor, VisualEditor-MediaWiki-Media

Mar 16 2021

alistair3149 removed a project from T277589: Archive the ShortDescription extension from Gerrit/CI: Other-skins.
Mar 16 2021, 7:21 PM · translatewiki.net, MediaWiki-extensions-Other, Wikimedia-GitHub, Diffusion-Repository-Administrators, Projects-Cleanup
alistair3149 created T277589: Archive the ShortDescription extension from Gerrit/CI.
Mar 16 2021, 7:21 PM · translatewiki.net, MediaWiki-extensions-Other, Wikimedia-GitHub, Diffusion-Repository-Administrators, Projects-Cleanup
alistair3149 added a comment to T277587: Add Extension:ShortDescription to translatewiki.net.

The extension was originally set up in Wikimedia Gerrit, but the Gerrit repo has ceased development and move to GitHub (T277589).

Mar 16 2021, 6:49 PM · Language-Team (Language-2021-April-June), translatewiki.net
alistair3149 created T277587: Add Extension:ShortDescription to translatewiki.net.
Mar 16 2021, 6:48 PM · Language-Team (Language-2021-April-June), translatewiki.net

Mar 11 2021

alistair3149 committed rSCOSb00f5ec5d04a: [Cosmos] tweak rail spacing (authored by alistair3149).
[Cosmos] tweak rail spacing
Mar 11 2021, 6:32 PM
alistair3149 closed T259858: Sitenotice: Button for dismissing content isn't in the right place and does nothing as Resolved.

Patch merged into core

Mar 11 2021, 3:41 AM · MW-1.35-release, MediaWiki-HTML-Templating, Vector (Vector (Tracking)), Regression, DismissableSiteNotice

Mar 9 2021

alistair3149 added a comment to T259858: Sitenotice: Button for dismissing content isn't in the right place and does nothing.

Reopen due to still being an issue on 1.35

Mar 9 2021, 1:46 PM · MW-1.35-release, MediaWiki-HTML-Templating, Vector (Vector (Tracking)), Regression, DismissableSiteNotice
alistair3149 reopened T259858: Sitenotice: Button for dismissing content isn't in the right place and does nothing as "Open".
Mar 9 2021, 1:45 PM · MW-1.35-release, MediaWiki-HTML-Templating, Vector (Vector (Tracking)), Regression, DismissableSiteNotice

Mar 7 2021

alistair3149 added a project to T259858: Sitenotice: Button for dismissing content isn't in the right place and does nothing: MW-1.35-release.
Mar 7 2021, 7:51 PM · MW-1.35-release, MediaWiki-HTML-Templating, Vector (Vector (Tracking)), Regression, DismissableSiteNotice
alistair3149 added a comment to T259872: Echo new message alert has no orange background in vector.

Cherry-picked the fix to 1.35 because of T259858.
Would someone mind to review it?
https://gerrit.wikimedia.org/r/668813

Mar 7 2021, 7:48 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), Vector, Growth-Team, Regression, Notifications
alistair3149 committed rSCOS9ebd20a91b80: [Cosmos] add margin left to indicator (authored by alistair3149).
[Cosmos] add margin left to indicator
Mar 7 2021, 7:41 PM
alistair3149 added a comment to T259858: Sitenotice: Button for dismissing content isn't in the right place and does nothing.

Cherry-picked the core fix to 1.35 instead:
https://gerrit.wikimedia.org/r/668813

Mar 7 2021, 7:37 PM · MW-1.35-release, MediaWiki-HTML-Templating, Vector (Vector (Tracking)), Regression, DismissableSiteNotice

Mar 4 2021

alistair3149 committed rSCOS23273debf546: [Cosmos] align ToC style with thumbnail styles (authored by alistair3149).
[Cosmos] align ToC style with thumbnail styles
Mar 4 2021, 7:00 PM
alistair3149 committed rSCOS4d79af232986: [Cosmos] Reduce page header bottom padding (authored by alistair3149).
[Cosmos] Reduce page header bottom padding
Mar 4 2021, 7:00 PM
alistair3149 committed rSCOS19a31053f0df: [Cosmos] thumbnail should use border-color (authored by alistair3149).
[Cosmos] thumbnail should use border-color
Mar 4 2021, 6:35 PM
alistair3149 committed rSCOS57e41f7db662: [Cosmos] tweak thumbnail styles (authored by alistair3149).
[Cosmos] tweak thumbnail styles
Mar 4 2021, 5:42 PM
alistair3149 committed rSCOSa42d48d22136: [Cosmos] Reimplement 668155 (authored by alistair3149).
[Cosmos] Reimplement 668155
Mar 4 2021, 5:17 PM
alistair3149 committed rSCOSce3943f24a2f: [Cosmos] clean up body styles (authored by alistair3149).
[Cosmos] clean up body styles
Mar 4 2021, 4:52 PM
alistair3149 committed rSCOS39ef0e48118b: [Cosmos] implement idiomatic order (authored by alistair3149).
[Cosmos] implement idiomatic order
Mar 4 2021, 3:52 AM

Feb 20 2021

alistair3149 added a comment to T259858: Sitenotice: Button for dismissing content isn't in the right place and does nothing.

@Ammarpad Would the patch be backported to 1.35 in the form of either core or the extension?
1.35 is the LTS version and the extension is widely used on many wikis.

Feb 20 2021, 9:34 PM · MW-1.35-release, MediaWiki-HTML-Templating, Vector (Vector (Tracking)), Regression, DismissableSiteNotice

Jan 30 2021

alistair3149 added a comment to T271047: CookieWarning appears confusingly inside dismissable sitenotice.

Why? Can't we just make it an absolutely-positioned thing on all skins, at the bottom of the page, like most of the Internet? Also keeping the banner at the top of the page on desktop skins is not optimal, as it obscures vital UI components such as the search box or the site's name on skins like Timeless and Vector.

Jan 30 2021, 4:19 PM · User-RhinosF1, DismissableSiteNotice, MediaWiki-extensions-CookieWarning

Oct 15 2020

alistair3149 added a member for Cosmos: alistair3149.
Oct 15 2020, 7:56 PM

Oct 13 2020

alistair3149 added a comment to T265355: MW 1.35 'noindex,nofollow' robot tag on every page.

I'm seeing a very weird bug with MW 1.35 and the Citizen Skin (uses mustache).
Using the Timeless with ?useskin=timeless the robot tag disappears (correct behaviour).
...I've narrowed it down to line 1019 in Article.php.

If it's not happening in 'Timeless', then how are you sure the issue is not from the skin where you're seeing it?. It seems strange also to be skin specific.

You should try another skin, Vector or Monobook to see. And you should also check what's the value of $wgDefaultRobotPolicy in your LocalSettings.php as well as other related variables. It'd be good to also check for NOINDEX magic word usages there.

Oct 13 2020, 11:09 PM · Patch-For-Review, MediaWiki-HTML-Templating
alistair3149 added a project to T265355: MW 1.35 'noindex,nofollow' robot tag on every page: MediaWiki-HTML-Templating.
Oct 13 2020, 1:07 PM · Patch-For-Review, MediaWiki-HTML-Templating

Aug 20 2020

alistair3149 closed T259815: Provide a method to disable core search suggestion as Resolved.

Patch merged to 1.35 in T250851

Aug 20 2020, 3:29 PM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Design-Systems-team-project (Vue.js Search Experience (Vector modern)), MW-1.35-release

Aug 12 2020

alistair3149 added a comment to T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped.

@Legoktm I cherry-picked the patches required and merged them into a single one.
I am not sure if it is the right way to do it so please let me know if any changes needed to be made.
https://gerrit.wikimedia.org/r/619157

We prefer that commits are cherry-picked just as they were merged in master. If you could cherry-pick it as a stack of patches that would be ideal.

Or if you could list the specific commits that need backporting I can take care of it.

Aug 12 2020, 4:25 PM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Performance-Team (Radar), Design-Systems-team-project (Vue.js Search Experience (Vector modern)), MediaWiki-Interface, Desktop Improvements

Aug 11 2020

alistair3149 added a comment to T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped.

@Legoktm I cherry-picked the patches required and merged them into a single one.
I am not sure if it is the right way to do it so please let me know if any changes needed to be made.
https://gerrit.wikimedia.org/r/619157

Aug 11 2020, 3:58 PM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Performance-Team (Radar), Design-Systems-team-project (Vue.js Search Experience (Vector modern)), MediaWiki-Interface, Desktop Improvements
alistair3149 added a comment to T259815: Provide a method to disable core search suggestion.

Relevant discussion and cherry-picked patch are in T250851,

Aug 11 2020, 1:24 AM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Design-Systems-team-project (Vue.js Search Experience (Vector modern)), MW-1.35-release

Aug 9 2020

alistair3149 added a comment to T250851: Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped.

Can this be backported to 1.35? T233677 removed the ability to stop mediawiki.searchSuggest from being loaded and there is no alternatives to do so in 1.35.

Aug 9 2020, 7:30 AM · MW-1.35-notes, MW-1.35-release, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Performance-Team (Radar), Design-Systems-team-project (Vue.js Search Experience (Vector modern)), MediaWiki-Interface, Desktop Improvements

Aug 6 2020

alistair3149 updated the task description for T259815: Provide a method to disable core search suggestion.
Aug 6 2020, 5:05 PM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Design-Systems-team-project (Vue.js Search Experience (Vector modern)), MW-1.35-release
alistair3149 updated the task description for T259815: Provide a method to disable core search suggestion.
Aug 6 2020, 5:01 PM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Design-Systems-team-project (Vue.js Search Experience (Vector modern)), MW-1.35-release
alistair3149 updated the task description for T259815: Provide a method to disable core search suggestion.
Aug 6 2020, 5:00 PM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Design-Systems-team-project (Vue.js Search Experience (Vector modern)), MW-1.35-release
alistair3149 added a project to T259815: Provide a method to disable core search suggestion: MediaWiki-Search.
Aug 6 2020, 4:58 PM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Design-Systems-team-project (Vue.js Search Experience (Vector modern)), MW-1.35-release
alistair3149 updated the task description for T259815: Provide a method to disable core search suggestion.
Aug 6 2020, 4:51 PM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Design-Systems-team-project (Vue.js Search Experience (Vector modern)), MW-1.35-release
alistair3149 updated the task description for T259815: Provide a method to disable core search suggestion.
Aug 6 2020, 4:49 PM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Design-Systems-team-project (Vue.js Search Experience (Vector modern)), MW-1.35-release
alistair3149 created T259815: Provide a method to disable core search suggestion.
Aug 6 2020, 4:46 PM · Discovery-Search, MediaWiki-Search, Desktop Improvements, Design-Systems-team-project (Vue.js Search Experience (Vector modern)), MW-1.35-release

Jun 30 2020

alistair3149 awarded T255100: Consider CSS naming convention/methodology as coding guideline for Wikimedia projects a Love token.
Jun 30 2020, 7:44 AM · CSS, Front-end-Standards-Group

Jun 19 2020

alistair3149 awarded T241946: Support @media (prefers-color-scheme: ...) rule a Love token.
Jun 19 2020, 11:18 PM · css-sanitizer, TemplateStyles
alistair3149 added a comment to T241946: Support @media (prefers-color-scheme: ...) rule.

How many skins have a night mode? There seems little point in having night-mode-compatible templates if the site doesn't actually have a night mode.

The Citizen skin has a night mode. I can't adapt templates to support night mode in my wiki cuz of this. But apparently the skin's original user and creator, the Star Citizen Wiki (starcitizen.tools), have some custom TemplateStyles with support for prefers-color-scheme...

Jun 19 2020, 7:29 AM · css-sanitizer, TemplateStyles

Jun 18 2020

alistair3149 added a comment to T255122: Add project Skin:Citizen to translatewiki.net.

@alistair3149 ,

  1. How often are changes from master deployed to the production server? We don't want translations pushed out from translatewiki to sit idle without being used for long periods of time.
Jun 18 2020, 6:17 PM · Patch-For-Review, Language-Team (Language-2020-Focus-Sprint), translatewiki.net

Jun 16 2020

alistair3149 added a comment to T255122: Add project Skin:Citizen to translatewiki.net.

@alistair3149 -

We've accepted the Github request.

  1. We'll be pushing translations to the master branch on Github.
  2. We're going to be using the following project icon on translatewiki - https://translatewiki.net/wiki/File:Starcitizen-logo.svg
  3. New translations are pushed out twice a week. How often do you release / deploy a new version of the skin?
Jun 16 2020, 12:55 AM · Patch-For-Review, Language-Team (Language-2020-Focus-Sprint), translatewiki.net

Jun 12 2020

alistair3149 added a comment to T255122: Add project Skin:Citizen to translatewiki.net.

@abi_ Thanks for adding the project!
I added the project information to Translatewiki, and commit access is granted too.
Please let me know if there's anything I can do to help.

Jun 12 2020, 8:51 AM · Patch-For-Review, Language-Team (Language-2020-Focus-Sprint), translatewiki.net
alistair3149 awarded T255122: Add project Skin:Citizen to translatewiki.net a Love token.
Jun 12 2020, 8:25 AM · Patch-For-Review, Language-Team (Language-2020-Focus-Sprint), translatewiki.net

Apr 13 2020

alistair3149 added a comment to T219590: Search proposals dropdown (jquery autocomplete) do not work on mobile devices e.g. Vector, Timeless.

@Isarra the portal implementation could theoretically replace the current jQuery autocomplete in the core as a drop-in replacement. One of the major benefit of the new search suggestions (OOUI, Portal, etc.) is that it has rich suggestions with images and descriptions. With both PageImage and TextExtract as default extensions, it might be a decent starting point to replace the jQuery solution.

Apr 13 2020, 8:26 PM · Design-Systems-team-project (Vue.js Search Experience (Vector modern)), MediaWiki-Interface (autocomplete search), Desktop Improvements, Mobile, CirrusSearch, Discovery-Search

Feb 15 2020

alistair3149 closed T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor as Resolved.

Seems to be a misconfiguration issue on my end.
The issue was resolved after a reinstall of Parsoid, now everything works fine.

Feb 15 2020, 6:35 AM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles

Feb 14 2020

alistair3149 added a comment to T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor.

The Parsoid output is as follow:

madmin@scw-u18lts:/home/www-data/public_html$ grep -C5 parsoid LocalSettings.php
#  'redisServer'    => '127.0.0.1:6379',
Feb 14 2020, 10:20 PM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles
alistair3149 added a comment to T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor.

although I can't tell if it's a bug or misconfiguration

If Parsoid is returning the literal representation then it's failing to recognize the extension tag as being installed. Does <templatestyles> show up on Special:Version? What about in "extensiontags" in action=query&meta=siteinfo?

Feb 14 2020, 9:26 PM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles

Feb 7 2020

alistair3149 added a comment to T243508: Suggestion: Enable the user to choose up-to-date fonts, more legible on LCD screens.

I have to learn about those performance measurements. Could you give some links?

As @Volker_E mentioned, WMF decided to not provide web fonts for large scale projects for now as the trade off on performance and UX is not worth the investment. When a website uses a webfont, the client needs to make a HTTP request then download the font, it is an additional delay on the critical rendering path. Take Roboto as an example, the WOFF2 (most compressed format) for Roboto Regular (400) with basic latin is 16KB. Plus the latency introduced in the HTTP request, it could easily be 2-3 seconds load delay on a slow 3G network. Page load time can be solved with font-display:swap or lazyload, but that will introduce other UX issues such as font popping when web font is loaded. For a site like Wikipedia that serves a lot of people with slower and capped connections, the negative performance impact is significant.

Feb 7 2020, 4:16 AM · Readers-Web-Backlog (Tracking), User-Demian, Design Research and product team collaboration, Design-Research, Design

Feb 6 2020

alistair3149 added a comment to T243508: Suggestion: Enable the user to choose up-to-date fonts, more legible on LCD screens.

@Volker_E if web fonts are out of the picture for now, I suggest that we should focus on updating the hierarchy on the current Vector skin first to match with the style guide to improve readability. However, it might introduce a lot of problems with existing templates or layout hack uses on WMF sites.

Feb 6 2020, 9:12 PM · Readers-Web-Backlog (Tracking), User-Demian, Design Research and product team collaboration, Design-Research, Design
alistair3149 added a comment to T243508: Suggestion: Enable the user to choose up-to-date fonts, more legible on LCD screens.

@AronManning The typography that the style guide suggested is not adopted at all by Vector, I suggest that instead of focusing on font choices first, we need to focus on adopting the hierarchy (size, styles, weight, etc.) defined in the style guide as it is more suited for modern day screens. Adopting the hierarchy first will improve the readability issues across different platforms, and also builds a foundation for studying other font choices.

Feb 6 2020, 9:06 PM · Readers-Web-Backlog (Tracking), User-Demian, Design Research and product team collaboration, Design-Research, Design
alistair3149 added a comment to T243508: Suggestion: Enable the user to choose up-to-date fonts, more legible on LCD screens.

Just curious, is there a particular reason to deviate from the fonts used in the style guide? It would make more sense to adopt the Wikimedia styles that is also used on Minerva and native apps instead of picking other fonts for UI standardizations and many reasons.

Feb 6 2020, 6:46 PM · Readers-Web-Backlog (Tracking), User-Demian, Design Research and product team collaboration, Design-Research, Design

Feb 5 2020

alistair3149 added a comment to T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor.

@matmarex thanks for looking into it and the praise! Not sure if the following information helps but we don't have RESTBase on the wiki.
Also another weird behavior is that templates placed inside the <tabber> tags (from Extension:Tabber) seems to be not affected.

Feb 5 2020, 12:20 AM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles

Feb 4 2020

alistair3149 added a comment to T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor.

@Ryasmeen instead of inserting a template, it was simply visual editing a page that already has a template in there.

Feb 4 2020, 8:26 PM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles
alistair3149 added a comment to T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor.

@Ryasmeen it is on a non-WMF wiki, here's an example page containing templates using TemplateStyles: https://scwdev.czen.me/Defender
Since it is a dev site, registration is locked and edits are permission only. However, I hope that the following screenshot would help:

Feb 4 2020, 3:49 AM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles

Jan 30 2020

alistair3149 added a comment to T239305: TemplateStyles tag transcluded in template is not parsed in Visual Editing mode in Visual Editor.

@Ryasmeen templates with TemplateStyles transclusion means using a template that uses TemplateStyles, aka having <templatestyles src="Template:Foo/style.css">.

Jan 30 2020, 6:33 PM · Parsoid, User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), TemplateStyles