Page MenuHomePhabricator

andymw
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 11 2016, 10:24 PM (165 w, 4 d)
Availability
Available
LDAP User
Andy M. Wang
MediaWiki User
Andy M. Wang [ Global Accounts ]

Recent Activity

Nov 2 2016

andymw added a comment to T149756: Special:Log/patrol with "manual" type returns automatic patrols.

T149344 could be related?

Nov 2 2016, 12:37 AM · MediaWiki-Patrolling, MediaWiki-Logging

Nov 1 2016

andymw added a comment to T61102: Allow FlaggedRevs to prevent unreviewed changes to transcluded (template) pages being visible on pages that don't themselves have FlaggedRevs enabled.

@Cenarium Another question. For a heavily transcluded page, is it the unreviewed edit that's meant to be the "heavy" action that adds to the job queue, or the act of accepting (unaccepting) the edit (meant to make the change go live) that adds to the job queue?

Nov 1 2016, 10:48 PM · MediaWiki-extensions-FlaggedRevs
andymw added a comment to T61102: Allow FlaggedRevs to prevent unreviewed changes to transcluded (template) pages being visible on pages that don't themselves have FlaggedRevs enabled.

@Cenarium the results I'm getting (testing with a non-reviewer account in tandem). In all cases, page B has unreviewed edits. Suppose the unreviewed edit on page B is in section "Foo".

  1. Transclude B onto non-PC-enabled page A: unreviewed changes of B are seen when viewing A logged out.
  2. Transclude B onto PC-enabled page A generating an unreviewed change for A, then later this change is reviewed: unreviewed changes of B are seen when viewing A logged out.
  3. Substitute B onto non-PC-enabled page A: contents of what's being substituted were from the latest unreviewed version of B, and the public sees this.
  4. Substitute B onto PC-enabled page A generating an unreviewed change for A, then later this change is reviewed: contents of what's being substituted were from the latest unreviewed version of B, and the public sees this.
  5. Use #section-h to transclude section B onto page A. The contents of the section that's transcluded is from the latest revision of B. If A has no unreviewed edits, these changes are live.
Nov 1 2016, 10:32 PM · MediaWiki-extensions-FlaggedRevs

Oct 29 2016

andymw added a comment to T61102: Allow FlaggedRevs to prevent unreviewed changes to transcluded (template) pages being visible on pages that don't themselves have FlaggedRevs enabled.

There are articles that transclude sections of other articles (#section-h and <onlyinclude>, etc, see https://en.wikipedia.org/wiki/The_Fast_and_the_Furious). Pretty sure the sections that get transcluded will be the latest revision despite possible unreviewed changes, which seems to be a problem.

Oct 29 2016, 5:38 PM · MediaWiki-extensions-FlaggedRevs

Oct 25 2016

andymw added a comment to T61102: Allow FlaggedRevs to prevent unreviewed changes to transcluded (template) pages being visible on pages that don't themselves have FlaggedRevs enabled.

@Cenarium At enwiki as far as I know, the template namespace doesn't seem to allow turning flagged protection on. As for transclusion of unreviewed pages, the issue seems known by VPT, but since stronger flavors of flagged protection don't officially have consensus yet, this hasn't been a big problem.

Oct 25 2016, 11:30 PM · MediaWiki-extensions-FlaggedRevs
andymw added a comment to T149019: Add the patroller group to the English Wikipedia.

@Cenarium The patch does not give a short time frame in which non-admins can patrol articles, i.e. I think it makes sense to introduce the patroller group and allow some time for sysops to populate it while autoconfirmed still has the patrol flag. A second patch then removes the flag from autoconfirmed once patrollers are set.

Oct 25 2016, 10:47 PM · User-Urbanecm, Patch-For-Review, Wikimedia-Site-requests
andymw added a comment to T149019: Add the patroller group to the English Wikipedia.

As far as I know, bureaucrats don't have the patrol flag

Oct 25 2016, 12:14 AM · User-Urbanecm, Patch-For-Review, Wikimedia-Site-requests
andymw updated the task description for T149019: Add the patroller group to the English Wikipedia.
Oct 25 2016, 12:14 AM · User-Urbanecm, Patch-For-Review, Wikimedia-Site-requests

Oct 17 2016

andymw added a comment to T85393: Alert users when performing restricted actions with Special:MovePage.

Updated original to archive link.
If the destination page was not "deleted" but moved with suppressredirect, would the deletion log still show (as it does in other circumstances)? As for the additional warnings, should a create prot level warning at semi (and extendedconfirmed for enwiki) show? Also assuming that bots and automated processes would need to be be unaffected by the additional warnings.

Oct 17 2016, 9:11 PM · MediaWiki-Special-pages
andymw added a project to T85393: Alert users when performing restricted actions with Special:MovePage: MediaWiki-Page-editing.
Oct 17 2016, 9:10 PM · MediaWiki-Special-pages

Oct 16 2016

andymw added a comment to T140026: Move subpages of talk page should include a list of subpages.

Great to hear!

Oct 16 2016, 3:30 AM · MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), MW-1.28-release-notes, MediaWiki-Special-pages, MediaWiki-Page-editing

Oct 15 2016

andymw added a comment to T140026: Move subpages of talk page should include a list of subpages.

Any updates or suggestions by any chance? Interested if this may be merged soon @Legoktm

Oct 15 2016, 4:26 PM · MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), MW-1.28-release-notes, MediaWiki-Special-pages, MediaWiki-Page-editing

Oct 9 2016

andymw claimed T140026: Move subpages of talk page should include a list of subpages.

Began working on this, expecting to have a changelist for review shortly.

Oct 9 2016, 6:16 AM · MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), MW-1.28-release-notes, MediaWiki-Special-pages, MediaWiki-Page-editing

Oct 8 2016

andymw lowered the priority of T140026: Move subpages of talk page should include a list of subpages from Normal to Lowest.

@Aklapper thanks for the link and your feedback. Haven't had as much experience, and any upsetting of workflow was unintended. I've restored lowest priority in the meantime. (I'll consider elaborating the scenario on a mailing list)

Oct 8 2016, 4:12 PM · MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), MW-1.28-release-notes, MediaWiki-Special-pages, MediaWiki-Page-editing
andymw added a comment to T147701: Semiprotected pages don't have monospace textarea.

FYI not reproducing this issue on my own laptop, Win10, Firefox 49.0.1, vector skin

Oct 8 2016, 6:25 AM · MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)), MediaWiki-Page-editing, Regression, MediaWiki-Page-protection

Oct 7 2016

andymw added a project to T140026: Move subpages of talk page should include a list of subpages: Wikimedia-Site-requests.
Oct 7 2016, 10:50 PM · MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), MW-1.28-release-notes, MediaWiki-Special-pages, MediaWiki-Page-editing
andymw added a comment to T140026: Move subpages of talk page should include a list of subpages.

I attempted to clarify that this is an issue when performing a move operation on a subject page that, given the option to move-subpages, talk subpages are not visible to the end user. This is critical for editors handling page moves, especially if the subject namespace does not support subpages, and the talk namespace does, and the editor cannot see the pages meant to be the talk pages of other distinct legitimate articles (i.e. MediaWiki thinks they are talk "subpages" when they are actually standalone).

Oct 7 2016, 10:46 PM · MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), MW-1.28-release-notes, MediaWiki-Special-pages, MediaWiki-Page-editing
andymw raised the priority of T140026: Move subpages of talk page should include a list of subpages from Lowest to Normal.
Oct 7 2016, 10:37 PM · MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), MW-1.28-release-notes, MediaWiki-Special-pages, MediaWiki-Page-editing

Oct 6 2016

andymw closed T141545: Move subpages by default on English Wikipedia if subject/talk namespaces both support subpages as Invalid.
Oct 6 2016, 4:12 PM · MediaWiki-Page-editing, MediaWiki-Special-pages, Wikimedia-Site-requests
andymw added a comment to T141545: Move subpages by default on English Wikipedia if subject/talk namespaces both support subpages.

See additional follow-up at https://en.wikipedia.org/w/index.php?oldid=742912477#Technical_implementation
Appears that the updated suggestion is invalid - not possible to know the destination subject/talk namespace pairs in advance, and not able to know of both destination namespaces support subpages.

Oct 6 2016, 4:12 PM · MediaWiki-Page-editing, MediaWiki-Special-pages, Wikimedia-Site-requests
andymw added a comment to T141545: Move subpages by default on English Wikipedia if subject/talk namespaces both support subpages.

Updated title, let the option be default only if both the subject and talk namespaces relevant to the move occurring support subpages. See https://en.wikipedia.org/w/index.php?oldid=742847522#Technical_implementation

Oct 6 2016, 5:02 AM · MediaWiki-Page-editing, MediaWiki-Special-pages, Wikimedia-Site-requests
andymw renamed T141545: Move subpages by default on English Wikipedia if subject/talk namespaces both support subpages from Move subpages by default on English Wikipedia to Move subpages by default on English Wikipedia if subject/talk namespaces both support subpages.
Oct 6 2016, 4:59 AM · MediaWiki-Page-editing, MediaWiki-Special-pages, Wikimedia-Site-requests

Sep 15 2016

andymw added a comment to T145344: Unable to undo or edit previous revision to undo contentmodel change with intermediate edit.

@Legoktm I'm a bit new at this, but as the bug filer, solution is fine by me for now. (wonder if tech ambassadors wanted to add anything) Makes sense to continue to track this

Sep 15 2016, 3:02 PM · MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)), Patch-For-Review, MediaWiki-Page-editing, MediaWiki-ContentHandler

Sep 14 2016

andymw added a comment to T145174: Perhaps should have a notion of titles that must use default content model.

I guess we would see if the current content model can be converted (losslessly) to the required one. If so do that, if not refuse to move the page.

Makes sense. I think this would solve the other (possible?) issue that Modules (Scribunto) can be moved to the Wikipedia space and stay Scribunto. After this, I believe that module moves would be converted to wikitext.

Sep 14 2016, 12:22 AM · MediaWiki-ContentHandler

Sep 13 2016

andymw updated the task description for T145548: Able to create Scribunto pages with Lua errors with contentmodel changes.
Sep 13 2016, 6:23 PM · MW-1.28-release (WMF-deploy-2016-09-20_(1.28.0-wmf.20)), Patch-For-Review, MediaWiki-extensions-Scribunto
andymw added a subtask for T85847: Grant editcontentmodel right to all logged in users: T145548: Able to create Scribunto pages with Lua errors with contentmodel changes.
Sep 13 2016, 6:22 PM · Community-consensus-needed, MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)), MW-1.28-release-notes, MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), Patch-For-Review, MediaWiki-ContentHandler
andymw edited parent tasks for T145548: Able to create Scribunto pages with Lua errors with contentmodel changes, added: T85847: Grant editcontentmodel right to all logged in users, T145174: Perhaps should have a notion of titles that must use default content model; removed: T145489: Allow AbuseFilter to filter edits that change content models.
Sep 13 2016, 6:22 PM · MW-1.28-release (WMF-deploy-2016-09-20_(1.28.0-wmf.20)), Patch-For-Review, MediaWiki-extensions-Scribunto
andymw added a subtask for T145174: Perhaps should have a notion of titles that must use default content model: T145548: Able to create Scribunto pages with Lua errors with contentmodel changes.
Sep 13 2016, 6:22 PM · MediaWiki-ContentHandler
andymw removed a subtask for T145489: Allow AbuseFilter to filter edits that change content models: T145548: Able to create Scribunto pages with Lua errors with contentmodel changes.
Sep 13 2016, 6:22 PM · MW-1.28-release (WMF-deploy-2016-09-20_(1.28.0-wmf.20)), MW-1.28-release-notes, Patch-For-Review, MediaWiki-ContentHandler, AbuseFilter
andymw created T145548: Able to create Scribunto pages with Lua errors with contentmodel changes.
Sep 13 2016, 6:20 PM · MW-1.28-release (WMF-deploy-2016-09-20_(1.28.0-wmf.20)), Patch-For-Review, MediaWiki-extensions-Scribunto
andymw added a comment to T145174: Perhaps should have a notion of titles that must use default content model.

@Bawolff @Legoktm Given the scenarios I tried above, I think it's very difficult to ensure that titles have a default contentmodel. Page moves (like CSS to JS, or even default wikitext to a css subpage) is a workaround to the proposed function.

Sep 13 2016, 6:13 PM · MediaWiki-ContentHandler
andymw added a comment to T145174: Perhaps should have a notion of titles that must use default content model.
Sep 13 2016, 5:45 PM · MediaWiki-ContentHandler
andymw added a comment to T145174: Perhaps should have a notion of titles that must use default content model.

What happens if User:Example/common.css doesn't exist, and User:Example moves User:Example/common (not a CSS page, not in CSS contentmodel) to User:Example/common.css? I'm able to move a sandbox to a new css page: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Andy_M._Wang/sandbox&action=history

Sep 13 2016, 4:41 PM · MediaWiki-ContentHandler

Sep 12 2016

andymw added a comment to T145344: Unable to undo or edit previous revision to undo contentmodel change with intermediate edit.

Comment: if it's decided that edit-previous-revision cross-contentmodel is to be supported, then non-autoconfirmed users (or whatever the scope of editcontentmodel is) should not be able to edit a revision with a different contentmodel because they don't have the permission.

Sep 12 2016, 6:17 PM · MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)), Patch-For-Review, MediaWiki-Page-editing, MediaWiki-ContentHandler
andymw added a comment to T145344: Unable to undo or edit previous revision to undo contentmodel change with intermediate edit.

@MZMcBride Similar issue in that undo doesn't work when there's an intermediate edit... but I'd say that in terms of usability, it's not as disruptive, and not being able to undo page moves is well-known. Users are given a "Move" option in the tabs at the top that takes users directly to Special:MovePage, whereas "Change content model" is not an option given (and probably shouldn't be).

Sep 12 2016, 1:46 PM · MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)), Patch-For-Review, MediaWiki-Page-editing, MediaWiki-ContentHandler

Sep 11 2016

andymw added a comment to T145344: Unable to undo or edit previous revision to undo contentmodel change with intermediate edit.

Believe not supporting editing a previous revision of in a different contentmodel is problematic and probable on high-traffic mainspace pages. Twinkle's revert to previous revision would break here too, as far as I know.
@Legoktm remarked at VPR that a potential mitigation is a "change tag that indicates the edit changed the content model of the page, which would then link to documentation about changing content models".

Sep 11 2016, 10:39 PM · MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)), Patch-For-Review, MediaWiki-Page-editing, MediaWiki-ContentHandler
andymw created T145344: Unable to undo or edit previous revision to undo contentmodel change with intermediate edit.
Sep 11 2016, 10:29 PM · MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)), Patch-For-Review, MediaWiki-Page-editing, MediaWiki-ContentHandler