Page MenuHomePhabricator

ashley (Jack Phoenix)
Senior Software Developer

Projects (56)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2014, 1:59 PM (497 w, 4 d)
Availability
Available
IRC Nick
ashley
LDAP User
Jack Phoenix
MediaWiki User
Jack Phoenix [ Global Accounts ]

I've been developing MediaWiki since 2008, maintaining social tools as well as a few other extensions and skins.

Since 2013 I've had +2 rights to mediawiki/skins/* repositories.

I'm also a staff member at ShoutWiki, a wiki hosting service.

Recent Activity

Tue, Apr 16

ashley closed T53296: Add a machine-readable output format to articlefeedbackv5-view-feedback API as Resolved.

Only a bit over a decade later, this is now finally fixed. :)

Tue, Apr 16, 8:56 AM · ArticleFeedbackv5

Sun, Apr 14

ashley committed rEMWC6c5a368c2fe2: Random cleanup.
Random cleanup
Sun, Apr 14, 5:55 AM
ashley committed rESPR4f1981dd3a7e: Make phan happy again?.
Make phan happy again?
Sun, Apr 14, 5:08 AM

Wed, Apr 3

ashley committed rSGMDd83c0a04e676: SECURITY: avoid stored XSS via MediaWiki:Sidebar.
SECURITY: avoid stored XSS via MediaWiki:Sidebar
Wed, Apr 3, 9:24 PM

Mon, Apr 1

ashley created T361476: E_NOTICE & E_WARNING when MediaWiki:Sidebar does not contain an entry titled "navigation".
Mon, Apr 1, 3:34 PM · Patch-For-Review, Poncho

Sun, Mar 31

ashley updated subscribers of T361452: Foreground skin: stored XSS via MediaWiki:Sidebar.

CC'ing @Samwilson since you've recently committed to this repository with significant contributions.

Sun, Mar 31, 9:27 PM · security-bug, SecTeam-Processed, MediaWiki-skins-Foreground, Vuln-XSS, Security
ashley added projects to T361452: Foreground skin: stored XSS via MediaWiki:Sidebar: Vuln-XSS, MediaWiki-skins-Foreground.
Sun, Mar 31, 9:25 PM · security-bug, SecTeam-Processed, MediaWiki-skins-Foreground, Vuln-XSS, Security
ashley created T361452: Foreground skin: stored XSS via MediaWiki:Sidebar.
Sun, Mar 31, 9:25 PM · security-bug, SecTeam-Processed, MediaWiki-skins-Foreground, Vuln-XSS, Security
ashley edited Description on Other-skins.
Sun, Mar 31, 9:12 PM
ashley added a comment to T361449: Metrolook skin: stored XSS via MediaWiki:Sidebar.

Thank you for reporting! Would you mind doing the patch on Gerrit and I’ll +2 it as soon as you’ve done it please?

Sun, Mar 31, 9:02 PM · SecTeam-Processed, security-bug, Metrolook, Vuln-XSS, Security, Security-Team
ashley added projects to T361449: Metrolook skin: stored XSS via MediaWiki:Sidebar: Vuln-XSS, Metrolook.
Sun, Mar 31, 7:28 PM · SecTeam-Processed, security-bug, Metrolook, Vuln-XSS, Security, Security-Team
ashley created T361449: Metrolook skin: stored XSS via MediaWiki:Sidebar.
Sun, Mar 31, 7:27 PM · SecTeam-Processed, security-bug, Metrolook, Vuln-XSS, Security, Security-Team
ashley claimed T361448: GuMaxDD skin: stored XSS via MediaWiki:Sidebar.
Sun, Mar 31, 7:10 PM · security-bug, SecTeam-Processed, MediaWiki-skins-GuMaxDD, Vuln-XSS, Security
ashley created T361448: GuMaxDD skin: stored XSS via MediaWiki:Sidebar.
Sun, Mar 31, 7:09 PM · security-bug, SecTeam-Processed, MediaWiki-skins-GuMaxDD, Vuln-XSS, Security
ashley closed T361365: Challenge: stored XSS on four challenge fields as Resolved.
Sun, Mar 31, 4:19 AM · Vuln-XSS, Social-Tools, Challenge, Security, Security-Team

Sat, Mar 30

ashley added a comment to T355744: Tabs on Swedish Wikimini are in French.

Hopefully fixed with https://gitlab.wikimedia.org/ashley/mediawiki-skins-Wikimini/-/commit/f2dbec0f6f5e8b73505559156d43d37765afaff0 ; note that it relies on the content language (on the JS file) so sticking ?uselang=sv to the URL on the French site won't load the Swedish code, and likewise, appending ?uselang=fr won't load the French code on the Swedish site. If the language code is neither fr or sv, the French (fr) code is used as a fallback. Oh, and as per SkinWikimini.php, the Swedish site's configuration file is assumed to have define( 'WIKIMINI_PROJECT_UID', 'sv' ); in it but as per my inline comment on that file, changing that is easy enough.

Sat, Mar 30, 11:31 PM · WMSE-Existing-communities-2023, User-AxelPettersson_WMSE, Wikimini.org

Fri, Mar 29

ashley moved T361365: Challenge: stored XSS on four challenge fields from Backlog to Challenge on the Social-Tools board.
Fri, Mar 29, 1:10 PM · Vuln-XSS, Social-Tools, Challenge, Security, Security-Team
ashley moved T361365: Challenge: stored XSS on four challenge fields from Backlog to Bugs on the Challenge board.
Fri, Mar 29, 1:10 PM · Vuln-XSS, Social-Tools, Challenge, Security, Security-Team
ashley claimed T361365: Challenge: stored XSS on four challenge fields.
Fri, Mar 29, 1:10 PM · Vuln-XSS, Social-Tools, Challenge, Security, Security-Team
ashley created T361365: Challenge: stored XSS on four challenge fields.
Fri, Mar 29, 1:09 PM · Vuln-XSS, Social-Tools, Challenge, Security, Security-Team

Mon, Mar 25

ashley added a comment to T355744: Tabs on Swedish Wikimini are in French.

Assuming this is about my fork of the Wikimini skin (ping T356324 etc.) ...

Mon, Mar 25, 10:23 AM · WMSE-Existing-communities-2023, User-AxelPettersson_WMSE, Wikimini.org

Fri, Mar 22

ashley added a comment to T360730: Avoid manual review of translations that include HTML tags with `style=""` attributes.

For PrivateDomains, SocialProfile and Video extension, as the maintainer I'd be more than happy to allow the tag, so please let me know what needs to be done for those repositories.

Fri, Mar 22, 1:15 AM · Language-Technical Support, MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)), Social-Tools, Video extension, SocialProfile, PrivateDomains, Security, WikimediaMessages, Math, I18n, affects-translatewiki.net

Nov 24 2023

ashley closed T351919: Incorrect PLURAL use in MediaWiki:Ga-awards-given-out as Resolved.

Fixed now, thanks for the report! 👍

Nov 24 2023, 5:42 PM · Social-Tools, SocialProfile, I18n
ashley committed rESPR3b1697ab7e59: Fix English grammar in the "ga-awards-given-out" i18n msg.
Fix English grammar in the "ga-awards-given-out" i18n msg
Nov 24 2023, 5:39 PM

Nov 18 2023

ashley committed rEWAN7e689b5271fd: Fix bug with the isDiff param passed to ReviewHandler constructor.
Fix bug with the isDiff param passed to ReviewHandler constructor
Nov 18 2023, 7:22 AM

Nov 11 2023

ashley added a comment to T21782: Existing drafts are not listed when a draft is saved with JS disabled.

This seems to originate from rEDRAdfd4fb2e73f4: Replaced full list with small notice on preview, show changes, and non…. With JS disabled, clicking on the Save draft button results in the URL action param being set to submit...and whaddya know, the code added in that commit explicitly checks for that value and lists the drafts only when action is not submit.

Nov 11 2023, 1:03 PM · MediaWiki-extensions-Drafts
ashley updated the task description for T21782: Existing drafts are not listed when a draft is saved with JS disabled.
Nov 11 2023, 1:03 PM · MediaWiki-extensions-Drafts

Nov 8 2023

ashley added a comment to T348573: All Wikimedia extensions that store their data outside the main database should use a virtual database domain.

Thanks for the swift replies, @Ladsgroup and @Tgr; much appreciated! :) I didn't submit a patch to gerrit as there was essentially nothing submission-worthy; quite the opposite, I had to revert my futile attempts to unbreak Special:Contributions so that I could test out some different extensions which hook into Special:Contributions as well.

Nov 8 2023, 11:50 AM · Epic, WMF-General-or-Unknown

Nov 6 2023

ashley added a comment to T348573: All Wikimedia extensions that store their data outside the main database should use a virtual database domain.

ArticleFeedbackv5 isn't currently WMF-deployed, though who knows, perhaps it will once again be someday. :-) In the meanwhile, I definitely could use a helping hand with this...I wished to implement this change in AFTv5 in a non-BC-breaking way but the code turned out to be somewhat convoluted and I don't have a 1.41+ test setup to test out this part. What I can definitely say is that everything I tried out ended up breaking things like Special:Contributions (!) and such, so, yeah. :-/

Nov 6 2023, 11:47 AM · Epic, WMF-General-or-Unknown

Nov 5 2023

ashley added a comment to T350549: De-deprecate gt.defineTour.

Per discussion on MW.org, +1. The method's been "deprecated" for almost a decade without being removed and there'd be a real use case for it, so let's simply revert that part of rEGTOfc9de92a6ae6: Refactor and add non-linear tours, with tests.

Nov 5 2023, 9:21 PM · Growth-Team, MediaWiki-extensions-GuidedTour

Nov 1 2023

ashley closed T312585: RegexBlock's master branch does not pass CI as Resolved.

Looks like this got fixed in ede423c7c355f7c8541dc19f9c2d6d8146ecfaf5 back in May by @Umherirrender.

Nov 1 2023, 12:34 PM · ci-test-error, RegexBlock
ashley closed T321145: [[MediaWiki:Action-regexblock-exempt/en]] incorrect lego as Resolved.

@Shirayuki seems to have addressed this in b8634f6106b3b10aec468e43630d9dfb0b571f87 back in early May. That said, it was not nor is not an issue since in practise the regexblock-exempt user right is used "internally" by the codebase to see "should we even try to see if this user can be blocked?" (includes/RegexBlockHooks.php, function onGetUserBlock). If the user has the right, they're exempt from RegexBlocks, and no error message will be shown; if the user does not have the right, the processing continues normally and if they're not blocked, no error message will be shown as they can then edit the site normally; if they're regexblocked, a regular-ish block message, similar to the one you'd get if you were blocked via Special:Block, is shown.

Nov 1 2023, 12:04 PM · RegexBlock, I18n
ashley added a comment to T309052: Archive the CodeReview extension.

Delighted to Decline this if people really are using it. https://wikiapiary.com/wiki/Extension:CodeReview last time I used it (and it worked) said no-one did, IIRC?

WORKSFORME currently, the list shows 12 wikis. […]

Should we un-archive the page at https://www.mediawiki.org/wiki/Extension:CodeReview?

Nov 1 2023, 10:32 AM · Patch-For-Review, MediaWiki-extensions-CodeReview, translatewiki.net, Wikimedia-GitHub, Diffusion-Repository-Administrators, Projects-Cleanup

Oct 31 2023

ashley edited Description on Other-skins.
Oct 31 2023, 2:32 PM

Oct 30 2023

ashley added a comment to T349955: Archive the Negref extension.

Negref looks to be like a prime example of a very lightweight extension that needs almost no maintenance whatsoever. Having it converted to extension registration might've been the only maintenance it needed (+the associated cleanup, i.e. introducing a Negref PHP class instead of having two global functions).

Oct 30 2023, 1:43 PM · translatewiki.net, MediaWiki-extensions-Other, Wikimedia-GitHub, Diffusion-Repository-Administrators, Projects-Cleanup

Oct 29 2023

ashley added a project to T349973: MediaWiki:Gadget-modrollback.js gadget blocks clicking Cancel and Rollback links in Rollback confirmation in Special:Preferences on ckb.wikipedia: MediaWiki-Core-Preferences.
Oct 29 2023, 3:09 PM · MediaWiki-Core-Preferences
ashley awarded T349970: Add Extensions/Skins as an alias of Extension/Skin on Mediawikiwiki a Love token.
Oct 29 2023, 10:15 AM · User-RhinosF1, Wikimedia-Site-requests
ashley committed rSHAS570b8d48ef56: Add link to the skin's MediaWiki.org talk page from Special:Preferences.
Add link to the skin's MediaWiki.org talk page from Special:Preferences
Oct 29 2023, 5:39 AM
ashley committed rSGMD08a8a97d74cd: Add link to the skin's MediaWiki.org talk page from Special:Preferences.
Add link to the skin's MediaWiki.org talk page from Special:Preferences
Oct 29 2023, 3:28 AM
ashley committed R1893:7d653761a96c: Add link to the skin's MediaWiki.org talk page from Special:Preferences.
Add link to the skin's MediaWiki.org talk page from Special:Preferences
Oct 29 2023, 3:25 AM
ashley committed rSANI8ab45a07b8ec: Add link to the skin's MediaWiki.org talk page from Special:Preferences.
Add link to the skin's MediaWiki.org talk page from Special:Preferences
Oct 29 2023, 3:23 AM

Oct 28 2023

ashley committed rSANI0a5338c98373: Fix call to Language#convert, thus unbreaking CI.
Fix call to Language#convert, thus unbreaking CI
Oct 28 2023, 9:43 AM
ashley committed R1893:4fdbf9c5c7f3: Orange Bar of Death work.
Orange Bar of Death work
Oct 28 2023, 5:23 AM

Oct 26 2023

ashley added a comment to T334320: Archive the Favorites extension.

Archiving the extension is a solution, but I feel it's the lazy one for when the issue is "there's a bit of bitrot and some things don't work quite right on the latest supported version(s) of MediaWiki".

Oct 26 2023, 9:59 AM · Patch-For-Review, User-Kizule, translatewiki.net, MediaWiki-extensions-Other, Wikimedia-GitHub, Diffusion-Repository-Administrators, Projects-Cleanup
ashley closed T306900: Running maintenance/PopulateContributorsTable.php: "Error: Class 'Revision' not found" as Resolved.
Oct 26 2023, 9:50 AM · MediaWiki-extensions-Contributors

Oct 24 2023

ashley closed T21684: Save Draft Button is enabled before doing any changes as Resolved.

Finally fixed in master. Thanks to @matmarex for all the help with this one! 👍 🏅

Oct 24 2023, 9:25 PM · MediaWiki-extensions-Drafts

Oct 22 2023

ashley added a comment to T152865: Convert SocialProfile to use extension registration.

Noting that if this is not done by the time MW 1.41 releases, then compatibly with scripts such as mergeMessageFileList.php will break as extension registration is now required.

Oct 22 2023, 5:49 PM · Patch-Needs-Improvement, Technical-Debt, SocialProfile, Social-Tools
ashley committed rEWAN3b3fa05c16ff: Rewrite a few WHERE conds to use the DBAL more properly.
Rewrite a few WHERE conds to use the DBAL more properly
Oct 22 2023, 3:39 PM
ashley committed rEWANa9ff2eb7eeaf: Reduce code reviewer anxiety by using typecasts and the MW DBAL properly.
Reduce code reviewer anxiety by using typecasts and the MW DBAL properly
Oct 22 2023, 11:53 AM

Oct 21 2023

ashley renamed T21767: User can access the expired drafts through saved bookmarks from User can access the expired drafts throug saved bookmarks to User can access the expired drafts through saved bookmarks.
Oct 21 2023, 7:28 AM · MediaWiki-extensions-Drafts

Oct 20 2023

ashley closed T21738: Draft created once when 'Preview', 'Show Changes' are clicked as Resolved.

This may have gotten fixed a long time ago but in 2f5650a4f3c7ac1810151749996707e13fe097a9 I added some intentional checks for the "Show preview" and "Show changes" buttons and the extension works now as described in this ticket (for existing pages), and there's no point in creating empty drafts (T21737/ab188ba8181493be6f97843b1636e5d99900c09f), so closing this ticket.

Oct 20 2023, 1:35 PM · MediaWiki-extensions-Drafts

Oct 18 2023

ashley committed rMSPOfe23faf3c1b5: More RequestContext, less global state.
More RequestContext, less global state
Oct 18 2023, 11:47 AM

Oct 17 2023

ashley closed T348979: CVE-2024-23177: WatchAnalytics: classic XSS on Special:PageStatistics with the 'page' URL parameter as Resolved.

Now fixed in git master by the afore-referenced commit. @sbassett, feel free to make this task public now; thanks!

Oct 17 2023, 2:17 PM · SecTeam-Processed, Vuln-XSS, MediaWiki-extensions-WatchAnalytics, Security
ashley committed rEWAN22199e2fc800: [SECURITY] Escape the 'page' URL parameter value before outputting it.
[SECURITY] Escape the 'page' URL parameter value before outputting it
Oct 17 2023, 2:05 PM
ashley committed rEWANb8f011f30a3c: Add FIXMEs for all the various hardcoded English strings, tweak some messages'….
Add FIXMEs for all the various hardcoded English strings, tweak some messages'…
Oct 17 2023, 2:05 PM
ashley moved T21684: Save Draft Button is enabled before doing any changes from Backlog to Bugs on the MediaWiki-extensions-Drafts board.
Oct 17 2023, 1:55 PM · MediaWiki-extensions-Drafts
ashley moved T21701: draft_edittime is same for all the drafts of an article from Backlog to Bugs on the MediaWiki-extensions-Drafts board.
Oct 17 2023, 1:55 PM · MediaWiki-extensions-Drafts
ashley moved T21710: Draft Save button is not enabled when spell check is done from Backlog to Bugs on the MediaWiki-extensions-Drafts board.
Oct 17 2023, 1:55 PM · MediaWiki-extensions-Drafts
ashley moved T21731: Drafts created before saving the article are not listed in Edit page from Backlog to Bugs on the MediaWiki-extensions-Drafts board.
Oct 17 2023, 1:55 PM · MediaWiki-extensions-Drafts
ashley moved T21735: Drafts' saved time is not displayed when a draft is saved from Backlog to Bugs on the MediaWiki-extensions-Drafts board.
Oct 17 2023, 1:54 PM · MediaWiki-extensions-Drafts
ashley moved T21743: Count shall be refreshed when a draft is Saved in Preview window from Backlog to Bugs on the MediaWiki-extensions-Drafts board.
Oct 17 2023, 1:54 PM · MediaWiki-extensions-Drafts
ashley moved T21745: Default set Minor edit is always checked for unchecked too from Backlog to Bugs on the MediaWiki-extensions-Drafts board.
Oct 17 2023, 1:54 PM · MediaWiki-extensions-Drafts
ashley moved T21749: Opera : 'Save Draft' is not enable when text is cut/paste from Backlog to Bugs on the MediaWiki-extensions-Drafts board.
Oct 17 2023, 1:54 PM · MediaWiki-extensions-Drafts
ashley moved T21763: 'Save Draft' is not enabled when content is deleted from popup menu from Backlog to Bugs on the MediaWiki-extensions-Drafts board.
Oct 17 2023, 1:54 PM · MediaWiki-extensions-Drafts
ashley moved T21764: Chrome : Shortcut keys are not working from Backlog to Bugs on the MediaWiki-extensions-Drafts board.
Oct 17 2023, 1:54 PM · MediaWiki-extensions-Drafts
ashley moved T21782: Existing drafts are not listed when a draft is saved with JS disabled from Backlog to Bugs on the MediaWiki-extensions-Drafts board.
Oct 17 2023, 1:54 PM · MediaWiki-extensions-Drafts
ashley moved T273703: null/empty integer values cause a badinteger error with api.php from Backlog to Bugs on the MediaWiki-extensions-Drafts board.
Oct 17 2023, 1:54 PM · MediaWiki-Action-API, MediaWiki-extensions-Drafts
ashley closed T21744: 'Save Draft' button is not enabled when text is droped to Edit area as Resolved.
Oct 17 2023, 1:50 PM · MediaWiki-extensions-Drafts
ashley closed T21737: A draft is saved when there is no content in the article as Resolved.
Oct 17 2023, 1:50 PM · MediaWiki-extensions-Drafts
ashley committed rSGMDa5aa3bed36a5: Fix old FIXME: do not render "in other languages" box for NS_SPECIAL pages +….
Fix old FIXME: do not render "in other languages" box for NS_SPECIAL pages +…
Oct 17 2023, 1:38 PM

Oct 16 2023

ashley created T348989: Various hardcoded English strings.
Oct 16 2023, 2:21 PM · translatewiki.net, I18n, MediaWiki-extensions-WatchAnalytics
ashley added projects to T348979: CVE-2024-23177: WatchAnalytics: classic XSS on Special:PageStatistics with the 'page' URL parameter: MediaWiki-extensions-WatchAnalytics, Vuln-XSS.
Oct 16 2023, 1:01 PM · SecTeam-Processed, Vuln-XSS, MediaWiki-extensions-WatchAnalytics, Security
ashley created T348979: CVE-2024-23177: WatchAnalytics: classic XSS on Special:PageStatistics with the 'page' URL parameter.
Oct 16 2023, 1:01 PM · SecTeam-Processed, Vuln-XSS, MediaWiki-extensions-WatchAnalytics, Security
ashley committed rEWAN4ed64143c568: Support a non-empty $wgDBprefix in the subqueries and build WHERE params….
Support a non-empty $wgDBprefix in the subqueries and build WHERE params…
Oct 16 2023, 12:26 PM
ashley committed rEWAN1e787d82d37c: Unbreak PendingReview#clearByUserAndTitle for supported/required MW version(s).
Unbreak PendingReview#clearByUserAndTitle for supported/required MW version(s)
Oct 16 2023, 11:58 AM
ashley committed rEWAN7fdd9898751c: Remove pre-MW 1.32 compatibility code, extesion requires MW 1.35+ as per….
Remove pre-MW 1.32 compatibility code, extesion requires MW 1.35+ as per…
Oct 16 2023, 11:58 AM
ashley committed rEWAN8be87d1884b6: Just skip the DB query params (options and/or JOIN conditions) that aren't….
Just skip the DB query params (options and/or JOIN conditions) that aren't…
Oct 16 2023, 11:58 AM

Oct 14 2023

ashley added a comment to T21763: 'Save Draft' is not enabled when content is deleted from popup menu.

I assume the "popup menu" refers to the right-click "context" menu; in that case, this is surprisingly tricky to do and it seems there's still no standardized way to detect that particular event. It can be done and people have written some, uh, creative solutions for that but it's definitely not as simple as listening to a standardized event like cut, copy, paste, keypress, etc. :-/

Oct 14 2023, 8:59 PM · MediaWiki-extensions-Drafts
ashley closed T45910: AJAX button not working on MW 1.20+: "ReferenceError: wgDraft is not defined" as Resolved.

As Yuvi pointed out, this is an ugly hack, and should be fixed in some other way.

I ended up going with the exact same ugly hack, albeit written slightly differently, back in November 2020 (28f48e343e675fc887ea2fe59025de7ce7d19208).
It's not the greatest thing ever but it got the job done so I'm marking this ticket as RESOLVED.

Oct 14 2023, 8:46 PM · MediaWiki-extensions-Drafts, Browser-Support-Firefox
ashley closed T57451: Use AJAX to replace textbox using Drafts extension as Resolved.
Oct 14 2023, 1:33 PM · MediaWiki-extensions-Drafts
ashley closed T57451: Use AJAX to replace textbox using Drafts extension, a subtask of T42482: Drafts extension selection integration needs UX rework (tracking), as Resolved.
Oct 14 2023, 1:33 PM · Epic, Design, MediaWiki-extensions-Drafts
ashley updated the task description for T212994: Archive all pages on mediawiki.org and items on wikidata.org about MediaWiki SVN extensions/skins.
Oct 14 2023, 8:41 AM · Projects-Cleanup, User-Kizule
ashley committed rEPPGb8d365099bb9: Fixed to work with MediaWiki 1.39(+).
Fixed to work with MediaWiki 1.39(+)
Oct 14 2023, 8:26 AM

Oct 12 2023

ashley committed rEWAN03f46c421766: Rewrite one DB query to use the DBAL properly instead of constructing raw SQL….
Rewrite one DB query to use the DBAL properly instead of constructing raw SQL…
Oct 12 2023, 10:20 PM
ashley committed rEWANebe5d3c17826: Add missing use statements for the PageMoveComplete hook + tweak docs.
Add missing use statements for the PageMoveComplete hook + tweak docs
Oct 12 2023, 10:20 PM
ashley committed rEWAN635fbdf59e89: Unbreak the addCategoryToWatchlist.php maintenance script.
Unbreak the addCategoryToWatchlist.php maintenance script
Oct 12 2023, 10:20 PM
ashley committed rEWANa461fab8a813: Clean up the LoadExtensionSchemaUpdates hook handler a bit.
Clean up the LoadExtensionSchemaUpdates hook handler a bit
Oct 12 2023, 10:14 PM

Oct 11 2023

ashley committed rEWAN00fb256189e9: Reduce the number of messages that (unnecessarily) accept raw HTML + fix one….
Reduce the number of messages that (unnecessarily) accept raw HTML + fix one…
Oct 11 2023, 5:12 PM
ashley committed rEXFAd52e8177d3ac: s/Google/XenForo/g + change one DB query construction to be more standards….
s/Google/XenForo/g + change one DB query construction to be more standards…
Oct 11 2023, 4:36 PM
ashley committed rEXFA34272d37014d: Clean up the LoadExtensionSchemaUpdates hook handler a bit.
Clean up the LoadExtensionSchemaUpdates hook handler a bit
Oct 11 2023, 3:56 PM
ashley committed rEAMD14e32baf1389: Filthy but potentially functional hack for selecting the first sentence(s) from….
Filthy but potentially functional hack for selecting the first sentence(s) from…
Oct 11 2023, 2:41 AM

Oct 9 2023

ashley committed rSGMD0764556efd60: Fix E_DEPRECATED arising from the use of the 'searchaction' parameter.
Fix E_DEPRECATED arising from the use of the 'searchaction' parameter
Oct 9 2023, 1:55 PM

Oct 7 2023

ashley added a comment to T62944: Old feedback not visible on article or talk when new feedback is disabled.

I'm not quite sure what's meant here. It's true that disabling AFTv5 for an article via the privileged action=protect UI does remove the "View reader feedback" link from Talk: pages and the "N reader comments" link from the actual content page in question, but a page like Special:ArticleFeedbackv5/Main_Page can still be accessed just fine. The "Add your feedback" and "View feedback" links, which IIRC are rendered via JS, in the toolbox are also removed if AFTv5 is disabled via action=protect; maybe this is about that? In any case, I'd argue that disabling the aforementioned links in case if AFTv5 is disabled is probably more intentional than not.

Oct 7 2023, 8:31 AM · ArticleFeedbackv5
ashley added a comment to T99220: Helpful vs. Useful.

Very confusing indeed. :-/

Oct 7 2023, 8:24 AM · I18n, ArticleFeedbackv5

Oct 5 2023

ashley committed rENBXff8b96b37667: Make NewsBox relevant again.
Make NewsBox relevant again
Oct 5 2023, 12:35 AM

Oct 2 2023

ashley committed rEIMRbb2d7b4418ba: Fix annoying rounding bug with the vote average on Special:ImageRating.
Fix annoying rounding bug with the vote average on Special:ImageRating
Oct 2 2023, 12:36 PM

Oct 1 2023

ashley committed rESPR94a739e284fd: Fix E_DEPRECATED on Special:UserActivity.
Fix E_DEPRECATED on Special:UserActivity
Oct 1 2023, 7:35 PM
ashley committed rESPR029206f96048: Fix the remaining PhanTypeMismatchArgumentProbablyReal issues properly.
Fix the remaining PhanTypeMismatchArgumentProbablyReal issues properly
Oct 1 2023, 12:43 PM
ashley committed rSGMD18a50a719963: Add skinname-gumaxdd i18n msg to display the skin name as "GuMaxDD" instead of….
Add skinname-gumaxdd i18n msg to display the skin name as "GuMaxDD" instead of…
Oct 1 2023, 9:22 AM

Sep 30 2023

ashley committed rESPR7525bbcafe29: Document why some phan issue types are suppressed.
Document why some phan issue types are suppressed
Sep 30 2023, 11:17 AM