Sun, Jun 6
Sat, Jun 5
Fri, Jun 4
Wed, Jun 2
Tue, Jun 1
The above patch should fix the E_NOTICE/E_WARNING about undefined indexes (though it's beyond me why those were happening in the first place; given that Lingo registers itself as a parser hook, surely the array should, well, be an array!), but I want to note two things:
- Apparently, as per its MediaWiki.org info page, Lingo is currently unmaintained
- Lingo does not use the TitleMoveComplete hook as of both git master and REL1_35; maybe you're using an old version of it? Though I have a hunch that Lingo never used that hook to begin with and the deprecation notice is caused by another (outdated) extension instead.
Closing since Duncan merged my patch. Glad to hear it's working again. :)
Mon, May 31
To state some of the obvious points:
- The test wiki in question is running MW 1.36.0, but Social-Tools have only been tested w/ 1.35(.0/.2); ideally this wouldn't really matter and they'd work just as well on both versions, just w/o losing the LTS compatibility, but I cannot vouch for that as I've not tested it myself
- Account creation is restricted so I'm not able to create a dummy user account to try to reproduce the bug, but...
- ...neither mentioned issue is one I've come across before locally, nor am I able to replicate the bugs on my local dev box, but...
- ...it wouldn't exactly shock me if you had found a bug or several bugs in the QuizGame JS; to put it very nicely, I don't like that code, despite or perhaps due to having written a fair chunk of it :)
Sun, May 30
Sat, May 29
The repo should probably be marked read-only sooner rather than later to discourage people from submitting patches against it (assuming that the said patch isn't someone willing to step up as the maintainer & unbreak the extension), given the extension's current, hopeless state.
Fri, May 28
Add WikiTeq as a member on Gerrit (so we can have +2 right)
I've done this.
Thu, May 27
And you think people don't just skip reading 20+ lines of boilerplate comments? ;-)
AIUI this is the long-term plan/vision, at least in some form; I assume the Parsoid people would know specifics? But VE is not yet a part of core, though it...might be bundled with the tarball release.
I think this should nowadays be mostly fixed? cc @Paladox
Sun, May 23
Fri, May 21
Thu, May 20
Is there a particular reason to have the network name included in the tag name? I.e. wouldn't a more generic "wikimedia-irc" tag suffice for any and all things IRC?
Tue, May 18
Boldly closing as resolved in light of the above discussion about the existing feature.
Seems that it's because of this (which, at a glance, looks very out-of-place to me):
Sun, May 16
Sat, May 15
May 14 2021
May 12 2021
May 9 2021
May 6 2021
May 5 2021
Seems to be just a few instances of getGroups() in UserGifts/includes/specials/SpecialGiftManager.php and nothing else (based on some very quick grepping). Yay!
May 4 2021
May 3 2021
Apr 30 2021
Apr 29 2021
Apr 27 2021
Apr 26 2021
Alas, SocialProfile does not yet to my knowledge run phan. (Just like how it doesn't support extension registration yet, or...)
Quickie patch which fixes this issue and swaps escaping stuff around and whatnot in order to reduce general reviewer anxiety with this super old codebase.
Apr 25 2021
Apr 24 2021
Proposed patch which fixes the issues in SystemGifts spotted with the malicious award name used as an example here, adjusts ->plain() to ->escaped(), ensures that LinkRenderer is passed raw text (->text()) instead of escaped to avoid double-escaping and removes parsing format from Message objects passed to OutputPage#setPageTitle because that method can be passed either a string or a Message object, and finally casts some things we definitely want to be ints as such (in SpecialSystemGiftManager.php).