Page MenuHomePhabricator

atagar
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2021, 10:40 PM (24 w, 4 d)
Availability
Available
LDAP User
Damian
MediaWiki User
Unknown

Recent Activity

Jul 30 2021

atagar closed T287332: Tests fail with test.wikipedia.org family as Invalid.
Jul 30 2021, 12:07 AM · Patch-For-Review, Pywikibot

Jul 27 2021

atagar reopened T287332: Tests fail with test.wikipedia.org family as "Open".

Hi Xqt. Sorry to reopen but changing my user-config.py in the way mentioned above surfaced a new test failure and I think this one is legitimate...

Jul 27 2021, 7:13 PM · Patch-For-Review, Pywikibot

Jul 26 2021

atagar added a comment to T287332: Tests fail with test.wikipedia.org family.

Just use Site('wikipedia:test') for test.wikipedia.org. The old test_family just duplicated the same site. (Ok the test family was prior)

Jul 26 2021, 10:25 PM · Patch-For-Review, Pywikibot

Jul 24 2021

atagar added a comment to T287332: Tests fail with test.wikipedia.org family.

test.wikipedia.org is part of wikipedia_family.py. Therefore the test family was dropped. See T228375

Jul 24 2021, 9:01 PM · Patch-For-Review, Pywikibot
atagar added a comment to T287332: Tests fail with test.wikipedia.org family.

Xqt requested that I move information about https://gerrit.wikimedia.org/r/c/pywikibot/core/+/707869 onto this ticket. The 'drev' value with the family mentioned above is...

Jul 24 2021, 8:57 PM · Patch-For-Review, Pywikibot
atagar updated the task description for T287332: Tests fail with test.wikipedia.org family.
Jul 24 2021, 7:40 PM · Patch-For-Review, Pywikibot
atagar created T287332: Tests fail with test.wikipedia.org family.
Jul 24 2021, 7:39 PM · Patch-For-Review, Pywikibot

Jul 10 2021

atagar triaged T286403: Consistently supply type hints as Low priority.
Jul 10 2021, 10:22 PM · Patch-For-Review, Pywikibot
atagar closed T281200: Clean up tools classes as Resolved.

They've all been merged or dropped. Resolving.

Jul 10 2021, 10:09 PM · Patch-For-Review, Pywikibot
atagar created T286403: Consistently supply type hints.
Jul 10 2021, 9:45 PM · Patch-For-Review, Pywikibot

Jun 28 2021

atagar created T285723: movepages requires pre-cached credentials.
Jun 28 2021, 9:58 PM · Pywikibot

Jun 15 2021

atagar closed T281202: Deprecation policy as Resolved.

Gotcha. I think we've concluded this ticket so closing. Feel free to reopen if you'd like to further discuss anything.

Jun 15 2021, 5:48 AM · Pywikibot

Jun 14 2021

atagar added a comment to T281202: Deprecation policy.

But I am also fine with your proposal and it might be better to have one big change with 7.0 than douzands every month. I explicitly aggree with your points above.

Jun 14 2021, 11:01 PM · Pywikibot

Jun 11 2021

atagar added a project to T284798: Configure Gerrit to cherry-pick: Pywikibot.
Jun 11 2021, 12:54 AM · Pywikibot
atagar created T284798: Configure Gerrit to cherry-pick.
Jun 11 2021, 12:52 AM · Pywikibot

Jun 7 2021

atagar added a comment to T281202: Deprecation policy.

Xqt merged our FutureWarning patch but hasn't said if he approves of the above (ie. to begin enforcing a symantic versioning policy). Since he merges most patches this will be a lost cause without his agreement so leaving this open to get his thoughts.

Jun 7 2021, 9:13 PM · Pywikibot

Jun 2 2021

atagar added a comment to T281202: Deprecation policy.

I amended our deprecation policy in the following ways...

Jun 2 2021, 11:47 PM · Pywikibot
atagar reopened T281202: Deprecation policy as "Open".

Hi Xqt. Sorry to reopen but on reflection I'd like to propose a different policy.

Jun 2 2021, 12:55 AM · Pywikibot

Jun 1 2021

atagar added a comment to T277396: Lint test to match function signature and documentation.

Hi Xqt. It's a bit unclear to me what the task is...

Jun 1 2021, 6:40 AM · Release-Engineering-Team (Seen), Pywikibot-tests, Pywikibot

May 30 2021

atagar added a comment to T281202: Deprecation policy.

Hi Xqt, I added a deprecation policy to our guidelines. When I get external link permission I'll link the tools functions to their API docs.

May 30 2021, 10:32 PM · Pywikibot

May 28 2021

atagar added a comment to T278046: Convert epytext docstrings to reST (sphinx).

Don't see any advantage.

May 28 2021, 9:50 PM · Patch-For-Review, Pywikibot, Pywikibot-Documentation
atagar added a comment to T278046: Convert epytext docstrings to reST (sphinx).

If we don't have existing epytext lint checks then why is reST linting a requirement to proceed with your change? Or did we discard the change for reasons aside from darglint?

rstcheck validates the reSt syntax. It does not validate the content.

May 28 2021, 12:45 AM · Patch-For-Review, Pywikibot, Pywikibot-Documentation

May 25 2021

atagar added a comment to T278046: Convert epytext docstrings to reST (sphinx).

Currently the only check is made by sphinx but there is no code validation.

May 25 2021, 6:56 AM · Patch-For-Review, Pywikibot, Pywikibot-Documentation
atagar added a comment to T278046: Convert epytext docstrings to reST (sphinx).

Hi Xqt. I really like your CR 673836 and would love to move this along. Unfortunately your CI link no longer works - what kind of errors did you experience and can we reproduce them locally?

May 25 2021, 12:28 AM · Patch-For-Review, Pywikibot, Pywikibot-Documentation

May 24 2021

atagar added a comment to T282962: ui_tests are failing on Travis.

Hi Xqt. For what it's worth I have the ui_tests inconsistently fail locally (it seems to happen about 70% of the time).

May 24 2021, 12:38 AM · Pywikibot-tests, Pywikibot

May 23 2021

atagar added a comment to T281202: Deprecation policy.

Thanks Xqt! Yesterday I finished evaluating all our deprecations prior to the end of 2019, removing FutureWarnings and changing DeprecationWarnings to FutureWarnings. In retrospect I should've discussed it here before digging in. Sorry about that.

May 23 2021, 9:22 PM · Pywikibot

May 21 2021

atagar closed T283209: Bot vs MultipleSitesBot? as Invalid.

Thanks for the detailed explanation Xqt! I don't have sufficient familiarity with our frameworks usage to determine the best class hierarchy to provide so I'm going to focus elsewhere for now. I might revisit this in the future. In the meantime I'll simply drop the deprecated bit of this module.

May 21 2021, 1:35 AM · Pywikibot
atagar closed T283214: Test site certificate expired as Invalid.

That wiki fixed their certificate. Closing.

May 21 2021, 1:23 AM · Pywikibot

May 20 2021

atagar added a project to T283214: Test site certificate expired: Pywikibot.
May 20 2021, 1:14 AM · Pywikibot
atagar created T283214: Test site certificate expired.
May 20 2021, 1:11 AM · Pywikibot

May 19 2021

atagar created T283209: Bot vs MultipleSitesBot?.
May 19 2021, 11:17 PM · Pywikibot
atagar reopened T281202: Deprecation policy as "Open".

Hi Xqt. I'm going to reopen this because T106121 did not answer this. This ticket is about documenting when deprecated code can be removed.

May 19 2021, 10:00 PM · Pywikibot

Apr 29 2021

atagar added a comment to T280227: Exception names does not follow PEP8.

There seems to be a Python 3.5 issue regarding ModuleDeprecationWrapper. Would you like for me to install Python 3.5 to troubleshoot or should we continue with this?

Apr 29 2021, 8:34 AM · Patch-For-Review, Pywikibot
atagar added a comment to T280227: Exception names does not follow PEP8.

That's... really odd. I have Python 3.8 and unfortunately installing a deprecated 3.5 interpreter would be a pita. Do you have any idea what's going on or should I try to get one working?

Apr 29 2021, 6:12 AM · Patch-For-Review, Pywikibot
atagar added a comment to T280227: Exception names does not follow PEP8.

That's odd. I do get it...

Apr 29 2021, 5:27 AM · Patch-For-Review, Pywikibot

Apr 28 2021

atagar added a comment to T280227: Exception names does not follow PEP8.

Thanks @JJMC89! Great point. Code review updated with a better approach which fixes that.

Apr 28 2021, 10:47 PM · Patch-For-Review, Pywikibot

Apr 26 2021

atagar created T281202: Deprecation policy.
Apr 26 2021, 11:00 PM · Pywikibot
atagar created T281200: Clean up tools classes.
Apr 26 2021, 10:46 PM · Patch-For-Review, Pywikibot
atagar created T281199: Suppress and assert against bot logs.
Apr 26 2021, 10:39 PM · Pywikibot
atagar added a project to T281197: Tox only runs with python 3.5-3.6: Pywikibot.
Apr 26 2021, 10:37 PM · Pywikibot
atagar created T281197: Tox only runs with python 3.5-3.6.
Apr 26 2021, 10:33 PM · Pywikibot

Apr 23 2021

atagar claimed T280227: Exception names does not follow PEP8.
Apr 23 2021, 4:53 AM · Patch-For-Review, Pywikibot