Is it difficult to change the widget to a DropdownWidget instead of the ButtonGroupWidget? If it's alright, then it should also be the same layout where Optional is already selected and they could just change to another in the dropdown. I guess also if it's ok, then this should be a new ticket?

Live on the test instance.

This was an existing problem, but the priority buttons are wrapping awkwardly regardless of zoom level:

@WMDE-Fisch I'm realizing that waiting on feedback for just the VisualEditor repo doesn't make sense. Let's go ahead and expand the experiment to include the other repos we're heavily branching, starting with CodeMirror and TemplateData, if you agree? I'll mirror those two, and I've added instructions to this task about how to mirror additional repos, under "Mirror a new repo from Gerrit".

I tried reproducing this on enwiki, by changing the TemplateData "description" multiple times. I was unable to cause corruption.

"no description" text should be above deprecated warning. Wrong:

Fix placeholders and non-image media files.

Looks like the infobox is missing one of its nested templates? Would you mind also pulling in "italic title"?

vagrant@mediawiki-vagrant:/vagrant$ mwscript importDump.php --wiki=enwiki /vagrant/xml_imports/en-T263521.xml

done!

Are the inline help strings listed somewhere? I can glean most of them from the mockup, but some are truncated...

@thiemowmde Does this really need review or can it be demoed now?

@ECohen_WMDE There's already an OOUI standard layout for inline help text:

Note to self: "Same size applies to the parameter editing screen" -> this will happen by default, the parameter editing screen is implemented as a pane in the template editor dialog.

Moving to review so that we can start collecting data.

Note to self, both the VE 2017 wikitext editor and the 2010 source code editor share the usecodemirror preference.

Preliminary counts,

In T260138#6463288, @ECohen_WMDE wrote:

In the original ticket they also mention the related gadgets and some usage numbers T101246: Highlighted wikisyntax while editing articles [AOI] - @Lena_WMDE could be useful to gather the current gadget usage numbers and compare with the CodeMirror hidden preference?

The "review" request is for other devs to go through all the steps and post their observations on this task.

Rebased and resolved some minor merge conflicts. This is live on the test instance.

Yes, if possible the three dots is much preferred. Thanks!

In T260803#6432826, @ECohen_WMDE wrote:

the progress bar is working for now, but I should coord with WMF about OOUI and the three loading dots.

It looks like the local "query imageinfo" API is able to return thumbnail URLs for commonswiki, I'll try to integrate with that.

Confirmed the same behavior in the original patch. It depends on the filename, I got lucky with a long name including many short words: "User overlap bug.png". Results from the server are nondeterministic, and I've seen nothing show up in the first hundred matches. Even more alarmingly, setting the limit to 200 caused server memory exhaustion, reporting that it had tried to allocate 700MB before crashing.

We're keeping this task open to iron out any last issues, the merge with other features was non-trivial and may have broken things.

Porting the branches to gitlab was really a pleasure. The basic process was,

In T262526#6451092, @JTannerWMF wrote:

Good catch @awight , are you planning to work on this in your efforts to improve templates in the VisualEditor?

@ECohen_WMDE This is only about the VisualEditor? Or should the TemplateWizard be modified as well?

We need to act on this, we're 11 patches into a branch on the VisualEditor repo alone, and it's becoming difficult to replicate the test instance locally for further development.

The TemplateData part of this feature is live on the test instance.

Fixing might be as simple as adding allowLanguages to the property descriptor.

@ECohen_WMDE
Should the "Deprecated guidance" header end with "(en)" like the other text inputs, and be translatable? I think this is correct because the message will be used in the interface. For now, I'll leave the string untranslateable for consistency with the shortcoming documented in T262526: TemplateData deprecated parameter guidance should be translatable.

We can capture the preference toggling by adding the preference name to an inclusion list in WikimediaEvents PrefUpdateInstrumentation::PROPERTY_TRACKLIST.

In T260803#6411369, @thiemowmde wrote:

There are several ways to request thumbnails from Commons.

Ready for demoing again. An earlier patch had inadvertently removed the example and parameter deprecation notices from the description text.

In T261504#6440358, @ECohen_WMDE wrote:

Yes, please implement as written. I'm a bit less worried, as this is already the behavior in TemplateWizard and it works quite well (you can try it out there already if you're curious). The current dropdown actually makes it much harder to work with templates with many parameters (it's hard to get an overview and to add/remove them to understand each parameter).

@ECohen_WMDE How should we change the static rendering of TemplateData? For example this table,

@ECohen_WMDE

Remove the 'Add more information' dropdown at the bottom of the main input area, where parameters are currently added to templates.

There needs to still be a way to add unknown template parameters. For example, when the TemplateData is incomplete and has not been updated to document a newly-implemented parameter.
I suggest we either leave "add more information", or have a button that does this.

When a template has hundreds of parameters, I worry that this might fall apart:

The sidebar will display all parameters, not just those that have been added. The parameter icon to the left of the parameter names is removed and replaced with "+"/"-" buttons (same buttons & behaviour as in the TemplateWizard sidebar). These are used to add and remove them to the template, i.e. shown in or removed from the main input section on the right.

Is there an affordance to search template names?

Reducing the estimate, there wasn't much left to this ticket.

In T260888#6436137, @awight wrote:

Minor thing: the dialog title is currently the template name (see below), but should we change that to "Insert a template"?

Wow, do *not* do what I did. Force push was a total disaster:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/624681
vs
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/VisualEditor/+/refs/heads/wmde-templates

Minor thing: the dialog title is currently the template name (see below), but should we change that to "Insert a template"?

It didn't work so well. The branch isn't forwarded when using the repo over anonymous HTTPS.

So far, I've done this with the VisualEditor repo. We have a branch wmde-templates and QWERTY staff are allowed to push or force-push.