Page MenuHomePhabricator

awight (Adam Roses Wight)
User

Projects (20)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 12 2014, 9:02 PM (275 w, 4 d)
Availability
Available
IRC Nick
awight
LDAP User
Awight
MediaWiki User
Adamw [ Global Accounts ]

Recent Activity

Today

awight added a comment to T26600: Cite: 'Cite error references missing key' not properly invoked.

"Let's rewrite it" has become a bit of a battle cry, good point :-) Agreed that we would schedule along with other cleanup work, later or never, so for now let's just decide whether it's a bug and what can be improved.

Fri, Jan 24, 1:43 PM · Cite
awight added a comment to T26600: Cite: 'Cite error references missing key' not properly invoked.

Interesting! The first error makes sense, I'd say. The second I agree is misleading, let's rewrite it.

Fri, Jan 24, 12:44 PM · Cite
awight awarded T30980: parser tags such as <ref>, <poem>, <timeline> etc. cannot be localized a Barnstar token.
Fri, Jan 24, 9:19 AM · Parsoid, Cite, RTL, I18n, MediaWiki-Internationalization

Yesterday

awight moved T243278: Investigation: Check if it's possible to fix the VE view in Cite alone from Review to Doing on the WMDE-QWERTY-Sprint-2020-01-21 board.
Thu, Jan 23, 10:50 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2020-01-21, Book-Referencing, Cite

Wed, Jan 22

awight claimed T243278: Investigation: Check if it's possible to fix the VE view in Cite alone.
Wed, Jan 22, 10:38 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2020-01-21, Book-Referencing, Cite
awight claimed T242141: Bad numbering when reusing a sub-reference before it's defined.
Wed, Jan 22, 10:37 AM · WMDE-QWERTY-Team, Cite, Book-Referencing, WMDE-QWERTY-Sprint-2020-01-08, WMDE-QWERTY-Sprint-2020-01-21
awight moved T233108: Basic dashboards for Reference Previews tracking from Demo to Watching on the WMDE-QWERTY-Sprint-2020-01-21 board.
Wed, Jan 22, 10:37 AM · TCB-Team, Reference Previews, WMDE-QWERTY-Sprint-2019-10-09, WMDE-QWERTY-Sprint-2019-10-23, WMDE-QWERTY-Sprint-2019-11-06, WMDE-QWERTY-Sprint-2020-01-08, WMDE-QWERTY-Sprint-2020-01-21

Tue, Jan 21

awight updated the task description for T242899: Make MobileFrontend and MinervaNeue compatible with BookReferencing.
Tue, Jan 21, 11:42 AM · WMDE-QWERTY-Sprint-2020-01-21, Reference Previews, MinervaNeue (Tracking), Book-Referencing
awight closed T176421: Design the import via url page as Resolved.

This happened. FWIW, the form is only reachable when a debugging flag is configured on the server, so it's not a user-facing feature.

Tue, Jan 21, 11:18 AM · WMDE-Design, Move-Files-To-Commons, TCB-Team, Design
awight closed T156795: Mockup for FileImporter SpecialPage, a subtask of T156792: Implement SpecialPage for FileImporter extension, as Resolved.
Tue, Jan 21, 11:17 AM · Move-Files-To-Commons, TCB-Team
awight closed T156795: Mockup for FileImporter SpecialPage as Resolved.

This happened, and the feature is deployed.

Tue, Jan 21, 11:17 AM · WMDE-Design, WMDE-UX-Workboard, Move-Files-To-Commons, WMDE-QWERTY-Team, Design, TCB-Team

Mon, Jan 20

awight moved T240671: Retrospective and learnings from the Parser/Cite clone incident from Sprint Backlog to Done on the WMDE-QWERTY-Sprint-2020-01-08 board.
Mon, Jan 20, 4:14 PM · WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-Incident, WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Team, Book-Referencing, Cite
awight created T243221: Rewrite LogicException using safer alternatives.
Mon, Jan 20, 3:58 PM · WMDE-QWERTY-Team, Cite
awight created T243220: Create logstash monitoring dashboard for Technical Wishes products.
Mon, Jan 20, 3:51 PM · WMDE-QWERTY-Team
awight moved T242437: Unable to view some articles due to fatal LogicException: Cannot roll back missing named ref "" (from ReferenceStack.php) from Review to Done on the WMDE-QWERTY-Sprint-2020-01-08 board.
Mon, Jan 20, 3:48 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikimedia-Incident, Book-Referencing, TCB-Team, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-production-error, Cite
awight moved T242141: Bad numbering when reusing a sub-reference before it's defined from Review to Demo on the WMDE-QWERTY-Sprint-2020-01-08 board.
Mon, Jan 20, 1:34 PM · WMDE-QWERTY-Team, Cite, Book-Referencing, WMDE-QWERTY-Sprint-2020-01-08, WMDE-QWERTY-Sprint-2020-01-21
awight moved T242437: Unable to view some articles due to fatal LogicException: Cannot roll back missing named ref "" (from ReferenceStack.php) from Doing to Review on the WMDE-QWERTY-Sprint-2020-01-08 board.
Mon, Jan 20, 10:41 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikimedia-Incident, Book-Referencing, TCB-Team, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-production-error, Cite
awight moved T242141: Bad numbering when reusing a sub-reference before it's defined from Doing to Sprint Backlog on the WMDE-QWERTY-Sprint-2020-01-08 board.
Mon, Jan 20, 9:47 AM · WMDE-QWERTY-Team, Cite, Book-Referencing, WMDE-QWERTY-Sprint-2020-01-08, WMDE-QWERTY-Sprint-2020-01-21
awight placed T242141: Bad numbering when reusing a sub-reference before it's defined up for grabs.
Mon, Jan 20, 9:47 AM · WMDE-QWERTY-Team, Cite, Book-Referencing, WMDE-QWERTY-Sprint-2020-01-08, WMDE-QWERTY-Sprint-2020-01-21
awight lowered the priority of T242437: Unable to view some articles due to fatal LogicException: Cannot roll back missing named ref "" (from ReferenceStack.php) from Unbreak Now! to High.

The "unbreak now" issue is fixed in production, but during code review we found that the fix needs to be rolled back and reimplemented. As currently deployed, the code will show inline errors for any refs with name="" or a name with pure whitespace. Although this is a degenerate case, it wasn't erroring in the past, and our guideline for the rewrite has been to not introduce any new errors for existing wikitext.

Mon, Jan 20, 9:18 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikimedia-Incident, Book-Referencing, TCB-Team, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-production-error, Cite

Fri, Jan 17

awight added a comment to T242437: Unable to view some articles due to fatal LogicException: Cannot roll back missing named ref "" (from ReferenceStack.php).

More examples of fixing the error (thanks, @Reedy!):
https://zh.wikipedia.org/w/index.php?title=User%3AAtana_goodwin%2FWork14&type=revision&diff=57736642&oldid=49425248

Fri, Jan 17, 2:31 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikimedia-Incident, Book-Referencing, TCB-Team, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-production-error, Cite
awight added a comment to T242437: Unable to view some articles due to fatal LogicException: Cannot roll back missing named ref "" (from ReferenceStack.php).

I've already hit the wall with my editing approach. https://zh.wikipedia.org/w/index.php?title=User:Atana_goodwin/Work14&oldid=49425248 cannot be edited because it's under the user namespace, but seems to be breaking the RefreshLinksJob.

Fri, Jan 17, 12:47 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikimedia-Incident, Book-Referencing, TCB-Team, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-production-error, Cite
awight added a comment to T242437: Unable to view some articles due to fatal LogicException: Cannot roll back missing named ref "" (from ReferenceStack.php).

Hopefully the second patch addresses the remaining exceptions. There was an interesting edge case where name="" in a template-generated reflist causes a crash. The patch does additional validation to catch these.

Fri, Jan 17, 10:37 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikimedia-Incident, Book-Referencing, TCB-Team, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-production-error, Cite
awight created T243058: Test that we correctly roll back errors during Cite parsing .
Fri, Jan 17, 10:18 AM · Technical-Debt, Cite

Thu, Jan 16

awight added a comment to T151308: Make VisualEditor compatible with "extends" parameter.

Another option might be to use the already available ….attrs.extends value to access the parent, and display it's contents while editing the sub-reference.

Thu, Jan 16, 3:56 PM · Parsoid, Book-Referencing, German-Community-Wishlist, VisualEditor, TCB-Team, Cite
awight claimed T242141: Bad numbering when reusing a sub-reference before it's defined.
Thu, Jan 16, 12:56 PM · WMDE-QWERTY-Team, Cite, Book-Referencing, WMDE-QWERTY-Sprint-2020-01-08, WMDE-QWERTY-Sprint-2020-01-21
awight moved T242141: Bad numbering when reusing a sub-reference before it's defined from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-01-08 board.
Thu, Jan 16, 12:56 PM · WMDE-QWERTY-Team, Cite, Book-Referencing, WMDE-QWERTY-Sprint-2020-01-08, WMDE-QWERTY-Sprint-2020-01-21
awight moved T240671: Retrospective and learnings from the Parser/Cite clone incident from Doing to Sprint Backlog on the WMDE-QWERTY-Sprint-2020-01-08 board.
Thu, Jan 16, 12:46 PM · WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-Incident, WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Team, Book-Referencing, Cite

Wed, Jan 15

awight moved T242437: Unable to view some articles due to fatal LogicException: Cannot roll back missing named ref "" (from ReferenceStack.php) from Doing to Review on the WMDE-QWERTY-Sprint-2020-01-08 board.
Wed, Jan 15, 11:47 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikimedia-Incident, Book-Referencing, TCB-Team, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-production-error, Cite
awight added a comment to T236765: Remove Phabricator 2FA for awight.

I would still like this reset. I've posted a user committed identity hash in https://www.mediawiki.org/w/index.php?title=User:Adamw&diff=3485365&oldid=3299259&diffmode=source

Wed, Jan 15, 9:25 AM · Phabricator

Tue, Jan 14

awight added a comment to T242437: Unable to view some articles due to fatal LogicException: Cannot roll back missing named ref "" (from ReferenceStack.php).

Um, just noticing that the error I'm chasing is different than the one reported in this task.

LogicException from line 309 of /srv/mediawiki/php-1.35.0-wmf.14/extensions/Cite/src/ReferenceStack.php: Cannot roll back ref with unknown group "".

Tue, Jan 14, 9:32 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikimedia-Incident, Book-Referencing, TCB-Team, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-production-error, Cite
awight added a comment to T242437: Unable to view some articles due to fatal LogicException: Cannot roll back missing named ref "" (from ReferenceStack.php).

I've "fixed" the article to mitigate the logspam: https://fr.wikipedia.org/w/index.php?title=Nachi_(navire)&diff=166346502&oldid=159845204

Tue, Jan 14, 9:14 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikimedia-Incident, Book-Referencing, TCB-Team, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-production-error, Cite
awight added a comment to T242437: Unable to view some articles due to fatal LogicException: Cannot roll back missing named ref "" (from ReferenceStack.php).

It's caused by nested References templates,

Tue, Jan 14, 9:07 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikimedia-Incident, Book-Referencing, TCB-Team, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-production-error, Cite
awight added a comment to T242437: Unable to view some articles due to fatal LogicException: Cannot roll back missing named ref "" (from ReferenceStack.php).

How exciting! This is a page which causes a render exception every time it's viewed: https://fr.wikipedia.org/wiki/Nachi_(navire)

Tue, Jan 14, 8:53 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikimedia-Incident, Book-Referencing, TCB-Team, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-production-error, Cite

Fri, Jan 10

awight added a comment to T242110: Bad numbering of reused sub-references.

My mistake, what I meant to show was this case:

<ref name="a">First</ref>
<ref name="b">Second</ref>
<ref extends="a" name="b">Second</ref>
Fri, Jan 10, 2:22 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), WMDE-QWERTY-Sprint-2020-01-08, WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Team, Cite, Book-Referencing
awight added a comment to T222783: Return meaningful error message when users try to import a file with a forbidden file type.
Fri, Jan 10, 12:42 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), WMDE-QWERTY-Sprint-2020-01-08, Patch-For-Review, good first task, WMDE-QWERTY-Team, TCB-Team, Move-Files-To-Commons

Thu, Jan 9

awight committed rECIT170484e93376: Annotate TODOs with task number (authored by awight).
Annotate TODOs with task number
Thu, Jan 9, 12:49 PM
awight added a comment to T242110: Bad numbering of reused sub-references.

Should we consider the task done now with the patch merged? Or what about the comment on the last patch? Should this go into an extra ticket?

Thu, Jan 9, 12:19 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), WMDE-QWERTY-Sprint-2020-01-08, WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Team, Cite, Book-Referencing
awight added a project to T241833: Instrument Cite to record the nubmer of footnote marks and references list entries rendered in each article: User-awight.
Thu, Jan 9, 10:29 AM · User-awight, Patch-For-Review, Analytics, Research, WMDE-QWERTY-Sprint-2019-12-11, Reference Previews, Cite

Wed, Jan 8

awight committed rECITb7c9dbb0d58c: Remove invalid test case (authored by awight).
Remove invalid test case
Wed, Jan 8, 5:05 PM
awight updated the task description for T242227: Edge case: don't allow following a subreference.
Wed, Jan 8, 3:56 PM · Book-Referencing, Cite
awight created T242227: Edge case: don't allow following a subreference.
Wed, Jan 8, 3:56 PM · Book-Referencing, Cite
awight reopened T239810: Book refs cannot extend references defined in {{#tag:references}} as "Open".

I closed this too quickly. Behavior is indeed different if <references> is used instead, which is incorrect. The snippet given in the task description should be allowed, and implementation will require changes to the ReferenceStack "undo" logic.

Wed, Jan 8, 2:05 PM · WMDE-QWERTY-Sprint-2020-01-08, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Book-Referencing
awight closed T239810: Book refs cannot extend references defined in {{#tag:references}} as Invalid.

The error is actually with the parent ref. It must be used outside of the <references> section:

Wed, Jan 8, 1:20 PM · WMDE-QWERTY-Sprint-2020-01-08, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Book-Referencing
awight added a comment to T240424: Decide whether to support "extends" in the references section.

Just a note during sprint planning: I think we can omit this feature from the MVP, by agreeing to always error if a ref is written using "extends" in some reuses but not others.

Wed, Jan 8, 12:47 PM · WMDE-QWERTY-Sprint-2020-01-08, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), Patch-For-Review, WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Sprint-2019-11-20, Book-Referencing, Design, WMDE-Design, TCB-Team, Cite
awight renamed T240449: Investigation: How to get to the edit conflict UI avoiding the automatic resolution from How to get to the edit conflict UI avoiding the automatic resolution to Investigation: How to get to the edit conflict UI avoiding the automatic resolution.
Wed, Jan 8, 12:44 PM · Spike, WMDE-QWERTY-Sprint-2020-01-08, Patch-For-Review, WMDE-QWERTY-Sprint-2019-12-11, Two-Column-Edit-Conflict-Merge, TCB-Team
awight changed the point value for T240858: Clean up implementation for "follow" cases from 8 to 3.
Wed, Jan 8, 12:43 PM · WMDE-QWERTY-Sprint-2020-01-21, WMDE-QWERTY-Sprint-2020-01-08, User-notice, Patch-For-Review, Technical-Debt, Book-Referencing, Cite, WMDE-QWERTY-Sprint-2019-12-11

Tue, Jan 7

awight created T242127: Remove or simplify tracking metrics.
Tue, Jan 7, 3:53 PM · CPT Initiatives (Modern Event Platform (TEC2)), Cite, Reference Previews, Analytics
awight moved T240858: Clean up implementation for "follow" cases from Review to Watching on the WMDE-QWERTY-Sprint-2019-12-11 board.
Tue, Jan 7, 3:44 PM · WMDE-QWERTY-Sprint-2020-01-21, WMDE-QWERTY-Sprint-2020-01-08, User-notice, Patch-For-Review, Technical-Debt, Book-Referencing, Cite, WMDE-QWERTY-Sprint-2019-12-11
awight closed T214493: Track interaction with ReferencePreviews, a subtask of T193051: Remove all page previews instrumentation code, as Resolved.
Tue, Jan 7, 2:53 PM · Page-Previews, Readers-Web-Backlog
awight closed T214493: Track interaction with ReferencePreviews, a subtask of T233108: Basic dashboards for Reference Previews tracking, as Resolved.
Tue, Jan 7, 2:53 PM · TCB-Team, Reference Previews, WMDE-QWERTY-Sprint-2019-10-09, WMDE-QWERTY-Sprint-2019-10-23, WMDE-QWERTY-Sprint-2019-11-06, WMDE-QWERTY-Sprint-2020-01-08, WMDE-QWERTY-Sprint-2020-01-21
awight closed T214493: Track interaction with ReferencePreviews as Resolved.

Summarized in the task description, now I think we can close and continue work by reviewing the dashboards in the next ticket.

Tue, Jan 7, 2:53 PM · WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Sprint-2019-11-20, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), WMDE-QWERTY-Sprint-2019-11-06, WMDE-QWERTY-Sprint-2019-10-23, WMDE-QWERTY-Sprint-2019-10-09, WMDE-QWERTY-Sprint-2019-09-25, WMDE-QWERTY-Sprint-2019-09-10, Readers-Web-Backlog (Tracking), TCB-Team, Page-Previews, Reference Previews
awight updated the task description for T214493: Track interaction with ReferencePreviews.
Tue, Jan 7, 2:43 PM · WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Sprint-2019-11-20, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), WMDE-QWERTY-Sprint-2019-11-06, WMDE-QWERTY-Sprint-2019-10-23, WMDE-QWERTY-Sprint-2019-10-09, WMDE-QWERTY-Sprint-2019-09-25, WMDE-QWERTY-Sprint-2019-09-10, Readers-Web-Backlog (Tracking), TCB-Team, Page-Previews, Reference Previews
awight added a comment to T242110: Bad numbering of reused sub-references.

I changed the title and description because this seems to be about reused refs, the "with the same content" part is irrelevant.

Tue, Jan 7, 2:19 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), WMDE-QWERTY-Sprint-2020-01-08, WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Team, Cite, Book-Referencing
awight renamed T242110: Bad numbering of reused sub-references from Bad numbering of identical sub-references with the same content to Bad numbering of reused sub-references.
Tue, Jan 7, 2:18 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), WMDE-QWERTY-Sprint-2020-01-08, WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Team, Cite, Book-Referencing
awight added a comment to T182351: Make HTML dumps available.

I noticed that the criteria listed in the "why?" of this task could also be satisfied by simply expanding the wikitext without fully rendering. For example:

Tue, Jan 7, 1:39 PM · Research-Backlog, Datasets-Archiving, Analytics
awight moved T233108: Basic dashboards for Reference Previews tracking from Sprint Backlog to Demo on the WMDE-QWERTY-Sprint-2019-12-11 board.
Tue, Jan 7, 1:16 PM · TCB-Team, Reference Previews, WMDE-QWERTY-Sprint-2019-10-09, WMDE-QWERTY-Sprint-2019-10-23, WMDE-QWERTY-Sprint-2019-11-06, WMDE-QWERTY-Sprint-2020-01-08, WMDE-QWERTY-Sprint-2020-01-21
awight added a project to T233108: Basic dashboards for Reference Previews tracking: WMDE-QWERTY-Sprint-2019-12-11.

Let's demo and close.

Tue, Jan 7, 1:16 PM · TCB-Team, Reference Previews, WMDE-QWERTY-Sprint-2019-10-09, WMDE-QWERTY-Sprint-2019-10-23, WMDE-QWERTY-Sprint-2019-11-06, WMDE-QWERTY-Sprint-2020-01-08, WMDE-QWERTY-Sprint-2020-01-21
awight added a comment to T240459: Merge sub-references when they have the same content.

Oops, I see the same discussion already took place on the deduplicated task.

Tue, Jan 7, 12:46 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Cite, Book-Referencing
awight added a comment to T240459: Merge sub-references when they have the same content.

Here's the syntax which matches the current feature, and it already does work correctly for subreferences. I think we should close this task.

Tue, Jan 7, 12:45 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Cite, Book-Referencing
awight added a comment to T240459: Merge sub-references when they have the same content.

this is how top-level references also behave

Tue, Jan 7, 12:42 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Cite, Book-Referencing
awight updated the task description for T241833: Instrument Cite to record the nubmer of footnote marks and references list entries rendered in each article.
Tue, Jan 7, 10:37 AM · User-awight, Patch-For-Review, Analytics, Research, WMDE-QWERTY-Sprint-2019-12-11, Reference Previews, Cite
awight set the color for User-awight to Checkered.
Tue, Jan 7, 9:35 AM
awight set the icon for User-awight to User.
Tue, Jan 7, 9:34 AM
awight added a member for Trusted-Contributors: Lena_WMDE.
Tue, Jan 7, 9:24 AM
awight awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Barnstar token.
Tue, Jan 7, 8:39 AM · Security-Team, TechCom-RFC

Mon, Jan 6

awight committed rECIT2aed80be24a6: Consolidate refCallStack-gnosticism (authored by awight).
Consolidate refCallStack-gnosticism
Mon, Jan 6, 12:56 PM
awight committed rECIT7bde21d49a65: Correction to error message (authored by awight).
Correction to error message
Mon, Jan 6, 12:49 PM

Fri, Jan 3

awight updated the task description for T241832: Research citation density and correlation to citation usage.
Fri, Jan 3, 1:36 PM · WMDE-QWERTY-Sprint-2019-12-11, Reference Previews, Cite
awight updated the task description for T241833: Instrument Cite to record the nubmer of footnote marks and references list entries rendered in each article.
Fri, Jan 3, 1:34 PM · User-awight, Patch-For-Review, Analytics, Research, WMDE-QWERTY-Sprint-2019-12-11, Reference Previews, Cite
awight created T241833: Instrument Cite to record the nubmer of footnote marks and references list entries rendered in each article.
Fri, Jan 3, 1:28 PM · User-awight, Patch-For-Review, Analytics, Research, WMDE-QWERTY-Sprint-2019-12-11, Reference Previews, Cite
awight created T241832: Research citation density and correlation to citation usage.
Fri, Jan 3, 1:20 PM · WMDE-QWERTY-Sprint-2019-12-11, Reference Previews, Cite

Wed, Jan 1

awight added a comment to T240858: Clean up implementation for "follow" cases.

This patch is currently a bottleneck to the others: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Cite/+/559671/

Wed, Jan 1, 11:27 AM · WMDE-QWERTY-Sprint-2020-01-21, WMDE-QWERTY-Sprint-2020-01-08, User-notice, Patch-For-Review, Technical-Debt, Book-Referencing, Cite, WMDE-QWERTY-Sprint-2019-12-11

Sun, Dec 29

awight committed rECIT475d2aeb75c8: Clean up i18n messages (authored by awight).
Clean up i18n messages
Sun, Dec 29, 9:30 PM

Dec 24 2019

awight committed rECIT2a3879eafa68: Harden logic assertions (authored by awight).
Harden logic assertions
Dec 24 2019, 1:47 PM

Dec 20 2019

awight committed rECIT377cdb3b9fd8: Less checkered error message style (authored by awight).
Less checkered error message style
Dec 20 2019, 11:35 AM
awight updated the task description for T241214: Discuss: Missing references group should be printed with error, rather than suppressed?.
Dec 20 2019, 9:32 AM · Design, WMDE-Design, Cite
awight updated the task description for T241214: Discuss: Missing references group should be printed with error, rather than suppressed?.
Dec 20 2019, 9:27 AM · Design, WMDE-Design, Cite
awight created T241214: Discuss: Missing references group should be printed with error, rather than suppressed?.
Dec 20 2019, 9:25 AM · Design, WMDE-Design, Cite

Dec 19 2019

awight committed rECIT028424a6822b: More function call argument unpacking (authored by thiemowmde).
More function call argument unpacking
Dec 19 2019, 12:12 PM
awight changed the point value for T229307: Reference numbers wrong in Firefox when following a list from 8 to 5.
Dec 19 2019, 10:46 AM · User-Ryasmeen, WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Cite, WMDE-QWERTY-Sprint-2019-11-20, Upstream, VisualEditor, VisualEditor-MediaWiki-References, Browser-Support-Firefox
awight set the point value for T240947: ReferencePreviews accidentally enabled for new users even if in Beta to 3.

Assigning random story points, please revise as needed.

Dec 19 2019, 10:45 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), WMDE-QWERTY-Sprint-2019-12-11, Reference Previews
awight set the point value for T239787: CSS counters are messing up <references> list numbering in Firefox to 5.

Assigning random story points, please revise as needed.

Dec 19 2019, 10:45 AM · WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Book-Referencing, WMDE-QWERTY-Sprint-2019-11-20, Cite
awight set the point value for T229307: Reference numbers wrong in Firefox when following a list to 8.

Assigning random story points, please revise as needed.

Dec 19 2019, 10:44 AM · User-Ryasmeen, WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Cite, WMDE-QWERTY-Sprint-2019-11-20, Upstream, VisualEditor, VisualEditor-MediaWiki-References, Browser-Support-Firefox
awight set the point value for T240858: Clean up implementation for "follow" cases to 8.
Dec 19 2019, 10:44 AM · WMDE-QWERTY-Sprint-2020-01-21, WMDE-QWERTY-Sprint-2020-01-08, User-notice, Patch-For-Review, Technical-Debt, Book-Referencing, Cite, WMDE-QWERTY-Sprint-2019-12-11
awight set the point value for T239329: [Design] How should book references appear when reused? to 0.
Dec 19 2019, 10:43 AM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Sprint-2019-11-20, Design, WMDE-Design, Book-Referencing, Cite
awight updated the task description for T240671: Retrospective and learnings from the Parser/Cite clone incident.
Dec 19 2019, 10:41 AM · WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-Incident, WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Team, Book-Referencing, Cite
awight set the point value for T240671: Retrospective and learnings from the Parser/Cite clone incident to 8.

Adding a random story point estimate. The incident report looks complete, I'll tick that box.

Dec 19 2019, 10:40 AM · WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-Incident, WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Team, Book-Referencing, Cite
awight committed rECIT1e82f8f0736d: Move "dir" error handling to validation (authored by awight).
Move "dir" error handling to validation
Dec 19 2019, 10:18 AM
awight awarded T240854: Leave feedback via Code-Review or Verified label a Like token.
Dec 19 2019, 9:39 AM · Code-Health-Metrics, Sonarqubebot

Dec 18 2019

awight added a comment to T240431: Circular reference prevents Parser destruction.

There might not be a way to measure the impact of this change. We aren't measuring the total memory extent of each thread, and garbage collection is (allegedly) disabled, with no recorded metrics that might show us decreased memory pressure.

Dec 18 2019, 3:46 PM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), WMDE-QWERTY-Sprint-2019-12-11, Cite
awight moved T237631: Improve on-wiki documentation for Cite features from Doing to Demo on the WMDE-QWERTY-Sprint-2019-12-11 board.

I ran out of steam on this iteration, here's a summary of what has changed:

  • All usage instructions moved from Extension:Cite to Help:Cite.
  • Configuration variables documented.
  • Extension template metadata updated.
  • Clean up formatting, translate tags, and details.
  • Deprioritize "follow" feature by moving lower in the doc.
  • Remove error message documentation.
Dec 18 2019, 3:00 PM · WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Sprint-2019-11-20, Book-Referencing, Cite, Documentation
awight added a comment to T239792: Exploration: What data do we have to decide if a conflict can be resolved?.

As can be seen in patch https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/530148/ , if we hook in after the external 3-way merge tool, we can detect whether automatic resolution failed.

Dec 18 2019, 2:39 PM · WMDE-QWERTY-Sprint-2019-12-11, TCB-Team, WMDE-QWERTY-Team, Two-Column-Edit-Conflict-Merge
awight added a comment to T239792: Exploration: What data do we have to decide if a conflict can be resolved?.

We also have access to the new, unsaved revision text.

Dec 18 2019, 2:24 PM · WMDE-QWERTY-Sprint-2019-12-11, TCB-Team, WMDE-QWERTY-Team, Two-Column-Edit-Conflict-Merge
awight moved T240671: Retrospective and learnings from the Parser/Cite clone incident from On-going to Follow-up on the Wikimedia-Incident board.
Dec 18 2019, 2:22 PM · WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-Incident, WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Team, Book-Referencing, Cite
awight added a project to T240671: Retrospective and learnings from the Parser/Cite clone incident: Wikimedia-Incident.
Dec 18 2019, 2:22 PM · WMDE-QWERTY-Sprint-2020-01-08, Wikimedia-Incident, WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Team, Book-Referencing, Cite
awight moved T240345: {{#expr: expression }} breaks references in the whole article if expression throws an error from Follow-up to On-going on the Wikimedia-Incident board.
Dec 18 2019, 2:22 PM · Wikimedia-Incident, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), WMDE-QWERTY-Sprint-2019-11-20, Cite, ParserFunctions, MediaWiki-Parser
awight moved T240345: {{#expr: expression }} breaks references in the whole article if expression throws an error from On-going to Follow-up on the Wikimedia-Incident board.
Dec 18 2019, 2:21 PM · Wikimedia-Incident, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), WMDE-QWERTY-Sprint-2019-11-20, Cite, ParserFunctions, MediaWiki-Parser
awight added a project to T240345: {{#expr: expression }} breaks references in the whole article if expression throws an error: Wikimedia-Incident.
Dec 18 2019, 2:21 PM · Wikimedia-Incident, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), WMDE-QWERTY-Sprint-2019-11-20, Cite, ParserFunctions, MediaWiki-Parser
awight moved T240947: ReferencePreviews accidentally enabled for new users even if in Beta from Backlog to Doing on the Reference Previews board.
Dec 18 2019, 12:54 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), WMDE-QWERTY-Sprint-2019-12-11, Reference Previews