Page MenuHomePhabricator

awight (Adam Roses Wight)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 12 2014, 9:02 PM (310 w, 3 d)
Availability
Available
IRC Nick
awight
LDAP User
Awight
MediaWiki User
Adamw [ Global Accounts ]

Recent Activity

Yesterday

awight updated the task description for T261876: Test instance: TemplateData editor parameter properties page updates.
Wed, Sep 23, 12:53 PM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight added a comment to T261876: Test instance: TemplateData editor parameter properties page updates.

Is it difficult to change the widget to a DropdownWidget instead of the ButtonGroupWidget? If it's alright, then it should also be the same layout where Optional is already selected and they could just change to another in the dropdown. I guess also if it's ok, then this should be a new ticket?

Wed, Sep 23, 12:52 PM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight moved T261876: Test instance: TemplateData editor parameter properties page updates from Doing to Demo on the WMDE-QWERTY-Sprint-2020-09-09 board.

Live on the test instance.

Wed, Sep 23, 12:48 PM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight added a comment to T261876: Test instance: TemplateData editor parameter properties page updates.

This was an existing problem, but the priority buttons are wrapping awkwardly regardless of zoom level:

Wed, Sep 23, 12:39 PM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight added a comment to T261876: Test instance: TemplateData editor parameter properties page updates.
Wed, Sep 23, 12:20 PM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight added a comment to T260773: Test instance: Convert cherry-picked forks to proper branches.

@WMDE-Fisch I'm realizing that waiting on feedback for just the VisualEditor repo doesn't make sense. Let's go ahead and expand the experiment to include the other repos we're heavily branching, starting with CodeMirror and TemplateData, if you agree? I'll mirror those two, and I've added instructions to this task about how to mirror additional repos, under "Mirror a new repo from Gerrit".

Wed, Sep 23, 11:39 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight updated the task description for T260773: Test instance: Convert cherry-picked forks to proper branches.
Wed, Sep 23, 11:37 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight moved T260773: Test instance: Convert cherry-picked forks to proper branches from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-09-23 board.
Wed, Sep 23, 8:24 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight moved T261876: Test instance: TemplateData editor parameter properties page updates from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-09-23 board.
Wed, Sep 23, 8:24 AM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight moved T262255: Test instance: Fix remaining issues with bracket matching from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-09-23 board.
Wed, Sep 23, 8:24 AM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea, WMDE-Technical-Wishes-Team

Tue, Sep 22

awight updated the task description for T260773: Test instance: Convert cherry-picked forks to proper branches.
Tue, Sep 22, 12:38 PM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight added a comment to T263534: Editing "deprecated" guidance in TemplateData destroys JSON.

I tried reproducing this on enwiki, by changing the TemplateData "description" multiple times. I was unable to cause corruption.

Tue, Sep 22, 12:25 PM · WMDE-Templates-FocusArea, TemplateData, VisualEditor
awight added a comment to T260888: VE Dialog on Test instance: Update template title, description, and help text.

"no description" text should be above deprecated warning. Wrong:

Tue, Sep 22, 12:06 PM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a comment to T260803: VE Dialog on the Test Instance: Add file preview to file type parameters.

Fix placeholders and non-image media files.

Tue, Sep 22, 11:58 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a comment to T263521: Test instance content: pull in templates for usability tests.

Looks like the infobox is missing one of its nested templates? Would you mind also pulling in "italic title"?

Tue, Sep 22, 10:44 AM · Unplanned-Sprint-Work, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight moved T263521: Test instance content: pull in templates for usability tests from Sprint Backlog to Demo on the WMDE-QWERTY-Sprint-2020-09-09 board.
vagrant@mediawiki-vagrant:/vagrant$ mwscript importDump.php --wiki=enwiki /vagrant/xml_imports/en-T263521.xml

done!

Tue, Sep 22, 8:44 AM · Unplanned-Sprint-Work, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea

Mon, Sep 21

awight added a comment to T261876: Test instance: TemplateData editor parameter properties page updates.

Are the inline help strings listed somewhere? I can glean most of them from the mockup, but some are truncated...

Mon, Sep 21, 11:41 AM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight added a comment to T261873: Test instance:TemplateData editor update parameter list.

@thiemowmde Does this really need review or can it be demoed now?

Mon, Sep 21, 6:42 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea

Fri, Sep 18

awight added a comment to T261876: Test instance: TemplateData editor parameter properties page updates.

@ECohen_WMDE There's already an OOUI standard layout for inline help text:

Fri, Sep 18, 1:21 PM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight added a comment to T261876: Test instance: TemplateData editor parameter properties page updates.

Note to self: "Same size applies to the parameter editing screen" -> this will happen by default, the parameter editing screen is implemented as a pane in the template editor dialog.

Fri, Sep 18, 1:08 PM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight moved T261876: Test instance: TemplateData editor parameter properties page updates from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-09-09 board.
Fri, Sep 18, 1:02 PM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight moved T260138: Record baseline statistics about syntax highlighting (CodeMirror) use from Doing to Review on the WMDE-QWERTY-Sprint-2020-09-09 board.

Moving to review so that we can start collecting data.

Fri, Sep 18, 1:01 PM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, Community-Tech, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea
awight added a comment to T260138: Record baseline statistics about syntax highlighting (CodeMirror) use.

Note to self, both the VE 2017 wikitext editor and the 2010 source code editor share the usecodemirror preference.

Fri, Sep 18, 12:56 PM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, Community-Tech, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea
awight added a comment to T260138: Record baseline statistics about syntax highlighting (CodeMirror) use.

Preliminary counts,

Fri, Sep 18, 12:41 PM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, Community-Tech, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea
awight updated the task description for T260138: Record baseline statistics about syntax highlighting (CodeMirror) use.
Fri, Sep 18, 12:27 PM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, Community-Tech, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea
awight added a comment to T260138: Record baseline statistics about syntax highlighting (CodeMirror) use.

In the original ticket they also mention the related gadgets and some usage numbers T101246: Highlighted wikisyntax while editing articles [AOI] - @Lena_WMDE could be useful to gather the current gadget usage numbers and compare with the CodeMirror hidden preference?

Fri, Sep 18, 12:14 PM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, Community-Tech, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea
awight claimed T260138: Record baseline statistics about syntax highlighting (CodeMirror) use.
Fri, Sep 18, 11:39 AM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, Community-Tech, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea
awight moved T260138: Record baseline statistics about syntax highlighting (CodeMirror) use from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-09-09 board.
Fri, Sep 18, 11:39 AM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, Community-Tech, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea
awight added a comment to T260773: Test instance: Convert cherry-picked forks to proper branches.

The "review" request is for other devs to go through all the steps and post their observations on this task.

Fri, Sep 18, 11:37 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea

Thu, Sep 17

awight moved T260888: VE Dialog on Test instance: Update template title, description, and help text from Review to Demo on the WMDE-QWERTY-Sprint-2020-09-09 board.

Rebased and resolved some minor merge conflicts. This is live on the test instance.

Thu, Sep 17, 11:03 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea

Wed, Sep 16

awight placed T260794: Test instance: Can use TemplateData to mark entire templates as deprecated up for grabs.
Wed, Sep 16, 11:14 AM · WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight placed T260803: VE Dialog on the Test Instance: Add file preview to file type parameters up for grabs.
Wed, Sep 16, 11:14 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight moved T262390: Test instance: Deprecated template warning from Doing to Demo on the WMDE-QWERTY-Sprint-2020-09-09 board.
Wed, Sep 16, 10:59 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight moved T262390: Test instance: Deprecated template warning from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-09-09 board.
Wed, Sep 16, 10:21 AM · Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight moved T260803: VE Dialog on the Test Instance: Add file preview to file type parameters from Doing to Demo on the WMDE-QWERTY-Sprint-2020-09-09 board.

Yes, if possible the three dots is much preferred. Thanks!

Wed, Sep 16, 10:12 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea

Tue, Sep 15

awight added a comment to T260803: VE Dialog on the Test Instance: Add file preview to file type parameters.

the progress bar is working for now, but I should coord with WMF about OOUI and the three loading dots.

Tue, Sep 15, 9:40 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a comment to T260803: VE Dialog on the Test Instance: Add file preview to file type parameters.

It looks like the local "query imageinfo" API is able to return thumbnail URLs for commonswiki, I'll try to integrate with that.

Tue, Sep 15, 8:39 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight claimed T260803: VE Dialog on the Test Instance: Add file preview to file type parameters.
Tue, Sep 15, 8:06 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight moved T260803: VE Dialog on the Test Instance: Add file preview to file type parameters from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-09-09 board.
Tue, Sep 15, 8:06 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea

Mon, Sep 14

awight placed T260803: VE Dialog on the Test Instance: Add file preview to file type parameters up for grabs.
Mon, Sep 14, 11:55 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight updated the task description for T260773: Test instance: Convert cherry-picked forks to proper branches.
Mon, Sep 14, 11:39 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight added a comment to T260803: VE Dialog on the Test Instance: Add file preview to file type parameters.

Confirmed the same behavior in the original patch. It depends on the filename, I got lucky with a long name including many short words: "User overlap bug.png". Results from the server are nondeterministic, and I've seen nothing show up in the first hundred matches. Even more alarmingly, setting the limit to 200 caused server memory exhaustion, reporting that it had tried to allocate 700MB before crashing.

Mon, Sep 14, 11:29 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a comment to T260803: VE Dialog on the Test Instance: Add file preview to file type parameters.

We're keeping this task open to iron out any last issues, the merge with other features was non-trivial and may have broken things.

Mon, Sep 14, 11:16 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight created T262813: Analyze actual usage of File and Page template parameters.
Mon, Sep 14, 10:55 AM · WMDE-Templates-FocusArea
awight claimed T260803: VE Dialog on the Test Instance: Add file preview to file type parameters.
Mon, Sep 14, 10:46 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight moved T260803: VE Dialog on the Test Instance: Add file preview to file type parameters from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-09-09 board.
Mon, Sep 14, 10:46 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight placed T260773: Test instance: Convert cherry-picked forks to proper branches up for grabs.
Mon, Sep 14, 10:46 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight moved T260773: Test instance: Convert cherry-picked forks to proper branches from Doing to Review on the WMDE-QWERTY-Sprint-2020-09-09 board.
Mon, Sep 14, 10:26 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight updated the task description for T260773: Test instance: Convert cherry-picked forks to proper branches.
Mon, Sep 14, 10:26 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight updated the task description for T260773: Test instance: Convert cherry-picked forks to proper branches.
Mon, Sep 14, 10:11 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight added a comment to T260773: Test instance: Convert cherry-picked forks to proper branches.

Porting the branches to gitlab was really a pleasure. The basic process was,

Mon, Sep 14, 10:06 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight updated the task description for T260773: Test instance: Convert cherry-picked forks to proper branches.
Mon, Sep 14, 9:53 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight updated the task description for T260773: Test instance: Convert cherry-picked forks to proper branches.
Mon, Sep 14, 9:52 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight updated the task description for T260773: Test instance: Convert cherry-picked forks to proper branches.
Mon, Sep 14, 8:55 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight updated the task description for T260773: Test instance: Convert cherry-picked forks to proper branches.
Mon, Sep 14, 8:55 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight claimed T260773: Test instance: Convert cherry-picked forks to proper branches.
Mon, Sep 14, 8:46 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight moved T260773: Test instance: Convert cherry-picked forks to proper branches from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-09-09 board.
Mon, Sep 14, 8:46 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea

Thu, Sep 10

awight added a comment to T262526: TemplateData deprecated parameter guidance should be translatable.

Good catch @awight , are you planning to work on this in your efforts to improve templates in the VisualEditor?

Thu, Sep 10, 5:25 PM · Editing-team (Tracking), VisualEditor, TemplateData
awight added a comment to T262390: Test instance: Deprecated template warning.

@ECohen_WMDE This is only about the VisualEditor? Or should the TemplateWizard be modified as well?

Thu, Sep 10, 12:36 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a project to T260773: Test instance: Convert cherry-picked forks to proper branches: WMDE-QWERTY-Sprint-2020-09-09.

We need to act on this, we're 11 patches into a branch on the VisualEditor repo alone, and it's becoming difficult to replicate the test instance locally for further development.

Thu, Sep 10, 12:28 PM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight moved T260794: Test instance: Can use TemplateData to mark entire templates as deprecated from Doing to Demo on the WMDE-QWERTY-Sprint-2020-09-09 board.
Thu, Sep 10, 12:24 PM · WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a comment to T260794: Test instance: Can use TemplateData to mark entire templates as deprecated.

The TemplateData part of this feature is live on the test instance.

Thu, Sep 10, 11:54 AM · WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a comment to T262526: TemplateData deprecated parameter guidance should be translatable.

Fixing might be as simple as adding allowLanguages to the property descriptor.

Thu, Sep 10, 11:29 AM · Editing-team (Tracking), VisualEditor, TemplateData
awight added a comment to T260794: Test instance: Can use TemplateData to mark entire templates as deprecated.

@ECohen_WMDE
Should the "Deprecated guidance" header end with "(en)" like the other text inputs, and be translatable? I think this is correct because the message will be used in the interface. For now, I'll leave the string untranslateable for consistency with the shortcoming documented in T262526: TemplateData deprecated parameter guidance should be translatable.

Thu, Sep 10, 11:28 AM · WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight created T262526: TemplateData deprecated parameter guidance should be translatable.
Thu, Sep 10, 11:26 AM · Editing-team (Tracking), VisualEditor, TemplateData
awight placed T260803: VE Dialog on the Test Instance: Add file preview to file type parameters up for grabs.
Thu, Sep 10, 6:31 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight moved T261852: Consider replacing the word "entry" from Review to Demo on the WMDE-QWERTY-Sprint-2020-08-26 board.
Thu, Sep 10, 6:31 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, Two-Column-Edit-Conflict-Merge

Wed, Sep 9

awight added a comment to T260138: Record baseline statistics about syntax highlighting (CodeMirror) use.

We can capture the preference toggling by adding the preference name to an inclusion list in WikimediaEvents PrefUpdateInstrumentation::PROPERTY_TRACKLIST.

Wed, Sep 9, 10:14 AM · WMDE-QWERTY-Sprint-2020-09-23, Patch-For-Review, WMDE-QWERTY-Sprint-2020-09-09, Community-Tech, MediaWiki-extensions-CodeMirror, WMDE-Templates-FocusArea
awight changed the point value for T261284: VE Dialog on the Test Instance: Change placement of examples from 1 to 2.
Wed, Sep 9, 9:34 AM · Unplanned-Sprint-Work, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a comment to T260803: VE Dialog on the Test Instance: Add file preview to file type parameters.

There are several ways to request thumbnails from Commons.

Wed, Sep 9, 8:50 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a comment to T261284: VE Dialog on the Test Instance: Change placement of examples.

Ready for demoing again. An earlier patch had inadvertently removed the example and parameter deprecation notices from the description text.

Wed, Sep 9, 8:43 AM · Unplanned-Sprint-Work, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea

Mon, Sep 7

awight added a comment to T261504: VE on Test Instance: Change behavior for adding/removing params.

Yes, please implement as written. I'm a bit less worried, as this is already the behavior in TemplateWizard and it works quite well (you can try it out there already if you're curious). The current dropdown actually makes it much harder to work with templates with many parameters (it's hard to get an overview and to add/remove them to understand each parameter).

Mon, Sep 7, 11:23 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a comment to T260794: Test instance: Can use TemplateData to mark entire templates as deprecated.

@ECohen_WMDE How should we change the static rendering of TemplateData? For example this table,

Mon, Sep 7, 11:10 AM · WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight renamed T260794: Test instance: Can use TemplateData to mark entire templates as deprecated from Test Instance: VE Dialog doesn't suggest deprecated templates; TemplateData editor can mark templates as deprecated to POC: Can use TemplateData to mark entire templates as deprecated.
Mon, Sep 7, 11:02 AM · WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight renamed T260794: Test instance: Can use TemplateData to mark entire templates as deprecated from VE Dialog on the Test Instance: Add deprecated templates to TemplateData to Test Instance: VE Dialog doesn't suggest deprecated templates; TemplateData editor can mark templates as deprecated.
Mon, Sep 7, 10:54 AM · WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight claimed T260794: Test instance: Can use TemplateData to mark entire templates as deprecated.
Mon, Sep 7, 10:47 AM · WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight moved T260794: Test instance: Can use TemplateData to mark entire templates as deprecated from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-08-26 board.
Mon, Sep 7, 10:47 AM · WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a comment to T261504: VE on Test Instance: Change behavior for adding/removing params.

@ECohen_WMDE

Remove the 'Add more information' dropdown at the bottom of the main input area, where parameters are currently added to templates.

There needs to still be a way to add unknown template parameters. For example, when the TemplateData is incomplete and has not been updated to document a newly-implemented parameter.
I suggest we either leave "add more information", or have a button that does this.

Mon, Sep 7, 10:05 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a comment to T261504: VE on Test Instance: Change behavior for adding/removing params.

When a template has hundreds of parameters, I worry that this might fall apart:

The sidebar will display all parameters, not just those that have been added. The parameter icon to the left of the parameter names is removed and replaced with "+"/"-" buttons (same buttons & behaviour as in the TemplateWizard sidebar). These are used to add and remove them to the template, i.e. shown in or removed from the main input section on the right.

Is there an affordance to search template names?

Mon, Sep 7, 9:48 AM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight moved T261503: Remove hide/show functionality from sidebar and adjust margins from Doing to Demo on the WMDE-QWERTY-Sprint-2020-08-26 board.
Mon, Sep 7, 9:38 AM · Unplanned-Sprint-Work, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight moved T261284: VE Dialog on the Test Instance: Change placement of examples from Review to Demo on the WMDE-QWERTY-Sprint-2020-08-26 board.
Mon, Sep 7, 9:36 AM · Unplanned-Sprint-Work, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight moved T261503: Remove hide/show functionality from sidebar and adjust margins from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-08-26 board.
Mon, Sep 7, 8:52 AM · Unplanned-Sprint-Work, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight claimed T261503: Remove hide/show functionality from sidebar and adjust margins.
Mon, Sep 7, 8:52 AM · Unplanned-Sprint-Work, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight moved T261503: Remove hide/show functionality from sidebar and adjust margins from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.
Mon, Sep 7, 8:52 AM · Unplanned-Sprint-Work, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight changed the point value for T261284: VE Dialog on the Test Instance: Change placement of examples from 3 to 1.

Reducing the estimate, there wasn't much left to this ticket.

Mon, Sep 7, 8:51 AM · Unplanned-Sprint-Work, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight updated the task description for T261284: VE Dialog on the Test Instance: Change placement of examples.
Mon, Sep 7, 8:09 AM · Unplanned-Sprint-Work, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight claimed T261284: VE Dialog on the Test Instance: Change placement of examples.
Mon, Sep 7, 8:07 AM · Unplanned-Sprint-Work, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a project to T261284: VE Dialog on the Test Instance: Change placement of examples: WMDE-QWERTY-Sprint-2020-08-26.
Mon, Sep 7, 8:07 AM · Unplanned-Sprint-Work, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight moved T261284: VE Dialog on the Test Instance: Change placement of examples from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.
Mon, Sep 7, 8:07 AM · Unplanned-Sprint-Work, Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea

Fri, Sep 4

awight moved T260888: VE Dialog on Test instance: Update template title, description, and help text from Doing to Sprint Backlog on the WMDE-QWERTY-Sprint-2020-08-26 board.
Fri, Sep 4, 3:04 PM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a comment to T260888: VE Dialog on Test instance: Update template title, description, and help text.

Minor thing: the dialog title is currently the template name (see below), but should we change that to "Insert a template"?

Fri, Sep 4, 2:55 PM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a comment to T260773: Test instance: Convert cherry-picked forks to proper branches.

Wow, do *not* do what I did. Force push was a total disaster:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/624681
vs
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/VisualEditor/+/refs/heads/wmde-templates

Fri, Sep 4, 2:52 PM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight added a comment to T260888: VE Dialog on Test instance: Update template title, description, and help text.

Minor thing: the dialog title is currently the template name (see below), but should we change that to "Insert a template"?

Fri, Sep 4, 2:41 PM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight moved T260888: VE Dialog on Test instance: Update template title, description, and help text from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2020-08-26 board.
Fri, Sep 4, 2:22 PM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, Patch-For-Review, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight assigned T260887: Implement unsaved changes warning message to Andrew-WMDE.
Fri, Sep 4, 2:19 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a comment to T260773: Test instance: Convert cherry-picked forks to proper branches.

It didn't work so well. The branch isn't forwarded when using the repo over anonymous HTTPS.

Fri, Sep 4, 1:39 PM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight moved T260886: VE Dialog on the Test Instance: Add media selector from Sprint Backlog to Demo on the WMDE-QWERTY-Sprint-2020-08-26 board.
Fri, Sep 4, 1:04 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea
awight added a comment to T260773: Test instance: Convert cherry-picked forks to proper branches.

So far, I've done this with the VisualEditor repo. We have a branch wmde-templates and QWERTY staff are allowed to push or force-push.

Fri, Sep 4, 12:59 PM · WMDE-QWERTY-Sprint-2020-09-23, WMDE-QWERTY-Sprint-2020-09-09, WMDE-Templates-FocusArea
awight created T262037: Test instance: need local commonswiki.
Fri, Sep 4, 11:47 AM · WMDE-Templates-FocusArea
awight updated the task description for T260886: VE Dialog on the Test Instance: Add media selector.
Fri, Sep 4, 10:57 AM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Patch-For-Review, WMDE-QWERTY-Sprint-2020-08-26, WMDE-Technical-Wishes-Team, WMDE-Templates-FocusArea