awight (Adam Roses Wight)
User

Projects (15)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 12 2014, 9:02 PM (205 w, 5 d)
Availability
Available
IRC Nick
awight
LDAP User
Awight
MediaWiki User
Awight (WMF) [ Global Accounts ]

Recent Activity

Today

awight committed rEJAD42346b259b3c: [WIP] Secondary indexes for JADE pages (authored by awight).
[WIP] Secondary indexes for JADE pages
Sat, Sep 22, 7:54 AM
awight committed rEJAD10f4d5888ace: Minor cleanup (authored by awight).
Minor cleanup
Sat, Sep 22, 7:54 AM
awight committed rEJAD59e795d3f82a: Don't let subclasses couple to judgment storage (authored by awight).
Don't let subclasses couple to judgment storage
Sat, Sep 22, 7:54 AM
awight committed rEJADb4975c8fde54: Wrap target entities in a JudgmentTarget (authored by awight).
Wrap target entities in a JudgmentTarget
Sat, Sep 22, 7:54 AM
awight committed rEJAD65a7be682cf1: New classes for the judgment link table and to encapsulate judgment targets (authored by awight).
New classes for the judgment link table and to encapsulate judgment targets
Sat, Sep 22, 7:54 AM

Yesterday

awight committed rEJAD0fba426c5f30: [WIP] Secondary indexes for JADE pages (authored by awight).
[WIP] Secondary indexes for JADE pages
Fri, Sep 21, 11:59 PM
awight committed rEJADd6c4918b7431: [WIP] Secondary indexes for JADE pages (authored by awight).
[WIP] Secondary indexes for JADE pages
Fri, Sep 21, 11:35 PM
awight committed rEJADcbb56da624e1: Return Status objects rather than throw exceptions (authored by awight).
Return Status objects rather than throw exceptions
Fri, Sep 21, 11:35 PM
awight committed rEJAD1244aacf97fc: [WIP] Secondary indexes for JADE pages (authored by awight).
[WIP] Secondary indexes for JADE pages
Fri, Sep 21, 10:45 PM
awight committed rEWLE7c10bf31e891: [WIP] Use extension registry for namespaces (authored by awight).
[WIP] Use extension registry for namespaces
Fri, Sep 21, 8:17 PM
awight committed rEWLE0740dd3f848d: [WIP] Use extension registry for namespaces (authored by awight).
[WIP] Use extension registry for namespaces
Fri, Sep 21, 8:14 PM
awight committed rEWLE7d2afe0b1113: [WIP] Use extension registry for namespaces (authored by awight).
[WIP] Use extension registry for namespaces
Fri, Sep 21, 7:52 PM
awight updated subscribers of T197267: Create constant for Lexeme namespace.

It got complicated, I found some custom namespace registration I wanted to ask @Ladsgroup about, if you know anything?

Fri, Sep 21, 7:51 PM · Patch-For-Review, Wikidata, Lexicographical data
awight committed rEWLEd5a9125f0371: [WIP] Use extension registry for namespaces (authored by awight).
[WIP] Use extension registry for namespaces
Fri, Sep 21, 7:49 PM
awight added a comment to T197267: Create constant for Lexeme namespace.

This is about a PHP constant, not a data item for the lexeme namespace, right? I'm new to Wikidata, so hearing "property" is enough to raise my hackles, that this is possibly a task about something persisted in Wikibase?

Fri, Sep 21, 6:56 PM · Patch-For-Review, Wikidata, Lexicographical data
awight updated the task description for T205052: Lexeme capitalization is inconsistent with other Wikibase data types.
Fri, Sep 21, 6:22 PM · Wikidata, Lexicographical data
awight updated the task description for T205052: Lexeme capitalization is inconsistent with other Wikibase data types.
Fri, Sep 21, 6:22 PM · Wikidata, Lexicographical data
awight created T205052: Lexeme capitalization is inconsistent with other Wikibase data types.
Fri, Sep 21, 12:51 AM · Wikidata, Lexicographical data
awight committed rEJADf44b7ac5b172: Make articlequality scale configurable per wiki (authored by awight).
Make articlequality scale configurable per wiki
Fri, Sep 21, 12:29 AM
awight committed rEJADd48b39c2b4f2: Include annoying copyright preamble (authored by awight).
Include annoying copyright preamble
Fri, Sep 21, 12:29 AM
awight committed rEJAD24a98dad49c9: Surface validation errors in the edit page (authored by awight).
Surface validation errors in the edit page
Fri, Sep 21, 12:29 AM
awight committed rEJAD166f7da5463d: Use null coalescing operator (authored by awight).
Use null coalescing operator
Fri, Sep 21, 12:29 AM
awight committed rEJADb74a0085ddb9: Validate preferred flags (authored by awight).
Validate preferred flags
Fri, Sep 21, 12:29 AM
awight committed rEJAD7fdb06bee269: Update judgment content schema (authored by awight).
Update judgment content schema
Fri, Sep 21, 12:29 AM
awight committed rEJADff3835a3aebc: Make articlequality scale configurable per wiki (authored by awight).
Make articlequality scale configurable per wiki
Fri, Sep 21, 12:18 AM
awight updated subscribers of T203030: Use local articlequality assessment scale for JADE..

@Halfak @Ladsgroup What do you think about squashing itemquality and articlequality scales into just articlequality? Now that the scale is configurable, are the pseudo-models conceptually similar enough that we can just present the single schema to editors?

Fri, Sep 21, 12:18 AM · Patch-For-Review, Scoring-platform-team (Current), JADE
awight committed rEJAD6ff43b05ecb9: Make articlequality scale configurable per wiki (authored by awight).
Make articlequality scale configurable per wiki
Fri, Sep 21, 12:15 AM
awight added a comment to T203030: Use local articlequality assessment scale for JADE..

Please ignore https://gerrit.wikimedia.org/r/456044, that has other features squashed in and will be abandoned.

Fri, Sep 21, 12:13 AM · Patch-For-Review, Scoring-platform-team (Current), JADE
awight committed rORES0ee85a3980d1: Implement option of whitelisting IPs (#265) (authored by Ladsgroup).
Implement option of whitelisting IPs (#265)
Fri, Sep 21, 12:03 AM
awight moved T203030: Use local articlequality assessment scale for JADE. from Active to Review on the Scoring-platform-team (Current) board.
Fri, Sep 21, 12:01 AM · Patch-For-Review, Scoring-platform-team (Current), JADE
awight moved T204955: Implement IP whitelisting for ORES PoolCounter from Review to Pending deployment on the Scoring-platform-team (Current) board.
Fri, Sep 21, 12:00 AM · User-Ladsgroup, ORES, Scoring-platform-team (Current)
awight committed rEJAD75dc93727a67: Include annoying copyright preamble (authored by awight).
Include annoying copyright preamble
Fri, Sep 21, 12:00 AM

Thu, Sep 20

awight renamed T204955: Implement IP whitelisting for ORES PoolCounter from Implement whitelisting for IPs for ORES to Implement IP whitelisting for ORES PoolCounter.
Thu, Sep 20, 11:58 PM · User-Ladsgroup, ORES, Scoring-platform-team (Current)
awight added a comment to T202596: Write our anticipated "phase two" schemas and submit for review.

Thanks for all the attention given to this, and apologies for thinking that the namespace condition would behave the same in the WHERE as in the ON. The heart of what I want to ask is about this condition, though:

page.page_title = concat('Diff/', revision.rev_id)
Thu, Sep 20, 11:53 PM · Patch-For-Review, DBA, Scoring-platform-team (Current), User-Joe, Operations, JADE
awight committed rEJADd8a47b6fd4de: Validate preferred flags (authored by awight).
Validate preferred flags
Thu, Sep 20, 11:43 PM
awight committed rEJAD7e8fff922dd0: Surface validation errors in the edit page (authored by awight).
Surface validation errors in the edit page
Thu, Sep 20, 11:43 PM
awight committed rEJADb01ca6739b6f: Make sure we assert things in tests (authored by awight).
Make sure we assert things in tests
Thu, Sep 20, 11:43 PM
awight committed rEJAD5d076f14cec1: Update judgment content schema (authored by awight).
Update judgment content schema
Thu, Sep 20, 11:43 PM
awight committed rEJADca6780a6e035: Use null coalescing operator (authored by awight).
Use null coalescing operator
Thu, Sep 20, 11:43 PM
awight committed rEJADafe555c6b5d9: Surface validation errors in the edit page (authored by awight).
Surface validation errors in the edit page
Thu, Sep 20, 11:40 PM
awight committed rEJAD7fd9c2b3655c: Validate preferred flags (authored by awight).
Validate preferred flags
Thu, Sep 20, 11:40 PM
awight committed rEJAD8af90d3e1985: Update judgment content schema (authored by awight).
Update judgment content schema
Thu, Sep 20, 11:40 PM
awight committed rEJAD29da4f80060b: MCR API compatibility (authored by awight).
MCR API compatibility
Thu, Sep 20, 11:40 PM
awight committed rEJAD9088669f4ba2: Use null coalescing operator (authored by awight).
Use null coalescing operator
Thu, Sep 20, 11:40 PM
awight committed rEJADbcce59437a7a: Drop page judgments for this release (authored by awight).
Drop page judgments for this release
Thu, Sep 20, 11:40 PM
awight committed rEJADd6f3ad52ad54: Drop "append-only" support (authored by awight).
Drop "append-only" support
Thu, Sep 20, 11:40 PM
awight committed rEJAD0d2367a4270b: Surface validation errors in the edit page (authored by awight).
Surface validation errors in the edit page
Thu, Sep 20, 11:25 PM
awight committed rEJAD6c8cd2dca3e5: Surface validation errors in the edit page (authored by awight).
Surface validation errors in the edit page
Thu, Sep 20, 11:22 PM
awight moved T197653: Surface JADE validation errors from Active to Review on the Scoring-platform-team (Current) board.
Thu, Sep 20, 11:21 PM · Scoring-platform-team (Current), Patch-For-Review, JADE
awight edited projects for T197653: Surface JADE validation errors, added: Scoring-platform-team (Current); removed Scoring-platform-team.
Thu, Sep 20, 11:21 PM · Scoring-platform-team (Current), Patch-For-Review, JADE
awight committed rEJAD4a3e6024c0cf: Validate preferred flags (authored by awight).
Validate preferred flags
Thu, Sep 20, 9:58 PM
awight committed rEJAD242bb1c7cf45: Use null coalescing operator (authored by awight).
Use null coalescing operator
Thu, Sep 20, 9:58 PM
awight committed rEJAD52178495883a: Use null coalescing operator (authored by awight).
Use null coalescing operator
Thu, Sep 20, 8:04 PM
awight committed rEJAD4889704b2125: Validate preferred flags (authored by awight).
Validate preferred flags
Thu, Sep 20, 8:04 PM
awight committed rORESeab843724995: Return 504 instead of 408 when worker times out (#264) (authored by Ladsgroup).
Return 504 instead of 408 when worker times out (#264)
Thu, Sep 20, 7:29 PM
awight created T204984: Read timeout from enwiki when requesting non-existent revision.
Thu, Sep 20, 5:50 PM · ORES, Scoring-platform-team
awight committed rORES8d6a4d3d1a8b: Return 429 instead of 408 in case of too many requests (#263) (authored by Ladsgroup).
Return 429 instead of 408 in case of too many requests (#263)
Thu, Sep 20, 4:42 PM
Addshore awarded T204912: Can't download PDF of Lexeme data a Insectivore token.
Thu, Sep 20, 7:30 AM · Lexicographical data, Wikidata
awight created T204912: Can't download PDF of Lexeme data.
Thu, Sep 20, 5:53 AM · Lexicographical data, Wikidata
awight committed rEJADe776c387cc5a: [WIP] Validate global user ID in endorsements (authored by awight).
[WIP] Validate global user ID in endorsements
Thu, Sep 20, 12:32 AM

Wed, Sep 19

awight created T204905: Write glossary of JADE concepts.
Wed, Sep 19, 11:51 PM · Documentation, Scoring-platform-team, JADE
awight committed rEJADd2796f96b332: Update judgment content schema (authored by awight).
Update judgment content schema
Wed, Sep 19, 11:41 PM
awight committed rEJAD6e621bcfe808: Update judgment content schema (authored by awight).
Update judgment content schema
Wed, Sep 19, 11:34 PM
awight added a comment to T204899: Exception when viewing MediaInfo history.

@Jdforrester-WMF Is there another task to implement the history view for MediaInfo? I'd like to subscribe to that, if and when it exists.

Wed, Sep 19, 10:52 PM · Structured-Data-Commons, Wikidata
awight added a comment to T204899: Exception when viewing MediaInfo history.

It's not blocking my work or anything, I just thought I would run the system through its paces, and maybe get a better understanding of MCR. Feel free to decline!

Wed, Sep 19, 10:48 PM · Structured-Data-Commons, Wikidata
awight created T204899: Exception when viewing MediaInfo history.
Wed, Sep 19, 10:43 PM · Structured-Data-Commons, Wikidata
awight committed rEJADb6a719d793de: [WIP] Update schema to current consensus (authored by awight).
[WIP] Update schema to current consensus
Wed, Sep 19, 10:38 PM
awight committed rEJAD5ead799578cc: [WIP] Secondary indexes for JADE pages (authored by awight).
[WIP] Secondary indexes for JADE pages
Wed, Sep 19, 8:24 PM
awight committed rEJADcd9f9d9b3e30: [WIP] update schema to include endorsements; drop page judgments for now (authored by awight).
[WIP] update schema to include endorsements; drop page judgments for now
Wed, Sep 19, 8:24 PM
awight committed rEJAD62fdedcb8b27: Change schema to a list of heterogenous judgments (authored by awight).
Change schema to a list of heterogenous judgments
Wed, Sep 19, 8:24 PM
awight committed rORESbc21c77ea033: Move releasing the lock to after doing the actual job (#262) (authored by Ladsgroup).
Move releasing the lock to after doing the actual job (#262)
Wed, Sep 19, 6:35 PM
awight added a comment to T202596: Write our anticipated "phase two" schemas and submit for review.

@jcrespo When you have a minute, I'd like to hear your opinion on calculated field joins, e.g.

1select revision.rev_id, judgment_page.page_title from revision
2left join page judgment_page
3 on judgment_page.page_title = concat('Diff/', revision.rev_id)
4where
5 -- Match the Judgment namespace.
6 judgment_page.page_namespace = 810
7-- Dummy range, in practice the rows would be constrained as part of e.g. a
8-- RecentChanges query.
9order by revision.rev_id desc
10limit 100;

Wed, Sep 19, 5:26 PM · Patch-For-Review, DBA, Scoring-platform-team (Current), User-Joe, Operations, JADE
awight created P7570 (An Untitled Masterwork).
Wed, Sep 19, 5:17 PM
awight added a comment to T204753: Failed executing job: ORESFetchScoreJob.

I made an adjustment to the graph, and it's now clear that there was no change in the overall error rate around switchover, it just shifted from one data center to the other as anticipated.

Wed, Sep 19, 3:45 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Services (watching), WMF-JobQueue, Scoring-platform-team (Current), ORES, Wikimedia-production-error
awight added a comment to T204753: Failed executing job: ORESFetchScoreJob.

This glitch predates PoolCounter by a few days, luckily.

Wed, Sep 19, 2:36 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Services (watching), WMF-JobQueue, Scoring-platform-team (Current), ORES, Wikimedia-production-error

Tue, Sep 18

awight committed rEJAD56c4ef57bd63: [WIP] Secondary indexes for JADE pages (authored by awight).
[WIP] Secondary indexes for JADE pages
Tue, Sep 18, 11:55 PM
awight committed rEJADc649514d3f42: update schema to include endorsements; drop page judgments for now (authored by awight).
update schema to include endorsements; drop page judgments for now
Tue, Sep 18, 11:55 PM
awight committed rEJAD9290513153e8: Change schema to a list of heterogenous judgments (authored by awight).
Change schema to a list of heterogenous judgments
Tue, Sep 18, 11:55 PM
awight committed rEJAD046e757c309f: Rename namespace to NS_JUDGMENT (authored by awight).
Rename namespace to NS_JUDGMENT
Tue, Sep 18, 11:55 PM
awight added a comment to T204753: Failed executing job: ORESFetchScoreJob.

According to the ORES code, this should only happen if the wiki context name is unexpected or if the model names are missing or unexpected.

CP have switched to POSTing all the new revision events to ORES and relying on ORES to find appropriate models to precache, so I'm not surprised there's some POSTs with unexpected wikis. It shouldn't be an error on the ORES side, this was done deliberately to make ORES completely own it's precaching config

Tue, Sep 18, 10:17 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Services (watching), WMF-JobQueue, Scoring-platform-team (Current), ORES, Wikimedia-production-error
awight added a comment to T204753: Failed executing job: ORESFetchScoreJob.

Here's something odd grabbed from the ORES service at the same second as one of the job failure messages:

ores1001:
[pid: 5573] <redacted IP> (-) {30 vars in 418 bytes} [Tue Sep 18 20:08:59 2018] POST /v3/precache => generated 0 bytes in 0 msecs (HTTP/1.1 204) 7 headers in 252 bytes (0 switches on core 0) user agent "ChangePropagation/WMF"

There are 5-10 of these empty responses per second. According to the ORES code, this should only happen if the wiki context name is unexpected or if the model names are missing or unexpected.

Tue, Sep 18, 8:21 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Services (watching), WMF-JobQueue, Scoring-platform-team (Current), ORES, Wikimedia-production-error
awight added a comment to T204753: Failed executing job: ORESFetchScoreJob.

This is probably related to the datacenter switchover. Score processing load on our CODFW cluster doubled on Sept 11, and we've had unusual levels of errors during high traffic. Prior to the switchover, our error rate was consistently zero, and afterwards it has been exhibited spikes up to c. 30 errors per minute (out of c. 2,500 scores processed per minute).

Tue, Sep 18, 7:45 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Services (watching), WMF-JobQueue, Scoring-platform-team (Current), ORES, Wikimedia-production-error
awight added a comment to T204753: Failed executing job: ORESFetchScoreJob.

Some of the errors point to a service failure,

Exception executing job: ORESFetchScoreJob Discipline_(academia) models=["damaging","goodfaith","wp10"] originalRequest={"ip":"10.68.23.172","userAgent":"ClueBot/2.0"} precache=1 requestId=W6FP8ArAEHQAACKHyRAAAAAG revid=860164910 : RuntimeException: Failed to make ORES request to [http://ores.discovery.wmnet:8081/v3/scores/enwiki/?models=damaging%7Cgoodfaith%7Cwp10&revids=860164910&precache=1&format=json], There was a problem during the HTTP request: 500 INTERNAL SERVER ERROR
Tue, Sep 18, 7:31 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Services (watching), WMF-JobQueue, Scoring-platform-team (Current), ORES, Wikimedia-production-error
awight edited projects for T204753: Failed executing job: ORESFetchScoreJob, added: Scoring-platform-team (Current); removed Scoring-platform-team.
Tue, Sep 18, 7:24 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Services (watching), WMF-JobQueue, Scoring-platform-team (Current), ORES, Wikimedia-production-error
awight added a comment to T202596: Write our anticipated "phase two" schemas and submit for review.

See also T204250: Document JADE schema proposals and justifications.

Tue, Sep 18, 5:35 PM · Patch-For-Review, DBA, Scoring-platform-team (Current), User-Joe, Operations, JADE

Mon, Sep 17

awight committed rEJADb929a71638db: [WIP] Hook to update judgment link table (authored by awight).
[WIP] Hook to update judgment link table
Mon, Sep 17, 10:24 PM
awight committed rEJADf46f876e997f: [WIP] Secondary indexes for JADE pages (authored by awight).
[WIP] Secondary indexes for JADE pages
Mon, Sep 17, 10:24 PM
awight committed rEJAD3e1a62ee7441: Change schema to a list of heterogenous judgments about a single entity (authored by awight).
Change schema to a list of heterogenous judgments about a single entity
Mon, Sep 17, 10:24 PM
awight committed rEJADf8d57c3fda2c: Rename namespace to NS_JUDGMENT (authored by awight).
Rename namespace to NS_JUDGMENT
Mon, Sep 17, 10:24 PM
awight committed rOEQ61ca663a6321: Remove code generation diff tools (authored by awight).
Remove code generation diff tools
Mon, Sep 17, 7:18 PM
awight closed T196475: Experiment with LIME integration for ORES, providing explanations for its predictions as Resolved.

This got a little bit of attention, with some discussion in meetings. People were generally intrigued and I created a new task for working on a special-purpose tool in the future.

Mon, Sep 17, 5:16 PM · Scoring-platform-team (Current), ORES
awight triaged T204560: User-facing tool to explain scoring algorithms as Low priority.
Mon, Sep 17, 4:48 PM · Scoring-platform-team, ORES
awight created T204560: User-facing tool to explain scoring algorithms.
Mon, Sep 17, 4:48 PM · Scoring-platform-team, ORES
awight moved T201691: Implement JS ORES client in mw-ORES extension from Review to Pending deployment on the Scoring-platform-team (Current) board.
Mon, Sep 17, 4:39 PM · Patch-For-Review, User-Ladsgroup, Scoring-platform-team (Current), MediaWiki-extensions-ORES, Gadgets
awight edited projects for T193789: [Discuss] Random sampling by PAWS vs API requests, added: Scoring-platform-team; removed Scoring-platform-team (Current).
Mon, Sep 17, 4:35 PM · Scoring-platform-team
awight updated subscribers of T196475: Experiment with LIME integration for ORES, providing explanations for its predictions.

@Ladsgroup has a great suggestion, that we build this as a separate app.

Mon, Sep 17, 4:33 PM · Scoring-platform-team (Current), ORES
awight claimed T203030: Use local articlequality assessment scale for JADE..
Mon, Sep 17, 4:33 PM · Patch-For-Review, Scoring-platform-team (Current), JADE
awight moved T203030: Use local articlequality assessment scale for JADE. from Review to Active on the Scoring-platform-team (Current) board.
Mon, Sep 17, 4:33 PM · Patch-For-Review, Scoring-platform-team (Current), JADE
awight added a comment to T203133: Introduce a new "strict-boolean" MediaWiki API parameter type for better validation and semantics?.

This sounds like a good migration plan, and I personally like the idea of keeping a single boolean type. I defer to others' opinion on how much disruption it would cause.

Mon, Sep 17, 3:57 PM · Patch-For-Review, MediaWiki-API

Fri, Sep 14

awight committed rEJADfa85d2eec372: [WIP] Hook to update judgment link table (authored by awight).
[WIP] Hook to update judgment link table
Fri, Sep 14, 11:40 PM