Page MenuHomePhabricator

barbarar (barbaramartina)
Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jan 19 2016, 1:25 PM (430 w, 3 d)
Availability
Available
IRC Nick
barbaramartina
LDAP User
Unknown
MediaWiki User
Barbararodeker [ Global Accounts ]

Recent Activity

Apr 10 2016

barbarar added a comment to T122561: [5.0.0 (601)] Special pages display confusing warnings.

I've been debugging this issue for a while. These are my findings for the next person that put some time on it:

Apr 10 2016, 2:27 PM · iOS-app-feature-Namespaces, iOS-app-feature-Links, iOS-app-v5.0.2-Rubiks, Wikipedia-iOS-App-Backlog
barbarar placed T117912: Rotating the device while in "Read More" scrolls to top of article up for grabs.
Apr 10 2016, 10:45 AM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog
barbarar added a comment to T117912: Rotating the device while in "Read More" scrolls to top of article.

I attach one more debugging video...isWebContentVisible is not working properly. The frame of the webView is reduce in height rotating to landscape and coming back to portrait.

Apr 10 2016, 10:44 AM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog
barbarar placed T127838: SPIKE: Investigate scroll performance on Saved page list with large number of articles (e.g. 30). up for grabs.
Apr 10 2016, 10:38 AM · Spike, Wikipedia-iOS-App-Backlog

Mar 18 2016

barbarar added a member for iOS-app-v5.1.0-Saturn: barbarar.
Mar 18 2016, 1:06 PM
barbarar added a member for iOS-app-v5.0.2-Rubiks: barbarar.
Mar 18 2016, 1:06 PM
barbarar added a member for iOS-app-v5.0.1-Kiwi: barbarar.
Mar 18 2016, 1:06 PM

Mar 8 2016

barbarar updated subscribers of T117912: Rotating the device while in "Read More" scrolls to top of article.

It seems that isWebContentVisible on WebViewController is not exactly what we need OR it's not working as intended.

Mar 8 2016, 3:23 PM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog
barbarar added a comment to T127838: SPIKE: Investigate scroll performance on Saved page list with large number of articles (e.g. 30)..

Hi team, I'm not very sure where to move this task now. I've completed the performance profiling, @JMinor @BGerstle-WMF

Mar 8 2016, 9:09 AM · Spike, Wikipedia-iOS-App-Backlog

Mar 2 2016

barbarar added a comment to T127838: SPIKE: Investigate scroll performance on Saved page list with large number of articles (e.g. 30)..

Hi guys, I attach the trace for this profiling.
This is run on iPhone5S, iOS 9.0.2.

Mar 2 2016, 12:47 PM · Spike, Wikipedia-iOS-App-Backlog
barbarar added a comment to T124336: [SPIKE] Measure CPU usage when switching tabs under high load (Explore, Saved, History).

Here are the articles that were saved to read later by the end of the tests:

Mar 2 2016, 8:34 AM · iOS-app-feature-Performance, Spike, Wikipedia-iOS-App-Backlog
barbarar added a comment to T124336: [SPIKE] Measure CPU usage when switching tabs under high load (Explore, Saved, History).

Guys, I continued today putting the app under stress and I can not find any further performance issue in the EXPLORER section.
I increased the number of article saved to 50.

Mar 2 2016, 8:29 AM · iOS-app-feature-Performance, Spike, Wikipedia-iOS-App-Backlog
barbarar claimed T127838: SPIKE: Investigate scroll performance on Saved page list with large number of articles (e.g. 30)..
Mar 2 2016, 7:33 AM · Spike, Wikipedia-iOS-App-Backlog

Feb 23 2016

barbarar added a comment to T124336: [SPIKE] Measure CPU usage when switching tabs under high load (Explore, Saved, History).

I did not remember some particular performance issue on History tab. I'll be doing a second profiling/CPU analyses and will keep an eye on History tab too.

Feb 23 2016, 5:12 PM · iOS-app-feature-Performance, Spike, Wikipedia-iOS-App-Backlog
barbarar committed rAPIOSfd1fa0201669: Change canShare to take into account the presence of a shareSnippet not only….
Change canShare to take into account the presence of a shareSnippet not only…
Feb 23 2016, 3:56 PM
barbarar committed rAPIOSbecfbe50bc79: Merge branch 'master' into bug/T123626/double-share-dialog.
Merge branch 'master' into bug/T123626/double-share-dialog
Feb 23 2016, 3:56 PM
barbarar committed rAPIOS43a06b189cf2: Merge branch 'bug/T123626/double-share-dialog' of https://github..
Merge branch 'bug/T123626/double-share-dialog' of https://github.
Feb 23 2016, 3:56 PM
barbarar committed rAPIOSded953550e54: Merge branch 'master' into bug/T123626/double-share-dialog.
Merge branch 'master' into bug/T123626/double-share-dialog
Feb 23 2016, 3:56 PM
barbarar committed rAPIOSa59afa04bd16: T123626: is share controller is already active do not show it again.
T123626: is share controller is already active do not show it again
Feb 23 2016, 3:56 PM
barbarar added a comment to T124336: [SPIKE] Measure CPU usage when switching tabs under high load (Explore, Saved, History).

I forgot to mention:

Feb 23 2016, 9:42 AM · iOS-app-feature-Performance, Spike, Wikipedia-iOS-App-Backlog

Feb 22 2016

barbarar updated subscribers of T124336: [SPIKE] Measure CPU usage when switching tabs under high load (Explore, Saved, History).

@BGerstle-WMF / @Fjalapeno and any body else who can make an opinion on that.
So far, I have found the following:

  1. There is a spike of CPU consumption after clicking on "save for later" in a suggested article, at the bottom of another article (not clicking from the toolbar).

But it's not compromising the main thread.

CPU consumption after saving for later.png (958×1 px, 351 KB)

  1. There is an increment in the CPU usage on the main thread after selecting an article to open it. It probably worthy to check if there is something to optimize here. I can do it later.
    CPU consumption after clicking an article.png (957×1 px, 285 KB)
  2. The app is eating too bad food :), sometimes while scrolling at the Explore section I got the app frozen and killed after a while. I could not catch it while profiling yet. But I have 2 crash logs related to this.


Feb 22 2016, 3:08 PM · iOS-app-feature-Performance, Spike, Wikipedia-iOS-App-Backlog
barbarar added a comment to T124336: [SPIKE] Measure CPU usage when switching tabs under high load (Explore, Saved, History).

I have profiled the application, with time instrument, using these articles:

Feb 22 2016, 1:56 PM · iOS-app-feature-Performance, Spike, Wikipedia-iOS-App-Backlog

Feb 16 2016

barbarar updated subscribers of T123626: Pressing the share-button before content loads and again after opens 2 dialoges.

@bgerstle / @Fjalapeno or any other person in the team, I will be reviewing the PR comments today.

Feb 16 2016, 12:48 PM · Wikipedia-iOS-App-Backlog, iOS-app-Bugs, User-Josve05a, Wikipedia-iOS-App-Development, iOS-app-v5-production, Mobile

Feb 11 2016

barbarar moved T124336: [SPIKE] Measure CPU usage when switching tabs under high load (Explore, Saved, History) from Ready for Development to Doing on the Wikipedia-iOS-App-Development board.
Feb 11 2016, 8:15 AM · iOS-app-feature-Performance, Spike, Wikipedia-iOS-App-Backlog
barbarar claimed T124336: [SPIKE] Measure CPU usage when switching tabs under high load (Explore, Saved, History).
Feb 11 2016, 8:15 AM · iOS-app-feature-Performance, Spike, Wikipedia-iOS-App-Backlog
barbarar moved T123626: Pressing the share-button before content loads and again after opens 2 dialoges from Doing to Needs Code Review on the Wikipedia-iOS-App-Development board.
Feb 11 2016, 8:10 AM · Wikipedia-iOS-App-Backlog, iOS-app-Bugs, User-Josve05a, Wikipedia-iOS-App-Development, iOS-app-v5-production, Mobile
barbarar added a comment to T123626: Pressing the share-button before content loads and again after opens 2 dialoges.

I've created a PR for this ticket: https://github.com/wikimedia/wikipedia-ios/pull/470

Feb 11 2016, 8:07 AM · Wikipedia-iOS-App-Backlog, iOS-app-Bugs, User-Josve05a, Wikipedia-iOS-App-Development, iOS-app-v5-production, Mobile

Feb 10 2016

barbarar added a comment to T117912: Rotating the device while in "Read More" scrolls to top of article.

Great Brian. Thanks for the feedback. I'll use it to solve the issue.

Feb 10 2016, 7:18 PM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog
barbarar claimed T123626: Pressing the share-button before content loads and again after opens 2 dialoges.
Feb 10 2016, 3:25 PM · Wikipedia-iOS-App-Backlog, iOS-app-Bugs, User-Josve05a, Wikipedia-iOS-App-Development, iOS-app-v5-production, Mobile
barbarar added a member for Wikipedia-iOS-App-Backlog: barbarar.
Feb 10 2016, 2:41 PM
barbarar added a member for Wikipedia-iOS-App-Development: barbarar.
Feb 10 2016, 2:41 PM

Feb 4 2016

barbarar added a comment to T117912: Rotating the device while in "Read More" scrolls to top of article.

@BGerstle-WMF Hi guys, I worked today a couple of hours in this issue. Please whenever you have time watch the video I attach. I explain what I found there, need some advice about the best solution for this case, thanks. I'll come back next week.

Feb 4 2016, 5:19 PM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Jan 28 2016

barbarar committed rAPIOS29b35dd039b7: Adding macro to cleanup retained variables on scope exit.
Adding macro to cleanup retained variables on scope exit
Jan 28 2016, 8:08 PM
barbarar committed rAPIOS0b20d7a78704: Do not fallback to strings. Return on nil tappedView and check for child….
Do not fallback to strings. Return on nil tappedView and check for child…
Jan 28 2016, 8:08 PM
barbarar committed rAPIOSd419d55ef793: Removing retain and release from association methods but also casting using….
Removing retain and release from association methods but also casting using…
Jan 28 2016, 8:08 PM
barbarar committed rAPIOS1ac3d4e586b5: Fixing conflict because of commented / uncommented lines.
Fixing conflict because of commented / uncommented lines
Jan 28 2016, 8:08 PM
barbarar committed rAPIOScc1b635d8d3c: Merge branch 'master' of https://github.com/wikimedia/wikipedia-ios into….
Merge branch 'master' of https://github.com/wikimedia/wikipedia-ios into…
Jan 28 2016, 8:08 PM
barbarar committed rAPIOS739351a03711: Fixing memory leak by retaining view key but not releasing it.
Fixing memory leak by retaining view key but not releasing it
Jan 28 2016, 8:08 PM
barbarar committed rAPIOS3875424b2e81: Preventing possible nil values crash.
Preventing possible nil values crash
Jan 28 2016, 8:08 PM
barbarar committed rAPIOSb1538e2e5ff0: Fixing memory leak on reachability instance.
Fixing memory leak on reachability instance
Jan 28 2016, 8:08 PM
barbarar committed rAPIOS8ff1d206a01f: Commenting out unused line of code: adding TODO tag to check why this code….
Commenting out unused line of code: adding TODO tag to check why this code…
Jan 28 2016, 8:08 PM
barbarar committed rAPIOS4af530bbdcd5: TODO item: remove the usage of interfaceOrientation as it's deprecated.
TODO item: remove the usage of interfaceOrientation as it's deprecated
Jan 28 2016, 8:08 PM
barbarar added a comment to T117912: Rotating the device while in "Read More" scrolls to top of article.

Ok, today I was trying to reproduce / understand the problem for this task and I find that rotating from portrait to landscape back and forth several times, makes the articles to scroll a bit closer to the top every time it's in portrait again... not the same problem, but might be related.

Jan 28 2016, 5:28 PM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog
barbarar claimed T117912: Rotating the device while in "Read More" scrolls to top of article.
Jan 28 2016, 4:31 PM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog
barbarar added a comment to T117912: Rotating the device while in "Read More" scrolls to top of article.

I think this could be a good ticket to start with, since the priority is low. I will assign to me.

Jan 28 2016, 4:30 PM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Jan 20 2016

barbarar added a comment to T124047: [BUG] Search view initial state says "Sorry, couldn't load results".

cool. I will give it a look.

Jan 20 2016, 9:13 PM · iOS-app-v5-production, Essential-Work, good first task, Wikipedia-iOS-App-Development
barbarar committed rAPIOSdb5adb2055d7: Using NS_ENUM() macro to define enumerations.
Using NS_ENUM() macro to define enumerations
Jan 20 2016, 6:09 PM
barbarar committed rAPIOSb0b4690956f1: Using CGGeometry functions instead of accessing the frames values directly.
Using CGGeometry functions instead of accessing the frames values directly
Jan 20 2016, 6:09 PM
barbarar committed rAPIOSeaf327e30e9f: Adding WMF prefix to test class includes.
Adding WMF prefix to test class includes
Jan 20 2016, 6:09 PM
barbarar committed rAPIOSf294888ac10e: Init and dealloc methods go before class methods.
Init and dealloc methods go before class methods
Jan 20 2016, 6:09 PM
barbarar committed rAPIOSc72337dbb34f: Using NS_ENUM() macro to define enumerations.
Using NS_ENUM() macro to define enumerations
Jan 20 2016, 6:09 PM
barbarar committed rAPIOS2f2dbf78f395: Using NS_ENUM() macro to define enumerations.
Using NS_ENUM() macro to define enumerations
Jan 20 2016, 6:09 PM
barbarar committed rAPIOS809f7963246d: Init and dealloc methods go before class methods.
Init and dealloc methods go before class methods
Jan 20 2016, 6:09 PM
barbarar committed rAPIOS8c33088db22f: Init and dealloc methods go before class methods.
Init and dealloc methods go before class methods
Jan 20 2016, 6:09 PM
barbarar committed rAPIOSfcb68a85680b: Adopting code style: Category instance methods should always have a prefix WMF.
Adopting code style: Category instance methods should always have a prefix WMF
Jan 20 2016, 6:09 PM
barbarar committed rAPIOSe528c2602743: Adopting code style: Never compare something directly to YES.
Adopting code style: Never compare something directly to YES
Jan 20 2016, 6:09 PM
barbarar committed rAPIOS5f94ef0f718d: Init and dealloc methods go before class methods.
Init and dealloc methods go before class methods
Jan 20 2016, 6:09 PM
barbarar committed rAPIOS95070d452512: Adopting code style: Category instance methods should always have a prefix.
Adopting code style: Category instance methods should always have a prefix
Jan 20 2016, 6:09 PM

Jan 19 2016

barbarar added a comment to T124039: Want to contribute to the project.

Great thanks ! Talk to you soon

Jan 19 2016, 8:55 PM · Wikipedia-iOS-App-Development
barbarar added a comment to T124039: Want to contribute to the project.

mm... ok, I will check these task categories on Phabricator... anyway I
will do the code cleanup, it's a good way for me to start... I will do a PR
might be and you can just ignore it until you decide it would be worth to
integrate or not... I would not like to start doing any task until I get a
taste of the code and architecture... so in the meantime I will do
things to approach the code from different angles, it's ok if the PR are
not integrated... or I don't know might be I will just do it on my forked
version... or in a local one...

Jan 19 2016, 5:00 PM · Wikipedia-iOS-App-Development
barbarar added a comment to T124039: Want to contribute to the project.

I see... so it might be better not to generate any UML docs now... I was thinking about reviewing the project looking for not used methods and unused classes... what do you think about that? I think is very important to have the base source as small in size as possible, makes knowledge acquisition easier and faster, as well as keep the code updated with the functionality is really used... I do not know if there are unused classes or methods... but if it were the case it might make sense for me to do this task also as an initial contact with the code.

Jan 19 2016, 4:11 PM · Wikipedia-iOS-App-Development
barbarar added a comment to T124039: Want to contribute to the project.

@BGerstle-WMF thanks! I supposed I should work as a collaborator.
I will fork the repo and will create a PR.

Jan 19 2016, 3:02 PM · Wikipedia-iOS-App-Development
barbarar renamed T124039: Want to contribute to the project from to Want to contribute to the project.
Jan 19 2016, 1:31 PM · Wikipedia-iOS-App-Development