In general I support pushing this out to beta cluster. I think this is mostly a question for the Services team. I'm not sure if there would be a lot of testing done on beta cluster, though.
I've started a wiki page for this: https://www.mediawiki.org/wiki/Page_Content_Service/References.
The link for this is (from https://en.wiktionary.org/api/rest_v1/page/html/asteroids):
<a rel="mw:WikiLink" href="./Appendix:Glossary#plural_number" title="Appendix:Glossary">plural</a>
Thu, Nov 16
@Fjalapeno I would prefer to keep the smaller images that usually should not end up in a gallery view out of this payload. Is there any client that would like to show them?
Wed, Nov 15
https://en.wikipedia.org/api/rest_v1/feed/onthisday/events/09/14 has two instances of 'MCI_Inc.' because WorldCom redirects to MCI_Inc.
@Mholloway I'm not yet convinced that we should add more items than a normal client would want to show. This would require all regular clients to add filtering code. I think instead the media client should already filter out the media items in a similar fashion as done by the MediaViewer.
FYI, the plural link points to https://en.wiktionary.org/wiki/Appendix:Glossary#plural_number.
Can you add a pattern for the domain instead to make sure this is under the *.wikipedia.org domain? I don't see this specified at all in the above code snippet. Hard-coding /zh* is specific for Chinese WP only. There are several other WP projects that allow for language variants.
There are two ways to get the news for huwiki:
- Hacky way:
a) Add the code to MCS specifically for huwiki. For that we need to know the page that holds the ITN template.
b) Come up with a CSS selector to find the news stories on that page (avoid any instructions if any). OR
- Long term preferred solution:
a) Come up with a convention to make it easy to find the ITN template. This could be similar to the convention used by the FeaturedFeed extension, where special pages in the MediaWiki namespace are used.
b) Come up with markup (class names, etc.) that wikis should use to help make more robust CSS selectors, which should be used by all wikis that have ITN.
Tue, Nov 14
The first one is strange. I can't repro the first that one on labs or locally. The only place in our codebase I find internal_http_error is the preq library. Not sure it's possible to repro on the beta cluster.
Fri, Nov 10
There's already a 2.2.0 out. Pushed an additional commit for that.
Thu, Nov 9
@phuedx Sounds fine.
I'm leaning towards removing the reference to mobile-sections since we will consider this a deprecated API once PCS is functional. No need to proliferate usage at this point IMO.
ACK. https://en.wikipedia.org/api/rest_v1/feed/featured/2017/11/02 in the first news story.
FYI, the latest patch here was deployed today.
@Fjalapeno Is this still blocked? If so on what?
There are no outstanding patches in MCS for the summary feature at the moment and I did an MCS deploy today. We might want to run the compare script again with the latest changes merged to master.
As far as I understand it, the timeline and how we roll this out is up to @ovasileva. If we can deploy for all wikis at the same time that would be easier for the Services team but I think @Pchelolo said that that is doable.
FWIW, a new summary endpoint implementation (not deployed yet) avoids this issue by only considering the characters in the first paragraph. Maybe this is preferable to use? Not sure what your use case is. Just want to give a heads-up about potential alternate solutions.
Wed, Nov 8
The MCS change is deployed as of a few minutes ago. That doesn't mean it's active, though. It will be active once Parsoid adds the section tags (in version 1.6).
Strike that last comment. We'll have to talk about this some more.
The revert hasn't been deployed yet but will be soon. Hopefully tomorrow.
Well, at least it removes one thing to check when it happens next time.
Yes, when page content is served by RESTBase / MCS (which is the default) it doesn't matter if the user is logged in or not. Pages served by RESTBase / MCS are provided from a perspective of a not logged in user. That way we can cache them better.
Tue, Nov 7
Is this only for the summary endpoint or also for the mobile-sections endpoints? I guess whatever we do for summary witht he geo property should also be done for mobile-sections.
I plan to deploy this during the deployment window tomorrow afternoon.
Mon, Nov 6
Fri, Nov 3
Took examples from T176959 and expanded on them. There are more good discussions about the why, what, and how there. Please comment here to adjust the proposed DOM.
Thu, Nov 2
Wed, Nov 1
There's a new branch for this: generic_mediawiki.
+1 to adding <header> tags (in PCS or wherever). I wonder whether adding <header> and content wrapper would make round tripping more reliable.
Tue, Oct 31
@Fjalapeno In addition to the above questions, did we want to change the gallery to media here as well?
Fri, Oct 27
While the updated variant property is much simpler and reduced now, I still would argue that a variant property should not be necessary. My main concern is that variant info stays the same for all pages of a particular wiki site.
Updated description to include an example of an issue with the old section code.
Wed, Oct 25
Here are the frwiki ones ready to plug into one of the top-pages scripts for testing:
Tue, Oct 24
That swagger UI for reading lists is so colorful. ;)
Duh, just noticed this ticket after I submitted mine.
Mon, Oct 23
I'd like to see an example of a page which includes videos as well. I want to see if the order of the videos is correct.
In an earlier patch set the order was incorrect. Now it seems to be corrected. Great! I still would like to see a unit test for the order of items.
Sun, Oct 22
Since this means the client checks every minute, I recommend storing the ETag header you get from previous responses and provide that value with future requests in the If-None-Match header.
Sat, Oct 21
We had a similar series of incident today, this time with the thumbnail of yesterday's featured article.
The October 20th TFA thumbnail was vandalized several times starting on October 21st at 00:02 UTC with a series of reverts and another counter attack.
00:02 First vandalism edit.
00:07 The 2nd vandalism was removed.
00:09 The page was edited to restored the correct pageimage.
00:36+ I updated the RESTBase storage for the feed for this day (from scb1001):
curl -H 'Cache-Control: no-cache' http://restbase1007.eqiad.wmnet:7231/en.wikipedia.org/v1/feed/featured/2017/10/20
00:46 James reported that it was fixed.
Fri, Oct 20
So, should we ask @ssastry if Parsoid could add the <div> wrapping to the <section> patch as well?
The example page has been deleted. But I found other examples when going through top 1000 pages in frwiki:
- fr:Mary_Pierce/138725507, section "Parcours en Coupe de la Fédération" or later
- fr:Eminem/140492693, section 37 "Tournées" or later
- fr:Kristina_Mladenovic/140586464, section 21 "Parcours aux Jeux olympiques" or later